[Qemu-devel] [PATCH RESEND v3 0/2] x86: Enable user wait instructions

2019-06-21 Thread Tao Xu
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. UMONITOR arms address monitoring hardware using an address. A store to an address within the specified address range triggers the monitoring hardware to wake up the processor waiting in umwait. UMWAIT instructs the processor to ente

[Qemu-devel] [PATCH RESEND v3 2/2] target/i386: Add support for save/load IA32_UMWAIT_CONTROL MSR

2019-06-21 Thread Tao Xu
UMWAIT and TPAUSE instructions use IA32_UMWAIT_CONTROL at MSR index E1H to determines the maximum time in TSC-quanta that the processor can reside in either C0.1 or C0.2. This patch is to Add support for save/load IA32_UMWAIT_CONTROL MSR in guest. Co-developed-by: Jingqi Liu Signed-off-by: Jingq

[Qemu-devel] [PATCH v2] aspeed: Link SCU to the watchdog

2019-06-21 Thread Joel Stanley
The ast2500 uses the watchdog to reset the SDRAM controller. This operation is usually performed by u-boot's memory training procedure, and it is enabled by setting a bit in the SCU and then causing the watchdog to expire. Therefore, we need the watchdog to be able to access the SCU's register spac

Re: [Qemu-devel] [PATCH 1/2] Acceptance tests: exclude "flaky" tests

2019-06-21 Thread Philippe Mathieu-Daudé
On 6/21/19 8:09 AM, Cleber Rosa wrote: > It's a fact that some tests may not be 100% reliable in all > environments. While it's a tough call to remove a useful test that > from the tree because it may fail every 1/100th time (or so), having > human attention drawn to known issues is very bad for h

Re: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP

2019-06-21 Thread Frediano Ziglio
> > Hello Eric, > > > A new command may be okay, however, > > thanks, I've fix the typos and updated the patch to use an Enum, which > indeed makes more sense. > > I've also updated "spice-query" command to provide the current value > of the "video-codec" property, > but it made me wonder if I

Re: [Qemu-devel] [PATCH V2 0/5] Add Xen COLO support

2019-06-21 Thread Jason Wang
On 2019/6/21 下午2:43, Zhang, Chen wrote: Anyone have any comments about this series? Thanks Zhang Chen I will probably review and give feedback sometime next week. Thanks -Original Message- From: Qemu-devel [mailto:qemu-devel- bounces+chen.zhang=intel@nongnu.org] On Behalf

[Qemu-devel] [Bug 1833661] Re: Linux kernel oops on Malta board while accessing pflash

2019-06-21 Thread Philippe Mathieu-Daudé
Relevant 32-bit output: tests/acceptance/linux_ssh_mips_malta.py:LinuxSSH.test_mips_malta32eb_kernel3_2_0 [ 34.968000] Using buffer write method [ 38.324000] Searching for RedBoot partition table in physmap-flash.0 at offset 0x3f [ 38.328000] No RedBoot partition table detected in phys

[Qemu-devel] [Bug 1833661] Re: Linux kernel oops on Malta board while accessing pflash

2019-06-21 Thread Philippe Mathieu-Daudé
Relevant 64-bit output: tests/acceptance/linux_ssh_mips_malta.py:LinuxSSH.test_mips_malta64eb_kernel3_2_0 [0.00] Initializing cgroup subsys cpuset [0.00] Initializing cgroup subsys cpu [0.00] Linux version 3.2.0-4-5kc-malta (debian-ker...@lists.debian.org) (gcc version 4.

[Qemu-devel] [Bug 1833661] [NEW] Linux kernel oops on Malta board while accessing pflash

2019-06-21 Thread Philippe Mathieu-Daudé
Public bug reported: commit 33d609990621dea6c7d056c86f707b8811320ac1 While running tests/acceptance/linux_ssh_mips_malta.py, the big-endian tests fail: physmap-flash.0: Found 1 x32 devices at 0x0 in 32-bit bank. Manufacturer ID 0x00 Chip ID 0x00 Intel/Sharp Extended Query Table at 0

Re: [Qemu-devel] [PATCH V2 0/5] Add Xen COLO support

2019-06-21 Thread Zhang, Chen
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Friday, June 21, 2019 3:25 PM > To: Zhang, Chen ; Li Zhijian ; > Dr. David Alan Gilbert ; Juan Quintela > ; zhanghailiang ; > qemu-dev ; Stefano Stabellini > ; Paul Durrant > Cc: Zhang Chen > Subject: Re: [PATC

Re: [Qemu-devel] [PATCH 2/3] migration/ram.c: start of cpu_physical_memory_sync_dirty_bitmap is always 0

2019-06-21 Thread Wei Yang
On Tue, May 14, 2019 at 03:21:08PM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> Since start of cpu_physical_memory_sync_dirty_bitmap is always 0, we can >> remove this parameter and simplify the calculation a bit. >> >> Signed-off-by: Wei Yang > >So I

Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer

2019-06-21 Thread Wei Yang
On Tue, Jun 11, 2019 at 10:33:29AM +0200, Juan Quintela wrote: >Wei Yang wrote: >> On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote: >>>MigrationState->bytes_xfer is only set to 0 in migrate_init(). >>> >>>Remove this unnecessary field. >>> >>>Signed-off-by: Wei Yang >> >> Hi, David > >Hi

Re: [Qemu-devel] [PATCH v4 03/13] vfio: Add save and load functions for VFIO PCI devices

2019-06-21 Thread Yan Zhao
On Fri, Jun 21, 2019 at 02:44:30PM +0800, Kirti Wankhede wrote: > > > On 6/21/2019 5:42 AM, Yan Zhao wrote: > > On Thu, Jun 20, 2019 at 10:37:31PM +0800, Kirti Wankhede wrote: > >> These functions save and restore PCI device specific data - config > >> space of PCI device. > >> Tested save and re

Re: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP

2019-06-21 Thread Kevin Pouget
On Fri, Jun 21, 2019 at 9:16 AM Frediano Ziglio wrote: > > > > > Hello Eric, > > > > > A new command may be okay, however, > > > > thanks, I've fix the typos and updated the patch to use an Enum, which > > indeed makes more sense. > > > > I've also updated "spice-query" command to provide the curr

[Qemu-devel] [Bug 1833668] [NEW] linux-user: Unable to run ARM binaries on Aarch64

2019-06-21 Thread Philippe Mathieu-Daudé
Public bug reported: Download a ARM package from https://packages.debian.org/sid/busybox- static Here tested with: busybox-static_1.30.1-4_armel.deb $ file busybox.armel busybox.armel: ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV), statically linked, for GNU/Linux 3.2.0, BuildID[sha1]

Re: [Qemu-devel] [RFC PATCH 0/9] hw/acpi: make build_madt arch agnostic

2019-06-21 Thread Igor Mammedov
On Fri, 21 Jun 2019 08:56:44 +0800 Wei Yang wrote: > On Thu, Jun 20, 2019 at 05:04:29PM +0200, Igor Mammedov wrote: > >On Thu, 20 Jun 2019 14:18:42 + > >Wei Yang wrote: > > > >> On Wed, Jun 19, 2019 at 11:04:40AM +0200, Igor Mammedov wrote: > >> >On Wed, 19 Jun 2019 14:20:50 +0800 > >> >

[Qemu-devel] [PATCH for-4.1 21/24] util/qemu-timer: refactor deadline calculation for external timers

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk icount-based record/replay uses qemu_clock_deadline_ns_all to measure the period until vCPU may be interrupted. This function takes in account the virtual timers, because they belong to the virtual devices that may generate interrupt request or affect the virtual machine sta

Re: [Qemu-devel] [PATCH v2] aspeed: Link SCU to the watchdog

2019-06-21 Thread Cédric Le Goater
On 21/06/2019 08:52, Joel Stanley wrote: > The ast2500 uses the watchdog to reset the SDRAM controller. This > operation is usually performed by u-boot's memory training procedure, > and it is enabled by setting a bit in the SCU and then causing the > watchdog to expire. Therefore, we need the watc

[Qemu-devel] [PATCH for-4.1 17/24] gdbstub: add reverse continue support in replay mode

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the b

Re: [Qemu-devel] [PATCH] memory: do not do out of bound notification

2019-06-21 Thread Yan Zhao
On Thu, Jun 20, 2019 at 08:59:55PM +0800, Peter Xu wrote: > On Thu, Jun 20, 2019 at 10:35:29AM +0200, Paolo Bonzini wrote: > > On 20/06/19 06:02, Peter Xu wrote: > > > Seems workable, to be explicit - we can even cut it into chunks with > > > different size to be efficient. > > > > Yes, this is no

[Qemu-devel] [PATCH for-4.1 23/24] replay: rename step-related variables and functions

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch renames replay_get_current_step() and related variables to make these names consistent with hmp/qmp commands. Signed-off-by: Pavel Dovgalyuk --- blockdev.c|2 +- include/sysemu/replay.h |2 +- migration/savevm.c|2 +- repla

[Qemu-devel] [PATCH for-4.1 18/24] replay: describe reverse debugging in docs/replay.txt

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch updates the documentation and describes usage of the reverse debugging in QEMU+GDB. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 33 + 1 file changed, 33 insertions(+) diff --git a/docs/replay.txt b/docs/replay.txt ind

[Qemu-devel] [PATCH for-4.1 12/24] replay: introduce breakpoint at the specified step

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch introduces replay_break, replay_delete_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. replay_break command has one argument - numb

[Qemu-devel] [PATCH for-4.1 22/24] replay: fix replay shutdown

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch fixes shutdown of the replay process, which is terminated with the assert when shutdown event is read from the log. replay_finish_event reads new data_kind and therefore the value of data_kind should be preserved to be valid at qemu_system_shutdown_request call.

[Qemu-devel] [PATCH for-4.1 15/24] replay: flush rr queue before loading the vmstate

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk Non-empty record/replay queue prevents saving and loading the VM state, because it includes pending bottom halves and block coroutines. But when the new VM state is loaded, we don't have to preserve the consistency of the current state anymore. Therefore this patch just flus

[Qemu-devel] [PATCH for-4.1 05/24] replay: don't drain/flush bdrv queue while RR is working

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk In record/replay mode bdrv queue is controlled by replay mechanism. It does not allow saving or loading the snapshots when bdrv queue is not empty. Stopping the VM is not blocked by nonempty queue, but flushing the queue is still impossible there, because it may cause deadlo

[Qemu-devel] [PATCH for-4.1 20/24] replay: document development rules

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch introduces docs/devel/replay.txt which describes the rules that should be followed to make virtual devices usable in record/replay mode. Signed-off-by: Pavel Dovgalyuk -- v9: fixed external virtual clock description (reported by Artem Pisarenko) --- docs/deve

[Qemu-devel] [PATCH for-4.1 24/24] icount: clean up cpu_can_io before jumping to the next block

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk Most of IO instructions can be executed only at the end of the block in icount mode. Therefore translator can set cpu_can_io flag when translating the last instruction. But when the blocks are chained, then this flag is not reset and may remain set at the beginning of the ne

[Qemu-devel] [PATCH for-4.1 19/24] replay: add BH oneshot event for block layer

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk Replay is capable of recording normal BH events, but sometimes there are single use callbacks scheduled with aio_bh_schedule_oneshot function. This patch enables recording and replaying such callbacks. Block layer uses these events for calling the completion function. Replay

[Qemu-devel] [PATCH for-4.1 16/24] gdbstub: add reverse step support in replay mode

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution. Bu

[Qemu-devel] [PATCH for-4.1 02/24] block: implement bdrv_snapshot_goto for blkreplay

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch enables making snapshots with blkreplay used in block devices. This function is required to make bdrv_snapshot_goto without calling .bdrv_open which is not implemented. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf --- block/blkreplay.c |8

Re: [Qemu-devel] [PATCH v4 00/13] Add migration support for VFIO device

2019-06-21 Thread Kirti Wankhede
On 6/21/2019 6:54 AM, Yan Zhao wrote: > On Fri, Jun 21, 2019 at 08:25:18AM +0800, Yan Zhao wrote: >> On Thu, Jun 20, 2019 at 10:37:28PM +0800, Kirti Wankhede wrote: >>> Add migration support for VFIO device >>> >>> This Patch set include patches as below: >>> - Define KABI for VFIO device for mi

[Qemu-devel] [PATCH for-4.1 14/24] replay: refine replay-time module

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch removes refactoring artifacts from the replay/replay-time.c Signed-off-by: Pavel Dovgalyuk --- replay/replay-time.c | 36 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/replay/replay-time.c b/replay/replay

[Qemu-devel] [PATCH for-4.1 01/24] replay: add missing fix for internal function

2019-06-21 Thread Pavel Dovgalyuk
From: pbonz...@redhat.com This is a fix which was missed by patch 74c0b816adfc6aa1b01b4426fdf385e32e35cbac, which added current_step parameter to the replay_advance_current_step function. Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c |2 +- 1 file changed, 1 insertion(+), 1 d

[Qemu-devel] [PATCH for-4.1 00/24] Fix record/replay and add reverse debugging

2019-06-21 Thread Pavel Dovgalyuk
GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended to stop at the last breakpoint that would happen when the program is executed normally.

Re: [Qemu-devel] [PATCH v3 00/50] tcg plugin support

2019-06-21 Thread Alex Bennée
Pranith Kumar writes: > Hi Alex/Emilio, > > I am really happy to see the progress you made on the plugin feature. Looking > forward to seeing it merged soon! Please CC me on future versions of the > patchset. I am happy to help review and contribute to this effort. Will do. > > I have a few g

Re: [Qemu-devel] [PATCH v7 1/3] block: include base when checking image chain for block allocation

2019-06-21 Thread Vladimir Sementsov-Ogievskiy
19.06.2019 22:27, Max Reitz wrote: > On 29.05.19 19:56, Andrey Shinkevich wrote: >> This patch is used in the 'block/stream: introduce a bottom node' >> that is following. Instead of the base node, the caller may pass >> the node that has the base as its backing image to the function >> bdrv_is_all

[Qemu-devel] [PATCH for-4.1 09/24] replay: provide an accessor for rr filename

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds an accessor function for the name of the record/replay log file. Adding an accessor instead of making variable global, prevents accidental modification of this variable by other modules. Signed-off-by: Pavel Dovgalyuk --- include/sysemu/replay.h |2 ++

Re: [Qemu-devel] [PATCH] blockjob: drain all job nodes in block_job_drain

2019-06-21 Thread Vladimir Sementsov-Ogievskiy
19.06.2019 19:37, Max Reitz wrote: > On 19.06.19 16:44, Vladimir Sementsov-Ogievskiy wrote: >> Instead of draining additional nodes in each job code, let's do it in >> common block_job_drain, draining just all job's children. >> >> It's also a first step to finally get rid of blockjob->blk. >> >> S

[Qemu-devel] [PATCH for-4.1 10/24] qapi: introduce replay.json for record/replay-related stuff

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds replay.json file. It will be used for adding record/replay-related data structures and commands. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Markus Armbruster -- v10: - minor changes v13: - rebased to the new QAPI files --- MAINTAINERS |

[Qemu-devel] [PATCH for-4.1 06/24] replay: finish record/replay before closing the disks

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c |

[Qemu-devel] [PATCH for-4.1 13/24] replay: implement replay-seek command

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds hmp/qmp commands replay_seek/replay-seek that proceed the execution to the specified instruction count. The command automatically loads nearest snapshot and replays the execution to find the desired instruction count. Signed-off-by: Pavel Dovgalyuk Acked-by

[Qemu-devel] [PATCH for-4.1 04/24] replay: update docs for record/replay with block devices

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch updates the description of the command lines for using record/replay with attached block devices. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/replay.txt b/docs/replay

[Qemu-devel] [PATCH for-4.1 11/24] replay: introduce info hmp/qmp command

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch introduces 'info replay' monitor command and corresponding qmp request. These commands request the current record/replay mode, replay log file name, and the instruction count (number of recorded/replayed instructions). The instruction count can be used with the r

Re: [Qemu-devel] [PATCH v2] aspeed: Link SCU to the watchdog

2019-06-21 Thread Philippe Mathieu-Daudé
On 6/21/19 10:25 AM, Cédric Le Goater wrote: > On 21/06/2019 08:52, Joel Stanley wrote: >> The ast2500 uses the watchdog to reset the SDRAM controller. This >> operation is usually performed by u-boot's memory training procedure, >> and it is enabled by setting a bit in the SCU and then causing the

[Qemu-devel] [PATCH for-4.1 08/24] migration: introduce icount field for snapshots

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for proceeding the recorded execution to the specific moment of the time. E.g., 'reverse step' action (

[Qemu-devel] [PATCH for-4.1 07/24] qcow2: introduce icount field for snapshots

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf -- v2: - documented format changes in docs/interop/qcow2.txt (sugges

Re: [Qemu-devel] [Qemu-block] [PATCH] blk: postpone request execution on a context protected with "drained section"

2019-06-21 Thread Kevin Wolf
Am 09.04.2019 um 12:01 hat Kevin Wolf geschrieben: > Am 02.04.2019 um 10:35 hat Denis Plotnikov geschrieben: > > On 13.03.2019 19:04, Kevin Wolf wrote: > > > Am 14.12.2018 um 12:54 hat Denis Plotnikov geschrieben: > > >> On 13.12.2018 15:20, Kevin Wolf wrote: > > >>> Am 13.12.2018 um 12:07 hat Deni

[Qemu-devel] [PATCH for-4.1 03/24] replay: disable default snapshot for record/replay

2019-06-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch disables setting '-snapshot' option on by default in record/replay mode. This is needed for creating vmstates in record and replay modes. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf --- vl.c | 10 -- 1 file changed, 8 insertions(+), 2 deletio

Re: [Qemu-devel] [PATCH v4 00/13] Add migration support for VFIO device

2019-06-21 Thread Yan Zhao
On Fri, Jun 21, 2019 at 04:02:50PM +0800, Kirti Wankhede wrote: > > > On 6/21/2019 6:54 AM, Yan Zhao wrote: > > On Fri, Jun 21, 2019 at 08:25:18AM +0800, Yan Zhao wrote: > >> On Thu, Jun 20, 2019 at 10:37:28PM +0800, Kirti Wankhede wrote: > >>> Add migration support for VFIO device > >>> > >>> Th

Re: [Qemu-devel] [PATCH v4 00/13] Add migration support for VFIO device

2019-06-21 Thread Kirti Wankhede
On 6/21/2019 2:16 PM, Yan Zhao wrote: > On Fri, Jun 21, 2019 at 04:02:50PM +0800, Kirti Wankhede wrote: >> >> >> On 6/21/2019 6:54 AM, Yan Zhao wrote: >>> On Fri, Jun 21, 2019 at 08:25:18AM +0800, Yan Zhao wrote: On Thu, Jun 20, 2019 at 10:37:28PM +0800, Kirti Wankhede wrote: > Add migr

Re: [Qemu-devel] [External Email] Re: [PATCH 3/3] qapi: add block size histogram interface

2019-06-21 Thread Vladimir Sementsov-Ogievskiy
21.06.2019 4:52, zhenwei pi wrote: > On 6/20/19 10:03 PM, Eric Blake wrote: > >> On 6/20/19 3:54 AM, zhenwei pi wrote: >>> Set/Clear block size histograms through new command >>> x-block-size-histogram-set and show new statistics in >>> query-blockstats results. >>> >> I'm guessing this is modeled

[Qemu-devel] [PATCH] spapr_pci: Unregister listeners before destroying the IOMMU address space

2019-06-21 Thread Greg Kurz
Hot-unplugging a PHB with a VFIO device connected to it crashes QEMU: -device spapr-pci-host-bridge,index=1,id=phb1 \ -device vfio-pci,host=0034:01:00.3,id=vfio0 (qemu) device_del phb1 [ 357.207183] iommu: Removing device 0001:00:00.0 from group 1 [ 360.375523] rpadlpar_io: slot PHB 1 removed q

[Qemu-devel] [PATCH 0/4] libvhost-user: VHOST_USER_PROTOCOL_F_MQ support

2019-06-21 Thread Stefan Hajnoczi
Sebastien Boeuf pointed out that libvhost-user doesn't advertise VHOST_USER_PROTOCOL_F_MQ. Today this prevents vhost-user-net multiqueue from working. In virtio-fs we also want to support multiqueue so I'm sending patches to add this. It's free to advertise VHOST_USER_PROTOCOL_F_MQ for all devi

[Qemu-devel] [PATCH 1/4] libvhost-user: add vmsg_set_reply_u64() helper

2019-06-21 Thread Stefan Hajnoczi
The VhostUserMsg request is reused as the reply by message processing functions. This is risky since request fields may corrupt the reply if the vhost-user message handler function forgets to re-initialize them. Changing this practice would be very invasive but we can introduce a helper function

[Qemu-devel] [PATCH 2/4] libvhost-user: support many virtqueues

2019-06-21 Thread Stefan Hajnoczi
Currently libvhost-user is hardcoded to at most 8 virtqueues. The device backend should decide the number of virtqueues, not libvhost-user. This is important for multiqueue device backends where the guest driver needs an accurate number of virtqueues. This change breaks libvhost-user and libvhos

[Qemu-devel] [PATCH 3/4] libvhost-user: implement VHOST_USER_PROTOCOL_F_MQ

2019-06-21 Thread Stefan Hajnoczi
Existing vhost-user device backends, including vhost-user-scsi and vhost-user-blk, support multiqueue but libvhost-user currently does not advertise this. VHOST_USER_PROTOCOL_F_MQ enables the VHOST_USER_GET_QUEUE_NUM request needed for a vhost-user master to query the number of queues. For exampl

[Qemu-devel] [PATCH 4/4] docs: avoid vhost-user-net specifics in multiqueue section

2019-06-21 Thread Stefan Hajnoczi
The "Multiple queue support" section makes references to vhost-user-net "queue pairs". This is confusing for two reasons: 1. This actually applies to all device types, not just vhost-user-net. 2. VHOST_USER_GET_QUEUE_NUM returns the number of virtqueues, not the number of queue pairs. Reword t

Re: [Qemu-devel] [PATCH 1/3] block/accounting: rename struct BlockLatencyHistogram

2019-06-21 Thread Vladimir Sementsov-Ogievskiy
20.06.2019 11:54, zhenwei pi wrote: > Rename struct BlockLatencyHistogram to BlockHistogram, and rename > related functions name. > make this struct and functions be common, they can be used widely. Hmm, we can go further, and make it just Histogram and move to separate file, as there is nothing a

Re: [Qemu-devel] [PATCH 2/3] block/accounting: introduce block size histogram

2019-06-21 Thread Vladimir Sementsov-Ogievskiy
20.06.2019 11:54, zhenwei pi wrote: > Introduce block size histogram statics for block devices. > > For read/write/flush operation type, the block size region > [0, +inf) is divided into subregions by several points. > It works like block latency histogram. > > Signed-off-by: zhenwei pi > --- >

Re: [Qemu-devel] [PATCH for-4.1 00/24] Fix record/replay and add reverse debugging

2019-06-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/156110523748.25431.9310430853468653085.stgit@pasha-Precision-3630-Tower/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH for-4.1 00/24] Fix record/replay and add reverse debugg

[Qemu-devel] [PULL 01/10] MAINTAINERS: Update file items for MIPS Malta board

2019-06-21 Thread Aleksandar Markovic
From: Aleksandar Markovic hw/mips/gt64xxx_pci.c is used for Malta only, so it is logical to place this file in Malta board section of the MAINTAINERS file. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Rikalo Message-Id: <1561037595-14413-2-git

[Qemu-devel] [PULL 02/10] MAINTAINERS: Consolidate MIPS disassembler-related items

2019-06-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Eliminate duplicate MIPS disassembler-related items in the MAINTAINERS file, and use wildcards to shorten the list of involved files. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1561037595-14413-3-git-send-email-aleksandar.marko...@r

[Qemu-devel] [PULL 00/10] MIPS queue for June 21st, 2019

2019-06-21 Thread Aleksandar Markovic
From: Aleksandar Markovic The following changes since commit 33d609990621dea6c7d056c86f707b8811320ac1: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-06-18 17:00:52 +0100) are available in the git repository at: https://github.com/AMarkovic/qemu tags/mip

[Qemu-devel] [PULL 04/10] target/mips: Fix if-else-switch-case arms checkpatch errors in translate.c

2019-06-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Remove if-else-switch-case-arms-related checkpatch errors. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <1561037595-14413-5-git-send-email-aleksandar.marko...@rt-r

[Qemu-devel] [PULL 07/10] target/mips: Fix emulation of ILVEV. on big endian host

2019-06-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix emulation of ILVEV. on big endian host by applying mapping of data element indexes from one endian to another. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1561038349-17105-2-git-send-email-aleksandar.marko...@rt-rk.com> --- targ

[Qemu-devel] [PULL 06/10] tests/tcg: target/mips: Amend tests for MSA pack instructions

2019-06-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Add tests for cases when destination register is the same as one of source registers. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1561031359-6727-3-git-send-email-aleksandar.marko...@rt-rk.com> --- tests/tcg/mips/include/wrappers_ms

[Qemu-devel] [PULL 03/10] target/mips: Fix some space checkpatch errors in translate.c

2019-06-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Remove some space-related checkpatch warning. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <1561037595-14413-4-git-send-email-aleksandar.marko...@rt-rk.com> --- t

[Qemu-devel] [PULL 09/10] target/mips: Fix emulation of ILVL. on big endian host

2019-06-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix emulation of ILVL. on big endian host by applying mapping of data element indexes from one endian to another. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1561038349-17105-4-git-send-email-aleksandar.marko...@rt-rk.com> --- targe

[Qemu-devel] [PULL 08/10] target/mips: Fix emulation of ILVOD. on big endian host

2019-06-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix emulation of ILVOD. on big endian host by applying mapping of data element indexes from one endian to another. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1561038349-17105-3-git-send-email-aleksandar.marko...@rt-rk.com> --- targ

[Qemu-devel] [PULL 10/10] target/mips: Fix emulation of ILVR. on big endian host

2019-06-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix emulation of ILVR. on big endian host by applying mapping of data element indexes from one endian to another. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1561038349-17105-5-git-send-email-aleksandar.marko...@rt-rk.com> --- targe

Re: [Qemu-devel] [Qemu-block] [PATCH] blk: postpone request execution on a context protected with "drained section"

2019-06-21 Thread Vladimir Sementsov-Ogievskiy
21.06.2019 12:16, Kevin Wolf wrote: > Am 09.04.2019 um 12:01 hat Kevin Wolf geschrieben: >> Am 02.04.2019 um 10:35 hat Denis Plotnikov geschrieben: >>> On 13.03.2019 19:04, Kevin Wolf wrote: Am 14.12.2018 um 12:54 hat Denis Plotnikov geschrieben: > On 13.12.2018 15:20, Kevin Wolf wrote: >>

Re: [Qemu-devel] [RFC v2 PATCH] hw/arm/virt: makes virt a default machine type

2019-06-21 Thread Peter Maydell
On Thu, 20 Jun 2019 at 23:23, Wainer dos Santos Moschetta wrote: > I came across this when running the acceptance tests in an aarch64 host. > The arch-independent tests fail because, in general, they don't set a > machine type. In order to avoid treating arm targets as special cases > on avocado_q

Re: [Qemu-devel] [PATCH v4 00/13] Add migration support for VFIO device

2019-06-21 Thread Yan Zhao
On Fri, Jun 21, 2019 at 05:22:37PM +0800, Kirti Wankhede wrote: > > > On 6/21/2019 2:16 PM, Yan Zhao wrote: > > On Fri, Jun 21, 2019 at 04:02:50PM +0800, Kirti Wankhede wrote: > >> > >> > >> On 6/21/2019 6:54 AM, Yan Zhao wrote: > >>> On Fri, Jun 21, 2019 at 08:25:18AM +0800, Yan Zhao wrote: > >>

[Qemu-devel] [PATCH v3 0/2] Fix build of Xen support + cleanup

2019-06-21 Thread Anthony PERARD
Hi, Changes in v3: - two patches queued for a pull requests[1]: xen: Drop includes of xen/hvm/params.h xen: Avoid VLA - the two others patchs has changed, to keep the headers identical (nearly; at least the header guard isn't changed anymore) Fix the build in osstest and some cleanup F

[Qemu-devel] [PATCH v3 2/2] xen: Import other xen/io/*.h

2019-06-21 Thread Anthony PERARD
A Xen public header have been imported into QEMU (by f65eadb639 "xen: import ring.h from xen"), but there are other header that depends on ring.h which come from the system when building QEMU. This patch resolves the issue of having headers from the system importing a different copie of ring.h. T

[Qemu-devel] [PATCH v3 1/2] Revert xen/io/ring.h of "Clean up a few header guard symbols"

2019-06-21 Thread Anthony PERARD
This reverts changes to include/hw/xen/io/ring.h from commit 37677d7db39a3c250ad661d00fb7c3b59d047b1f. Following 37677d7db3 "Clean up a few header guard symbols", QEMU start to fail to build: In file included from ~/xen/tools/../tools/include/xen/io/blkif.h:31:0, from ~/xen/tools

Re: [Qemu-devel] [PATCH v2 4/5] tricore: add QSEED instruction

2019-06-21 Thread Konopik, Andreas (EFS-GH2)
Hi Bastian, allright thank you. A fix is already on the way. Best regards, Andreas > -Ursprüngliche Nachricht- > Von: Bastian Koppelmann > Gesendet: Mittwoch, 19. Juni 2019 14:25 > An: David Brenken ; qemu-devel@nongnu.org > Cc: Biermanski, Lars (EFS-GH3) ; Hofstetter, > Georg (EFS-GH

Re: [Qemu-devel] [PATCH v3 1/2] Revert xen/io/ring.h of "Clean up a few header guard symbols"

2019-06-21 Thread Daniel P . Berrangé
On Fri, Jun 21, 2019 at 11:54:40AM +0100, Anthony PERARD wrote: > This reverts changes to include/hw/xen/io/ring.h from commit > 37677d7db39a3c250ad661d00fb7c3b59d047b1f. > > Following 37677d7db3 "Clean up a few header guard symbols", QEMU start > to fail to build: > > In file included from ~/xen

[Qemu-devel] [PATCH v3 2/8] target/ppc: Optimize emulation of vsl and vsr instructions

2019-06-21 Thread Stefan Brankovic
Optimization of altivec instructions vsl and vsr(Vector Shift Left/Rigt). Perform shift operation (left and right respectively) on 128 bit value of register vA by value specified in bits 125-127 of register vB. Lowest 3 bits in each byte element of register vB must be identical or result is undefin

[Qemu-devel] [PATCH v3 6/8] target/ppc: Optimize emulation of vclzw instruction

2019-06-21 Thread Stefan Brankovic
Optimize Altivec instruction vclzw (Vector Count Leading Zeros Word). This instruction counts the number of leading zeros of each word element in source register and places result in the appropriate word element of destination register. Counting is to be performed in four iterations of for loop(on

Re: [Qemu-devel] [PATCH v6] vfio-ccw: support async command subregion

2019-06-21 Thread Cornelia Huck
On Wed, 19 Jun 2019 15:05:25 -0400 Eric Farman wrote: > On 6/13/19 5:25 AM, Cornelia Huck wrote: > > A vfio-ccw device may provide an async command subregion for > > issuing halt/clear subchannel requests. If it is present, use > > it for sending halt/clear request to the device; if not, fall > >

[Qemu-devel] [PATCH v3 3/8] target/ppc: Optimize emulation of vpkpx instruction

2019-06-21 Thread Stefan Brankovic
Optimize altivec instruction vpkpx (Vector Pack Pixel). Rearranges 8 pixels coded in 6-5-5 pattern (4 from each source register) into contigous array of bits in the destination register. In each iteration of outer loop, the instruction is to be done with the 6-5-5 pack for 2 pixels of each doublew

[Qemu-devel] [PATCH v3 1/8] target/ppc: Optimize emulation of lvsl and lvsr instructions

2019-06-21 Thread Stefan Brankovic
Adding simple macro that is calling tcg implementation of appropriate instruction if altivec support is active. Optimization of altivec instruction lvsl (Load Vector for Shift Left). Place bytes sh:sh+15 of value 0x00 || 0x01 || 0x02 || ... || 0x1E || 0x1F in destination register. Sh is calculated

[Qemu-devel] [PATCH v3 8/8] target/ppc: Refactor emulation of vmrgew and vmrgow instructions

2019-06-21 Thread Stefan Brankovic
Since I found this two instructions implemented with tcg, I refactored them so they are consistent with other similar implementations that I introduced in this patch. Also, a new dual macro GEN_VXFORM_TRANS_DUAL is added. This macro is used if one instruction is realized with direct translation, a

[Qemu-devel] [PATCH v3 4/8] target/ppc: Optimize emulation of vgbbd instruction

2019-06-21 Thread Stefan Brankovic
Optimize altivec instruction vgbbd (Vector Gather Bits by Bytes by Doubleword) All ith bits (i in range 1 to 8) of each byte of doubleword element in source register are concatenated and placed into ith byte of appropriate doubleword element in destination register. Following solution is done for

[Qemu-devel] [PATCH v3 0/8] target/ppc: Optimize emulation of some Altivec

2019-06-21 Thread Stefan Brankovic
Optimize emulation of ten Altivec instructions: lvsl, lvsr, vsl, vsr, vpkpx, vgbbd, vclzb, vclzh, vclzw and vclzd. This series buils up on and complements recent work of Thomas Murta, Mark Cave-Ayland and Richard Henderson in the same area. It is based on devising TCG translation implementation fo

[Qemu-devel] [PATCH v3 7/8] target/ppc: Optimize emulation of vclzh and vclzb instructions

2019-06-21 Thread Stefan Brankovic
Optimize Altivec instruction vclzh (Vector Count Leading Zeros Halfword). This instruction counts the number of leading zeros of each halfword element in source register and places result in the appropriate halfword element of destination register. In each iteration of outer for loop count operati

[Qemu-devel] [PATCH v3 5/8] target/ppc: Optimize emulation of vclzd instruction

2019-06-21 Thread Stefan Brankovic
Optimize Altivec instruction vclzd (Vector Count Leading Zeros Doubleword). This instruction counts the number of leading zeros of each doubleword element in source register and places result in the appropriate doubleword element of destination register. Using tcg-s count leading zeros instruction

Re: [Qemu-devel] [PATCH v3 2/2] xen: Import other xen/io/*.h

2019-06-21 Thread Daniel P . Berrangé
On Fri, Jun 21, 2019 at 11:54:41AM +0100, Anthony PERARD wrote: > A Xen public header have been imported into QEMU (by > f65eadb639 "xen: import ring.h from xen"), but there are other header > that depends on ring.h which come from the system when building QEMU. > > This patch resolves the issue o

[Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline parenthesized returned value

2019-06-21 Thread Paolo Bonzini
While indeed we do not want to have return (a); it is less clear that this applies to return (a && b); Some editors indent more nicely if you have parentheses, and some people's eyes may appreciate that as well. Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 3 +

[Qemu-devel] [PULL 04/25] i386/kvm: add support for KVM_GET_SUPPORTED_HV_CPUID

2019-06-21 Thread Paolo Bonzini
From: Vitaly Kuznetsov KVM now supports reporting supported Hyper-V features through CPUID (KVM_GET_SUPPORTED_HV_CPUID ioctl). Going forward, this is going to be the only way to announce new functionality and this has already happened with Direct Mode stimers. While we could just support KVM_GET

[Qemu-devel] [PULL v2 00/25] Misc (mostly x86) patches for 2019-06-21

2019-06-21 Thread Paolo Bonzini
The following changes since commit 33d609990621dea6c7d056c86f707b8811320ac1: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-06-18 17:00:52 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch

[Qemu-devel] [PULL 03/25] i386/kvm: convert hyperv enlightenments properties from bools to bits

2019-06-21 Thread Paolo Bonzini
From: Vitaly Kuznetsov Representing Hyper-V properties as bits will allow us to check features and dependencies between them in a natural way. Suggested-by: Roman Kagan Signed-off-by: Vitaly Kuznetsov Message-Id: <20190517141924.19024-2-vkuzn...@redhat.com> Signed-off-by: Paolo Bonzini --- h

Re: [Qemu-devel] [PATCH 02/12] block/backup: Add mirror sync mode 'bitmap'

2019-06-21 Thread Vladimir Sementsov-Ogievskiy
20.06.2019 4:03, John Snow wrote: > We don't need or want a new sync mode for simple differences in > semantics. Create a new mode simply named "BITMAP" that is designed to > make use of the new Bitmap Sync Mode field. > > Because the only bitmap mode is 'conditional', this adds no new > function

[Qemu-devel] [PULL 02/25] hax: Honor CPUState::halted

2019-06-21 Thread Paolo Bonzini
From: Colin Xu QEMU tracks whether a vcpu is halted using CPUState::halted. E.g., after initialization or reset, halted is 0 for the BSP (vcpu 0) and 1 for the APs (vcpu 1, 2, ...). A halted vcpu should not be handed to the hypervisor to run (e.g. hax_vcpu_run()). Under HAXM, Android Emulator so

[Qemu-devel] [PULL 06/25] i386/kvm: document existing Hyper-V enlightenments

2019-06-21 Thread Paolo Bonzini
From: Vitaly Kuznetsov Currently, there is no doc describing hv-* CPU flags, people are encouraged to get the information from Microsoft Hyper-V Top Level Functional specification (TLFS). There is, however, a bit of QEMU specifics. Signed-off-by: Vitaly Kuznetsov Message-Id: <20190517141924.190

[Qemu-devel] [PULL 01/25] kvm-all: Add/update fprintf's for kvm_*_ioeventfd_del

2019-06-21 Thread Paolo Bonzini
From: Yury Kotov Signed-off-by: Yury Kotov Message-Id: <20190607090830.18807-1-yury-ko...@yandex-team.ru> Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index b0c4be

[Qemu-devel] [PULL 21/25] target/i386: kvm: Add support for KVM_CAP_EXCEPTION_PAYLOAD

2019-06-21 Thread Paolo Bonzini
From: Liran Alon Kernel commit c4f55198c7c2 ("kvm: x86: Introduce KVM_CAP_EXCEPTION_PAYLOAD") introduced a new KVM capability which allows userspace to correctly distinguish between pending and injected exceptions. This distinguish is important in case of nested virtualization scenarios because

[Qemu-devel] [PULL 16/25] target/i386: kvm: Re-inject #DB to guest with updated DR6

2019-06-21 Thread Paolo Bonzini
From: Liran Alon If userspace (QEMU) debug guest, when #DB is raised in guest and intercepted by KVM, KVM forwards information on #DB to userspace instead of injecting #DB to guest. While doing so, KVM don't update vCPU DR6 but instead report the #DB DR6 value to userspace for further handling. S

  1   2   3   >