Re: [Qemu-devel] [PATCH 1/6] xics/spapr: Drop unused function declaration

2019-06-20 Thread David Gibson
On Mon, Jun 17, 2019 at 03:46:35PM +0200, Greg Kurz wrote: > Commit 9fb6eb7ca50c added the declaration of xics_spapr_connect(), which > has no implementation and no users. > > This is a leftover from a previous iteration of this patch. Drop it. > > Signed-off-by: Greg Kurz Applied, thanks. > -

Re: [Qemu-devel] [Qemu-riscv] [RFC v1 0/5] RISC-V: Add firmware loading support and default

2019-06-20 Thread Andrea Bolognani
On Wed, 2019-06-19 at 11:23 -0700, Alistair Francis wrote: > On Wed, Jun 19, 2019 at 7:42 AM Bin Meng wrote: > > On Wed, Jun 19, 2019 at 10:30 PM Alistair Francis > > wrote: > > > On Wed, Jun 19, 2019 at 7:26 AM Bin Meng wrote: > > > > > pc-bios/opensbi-riscv32-fw_jump.elf | Bin 0 -> 197988 by

Re: [Qemu-devel] [PATCH 2/6] xics/spapr: Rename xics_kvm_init()

2019-06-20 Thread David Gibson
On Mon, Jun 17, 2019 at 03:46:41PM +0200, Greg Kurz wrote: > Switch to using the connect/disconnect terminology like we already do for > XIVE. > > Signed-off-by: Greg Kurz Applied, thanks. > --- > hw/intc/xics_kvm.c |2 +- > hw/ppc/spapr_irq.c |2 +- > include/hw/ppc/

Re: [Qemu-devel] [PATCH 4/6] xics/kvm: Always use local_err in xics_kvm_init()

2019-06-20 Thread David Gibson
On Mon, Jun 17, 2019 at 03:46:52PM +0200, Greg Kurz wrote: > Passing both errp and &local_err to functions is a recipe for messing > things up. > > Since we must use &local_err for icp_kvm_realize(), use &local_err > everywhere where rollback must happen and have a single call to > error_propagate

Re: [Qemu-devel] [PATCH] memory: do not do out of bound notification

2019-06-20 Thread Peter Xu
On Thu, Jun 20, 2019 at 12:14:00AM -0400, Yan Zhao wrote: > On Thu, Jun 20, 2019 at 12:02:30PM +0800, Peter Xu wrote: > > On Wed, Jun 19, 2019 at 03:17:41PM +0200, Auger Eric wrote: > > > Hi Yan, > > > > > > [+ Peter] > > > > > > On 6/19/19 10:49 AM, Yan Zhao wrote: > > > > even if an entry overl

Re: [Qemu-devel] [PATCH 3/6] xics/kvm: Skip rollback when KVM XICS is absent

2019-06-20 Thread David Gibson
On Mon, Jun 17, 2019 at 03:46:46PM +0200, Greg Kurz wrote: > There is no need to rollback anything at this point, so just return an > error. > > Signed-off-by: Greg Kurz Applied, thanks. > --- > hw/intc/xics_kvm.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/

Re: [Qemu-devel] [Qemu-devel PATCH v3 0/2] fix incorrect assertions in sd and main-loop

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/19/19 9:14 PM, Lidong Chen wrote: > This v3 added Philippe's Reviewed-by in patch2 (main-loop.c) Thanks. > I also included Philippe's previous comment about patch1 (sd.c) > in this cover: > > > Not sure via which tree this patch is going (trivial?). > To the maintainer, please co

Re: [Qemu-devel] [Qemu-devel PATCH v3 0/2] fix incorrect assertions in sd and main-loop

2019-06-20 Thread Paolo Bonzini
On 19/06/19 21:14, Lidong Chen wrote: > This v3 added Philippe's Reviewed-by in patch2 (main-loop.c) > I also included Philippe's previous comment about patch1 (sd.c) > in this cover: > > > Not sure via which tree this patch is going (trivial?). > To the maintainer, please consider addi

Re: [Qemu-devel] [PATCH] memory: do not do out of bound notification

2019-06-20 Thread Yan Zhao
On Thu, Jun 20, 2019 at 04:14:37PM +0800, Peter Xu wrote: > On Thu, Jun 20, 2019 at 12:14:00AM -0400, Yan Zhao wrote: > > On Thu, Jun 20, 2019 at 12:02:30PM +0800, Peter Xu wrote: > > > On Wed, Jun 19, 2019 at 03:17:41PM +0200, Auger Eric wrote: > > > > Hi Yan, > > > > > > > > [+ Peter] > > > > >

Re: [Qemu-devel] [PATCH 09/17] hw/core: Move numa.c to hw/core/

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:42PM +0200, Markus Armbruster wrote: > Cc: Eduardo Habkost > Cc: Marcel Apfelbaum > Signed-off-by: Markus Armbruster > --- > MAINTAINERS | 2 +- > Makefile.target | 2 +- > hw/core/Makefile.objs| 2 ++ > numa.c => hw/core/numa.c | 0 > 4 f

Re: [Qemu-devel] [PATCH 08/17] qapi: Split machine.json off misc.json

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:41PM +0200, Markus Armbruster wrote: > Move commands cpu-add, query-cpus, query-cpus-fast, > query-current-machine, query-hotpluggable-cpus, query-machines, > query-memdev, and set-numa-node with their types from misc.json to new > machine.json. Also move types X86CPU

Re: [Qemu-devel] [PATCH 07/17] MAINTAINERS: Merge sections CPU, NUMA into Machine core

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:40PM +0200, Markus Armbruster wrote: > Suggested-by: Paolo Bonzini > Cc: Eduardo Habkost > Cc: Marcel Apfelbaum > Signed-off-by: Markus Armbruster > --- > MAINTAINERS | 16 > 1 file changed, 4 insertions(+), 12 deletions(-) Reviewed-by: Daniel P.

Re: [Qemu-devel] [PATCH 03/17] hmp: Move hmp.h to include/monitor/

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:36PM +0200, Markus Armbruster wrote: > Cc: "Dr. David Alan Gilbert" > Signed-off-by: Markus Armbruster > --- > hmp.h => include/monitor/hmp.h | 0 > monitor/hmp-cmds.c | 2 +- > monitor/misc.c | 2 +- > target/i386/monitor.c | 2

Re: [Qemu-devel] [PATCH 06/17] qom: Move HMP command handlers to qom/

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:39PM +0200, Markus Armbruster wrote: > There are just two HMP commands related to QOM: qom-list and qom-set. > Move their handlers from monitor/hmp-cmds.c to new qom/qom-hmp-cmds.c, > where they are covered by MAINTAINERS section QOM. > > Cc: Paolo Bonzini > Cc: "Dan

Re: [Qemu-devel] [PATCH 6/6] xics/kvm: Add proper rollback to xics_kvm_init()

2019-06-20 Thread David Gibson
On Mon, Jun 17, 2019 at 03:47:03PM +0200, Greg Kurz wrote: > Make xics_kvm_disconnect() able to undo the changes of a partial execution > of xics_kvm_connect() and use it to perform rollback. > > Note that kvmppc_define_rtas_kernel_token(0) never fails, no matter the > RTAS call has been defined o

Re: [Qemu-devel] [PATCH 10/17] hw/core: Collect QMP command handlers in hw/core/

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:43PM +0200, Markus Armbruster wrote: > The handlers for qapi/machine.json's QMP commands are spread over > cpus.c, hw/core/numa.c, monitor/misc.c, monitor/qmp-cmds.c, and vl.c. > Move them all to new hw/core/machine-qmp-cmds.c, where they are > covered by MAINTAINERS s

Re: [Qemu-devel] [PATCH 05/17] qom: Move QMP command handlers to qom/

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:38PM +0200, Markus Armbruster wrote: > The handlers for qapi/qom.json's QMP commands are in > monitor/qmp-cmds.c. Move them to new qom/qom-qmp-cmds.c, where they > are covered by MAINTAINERS section QOM, just like qapi/qom.json. > > Move along qmp_device_list_propert

Re: [Qemu-devel] [PATCH 04/17] qapi: Split qom.json and qdev.json off misc.json

2019-06-20 Thread Paolo Bonzini
On 19/06/19 22:10, Markus Armbruster wrote: > Move commands device-list-properties, device_add, device-del, and > event DEVICE_DELETED from misc.json to new qdev.json. qdev.json > remains uncovered by MAINTAINERS, like the rest of qdev. qdev should be added to either QOM or machine core. QOM wou

Re: [Qemu-devel] [PATCH 11/17] hw/core: Collect HMP command handlers in hw/core/

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:44PM +0200, Markus Armbruster wrote: > Move the HMP handlers related to qapi/machine.json to > hw/core/machine-hmp-cmds.c, where they are covered by MAINTAINERS > section "Machine core", just like qapi/machine.json. > > Cc: Eduardo Habkost > Cc: Marcel Apfelbaum > C

[Qemu-devel] [PATCH 0/3] Add block size histogram qapi interface

2019-06-20 Thread zhenwei pi
Set/Clear block size histograms through new command x-block-size-histogram-set and show new statistics in query-blockstats results. This command has been tested for half year on QEMU-2.12, and we found that 3K+ virtual machines write 25GB/s totally, the block size histogram like following:

Re: [Qemu-devel] [PATCH 04/17] qapi: Split qom.json and qdev.json off misc.json

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:37PM +0200, Markus Armbruster wrote: > Move commands object-add, object-del, qom-get, qom-list, > qom-list-properties, qom-list-types, and qom-set with their types from > misc.json to new qom.json. Add qom.json to MAINTAINERS section QOM. > > Move commands device-lis

Re: [Qemu-devel] [PATCH 5/6] xics/kvm: Add error propagation to ic*_set_kvm_state() functions

2019-06-20 Thread David Gibson
On Mon, Jun 17, 2019 at 03:46:57PM +0200, Greg Kurz wrote: > This allows errors happening there to be propagated up to spapr_irq, > just like XIVE already does. > > Signed-off-by: Greg Kurz Applied, thanks. > --- > hw/intc/xics.c| 39 ++- > hw/intc

[Qemu-devel] [PATCH 2/3] block/accounting: introduce block size histogram

2019-06-20 Thread zhenwei pi
Introduce block size histogram statics for block devices. For read/write/flush operation type, the block size region [0, +inf) is divided into subregions by several points. It works like block latency histogram. Signed-off-by: zhenwei pi --- block/accounting.c | 24 +

Re: [Qemu-devel] [PATCH qemu] loader: Trace loaded images

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/20/19 7:50 AM, Alexey Kardashevskiy wrote: > On 17/06/2019 14:56, Philippe Mathieu-Daudé wrote: >> On 6/17/19 3:25 AM, Alexey Kardashevskiy wrote: >>> On 14/06/2019 19:33, Stefan Hajnoczi wrote: On Fri, Jun 14, 2019 at 10:13:04AM +1000, Alexey Kardashevskiy wrote: > > > On 13/

Re: [Qemu-devel] [PATCH 01/17] MAINTAINERS: new maintainers for QOM

2019-06-20 Thread Paolo Bonzini
On 19/06/19 22:31, Andreas Färber wrote: > Am 19.06.19 um 22:10 schrieb Markus Armbruster: >> From: Paolo Bonzini >> >> QOM is not a particularly active subsystem now: 51 commits in two years. >> But, we need active maintainers to review and merge patches, and Git >> shows the following top commit

Re: [Qemu-devel] [PATCH 01/17] MAINTAINERS: new maintainers for QOM

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:34PM +0200, Markus Armbruster wrote: > From: Paolo Bonzini > > QOM is not a particularly active subsystem now: 51 commits in two years. > But, we need active maintainers to review and merge patches, and Git > shows the following top committers taking on QOM: > >

[Qemu-devel] [PATCH 3/3] qapi: add block size histogram interface

2019-06-20 Thread zhenwei pi
Set/Clear block size histograms through new command x-block-size-histogram-set and show new statistics in query-blockstats results. Signed-off-by: zhenwei pi --- block/qapi.c | 24 blockdev.c | 56 +++ qapi/block-core.json | 105 ++

Re: [Qemu-devel] [PATCH 14/17] qapi: Split dump.json off misc.json

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:47PM +0200, Markus Armbruster wrote: > Move commands dump-guest-memory, query-dump, > query-dump-guest-memory-capability with their types from misc.json to > new dump.json. Add dump.json to MAINTAINERS section "Dump". > > Cc: Marc-André Lureau > Signed-off-by: Marku

Re: [Qemu-devel] [PATCH] memory: do not do out of bound notification

2019-06-20 Thread Paolo Bonzini
On 20/06/19 06:02, Peter Xu wrote: > Seems workable, to be explicit - we can even cut it into chunks with > different size to be efficient. Yes, this is not hard (completely untested): diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 44b1231157..541538bc6c 100644 --- a/hw/i386/int

Re: [Qemu-devel] [PATCH 12/17] qapi: Split machine-target.json off target.json and misc.json

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:45PM +0200, Markus Armbruster wrote: > Move commands query-cpu-definitions, query-cpu-model-baseline, > query-cpu-model-comparison, and query-cpu-model-expansion with their > types from target.json to machine-target.json. Also move typee > CpuModelInfo, CpuModelExpans

Re: [Qemu-devel] [PATCH 15/17] dump: Move the code to dump/

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:48PM +0200, Markus Armbruster wrote: > Cc: Marc-André Lureau > Signed-off-by: Markus Armbruster > --- > MAINTAINERS | 2 +- > Makefile.target | 3 +-- > dump/Makefile.objs| 2 ++ > dump.c => dump/dump.c | 0 > win_

[Qemu-devel] [PATCH 4/4] target/mips: Fix emulation of ILVR. on big endian host

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix emulation of ILVR. on big endian host by applying mapping of data element indexes from one endian to another. Signed-off-by: Aleksandar Markovic --- target/mips/msa_helper.c | 37 + 1 file changed, 37 insertions(+) diff --git a

Re: [Qemu-devel] [PATCH 02/17] Makefile: Don't add monitor/ twice to common-obj-y

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:35PM +0200, Markus Armbruster wrote: > Both commit f1b3ccfaa68 "monitor: Move {hmp, qmp}.c to monitor/{hmp, > qmp}-cmds.c" and commit 7e3c0deab1b "monitor: Split out monitor/qmp.c" > added monitor/ to common-obj-y ifeq ($(CONFIG_SOFTMMU),y). Revert the > second additi

Re: [Qemu-devel] [PATCH 17/17] dump: Move HMP command handlers to dump/

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:50PM +0200, Markus Armbruster wrote: > Move the HMP handlers related to qapi/dump.json to > dimp/dump-hmp-cmds.c, where they are covered by MAINTAINERS section > "Dump", just like qapi/dump.json. > > Cc: Marc-André Lureau > Cc: "Dr. David Alan Gilbert" > Signed-off-

Re: [Qemu-devel] [PATCH 16/17] MAINTAINERS: Add Windows dump to section "Dump"

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:49PM +0200, Markus Armbruster wrote: > Commit 2da91b54fe9 "dump: add Windows dump format to > dump-guest-memory" neglected to update MAINTAINERS. Do it now. > > Cc: Marc-André Lureau > Signed-off-by: Markus Armbruster > --- > MAINTAINERS | 3 ++- > 1 file changed,

Re: [Qemu-devel] [PATCH 13/17] qapi: Rename target.json to misc-target.json

2019-06-20 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:10:46PM +0200, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hw/ppc/spapr_rtc.c | 2 +- > hw/s390x/s390-skeys.c | 2 +- > hw/timer/mc146818rtc.c | 4 ++-- > qapi/Makefile.objs

[Qemu-devel] [PATCH 0/4] target/mips: Fix some issues of MSA emulation on big endian hosts

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix some issues of MSA emulation on big endian hosts. Aleksandar Markovic (4): target/mips: Fix emulation of ILVEV. on big endian host target/mips: Fix emulation of ILVOD. on big endian host target/mips: Fix emulation of ILVL. on big endian host target/mips: Fix

[Qemu-devel] [PATCH 2/4] target/mips: Fix emulation of ILVOD. on big endian host

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix emulation of ILVOD. on big endian host by applying mapping of data element indexes from one endian to another. Signed-off-by: Aleksandar Markovic --- target/mips/msa_helper.c | 37 + 1 file changed, 37 insertions(+) diff --git

[Qemu-devel] [PATCH v3 1/3] vmdk: Fix comment regarding max l1_size coverage

2019-06-20 Thread Sam Eiderman
Commit b0651b8c246d ("vmdk: Move l1_size check into vmdk_add_extent") extended the l1_size check from VMDK4 to VMDK3 but did not update the default coverage in the moved comment. The previous vmdk4 calculation: (512 * 1024 * 1024) * 512(l2 entries) * 65536(grain) = 16PB The added vmdk3 calcu

[Qemu-devel] [PATCH 1/3] block/accounting: rename struct BlockLatencyHistogram

2019-06-20 Thread zhenwei pi
Rename struct BlockLatencyHistogram to BlockHistogram, and rename related functions name. make this struct and functions be common, they can be used widely. Signed-off-by: zhenwei pi --- block/accounting.c | 31 ++- block/qapi.c | 2 +- include/

[Qemu-devel] [PATCH v3 2/3] vmdk: Reduce the max bound for L1 table size

2019-06-20 Thread Sam Eiderman
512M of L1 entries is a very loose bound, only 32M are required to store the maximal supported VMDK file size of 2TB. Fixed qemu-iotest 59# - now failure occures before on impossible L1 table size. Reviewed-by: Karl Heubaum Reviewed-by: Eyal Moscovici Reviewed-by: Liran Alon Reviewed-by: Arbel

[Qemu-devel] [PATCH 1/4] target/mips: Fix emulation of ILVEV. on big endian host

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix emulation of ILVEV. on big endian host by applying mapping of data element indexes from one endian to another. Signed-off-by: Aleksandar Markovic --- target/mips/msa_helper.c | 37 + 1 file changed, 37 insertions(+) diff --git

Re: [Qemu-devel] [SeaBIOS] [PATCH v3 4/4] geometry: Apply LCHS values for boot devices

2019-06-20 Thread Sam Eiderman
> On 20 Jun 2019, at 8:42, Gerd Hoffmann wrote: > >> +static int >> +overriden_lchs_supplied(struct drive_s *drive) >> +{ >> +return drive->lchs.cylinder || drive->lchs.head || drive->lchs.sector; >> +} > >> +case TRANSLATION_MACHINE: > > Hmm, why this name? Doesn't look intuitive t

[Qemu-devel] [PATCH 3/4] target/mips: Fix emulation of ILVL. on big endian host

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix emulation of ILVL. on big endian host by applying mapping of data element indexes from one endian to another. Signed-off-by: Aleksandar Markovic --- target/mips/msa_helper.c | 37 + 1 file changed, 37 insertions(+) diff --git a

Re: [Qemu-devel] [PATCH v2 3/3] vmdk: Add read-only support for seSparse snapshots

2019-06-20 Thread Sam Eiderman
> On 19 Jun 2019, at 20:12, Max Reitz wrote: > > On 05.06.19 14:17, Sam Eiderman wrote: >> Until ESXi 6.5 VMware used the vmfsSparse format for snapshots (VMDK3 in >> QEMU). >> >> This format was lacking in the following: >> >>* Grain directory (L1) and grain table (L2) entries were 32-b

[Qemu-devel] [PATCH v3 3/3] vmdk: Add read-only support for seSparse snapshots

2019-06-20 Thread Sam Eiderman
Until ESXi 6.5 VMware used the vmfsSparse format for snapshots (VMDK3 in QEMU). This format was lacking in the following: * Grain directory (L1) and grain table (L2) entries were 32-bit, allowing access to only 2TB (slightly less) of data. * The grain size (default) was 512 bytes -

Re: [Qemu-devel] [SeaBIOS] [QEMU] [PATCH v4 0/8] Add Qemu to SeaBIOS LCHS interface

2019-06-20 Thread Sam Eiderman
> On 20 Jun 2019, at 8:50, Gerd Hoffmann wrote: > >> === OUTPUT BEGIN === >> 1/8 Checking commit cf2168a66dbd (block: Refactor macros - fix tabbing) >> ERROR: Macros with complex values should be enclosed in parenthesis >> #55: FILE: include/hw/block/block.h:65: >> +#define DEFINE_BLOCK_CHS_PR

[Qemu-devel] [PATCH 3/4] target/mips: Fix some space checkpatch errors in translate.c

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic Remove some space-related checkpatch warning. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 126 +--- 1 file changed, 65 insertions(+), 61 deletions(-) diff --git a/target/mips/translate.c b/target/mips/t

[Qemu-devel] [PATCH v3 0/3] vmdk: Add read-only support for the new seSparse format

2019-06-20 Thread Sam Eiderman
v1: VMware introduced a new snapshot format in VMFS6 - seSparse (Space Efficient Sparse) which is the default format available in ESXi 6.7. Add read-only support for the new snapshot format. v2: Fixed after Max's review: * Removed strict sesparse checks * Reduced maximal L1 table size * Added n

Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model

2019-06-20 Thread Igor Mammedov
On Tue, 18 Jun 2019 10:55:16 -0300 Eduardo Habkost wrote: > On Tue, Jun 18, 2019 at 01:34:10PM +0200, Igor Mammedov wrote: > > On Mon, 17 Jun 2019 13:27:00 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Jun 17, 2019 at 05:33:43PM +0200, Igor Mammedov wrote: > > > > On Mon, 17 Jun 2019 1

Re: [Qemu-devel] [PATCH] qmp: make qmp-shell work with python3

2019-06-20 Thread Igor Mammedov
On Wed, 19 Jun 2019 09:29:24 -0400 Cleber Rosa wrote: > On Tue, Jun 18, 2019 at 10:29:31AM -0400, Igor Mammedov wrote: > > python3 doesn't have raw_input(), so qmp-shell breaks. > > Use input() instead and override it with raw_input() > > if running on python2. > > > > Signed-off-by: Igor Mammed

[Qemu-devel] [PATCH 2/4] MAINTAINERS: Consolidate MIPS disassembler-related items

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic Eliminate duplicate MIPS disassembler-related items in the MAINTAINERS file, and use wildcards to shorten the list of involved files. Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/MAINTAINERS

[Qemu-devel] [PATCH 4/4] target/mips: Fix if-else arms checkpatch errors in translate.c

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic Remove if-else-arms-related checkpatch errors. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 106 ++-- 1 file changed, 66 insertions(+), 40 deletions(-) diff --git a/target/mips/translate.c b/target/mips/

[Qemu-devel] [PATCH 0/4] target/mips: Misc fixes and maintenance for 4.1

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic This series contains miscelaneous fixes, improvements, and maintainance items intended to be integrated into QEMU 4.1. I will gradually add patches by the end of June 2019. v1->v2: - added two patches on cleaning checkpatch warnings Aleksandar Markovic (4): MAINTA

[Qemu-devel] [PATCH 1/4] MAINTAINERS: Update file items for MIPS Malta board

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic hw/mips/gt64xxx_pci.c is used for Malta only, so it is logical to place this file in Malta board section of the MAINTAINERS file. Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index acb

Re: [Qemu-devel] [PATCH 03/17] hmp: Move hmp.h to include/monitor/

2019-06-20 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Cc: "Dr. David Alan Gilbert" > Signed-off-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert > --- > hmp.h => include/monitor/hmp.h | 0 > monitor/hmp-cmds.c | 2 +- > monitor/misc.c | 2 +- > target/i386/moni

Re: [Qemu-devel] [PATCH v3 03/50] cpu: introduce cpu_in_exclusive_work_context()

2019-06-20 Thread Alex Bennée
Richard Henderson writes: > On 6/14/19 10:11 AM, Alex Bennée wrote: >> start_exclusive(); >> +cpu->in_exclusive_work_context = true; >> wi->func(cpu, wi->data); >> +cpu->in_exclusive_work_context = false; >> end_exclusive(); > > Is

Re: [Qemu-devel] [PATCH v10] ssh: switch from libssh2 to libssh

2019-06-20 Thread Pino Toscano
On Tuesday, 18 June 2019 15:14:30 CEST Max Reitz wrote: > On 18.06.19 11:24, Pino Toscano wrote: > > Rewrite the implementation of the ssh block driver to use libssh instead > > of libssh2. The libssh library has various advantages over libssh2: > > - easier API for authentication (for example for

Re: [Qemu-devel] [PATCH 06/17] qom: Move HMP command handlers to qom/

2019-06-20 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > There are just two HMP commands related to QOM: qom-list and qom-set. > Move their handlers from monitor/hmp-cmds.c to new qom/qom-hmp-cmds.c, > where they are covered by MAINTAINERS section QOM. > > Cc: Paolo Bonzini > Cc: "Daniel P. Berrange" >

Re: [Qemu-devel] [PATCH 11/17] hw/core: Collect HMP command handlers in hw/core/

2019-06-20 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Move the HMP handlers related to qapi/machine.json to > hw/core/machine-hmp-cmds.c, where they are covered by MAINTAINERS > section "Machine core", just like qapi/machine.json. > > Cc: Eduardo Habkost > Cc: Marcel Apfelbaum > Cc: "Dr. David Alan G

Re: [Qemu-devel] [PATCH 17/17] dump: Move HMP command handlers to dump/

2019-06-20 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Move the HMP handlers related to qapi/dump.json to > dimp/dump-hmp-cmds.c, where they are covered by MAINTAINERS section > "Dump", just like qapi/dump.json. > > Cc: Marc-André Lureau > Cc: "Dr. David Alan Gilbert" > Signed-off-by: Markus Armbruste

Re: [Qemu-devel] [PATCH v10] ssh: switch from libssh2 to libssh

2019-06-20 Thread Daniel P . Berrangé
On Tue, Jun 18, 2019 at 03:14:30PM +0200, Max Reitz wrote: > On 18.06.19 11:24, Pino Toscano wrote: > > Rewrite the implementation of the ssh block driver to use libssh instead > > of libssh2. The libssh library has various advantages over libssh2: > > - easier API for authentication (for example

[Qemu-devel] [PATCH v3 4/4] target/mips: Fix if-else-switch-case arms checkpatch errors in translate.c

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic Remove if-else-switch-case-arms-related checkpatch errors. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 205 +++- 1 file changed, 133 insertions(+), 72 deletions(-) diff --git a/target/mips/translate.c b

[Qemu-devel] [PATCH v3 2/4] MAINTAINERS: Consolidate MIPS disassembler-related items

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic Eliminate duplicate MIPS disassembler-related items in the MAINTAINERS file, and use wildcards to shorten the list of involved files. Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/MAINTAINERS

[Qemu-devel] [PATCH v3 3/4] target/mips: Fix some space checkpatch errors in translate.c

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic Remove some space-related checkpatch warning. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 240 1 file changed, 122 insertions(+), 118 deletions(-) diff --git a/target/mips/translate.c b/target/mips

[Qemu-devel] [PATCH v3 1/4] MAINTAINERS: Update file items for MIPS Malta board

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic hw/mips/gt64xxx_pci.c is used for Malta only, so it is logical to place this file in Malta board section of the MAINTAINERS file. Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index acb

[Qemu-devel] [PATCH v3 0/4] target/mips: Misc fixes and maintenance for 4.1

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic This series contains miscelaneous fixes, improvements, and maintainance items intended to be integrated into QEMU 4.1. I will gradually add patches by the end of June 2019. v2->v3: - amendeded two patches on cleaning checkpatch warnings v1->v2: - added two patche

Re: [Qemu-devel] [PATCH 0/2] target/mips: Improve MSA tests

2019-06-20 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Wednesday, June 19, 2019 8:33 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; Aleksandar Rikalo > Subject: [PATCH 0/2] target/mips: Improve MSA tests > > From: Aleksandar Markovic > > This series contains various improvements and additions of MSA ASE

Re: [Qemu-devel] [PATCH 0/4] target/mips: Fix some issues of MSA emulation on big endian hosts

2019-06-20 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Thursday, June 20, 2019 10:57 AM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; Aleksandar Rikalo > Subject: [PATCH 0/4] target/mips: Fix some issues of MSA emulation on big > endian hosts > > From: Aleksandar Markovic > > Fix some issues of MSA emulat

Re: [Qemu-devel] [PATCH v1 02/17] tests/vm: avoid image presence check and removal

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/19/19 9:40 PM, Alex Bennée wrote: > From: Cleber Rosa > > Python's os.rename() will silently replace an existing file, > so there's no need for the extra check and removal. > > Reference: https://docs.python.org/3/library/os.html#os.rename > Signed-off-by: Cleber Rosa Reviewed-by: Philipp

Re: [Qemu-devel] [PATCH v1 03/17] tests/vm: pin ubuntu.i386 image

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/19/19 9:40 PM, Alex Bennée wrote: > From: Cleber Rosa > > It's a good practice to always have the same components used in tests. > According to: > >https://cloud-images.ubuntu.com/releases/16.04/ > > New images are released from time to time, and the "release/" > directory points to th

Re: [Qemu-devel] [PATCH v1 12/17] tests/vm: freebsd autoinstall, using serial console

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/19/19 9:40 PM, Alex Bennée wrote: > From: Gerd Hoffmann > > Instead of fetching the prebuilt image from patchew download the install > iso and prepare the image locally. Install to disk, using the serial > console. Create qemu user, configure ssh login. Install packages > needed for qemu

Re: [Qemu-devel] [PATCH v3 0/4] target/mips: Misc fixes and maintenance for 4.1

2019-06-20 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Thursday, June 20, 2019 12:02 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; Aleksandar Rikalo > Subject: [PATCH v3 0/4] target/mips: Misc fixes and maintenance for 4.1 > > From: Aleksandar Markovic > > This series contains miscelaneous fixes, improv

Re: [Qemu-devel] [PATCH v1 05/17] tests/vm: send proxy environment variables over ssh

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/19/19 9:40 PM, Alex Bennée wrote: > From: Gerd Hoffmann > > Packages are fetched via proxy that way, if configured on the host. > That might be required to pass firewalls, and it allows to route > package downloads through a caching proxy server. > > Needs AcceptEnv setup in sshd_config on

Re: [Qemu-devel] [PATCH v1 17/17] .travis.yml: force a brew update for MacOS builds

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/19/19 9:40 PM, Alex Bennée wrote: > It looks like the Travis image package databases are out of date > causing the build to error with: > > Error: Your Homebrew is outdated. Please run `brew update`. > Error: Kernel.exit > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Alex Benn

Re: [Qemu-devel] [PATCH v1 14/17] tests/vm: fedora autoinstall, using serial console

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/19/19 9:40 PM, Alex Bennée wrote: > From: Gerd Hoffmann > > Download the install iso and prepare the image locally. Install to > disk, using the serial console. Create qemu user, configure ssh login. > Install packages needed for qemu builds. > > Yes, we have docker images for fedora. Bu

Re: [Qemu-devel] [PATCH v1 16/17] .travis.yml: default the --disable-system build to --static

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/19/19 9:40 PM, Alex Bennée wrote: > It's fairly common to build qemu-user binaries with --static linking > so the binary can be copied around without libraries. Enable --static > in the default qemu-user build to cover this. > > There are other qemu-user builds that use dynamic linking so the

[Qemu-devel] [PATCH RFC] x86: BFloat16 feature enabling on Cooper Lake

2019-06-20 Thread Jing Liu
Intel CooperLake cpu adds AVX512_BF16 instruction, defining as CPUID.(EAX=7,EXC=1):EAX[bit 05]. The release spec link as follows, https://software.intel.com/sites/default/files/managed/c5/15/\ architecture-instruction-set-extensions-programming-reference.pdf Signed-off-by: Jing Liu --- target/i

Re: [Qemu-devel] [PATCH] memory: do not do out of bound notification

2019-06-20 Thread Yan Zhao
On Thu, Jun 20, 2019 at 04:35:29PM +0800, Paolo Bonzini wrote: > On 20/06/19 06:02, Peter Xu wrote: > > Seems workable, to be explicit - we can even cut it into chunks with > > different size to be efficient. > > Yes, this is not hard (completely untested): > > diff --git a/hw/i386/intel_iommu.c

Re: [Qemu-devel] [PATCH v1 01/17] tests/vm: avoid extra compressed image copy

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/19/19 9:40 PM, Alex Bennée wrote: > From: Cleber Rosa > > The image copy is only really needed because xz doesn't know to > properly decompress a file not named properly. Instead of > decompressing to stdout, and having to rely on a shell, let's just > create a link instead of copying the f

Re: [Qemu-devel] [PATCH v1 04/17] tests/vm: add source repos on ubuntu.i386

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/19/19 9:40 PM, Alex Bennée wrote: > From: Cleber Rosa > > Possibly because of different behavior on the newly update > cloud-image, trying to run 'apt-get build-dep' results in: > >E: You must put some 'source' URIs in your sources.list > > This enables all source repos (even though so

Re: [Qemu-devel] [PATCH v1 02/17] tests/vm: avoid image presence check and removal

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/20/19 12:29 PM, Philippe Mathieu-Daudé wrote: > On 6/19/19 9:40 PM, Alex Bennée wrote: >> From: Cleber Rosa >> >> Python's os.rename() will silently replace an existing file, >> so there's no need for the extra check and removal. >> >> Reference: https://docs.python.org/3/library/os.html#os.r

Re: [Qemu-devel] [PATCH 1/4] MAINTAINERS: Update file items for MIPS Malta board

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/20/19 11:19 AM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > hw/mips/gt64xxx_pci.c is used for Malta only, so it is logical to > place this file in Malta board section of the MAINTAINERS file. > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Aleksandar Markovic > ---

Re: [Qemu-devel] [PATCH 3/4] target/mips: Fix some space checkpatch errors in translate.c

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/20/19 11:19 AM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Remove some space-related checkpatch warning. > > Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 126 > ++

Re: [Qemu-devel] [PATCH 4/4] target/mips: Fix if-else arms checkpatch errors in translate.c

2019-06-20 Thread Philippe Mathieu-Daudé
On 6/20/19 11:19 AM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Remove if-else-arms-related checkpatch errors. > > Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 106 > +

Re: [Qemu-devel] [SeaBIOS] [PATCH v3 4/4] geometry: Apply LCHS values for boot devices

2019-06-20 Thread Gerd Hoffmann
On Thu, Jun 20, 2019 at 11:52:01AM +0300, Sam Eiderman wrote: > > > > On 20 Jun 2019, at 8:42, Gerd Hoffmann wrote: > > > >> +static int > >> +overriden_lchs_supplied(struct drive_s *drive) > >> +{ > >> +return drive->lchs.cylinder || drive->lchs.head || drive->lchs.sector; > >> +} > > > >

[Qemu-devel] [PATCH v5 0/2] ati-vga: Implement DDC and EDID info from monitor

2019-06-20 Thread BALATON Zoltan
Version 5 Works with ATI MacOS NDRV, MorphOS and Linux radeonfb so hopefully this is good enough for now (each of these access DDC bits slightly differently). Version 4 try to fix an ASan warning about leaking bitbang_i2c. Version 3 keeps bitbang_i2c.h and moves it to include/hw

[Qemu-devel] [PATCH] deprecate -mem-path fallback to anonymous RAM

2019-06-20 Thread Igor Mammedov
Fallback might affect guest or worse whole host performance or functionality if backing file were used to share guest RAM with another process. Patch deprecates fallback so that we could remove it in future and ensure that QEMU will provide expected behavior and fail if it can't use user provided

Re: [Qemu-devel] [PATCH v1 12/17] tests/vm: freebsd autoinstall, using serial console

2019-06-20 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 6/19/19 9:40 PM, Alex Bennée wrote: >> From: Gerd Hoffmann >> >> Instead of fetching the prebuilt image from patchew download the install >> iso and prepare the image locally. Install to disk, using the serial >> console. Create qemu user, configure ssh lo

[Qemu-devel] [PATCH v5 1/2] i2c: Move bitbang_i2c.h to include/hw/i2c/

2019-06-20 Thread BALATON Zoltan
The bitbang i2c implementation is also useful for other device models such as DDC in display controllers. Move the header to include/hw/i2c/ to allow it to be used from other device models and adjust users of this include. This also reverts commit 2b4c1125ac which is no longer needed. Signed-off-b

Re: [Qemu-devel] [PATCH] Makefile: Rename the 'vm-test' target as 'vm-help'

2019-06-20 Thread Philippe Mathieu-Daudé
Hi Stefano, On 5/31/19 9:38 AM, Stefano Garzarella wrote: > On Fri, May 31, 2019 at 08:43:41AM +0200, Philippe Mathieu-Daudé wrote: >> We already have 'make check-help', use the 'make vm-help' form >> to display helps about VM testing. Keep the old target to not >> bother old customs. >> >> Signed

[Qemu-devel] [PATCH v5 2/2] ati-vga: Implement DDC and EDID info from monitor

2019-06-20 Thread BALATON Zoltan
This adds DDC support to ati-vga and connects i2c-ddc to it. This allows at least MacOS with an ATI ndrv, Linux radeonfb and MorphOS to get monitor EDID info (although MorphOS splash screen is not displayed and radeonfb needs additional tables from vgabios-rv100). Xorg needs additional support from

[Qemu-devel] [PATCH v2 0/3] target/mips: Improve MSA tests

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic This series contains various improvements and additions of MSA ASE TCG tests. v1-v2: - added some tests from bit move group - improved and updated commit messages Aleksandar Markovic (3): tests/tcg: target/mips: Include isa/ase and group name in test output te

[Qemu-devel] [PATCH v2 3/3] tests/tcg: target/mips: Add tests for MSA bit move instructions

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic Add tests for MSA bit move instructions. Signed-off-by: Aleksandar Markovic --- tests/tcg/mips/include/wrappers_msa.h | 6 + .../mips/user/ase/msa/bit-move/test_msa_bmnz_v.c | 214 + .../mips/user/ase/msa/bit-move/test_msa_bmz_v.c

[Qemu-devel] [PATCH v2 2/3] tests/tcg: target/mips: Amend tests for MSA pack instructions

2019-06-20 Thread Aleksandar Markovic
From: Aleksandar Markovic Add tests for cases when destination register is the same as one of source registers. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo --- tests/tcg/mips/include/wrappers_msa.h | 24 + .../tcg/mips/user/ase/msa/pack/test_msa_pcke

Re: [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes

2019-06-20 Thread Howard Spoelstra
Hi, As reported before, qemu-system-ppc still crashes with a segmentation fault on Lubuntu 16 on a G5. Built from current tcg-ppc-vsx branch. Linux hsp-G5-Lubuntu 4.4.0-143-powerpc64-smp #169-Ubuntu SMP Thu Feb 7 08:25:49 UTC 2019 ppc64 ppc64 ppc64 GNU/Linux hsp@hsp-G5-Lubuntu:~$ gcc -v Using bu

Re: [Qemu-devel] [PATCH] deprecate -mem-path fallback to anonymous RAM

2019-06-20 Thread Daniel P . Berrangé
On Thu, Jun 20, 2019 at 07:41:16AM -0400, Igor Mammedov wrote: > Fallback might affect guest or worse whole host performance > or functionality if backing file were used to share guest RAM > with another process. > > Patch deprecates fallback so that we could remove it in future > and ensure that

Re: [Qemu-devel] [PATCH v17 02/10] ACPI: add some GHES structures and macros definition

2019-06-20 Thread Igor Mammedov
On Tue, 14 May 2019 04:18:15 -0700 Dongjiu Geng wrote: > Add Generic Error Status Block structures and some macros > definitions, which is referred to the ACPI 4.0 or ACPI 6.2. The > HEST table generation and CPER record will use them. > > Signed-off-by: Dongjiu Geng > --- > include/hw/acpi/ac

Re: [Qemu-devel] [PATCH v3 2/4] hw/firmware: Add Edk2Crypto and edk2_add_host_crypto_policy()

2019-06-20 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 3/13/19 11:11 AM, Laszlo Ersek wrote: > On 03/13/19 10:43, Laszlo Ersek wrote: >> On 03/10/19 01:47, Philippe Mathieu-Daudé wrote: >>> The Edk2Crypto object is used to hold configuration values specific >>> to EDK2. >>> >>> The edk2_add_host_crypto_policy() function loads crypto poli

[Qemu-devel] [PATCH v5 3/3] hw/arm/virt: Use edk2_add_host_crypto_policy()

2019-06-20 Thread Philippe Mathieu-Daudé
Enable the EDK2 Crypto Policy features on the Virt machine. Reviewed-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 431e2900fd..15727b3d59 100644 --- a/hw/arm/virt.c +++

  1   2   3   4   >