[Qemu-devel] [PATCH 0/6] configure: Try to fix --static linking

2019-06-14 Thread Philippe Mathieu-Daudé
Hi, Apparently QEMU static linking is slowly bitroting. Obviously it depends the libraries an user has installed, anyway it seems there are not much testing done. This series fixes few issues, enough to build QEMU on a Ubuntu aarch64 host, but not yet on a x86_64 host: LINKx86_64-softmmu

[Qemu-devel] [PATCH 1/6] configure: Only generate GLUSTERFS variables if glusterfs is usable

2019-06-14 Thread Philippe Mathieu-Daudé
It is pointless and confusing to have GLUSTERFS variables in config-host.mak when glusterfs is not usable. Signed-off-by: Philippe Mathieu-Daudé --- configure | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/configure b/configure index b0

[Qemu-devel] [PATCH 2/6] configure: Link test before auto-enabling glusterfs libraries

2019-06-14 Thread Philippe Mathieu-Daudé
Similarly to commit a73e82ef912, test the libraries link correctly before considering them as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-aarch64-softmmu [...] LINKaarch64-softmmu/qemu-system-aarch64 /usr/bin/ld: cannot find -lgfapi /usr/bin/ld: ca

[Qemu-devel] [PATCH 4/6] configure: Link test before auto-enabling the libusbredir library

2019-06-14 Thread Philippe Mathieu-Daudé
Similarly to commit a73e82ef912, test the library links correctly before considering it as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-aarch64-softmmu [...] LINKaarch64-softmmu/qemu-system-aarch64 /usr/bin/ld: cannot find -lusbredirparser collect2:

[Qemu-devel] [PATCH 3/6] configure: Link test before auto-enabling the libusb library

2019-06-14 Thread Philippe Mathieu-Daudé
Similarly to commit a73e82ef912, test the library links correctly before considering it as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-aarch64-softmmu [...] LINKaarch64-softmmu/qemu-system-aarch64 /usr/bin/ld: cannot find -ludev collect2: error: ld

[Qemu-devel] [PATCH 5/6] configure: Link test before auto-enabling the pulseaudio library

2019-06-14 Thread Philippe Mathieu-Daudé
Similarly to commit a73e82ef912, test the library links correctly before considering it as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-aarch64-softmmu [...] LINKaarch64-softmmu/qemu-system-aarch64 /usr/bin/ld: cannot find -lpulse /usr/bin/ld: canno

[Qemu-devel] [PATCH 6/6] .travis.yml: Test static linking

2019-06-14 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- This job currently fails: LINKlm32-softmmu/qemu-system-lm32 /usr/bin/ld: cannot find -lgtk-3 /usr/bin/ld: cannot find -latk-bridge-2.0 /usr/bin/ld: cannot find -latspi /usr/bin/ld: cannot find -lsystemd /usr/bin/ld: cannot fi

Re: [Qemu-devel] [PATCH 1/6] configure: Only generate GLUSTERFS variables if glusterfs is usable

2019-06-14 Thread Niels de Vos
On Fri, Jun 14, 2019 at 09:24:27AM +0200, Philippe Mathieu-Daudé wrote: > It is pointless and confusing to have GLUSTERFS variables > in config-host.mak when glusterfs is not usable. > > Signed-off-by: Philippe Mathieu-Daudé Looks good to me, thanks. Reviewed-by: Niels de Vos > --- > configu

Re: [Qemu-devel] [RFC] virtio-rng: add a watchdog

2019-06-14 Thread Amit Shah
On Thu, 2019-06-13 at 10:53 +0200, Laurent Vivier wrote: > On 12/06/2019 09:03, Amit Shah wrote: > > On Tue, 2019-06-11 at 19:20 +0200, Laurent Vivier wrote: > > > The virtio-rng linux driver can be stuck in virtio_read() on a > > > wait_for_completion_killable() call if the virtio-rng device in >

Re: [Qemu-devel] [PATCH] MAINTAINERS: Change maintership of Xen code under hw/9pfs

2019-06-14 Thread Greg Kurz
On Wed, 5 Jun 2019 10:12:05 + Paul Durrant wrote: > > -Original Message- > > From: Greg Kurz [mailto:gr...@kaod.org] > > Sent: 05 June 2019 11:11 > > To: Anthony Perard > > Cc: qemu-devel@nongnu.org; Stefano Stabellini ; > > Paul Durrant > > > > Subject: Re: [PATCH] MAINTAINERS: Ch

Re: [Qemu-devel] [PATCH] MAINTAINERS: Change maintership of Xen code under hw/9pfs

2019-06-14 Thread Paul Durrant
> -Original Message- > From: Greg Kurz [mailto:gr...@kaod.org] > Sent: 14 June 2019 09:16 > To: Paul Durrant > Cc: Anthony Perard ; qemu-devel@nongnu.org; > Stefano Stabellini > > Subject: Re: [PATCH] MAINTAINERS: Change maintership of Xen code under hw/9pfs > > On Wed, 5 Jun 2019 10:12

Re: [Qemu-devel] [PATCH v3 11/15] monitor: Split out monitor/hmp.c

2019-06-14 Thread Markus Armbruster
Kevin Wolf writes: > Move HMP infrastructure from monitor/misc.c to monitor/hmp.c. This is > code that can be shared for all targets, so compile it only once. > > The amount of function and particularly extern variables in > monitor_int.h is probably a bit larger than it needs to be, but this way

Re: [Qemu-devel] [PATCH v3 12/15] monitor: Split out monitor/monitor.c

2019-06-14 Thread Markus Armbruster
Kevin Wolf writes: > Move the monitor core infrastructure from monitor/misc.c to > monitor/monitor.c. This is code that can be shared for all targets, so > compile it only once. > > What remains in monitor/misc.c after this patch is mostly monitor > command implementations (which could move to hm

Re: [Qemu-devel] [PATCH] [RFC] Add a eBPF-capable PCIe device

2019-06-14 Thread Stefan Hajnoczi
On Mon, Jun 03, 2019 at 02:58:26PM -0600, Martin Ichilevici de Oliveira wrote: Thanks for sharing! The bpf_ram accesses are unsafe. The guest can modify bpf_ram while the device is accessing it. This is likely to cause security problems. I think a model is required where the device copies in t

Re: [Qemu-devel] [PATCH 1/1] tcg: Fix typos in helper_gvec_sar{8, 32, 64}v

2019-06-14 Thread Peter Maydell
On Fri, 14 Jun 2019 at 07:09, Aleksandar Markovic wrote: > Peter, would you please explain to me what was going on with this patch? The original patch was posted to the list on the 7th June; it got reviewed and tested by Laurent. This email accidentally has "PATCH" in the subject line instead of

Re: [Qemu-devel] [PATCH] docs/vhost-user.json: some firmware.json copy leftovers

2019-06-14 Thread Stefan Hajnoczi
On Wed, Jun 05, 2019 at 03:12:21PM +0200, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > docs/interop/vhost-user.json | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH 2/6] configure: Link test before auto-enabling glusterfs libraries

2019-06-14 Thread Philippe Mathieu-Daudé
On 6/14/19 9:24 AM, Philippe Mathieu-Daudé wrote: > Similarly to commit a73e82ef912, test the libraries link correctly > before considering them as usable. > > This fixes using ./configure --static on Ubuntu 18.04: > > $ make subdir-aarch64-softmmu > [...] > LINKaarch64-softmmu/qemu-s

Re: [Qemu-devel] [PATCH v3 09/15] monitor: Create monitor-internal.h with common definitions

2019-06-14 Thread Kevin Wolf
Am 14.06.2019 um 08:37 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Before we can split monitor/misc.c, we need to create a header file that > > contains the common definitions that will be used by multiple source > > files. > > > > For a start, add the type definitions for Monit

Re: [Qemu-devel] [PATCH 0/6] configure: Try to fix --static linking

2019-06-14 Thread Philippe Mathieu-Daudé
On 6/14/19 9:24 AM, Philippe Mathieu-Daudé wrote: > Hi, > > Apparently QEMU static linking is slowly bitroting. Obviously it > depends the libraries an user has installed, anyway it seems there > are not much testing done. > > This series fixes few issues, enough to build QEMU on a Ubuntu > aarch

Re: [Qemu-devel] [PATCH v3 13/15] monitor: Split Monitor.flags into separate bools

2019-06-14 Thread Markus Armbruster
Kevin Wolf writes: > Monitor.flags contains three different flags: One to distinguish HMP > from QMP; one specific to HMP (MONITOR_USE_READLINE) that is ignored > with QMP; and another one specific to QMP (MONITOR_USE_PRETTY) that is > ignored with HMP. > > Split the flags field into three bools

Re: [Qemu-devel] [PATCH v3 14/15] monitor: Replace monitor_init() with monitor_init_{hmp, qmp}()

2019-06-14 Thread Markus Armbruster
Kevin Wolf writes: > Most callers know which monitor type they want to have. Instead of > calling monitor_init() with flags that can describe both types of > monitors, make monitor_init_{hmp,qmp}() public interfaces that take > specific bools instead of flags and call these functions directly. >

Re: [Qemu-devel] [PATCH v3 02/15] monitor: Split monitor_init in HMP and QMP function

2019-06-14 Thread Markus Armbruster
Kevin Wolf writes: > Instead of mixing HMP and QMP monitors in the same function, separate > the monitor creation function for both. > > While in theory, one could pass both MONITOR_USE_CONTROL and > MONITOR_USE_READLINE before this patch and both flags would do > something, readline support is t

Re: [Qemu-devel] [PATCH 0/6] configure: Try to fix --static linking

2019-06-14 Thread Peter Maydell
On Fri, 14 Jun 2019 at 08:27, Philippe Mathieu-Daudé wrote: > Apparently QEMU static linking is slowly bitroting. Obviously it > depends the libraries an user has installed, anyway it seems there > are not much testing done. The main reason for supporting static linking is so we can build the use

Re: [Qemu-devel] [PATCH v3 03/15] monitor: Make MonitorQMP a child class of Monitor

2019-06-14 Thread Markus Armbruster
Kevin Wolf writes: > Currently, struct Monitor mixes state that is only relevant for HMP, > state that is only relevant for QMP, and some actually shared state. > In particular, a MonitorQMP field is present in the state of any > monitor, even if it's not a QMP monitor and therefore doesn't use t

Re: [Qemu-devel] [PATCH v3 04/15] monitor: Create MonitorHMP with readline state

2019-06-14 Thread Markus Armbruster
Kevin Wolf writes: > The ReadLineState in Monitor is only used for HMP monitors. Create > MonitorHMP and move it there. > > Signed-off-by: Kevin Wolf > Reviewed-by: Dr. David Alan Gilbert > --- > include/monitor/monitor.h | 5 +- > hmp.c | 4 +- > monitor.c

Re: [Qemu-devel] [PATCH v3 15/15] vl: Deprecate -mon pretty=... for HMP monitors

2019-06-14 Thread Markus Armbruster
Kevin Wolf writes: > The -mon pretty=on|off switch of the -mon option applies only the QMP > monitors. It used to be silently ignored for HMP. Deprecate this > combination so that we can make it an error in future versions. > > Signed-off-by: Kevin Wolf > --- > vl.c | 10 +++

Re: [Qemu-devel] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-14 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 18:57, Max Reitz wrote: > On 29.05.19 17:46, Vladimir Sementsov-Ogievskiy wrote: >> Backup-top filter does copy-before-write operation. It should be >> inserted above active disk and has a target node for CBW, like the >> following: >> >> +---+ >> | Guest | >> +---

Re: [Qemu-devel] [PULL 0/3] vfio updates 2019-06-13

2019-06-14 Thread Peter Maydell
On Thu, 13 Jun 2019 at 22:41, Alex Williamson wrote: > > The following changes since commit 650a379d505bf558bcb41124bc6c951a76cbc113: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190613-1' into staging (2019-06-13 > 15:16:39 +0100) > > are available in the Git re

Re: [Qemu-devel] [PATCH v3 00/15] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-14 Thread Markus Armbruster
Kevin Wolf writes: > monitor.c mixes a lot of different things in a single file: The core > monitor infrastructure, HMP infrastrcture, QMP infrastructure, and the > implementation of several HMP and QMP commands. Almost worse, struct > Monitor mixes state for HMP, for QMP, and state actually shar

Re: [Qemu-devel] [PATCH 0/2] qemu-tech: move part to docs/devel, delete part

2019-06-14 Thread Stefan Hajnoczi
On Fri, Jun 07, 2019 at 04:28:25PM +0100, Peter Maydell wrote: > This patchset makes some of the cleanups to qemu-tech.texi which > I suggested in my Sphinx transition plan: > https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg04932.html > > (1) the "translator internals" docs move to the de

Re: [Qemu-devel] [PATCH v3 15/15] vl: Deprecate -mon pretty=... for HMP monitors

2019-06-14 Thread Kevin Wolf
Am 14.06.2019 um 11:01 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > The -mon pretty=on|off switch of the -mon option applies only the QMP s/the QMP/to QMP/ Can you fix up this one as well while you're at it? > > monitors. It used to be silently ignored for HMP. Deprecate this

Re: [Qemu-devel] [PATCH v3 11/15] monitor: Split out monitor/hmp.c

2019-06-14 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Kevin Wolf writes: > > > Move HMP infrastructure from monitor/misc.c to monitor/hmp.c. This is > > code that can be shared for all targets, so compile it only once. > > > > The amount of function and particularly extern variables in > > monitor_int

Re: [Qemu-devel] [PATCH v1 2/4] disas/riscv: Disassemble reserved compressed encodings as illegal

2019-06-14 Thread Palmer Dabbelt
On Fri, 17 May 2019 15:11:01 PDT (-0700), Alistair Francis wrote: From: Michael Clark Due to the design of the disassembler, the immediate is not known during decoding of the opcode; so to handle compressed encodings with reserved immediate values (non-zero), we need to add an additional check

Re: [Qemu-devel] [PATCH v8 7/7] block/backup: use backup-top instead of write notifiers

2019-06-14 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 21:02, Max Reitz wrote: > On 29.05.19 17:46, Vladimir Sementsov-Ogievskiy wrote: >> Drop write notifiers and use filter node instead. Changes: >> >> 1. copy-before-writes now handled by filter node, so, drop all >> is_write_notifier arguments. >> >> 2. we don't have intersecting requ

Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs

2019-06-14 Thread Stefan Hajnoczi
On Tue, Jun 11, 2019 at 05:35:17PM -0700, Raphael Norwitz wrote: > Of the 3 virtqueues, seabios only sets cmd, leaving ctrl > and event without a physical address. This can cause > vhost_verify_ring_part_mapping to return ENOMEM, causing > the following logs: > > qemu-system-x86_64: Unable to map

Re: [Qemu-devel] [PATCH qemu] loader: Trace loaded images

2019-06-14 Thread Stefan Hajnoczi
On Fri, Jun 14, 2019 at 10:13:04AM +1000, Alexey Kardashevskiy wrote: > > > On 13/06/2019 23:08, Philippe Mathieu-Daudé wrote: > > Hi Alexey, > > > > On 6/13/19 7:09 AM, Alexey Kardashevskiy wrote: > >> This adds a trace point which prints every loaded image. This includes > >> bios/firmware/ker

[Qemu-devel] [PATCH] block/replication.c: Fix crash issue after failover

2019-06-14 Thread Zhang Chen
From: Zhang Chen No block job on active disk after failover. In the replication_stop() function have canceled the block job, we check it again here. Signed-off-by: Zhang Chen --- block/replication.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/replication.c b/bl

Re: [Qemu-devel] [PATCH v3 00/15] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-14 Thread Kevin Wolf
Am 14.06.2019 um 11:06 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > monitor.c mixes a lot of different things in a single file: The core > > monitor infrastructure, HMP infrastrcture, QMP infrastructure, and the > > implementation of several HMP and QMP commands. Almost worse, st

[Qemu-devel] [PATCH v3 1/5] virtio: add "use-started" property

2019-06-14 Thread elohimes
From: Xie Yongji In order to avoid migration issues, we introduce a "use-started" property to the base virtio device to indicate whether use "started" flag or not. This property will be true by default and set to false when machine type <= 4.0.1. Suggested-by: Greg Kurz Signed-off-by: Xie Yongj

[Qemu-devel] [PATCH v3 3/5] virtio: Set "start_on_kick" on virtio_set_features()

2019-06-14 Thread elohimes
From: Xie Yongji The guest feature is not set correctly on virtio_reset() and virtio_init(). So we should not use it to set "start_on_kick" at that point. This patch set "start_on_kick" on virtio_set_features() instead. Fixes: badaf79cfdbd3 ("virtio: Introduce started flag to VirtioDevice") Sign

[Qemu-devel] [PATCH v3 4/5] virtio: Make sure we get correct state of device on handle_aio_output()

2019-06-14 Thread elohimes
From: Xie Yongji We should set the flags: "start_on_kick" and "started" after we call the kick functions (handle_aio_output() and handle_output()). Signed-off-by: Xie Yongji --- hw/virtio/virtio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio.c b/hw

Re: [Qemu-devel] Virtual I2C adapter and I2C external simulator

2019-06-14 Thread Stefan Hajnoczi
On Thu, Jun 13, 2019 at 10:53:16AM -0700, Rahul Govind wrote: > Hi Everyone, > > I'm working on a project that involves building on top of existing QEMU > work, and I'm trying to virtualize I2C devices that are shared between > multiple VMs. I've been reading QEMU documentation and source code to

[Qemu-devel] [PATCH v3 0/5] virtio: fix some issues of "started" and "start_on_kick" flag

2019-06-14 Thread elohimes
From: Xie Yongji We introduced two flags "started" and "start_on_kick" to indicate virtio device's state before. But there still are some problems with them. So we try to fixup them in this patchset. The patch 1 introduces a "use-started" property to avoid a migration issue under Greg Kurz's sug

[Qemu-devel] [PATCH v3 5/5] virtio: Don't change "started" flag on virtio_vmstate_change()

2019-06-14 Thread elohimes
From: Xie Yongji We will call virtio_set_status() on virtio_vmstate_change(). The "started" flag should not be changed in this case. Otherwise, we may get an incorrect value when we set "started" flag but not set DRIVER_OK in source VM. Signed-off-by: Xie Yongji --- hw/virtio/virtio.c | 5

[Qemu-devel] [PATCH] vfio-ccw: use vfio_set_irq_signaling

2019-06-14 Thread Cornelia Huck
Use the new helper. Signed-off-by: Cornelia Huck --- hw/vfio/ccw.c | 68 +++ 1 file changed, 14 insertions(+), 54 deletions(-) diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c index 03a2becb3ec9..3dc08721a3db 100644 --- a/hw/vfio/ccw.c +++ b/hw/vfio/ccw

Re: [Qemu-devel] [PATCH 1/2] vl: Drain before (block) job cancel when quitting

2019-06-14 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 19:03, Max Reitz wrote: > [re-adding the original CCs, why not] > > On 13.06.19 16:30, Vladimir Sementsov-Ogievskiy wrote: >> 13.06.2019 17:21, Max Reitz wrote: >>> On 13.06.19 16:19, Vladimir Sementsov-Ogievskiy wrote: 13.06.2019 1:08, Max Reitz wrote: > If the main loop cance

[Qemu-devel] [PATCH v3 2/5] virtio: Set "start_on_kick" for legacy devices

2019-06-14 Thread elohimes
From: Xie Yongji Besides virtio 1.0 transitional devices, we should also set "start_on_kick" flag for legacy devices (virtio 0.9). Signed-off-by: Xie Yongji --- hw/virtio/virtio.c | 6 ++ include/hw/virtio/virtio.h | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --gi

Re: [Qemu-devel] [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface

2019-06-14 Thread Sam Eiderman
> On 14 Jun 2019, at 7:43, Gerd Hoffmann wrote: > > Hi, > >> Can there be a guest that will fail the MBR in such a way? Yes. >> Look at the following MBR partition table of a Windows XP guest in our >> production >> environment: >> >> Disk size in sectors: 16777216 >> >> Binary (only one

Re: [Qemu-devel] [PATCH] iotests: Hide timestamps for skipped tests

2019-06-14 Thread Kevin Wolf
Am 13.06.2019 um 20:37 hat Max Reitz geschrieben: > Currently, the "thistime" variable is not reinitialized on every loop > iteration. This leads to tests that do not yield a run time (because > they failed or were skipped) printing the run time of the previous test > that did. Fix that by reinit

Re: [Qemu-devel] [PATCH v1 3/4] disas/riscv: Fix `rdinstreth` constraint

2019-06-14 Thread Palmer Dabbelt
On Fri, 17 May 2019 15:11:04 PDT (-0700), Alistair Francis wrote: From: Michael Clark The constraint for `rdinstreth` was comparing the csr number to 0xc80, which is `cycleh` instead. Fix this. Author: Wladimir J. van der Laan I'm not sure what this tag is supposed to mean. If this is the

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-14 Thread Kevin Wolf
Am 13.06.2019 um 21:41 hat Stefan Weil geschrieben: > On 12.06.19 15:27, Philippe Mathieu-Daudé wrote: > > Cc'ing Alex (Docker, Travis) and Stefan (MinGW) > [...] > > Note, libssh is not available on MinGW. > > Nor is it available for Mingw64: > > https://cygwin.com/cgi-bin2/package-grep.cgi?grep

Re: [Qemu-devel] [PATCH v1 4/4] target/riscv: Implement riscv_cpu_unassigned_access

2019-06-14 Thread Palmer Dabbelt
On Fri, 17 May 2019 15:11:06 PDT (-0700), Alistair Francis wrote: From: Michael Clark This patch adds support for the riscv_cpu_unassigned_access call and will raise a load or store access fault. Signed-off-by: Michael Clark [Changes by AF: - Squash two patches and rewrite commit message -

Re: [Qemu-devel] [PATCH v1 0/4] Miscellaneous patches from the RISC-V fork

2019-06-14 Thread Palmer Dabbelt
On Fri, 17 May 2019 15:10:56 PDT (-0700), Alistair Francis wrote: This should be the last series bringing the patches from the RISC-V fork into mainline QEMU. Dayeol Lee (1): target/riscv: Fix PMP range boundary address bug Michael Clark (3): disas/riscv: Disassemble reserved compressed enc

[Qemu-devel] [PATCH v2 0/9] configure: Fix softmmu --static linking

2019-06-14 Thread Philippe Mathieu-Daudé
Hi, Apparently QEMU static linking is slowly bitroting. Obviously it depends the libraries an user has installed, anyway it seems there are not much testing done. This series fixes few issues, enough to build QEMU on a Ubuntu 18.04 host. Peter commented on v1: The main reason for supporting s

[Qemu-devel] [PATCH v2 4/9] configure: Link test before auto-enabling libusbredir library

2019-06-14 Thread Philippe Mathieu-Daudé
Similarly to commit a73e82ef912, test the library links correctly before considering it as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-aarch64-softmmu [...] LINKaarch64-softmmu/qemu-system-aarch64 /usr/bin/ld: cannot find -lusbredirparser collect2:

[Qemu-devel] [PATCH v2 1/9] configure: Only generate GLUSTERFS variables if glusterfs is usable

2019-06-14 Thread Philippe Mathieu-Daudé
It is pointless and confusing to have GLUSTERFS variables in config-host.mak when glusterfs is not usable. Reviewed-by: Niels de Vos Signed-off-by: Philippe Mathieu-Daudé --- configure | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/con

[Qemu-devel] [PATCH v2 5/9] configure: Link test before auto-enabling PulseAudio library

2019-06-14 Thread Philippe Mathieu-Daudé
Similarly to commit a73e82ef912, test the library links correctly before considering it as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-aarch64-softmmu [...] LINKaarch64-softmmu/qemu-system-aarch64 /usr/bin/ld: cannot find -lpulse /usr/bin/ld: canno

[Qemu-devel] [PATCH v2 2/9] configure: Link test before auto-enabling GlusterFS libraries

2019-06-14 Thread Philippe Mathieu-Daudé
Similarly to commit a73e82ef912, test the libraries link correctly before considering them as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-aarch64-softmmu [...] LINKaarch64-softmmu/qemu-system-aarch64 /usr/bin/ld: cannot find -lgfapi /usr/bin/ld: ca

[Qemu-devel] [PATCH v2 3/9] configure: Link test before auto-enabling libusb library

2019-06-14 Thread Philippe Mathieu-Daudé
Similarly to commit a73e82ef912, test the library links correctly before considering it as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-aarch64-softmmu [...] LINKaarch64-softmmu/qemu-system-aarch64 /usr/bin/ld: cannot find -ludev collect2: error: ld

[Qemu-devel] [PATCH v2 8/9] tests/docker: Kludge for missing libunistring.so symlink on Ubuntu 18.04

2019-06-14 Thread Philippe Mathieu-Daudé
When linking statically on Ubuntu 18.04 we get: $ make subdir-x86_64-softmmu [...] LINKx86_64-softmmu/qemu-system-x86_64 c++: error: /usr/lib/x86_64-linux-gnu/libunistring.so: No such file or directory This library is pulled in by GTK: $ pkg-config --libs --static gtk+-3.0 -l

[Qemu-devel] [PATCH v2 6/9] configure: Link test before auto-enabling OpenGL libraries

2019-06-14 Thread Philippe Mathieu-Daudé
Similarly to commit a73e82ef912, test the libraries link correctly before considering them as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-lm32-softmmu [...] LINKlm32-softmmu/qemu-system-lm32 /usr/bin/ld: cannot find -lepoxy /usr/bin/ld: cannot find -

[Qemu-devel] [PATCH v2 7/9] configure: Link test before auto-enabling GTK libraries

2019-06-14 Thread Philippe Mathieu-Daudé
Similarly to commit a73e82ef912, test the libraries link correctly before considering them as usable. This fixes using ./configure --static on Ubuntu 18.04: $ make subdir-lm32-softmmu [...] LINKlm32-softmmu/qemu-system-lm32 /usr/bin/ld: cannot find -lgtk-3 /usr/bin/ld: cannot find -

Re: [Qemu-devel] [PATCH] block/replication.c: Fix crash issue after failover

2019-06-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190614092853.26551-1-chen.zh...@intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash ma

Re: [Qemu-devel] [PATCH] block/replication.c: Fix crash issue after failover

2019-06-14 Thread Kevin Wolf
Am 14.06.2019 um 11:28 hat Zhang Chen geschrieben: > From: Zhang Chen > > No block job on active disk after failover. > In the replication_stop() function have canceled the block job, > we check it again here. > > Signed-off-by: Zhang Chen > --- > block/replication.c | 4 +++- > 1 file changed

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-14 Thread Philippe Mathieu-Daudé
On 6/14/19 11:42 AM, Kevin Wolf wrote: > Am 13.06.2019 um 21:41 hat Stefan Weil geschrieben: >> On 12.06.19 15:27, Philippe Mathieu-Daudé wrote: >>> Cc'ing Alex (Docker, Travis) and Stefan (MinGW) >> [...] >>> Note, libssh is not available on MinGW. >> >> Nor is it available for Mingw64: Yes, by "

Re: [Qemu-devel] [PATCH 0/4] block: drop bs->job

2019-06-14 Thread Kevin Wolf
Am 06.06.2019 um 17:41 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > These series follow Kevin's suggestions under > https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg00670.html > [Qemu-devel] [PATCH v2 0/2] introduce pinned blk > (hope you don't mind me using exactly your wo

Re: [Qemu-devel] [PATCH] roms/edk2-build.sh: Allow to run edk2-build.sh from command line

2019-06-14 Thread Philippe Mathieu-Daudé
Cc'ing Eric :) On 6/13/19 7:54 PM, Philippe Mathieu-Daudé wrote: > The edk2-build.sh script set the 'nounset' option: > > BASH(1) > > set [arg ...] > > -u Treat unset variables and parameters other than the >special parameters "@" and "*" as an error when >pe

Re: [Qemu-devel] [PATCH qemu] loader: Trace loaded images

2019-06-14 Thread Philippe Mathieu-Daudé
On 6/14/19 11:33 AM, Stefan Hajnoczi wrote: > On Fri, Jun 14, 2019 at 10:13:04AM +1000, Alexey Kardashevskiy wrote: >> >> >> On 13/06/2019 23:08, Philippe Mathieu-Daudé wrote: >>> Hi Alexey, >>> >>> On 6/13/19 7:09 AM, Alexey Kardashevskiy wrote: This adds a trace point which prints every load

[Qemu-devel] [PATCH v2 9/9] .travis.yml: Test softmmu static linking

2019-06-14 Thread Philippe Mathieu-Daudé
Add a test to avoid the ./configure script to bitrot. Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/.travis.yml b/.travis.yml index 08502c0aa2..6962fff826 100644 --- a/.travis.yml +++ b/.travis.yml @@ -92,6 +92,11 @@ matrix:

[Qemu-devel] [PATCH 0/2] target/arm: Support single-precision only FPUs

2019-06-14 Thread Peter Maydell
The Arm architecture permits FPUs which have only single-precision support, not double-precision; Cortex-M4 and Cortex-M33 are both like that. Now that we've refactored the VFP code to use decodetree it's fairly easy to add the necessary checks on the MVFR0 FPDP field so that we UNDEF any double-pr

[Qemu-devel] [PATCH 1/2] target/arm: Fix typos in trans function prototypes

2019-06-14 Thread Peter Maydell
In several places cut and paste errors meant we were using the wrong type for the 'arg' struct in trans_ functions called by the decodetree decoder, because we were using the _sp version of the struct in the _dp function. These were harmless, because the two structs were identical and so decodetre

[Qemu-devel] [PATCH 2/2] target/arm: Only implement doubles if the FPU supports them

2019-06-14 Thread Peter Maydell
The architecture permits FPUs which have only single-precision support, not double-precision; Cortex-M4 and Cortex-M33 are both like that. Add the necessary checks on the MVFR0 FPDP field so that we UNDEF any double-precision instructions on CPUs like this. Note that even if FPDP==0 the insns like

Re: [Qemu-devel] [PATCH v3 15/15] vl: Deprecate -mon pretty=... for HMP monitors

2019-06-14 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.06.2019 um 11:01 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > The -mon pretty=on|off switch of the -mon option applies only the QMP > > s/the QMP/to QMP/ > > Can you fix up this one as well while you're at it? Sure! >> > monitors. It used to be s

[Qemu-devel] [PATCH 7/7] target/ppc/machine: Add kvmppc_pvr_workaround_required() stub

2019-06-14 Thread Greg Kurz
This allows to drop the CONFIG_KVM guard from the code. Signed-off-by: Greg Kurz --- target/ppc/kvm_ppc.h |5 + target/ppc/machine.c |2 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/target/ppc/kvm_ppc.h b/target/ppc/kvm_ppc.h index e642aaaf9226..98bd7d5da6d6 1006

[Qemu-devel] [PATCH 1/7] spapr_pci: Drop useless CONFIG_KVM ifdefery

2019-06-14 Thread Greg Kurz
kvm_enabled() expands to (0) when CONFIG_KVM is not defined. Signed-off-by: Greg Kurz --- hw/ppc/spapr_pci.c |2 -- 1 file changed, 2 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index fbeb1c90ee6c..00d9f2cfe464 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @

[Qemu-devel] [PATCH 5/7] hw/ppc: Drop useless CONFIG_KVM ifdefery

2019-06-14 Thread Greg Kurz
kvmppc_set_interrupt() has a stub that does nothing when CONFIG_KVM is not defined. Signed-off-by: Greg Kurz --- hw/ppc/ppc.c |2 -- 1 file changed, 2 deletions(-) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index 9d91e8481b32..288196dfa67a 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -80,9

[Qemu-devel] [PATCH 4/7] hw/ppc/prep: Drop useless CONFIG_KVM ifdefery

2019-06-14 Thread Greg Kurz
kvm_enabled() expands to (0) when CONFIG_KVM is not defined. It is likely that the compiler will optimize the code out. And even if it doesn't, we have a stub for kvmppc_get_hypercall(). Signed-off-by: Greg Kurz --- hw/ppc/prep.c |2 -- 1 file changed, 2 deletions(-) diff --git a/hw/ppc/pre

[Qemu-devel] [PATCH 0/7] ppc: Get rid of some CONFIG_KVM guards

2019-06-14 Thread Greg Kurz
There are several places where CONFIG_KVM is used to guard code that should only be built when KVM is supported. It is generally preferable to avoid that and leave such guards in header files for improved readability. In many cases, the execution of the code is also conditionned by kvm_enabled() w

[Qemu-devel] [PATCH 6/7] ppc: Introduce kvmppc_set_reg_tb_offset() helper

2019-06-14 Thread Greg Kurz
Introduce a KVM helper and its stub instead of guarding the code with CONFIG_KVM. Signed-off-by: Greg Kurz --- hw/ppc/ppc.c |5 + target/ppc/kvm.c |9 + target/ppc/kvm_ppc.h |5 + 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/hw/ppc/ppc.c

[Qemu-devel] [PATCH 2/7] hw/ppc/mac_oldworld: Drop useless CONFIG_KVM ifdefery

2019-06-14 Thread Greg Kurz
kvm_enabled() expands to (0) when CONFIG_KVM is not defined. It is likely that the compiler will optimize the code out. And even if it doesn't, we have a stub for kvmppc_get_hypercall(). Signed-off-by: Greg Kurz --- hw/ppc/mac_oldworld.c |2 -- 1 file changed, 2 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 3/7] hw/ppc/mac_newworld: Drop useless CONFIG_KVM ifdefery

2019-06-14 Thread Greg Kurz
kvm_enabled() expands to (0) when CONFIG_KVM is not defined. The first CONFIG_KVM guard is thus useless and it is likely that the compiler will optimize the code out in the case of the second guard. And even if it doesn't, we have a stub for kvmppc_get_hypercall(). Signed-off-by: Greg Kurz --- h

Re: [Qemu-devel] [PATCH v4 5/6] migration: Make no compression operations into its own structure

2019-06-14 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It will be used later. > > Signed-off-by: Juan Quintela > > --- > Move setup of ->ops helper to proper place (wei) > Rename s/none/nocomp/ (dave) > --- > migration/migration.c | 9 ++ > migration/migration.h | 1 + > migration/ram.c | 188

Re: [Qemu-devel] [PATCH v3 1/5] virtio: add "use-started" property

2019-06-14 Thread Greg Kurz
On Fri, 14 Jun 2019 17:31:17 +0800 elohi...@gmail.com wrote: > From: Xie Yongji > > In order to avoid migration issues, we introduce a "use-started" > property to the base virtio device to indicate whether use > "started" flag or not. This property will be true by default and > set to false when

Re: [Qemu-devel] [PATCH v1 2/2] s390x/cpumodel: Prepend KDSA features with "KDSA"

2019-06-14 Thread Cornelia Huck
On Wed, 12 Jun 2019 15:25:26 +0200 David Hildenbrand wrote: > Let's handle it just like for other crypto features. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu_features_def.inc.h | 30 ++--- > target/s390x/gen-features.c | 30 ++-

Re: [Qemu-devel] [PATCH for 4.1 v3] target/riscv: Expose time CSRs when allowed by [m|s]counteren

2019-06-14 Thread Palmer Dabbelt
On Tue, 28 May 2019 11:30:20 PDT (-0700), jonat...@fintelia.io wrote: Currently mcounteren.TM acts as though it is hardwired to zero, even though QEMU allows it to be set. This change resolves the issue by allowing reads to the time and timeh control registers when running in a privileged mode

Re: [Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition

2019-06-14 Thread Cornelia Huck
On Wed, 12 Jun 2019 15:25:24 +0200 David Hildenbrand wrote: > Rework the feature initialization, making it harder to make mistakes. > While at it, rename the enum names of the KDSA features. > > David Hildenbrand (2): > s390x/cpumodel: Rework CPU feature definition > s390x/cpumodel: Prepend

Re: [Qemu-devel] [PATCH v1 1/2] s390x/cpumodel: Rework CPU feature definition

2019-06-14 Thread Cornelia Huck
On Wed, 12 Jun 2019 15:25:25 +0200 David Hildenbrand wrote: > Let's define features at a single spot and make it less error prone to > define new features. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu_features.c | 352 +- > target/s390x/cpu_feat

Re: [Qemu-devel] [PATCH 13/19] aspeed/smc: add a 'sdram_base' propertie

2019-06-14 Thread Cédric Le Goater
On 13/06/2019 16:32, Philippe Mathieu-Daudé wrote: > On 5/25/19 5:12 PM, Cédric Le Goater wrote: >> The DRAM address of a DMA transaction depends on the DRAM base address >> of the SoC. Inform the SMC controller model of this value. > > I'd reorder this one previous patch #16 "aspeed/smc: add supp

Re: [Qemu-devel] [PATCH 18/19] aspeed/smc: inject errors in DMA checksum

2019-06-14 Thread Cédric Le Goater
On 13/06/2019 16:31, Philippe Mathieu-Daudé wrote: > Hi Cédric, > > On 5/25/19 5:12 PM, Cédric Le Goater wrote: >> Emulate read errors in the DMA Checksum Register for high frequencies >> and optimistic settings of the Read Timing Compensation Register. This >> will help in tuning the SPI timing c

Re: [Qemu-devel] [PULL 01/29] SiFive RISC-V GPIO Device

2019-06-14 Thread Palmer Dabbelt
On Thu, 30 May 2019 03:57:12 PDT (-0700), Peter Maydell wrote: On Sun, 26 May 2019 at 02:10, Palmer Dabbelt wrote: From: Fabien Chouteau QEMU model of the GPIO device on the SiFive E300 series SOCs. The pins are not used by a board definition yet, however this implementation can already be

Re: [Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition

2019-06-14 Thread David Hildenbrand
On 14.06.19 13:49, Cornelia Huck wrote: > On Wed, 12 Jun 2019 15:25:24 +0200 > David Hildenbrand wrote: > >> Rework the feature initialization, making it harder to make mistakes. >> While at it, rename the enum names of the KDSA features. >> >> David Hildenbrand (2): >> s390x/cpumodel: Rework C

Re: [Qemu-devel] [PATCH v5 13/42] block: Use CAFs in block status functions

2019-06-14 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 1:09, Max Reitz wrote: > Use the child access functions in the block status inquiry functions as > appropriate. > > Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition

2019-06-14 Thread David Hildenbrand
On 12.06.19 15:25, David Hildenbrand wrote: > Rework the feature initialization, making it harder to make mistakes. > While at it, rename the enum names of the KDSA features. > > David Hildenbrand (2): > s390x/cpumodel: Rework CPU feature definition > s390x/cpumodel: Prepend KDSA features with

[Qemu-devel] [PATCH] RISC-V: Fix a memory leak when realizing a sifive_e

2019-06-14 Thread Palmer Dabbelt
Coverity pointed out a memory leak in riscv_sifive_e_soc_realize(), where a pair of recently added MemoryRegion instances would not be freed if there were errors elsewhere in the function. The fix here is to simply not use dynamic allocation for these instances: there's always one of each in SiFiv

Re: [Qemu-devel] [PATCH v2] hw: misc: Add Aspeed XDMA device

2019-06-14 Thread Cédric Le Goater
On 11/06/2019 22:54, Eddie James wrote: > The XDMA engine embedded in the Aspeed SOCs performs PCI DMA operations > between the SOC (acting as a BMC) and a host processor in a server. > > The XDMA engine exists on the AST2400, AST2500, and AST2600 SOCs, so > enable it for all of those. Add trace e

Re: [Qemu-devel] [PATCH] RISC-V: Fix a memory leak when realizing a sifive_e

2019-06-14 Thread Philippe Mathieu-Daudé
On 6/14/19 2:08 PM, Palmer Dabbelt wrote: > Coverity pointed out a memory leak in riscv_sifive_e_soc_realize(), > where a pair of recently added MemoryRegion instances would not be freed > if there were errors elsewhere in the function. The fix here is to > simply not use dynamic allocation for th

Re: [Qemu-devel] [PATCH v2] hw: misc: Add Aspeed XDMA device

2019-06-14 Thread Philippe Mathieu-Daudé
On 6/14/19 2:10 PM, Cédric Le Goater wrote: > On 11/06/2019 22:54, Eddie James wrote: >> The XDMA engine embedded in the Aspeed SOCs performs PCI DMA operations >> between the SOC (acting as a BMC) and a host processor in a server. >> >> The XDMA engine exists on the AST2400, AST2500, and AST2600 S

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-14 Thread Philippe Mathieu-Daudé
On 6/14/19 2:29 PM, Stefan Weil wrote: > On 14.06.19 12:13, Philippe Mathieu-Daudé wrote: >> I agree with Kevin. The only user of the 'ssh' block driver that I am >> aware of is the virt-v2v tool: >> >> http://libguestfs.org/virt-v2v.1.html#convert-from-esxi-hypervisor-over-ssh-to-local-libvirt >>

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-14 Thread Stefan Weil
On 14.06.19 12:13, Philippe Mathieu-Daudé wrote: > I agree with Kevin. The only user of the 'ssh' block driver that I am > aware of is the virt-v2v tool: > > http://libguestfs.org/virt-v2v.1.html#convert-from-esxi-hypervisor-over-ssh-to-local-libvirt > > Stefan, do you think someone would use it

Re: [Qemu-devel] [PATCH 18/19] aspeed/smc: inject errors in DMA checksum

2019-06-14 Thread Philippe Mathieu-Daudé
Cc'ing Markus & Marc-André On 6/14/19 2:02 PM, Cédric Le Goater wrote: > On 13/06/2019 16:31, Philippe Mathieu-Daudé wrote: >> Hi Cédric, >> >> On 5/25/19 5:12 PM, Cédric Le Goater wrote: >>> Emulate read errors in the DMA Checksum Register for high frequencies >>> and optimistic settings of the R

  1   2   3   4   >