[Qemu-devel] [PATCH v13 4/7] dm: enable synchronous dax

2019-06-12 Thread Pankaj Gupta
This patch sets dax device 'DAXDEV_SYNC' flag if all the target devices of device mapper support synchrononous DAX. If device mapper consists of both synchronous and asynchronous dax devices, we don't set 'DAXDEV_SYNC' flag. 'dm_table_supports_dax' is refactored to pass 'iterate_devices_fn' as arg

[Qemu-devel] [Bug 1832535] [NEW] [riscv/regression] Missing tlb flush introduced in refactoring

2019-06-12 Thread QEMU
Public bug reported: Hello, In qemu-system-riscv64, following a QEMU update, I get all sort of weird and not easily reproducible crashes in my risc-v guest. I have bissected this issue to commit c7b951718815694284501ed01fec7acb8654db7b. Some TLB flushes were removed in the following places: targ

[Qemu-devel] [PATCH v13 0/7] virtio pmem driver

2019-06-12 Thread Pankaj Gupta
This patch series is ready to be merged via nvdimm tree as discussed with Dan. We have ack/review on XFS, EXT4 device mapper & VIRTIO patches. This version has minor changes in patch 2. Keeping all the existing r-o-bs. Jakob CCed also tested the patch series and confirmed the working of v9.

[Qemu-devel] [PATCH v13 5/7] dax: check synchronous mapping is supported

2019-06-12 Thread Pankaj Gupta
This patch introduces 'daxdev_mapping_supported' helper which checks if 'MAP_SYNC' is supported with filesystem mapping. It also checks if corresponding dax_device is synchronous. Virtio pmem device is asynchronous and does not not support VM_SYNC. Suggested-by: Jan Kara Signed-off-by: Pankaj Gup

[Qemu-devel] [PATCH v13 3/7] libnvdimm: add dax_dev sync flag

2019-06-12 Thread Pankaj Gupta
This patch adds 'DAXDEV_SYNC' flag which is set for nd_region doing synchronous flush. This later is used to disable MAP_SYNC functionality for ext4 & xfs filesystem for devices don't support synchronous flush. Signed-off-by: Pankaj Gupta --- drivers/dax/bus.c| 2 +- drivers/dax/sup

[Qemu-devel] [PATCH v13 1/7] libnvdimm: nd_region flush callback support

2019-06-12 Thread Pankaj Gupta
This patch adds functionality to perform flush from guest to host over VIRTIO. We are registering a callback based on 'nd_region' type. virtio_pmem driver requires this special flush function. For rest of the region types we are registering existing flush function. Report error returned by host fsy

[Qemu-devel] [PATCH v13 2/7] virtio-pmem: Add virtio pmem driver

2019-06-12 Thread Pankaj Gupta
This patch adds virtio-pmem driver for KVM guest. Guest reads the persistent memory range information from Qemu over VIRTIO and registers it on nvdimm_bus. It also creates a nd_region object with the persistent memory range information so that existing 'nvdimm/pmem' driver can reserve this into sy

Re: [Qemu-devel] [PULL 0/6] Python queue, 2019-06-11

2019-06-12 Thread Peter Maydell
On Tue, 11 Jun 2019 at 18:15, Eduardo Habkost wrote: > > Changes from 2019-06-07: Python 2 deprecation and Python 3 check > for 3.5+ were removed. > > The following changes since commit 219dca61ebf41625831d4f96a720852baf44b762: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pul

Re: [Qemu-devel] [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface

2019-06-12 Thread Gerd Hoffmann
On Wed, Jun 12, 2019 at 02:59:31PM +0300, Sam Eiderman wrote: > v1: > > Non-standard logical geometries break under QEMU. > > A virtual disk which contains an operating system which depends on > logical geometries (consistent values being reported from BIOS INT13 > AH=08) will most likely break u

[Qemu-devel] [PATCH v13 6/7] ext4: disable map_sync for async flush

2019-06-12 Thread Pankaj Gupta
Dont support 'MAP_SYNC' with non-DAX files and DAX files with asynchronous dax_device. Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and ext4. Signed-off-by: Pankaj Gupta Reviewed-by: Jan Kara --- fs/ext4/file.c | 10 ++

[Qemu-devel] [PATCH v13 7/7] xfs: disable map_sync for async flush

2019-06-12 Thread Pankaj Gupta
Dont support 'MAP_SYNC' with non-DAX files and DAX files with asynchronous dax_device. Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and xfs. Signed-off-by: Pankaj Gupta Reviewed-by: Darrick J. Wong --- fs/xfs/xfs_file.c | 9

Re: [Qemu-devel] [PATCH v2 09/11] monitor: Split out monitor/qmp.c

2019-06-12 Thread Markus Armbruster
Kevin Wolf writes: > Move QMP infrastructure from monitor/misc.c to monitor/qmp.c. This is > code that can be shared for all targets, so compile it only once. Less code compiled per target, yay! > The amount of function and particularly extern variables in > monitor_int.h is probably a bit larg

Re: [Qemu-devel] [PATCH v2 10/11] monitor: Split out monitor/hmp.c

2019-06-12 Thread Markus Armbruster
Kevin Wolf writes: > Move HMP infrastructure from monitor/misc.c to monitor/hmp.c. This is > code that can be shared for all targets, so compile it only once. > > The amount of function and particularly extern variables in > monitor_int.h is probably a bit larger than it needs to be, but this way

Re: [Qemu-devel] [QEMU] [PATCH 7/8] bootdevice: FW_CFG interface for LCHS values

2019-06-12 Thread Sam Eiderman
> On 12 Jun 2019, at 15:27, Laszlo Ersek wrote: > > On 06/12/19 11:42, Sam Eiderman wrote: >> Using fw_cfg, supply logical CHS values directly from QEMU to the BIOS. >> >> Non-standard logical geometries break under QEMU. >> >> A virtual disk which contains an operating system which depends

[Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition

2019-06-12 Thread David Hildenbrand
Rework the feature initialization, making it harder to make mistakes. While at it, rename the enum names of the KDSA features. David Hildenbrand (2): s390x/cpumodel: Rework CPU feature definition s390x/cpumodel: Prepend KDSA features with "KDSA" target/s390x/cpu_features.c | 352 +---

[Qemu-devel] [PATCH v1 2/2] s390x/cpumodel: Prepend KDSA features with "KDSA"

2019-06-12 Thread David Hildenbrand
Let's handle it just like for other crypto features. Signed-off-by: David Hildenbrand --- target/s390x/cpu_features_def.inc.h | 30 ++--- target/s390x/gen-features.c | 30 ++--- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-12 Thread Philippe Mathieu-Daudé
Cc'ing Alex (Docker, Travis) and Stefan (MinGW) On 6/5/19 11:36 PM, Pino Toscano wrote: > Rewrite the implementation of the ssh block driver to use libssh instead > of libssh2. The libssh library has various advantages over libssh2: > - easier API for authentication (for example for using ssh-age

[Qemu-devel] [PATCH v1 1/2] s390x/cpumodel: Rework CPU feature definition

2019-06-12 Thread David Hildenbrand
Let's define features at a single spot and make it less error prone to define new features. Signed-off-by: David Hildenbrand --- target/s390x/cpu_features.c | 352 +- target/s390x/cpu_features_def.h | 352 +- target/s390x/cpu_features_d

Re: [Qemu-devel] [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface

2019-06-12 Thread Sam Eiderman
> On 12 Jun 2019, at 16:06, Gerd Hoffmann wrote: > > On Wed, Jun 12, 2019 at 02:59:31PM +0300, Sam Eiderman wrote: >> v1: >> >> Non-standard logical geometries break under QEMU. >> >> A virtual disk which contains an operating system which depends on >> logical geometries (consistent values

Re: [Qemu-devel] [RFC PATCH v4 5/5] target/ppc: support single stepping with KVM HV

2019-06-12 Thread Fabiano Rosas
Alexey Kardashevskiy writes: > Are you reposting this any time soon? I have sent a v2 to the kernel side of it: https://lore.kernel.org/kvm/2019052919.27994-1-faro...@linux.ibm.com/ I'm depending on what we decide to do there. The core of this patchset will not change, just the mechanism b

[Qemu-devel] [Bug 1818122] Re: QEMU 3.1 makes libxslt to crash on ppc64

2019-06-12 Thread DDoSolitary
** Tags added: ppc -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1818122 Title: QEMU 3.1 makes libxslt to crash on ppc64 Status in QEMU: New Bug description: Host: clean Ubuntu Disco with QEM

Re: [Qemu-devel] [SeaBIOS] [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface

2019-06-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190612115939.23825-1-shmuel.eider...@oracle.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/b

Re: [Qemu-devel] [PATCH v2 11/11] monitor: Split out monitor/monitor.c

2019-06-12 Thread Markus Armbruster
Kevin Wolf writes: > Move the monitor core infrastructure from monitor/misc.c to > monitor/monitor.c. This is code that can be shared for all targets, so > compile it only once. > > What remains in monitor/misc.c after this patch is mostly monitor > command implementations and code that requires

Re: [Qemu-devel] [PATCH v2 05/11] monitor: Move cmd_table to MonitorHMP

2019-06-12 Thread Kevin Wolf
Am 12.06.2019 um 13:45 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Monitor.cmd_table contains the handlers for HMP commands, so there is no > > reason to keep it in the state shared with QMP. Move it to MonitorHMP. > > > > Signed-off-by: Kevin Wolf > > Reviewed-by: Dr. David Al

Re: [Qemu-devel] [PULL v3 00/12] Miscellaneous patches for 2019-06-11

2019-06-12 Thread Peter Maydell
On Wed, 12 Jun 2019 at 12:36, Markus Armbruster wrote: > > The following changes since commit a578cdfbdd8f9beff5ced52b7826ddb1669abbbf: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190610' into > staging (2019-06-10 16:09:19 +0100) > > are available in the Git repository at: >

Re: [Qemu-devel] [PATCH v4] virtio-scsi: restart DMA after iothread

2019-06-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190612120421.20336-1-stefa...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v4] virtio-scsi: restart DMA after iothread Type: series Message-id: 20190612120421.2

Re: [Qemu-devel] [PATCH v2 04/11] monitor: Create MonitorHMP with readline state

2019-06-12 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.06.2019 um 11:07 hat Markus Armbruster geschrieben: >> Cc: Peter for a monitor I/O thread question. >> >> Kevin Wolf writes: >> >> > The ReadLineState in Monitor is only used for HMP monitors. Create >> > MonitorHMP and move it there. >> > >> > Signed-off-by: Kevin W

[Qemu-devel] [Bug 1818122] Re: QEMU 3.1 makes libxslt to crash on ppc64

2019-06-12 Thread Peter Maydell
Could you try with QEMU 4.0, please? There was a bug/incompatibility between earlier QEMU and the Alpine Linux libc which we fixed in 4.0, and so this might be that bug (or some other bug we've already fixed). -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-12 Thread Markus Armbruster
Kevin Wolf writes: > monitor.c mixes a lot of different things in a single file: The core > monitor infrastructure, HMP infrastrcture, QMP infrastructure, and the > implementation of several HMP and QMP commands. Almost worse, struct > Monitor mixes state for HMP, for QMP, and state actually shar

Re: [Qemu-devel] [PATCH v13 2/7] virtio-pmem: Add virtio pmem driver

2019-06-12 Thread Cornelia Huck
On Wed, 12 Jun 2019 18:15:22 +0530 Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range infor

Re: [Qemu-devel] [PATCH v2 03/11] monitor: Make MonitorQMP a child class of Monitor

2019-06-12 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.06.2019 um 09:59 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Currently, struct Monitor mixes state that is only relevant for HMP, >> > state that is only relevant for QMP, and some actually shared state. >> > In particular, a MonitorQMP field is p

Re: [Qemu-devel] [PATCH v2 04/11] monitor: Create MonitorHMP with readline state

2019-06-12 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Kevin Wolf writes: > > > Am 12.06.2019 um 11:07 hat Markus Armbruster geschrieben: > >> Cc: Peter for a monitor I/O thread question. > >> > >> Kevin Wolf writes: > >> > >> > The ReadLineState in Monitor is only used for HMP monitors. Create > >>

Re: [Qemu-devel] [PATCH v5 04/12] block/io_uring: implements interfaces for io_uring

2019-06-12 Thread Stefan Hajnoczi
On Tue, Jun 11, 2019 at 07:17:14PM +0800, Fam Zheng wrote: > On Mon, 06/10 19:18, Aarushi Mehta wrote: > > +/* Prevent infinite loop if submission is refused */ > > +if (ret <= 0) { > > +if (ret == -EAGAIN) { > > +continue; > > +} > > +

[Qemu-devel] [PATCH v7] ssh: switch from libssh2 to libssh

2019-06-12 Thread Pino Toscano
Rewrite the implementation of the ssh block driver to use libssh instead of libssh2. The libssh library has various advantages over libssh2: - easier API for authentication (for example for using ssh-agent) - easier API for known_hosts handling - supports newer types of keys in known_hosts Use AP

Re: [Qemu-devel] [PATCH] migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS

2019-06-12 Thread Wei Yang
On Wed, Jun 12, 2019 at 12:14:14PM +0200, Juan Quintela wrote: >Wei Yang wrote: >> On receiving RAM_SAVE_FLAG_EOS, multifd_recv_sync_main() is called to >> synchronize receive threads. Current synchronization mechanism is to wait >> for each channel's sem_sync semaphore. This semaphore is triggere

Re: [Qemu-devel] [PATCH 2/2] migration/xbzrle: make xbzrle_encode_buffer little easier to read

2019-06-12 Thread Wei Yang
On Wed, Jun 12, 2019 at 12:29:27PM +0200, Juan Quintela wrote: >"Dr. David Alan Gilbert" wrote: >> * Wei Yang (richardw.y...@linux.intel.com) wrote: >>> The encoding process could be described below: >>> >>> for [content] >>> get length of a run >>> encode this run >>> >>> By

Re: [Qemu-devel] [PATCH v2 04/11] monitor: Create MonitorHMP with readline state

2019-06-12 Thread Kevin Wolf
Am 12.06.2019 um 16:08 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 12.06.2019 um 11:07 hat Markus Armbruster geschrieben: > >> Cc: Peter for a monitor I/O thread question. > >> > >> Kevin Wolf writes: > >> > >> > The ReadLineState in Monitor is only used for HMP monitors.

Re: [Qemu-devel] [PATCH v2 09/11] monitor: Split out monitor/qmp.c

2019-06-12 Thread Kevin Wolf
Am 12.06.2019 um 15:11 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Move QMP infrastructure from monitor/misc.c to monitor/qmp.c. This is > > code that can be shared for all targets, so compile it only once. > > Less code compiled per target, yay! > > > The amount of function a

Re: [Qemu-devel] [PATCH v2 0/3] vhost-scsi: Support migration

2019-06-12 Thread Paolo Bonzini
On 03/06/19 01:40, Liran Alon wrote: > Any news on when this patch-series is expected to be merged to upstream QEMU? > It was accepted 2 months ago. It was merged on June 6th. Paolo

[Qemu-devel] qemu processes

2019-06-12 Thread Ryan Boyce
Hi Stefan, I am a big fan of your blog! In relation to your blog post, http://blog.vmsplice.net/2011/03/qemu-internals-big-picture-overview.html, I have a question I am really hoping you can answer: When I start a VM, I see that the qemu-kvm processes start and run as "qemu-kvm. -name "someth

Re: [Qemu-devel] [PATCH v3 3/4] net/announce: Add optional ID

2019-06-12 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 6/10/19 1:44 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Previously there was a single instance of the timer used by > > monitor triggered announces, that's OK, but when combined with the > > previous change that

Re: [Qemu-devel] [PATCH v2 10/11] monitor: Split out monitor/hmp.c

2019-06-12 Thread Kevin Wolf
Am 12.06.2019 um 15:17 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Move HMP infrastructure from monitor/misc.c to monitor/hmp.c. This is > > code that can be shared for all targets, so compile it only once. > > > > The amount of function and particularly extern variables in > >

Re: [Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition

2019-06-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190612132526.8905-1-da...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition Type: series Message-id: 2019061213

Re: [Qemu-devel] [PULL 00/13] ppc-for-4.1 queue 20190612

2019-06-12 Thread Peter Maydell
available in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-4.1-20190612 > > for you to fetch changes up to 4aca9786542e427d4337503566efdf09f2cb87cd: > > ppc/xive: Make XIVE generate the pro

[Qemu-devel] [Bug 1818122] Re: QEMU 3.1 makes libxslt to crash on ppc64

2019-06-12 Thread DDoSolitary
@pmaydell I'm willing to test. However, I encountered another bug introduced in 4.0 which even prevents me from installing xmlto. I'll preparing a bug report and will post it soon. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. htt

Re: [Qemu-devel] [PATCH v2 11/11] monitor: Split out monitor/monitor.c

2019-06-12 Thread Kevin Wolf
Am 12.06.2019 um 15:49 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Move the monitor core infrastructure from monitor/misc.c to > > monitor/monitor.c. This is code that can be shared for all targets, so > > compile it only once. > > > > What remains in monitor/misc.c after this p

Re: [Qemu-devel] [PATCH 0/4] add failover feature for assigned network devices

2019-06-12 Thread Laine Stump
On 6/12/19 7:59 AM, Jens Freimann wrote: On Wed, Jun 12, 2019 at 11:11:23AM +0200, Daniel P. Berrangé wrote: On Tue, Jun 11, 2019 at 11:42:54AM -0400, Laine Stump wrote: On 5/17/19 8:58 AM, Jens Freimann wrote: > > Command line example: > > qemu-system-x86_64 -enable-kvm -m 3072 -smp 3 \ >   

Re: [Qemu-devel] [PULL v2 00/52] testing, gdbstub and cputlb fixes

2019-06-12 Thread Peter Maydell
On Wed, 12 Jun 2019 at 12:19, Alex Bennée wrote: > > The following changes since commit 219dca61ebf41625831d4f96a720852baf44b762: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' > into staging (2019-06-11 16:02:07 +0100) > > are available in the Git repository at:

[Qemu-devel] [PATCH] docs: updates on the POWER9 XIVE interrupt controller documentation

2019-06-12 Thread Cédric Le Goater
This includes various small updates and a better description of the chosen interrupt mode resulting from the combination of the 'ic-mode' machine option, the 'kernel_irqchip' option, guest support and KVM support. Signed-off-by: Cédric Le Goater --- David, please check the tables below. Thanks

Re: [Qemu-devel] [PULL v2 00/52] testing, gdbstub and cputlb fixes

2019-06-12 Thread Philippe Mathieu-Daudé
Le mer. 12 juin 2019 18:04, Peter Maydell a écrit : > On Wed, 12 Jun 2019 at 12:19, Alex Bennée wrote: > > > > The following changes since commit > 219dca61ebf41625831d4f96a720852baf44b762: > > > > Merge remote-tracking branch > 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2019-

Re: [Qemu-devel] [PATCH v5] vfio-ccw: support async command subregion

2019-06-12 Thread Farhan Ali
On 06/12/2019 05:38 AM, Cornelia Huck wrote: On Tue, 11 Jun 2019 15:33:59 -0400 Farhan Ali wrote: On 06/07/2019 10:53 AM, Cornelia Huck wrote: A vfio-ccw device may provide an async command subregion for issuing halt/clear subchannel requests. If it is present, use it for sending halt/clea

[Qemu-devel] [PATCH] ppc/pnv: fix StoreEOI activation

2019-06-12 Thread Cédric Le Goater
The firmware (skiboot) of the PowerNV machines can configure the XIVE interrupt controller to activate StoreEOI on the ESB pages of the interrupts. This feature lets software do an EOI with a store instead of a load. It is not activated today on P9 for rare race condition issues but it should be on

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-06-12 Thread Stefan Hajnoczi
On Thu, May 30, 2019 at 01:54:35PM -0700, Elena Ufimtseva wrote: > On Tue, May 28, 2019 at 08:18:20AM -0700, Elena Ufimtseva wrote: > > On Thu, May 23, 2019 at 12:11:30PM +0100, Stefan Hajnoczi wrote: > > > Hi Jag and Elena, > > > Do you think a call would help to move discussion along more quickly

Re: [Qemu-devel] [PATCH 6/7] file-posix: Add dynamic-auto-read-only QAPI feature

2019-06-12 Thread Markus Armbruster
Eric Blake writes: > On 6/6/19 10:38 AM, Markus Armbruster wrote: >> From: Kevin Wolf >> >> In commit 23dece19da4 ('file-posix: Make auto-read-only dynamic') , >> auto-read-only=on changed its behaviour in file-posix for the 4.0 >> release. This change cannot be detected through the usual mecha

Re: [Qemu-devel] [PATCH v21 4/7] target/avr: Add instruction translation

2019-06-12 Thread Richard Henderson
On 6/11/19 2:02 PM, Michael Rolnik wrote: > I am using this > one  > https://github.com/seharris/qemu-avr-tests/blob/master/free-rtos/Demo/AVR_ATMega2560_GCC/demo.elf > >   > it fails within __divmod

Re: [Qemu-devel] [PATCH v2 04/15] target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions

2019-06-12 Thread Richard Henderson
On 6/11/19 10:16 PM, David Gibson wrote: > Fair enough. Richard, I was kind of hoping for an A-b or R-b on the > series from you, but didn't see one..? It's still on my queue. I hope to get to it soon. r~

Re: [Qemu-devel] [PULL v2 00/52] testing, gdbstub and cputlb fixes

2019-06-12 Thread Alex Bennée
It looks like it's still trying to use the system QEMU (which is broken for this in hackbox) to launch. Is there a built qemu-system-x86_64 in your build directory? On Wed, 12 Jun 2019 at 16:57, Peter Maydell wrote: > > On Wed, 12 Jun 2019 at 12:19, Alex Bennée wrote: > > > > The following chang

Re: [Qemu-devel] [PATCH 0/7] file-posix: Add dynamic-auto-read-only QAPI feature

2019-06-12 Thread Markus Armbruster
Markus Armbruster writes: > This series adds optional feature lists to struct definitions in the > QAPI schema and makes use of them to advertise the new behaviour of > auto-read-only=on in file-posix. Queued, thanks!

Re: [Qemu-devel] [PATCH v10 1/3] linux-user: Add support for setsockopt() options IPV6__MEMBERSHIP

2019-06-12 Thread Laurent Vivier
On 07/06/2019 12:35, Aleksandar Markovic wrote: > From: Neng Chen > > Add support for options IPV6_ADD_MEMBERSHIP and IPV6_DROP_MEMPEMBERSHIP > of the syscall setsockopt(). These options control membership in > multicast groups. Their argument is a pointer to a struct ipv6_mreq, > which is in tur

Re: [Qemu-devel] [PATCH v5] vfio/common: Introduce vfio_set_irq_signaling helper

2019-06-12 Thread Cornelia Huck
On Wed, 12 Jun 2019 14:40:04 +0200 Eric Auger wrote: > The code used to assign an interrupt index/subindex to an > eventfd is duplicated many times. Let's introduce an helper that > allows to set/unset the signaling for an ACTION_TRIGGER, > ACTION_MASK or ACTION_UNMASK action. > > In the error m

Re: [Qemu-devel] [PULL v2 00/52] testing, gdbstub and cputlb fixes

2019-06-12 Thread Peter Maydell
On Wed, 12 Jun 2019 at 17:42, Alex Bennée wrote: > > It looks like it's still trying to use the system QEMU (which is > broken for this in hackbox) to launch. Is there a built > qemu-system-x86_64 in your build directory? No -- the build process here is just make -C build vm-build-openbsd (etc) o

Re: [Qemu-devel] qemu processes

2019-06-12 Thread Alex Bennée
You've actually contacted the development list but I can answer the question. QEMU is multi-threaded so there will be a thread per KVM based vCPU (and also for TCG based vCPUs where MTTCG is enabled). There will also be a number of additional threads created including at least one for the main mon

[Qemu-devel] [PULL 01/11] qdev: Delete unused LostTickPolicy "merge"

2019-06-12 Thread Markus Armbruster
Commit 4e4fa398db6 "qdev: Introduce lost tick policy property" (v1.1.0) created PropertyType PROP_TYPE_LOSTTICKPOLICY with values "discard", "delay", "merge", and "slew". Value "merge" has never been used. Delete it. Signed-off-by: Markus Armbruster Message-Id: <20190401150140.29151-1-arm...@re

[Qemu-devel] [PULL 00/11] QAPI patches for 2019-06-12

2019-06-12 Thread Markus Armbruster
The following changes since commit a050901d4b40092dc356b59912c6df39e389c7b9: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190612' into staging (2019-06-12 14:43:47 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-

Re: [Qemu-devel] qemu processes

2019-06-12 Thread Ryan Boyce
Thank you my friend! On Wed, Jun 12, 2019 at 12:48 PM Alex Bennée wrote: > You've actually contacted the development list but I can answer the > question. > > QEMU is multi-threaded so there will be a thread per KVM based vCPU > (and also for TCG based vCPUs where MTTCG is enabled). There will a

[Qemu-devel] [PULL 07/11] tests/qapi-schema: Error case tests for features in structs

2019-06-12 Thread Markus Armbruster
From: Kevin Wolf Signed-off-by: Kevin Wolf Message-Id: <20190606153803.5278-4-arm...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- tests/Makefile.include | 6 ++ tests/qapi-schema/features-bad-type.err| 1 + tests/qapi-sche

[Qemu-devel] [PULL 02/11] qapi/block-core: update documentation of preallocation parameter

2019-06-12 Thread Markus Armbruster
From: Stefano Garzarella Add default and available values in the documentation block of each block device or protocol that supports the 'preallocation' parameter during the image creation. Suggested-by: Markus Armbruster Signed-off-by: Stefano Garzarella Reviewed-by: Markus Armbruster Message

[Qemu-devel] [PULL 04/11] block/gluster: update .help of BLOCK_OPT_PREALLOC option

2019-06-12 Thread Markus Armbruster
From: Stefano Garzarella Add missing 'falloc' among the allowed values of 'preallocation' option; show it and 'full' only when they are supported. ('falloc' is supported if defined CONFIG_GLUSTERFS_FALLOCATE, 'full' is supported if defined CONFIG_GLUSTERFS_ZEROFILL) Signed-off-by: Stefano Garzar

[Qemu-devel] [PULL 05/11] qapi: Add feature flags to struct types

2019-06-12 Thread Markus Armbruster
From: Kevin Wolf Sometimes, the behaviour of QEMU changes without a change in the QMP syntax (usually by allowing values or operations that previously resulted in an error). QMP clients may still need to know whether they can rely on the changed behavior. Let's add feature flags to the QAPI sche

[Qemu-devel] [PULL 06/11] tests/qapi-schema: Test for good feature lists in structs

2019-06-12 Thread Markus Armbruster
From: Kevin Wolf Signed-off-by: Kevin Wolf Message-Id: <20190606153803.5278-3-arm...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- tests/qapi-schema/qapi-schema-test.json | 39 ++ tests/qapi-schema/qapi-schema-test.out | 43 ++

[Qemu-devel] [PULL 03/11] block/file-posix: update .help of BLOCK_OPT_PREALLOC option

2019-06-12 Thread Markus Armbruster
From: Stefano Garzarella Show 'falloc' among the allowed values of 'preallocation' option, only when it is supported (if defined CONFIG_POSIX_FALLOCATE) Signed-off-by: Stefano Garzarella Reviewed-by: Markus Armbruster Message-Id: <20190524075848.23781-3-sgarz...@redhat.com> Signed-off-by: Mark

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-06-12 Thread Elena Ufimtseva
On Wed, Jun 12, 2019 at 05:24:13PM +0100, Stefan Hajnoczi wrote: > On Thu, May 30, 2019 at 01:54:35PM -0700, Elena Ufimtseva wrote: > > On Tue, May 28, 2019 at 08:18:20AM -0700, Elena Ufimtseva wrote: > > > On Thu, May 23, 2019 at 12:11:30PM +0100, Stefan Hajnoczi wrote: > > > > Hi Jag and Elena, >

[Qemu-devel] [PULL 08/11] qapi: Disentangle QAPIDoc code

2019-06-12 Thread Markus Armbruster
From: Kevin Wolf Documentation comments follow a certain structure: First, we have a text with a general description (called QAPIDoc.body). After this, descriptions of the arguments follow. Finally, we have a part that contains various named sections. The code doesn't show this structure, but ju

[Qemu-devel] [PULL 11/11] qapi: Simplify how QAPIDoc implements its state machine

2019-06-12 Thread Markus Armbruster
QAPIDoc uses a state machine to for processing of documentation lines. Its state is encoded as an enum QAPIDoc._state (well, as enum-like class actually, thanks to our infatuation with Python 2). All we ever do with the state is calling the state's function to process a line of documentation. The

[Qemu-devel] [PULL 10/11] file-posix: Add dynamic-auto-read-only QAPI feature

2019-06-12 Thread Markus Armbruster
From: Kevin Wolf In commit 23dece19da4 ('file-posix: Make auto-read-only dynamic') , auto-read-only=on changed its behaviour in file-posix for the 4.0 release. This change cannot be detected through the usual mechanisms like schema introspection. Add a new feature flag to the schema to allow libv

[Qemu-devel] [PULL 09/11] qapi: Allow documentation for features

2019-06-12 Thread Markus Armbruster
From: Kevin Wolf Features will be documented in a new part introduced by a "Features:" line, after arguments and before named sections. Signed-off-by: Kevin Wolf Message-Id: <20190606153803.5278-6-arm...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/

Re: [Qemu-devel] [PULL v2 00/52] testing, gdbstub and cputlb fixes

2019-06-12 Thread Alex Bennée
Peter Maydell writes: > On Wed, 12 Jun 2019 at 17:42, Alex Bennée wrote: >> >> It looks like it's still trying to use the system QEMU (which is >> broken for this in hackbox) to launch. Is there a built >> qemu-system-x86_64 in your build directory? > > No -- the build process here is just mak

Re: [Qemu-devel] [PATCH v3 00/14] tests/vm: serial console autoinstall, misc fixes.

2019-06-12 Thread Alex Bennée
Alex Bennée writes: > Gerd Hoffmann writes: > >> This patch series changes the way virtual machines for test builds are >> managed. They are created locally on the developer machine now. The >> installer is booted on the serial console and the scripts walks through >> the dialogs to install

[Qemu-devel] [PATCH 2/2] ppc/pnc: remove xscom_base field from PnvChip

2019-06-12 Thread Cédric Le Goater
It has now became useless with the previous patch. Signed-off-by: Cédric Le Goater --- include/hw/ppc/pnv.h | 5 + hw/ppc/pnv.c | 10 -- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h index aa926d120771..de0c1d285fa

[Qemu-devel] [PATCH 1/2] ppc/pnc: fix XSCOM MMIO base address for P9 machines with multiple chips

2019-06-12 Thread Cédric Le Goater
The PNV_XSCOM_BASE and PNV_XSCOM_SIZE macros are specific to POWER8 and they are used when the device tree is populated and the MMIO region created, even for POWER9 chips. This is not too much of a problem today because we don't have important devices on the second chip, but we might have oneday (P

[Qemu-devel] [PULL v3 00/40] testing, gdbstub and cputlb fixes

2019-06-12 Thread Alex Bennée
The following changes since commit a050901d4b40092dc356b59912c6df39e389c7b9: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190612' into staging (2019-06-12 14:43:47 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pu

[Qemu-devel] [PATCH 0/2] ppc/pnc: fix XSCOM MMIO base address for P9 machines with multiple chips

2019-06-12 Thread Cédric Le Goater
Hello, The base address of the MMIO window of the XSCOM bus is incorrect on P9 machines with multiple chips. Provide a fix for that to prepare ground for future PowerNV chips. Thanks, C. Cédric Le Goater (2): ppc/pnc: fix XSCOM MMIO base address for P9 machines with multiple chips ppc/

Re: [Qemu-devel] [PATCH 0/2] ppc/pnc: fix XSCOM MMIO base address for P9 machines with multiple chips

2019-06-12 Thread Cédric Le Goater
On 12/06/2019 19:43, Cédric Le Goater wrote: > Hello, > > The base address of the MMIO window of the XSCOM bus is incorrect on > P9 machines with multiple chips. Provide a fix for that to prepare > ground for future PowerNV chips. David, I just noticed the 'pnc' in the title. If you were to merg

Re: [Qemu-devel] [Qemu-arm] [PATCH v2] net: cadence_gem: fix compilation error when debug is on

2019-06-12 Thread Alex Bennée
Ramon Fried writes: > defining CADENCE_GEM_ERR_DEBUG causes compilation > errors, fix that. It would be worth doing something like: #ifdef CADENCE_GEM_ERR_DEBUG #define CADENCE_GEM_GATE 1 #else #define CADENCE_GEM_GATE 0 #endif #define DB_PRINT(...) do { \ if (CADENCE_GEM_GATE) { \

Re: [Qemu-devel] [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface

2019-06-12 Thread Gerd Hoffmann
On Wed, Jun 12, 2019 at 04:30:03PM +0300, Sam Eiderman wrote: > > > > On 12 Jun 2019, at 16:06, Gerd Hoffmann wrote: > > > > On Wed, Jun 12, 2019 at 02:59:31PM +0300, Sam Eiderman wrote: > >> v1: > >> > >> Non-standard logical geometries break under QEMU. > >> > >> A virtual disk which contai

Re: [Qemu-devel] [Qemu-arm] [PATCH v2] net: cadence_gem: fix compilation error when debug is on

2019-06-12 Thread Eric Blake
On 6/12/19 1:03 PM, Alex Bennée wrote: > > Ramon Fried writes: > >> defining CADENCE_GEM_ERR_DEBUG causes compilation >> errors, fix that. > > It would be worth doing something like: > > #ifdef CADENCE_GEM_ERR_DEBUG > #define CADENCE_GEM_GATE 1 > #else > #define CADENCE_GEM_GATE 0 > #endif >

Re: [Qemu-devel] [PATCH v2 04/15] target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions

2019-06-12 Thread Richard Henderson
On 6/2/19 4:08 AM, Mark Cave-Ayland wrote: > Rather than perform the VSR register decoding within the helper itself, > introduce a new VSX_CMP macro which performs the decode based upon xT, xA > and xB at translation time. > > Subsequent commits will make the same changes for other instructions ho

Re: [Qemu-devel] [PATCH v2 02/15] target/ppc: remove getVSR()/putVSR() from mem_helper.c

2019-06-12 Thread Richard Henderson
On 6/2/19 4:08 AM, Mark Cave-Ayland wrote: > -getVSR(xt_num, &xt, env); \ > + \ > nb = (nb >= 16) ? 16 : nb;\ > if (msr_le && !lj) {

Re: [Qemu-devel] [PATCH v2 03/15] target/ppc: remove getVSR()/putVSR() from int_helper.c

2019-06-12 Thread Richard Henderson
On 6/2/19 4:08 AM, Mark Cave-Ayland wrote: > Since commit 8a14d31b00 "target/ppc: switch fpr/vsrl registers so all VSX > registers are in host endian order" functions getVSR() and putVSR() which used > to convert the VSR registers into host endian order are no longer required. > > Now that there a

Re: [Qemu-devel] [PATCH v2 01/15] target/ppc: remove getVSR()/putVSR() from fpu_helper.c

2019-06-12 Thread Richard Henderson
On 6/2/19 4:08 AM, Mark Cave-Ayland wrote: > void helper_xvxsigsp(CPUPPCState *env, uint32_t opcode) > { > -ppc_vsr_t xt, xb; > +ppc_vsr_t *xt = &env->vsr[xT(opcode)]; > +ppc_vsr_t *xb = &env->vsr[xB(opcode)]; > +ppc_vsr_t t = *xt; > uint32_t exp, i, fraction; > > -getV

Re: [Qemu-devel] [PATCH v2 07/15] target/ppc: introduce GEN_VSX_HELPER_X2 macro to fpu_helper.c

2019-06-12 Thread Richard Henderson
On 6/2/19 4:08 AM, Mark Cave-Ayland wrote: > Rather than perform the VSR register decoding within the helper itself, > introduce a new GEN_VSX_HELPER_X2 macro which performs the decode based > upon xT and xB at translation time. > > With the previous change to the xscvqpdp generator and helper fun

Re: [Qemu-devel] [PATCH v2 05/15] target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c

2019-06-12 Thread Richard Henderson
On 6/2/19 4:08 AM, Mark Cave-Ayland wrote: > Rather than perform the VSR register decoding within the helper itself, > introduce a new GEN_VSX_HELPER_X3 macro which performs the decode based > upon xT, xA and xB at translation time. > > With the previous changes to the VSX_CMP generator and helper

Re: [Qemu-devel] [PATCH v2 08/15] target/ppc: introduce GEN_VSX_HELPER_X2_AB macro to fpu_helper.c

2019-06-12 Thread Richard Henderson
On 6/2/19 4:08 AM, Mark Cave-Ayland wrote: > Rather than perform the VSR register decoding within the helper itself, > introduce a new GEN_VSX_HELPER_X2_AB macro which performs the decode based > upon xA and xB at translation time. > > Signed-off-by: Mark Cave-Ayland > --- > target/ppc/fpu_helpe

Re: [Qemu-devel] [PATCH v2 06/15] target/ppc: introduce separate generator and helper for xscvqpdp

2019-06-12 Thread Richard Henderson
On 6/2/19 4:08 AM, Mark Cave-Ayland wrote: > Rather than perform the VSR register decoding within the helper itself, > introduce a new generator and helper function which perform the decode based > upon xT and xB at translation time. > > The xscvqpdp helper is the only 2 parameter xT/xB implementa

Re: [Qemu-devel] [PATCH v7] ssh: switch from libssh2 to libssh

2019-06-12 Thread Philippe Mathieu-Daudé
Hi Pino, On 6/12/19 4:48 PM, Pino Toscano wrote: > Rewrite the implementation of the ssh block driver to use libssh instead > of libssh2. The libssh library has various advantages over libssh2: > - easier API for authentication (for example for using ssh-agent) > - easier API for known_hosts hand

[Qemu-devel] [PATCH] sun4m: set default display type to TCX

2019-06-12 Thread Mark Cave-Ayland
Commit 6807874d55 "sun4m: obey -vga none" changed the sun4m machines so that they could be started without a framebuffer installed, but as no default display type was configured the machines would start in headless mode without an explict -vga option. Set the default display type for all sun4m mac

Re: [Qemu-devel] [PULL 6/6] travis: Make check-acceptance job more verbose

2019-06-12 Thread Philippe Mathieu-Daudé
On 6/11/19 7:14 PM, Eduardo Habkost wrote: > It will help us debug issues when tests fail. > > Signed-off-by: Eduardo Habkost > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index b053a836a3..a08a7b7278 100644 > --- a/.tra

Re: [Qemu-devel] [PULL 6/6] travis: Make check-acceptance job more verbose

2019-06-12 Thread Eduardo Habkost
On Wed, Jun 12, 2019 at 10:49:18PM +0200, Philippe Mathieu-Daudé wrote: > On 6/11/19 7:14 PM, Eduardo Habkost wrote: > > It will help us debug issues when tests fail. > > > > Signed-off-by: Eduardo Habkost > > --- > > .travis.yml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >

[Qemu-devel] [PATCH 2/2] iotests: Test quitting with job on throttled node

2019-06-12 Thread Max Reitz
When qemu quits, all throttling should be ignored. That means, if there is a mirror job running from a throttled node, it should be cancelled immediately and qemu close without blocking. Signed-off-by: Max Reitz --- tests/qemu-iotests/218 | 55 -- tests/q

[Qemu-devel] [PATCH 0/2] vl: Drain before (block) job cancel when quitting

2019-06-12 Thread Max Reitz
Quitting qemu should lead to qemu exiting pretty much immediately. That means if you have a block job running on a throttled block node, the node should ignore its throttling and the job should be cancelled immediately. Unfortunately, that is not what happens. Currently, the node will be drained

<    1   2   3   >