Re: [Qemu-devel] [PATCH 15/18] Boot Linux Console Test: add a test for aarch64 + virt

On Fri, Jun 07, 2019 at 03:58:57PM -0300, Eduardo Habkost wrote: > CCing Daniel, who wrote commit 6ab3fc32ea64. > > On Fri, Jun 07, 2019 at 11:44:32AM -0400, Cleber Rosa wrote: > > On Fri, Jun 07, 2019 at 12:42:14AM -0300, Eduardo Habkost wrote: > > > On Fri, Jun 07, 2019 at 12:26:48AM -0300, Edua

Re: [Qemu-devel] [PATCH 7/8] VNC Acceptance test: check protocol version

On Fri, Jun 07, 2019 at 02:12:07PM -0400, Cleber Rosa wrote: > On Fri, Jun 07, 2019 at 06:29:15PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 07, 2019 at 11:22:22AM -0400, Cleber Rosa wrote: > > > This goes a bit further than the other tests, and does a basic (read > > > only) interaction with

Re: [Qemu-devel] [PATCH] RFC: qio: Improve corking of TLS sessions

On Fri, Jun 07, 2019 at 05:14:14PM -0500, Eric Blake wrote: > Our current implementation of qio_channel_set_cork() is pointless for > TLS sessions: we block the underlying channel, but still hand things > piecemeal to gnutls which then produces multiple encryption packets. > Better is to directly u

[Qemu-devel] [PATCH v11 0/7] virtio pmem driver

This patch series is ready to be merged via nvdimm tree as discussed with Dan. We have ack/review on XFS, EXT4 & VIRTIO patches. Need an ack on device mapper change in patch 4. Mike, Can you please review and ack patch4. This version does not has any additonal code change from v10 and is

[Qemu-devel] [PATCH v11 1/7] libnvdimm: nd_region flush callback support

This patch adds functionality to perform flush from guest to host over VIRTIO. We are registering a callback based on 'nd_region' type. virtio_pmem driver requires this special flush function. For rest of the region types we are registering existing flush function. Report error returned by host fsy

[Qemu-devel] [PATCH v11 2/7] virtio-pmem: Add virtio pmem driver

This patch adds virtio-pmem driver for KVM guest. Guest reads the persistent memory range information from Qemu over VIRTIO and registers it on nvdimm_bus. It also creates a nd_region object with the persistent memory range information so that existing 'nvdimm/pmem' driver can reserve this into sy

Re: [Qemu-devel] [PATCH 2/7] iotests: amendment for benchmark output of 039 061 137

On Sun, Jun 09, 2019 at 09:35:43PM +0300, Andrey Shinkevich wrote: > After including the Valgrind into the QEMU processes wrappers in the > common.rc script, the output for the tests 039 061 137 has been > changed and is to be amended. The change to common.rc was done in the previous patch, so thi

[Qemu-devel] [PATCH v11 3/7] libnvdimm: add dax_dev sync flag

This patch adds 'DAXDEV_SYNC' flag which is set for nd_region doing synchronous flush. This later is used to disable MAP_SYNC functionality for ext4 & xfs filesystem for devices don't support synchronous flush. Signed-off-by: Pankaj Gupta --- drivers/dax/bus.c| 2 +- drivers/dax/sup

[Qemu-devel] [PATCH v11 5/7] dax: check synchronous mapping is supported

This patch introduces 'daxdev_mapping_supported' helper which checks if 'MAP_SYNC' is supported with filesystem mapping. It also checks if corresponding dax_device is synchronous. Virtio pmem device is asynchronous and does not not support VM_SYNC. Suggested-by: Jan Kara Signed-off-by: Pankaj Gup

[Qemu-devel] [PATCH v11 4/7] dm: enable synchronous dax

This patch sets dax device 'DAXDEV_SYNC' flag if all the target devices of device mapper support synchrononous DAX. If device mapper consists of both synchronous and asynchronous dax devices, we don't set 'DAXDEV_SYNC' flag. Signed-off-by: Pankaj Gupta --- drivers/md/dm-table.c | 14

[Qemu-devel] [PATCH v11 6/7] ext4: disable map_sync for async flush

Dont support 'MAP_SYNC' with non-DAX files and DAX files with asynchronous dax_device. Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and ext4. Signed-off-by: Pankaj Gupta Reviewed-by: Jan Kara --- fs/ext4/file.c | 10 ++

[Qemu-devel] [PATCH v11 7/7] xfs: disable map_sync for async flush

Dont support 'MAP_SYNC' with non-DAX files and DAX files with asynchronous dax_device. Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and xfs. Signed-off-by: Pankaj Gupta Reviewed-by: Darrick J. Wong --- fs/xfs/xfs_file.c | 9

Re: [Qemu-devel] [PATCH v3 3/8] tests: Add migration multifd test

Wei Yang wrote: > On Wed, May 15, 2019 at 02:15:39PM +0200, Juan Quintela wrote: >>We set multifd-channels. >> >>Reviewed-by: Dr. David Alan Gilbert >>Reviewed-by: Thomas Huth >>Signed-off-by: Juan Quintela >>--- >> tests/migration-test.c | 48 ++ >> 1 fil

Re: [Qemu-devel] [PATCH v3 3/8] tests: Add migration multifd test

Wei Yang wrote: > On Wed, May 15, 2019 at 02:15:39PM +0200, Juan Quintela wrote: >>We set multifd-channels. >> >>+wait_for_serial("dest_serial"); >>+wait_for_migration_complete(from); >>+ >>+test_migrate_end(from, to, true); > > Miss free uri here? > > g_free(uri); You are right.

Re: [Qemu-devel] [PATCH 2/5] block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap

08.06.2019 1:08, John Snow wrote: > > > On 6/7/19 2:17 PM, Vladimir Sementsov-Ogievskiy wrote: >> 07.06.2019 21:10, John Snow wrote: >>> >>> >>> On 6/7/19 10:29 AM, Vladimir Sementsov-Ogievskiy wrote: 06.06.2019 21:41, John Snow wrote: > Instead of bdrv_can_store_new_bitmap, rework this

Re: [Qemu-devel] [PATCH 2/7] iotests: amendment for benchmark output of 039 061 137

On 10/06/2019 12:10, Daniel P. Berrangé wrote: > On Sun, Jun 09, 2019 at 09:35:43PM +0300, Andrey Shinkevich wrote: >> After including the Valgrind into the QEMU processes wrappers in the >> common.rc script, the output for the tests 039 061 137 has been >> changed and is to be amended. > > The

Re: [Qemu-devel] [PATCH 2/4] block/dirty-bitmap: add hide/unhide API

08.06.2019 1:39, John Snow wrote: > > > On 6/3/19 8:00 AM, Vladimir Sementsov-Ogievskiy wrote: >> Add functionality to make bitmap temporary anonymous. It will be used >> to implement bitmap remove transaction action. We need hide bitmap >> persistence too, as there are should not be unnamed pers

Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

Markus Armbruster wrote: > Juan Quintela writes: >> +case MIGRATION_PARAMETER_MULTIFD_COMPRESS: >> +p->has_multifd_compress = true; >> +visit_type_MultifdCompress(v, param, &compress_type, &err); >> +if (err) { >> +break; >> +} >> +if (compr

Re: [Qemu-devel] [PATCH 3/4] qapi: implement block-dirty-bitmap-remove transaction action

08.06.2019 1:57, John Snow wrote: > > > On 6/3/19 8:00 AM, Vladimir Sementsov-Ogievskiy wrote: >> It is used to do transactional movement of the bitmap (which is >> possible in conjunction with merge command). Transactional bitmap >> movement is needed in scenarios with external snapshot, when we

Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

Wei Yang wrote: > On Wed, May 15, 2019 at 02:15:41PM +0200, Juan Quintela wrote: >>Signed-off-by: Juan Quintela >>diff --git a/tests/migration-test.c b/tests/migration-test.c >>index 65d5e256a7..8a1ccc2516 100644 >>--- a/tests/migration-test.c >>+++ b/tests/migration-test.c > > Well, may I sugges

Re: [Qemu-devel] [PATCH 2/4] block/dirty-bitmap: add hide/unhide API

10.06.2019 12:33, Vladimir Sementsov-Ogievskiy wrote: > 08.06.2019 1:39, John Snow wrote: >> >> >> On 6/3/19 8:00 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Add functionality to make bitmap temporary anonymous. It will be used >>> to implement bitmap remove transaction action. We need hide bitmap

Re: [Qemu-devel] [PATCH] target/mips: Add implementation of DSPRAM

On 8.6.19. 07:32, Aleksandar Markovic wrote: On Jun 6, 2019 3:49 PM, "Mateja Marjanovic" mailto:mateja.marjano...@rt-rk.com>> wrote: > > From: Mateja Marjanovic > > > Add support for DSPRAM (Data Scratch Pad RAM). It still needs > some minor fixing, but

Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

Wei Yang wrote: > On Wed, May 15, 2019 at 02:15:41PM +0200, Juan Quintela wrote: >>Signed-off-by: Juan Quintela >>@@ -1821,6 +1826,18 @@ void hmp_migrate_set_parameter(Monitor *mon, const >>QDict *qdict) >> p->has_multifd_channels = true; >> visit_type_int(v, param, &p->multifd_c

Re: [Qemu-devel] [PATCH 2/4] block/dirty-bitmap: add hide/unhide API

10.06.2019 12:42, Vladimir Sementsov-Ogievskiy wrote: > 10.06.2019 12:33, Vladimir Sementsov-Ogievskiy wrote: >> 08.06.2019 1:39, John Snow wrote: >>> >>> >>> On 6/3/19 8:00 AM, Vladimir Sementsov-Ogievskiy wrote: Add functionality to make bitmap temporary anonymous. It will be used to im

Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

Wei Yang wrote: > On Wed, May 15, 2019 at 02:15:41PM +0200, Juan Quintela wrote: >>diff --git a/qapi/migration.json b/qapi/migration.json >>index 9cfbaf8c6c..8ec1944b7a 100644 >>--- a/qapi/migration.json >>+++ b/qapi/migration.json >>@@ -482,6 +482,19 @@ >> # TODO either fuse back into MigrationPa

Re: [Qemu-devel] [PATCH 2/4] block/dirty-bitmap: add hide/unhide API

10.06.2019 12:42, Vladimir Sementsov-Ogievskiy wrote: > 10.06.2019 12:33, Vladimir Sementsov-Ogievskiy wrote: >> 08.06.2019 1:39, John Snow wrote: >>> >>> >>> On 6/3/19 8:00 AM, Vladimir Sementsov-Ogievskiy wrote: Add functionality to make bitmap temporary anonymous. It will be used to im

Re: [Qemu-devel] QEMU/KVM migration backwards compatibility broken?

* Liran Alon (liran.a...@oracle.com) wrote: > > > On 6 Jun 2019, at 16:31, Dr. David Alan Gilbert wrote: > > > >>> > >>> So we still need to tie subsections to machine types; that way > >>> you don't send them to old qemu's and there for you don't have the > >>> problem of the qemu receiving so

Re: [Qemu-devel] qgraph

Hi there! Read please our correspondence and answer on last question (Will it ok for QOM conception?) Also forwarding to QOM and QMP maintainers. Can you make comments on this discussion? Best regards, Natalia -Original Message- From: Natalia Fursova [mailto:natalia.furs...@ispras.ru] S

Re: [Qemu-devel] [PATCH v3 6/8] migration: Make none operations into its own structure

Wei Yang wrote: > On Wed, May 15, 2019 at 02:15:42PM +0200, Juan Quintela wrote: >>+ >>+MultifdMethods multifd_none_ops = { >>+.send_prepare = none_send_prepare, >>+.send_write = none_send_write, >>+.recv_pages = none_recv_pages >>+}; >>+ >> static int multifd_send_initial_packet(Multi

Re: [Qemu-devel] [PATCH v3 6/8] migration: Make none operations into its own structure

"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> It will be used later. > > 'none' is confusing - I think this is no-compression specifically - > right? > I'd be happy with something abbreviated like 'nocomp' Got into nocomp. >> @@ -1093,6 +1129,8 @@ static void *

Re: [Qemu-devel] [PULL 00/12] Miscellaneous patches for 2019-06-07

On Fri, 7 Jun 2019 at 19:21, Markus Armbruster wrote: > > The following changes since commit 0d74f3b4277a7ecb0ccb80c865797d11f8e466f5: > > Merge remote-tracking branch > 'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-06-06 > 14:09:14 +0100) > > are available in the Git r

Re: [Qemu-devel] [PULL 0/2] Machine Core queue, 2019-06-07

On Fri, 7 Jun 2019 at 19:32, Eduardo Habkost wrote: > > The following changes since commit 185b7ccc11354cbd69b6d53bf8d831dd964f6c88: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190607-2' into > staging (2019-06-07 15:24:13 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v2] migration/xbzrle: update cache and current_data in one place

* Wei Yang (richardw.y...@linux.intel.com) wrote: > When we are not in the last_stage, we need to update the cache if page > is not the same. > > Currently this procedure is scattered in two places and mixed with > encoding status check. > > This patch extract this general step out to make the co

[Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

Right now QMP and HMP monitors read 1 byte at a time from the socket, which is very inefficient. With 100+ VMs on the host this easily reasults in a lot of unnecessary system calls and CPU usage in the system. This patch changes the amount of data to read to 4096 bytes, which matches buffer size o

[Qemu-devel] [PATCH 2/7] configure: set $PYTHON to a full path

This will make it possible to replace it in a shebang line. Signed-off-by: Paolo Bonzini --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 203dece..0814a5f 100755 --- a/configure +++ b/configure @@ -918,7 +918,7 @@ for binary in "${PYTH

[Qemu-devel] [RFC PATCH 0/7] Proof of concept for Meson integration

Hi all, this is just a simple example of introducing Meson into the build system, converting a few contrib/ subprojects to use it instead of Makefile.objs. There are certainly many rough edges, but I wanted to throw this out to show what it could look like. I chose contrib/ because it's a simple

[Qemu-devel] [PATCH 6/7] vhost-user-scsi: convert to Meson

The libiscsi pkg-config information is extracted from config-host.mak and used to link vhost-user-blk. Signed-off-by: Paolo Bonzini --- .gitignore| 2 +- Makefile | 3 --- Makefile.objs | 3 --- contrib/vhost-user-s

[Qemu-devel] [PATCH 1/7] configure: do not include $(...) variables in config-host.mak

This ensures that Meson will be able to reuse the results of the tests that are performed in the configure script. Signed-off-by: Paolo Bonzini --- configure | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/configure b/configure index 6cdcfb2

[Qemu-devel] [PATCH 7/7] rdmacm-mux: convert to Meson

We can use config-host.mak to decide whether the tool has to be built, apart from that the conversion is straightforward. Signed-off-by: Paolo Bonzini --- .gitignore | 1 + Makefile | 5 - Makefile.objs| 1 - contrib/rdmacm-mu

[Qemu-devel] [PATCH 3/7] configure: integrate Meson in the build system

The Meson build system is integrated in the existing configure/make steps by invoking Meson from the configure script and converting Meson's build.ninja rules to an included Makefile. Signed-off-by: Paolo Bonzini --- Makefile | 9 + configure| 30 ++ meson.build

[Qemu-devel] [PATCH 4/7] libvhost-user: convert to Meson

Because libqemuutil.a is not converted yet, selected files have to be compiled twice, once with Meson and once with Makefile.objs. Apart from this the conversion is straightforward. Signed-off-by: Paolo Bonzini --- Makefile| 10 -- Makefile.objs

[Qemu-devel] [PATCH 5/7] vhost-user-blk: convert to Meson

The GLib pkg-config information is extracted from config-host.mak and used to link vhost-user-blk. Signed-off-by: Paolo Bonzini --- .gitignore | 2 +- Makefile | 3 --- Makefile.objs| 1 - configure

Re: [Qemu-devel] [PULL 0/1] Usb 20190607 patches

On Fri, 7 Jun 2019 at 20:14, Gerd Hoffmann wrote: > > The following changes since commit 442bac16a6cd708a9f87adb0a263f9d833f03ed5: > > usb-tablet: fix serial compat property (2019-05-29 07:10:02 +0200) > > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/usb-20190607-

Re: [Qemu-devel] qgraph

Hi Natalia, Am 10.06.19 um 11:53 schrieb Natalia Fursova: > Hi there! > Read please our correspondence and answer on last question (Will it ok for > QOM conception?) > Also forwarding to QOM and QMP maintainers. Can you make comments on this > discussion? Your question doesn't make sense grammati

Re: [Qemu-devel] qgraph

On 10/06/19 13:57, Andreas Färber wrote: > Your question doesn't make sense grammatically or conceptually. As Paolo > explained below, QOM is a pure object model, with object types/classes > and properties. Buses are just object instances attached as properties > and don't necessarily even need the

Re: [Qemu-devel] kvm / virsh snapshot management

On Sat, Jun 01, 2019 at 08:12:01PM -0400, Gary Dale wrote: > A while back I converted a raw disk image to qcow2 to be able to use > snapshots. However I realize that I may not really understand exactly how > snapshots work. In this particular case, I'm only talking about internal > snapshots curren

Re: [Qemu-devel] [PATCH v4 0/3] numa: deprecate '-numa node, mem' and default memory distribution

On Fri, 07 Jun 2019 19:28:58 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > Changes since v3: > > - simplify series by dropping idea of showing property values in > > "qom-list-properties" > > and use MachineInfo in QAPI schema instead > > Where did "[PATCH v3 1/6] pc: f

Re: [Qemu-devel] [PATCH v4 1/3] machine: show if CLI option '-numa node, mem' is supported in QAPI schema

On Fri, 07 Jun 2019 19:39:17 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > Legacy '-numa node,mem' option has a number of issues and mgmt often > > defaults to it. Unfortunately it's no possible to replace it with > > an alternative '-numa memdev' without breaking migration compa

Re: [Qemu-devel] [RFC PATCH 0/7] Proof of concept for Meson integration

Patchew URL: https://patchew.org/QEMU/1560165301-39026-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH 0/7] Proof of concept for Meson integration Type: series Message-id: 1

Re: [Qemu-devel] [PATCH v6 6/7] block/nbd-client: nbd reconnect

07.06.2019 6:17, Eric Blake wrote: >> +typedef struct NBDConnection { >> +BlockDriverState *bs; >> +SocketAddress *saddr; >> +const char *export; >> +QCryptoTLSCreds *tlscreds; >> +const char *hostname; >> +const char *x_dirty_bitmap; >> +} NBDConnection; > Can we put this t

Re: [Qemu-devel] [RFC PATCH 0/7] Proof of concept for Meson integration

Patchew URL: https://patchew.org/QEMU/1560165301-39026-1-git-send-email-pbonz...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/b

Re: [Qemu-devel] [PATCH v5] qemu-io: add pattern file for write command

On 31.05.2019 18:13, Eric Blake wrote: > On 5/31/19 2:46 AM, Denis Plotnikov wrote: >> The patch allows to provide a pattern file for write >> command. There was no similar ability before. >> >> Signed-off-by: Denis Plotnikov >> --- >> v5: >>* file name initiated with null to make compilers

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

On Fri, 7 Jun 2019 at 22:16, Eduardo Habkost wrote: > > The following changes since commit 185b7ccc11354cbd69b6d53bf8d831dd964f6c88: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190607-2' into > staging (2019-06-07 15:24:13 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v18 04/29] !fixup target/rx: CPU definition

On Fri, 7 Jun 2019 20:06:12 +0200 Philippe Mathieu-Daudé wrote: > On 6/7/19 8:02 PM, Eric Blake wrote: > > On 6/7/19 10:37 AM, Philippe Mathieu-Daudé wrote: > >> Rename macros. > > > > Why is this marked '!fixup' in the subject instead of just merging the > > patches directly? > > Since a

[Qemu-devel] [PATCH v5 1/3] machine: show if CLI option '-numa node, mem' is supported in QAPI schema

Legacy '-numa node,mem' option has a number of issues and mgmt often defaults to it. Unfortunately it's no possible to replace it with an alternative '-numa memdev' without breaking migration compatibility. What's possible though is to deprecate it, keeping option working with old machine types onl

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

On Mon, Jun 10, 2019 at 01:58:50PM +0100, Peter Maydell wrote: > On Fri, 7 Jun 2019 at 22:16, Eduardo Habkost wrote: > > > > The following changes since commit 185b7ccc11354cbd69b6d53bf8d831dd964f6c88: > > > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190607-2' into > > staging

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

On Mon, 10 Jun 2019 at 14:11, Eduardo Habkost wrote: > > On Mon, Jun 10, 2019 at 01:58:50PM +0100, Peter Maydell wrote: > > Hi. This fails to build on one of my buildtest machines: > > > > ERROR: Cannot use 'python3', Python 2 >= 2.7 or Python 3 >= 3.5 is required. > >Use --python=/path/to

Re: [Qemu-devel] [RFC PATCH 0/7] Proof of concept for Meson integration

Patchew URL: https://patchew.org/QEMU/1560165301-39026-1-git-send-email-pbonz...@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a

[Qemu-devel] [PATCH v6] qemu-io: add pattern file for write command

The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v6: * the pattern file is read once to reduce io v5: * file name initiated with null to make compilers happy v4: * missing signed-off clause added v3: *

Re: [Qemu-devel] qgraph

Am 10.06.19 um 14:03 schrieb Paolo Bonzini: > On 10/06/19 13:57, Andreas Färber wrote: >> Your question doesn't make sense grammatically or conceptually. As Paolo >> explained below, QOM is a pure object model, with object types/classes >> and properties. Buses are just object instances attached as

Re: [Qemu-devel] [PATCH v6 6/7] block/nbd-client: nbd reconnect

10.06.2019 15:38, Vladimir Sementsov-Ogievskiy wrote: > 07.06.2019 6:17, Eric Blake wrote: >>> +typedef struct NBDConnection { >>> +    BlockDriverState *bs; >>> +    SocketAddress *saddr; >>> +    const char *export; >>> +    QCryptoTLSCreds *tlscreds; >>> +    const char *hostname; >>> +    const

[Qemu-devel] [PATCH] file-posix: unlock qemu_global_mutex before pread when attach disk

virtual machine cpu soft lockup when attach a disk to the vm in the case that backend storage network has a large delay or IO pressure is too large. The bt of qemu main thread: #0 0x9d78402c in pread64 () from /lib64/libpthread.so.0 #1 0xce3357d8 in pread64 (__offset=0, __nbytes=40

Re: [Qemu-devel] [PATCH v4 07/11] hmat acpi: Build Memory Side Cache Information Structure(s) in ACPI HMAT

On 6/7/2019 12:45 AM, Igor Mammedov wrote: On Thu, 6 Jun 2019 11:00:33 +0800 Tao Xu wrote: ... But the kernel HMAT can read othe Memory Side Cache Information except SMBIOS entries and the host HMAT tables also haven’t SMBIOS Handles it also shows Number of SMBIOS handles (n) as 0. So I am w

Re: [Qemu-devel] [PATCH v2 1/5] target/i386: Add cpu die-level topology support for X86CPU

On 2019/6/6 11:32, Eduardo Habkost wrote: On Tue, May 21, 2019 at 12:50:52AM +0800, Like Xu wrote: The die-level as the first PC-specific cpu topology is added to the leagcy cpu topology model which only covers sockets/cores/threads. In the new model with die-level support, the total number of

[Qemu-devel] [PATCH] qemu-ga: Convert invocation documentation to rST

The qemu-ga documentation is currently in qemu-ga.texi in Texinfo format, which we present to the user as: * a qemu-ga manpage * a section of the main qemu-doc HTML documentation Convert the documentation to rST format, and present it to the user as: * a qemu-ga manpage * part of the interop/

Re: [Qemu-devel] [PULL 00/39] tcg: Move the softmmu tlb to CPUNegativeOffsetState

On Mon, 10 Jun 2019 at 03:02, Richard Henderson wrote: > > The following changes since commit 185b7ccc11354cbd69b6d53bf8d831dd964f6c88: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190607-2' into > staging (2019-06-07 15:24:13 +0100) > > are available in the Git repository at:

[Qemu-devel] [PATCH v5 02/12] qapi/block-core: add option for io_uring

Option only enumerates for hosts that support it. Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi --- qapi/block-core.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 1defcde048..db7eedd058 100644 --- a/qapi/

[Qemu-devel] [PATCH v5 00/12] Add support for io_uring

This patch series adds support for the newly developed io_uring Linux AIO interface. Linux io_uring is faster than Linux's AIO asynchronous I/O code, offers efficient buffered asynchronous I/O support, the ability to do I/O without performing a system call via polled I/O, and other efficiency enha

[Qemu-devel] [PATCH v5 01/12] configure: permit use of io_uring

Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi Reviewed-by: Maxim Levitsky --- configure | 27 +++ 1 file changed, 27 insertions(+) diff --git a/configure b/configure index b091b82cb3..7aa18d308d 100755 --- a/configure +++ b/configure @@ -365,6 +365,7 @@ xen=

[Qemu-devel] [PATCH] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

QEMU will crash when device-memory-region-size property is read if ms->device_memory wasn't initialized yet. Crash can be reproduced with: $QEMU -preconfig -qmp unix:qmp_socket,server,nowait & ./scripts/qmp/qom-get -s qmp_socket /machine.device-memory-region-size Instead of crashing return 0 i

[Qemu-devel] [PATCH v5 05/12] stubs: add stubs for io_uring interface

Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + stubs/Makefile.objs | 1 + stubs/io_uring.c| 32 3 files changed, 34 insertions(+) create mode 100644 stubs/io_uring.c diff --git a/MAINTAINERS b/MAINTAINERS index 49

[Qemu-devel] [PATCH v5 04/12] block/io_uring: implements interfaces for io_uring

Aborts when sqe fails to be set as sqes cannot be returned to the ring. Signed-off-by: Aarushi Mehta --- MAINTAINERS | 7 + block/Makefile.objs | 3 + block/io_uring.c| 314 include/block/aio.h | 16 +- include/block/raw-a

[Qemu-devel] [PATCH v5 03/12] block/block: add BDRV flag for io_uring

Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi Reviewed-by: Maxim Levitsky --- include/block/block.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/block/block.h b/include/block/block.h index f9415ed740..5e08df716f 100644 --- a/include/block/block.h +++ b/include/block/b

[Qemu-devel] [PATCH v5 06/12] util/async: add aio interfaces for io_uring

Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi --- util/async.c | 36 1 file changed, 36 insertions(+) diff --git a/util/async.c b/util/async.c index c10642a385..2709f0edc3 100644 --- a/util/async.c +++ b/util/async.c @@ -277,6 +277,14 @@ aio_ctx_

[Qemu-devel] [PATCH v5 09/12] block: add trace events for io_uring

Signed-off-by: Aarushi Mehta --- block/io_uring.c | 14 -- block/trace-events | 8 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/block/io_uring.c b/block/io_uring.c index f327c7ef96..47e027364a 100644 --- a/block/io_uring.c +++ b/block/io_uring.c @@ -17,6

[Qemu-devel] [PATCH v5 08/12] block/file-posix.c: extend to use io_uring

Signed-off-by: Aarushi Mehta --- block/file-posix.c | 85 +- 1 file changed, 69 insertions(+), 16 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index d018429672..211dfe5337 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@

[Qemu-devel] [PATCH v5 07/12] blockdev: accept io_uring as option

Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi --- blockdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 3f44b891eb..a2a5b32604 100644 --- a/blockdev.c +++ b/blockdev.c @@ -386,6 +386,8 @@ static void extract_common_blockdev_op

[Qemu-devel] [PATCH v5 12/12] qemu-iotests/087: checks for io_uring

Signed-off-by: Aarushi Mehta --- tests/qemu-iotests/087 | 26 ++ tests/qemu-iotests/087.out | 10 ++ 2 files changed, 36 insertions(+) diff --git a/tests/qemu-iotests/087 b/tests/qemu-iotests/087 index d6c8613419..0cc7283ad8 100755 --- a/tests/qemu-iotests/087

[Qemu-devel] [PATCH v5 10/12] block/io_uring: adds userspace completion polling

Signed-off-by: Aarushi Mehta --- block/io_uring.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/block/io_uring.c b/block/io_uring.c index 47e027364a..acfaa48151 100644 --- a/block/io_uring.c +++ b/block/io_uring.c @@ -142,6 +142,21 @@ static void qemu_lurin

[Qemu-devel] [PATCH v5 11/12] qemu-io: adds support for io_uring

Signed-off-by: Aarushi Mehta --- qemu-io.c | 13 + 1 file changed, 13 insertions(+) diff --git a/qemu-io.c b/qemu-io.c index 8d5d5911cb..54b82151c4 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -129,6 +129,7 @@ static void open_help(void) " -n, -- disable host cache, short for -t none\n

Re: [Qemu-devel] [PATCH] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

On 10/06/19 15:50, Igor Mammedov wrote: > QEMU will crash when device-memory-region-size property is read if > ms->device_memory > wasn't initialized yet. > > Crash can be reproduced with: > $QEMU -preconfig -qmp unix:qmp_socket,server,nowait & > ./scripts/qmp/qom-get -s qmp_socket /machine.dev

Re: [Qemu-devel] [Qemu-block] [PATCH] file-posix: unlock qemu_global_mutex before pread when attach disk

On 10/06/19 15:34, Zhengui li wrote: > > when do qmp sush as drive_add, qemu main thread locks the > qemu_global_mutex and do pread in raw_probe_alignmen. Pread is a > synchronous operation. If backend storage network has a large delay > or IO pressure is too large, the pread operation will not

Re: [Qemu-devel] [PATCH] qemu-ga: Convert invocation documentation to rST

On 10/06/19 15:45, Peter Maydell wrote: > +# Canned command to build manpages from a single manual > +build-manpages = $(call quiet-command,CONFDIR="$(qemu_confdir)" sphinx-build > $(if $(V),,-q) -W -n -b man -D version=$(VERSION) -D > release="$(FULL_VERSION)" -d .doctrees/$1 $(SRC_PATH)/docs/$1

Re: [Qemu-devel] qgraph

On 10/06/19 15:28, Andreas Färber wrote: > So if we want a new QMP operation, the most sense would probably make > where-can-I-attach-type(foo) returning a list of QOM paths, showing only > the first free slot per bus. That would allow a more efficient lookup > implementation inside QEMU than needi

Re: [Qemu-devel] [PATCH] RFC: qio: Improve corking of TLS sessions

On 6/10/19 4:08 AM, Daniel P. Berrangé wrote: > On Fri, Jun 07, 2019 at 05:14:14PM -0500, Eric Blake wrote: >> Our current implementation of qio_channel_set_cork() is pointless for >> TLS sessions: we block the underlying channel, but still hand things >> piecemeal to gnutls which then produces mul

Re: [Qemu-devel] [PATCH] qemu-ga: Convert invocation documentation to rST

On Mon, 10 Jun 2019 at 14:56, Paolo Bonzini wrote: > > On 10/06/19 15:45, Peter Maydell wrote: > > +# Canned command to build manpages from a single manual > > +build-manpages = $(call quiet-command,CONFDIR="$(qemu_confdir)" > > sphinx-build $(if $(V),,-q) -W -n -b man -D version=$(VERSION) -D >

Re: [Qemu-devel] [PATCH] file-posix: unlock qemu_global_mutex before pread when attach disk

Patchew URL: https://patchew.org/QEMU/1560173684-6264-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] file-posix: unlock qemu_global_mutex before pread when attach disk Type:

[Qemu-devel] Need help generating instruction traces from the emulator.

Hello, I am using qemu based aosp (emu-master-dev branch of the aosp) to generate the instruction traces for android os running on the ARM architecture. I am able to generate the CPU instruction using the qemu invocation flags. For the p

Re: [Qemu-devel] [PATCH v6 6/7] block/nbd-client: nbd reconnect

On 6/10/19 8:29 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hmm, and then, include it into BDRVNBDState? I don't remember why didn't do >> it, and now I don't see any reason for it. We store this information anyway >> for the whole life of the driver.. >> >> So, if I'm going to refactor it, I have

Re: [Qemu-devel] [PATCH v3 0/8] WIP: Multifd compression support

On 5/20/19 1:35 AM, Wei Yang wrote: > On Wed, May 15, 2019 at 02:15:36PM +0200, Juan Quintela wrote: >> v3: >> - improve the code >> - address David and Markus comments >> - make compression code into methods >> so we can add any other method ading just three functions >> >> Please review, as far

Re: [Qemu-devel] [PATCH 1/7] iotests: allow Valgrind checking all QEMU processes

On 6/9/19 1:35 PM, Andrey Shinkevich wrote: > With the '-valgrind' option, let all the QEMU processes be run under > the Valgrind tool. The Valgrind own parameters may be set with its > environment variable VALGRIND_OPTS, e.g. > VALGRIND_OPTS="--leak-check=yes" ./check -qcow2 -valgrind Let's spel

Re: [Qemu-devel] [PATCH] RFC: qio: Improve corking of TLS sessions

On 6/10/19 9:02 AM, Eric Blake wrote: > > send(MSG_MORE) > send() > > is ideal; under the hood, we can translate it to: > > send(MSG_MORE) > gnutls_record_cork() > gnutls_record_send() > send() > if (size > threshold) { > gnutls_record_uncork() > gnutls_record_send() > } else {

Re: [Qemu-devel] Need help generating instruction traces from the emulator.

On Mon, 10 Jun 2019 at 15:24, Nisarg Ujjainkar wrote: > > Hello, > > I am using qemu based aosp (emu-master-dev branch of the aosp) to generate > the instruction traces for android os running on the ARM architecture. > > I am able to generate the CPU instruction using the qemu invocation >

Re: [Qemu-devel] [Qemu-block] [PATCH] file-posix: unlock qemu_global_mutex before pread when attach disk

The pread will hang in attaching disk just when backend storage network disconnection . I think the locking range of qemu_global_mutex is too large when do qmp operation. what does the qemu_global_mutex  really protect?  what is the risk of unlocking qemu_global_mutex in qmp? On 2019/6/1

Re: [Qemu-devel] [PATCH] qemu-ga: Convert invocation documentation to rST

On Mon, 10 Jun 2019 at 14:45, Peter Maydell wrote: > > The qemu-ga documentation is currently in qemu-ga.texi in > Texinfo format, which we present to the user as: > * a qemu-ga manpage > * a section of the main qemu-doc HTML documentation > > Convert the documentation to rST format, and present

[Qemu-devel] [PATCH 14/39] target/i386: Use env_cpu, env_archcpu

Cleanup in the boilerplate that each target must define. Replace x86_env_get_cpu with env_archcpu. The combination CPU(x86_env_get_cpu) should have used ENV_GET_CPU to begin; use env_cpu now. Reviewed-by: Alistair Francis Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/

[Qemu-devel] [PULL v2 00/39] tcg: Move softmmu tlb into CPUNegativeOffsetState

: https://github.com/rth7680/qemu.git tags/pull-tcg-20190610 for you to fetch changes up to 43b3952dea0f763ceeaa2f119c473b5cc6d29c90: tcg/arm: Remove mostly unreachable tlb special case (2019-06-10 07:03:42 -0700) Move softmm

Re: [Qemu-devel] [PATCH 1/7] iotests: allow Valgrind checking all QEMU processes

On 10/06/2019 17:24, Eric Blake wrote: > On 6/9/19 1:35 PM, Andrey Shinkevich wrote: >> With the '-valgrind' option, let all the QEMU processes be run under >> the Valgrind tool. The Valgrind own parameters may be set with its >> environment variable VALGRIND_OPTS, e.g. >> VALGRIND_OPTS="--leak-c

Re: [Qemu-devel] [PATCH v21 3/7] target/avr: Add instruction decoding

On 6/6/19 12:30 PM, Michael Rolnik wrote: > +STS 1001 001 . @ldst_s > + > -- checkpatch error for extra blank line at end of file. r~

Re: [Qemu-devel] [PATCH v21 4/7] target/avr: Add instruction translation

On 6/6/19 12:30 PM, Michael Rolnik wrote: > +void avr_cpu_tcg_init(void) > +{ > +int i; > + > +#define AVR_REG_OFFS(x) offsetof(CPUAVRState, x) > +cpu_pc = tcg_global_mem_new_i32(cpu_env, AVR_REG_OFFS(pc_w), "pc"); > +cpu_Cf = tcg_global_mem_new_i32(cpu_env, AVR_REG_OFFS(sregC), "Cf");

  1   2   >