Re: [Qemu-devel] [PATCH 07/42] target/arm: Convert VMINNM, VMAXNM to decodetree

2019-06-07 Thread Richard Henderson
On 6/6/19 12:45 PM, Peter Maydell wrote: > Convert the VMINNM and VMAXNM instructions to decodetree. > As with VSEL, we leave the trans_VMINMAXNM() function > in translate.c for the moment. > > Signed-off-by: Peter Maydell > --- > target/arm/translate.c | 41 ---

Re: [Qemu-devel] [PATCH v6 5/7] qemu-coroutine-sleep: introduce qemu_co_sleep_wake

2019-06-07 Thread Vladimir Sementsov-Ogievskiy
07.06.2019 16:02, Kevin Wolf wrote: > Am 07.06.2019 um 13:18 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 07.06.2019 10:57, Kevin Wolf wrote: >>> Am 11.04.2019 um 19:27 hat Vladimir Sementsov-Ogievskiy geschrieben: Introduce a function to gracefully wake-up a coroutine, sleeping in qe

Re: [Qemu-devel] [PATCH v5] vfio-ccw: support async command subregion

2019-06-07 Thread Cornelia Huck
On Fri, 7 Jun 2019 11:02:36 -0400 Farhan Ali wrote: > On 06/07/2019 10:53 AM, Cornelia Huck wrote: > > A vfio-ccw device may provide an async command subregion for > > issuing halt/clear subchannel requests. If it is present, use > > it for sending halt/clear request to the device; if not, fall >

[Qemu-devel] [PULL v2 15/34] s390x/tcg: Implement VECTOR FP COMPARE (EQUAL|HIGH|HIGH OR EQUAL)

2019-06-07 Thread Cornelia Huck
From: David Hildenbrand Provide for all three instructions all four combinations of cc bit and s bit. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 12 target/s390x/insn-data.def | 6 ++ target/s390x/translate_vx.inc.c | 51

[Qemu-devel] [PULL v2 04/34] s390x/tcg: Implement VECTOR FIND ELEMENT NOT EQUAL

2019-06-07 Thread Cornelia Huck
From: David Hildenbrand Similar to VECTOR FIND ELEMENT EQUAL. Core logic courtesy of Richard H. Add s390_vec_read_element() that can deal with element sizes. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h| 6 +++ target/s390x/insn-data.

Re: [Qemu-devel] [PATCH 0/7] file-posix: Add dynamic-auto-read-only QAPI feature

2019-06-07 Thread Kevin Wolf
Am 06.06.2019 um 17:37 hat Markus Armbruster geschrieben: > This series adds optional feature lists to struct definitions in the > QAPI schema and makes use of them to advertise the new behaviour of > auto-read-only=on in file-posix. Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 3/5] block/dirty-bitmap: rework bdrv_remove_persistent_dirty_bitmap

2019-06-07 Thread Vladimir Sementsov-Ogievskiy
06.06.2019 21:41, John Snow wrote: > Allow propagating error code information from > bdrv_remove_persistent_dirty_bitmap as well. > > Give it an interface that matches the newly revised > bdrv_add_persistent_dirty_bitmap, including removing the persistent flag > when the operation succeeds and ref

Re: [Qemu-devel] [PATCH v5] vfio-ccw: support async command subregion

2019-06-07 Thread Farhan Ali
On 06/07/2019 11:09 AM, Cornelia Huck wrote: On Fri, 7 Jun 2019 11:02:36 -0400 Farhan Ali wrote: On 06/07/2019 10:53 AM, Cornelia Huck wrote: A vfio-ccw device may provide an async command subregion for issuing halt/clear subchannel requests. If it is present, use it for sending halt/clear

Re: [Qemu-devel] [PULL v2 00/34] s390x updates

2019-06-07 Thread Peter Maydell
available in the Git repository at: > > https://github.com/cohuck/qemu tags/s390x-20190607-2 > > for you to fetch changes up to c984c4e8e31e57c44b3674d9dd8ed6aa5e68306e: > > Merge tag 's390x-tcg-2019-06-07

[Qemu-devel] [PATCH 3/8] Acceptance tests: drop left over usage of ":avocado: enable"

2019-06-07 Thread Cleber Rosa
Commit 9531d26c10 removed all of ":avocado: enable" tags, but then a new entry was added with the introduction of migration.py. Let's remove it for consistency. Signed-off-by: Cleber Rosa --- tests/acceptance/migration.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/acceptance/mi

Re: [Qemu-devel] [PATCH 03/42] target/arm: Factor out VFP access checking code

2019-06-07 Thread Richard Henderson
On 6/6/19 12:45 PM, Peter Maydell wrote: > Factor out the VFP access checking code so that we can use it in the > leaf functions of the decodetree decoder. > > We call the function full_vfp_access_check() so we can keep > the more natural vfp_access_check() for a version which doesn't > have the '

[Qemu-devel] [PATCH 4/8] Boot Linux Console Test: add a test for ppc64 + pseries

2019-06-07 Thread Cleber Rosa
Just like the previous tests, boots a Linux kernel on a ppc64 target using the pseries machine. Signed-off-by: Cleber Rosa Reviewed-by: Caio Carrara CC: Daniel P. Berrangé --- .travis.yml| 2 +- tests/acceptance/boot_linux_console.py | 19 +++ 2 fil

[Qemu-devel] [PATCH 8/8] Migration acceptance test: reduce the possibility of port collisions

2019-06-07 Thread Cleber Rosa
The avocado.utils.network.find_free_port() will by default attempt to return the first port given in the range, if it seems to be available. Let's reduce the probability of collisions by picking a random port by default. As a side note, this behavior has changed in a recent Avocado version, and t

[Qemu-devel] [PULL v2 12/34] s390x/tcg: Export float_comp_to_cc() and float(32|64|128)_dcmask()

2019-06-07 Thread Cornelia Huck
From: David Hildenbrand Vector floating-point instructions will require these functions, so allow to use them from other files. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/fpu_helper.c | 4 ++-- target/s390x/internal.h | 4 2 files changed, 6 insert

Re: [Qemu-devel] [PATCH 05/42] target/arm: Explicitly enable VFP short-vectors for aarch32 -cpu max

2019-06-07 Thread Richard Henderson
On 6/6/19 12:45 PM, Peter Maydell wrote: > At the moment our -cpu max for AArch32 supports VFP short-vectors > because we always implement them, even for CPUs which should > not have them. The following commits are going to switch to > using the correct ID-register-check to enable or disable short

[Qemu-devel] [PATCH 5/8] VNC Acceptance test: use UNIX domain sockets to avoid port collisions

2019-06-07 Thread Cleber Rosa
While running in parallel, the VNC tests that use a TCP port easily collide. There's a number of possibilities to reduce the probability of collisions, but none that completely prevents it from happening. So, to avoid those collisions, and given that the scope of the tests are really not related

[Qemu-devel] [PATCH 1/8] Travis: print acceptance tests logs in case of job failure

2019-06-07 Thread Cleber Rosa
Because Travis doesn't allow us to keep files produced during tests (such as log files), let's print the complete job log to the "console" in case of job failures. This is a debugging aid, and given that there's been some timeouts happening on some tests, we absolutely needs the logs to have a pro

Re: [Qemu-devel] [PATCH 09/42] target/arm: Convert VCVTA/VCVTN/VCVTP/VCVTM to decodetree

2019-06-07 Thread Peter Maydell
On Fri, 7 Jun 2019 at 16:38, Richard Henderson wrote: > > On 6/6/19 12:45 PM, Peter Maydell wrote: > > @@ -3452,6 +3446,15 @@ static int disas_vfp_insn(DisasContext *s, uint32_t > > insn) > > } > > } > > > > +if (extract32(insn, 28, 4) == 0xf) { > > +/* > > + * E

[Qemu-devel] [PULL v2 06/34] s390x/tcg: Implement VECTOR STRING RANGE COMPARE

2019-06-07 Thread Cornelia Huck
From: David Hildenbrand Unfortunately, there is no easy way to avoid looping over all elements in v2. Provide specialized variants for !cc,!rt/!cc,rt/cc,!rt/cc,rt and all element types. Especially for different values of rt, the compiler might be able to optimize the code a lot. Add s390_vec_wri

Re: [Qemu-devel] [PATCH 08/42] target/arm: Convert VRINTA/VRINTN/VRINTP/VRINTM to decodetree

2019-06-07 Thread Richard Henderson
On 6/6/19 12:45 PM, Peter Maydell wrote: > Convert the VRINTA/VRINTN/VRINTP/VRINTM instructions to decodetree. > Again, trans_VRINT() is temporarily left in translate.c. > > Signed-off-by: Peter Maydell > --- > target/arm/translate.c | 60 +++- > target/arm/

[Qemu-devel] [PATCH 0/8] Miscellaneous acceptance test and Travis CI improvements

2019-06-07 Thread Cleber Rosa
This is a collection of small improvements to some of the acceptance tests, and the Travis CI experience. The main goal was to make tests a bit more robust when run in parallel (an Avocado feature pending review), and Travis CI diagnostics better by printing out the full Avocado job log when any e

[Qemu-devel] [PULL 01/12] qemu-common: Move tcg_enabled() etc. to sysemu/tcg.h

2019-06-07 Thread Markus Armbruster
Other accelerators have their own headers: sysemu/hax.h, sysemu/hvf.h, sysemu/kvm.h, sysemu/whpx.h. Only tcg_enabled() & friends sit in qemu-common.h. This necessitates inclusion of qemu-common.h into headers, which is against the rules spelled out in qemu-common.h's file comment. Move tcg_enabl

[Qemu-devel] [PATCH v18 25/29] target/rx: Dump bytes for each insn during disassembly

2019-06-07 Thread Philippe Mathieu-Daudé
From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <201906070

Re: [Qemu-devel] [PATCH v2] target/arm: Vectorize USHL and SSHL

2019-06-07 Thread Richard Henderson
On 6/7/19 9:54 AM, Peter Maydell wrote: > On Tue, 4 Jun 2019 at 00:22, Richard Henderson > wrote: >> >> These instructions shift left or right depending on the sign >> of the input, and 7 bits are significant to the shift. This >> requires several masks and selects in addition to the actual >> sh

Re: [Qemu-devel] [Qemu-trivial] [PATCH] test: Use g_strndup instead of plain strndup

2019-06-07 Thread Markus Armbruster
writes: > Due to memory management rules. See HACKING. > > Signed-off-by: Tony Nguyen > > diff --git a/tests/check-qjson.c b/tests/check-qjson.c > index fa2afcc..07a773e 100644 > --- a/tests/check-qjson.c > +++ b/tests/check-qjson.c > @@ -767,7 +767,7 @@ static void utf8_string(void) >

[Qemu-devel] [PATCH 2/8] tests/requirements.txt: pin paramiko version requirement

2019-06-07 Thread Cleber Rosa
It's a good practice (I'd really say a must) to pin as much as possible of the software versions used during test, so let's apply that to paramiko. According to https://pypi.org/project/paramiko/, 2.4.2 is the latest released version. It's also easily obtainable on systems such as Fedora 30. Sig

[Qemu-devel] [PATCH v18 29/29] BootLinuxConsoleTest: Test the RX-Virt machine

2019-06-07 Thread Philippe Mathieu-Daudé
Add two tests for the rx-virt machine, based on the recommended test setup from Yoshinori Sato: https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg03586.html - U-Boot prompt - Linux kernel with Sash shell These are very quick tests: $ avocado run -t arch:rx tests/acceptance/boot_linux_co

[Qemu-devel] [PATCH v18 24/29] target/rx: Collect all bytes during disassembly

2019-06-07 Thread Philippe Mathieu-Daudé
From: Richard Henderson Collected, to be used in the next patch. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-23-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH v2 0/3] MAINTAINERS: Clean up and improve section headlines

2019-06-07 Thread Markus Armbruster
Queued with PATCH 1 replaced by a prior patch from Philippe. Actual patch is identical.

[Qemu-devel] [Qemu-trivial] [PATCH] test: Use g_strndup instead of plain strndup

2019-06-07 Thread tony.nguyen
Due to memory management rules. See HACKING. Signed-off-by: Tony Nguyen diff --git a/tests/check-qjson.c b/tests/check-qjson.c index fa2afcc..07a773e 100644 --- a/tests/check-qjson.c +++ b/tests/check-qjson.c @@ -767,7 +767,7 @@ static void utf8_string(void) if (*end ==

[Qemu-devel] [PATCH v18 28/29] hw/rx: Fix comments

2019-06-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/rx/rx-virt.c | 2 +- hw/rx/rx62n.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/rx/rx-virt.c b/hw/rx/rx-virt.c index 49d04d22ea..53f43f62bd 100644 --- a/hw/rx/rx-virt.c +++ b/hw/rx/rx-virt.c @@ -55,7 +55,7 @@ static void

[Qemu-devel] [PATCH v18 23/29] target/rx: Emit all disassembly in one prt()

2019-06-07 Thread Philippe Mathieu-Daudé
From: Richard Henderson Many of the multi-part prints have been eliminated by previous patches. Eliminate the rest of them. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-22-ys...@users.sourceforge.jp> Tested-by

Re: [Qemu-devel] [PATCH 0/4] Cleanups around qemu-common.h

2019-06-07 Thread Markus Armbruster
Markus Armbruster writes: > qemu-common.h stipulates: > > * If a header file uses a definition from qemu-common.h, that definition > * must be moved to a separate header file, and the header that uses it > * must include that header. > > I count 117 violations of that rule. This series fixes

[Qemu-devel] [PATCH v18 27/29] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core

2019-06-07 Thread Philippe Mathieu-Daudé
While the VIRT machine can use different microcontrollers, the RX62N microcontroller is tied to the RX62N CPU core. Signed-off-by: Philippe Mathieu-Daudé --- hw/rx/rx-virt.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/rx/rx-virt.c b/hw/rx/rx-virt.c index 72a2989fcf..49d04d22ea

[Qemu-devel] [PATCH v18 20/29] target/rx: Disassemble rx_index_addr into a string

2019-06-07 Thread Philippe Mathieu-Daudé
From: Richard Henderson We were eliding all zero indexes. It is only ld==0 that does not have an index in the instruction. This also allows us to avoid breaking the final print into multiple pieces. Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-1

[Qemu-devel] [PATCH v18 19/29] MAINTAINERS: Add RX

2019-06-07 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-18-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- MAINTAINERS | 19 +++ 1 file changed, 19 insertions(+)

Re: [Qemu-devel] [RFC PATCH 01/10] monitor: Remove unused password prompting fields

2019-06-07 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Commit 788cf9f8c removed the code for password prompting from the > monitor. Since then, the Monitor fields password_completion_cb and > password_opaque have been unused. Remove them. > > Signed-off-by: Kevin Wolf A shame, I love the idea of password comp

Re: [Qemu-devel] [PATCH 0/4] Header guards

2019-06-07 Thread Markus Armbruster
Queued.

[Qemu-devel] [PATCH v18 13/29] hw/registerfields.h: Add 8bit and 16bit register macros

2019-06-07 Thread Philippe Mathieu-Daudé
Some RX peripheral using 8bit and 16bit registers. Added 8bit and 16bit APIs. Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-11-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richa

[Qemu-devel] [PATCH v18 16/29] tests: Add rx to machine-none-test.c

2019-06-07 Thread Philippe Mathieu-Daudé
From: Richard Henderson Fixes check-qtest-rx: tests/machine-none-test. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-15-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tests/machine-none

[Qemu-devel] [PATCH v18 22/29] target/rx: Use prt_ldmi for XCHG_mr disassembly

2019-06-07 Thread Philippe Mathieu-Daudé
From: Richard Henderson Note that the ld == 3 case handled by prt_ldmi is decoded as XCHG_rr and cannot appear here. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-21-ys...@users.sourceforge.jp> Tested-by: Philip

[Qemu-devel] [PATCH v18 00/29] Add RX archtecture support

2019-06-07 Thread Philippe Mathieu-Daudé
Hi Yoshinori, Richard, Igor. This series an iteration of the previous v17 from Yoshinori with the fixups requested by Igor here: https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg07260.html and https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg01547.html plus trivial cleanups. We ha

[Qemu-devel] [PATCH 7/8] VNC Acceptance test: check protocol version

2019-06-07 Thread Cleber Rosa
This goes a bit further than the other tests, and does a basic (read only) interaction with the VNC protocol. This is not a enough to perform a handshake, but enough to make sure that the socket is somewhat operational and that the expected initial step of the handshake is performed by the server

[Qemu-devel] [PATCH 6/8] VNC Acceptance test: simplify test names

2019-06-07 Thread Cleber Rosa
The test name is composed of the class name and method name, so it looks like there's some redundancy here that we can eliminate. Signed-off-by: Cleber Rosa --- tests/acceptance/vnc.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/acceptance/vnc.py b/tests/accepta

[Qemu-devel] [PATCH v18 15/29] target/rx: Add RX to SysEmuTarget

2019-06-07 Thread Philippe Mathieu-Daudé
From: Richard Henderson Fixes check-qtest-rx: tests/qmp-cmd-test Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-13-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- qapi/common.json | 3 ++-

[Qemu-devel] [PATCH v18 01/29] target/rx: TCG translation

2019-06-07 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato This part only supported RXv1 instructions. Instruction manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190607091

[Qemu-devel] [PATCH v18 11/29] !fixup hw/rx: RX Target hardware definition

2019-06-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/rx/rx-virt.c | 2 +- hw/rx/rx62n.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/rx/rx-virt.c b/hw/rx/rx-virt.c index 3deb7cb335..72a2989fcf 100644 --- a/hw/rx/rx-virt.c +++ b/hw/rx/rx-virt.c @@ -88,7 +88,7 @@ static void

[Qemu-devel] [PATCH v18 14/29] target/rx: Convert to CPUClass::tlb_fill

2019-06-07 Thread Philippe Mathieu-Daudé
From: Richard Henderson The interface for tlb_fill has changed very recently. Move the function into cpu.c so that it may be static while assigning to the CPUClass methods. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-12-ys...@users.source

[Qemu-devel] [PATCH v18 17/29] hw/rx: Honor -accel qtest

2019-06-07 Thread Philippe Mathieu-Daudé
From: Richard Henderson Issue an error if no kernel, no bios, and not qtest'ing. Fixes make check-qtest-rx: test/qom-test. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-16-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signe

[Qemu-devel] [PATCH 2/2] qemu-tech.texi: Remove "QEMU compared to other emulators" section

2019-06-07 Thread Peter Maydell
The "QEMU compared to other emulators" section of our documentation hasn't been updated since 2015 (and parts of the text are even older). We're clearly not very well placed to track the evolution of a dozen other emulation projects, and an inaccurate or out of date comparison doesn't serve anybody

[Qemu-devel] [PATCH v18 26/29] target/rx: Restrict access to extable[]

2019-06-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/rx/cpu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/rx/cpu.c b/target/rx/cpu.c index 3eef1329a1..7b8e0144c8 100644 --- a/target/rx/cpu.c +++ b/target/rx/cpu.c @@ -229,11 +229,10 @@ static void rx_cpu_register_ty

[Qemu-devel] [PATCH v18 04/29] !fixup target/rx: CPU definition

2019-06-07 Thread Philippe Mathieu-Daudé
Rename macros. Signed-off-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/rx/cpu.c | 22 ++ target/rx/cpu.h | 12 ++-- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/target/rx/cpu.c b/target/rx/cpu.c index 4b96f2e463..3c434675

[Qemu-devel] [PATCH v18 21/29] target/rx: Replace operand with prt_ldmi in disassembler

2019-06-07 Thread Philippe Mathieu-Daudé
From: Richard Henderson This has consistency with prt_ri(). It loads all data before beginning output. It uses exactly one call to prt() to emit the full instruction. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49

[Qemu-devel] [PATCH v18 18/29] Add rx-softmmu

2019-06-07 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-17-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- arch_init.c| 2 ++ configure

[Qemu-devel] [PULL 10/12] MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org

2019-06-07 Thread Markus Armbruster
From: Philippe Mathieu-Daudé The list is always selected by the 'All patches CC here' section. Signed-off-by: Philippe Mathieu-Daudé [Conflicts resolved by redoing the patch] Signed-off-by: Markus Armbruster --- MAINTAINERS | 11 --- 1 file changed, 11 deletions(-) diff --git a/MAINT

[Qemu-devel] [PATCH v18 03/29] target/rx: CPU definition

2019-06-07 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Message-Id: <20190607091116.49044-4-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/cpu.c | 222 +++ targ

Re: [Qemu-devel] [PATCH 09/42] target/arm: Convert VCVTA/VCVTN/VCVTP/VCVTM to decodetree

2019-06-07 Thread Richard Henderson
On 6/6/19 12:45 PM, Peter Maydell wrote: > @@ -3452,6 +3446,15 @@ static int disas_vfp_insn(DisasContext *s, uint32_t > insn) > } > } > > +if (extract32(insn, 28, 4) == 0xf) { > +/* > + * Encodings with T=1 (Thumb) or unconditional (ARM): these > + * wer

[Qemu-devel] [PULL 05/12] Normalize position of header guard

2019-06-07 Thread Markus Armbruster
This is the common header guard idiom: /* * File comment */ #ifndef GUARD_SYMBOL_H #define GUARD_SYMBOL_H ... actual contents ... #endif A few of our headers have some #include before the guard. target/tilegx/spr_def_64.h has #ifndef __DOXYGEN__ outside the guard.

[Qemu-devel] [PATCH v18 12/29] qemu/bitops.h: Add extract8 and extract16

2019-06-07 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-10-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/qemu/bitops.h | 38 ++

[Qemu-devel] [PATCH v18 08/29] hw/timer: RX62N internal timer modules

2019-06-07 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato renesas_tmr: 8bit timer modules. renesas_cmt: 16bit compare match timer modules. This part use many renesas's CPU. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Benn

Re: [Qemu-devel] [RFC PATCH 00/10] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-07 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Jun 07, 2019 at 04:25:14PM +0200, Kevin Wolf wrote: > > Am 07.06.2019 um 16:03 hat Daniel P. Berrangé geschrieben: > > > On Fri, Jun 07, 2019 at 03:54:20PM +0200, Kevin Wolf wrote: > > > > monitor.c mixes a lot of different things in a sin

[Qemu-devel] [PATCH v18 06/29] target/rx: RX disassembler

2019-06-07 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-5-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- include/disas/dis-asm.h |5 + target/rx/disas.c | 1480 ++

[Qemu-devel] [PATCH v18 09/29] hw/char: RX62N serial communication interface (SCI)

2019-06-07 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato This module supported only non FIFO type. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.4904

Re: [Qemu-devel] [PATCH 15/18] Boot Linux Console Test: add a test for aarch64 + virt

2019-06-07 Thread Cleber Rosa
On Fri, Jun 07, 2019 at 12:26:48AM -0300, Eduardo Habkost wrote: > On Fri, Feb 01, 2019 at 11:10:31AM -0500, Cleber Rosa wrote: > > > > > > On 1/31/19 4:26 PM, Cleber Rosa wrote: > > > > > > > > > On 1/31/19 3:21 PM, Cleber Rosa wrote: > > >> > > >> > > >> On 1/31/19 3:02 PM, Wainer dos Santos

[Qemu-devel] [PULL 07/12] Clean up a few header guard symbols

2019-06-07 Thread Markus Armbruster
Commit 58ea30f5145 "Clean up header guards that don't match their file name" messed up contrib/elf2dmp/qemu_elf.h and tests/migration/migration-test.h. It missed target/cris/opcode-cris.h and tests/uefi-test-tools/UefiTestToolsPkg/Include/Guid/BiosTablesTest.h due to the scripts/clean-header-guard

[Qemu-devel] [PATCH v18 10/29] hw/rx: RX Target hardware definition

2019-06-07 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato rx62n - RX62N cpu. rx-virt - RX QEMU virtual target. Signed-off-by: Yoshinori Sato Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-9-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- hw/rx/Kconfig

[Qemu-devel] [PATCH v18 05/29] !fixup target/rx: CPU definition

2019-06-07 Thread Philippe Mathieu-Daudé
New qom-cpu style requested by Igor. Signed-off-by: Philippe Mathieu-Daudé --- target/rx/cpu.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/target/rx/cpu.c b/target/rx/cpu.c index 3c43467534..c370f65faa 100644 --- a/target/rx/cpu.c +++ b/target/rx/cpu.

[Qemu-devel] [PULL 02/12] qemu-common: Move qemu_isalnum() etc. to qemu/ctype.h

2019-06-07 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20190523143508.25387-3-arm...@redhat.com> Reviewed-by: Richard Henderson --- block/ssh.c| 1 + block/vvfat.c | 1 + gdbstub.c | 2 ++ hw/core/bus.c | 2 +- hw/core/qdev-properties.c | 1

Re: [Qemu-devel] [PATCH v2] target/arm: Vectorize USHL and SSHL

2019-06-07 Thread Peter Maydell
On Fri, 7 Jun 2019 at 16:40, Richard Henderson wrote: > > On 6/7/19 9:54 AM, Peter Maydell wrote: > > On Tue, 4 Jun 2019 at 00:22, Richard Henderson > > wrote: > >> > >> These instructions shift left or right depending on the sign > >> of the input, and 7 bits are significant to the shift. This

[Qemu-devel] [PULL 09/12] Clean up a header guard symbols (again)

2019-06-07 Thread Markus Armbruster
Commit d52c454aad "contrib: add vhost-user-gpu" and "c68082c43a virtio-gpu: split virtio-gpu-pci & virtio-vga" created headers with unusual header guard symbols. Clean them up Signed-off-by: Markus Armbruster Message-Id: <20190607141321.9726-1-arm...@redhat.com> --- contrib/vhost-user-gpu/virgl

[Qemu-devel] [PATCH v18 07/29] hw/intc: RX62N interrupt controller (ICUa)

2019-06-07 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato This implementation supported only ICUa. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044

[Qemu-devel] [PATCH v18 02/29] target/rx: TCG helper

2019-06-07 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Message-Id: <20190607091116.49044-3-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/helper.c| 148 + target/rx/helper.h| 31 +++

[Qemu-devel] [PULL 11/12] MAINTAINERS: Improve section headlines

2019-06-07 Thread Markus Armbruster
When scripts/get_maintainer.pl reports something like John Doe (maintainer:Overall) the user is left to wonder *which* of our three "Overall" sections applies: the one under "Guest CPU cores (TCG)", or the one under "Guest CPU Cores (KVM)", or the one under "Usermode emulation". Rename sect

[Qemu-devel] [PATCH 1/2] Convert "translator internals" docs to RST, move to devel manual

2019-06-07 Thread Peter Maydell
Our user-facing manual currently has a section "translator internals" which has some high-level information about the design of the TCG translator. This should really be in our new devel/ manual. Convert it to RST format and move it there. Signed-off-by: Peter Maydell --- docs/devel/index.rst |

[Qemu-devel] [PATCH 0/2] qemu-tech: move part to docs/devel, delete part

2019-06-07 Thread Peter Maydell
This patchset makes some of the cleanups to qemu-tech.texi which I suggested in my Sphinx transition plan: https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg04932.html (1) the "translator internals" docs move to the devel/ manual (and are given a simple by-hand texi-to-rst conversion) (2) t

[Qemu-devel] [PULL 08/12] Supply missing header guards

2019-06-07 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20190604181618.19980-5-arm...@redhat.com> --- hw/9pfs/xen-9pfs.h| 6 +- hw/hppa/hppa_hardware.h | 5 + hw/input/adb-internal.h | 4 hw/net/e1000e_core.h | 5 + hw/net/e1

Re: [Qemu-devel] [PATCH 0/8] Miscellaneous acceptance test and Travis CI improvements

2019-06-07 Thread Cleber Rosa
On Fri, Jun 07, 2019 at 11:22:15AM -0400, Cleber Rosa wrote: > This is a collection of small improvements to some of the acceptance > tests, and the Travis CI experience. > > The main goal was to make tests a bit more robust when run in parallel > (an Avocado feature pending review), and Travis CI

[Qemu-devel] [PULL 06/12] scripts/clean-header-guards: Fix handling of trailing comments

2019-06-07 Thread Markus Armbruster
clean-header-guards.pl fails to recognize a header guard #endif when it's followed by a // comment, or multiple comments. Fix that. Signed-off-by: Markus Armbruster Message-Id: <20190604181618.19980-3-arm...@redhat.com> --- scripts/clean-header-guards.pl | 12 +++- 1 file changed, 7 ins

[Qemu-devel] [PULL 12/12] MAINTAINERS: Polish headline decorations

2019-06-07 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20190606172408.18399-4-arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5cef4aa5bd..3ec8f3b009 100644

Re: [Qemu-devel] [PATCH v18 05/29] !fixup target/rx: CPU definition

2019-06-07 Thread Philippe Mathieu-Daudé
On 6/7/19 5:37 PM, Philippe Mathieu-Daudé wrote: > New qom-cpu style requested by Igor. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/rx/cpu.c | 19 +++ > 1 file changed, 15 insertions(+), 4 deletions(-) > > diff --git a/target/rx/cpu.c b/target/rx/cpu.c > index 3c434

[Qemu-devel] [PULL 00/12] Miscellaneous patches for 2019-06-07

2019-06-07 Thread Markus Armbruster
The following changes since commit 0d74f3b4277a7ecb0ccb80c865797d11f8e466f5: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-06-06 14:09:14 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-misc-2019

Re: [Qemu-devel] [RFC PATCH 04/10] monitor: Create MonitorHMP with readline state

2019-06-07 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > The ReadLineState in Monitor is only used for HMP monitors. Create > MonitorHMP and move it there. > > Signed-off-by: Kevin Wolf Reviewed-by: Dr. David Alan Gilbert > --- > include/monitor/monitor.h | 5 +- > hmp.c | 4 +- > mon

Re: [Qemu-devel] [PATCH v6 5/7] qemu-coroutine-sleep: introduce qemu_co_sleep_wake

2019-06-07 Thread Vladimir Sementsov-Ogievskiy
07.06.2019 16:02, Kevin Wolf wrote: > Am 07.06.2019 um 13:18 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 07.06.2019 10:57, Kevin Wolf wrote: >>> Am 11.04.2019 um 19:27 hat Vladimir Sementsov-Ogievskiy geschrieben: Introduce a function to gracefully wake-up a coroutine, sleeping in qe

Re: [Qemu-devel] [PATCH 15/18] Boot Linux Console Test: add a test for aarch64 + virt

2019-06-07 Thread Cleber Rosa
On Fri, Jun 07, 2019 at 12:42:14AM -0300, Eduardo Habkost wrote: > On Fri, Jun 07, 2019 at 12:26:48AM -0300, Eduardo Habkost wrote: > > On Fri, Feb 01, 2019 at 11:10:31AM -0500, Cleber Rosa wrote: > > > > > > > > > On 1/31/19 4:26 PM, Cleber Rosa wrote: > > > > > > > > > > > > On 1/31/19 3:21 P

[Qemu-devel] [PULL 1/1] usb-mtp: refactor the flow of usb_mtp_write_data

2019-06-07 Thread Gerd Hoffmann
From: Bandan Das There's no functional change but the flow is (hopefully) more consistent for both file and folder object types. Signed-off-by: Bandan Das Message-Id: <20190401211712.19012-4-...@redhat.com> Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 57 +--

Re: [Qemu-devel] [PATCH 10/42] target/arm: Move the VFP trans_* functions to translate-vfp.inc.c

2019-06-07 Thread Richard Henderson
On 6/6/19 12:45 PM, Peter Maydell wrote: > Move the trans_*() functions we've just created from translate.c > to translate-vfp.inc.c. This is pure code motion with no textual > changes (this can be checked with 'git show --color-moved'). > > Signed-off-by: Peter Maydell > --- > target/arm/transl

Re: [Qemu-devel] [RFC PATCH 02/10] monitor: Split monitor_init in HMP and QMP function

2019-06-07 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Instead of mixing HMP and QMP monitors in the same function, separate > the monitor creation function for both. > > Signed-off-by: Kevin Wolf Reviewed-by: Dr. David Alan Gilbert > --- > monitor.c | 86 +++

Re: [Qemu-devel] [RFC PATCH 07/10] monitor: Create monitor_int.h with common definitions

2019-06-07 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Before we can split monitor.c, we need to create a header file that > contains the common definitions that will be used by multiple source > files. > > Signed-off-by: Kevin Wolf Reviewed-by: Dr. David Alan Gilbert > --- > monitor/monitor_int.h | 147 ++

Re: [Qemu-devel] [PATCH v18 28/29] hw/rx: Fix comments

2019-06-07 Thread Peter Maydell
On Fri, 7 Jun 2019 at 17:52, Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/rx/rx-virt.c | 2 +- > hw/rx/rx62n.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/rx/rx-virt.c b/hw/rx/rx-virt.c > index 49d04d22ea..53f43f62bd 100

Re: [Qemu-devel] [RFC PATCH 03/10] monitor: Make MonitorQMP a child class of Monitor

2019-06-07 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Currently, struct Monitor mixes state that is only relevant for HMP, > state that is only relevant for QMP, and some actually shared state. > In particular, a MonitorQMP field is present in the state of any > monitor, even if it's not a QMP monitor and there

Re: [Qemu-devel] [RFC PATCH 08/10] monitor: Split out monitor/qmp.c

2019-06-07 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Move QMP infrastructure from monitor/misc.c to monitor/qmp.c. This is > code that can be shared for all targets, so compile it only once. > > The amount of function and particularly extern variables in > monitor_int.h is probably a bit larger than it needs

Re: [Qemu-devel] [PATCH v17 00/24] Add RX archtecture support

2019-06-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190607091116.49044-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v17 00/24] Add RX archtecture support Type: series Message-id: 20190607091116.

Re: [Qemu-devel] [PATCH 1/2] ui/cocoa: Fix absolute input device grabbing issue on Mojave

2019-06-07 Thread Peter Maydell
On Tue, 4 Jun 2019 at 10:36, Chen Zhang wrote: > > On Mojave, absolute input device, i.e. tablet, had trouble re-grabbing > the cursor in re-entry into the virtual screen area. In some cases, > the `window` property of NSEvent object was nil after cursor exiting from > window, hinting that the `-l

Re: [Qemu-devel] [RFC PATCH 09/10] monitor: Split out monitor/hmp.c

2019-06-07 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Move HMP infrastructure from monitor/misc.c to monitor/hmp.c. This is > code that can be shared for all targets, so compile it only once. > > The amount of function and particularly extern variables in > monitor_int.h is probably a bit larger than it needs

Re: [Qemu-devel] [RFC PATCH 00/10] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190607135430.22149-1-kw...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH 00/10] monitor: Split monitor.c in core/HMP/QMP/misc Message-id: 20190607135430.2214

Re: [Qemu-devel] lists.nongnu.org was upgraded today, one issue is still being worked out

2019-06-07 Thread Ian Kelling
Ian Kelling writes: > The server is sending mail using a new ip which is causing a higher than > average number of mail servers telling us to retry and send later as > they hopefully decide we are legitimate. The only big provider doing > this is yahoo, others are small enough that if messages

Re: [Qemu-devel] [PATCH v6 5/7] qemu-coroutine-sleep: introduce qemu_co_sleep_wake

2019-06-07 Thread Vladimir Sementsov-Ogievskiy
07.06.2019 18:52, Vladimir Sementsov-Ogievskiy wrote: > 07.06.2019 16:02, Kevin Wolf wrote: >> Am 07.06.2019 um 13:18 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> 07.06.2019 10:57, Kevin Wolf wrote: Am 11.04.2019 um 19:27 hat Vladimir Sementsov-Ogievskiy geschrieben: > Introduce a fun

Re: [Qemu-devel] [PATCH] qapi: InitSocketAddress: add keepalive option

2019-06-07 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 06.06.2019 14:17, Daniel P. Berrangé wrote: >> On Thu, Jun 06, 2019 at 01:15:33PM +0300, Vladimir Sementsov-Ogievskiy wrote: >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>> >>> Hi all! >>> >>> This is a continuation of "[PATCH v2 0/2] nbd: enabl

Re: [Qemu-devel] Headers without multiple inclusion guards

2019-06-07 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 07:52:50PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, May 28, 2019 at 08:12:24PM +0200, Markus Armbruster wrote: > >> We have a bunch of headers without multiple inclusion guards. Some are > >> clearly intentional, some look accidental. To

Re: [Qemu-devel] [PATCH v4 0/3] numa: deprecate '-numa node, mem' and default memory distribution

2019-06-07 Thread Markus Armbruster
Igor Mammedov writes: > Changes since v3: > - simplify series by dropping idea of showing property values in > "qom-list-properties" > and use MachineInfo in QAPI schema instead Where did "[PATCH v3 1/6] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size

<    1   2   3   4   5   >