Re: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks

2019-06-07 Thread Markus Armbruster
Paolo Bonzini writes: > On 27/05/19 10:00, Markus Armbruster wrote: >> As long as we don't have an active QOM maintainer[*], the benefit is >> low. >> >> >> [*] We need one. I'm not volunteering. > > I think Daniel, Eduardo and I could count as de facto maintainer. I > guess I could maintain

[Qemu-devel] [PATCH v2] q35: fix mmconfig and PCI0._CRS

2019-06-07 Thread Gerd Hoffmann
This patch changes the handling of the mmconfig area. Thanks to the pci(e) expander devices we already have the logic to exclude address ranges from PCI0._CRS. We can simply add the mmconfig address range to the list get it excluded as well. With that in place we can go with a fixed pci hole whi

[Qemu-devel] [PATCH v2] q35: split memory at 2G

2019-06-07 Thread Gerd Hoffmann
Original q35 behavior was to split memory at 2.75 GB, leaving space for the mmconfig bar at 0xb00 and pci I/O window starting at 0xc000. Note: Those machine types have been removed from the qemu codebase meanwhile because they could not be live-migrated so there was little value in keeping

Re: [Qemu-devel] [PATCH 15/18] Boot Linux Console Test: add a test for aarch64 + virt

2019-06-07 Thread Laszlo Ersek
On 06/07/19 05:26, Eduardo Habkost wrote: > Thread 4 (Thread 0x7f2e45fff700 (LWP 6461)): > #0 0x7f2e4ec03500 in nanosleep () at /lib64/libpthread.so.0 > #1 0x7f2e4fb229d7 in g_usleep () at /lib64/libglib-2.0.so.0 > #2 0x559a4e7ca4c9 in qemu_chr_write_buffer (s=s@entry=0x559a502d0ac0

Re: [Qemu-devel] [PATCH v2] q35: fix mmconfig and PCI0._CRS

2019-06-07 Thread Laszlo Ersek
On 06/07/19 09:34, Gerd Hoffmann wrote: > This patch changes the handling of the mmconfig area. Thanks to the > pci(e) expander devices we already have the logic to exclude address > ranges from PCI0._CRS. We can simply add the mmconfig address range > to the list get it excluded as well. > > Wi

[Qemu-devel] [Bug 1831545] Re: "accel/tcg: demacro cputlb" break qemu-system-x86_64 on 32-bit x86 host

2019-06-07 Thread Alex Bennée
** Tags added: tcg -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1831545 Title: "accel/tcg: demacro cputlb" break qemu-system-x86_64 on 32-bit x86 host Status in QEMU: New Bug description:

Re: [Qemu-devel] [PATCH v6 5/7] qemu-coroutine-sleep: introduce qemu_co_sleep_wake

2019-06-07 Thread Kevin Wolf
Am 11.04.2019 um 19:27 hat Vladimir Sementsov-Ogievskiy geschrieben: > Introduce a function to gracefully wake-up a coroutine, sleeping in > qemu_co_sleep_ns() sleep. > > Signed-off-by: Vladimir Sementsov-Ogievskiy You can simply reenter the coroutine while it has yielded in qemu_co_sleep_ns().

Re: [Qemu-devel] [PATCH v6 6/7] block/nbd-client: nbd reconnect

2019-06-07 Thread Kevin Wolf
Am 07.06.2019 um 05:17 hat Eric Blake geschrieben: > On 4/11/19 12:27 PM, Vladimir Sementsov-Ogievskiy wrote: > > +static coroutine_fn void nbd_reconnect_loop(NBDConnection *con) > > +{ > > +NBDClientSession *s = nbd_get_client_session(con->bs); > > +uint64_t start_time_ns = qemu_clock_get_

Re: [Qemu-devel] [PATCH] spapr: Don't use the "dual" interrupt controller mode with an old hypervisor

2019-06-07 Thread Cédric Le Goater
On 07/06/2019 02:19, David Gibson wrote: > On Thu, Jun 06, 2019 at 07:08:59PM +0200, Greg Kurz wrote: >> If KVM is too old to support XIVE native exploitation mode, we might end >> up using the emulated XIVE after CAS. This is sub-optimal if KVM in-kernel >> XICS is available, which is the case mos

Re: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks

2019-06-07 Thread Markus Armbruster
Paolo Bonzini writes: > On 23/05/19 18:14, Markus Armbruster wrote: >> * Machine core (Eduardo, Marcel) >> >> query-machines, query-current-machine, >> >> ~60 lines. Hardly worthwhile from a "let's shrink misc.json" point of >> view. Might be worthwhile from a "let's make get_maintaine

Re: [Qemu-devel] [PATCH] spapr: Don't use the "dual" interrupt controller mode with an old hypervisor

2019-06-07 Thread Cédric Le Goater
> kernel_irqchip > >(default) > ic-mode allowed offon > > dualXICS KVM XICS emul.(3) XICS KVM (default mode) > xicsXICS KVM XICS emul. XICS KVM > xiveXIVE emul.(1) XIVE emul.

Re: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks

2019-06-07 Thread Philippe Mathieu-Daudé
On 6/7/19 8:59 AM, Markus Armbruster wrote: [...] > QOM is not a particularly active subsystem now: 51 commits in two years. > > We obviously need maintainers to review and merge patches. The nominal > maintainer hasn't been doing that since 2015. Git shows the following > top committers taking

[Qemu-devel] [PATCH] edid: add xmax + ymax properties

2019-06-07 Thread Gerd Hoffmann
Add new properties to allow setting the maximum display resolution. Resolutions larger than that will not be included in the mode list. In linux guests xrandr can be used to list modes. Note: The existing xres and yres properties set the preferred display resolution, i.e. the mode should be first

Re: [Qemu-devel] [PATCH v2] m68k comments break patch submission due to being incorrectly formatted

2019-06-07 Thread Peter Maydell
On Fri, 7 Jun 2019 at 04:30, Lucien Murray-Pitts wrote: > checkpatch is correctly identifying the wrong style in the changed code. > This changed code contains the original comments with ADDITIONAL edits > resulting in pachew/checkpatch complaining. > > The m68k is, by my guess, older code and nea

[Qemu-devel] [PATCH] edid: flip the default to enabled

2019-06-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 2 +- hw/core/machine.c | 8 +++- hw/display/bochs-display.c | 2 +- hw/display/vga-pci.c | 4 ++-- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/include/hw/virtio/virtio-gpu.h b/inc

Re: [Qemu-devel] [PATCH 5/5] vhost-user-gpu: initialize msghdr & iov at declaration

2019-06-07 Thread Peter Maydell
On Wed, 5 Jun 2019 at 16:01, Marc-André Lureau wrote: > > This should fix uninitialized fields found by coverity CID 1401762. > > Signed-off-by: Marc-André Lureau > --- > contrib/vhost-user-gpu/main.c | 21 - > 1 file changed, 8 insertions(+), 13 deletions(-) > Reviewed-by:

Re: [Qemu-devel] [PATCH 2/5] vhost-user: check unix_listen() return value

2019-06-07 Thread Peter Maydell
On Wed, 5 Jun 2019 at 16:02, Marc-André Lureau wrote: > > This check shouldn't be necessary, since &error_fatal is given as > argument and will exit() on failure. However, this change should > silence coverity CID 1401761 & 1401705. > > Signed-off-by: Marc-André Lureau > --- > contrib/vhost-user

Re: [Qemu-devel] [PATCH 4/5] vhost-user-input: check ioctl(EVIOCGNAME) return value

2019-06-07 Thread Peter Maydell
On Wed, 5 Jun 2019 at 16:04, Marc-André Lureau wrote: > > This should fix coverity CID 1401704. > > Signed-off-by: Marc-André Lureau > --- > contrib/vhost-user-input/main.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/contrib/vhost-user-input/main.c b/contrib/vho

Re: [Qemu-devel] [PATCH v4 0/3] misc usb-mtp fixes

2019-06-07 Thread Peter Maydell
On Mon, 1 Apr 2019 at 22:17, Bandan Das wrote: > > v4: > Added 1/3: > v3: > 2/2: Fix indentation >Add back sending RES_OK for success > v2: > 1/2: Add Reviewed-by tag > 2/2: remove extra vars and directly call usb_mtp_queue_result > > The first patch removes a unnecessary function

Re: [Qemu-devel] [PATCH] migration: Add error_desc for file channel errors

2019-06-07 Thread Yury Kotov
Ping 22.04.2019, 13:50, "Yury Kotov" : > Currently, there is no information about error if outgoing migration was > failed > because of file channel errors. > Example (QMP session): > -> { "execute": "migrate", "arguments": { "uri": "exec:head -c 1" }} > <- { "return": {} } > ... > -> { "execute"

Re: [Qemu-devel] [PATCH v2] m68k comments break patch submission due to being incorrectly formatted

2019-06-07 Thread Laurent Vivier
Le 07/06/2019 à 10:34, Peter Maydell a écrit : > On Fri, 7 Jun 2019 at 04:30, Lucien Murray-Pitts > wrote: >> checkpatch is correctly identifying the wrong style in the changed code. >> This changed code contains the original comments with ADDITIONAL edits >> resulting in pachew/checkpatch complai

[Qemu-devel] [PULL 04/52] tests/docker: Update the Fedora cross compile images to 30

2019-06-07 Thread Alex Bennée
While at it remove the bogus :latest tag for cris cross compiler. It tends to break caching and cause confusion. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/dockerfiles/fedora-cris-cr

[Qemu-devel] [PULL 03/52] tests/docker: Update the Fedora image to Fedora 30

2019-06-07 Thread Alex Bennée
From: Philippe Mathieu-Daudé Fedora 30 got released: https://fedoramagazine.org/announcing-fedora-30/ Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Marc-André Lureau Tested-by: Stefano Garzarella Reviewed-by: Stefano Garzarella Message-Id: <20190528153304.27157-1-phi...@redhat.com>

[Qemu-devel] [PULL 05/52] tests/docker: Update the Ubuntu image to 19.04

2019-06-07 Thread Alex Bennée
This has aged a little and we have a separate LTS image for testing on the older distros. Update it to a more recent release like its Fedora cousin. Besides it is useful to have something with gcc-9 on it for squashing those stringop truncation errors. Signed-off-by: Alex Bennée Reviewed-by: Ric

[Qemu-devel] [PULL 02/52] qemu-io-cmds: use clock_gettime for benchmarking

2019-06-07 Thread Alex Bennée
The previous use of gettimeofday() ran into undefined behaviour when we ended up doing a div 0 for a very short operation. This is because gettimeofday only works at the microsecond level as well as being prone to discontinuous jumps in system time. Using clock_gettime with CLOCK_MONOTONIC gives gr

[Qemu-devel] [PULL 00/52] testing, gdbstub and cputlb fixes

2019-06-07 Thread Alex Bennée
The following changes since commit 0d74f3b4277a7ecb0ccb80c865797d11f8e466f5: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-06-06 14:09:14 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testin

[Qemu-devel] [PULL 07/52] .travis.yml: add clang ubsan job

2019-06-07 Thread Alex Bennée
We document this on our wiki and we might as well catch it in our CI rather than waiting for it to be picked up on merge: https://wiki.qemu.org/Testing#clang_UBSan Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/.travis.yml b/.tr

[Qemu-devel] [PULL 09/52] tests/vm: Port basevm to Python 3

2019-06-07 Thread Alex Bennée
From: Wainer dos Santos Moschetta Fixed tests/vm/basevm.py to run with Python 3: - hashlib.sha1() requires an binary encoded object. - uses floor division ("//") (PEP 238). - decode bytes to unicode when needed. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL 10/52] tests/vm: Fix build-centos docker-based tests run

2019-06-07 Thread Alex Bennée
From: Wainer dos Santos Moschetta `make vm-build-centos` run docker-based tests on CentOS. The created containers should have network otherwise some tests fail. Also fixed the BUILD_SCRIPT template to correctly evaluate "V=1" for verbose output. Signed-off-by: Wainer dos Santos Moschetta Messag

[Qemu-devel] [PULL 01/52] editorconfig: add setting for shell scripts

2019-06-07 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/.editorconfig b/.editorconfig index df6db65531..a001f340bd 100644 --- a/.editorconfig +++ b/.editorconfig @@ -26,6 +26,10 @@ file_type_emacs = makefile indent_style = space indent_size = 4 +[*.sh] +indent_style = space +i

[Qemu-devel] [PULL 11/52] tests/vm: Add missing variables on help

2019-06-07 Thread Alex Bennée
From: Wainer dos Santos Moschetta Added description of variables missing on vm-test help. Signed-off-by: Wainer dos Santos Moschetta Message-Id: <20190329210804.22121-6-waine...@redhat.com> Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff

[Qemu-devel] [PATCH v17 12/24] target/rx: Add RX to SysEmuTarget

2019-06-07 Thread Yoshinori Sato
From: Richard Henderson Fixes check-qtest-rx: tests/qmp-cmd-test Signed-off-by: Richard Henderson Signed-off-by: Yoshinori Sato --- qapi/common.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/common.json b/qapi/common.json index 99d313ef3b..d0fc931159 100644 --

[Qemu-devel] [PULL 36/52] gdbstub: Implement continue (c pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Reviewed-by: Alex Bennée Message-Id: <20190529064148.19856-5-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index ad00f223f2..c3089a6b5a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1531,6 +1531,16 @@ static void handle_t

[Qemu-devel] [PULL 06/52] .travis.yml: bump gcc sanitiser job to gcc-9

2019-06-07 Thread Alex Bennée
The toolchain PPA has it so we might as well use it. We currently have to add: -Wno-error=stringop-truncation as there are still strncpy operations in the tree operating on things that haven't been annotated with QEMU_NONSTRING. Signed-off-by: Alex Bennée diff --git a/.travis.yml b/.travis.y

[Qemu-devel] [PULL 17/52] tests/vm: proper guest shutdown

2019-06-07 Thread Alex Bennée
From: Gerd Hoffmann When not running in snapshot mode ask the guest to poweroff and wait for this to finish instead of simply quitting qemu, so the guest can flush pending updates to disk. Signed-off-by: Gerd Hoffmann Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Phili

[Qemu-devel] [PATCH v17 20/24] target/rx: Use prt_ldmi for XCHG_mr disassembly

2019-06-07 Thread Yoshinori Sato
From: Richard Henderson Note that the ld == 3 case handled by prt_ldmi is decoded as XCHG_rr and cannot appear here. Reviewed-by: Yoshinori Sato Signed-off-by: Richard Henderson Signed-off-by: Yoshinori Sato --- target/rx/disas.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-)

[Qemu-devel] [PATCH] kvm-all: Add/update fprintf's for kvm_*_ioeventfd_del

2019-06-07 Thread Yury Kotov
Signed-off-by: Yury Kotov --- accel/kvm/kvm-all.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 524c4ddfbd..e4ac3386cb 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -864,8 +864,8 @@ static void kvm_

[Qemu-devel] [PULL 08/52] tests/vm: Use python configured on build

2019-06-07 Thread Alex Bennée
From: Wainer dos Santos Moschetta Changed the vm-test makefile to execute python scripts with the interpreter configured on build. This allows to run vm-test targets properly in Linux distros with Python 3 only support. Signed-off-by: Wainer dos Santos Moschetta Message-Id: <20190329210804.2212

[Qemu-devel] [PATCH v17 14/24] tests: Add rx to machine-none-test.c

2019-06-07 Thread Yoshinori Sato
From: Richard Henderson Fixes check-qtest-rx: tests/machine-none-test. Signed-off-by: Richard Henderson Signed-off-by: Yoshinori Sato --- tests/machine-none-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/machine-none-test.c b/tests/machine-none-test.c index 4c6d470798..80df2

[Qemu-devel] [PATCH v17 13/24] target/rx: Fix cpu types and names

2019-06-07 Thread Yoshinori Sato
From: Richard Henderson There was confusion here about abstract classes and naming cpus. We had registered a concrete class named "-rxcpu". This was put into the default cpu fields, and matched, so basic tests worked. However, no value for -cpu could ever match in rx_cpu_class_by_name. Rename t

[Qemu-devel] [PULL 38/52] gdbstub: Implement set_thread (H pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Reviewed-by: Alex Bennée Message-Id: <20190529064148.19856-7-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index 3425f0674d..7735c244b3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1560,6 +1560,51 @@ static void handle_c

[Qemu-devel] [PATCH v17 23/24] target/rx: Dump bytes for each insn during disassembly

2019-06-07 Thread Yoshinori Sato
From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Yoshinori Sato Signed-off-by: Richard Henderson Signed-off-by: Yoshinori Sato --- target/rx/disas.c |

[Qemu-devel] [PATCH v17 02/24] target/rx: TCG helper

2019-06-07 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Message-Id: <20190516055244.95559-3-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- target/rx/helper.h| 31 target/rx/helper.c| 148 target/rx/op_helper.c | 481 +

[Qemu-devel] [PATCH v17 11/24] target/rx: Convert to CPUClass::tlb_fill

2019-06-07 Thread Yoshinori Sato
From: Richard Henderson The interface for tlb_fill has changed very recently. Move the function into cpu.c so that it may be static while assigning to the CPUClass methods. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Signed-off-by: Yoshinori Sato --- target/rx/cpu.c

[Qemu-devel] [PATCH v17 09/24] qemu/bitops.h: Add extract8 and extract16

2019-06-07 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.95559-12-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- include/qemu/bitops.h | 38 ++ 1 file changed, 38 insertion

[Qemu-devel] [PATCH v17 17/24] MAINTAINERS: Add RX

2019-06-07 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.95559-13-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- MAINTAINERS | 19 +++ 1 file changed, 19 insertions(+) diff --git a/MAINTAINER

[Qemu-devel] [PATCH v17 08/24] hw/rx: RX Target hardware definition

2019-06-07 Thread Yoshinori Sato
rx62n - RX62N cpu. rx-virt - RX QEMU virtual target. Signed-off-by: Yoshinori Sato Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.95559-9-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- include/hw/rx/rx.h| 7 ++ include

[Qemu-devel] [PATCH v17 10/24] hw/registerfields.h: Add 8bit and 16bit register macros

2019-06-07 Thread Yoshinori Sato
Some RX peripheral using 8bit and 16bit registers. Added 8bit and 16bit APIs. Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.95559-11-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- include/hw/regis

[Qemu-devel] [PATCH v17 15/24] hw/rx: Honor -accel qtest

2019-06-07 Thread Yoshinori Sato
From: Richard Henderson Issue an error if no kernel, no bios, and not qtest'ing. Fixes make check-qtest-rx: test/qom-test. Signed-off-by: Richard Henderson Signed-off-by: Yoshinori Sato --- hw/rx/rx62n.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/rx/rx62n

[Qemu-devel] [PATCH v17 16/24] Add rx-softmmu

2019-06-07 Thread Yoshinori Sato
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato Message-Id: <20190516055244.95559-10-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- configure | 8 default-configs/rx-softmmu.mak | 3 +++ include

[Qemu-devel] [PATCH v17 01/24] target/rx: TCG translation

2019-06-07 Thread Yoshinori Sato
This part only supported RXv1 instructions. Instruction manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.95559-2-ys...@users

[Qemu-devel] [PATCH v17 00/24] Add RX archtecture support

2019-06-07 Thread Yoshinori Sato
Hello. This patch series is added Renesas RX target emulation. Changes v17. Remove cpu class name suffix. My git repository is bellow. git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20190607 Testing binaries bellow. u-boot Download - https://osdn.net/users/ysato/pf/qemu/dl/u

[Qemu-devel] [PATCH v17 24/24] target/rx: Remove suffix in cpu class.

2019-06-07 Thread Yoshinori Sato
New CPUs should not be suffixed like other devices. Signed-off-by: Yoshinori Sato --- include/hw/rx/rx62n.h | 2 +- target/rx/cpu.h | 3 +-- target/rx/cpu.c | 8 ++-- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/include/hw/rx/rx62n.h b/include/hw/rx/rx62n.h inde

[Qemu-devel] [PATCH v17 18/24] target/rx: Disassemble rx_index_addr into a string

2019-06-07 Thread Yoshinori Sato
From: Richard Henderson We were eliding all zero indexes. It is only ld==0 that does not have an index in the instruction. This also allows us to avoid breaking the final print into multiple pieces. Reviewed-by: Yoshinori Sato Signed-off-by: Richard Henderson Signed-off-by: Yoshinori Sato -

[Qemu-devel] [PATCH v17 22/24] target/rx: Collect all bytes during disassembly

2019-06-07 Thread Yoshinori Sato
From: Richard Henderson Collected, to be used in the next patch. Reviewed-by: Yoshinori Sato Signed-off-by: Richard Henderson Signed-off-by: Yoshinori Sato --- target/rx/disas.c | 62 +-- 1 file changed, 42 insertions(+), 20 deletions(-) d

[Qemu-devel] [PULL 42/52] gdbstub: Implement write memory (M pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Reviewed-by: Alex Bennée Message-Id: <20190529064148.19856-11-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index 63809b2ab9..681a0c8550 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1702,6 +1702,31 @@ static void handle_

[Qemu-devel] [PATCH v17 05/24] hw/intc: RX62N interrupt controller (ICUa)

2019-06-07 Thread Yoshinori Sato
This implementation supported only ICUa. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.95559-6-ys...@users.sourcefo

[Qemu-devel] [PATCH v17 07/24] hw/char: RX62N serial communication interface (SCI)

2019-06-07 Thread Yoshinori Sato
This module supported only non FIFO type. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.95559-8-ys...@users.sourcef

[Qemu-devel] [PATCH v17 21/24] target/rx: Emit all disassembly in one prt()

2019-06-07 Thread Yoshinori Sato
From: Richard Henderson Many of the multi-part prints have been eliminated by previous patches. Eliminate the rest of them. Reviewed-by: Yoshinori Sato Signed-off-by: Richard Henderson Signed-off-by: Yoshinori Sato --- target/rx/disas.c | 75 +

[Qemu-devel] [PULL 15/52] tests/vm: use ssh with pty unconditionally

2019-06-07 Thread Alex Bennée
From: Gerd Hoffmann Allways ask ssh to run with a pseudo terminal. Not having a terminal causes problems now and then. Signed-off-by: Gerd Hoffmann Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20190520124716.30472-5-kra...@redhat.c

[Qemu-devel] [PULL 29/52] tests/tcg: clean-up VPATH/TESTS for i386

2019-06-07 Thread Alex Bennée
Since we only run build the multiarch tests and we use a fully resolved path for the crt object we don't need the wildcard or VPATH messing about. Signed-off-by: Alex Bennée diff --git a/tests/tcg/i386/Makefile.softmmu-target b/tests/tcg/i386/Makefile.softmmu-target index e1f98177aa..e1d880f9b5

[Qemu-devel] [PATCH v17 19/24] target/rx: Replace operand with prt_ldmi in disassembler

2019-06-07 Thread Yoshinori Sato
From: Richard Henderson This has consistency with prt_ri(). It loads all data before beginning output. It uses exactly one call to prt() to emit the full instruction. Reviewed-by: Yoshinori Sato Signed-off-by: Richard Henderson Signed-off-by: Yoshinori Sato --- target/rx/disas.c | 77 +

[Qemu-devel] [PULL 32/52] cputlb: cast size_t to target_ulong before using for address masks

2019-06-07 Thread Alex Bennée
While size_t is defined to happily access the biggest host object this isn't the case when generating masks for 64 bit guests on 32 bit hosts. Otherwise we end up truncating the address when we fall back to our unaligned helper. Fixes: https://bugs.launchpad.net/qemu/+bug/1831545 Signed-off-by: A

[Qemu-devel] [PULL 45/52] gdbstub: Implement read all registers (g pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Reviewed-by: Alex Bennée Message-Id: <20190529064148.19856-14-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index 880bbb469a..b3c5ced80d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1774,6 +1774,21 @@ static void handle_

[Qemu-devel] [PULL 43/52] gdbstub: Implement read memory (m pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Reviewed-by: Alex Bennée Message-Id: <20190529064148.19856-12-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index 681a0c8550..ceaa47d184 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1727,6 +1727,30 @@ static void handle_

[Qemu-devel] [PULL 30/52] tests/tcg/x86_64: add a PVH crt.o for x86_64 system tests

2019-06-07 Thread Alex Bennée
Instead of doing the full real to 64 bit dance we are attempting to leverage Xen's PVH boot spec to go from 32 bit to 64 bit. Signed-off-by: Alex Bennée diff --git a/tests/tcg/i386/Makefile.softmmu-target b/tests/tcg/i386/Makefile.softmmu-target index e1d880f9b5..0a4364868c 100644 --- a/tests/t

[Qemu-devel] [PATCH v17 03/24] target/rx: CPU definition

2019-06-07 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Message-Id: <20190516055244.95559-4-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- target/rx/cpu.h | 227 target/rx/cpu.c | 222 +++

[Qemu-devel] [PULL 13/52] tests/vm: python3 fixes

2019-06-07 Thread Alex Bennée
From: Gerd Hoffmann Add proper unicode handling when processing strings. Also need to explicitly say we want int not float. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20190520124716.30472-3-kra...@redhat.com> [AJB: fix confl

[Qemu-devel] [PULL 27/52] cputlb: use uint64_t for interim values for unaligned load

2019-06-07 Thread Alex Bennée
When running on 32 bit TCG backends a wide unaligned load ends up truncating data before returning to the guest. We specifically have the return type as uint64_t to avoid any premature truncation so we should use the same for the interim types. Fixes: https://bugs.launchpad.net/qemu/+bug/1830872 F

[Qemu-devel] [PULL 26/52] semihosting: split console_out into string and char versions

2019-06-07 Thread Alex Bennée
This is ostensibly to avoid the weirdness of len looking like it might come from a guest and sometimes being used. While we are at it fix up the error checking for the arm-linux-user implementation of the API which got flagged up by Coverity (CID 1401700). Signed-off-by: Alex Bennée diff --git a

[Qemu-devel] [PATCH v17 06/24] hw/timer: RX62N internal timer modules

2019-06-07 Thread Yoshinori Sato
renesas_tmr: 8bit timer modules. renesas_cmt: 16bit compare match timer modules. This part use many renesas's CPU. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philip

[Qemu-devel] [PULL 25/52] tests/vm: ubuntu.i386: apt proxy setup

2019-06-07 Thread Alex Bennée
From: Gerd Hoffmann Configure apt proxy so package downloads can be cached and can pass firewalls. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190520124716.30472-15-kra...@redhat.com> Signed-off-by: Alex Bennée diff --git a/tests/vm/ubuntu.i386 b/tests/vm/

[Qemu-devel] [PULL 51/52] gdbstub: Clear unused variables in gdb_handle_packet

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Reviewed-by: Alex Bennée Message-Id: <20190529064148.19856-20-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index 26c0c30682..12671e6e11 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2284,17 +2284,11 @@ static void handle

[Qemu-devel] [PATCH v17 04/24] target/rx: RX disassembler

2019-06-07 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.95559-5-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- include/disas/dis-asm.h |5 + target/rx/disas.c | 1480 +

Re: [Qemu-devel] [Qemu-ppc] [PULL 09/29] target/ppc: introduce get_cpu_vsr{l, h}() and set_cpu_vsr{l, h}() helpers for VSR register access

2019-06-07 Thread Laurent Vivier
On 06/06/2019 22:21, Mark Cave-Ayland wrote: > On 06/06/2019 20:24, Laurent Vivier wrote: > >> On 05/06/2019 09:43, Laurent Vivier wrote: >>> On 05/06/2019 08:32, Mark Cave-Ayland wrote: On 04/06/2019 22:23, Laurent Vivier wrote: > This patch breaks something in the libcrypto. >

[Qemu-devel] [PULL 44/52] gdbstub: Implement write all registers (G pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Reviewed-by: Alex Bennée Message-Id: <20190529064148.19856-13-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index ceaa47d184..880bbb469a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1751,6 +1751,29 @@ static void handle_

[Qemu-devel] [PULL 20/52] tests/vm: serial console support helpers

2019-06-07 Thread Alex Bennée
From: Gerd Hoffmann Add a bunch of helpers to talk to the guest using the serial console. Also drop the hard-coded -serial parameter for the vm so QEMUMachine.set_console() actually works. Signed-off-by: Gerd Hoffmann Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Phil

[Qemu-devel] [PULL 23/52] tests/vm: netbsd autoinstall, using serial console

2019-06-07 Thread Alex Bennée
From: Gerd Hoffmann Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Signed-off-by: Gerd Hoffmann Reviewed-by:

[Qemu-devel] [PULL 16/52] tests/vm: run test builds on snapshot

2019-06-07 Thread Alex Bennée
From: Gerd Hoffmann The build script doesn't shutdown the guest VMs properly, which results in filesystem corruption and guest boot failures sooner or later. Use the --snapshot to run builds on a snapshot, That way killing the VM doesn't corrupt the base image. Signed-off-by: Gerd Hoffmann Tes

[Qemu-devel] [PULL 41/52] gdbstub: Implement get register (p pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Message-Id: <20190529064148.19856-10-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index 630f931765..63809b2ab9 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1672,6 +1672,36 @@ static void handle_set_reg(GdbCmdContext *gdb

[Qemu-devel] [PULL 40/52] gdbstub: Implement set register (P pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Message-Id: <20190529064148.19856-9-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index 8416f4c13f..630f931765 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1651,6 +1651,27 @@ static void handle_remove_bp(GdbCmdContext *gd

[Qemu-devel] [PULL 33/52] gdbstub: Add infrastructure to parse cmd packets

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Reviewed-by: Alex Bennée Message-Id: <20190529064148.19856-2-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index 462f89edfe..09fe5a4b99 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1268,6 +1268,201 @@ out: return re

[Qemu-devel] [PULL 19/52] tests/vm: add DEBUG=1 to help text

2019-06-07 Thread Alex Bennée
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Tested-by: Thomas Huth Message-Id: <20190520124716.30472-9-kra...@redhat.com> [AJB: fix minor conflict] Signed-off-by: Alex Bennée diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include index e32

[Qemu-devel] [PULL 18/52] tests/vm: add vm-boot-{ssh, serial}- targets

2019-06-07 Thread Alex Bennée
From: Gerd Hoffmann For testing/troubleshooting convinience. make vm-boot-serial- Boot guest, with the serial console on stdio. make vm-boot-ssh- Boot guest, login via ssh. Signed-off-by: Gerd Hoffmann Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathie

[Qemu-devel] [PULL 28/52] tests/tcg: better detect truncated reads

2019-06-07 Thread Alex Bennée
If we've truncated a wider read we can detect the condition earlier by looking at the number of zeros we've read. So we don't trip up on cases where we have written zeros to the start of the buffer we also ensure we only start each offset read from the right address. Signed-off-by: Alex Bennée d

[Qemu-devel] [PULL 31/52] MAINTAINERS: put myself forward for gdbstub

2019-06-07 Thread Alex Bennée
As I've been reviewing a lot of this recently and I'm going to put together a pull request I'd better keep an eye on it. Philippe has also volunteered to be a reviewer. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé dif

[Qemu-devel] [PULL 37/52] gdbstub: Implement continue with signal (C pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Reviewed-by: Alex Bennée Message-Id: <20190529064148.19856-6-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index c3089a6b5a..3425f0674d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1541,6 +1541,25 @@ static void handle_c

[Qemu-devel] [PULL 46/52] gdbstub: Implement file io (F pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Message-Id: <20190529064148.19856-15-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index b3c5ced80d..1871077cd7 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1789,6 +1789,25 @@ static void handle_read_all_regs(GdbCmdContex

[Qemu-devel] [PULL 50/52] gdbstub: Implement target halted (? pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Note: The user-mode thread-id has been correctly reported since bd88c780e6 Signed-off-by: Jon Doron Message-Id: <20190529064148.19856-19-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index c45cefd721..26c0c30682 100644 --- a/gdbstub.c +++ b/gd

[Qemu-devel] [PULL 39/52] gdbstub: Implement breakpoint commands (Z/z pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Message-Id: <20190529064148.19856-8-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index 7735c244b3..8416f4c13f 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -950,7 +950,7 @@ static inline int xlat_gdb_type(CPUState *cpu, in

[Qemu-devel] [PULL 48/52] gdbstub: Implement v commands with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Message-Id: <20190529064148.19856-17-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index 6fd276892a..5a4d10f1c0 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1818,6 +1818,106 @@ static void handle_step(GdbCmdContext *gdb_c

[Qemu-devel] [PULL 47/52] gdbstub: Implement step (s pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Reviewed-by: Alex Bennée Message-Id: <20190529064148.19856-16-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index 1871077cd7..6fd276892a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1808,6 +1808,16 @@ static void handle_

[Qemu-devel] [PULL 22/52] tests/vm: freebsd autoinstall, using serial console

2019-06-07 Thread Alex Bennée
From: Gerd Hoffmann Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Note that freebsd package downloads are de

[Qemu-devel] [Bug 1831545] Re: "accel/tcg: demacro cputlb" break qemu-system-x86_64 on 32-bit x86 host

2019-06-07 Thread Alex Bennée
** Changed in: qemu Status: New => In Progress ** Changed in: qemu Assignee: (unassigned) => Alex Bennée (ajbennee) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1831545 Title: "accel/

[Qemu-devel] [PULL 24/52] tests/vm: fedora autoinstall, using serial console

2019-06-07 Thread Alex Bennée
From: Gerd Hoffmann Download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Yes, we have docker images for fedora. But for trouble-shooting it might be helpful to have a

[Qemu-devel] [PULL 35/52] gdbstub: Implement thread_alive (T pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Reviewed-by: Alex Bennée Message-Id: <20190529064148.19856-4-ari...@gmail.com> Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index 120e52f5d2..ad00f223f2 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1507,6 +1507,30 @@ static void handle_d

[Qemu-devel] [PULL 21/52] tests/vm: openbsd autoinstall, using serial console

2019-06-07 Thread Alex Bennée
From: Gerd Hoffmann Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Signed-off-by: Gerd Hoffmann Reviewed-by:

[Qemu-devel] [PULL 49/52] gdbstub: Implement generic set/query (Q/q pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron The generic set/query packets contains implementation for varioius sub-commands which are required for GDB and also additional commands which are QEMU specific. To see which QEMU specific commands are available use the command gdb> maintenance packet qqemu.Supported Currently th

[Qemu-devel] [PULL 34/52] gdbstub: Implement deatch (D pkt) with new infra

2019-06-07 Thread Alex Bennée
From: Jon Doron Signed-off-by: Jon Doron Message-Id: <20190529064148.19856-3-ari...@gmail.com> Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée diff --git a/gdbstub.c b/gdbstub.c index 09fe5a4b99..120e52f5d2 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1413,11 +1413,6 @@ static inline int st

[Qemu-devel] [PULL 03/35] s390x/tcg: Implement VECTOR FIND ANY ELEMENT EQUAL

2019-06-07 Thread Cornelia Huck
From: David Hildenbrand Complicated stuff. Provide two different helpers for CC an !CC handling. We might want to add more helpers later. zero_search() and match_index() are courtesy of Richard H. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/Makefile.objs

  1   2   3   4   5   >