[Qemu-devel] [PATCH v2 2/2] BootLinuxConsoleTest: Test the SmartFusion2 board

2019-06-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Similar to the x86_64/pc test, it boots a Linux kernel on an Emcraft board and verify the serial is working. If ARM is a target being built, "make check-acceptance" will automatically include this test by the use of the "arch:arm" tags. Alternatively, this test can

Re: [Qemu-devel] [PATCHv4 4/6] RISC-V: Check PMP during Page Table Walks

2019-06-06 Thread Alistair Francis
On Wed, Jun 5, 2019 at 3:59 PM Hesham Almatary wrote: > > On Wed, 5 Jun 2019 at 23:07, Alistair Francis wrote: > > > > On Thu, May 30, 2019 at 6:52 AM Hesham Almatary > > wrote: > > > > > > The PMP should be checked when doing a page table walk, and report access > > > fault exception if the to-

[Qemu-devel] [PATCH v2 1/2] BootLinuxConsoleTest: Do not log empty lines

2019-06-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Avoid to log empty lines in console debug logs. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Acked-by: Aleksandar Markovic --- v2: no change --- tests/acceptance/boot_linux_console.py | 6 ++

[Qemu-devel] [Bug 1824053] Re: Qemu-img convert appears to be stuck on aarch64 host with low probability

2019-06-06 Thread dann frazier
*** This bug is a duplicate of bug 1805256 *** https://bugs.launchpad.net/bugs/1805256 ** This bug has been marked a duplicate of bug 1805256 qemu-img hangs on high core count ARM system -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH for-4.1 2/2] target/riscv: Add support for -bios "firmware_filename" flag

2019-06-06 Thread Alistair Francis
On Fri, May 31, 2019 at 3:38 PM Jonathan Behrens wrote: > > I've thought some more about this issue, and long term I think there are a > couple different useful configurations: > > For end users, having default firmware that loaded the OS from a block device > would be easiest > > Current invoca

[Qemu-devel] [PATCH v2 0/2] tests: Avocado-test for the SmartFusion2 board

2019-06-06 Thread Philippe Mathieu-Daudé
Hi, I added test guide lines from Subbaraya Sundeep [*] to avoid this board to bitrot. v2: Addressed issues reported by Cleber Regards, Phil. [*] https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg03810.html Philippe Mathieu-Daudé (2): BootLinuxConsoleTest: Do not log empty lines Bo

Re: [Qemu-devel] [PATCH] cputlb: cast size_t to target_ulong before using for address masks

2019-06-06 Thread Philippe Mathieu-Daudé
On 6/6/19 5:43 PM, Alex Bennée wrote: > While size_t is defined to happily access the biggest host object this > isn't the case when generating masks for 64 bit guests on 32 bit > hosts. Otherwise we end up truncating the address when we fall back to > our unaligned helper. > > Cc: Andrew Randrian

Re: [Qemu-devel] [PATCH v2 2/2] BootLinuxConsoleTest: Test the SmartFusion2 board

2019-06-06 Thread Cleber Rosa
On Fri, Jun 07, 2019 at 12:55:21AM +0200, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Similar to the x86_64/pc test, it boots a Linux kernel on an > Emcraft board and verify the serial is working. > > If ARM is a target being built, "make check-acceptance" will > automatical

Re: [Qemu-devel] [Qemu-devel PATCH v2 1/2] sd: Fix out-of-bounds assertions

2019-06-06 Thread Philippe Mathieu-Daudé
Hi, On 6/5/19 9:15 PM, Lidong Chen wrote: > Due to an off-by-one error, the assert statements allow an > out-of-bound array access. I believe this is a "v2 RESEND" patch, since there is no change with the other v2 posted here: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg00634.html So

Re: [Qemu-devel] [Qemu-devel PATCH v2 2/2] util/main-loop: Fix incorrect assertion

2019-06-06 Thread Philippe Mathieu-Daudé
On 6/5/19 9:15 PM, Lidong Chen wrote: > The check for poll_fds in g_assert() was incorrect. The correct assertion > should check "n_poll_fds + w->num <= ARRAY_SIZE(poll_fds)" because the > subsequent for-loop is doing access to poll_fds[n_poll_fds + i] where i > is in [0, w->num). > > Signed-off-b

Re: [Qemu-devel] [PATCH] MAINTAINERS: put myself forward for gdbstub

2019-06-06 Thread Philippe Mathieu-Daudé
Hi Alex, On 6/6/19 10:29 AM, Alex Bennée wrote: > As I've been reviewing a lot of this recently and I'm going to put > together a pull request I'd better keep an eye on it. > > Signed-off-by: Alex Bennée > --- > MAINTAINERS | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --g

[Qemu-devel] RISC-V: Include ROM in QEMU

2019-06-06 Thread Alistair Francis
Hello, As a test of the waters, how would the QEMU community feel about including the RISC-V OpenSBI project as a ROM submodule? The idea would be to have OpenSBI (similar to ATF for ARM and a BIOS for x86) included by default to simplify the QEMU RISC-V boot process for users. This would remove

Re: [Qemu-devel] [PATCH v3 2/2] BootLinuxConsoleTest: Run kerneltests BusyBox on Malta

2019-06-06 Thread Cleber Rosa
On Fri, Jun 07, 2019 at 01:02:32AM +0200, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > This tests boots a Linux kernel on a Malta machine up to a > busybox shell on the serial console. Few commands are executed > before halting the machine (via reboot). > > We use the initrd

Re: [Qemu-devel] [PATCH] hw: misc: Add Aspeed XDMA device

2019-06-06 Thread Philippe Mathieu-Daudé
Hi Eddie, On 6/4/19 12:09 AM, Eddie James wrote: > The XDMA engine embedded in the Aspeed SOCs performs PCI DMA operations > between the SOC (acting as a BMC) and a host processor in a server. If I got your model correctly, it does no DMA operation but simply answer correctly to the BMC, and set

[Qemu-devel] [PATCH v2] m68k comments break patch submission due to being incorrectly formatted

2019-06-06 Thread Lucien Murray-Pitts
Altering all comments in target/m68k to match Qemu coding styles so that future patches wont fail due to style breaches. Signed-off-by: Lucien Murray-Pitts --- Notes: v1->v2 - incorrectly made split-single line comments multiple single lines - added corrections for /** comments as

Re: [Qemu-devel] [PATCH] cputlb: cast size_t to target_ulong before using for address masks

2019-06-06 Thread Andrew Randrianasulu
В сообщении от Thursday 06 June 2019 20:04:07 Alex Bennée написал(а): > > Andrew Randrianasulu writes: > > > В сообщении от Thursday 06 June 2019 18:43:10 Alex Bennée написал(а): > >> addr1 = addr & ~((target_ulong)size - 1); > > > > yes, this fixes my hang! Thanks! > > Can I take that as a: >

Re: [Qemu-devel] [PATCH v2] m68k comments break patch submission due to being incorrectly formatted

2019-06-06 Thread Aleksandar Markovic
On Jun 7, 2019 1:42 AM, "Lucien Murray-Pitts" wrote: > > Altering all comments in target/m68k to match Qemu coding styles so that future > patches wont fail due to style breaches. > Are you saying that patches fail checkpatch checks even if the new code has only correct comment format? (Or, in ot

Re: [Qemu-devel] [PATCH v3 2/2] BootLinuxConsoleTest: Run kerneltests BusyBox on Malta

2019-06-06 Thread Aleksandar Markovic
On Jun 7, 2019 1:06 AM, "Philippe Mathieu-Daudé" wrote: > > From: Philippe Mathieu-Daudé > > This tests boots a Linux kernel on a Malta machine up to a > busybox shell on the serial console. Few commands are executed > before halting the machine (via reboot). > > We use the initrd cpio image from

Re: [Qemu-devel] [PATCH] ppc/xive: Make XIVE generate the proper interrupt types

2019-06-06 Thread David Gibson
On Thu, Jun 06, 2019 at 07:44:09PM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > It should be generic Hypervisor Virtualization interrupts for HV > directed rings and traditional External Interrupts for the OS directed > ring. > > Don't generate anything for the user ring as

Re: [Qemu-devel] [PATCH] ppc/pnv: activate the "dumpdtb" option on the powernv machine

2019-06-06 Thread David Gibson
On Thu, Jun 06, 2019 at 07:47:32PM +0200, Cédric Le Goater wrote: > This is a good way to debug the DT creation for current PowerNV > machines and new ones to come. > > Signed-off-by: Cédric Le Goater Applied, thanks. > --- > hw/ppc/pnv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --g

Re: [Qemu-devel] [PATCH] spapr: Don't use the "dual" interrupt controller mode with an old hypervisor

2019-06-06 Thread David Gibson
On Thu, Jun 06, 2019 at 07:08:59PM +0200, Greg Kurz wrote: > If KVM is too old to support XIVE native exploitation mode, we might end > up using the emulated XIVE after CAS. This is sub-optimal if KVM in-kernel > XICS is available, which is the case most of the time. This is intentional. A predic

Re: [Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-06 Thread David Gibson
On Thu, Jun 06, 2019 at 04:55:18PM +0530, Aravinda Prasad wrote: > > > On Thursday 06 June 2019 08:36 AM, David Gibson wrote: > > On Wed, May 29, 2019 at 11:10:57AM +0530, Aravinda Prasad wrote: > >> This patch includes migration support for machine check > >> handling. Especially this patch bloc

Re: [Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-06 Thread David Gibson
On Thu, Jun 06, 2019 at 02:10:48PM +0200, Greg Kurz wrote: > On Thu, 6 Jun 2019 16:45:30 +0530 > Aravinda Prasad wrote: > > > On Thursday 06 June 2019 11:36 AM, Greg Kurz wrote: > > > On Thu, 6 Jun 2019 13:06:14 +1000 > > > David Gibson wrote: > > > > > >> On Wed, May 29, 2019 at 11:10:57AM +

[Qemu-devel] lists.nongnu.org was upgraded today, one issue is still being worked out

2019-06-06 Thread Ian Kelling
I'm Ian Kelling, part of the FSF tech team that maintains the lists.nongnu.org server. The server is sending mail using a new ip which is causing a higher than average number of mail servers telling us to retry and send later as they hopefully decide we are legitimate. The only big provider doing

Re: [Qemu-devel] [PATCH 1/5] block/qcow2-bitmap: allow bitmap_list_load to return an error code

2019-06-06 Thread Eric Blake
On 6/6/19 1:41 PM, John Snow wrote: > This simply makes this function a little more convenient to call, and in > a forthcoming patch gives us a return code we can report to the > caller. (Which in turn makes THOSE functions easier to call.) > > While we're here, remove the offset+size arguments wh

Re: [Qemu-devel] [PATCH 2/5] block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap

2019-06-06 Thread Eric Blake
On 6/6/19 1:41 PM, John Snow wrote: > Instead of bdrv_can_store_new_bitmap, rework this as > bdrv_add_persistent_dirty_bitmap. This makes a more obvious symmetry > with bdrv_remove_persistent_dirty_bitmap. Most importantly, we are free > to modify the driver state because we know we ARE adding a bi

Re: [Qemu-devel] [PATCH 3/5] block/dirty-bitmap: rework bdrv_remove_persistent_dirty_bitmap

2019-06-06 Thread Eric Blake
On 6/6/19 1:41 PM, John Snow wrote: > Allow propagating error code information from > bdrv_remove_persistent_dirty_bitmap as well. > > Give it an interface that matches the newly revised > bdrv_add_persistent_dirty_bitmap, including removing the persistent flag > when the operation succeeds and re

Re: [Qemu-devel] [PATCH 4/5] block/qcow2-bitmap: Count queued bitmaps towards nb_bitmaps

2019-06-06 Thread Eric Blake
On 6/6/19 1:41 PM, John Snow wrote: > When we check to see if we can store a bitmap, we don't check how many > we've queued up. This can cause a problem saving bitmaps on close > instead of when we request them to be added. With the stricter add > interface, prohibit these bitmaps specifically. >

Re: [Qemu-devel] [PATCH 5/5] block/qcow2-bitmap: Count queued bitmaps towards directory_size

2019-06-06 Thread Eric Blake
On 6/6/19 1:41 PM, John Snow wrote: > Similarly to the previous commit, we need to also keep a ledger of the > additional directory size burden that we've not yet committed so we can > reject new additions sooner instead of later. > > Signed-off-by: John Snow > --- > block/qcow2.h| 1 +

Re: [Qemu-devel] [PATCH v6 1/7] block/nbd-client: split connection_co start out of nbd_client_connect

2019-06-06 Thread Eric Blake
On 4/11/19 12:27 PM, Vladimir Sementsov-Ogievskiy wrote: > nbd_client_connect is going to be used from connection_co, so, let's > refactor nbd_client_connect in advance, leaving io channel > configuration all in nbd_client_connect. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nb

Re: [Qemu-devel] [PATCH v6 2/7] block/nbd-client: use non-blocking io channel for nbd negotiation

2019-06-06 Thread Eric Blake
On 4/11/19 12:27 PM, Vladimir Sementsov-Ogievskiy wrote: > No reason to use blocking channel for negotiation and we'll benefit in > further reconnect feature, as qio_channel reads and writes will do > qemu_coroutine_yield while waiting for io completion. > > Signed-off-by: Vladimir Sementsov-Ogiev

Re: [Qemu-devel] [PATCH v6 3/7] block/nbd-client: move from quit to state

2019-06-06 Thread Eric Blake
On 4/11/19 12:27 PM, Vladimir Sementsov-Ogievskiy wrote: > To implement reconnect we need several states for the client: > CONNECTED, QUIT and two different CONNECTING states. CONNECTING states > will be added in the following patches. This patch implements CONNECTED > and QUIT. > > QUIT means, th

Re: [Qemu-devel] [PATCH v6 4/7] block/nbd: add cmdline and qapi parameter reconnect-delay

2019-06-06 Thread Eric Blake
On 4/11/19 12:27 PM, Vladimir Sementsov-Ogievskiy wrote: > Reconnect will be implemented in the following commit, so for now, > in semantics below, disconnect itself is a "serious error". > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 12 +++- > block/nbd-

Re: [Qemu-devel] Fwd: [j...@sing.id.au: atomic failures on qemu-system-riscv64]

2019-06-06 Thread Richard Henderson
> > Also, unless I'm misunderstanding something our implementation of LR/SC is > pretty broken. We're just using a CAS to check if the value changed, which > suffers from the ABA problem that LR/SC is there to fix in the first > place. I > might be missing something here, though, as it looks like

Re: [Qemu-devel] [PATCH v6 5/7] qemu-coroutine-sleep: introduce qemu_co_sleep_wake

2019-06-06 Thread Eric Blake
On 4/11/19 12:27 PM, Vladimir Sementsov-Ogievskiy wrote: > Introduce a function to gracefully wake-up a coroutine, sleeping in > qemu_co_sleep_ns() sleep. Maybe: Introduce a function to gracefully short-circuit the remainder of the delay for a coroutine sleeping in qemu_co_sleep_ns(). > > Signe

Re: [Qemu-devel] [PATCH v6 6/7] block/nbd-client: nbd reconnect

2019-06-06 Thread Eric Blake
On 4/11/19 12:27 PM, Vladimir Sementsov-Ogievskiy wrote: > Implement reconnect. To achieve this: > > 1. add new modes: >connecting-wait: means, that reconnecting is in progress, and there > were small number of reconnect attempts, so all requests are > waiting for the connection. >

Re: [Qemu-devel] [PATCH 15/18] Boot Linux Console Test: add a test for aarch64 + virt

2019-06-06 Thread Eduardo Habkost
On Fri, Feb 01, 2019 at 11:10:31AM -0500, Cleber Rosa wrote: > > > On 1/31/19 4:26 PM, Cleber Rosa wrote: > > > > > > On 1/31/19 3:21 PM, Cleber Rosa wrote: > >> > >> > >> On 1/31/19 3:02 PM, Wainer dos Santos Moschetta wrote: > >>> > >>> On 01/17/2019 04:56 PM, Cleber Rosa wrote: > Just l

Re: [Qemu-devel] [PATCH v2] m68k comments break patch submission due to being incorrectly formatted

2019-06-06 Thread Lucien Murray-Pitts
On Fri, Jun 07, 2019 at 01:58:05AM +0200, Aleksandar Markovic wrote: > On Jun 7, 2019 1:42 AM, "Lucien Murray-Pitts" > wrote: > > > > Altering all comments in target/m68k to match Qemu coding styles so that > future > > patches wont fail due to style breaches. > > > > Are you saying that patches

Re: [Qemu-devel] [PATCH 15/18] Boot Linux Console Test: add a test for aarch64 + virt

2019-06-06 Thread Eduardo Habkost
On Fri, Jun 07, 2019 at 12:26:48AM -0300, Eduardo Habkost wrote: > On Fri, Feb 01, 2019 at 11:10:31AM -0500, Cleber Rosa wrote: > > > > > > On 1/31/19 4:26 PM, Cleber Rosa wrote: > > > > > > > > > On 1/31/19 3:21 PM, Cleber Rosa wrote: > > >> > > >> > > >> On 1/31/19 3:02 PM, Wainer dos Santos

Re: [Qemu-devel] [PATCH 0/8] Optimize emulation of ten Altivec instructions: lvsl,

2019-06-06 Thread Howard Spoelstra
Hi, This series gives me several compilation errors. When compiled with --disable-werror, OSX 10.3 guest on qemu-system-ppc shows corrupted desktop graphics. Compiled with: ./configure --target-list="ppc-softmmu" --enable-sdl --enable-gtk && make -j8 gcc is: [hsp@fedora30 qemu-master]$ gcc -v U

Re: [Qemu-devel] [PATCH] vhost-user: fix reconnection support for host notifier

2019-06-06 Thread Tiwei Bie
Hi, On Thu, Jun 06, 2019 at 03:30:29PM +0200, Marc-André Lureau wrote: > Hi > > On Fri, Apr 26, 2019 at 8:32 AM Tiwei Bie wrote: > > > > We need to destroy the host notifiers when cleaning up > > the backend. Otherwise, some resources are not released > > after the connection is closed, and it m

<    1   2   3   4