Re: [Qemu-devel] [qemu-s390x] [PATCH v3 06/10] hw/s390x: Replace global smp variables with machine smp properties

2019-06-06 Thread Christian Borntraeger
On 06.06.19 04:56, Eduardo Habkost wrote: > On Sun, May 19, 2019 at 04:54:24AM +0800, Like Xu wrote: >> The global smp variables in s390x are replaced with smp machine properties. >> >> A local variable of the same name would be introduced in the declaration >> phase if it's used widely in the c

Re: [Qemu-devel] [PATCH v2 5/5] block/nvme: add support for discard

2019-06-06 Thread Maxim Levitsky
On Thu, 2019-06-06 at 11:19 +0800, Fam Zheng wrote: > On Wed, 04/17 22:53, Maxim Levitsky wrote: > > Signed-off-by: Maxim Levitsky > > --- > > block/nvme.c | 80 ++ > > block/trace-events | 2 ++ > > 2 files changed, 82 insertions(+) > > > > dif

Re: [Qemu-devel] [PATCH v4 08/11] numa: Extend the command-line to provide memory latency and bandwidth information

2019-06-06 Thread Tao Xu
On 6/5/2019 10:40 PM, Igor Mammedov wrote: On Wed, 8 May 2019 14:17:23 +0800 Tao Xu wrote: From: Liu Jingqi Add -numa hmat-lb option to provide System Locality Latency and Bandwidth Information. These memory attributes help to build System Locality Latency and Bandwidth Information Structur

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 5/6] ppc: spapr: Enable FWNMI capability

2019-06-06 Thread Aravinda Prasad
On Thursday 06 June 2019 08:32 AM, David Gibson wrote: > On Tue, Jun 04, 2019 at 12:15:26PM +0530, Aravinda Prasad wrote: >> >> >> On Monday 03 June 2019 08:55 PM, Greg Kurz wrote: >>> On Wed, 29 May 2019 11:10:49 +0530 >>> Aravinda Prasad wrote: >>> Enable the KVM capability KVM_CAP_PPC_F

Re: [Qemu-devel] [PATCH v3 06/10] hw/s390x: Replace global smp variables with machine smp properties

2019-06-06 Thread Cornelia Huck
On Wed, 5 Jun 2019 23:56:35 -0300 Eduardo Habkost wrote: > On Sun, May 19, 2019 at 04:54:24AM +0800, Like Xu wrote: > > The global smp variables in s390x are replaced with smp machine properties. > > > > A local variable of the same name would be introduced in the declaration > > phase if it's u

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 04/10] hw/ppc: Replace global smp variables with machine smp properties

2019-06-06 Thread Greg Kurz
On Thu, 6 Jun 2019 13:07:32 +1000 David Gibson wrote: > On Wed, Jun 05, 2019 at 11:54:56PM -0300, Eduardo Habkost wrote: > > On Wed, Jun 05, 2019 at 11:52:41PM -0300, Eduardo Habkost wrote: > > > On Sun, May 19, 2019 at 04:54:22AM +0800, Like Xu wrote: > > > > The global smp variables in ppc

[Qemu-devel] [PATCH 2/6] migration/multifd: notify channels_ready when send thread starts

2019-06-06 Thread Wei Yang
multifd_send_state->channels_ready is initialized to 0. It is proper to let main thread know we are ready when thread start running. Current implementation works since ram_save_setup() calls multifd_send_sync_main() which wake up send thread and posts channels_ready. This behavior will introduce s

Re: [Qemu-devel] [PATCH 07/13] target/arm/kvm: max cpu: Allow sve max vector length setting

2019-06-06 Thread Auger Eric
Hi Drew, On 5/12/19 10:36 AM, Andrew Jones wrote: > Allow the cpu type 'max' sve-max-vq property to work with kvm > too. If the property is not specified then the maximum kvm > supports is used. If it is specified we check that kvm supports > that exact length or error out if it doesn't. > > Signe

[Qemu-devel] [PATCH 4/6] migration/multifd: used must not be 0 for a pending job

2019-06-06 Thread Wei Yang
After thread synchronization request is handled in another case, this means when we only get pending_job when there is used pages. Signed-off-by: Wei Yang --- migration/ram.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 9982

[Qemu-devel] [PATCH 6/6] migration/multifd: there is no spurious wakeup now

2019-06-06 Thread Wei Yang
The spurious wakeup is gone. Signed-off-by: Wei Yang --- migration/ram.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 831b15833b..2490631d52 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1153,9 +1153,6 @@ static void *multifd_send_thread(

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 04/10] hw/ppc: Replace global smp variables with machine smp properties

2019-06-06 Thread Like Xu
On 2019/6/6 16:20, Greg Kurz wrote: On Thu, 6 Jun 2019 13:07:32 +1000 David Gibson wrote: On Wed, Jun 05, 2019 at 11:54:56PM -0300, Eduardo Habkost wrote: On Wed, Jun 05, 2019 at 11:52:41PM -0300, Eduardo Habkost wrote: On Sun, May 19, 2019 at 04:54:22AM +0800, Like Xu wrote: The global smp

[Qemu-devel] [PATCH 3/6] migration/multifd: use sync field to synchronize send threads

2019-06-06 Thread Wei Yang
Add a field in MultiFDSendParams to indicate there is a request to synchronize send threads. By doing so, send_thread will just post sem_sync on synchronization request and channels_ready will not *overflow*. Signed-off-by: Wei Yang --- migration/ram.c | 30 -- 1 fil

[Qemu-devel] [PATCH 0/6] multifd: a new mechanism for send thread sync

2019-06-06 Thread Wei Yang
Current send thread could work while the sync mechanism has some problem: * has spuriously wakeup * number of channels_ready will *overflow* the number of real channels The reason is: * if MULTIFD_FLAG_SYNC is set in the middle of send thread running, there is one more spurious wakeup

[Qemu-devel] [PATCH 5/6] migration/multifd: use boolean for pending_job is enough

2019-06-06 Thread Wei Yang
After synchronization request is handled in another case, there only could be one pending_job for one send thread at most. This is fine to use boolean to represent this behavior. Signed-off-by: Wei Yang --- migration/ram.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --g

Re: [Qemu-devel] [PATCH v6 4/6] include/elf: Add defines related to notes for GNU systems

2019-06-06 Thread Markus Armbruster
Aleksandar Markovic writes: > On Jun 5, 2019 11:03 PM, "Richard Henderson" > wrote: >> >> This is a collection of related > > Related to what? > >> defines for notes, copied >> from glibc's . We're not going to use all of these >> right away, but it seemed foolish > > I don't think this an appr

[Qemu-devel] [PATCH] MAINTAINERS: put myself forward for gdbstub

2019-06-06 Thread Alex Bennée
As I've been reviewing a lot of this recently and I'm going to put together a pull request I'd better keep an eye on it. Signed-off-by: Alex Bennée --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a96829ea83..8ef34cf1ce 100644

[Qemu-devel] [PATCH 1/6] migration/multifd: move MultiFDSendParams handling into multifd_send_fill_packet()

2019-06-06 Thread Wei Yang
Currently there is only one user of multifd_send_fill_packet(). We enlarge the responsibility of it to adjust MultiFDSendParams. Signed-off-by: Wei Yang --- migration/ram.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index bd3

Re: [Qemu-devel] QEMU/KVM migration backwards compatibility broken?

2019-06-06 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > Hi, > > Looking at QEMU source code, I am puzzled regarding how migration backwards > compatibility is preserved regarding X86CPU. > > As I understand it, fields that are based on KVM capabilities and guest > runtime usage are defined in VMState sub

Re: [Qemu-devel] [PATCH 07/13] target/arm/kvm: max cpu: Allow sve max vector length setting

2019-06-06 Thread Andrew Jones
On Thu, Jun 06, 2019 at 10:30:00AM +0200, Auger Eric wrote: > Hi Drew, > On 5/12/19 10:36 AM, Andrew Jones wrote: > > Allow the cpu type 'max' sve-max-vq property to work with kvm > > too. If the property is not specified then the maximum kvm > > supports is used. If it is specified we check that k

Re: [Qemu-devel] QEMU/KVM migration backwards compatibility broken?

2019-06-06 Thread Liran Alon
> On 6 Jun 2019, at 11:42, Dr. David Alan Gilbert wrote: > > * Liran Alon (liran.a...@oracle.com) wrote: >> Hi, >> >> Looking at QEMU source code, I am puzzled regarding how migration backwards >> compatibility is preserved regarding X86CPU. >> >> As I understand it, fields that are based o

Re: [Qemu-devel] [PATCH v4 0/3] numa: deprecate '-numa node, mem' and default memory distribution

2019-06-06 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 03:06:08PM -0300, Eduardo Habkost wrote: > On Wed, Jun 05, 2019 at 06:33:11PM +0100, Daniel P. Berrangé wrote: > [...] > > I wonder if there's a way to close the testing gap somehow ? Random idea > > would be a non-versioned "pc-no-deprecated" machine type, which blocks > >

Re: [Qemu-devel] Deprecation policy and build dependencies

2019-06-06 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 03:42:39PM -0500, Eric Blake wrote: > On 6/5/19 3:13 PM, Eduardo Habkost wrote: > > >> IOW, I don't think RHEL-7 support as a build platform blocks us from > >> dropping py2. We merely need to tweak our build platforms doc to clarify > >> our intent wrt add-on yum repos. >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vhost: fix incorrect print type

2019-06-06 Thread Laurent Vivier
Le 29/05/2019 à 15:13, Philippe Mathieu-Daudé a écrit : > Cc'ing qemu-trivial > > On 4/30/19 10:48 AM, Philippe Mathieu-Daudé wrote: >> On 4/30/19 8:29 AM, Jie Wang wrote: >>> fix incorrect print type in vhost_virtqueue_stop >>> >>> Signed-off-by: Jie Wang >>> --- >>> hw/virtio/vhost.c | 2 +- >>

Re: [Qemu-devel] [Qemu-trivial] [PATCH] util: Adjust qemu_guest_getrandom_nofail for Coverity

2019-06-06 Thread Laurent Vivier
Le 30/05/2019 à 19:38, Richard Henderson a écrit : > Explicitly ignore the return value of qemu_guest_getrandom. > Because we use error_fatal, all errors are already caught. > > Fixes: CID 1401701 > Signed-off-by: Richard Henderson > --- > util/guest-random.c | 2 +- > 1 file changed, 1 insertio

Re: [Qemu-devel] [Qemu-trivial] [PATCH] test: Fix make target check-report.tap

2019-06-06 Thread Laurent Vivier
Le 04/06/2019 à 10:42, Philippe Mathieu-Daudé a écrit : > On 6/4/19 10:28 AM, Paolo Bonzini wrote: >> On 04/06/19 10:09, Philippe Mathieu-Daudé wrote: check-report.tap: $(patsubst %,check-report-qtest-%.tap, $(QTEST_TARGETS)) check-report-unit.tap - $(call quiet-command,./scripts/

Re: [Qemu-devel] QEMU/KVM migration backwards compatibility broken?

2019-06-06 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > > > > On 6 Jun 2019, at 11:42, Dr. David Alan Gilbert wrote: > > > > * Liran Alon (liran.a...@oracle.com) wrote: > >> Hi, > >> > >> Looking at QEMU source code, I am puzzled regarding how migration > >> backwards compatibility is preserved regardi

Re: [Qemu-devel] Deprecation policy and build dependencies

2019-06-06 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 03:13:08PM -0300, Eduardo Habkost wrote: > On Wed, Jun 05, 2019 at 04:44:03PM +0100, Daniel P. Berrangé wrote: > [...] > > Thus to answer your python 2 question, we should ask which of our build > > targets cannot support python 3 ? > > > > Obviously we know the answer to t

[Qemu-devel] [PATCH] nvme: do not advertise support for unsupported arbitration mechanism

2019-06-06 Thread Klaus Birkelund Jensen
The device mistakenly reports that the Weighted Round Robin with Urgent Priority Class arbitration mechanism is supported. It is not. Signed-off-by: Klaus Birkelund Jensen --- hw/block/nvme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 30e50f7a3853

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] docs/devel/build-system: Update an example

2019-06-06 Thread Laurent Vivier
Le 29/05/2019 à 16:05, Philippe Mathieu-Daudé a écrit : > The default-configs/ example added in 717171bd2025 is no > more accurate since fa212a2b8b60 (and various further other > commits). > > The Kconfig build system is now in place. > Use the aarch64-softmmu config as example. > > Reviewed-by:

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 01/10] hw/scsi/vmw_pvscsi: Use qbus_reset_all() directly

2019-06-06 Thread Laurent Vivier
Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit : > Since the BusState is accesible from the SCSIBus object, > it is pointless to use qbus_reset_all_fn. > Use qbus_reset_all() directly. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Use BUS() macro (Peter Maydell) > > One step towar

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 03/10] hw/pci-bridge: Use the QOM BUS() macro to access BusState.qbus

2019-06-06 Thread Laurent Vivier
Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit : > Rather than looking inside the definition of a BusState with "s->bus.qbus", > use the QOM prefered style: "BUS(&s->bus)". > > This patch was generated using the following Coccinelle script: > > // Use BUS() macros to access BusState.qb

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 04/10] hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbus

2019-06-06 Thread Laurent Vivier
Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit : > Rather than looking inside the definition of a BusState with "s->bus.qbus", > use the QOM prefered style: "BUS(&s->bus)". > > This patch was generated using the following Coccinelle script: > > // Use BUS() macros to access BusState.qb

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 07/10] hw/isa: Use the QOM DEVICE() macro to access DeviceState.qdev

2019-06-06 Thread Laurent Vivier
Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit : > Rather than looking inside the definition of a DeviceState with > "s->qdev", use the QOM prefered style: "DEVICE(s)". > > This patch was generated using the following Coccinelle script: > > // Use DEVICE() macros to access DeviceState.

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 08/10] hw/usb-storage: Use the QOM DEVICE() macro to access DeviceState.qdev

2019-06-06 Thread Laurent Vivier
Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit : > Rather than looking inside the definition of a DeviceState with > "s->qdev", use the QOM prefered style: "DEVICE(s)". > > This patch was generated using the following Coccinelle script: > > // Use DEVICE() macros to access DeviceState.

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 09/10] hw/vfio/pci: Use the QOM DEVICE() macro to access DeviceState.qdev

2019-06-06 Thread Laurent Vivier
Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit : > Rather than looking inside the definition of a DeviceState with > "s->qdev", use the QOM prefered style: "DEVICE(s)". > > This patch was generated using the following Coccinelle script: > > // Use DEVICE() macros to access DeviceState.

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 02/10] hw/scsi: Use the QOM BUS() macro to access BusState.qbus

2019-06-06 Thread Laurent Vivier
Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit : > Rather than looking inside the definition of a BusState with "s->bus.qbus", > use the QOM prefered style: "BUS(&s->bus)". > > This patch was generated using the following Coccinelle script: > > // Use BUS() macros to access BusState.qb

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 10/10] hw/watchdog/wdt_i6300esb: Use DEVICE() macro to access DeviceState.qdev

2019-06-06 Thread Laurent Vivier
Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit : > Rather than looking inside the definition of a DeviceState with > "s->qdev", use the QOM prefered style: "DEVICE(s)". > > This patch was generated using the following Coccinelle script: > > // Use DEVICE() macros to access DeviceState.

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 06/10] hw/audio/ac97: Use the QOM DEVICE() macro to access DeviceState.qdev

2019-06-06 Thread Laurent Vivier
Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit : > Rather than looking inside the definition of a DeviceState with > "s->qdev", use the QOM prefered style: "DEVICE(s)". > > This patch was generated using the following Coccinelle script > (with a bit of manual fix-up, removing an extra space

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 05/10] hw/sd: Use the QOM BUS() macro to access BusState.qbus

2019-06-06 Thread Laurent Vivier
Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit : > Rather than looking inside the definition of a BusState with "s->bus.qbus", > use the QOM prefered style: "BUS(&s->bus)". > > This patch was generated using the following Coccinelle script: > > // Use BUS() macros to access BusState.qb

Re: [Qemu-devel] Qemu baseline requirements/portability?

2019-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2019 at 07:30:08AM +0200, Markus Armbruster wrote: > "H. Peter Anvin" writes: > > > On 6/5/19 12:55 PM, H. Peter Anvin wrote: > >> Hi, > >> > >> I am writing some code I'm hoping will be able to make it into Qemu, but I > >> can't seem to find what the baseline portability requir

Re: [Qemu-devel] [PATCH v6 1/6] linux-user/aarch64: Reset btype for syscalls and signalsy

2019-06-06 Thread Dave Martin
On Wed, Jun 05, 2019 at 09:57:01PM +0100, Richard Henderson wrote: > The value of btype for syscalls is CONSTRAINED UNPREDICTABLE, > so we need to make sure that the value is 0 before clone, > fork, or syscall return. > > The kernel sets btype for the signal handler as if for a call. > > Signed-o

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 02/10] hw/scsi: Use the QOM BUS() macro to access BusState.qbus

2019-06-06 Thread Laurent Vivier
Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit : > Rather than looking inside the definition of a BusState with "s->bus.qbus", > use the QOM prefered style: "BUS(&s->bus)". > > This patch was generated using the following Coccinelle script: > > // Use BUS() macros to access BusState.qb

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 10/10] hw/watchdog/wdt_i6300esb: Use DEVICE() macro to access DeviceState.qdev

2019-06-06 Thread Laurent Vivier
Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit : > Rather than looking inside the definition of a DeviceState with > "s->qdev", use the QOM prefered style: "DEVICE(s)". > > This patch was generated using the following Coccinelle script: > > // Use DEVICE() macros to access DeviceState.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] scripts/qmp: fix deleted link in qemu-ga-client script

2019-06-06 Thread Laurent Vivier
Le 07/05/2019 à 20:41, Rami Rosen a écrit : > This patch fixes a deleted link in qemu-ga-client script. > According to the old link, the page moved to > https://wiki.qemu.org/Features/QAPI/GuestAgent. > > Signed-off-by: Rami Rosen > --- > scripts/qmp/qemu-ga-client | 2 +- > 1 file changed, 1 i

Re: [Qemu-devel] [PATCH v2 2/2] blockjob: use blk_new_pinned in block_job_create

2019-06-06 Thread Kevin Wolf
Am 05.06.2019 um 19:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > 05.06.2019 20:11, Kevin Wolf wrote: > > Am 05.06.2019 um 14:32 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> child_role job already has .stay_at_node=true, so on bdrv_replace_node > >> operation these child are unchanged. M

Re: [Qemu-devel] QEMU/KVM migration backwards compatibility broken?

2019-06-06 Thread Liran Alon
> On 6 Jun 2019, at 12:23, Dr. David Alan Gilbert wrote: > > * Liran Alon (liran.a...@oracle.com) wrote: >> >> >>> On 6 Jun 2019, at 11:42, Dr. David Alan Gilbert wrote: >>> >>> * Liran Alon (liran.a...@oracle.com) wrote: Hi, Looking at QEMU source code, I am puzzled regard

Re: [Qemu-devel] [PATCH v6 5/6] linux-user: Parse NT_GNU_PROPERTY_TYPE_0 notes

2019-06-06 Thread Dave Martin
On Wed, Jun 05, 2019 at 09:57:05PM +0100, Richard Henderson wrote: > For aarch64, this includes the GNU_PROPERTY_AARCH64_FEATURE_1_BTI bit, > which indicates that the image should be mapped with guarded pages. Heads-up: for arm64 I plan to move to making PT_GNU_PROPERTY authoritiative for ELF on l

[Qemu-devel] [PATCH] qapi: InitSocketAddress: add keepalive option

2019-06-06 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! This is a continuation of "[PATCH v2 0/2] nbd: enable keepalive", but it's a try from another side, so almost nothing common with v2. qapi/sockets.json | 5 - util/qemu-sockets.c | 13 + 2 files changed, 17 insertions(

[Qemu-devel] [PATCH 2/8] target/ppc: Optimize emulation of vsl and vsr instructions

2019-06-06 Thread Stefan Brankovic
Optimization of altivec instructions vsl and vsr(Vector Shift Left/Rigt). Perform shift operation (left and right respectively) on 128 bit value of register vA by value specified in bits 125-127 of register vB. Lowest 3 bits in each byte element of register vB must be identical or result is undefin

[Qemu-devel] [PATCH 1/8] target/ppc: Optimize emulation of lvsl and lvsr instructions

2019-06-06 Thread Stefan Brankovic
Adding simple macro that is calling tcg implementation of appropriate instruction if altivec support is active. Optimization of altivec instruction lvsl (Load Vector for Shift Left). Place bytes sh:sh+15 of value 0x00 || 0x01 || 0x02 || ... || 0x1E || 0x1F in destination register. Sh is calculated

[Qemu-devel] [PATCH 7/8] target/ppc: Optimize emulation of vclzh and vclzb instructions

2019-06-06 Thread Stefan Brankovic
Optimize Altivec instruction vclzh (Vector Count Leading Zeros Halfword). This instruction counts the number of leading zeros of each halfword element in source register and places result in the appropriate halfword element of destination register. In each iteration of outer for loop we perform co

[Qemu-devel] [PATCH 0/8] Optimize emulation of ten Altivec instructions: lvsl,

2019-06-06 Thread Stefan Brankovic
This series buils up on and complements recent work of Thomas Murta, Mark Cave-Ayland and Richard Henderson in the same area. It is based on devising TCG translation implementation for selected instructions rather than using helpers. The selected instructions are most of the time idiosyncratic to p

[Qemu-devel] [PATCH 4/8] target/ppc: Optimize emulation of vgbbd instruction

2019-06-06 Thread Stefan Brankovic
Optimize altivec instruction vgbbd (Vector Gather Bits by Bytes by Doubleword) All ith bits (i in range 1 to 8) of each byte of doubleword element in source register are concatenated and placed into ith byte of appropriate doubleword element in destination register. Following solution is done for

[Qemu-devel] [PATCH 6/8] target/ppc: Optimize emulation of vclzw instruction

2019-06-06 Thread Stefan Brankovic
Optimize Altivec instruction vclzw (Vector Count Leading Zeros Word). This instruction counts the number of leading zeros of each word element in source register and places result in the appropriate word element of destination register. We perform counting in two iterations of for loop(one for eac

[Qemu-devel] [PATCH 5/8] target/ppc: Optimize emulation of vclzd instruction

2019-06-06 Thread Stefan Brankovic
Optimize Altivec instruction vclzd (Vector Count Leading Zeros Doubleword). This instruction counts the number of leading zeros of each doubleword element in source register and places result in the appropriate doubleword element of destination register. Using tcg-s count leading zeros instruction

[Qemu-devel] [PATCH 8/8] target/ppc: Refactor emulation of vmrgew and vmrgow instructions

2019-06-06 Thread Stefan Brankovic
Since I found this two instructions implemented with tcg, I refactored them so they are consistent with other similar implementations that I introduced in this patch. Also had to add new dual macro GEN_VXFORM_TRANS_DUAL. We use this macro if one instruction is realized with direct translation, and

[Qemu-devel] [PATCH 3/8] target/ppc: Optimize emulation of vpkpx instruction

2019-06-06 Thread Stefan Brankovic
Optimize altivec instruction vpkpx (Vector Pack Pixel). Rearranges 8 pixels coded in 6-5-5 pattern (4 from each source register) into contigous array of bits in the destination register. In each iteration of outer loop we do the 6-5-5 pack for 2 pixels of each doubleword element of each source reg

Re: [Qemu-devel] [PATCH v6 6/6] tests/tcg/aarch64: Add bti smoke test

2019-06-06 Thread Dave Martin
On Wed, Jun 05, 2019 at 09:57:06PM +0100, Richard Henderson wrote: > This will build with older toolchains, without the upstream support > for -mbranch-protection. Such a toolchain will produce a warning > in such cases, > > ld: warning: /tmp/ccyZt0kq.o: unsupported GNU_PROPERTY_TYPE (5) \ > type

Re: [Qemu-devel] QEMU/KVM migration backwards compatibility broken?

2019-06-06 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > > > > On 6 Jun 2019, at 12:23, Dr. David Alan Gilbert wrote: > > > > * Liran Alon (liran.a...@oracle.com) wrote: > >> > >> > >>> On 6 Jun 2019, at 11:42, Dr. David Alan Gilbert > >>> wrote: > >>> > >>> * Liran Alon (liran.a...@oracle.com) wrote

Re: [Qemu-devel] [PULL 0/5] Migration patches

2019-06-06 Thread Peter Maydell
On Wed, 5 Jun 2019 at 12:55, Juan Quintela wrote: > > The following changes since commit 47fbad45d47af8af784bb12a5719489edcd89b4c: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2019-06-04 17:22:42 +0100) > > are available in the Git repository at: > > http

Re: [Qemu-devel] QEMU/KVM migration backwards compatibility broken?

2019-06-06 Thread Liran Alon
> On 6 Jun 2019, at 13:39, Dr. David Alan Gilbert wrote: > > * Liran Alon (liran.a...@oracle.com) wrote: >> >> >>> On 6 Jun 2019, at 12:23, Dr. David Alan Gilbert wrote: >>> >>> * Liran Alon (liran.a...@oracle.com) wrote: > On 6 Jun 2019, at 11:42, Dr. David Alan Gilbert

[Qemu-devel] [PULL 07/16] hw/scsi/vmw_pvscsi: Use qbus_reset_all() directly

2019-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Since the BusState is accesible from the SCSIBus object, it is pointless to use qbus_reset_all_fn. Use qbus_reset_all() directly. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dmitry Fleytman Message-Id: <20190528164020.32250-2-phi...@redhat.com> Signed-off-by

[Qemu-devel] [PULL 11/16] hw/usb-storage: Use the QOM DEVICE() macro to access DeviceState.qdev

2019-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Rather than looking inside the definition of a DeviceState with "s->qdev", use the QOM prefered style: "DEVICE(s)". This patch was generated using the following Coccinelle script: // Use DEVICE() macros to access DeviceState.qdev @use_device_macro_to_access_

[Qemu-devel] [PULL 06/16] docs/devel/build-system: Update an example

2019-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé The default-configs/ example added in 717171bd2025 is no more accurate since fa212a2b8b60 (and various further other commits). The Kconfig build system is now in place. Use the aarch64-softmmu config as example. Reviewed-by: Thomas Huth Signed-off-by: Philippe Math

[Qemu-devel] [PULL 04/16] util: Adjust qemu_guest_getrandom_nofail for Coverity

2019-06-06 Thread Laurent Vivier
From: Richard Henderson Explicitly ignore the return value of qemu_guest_getrandom. Because we use error_fatal, all errors are already caught. Fixes: CID 1401701 Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190530173824.30699-1

[Qemu-devel] [PULL 09/16] hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbus

2019-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Rather than looking inside the definition of a BusState with "s->bus.qbus", use the QOM prefered style: "BUS(&s->bus)". This patch was generated using the following Coccinelle script: // Use BUS() macros to access BusState.qbus @use_bus_macro_to_access_qbus@

[Qemu-devel] [PULL 03/16] vhost: fix incorrect print type

2019-06-06 Thread Laurent Vivier
From: Jie Wang fix incorrect print type in vhost_virtqueue_stop Signed-off-by: Jie Wang Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1556605773-42019-1-git-send-email-wangji...@huawei.com> Signed-off-by: Laurent Vivier --- hw/virtio/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[Qemu-devel] [PULL 14/16] hw/sd: Use the QOM BUS() macro to access BusState.qbus

2019-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Rather than looking inside the definition of a BusState with "s->bus.qbus", use the QOM prefered style: "BUS(&s->bus)". This patch was generated using the following Coccinelle script: // Use BUS() macros to access BusState.qbus @use_bus_macro_to_access_qbus@

[Qemu-devel] [PULL 08/16] hw/pci-bridge: Use the QOM BUS() macro to access BusState.qbus

2019-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Rather than looking inside the definition of a BusState with "s->bus.qbus", use the QOM prefered style: "BUS(&s->bus)". This patch was generated using the following Coccinelle script: // Use BUS() macros to access BusState.qbus @use_bus_macro_to_access_qbus@

[Qemu-devel] [PULL 01/16] hw/rdma: Delete unused headers inclusion

2019-06-06 Thread Laurent Vivier
From: Yuval Shaia This is a trivial cleanup patch. Signed-off-by: Yuval Shaia Reviewed-by: Kamal Heib Message-Id: <20190505105112.22691-1-yuval.sh...@oracle.com> Signed-off-by: Laurent Vivier --- hw/rdma/rdma_backend.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/hw/rdma/rdma_ba

Re: [Qemu-devel] QEMU/KVM migration backwards compatibility broken?

2019-06-06 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > > > > On 6 Jun 2019, at 13:39, Dr. David Alan Gilbert wrote: > > > > * Liran Alon (liran.a...@oracle.com) wrote: > >> > >> > >>> On 6 Jun 2019, at 12:23, Dr. David Alan Gilbert > >>> wrote: > >>> > >>> * Liran Alon (liran.a...@oracle.com) wrote

[Qemu-devel] [PULL 13/16] hw/audio/ac97: Use the QOM DEVICE() macro to access DeviceState.qdev

2019-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Rather than looking inside the definition of a DeviceState with "s->qdev", use the QOM prefered style: "DEVICE(s)". This patch was generated using the following Coccinelle script (with a bit of manual fix-up, removing an extra space to please checkpatch.pl): //

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-06 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 11:36:54PM +0200, Pino Toscano wrote: > Rewrite the implementation of the ssh block driver to use libssh instead > of libssh2. The libssh library has various advantages over libssh2: > - easier API for authentication (for example for using ssh-agent) > - easier API for know

[Qemu-devel] [PULL 05/16] test: Fix make target check-report.tap

2019-06-06 Thread Laurent Vivier
From: Markus Armbruster Fix a fat-fingered invocation of tap-merge.pl in the recipe of target check-report.tap. Fixes: 9df43317b82 "test: replace gtester with a TAP driver" Signed-off-by: Markus Armbruster Reviewed-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Math

[Qemu-devel] [PULL 12/16] hw/vfio/pci: Use the QOM DEVICE() macro to access DeviceState.qdev

2019-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Rather than looking inside the definition of a DeviceState with "s->qdev", use the QOM prefered style: "DEVICE(s)". This patch was generated using the following Coccinelle script: // Use DEVICE() macros to access DeviceState.qdev @use_device_macro_to_access_

[Qemu-devel] [PULL 00/16] Trivial branch patches

2019-06-06 Thread Laurent Vivier
The following changes since commit 47fbad45d47af8af784bb12a5719489edcd89b4c: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-06-04 17:22:42 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/trivial-branch-pull-request for

Re: [Qemu-devel] [PATCH] qapi: InitSocketAddress: add keepalive option

2019-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2019 at 01:15:33PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > Hi all! > > This is a continuation of "[PATCH v2 0/2] nbd: enable keepalive", but > it's a try from another side, so almost nothing common with v2. > > > qapi/

[Qemu-devel] [PULL 16/16] hw/watchdog/wdt_i6300esb: Use DEVICE() macro to access DeviceState.qdev

2019-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Rather than looking inside the definition of a DeviceState with "s->qdev", use the QOM prefered style: "DEVICE(s)". This patch was generated using the following Coccinelle script: // Use DEVICE() macros to access DeviceState.qdev @use_device_macro_to_access_

Re: [Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-06 Thread Aravinda Prasad
On Thursday 06 June 2019 11:36 AM, Greg Kurz wrote: > On Thu, 6 Jun 2019 13:06:14 +1000 > David Gibson wrote: > >> On Wed, May 29, 2019 at 11:10:57AM +0530, Aravinda Prasad wrote: >>> This patch includes migration support for machine check >>> handling. Especially this patch blocks VM migratio

[Qemu-devel] [PULL 10/16] hw/isa: Use the QOM DEVICE() macro to access DeviceState.qdev

2019-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Rather than looking inside the definition of a DeviceState with "s->qdev", use the QOM prefered style: "DEVICE(s)". This patch was generated using the following Coccinelle script: // Use DEVICE() macros to access DeviceState.qdev @use_device_macro_to_access_

[Qemu-devel] [PULL 15/16] hw/scsi: Use the QOM BUS() macro to access BusState.qbus

2019-06-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Rather than looking inside the definition of a BusState with "s->bus.qbus", use the QOM prefered style: "BUS(&s->bus)". This patch was generated using the following Coccinelle script: // Use BUS() macros to access BusState.qbus @use_bus_macro_to_access_qbus@

[Qemu-devel] [PULL 02/16] migration: fix a typo

2019-06-06 Thread Laurent Vivier
From: Li Qiang 'postocpy' should be 'postcopy'. CC: qemu-triv...@nongnu.org Signed-off-by: Li Qiang Reviewed-by: Alex Bennée Reviewed-by: Juan Quintela Message-Id: <20190525062832.18009-1-liq...@163.com> Signed-off-by: Laurent Vivier --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+

Re: [Qemu-devel] [PATCH v6 2/6] linux-user: Validate mmap/mprotect prot value

2019-06-06 Thread Aleksandar Markovic
On Jun 5, 2019 11:13 PM, "Richard Henderson" wrote: > > The kernel will return -EINVAL for bits set in the prot argument > that are unknown or invalid. Previously we were simply cropping > out the bits that we care about. > > Introduce validate_prot_to_pageflags to perform this check in a > singl

Re: [Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-06 Thread Aravinda Prasad
On Thursday 06 June 2019 08:36 AM, David Gibson wrote: > On Wed, May 29, 2019 at 11:10:57AM +0530, Aravinda Prasad wrote: >> This patch includes migration support for machine check >> handling. Especially this patch blocks VM migration >> requests until the machine check error handling is >> com

Re: [Qemu-devel] [PATCH v4 4/6] qapi: Disentangle QAPIDoc code

2019-06-06 Thread Markus Armbruster
Kevin Wolf writes: > Documentation comments follow a certain structure: First, we have a text > with a general description (called QAPIDoc.body). After this, > descriptions of the arguments follow. Finally, we have a part that > contains various named sections. > > The code doesn't show this stru

Re: [Qemu-devel] QEMU/KVM migration backwards compatibility broken?

2019-06-06 Thread Liran Alon
> On 6 Jun 2019, at 14:07, Dr. David Alan Gilbert wrote: > > * Liran Alon (liran.a...@oracle.com) wrote: >> >> >>> On 6 Jun 2019, at 13:39, Dr. David Alan Gilbert wrote: >>> >>> * Liran Alon (liran.a...@oracle.com) wrote: > On 6 Jun 2019, at 12:23, Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH] qapi: InitSocketAddress: add keepalive option

2019-06-06 Thread Vladimir Sementsov-Ogievskiy
06.06.2019 14:17, Daniel P. Berrangé wrote: > On Thu, Jun 06, 2019 at 01:15:33PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> >> Hi all! >> >> This is a continuation of "[PATCH v2 0/2] nbd: enable keepalive", but >> it's a try from another sid

Re: [Qemu-devel] [Qemu-block] [PATCH v4 1/9] configure: permit use of io_uring

2019-06-06 Thread Maxim Levitsky
On Mon, 2019-06-03 at 18:08 +0530, Aarushi Mehta wrote: > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Aarushi Mehta > --- > configure | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git a/configure b/configure > index 6cdcfb2dc3..cb49ef0fcc 100755 > --- a/confi

Re: [Qemu-devel] [Qemu-block] [PATCH v4 2/9] qapi/block-core: add option for io_uring

2019-06-06 Thread Maxim Levitsky
On Wed, 2019-06-05 at 07:58 +0200, Markus Armbruster wrote: > Aarushi Mehta writes: > > > Option only enumerates for hosts that support it. > > Blank line here, please. Same in other patches. > > > Signed-off-by: Aarushi Mehta > > --- > > qapi/block-core.json | 4 +++- > > 1 file changed, 3

Re: [Qemu-devel] [PULL 0/2] SCSI/vl.c patches for 2019-06-05

2019-06-06 Thread Peter Maydell
On Wed, 5 Jun 2019 at 15:45, Paolo Bonzini wrote: > > The following changes since commit c87759ce876a7a0b17c2bf4f0b964bd51f0ee871: > > q35: Revert to kernel irqchip (2019-06-03 14:03:03 +0200) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstream >

Re: [Qemu-devel] [Qemu-block] [PATCH v4 3/9] block/block: add BDRV flag for io_uring

2019-06-06 Thread Maxim Levitsky
On Mon, 2019-06-03 at 18:08 +0530, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta > Reviewed-by: Stefan Hajnoczi > --- > include/block/block.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/block/block.h b/include/block/block.h > index 9b083e2bca..60f7c6c01c 100644 > ---

[Qemu-devel] [PATCH v4 4.5/6] qapi: Replace QAPIDoc._part by ._append_line, and rework comments

2019-06-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- This is on top of the fixup I appended to my review of v4. I'd squash all three patches together. The next patch needs to be updated for this. Unsquashed branch at git://repo.or.cz/qemu/armbru.git branch qapi-features. Let me know what you think. scripts/

Re: [Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-06 Thread Greg Kurz
On Thu, 6 Jun 2019 16:45:30 +0530 Aravinda Prasad wrote: > On Thursday 06 June 2019 11:36 AM, Greg Kurz wrote: > > On Thu, 6 Jun 2019 13:06:14 +1000 > > David Gibson wrote: > > > >> On Wed, May 29, 2019 at 11:10:57AM +0530, Aravinda Prasad wrote: > >>> This patch includes migration support

Re: [Qemu-devel] [PULL 09/16] hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbus

2019-06-06 Thread David Hildenbrand
On 06.06.19 13:06, Laurent Vivier wrote: > From: Philippe Mathieu-Daudé > > Rather than looking inside the definition of a BusState with "s->bus.qbus", > use the QOM prefered style: "BUS(&s->bus)". > > This patch was generated using the following Coccinelle script: > > // Use BUS() macros t

Re: [Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-06 Thread Greg Kurz
On Thu, 6 Jun 2019 16:55:18 +0530 Aravinda Prasad wrote: > On Thursday 06 June 2019 08:36 AM, David Gibson wrote: > > On Wed, May 29, 2019 at 11:10:57AM +0530, Aravinda Prasad wrote: > >> This patch includes migration support for machine check > >> handling. Especially this patch blocks VM migr

[Qemu-devel] [PATCH v2 04/10] target/mips: Unroll loops in helpers for MSA logic instructions

2019-06-06 Thread Aleksandar Markovic
From: Aleksandar Markovic Unroll loops in helpers for MSA logic instructions for better performance. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1559745316-1454-4-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/msa_helper.c | 44 +++

[Qemu-devel] [PATCH v2 00/10] Amend and clean up MSA support

2019-06-06 Thread Aleksandar Markovic
From: Aleksandar Markovic This series contains various refactorings and cleanups of MSA support. Improve support for logic instructions, add tests for shift and FP max/min instructions, add reseting all MSA registers before running tests, improve code style, outline future organization. v1->v2:

[Qemu-devel] [PATCH v2 05/10] tests/tcg: target/mips: Amend and rearrange MSA wrappers

2019-06-06 Thread Aleksandar Markovic
From: Aleksandar Markovic Amend and rearrange MSA wrappers to follow the same organization as in MSA tests. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1559745316-1454-6-git-send-email-aleksandar.marko...@rt-rk.com> --- tests/tcg/mips/include/wrappers_msa.h

[Qemu-devel] [PATCH v2 03/10] target/mips: Outline places for future MSA helpers

2019-06-06 Thread Aleksandar Markovic
From: Aleksandar Markovic Outline places for future MSA helpers to follow the same organization as in MSA tests. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1559745316-1454-7-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/msa_helper.c | 138 ++

[Qemu-devel] [PATCH v2 02/10] target/mips: Fix block-comment-related issues im msa_helper.c

2019-06-06 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix block-comment-related issues reported by checkpatch for file msa_helper.c. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1559745316-1454-3-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/msa_helper.c | 42 +++

  1   2   3   4   >