[Qemu-devel] [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave

2019-06-04 Thread Chen Zhang via Qemu-devel
The following patches fixed issues of absolute and relative input devices on macOS Mojave. Chen Zhang (2): ui/cocoa: Fix absolute input device grabbing issue on Mojave ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input device ui/cocoa.m | 50 +

[Qemu-devel] [PATCH] migratioin/ram.c: reset complete_round when we gets a queued page

2019-06-04 Thread Wei Yang
In case we gets a queued page, the order of block is interrupted. We may not rely on the complete_round flag to say we have already searched the whole blocks on the list. Signed-off-by: Wei Yang --- migration/ram.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/migration/ram.c b/migra

[Qemu-devel] sigsegv in chardev on iotest 045 (raw)

2019-06-04 Thread John Snow
Running tests on a development branch (I haven't touched chardev stuff, I swear!); I ran into the below crash where s->ioc was NULL. I don't have the time to investigate at this exact moment, so please excuse the hasty report so I don't forget to tell someone. It does not reproduce consistently, a

Re: [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave

2019-06-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1559638310.git.tgfb...@me.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave Type: series Message-id: cover.1559638310.gi

Re: [Qemu-devel] [PATCH v2] [for 4.0.1] q35: Revert to kernel irqchip

2019-06-04 Thread Michael S. Tsirkin
On Tue, Jun 04, 2019 at 04:12:24PM -0600, Alex Williamson wrote: > Backport of QEMU v4.1 commit for stable v4.0.1 release > > commit c87759ce876a7a0b17c2bf4f0b964bd51f0ee871 > Author: Alex Williamson > Date: Tue May 14 14:14:41 2019 -0600 > > q35: Revert to kernel irqchip > > Commit b

Re: [Qemu-devel] [PATCH for-stable 0/5] target/ppc: VSX/xvxsigdp fixes for 4.0 stable

2019-06-04 Thread David Gibson
On Tue, Jun 04, 2019 at 08:01:10PM +0100, Mark Cave-Ayland wrote: > Nothing to see here - just Anton's patches fixing several issues with the > VSX native endian conversion patches from 4.0, plus a related bug in xvxsigdp > queued for 4.0 stable. > > Signed-off-by: Mark Cave-Ayland Acked-by: Dav

Re: [Qemu-devel] [PATCH v2 1/2] qapi/block-core: Overlays are not snapshots

2019-06-04 Thread Markus Armbruster
Max Reitz writes: > A snapshot is something that reflects the state of something at a > certain point in time. It does not change. > > The file our snapshot commands create (or the node they install) is not > a snapshot, as it does change over time. It is an overlay. We cannot > do anything ab

Re: [Qemu-devel] [PATCH v4 2/9] qapi/block-core: add option for io_uring

2019-06-04 Thread Markus Armbruster
Aarushi Mehta writes: > Option only enumerates for hosts that support it. Blank line here, please. Same in other patches. > Signed-off-by: Aarushi Mehta > --- > qapi/block-core.json | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-

Re: [Qemu-devel] [PATCH v4 07/11] hmat acpi: Build Memory Side Cache Information Structure(s) in ACPI HMAT

2019-06-04 Thread Tao Xu
On 6/4/2019 11:04 PM, Igor Mammedov wrote: On Wed, 8 May 2019 14:17:22 +0800 Tao Xu wrote: From: Liu Jingqi This structure describes memory side cache information for memory proximity domains if the memory side cache is present and the physical device(SMBIOS handle) forms the memory side ca

[Qemu-devel] [PATCH 2/5] tricore: add UTOF instruction

2019-06-04 Thread David Brenken
From: David Brenken Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/fpu_helper.c | 16 target/tricore/helper.h | 1 + target/tricore/translate.c

[Qemu-devel] [PATCH 4/5] tricore: add QSEED instruction

2019-06-04 Thread David Brenken
From: Andreas Konopik Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/fpu_helper.c | 88 + target/tricore/helper.h | 1 + targ

[Qemu-devel] [PATCH 3/5] tricore: fix RRPW_INSERT instruction

2019-06-04 Thread David Brenken
From: David Brenken Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/translate.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/target/

[Qemu-devel] [PATCH 5/5] tricore: reset DisasContext before generating code

2019-06-04 Thread David Brenken
From: Georg Hofstetter Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/tricore/translate.c b/tar

[Qemu-devel] [PATCH 1/5] tricore: add FTOIZ instruction

2019-06-04 Thread David Brenken
From: David Brenken Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/fpu_helper.c | 25 + target/tricore/helper.h | 1 + target/tricore/tra

[Qemu-devel] [PATCH 0/5] tricore: adding new instructions and fixing issues

2019-06-04 Thread David Brenken
From: David Brenken Hello everyone, in the scope of this patchset we added implementations for the following instructions for the target TriCore: QSEED, FTOIZ, UTOF For the implementation of the QSEED instruction we wrote a test application to record the QSEED results on the actual target. W

[Qemu-devel] [Qemu-devel PATCH v2 1/2] sd: Fix out-of-bounds assertions

2019-06-04 Thread Lidong Chen
Due to an off-by-one error, the assert statements allow an out-of-bound array access. Signed-off-by: Lidong Chen Reviewed-by: Liam Merwick Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Darren Kenny --- hw/sd/sd.c | 4 ++-- 1 file chang

[Qemu-devel] [Qemu-devel PATCH v2 0/2] sd: Fix out-of-bounds assertions

2019-06-04 Thread Lidong Chen
The v2 changes include the fix for the incorrect assertion for poll_fds in util/main-loop.c according to the review comments from the previous sd fixes. Lidong Chen (2): sd: Fix out-of-bounds assertions util/main-loop: Fix incorrect assertion hw/sd/sd.c | 4 ++-- util/main-loop.c | 2 +

[Qemu-devel] [Qemu-devel PATCH v2 2/2] util/main-loop: Fix incorrect assertion

2019-06-04 Thread Lidong Chen
The check for poll_fds in g_assert() was incorrect. The correct assertion should check "n_poll_fds + w->num <= ARRAY_SIZE(poll_fds)" because the subsequent for-loop is doing access to poll_fds[n_poll_fds + i] where i is in [0, w->num). Signed-off-by: Lidong Chen Reviewed-by: Liran Alon Reviewed-

Re: [Qemu-devel] [Qemu-ppc] [PULL 09/29] target/ppc: introduce get_cpu_vsr{l, h}() and set_cpu_vsr{l, h}() helpers for VSR register access

2019-06-04 Thread Mark Cave-Ayland
On 04/06/2019 22:23, Laurent Vivier wrote: > This patch breaks something in the libcrypto. > > I've been able to reproduce the problem with Fedora 29: > > dnf install 'dnf-command(download)' > dnf download --source coreutils-single > rpm --verify coreutils-8.30-7.fc29.src.rpm > error: coreutils-

Re: [Qemu-devel] [PATCH] migratioin/ram.c: reset complete_round when we gets a queued page

2019-06-04 Thread Peter Xu
On Wed, Jun 05, 2019 at 09:08:28AM +0800, Wei Yang wrote: > In case we gets a queued page, the order of block is interrupted. We may > not rely on the complete_round flag to say we have already searched the > whole blocks on the list. > > Signed-off-by: Wei Yang > --- > migration/ram.c | 6 +

Re: [Qemu-devel] [PATCH v2 2/5] virtio: Set "start_on_kick" for legacy devices

2019-06-04 Thread Greg Kurz
On Tue, 4 Jun 2019 15:34:56 +0800 elohi...@gmail.com wrote: > From: Xie Yongji > > Besides virtio 1.0 transitional devices, we should also > set "start_on_kick" flag for legacy devices (virtio 0.9). > > Signed-off-by: Xie Yongji > --- Patch looks good but it would be even better if applied e

Re: [Qemu-devel] [Qemu-devel PATCH v2 2/2] util/main-loop: Fix incorrect assertion

2019-06-04 Thread Li Qiang
Lidong Chen 于2019年6月5日周三 下午2:23写道: > The check for poll_fds in g_assert() was incorrect. The correct assertion > should check "n_poll_fds + w->num <= ARRAY_SIZE(poll_fds)" because the > subsequent for-loop is doing access to poll_fds[n_poll_fds + i] where i > is in [0, w->num). > > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 2/5] virtio: Set "start_on_kick" for legacy devices

2019-06-04 Thread Yongji Xie
On Wed, 5 Jun 2019 at 14:42, Greg Kurz wrote: > > On Tue, 4 Jun 2019 15:34:56 +0800 > elohi...@gmail.com wrote: > > > From: Xie Yongji > > > > Besides virtio 1.0 transitional devices, we should also > > set "start_on_kick" flag for legacy devices (virtio 0.9). > > > > Signed-off-by: Xie Yongji

<    1   2   3