[Qemu-devel] [PATCH v4 09/11] kvm: Introduce slots lock for memory listener

Introduce KVMMemoryListener.slots_lock to protect the slots inside the kvm memory listener. Currently it is close to useless because all the KVM code path now is always protected by the BQL. But it'll start to make sense in follow up patches where we might do remote dirty bitmap clear and also we

Re: [Qemu-devel] [PATCH v3 4/4] egl-helpers: add modifier support to egl_dmabuf_import_texture()

Hi, > > +#ifdef EGL_DMA_BUF_PLANE0_MODIFIER_LO_EXT > > +if (dmabuf->modifier) { > > +attrs[i++] = EGL_DMA_BUF_PLANE0_MODIFIER_LO_EXT; > > +attrs[i++] = (dmabuf->modifier >> 0) & 0x; > > +attrs[i++] = EGL_DMA_BUF_PLANE0_MODIFIER_HI_EXT; > > +attrs[i++]

Re: [Qemu-devel] [PATCH v2 0/8] pseries: Allow hotplug of P2P bridges and devices under P2P bridges

On Thu, May 30, 2019 at 03:38:23PM +1000, David Gibson wrote: > PAPR has its own PCI hotplug mechanism which we implemented quite a > while ago. However, we weren't able to hotplug devices under PCI > bridges, because the pci-bridge code would try to handle the hotplug > using SHPC which won't wor

[Qemu-devel] [PATCH v4 11/11] migration: Split log_clear() into smaller chunks

Currently we are doing log_clear() right after log_sync() which mostly keeps the old behavior when log_clear() was still part of log_sync(). This patch tries to further optimize the migration log_clear() code path to split huge log_clear()s into smaller chunks. We do this by spliting the whole gu

[Qemu-devel] [Bug 1830821] Re: Expose ARCH_CAP_MDS_NO in guest

This is done upstream, no need for the upstream bug task. For Ubuntu I'll update the tasks to match the statement of sbeattie. There are discussions to reconsider some of the backports, but unfortunately the IA32_ARCH_CAPABILITIES infrastructure is a rather big set of changes. ** Changed in: qemu

Re: [Qemu-devel] [PATCH v1 0/2] s390x/tcg: STFLE fixes

On Fri, 31 May 2019 16:56:06 +0200 David Hildenbrand wrote: > While testing vector instructions, I ran into various issues with > user space binaries compiled with more recent compiler versions like > > # gunzip /usr/share/man/man1/hexdump.1.gz > *** stack smashing detected ***: terminated >

Re: [Qemu-devel] [PATCH] block/linux-aio: Drop unused BlockAIOCB submission method

On Sun, Jun 02, 2019 at 11:17:09PM +0300, Julia Suvorova via Qemu-devel wrote: > Callback-based laio_submit() and laio_cancel() were left after > rewriting Linux AIO backend to coroutines in hope that they would be > used in other code that could bypass coroutines. They can be safely > removed beca

Re: [Qemu-devel] [PATCH v1 0/2] s390x/tcg: STFLE fixes

On 03.06.19 09:02, Cornelia Huck wrote: > On Fri, 31 May 2019 16:56:06 +0200 > David Hildenbrand wrote: > >> While testing vector instructions, I ran into various issues with >> user space binaries compiled with more recent compiler versions like >> >> # gunzip /usr/share/man/man1/hexdump.1.gz >>

Re: [Qemu-devel] [PATCH v2 2/6] tests/qapi-schema: Test for good feature lists in structs

Am 03.06.2019 um 08:35 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 24.05.2019 um 15:29 hat Markus Armbruster geschrieben: > >> Let's add > >> > >>{ 'command': 'test-features', > >> 'data': { 'fs0': 'FeatureStruct0', > >>'fs1': 'FeatureStruct1', > >>

Re: [Qemu-devel] [PATCH 4/6] COLO-compare: Add colo-compare remote notify support

From: Li Zhijian [mailto:lizhij...@cn.fujitsu.com] Sent: Monday, June 3, 2019 10:33 AM To: Zhang, Chen ; Dr. David Alan Gilbert ; Juan Quintela ; zhanghailiang ; Jason Wang ; qemu-dev Cc: Zhang Chen Subject: Re: [PATCH 4/6] COLO-compare: Add colo-compare remote notify support how about do s

Re: [Qemu-devel] [PATCH] block/linux-aio: Drop unused BlockAIOCB submission method

Am 02.06.2019 um 22:17 hat Julia Suvorova geschrieben: > Callback-based laio_submit() and laio_cancel() were left after > rewriting Linux AIO backend to coroutines in hope that they would be > used in other code that could bypass coroutines. They can be safely > removed because they have not been u

Re: [Qemu-devel] [RFC PATCH 0/2] target: Build with CONFIG_SEMIHOSTING disabled

On 31/05/19 18:54, Miroslav Rezanina wrote: > What about CONFIG_ARM_VIRT - can we use it to introduce dependency on > CONFIG_SEMIHOSTING or is there valid scenario of qemu build with > CONFIG_ARM_VIRT > enabled and CONFIG_SEMIHOSTING disabled? If you are not really going to use TCG, disabling SEM

Re: [Qemu-devel] [PATCH v3 01/12] checkpatch: Allow SPDX-License-Identifier

On 03/06/19 08:21, Peter Xu wrote: > On Fri, May 31, 2019 at 02:56:21PM +0200, Juan Quintela wrote: >> Peter Xu wrote: >>> According to: https://spdx.org/ids-how, let's still allow QEMU to use >>> the SPDX license identifier: >>> >>> // SPDX-License-Identifier: *** >>> >>> Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH v2 4/6] qapi: Disentangle QAPIDoc code

Cc: Eric for English language advice. Kevin Wolf writes: > Am 24.05.2019 um 18:11 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Documentation comment follow a certain structure: First, we have a text >> > with a general description (called QAPIDoc.body). After this, >> > des

[Qemu-devel] [PATCH] qgraph: allow extra_device_opts on contains nodes

Allow choosing the bus that the device will be placed on, in case the machine has more than one. Otherwise, the bus may not match the base address of the controller we attach it to. Signed-off-by: Paolo Bonzini --- tests/qos-test.c | 17 ++--- 1 file changed, 10 insertions(+), 7 del

Re: [Qemu-devel] [PATCH v3] monitor: Fix return type of monitor_fdset_dup_fd_find

"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> David, got anything queued for the monitor? If yes, can you stick this >> in? If not, I can handle it. > > I've not got anything else, so please take it; > am I right in thinking this supercedes > > 'monitor:

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, May 31, 2019 at 07:45:13PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > > > > Yes. It's just lots of extremely low level inter

[Qemu-devel] [PATCH] qgraph: fix qos_node_contains with options

Currently, if qos_node_contains was passed options, it would still create an edge without any options. Instead, in that case NULL acts as a terminator. Signed-off-by: Paolo Bonzini --- tests/libqos/qgraph.c | 12 tests/libqos/qgraph.h | 15 +-- 2 files changed, 17 inser

Re: [Qemu-devel] [PATCH for-4.1 v2] q35: Revert to kernel irqchip

On 29/05/19 05:30, Michael S. Tsirkin wrote: > On Tue, May 14, 2019 at 02:14:41PM -0600, Alex Williamson wrote: >> Commit b2fc91db8447 ("q35: set split kernel irqchip as default") changed >> the default for the pc-q35-4.0 machine type to use split irqchip, which >> turned out to have disasterous ef

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: > On Tue, May 21, 2019 at 10:45:05AM +0100, Dr. David Alan Gilbert wrote: > > * Jens Freimann (jfrei

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

Aleksandar Markovic writes: > On May 29, 2019 5:09 PM, "Markus Armbruster" wrote: >> >> When scripts/get_maintainer.pl reports something like >> >> John Doe (maintainer:Overall) >> >> the user is left to wonder *which* of our three "Overall" sections >> applies. We have three, one each und

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

Stafford Horne writes: > On Wed, May 29, 2019 at 05:08:52PM +0200, Markus Armbruster wrote: >> When scripts/get_maintainer.pl reports something like >> >> John Doe (maintainer:Overall) >> >> the user is left to wonder *which* of our three "Overall" sections >> applies. We have three, one

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

On 5/31/19 5:36 AM, Stafford Horne wrote: > On Wed, May 29, 2019 at 05:08:52PM +0200, Markus Armbruster wrote: >> When scripts/get_maintainer.pl reports something like >> >> John Doe (maintainer:Overall) >> >> the user is left to wonder *which* of our three "Overall" sections >> applies. We h

Re: [Qemu-devel] [PATCH] qgraph: fix qos_node_contains with options

On 6/3/19 10:13 AM, Paolo Bonzini wrote: > Currently, if qos_node_contains was passed options, it would still > create an edge without any options. Instead, in that case > NULL acts as a terminator. > > Signed-off-by: Paolo Bonzini > --- > tests/libqos/qgraph.c | 12 > tests/libqos

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

* Alex Williamson (alex.william...@redhat.com) wrote: > On Fri, 31 May 2019 19:45:13 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > > > > Yes. It's just lots of extremely low

[Qemu-devel] [PATCH v2 02/22] s390x/tcg: Introduce tcg_s390_vector_exception()

Handling is similar to data exceptions, however we can always store the VXC into the lowore and the FPC: z14 PoP, 6-20, "Vector-Exception Code" When a vector-processing exception causes a pro- gram interruption, a vector-exception code (VXC) is stored at location 147, and zeros are sto

[Qemu-devel] [PATCH v2 11/22] s390x/tcg: Implement VECTOR FP DIVIDE

We can reuse most of the infrastructure added for VECTOR FP ADD. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 3 +++ target/s390x/vec_fpu_helper.c | 17 +

[Qemu-devel] [PATCH v2 04/22] s390x/tcg: Implement VECTOR FP ADD

1. We'll reuse op_vfa() for similar instructions later, prepare for that. 2. We'll reuse vop64_3() for other instructions later. 3. Take care of modifying the vector register only if no trap happened. - on traps, flags are not updated and no elements are modified - traps don't modify the fpc f

[Qemu-devel] [PATCH v2 03/22] s390x/tcg: Export float_comp_to_cc() and float(32|64|128)_dcmask()

Vector floating-point instructions will require these functions, so allow to use them from other files. Signed-off-by: David Hildenbrand --- target/s390x/fpu_helper.c | 4 ++-- target/s390x/internal.h | 4 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/target/s390x/fpu_hel

[Qemu-devel] [PATCH v2 16/22] s390x/tcg: Implement VECTOR FP MULTIPLY AND (ADD|SUBTRACT)

Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 4 +++ target/s390x/insn-data.def | 4 +++ target/s390x/translate_vx.inc.c | 23 target/s390x/vec_fpu_helper.c | 48 + 4 files changed, 79 insertions(+) diff --git a/t

[Qemu-devel] [PATCH v2 20/22] s390x/tcg: Implement VECTOR FP TEST DATA CLASS IMMEDIATE

We can reuse float64_dcmask(). Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 21 +++ target/s390x/vec_fpu_helper.c | 37 +++

[Qemu-devel] [PATCH v2 08/22] s390x/tcg: Implement VECTOR FP CONVERT FROM LOGICAL 64-BIT

Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 3 +++ target/s390x/vec_fpu_helper.c | 23 +++ 4 files changed, 30 insertions(+) diff --

[Qemu-devel] [PATCH v2 00/22] s390x/tcg: Vector Instruction Support Part 4

This is the final part of vector instruction support for s390x. Part 1: Vector Support Instructions Part 2: Vector Integer Instructions Part 3: Vector String Instructions Part 4: Vector Floating-Point Instructions The current state can be found at (kept updated): https://github.com/davidhilde

[Qemu-devel] [PATCH v2 13/22] s390x/tcg: Implement VECTOR LOAD LENGTHENED

Take care of reading/indicating the 32-bit elements. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 19 ++ target/s390x/vec_fpu_helper.c | 3

[Qemu-devel] [PATCH v2 01/22] s390x/tcg: Store only the necessary amount of doublewords for STFLE

The PoP (z14, 7-382) says: Doublewords to the right of the doubleword in which the highest-numbered facility bit is assigned for a model may or may not be stored. However, stack protection in certain binaries can't deal with that. "gzip" example code: f1b4: a7 08 00 03

[Qemu-devel] [PATCH v2 07/22] s390x/tcg: Implement VECTOR FP CONVERT FROM FIXED 64-BIT

1. We'll reuse op_vcdg() for similar instructions later, prepare for that. 2. We'll reuse vop64_2() later for other instructions. We have to mangle the erm (effective rounding mode) and the m4 into the simd_data(), and properly unmangle them again. Make sure to restore the erm before triggerin

[Qemu-devel] [PATCH v2 09/22] s390x/tcg: Implement VECTOR FP CONVERT TO FIXED 64-BIT

Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 3 +++ target/s390x/vec_fpu_helper.c | 23 +++ 4 files changed, 30 insertions(+) diff --

[Qemu-devel] [PATCH v2 14/22] s390x/tcg: Implement VECTOR LOAD ROUNDED

We can reuse some of the infrastructure introduced for VECTOR FP CONVERT FROM FIXED 64-BIT and friends. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 3 +++

[Qemu-devel] [PATCH v2 05/22] s390x/tcg: Implement VECTOR FP COMPARE (AND SIGNAL) SCALAR

As far as I can see, there is only a tiny difference. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 4 target/s390x/translate_vx.inc.c | 21 + target/s390x/vec_fpu_helper.c

[Qemu-devel] [PATCH v2 10/22] s390x/tcg: Implement VECTOR FP CONVERT TO LOGICAL 64-BIT

Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 3 +++ target/s390x/vec_fpu_helper.c | 23 +++ 4 files changed, 30 insertions(+) diff --

[Qemu-devel] [PATCH v2 15/22] s390x/tcg: Implement VECTOR FP MULTIPLY

Very similar to VECTOR FP DIVIDE. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 3 +++ target/s390x/vec_fpu_helper.c | 17 + 4 files chang

[Qemu-devel] [PATCH v2 06/22] s390x/tcg: Implement VECTOR FP COMPARE (EQUAL|HIGH|HIGH OR EQUAL)

Provide for all three instructions all four combinations of cc bit and s bit. Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 12 target/s390x/insn-data.def | 6 ++ target/s390x/translate_vx.inc.c | 51 target/s390x/vec_fpu_helper.c | 104 +

[Qemu-devel] [PATCH v2 19/22] s390x/tcg: Implement VECTOR FP SUBTRACT

Similar to VECTOR FP ADD. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 3 +++ target/s390x/vec_fpu_helper.c | 17 + 4 files changed, 24 i

[Qemu-devel] [PATCH v2 23/22] s390x: Bump the "qemu" CPU model up to a stripped-down z13

We don't care about the other two missing base features: - S390_FEAT_DFP_PACKED_CONVERSION - S390_FEAT_GROUP_GEN13_PTFF Cc: Christian Borntraeger Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 2 ++ target/s390x/cpu_models.c | 4 ++-- targ

[Qemu-devel] [PATCH v2 21/22] s390x/tcg: Allow linux-user to use vector instructions

Once we unlock S390_FEAT_VECTOR for TCG, we want linux-user to be able to make use of it. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c index b1df63d82c..6af1a

[Qemu-devel] [PATCH v2 18/22] s390x/tcg: Implement VECTOR FP SQUARE ROOT

Simulate XxC=0 and ERM=0 (current mode), so we can use the existing helper function. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 19 +++ ta

[Qemu-devel] [PATCH v2 12/22] s390x/tcg: Implement VECTOR LOAD FP INTEGER

We can reuse most of the infrastructure introduced for VECTOR FP CONVERT FROM FIXED 64-BIT and friends. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 3 +++

[Qemu-devel] [PATCH v2 22/22] s390x/tcg: We support the Vector Facility

Let's add it to the max model, so we can enable it. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/gen-features.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index c346b76bdf..a818c80332 100644 -

Re: [Qemu-devel] [PATCH v2 00/22] s390x/tcg: Vector Instruction Support Part 4

On 03.06.19 11:06, David Hildenbrand wrote: > This is the final part of vector instruction support for s390x. > > Part 1: Vector Support Instructions > Part 2: Vector Integer Instructions > Part 3: Vector String Instructions > Part 4: Vector Floating-Point Instructions > > The current state can b

[Qemu-devel] [PATCH v2 17/22] s390x/tcg: Implement VECTOR FP PERFORM SIGN OPERATION

The only FP instruction we can implement without an helper. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 52 + 2 files changed, 54 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s3

Re: [Qemu-devel] [PATCH v2 01/22] s390x/tcg: Store only the necessary amount of doublewords for STFLE

On 03.06.19 11:06, David Hildenbrand wrote: > The PoP (z14, 7-382) says: > Doublewords to the right of the doubleword in which the > highest-numbered facility bit is assigned for a model > may or may not be stored. > > However, stack protection in certain binaries can't deal with that.

Re: [Qemu-devel] [libvirt patch] qemu: adds support for virtfs 9p argument 'vii'

On Montag, 3. Juni 2019 08:57:15 CEST Greg Kurz wrote: > > Ok, I will extend Antonios' patch to log that error on host. I thought > > about limiting that error message to once per session (for not flooding > > the logs), but it is probably not worth it, so if you don't veto then I > > will just log

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

On Mon, Jun 03, 2019 at 10:24:56AM +0200, Jens Freimann wrote: On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: On Tue, May 21, 2019 at 10:45:05AM

Re: [Qemu-devel] [PATCH v4 04/11] bitmap: Add bitmap_copy_with_{src|dst}_offset()

* Peter Xu (pet...@redhat.com) wrote: > These helpers copy the source bitmap to destination bitmap with a > shift either on the src or dst bitmap. > > Meanwhile, we never have bitmap tests but we should. > > This patch also introduces the initial test cases for utils/bitmap.c > but it only tests

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

On Mon, 03 Jun 2019 10:29:35 +0200 Markus Armbruster wrote: > Aleksandar Markovic writes: > > > On May 29, 2019 5:09 PM, "Markus Armbruster" wrote: > >> > >> When scripts/get_maintainer.pl reports something like > >> > >> John Doe (maintainer:Overall) > >> > >> the user is left to wonde

Re: [Qemu-devel] [PATCH v4 05/11] memory: Pass mr into snapshot_and_clear_dirty

* Peter Xu (pet...@redhat.com) wrote: > Also we change the 2nd parameter of it to be the relative offset > within the memory region. This is to be used in follow up patches. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > exec.c | 3 ++- > include/exec

Re: [Qemu-devel] [PATCH] block/linux-aio: Drop unused BlockAIOCB submission method

Patchew URL: https://patchew.org/QEMU/20190602201709.11901-1-jus...@mail.ru/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] block/linux-aio: Drop unused BlockAIOCB submission method Type: series Message-id: 201906

Re: [Qemu-devel] [PATCH 1/2] target/mips: Improve performance for MSA binary operations

On 2.6.19. 09:06, Aleksandar Markovic wrote: On Jun 1, 2019 4:16 PM, "Aleksandar Markovic" > wrote: > > > From: Mateja Marjanovic > > > Sent: Monday, March 4, 2019 5:51 PM > > To: qemu-devel@nongnu.org

Re: [Qemu-devel] [PATCH v4 08/11] kvm: Persistent per kvmslot dirty bitmap

* Peter Xu (pet...@redhat.com) wrote: > When synchronizing dirty bitmap from kernel KVM we do it in a > per-kvmslot fashion and we allocate the userspace bitmap for each of > the ioctl. This patch instead make the bitmap cache be persistent > then we don't need to g_malloc0() every time. > > More

Re: [Qemu-devel] [PATCH v4 11/11] migration: Split log_clear() into smaller chunks

* Peter Xu (pet...@redhat.com) wrote: > Currently we are doing log_clear() right after log_sync() which mostly > keeps the old behavior when log_clear() was still part of log_sync(). > > This patch tries to further optimize the migration log_clear() code > path to split huge log_clear()s into smal

Re: [Qemu-devel] [PULL 0/8] MIPS queue for June 1st, 2019

On Sat, 1 Jun 2019 at 19:30, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > The following changes since commit 60905286cb5150de854e08279bca7dfc4b549e91: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190529' > into staging (2019-05-30 15:08:00 +0100) > > are

Re: [Qemu-devel] [PATCH v2 3/9] iotests: add test 255 to check bitmap life after snapshot + commit

01.06.2019 2:42, John Snow wrote: > > > On 5/31/19 12:31 PM, Vladimir Sementsov-Ogievskiy wrote: >> Two testcases with persistent bitmaps are not added here, as there are >> bugs to be fixed soon. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> tests/qemu-iotests/255 | 84 +

Re: [Qemu-devel] [PATCH v2 2/9] python/qemu: improve event_wait method of vm

01.06.2019 2:33, John Snow wrote: > > > On 5/31/19 12:31 PM, Vladimir Sementsov-Ogievskiy wrote: >> Support several names to wait for, which useful, when we don't sure >> which event will we get. For example when mirror fails we get >> BLOCK_JOB_COMPLETE otherwise we get BLOCK_JOB_READY (and only

Re: [Qemu-devel] [PATCH v9 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

On Wed, 29 May 2019 11:10:14 +0530 Aravinda Prasad wrote: > This patch adds support in QEMU to handle "ibm,nmi-register" > and "ibm,nmi-interlock" RTAS calls. > > The machine check notification address is saved when the > OS issues "ibm,nmi-register" RTAS call. > > This patch also handles the c

Re: [Qemu-devel] [Qemu-block] [PATCH v7 0/9] discard blockstats

On Tue, May 14, 2019 at 12:10:40PM +, Anton Nefedov wrote: > hi, > > yet another take for this patch series; please kindly consider these for 4.1 > > Just a few cosmetic comments were received for v6 so this is mostly > a rebase+ping. > > new in v7: > - general rebase > - since claus

Re: [Qemu-devel] [PATCH v2 6/9] block/qcow2-bitmap: do not remove bitmaps on reopen-ro

01.06.2019 3:06, John Snow wrote: > > > On 5/31/19 12:31 PM, Vladimir Sementsov-Ogievskiy wrote: >> qcow2_reopen_bitmaps_ro wants to store bitmaps and then mark them all >> readonly. But the latter don't work, as >> qcow2_store_persistent_dirty_bitmaps removes bitmaps after storing. >> It's OK fo

Re: [Qemu-devel] [PATCH] q35: split memory at 2G

On 05/29/19 06:47, Gerd Hoffmann wrote: > On Tue, May 28, 2019 at 10:49:55PM -0400, Michael S. Tsirkin wrote: >> On Wed, May 29, 2019 at 03:21:16AM +0200, Paolo Bonzini wrote: >>> On 28/05/19 22:48, Gerd Hoffmann wrote: Original q35 behavior was to split memory 2.75 GB, leaving space for the >

Re: [Qemu-devel] [PATCH] q35: fix mmconfig and PCI0._CRS

On 05/28/19 22:43, Gerd Hoffmann wrote: > This patch changes the handling of the mmconfig area. Thanks to the > pci(e) expander devices we already have the logic to exclude address > ranges from PCI0._CRS. We can simply add the mmconfig address range > to the list get it excluded as well. > > Wi

Re: [Qemu-devel] [PATCH v1 2/2] s390x/tcg: Store only the necessary amount of doublewords for STFLE

On 03.06.19 12:38, Stefan Liebler wrote: > On 5/31/19 4:56 PM, David Hildenbrand wrote: >> The PoP (z14, 7-382) says: >> Doublewords to the right of the doubleword in which the >> highest-numbered facility bit is assigned for a model >> may or may not be stored. >> >> However, stack

Re: [Qemu-devel] [PATCH v7 2/2] hw/arm: Add arm SBSA reference machine, devices part

Hi Hongbo, Ard. On 4/18/19 6:04 AM, Hongbo Zhang wrote: > Following the previous patch, this patch adds peripheral devices to the > newly introduced SBSA-ref machine. > > Signed-off-by: Hongbo Zhang > --- > hw/arm/sbsa-ref.c | 451 > ++ > 1 f

Re: [Qemu-devel] Headers without multiple inclusion guards

Hi Markus, (sorry about the late reply, I've been away.) On 05/28/19 20:12, Markus Armbruster wrote: > EDK2 Firmware > M: Laszlo Ersek > M: Philippe Mathieu-Daudé > tests/uefi-test-tools/UefiTestToolsPkg/Include/Guid/BiosTablesTest.h This header file does have a multiple inclusion guard: > /

Re: [Qemu-devel] Headers without multiple inclusion guards

On 05/29/19 16:10, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 5/28/19 8:12 PM, Markus Armbruster wrote: >>> We have a bunch of headers without multiple inclusion guards. Some are >>> clearly intentional, some look accidental. Too many for me to find out >>> by examining e

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

On Mon, 3 Jun 2019 12:12:43 +0200 Greg Kurz wrote: > On Wed, 29 May 2019 11:10:14 +0530 > Aravinda Prasad wrote: > > > This patch adds support in QEMU to handle "ibm,nmi-register" > > and "ibm,nmi-interlock" RTAS calls. > > > > The machine check notification address is saved when the > > OS is

[Qemu-devel] [PATCH v6 1/2] tests: add expected ACPI tables for arm/virt board

Signed-off-by: Igor Mammedov Tested-by: Philippe Mathieu-Daudé --- this patch is ahead fo "tests: acpi: add simple arm/virt testcase" to keep 'make check' working during bisection and not to pollute code with binary blobs which are not reviewable. tests/data/acpi/virt/APIC | Bin 0 -> 168 bytes

[Qemu-devel] [PATCH v6 0/2] tests: acpi: ARM testing support

Changelog: - from v4: * uefi support has been merged already, but only ARM part wasn't due to test failing on ARM 32 bit host. It turned out that's aarch64 TCG issue on 32-bit ARM host. Blacklist aarch64 test on 32 bit ARM host for now. Series adds reference tables and a ACPI

Re: [Qemu-devel] [PATCH v2] nvme: add Get/Set Feature Timestamp support

Am 28.05.2019 um 08:18 hat Klaus Birkelund geschrieben: > On Mon, May 20, 2019 at 11:40:30AM -0600, Kenneth Heitke wrote: > > Signed-off-by: Kenneth Heitke > > diff --git a/hw/block/nvme.h b/hw/block/nvme.h > > index 56c9d4b4b1..d7277e72b7 100644 > > --- a/hw/block/nvme.h > > +++ b/hw/block/nvme.

[Qemu-devel] [PATCH v6 2/2] tests: acpi: add simple arm/virt testcase

adds simple arm/virt test case that starts guest with bios-tables-test.aarch64.iso.qcow2 boot image which initializes UefiTestSupport* structure in RAM once guest is booted. * see commit: tests: acpi: add acpi_find_rsdp_address_uefi() helper Signed-off-by: Igor Mammedov --- v6: * Since aarch6

Re: [Qemu-devel] [PATCH v2] nvme: add Get/Set Feature Timestamp support

Am 20.05.2019 um 19:40 hat Kenneth Heitke geschrieben: > Signed-off-by: Kenneth Heitke Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 3/6] target/ppc: Handle NMI guest exit

On Wed, 29 May 2019 11:10:32 +0530 Aravinda Prasad wrote: > Memory error such as bit flips that cannot be corrected > by hardware are passed on to the kernel for handling. > If the memory address in error belongs to guest then > the guest kernel is responsible for taking suitable action. > Patch

Re: [Qemu-devel] [Bug 1830872] Re: AARCH64 to ARMv7 mistranslation in TCG

Alex Bennée writes: > Laszlo Ersek (Red Hat) writes: > >> Possibly related: >> [Qemu-devel] "accel/tcg: demacro cputlb" break qemu-system-x86_64 >> https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg07362.html >> >> (qemu-system-x86_64 fails to boot 64-bit kernel under TCG accel when >>

[Qemu-devel] [PATCH 0/4] qapi: block-dirty-bitmap-remove transaction action

Hi all! Here is block-dirty-bitmap-remove transaction action. It is used to do transactional movement of the bitmap (which is possible in conjunction with merge command). Transactional bitmap movement is needed in scenarios with external snapshot, when we don't want to leave copy of the bitmap in

Re: [Qemu-devel] "accel/tcg: demacro cputlb" break qemu-system-x86_64

Hi Andrew, On 06/01/19 05:03, Andrew Randrianasulu wrote: > Hello! > > I was compiling latest qemu git, and was surprized to find qemu-system-x86_64 > (compiled for 32-bit x86 machine) can't boot any 64-bit kernel anymore. > > 32-bit kernels and kvm were fine. > So, I run git bisect > # first b

[Qemu-devel] [PATCH 2/4] block/dirty-bitmap: add hide/unhide API

Add functionality to make bitmap temporary anonymous. It will be used to implement bitmap remove transaction action. We need hide bitmap persistence too, as there are should not be unnamed persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 2 ++ b

[Qemu-devel] [PATCH 3/4] qapi: implement block-dirty-bitmap-remove transaction action

It is used to do transactional movement of the bitmap (which is possible in conjunction with merge command). Transactional bitmap movement is needed in scenarios with external snapshot, when we don't want to leave copy of the bitmap in the base image. Signed-off-by: Vladimir Sementsov-Ogievskiy -

[Qemu-devel] [PATCH 1/4] blockdev: reduce aio_context locked sections in bitmap add/remove

Commit 0a6c86d024c52 returned these locks back to add/remove functionality, to protect from intersection of persistent bitmap related IO with other IO. But other bitmap-related functions called here are unrelated to the problem, and there are no needs to keep these calls inside critical sections.

[Qemu-devel] [PATCH 4/4] iotests: test bitmap moving inside 254

Test persistent bitmap copying with and without removal of original bitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/254 | 30 +- tests/qemu-iotests/254.out | 82 ++ 2 files changed, 110 insertions(+), 2 deletions(-)

Re: [Qemu-devel] Deprecation policy and build dependencies

John Snow writes: > On 5/31/19 3:24 PM, Eduardo Habkost wrote: >> Long story short: I would really like to drop support for Python >> 2 in QEMU 4.1. The sooner, the better, as far as I'm concerned. >> What exactly prevents us from doing this? Does our deprecation >> policy really apply to buil

Re: [Qemu-devel] [PATCH v2 0/5] Few fixes for userspace NVME driver

On Wed, 2019-04-17 at 22:53 +0300, Maxim Levitsky wrote: > Hi! > These are few assorted fixes and features for the userspace > nvme driver. > > Tested that on my laptop with my Samsung X5 thunderbolt drive, which > happens to have 4K sectors, support for discard and write zeros. > > Also bunch of

[Qemu-devel] [PATCH v4 5/9] stubs: add stubs for io_uring interface

Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + stubs/Makefile.objs | 1 + stubs/io_uring.c| 32 3 files changed, 34 insertions(+) create mode 100644 stubs/io_uring.c diff --git a/MAINTAINERS b/MAINTAINERS index dc

[Qemu-devel] [PATCH v4 7/9] blockdev: accept io_uring as option

Reviewed-by: Stefan Hajnoczi Signed-off-by: Aarushi Mehta --- blockdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 17c2d801d7..58a9e69268 100644 --- a/blockdev.c +++ b/blockdev.c @@ -386,6 +386,8 @@ static void extract_common_blockdev_op

[Qemu-devel] [PATCH v4 6/9] util/async: add aio interfaces for io_uring

Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi --- util/async.c | 36 1 file changed, 36 insertions(+) diff --git a/util/async.c b/util/async.c index c10642a385..2709f0edc3 100644 --- a/util/async.c +++ b/util/async.c @@ -277,6 +277,14 @@ aio_ctx_

[Qemu-devel] [PATCH v4 9/9] block: add trace events for io_uring

Signed-off-by: Aarushi Mehta --- block/io_uring.c | 14 -- block/trace-events | 8 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/block/io_uring.c b/block/io_uring.c index 536a9fbe87..e92e45ccca 100644 --- a/block/io_uring.c +++ b/block/io_uring.c @@ -17,6

[Qemu-devel] [PATCH v4 3/9] block/block: add BDRV flag for io_uring

Signed-off-by: Aarushi Mehta Reviewed-by: Stefan Hajnoczi --- include/block/block.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/block/block.h b/include/block/block.h index 9b083e2bca..60f7c6c01c 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -121,6 +121,7 @@ ty

[Qemu-devel] [PATCH v4 4/9] block/io_uring: implements interfaces for io_uring

Aborts when sqes cannot be set as sqes cannot be returned to ring. Signed-off-by: Aarushi Mehta --- MAINTAINERS | 7 + block/Makefile.objs | 3 + block/io_uring.c| 315 include/block/aio.h | 16 +- include/block/raw-aio.h |

[Qemu-devel] [PATCH v4 0/9] Add support for io_uring

This patch series adds support for the newly developed io_uring Linux AIO interface. Linux io_uring is faster than Linux's AIO asynchronous I/O code, offers efficient buffered asynchronous I/O support, the ability to do I/O without performing a system call via polled I/O, and other efficiency enha

[Qemu-devel] [PATCH v4 8/9] block/file-posix.c: extend to use io_uring

Signed-off-by: Aarushi Mehta --- block/file-posix.c | 85 +- 1 file changed, 69 insertions(+), 16 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index d018429672..211dfe5337 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@

[Qemu-devel] [PATCH v4 2/9] qapi/block-core: add option for io_uring

Option only enumerates for hosts that support it. Signed-off-by: Aarushi Mehta --- qapi/block-core.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 1defcde048..db7eedd058 100644 --- a/qapi/block-core.json +++ b/qapi/bloc

Re: [Qemu-devel] [PATCH v1 2/2] s390x/tcg: Store only the necessary amount of doublewords for STFLE

On 5/31/19 4:56 PM, David Hildenbrand wrote: The PoP (z14, 7-382) says: Doublewords to the right of the doubleword in which the highest-numbered facility bit is assigned for a model may or may not be stored. However, stack protection in certain binaries can't deal with that. "gzip

[Qemu-devel] [PATCH v4 1/9] configure: permit use of io_uring

Reviewed-by: Stefan Hajnoczi Signed-off-by: Aarushi Mehta --- configure | 27 +++ 1 file changed, 27 insertions(+) diff --git a/configure b/configure index 6cdcfb2dc3..cb49ef0fcc 100755 --- a/configure +++ b/configure @@ -365,6 +365,7 @@ xen="" xen_ctrl_version="" xen_

[Qemu-devel] ping Re: [PATCH v5 0/3] Fix overflow bug in qcow2 discard

ping 21.05.2019 12:38, Vladimir Sementsov-Ogievskiy wrote: > ping > > 23.04.2019 15:57, Vladimir Sementsov-Ogievskiy wrote: >> v5: by Kevin's comments >> 02: add check for invalid @bytes parameter, drop r-b >> 03: move from qemu-img info to qemu-img map -f raw, drop r-b and t-b >> >> Vladimir Seme

  1   2   3   >