Re: [Qemu-devel] [PATCH v1 16/23] s390x/tcg: Implement VECTOR FP MULTIPLY AND (ADD|SUBTRACT)

2019-05-31 Thread David Hildenbrand
On 31.05.19 19:42, Richard Henderson wrote: > On 5/31/19 5:44 AM, David Hildenbrand wrote: >> +typedef uint64_t (*vop64_4_fn)(uint64_t a, uint64_t b, uint64_t c, >> + float_status *s); >> +static void vop64_4(S390Vector *v1, const S390Vector *v2, const S390Vector >> *

Re: [Qemu-devel] [PATCH v1 17/23] s390x/tcg: Implement VECTOR FP PERFORM SIGN OPERATION

2019-05-31 Thread Richard Henderson
On 5/31/19 5:44 AM, David Hildenbrand wrote: > +static DisasJumpType op_vfpso(DisasContext *s, DisasOps *o) > +{ > +const uint8_t fpf = get_field(s->fields, m3); > +const uint8_t m4 = get_field(s->fields, m4); > +const uint8_t m5 = get_field(s->fields, m5); > +const bool se = extrac

Re: [Qemu-devel] [PATCH v1 18/23] s390x/tcg: Implement VECTOR FP SQUARE ROOT

2019-05-31 Thread Richard Henderson
On 5/31/19 5:44 AM, David Hildenbrand wrote: > Simulate XxC=0 and ERM=0 (current mode), so we can use the existing > helper function. > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.h | 2 ++ > target/s390x/insn-data.def | 2 ++ > target/s390x/translate_vx.inc.c

Re: [Qemu-devel] [PATCH v1 19/23] s390x/tcg: Implement VECTOR FP SUBTRACT

2019-05-31 Thread Richard Henderson
On 5/31/19 5:44 AM, David Hildenbrand wrote: > Similar to VECTOR FP ADD. > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.h | 2 ++ > target/s390x/insn-data.def | 2 ++ > target/s390x/translate_vx.inc.c | 3 +++ > target/s390x/vec_fpu_helper.c | 17 +++

Re: [Qemu-devel] [PATCH v1 20/23] s390x/tcg: Implement VECTOR FP TEST DATA CLASS IMMEDIATE

2019-05-31 Thread Richard Henderson
On 5/31/19 5:44 AM, David Hildenbrand wrote: > We can reuse float64_dcmask(). > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.h | 2 ++ > target/s390x/insn-data.def | 2 ++ > target/s390x/translate_vx.inc.c | 21 ++ > target/s390x/vec_fpu_helper.

Re: [Qemu-devel] [PATCH v1 22/23] s390x/tcg: We support the Vector Facility

2019-05-31 Thread Richard Henderson
On 5/31/19 5:44 AM, David Hildenbrand wrote: > Let's add it to the max model, so we can enable it. > > Signed-off-by: David Hildenbrand > --- > target/s390x/gen-features.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v1 21/23] s390x/tcg: Allow linux-user to use vector instructions

2019-05-31 Thread Richard Henderson
On 5/31/19 5:44 AM, David Hildenbrand wrote: > Once we unlock S390_FEAT_VECTOR for TCG, we want linux-user to be > able to make use of it. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v1 23/23] s390x: Bump the "qemu" CPU model up to a stripped-down z13

2019-05-31 Thread Richard Henderson
On 5/31/19 5:44 AM, David Hildenbrand wrote: > We don't care about the other two missing base features: > - S390_FEAT_DFP_PACKED_CONVERSION > - S390_FEAT_GROUP_GEN13_PTFF > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 2 ++ > target/s390x/cpu_models.c | 4 ++-- >

Re: [Qemu-devel] [PATCH v1 23/23] s390x: Bump the "qemu" CPU model up to a stripped-down z13

2019-05-31 Thread David Hildenbrand
On 31.05.19 19:57, Richard Henderson wrote: > On 5/31/19 5:44 AM, David Hildenbrand wrote: >> We don't care about the other two missing base features: >> - S390_FEAT_DFP_PACKED_CONVERSION >> - S390_FEAT_GROUP_GEN13_PTFF >> >> Signed-off-by: David Hildenbrand >> --- >> hw/s390x/s390-virtio-ccw.c

Re: [Qemu-devel] [PATCH v1 17/23] s390x/tcg: Implement VECTOR FP PERFORM SIGN OPERATION

2019-05-31 Thread David Hildenbrand
On 31.05.19 19:48, Richard Henderson wrote: > On 5/31/19 5:44 AM, David Hildenbrand wrote: >> +static DisasJumpType op_vfpso(DisasContext *s, DisasOps *o) >> +{ >> +const uint8_t fpf = get_field(s->fields, m3); >> +const uint8_t m4 = get_field(s->fields, m4); >> +const uint8_t m5 = get_

Re: [Qemu-devel] [PATCH v1 23/23] s390x: Bump the "qemu" CPU model up to a stripped-down z13

2019-05-31 Thread David Hildenbrand
On 31.05.19 20:06, Richard Henderson wrote: > On 5/31/19 12:58 PM, David Hildenbrand wrote: >> Are you aware of a HFP library? > > No. It might be possible to shoehorn into softfloat, because I *think* to can > treat HFP as BFP with weird rounding. At least that's what I remember from my > old c

Re: [Qemu-devel] [PULL v2 3/3] blockdev: acquire aio_context for bitmap add/remove

2019-05-31 Thread John Snow
On 5/31/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote: > Hi! > > 20.02.2019 21:01, John Snow wrote: >> When bitmaps are persistent, they may incur a disk read or write when bitmaps >> are added or removed. For configurations like virtio-dataplane, failing to >> acquire this lock will abort QEM

Re: [Qemu-devel] [PATCH] qapi: add dirty-bitmaps to query-named-block-nodes result

2019-05-31 Thread John Snow
On 5/31/19 10:55 AM, Eric Blake wrote: > On 5/30/19 11:26 AM, John Snow wrote: >> >> >> On 5/30/19 10:39 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Let's add a possibility to query dirty-bitmaps not only on root nodes. >>> It is useful when dealing both with snapshots and incremental backups. >

Re: [Qemu-devel] [PATCH v1 23/23] s390x: Bump the "qemu" CPU model up to a stripped-down z13

2019-05-31 Thread Richard Henderson
On 5/31/19 12:58 PM, David Hildenbrand wrote: > Are you aware of a HFP library? No. It might be possible to shoehorn into softfloat, because I *think* to can treat HFP as BFP with weird rounding. At least that's what I remember from my old college daze on the esa/390. Otherwise we could maybe s

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Michael S. Tsirkin
On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > Yes. It's just lots of extremely low level interfaces > > and all rather pointless. > > > > And down the road extensions like surprise removal support will make it > > all cleaner and more transparent. Floating things up to libvi

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Eduardo Habkost
On Fri, May 31, 2019 at 02:04:49PM -0400, Michael S. Tsirkin wrote: > On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > > Yes. It's just lots of extremely low level interfaces > > > and all rather pointless. > > > > > > And down the road extensions like surprise removal support

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > > Yes. It's just lots of extremely low level interfaces > > > and all rather pointless. > > > > > > And down the road extensions like surprise removal support will make it > > > all

Re: [Qemu-devel] [PULL v2 3/3] blockdev: acquire aio_context for bitmap add/remove

2019-05-31 Thread Vladimir Sementsov-Ogievskiy
31.05.2019 21:16, John Snow wrote: > > > On 5/31/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote: >> Hi! >> >> 20.02.2019 21:01, John Snow wrote: >>> When bitmaps are persistent, they may incur a disk read or write when >>> bitmaps >>> are added or removed. For configurations like virtio-dataplan

Re: [Qemu-devel] [PULL v2 3/3] blockdev: acquire aio_context for bitmap add/remove

2019-05-31 Thread John Snow
On 5/31/19 3:01 PM, Vladimir Sementsov-Ogievskiy wrote: > 31.05.2019 21:16, John Snow wrote: >> >> >> On 5/31/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi! >>> >>> 20.02.2019 21:01, John Snow wrote: When bitmaps are persistent, they may incur a disk read or write when bitmap

Re: [Qemu-devel] [PATCH v3] monitor: Fix return type of monitor_fdset_dup_fd_find

2019-05-31 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > David, got anything queued for the monitor? If yes, can you stick this > in? If not, I can handle it. I've not got anything else, so please take it; am I right in thinking this supercedes 'monitor: Fix fdset_id & fd types for corresponding QMP

[Qemu-devel] Deprecation policy and build dependencies

2019-05-31 Thread Eduardo Habkost
Long story short: I would really like to drop support for Python 2 in QEMU 4.1. What exactly prevents us from doing this? Does our deprecation policy really apply to build dependencies? -- Eduardo

Re: [Qemu-devel] [PULL v2 04/36] virtio: Introduce started flag to VirtioDevice

2019-05-31 Thread Eduardo Habkost
On Tue, May 28, 2019 at 10:48:09AM +0800, Yongji Xie wrote: > On Tue, 28 May 2019 at 02:54, Michael S. Tsirkin wrote: > > > > On Mon, May 27, 2019 at 12:44:46PM +0200, Greg Kurz wrote: > > > On Fri, 24 May 2019 19:56:06 +0800 > > > Yongji Xie wrote: > > > > > > > On Fri, 24 May 2019 at 18:20, Gre

Re: [Qemu-devel] [RFC PATCH 1/2] python/qemu: split QEMUMachine out from underneath __init__.py

2019-05-31 Thread Eduardo Habkost
On Tue, May 28, 2019 at 04:42:19PM -0400, John Snow wrote: > It's not obvious that something named __init__.py actually houses > important code that isn't relevant to python packaging glue. Move the > QEMUMachine and related error classes out into their own module. > > Adjust users to the new impo

Re: [Qemu-devel] [RFC PATCH 1/2] python/qemu: split QEMUMachine out from underneath __init__.py

2019-05-31 Thread John Snow
On 5/31/19 3:40 PM, Eduardo Habkost wrote: > On Tue, May 28, 2019 at 04:42:19PM -0400, John Snow wrote: >> It's not obvious that something named __init__.py actually houses >> important code that isn't relevant to python packaging glue. Move the >> QEMUMachine and related error classes out into

Re: [Qemu-devel] [PATCH v4] numa: improve cpu hotplug error message with a wrong node-id

2019-05-31 Thread Eduardo Habkost
On Wed, May 29, 2019 at 06:07:47PM +0200, Laurent Vivier wrote: > On pseries, core-ids are strongly binded to a node-id by the command > line option. If an user tries to add a CPU to the wrong node, he has > an error but it is not really helpful: > > qemu-system-ppc64 ... -smp 1,maxcpus=64,cores

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Alex Williamson
On Fri, 31 May 2019 19:45:13 +0100 "Dr. David Alan Gilbert" wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > > > Yes. It's just lots of extremely low level interfaces > > > > and all rather pointless. > > > > > > >

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Michael S. Tsirkin
On Fri, May 31, 2019 at 07:45:13PM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > > > Yes. It's just lots of extremely low level interfaces > > > > and all rather pointless. > > > > > > >

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Michael S. Tsirkin
On Fri, May 31, 2019 at 02:29:33PM -0600, Alex Williamson wrote: > I don't know what this frontend/backend rework would > look like for vfio-pci, but it seems non-trivial for this one use case > and I don't see that it adds any value outside of this use case, > perhaps quite the opposite, it's an o

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Eduardo Habkost
On Fri, May 31, 2019 at 04:43:44PM -0400, Michael S. Tsirkin wrote: > On Fri, May 31, 2019 at 07:45:13PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > > > > Yes. It's just lots of ext

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Eduardo Habkost
On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: > > On Tue, May 21, 2019 at 10:45:05AM +0100, Dr. David Alan Gilbert wrote: > > > * Jens Freimann (jfreim...@redhat.com) wrote: [...] > > > > +} > > > > +if (

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Eduardo Habkost
On Fri, May 31, 2019 at 05:05:26PM -0400, Michael S. Tsirkin wrote: > On Fri, May 31, 2019 at 02:29:33PM -0600, Alex Williamson wrote: > > I don't know what this frontend/backend rework would > > look like for vfio-pci, but it seems non-trivial for this one use case > > and I don't see that it adds

Re: [Qemu-devel] Deprecation policy and build dependencies

2019-05-31 Thread John Snow
On 5/31/19 3:24 PM, Eduardo Habkost wrote: > Long story short: I would really like to drop support for Python > 2 in QEMU 4.1. > > What exactly prevents us from doing this? Does our deprecation > policy really apply to build dependencies? > Normally I'd say it's only nice to also follow the

Re: [Qemu-devel] [PATCH for-4.1 2/2] target/riscv: Add support for -bios "firmware_filename" flag

2019-05-31 Thread Jonathan Behrens
I've thought some more about this issue, and long term I think there are a couple different useful configurations: - For end users, having default firmware that loaded the OS from a block device would be easiest - Current invocation: impossible - Proposed: empty command line (i.e

Re: [Qemu-devel] [PATCH v2 2/9] python/qemu: improve event_wait method of vm

2019-05-31 Thread John Snow
On 5/31/19 12:31 PM, Vladimir Sementsov-Ogievskiy wrote: > Support several names to wait for, which useful, when we don't sure > which event will we get. For example when mirror fails we get > BLOCK_JOB_COMPLETE otherwise we get BLOCK_JOB_READY (and only then, > after completing block-job we get

Re: [Qemu-devel] [PATCH v2 3/9] iotests: add test 255 to check bitmap life after snapshot + commit

2019-05-31 Thread John Snow
On 5/31/19 12:31 PM, Vladimir Sementsov-Ogievskiy wrote: > Two testcases with persistent bitmaps are not added here, as there are > bugs to be fixed soon. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/255 | 84 ++ > tests/qe

Re: [Qemu-devel] [PATCH v2 5/9] block/qcow2-bitmap: drop qcow2_reopen_bitmaps_rw_hint()

2019-05-31 Thread John Snow
On 5/31/19 12:31 PM, Vladimir Sementsov-Ogievskiy wrote: > The function is unused, drop it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.h| 2 -- > block/qcow2-bitmap.c | 15 +-- > 2 files changed, 1 insertion(+), 16 deletions(-) > > diff --git a/b

Re: [Qemu-devel] [PATCH v2 6/9] block/qcow2-bitmap: do not remove bitmaps on reopen-ro

2019-05-31 Thread John Snow
On 5/31/19 12:31 PM, Vladimir Sementsov-Ogievskiy wrote: > qcow2_reopen_bitmaps_ro wants to store bitmaps and then mark them all > readonly. But the latter don't work, as > qcow2_store_persistent_dirty_bitmaps removes bitmaps after storing. > It's OK for inactivation but bad idea for reopen-ro.

Re: [Qemu-devel] [PATCH v3 04/12] memory: Don't set migration bitmap when without migration

2019-05-31 Thread Peter Xu
On Fri, May 31, 2019 at 03:01:29PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > Similar to 9460dee4b2 ("memory: do not touch code dirty bitmap unless > > TCG is enabled", 2015-06-05) but for the migration bitmap - we can > > skip the MIGRATION bitmap update if migration not enabled. > > > > R

[Qemu-devel] "accel/tcg: demacro cputlb" break qemu-system-x86_64

2019-05-31 Thread Andrew Randrianasulu
Hello! I was compiling latest qemu git, and was surprized to find qemu-system-x86_64 (compiled for 32-bit x86 machine) can't boot any 64-bit kernel anymore. 32-bit kernels and kvm were fine. So, I run git bisect ./configure --target-list=x86_64-softmmu --disable-werror make -j 5 x86_64-softmm

Re: [Qemu-devel] [PATCH] migratioin/ram: leave RAMBlock->bmap blank on allocating

2019-05-31 Thread Peter Xu
On Fri, May 31, 2019 at 05:43:37PM +0100, Dr. David Alan Gilbert wrote: > * Wei Yang (richardw.y...@linux.intel.com) wrote: > > During migration, we would sync bitmap from ram_list.dirty_memory to > > RAMBlock.bmap in cpu_physical_memory_sync_dirty_bitmap(). > > > > Since we set RAMBlock.bmap and

Re: [Qemu-devel] [PATCH v10 4/7] dm: enable synchronous dax

2019-05-31 Thread Dan Williams
On Tue, May 21, 2019 at 6:43 AM Pankaj Gupta wrote: > > This patch sets dax device 'DAXDEV_SYNC' flag if all the target > devices of device mapper support synchrononous DAX. If device > mapper consists of both synchronous and asynchronous dax devices, > we don't set 'DAXDEV_SYNC' flag. > > Sig

<    1   2   3