[Qemu-devel] [PATCH v2 4/4] egl-helpers: add modifier support to egl_dmabuf_import_texture()

2019-05-24 Thread Gerd Hoffmann
Check and use QemuDmaBuf->modifier in egl_dmabuf_import_texture() for dmabuf imports. Signed-off-by: Gerd Hoffmann --- ui/egl-helpers.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index 0c9716067cfb..87

[Qemu-devel] [PATCH v2 2/4] vfio/display: set dmabuf modifier field

2019-05-24 Thread Gerd Hoffmann
Fill the new QemuDmaBuf->modifier field properly from plane info. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- hw/vfio/display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/vfio/display.c b/hw/vfio/display.c index a3d9c8f5beac..13969180b2dd 100644 --- a/hw/vfio/dis

[Qemu-devel] [PATCH v2 0/4] add drm modifier support for dmabufs.

2019-05-24 Thread Gerd Hoffmann
Gerd Hoffmann (4): console: add dmabuf modifier field. vfio/display: set dmabuf modifier field egl-helpers: add modifier support to egl_get_fd_for_texture(). egl-helpers: add modifier support to egl_dmabuf_import_texture() include/ui/console.h | 1 + include/ui/egl-helpers.h | 3

[Qemu-devel] [PATCH v2 1/5] usb-hub: tweak feature names

2019-05-24 Thread Gerd Hoffmann
Add dashes, so they don't look like two separate things when printed. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c index 7e9339b8a83d..9b04b6a6ec2d 100644 --- a/hw/usb/dev-hub.

[Qemu-devel] [PATCH v2 0/5] usb-hub: cleanups, configurable port count, per-port power switching emulation.

2019-05-24 Thread Gerd Hoffmann
v2: codestyle fixes. Gerd Hoffmann (5): usb-hub: tweak feature names usb-hub: make number of ports runtime-configurable usb-hub: add helpers to update port state usb-hub: add usb_hub_port_update() usb-hub: emulate per port power switching hw/usb/dev-hub.c | 221

[Qemu-devel] [PATCH v2 1/4] console: add dmabuf modifier field.

2019-05-24 Thread Gerd Hoffmann
dmabufs can have a format modifier (DRM_FORMAT_MOD_*) which is used for tiled layouts for example. Add a field to QemuDmaBuf so we can carry around that information. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- include/ui/console.h | 1 + 1 file changed, 1 insertion(+) diff

[Qemu-devel] [PATCH v2 5/5] usb-hub: emulate per port power switching

2019-05-24 Thread Gerd Hoffmann
Add support for per port power switching. Virtual power of course ;) Use port-power=on property to enable this. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 63 1 file changed, 63 insertions(+) diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-h

[Qemu-devel] [PATCH v2 3/4] egl-helpers: add modifier support to egl_get_fd_for_texture().

2019-05-24 Thread Gerd Hoffmann
Add modifier parameter to egl_get_fd_for_texture(), to return the used modifier on dmabuf exports. Signed-off-by: Gerd Hoffmann --- include/ui/egl-helpers.h | 3 ++- ui/egl-helpers.c | 5 +++-- ui/spice-display.c | 7 --- 3 files changed, 9 insertions(+), 6 deletions(-) diff -

[Qemu-devel] [PATCH v2 3/5] usb-hub: add helpers to update port state

2019-05-24 Thread Gerd Hoffmann
Add usb_hub_port_set() and usb_hub_port_clear() helpers which care about updating the change bits (port->wPortChange) properly, so we don't need to have that logic sprinkled all over the place ;) Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 84 ++---

Re: [Qemu-devel] [PATCH] configure: Only enable iconv if curses is enabled

2019-05-24 Thread Gerd Hoffmann
On Fri, May 17, 2019 at 04:18:05PM -0500, Kumar Gala wrote: > iconv is only used with if curses is enabled, there's no need to do any > configure checking for iconv, if curses is disabled. Also, ignore > --enable-iconv if curses is already disabled. How about just doing this ... --- a/configure

[Qemu-devel] [PATCH v2 4/5] usb-hub: add usb_hub_port_update()

2019-05-24 Thread Gerd Hoffmann
Helper function to update port status bits which depends on the connected device. We need the same logic for device attach and port reset, so factor it out. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) d

[Qemu-devel] [PATCH v2 2/5] usb-hub: make number of ports runtime-configurable

2019-05-24 Thread Gerd Hoffmann
Add num_ports property which allows configure the number of downstream ports. Valid range is 1-8, default is 8. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 45 + 1 file changed, 29 insertions(+), 16 deletions(-) diff --git a/hw/usb/dev-hub.c

Re: [Qemu-devel] [PATCH] linux-user: fix __NR_semtimedop undeclared error

2019-05-24 Thread Cornelia Huck
On Thu, 23 May 2019 19:54:13 +0200 Laurent Vivier wrote: > In current code, __NR_msgrcv and__NR_semtimedop are supposed to be > defined if __NR_msgsnd is defined. > > But linux headers 5.2-rc1 for MIPS define __NR_msgsnd without defining > __NR_semtimedop and it breaks the QEMU build. > > __NR_

Re: [Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/

2019-05-24 Thread Thomas Huth
On 23/05/2019 10.15, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster Please add a proper patch description. You don't really expect someone to review this monster patch without instructions where to look first? Thomas

Re: [Qemu-devel] [PATCH] linux-user: fix __NR_semtimedop undeclared error

2019-05-24 Thread Alex Bennée
Laurent Vivier writes: > In current code, __NR_msgrcv and__NR_semtimedop are supposed to be > defined if __NR_msgsnd is defined. > > But linux headers 5.2-rc1 for MIPS define __NR_msgsnd without defining > __NR_semtimedop and it breaks the QEMU build. > > __NR_semtimedop is defined in asm-mips/

Re: [Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/

2019-05-24 Thread Philippe Mathieu-Daudé
On 5/24/19 9:24 AM, Thomas Huth wrote: > On 23/05/2019 10.15, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster > > Please add a proper patch description. You don't really expect someone > to review this monster patch without instructions where to look first? >From the cover letter:

Re: [Qemu-devel] [PATCH 1/3] qapi/block-core: update documentation of preallocation parameter

2019-05-24 Thread Stefano Garzarella
On Thu, May 23, 2019 at 06:33:06PM +0200, Markus Armbruster wrote: > Stefano Garzarella writes: > > > Add default and available values in the documentation block of > > each block device or protocol that supports the 'preallocation' > > parameter during the image creation. > > > > Suggested-by: M

Re: [Qemu-devel] [PATCH 3/3] block/gluster: update .help of BLOCK_OPT_PREALLOC option

2019-05-24 Thread Stefano Garzarella
On Thu, May 23, 2019 at 06:35:18PM +0200, Markus Armbruster wrote: > Stefano Garzarella writes: > > > Show 'falloc' and 'full' among the allowed values of > > 'preallocation' option, only when they are supported > > ('falloc' is support if defined CONFIG_GLUSTERFS_FALLOCATE, > > 'full' is support

Re: [Qemu-devel] [PATCH 3/4] docker: update fedora to f30

2019-05-24 Thread Philippe Mathieu-Daudé
On 5/24/19 1:40 AM, Marc-André Lureau wrote: > Released last month. > > Signed-off-by: Marc-André Lureau > --- > tests/docker/dockerfiles/fedora.docker | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/docker/dockerfiles/fedora.docker > b/tests/docker/dockerfiles/f

Re: [Qemu-devel] [PATCH] tests/docker: Update the Fedora image to Fedora 30

2019-05-24 Thread Philippe Mathieu-Daudé
On 5/4/19 8:03 AM, Philippe Mathieu-Daudé wrote: > Fedora 30 got released: > > https://fedoramagazine.org/announcing-fedora-30/ > > Signed-off-by: Philippe Mathieu-Daudé > --- > Based-on: <20190408201203.28924-1-marcandre.lur...@redhat.com> > qxl: fix -Waddress-of-packed-member > >

Re: [Qemu-devel] [PATCH v2 1/5] usb-hub: tweak feature names

2019-05-24 Thread Philippe Mathieu-Daudé
On 5/24/19 9:03 AM, Gerd Hoffmann wrote: > Add dashes, so they don't look like two separate things when printed. > > Signed-off-by: Gerd Hoffmann > --- > hw/usb/dev-hub.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c > in

Re: [Qemu-devel] [PATCH v2 4/5] usb-hub: add usb_hub_port_update()

2019-05-24 Thread Philippe Mathieu-Daudé
On 5/24/19 9:03 AM, Gerd Hoffmann wrote: > Helper function to update port status bits which depends on the > connected device. We need the same logic for device attach and > port reset, so factor it out. > > Signed-off-by: Gerd Hoffmann > --- > hw/usb/dev-hub.c | 29 +---

[Qemu-devel] [PATCH v2 2/3] block/file-posix: update .help of BLOCK_OPT_PREALLOC option

2019-05-24 Thread Stefano Garzarella
Show 'falloc' among the allowed values of 'preallocation' option, only when it is supported (if defined CONFIG_POSIX_FALLOCATE) Signed-off-by: Stefano Garzarella Reviewed-by: Markus Armbruster --- block/file-posix.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/block/

[Qemu-devel] [PATCH v2 0/3] Update documentation and help related to the preallocation parameter

2019-05-24 Thread Stefano Garzarella
Following Markus' advice, I updated the documentation of preallocation parameter in qapi/block-core.json adding default and allowed values (patch 1). I also updated the help related to BLOCK_OPT_PREALLOC in the QemuOptsList of file-posix (patch 2) and gluster (patch 3). v2: - Patch 1: removed ref

[Qemu-devel] [PATCH v2 3/3] block/gluster: update .help of BLOCK_OPT_PREALLOC option

2019-05-24 Thread Stefano Garzarella
Add missing 'falloc' among the allowed values of 'preallocation' option; show it and 'full' only when they are supported. ('falloc' is supported if defined CONFIG_GLUSTERFS_FALLOCATE, 'full' is supported if defined CONFIG_GLUSTERFS_ZEROFILL) Signed-off-by: Stefano Garzarella Reviewed-by: Markus A

[Qemu-devel] [PATCH v2 1/3] qapi/block-core: update documentation of preallocation parameter

2019-05-24 Thread Stefano Garzarella
Add default and available values in the documentation block of each block device or protocol that supports the 'preallocation' parameter during the image creation. Suggested-by: Markus Armbruster Signed-off-by: Stefano Garzarella Reviewed-by: Markus Armbruster --- qapi/block-core.json | 20 +++

Re: [Qemu-devel] [PATCH v4 02/11] block: Filtered children access functions

2019-05-24 Thread Vladimir Sementsov-Ogievskiy
23.05.2019 20:27, Max Reitz wrote: > On 17.05.19 16:50, Vladimir Sementsov-Ogievskiy wrote: >> 10.04.2019 23:20, Max Reitz wrote: >>> What bs->file and bs->backing mean depends on the node. For filter >>> nodes, both signify a node that will eventually receive all R/W >>> accesses. For format nod

[Qemu-devel] [PATCH v2 2/2] target/i386: Add support for save/load IA32_UMWAIT_CONTROL MSR

2019-05-24 Thread Tao Xu
UMWAIT and TPAUSE instructions use IA32_UMWAIT_CONTROL at MSR index E1H to determines the maximum time in TSC-quanta that the processor can reside in either C0.1 or C0.2. This patch is to Add support for save/load IA32_UMWAIT_CONTROL MSR in guest. Co-developed-by: Jingqi Liu Signed-off-by: Jingq

[Qemu-devel] [PATCH v2 0/2] x86: Enable user wait instructions

2019-05-24 Thread Tao Xu
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. UMONITOR arms address monitoring hardware using an address. A store to an address within the specified address range triggers the monitoring hardware to wake up the processor waiting in umwait. UMWAIT instructs the processor to ente

[Qemu-devel] [PATCH v2 1/2] x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE

2019-05-24 Thread Tao Xu
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. Availability of the user wait instructions is indicated by the presence of the CPUID feature flag WAITPKG CPUID.0x07.0x0:ECX[5]. The patch enable the umonitor, umwait and tpause features in KVM. Because umwait and tpause can put a (p

[Qemu-devel] [PULL 0/3] Vga 20190524 patches

2019-05-24 Thread Gerd Hoffmann
The following changes since commit 8dc7fd56dd4f56ab8ff1df3765ae6b5d3ac11c5e: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20190523-pull-request' into staging (2019-05-23 14:15:34 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/vg

[Qemu-devel] [PATCH 1.5/15] nbd-server: Call blk_set_allow_aio_context_change()

2019-05-24 Thread Kevin Wolf
The NBD server uses an AioContext notifier, so it can tolerate that its BlockBackend is switched to a different AioContext. Before we start actually calling bdrv_try_set_aio_context(), which checks for consistency, outside of test cases, we need to make sure that the NBD server actually allows this

[Qemu-devel] [PULL 3/3] hw/display/ramfb: initialize fw-config space with xres/ yres

2019-05-24 Thread Gerd Hoffmann
From: Hou Qiming If xres / yres were specified in QEMU command line, write them as an initial resolution to the fw-config space on guest reset, which a later BIOS / OVMF patch can take advantage of. Signed-off-by: HOU Qiming Signed-off-by: Marcel Apfelbaum Message-id: 20190513115731.17588-4-ma

[Qemu-devel] [PULL 2/3] hw/display/ramfb: lock guest resolution after it's set

2019-05-24 Thread Gerd Hoffmann
From: Hou Qiming Only allow one resolution change per guest boot, which prevents a crash when the guest writes garbage to the configuration space (e.g. when rebooting). Signed-off-by: HOU Qiming Signed-off-by: Marcel Apfelbaum Message-id: 20190513115731.17588-3-marcel.apfelb...@gmail.com [fixe

[Qemu-devel] [PULL 1/3] hw/display/ramfb: fix guest memory un-mapping

2019-05-24 Thread Gerd Hoffmann
From: Hou Qiming Pulled back the `qemu_create_displaysurface_guestmem` function to create the display surface so that the guest memory gets properly unmapped. Signed-off-by: HOU Qiming Signed-off-by: Marcel Apfelbaum Message-id: 20190513115731.17588-2-marcel.apfelb...@gmail.com [rename the new

Re: [Qemu-devel] [PATCH] vmstate: Add VMSTATE_OPAQUE to save/load complex data structures

2019-05-24 Thread Peter Maydell
On Thu, 23 May 2019 at 18:02, Roman Kiryanov via Qemu-devel wrote: > > Hi Dave, thank you for looking. > > > Can you give me an example of where you would use it? > > We use it in our host memory sharing device. I used the existing > macros for all fields I could, but unfortunately some state does

Re: [Qemu-devel] Running linux on qemu omap

2019-05-24 Thread Peter Maydell
On Thu, 23 May 2019 at 19:36, Aaro Koskinen wrote: > Cheetah works with serial console. I tried with console on display, > and it seems to boot up, and the frame buffer window gets correctly > sized but for some reason it just stays blank. As a general question, when you're doing these tests are

Re: [Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/

2019-05-24 Thread Peter Maydell
On Thu, 23 May 2019 at 09:15, Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster > --- > 432 files changed, 1035 insertions(+), 8 deletions(-) > > diff --git a/accel/tcg/atomic_template.h b/accel/tcg/atomic_template.h > index 685602b076..352da0c745 100644 > --- a/accel/tcg/atomic_tem

Re: [Qemu-devel] [PULL 00/13] Add RX architecture

2019-05-24 Thread Peter Maydell
On Thu, 23 May 2019 at 15:01, Richard Henderson wrote: > > Thanks to Sato-san for persevering through 14 iterations. > > > r~ > > > The following changes since commit d418238dca7b4e0b124135827ead3076233052b1: > > Merge remote-tracking branch 'remotes/rth/tags/pull-rng-20190522' into > staging (

[Qemu-devel] [RISU PATCH] build-all-arches: include x86 triplets in the build

2019-05-24 Thread Alex Bennée
There are a couple of minor warts: - 32 bit x86 can be either i386-linux-gnu or i686-linux-gnu - skip looking for x86_64-linux-gnu-gcc in docker cross envs Signed-off-by: Alex Bennée --- build-all-archs | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/build-all

Re: [Qemu-devel] [RISU v3 07/11] test_i386: change syntax from nasm to gas

2019-05-24 Thread Alex Bennée
Jan Bobek writes: > This allows us to drop dependency on NASM and build the test image > with GCC only. Adds support for x86_64, too. > > Suggested-by: Richard Henderson > Reviewed-by: Richard Henderson > Signed-off-by: Jan Bobek Reviewed-by: Alex Bennée > --- > Makefile| 3 +++ > t

Re: [Qemu-devel] [RISU v3 09/11] i386: Add avx512 state to reginfo_t

2019-05-24 Thread Alex Bennée
Jan Bobek writes: > From: Richard Henderson > > The state expected for a given test must be specifically requested > with the --xfeatures=mask command-line argument. This is recorded > with the saved state so that it is obvious if the apprentice is given > a different argument. Any features

Re: [Qemu-devel] [RISU v3 11/11] risu_reginfo_i386: rework --xfeatures value parsing

2019-05-24 Thread Alex Bennée
Jan Bobek writes: > Have the --xfeatures option accept "sse", "avx" and "avx512" in > addition to a plain numerical value, purely for users' convenience. > Don't fail silently when an incorrect value is specified, to avoid > confusion. > > Suggested-by: Richard Henderson > Signed-off-by: Jan B

[Qemu-devel] [PATCH v2 0/5] s390x/tcg: Vector Instruction Support Part 3

2019-05-24 Thread David Hildenbrand
This is the third part of vector instruction support for s390x. It is based on part 2, which is will send a pull-request for to Conny soon. Part 1: Vector Support Instructions Part 2: Vector Integer Instructions Part 3: Vector String Instructions Part 4: Vector Floating-Point Instructions The cur

[Qemu-devel] [PATCH v2 3/5] s390x/tcg: Implement VECTOR FIND ELEMENT NOT EQUAL

2019-05-24 Thread David Hildenbrand
Similar to VECTOR FIND ELEMENT EQUAL. Core logic courtesy of Richard H. Add s390_vec_read_element() that can deal with element sizes. Signed-off-by: David Hildenbrand --- target/s390x/helper.h| 6 +++ target/s390x/insn-data.def | 2 + target/s390x/translate_vx.inc.c | 31 ++

[Qemu-devel] [PATCH v2 1/5] s390x/tcg: Implement VECTOR FIND ANY ELEMENT EQUAL

2019-05-24 Thread David Hildenbrand
Complicated stuff. Provide two different helpers for CC an !CC handling. We might want to add more helpers later. zero_search() and match_index() are courtesy of Richard H. Signed-off-by: David Hildenbrand --- target/s390x/Makefile.objs | 2 +- target/s390x/helper.h| 8 ++

[Qemu-devel] [PATCH v2 2/5] s390x/tcg: Implement VECTOR FIND ELEMENT EQUAL

2019-05-24 Thread David Hildenbrand
Core logic courtesy of Richard H. Signed-off-by: David Hildenbrand --- target/s390x/helper.h| 6 target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 31 + target/s390x/vec_string_helper.c | 57 4 files ch

[Qemu-devel] [PATCH v2 4/5] s390x/tcg: Implement VECTOR ISOLATE STRING

2019-05-24 Thread David Hildenbrand
Logic mostly courtesy of Richard H. Signed-off-by: David Hildenbrand --- target/s390x/helper.h| 6 + target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 34 target/s390x/vec_string_helper.c | 45

[Qemu-devel] [PATCH v2 5/5] s390x/tcg: Implement VECTOR STRING RANGE COMPARE

2019-05-24 Thread David Hildenbrand
Unfortunately, there is no easy way to avoid looping over all elements in v2. Provide specialized variants for !cc,!rt/!cc,rt/cc,!rt/cc,rt and all element types. Especially for different values of rt, the compiler might be able to optimize the code a lot. Add s390_vec_write_element(). Signed-off-

Re: [Qemu-devel] [RISU v3 00/11] Support for i386/x86_64 with vector extensions

2019-05-24 Thread Alex Bennée
Jan Bobek writes: > This patch series adds support for i386 and x86_64 architectures to > RISU. Notably, vector registers (SSE, AVX, AVX-512) are supported for > verification of the apprentice. This is V3 of the series posted in [1] > and [2]. I've sent a patch to enable x86 in the build-all-a

Re: [Qemu-devel] custom virt-io support (in user-mode-linux)

2019-05-24 Thread Johannes Berg
On Thu, 2019-05-23 at 15:41 +0100, Stefan Hajnoczi wrote: > > Also, not sure I understand how the client is started? > > The vhost-user device backend can be launched before QEMU. QEMU is > started with the UNIX domain socket path so it can connect. Hmm. I guess I'm confusing the terminology th

Re: [Qemu-devel] [PULL 00/12] target-arm queue

2019-05-24 Thread Peter Maydell
On Thu, 23 May 2019 at 15:23, Peter Maydell wrote: > > Not very much here, but several people have fallen over > the vector operation segfault bug, so let's get the fix > into master. > > thanks > -- PMM > > The following changes since commit d418238dca7b4e0b124135827ead3076233052b1: > > Merge r

Re: [Qemu-devel] [PULL v2 04/36] virtio: Introduce started flag to VirtioDevice

2019-05-24 Thread Greg Kurz
On Mon, 20 May 2019 19:10:35 -0400 "Michael S. Tsirkin" wrote: > From: Xie Yongji > > The virtio 1.0 transitional devices support driver uses the device > before setting the DRIVER_OK status bit. So we introduce a started > flag to indicate whether driver has started the device or not. > > Sig

Re: [Qemu-devel] [PULL 00/16] tcg queued patches

2019-05-24 Thread Peter Maydell
On Wed, 22 May 2019 at 23:28, Richard Henderson wrote: > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into > staging (2019-05-21 16:30:13 +0100) > > are available in the Git repository at:

[Qemu-devel] [PATCH v3] numa: improve cpu hotplug error message with a wrong node-id

2019-05-24 Thread Laurent Vivier
On pseries, core-ids are strongly binded to a node-id by the command line option. If an user tries to add a CPU to the wrong node, he has an error but it is not really helpful: qemu-system-ppc64 ... -smp 1,maxcpus=64,cores=1,threads=1,sockets=1 \ -numa node,nodeid=0 -numa

Re: [Qemu-devel] [PATCH v2 03/28] semihosting: implement a semihosting console

2019-05-24 Thread Alex Bennée
Peter Maydell writes: > On Thu, 23 May 2019 at 11:39, Alex Bennée wrote: >> >> This provides two functions for handling console output that handle >> the common backend behaviour for semihosting. >> >> Signed-off-by: Alex Bennée > >> diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.

Re: [Qemu-devel] [PATCH v8 5/8] contrib: add vhost-user-gpu

2019-05-24 Thread Gerd Hoffmann
On Thu, May 23, 2019 at 03:20:32PM +0200, Marc-André Lureau wrote: > Add a vhost-user gpu backend, based on virtio-gpu/3d device. It is > associated with a vhost-user-gpu device. > > Various TODO and nice to have items: > - multi-head support > - crash & resume handling > - accelerated rendering/d

Re: [Qemu-devel] [PATCH v2 03/28] semihosting: implement a semihosting console

2019-05-24 Thread Peter Maydell
On Fri, 24 May 2019 at 11:46, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Thu, 23 May 2019 at 11:39, Alex Bennée wrote: > > I'm not sure about the "no callback" part of this API. The operation > > here is genuinely asynchronous and providing no mechanism for the > > caller to be able

Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes

2019-05-24 Thread Laszlo Ersek
On 05/23/19 10:37, Peter Maydell wrote: > On Thu, 23 May 2019 at 01:51, Laszlo Ersek wrote: >> I have narrowed down the issue sufficiently that I think I can hand >> it over to Peter and Ard now -- because they know AARCH32 and AARCH64 >> assembly, and "target/arm/translate-a64.c" and "tcg/arm/*"

Re: [Qemu-devel] [PATCH v8 0/8] Add vhost-user-gpu

2019-05-24 Thread Gerd Hoffmann
On Thu, May 23, 2019 at 03:20:27PM +0200, Marc-André Lureau wrote: > Hi, > > vhost-user allows to drive a virtio device in a seperate > process. After vhost-user-net, we have seen > vhost-user-{scsi,blk,crypto,input} added more recently. > > This series, initially proposed ~3 years ago, time flie

Re: [Qemu-devel] [PATCH 3/4] docker: update fedora to f30

2019-05-24 Thread Marc-André Lureau
Hi On Fri, May 24, 2019 at 9:41 AM Philippe Mathieu-Daudé wrote: > > On 5/24/19 1:40 AM, Marc-André Lureau wrote: > > Released last month. > > > > Signed-off-by: Marc-André Lureau > > --- > > tests/docker/dockerfiles/fedora.docker | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >

Re: [Qemu-devel] [PULL 00/10] Linux user for 4.1 patches

2019-05-24 Thread Peter Maydell
On Thu, 23 May 2019 at 15:47, Laurent Vivier wrote: > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into > staging (2019-05-21 16:30:13 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v2 03/28] semihosting: implement a semihosting console

2019-05-24 Thread Alex Bennée
Peter Maydell writes: > On Fri, 24 May 2019 at 11:46, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> >> > On Thu, 23 May 2019 at 11:39, Alex Bennée wrote: >> > I'm not sure about the "no callback" part of this API. The operation >> > here is genuinely asynchronous and providing no mech

[Qemu-devel] [PULL v2 3/9] linux-user: Fix support for SIOCATMARK and SIOCGPGRP ioctls for xtensa

2019-05-24 Thread Laurent Vivier
From: Aleksandar Markovic Fix support for the SIOCATMARK and SIOCGPGRP ioctls for xtensa by correcting corresponding macro definition. Values for TARGET_SIOCATMARK and TARGET_SIOCGPGRP are determined by Linux kernel. Following relevant lines (obtained by grep) are from the kernel source tree: a

[Qemu-devel] [PULL v2 5/9] linux-user: Add support for SIOCIFPFLAGS ioctls for all targets

2019-05-24 Thread Laurent Vivier
From: Neng Chen Add support for getting and setting extended private flags of a network device via SIOCSIFPFLAGS and SIOCGIFPFLAGS ioctls. The ioctl numeric values are platform-independent and determined by the file include/uapi/linux/sockios.h in Linux kernel source code: #define SIOCSIFPFLA

Re: [Qemu-devel] [PULL 00/10] Linux user for 4.1 patches

2019-05-24 Thread Laurent Vivier
On 24/05/2019 13:07, Peter Maydell wrote: On Thu, 23 May 2019 at 15:47, Laurent Vivier wrote: The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into staging (2019-05-21 16:30:13 +0100) are avai

[Qemu-devel] [PULL v2 1/9] linux-user: add pseudo /proc/cpuinfo for sparc

2019-05-24 Thread Laurent Vivier
SPARC libc6 debian package wants to check the cpu level to be installed or not: WARNING: This machine has a SPARC V8 or earlier class processor. Debian lenny and later does not support such old hardware any longer. To avoid this, it only needs to know if the machine type is sun4u or sun4v,

[Qemu-devel] [PULL v2 7/9] linux-user: Fix shmat emulation by honoring host SHMLBA

2019-05-24 Thread Laurent Vivier
From: Richard Henderson For those hosts with SHMLBA > getpagesize, we don't automatically select a guest address that is compatible with the host. We can achieve this by boosting the alignment of guest_base and by adding an extra alignment argument to mmap_find_vma. Signed-off-by: Richard Hende

[Qemu-devel] [PULL v2 8/9] linux-user: Align mmap_find_vma to host page size

2019-05-24 Thread Laurent Vivier
From: Richard Henderson This can avoid stack allocation failures for i386 guest on ppc64 (64k page) host. Suggested-by: Laurent Vivier Signed-off-by: Richard Henderson Message-Id: <20190519201953.20161-14-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/mmap.c | 2 +

[Qemu-devel] [PULL v2 4/9] linux-user: Add support for SIOCSPGRP ioctl for all targets

2019-05-24 Thread Laurent Vivier
From: Aleksandar Markovic Add support for setting the process (or process group) to receive SIGIO or SIGURG signals when I/O becomes possible or urgent data is available, using SIOCSPGRP ioctl. The ioctl numeric values for SIOCSPGRP are platform-dependent and are determined by following files in

[Qemu-devel] [PULL v2 2/9] linux-user: add pseudo /proc/hardware for m68k

2019-05-24 Thread Laurent Vivier
Debian console-setup uses /proc/hardware to guess the keyboard layout. If the file /proc/hardware cannot be opened, the installation fails. This patch adds a pseudo /proc/hardware file to report the model of the machine. Instead of reporting a known and fake model, it reports "qemu-m68k", which is

[Qemu-devel] [PULL v2 9/9] linux-user: Pass through nanosecond timestamp components for stat syscalls

2019-05-24 Thread Laurent Vivier
From: Chen-Yu Tsai Since Linux 2.6 the stat syscalls have mostly supported nanosecond components for each of the file-related timestamps. QEMU user mode emulation currently does not pass through the nanosecond portion of the timestamp, even when the host system fills in the value. This results i

[Qemu-devel] [PULL v2 6/9] linux-user: Sanitize interp_info and, for mips only, init field fp_abi

2019-05-24 Thread Laurent Vivier
From: Daniel Santos Sanitize interp_info structure in load_elf_binary() and, for MIPS only, init its field fp_abi to MIPS_ABI_FP_UNKNOWN. This fixes appearances of "Unexpected FPU mode" message in some MIPS use cases. Currently, this bug is a complete stopper for some MIPS binaries. In load_elf_

[Qemu-devel] [PULL v2 0/9] Linux user for 4.1 patches

2019-05-24 Thread Laurent Vivier
The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into staging (2019-05-21 16:30:13 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-4.1-pull-req

Re: [Qemu-devel] [PATCH v8 5/8] contrib: add vhost-user-gpu

2019-05-24 Thread Marc-André Lureau
On Fri, May 24, 2019 at 12:50 PM Gerd Hoffmann wrote: > > On Thu, May 23, 2019 at 03:20:32PM +0200, Marc-André Lureau wrote: > > Add a vhost-user gpu backend, based on virtio-gpu/3d device. It is > > associated with a vhost-user-gpu device. > > > > Various TODO and nice to have items: > > - multi-

Re: [Qemu-devel] [RFC v4 1/7] Makefile: Remove code to smooth transition to config.status

2019-05-24 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi Markus, > > On 5/23/19 10:15 AM, Markus Armbruster wrote: >> When commit bdf523e6923 made configure generate config.status, it >> added a fallback to Makefile to smooth the transition, with a TODO >> "code can be removed after QEMU 1.7." It's been more than fi

Re: [Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/

2019-05-24 Thread Markus Armbruster
Thomas Huth writes: > On 23/05/2019 10.15, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster > > Please add a proper patch description. You don't really expect someone > to review this monster patch without instructions where to look first? Fair point. RFC is no excuse for making re

Re: [Qemu-devel] [PULL 0/3] Vga 20190524 patches

2019-05-24 Thread Peter Maydell
00) > > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/vga-20190524-pull-request > > for you to fetch changes up to f79081b4b71b72640bedd40a7cd76f864c8287f1: > > hw/display/ramfb: initialize fw-config

Re: [Qemu-devel] [PATCH 03/20] hw/i386/pc: Let e820_add_entry() return a ssize_t type

2019-05-24 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年5月24日周五 下午2:43写道: > e820_add_entry() returns an array size on success, or a negative > value on error. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Li Qiang > --- > hw/i386/pc.c | 2 +- > include/hw/i386/pc.h | 2 +- > 2 files changed, 2 ins

Re: [Qemu-devel] [PATCH 02/20] hw/i386/pc: Use size_t type to hold/return a size of array

2019-05-24 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年5月24日周五 下午2:37写道: > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Li Qiang > --- > hw/i386/pc.c | 4 ++-- > include/hw/i386/pc.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index fc38b

Re: [Qemu-devel] [PULL v2 04/36] virtio: Introduce started flag to VirtioDevice

2019-05-24 Thread Yongji Xie
On Fri, 24 May 2019 at 18:20, Greg Kurz wrote: > > On Mon, 20 May 2019 19:10:35 -0400 > "Michael S. Tsirkin" wrote: > > > From: Xie Yongji > > > > The virtio 1.0 transitional devices support driver uses the device > > before setting the DRIVER_OK status bit. So we introduce a started > > flag to

Re: [Qemu-devel] [PATCH 01/20] hw/i386/pc: Use unsigned type to index arrays

2019-05-24 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年5月24日周五 下午2:40写道: > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Li Qiang > --- > hw/i386/pc.c | 5 +++-- > include/hw/i386/pc.h | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 2632b

Re: [Qemu-devel] [PATCH 07/15] test-block-iothread: Test adding parent to iothread node

2019-05-24 Thread Eric Blake
On 5/23/19 11:00 AM, Kevin Wolf wrote: > Opening a new parent node for a node that has already been moved into a > different AioContext must cause the new parent ot move into the same to > context. > > Signed-off-by: Kevin Wolf > --- > tests/test-block-iothread.c | 33 +

Re: [Qemu-devel] [PATCH 01/15] test-block-iothread: Check filter node in test_propagate_mirror

2019-05-24 Thread Eric Blake
On 5/23/19 11:00 AM, Kevin Wolf wrote: > Just make the test cover the AioContext of the filter node as well. > > Signed-off-by: Kevin Wolf > --- > tests/test-block-iothread.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Sof

Re: [Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/

2019-05-24 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 23 May 2019 at 09:15, Markus Armbruster wrote: >> >> Signed-off-by: Markus Armbruster >> --- > >> 432 files changed, 1035 insertions(+), 8 deletions(-) >> >> diff --git a/accel/tcg/atomic_template.h b/accel/tcg/atomic_template.h >> index 685602b076..352da0c745 1

Re: [Qemu-devel] [PATCH] tests/docker: Update the Fedora image to Fedora 30

2019-05-24 Thread Stefano Garzarella
On Fri, May 24, 2019 at 09:44:41AM +0200, Philippe Mathieu-Daudé wrote: > On 5/4/19 8:03 AM, Philippe Mathieu-Daudé wrote: > > Fedora 30 got released: > > > > https://fedoramagazine.org/announcing-fedora-30/ > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > Based-on: <20190408201203.28

Re: [Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/

2019-05-24 Thread Peter Maydell
On Fri, 24 May 2019 at 13:25, Markus Armbruster wrote: > > Peter Maydell writes: > > > On Thu, 23 May 2019 at 09:15, Markus Armbruster wrote: > >> > >> Signed-off-by: Markus Armbruster > >> --- > > > >> 432 files changed, 1035 insertions(+), 8 deletions(-) > >> > >> diff --git a/accel/tcg/atom

Re: [Qemu-devel] [PATCH 1.5/15] nbd-server: Call blk_set_allow_aio_context_change()

2019-05-24 Thread Eric Blake
On 5/24/19 3:57 AM, Kevin Wolf wrote: > The NBD server uses an AioContext notifier, so it can tolerate that its > BlockBackend is switched to a different AioContext. Before we start > actually calling bdrv_try_set_aio_context(), which checks for > consistency, outside of test cases, we need to make

Re: [Qemu-devel] [PULL v2 0/9] Linux user for 4.1 patches

2019-05-24 Thread Peter Maydell
On Fri, 24 May 2019 at 12:36, Laurent Vivier wrote: > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into > staging (2019-05-21 16:30:13 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support

2019-05-24 Thread Laszlo Ersek
Hi, On 11/02/18 18:16, Peter Maydell wrote: > From: Richard Henderson > > When populating id registers from kvm, on a host that doesn't support > aarch32 mode at all, neither arm_div nor jazelle will be supported either. > > Signed-off-by: Richard Henderson > Reviewed-by: Alex Bennée > Tested

Re: [Qemu-devel] [PATCH 04/20] hw/i386/pc: Add the E820Type enum type

2019-05-24 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年5月24日周五 下午2:45写道: > This ensure we won't use an incorrect value. > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/pc.c | 12 +++- > include/hw/i386/pc.h | 16 ++-- > 2 files changed, 17 insertions(+), 11 deletions(-) > > diff --git

Re: [Qemu-devel] [RFC v4 3/7] Makefile: Rename targets for make recursion

2019-05-24 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 5/23/19 10:15 AM, Markus Armbruster wrote: >> We make a few sub-directories recursively, in particular >> $(TARGET_DIRS). >> >> For goal "all", we do it the nice way: "all" has a prerequisite >> subdir-T for each T in $(TARGET_DIRS), and T's recipe runs make >

Re: [Qemu-devel] [PATCH v4 04/11] acpi: introduce AcpiDeviceIfClass.build_mem_ranges hook

2019-05-24 Thread Igor Mammedov
On Wed, 8 May 2019 14:17:19 +0800 Tao Xu wrote: > Add build_mem_ranges callback to AcpiDeviceIfClass and use > it for generating SRAT and HMAT numa memory ranges. > > Suggested-by: Igor Mammedov > Co-developed-by: Liu Jingqi > Signed-off-by: Liu Jingqi > Signed-off-by: Tao Xu > --- > > Cha

Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source

2019-05-24 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 5/23/19 10:15 AM, Markus Armbruster wrote: >> Make target check-source is for checking the source code itself. For >> now, there's just one such check, make target check-headers. It >> checks basic header sanity: for each header "FOO.h", test whether >> >>

Re: [Qemu-devel] [PATCH v3 3/5] QEMUMachine: add events_wait method

2019-05-24 Thread Max Reitz
On 23.05.19 20:03, John Snow wrote: > > > On 5/23/19 1:49 PM, Max Reitz wrote: >> On 23.05.19 19:06, John Snow wrote: >>> Instead of event_wait which looks for a single event, add an events_wait >>> which can look for any number of events simultaneously. However, it >>> will still only return one

[Qemu-devel] [PATCH v2 2/2] hw/intc/arm_gicv3: GICD_TYPER.SecurityExtn is RAZ if GICD_CTLR.DS == 1

2019-05-24 Thread Peter Maydell
The GICv3 specification says that the GICD_TYPER.SecurityExtn bit is RAZ if GICD_CTLR.DS is 1. We were incorrectly making it RAZ if the security extension is unsupported. "Security extension unsupported" always implies GICD_CTLR.DS == 1, but the guest can also set DS on a GIC which does support the

[Qemu-devel] [PATCH v2 0/2] hw/intc/arm_gicv3: Some simple bugfixes

2019-05-24 Thread Peter Maydell
This patchset fixes a couple of simple bugs in our GICv3 implementation. Changes since v1: * patches 3 and 4 from the old patchset are now in master * patch 1 now covers both the read and write functions I've also just noticed (via grep for IDREGS) that we made the same decode mistake in the SM

[Qemu-devel] [PATCH v2 1/2] hw/intc/arm_gicv3: Fix decoding of ID register range

2019-05-24 Thread Peter Maydell
The GIC ID registers cover an area 0x30 bytes in size (12 registers, 4 bytes each). We were incorrectly decoding only the first 0x20 bytes. Signed-off-by: Peter Maydell --- hw/intc/arm_gicv3_dist.c | 4 ++-- hw/intc/arm_gicv3_redist.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support

2019-05-24 Thread Laszlo Ersek
On 05/24/19 14:33, Laszlo Ersek wrote: > Hi, > > On 11/02/18 18:16, Peter Maydell wrote: >> From: Richard Henderson >> >> When populating id registers from kvm, on a host that doesn't support >> aarch32 mode at all, neither arm_div nor jazelle will be supported either. >> >> Signed-off-by: Richard

[Qemu-devel] [PATCH] hw/arm/smmuv3: Fix decoding of ID register range

2019-05-24 Thread Peter Maydell
The SMMUv3 ID registers cover an area 0x30 bytes in size (12 registers, 4 bytes each). We were incorrectly decoding only the first 0x20 bytes. Signed-off-by: Peter Maydell --- hw/arm/smmuv3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c in

  1   2   3   >