Re: [Qemu-devel] [PATCH qemu v2] hmp: Print if memory section is registered with an accelerator

2019-05-21 Thread Alexey Kardashevskiy
Ping, anyone? I still enjoy seeing "kvm" next to MRs in "info mtree -f" in my local QEMU :) On 24/04/2019 15:32, Alexey Kardashevskiy wrote: > Paolo, ping? > > > On 19/03/2019 18:05, Alexey Kardashevskiy wrote: >> >> >> On 11/02/2019 15:56, Alexey Kardashevskiy wrote: >>> >>> >>> On 09/02/2019

[Qemu-devel] [PULL 21/38] spapr: Add forgotten capability to migration stream

2019-05-21 Thread David Gibson
spapr machine capabilities are supposed to be sent in the migration stream so that we can sanity check the source and destination have compatible configuration. Unfortunately, when we added the hpt-max-page-size capability, we forgot to add it to the migration state. This means that we can genera

[Qemu-devel] [PULL 25/38] linux-headers: Update linux headers to 5.2-rc1

2019-05-21 Thread David Gibson
From: Cédric Le Goater Update the QEMU copy of the Linux headers to upstream 5.2-rc1 (linux commit a188339ca5a3). Signed-off-by: Cédric Le Goater Message-Id: <20190520062552.389-1-...@kaod.org> Signed-off-by: David Gibson --- .../infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h | 15 +- include/sta

[Qemu-devel] [PULL 26/38] spapr/xive: add KVM support

2019-05-21 Thread David Gibson
From: Cédric Le Goater This introduces a set of helpers when KVM is in use, which create the KVM XIVE device, initialize the interrupt sources at a KVM level and connect the interrupt presenters to the vCPU. They also handle the initialization of the TIMA and the source ESB memory regions of the

[Qemu-devel] [PULL 34/38] spapr: check for the activation of the KVM IRQ device

2019-05-21 Thread David Gibson
From: Cédric Le Goater The activation of the KVM IRQ device depends on the interrupt mode chosen at CAS time by the machine and some methods used at reset or by the migration need to be protected. Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson Signed-off-by: Cédric Le Goater Messag

Re: [Qemu-devel] [PATCH v9 02/27] gdbstub: Implement deatch (D pkt) with new infra

2019-05-21 Thread Alex Bennée
Jon Doron writes: > Hi Alex, I implemented this change but i'm having second guesses on > this, basically a NULL packet means the command is not supported (as > far as i understand from the protocol documentation and implementation > of GDB) > That being said I think it's correct to send back a

Re: [Qemu-devel] [PULL 00/38] ppc-for-4.1 queue 20190521

2019-05-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190521062924.6930-1-da...@gibson.dropbear.id.au/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/38] ppc-for-4.1 queue 20190521 Message-id: 20190521062924.6930-1-da

Re: [Qemu-devel] [PATCH v3 1/7] tests/libqos: Add io_fw_cfg_uninit() and mm_fw_cfg_uninit()

2019-05-21 Thread Laszlo Ersek
On 05/20/19 23:36, Philippe Mathieu-Daudé wrote: > The mm_fw_cfg_init() allocates a QFWCFG object, > add mm_fw_cfg_uninit() to deallocate it. > Similarly with io_fw_cfg_init(), add io_fw_cfg_uninit(). > > Signed-off-by: Li Qiang > Tested-by: Thomas Huth > Reviewed-by: Philippe Mathieu-Daudé > T

Re: [Qemu-devel] [qemu-s390x] [PULL 00/54] s390x update

2019-05-21 Thread Christian Borntraeger
On 20.05.19 21:00, Cornelia Huck wrote: > On Mon, 20 May 2019 18:30:46 +0100 > Peter Maydell wrote: > >> On Mon, 20 May 2019 at 18:03, Cornelia Huck wrote: >>> >>> The following changes since commit d8276573da58e8ce78dab8c46dd660efd664bcb7: >>> >>> Merge remote-tracking branch 'remotes/rth/

Re: [Qemu-devel] [PATCH v3 2/7] tests/libqos: Add pc_fw_cfg_uninit() and use it

2019-05-21 Thread Laszlo Ersek
On 05/20/19 23:36, Philippe Mathieu-Daudé wrote: > The pc_fw_cfg_init() function allocates an IO QFWCFG object. > Add the pc_fw_cfg_uninit() function to deallocate it (and use it). > > Signed-off-by: Li Qiang > Tested-by: Thomas Huth > Message-Id: <20190424140643.62457-2-liq...@163.com> > Review

Re: [Qemu-devel] [PATCH 0/4] add failover feature for assigned network devices

2019-05-21 Thread Jens Freimann
On Mon, May 20, 2019 at 04:56:57PM -0600, Alex Williamson wrote: On Fri, 17 May 2019 14:58:16 +0200 Jens Freimann wrote: Command line example: qemu-system-x86_64 -enable-kvm -m 3072 -smp 3 \ -machine q35,kernel-irqchip=split -cpu host \ -k fr \ -serial stdio \

[Qemu-devel] [PATCH v2] numa: improve cpu hotplug error message with a wrong node-id

2019-05-21 Thread Laurent Vivier
On pseries, core-ids are strongly binded to a node-id by the command line option. If an user tries to add a CPU to the wrong node, he has an error but it is not really helpful: qemu-system-ppc64 ... -smp 1,maxcpus=64,cores=1,threads=1,sockets=1 \ -numa node,nodeid=0 -numa

[Qemu-devel] ping Re: [PATCH v2 for 4.1 0/2] avoid lseek on block_status

2019-05-21 Thread Vladimir Sementsov-Ogievskiy
ping 08.04.2019 19:26, Vladimir Sementsov-Ogievskiy wrote: > Hi! > > It's a continuation for > "[PATCH] qcow2: avoid lseek on block_status if possible" > https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06598.html > > performance results for block-status on tmpfs [tests originally by Kev

Re: [Qemu-devel] [PATCH v6 0/3] block/stream: get rid of the base

2019-05-21 Thread Vladimir Sementsov-Ogievskiy
ping 06.05.2019 18:34, Vladimir Sementsov-Ogievskiy wrote: > This series introduces a bottom intermediate node that eliminates the > dependency on the base that may change while stream job is running. > It happens when stream/commit parallel jobs are running on the same > backing chain. The base n

Re: [Qemu-devel] [PATCH v2 2/6] tests/vhost-user-bridge: Fix misuse of isdigit()

2019-05-21 Thread Thomas Huth
On 14/05/2019 20.41, Thomas Huth wrote: > On 14/05/2019 20.03, Markus Armbruster wrote: >> vubr_set_host() passes char values to isdigit(). Undefined behavior >> when the value is negative. >> >> Fix by using qemu_isdigit() instead. >> >> Signed-off-by: Markus Armbruster >> --- >> tests/vhost-us

[Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard

2019-05-21 Thread Wei Yang
All the python script in scripts/qapi is used to generate qapi code. Use wildcard to simplify it. Signed-off-by: Wei Yang --- Makefile | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 155f066a20..38b74782d9 100644 --- a/Makefile +++ b/Makefile

Re: [Qemu-devel] [PATCH v2] docs: provide documentation on the POWER9 XIVE interrupt controller

2019-05-21 Thread Greg Kurz
On Fri, 17 May 2019 11:44:35 +0200 Cédric Le Goater wrote: > This documents the overall XIVE architecture and the XIVE support for > sPAPR guest machines (pseries). > > It also provides documentation on the 'info pic' command. > > Signed-off-by: Cédric Le Goater > --- LGTM. Just found two typ

Re: [Qemu-devel] [PATCH 4/4] BootLinuxSshTest: Test some userspace commands on Malta

2019-05-21 Thread Aleksandar Markovic
On May 21, 2019 1:19 AM, "Philippe Mathieu-Daudé" wrote: > > This tests boot a full VM and check the serial console until > the SSH daemon is running, then start a SSH session and run > some commands. > > This test can be run using: > > $ avocado --show=ssh run -t arch:mips tests/acceptance/linu

[Qemu-devel] [PATCH qemu-web] Add a blog post about micro:bit emulation

2019-05-21 Thread Stefan Hajnoczi
QEMU 4.0 ships the core micro:bit emulation that was implemented during Outreachy and GSoC 2018. This blog posts explains how to use it and describes the current status. Signed-off-by: Stefan Hajnoczi --- _posts/2019-05-21-microbit.md | 132 ++ screenshots/makeco

[Qemu-devel] [PATCH v3] docs: provide documentation on the POWER9 XIVE interrupt controller

2019-05-21 Thread Cédric Le Goater
This documents the overall XIVE architecture and the XIVE support for sPAPR guest machines (pseries). It also provides documentation on the 'info pic' command. Signed-off-by: Cédric Le Goater --- Changes since v2: - fixed typos. Changes since v1: - reorganized into different files and di

Re: [Qemu-devel] [PATCH 2/4] BootLinuxConsoleTest: Test nanoMIPS kernels on the I7200 CPU

2019-05-21 Thread Aleksandar Markovic
On May 21, 2019 1:19 AM, "Philippe Mathieu-Daudé" wrote: > > Similar to the x86_64/pc test, it boots a Linux kernel on a Malta > machine and verify the serial is working. > > Use the documentation added in commit f7d257cb4a17 to test > nanoMIPS kernels and the I7200 CPU. > > This test can be run u

Re: [Qemu-devel] [PATCH 0/4] add failover feature for assigned network devices

2019-05-21 Thread Daniel P . Berrangé
On Fri, May 17, 2019 at 02:58:16PM +0200, Jens Freimann wrote: > This is another attempt at implementing the host side of the > net_failover concept > (https://www.kernel.org/doc/html/latest/networking/net_failover.html) > > Changes since last RFC: > - work around circular dependency of commandlin

Re: [Qemu-devel] [PATCH 3/4] BootLinuxConsoleTest: Run kerneltests BusyBox on Malta

2019-05-21 Thread Aleksandar Markovic
On May 21, 2019 1:19 AM, "Philippe Mathieu-Daudé" wrote: > > This tests boots a Linux kernel on a Malta machine up to a > busybox shell on the serial console. Few commands are executed > before halting the machine (via reboot). > > We use the initrd cpio image from the kerneltests project: > https

Re: [Qemu-devel] [qemu-s390x] [PULL 00/54] s390x update

2019-05-21 Thread Cornelia Huck
On Tue, 21 May 2019 09:20:15 +0200 Christian Borntraeger wrote: > On 20.05.19 21:00, Cornelia Huck wrote: > > On Mon, 20 May 2019 18:30:46 +0100 > > Peter Maydell wrote: > > > >> On Mon, 20 May 2019 at 18:03, Cornelia Huck wrote: > >>> > >>> The following changes since commit > >>> d82765

[Qemu-devel] [RFC PATCH 3/3] block/qcow2: implement .bdrv_co_preadv_part

2019-05-21 Thread Vladimir Sementsov-Ogievskiy
Implement and use new interface to get rid of hd_qiov. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 45 - 1 file changed, 20 insertions(+), 25 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 5b4e5e7537..dcfa688c13 1006

[Qemu-devel] [RFC PATCH 0/3] block: qiov_offset parameter for io

2019-05-21 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is idea of adding qiov_offset parameter to io path, to avoid a lot of places with same pattern of creating local_qiov or hd_qiov variables. Here is only read path for qcow2, if we like it, I'll make v2 with both read and write paths for qcow2. Vladimir Sementsov-Ogievskiy (3): bloc

[Qemu-devel] [RFC PATCH 2/3] block/qcow2: refactor qcow2_co_preadv to use buffer-based io

2019-05-21 Thread Vladimir Sementsov-Ogievskiy
Use buffer based io in encrypted case. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index de524d870b..5b4e5e7537 100644 --- a/block/qcow2.c +++ b/bloc

Re: [Qemu-devel] [RFC PATCH 0/3] block: qiov_offset parameter for io

2019-05-21 Thread Vladimir Sementsov-Ogievskiy
21.05.2019 11:45, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is idea of adding qiov_offset parameter to io path, to avoid > a lot of places with same pattern of creating local_qiov or hd_qiov > variables. Here is only read path for qcow2, if we like it, I'll > make v2 with both read an

Re: [Qemu-devel] [PATCH qemu-web] Add a blog post about micro:bit emulation

2019-05-21 Thread Thomas Huth
On 21/05/2019 10.20, Stefan Hajnoczi wrote: > QEMU 4.0 ships the core micro:bit emulation that was implemented during > Outreachy and GSoC 2018. This blog posts explains how to use it and > describes the current status. [...] > +* Boot, device driver, and language runtime code can be tested Nit:

[Qemu-devel] [RFC PATCH 1/3] block/io: introduce bdrv_co_preadv_part

2019-05-21 Thread Vladimir Sementsov-Ogievskiy
Introduce extended variant of bdrv_co_preadv with qiov_offset parameter, to finally get rid of (most of) local_qiov workarounds. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 6 +++ block/io.c| 87 ++- 2 files cha

[Qemu-devel] [PATCH v2 2/5] i386/cpu: Consolidate die-id validity in smp context

2019-05-21 Thread Like Xu
Following the legacy smp check rules, the die_id validity is added to the same contexts as leagcy smp variables such as hmp_hotpluggable_cpus(), machine_set_cpu_numa_node(), cpu_slot_to_string() and pc_cpu_pre_plug(). Signed-off-by: Like Xu --- hmp.c | 3 +++ hw/core/machine.c | 12

[Qemu-devel] [PATCH v2 1/5] target/i386: Add cpu die-level topology support for X86CPU

2019-05-21 Thread Like Xu
The die-level as the first PC-specific cpu topology is added to the leagcy cpu topology model which only covers sockets/cores/threads. In the new model with die-level support, the total number of logical processors (including offline) on board will be calculated as: #cpus = #sockets * #dies

[Qemu-devel] [PATCH v2 0/5] Introduce cpu die topology and enable CPUID.1F for i386

2019-05-21 Thread Like Xu
Multi-chip packaging technology allows integration of multi-cores in one die and multi-dies in one single package, for example Intel CLX-AP or AMD EPYC. This kind of integration can be enabled by high-performance, heterogeneous, multi-dies interconnect technology, providing a more cost-effective m

[Qemu-devel] [PATCH v2 3/5] vl.c: Add -smp, dies=* command line support and update -smp doc

2019-05-21 Thread Like Xu
For PC target, users could configure the number of dies per one package via command line with this patch, such as "-smp dies=2,cores=4". A new pc-specified pc_smp_parse() is introduced and to keep the interface consistent, refactoring legacy smp_parse() to __smp_parse() is necessary. The parsing

[Qemu-devel] [PATCH v2 5/5] target/i386: Add CPUID.1F generation support for multi-die PCMachine

2019-05-21 Thread Like Xu
The CPUID.1F as Intel V2 Extended Topology Enumeration Leaf would be exposed if guests want to emulate multiple software-visible die within each package. Per Intel's SDM, the 0x1f is a superset of 0xb, thus they can be generated by almost same code as 0xb except die_offset setting. If the number o

[Qemu-devel] [PATCH v2 4/5] i386/cpu: Update apicid parsing rules and topo-bit tests for dies

2019-05-21 Thread Like Xu
On Intel MCP (Multi-chip packaging) platforms, the apicid of logical cpu would imply die level info of cpu topology thus x86_apicid_from_cpu_idx() should be refactored with virtual nr_dies, so does apicid_*_offset(). To maintain semantic consistency, the pkg_offset which helps to generate CPUIDs s

Re: [Qemu-devel] [Qemu-block] [PATCH v3] block/rbd: increase dynamically the image size

2019-05-21 Thread Stefano Garzarella
Kindly ping. Thanks, Stefano On Thu, May 09, 2019 at 04:59:27PM +0200, Stefano Garzarella wrote: > RBD APIs don't allow us to write more than the size set with > rbd_create() or rbd_resize(). > In order to support growing images (eg. qcow2), we resize the > image before write operations that exce

Re: [Qemu-devel] Introducing GSoC project: API Documentation Generation

2019-05-21 Thread Daniel P . Berrangé
On Mon, May 20, 2019 at 03:41:08PM -0300, Eduardo Habkost wrote: > Please welcome GSoC student Gabriel Barreto. Gabriel is going to > work on QEMU API Documentation Generation[1]. > > Gabriel's first task is to evaluate our options for extract doc > comments from C source code and integrate them

Re: [Qemu-devel] [PATCH v4 04/11] block: Inline bdrv_co_block_status_from_*()

2019-05-21 Thread Vladimir Sementsov-Ogievskiy
10.04.2019 23:20, Max Reitz wrote: > With bdrv_filtered_rw_bs(), we can easily handle this default filter > behavior in bdrv_co_block_status(). > > blkdebug wants to have an additional assertion, so it keeps its own > implementation, except bdrv_co_block_status_from_file() needs to be > inlined th

Re: [Qemu-devel] [RISU v2 07/11] test_i386: change syntax from nasm to gas

2019-05-21 Thread Alex Bennée
Richard Henderson writes: > On Mon, May 20, 2019, 08:17 Alex Bennée wrote: > >> >> Jan Bobek writes: >> >> > This allows us to drop dependency on NASM and build the test image >> > with GCC only. Adds support for x86_64, too. >> >> ./risu --master -t run.out test_i386.bin >> >> and then: >>

[Qemu-devel] [PULL v2 46/54] linux headers: update against Linux 5.2-rc1

2019-05-21 Thread Cornelia Huck
commit a188339ca5a396acc588e5851ed7e19f66b0ebd9 Signed-off-by: Cornelia Huck --- .../infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h | 15 +- include/standard-headers/drm/drm_fourcc.h | 114 +++- include/standard-headers/linux/ethtool.h | 48 +++-- .../linux/input-event-codes.h

[Qemu-devel] [PULL v2 00/54] s390x update

2019-05-21 Thread Cornelia Huck
ommit d8276573da58e8ce78dab8c46dd660efd664bcb7: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190510' into staging (2019-05-16 13:15:08 +0100) are available in the Git repository at: https://github.com/cohuck/qemu tags/s390x-20190521-2 for you to fetch changes up to 4d727d1aa0e5cbf9f5f00968698dfa34c7b

Re: [Qemu-devel] [Qemu-arm] [PATCH] target/arm: Fix broken VQADD and VQSUB causing abort

2019-05-21 Thread Torbjorn SVENSSON
Hi Peter, Thanks for the fast response! Great to hear that a patch for the issue is on its way into master. Kind regards, Torbjörn -Original Message- From: Peter Maydell Sent: den 17 maj 2019 18:24 To: Torbjorn SVENSSON Cc: qemu-...@nongnu.org; Samuel HULTGREN ; qemu-devel@nongnu.or

Re: [Qemu-devel] [PATCH v2 1/2] hw: report invalid disable-legacy|modern usage for virtio-1-only devs

2019-05-21 Thread Daniel P . Berrangé
On Mon, May 20, 2019 at 05:59:59PM -0300, Eduardo Habkost wrote: > On Mon, May 20, 2019 at 10:56:11AM +0100, Daniel P. Berrangé wrote: > > On Fri, May 17, 2019 at 04:01:29PM -0300, Eduardo Habkost wrote: > > > Hi, > > > > > > Sorry for taking so long to look at this more closely: > > > > > > On F

Re: [Qemu-devel] [PATCH 4/4] BootLinuxSshTest: Test some userspace commands on Malta

2019-05-21 Thread Aleksandar Markovic
On May 21, 2019 10:18 AM, "Aleksandar Markovic" wrote: > > > On May 21, 2019 1:19 AM, "Philippe Mathieu-Daudé" wrote: > > > > This tests boot a full VM and check the serial console until > > the SSH daemon is running, then start a SSH session and run > > some commands. > > If there is no objecti

[Qemu-devel] [PATCH] authz: optimize linking of objects for authorization services

2019-05-21 Thread Daniel P . Berrangé
The core authorization API is a dependancy of the crypto code for the TLS servers. The TLS server code is pulled into anything which links to the crypto objects, which is every QEMU tool. This in turns means that every tool ended up linking to the authz code, which in turn pulls in the PAM library

Re: [Qemu-devel] [PATCH 1/4] migration: allow unplug during migration for failover devices

2019-05-21 Thread Dr. David Alan Gilbert
* Jens Freimann (jfreim...@redhat.com) wrote: > In "b06424de62 migration: Disable hotplug/unplug during migration" we > added a check to disable unplug for all devices until we have figured > out what works. For failover primary devices qdev_unplug() is called > from the migration handler, i.e. dur

Re: [Qemu-devel] [PATCH v5 0/3] Fix overflow bug in qcow2 discard

2019-05-21 Thread Vladimir Sementsov-Ogievskiy
ping 23.04.2019 15:57, Vladimir Sementsov-Ogievskiy wrote: > v5: by Kevin's comments > 02: add check for invalid @bytes parameter, drop r-b > 03: move from qemu-img info to qemu-img map -f raw, drop r-b and t-b > > Vladimir Sementsov-Ogievskiy (3): >block/qcow2-refcount: add trace-point to qc

Re: [Qemu-devel] Introducing GSoC project: API Documentation Generation

2019-05-21 Thread Peter Maydell
On Mon, 20 May 2019 at 19:41, Eduardo Habkost wrote: > > Please welcome GSoC student Gabriel Barreto. Gabriel is going to > work on QEMU API Documentation Generation[1]. > > Gabriel's first task is to evaluate our options for extract doc > comments from C source code and integrate them into Sphin

Re: [Qemu-devel] Introducing GSoC project: API Documentation Generation

2019-05-21 Thread Peter Maydell
On Tue, 21 May 2019 at 09:54, Daniel P. Berrangé wrote: > Hawkmoth seems pretty attractive in its output format, but doesn't appear > to be part of either Debian or Fedora distros, so we would have to bundle > it in QEMU I expect. My big concern there is that there have only been > 2 contributors

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-21 Thread Dr. David Alan Gilbert
* Jens Freimann (jfreim...@redhat.com) wrote: > This patch adds support to handle failover device pairs of a virtio-net > device and a vfio-pci device, where the virtio-net acts as the standby > device and the vfio-pci device as the primary. > > The general idea is that we have a pair of devices,

Re: [Qemu-devel] [PATCH 1/4] migration: allow unplug during migration for failover devices

2019-05-21 Thread Daniel P . Berrangé
On Tue, May 21, 2019 at 10:33:36AM +0100, Dr. David Alan Gilbert wrote: > * Jens Freimann (jfreim...@redhat.com) wrote: > > In "b06424de62 migration: Disable hotplug/unplug during migration" we > > added a check to disable unplug for all devices until we have figured > > out what works. For failove

Re: [Qemu-devel] [PATCH] blockdev: loosen restrictions on drive-backup source node

2019-05-21 Thread Vladimir Sementsov-Ogievskiy
21.05.2019 1:38, John Snow wrote: > > > On 5/10/19 5:11 PM, John Snow wrote: >> We mandate that the source node must be a root node; but there's no reason >> I am aware of that it needs to be restricted to such. In some cases, we need >> to make sure that there's a medium present, but in the gene

[Qemu-devel] [PATCH v2] authz: optimize linking of objects for authorization services

2019-05-21 Thread Daniel P . Berrangé
The core authorization API is a dependancy of the crypto code for the TLS servers. The TLS server code is pulled into anything which links to the crypto objects, which is every QEMU tool. This in turns means that every tool ended up linking to the authz code, which in turn pulls in the PAM library

[Qemu-devel] [PATCH v10 04/20] gdbstub: Implement continue (c pkt) with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index b4c4bd4b08..698d6f558a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1517,6 +1517,16 @@ static void handle_thread_alive(GdbCmdContext *gdb

[Qemu-devel] [PATCH v10 00/20] gdbstub: Refactor command packets handler

2019-05-21 Thread Jon Doron
This patch series refactors the old gdbstub command packets handler with a new infrastructure which should ease extending and adding new and missing gdb command packets. version 10 changes: - Remove kvm added API as this is not really required and can be accomplished by defining a coprocessor ca

[Qemu-devel] [PATCH v10 02/20] gdbstub: Implement deatch (D pkt) with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 93 +++ 1 file changed, 53 insertions(+), 40 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index e6d895177b..307366b250 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1413,11 +1413,6 @@ static inline int s

[Qemu-devel] [PATCH v10 01/20] gdbstub: Add infrastructure to parse cmd packets

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 195 ++ 1 file changed, 195 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d54abd17cc..e6d895177b 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1268,6 +1268,201 @@ out: return res; } +typede

[Qemu-devel] [PATCH v10 11/20] gdbstub: Implement read memory (m pkt) with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 48 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c798d93e22..c957b0d8a7 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1713,6 +1713,30 @@ static void handle_write_m

[Qemu-devel] [PATCH v10 06/20] gdbstub: Implement set_thread (H pkt) with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 83 +++ 1 file changed, 53 insertions(+), 30 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index f74a30da03..129a47230f 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1546,6 +1546,51 @@ static void handle_

[Qemu-devel] [PATCH v10 03/20] gdbstub: Implement thread_alive (T pkt) with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 43 --- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 307366b250..b4c4bd4b08 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1493,6 +1493,30 @@ static void handle_detach(GdbCm

[Qemu-devel] [PATCH v10 05/20] gdbstub: Implement continue with signal (C pkt) with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 698d6f558a..f74a30da03 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1527,6 +1527,25 @@ static void handle_continue(GdbCmdContext

[Qemu-devel] [PATCH v10 14/20] gdbstub: Implement file io (F pkt) with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 48 ++-- 1 file changed, 26 insertions(+), 22 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 781f5882ac..b35acc679c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1775,6 +1775,25 @@ static void handle_read_al

[Qemu-devel] [PATCH v10 16/20] gdbstub: Implement v commands with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 170 +++--- 1 file changed, 110 insertions(+), 60 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index a8b81121c5..3773b23581 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1804,6 +1804,106 @@ static void handl

[Qemu-devel] [PATCH v10 07/20] gdbstub: Implement breakpoint commands (Z/z pkt) with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 84 +++ 1 file changed, 66 insertions(+), 18 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 129a47230f..c59a6765cd 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -950,7 +950,7 @@ static inline int xlat

[Qemu-devel] [PATCH v10 13/20] gdbstub: Implement read all registers (g pkt) with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 1afad31b49..781f5882ac 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1760,6 +1760,21 @@ static void handle_write_all_regs(GdbCmdCont

[Qemu-devel] [PATCH v10 08/20] gdbstub: Implement set register (P pkt) with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c59a6765cd..1c210d671a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1637,6 +1637,27 @@ static void handle_remove_bp(GdbCmdC

[Qemu-devel] [PATCH v10 18/20] gdbstub: Implement target halted (? pkt) with new infra

2019-05-21 Thread Jon Doron
Note: The user-mode thread-id has been correctly reported since bd88c780e6 Signed-off-by: Jon Doron --- gdbstub.c | 35 +-- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 57a05fd6a4..097b7d1231 100644 --- a/gdbstub.c ++

Re: [Qemu-devel] [PATCH 0/4] add failover feature for assigned network devices

2019-05-21 Thread Michael S. Tsirkin
On Fri, May 17, 2019 at 02:58:16PM +0200, Jens Freimann wrote: > This is another attempt at implementing the host side of the > net_failover concept > (https://www.kernel.org/doc/html/latest/networking/net_failover.html) > > Changes since last RFC: > - work around circular dependency of commandlin

[Qemu-devel] [PATCH v10 19/20] gdbstub: Clear unused variables in gdb_handle_packet

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 097b7d1231..9dd934a079 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2270,17 +2270,11 @@ static void handle_target_halt(GdbCmdContext *gdb_ctx, void *us

[Qemu-devel] [PATCH v10 09/20] gdbstub: Implement get register (p pkt) with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 50 ++ 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 1c210d671a..3284b3e01d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1658,6 +1658,36 @@ static void handle_set_r

[Qemu-devel] [PATCH v10 20/20] gdbstub: Implement qemu physical memory mode

2019-05-21 Thread Jon Doron
Add a new query/set which changes the memory GDB sees to physical memory only. gdb> maint packet qqemu.PhyMemMode will reply the current phy_mem_mode state (1 for enabled, 0 for disabled) gdb> maint packet Qqemu.PhyMemMode:1 Will make GDB read/write only to physical memory, set to 0 to disable Si

[Qemu-devel] [PATCH v10 10/20] gdbstub: Implement write memory (M pkt) with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 51 +-- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3284b3e01d..c798d93e22 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1688,6 +1688,31 @@ static void handle_get_

[Qemu-devel] [PATCH v10 12/20] gdbstub: Implement write all registers (G pkt) with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c957b0d8a7..1afad31b49 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1737,6 +1737,29 @@ static void handle_read_mem(GdbCm

[Qemu-devel] [PATCH v10 15/20] gdbstub: Implement step (s pkt) with new infra

2019-05-21 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index b35acc679c..a8b81121c5 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1794,6 +1794,16 @@ static void handle_file_io(GdbCmdContext *gdb_ctx,

[Qemu-devel] [PATCH v10 17/20] gdbstub: Implement generic set/query (Q/q pkt) with new infra

2019-05-21 Thread Jon Doron
The generic set/query packets contains implementation for varioius sub-commands which are required for GDB and also additional commands which are QEMU specific. To see which QEMU specific commands are available use the command gdb> maintenance packet qqemu.Supported Currently the only implemented

[Qemu-devel] [RFC] scsi: restart dma after vm change state handlers

2019-05-21 Thread Stefan Hajnoczi
Various components register vm change state handlers to restart device emulation when the guest is unpaused. These handlers run in an arbitrary order since there is no way to specific explicit dependencies or priorities. Each SCSIDevice has a vm change state handler to restart failed I/O requests

[Qemu-devel] [PATCHv3 1/5] RISC-V: Only Check PMP if MMU translation succeeds

2019-05-21 Thread Hesham Almatary
The current implementation unnecessarily checks for PMP even if MMU translation failed. This may trigger a wrong PMP access exception instead of a page exception. For example, the very first instruction fetched after the first satp write in S-Mode will trigger a PMP access fault instead of an inst

[Qemu-devel] [PATCHv3 3/5] RISC-V: Check PMP during Page Table Walks

2019-05-21 Thread Hesham Almatary
The PMP should be checked when doing a page table walk, and report access fault exception if the to-be-read PTE failed the PMP check. Suggested-by: Jonathan Behrens Signed-off-by: Hesham Almatary --- target/riscv/cpu.h| 1 + target/riscv/cpu_helper.c | 10 +- 2 files changed, 1

[Qemu-devel] [PATCHv3 5/5] RISC-V: Fix a PMP check with the correct access size

2019-05-21 Thread Hesham Almatary
The PMP check should be of the memory access size rather than TARGET_PAGE_SIZE. Signed-off-by: Hesham Almatary --- target/riscv/cpu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index d0b0f9cf88..ce1f47e4e3 1006

[Qemu-devel] [PATCHv3 2/5] RISC-V: Raise access fault exceptions on PMP violations

2019-05-21 Thread Hesham Almatary
Section 3.6 in RISC-V v1.10 privilege specification states that PMP violations report "access exceptions." The current PMP implementation has a bug which wrongly reports "page exceptions" on PMP violations. This patch fixes this bug by reporting the correct PMP access exceptions trap values. Revi

[Qemu-devel] [PATCHv3 4/5] RISC-V: Fix a PMP bug where it succeeds even if PMP entry is off

2019-05-21 Thread Hesham Almatary
The current implementation returns 1 (PMP check success) if the address is in range even if the PMP entry is off. This is a bug. For example, if there is a PMP check in S-Mode which is in range, but its PMP entry is off, this will succeed, which it should not. The patch fixes this bug by only che

[Qemu-devel] [PULL 01/13] tests/libqtest: Remove unused global_qtest-related wrapper functions

2019-05-21 Thread Thomas Huth
A bunch of the wrapper functions that use global_qtest are not used anymore. Remove them to avoid that they are used in new code again. Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-Id: <20190510052239.21947-1-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/libqtest.c |

[Qemu-devel] [PULL 00/13] qtests and some iotest patches

2019-05-21 Thread Thomas Huth
Hi Peter, the following changes since commit 2259637b95bef3116cc262459271de08e038cc66: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-05-20 17:22:05 +0100) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pull-request-2019-05

[Qemu-devel] [PULL 04/13] tests/q35-test: Make test independent of global_qtest

2019-05-21 Thread Thomas Huth
Use a local QTestState variable, so that we can finally get rid of the undesired global_qtest variable in this file, too. Message-Id: <20190515174328.16361-3-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/q35-test.c | 39 ++- 1 file changed, 18 inserti

[Qemu-devel] [PULL 06/13] tests/qom-test: Use qtest_init() instead of qtest_start()

2019-05-21 Thread Thomas Huth
qtest_start() + qtest_end() should be avoided, since they use the global_qtest variable that we want to get rid of in the long run. Use qtest_init() and qtest_quit() instead. Message-Id: <20190515174328.16361-5-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/qom-test.c | 28 +-

[Qemu-devel] [PULL 08/13] tests/hd-geo-test: Use qtest_init() instead of qtest_start()

2019-05-21 Thread Thomas Huth
qtest_start() + qtest_end() should be avoided, since they use the global_qtest variable that we want to get rid of in the long run. Use qtest_init() and qtest_quit() instead. Message-Id: <20190515174328.16361-7-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/hd-geo-test.c | 76 +++

[Qemu-devel] [PULL 03/13] tests/libqos: Get rid of global_qtest dependency in qvring_init()

2019-05-21 Thread Thomas Huth
Library functions should not depend on global_qtest functions like writew() and writeq(), so that they can also be used in tests that deal with multiple QTestStates at the same time (like migration tests). Message-Id: <20190515174328.16361-2-th...@redhat.com> Signed-off-by: Thomas Huth --- tests

[Qemu-devel] [PULL 02/13] tests/libqtest: Fix description of qtest_vinitf() and qtest_initf()

2019-05-21 Thread Thomas Huth
These functions are convenience wrappers of qtest_init() and not of qtest_start(). Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190513154759.24973-1-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/libqtest.h | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[Qemu-devel] [PULL 09/13] tests/qemu-iotests/005: Add a sanity check for large sparse file support

2019-05-21 Thread Thomas Huth
"check -raw 005" fails when running on certain filesystems - these do not support such large sparse files. Use the same check as in test 220 to skip the test in this case. Suggested-by: Eric Blake Message-Id: <20190502084506.8009-2-th...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Alex Benn

[Qemu-devel] [PULL 12/13] cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD

2019-05-21 Thread Thomas Huth
We are going to enable the qemu-iotests during "make check" again, and for running the iotests, we need bash and gnu-sed. Reviewed-by: Li-Wen Hsu Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Acked-by: Christian Borntraeger Message-Id: <20190502084506.8009-5-th...@redhat.com> Si

[Qemu-devel] [PULL 07/13] tests/device-introspect: Use qtest_init() instead of qtest_start()

2019-05-21 Thread Thomas Huth
qtest_start() + qtest_end() should be avoided, since they use the global_qtest variable that we want to get rid of in the long run. Use qtest_init() and qtest_quit() instead. Message-Id: <20190515174328.16361-6-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/device-introspect-test.c | 85

[Qemu-devel] [PULL 05/13] tests/numa-test: Use qtest_init() instead of qtest_start()

2019-05-21 Thread Thomas Huth
qtest_start() + qtest_end() should be avoided, since they use the global_qtest variable that we want to get rid of in the long run. Use qtest_init() and qtest_quit() instead. Message-Id: <20190515174328.16361-4-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/numa-test.c | 53 +

[Qemu-devel] [PULL 10/13] tests/qemu-iotests/check: Pick a default machine if necessary

2019-05-21 Thread Thomas Huth
qemu-system-arm, qemu-system-aarch64 and qemu-system-tricore do not have a default machine, so when running the qemu-iotests with such a binary, lots of tests are failing. Fix it by picking a default machine in the "check" script instead. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Dau

[Qemu-devel] [PULL 11/13] tests/qemu-iotests: Do not hard-code the path to bash

2019-05-21 Thread Thomas Huth
bash is installed in a different directory on non-Linux systems like FreeBSD. Do not hard-code /bin/bash here so that the tests can run there, too. Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Acked-by: Christian Borntraeger Message-Id: <20190502084506.8

[Qemu-devel] [PULL 13/13] tests/qemu-iotests: Remove the "_supported_os Linux" line from many tests

2019-05-21 Thread Thomas Huth
A lot of tests run fine on FreeBSD and macOS, too - the limitation to Linux here was likely just copied-and-pasted from other tests. Thus remove the "_supported_os Linux" line from tests that run successful in our CI pipelines on FreeBSD and macOS. Reviewed-by: Alex Bennée Tested-by: Alex Bennée

Re: [Qemu-devel] Introducing GSoC project: API Documentation Generation

2019-05-21 Thread Paolo Bonzini
On 21/05/19 10:53, Daniel P. Berrangé wrote: > Hawkmoth seems pretty attractive in its output format, but doesn't appear > to be part of either Debian or Fedora distros, so we would have to bundle > it in QEMU I expect. My big concern there is that there have only been > 2 contributors to Hawkmoth

Re: [Qemu-devel] Introducing GSoC project: API Documentation Generation

2019-05-21 Thread Daniel P . Berrangé
On Tue, May 21, 2019 at 10:43:04AM +0100, Peter Maydell wrote: > On Tue, 21 May 2019 at 09:54, Daniel P. Berrangé wrote: > > Hawkmoth seems pretty attractive in its output format, but doesn't appear > > to be part of either Debian or Fedora distros, so we would have to bundle > > it in QEMU I expe

Re: [Qemu-devel] [PULL 0/9] target/xtensa queue

2019-05-21 Thread Peter Maydell
On Mon, 20 May 2019 at 18:58, Max Filippov wrote: > > Hi Peter, > > please pull the following batch of updates to target/xtensa: > > The following changes since commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into st

Re: [Qemu-devel] Introducing GSoC project: API Documentation Generation

2019-05-21 Thread Paolo Bonzini
On 21/05/19 11:42, Peter Maydell wrote: > (The other interesting thing I'd wondered about with generation > of docs from code comments is whether we would get better > (ie more accurate, regularly updated) documentation of our > supported machine models if we generated those parts of the > docs fro

  1   2   3   4   >