* Wei Yang (richardw.y...@linux.intel.com) wrote:
> During each iteration, se->ops is checked before each loop. So it is not
> necessary to check it again and simplify the following check a little.
>
> Signed-off-by: Wei Yang
Queued
> ---
> migration/savevm.c | 14 ++
> 1 file chan
On 5/14/19 11:17 AM, Peter Maydell wrote:
> On Tue, 14 May 2019 at 07:46, Cédric Le Goater wrote:
>>
>> This documents the overall XIVE architecture and gives an overview of
>> the QEMU models. It also provides documentation on the 'info pic'
>> command.
>>
>> Signed-off-by: Cédric Le Goater
>> -
On Sat 13 Apr 2019 02:53:42 AM CEST, Max Reitz wrote:
>> Calling x-blockdev-reopen without 'backing' should only fail if
>>
>> a) the image has a backing file attached to it.
>> In this case it doesn't: we just detached it in the previous line.
>>
>> b) there's a default backing file writte
On 5/14/19 9:33 AM, Satheesh Rajendran wrote:
> On Tue, May 14, 2019 at 08:46:27AM +0200, Cédric Le Goater wrote:
>> This documents the overall XIVE architecture and gives an overview of
>> the QEMU models. It also provides documentation on the 'info pic'
>> command.
>>
>> Signed-off-by: Cédric Le
On Fri, 10 May 2019 16:38:51 +0200
Pierre Morel wrote:
> We use a S390PCIGroup structure to hold the information
> related to zPCI Function group.
>
> This allows us to be ready to support multiple groups and to retrieve
> the group information from the host.
What if there is no host to retriev
On 5/14/19 12:41 PM, Marc-André Lureau wrote:
> Fixes warnings:
> warning: cast to pointer from integer of different size
> [-Wint-to-pointer-cast]
>
> Signed-off-by: Marc-André Lureau
> ---
> contrib/libvhost-user/libvhost-user.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Hi Marc-André,
On 5/14/19 12:41 PM, Marc-André Lureau wrote:
> That should fix the following warning:
>
> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c: In function
> ‘vu_set_mem_table_exec_postcopy’:
> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:666:9: error:
> format ‘%llx’
Make the stat fields definition slightly more readable.
Also reorder total_time_ns stats read-write-flush as done elsewhere.
Cosmetic change only.
Signed-off-by: Anton Nefedov
Reviewed-by: Alberto Garcia
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
qapi/block-core.json | 26 +++---
Signed-off-by: Anton Nefedov
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
hw/ide/core.c | 12
1 file changed, 12 insertions(+)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 6afadf894f..3a7ac93777 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -441,6 +441,14 @@ static void id
it allows to report it in the error handler
Signed-off-by: Anton Nefedov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
---
hw/scsi/scsi-disk.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
inde
Signed-off-by: Anton Nefedov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Reviewed-by: Eric Blake
---
qapi/block-core.json | 29 +++--
include/block/accounting.h | 1 +
block/qapi.c | 6 ++
tests/qemu-iotests/227.out |
hi,
yet another take for this patch series; please kindly consider these for 4.1
Just a few cosmetic comments were received for v6 so this is mostly
a rebase+ping.
new in v7:
- general rebase
- since clauses -> 4.1
- patch 8: not completely trivial rebase: raw_account_discard moved t
A block driver can provide a callback to report driver-specific
statistics.
file-posix driver now reports discard statistics
Signed-off-by: Anton Nefedov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Acked-by: Markus Armbruster
---
qapi/block-core.json | 38 ++
This adds some protection from accounting uninitialized cookie.
That is, block_acct_failed/done without previous block_acct_start;
in that case, cookie probably holds values from previous operation.
(Note: it might also be uninitialized holding garbage value and there is
still "< BLOCK_MAX_IOTYPE
This will help to account the operation in the following commit.
The difference is that we don't call scsi_disk_req_check_error() before
the 1st discard iteration anymore. That function also checks if
the request is cancelled, however it shouldn't get canceled until it
yields in blk_aio() function
Peter Maydell writes:
> On Mon, 13 May 2019 at 14:21, Markus Armbruster wrote:
>> Perhaps I should do it just for this file while I touch it anyway. The
>> question to ask: should parse_acl_file() obey the locale for whitespace
>> recognition?
>
> I vote for "no".
>
> Q: do we document the form
Signed-off-by: Anton Nefedov
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
hw/scsi/scsi-disk.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 6eff496b54..5c77981d60 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/sc
This will help to identify how many of the user-issued discard operations
(accounted on a device level) have actually suceeded down on the host file
(even though the numbers will not be exactly the same if non-raw format
driver is used (e.g. qcow2 sending metadata discards)).
Note that these numbe
On Mon, 2019-05-13 at 14:36 +0200, Andrew Jones wrote:
> On Mon, May 13, 2019 at 11:32:46AM +0200, Andrea Bolognani wrote:
> > On Sun, 2019-05-12 at 10:36 +0200, Andrew Jones wrote:
> > [...]
> > >CPU type | accel | sve-max-vq | sve-vls-map
> > >---
>
On Tue, 14 May 2019 at 01:22, Richard Henderson
wrote:
>
> Most of these patches are in support of David's guest vector
> patches for target/s390x.
>
>
> r~
>
>
> The following changes since commit e24f44dbeab8e54c72bdaedbd35453fb2a6c38da:
>
> Merge remote-tracking branch
> 'remotes/huth-gitlab
On Fri, 10 May 2019 at 19:54, Richard Henderson
wrote:
>
> Changes in v2:
>
> * Fix --disable-tcg compilation for x86 and s390x.
> I adjusted every target/ that used any CONFIG_TCG in cpu.c.
> but then afterward I see that only x86 and s390x have had
> their Makefiles adjusted to mak
Hi
On Tue, May 14, 2019 at 2:10 PM Philippe Mathieu-Daudé
wrote:
>
> Hi Marc-André,
>
> On 5/14/19 12:41 PM, Marc-André Lureau wrote:
> > That should fix the following warning:
> >
> > /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c: In function
> > ‘vu_set_mem_table_exec_postcopy’:
> > /h
On Tue, May 14, 2019 at 02:29:51PM +0200, Andrea Bolognani wrote:
> On Mon, 2019-05-13 at 14:36 +0200, Andrew Jones wrote:
> > On Mon, May 13, 2019 at 11:32:46AM +0200, Andrea Bolognani wrote:
> > > On Sun, 2019-05-12 at 10:36 +0200, Andrew Jones wrote:
> > > [...]
> > > >CPU type | accel | sve
On 14.05.19 13:30, Alberto Garcia wrote:
> On Sat 13 Apr 2019 02:53:42 AM CEST, Max Reitz wrote:
>>> Calling x-blockdev-reopen without 'backing' should only fail if
>>>
>>> a) the image has a backing file attached to it.
>>> In this case it doesn't: we just detached it in the previous line.
>>
On Tue 14 May 2019 03:02:33 PM CEST, Max Reitz wrote:
>> Why would both be fine? backing_file refers to the backing file
>> currently attached, and auto_backing_file refers to the one written
>> on the image metadata, or am I wrong?
>
> After my series, backing_file refers to the image metadata.
I
monitor_fdset_dup_fd_find_remove() and monitor_fdset_dup_fd_find()
returns mon_fdset->id which is int64_t. Downcast from int64_t to int leads to
a bug with removing fd from fdset which id >= 2^32.
So, fix return types for these function.
Signed-off-by: Yury Kotov
---
include/monitor/monitor.h |
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
> * Wei Yang (richardw.y...@linux.intel.com) wrote:
> > MigrationState->xfer_limit is only set to 0 in migrate_init().
> >
> > Remove this unnecessary field.
> >
> > Signed-off-by: Wei Yang
>
> Nice; I think that field has been unneeded sinc
Andrew Jones writes:
> On Tue, May 14, 2019 at 06:54:03AM +0200, Markus Armbruster wrote:
>> Andrew Jones writes:
>>
>> > On Thu, Apr 18, 2019 at 07:48:09PM +0200, Markus Armbruster wrote:
>> >> Daniel P. Berrangé writes:
>> >>
>> >> > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wr
* Wei Yang (richardw.y...@linux.intel.com) wrote:
> subsection_found is true implies vmdesc is not NULL.
>
> This patch remove the additional check on vmdesc and rename
> subsection_found to vmdesc_has_subsections to make it more self-explain.
>
> Signed-off-by: Wei Yang
Queued.
> ---
> v2:
>
Laurent Vivier writes:
> On 14/05/2019 10:08, Kashyap Chamarthy wrote:
>> On Tue, May 14, 2019 at 09:56:00AM +0200, Laurent Vivier wrote:
>>> From: Kashyap Chamarthy
>>>
>>> When QEMU exposes a VirtIO-RNG device to the guest, that device needs a
>>> source of entropy, and that source needs to be
hi,
this used to be a large 10-patches series, but now thanks to Kevin's
BDRV_REQ_NO_FALLBACK series
(http://lists.nongnu.org/archive/html/qemu-devel/2019-03/msg06389.html)
the core block layer functionality is already in place: the existing flag
can be reused.
A few accompanying patches were als
If COW areas of the newly allocated clusters are zeroes on the backing
image, efficient bdrv_write_zeroes(flags=BDRV_REQ_NO_FALLBACK) can be
used on the whole cluster instead of writing explicit zero buffers later
in perform_cow().
iotest 060:
write to the discarded cluster does not trigger COW an
> > > + typedef struct VhostUserGpuMsg {
> > > + uint32_t request; /* VhostUserGpuRequest */
> > > + uint32_t flags;
> > > + uint32_t size; /* the following payload size */
> >
> > uint32_t padding;
> >
> > > + union {
> > > + VhostUserGpuCursorPos cursor_pos;
> > > +
COW (even empty/zero) areas require encryption too
Signed-off-by: Anton Nefedov
Reviewed-by: Eric Blake
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
---
used to be a part of 'qcow2: cluster space preallocation' series
http://lists.nongnu.org/archive/html/qemu-devel/2019-01/msg02769.html
There are a few places in which we turn a number of bytes into sectors
in order to compare the result against BDRV_REQUEST_MAX_SECTORS
instead of using BDRV_REQUEST_MAX_BYTES directly.
Signed-off-by: Alberto Garcia
---
block/io.c | 6 +++---
qemu-io-cmds.c | 7 +++
2 files changed, 6 ins
On Fri, Apr 05, 2019 at 03:41:17PM -0600, Kenneth Heitke wrote:
> Signed-off-by: Kenneth Heitke
> ---
> hw/block/nvme.c | 120 +-
> hw/block/nvme.h | 3 ++
> hw/block/trace-events | 2 +
> include/block/nvme.h | 2 +
> 4 files changed, 12
Yury Kotov writes:
> monitor_fdset_dup_fd_find_remove() and monitor_fdset_dup_fd_find()
> returns mon_fdset->id which is int64_t. Downcast from int64_t to int leads to
Grammar nits:
s/returns/return/
s/Downcast/Downcasting/
> a bug with removing fd from fdset which id >= 2^32.
s/which
* Wei Yang (richardw.y...@linux.intel.com) wrote:
> We can eliminate to pass 0.
>
> Signed-off-by: Wei Yang
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/ram.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 3
* Zhang Chen (chen.zh...@intel.com) wrote:
> From: Zhang Chen
>
> In this series we optimize codes and fix some tiny issues.
Queued
>
> Zhang Chen (3):
> migration/colo.c: Remove redundant input parameter
> migration/colo.h: Remove obsolete codes
> qemu-option.hx: Update missed parameter
On 5/14/19 8:15 AM, Yury Kotov wrote:
> monitor_fdset_dup_fd_find_remove() and monitor_fdset_dup_fd_find()
> returns mon_fdset->id which is int64_t. Downcast from int64_t to int leads to
> a bug with removing fd from fdset which id >= 2^32.
> So, fix return types for these function.
fd's cannot ex
* Cole Robinson (crobi...@redhat.com) wrote:
> The only caller that checks the error code is looking for != 0,
> so returning false is incorrect.
>
> Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
>
> Signed-off-by: Cole Robinson
Queued
> ---
> migration/savevm.c | 2 +-
>
* Wei Yang (richardw.y...@linux.intel.com) wrote:
> Since start of cpu_physical_memory_sync_dirty_bitmap is always 0, we can
> remove this parameter and simplify the calculation a bit.
>
> Signed-off-by: Wei Yang
So I think you're right it's currently unused; however, lets ask
Paolo: Do we need
* Wei Yang (richardw.y...@linux.intel.com) wrote:
> We can eliminate to pass 0.
>
> Signed-off-by: Wei Yang
I'm going to queue just 1/3for the current pull.
Dave
> ---
> migration/ram.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/migration/ram.c b/migrati
* Yi Wang (wang.y...@zte.com.cn) wrote:
> Since the ram bitmap and the unsent bitmap are split by RAMBlock
> in commit 6b6712e, it's better to update the comments about them.
>
> Signed-off-by: Yi Wang
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/ram.c | 4 +---
> 1 file changed, 1 i
* Yi Wang (wang.y...@zte.com.cn) wrote:
> Since the ram bitmap and the unsent bitmap are split by RAMBlock
> in commit 6b6712e, it's better to update the comments about them.
>
> Signed-off-by: Yi Wang
Queued
> ---
> migration/ram.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Laurent Vivier writes:
> On 10/05/2019 18:36, Markus Armbruster wrote:
>> Laurent Vivier writes:
>>
>>> Signed-off-by: Laurent Vivier
>>> ---
>>> backends/rng-builtin.c | 8 +++-
>>> hw/virtio/virtio-rng.c | 2 +-
>>> include/hw/virtio/virtio-rng.h | 4 ++--
>>> incl
On Tue, May 14, 2019 at 04:57:35PM +0300, Alberto Garcia wrote:
> There are a few places in which we turn a number of bytes into sectors
> in order to compare the result against BDRV_REQUEST_MAX_SECTORS
> instead of using BDRV_REQUEST_MAX_BYTES directly.
>
> Signed-off-by: Alberto Garcia
> ---
>
Laurent Vivier writes:
> From: Kashyap Chamarthy
>
> When QEMU exposes a VirtIO-RNG device to the guest, that device needs a
> source of entropy, and that source needs to be "non-blocking", like
> `/dev/urandom`. However, currently QEMU defaults to the problematic
> `/dev/random`, which on linu
* Wei Yang (richardw.y...@linux.intel.com) wrote:
> Current call flow of save_snapshot is:
>
> save_snapshot
> migration_is_blocked
> qemu_savevm_state
> migration_is_blocked
>
> Since qemu_savevm_state is only called in save_snapshot, this means
> migration_is_blocked has bee
On Tue, 14 May 2019 11:02:25 +0200
Andrew Jones wrote:
> On Tue, May 14, 2019 at 06:54:03AM +0200, Markus Armbruster wrote:
> > Andrew Jones writes:
> >
> > > On Thu, Apr 18, 2019 at 07:48:09PM +0200, Markus Armbruster wrote:
> > >> Daniel P. Berrangé writes:
> > >>
> > >> > On Thu, Apr 18, 2
Laurent Vivier writes:
> Add a new RNG backend using QEMU builtin getrandom function.
>
> It can be created and used with something like:
>
> ... -object rng-builtin,id=rng0 -device virtio-rng,rng=rng0 ...
>
> Reviewed-by: Richard Henderson
> Signed-off-by: Laurent Vivier
> ---
> backends/
14.05.2019, 17:05, "Eric Blake" :
> On 5/14/19 8:15 AM, Yury Kotov wrote:
>> monitor_fdset_dup_fd_find_remove() and monitor_fdset_dup_fd_find()
>> returns mon_fdset->id which is int64_t. Downcast from int64_t to int leads
>> to
>> a bug with removing fd from fdset which id >= 2^32.
>> So, fix
Hi Dan,
Proposing the patch series to be merged via nvdimm tree
as kindly agreed by you. We have ack/review on XFS, EXT4 &
VIRTIO patches.
Incorporated all the changes suggested in v8. This version
added a new patch 4 for dax for device mapper change and some
minor style changes in patch
This patch adds functionality to perform flush from guest
to host over VIRTIO. We are registering a callback based
on 'nd_region' type. virtio_pmem driver requires this special
flush function. For rest of the region types we are registering
existing flush function. Report error returned by host fsy
This patch adds virtio-pmem driver for KVM guest.
Guest reads the persistent memory range information from
Qemu over VIRTIO and registers it on nvdimm_bus. It also
creates a nd_region object with the persistent memory
range information so that existing 'nvdimm/pmem' driver
can reserve this into sy
This patch sets dax device 'DAXDEV_SYNC' flag if all the target
devices of device mapper support synchrononous DAX. If device
mapper consists of both synchronous and asynchronous dax devices,
we don't set 'DAXDEV_SYNC' flag.
Signed-off-by: Pankaj Gupta
---
drivers/md/dm-table.c | 14 +++
This patch introduces 'daxdev_mapping_supported' helper
which checks if 'MAP_SYNC' is supported with filesystem
mapping. It also checks if corresponding dax_device is
synchronous. Virtio pmem device is asynchronous and
does not not support VM_SYNC.
Suggested-by: Jan Kara
Signed-off-by: Pankaj Gup
This patch adds 'DAXDEV_SYNC' flag which is set
for nd_region doing synchronous flush. This later
is used to disable MAP_SYNC functionality for
ext4 & xfs filesystem for devices don't support
synchronous flush.
Signed-off-by: Pankaj Gupta
---
drivers/dax/bus.c| 2 +-
drivers/dax/sup
Dont support 'MAP_SYNC' with non-DAX files and DAX files
with asynchronous dax_device. Virtio pmem provides
asynchronous host page cache flush mechanism. We don't
support 'MAP_SYNC' with virtio pmem and ext4.
Signed-off-by: Pankaj Gupta
Reviewed-by: Jan Kara
---
fs/ext4/file.c | 10 ++
14.05.2019, 17:01, "Markus Armbruster" :
> Yury Kotov writes:
>
>> monitor_fdset_dup_fd_find_remove() and monitor_fdset_dup_fd_find()
>> returns mon_fdset->id which is int64_t. Downcast from int64_t to int leads
>> to
>
> Grammar nits:
>
> s/returns/return/
> s/Downcast/Downcasting/
>
Dont support 'MAP_SYNC' with non-DAX files and DAX files
with asynchronous dax_device. Virtio pmem provides
asynchronous host page cache flush mechanism. We don't
support 'MAP_SYNC' with virtio pmem and xfs.
Signed-off-by: Pankaj Gupta
Reviewed-by: Darrick J. Wong
---
fs/xfs/xfs_file.c | 9
On Tue, 14 May 2019 09:43:44 +0200
Erik Skultety wrote:
> On Tue, May 14, 2019 at 03:32:19AM -0400, Yan Zhao wrote:
> > On Tue, May 14, 2019 at 03:20:40PM +0800, Erik Skultety wrote:
> > > On Tue, May 14, 2019 at 02:12:35AM -0400, Yan Zhao wrote:
> > > > On Mon, May 13, 2019 at 09:28:04PM +08
Hi,
Unaligned images don’t work so well with O_DIRECT:
$ echo > foo
$ qemu-img map --image-opts driver=file,filename=foo,cache.direct=on
Offset Length Mapped to File
qemu-img: block/io.c:2093: bdrv_co_block_status: Assertion `*pnum &&
QEMU_IS_ALIGNED(*pnum, align) && align
On 5/14/19 7:54 AM, Pankaj Gupta wrote:
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 35897649c24f..94bad084ebab 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -42,6 +42,17 @@ config VIRTIO_PCI_LEGACY
>
> If unsure, say Y.
>
> +config
"make check-unit" fails for me:
TESTcheck-unit: tests/test-crypto-tlscredsx509
Unexpected error in object_new_with_propv() at
/work/armbru/qemu/qom/object.c:674:
invalid object type: tls-creds-x509
and
TESTcheck-unit: tests/test-io-channel-tls
Unexpected error in object_new_with_pro
* Wei Yang (richardw.y...@linux.intel.com) wrote:
> On Thu, Apr 25, 2019 at 05:55:15PM -0300, Daniel Henrique Barboza wrote:
> >
> >
> >On 4/23/19 9:46 PM, Wei Yang wrote:
> >> migration_is_blocked() is used in migrate_prepare() and
> >> save_snapshot(), this is more proper to use this instead of
>
Now, fdset_id is int64, but in some places we work with it as int.
It seems that there is no sense to use int64 for fdset_id, so it's
better to fix inconsistency by changing fdset_id type to int and by
fixing the reference of corresponding QMP commands: add-fd, remove-fd,
query-fdsets.
Signed-off-
The default backend is only used within virtio_rng_device_realize().
Replace VirtIORNGConf member default_backend by a local variable.
Adjust its type to reduce conversions.
While there, pass &error_abort instead of NULL when failure would be a
programming error.
Signed-off-by: Markus Armbruster
On Tue, May 14, 2019 at 05:15:31PM +0200, Markus Armbruster wrote:
> "make check-unit" fails for me:
>
> TESTcheck-unit: tests/test-crypto-tlscredsx509
> Unexpected error in object_new_with_propv() at
> /work/armbru/qemu/qom/object.c:674:
> invalid object type: tls-creds-x509
>
> and
>
>
Laurent Vivier writes:
> Signed-off-by: Laurent Vivier
> ---
> backends/rng-builtin.c | 8 +++-
> hw/virtio/virtio-rng.c | 2 +-
> include/hw/virtio/virtio-rng.h | 4 ++--
> include/sysemu/rng-builtin.h | 17 +
> qemu-options.hx| 5 ++---
> On 5/14/19 7:54 AM, Pankaj Gupta wrote:
> > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> > index 35897649c24f..94bad084ebab 100644
> > --- a/drivers/virtio/Kconfig
> > +++ b/drivers/virtio/Kconfig
> > @@ -42,6 +42,17 @@ config VIRTIO_PCI_LEGACY
> >
> > If unsure, say Y
On Sat, 11 May 2019 at 14:43, Aleksandar Markovic
wrote:
> This commit message is generally poor, as it explains relatively unimportant
> logging issue, while not explaining the core of the change.
I think the assumption with this sort of "refactor to change
all instances of an API" change is th
On 14/05/2019 17:24, Markus Armbruster wrote:
Laurent Vivier writes:
Signed-off-by: Laurent Vivier
---
backends/rng-builtin.c | 8 +++-
hw/virtio/virtio-rng.c | 2 +-
include/hw/virtio/virtio-rng.h | 4 ++--
include/sysemu/rng-builtin.h | 17 +
q
On Tue, May 14, 2019 at 05:54:03AM +0100, Markus Armbruster wrote:
> Andrew Jones writes:
>
> > On Thu, Apr 18, 2019 at 07:48:09PM +0200, Markus Armbruster wrote:
> >> Daniel P. Berrangé writes:
> >>
> >> > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote:
> >> >> Hi all,
> >> >>
>
On Wed, 8 May 2019 17:27:47 +0200
Boris Fiuczynski wrote:
> On 5/8/19 11:22 PM, Alex Williamson wrote:
> >>> I thought there was a request to make this more specific to migration
> >>> by renaming it to something like migration_version. Also, as an
> >>>
> >> so this attribute may not only
* Wei Yang (richardw.y...@linux.intel.com) wrote:
> In migration_thread() and qemu_savevm_state(), we savevm_state in
> following sequence:
>
> qemu_savevm_state_header(f);
> qemu_savevm_state_setup(f);
>
> Then it would be more proper to loadvm_state in the save sequence.
>
> Signed-off
On 5/14/19 10:06 AM, Max Reitz wrote:
> Hi,
>
> Unaligned images don’t work so well with O_DIRECT:
>
> $ echo > foo
> $ qemu-img map --image-opts driver=file,filename=foo,cache.direct=on
> Offset Length Mapped to File
> qemu-img: block/io.c:2093: bdrv_co_block_status: Asse
Aleksandar Markovic writes:
> On May 10, 2019 8:57 PM, "Richard Henderson"
> wrote:
>>
>
> Please change the title to 'target/mips: Switch to using
> mips_cpu_tlb_fill()', or something along that line.
It does seem a little redundant as "target/mips:" already marks it as a
mips specific chang
This provides two functions for handling console output that handle
the common backend behaviour for semihosting.
Signed-off-by: Alex Bennée
---
gdbstub.c| 5 +++
hw/semihosting/Makefile.objs | 1 +
hw/semihosting/console.c | 70 +
Clean-up our unimplemented bits with a proper message.
Signed-off-by: Alex Bennée
---
target/arm/arm-semi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/arm/arm-semi.c b/target/arm/arm-semi.c
index 253c66b172a..a3bbef18ef7 100644
--- a/target/arm/arm-semi.c
+++
There isn't much point building semihosting for platforms that don't
support it. Introduce a new symbol and enable it only for the softmmu
targets that need it.
Signed-off-by: Alex Bennée
---
default-configs/arm-softmmu.mak | 1 +
default-configs/lm32-softmmu.mak| 2 +
default-
This cleans up a number of the block comments to fit the proper style.
While we are at it we also reference the official specification and
document what the return register value can be.
Signed-off-by: Alex Bennée
---
target/arm/arm-semi.c | 40 +++-
1 file ch
It will be useful for a number of use-cases to be able to re-direct
output to a file like we do with serial output. This does the wiring
to allow us to treat then semihosting console like just another
character output device.
Signed-off-by: Alex Bennée
---
hw/semihosting/config.c | 26
Now we have a common semihosting console interface use that for our
string output. However ARM is currently unique in also supporting
semihosting for linux-user so we need to replicate the API in
linux-user. If other architectures gain this support we can move the
file later.
Signed-off-by: Alex B
In preparation for having some more common semihosting code let's
excise the current config magic from vl.c into its own file. We shall
later add more conditionals to the build configurations so we can
avoid building this if we don't need it.
Signed-off-by: Alex Bennée
---
gdbstub.c
Hi,
This collects together some fixes from last weeks RFC clean-up patch
as well as a generalised version of the chardev console tweak I made
last week for testing/next. As it happens it only really made sense
for ARM and MIPs logging semihost calls but there is certainly scope
for handling all
Rather than printing directly to stdout lets use our common
semihosting code. There is one minor difference in that the output
currently defaults to stderr instead of stdout however this can be
controlled by connecting semihosting to a chardev.
Signed-off-by: Alex Bennée
---
target/mips/mips-sem
The documentation says the write should return the number of bytes not
written on an error (0 means everything was written). Read provides a
buffer length and the return value should be the buffer length - bytes
actually read. Remove the incorrect FIXME's and return the correct
values.
Signed-off-
The is_uhi gates all semihosting calls and always returns false for
CONFIG_USER_ONLY builds. There is no reason to build and link
mips-semi for these builds so lets fix that.
Signed-off-by: Alex Bennée
---
target/mips/Makefile.objs | 3 ++-
target/mips/helper.h | 2 ++
target/mips/translate
* Yury Kotov (yury-ko...@yandex-team.ru) wrote:
> It fixes heap-use-after-free which was found by clang's ASAN.
Reviewed-by: Dr. David Alan Gilbert
and queued.
(cc'ing in Stefan since aio crashes often get to him).
> Control flow of this use-after-free:
> main_thread:
> * Got SIGTERM and c
Seeing as I touched it I should at least keep an eye on it.
Signed-off-by: Alex Bennée
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index a73a61a5465..e9050beb222 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2559,6 +2559,13 @@ F: docs/pvr
On 5/14/19 2:18 PM, Markus Armbruster wrote:
> Peter Maydell writes:
>
>> On Mon, 13 May 2019 at 14:21, Markus Armbruster wrote:
>>> Perhaps I should do it just for this file while I touch it anyway. The
>>> question to ask: should parse_acl_file() obey the locale for whitespace
>>> recognition
* Wei Yang (richardw.y...@linux.intel.com) wrote:
> Current call flow of save_snapshot is:
>
> save_snapshot
> migration_is_blocked
> qemu_savevm_state
> migration_is_blocked
>
> Since qemu_savevm_state is only called in save_snapshot, this means
> migration_is_blocked has bee
On May 14, 2019 5:26 PM, "Peter Maydell" wrote:
>
> On Sat, 11 May 2019 at 14:43, Aleksandar Markovic
> wrote:
> > This commit message is generally poor, as it explains relatively
unimportant logging issue, while not explaining the core of the change.
>
> I think the assumption with this sort of
On 5/14/19 5:48 PM, Alex Bennée wrote:
>
> Aleksandar Markovic writes:
>
>> On May 10, 2019 8:57 PM, "Richard Henderson"
>> wrote:
>>>
>>
>> Please change the title to 'target/mips: Switch to using
>> mips_cpu_tlb_fill()', or something along that line.
>
> It does seem a little redundant as "t
On Tue, 2019-05-14 at 14:53 +0200, Andrew Jones wrote:
> On Tue, May 14, 2019 at 02:29:51PM +0200, Andrea Bolognani wrote:
> > Since we expect management applications to use QMP to discover what
> > vector lengths are supported and then provide an explicit map, I
> > think it's fair to say that the
* Wei Yang (richardw.y...@linux.intel.com) wrote:
> Signed-off-by: Wei Yang
> ---
> migration/ram.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Dr. David Alan Gilbert
and queued.
> diff --git a/migration/ram.c b/migration/ram.c
> index 1def8122e9..720c2b73
On 5/14/19 8:23 AM, Daniel P. Berrangé wrote:
> On Tue, May 14, 2019 at 05:15:31PM +0200, Markus Armbruster wrote:
>> "make check-unit" fails for me:
>>
>> TESTcheck-unit: tests/test-crypto-tlscredsx509
>> Unexpected error in object_new_with_propv() at
>> /work/armbru/qemu/qom/object.c:674:
On 5/14/19 5:52 PM, Alex Bennée wrote:
> Clean-up our unimplemented bits with a proper message.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/arm/arm-semi.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/target/arm/arm-semi.c
On Mon, May 13, 2019 at 5:19 PM Richard Henderson
wrote:
>
> On 5/13/19 5:08 PM, Alistair Francis wrote:
> > We hit the second switch case as
> > NEON_3R_VQADD and NEON_3R_VQSUB don't return from the function in the
> > first switch case.
>
> That's the bug, not here in this second switch.
Ah ok,
101 - 200 of 337 matches
Mail list logo
