[Qemu-devel] [PULL 5/7] util: simplify unix_listen()

2019-05-13 Thread Gerd Hoffmann
From: Marc-André Lureau The only caller of unix_listen() left is qga/channel-posix.c. There is no need to deal with legacy coma-trailing options ",...". Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-id: 20190503130034.24916-6-marcandre.lur...@redhat.com Signed-off-b

[Qemu-devel] [PULL 4/7] Add vhost-user-input-pci

2019-05-13 Thread Gerd Hoffmann
From: Marc-André Lureau Add a new virtio-input device, which connects to a vhost-user backend. Instead of reading configuration directly from an input device / evdev (like virtio-input-host), it reads it over vhost-user protocol with {SET,GET}_CONFIG messages. The vhost-user-backend handles the

[Qemu-devel] [PULL 3/7] Add vhost-user-backend

2019-05-13 Thread Gerd Hoffmann
From: Marc-André Lureau Create a vhost-user-backend object that holds a connection to a vhost-user backend (or "slave" process) and can be referenced from virtio devices that support it. See later patches for input & gpu usage. Note: a previous iteration of this object made it user-creatable, an

[Qemu-devel] [PULL 6/7] virtio-input-host-pci: cleanup types

2019-05-13 Thread Gerd Hoffmann
virtio input is virtio-1.0 only, so we don't need the -transitional and -non-transitional variants. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20190510105137.17481-1-kra...@redhat.com --- hw/virtio/virtio-input-host-pci.c | 7 ++- 1 file changed, 2 insertions(+)

[Qemu-devel] [PULL 2/7] libvhost-user: add PROTOCOL_F_CONFIG if {set, get}_config

2019-05-13 Thread Gerd Hoffmann
From: Marc-André Lureau Add the config protocol feature bit if the set_config & get_config callbacks are implemented. Signed-off-by: Marc-André Lureau Message-id: 20190503130034.24916-3-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann --- contrib/libvhost-user/libvhost-user.c | 4

[Qemu-devel] [PULL 1/7] libvhost-user: fix -Waddress-of-packed-member

2019-05-13 Thread Gerd Hoffmann
From: Marc-André Lureau /home/elmarco/src/qemu/contrib/libvhost-user/libvhost-user.c: In function ‘vu_set_mem_table_exec_postcopy’: /home/elmarco/src/qemu/contrib/libvhost-user/libvhost-user.c:546:31: warning: taking address of packed member of ‘struct VhostUserMsg’ may result in an unaligned

[Qemu-devel] [PULL 0/7] Input 20190513 v2 patches

2019-05-13 Thread Gerd Hoffmann
The following changes since commit 812b835fb4d23dd108b2f9802158472d50b73579: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-05-07' into staging (2019-05-09 16:31:12 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/input-201905

[Qemu-devel] [PULL 7/7] virtio-input: fix Kconfig dependency and Makefile

2019-05-13 Thread Gerd Hoffmann
Make VIRTIO_INPUT_HOST depend on VIRTIO_INPUT. Use CONFIG_VIRTIO_INPUT_HOST in Makefile. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20190510105137.17481-2-kra...@redhat.com --- hw/input/Kconfig | 2 +- hw/input/Makefile.objs | 4 +--- 2 files changed, 2 insert

Re: [Qemu-devel] [PULL 0/8] Input 20190510 patches

2019-05-13 Thread Gerd Hoffmann
> Hi; there are some compile failures here I'm afraid: > > On ppc64: > > /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c: In function > ‘vu_set_mem_table_exec_postcopy’: > /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:666:9: error: > format ‘%llx’ expects argument of type ‘long lo

Re: [Qemu-devel] [qemu-s390x] [PULL SUBSYSTEM s390x 2/3] s390-bios: Skip bootmap signature entries

2019-05-13 Thread Cornelia Huck
On Sat, 11 May 2019 08:15:21 +0200 Thomas Huth wrote: > On 10/05/2019 15.59, Christian Borntraeger wrote: > > Shall we cc stable this? > > I think I'd rather not do it unless someone really speaks up that they > urgently need it. If we could use the binary from the master branch, I'd > say go

Re: [Qemu-devel] [qemu-s390x] [PULL SUBSYSTEM s390x 2/3] s390-bios: Skip bootmap signature entries

2019-05-13 Thread Christian Borntraeger
On 13.05.19 09:42, Cornelia Huck wrote: > On Sat, 11 May 2019 08:15:21 +0200 > Thomas Huth wrote: > >> On 10/05/2019 15.59, Christian Borntraeger wrote: >>> Shall we cc stable this? >> >> I think I'd rather not do it unless someone really speaks up that they >> urgently need it. If we could

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread David Hildenbrand
On 02.05.19 00:31, Collin Walling wrote: > DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must > be intercepted by SIE and handled via KVM. Let's introduce some > functions to communicate between QEMU and KVM via ioctls. These > will be used to get/set the diag318 related informati

Re: [Qemu-devel] [qemu-s390x] [PULL SUBSYSTEM s390x 2/3] s390-bios: Skip bootmap signature entries

2019-05-13 Thread Cornelia Huck
On Mon, 13 May 2019 09:44:37 +0200 Christian Borntraeger wrote: > On 13.05.19 09:42, Cornelia Huck wrote: > > On Sat, 11 May 2019 08:15:21 +0200 > > Thomas Huth wrote: > > > >> On 10/05/2019 15.59, Christian Borntraeger wrote: > >>> Shall we cc stable this? > >> > >> I think I'd rather

Re: [Qemu-devel] [Qemu-block] [PATCH] nbd/server: Nicer spelling of max BLOCK_STATUS reply length

2019-05-13 Thread Stefano Garzarella
On Fri, May 10, 2019 at 10:17:35AM -0500, Eric Blake wrote: > Commit 3d068aff (3.0) introduced NBD_MAX_BITMAP_EXTENTS as a limit on > how large we would allow a reply to NBD_CMD_BLOCK_STATUS to grow when > it is visiting a qemu:dirty-bitmap: context. Later, commit fb7afc79 > (3.1) reused the const

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread David Hildenbrand
On 13.05.19 09:46, David Hildenbrand wrote: > On 02.05.19 00:31, Collin Walling wrote: >> DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must >> be intercepted by SIE and handled via KVM. Let's introduce some >> functions to communicate between QEMU and KVM via ioctls. These >> wil

Re: [Qemu-devel] [PATCH v4 5/5] pci: Fold pci_get_bus_devfn() into its sole caller

2019-05-13 Thread Greg Kurz
On Mon, 13 May 2019 16:19:39 +1000 David Gibson wrote: > The only remaining caller of pci_get_bus_devfn() is pci_nic_init_nofail(), > itself an old compatibility function. Fold the two together to avoid > re-using the stale interface. > > While we're there replace the explicit fprintf()s with e

[Qemu-devel] [PULL 5/9] target/xtensa: Clean up core-isa.h header guards

2019-05-13 Thread Markus Armbruster
scripts/clean-header-guards.pl warns these headers use reserved identifier _XTENSA_CORE_CONFIGURATION_H as header guard symbol. It additionally warns the guard doesn't match the file name. Reuse of the same guard symbol in multiple headers is okay as long as they cannot be included together. Sin

[Qemu-devel] [PULL 4/9] linux-user/nios2 linux-user/riscv: Clean up header guards

2019-05-13 Thread Markus Armbruster
Reuse of the same guard symbol in multiple headers is okay as long as they cannot be included together. scripts/clean-header-guards.pl can't tell, so it warns. Since we can avoid guard symbol reuse easily, do so: use guard symbol ${target^^}_${fname^^} for linux-user/$target/$fname, just like we

[Qemu-devel] [PULL 1/9] Clean up includes

2019-05-13 Thread Markus Armbruster
Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes, with the changes to the following files manually reverted: contrib/libvhost-user/libvhost-user-glib.h contrib/libvhost-user/libv

[Qemu-devel] [PULL 8/9] Normalize header guard symbol definition.

2019-05-13 Thread Markus Armbruster
We commonly define the header guard symbol without an explicit value. Normalize the exceptions. Done with scripts/clean-header-guards.pl. Signed-off-by: Markus Armbruster Message-Id: <20190315145123.28030-8-arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé --- hw/timer/m48t59-internal.h

[Qemu-devel] [PULL 0/9] Miscellaneous patches for 2019-05-13

2019-05-13 Thread Markus Armbruster
This is actually a fixed rebase of "[PULL for-4.1 0/9] Miscellaneous patches for 2019-04-18", but that subject has since become misleading, so I changed it. v2: * Back out the change to tests/fp/platform.h that breaks big endian * Rebase The following changes since commit efb4f3b62c69383a7308d7b7

[Qemu-devel] [PULL 2/9] Use #include "..." for our own headers, <...> for others

2019-05-13 Thread Markus Armbruster
Also delete a few redundant #include. Signed-off-by: Markus Armbruster Message-Id: <20190315145123.28030-2-arm...@redhat.com> --- contrib/rdmacm-mux/main.c | 18 +- contrib/rdmacm-mux/rdmacm-mux.h | 6 +++--- hw/rdma/rdma_utils.h| 1 - target/i386/whp-dispatch

[Qemu-devel] [PULL 6/9] Clean up header guards that don't match their file name

2019-05-13 Thread Markus Armbruster
Header guard symbols should match their file name to make guard collisions less likely. Cleaned up with scripts/clean-header-guards.pl, followed by some renaming of new guard symbols picked by the script to better ones. Signed-off-by: Markus Armbruster Message-Id: <20190315145123.28030-6-arm...@

[Qemu-devel] [PULL 3/9] authz: Normalize #include "authz/trace.h" to "trace.h"

2019-05-13 Thread Markus Armbruster
Include the generated trace.h the same way as we do everywhere else. Signed-off-by: Markus Armbruster Message-Id: <20190315145123.28030-3-arm...@redhat.com> Acked-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé --- authz/base.c | 2 +- authz/list.c | 2 +- authz/listfile.c |

[Qemu-devel] [Bug 1828608] Re: Chardev websocket might not support pasting more than a few chars

2019-05-13 Thread Anisse Astier
I wrote a websocket client to help reproduce the bug without a browser: https://github.com/anisse/websocktty You can install it to your $GOPATH/bin (defaults to ~/go/bin) with "go get github.com/anisse/websocktty" I can reproduce the bug with it by simply pasting a long-enough (5 to 20 characters

[Qemu-devel] [PULL 9/9] Clean up decorations and whitespace around header guards

2019-05-13 Thread Markus Armbruster
Cleaned up with scripts/clean-header-guards.pl. Signed-off-by: Markus Armbruster Message-Id: <20190315145123.28030-9-arm...@redhat.com> --- hw/ide/ahci_internal.h | 2 +- include/block/aio-wait.h| 2 +- include/exec/translator.h | 2 +- include/hw/arm/nrf51_soc

[Qemu-devel] [PULL 7/9] Clean up ill-advised or unusual header guards

2019-05-13 Thread Markus Armbruster
Leading underscores are ill-advised because such identifiers are reserved. Trailing underscores are merely ugly. Strip both. Our header guards commonly end in _H. Normalize the exceptions. Done with scripts/clean-header-guards.pl. Signed-off-by: Markus Armbruster Message-Id: <20190315145123.

[Qemu-devel] [PULL v3 00/29] Kconfig for Arm

2019-05-13 Thread Thomas Huth
Hi Peter, the following changes since commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-05-10 14:49:36 +0100) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pull-reques

[Qemu-devel] [PULL v3 02/29] Makefile: Fix inclusion of the config-devices.mak.d Kconfig dependencies

2019-05-13 Thread Thomas Huth
The Makefile tries to include device Kconfig dependencies via -include $(SUBDIR_DEVICES_MAK_DEP) and thus expects files that match *-softmmu/config-devices.mak.d ... however, the minikconf script currently generates files a la "*-softmmu-config.devices.mak.d" instead, so the dependency files sim

[Qemu-devel] [PULL v3 03/29] hw/ide/ahci: Add a Kconfig switch for the AHCI-ICH9 device

2019-05-13 Thread Thomas Huth
Some of our machines (like the ARM cubieboard) use CONFIG_AHCI for an AHCI sysbus device, but do not use CONFIG_PCI since they do not feature a PCI bus. With CONFIG_AHCI but without CONFIG_PCI, currently linking fails: ../hw/ide/ich.o: In function `pci_ich9_ahci_realize': hw/ide/ich.c:124:

Re: [Qemu-devel] [PATCH 6/6] virtfs: Fix documentation of -fsdev and -virtfs

2019-05-13 Thread Thomas Huth
On 09/05/2019 15.18, Greg Kurz wrote: > On Wed, 8 May 2019 17:54:42 +0200 > Thomas Huth wrote: > >> On 07/05/2019 10.45, Greg Kurz wrote: >>> This fixes several things: >>> - add "id" description to -virtfs documentation >>> - split the description into several lines in both usage and documentati

[Qemu-devel] [PATCH v4 00/14] spapr: add KVM support to the XIVE interrupt mode

2019-05-13 Thread Cédric Le Goater
Hello, This is the v4 of the QEMU/KVM patchset. The first patches introduce the XIVE KVM device, state synchronization and migration support under KVM. The second part of the patchset modifies the XICS and XIVE interrupt models to add KVM support to the 'dual' IRQ backend. GitHub trees available

[Qemu-devel] [PATCH v4 01/14] linux-headers: update linux headers to kvm-ppc-next-5.2-1

2019-05-13 Thread Cédric Le Goater
This updates the kvm headers to commit 0caecf5b0019 (kvm-ppc-next-5.2-1) in branch kvm-ppc-next from : https://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git/ These changes provide the interface with the KVM device implementing the XIVE native exploitation interrupt mode. Signed-of

[Qemu-devel] [PATCH v4 03/14] spapr/xive: add hcall support when under KVM

2019-05-13 Thread Cédric Le Goater
XIVE hcalls are all redirected to QEMU as none are on a fast path. When necessary, QEMU invokes KVM through specific ioctls to perform host operations. QEMU should have done the necessary checks before calling KVM and, in case of failure, H_HARDWARE is simply returned. H_INT_ESB is a special case

[Qemu-devel] [PATCH v4 02/14] spapr/xive: add KVM support

2019-05-13 Thread Cédric Le Goater
This introduces a set of helpers when KVM is in use, which create the KVM XIVE device, initialize the interrupt sources at a KVM level and connect the interrupt presenters to the vCPU. They also handle the initialization of the TIMA and the source ESB memory regions of the controller. These have a

[Qemu-devel] [PATCH v4 05/14] spapr/xive: introduce a VM state change handler

2019-05-13 Thread Cédric Le Goater
This handler is in charge of stabilizing the flow of event notifications in the XIVE controller before migrating a guest. This is a requirement before transferring the guest EQ pages to a destination. When the VM is stopped, the handler sets the source PQs to PENDING to stop the flow of events and

[Qemu-devel] [PATCH v4 10/14] spapr: check for the activation of the KVM IRQ device

2019-05-13 Thread Cédric Le Goater
The activation of the KVM IRQ device depends on the interrupt mode chosen at CAS time by the machine and some methods used at reset or by the migration need to be protected. Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson Signed-off-by: Cédric Le Goater --- May be we can improve the

Re: [Qemu-devel] [PATCH v3 0/3] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

2019-05-13 Thread Kashyap Chamarthy
On Mon, May 13, 2019 at 08:36:23AM +0200, Laurent Vivier wrote: > On 12/05/2019 20:21, Michael S. Tsirkin wrote: [...] > > > Kashyap Chamarthy (1): > > >VirtIO-RNG: Update default entropy source to `/dev/urandom` > > > > > > Laurent Vivier (2): > > >rng-builtin: add an RNG backend that u

[Qemu-devel] [PATCH v4 14/14] spapr/irq: add KVM support to the 'dual' machine

2019-05-13 Thread Cédric Le Goater
The interrupt mode is chosen by the CAS negotiation process and activated after a reset to take into account the required changes in the machine. This brings new constraints on how the associated KVM IRQ device is initialized. Currently, each model takes care of the initialization of the KVM devic

[Qemu-devel] [PATCH v4 13/14] ppc/xics: fix irq priority in ics_set_irq_type()

2019-05-13 Thread Cédric Le Goater
Recent commits changed the behavior of ics_set_irq_type() to initialize correctly LSIs at the KVM level. ics_set_irq_type() is also called by the realize routine of the different devices of the machine when initial interrupts are claimed, before the ICSState device is reseted. In the case, the ICS

[Qemu-devel] [PATCH v4 12/14] spapr/irq: initialize the IRQ device only once

2019-05-13 Thread Cédric Le Goater
Add a check to make sure that the routine initializing the emulated IRQ device is called once. We don't have much to test on the XICS side, so we introduce a 'init' boolean under ICSState. Signed-off-by: Cédric Le Goater --- Changes since v3: - introduced a 'init' boolean under ICSState in

[Qemu-devel] [PATCH v4 08/14] sysbus: add a sysbus_mmio_unmap() helper

2019-05-13 Thread Cédric Le Goater
This will be used to remove the MMIO regions of the POWER9 XIVE interrupt controller when the sPAPR machine is reseted. Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson --- include/hw/sysbus.h | 1 + hw/core/sysbus.c| 10 ++ 2 files changed, 11 insertions(+) diff --git a/

[Qemu-devel] [PATCH v4 06/14] spapr/xive: add migration support for KVM

2019-05-13 Thread Cédric Le Goater
When the VM is stopped, the VM state handler stabilizes the XIVE IC and marks the EQ pages dirty. These are then transferred to destination before the transfer of the device vmstates starts. The SpaprXive interrupt controller model captures the XIVE internal tables, EAT and ENDT and the XiveTCTX m

[Qemu-devel] [PATCH v4 04/14] spapr/xive: add state synchronization with KVM

2019-05-13 Thread Cédric Le Goater
This extends the KVM XIVE device backend with 'synchronize_state' methods used to retrieve the state from KVM. The HW state of the sources, the KVM device and the thread interrupt contexts are collected for the monitor usage and also migration. These get operations rely on their KVM counterpart in

[Qemu-devel] [PATCH] linux-user: Implement membarrier syscall

2019-05-13 Thread Andreas Schwab
Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index f5ff6f5dc8..80399f4eb0 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -313,6 +313,9 @@ _syscall3(int, getrandom, voi

[Qemu-devel] [PATCH v4 09/14] spapr: introduce routines to delete the KVM IRQ device

2019-05-13 Thread Cédric Le Goater
If a new interrupt mode is chosen by CAS, the machine generates a reset to reconfigure. At this point, the connection with the previous KVM device needs to be closed and a new connection needs to opened with the KVM device operating the chosen interrupt mode. New routines are introduced to destroy

[Qemu-devel] [PATCH v4 11/14] spapr/irq: introduce a spapr_irq_init_device() helper

2019-05-13 Thread Cédric Le Goater
The way the XICS and the XIVE devices are initialized follows the same pattern. First, try to connect to the KVM device and if not possible fallback on the emulated device, unless a kernel_irqchip is required. The spapr_irq_init_device() routine implements this sequence in generic way using new sPA

[Qemu-devel] [PATCH v4 07/14] spapr/xive: activate KVM support

2019-05-13 Thread Cédric Le Goater
All is in place for KVM now. State synchronization and migration will come next. Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson --- hw/ppc/spapr_irq.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/ppc/spapr_irq.c b/hw/ppc/spapr_irq.c index 8d371523e66e..e969683f5c49

[Qemu-devel] [PATCH] linux-user: implement getsockopt SO_RCVTIMEO and SO_SNDTIMEO

2019-05-13 Thread Andreas Schwab
Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index d113a65831..ba5775a94e 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-13 Thread Daniel P . Berrangé
On Sun, May 12, 2019 at 03:47:49PM +0200, Thomas Huth wrote: > Maybe try to clean the folder first: > > rm -r capstone > mkdir capstone > make git-submodule-update > > If that does not help, maybe try a completely fresh git checkout? Rather than deleting stuff like that, it is best to use git

Re: [Qemu-devel] [PATCH v4 01/15] tests: acpi: rename acpi_parse_rsdp_table() into acpi_fetch_rsdp_table()

2019-05-13 Thread Igor Mammedov
On Sun, 12 May 2019 14:19:08 -0400 "Michael S. Tsirkin" wrote: > On Thu, May 02, 2019 at 04:51:49PM +0200, Igor Mammedov wrote: > > so name would reflect what the function does > > > > Signed-off-by: Igor Mammedov > > Reviewed-by: Philippe Mathieu-Daudé > > Reviewed-by: Wei Yang > > --- > > v

[Qemu-devel] [RFC v2 PATCH 0/3] ppc: spapr: virtual NVDIMM support

2019-05-13 Thread Shivaprasad G Bhat
The patchset attempts to implement the virtual NVDIMM for pseries. PAPR semantics is such that each NVDIMM device is comprising of multiple SCM(Storage Class Memory) blocks. The hypervisor is expected to prepare the FDT for the NVDIMM device and send guest a hotplug interrupt with new type RTAS_L

[Qemu-devel] [RFC v2 PATCH 1/3] mem: make nvdimm_device_list global

2019-05-13 Thread Shivaprasad G Bhat
nvdimm_device_list is required for parsing the list for devices in subsequent patches. Move it to common area. Signed-off-by: Shivaprasad G Bhat Reviewed-By: Igor Mammedov --- This looks to break the mips*-softmmu build. The mips depend on CONFIG_NVDIMM_ACPI, adding CONFIG_NVDIMM looks wrong. Is

[Qemu-devel] [RFC v2 PATCH 2/3] spapr: Add NVDIMM device support

2019-05-13 Thread Shivaprasad G Bhat
Add support for NVDIMM devices for sPAPR. Piggyback on existing nvdimm device interface in QEMU to support virtual NVDIMM devices for Power (May have to re-look at this later). Create the required DT entries for the device (some entries have dummy values right now). The patch creates the required

[Qemu-devel] [RFC v2 PATCH 3/3] spapr: Add Hcalls to support PAPR NVDIMM device

2019-05-13 Thread Shivaprasad G Bhat
This patch implements few of the necessary hcalls for the nvdimm support. PAPR semantics is such that each NVDIMM device is comprising of multiple SCM(Storage Class Memory) blocks. The guest requests the hypervisor to bind each of the SCM blocks of the NVDIMM device using hcalls. There can be SCM

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-13 Thread Andrea Bolognani
On Sun, 2019-05-12 at 10:36 +0200, Andrew Jones wrote: [...] >CPU type | accel | sve-max-vq | sve-vls-map >--- > 1) max | tcg | $MAX_VQ | $VLS_MAP > 2) max | kvm | $MAX_VQ | $VLS_MAP > 3)host | kvm | N/A | $VLS_MAP

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread Christian Borntraeger
On 13.05.19 10:03, David Hildenbrand wrote: >>> +if ((SCCB_SIZE - sizeof(ReadInfo)) / sizeof(CPUEntry) < S390_MAX_CPUS) >>> +mc->max_cpus = S390_MAX_CPUS - 8; >> >> This is too complicated, just set it always to 240. >> >> However, I am still not sure how to best handle this scenario

Re: [Qemu-devel] [PATCH 6/6] virtfs: Fix documentation of -fsdev and -virtfs

2019-05-13 Thread Greg Kurz
On Mon, 13 May 2019 10:39:17 +0200 Thomas Huth wrote: > On 09/05/2019 15.18, Greg Kurz wrote: > > On Wed, 8 May 2019 17:54:42 +0200 > > Thomas Huth wrote: > > > >> On 07/05/2019 10.45, Greg Kurz wrote: > >>> This fixes several things: > >>> - add "id" description to -virtfs documentation >

Re: [Qemu-devel] [PATCH v4 01/15] tests: acpi: rename acpi_parse_rsdp_table() into acpi_fetch_rsdp_table()

2019-05-13 Thread Igor Mammedov
On Mon, 13 May 2019 11:04:40 +0200 Igor Mammedov wrote: > On Sun, 12 May 2019 14:19:08 -0400 > "Michael S. Tsirkin" wrote: > > > On Thu, May 02, 2019 at 04:51:49PM +0200, Igor Mammedov wrote: > > > so name would reflect what the function does > > > > > > Signed-off-by: Igor Mammedov > > > Rev

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread David Hildenbrand
On 13.05.19 11:34, Christian Borntraeger wrote: > > > On 13.05.19 10:03, David Hildenbrand wrote: +if ((SCCB_SIZE - sizeof(ReadInfo)) / sizeof(CPUEntry) < S390_MAX_CPUS) +mc->max_cpus = S390_MAX_CPUS - 8; >>> >>> This is too complicated, just set it always to 240. >>> >>> Ho

Re: [Qemu-devel] [PULL 00/15] Block layer patches

2019-05-13 Thread Peter Maydell
On Fri, 10 May 2019 at 17:18, Kevin Wolf wrote: > > The following changes since commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-05-10 14:49:36 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH 6/6] virtfs: Fix documentation of -fsdev and -virtfs

2019-05-13 Thread Thomas Huth
On 13/05/2019 11.34, Greg Kurz wrote: > On Mon, 13 May 2019 10:39:17 +0200 > Thomas Huth wrote: > >> On 09/05/2019 15.18, Greg Kurz wrote: >>> On Wed, 8 May 2019 17:54:42 +0200 >>> Thomas Huth wrote: >>> On 07/05/2019 10.45, Greg Kurz wrote: > This fixes several things: > - add

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-13 Thread Peter Maydell
On Mon, 13 May 2019 at 10:08, Daniel P. Berrangé wrote: > > On Sun, May 12, 2019 at 03:47:49PM +0200, Thomas Huth wrote: > > Maybe try to clean the folder first: > > > > rm -r capstone > > mkdir capstone > > make git-submodule-update > > > > If that does not help, maybe try a completely fresh g

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2019 at 10:48:58AM +0100, Peter Maydell wrote: > On Mon, 13 May 2019 at 10:08, Daniel P. Berrangé wrote: > > > > On Sun, May 12, 2019 at 03:47:49PM +0200, Thomas Huth wrote: > > > Maybe try to clean the folder first: > > > > > > rm -r capstone > > > mkdir capstone > > > make git

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-13 Thread Peter Maydell
On Sun, 12 May 2019 at 09:36, Andrew Jones wrote: > > With the recent KVM guest SVE support pull request [1] KVM will be > ready for guests with SVE. This series provides the QEMU bits for > that enablement. The series starts with the bits needed for the KVM > SVE ioctls. Then it enables the arm '

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread Christian Borntraeger
On 13.05.19 11:40, David Hildenbrand wrote: > On 13.05.19 11:34, Christian Borntraeger wrote: >> >> >> On 13.05.19 10:03, David Hildenbrand wrote: > +if ((SCCB_SIZE - sizeof(ReadInfo)) / sizeof(CPUEntry) < > S390_MAX_CPUS) > +mc->max_cpus = S390_MAX_CPUS - 8; T

Re: [Qemu-devel] [PATCH v7 5/5] block/backup: refactor: split out backup_calculate_cluster_size

2019-05-13 Thread Vladimir Sementsov-Ogievskiy
09.05.2019 19:12, Max Reitz wrote: > On 29.04.19 11:08, Vladimir Sementsov-Ogievskiy wrote: >> Split out cluster_size calculation. Move copy-bitmap creation above >> block-job creation, as we are going to share it with upcoming >> backup-top filter, which also should be created before actual block

Re: [Qemu-devel] [PATCH v6 0/8] qcow2: encryption threads

2019-05-13 Thread Vladimir Sementsov-Ogievskiy
09.05.2019 17:56, Max Reitz wrote: > On 06.05.19 16:27, Vladimir Sementsov-Ogievskiy wrote: >> v6: >> - Rebase on master, so 02 changed to reflect changes in >> qcow2_compress(), keep r-b. >> - Rewrite 06 to even simpler locking [Max], drop r-b >> Drop following >> "qcow2: qcow2_co_

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread David Hildenbrand
On 13.05.19 11:51, Christian Borntraeger wrote: > > > On 13.05.19 11:40, David Hildenbrand wrote: >> On 13.05.19 11:34, Christian Borntraeger wrote: >>> >>> >>> On 13.05.19 10:03, David Hildenbrand wrote: >> +if ((SCCB_SIZE - sizeof(ReadInfo)) / sizeof(CPUEntry) < >> S390_MAX_CPUS) >

Re: [Qemu-devel] [PATCH] nbd/server: Nicer spelling of max BLOCK_STATUS reply length

2019-05-13 Thread Vladimir Sementsov-Ogievskiy
10.05.2019 18:17, Eric Blake wrote: > Commit 3d068aff (3.0) introduced NBD_MAX_BITMAP_EXTENTS as a limit on > how large we would allow a reply to NBD_CMD_BLOCK_STATUS to grow when > it is visiting a qemu:dirty-bitmap: context. Later, commit fb7afc79 > (3.1) reused the constant to limit base:alloca

Re: [Qemu-devel] [PATCH v3 3/3] virtio-rng: change default backend to rng-builtin

2019-05-13 Thread Laurent Vivier
On 10/05/2019 18:36, Markus Armbruster wrote: Laurent Vivier writes: Signed-off-by: Laurent Vivier --- backends/rng-builtin.c | 8 +++- hw/virtio/virtio-rng.c | 2 +- include/hw/virtio/virtio-rng.h | 4 ++-- include/sysemu/rng-builtin.h | 17 + q

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 5/6] ppc: spapr: Enable FWNMI capability

2019-05-13 Thread Aravinda Prasad
On Friday 10 May 2019 03:23 PM, David Gibson wrote: > On Fri, May 10, 2019 at 12:45:29PM +0530, Aravinda Prasad wrote: >> >> >> On Friday 10 May 2019 12:16 PM, David Gibson wrote: >>> On Mon, Apr 22, 2019 at 12:33:35PM +0530, Aravinda Prasad wrote: Enable the KVM capability KVM_CAP_PPC_FWNM

[Qemu-devel] [PATCH v2 1/2] vl: Deprecate -virtfs_synth

2019-05-13 Thread Greg Kurz
The synth fsdriver never got used for anything else but the QTest testcase for VirtIO 9P. And even there, QTest uses -fsdev synth and -device virtio-9p-... directly. Signed-off-by: Greg Kurz --- v2: - change "no replacement" to "use '-fsdev synth' instead" --- qemu-deprecated.texi |5 +

[Qemu-devel] [PATCH v2 0/2] fsdev/virtfs: Assorted cleanups and fixes

2019-05-13 Thread Greg Kurz
I've already applied patches from v1 with r-b tags to 9p-next. Please find updated versions of the -virtfs_synth deprecation and the documentation patches. -- Greg --- Greg Kurz (2): vl: Deprecate -virtfs_synth virtfs: Fix documentation of -fsdev and -virtfs qemu-deprecated.texi |

[Qemu-devel] [PATCH v2 2/2] virtfs: Fix documentation of -fsdev and -virtfs

2019-05-13 Thread Greg Kurz
This fixes several things: - add "id" description to -virtfs documentation - split the description into several lines in both usage and documentation for accurateness and clarity - add documentation and usage of the synth fsdriver - add "throttling.*" description to -fsdev local - add some missin

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread Christian Borntraeger
On 13.05.19 11:57, David Hildenbrand wrote: > On 13.05.19 11:51, Christian Borntraeger wrote: >> >> >> On 13.05.19 11:40, David Hildenbrand wrote: >>> On 13.05.19 11:34, Christian Borntraeger wrote: On 13.05.19 10:03, David Hildenbrand wrote: >>> +if ((SCCB_SIZE - sizeof(R

Re: [Qemu-devel] [PATCH] linux-user: implement getsockopt SO_RCVTIMEO and SO_SNDTIMEO

2019-05-13 Thread Laurent Vivier
On 13/05/2019 11:06, Andreas Schwab wrote: Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) Reviewed-by: Laurent Vivier

[Qemu-devel] [Bug 1823458] Update Released

2019-05-13 Thread Łukasz Zemczak
The verification of the Stable Release Update for qemu has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a reg

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-05-13 Thread Łukasz Zemczak
This is even more than what I wanted, thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1823458 Title: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu Sta

Re: [Qemu-devel] [PATCH] linux-user: Implement membarrier syscall

2019-05-13 Thread Laurent Vivier
On 13/05/2019 11:02, Andreas Schwab wrote: Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 7 +++ 1 file changed, 7 insertions(+) Reviewed-by: Laurent Vivier

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-05-13 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:2.5+dfsg-5ubuntu10.37 --- qemu (1:2.5+dfsg-5ubuntu10.37) xenial; urgency=medium * d/p/lp1823458/add-VirtIONet-vhost_stopped-flag-to-prevent-multiple.patch, d/p/lp1823458/do-not-call-vhost_net_cleanup-on-running-net-from-ch.patch: -

Re: [Qemu-devel] [PATCH] block/file-posix: Truncate in xfs_write_zeroes()

2019-05-13 Thread Kevin Wolf
Am 10.05.2019 um 23:12 hat Max Reitz geschrieben: > XFS_IOC_ZERO_RANGE does not increase the file length: > $ touch foo > $ xfs_io -c 'zero 0 65536' foo > $ stat -c "size=%s, blocks=%b" foo > size=0, blocks=128 > > We do want writes beyond the EOF to automatically increase the file > length, howev

Re: [Qemu-devel] [PATCH 11/13] target/arm/cpu64: max cpu: Introduce sve-vls-map

2019-05-13 Thread Dave Martin
On Sun, May 12, 2019 at 09:36:22AM +0100, Andrew Jones wrote: > Introduce another cpu property to control SVE vector lengths, > sve-vls-map, which allows the user to explicitly select the > set of vector lengths the guest can use. The map must conform > to QEMU's limits and architectural constraint

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-13 Thread Dave Martin
On Mon, May 13, 2019 at 10:32:46AM +0100, Andrea Bolognani wrote: > On Sun, 2019-05-12 at 10:36 +0200, Andrew Jones wrote: > [...] > >CPU type | accel | sve-max-vq | sve-vls-map > >--- > > 1) max | tcg | $MAX_VQ | $VLS_MAP > > 2) max |

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 4/6] target/ppc: Build rtas error log upon an MCE

2019-05-13 Thread Greg Kurz
On Mon, 22 Apr 2019 12:33:26 +0530 Aravinda Prasad wrote: > Upon a machine check exception (MCE) in a guest address space, > KVM causes a guest exit to enable QEMU to build and pass the > error to the guest in the PAPR defined rtas error log format. > > This patch builds the rtas error log, copi

Re: [Qemu-devel] [PATCH] qcow2: Define and use QCOW2_COMPRESSED_SECTOR_SIZE

2019-05-13 Thread Stefano Garzarella
The patch LGTM, just a comment below. On Fri, May 10, 2019 at 07:22:54PM +0300, Alberto Garcia wrote: > When an L2 table entry points to a compressed cluster the space used > by the data is specified in 512-byte sectors. This size is independent > from BDRV_SECTOR_SIZE and is specific to the qcow2

Re: [Qemu-devel] [PATCH] blockdev: fix missed target unref for drive-backup

2019-05-13 Thread Kevin Wolf
Am 10.05.2019 um 23:52 hat John Snow geschrieben: > If the bitmap can't be used for whatever reason, we skip putting down > the reference. Fix that. > > In practice, this means that if you attempt to gracefully exit QEMU > after a backup command being rejected, bdrv_close_all will fail and > tell

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread David Hildenbrand
On 13.05.19 12:55, Christian Borntraeger wrote: > > > On 13.05.19 11:57, David Hildenbrand wrote: >> On 13.05.19 11:51, Christian Borntraeger wrote: >>> >>> >>> On 13.05.19 11:40, David Hildenbrand wrote: On 13.05.19 11:34, Christian Borntraeger wrote: > > > On 13.05.19 10:03, Da

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread Cornelia Huck
On Mon, 13 May 2019 13:34:35 +0200 David Hildenbrand wrote: > On 13.05.19 12:55, Christian Borntraeger wrote: > > > > > > On 13.05.19 11:57, David Hildenbrand wrote: > >> On 13.05.19 11:51, Christian Borntraeger wrote: > >>> > >>> > >>> On 13.05.19 11:40, David Hildenbrand wrote: > O

Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP

2019-05-13 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, May 10, 2019 at 11:29:53AM +0200, Markus Armbruster wrote: > [...] >> >> >> > We could extend QAPI introspection to return that if necessary, >> >> >> > right? >> >> >> >> >> >> I'm confident we can come up with *something*. It might kill the neat >> >> >> and

Re: [Qemu-devel] [PATCH] qcow2: Define and use QCOW2_COMPRESSED_SECTOR_SIZE

2019-05-13 Thread Alberto Garcia
On Mon 13 May 2019 01:28:46 PM CEST, Stefano Garzarella wrote: >> +int size = QCOW2_COMPRESSED_SECTOR_SIZE * >> +(((l2_entry >> s->csize_shift) & s->csize_mask) + 1); > > What about using int64_t type for the 'size' variable? > (because the qcow2_free_clusters() 'size' p

Re: [Qemu-devel] [PATCH v4 3/5] linux-user: Add support the SIOCIFPFLAGS ioctls for all targets

2019-05-13 Thread Laurent Vivier
On 03/05/2019 19:50, Aleksandar Markovic wrote: From: Neng Chen Add support for getting and setting extended private flags of a network device via SIOCSIFPFLAGS and SIOCGIFPFLAGS ioctls. The ioctl numeric values are platform-independent and determined by the file include/uapi/linux/sockios.h i

[Qemu-devel] [PATCH V3 2/3] hw/display/ramfb: lock guest resolution after it's set

2019-05-13 Thread Marcel Apfelbaum
From: Hou Qiming Only allow one resolution change per guest boot, which prevents a crash when the guest writes garbage to the configuration space (e.g. when rebooting). Signed-off-by: HOU Qiming [fixed malformed patch] Signed-off-by: Marcel Apfelbaum --- hw/display/ramfb.c | 26 ++

[Qemu-devel] [PATCH V3 0/3] ramfb improvements

2019-05-13 Thread Marcel Apfelbaum
Please see the description in each patch. Qiming, thanks for taking the time to upstream your patches! Marcel V2 - V3: - rebase to latest master - send as new series - use QEMU coding conventions - fixed malformed patches (maybe I didn't import them right) Hou Qiming (3): hw/display/ramfb:

Re: [Qemu-devel] [PULL 0/5] demacro SoftMMU

2019-05-13 Thread Peter Maydell
On Fri, 10 May 2019 at 21:01, Alex Bennée wrote: > > The following changes since commit a6ae23831b05a11880b40f7d58e332c45a6b04f7: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/python-next-pull-request' into staging (2019-05-03 > 15:26:09 +0100) > > are available in the Git reposito

Re: [Qemu-devel] [PATCH v4 3/8] hw/acpi: Add ACPI Generic Event Device Support

2019-05-13 Thread Shameerali Kolothum Thodi
Hi Igor, > -Original Message- > From: Shameerali Kolothum Thodi > Sent: 03 May 2019 13:46 > To: 'Igor Mammedov' > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; > shannon.zha...@gmail.com; sa...@linux.intel.com; > sebastien.bo...@intel.c

[Qemu-devel] [PATCH V3 3/3] hw/display/ramfb: initialize fw-config space with xres/ yres

2019-05-13 Thread Marcel Apfelbaum
From: Hou Qiming If xres / yres were specified in QEMU command line, write them as an initial resolution to the fw-config space on guest reset, which a later BIOS / OVMF patch can take advantage of. Signed-off-by: HOU Qiming [fixed malformed patch] Signed-off-by: Marcel Apfelbaum --- hw/displ

[Qemu-devel] [PATCH V3 1/3] hw/display/ramfb: fix guest memory un-mapping

2019-05-13 Thread Marcel Apfelbaum
From: Hou Qiming Pulled back the `qemu_create_displaysurface_guestmem` function to create the display surface so that the guest memory gets properly unmapped. Signed-off-by: HOU Qiming [rename the new functions and use QEMU coding style] Signed-off-by: Marcel Apfelbaum --- hw/display/ramfb.c

Re: [Qemu-devel] [PATCH v4 4/5] linux-user: Add support for setsockopt() options IPV6__MEMBERSHIP

2019-05-13 Thread Laurent Vivier
On 03/05/2019 19:50, Aleksandar Markovic wrote: From: Neng Chen Add support for options IPV6_ADD_MEMBERSHIP and IPV6_DROP_MEMPEMBERSHIP of the syscall setsockopt(). These options control membership in multicast groups. Their argument is a pointer to a struct ipv6_mreq, which is in turn defined

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

2019-05-13 Thread Daniel P . Berrangé
On Wed, May 08, 2019 at 02:44:07PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, May 07, 2019 at 10:47:06AM +0200, Markus Armbruster wrote: > > > >> >> > I can think of some options: > >> >> > > >> >> > 1. Encode unsigned 64-bit integers as signed 64-bit integers.

  1   2   3   4   >