Re: [Qemu-devel] [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Yan Zhao
On Wed, May 08, 2019 at 11:27:47PM +0800, Boris Fiuczynski wrote: > On 5/8/19 11:22 PM, Alex Williamson wrote: > >>> I thought there was a request to make this more specific to migration > >>> by renaming it to something like migration_version. Also, as an > >>> > >> so this attribute may not o

Re: [Qemu-devel] [PATCH v2 18/27] target/s390x: Convert to CPUClass::tlb_fill

2019-05-09 Thread David Hildenbrand
On 09.05.19 08:02, Richard Henderson wrote: > Cc: qemu-s3...@nongnu.org > Cc: Cornelia Huck > Cc: David Hildenbrand > Signed-off-by: Richard Henderson > --- > v2: Keep user-only and system tlb_fill separate. > --- > target/s390x/internal.h| 5 +-- > target/s390x/cpu.c | 5 ++- > t

Re: [Qemu-devel] [PATCH] The ioctl(SIOCGIFNAME) call requires a struct ifreq.

2019-05-09 Thread Erik Kline
Anything else I need to do? On Wed, 24 Apr 2019 at 02:10, Peter Maydell wrote: > On Tue, 23 Apr 2019 at 23:28, Erik Kline via Qemu-devel > wrote: > > > > Signed-off-by: Erik Kline > > Buglink: https://bugs.launchpad.net/qemu/+bug/1814352 > > --- > > linux-user/ioctls.h | 2 +- > > 1 file chan

Re: [Qemu-devel] [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Boris Fiuczynski
On 5/8/19 11:22 PM, Alex Williamson wrote: I thought there was a request to make this more specific to migration by renaming it to something like migration_version. Also, as an so this attribute may not only include a mdev device's parent device info and mdev type, but also include numeric s

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-09 Thread Xiang Zheng
On 2019/5/8 21:20, Markus Armbruster wrote: > Laszlo Ersek writes: > >> Hi Markus, >> >> On 05/07/19 20:01, Markus Armbruster wrote: >>> The subject is slightly misleading. Holes read as zero. So do >>> non-holes full of zeroes. The patch avoids reading the former, but >>> still reads the l

Re: [Qemu-devel] [PATCH 03/13] tests/vm: send locale environment variables over ssh

2019-05-09 Thread Thomas Huth
On 08/05/2019 10.56, Gerd Hoffmann wrote: > Needed for unicode tests. > > Signed-off-by: Gerd Hoffmann > --- > tests/vm/basevm.py | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py > index 6b46674f4497..20eec5420dbf 100755 > --- a/te

Re: [Qemu-devel] [PATCH] Multiple ramfb enhancements

2019-05-09 Thread Hou Qiming
Done. Will resend the split patches. On Thu, May 9, 2019 at 2:48 PM Gerd Hoffmann wrote: > On Thu, May 09, 2019 at 08:15:44AM +0800, Hou Qiming wrote: > > Pulled back the `qemu_create_displaysurface_guestmem` function to create > > the display surface so that the guest memory gets properly unmap

[Qemu-devel] [PATCH 2/3] ramfb enhancement

2019-05-09 Thread Hou Qiming
Only allow one resolution change per guest boot, which prevents a crash when the guest writes garbage to the configuration space (e.g. when rebooting). Signed-off-by: HOU Qiming --- hw/display/ramfb.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a

[Qemu-devel] [PATCH 1/3] ramfb enhancement

2019-05-09 Thread Hou Qiming
Pulled back the `qemu_create_displaysurface_guestmem` function to create the display surface so that the guest memory gets properly unmaped. Signed-off-by: HOU Qiming --- hw/display/ramfb.c | 53 -- 1 file changed, 42 insertions(+), 11 deletions(-) di

[Qemu-devel] [PATCH 3/3] ramfb enhancement

2019-05-09 Thread Hou Qiming
Write an initial resolution to the configuration space on guest reset, which a later BIOS / OVMF patch can take advantage of. Signed-off-by: HOU Qiming --- hw/display/ramfb-standalone.c | 12 +++- hw/display/ramfb.c| 16 +++- hw/vfio/display.c | 4 ++-

[Qemu-devel] [PULL 1/1] Update upstream slirp

2019-05-09 Thread Samuel Thibault
Adds gitignore, README file, and fixes ident protocol parsing. Signed-off-by: Samuel Thibault --- slirp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp b/slirp index 0e79ba4856..f0da672620 16 --- a/slirp +++ b/slirp @@ -1 +1 @@ -Subproject commit 0e79ba48567ccfb3cc2

[Qemu-devel] [PULL 0/1] Update upstream slirp

2019-05-09 Thread Samuel Thibault
The following changes since commit 30302acee710881cb248ec3391adcd54dcf52396: Update upstream slirp (2019-05-09 09:58:57 +0200) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to 30302acee710881cb248ec3391

Re: [Qemu-devel] [PATCH] blockdev-backup: don't check aio_context too early

2019-05-09 Thread Kevin Wolf
Am 09.05.2019 um 00:55 hat John Snow geschrieben: > > On 5/7/19 4:50 AM, Kevin Wolf wrote: > > Am 06.05.2019 um 22:33 hat John Snow geschrieben: > >> in blockdev_backup_prepare, we check to make sure that the target is > >> associated with a compatible aio context. However, do_blockdev_backup is >

[Qemu-devel] [PATCH] Fix typo on "info pic" monitor cmd output for xive

2019-05-09 Thread sathnaga
From: Satheesh Rajendran Instead of LISN i.e "Logical Interrupt Source Number" as per Xive PAPR document "info pic" prints as LSIN, let's fix it. Signed-off-by: Satheesh Rajendran --- hw/intc/spapr_xive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/spapr_xive.c

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Fix typo on "info pic" monitor cmd output for xive

2019-05-09 Thread Greg Kurz
On Thu, 9 May 2019 13:37:50 +0530 sathn...@linux.vnet.ibm.com wrote: > From: Satheesh Rajendran > > Instead of LISN i.e "Logical Interrupt Source Number" as per > Xive PAPR document "info pic" prints as LSIN, let's fix it. > > Signed-off-by: Satheesh Rajendran > --- Reviewed-by: Greg Kurz

Re: [Qemu-devel] [PATCH 03/13] tests/vm: send locale environment variables over ssh

2019-05-09 Thread Gerd Hoffmann
Hi, > "gmake check" then also finally failed: > > --- /home/qemu/qemu-test.AOvcgx/src/tests/qapi-schema/unicode-str.err > 2019-05-09 05:56:17.0 + > +++ - 2019-05-09 06:12:54.451392000 + > @@ -1 +1 @@ > -tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name 'é' > +tes

[Qemu-devel] [PULL 07/14] tests/tpm-tests: Use g_test_skip() to mark skipped tests

2019-05-09 Thread Thomas Huth
Since we do not use gtester anymore (which had a bug here), we can now use g_test_skip() to mark skipped tests. Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Berger Message-Id: <20190424094557.28404-1-th...@redhat.com> Signed-off-by: Thomas Huth --- te

[Qemu-devel] [PULL 01/14] tests: Force Python I/O encoding for check-qapi-schema

2019-05-09 Thread Thomas Huth
From: Eduardo Habkost test-qapi.py doesn't force a specific encoding for stderr or stdout, but the reference files used by check-qapi-schema are in UTF-8. This breaks check-qapi-schema under certain circumstances (e.g. if using the C locale and Python < 3.7). We need to make sure test-qapi.py a

[Qemu-devel] [PULL 04/14] tests/qmp-cmd-test: Use qtest_init() instead of qtest_start()

2019-05-09 Thread Thomas Huth
qtest_start() + qtest_end() should be avoided, since they use the global_qtest variable that we want to get rid of in the long run (since global_qtest can not be used in tests that have to track multiple QEMU states, like migration tests). Use qtest_init() and qtest_quit() instead. Message-Id: <20

[Qemu-devel] [PULL 02/14] tests/tco: Make test independent of global_qtest

2019-05-09 Thread Thomas Huth
Pass around the QTestState in the TestData, so we do not need the global_qtest variable here anymore. Message-Id: <20190409085245.31548-2-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/tco-test.c | 63 1 file changed, 32 insertions(+), 31

[Qemu-devel] [PULL 05/14] tests/test-hmp: Use qtest_init() instead of qtest_start()

2019-05-09 Thread Thomas Huth
qtest_start() + qtest_end() should be avoided, since they use the global_qtest variable that we want to get rid of in the long run Use qtest_init() and qtest_quit() instead. Reviewed-by: Dr. David Alan Gilbert Message-Id: <20190409085245.31548-5-th...@redhat.com> Signed-off-by: Thomas Huth ---

[Qemu-devel] [PULL 06/14] tests/ide-test: Make test independent of global_qtest

2019-05-09 Thread Thomas Huth
Pass around the QTestState, so we do not need the problematic global_qtest variable (which causes trouble for tests that have multiple test states) here anymore. Message-Id: <20190409085245.31548-6-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/ide-test.c | 284 ++

[Qemu-devel] [PULL 09/14] tests/drive_del-test: Use qtest_init() instead of qtest_start()

2019-05-09 Thread Thomas Huth
qtest_start() + qtest_end() should be avoided, since they use the global_qtest variable that we want to get rid of in the long run Use qtest_init() and qtest_quit() instead. Reviewed-by: Eric Blake Message-Id: <20190508142153.21555-1-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/drive_

[Qemu-devel] [PULL 13/14] target/sh4: Fix LGPL information in the file headers

2019-05-09 Thread Thomas Huth
It's either "GNU *Library* General Public License version 2" or "GNU Lesser General Public License version *2.1*", but there was no "version 2.0" of the "Lesser" license. So assume that version 2.1 is meant here. Message-Id: <1550073530-4138-1-git-send-email-th...@redhat.com> Signed-off-by: Thomas

[Qemu-devel] [PULL 10/14] tests: qpci_unplug_acpi_device_test() should not rely on global_qtest

2019-05-09 Thread Thomas Huth
libqos functions should not use functions that require global_qtest to be set, since such library functions could also be used by tests that deal with multiple test states. Add a parameter to this function to explicitly specify the test state. Reviewed-by: Eric Blake Message-Id: <20190508143209.2

[Qemu-devel] [PULL 08/14] tests/Makefile: Remove unused test-obj-y variable

2019-05-09 Thread Thomas Huth
I recently noticed that test-obj-y contains a file called tests/check-block-qtest.o which simply does not belong to any .c file and thus wondered why this is not causing any trouble. It is only used to add -Itests to the command line (which refers to the build directory). However, it is not needed

[Qemu-devel] [PULL 03/14] tests/megasas: Make test independent of global_qtest

2019-05-09 Thread Thomas Huth
The test uses memwrite() and thus relies on global_qtest. Let's replace it with qtest_memwrite(), so that we are independent from global_qtest here. Message-Id: <20190409085245.31548-3-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/megasas-test.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] Use of PreallocMode in block drivers

2019-05-09 Thread Stefano Garzarella
On Wed, May 08, 2019 at 01:44:27PM +0200, Markus Armbruster wrote: > Stefano Garzarella writes: > > > On Tue, May 07, 2019 at 08:34:51AM +0200, Markus Armbruster wrote: > >> Cc: Peter for a libvirt perspective. > >> > >> Stefano Garzarella writes: > >> > >> > This patch adds the support of pre

[Qemu-devel] [PULL 00/14] qtests, copyright statement clarifications and misc patches

2019-05-09 Thread Thomas Huth
Hi Peter, the following changes since commit 629d166994725773dea9cef843fcb0ae5f3585fe: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190507' into staging (2019-05-08 00:06:43 +0100) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pull-

[Qemu-devel] [PULL 14/14] include/exec/poison: Mark TARGET_FMT_lu as poisoned, too

2019-05-09 Thread Thomas Huth
We already poison TARGET_FMT_lx and TARGET_FMT_ld, but apparently forgot to poison TARGET_FMT_lu, too. Do it now. Reviewed-by: Richard Henderson Message-Id: <20190508150608.3311-1-th...@redhat.com> Signed-off-by: Thomas Huth --- include/exec/poison.h | 1 + 1 file changed, 1 insertion(+) diff

[Qemu-devel] [PULL 12/14] target/openrisc: Fix LGPL information in the file headers

2019-05-09 Thread Thomas Huth
It's either "GNU *Library* General Public License version 2" or "GNU Lesser General Public License version *2.1*", but there was no "version 2.0" of the "Lesser" license. So assume that version 2.1 is meant here. Acked-by: Stafford Horne Message-Id: <1550073577-4248-1-git-send-email-th...@redhat.

[Qemu-devel] [PULL 11/14] hw/i2c/smbus_ich9: Fix the confusing contributions-after-2012 statement

2019-05-09 Thread Thomas Huth
The license information in this file is rather confusing. The text declares LGPL first, but then says that contributions after Jan 2012 are licensed under the GPL instead. How should the average user who just downloaded the release tarball know which part is now GPL and which is LGPL? Also, as far

Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP

2019-05-09 Thread Markus Armbruster
We've wandered into the QAPI vs. QOM swamp. Cc: Paolo. Eduardo Habkost writes: > On Wed, May 08, 2019 at 11:16:50AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Tue, May 07, 2019 at 07:07:04AM +0200, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >> >> >>

Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci

2019-05-09 Thread Marc-André Lureau
Hi On Thu, May 9, 2019 at 8:32 AM Gerd Hoffmann wrote: > > Hi, > > > +static const VirtioPCIDeviceTypeInfo vhost_user_input_pci_info = { > > +.base_name = TYPE_VHOST_USER_INPUT_PCI, > > +.generic_name = "vhost-user-input-pci", > > +.transitional_name = "vhost-user-input-pci-transiti

Re: [Qemu-devel] [PULL 00/13] Trivial branch patches

2019-05-09 Thread Markus Armbruster
Alex Bennée writes: > Markus Armbruster writes: > >> Alex Bennée writes: >> >>> Peter Maydell writes: >>> On Thu, 2 May 2019 at 19:58, Laurent Vivier wrote: > > The following changes since commit > 8482ff2eb3bb95020eb2f370a9b3ea26511e41df: > > Merge remote-tracking

Re: [Qemu-devel] [PATCH] tests: Force Python I/O encoding for check-qapi-schema

2019-05-09 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, May 08, 2019 at 03:04:43PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Tue, May 07, 2019 at 03:13:45PM +0100, Daniel P. Berrangé wrote: >> >> On Mon, May 06, 2019 at 06:38:17PM -0300, Eduardo Habkost wrote: >> >> > test-qapi.py doesn't

Re: [Qemu-devel] [PATCH v7 2/2] hw/arm: Add arm SBSA reference machine, devices part

2019-05-09 Thread Peter Maydell
On Wed, 8 May 2019 at 18:48, Radoslaw Biernacki wrote: > > > > On Wed, 8 May 2019 at 13:30, Hongbo Zhang wrote: >> >> On Tue, 30 Apr 2019 at 22:17, Peter Maydell wrote: >> > I don't think we should automatically create the usb keyboard >> > and mouse devices. The user can do it on the command li

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] spapr/xive: EQ page should be naturally aligned

2019-05-09 Thread Greg Kurz
On Wed, 8 May 2019 19:19:44 +0200 Cédric Le Goater wrote: > When the OS configures the EQ page in which to receive event > notifications from the XIVE interrupt controller, the page should be > naturally aligned. Add this check. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz

Re: [Qemu-devel] [PULL v2 00/12] Trivial branch patches

2019-05-09 Thread Peter Maydell
On Tue, 7 May 2019 at 21:48, Peter Maydell wrote: > > On Tue, 7 May 2019 at 20:10, Laurent Vivier wrote: > > > > Ping ? > > This is in my queue to process, but there are still a bunch of > other pullreqs in the queue too; I am working through them. Wait, I'm confused now. Looking back through my

Re: [Qemu-devel] [PULL 00/11] Block patches

2019-05-09 Thread Peter Maydell
On Tue, 7 May 2019 at 16:18, Max Reitz wrote: > > The following changes since commit 19eb2d4e736dc895f31fbd6b520e514f10cc08e0: > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into > staging (2019-05-07 10:43:32 +0100) > > are available in the Git repository at: > > ht

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] spapr/xive: fix EQ page addresses above 64GB

2019-05-09 Thread Greg Kurz
On Wed, 8 May 2019 19:19:45 +0200 Cédric Le Goater wrote: > The high order bits of the address of the OS event queue is stored in > bits [4-31] of word2 of the XIVE END internal structures and the low > order bits in word3. This structure is using Big Endian ordering and > computing the value re

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] spapr/xive: print out the EQ page address in the monitor

2019-05-09 Thread Greg Kurz
On Wed, 8 May 2019 19:19:46 +0200 Cédric Le Goater wrote: > This proved to be a useful information when debugging issues with OS > event queues allocated above 64GB. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > hw/intc/spapr_xive.c | 5 +++-- > 1 file changed, 3 inser

Re: [Qemu-devel] [PULL 00/13] Trivial branch patches

2019-05-09 Thread Peter Maydell
On Thu, 9 May 2019 at 09:32, Markus Armbruster wrote: > > Alex Bennée writes: > > I couldn't replicate the bug with access to my s390 account so I think > > it might be existing build artefact related which is odd. > > Any ideas on how to debug this further? It's consistently failed for me both

Re: [Qemu-devel] [PATCH] The ioctl(SIOCGIFNAME) call requires a struct ifreq.

2019-05-09 Thread Peter Maydell
Ah, just noticed the linux-user maintainers weren't cc'd on this patch. Laurent, could you pick this patch up, please? thanks -- PMM On Wed, 8 May 2019 at 23:54, Erik Kline wrote: > > Anything else I need to do? > > On Wed, 24 Apr 2019 at 02:10, Peter Maydell wrote: >> >> On Tue, 23 Apr 2019 at

Re: [Qemu-devel] [PATCH 26/26] tcg: Use tlb_fill probe from tlb_vaddr_to_host

2019-05-09 Thread Peter Maydell
On Thu, 9 May 2019 at 06:24, Richard Henderson wrote: > > On 4/29/19 10:41 AM, Peter Maydell wrote: > > On Wed, 3 Apr 2019 at 05:05, Richard Henderson > > wrote: > >> > >> Most of the existing users would continue around a loop which > >> would fault the tlb entry in via a normal load/store. But

Re: [Qemu-devel] [PULL v2 00/12] Trivial branch patches

2019-05-09 Thread Laurent Vivier
On 09/05/2019 10:51, Peter Maydell wrote: On Tue, 7 May 2019 at 21:48, Peter Maydell wrote: On Tue, 7 May 2019 at 20:10, Laurent Vivier wrote: Ping ? This is in my queue to process, but there are still a bunch of other pullreqs in the queue too; I am working through them. Wait, I'm conf

Re: [Qemu-devel] [PATCH] The ioctl(SIOCGIFNAME) call requires a struct ifreq.

2019-05-09 Thread Laurent Vivier
On 09/05/2019 10:55, Peter Maydell wrote: Ah, just noticed the linux-user maintainers weren't cc'd on this patch. Laurent, could you pick this patch up, please? Applied to my linux-user branch. Thanks, Laurent thanks -- PMM On Wed, 8 May 2019 at 23:54, Erik Kline wrote: Anything else I

Re: [Qemu-devel] [PATCH] include/exec/poison: Mark TARGET_FMT_lu as poisoned, too

2019-05-09 Thread Paolo Bonzini
On 08/05/19 10:06, Thomas Huth wrote: > > Signed-off-by: Thomas Huth > --- > include/exec/poison.h | 1 + > 1 file changed, 1 insertion(+) Queued, thanks. Paolo

Re: [Qemu-devel] [PATCH] Fix typo on "info pic" monitor cmd output for xive

2019-05-09 Thread Cédric Le Goater
On 5/9/19 10:07 AM, sathn...@linux.vnet.ibm.com wrote: > From: Satheesh Rajendran > > Instead of LISN i.e "Logical Interrupt Source Number" as per > Xive PAPR document "info pic" prints as LSIN, let's fix it. > > Signed-off-by: Satheesh Rajendran Reviewed-by: Cédric Le Goater Thanks, C.

Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 10:31:46AM +0200, Markus Armbruster wrote: > We've wandered into the QAPI vs. QOM swamp. Cc: Paolo. > > Eduardo Habkost writes: > > > On Wed, May 08, 2019 at 11:16:50AM +0200, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Tue, May 07, 2019 at 07:

Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci

2019-05-09 Thread Gerd Hoffmann
On Thu, May 09, 2019 at 10:37:20AM +0200, Marc-André Lureau wrote: > Hi > > On Thu, May 9, 2019 at 8:32 AM Gerd Hoffmann wrote: > > > > Hi, > > > > > +static const VirtioPCIDeviceTypeInfo vhost_user_input_pci_info = { > > > +.base_name = TYPE_VHOST_USER_INPUT_PCI, > > > +.generic_name =

Re: [Qemu-devel] [PATCH] configure: Require python3 >= 3.5

2019-05-09 Thread Kevin Wolf
Am 09.05.2019 um 07:45 hat Markus Armbruster geschrieben: > Eduardo Habkost writes: > > diff --git a/.travis.yml b/.travis.yml > > index 66448d99d6..0f6986b3f1 100644 > > --- a/.travis.yml > > +++ b/.travis.yml > > @@ -211,7 +211,7 @@ matrix: > > - CONFIG="--target-list=x86_64-softmmu" >

[Qemu-devel] [PATCH 1/2] virtio-input-host-pci: cleanup types

2019-05-09 Thread Gerd Hoffmann
virtio input is virtio-1.0 only, so we don't need the -transitional and -non-transitional variants. Signed-off-by: Gerd Hoffmann --- hw/virtio/virtio-input-host-pci.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio-input-host-pci.c b/hw/virtio/virtio

[Qemu-devel] [PATCH 2/2] virtio-input: fix Kconfig dependency and Makefile

2019-05-09 Thread Gerd Hoffmann
Make VIRTIO_INPUT_HOST depend on VIRTIO_INPUT. Use CONFIG_VIRTIO_INPUT_HOST in Makefile. Signed-off-by: Gerd Hoffmann --- hw/input/Kconfig | 2 +- hw/input/Makefile.objs | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/input/Kconfig b/hw/input/Kconfig index 50e55

Re: [Qemu-devel] [PULL v2 00/28] Kconfig for Arm machines

2019-05-09 Thread Philippe Mathieu-Daudé
On 5/9/19 7:34 AM, Thomas Huth wrote: > On 08/05/2019 18.45, Philippe Mathieu-Daudé wrote: >> [clicked ctrl+enter too fast] >> >> On Wed, May 8, 2019 at 6:43 PM Philippe Mathieu-Daudé >> wrote: >>> On 5/8/19 5:33 PM, Thomas Huth wrote: On 08/05/2019 17.09, Peter Maydell wrote: > On Tue,

Re: [Qemu-devel] [PATCH] configure: Require python3 >= 3.5

2019-05-09 Thread Kevin Wolf
Am 09.05.2019 um 11:24 hat Kevin Wolf geschrieben: > Am 09.05.2019 um 07:45 hat Markus Armbruster geschrieben: > > Eduardo Habkost writes: > > > diff --git a/.travis.yml b/.travis.yml > > > index 66448d99d6..0f6986b3f1 100644 > > > --- a/.travis.yml > > > +++ b/.travis.yml > > > @@ -211,7 +211,7 @

Re: [Qemu-devel] [PATCH] configure: Require python3 >= 3.5

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 11:36:04AM +0200, Kevin Wolf wrote: > Am 09.05.2019 um 11:24 hat Kevin Wolf geschrieben: > > Am 09.05.2019 um 07:45 hat Markus Armbruster geschrieben: > > > Eduardo Habkost writes: > > > > diff --git a/.travis.yml b/.travis.yml > > > > index 66448d99d6..0f6986b3f1 100644 >

Re: [Qemu-devel] [PATCH v2 10/27] target/mips: Pass a valid error to raise_mmu_exception for user-only

2019-05-09 Thread Philippe Mathieu-Daudé
On 5/9/19 8:02 AM, Richard Henderson wrote: > At present we give ret = 0, or TLBRET_MATCH. This gets matched > by the default case, which falls through to TLBRET_BADADDR. > However, it makes more sense to use a proper value. All of the > tlb-related exceptions are handled identically in cpu_loop.

Re: [Qemu-devel] [PATCH v2 22/27] target/tricore: Convert to CPUClass::tlb_fill

2019-05-09 Thread Bastian Koppelmann
On 5/9/19 8:02 AM, Richard Henderson wrote: Cc: Bastian Koppelmann Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/tricore/cpu.h | 6 +++--- target/tricore/cpu.c | 1 + target/tricore/helper.c| 27 +++ target/tricore/op_help

Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci

2019-05-09 Thread Marc-André Lureau
Hi On Thu, May 9, 2019 at 11:25 AM Gerd Hoffmann wrote: > > On Thu, May 09, 2019 at 10:37:20AM +0200, Marc-André Lureau wrote: > > Hi > > > > On Thu, May 9, 2019 at 8:32 AM Gerd Hoffmann wrote: > > > > > > Hi, > > > > > > > +static const VirtioPCIDeviceTypeInfo vhost_user_input_pci_info = { >

[Qemu-devel] [Bug 1828272] Re: 4.0 breaks keyboard autorepeat in guests with xserver

2019-05-09 Thread Daniel Berrange
Adding Gerd to the CC, since this is possibly caused by recent work to keyboard state tracking code. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1828272 Title: 4.0 breaks keyboard autorepeat in g

Re: [Qemu-devel] [PATCH v2 27/27] tcg: Use tlb_fill probe from tlb_vaddr_to_host

2019-05-09 Thread Philippe Mathieu-Daudé
On 5/9/19 8:02 AM, Richard Henderson wrote: > Most of the existing users would continue around a loop which > would fault the tlb entry in via a normal load/store. But for > SVE we have a true non-faulting case which requires the new > probing form of tlb_fill. > > Reviewed-by: Peter Maydell > S

Re: [Qemu-devel] [PATCH v2 12/27] target/mips: Convert to CPUClass::tlb_fill

2019-05-09 Thread Philippe Mathieu-Daudé
On 5/9/19 8:02 AM, Richard Henderson wrote: > Note that env->active_tc.PC is removed from the qemu_log as that value > is garbage. The PC isn't recovered until cpu_restore_state, called from > cpu_loop_exit_restore, called from do_raise_exception_err. > > Cc: Aleksandar Markovic > Cc: Aleksandar

Re: [Qemu-devel] [PATCH v2 24/27] target/xtensa: Convert to CPUClass::tlb_fill

2019-05-09 Thread Peter Maydell
On Thu, 9 May 2019 at 07:20, Richard Henderson wrote: > > Cc: Max Filippov > Signed-off-by: Richard Henderson > --- > v2: Keep user-only and system tlb_fill separate. > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2 0/5] fw_cfg_test refactor and add two test cases

2019-05-09 Thread Li Qiang
Ping this serials. Thanks, Li Qiang Li Qiang 于2019年4月24日周三 下午10:07写道: > In the disscuss of adding reboot timeout test case: > https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg03304.html > > Philippe suggested we should uses the only related option for one > specific test. However cu

Re: [Qemu-devel] [PATCH v2 09/27] target/microblaze: Convert to CPUClass::tlb_fill

2019-05-09 Thread Peter Maydell
On Thu, 9 May 2019 at 07:08, Richard Henderson wrote: > > Cc: Edgar E. Iglesias > Signed-off-by: Richard Henderson > --- > v2: Keep user-only and system tlb_fill separate. > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-09 Thread Christian Borntraeger
On 02.05.19 00:31, Collin Walling wrote: > DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must > be intercepted by SIE and handled via KVM. Let's introduce some > functions to communicate between QEMU and KVM via ioctls. These > will be used to get/set the diag318 related inform

Re: [Qemu-devel] [PATCH v2 11/27] target/mips: Tidy control flow in mips_cpu_handle_mmu_fault

2019-05-09 Thread Philippe Mathieu-Daudé
On 5/9/19 8:02 AM, Richard Henderson wrote: > Since the only non-negative TLBRET_* value is TLBRET_MATCH, > the subsequent test for ret < 0 is useless. Use early return > to allow subsequent blocks to be unindented. > > Signed-off-by: Richard Henderson > --- > target/mips/helper.c | 54

Re: [Qemu-devel] [PATCH v2 14/27] target/nios2: Convert to CPUClass::tlb_fill

2019-05-09 Thread Peter Maydell
On Thu, 9 May 2019 at 07:10, Richard Henderson wrote: > > Remove the leftover debugging cpu_dump_state. > > Cc: Chris Wulff > Cc: Marek Vasut > Signed-off-by: Richard Henderson > --- > v2: Keep user-only and system tlb_fill separate. > --- > -int nios2_cpu_handle_mmu_fault(CPUState *cs, vaddr

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-09 Thread David Hildenbrand
On 09.05.19 11:58, Christian Borntraeger wrote: > > > On 02.05.19 00:31, Collin Walling wrote: >> DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must >> be intercepted by SIE and handled via KVM. Let's introduce some >> functions to communicate between QEMU and KVM via ioctls. Th

Re: [Qemu-devel] [PATCH] include/exec/poison: Mark TARGET_FMT_lu as poisoned, too

2019-05-09 Thread Philippe Mathieu-Daudé
On 5/9/19 11:10 AM, Paolo Bonzini wrote: > On 08/05/19 10:06, Thomas Huth wrote: >> >> Signed-off-by: Thomas Huth >> --- >> include/exec/poison.h | 1 + >> 1 file changed, 1 insertion(+) > > Queued, thanks. Thomas already included it in his "qtests, copyright statement clarifications and misc p

Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci

2019-05-09 Thread Marc-André Lureau
Hi On Thu, May 9, 2019 at 11:53 AM Marc-André Lureau wrote: > > Hi > > On Thu, May 9, 2019 at 11:25 AM Gerd Hoffmann wrote: > > > > On Thu, May 09, 2019 at 10:37:20AM +0200, Marc-André Lureau wrote: > > > Hi > > > > > > On Thu, May 9, 2019 at 8:32 AM Gerd Hoffmann wrote: > > > > > > > > Hi, >

Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci

2019-05-09 Thread Marc-André Lureau
Hi On Thu, May 9, 2019 at 12:09 PM Marc-André Lureau wrote: > > Hi > > On Thu, May 9, 2019 at 11:53 AM Marc-André Lureau > wrote: > > > > Hi > > > > On Thu, May 9, 2019 at 11:25 AM Gerd Hoffmann wrote: > > > > > > On Thu, May 09, 2019 at 10:37:20AM +0200, Marc-André Lureau wrote: > > > > Hi > >

Re: [Qemu-devel] [PATCH 1/2] virtio-input-host-pci: cleanup types

2019-05-09 Thread Marc-André Lureau
Hi On Thu, May 9, 2019 at 11:33 AM Gerd Hoffmann wrote: > > virtio input is virtio-1.0 only, so we don't need the -transitional and > -non-transitional variants. > > Signed-off-by: Gerd Hoffmann > --- > hw/virtio/virtio-input-host-pci.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletio

Re: [Qemu-devel] [PATCH 2/2] virtio-input: fix Kconfig dependency and Makefile

2019-05-09 Thread Marc-André Lureau
On Thu, May 9, 2019 at 11:31 AM Gerd Hoffmann wrote: > > Make VIRTIO_INPUT_HOST depend on VIRTIO_INPUT. > Use CONFIG_VIRTIO_INPUT_HOST in Makefile. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau > --- > hw/input/Kconfig | 2 +- > hw/input/Makefile.objs | 4 +--- > 2 fil

Re: [Qemu-devel] [PATCH 1/3] ramfb enhancement

2019-05-09 Thread Marcel Apfelbaum
Hi Qiming, On 5/9/19 10:57 AM, Hou Qiming wrote: Please format the commit subject with a prefix and do not use the same subject for all the pacthes in the series, for this patch it can be something like: Next version should also have a V2 in the prefix, for this patch it can look somethin

Re: [Qemu-devel] [PATCH 2/3] ramfb enhancement

2019-05-09 Thread Marcel Apfelbaum
On 5/9/19 10:58 AM, Hou Qiming wrote: The subject for this patch may be:     [PATCH V2 2/3] hw/display/ramfb: don't allow resolution change until vm reset Only allow one resolution change per guest boot, which prevents a crash when the guest writes garbage to the configuration space (e

Re: [Qemu-devel] [PATCH 3/3] ramfb enhancement

2019-05-09 Thread Marcel Apfelbaum
On 5/9/19 10:58 AM, Hou Qiming wrote: Write an initial resolution to the configuration space on guest reset, which a later BIOS / OVMF patch can take advantage of. I like the idea of moving the ramfb configuration to the PCI configuration space, do you think is possible to move all the ra

Re: [Qemu-devel] [PATCH 00/13] tests/vm: serial console autoinstall, misc fixes.

2019-05-09 Thread Thomas Huth
On 08/05/2019 10.56, Gerd Hoffmann wrote: > This patch series changes the way virtual machines for test builds are > managed. They are created locally on the developer machine now. The > installer is booted on the serial console and the scripts walks through > the dialogs to install and configure

Re: [Qemu-devel] [PATCH 00/13] tests/vm: serial console autoinstall, misc fixes.

2019-05-09 Thread Philippe Mathieu-Daudé
Hi Thomas, On 5/9/19 1:53 PM, Thomas Huth wrote: > On 08/05/2019 10.56, Gerd Hoffmann wrote: >> This patch series changes the way virtual machines for test builds are >> managed. They are created locally on the developer machine now. The >> installer is booted on the serial console and the scrip

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-09 Thread Markus Armbruster
Xiang Zheng writes: > On 2019/5/8 21:20, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> Hi Markus, >>> >>> On 05/07/19 20:01, Markus Armbruster wrote: The subject is slightly misleading. Holes read as zero. So do non-holes full of zeroes. The patch avoids reading the forme

Re: [Qemu-devel] [PATCH 12/13] tests/vm: fedora autoinstall, using serial console

2019-05-09 Thread Thomas Huth
On 08/05/2019 10.56, Gerd Hoffmann wrote: > Download the install iso and prepare the image locally. Install to > disk, using the serial console. Create qemu user, configure ssh login. > Install packages needed for qemu builds. > > Yes, we have docker images for fedora. But for trouble-shooting

Re: [Qemu-devel] Use of PreallocMode in block drivers

2019-05-09 Thread Markus Armbruster
Stefano Garzarella writes: > On Wed, May 08, 2019 at 01:44:27PM +0200, Markus Armbruster wrote: >> Stefano Garzarella writes: >> >> > On Tue, May 07, 2019 at 08:34:51AM +0200, Markus Armbruster wrote: >> >> Cc: Peter for a libvirt perspective. >> >> >> >> Stefano Garzarella writes: >> >> >>

Re: [Qemu-devel] [PATCH v6 6/8] qcow2: qcow2_co_preadv: improve locking

2019-05-09 Thread Alberto Garcia
On Mon 06 May 2019 04:27:39 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > Background: decryption will be done in threads, to take benefit of it, > we should move it out of the lock first. > > But let's go further: it turns out, that only > qcow2_get_cluster_offset() needs locking, so reduce lockin

Re: [Qemu-devel] [PATCH 13/13] tests/vm: ubuntu.i386: apt proxy setup

2019-05-09 Thread Philippe Mathieu-Daudé
On 5/8/19 10:56 AM, Gerd Hoffmann wrote: > Configure apt proxy so package downloads > can be cached and can pass firewalls. Yay \o/ > > Signed-off-by: Gerd Hoffmann > --- > tests/vm/ubuntu.i386 | 4 > 1 file changed, 4 insertions(+) > > diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu

[Qemu-devel] [PATCH v3 0/2] security.rst: add Security Guide to developer docs

2019-05-09 Thread Stefan Hajnoczi
v3: * Split into security.texi for qemu-doc and secure-coding-practices.rst for the developer documentation [danpb] * Mentioned that QEMU can be started as non-root using UNIX groups on /dev/kvm, /dev/net/tun, etc [Alex Bennee] * Kept Acked-by and Reviewed-by since the v3 changes are minor

[Qemu-devel] [PATCH v3 1/2] docs: add Secure Coding Practices to developer docs

2019-05-09 Thread Stefan Hajnoczi
At KVM Forum 2018 I gave a presentation on security in QEMU: https://www.youtube.com/watch?v=YAdRf_hwxU8 (video) https://vmsplice.net/~stefan/stefanha-kvm-forum-2018.pdf (slides) This patch adds a guide to secure coding practices. This document covers things that developers should know about secu

[Qemu-devel] [PATCH v3 2/2] docs: add Security chapter to the documentation

2019-05-09 Thread Stefan Hajnoczi
This new chapter in the QEMU documentation covers the security requirements that QEMU is designed to meet and principles for securely deploying QEMU. It is just a starting point that can be extended in the future with more information. Signed-off-by: Stefan Hajnoczi Acked-by: Stefano Garzarella

Re: [Qemu-devel] [PATCH v3 2/2] docs: add Security chapter to the documentation

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 01:18:20PM +0100, Stefan Hajnoczi wrote: > This new chapter in the QEMU documentation covers the security > requirements that QEMU is designed to meet and principles for securely > deploying QEMU. > > It is just a starting point that can be extended in the future with more

Re: [Qemu-devel] [PATCH v3 1/2] docs: add Secure Coding Practices to developer docs

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 01:18:19PM +0100, Stefan Hajnoczi wrote: > At KVM Forum 2018 I gave a presentation on security in QEMU: > https://www.youtube.com/watch?v=YAdRf_hwxU8 (video) > https://vmsplice.net/~stefan/stefanha-kvm-forum-2018.pdf (slides) > > This patch adds a guide to secure coding pra

Re: [Qemu-devel] [PATCH v7 3/6] libnvdimm: add dax_dev sync flag

2019-05-09 Thread Pankaj Gupta
> > > > This patch adds 'DAXDEV_SYNC' flag which is set > > for nd_region doing synchronous flush. This later > > is used to disable MAP_SYNC functionality for > > ext4 & xfs filesystem for devices don't support > > synchronous flush. > > > > Signed-off-by: Pankaj Gupta > [..] > > diff --git a/i

Re: [Qemu-devel] [PATCH v2 0/6] Add vhost-user-input

2019-05-09 Thread Michael S. Tsirkin
On Fri, May 03, 2019 at 03:00:28PM +0200, Marc-André Lureau wrote: > Hi, > > This is the vhost-user-input part of "[PATCH v6 00/11] vhost-user for input & > GPU". > > v2: > - build fixes > > v1: (changes since original v6 series) > - add "libvhost-user: fix -Waddress-of-packed-member" & "util:

Re: [Qemu-devel] [PULL 0/1] Update upstream slirp

2019-05-09 Thread Peter Maydell
On Thu, 9 May 2019 at 09:01, Samuel Thibault wrote: > > The following changes since commit 30302acee710881cb248ec3391adcd54dcf52396: > > Update upstream slirp (2019-05-09 09:58:57 +0200) > > are available in the Git repository at: > > https://people.debian.org/~sthibault/qemu.git tags/samuel-t

Re: [Qemu-devel] [PATCH 00/13] tests/vm: serial console autoinstall, misc fixes.

2019-05-09 Thread Thomas Huth
On 09/05/2019 14.04, Philippe Mathieu-Daudé wrote: [...] >> I now gave your series another try and replaced patch 3 with the python3 >> fix from Eduardo locally here. FreeBSD works great. OpenBSD is fine too, >> except for the known issue that the "gmake check" does not work - but >> this issue has

Re: [Qemu-devel] [PATCH v2] chardev/char-i2c: Implement Linux I2C character device

2019-05-09 Thread Stefan Hajnoczi
On Sat, May 04, 2019 at 07:11:19PM +0100, Ernest Esene wrote: > Add support for Linux I2C character device for I2C device passthrough > For example: > -chardev linux-i2c,address=0x46,path=/dev/i2c-N,id=i2c-chardev There is a mixture of "linux-i2c" and "char-i2c" names in this patch, which I find c

[Qemu-devel] [PATCH v2 4/4] net: remove unused get_str_sep() function

2019-05-09 Thread Stefano Garzarella
Since the get_str_sep() function is no longer used in net/net.c, we can remove it. Signed-off-by: Stefano Garzarella --- net/net.c | 20 1 file changed, 20 deletions(-) diff --git a/net/net.c b/net/net.c index 570e093c4f..52496caca5 100644 --- a/net/net.c +++ b/net/net.c @@

[Qemu-devel] [PATCH v2 0/4] Clean ups in net/net.c

2019-05-09 Thread Stefano Garzarella
This series is a follow up of "[PATCH] net: avoid to use variable length array in net_client_init()" [1], so it contains the v2 of that patch, plus other new related patches. I discovered an assertion failure while I was testing the patches, so I added the patch 1 to solve this issue. Following t

[Qemu-devel] [PATCH v2 3/4] net: use g_strsplit() for parsing host address and port

2019-05-09 Thread Stefano Garzarella
Use the glib function to split host address and port in the parse_host_port() function. Suggested-by: Markus Armbruster Signed-off-by: Stefano Garzarella --- net/net.c | 43 +++ 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/net/net.c b/n

[Qemu-devel] [PATCH v2 1/4] net: fix assertion failure when ipv6-prefixlen is not a number

2019-05-09 Thread Stefano Garzarella
If 'ipv6-prefixlen' is not a number, the current behaviour produces an assertion failure: $ qemu-system-x86_64 -net user,ipv6-net=feca::0/a qemu-system-x86_64: qemu/util/qemu-option.c:1175: qemu_opts_foreach: Assertion `!errp || !*errp' failed. Aborted (core dumped) This patch fixe

Re: [Qemu-devel] [PATCH 12/13] tests/vm: fedora autoinstall, using serial console

2019-05-09 Thread Gerd Hoffmann
Hi, > > +# shutdown > > +self.ssh_root("poweroff") > > +self.console_wait("sleep state S5") > > +self.wait() > > + > > +if os.path.exists(img): > > +os.remove(img) > > +os.rename(img_tmp, img) > > +os.remove(iso) > > +se

  1   2   3   4   >