Re: [Qemu-devel] Update *BSD images with gnu-sed and bash

2019-05-08 Thread Kamil Rytarowski
On 06.05.2019 12:12, Thomas Huth wrote: > On 26/04/2019 18.43, Laszlo Ersek wrote: >> On 04/25/19 08:00, Thomas Huth wrote: >>> On 24/04/2019 23.29, Wainer dos Santos Moschetta wrote: Hello Thomas, On 04/24/2019 07:37 AM, Thomas Huth wrote: > We are going to enable the qemu-iotes

Re: [Qemu-devel] [PATCH v4 13/24] linux-user: Call qcrypto_init if not using -seed

2019-05-08 Thread Laurent Vivier
On 08/05/2019 06:11, Richard Henderson wrote: On 5/7/19 7:13 AM, Laurent Vivier wrote: -    if (seed_optarg != NULL) { -    qemu_guest_random_seed_main(seed_optarg, &error_fatal); +    { +    Error *err = NULL; +    if (seed_optarg != NULL) { +    qemu_guest_random_seed_main(

Re: [Qemu-devel] [PATCH v4 09/24] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc

2019-05-08 Thread Laurent Vivier
On 08/05/2019 02:32, Richard Henderson wrote: On 5/7/19 3:49 AM, Laurent Vivier wrote:     void start_auth_vnc(VncState *vs)   { -    make_challenge(vs); +    Error *err = NULL; + +    if (qcrypto_random_bytes(vs->challenge, sizeof(vs->challenge), &err)) { +    trace_vnc_auth_fail(vs, vs->

[Qemu-devel] [PATCH v2] tests/Makefile: Remove unused test-obj-y variable

2019-05-08 Thread Thomas Huth
I recently noticed that test-obj-y contains a file called tests/check-block-qtest.o which simply does not belong to any .c file and thus wondered why this is not causing any trouble. It is only used to add -Itests to the command line (which refers to the build directory). However, it is not needed

Re: [Qemu-devel] Update *BSD images with gnu-sed and bash

2019-05-08 Thread Thomas Huth
On 08/05/2019 09.06, Kamil Rytarowski wrote: > On 06.05.2019 12:12, Thomas Huth wrote: [...] >> Kamil, >> >> could you maybe help with the NetBSD image and the tests/vm/netbsd script? >> > > Please be more specific what am I expected to do. We have some VMs (including NetBSD) available that are

[Qemu-devel] qemu iotest 192 does not clean up correctly

2019-05-08 Thread Thomas Huth
I've ran into this failure today: 140 0s ... - output mismatch (see 140.out.bad) --- /home/thuth/devel/qemu/tests/qemu-iotests/140.out 2019-05-07 17:57:08.0 +0200 +++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/140.out.bad 2019-05-08 07:19:23.0 +0200 @@ -10,6 +10,8 @@ {"

Re: [Qemu-devel] [PATCH v3 18/39] target/mips: Use env_cpu, env_archcpu

2019-05-08 Thread Aleksandar Markovic
On May 8, 2019 2:19 AM, "Richard Henderson" wrote: > > > This commit message doesnˊt explain the reason for the change, and why is this an improvement. The underlyng reason for distingishing between env_cpu and env_archcpu cases is not explained too. Thanks, Aleksandar > Reviewed-by: Philippe M

Re: [Qemu-devel] [PATCH 5/6] vl: Deprecate -virtfs_synth

2019-05-08 Thread Thomas Huth
On 07/05/2019 10.45, Greg Kurz wrote: > The synth fsdriver never got used for anything else but the > QTest testcase for VirtIO 9P. And even there, QTest directly > uses -fsdev synth and -device virtio-9p-{pci|device}. > > Signed-off-by: Greg Kurz > --- > > This should be Cc'd to libvir-l...@red

Re: [Qemu-devel] [PATCH 3/6] fsdev: Move some types definition to qemu-fsdev.c

2019-05-08 Thread Thomas Huth
On 07/05/2019 10.45, Greg Kurz wrote: > It would make sense for these types to be defined in a header file if > we had an API for fsdrivers to register themselves. In practice, we > only have three of them and it is very unlikely we add new ones since > the future of file sharing between host and g

Re: [Qemu-devel] [PATCH 0/7] Delete 16 *_cpu_class_by_name() functions

2019-05-08 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, May 06, 2019 at 01:53:28PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > This series adds a new CPUClass::class_name_format field, which >> > allows us to delete 16 of the 21 *_cpu_class_by_name() functions >> > that exist today. >> >> Whi

Re: [Qemu-devel] [PATCH RFC v2] s390/css: handle CCW_FLAG_SKIP

2019-05-08 Thread Cornelia Huck
On Tue, 7 May 2019 11:31:16 -0400 Eric Farman wrote: > On 5/7/19 5:08 AM, Pierre Morel wrote: > > On 07/05/2019 10:12, Cornelia Huck wrote: > >> If a ccw has CCW_FLAG_SKIP set, and the command is of type > >> read, read backwards, or sense, no data should be written > >> to the guest for that c

Re: [Qemu-devel] [PATCH 5/6] pc-bios/s390-ccw: Clean up harmless misuse of isdigit()

2019-05-08 Thread Thomas Huth
On 18/04/2019 20.13, Markus Armbruster wrote: > Thomas Huth writes: > >> On 18/04/2019 16.53, Markus Armbruster wrote: >>> atoui() and get_index() pass char values to isdigit(). With a >>> standard isdigit(), we'd get undefined behavior when the value is >>> negative. But we're using isdigit()

Re: [Qemu-devel] [PATCH 5/6] vl: Deprecate -virtfs_synth

2019-05-08 Thread Greg Kurz
On Wed, 8 May 2019 10:26:53 +0200 Thomas Huth wrote: > On 07/05/2019 10.45, Greg Kurz wrote: > > The synth fsdriver never got used for anything else but the > > QTest testcase for VirtIO 9P. And even there, QTest directly > > uses -fsdev synth and -device virtio-9p-{pci|device}. > > > > Signed-o

[Qemu-devel] [PATCH 02/13] tests/vm: send proxy environment variables over ssh

2019-05-08 Thread Gerd Hoffmann
Packages are fetched via proxy that way, if configured on the host. That might be required to pass firewalls, and it allows to route package downloads through a caching proxy server. Needs AcceptEnv setup in sshd_config on the guest side to work. Signed-off-by: Gerd Hoffmann --- tests/vm/basevm

[Qemu-devel] [PATCH 04/13] tests/vm: use ssh with pty unconditionally

2019-05-08 Thread Gerd Hoffmann
Allways ask ssh to run with a pseudo terminal. Not having a terminal causes problems now and then. Signed-off-by: Gerd Hoffmann --- tests/vm/basevm.py | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 20eec5420dbf..9c6

[Qemu-devel] [PATCH 03/13] tests/vm: send locale environment variables over ssh

2019-05-08 Thread Gerd Hoffmann
Needed for unicode tests. Signed-off-by: Gerd Hoffmann --- tests/vm/basevm.py | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 6b46674f4497..20eec5420dbf 100755 --- a/tests/vm/basevm.py +++ b/tests/vm/basevm.py @@ -43,6 +43,20 @@ c

[Qemu-devel] [PATCH 01/13] scripts: use git archive in archive-source

2019-05-08 Thread Gerd Hoffmann
Use git archive to create tarballs of qemu and submodules instead of cloning the repository and the submodules. This is a order of magnitude faster because it doesn't fetch the submodules from the internet each time the script runs. Signed-off-by: Gerd Hoffmann --- scripts/archive-source.sh | 7

[Qemu-devel] [PATCH 05/13] tests/vm: run test builds on snapshot

2019-05-08 Thread Gerd Hoffmann
The build script doesn't shutdown the guest VMs properly, which results in filesystem corruption and guest boot failures sooner or later. Use the --snapshot to run builds on a snapshot, That way killing the VM doesn't corrupt the base image. Signed-off-by: Gerd Hoffmann --- tests/vm/Makefile.in

[Qemu-devel] [PATCH 00/13] tests/vm: serial console autoinstall, misc fixes.

2019-05-08 Thread Gerd Hoffmann
This patch series changes the way virtual machines for test builds are managed. They are created locally on the developer machine now. The installer is booted on the serial console and the scripts walks through the dialogs to install and configure the guest. That takes the download.patchew.org s

[Qemu-devel] [PATCH 10/13] tests/vm: freebsd autoinstall, using serial console

2019-05-08 Thread Gerd Hoffmann
Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Note that freebsd package downloads are delivered as non-cachabl

[Qemu-devel] [PATCH 06/13] tests/vm: add vm-boot-{ssh, serial}- targets

2019-05-08 Thread Gerd Hoffmann
For testing/troubleshooting convinience. make vm-boot-serial- Boot guest, with the serial console on stdio. make vm-boot-ssh- Boot guest, login via ssh. Signed-off-by: Gerd Hoffmann --- tests/vm/Makefile.include | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests

[Qemu-devel] [PATCH 07/13] tests/vm: add DEBUG=1 to help text

2019-05-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/vm/Makefile.include | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include index 47084d5717c6..8714b5947958 100644 --- a/tests/vm/Makefile.include +++ b/tests/vm/Makefile.include @@ -25,6 +25,8 @@ vm-test:

[Qemu-devel] [PATCH 08/13] tests/vm: serial console support helpers

2019-05-08 Thread Gerd Hoffmann
Add a bunch of helpers to talk to the guest using the serial console. Also drop the hard-coded -serial parameter for the vm so QEMUMachine.set_console() actually works. Signed-off-by: Gerd Hoffmann --- tests/vm/basevm.py | 82 -- 1 file changed, 80 in

Re: [Qemu-devel] [PATCH 1/5] qemu-nbd: Add --pid-file option

2019-05-08 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 08:36:06PM +0200, Max Reitz wrote: > --fork is a bit boring if there is no way to get the child's PID. This > option helps. > > Signed-off-by: Max Reitz > --- > qemu-nbd.c| 29 + > qemu-nbd.texi | 2 ++ > 2 files changed, 31 insertions(+)

[Qemu-devel] [PATCH 12/13] tests/vm: fedora autoinstall, using serial console

2019-05-08 Thread Gerd Hoffmann
Download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Yes, we have docker images for fedora. But for trouble-shooting it might be helpful to have a vm too. When vm build

[Qemu-devel] [PATCH 13/13] tests/vm: ubuntu.i386: apt proxy setup

2019-05-08 Thread Gerd Hoffmann
Configure apt proxy so package downloads can be cached and can pass firewalls. Signed-off-by: Gerd Hoffmann --- tests/vm/ubuntu.i386 | 4 1 file changed, 4 insertions(+) diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386 index a22d137e76df..b869afd212fa 100755 --- a/tests/vm/ubuntu.i

[Qemu-devel] [PATCH 09/13] tests/vm: openbsd autoinstall, using serial console

2019-05-08 Thread Gerd Hoffmann
Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Signed-off-by: Gerd Hoffmann --- tests/vm/openbsd | 150 ++

[Qemu-devel] [PATCH 11/13] tests/vm: netbsd autoinstall, using serial console

2019-05-08 Thread Gerd Hoffmann
Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Signed-off-by: Gerd Hoffmann --- tests/vm/netbsd | 178 +++

Re: [Qemu-devel] [PATCH 1/5] qemu-nbd: Add --pid-file option

2019-05-08 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 09:39:01PM +0200, Max Reitz wrote: > On 07.05.19 21:30, Eric Blake wrote: > > On 5/7/19 1:36 PM, Max Reitz wrote: > >> --fork is a bit boring if there is no way to get the child's PID. This > >> option helps. > >> > >> Signed-off-by: Max Reitz > >> --- > >> qemu-nbd.c

Re: [Qemu-devel] Question in QEMU : The result of printf does not appear in the qemu VM's log.

2019-05-08 Thread Daniel P . Berrangé
On Wed, May 08, 2019 at 10:51:00AM +0900, S KH wrote: > Hello. > > I'am student studying QEMU hypervisor and SPICE. > > In order to find out the calling order of functions in QEMU source, I input > and compiled 'printf ("% s \ n", __ func__) "into source. If using printf() output is buffered so

Re: [Qemu-devel] [PATCH v3] i386: Add some MSR based features on Cascadelake-Server CPU model

2019-05-08 Thread Daniel P . Berrangé
On Wed, May 08, 2019 at 09:31:53AM +0800, Tao Xu wrote: > As noted in "c7a88b52f6 i386: Add new model of Cascadelake-Server" > Because MSR based feature has been supported by QEMU, we add > CPUID_7_0_EDX_ARCH_CAPABILITIES on Cascadelake-Server CPU model, > and add IA32_ARCH_CAPABILITIES MSR based f

Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP

2019-05-08 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, May 07, 2019 at 07:07:04AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > This series adds machine type deprecation information to the >> > output of the `query-machines` QMP command. With this, libvirt >> > and management software will be

[Qemu-devel] [PATCH RFC v3] s390/css: handle CCW_FLAG_SKIP

2019-05-08 Thread Cornelia Huck
If a ccw has CCW_FLAG_SKIP set, and the command is of type read, read backwards, or sense, no data should be written to the guest for that command. Signed-off-by: Cornelia Huck --- v2 -> v3: fixed checks even more [Pierre] v1 -> v2: fixed checks for command type [Eric] --- hw/s390x/css.c

Re: [Qemu-devel] [PATCH] tests: Force Python I/O encoding for check-qapi-schema

2019-05-08 Thread Alex Bennée
Eduardo Habkost writes: > test-qapi.py doesn't force a specific encoding for stderr or > stdout, but the reference files used by check-qapi-schema are in > UTF-8. This breaks check-qapi-schema under certain circumstances > (e.g. if using the C locale and Python < 3.7). > > We need to make sure

Re: [Qemu-devel] [PATCH v2] block/rbd: increase dynamically the image size

2019-05-08 Thread Stefano Garzarella
On Tue, May 07, 2019 at 11:43:50AM +0200, Kevin Wolf wrote: > Am 06.05.2019 um 11:50 hat Stefano Garzarella geschrieben: > > On Fri, May 03, 2019 at 01:21:23PM -0400, Jason Dillaman wrote: > > > On Fri, May 3, 2019 at 12:30 PM Stefano Garzarella > > > wrote: > > > > > > > > RBD APIs don't allow u

[Qemu-devel] [PULL SUBSYSTEM s390x 1/3] pc-bios/s390-ccw: Clean up harmless misuse of isdigit()

2019-05-08 Thread Thomas Huth
From: Markus Armbruster atoui() and get_index() pass char values to isdigit(). With a standard isdigit(), we'd get undefined behavior when the value is negative. Can't happen as char is unsigned on s390x. Even if it ould, we're actually using isdigit() from pc-bios/s390-ccw/libc.h here, which

[Qemu-devel] [PULL SUBSYSTEM s390x 0/3] s390-ccw-bios: Skip bootmap signature entries

2019-05-08 Thread Thomas Huth
This pull request is not for master. Hi Cornelia, the following changes since commit a6f6d24757a73f7176989134b97284a1a7df11e5: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20190507-pull-request' into staging (2019-05-07 21:39:28 +0100) are available in the Git repository at: ht

[Qemu-devel] [PULL SUBSYSTEM s390x 2/3] s390-bios: Skip bootmap signature entries

2019-05-08 Thread Thomas Huth
From: "Jason J. Herne" Newer versions of zipl have the ability to write signature entries to the boot script for secure boot. We don't yet support secure boot, but we need to skip over signature entries while reading the boot script in order to maintain our ability to boot guest operating systems

[Qemu-devel] [PULL SUBSYSTEM s390x 3/3] pc-bios/s390: Update firmware image with "Skip bootmap signature entries" fix

2019-05-08 Thread Thomas Huth
Firmware now skips the unsupported signature entries instead of aborting the boot process. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw.img | Bin 42608 -> 42608 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index ba054828d35d

Re: [Qemu-devel] [PATCH 00/11] kvm/migration: support KVM_CLEAR_DIRTY_LOG

2019-05-08 Thread Paolo Bonzini
On 08/05/19 01:15, Peter Xu wrote: > Design > === > > I started with a naive/stupid design that I always pass all 1's to the > KVM for a memory range to clear all the dirty bits within that memory > range, but then I encountered guest oops - it's simply because we > can't clear any

Re: [Qemu-devel] [PATCH 03/11] memory: Don't set migration bitmap when without migration

2019-05-08 Thread Paolo Bonzini
On 08/05/19 01:15, Peter Xu wrote: > Similar to 9460dee4b2 ("memory: do not touch code dirty bitmap unless > TCG is enabled", 2015-06-05) but for the migration bitmap - we can > skip the MIGRATION bitmap update if migration not enabled. > > Signed-off-by: Peter Xu > --- > include/exec/memory.h

Re: [Qemu-devel] [PATCH 01/11] migration: No need to take rcu during sync_dirty_bitmap

2019-05-08 Thread Paolo Bonzini
On 08/05/19 01:15, Peter Xu wrote: > cpu_physical_memory_sync_dirty_bitmap() has one RAMBlock* as > parameter, which means that it must be with RCU read lock held > already. Taking it again inside seems redundant. Removing it. > Instead comment on the functions about the RCU read lock. > > Signe

Re: [Qemu-devel] [PATCH 02/11] memory: Remove memory_region_get_dirty()

2019-05-08 Thread Paolo Bonzini
On 08/05/19 01:15, Peter Xu wrote: > It's never used anywhere. > > Signed-off-by: Peter Xu > --- > include/exec/memory.h | 17 - > memory.c | 8 > 2 files changed, 25 deletions(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 9144a

Re: [Qemu-devel] Question in QEMU : The result of printf does not appear in the qemu VM's log.

2019-05-08 Thread Daniel P . Berrangé
Re-adding qemu-devel - please don't take mailing list threads private. On Wed, May 08, 2019 at 07:07:01PM +0900, S KH wrote: > Hello. > > Thanks to help, I can see the results of the output in the log file. Thank > you very much for your help. I am currently working with the QEMU source as > well

[Qemu-devel] [Question] Memory hotplug clarification for Qemu ARM/virt

2019-05-08 Thread Shameerali Kolothum Thodi
Hi, This series here[0] attempts to add support for PCDIMM in QEMU for ARM/Virt platform and has stumbled upon an issue as it is not clear(at least from Qemu/EDK2 point of view) how in physical world the hotpluggable memory is handled by kernel. The proposed implementation in Qemu, builds the SRA

Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-05-08 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Suraj Jitindar Singh writes: > > > Add a monitor command "dump-stack" to be used to dump the stack for the > > current cpu. > > I guess this is just for debugging. Correct? > > Shouldn't this be "info stack", to match "info registers" and "info

Re: [Qemu-devel] [PATCH v4 8/8] hw/arm/boot: Expose the PC-DIMM nodes in the DT

2019-05-08 Thread Shameerali Kolothum Thodi
Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: 03 May 2019 15:14 > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org; eric.au...@redhat.com; > imamm...@redhat.com > Cc: peter.mayd...@linaro.org; sa...@linux.intel.com; > ar

Re: [Qemu-devel] [PULL 10/19] tests/boot_linux_console: increase timeout

2019-05-08 Thread Gerd Hoffmann
On Thu, May 02, 2019 at 09:41:21PM -0300, Eduardo Habkost wrote: > From: Cleber Rosa > > When running on very low powered environments, some tests may time out > causing false negatives. As a conservative change, and for > considering that human time (investigating false negatives) is worth > mo

[Qemu-devel] [PATCH] qemu-img: Use IEC binary prefixes for size constants

2019-05-08 Thread Stefano Garzarella
Using IEC binary prefixes in order to make the code more readable. Signed-off-by: Stefano Garzarella --- qemu-img.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index e6ad5978e0..71c92f142a 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -37,6 +37,

Re: [Qemu-devel] [PATCH v2 2/2] drm/i915/gvt: export mdev device version to sysfs for Intel vGPU

2019-05-08 Thread Dr. David Alan Gilbert
* Yan Zhao (yan.y.z...@intel.com) wrote: > This feature implements the version attribute for Intel's vGPU mdev > devices. > > version attribute is rw. > It's used to check device compatibility for two mdev devices. > version string format and length are private for vendor driver. vendor > driver i

Re: [Qemu-devel] [PATCH v7 2/6] virtio-pmem: Add virtio pmem driver

2019-05-08 Thread Pankaj Gupta
> > On 4/25/19 10:00 PM, Pankaj Gupta wrote: > > > +void host_ack(struct virtqueue *vq) > > +{ > > + unsigned int len; > > + unsigned long flags; > > + struct virtio_pmem_request *req, *req_buf; > > + struct virtio_pmem *vpmem = vq->vdev->priv; > > + > > + spin_lock_irqsave(&vpmem->pm

Re: [Qemu-devel] [PATCH v2 09/16] hw/mips: Use object_initialize() on MIPSCPSState

2019-05-08 Thread Paolo Bonzini
On 07/05/19 11:34, Philippe Mathieu-Daudé wrote: > Initialize the MIPSCPSState with object_initialize() instead of > object_new(). This will allow us to add it as children of the > machine container. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/mips/boston.c | 25

Re: [Qemu-devel] [PATCH v2 13/16] hw/microblaze/zynqmp: Use object_initialize_child for correct ref. counting

2019-05-08 Thread Paolo Bonzini
On 07/05/19 11:34, Philippe Mathieu-Daudé wrote: > As explained in commit aff39be0ed97: > > Both functions, object_initialize() and object_property_add_child() > increase the reference counter of the new object, so one of the > references has to be dropped afterwards to get the reference >

Re: [Qemu-devel] [PATCH v2 04/16] hw/arm/bcm2835: Use TYPE_PL011 instead of hardcoded string

2019-05-08 Thread Paolo Bonzini
On 07/05/19 11:34, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/bcm2835_peripherals.c | 2 +- > include/hw/arm/bcm2835_peripherals.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm

Re: [Qemu-devel] [PATCH v2 11/16] hw/microblaze/zynqmp: Move the IPI state into the PMUSoC state

2019-05-08 Thread Paolo Bonzini
On 07/05/19 11:34, Philippe Mathieu-Daudé wrote: > The Inter Processor Interrupt is a block part of the SoC, not the > "machine" (talking about machine is borderline with the PMU, since > it is embedded into the ZynqMP SoC, but currentl QEMU doesn't > support multi-arch cores). > > Move the IPI st

Re: [Qemu-devel] [PATCH v2 10/16] hw/mips: Use object_initialize_child for correct reference counting

2019-05-08 Thread Paolo Bonzini
On 07/05/19 11:34, Philippe Mathieu-Daudé wrote: > As explained in commit aff39be0ed97: > > Both functions, object_initialize() and object_property_add_child() > increase the reference counter of the new object, so one of the > references has to be dropped afterwards to get the reference >

Re: [Qemu-devel] [PATCH v2 08/16] hw/arm: Use object_initialize_child for correct reference counting

2019-05-08 Thread Paolo Bonzini
On 07/05/19 11:34, Philippe Mathieu-Daudé wrote: > As explained in commit aff39be0ed97: > > Both functions, object_initialize() and object_property_add_child() > increase the reference counter of the new object, so one of the > references has to be dropped afterwards to get the reference >

Re: [Qemu-devel] [PATCH v2 07/16] hw/arm/aspeed: Use object_initialize_child for correct ref. counting

2019-05-08 Thread Paolo Bonzini
On 07/05/19 11:34, Philippe Mathieu-Daudé wrote: > As explained in commit aff39be0ed97: > > Both functions, object_initialize() and object_property_add_child() > increase the reference counter of the new object, so one of the > references has to be dropped afterwards to get the reference >

Re: [Qemu-devel] [PATCH v2 05/16] hw/arm/bcm2835: Use object_initialize() on PL011State

2019-05-08 Thread Paolo Bonzini
On 07/05/19 11:34, Philippe Mathieu-Daudé wrote: > To be coherent with the other peripherals contained in the > BCM2835PeripheralState structure, directly allocate the PL011State > (instead of using the pl011 uart as a pointer to a SysBusDevice). > > Initialize the PL011State with object_initializ

Re: [Qemu-devel] [PATCH v2 06/16] hw/arm/bcm2835: Use object_initialize_child for correct ref. counting

2019-05-08 Thread Paolo Bonzini
On 07/05/19 11:34, Philippe Mathieu-Daudé wrote: > As explained in commit aff39be0ed97: > > Both functions, object_initialize() and object_property_add_child() > increase the reference counter of the new object, so one of the > references has to be dropped afterwards to get the reference >

Re: [Qemu-devel] [PATCH v2 14/16] hw/microblaze/zynqmp: Use object_initialize_child for correct ref. counting

2019-05-08 Thread Paolo Bonzini
On 07/05/19 11:34, Philippe Mathieu-Daudé wrote: > As explained in commit aff39be0ed97: > > Both functions, object_initialize() and object_property_add_child() > increase the reference counter of the new object, so one of the > references has to be dropped afterwards to get the reference >

Re: [Qemu-devel] [PATCH v2 12/16] hw/microblaze/zynqmp: Let the SoC manage the IPI devices

2019-05-08 Thread Paolo Bonzini
On 07/05/19 11:34, Philippe Mathieu-Daudé wrote: > The Inter Processor Interrupt is a block part of the SoC, not the > "machine" (See Zynq UltraScale+ Device TRM UG1085, "Platform > Management Unit", Power Domains and Islands). > > Move the IPI management from the machine to the SoC. > > Signed-o

Re: [Qemu-devel] [PATCH v7 2/6] virtio-pmem: Add virtio pmem driver

2019-05-08 Thread Pankaj Gupta
Hi Dan, Thank you for the review. Please see my reply inline. > > Hi Pankaj, > > Some minor file placement comments below. Sure. > > On Thu, Apr 25, 2019 at 10:02 PM Pankaj Gupta wrote: > > > > This patch adds virtio-pmem driver for KVM guest. > > > > Guest reads the persistent memory ran

Re: [Qemu-devel] [PATCH v7 1/2] hw/arm: Add arm SBSA reference machine, skeleton part

2019-05-08 Thread Hongbo Zhang
On Tue, 30 Apr 2019 at 22:04, Peter Maydell wrote: > > On Thu, 18 Apr 2019 at 05:05, Hongbo Zhang wrote: > > > > For the Aarch64, there is one machine 'virt', it is primarily meant to > > run on KVM and execute virtualization workloads, but we need an > > environment as faithful as possible to ph

Re: [Qemu-devel] [PATCH v2 16/16] hw/intc/nvic: Use object_initialize_child for correct reference counting

2019-05-08 Thread Paolo Bonzini
On 07/05/19 11:34, Philippe Mathieu-Daudé wrote: > As explained in commit aff39be0ed97: > > Both functions, object_initialize() and object_property_add_child() > increase the reference counter of the new object, so one of the > references has to be dropped afterwards to get the reference >

Re: [Qemu-devel] [PATCH 0/3] acpi: More trace points

2019-05-08 Thread Markus Armbruster
Ping? Markus Armbruster writes: > I wrote these patches to help me debug an unplug failure. I expect > them to be helpful for others, too. > > Markus Armbruster (3): > acpi/piix4: Convert debug printf()s to trace events > acpi/pcihp: Convert debug printf()s to trace events > acpi/pcihp: A

Re: [Qemu-devel] [PATCH v2 15/16] hw/arm/mps2: Use object_initialize_child for correct reference counting

2019-05-08 Thread Paolo Bonzini
On 07/05/19 11:34, Philippe Mathieu-Daudé wrote: > As explained in commit aff39be0ed97: > > Both functions, object_initialize() and object_property_add_child() > increase the reference counter of the new object, so one of the > references has to be dropped afterwards to get the reference >

Re: [Qemu-devel] [PATCH v7 2/2] hw/arm: Add arm SBSA reference machine, devices part

2019-05-08 Thread Hongbo Zhang
On Tue, 30 Apr 2019 at 22:17, Peter Maydell wrote: > > On Thu, 18 Apr 2019 at 05:05, Hongbo Zhang wrote: > > > > Following the previous patch, this patch adds peripheral devices to the > > newly introduced SBSA-ref machine. > > > > Signed-off-by: Hongbo Zhang > > --- > > hw/arm/sbsa-ref.c | 451

Re: [Qemu-devel] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-08 Thread Yan Zhao
On Wed, May 08, 2019 at 05:18:26AM +0800, Alex Williamson wrote: > On Sun, 5 May 2019 21:49:04 -0400 > Yan Zhao wrote: > > > version attribute is used to check two mdev devices' compatibility. > > > > The key point of this version attribute is that it's rw. > > User space has no need to underst

Re: [Qemu-devel] [PATCH 00/11] kvm/migration: support KVM_CLEAR_DIRTY_LOG

2019-05-08 Thread Peter Xu
On Wed, May 08, 2019 at 12:09:00PM +0200, Paolo Bonzini wrote: > On 08/05/19 01:15, Peter Xu wrote: > > Design > > === > > > > I started with a naive/stupid design that I always pass all 1's to the > > KVM for a memory range to clear all the dirty bits within that memory > > range,

Re: [Qemu-devel] Use of PreallocMode in block drivers

2019-05-08 Thread Markus Armbruster
Stefano Garzarella writes: > On Tue, May 07, 2019 at 08:34:51AM +0200, Markus Armbruster wrote: >> Cc: Peter for a libvirt perspective. >> >> Stefano Garzarella writes: >> >> > This patch adds the support of preallocation (off/full) for the RBD >> > block driver. >> > If available, we use rbd_

Re: [Qemu-devel] [PATCH 00/11] kvm/migration: support KVM_CLEAR_DIRTY_LOG

2019-05-08 Thread Paolo Bonzini
On 08/05/19 06:39, Peter Xu wrote: >> The disadvantage of this is that you won't clear in the kernel those >> dirty bits that come from other sources (e.g. vhost or >> address_space_map). This can lead to double-copying of pages. >> >> Migration already makes a local copy in rb->bmap, and >> memor

Re: [Qemu-devel] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-08 Thread Yan Zhao
On Tue, May 07, 2019 at 05:19:54PM +0800, Cornelia Huck wrote: > On Sun, 5 May 2019 21:49:04 -0400 > Yan Zhao wrote: > > > version attribute is used to check two mdev devices' compatibility. > > > > The key point of this version attribute is that it's rw. > > User space has no need to understan

[Qemu-devel] [PATCH] qemu-iotests: Fix cleanup for 192

2019-05-08 Thread Kevin Wolf
Test case 192 calls _launch_qemu, so it also needs to _cleanup_qemu when it's done, otherwise the QMP FIFOs stay around in scratch/. It also creates a temporary NBD socket that needs to be removed as well at the end of the test case. Reported-by: Thomas Huth Signed-off-by: Kevin Wolf --- tests/

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix cleanup for 192

2019-05-08 Thread Thomas Huth
On 08/05/2019 14.04, Kevin Wolf wrote: > Test case 192 calls _launch_qemu, so it also needs to _cleanup_qemu when > it's done, otherwise the QMP FIFOs stay around in scratch/. It also > creates a temporary NBD socket that needs to be removed as well at the > end of the test case. > > Reported-by:

Re: [Qemu-devel] [PATCH v2 2/2] drm/i915/gvt: export mdev device version to sysfs for Intel vGPU

2019-05-08 Thread Yan Zhao
On Tue, May 07, 2019 at 05:27:53PM +0800, Cornelia Huck wrote: > On Sun, 5 May 2019 21:51:02 -0400 > Yan Zhao wrote: > > > This feature implements the version attribute for Intel's vGPU mdev > > devices. > > > > version attribute is rw. > > It's used to check device compatibility for two mdev d

Re: [Qemu-devel] [PATCH 0/2] blockjob: Fix coroutine thread after AioContext change

2019-05-08 Thread Kevin Wolf
Am 03.05.2019 um 19:17 hat Kevin Wolf geschrieben: > Kevin Wolf (2): > blockjob: Fix coroutine thread after AioContext change > test-block-iothread: Job coroutine thread after AioContext switch Applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH v2 2/2] drm/i915/gvt: export mdev device version to sysfs for Intel vGPU

2019-05-08 Thread Yan Zhao
On Wed, May 08, 2019 at 06:50:33PM +0800, Dr. David Alan Gilbert wrote: > * Yan Zhao (yan.y.z...@intel.com) wrote: > > This feature implements the version attribute for Intel's vGPU mdev > > devices. > > > > version attribute is rw. > > It's used to check device compatibility for two mdev devices.

Re: [Qemu-devel] [PATCH] hw/net/ne2000: Extract the PCI device from the chipset common code

2019-05-08 Thread Paolo Bonzini
On 04/05/19 07:35, Philippe Mathieu-Daudé wrote: > The ne2000.c file contains functions common the the ISA and PCI > devices. To allow to build with one or another, extract the PCI > specific part into a new file. > > This fix an issue where the NE2000_ISA Kconfig had to pull the > full PCI core o

Re: [Qemu-devel] [PATCH] qemu-img: Use IEC binary prefixes for size constants

2019-05-08 Thread Kevin Wolf
Am 08.05.2019 um 12:43 hat Stefano Garzarella geschrieben: > Using IEC binary prefixes in order to make the code more readable. > > Signed-off-by: Stefano Garzarella Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH v2 2/5] vdi: Replace bdrv_{read, write}() with bdrv_{pread, pwrite}()

2019-05-08 Thread Kevin Wolf
Am 06.05.2019 um 18:38 hat Vladimir Sementsov-Ogievskiy geschrieben: > 01.05.2019 21:13, Alberto Garcia wrote: > > There's only a couple of bdrv_read() and bdrv_write() calls left in > > the vdi code, and they can be trivially replaced with the byte-based > > bdrv_pread() and bdrv_pwrite(). > > >

Re: [Qemu-devel] [PATCH v2 0/5] Remove bdrv_read() and bdrv_write()

2019-05-08 Thread Kevin Wolf
Am 01.05.2019 um 20:13 hat Alberto Garcia geschrieben: > Hi, > > this API only had a few users left so it can be easily removed. Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] hw/timer: Compile devices not target-dependent as common objects

2019-05-08 Thread Paolo Bonzini
On 06/05/19 03:06, Philippe Mathieu-Daudé wrote: >> By the way, I was surprised to see TARGET_FMT_plx there, since I first >> thought that this would be a target-specific define, too. But apparently >> it is not. Very confusing. I'd suggest to rename that to HWADDR_FMT_plx >> instead, what do you t

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

2019-05-08 Thread Markus Armbruster
Eric Blake writes: > On 5/7/19 4:39 AM, Daniel P. Berrangé wrote: > >>> JSON is terrible at interoperability, so good luck with that. >>> >>> If you reduce your order to "the commonly used JSON libraries we know", >>> we can talk. >> >> I don't particularly want us to rely on semantics of small

Re: [Qemu-devel] qemu iotest 192 does not clean up correctly

2019-05-08 Thread Max Reitz
On 08.05.19 10:14, Thomas Huth wrote: > > I've ran into this failure today: > > 140 0s ... - output mismatch (see 140.out.bad) > --- /home/thuth/devel/qemu/tests/qemu-iotests/140.out 2019-05-07 > 17:57:08.0 +0200 > +++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/140.out.bad 2019-05-08

Re: [Qemu-devel] [PATCH 1/5] qemu-nbd: Add --pid-file option

2019-05-08 Thread Max Reitz
On 08.05.19 11:01, Daniel P. Berrangé wrote: > On Tue, May 07, 2019 at 08:36:06PM +0200, Max Reitz wrote: >> --fork is a bit boring if there is no way to get the child's PID. This >> option helps. >> >> Signed-off-by: Max Reitz >> --- >> qemu-nbd.c| 29 + >> qemu-

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

2019-05-08 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Eric Blake writes: > > > On 5/7/19 4:39 AM, Daniel P. Berrangé wrote: > > > >>> JSON is terrible at interoperability, so good luck with that. > >>> > >>> If you reduce your order to "the commonly used JSON libraries we know", > >>> we can talk. > >

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

2019-05-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, May 07, 2019 at 10:47:06AM +0200, Markus Armbruster wrote: > >> > The Golang JSON parser decodes JSON numbers to float64 by default so >> > will have this precision limitation too, though at least they provide >> > a backdoor for custom parsing from the origin

Re: [Qemu-devel] [PATCH v3 6/7] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run

2019-05-08 Thread Markus Armbruster
Eric Blake writes: > On 5/7/19 10:22 AM, Thomas Huth wrote: >> On 07/05/2019 15.22, Markus Armbruster wrote: >>> Thomas Huth writes: >>> Currently, all tests are in the "auto" group. This is a little bit pointless. OTOH, we need a group for the tests that we can automatically run

Re: [Qemu-devel] [PATCH] Deprecate Python 2 support

2019-05-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, May 07, 2019 at 12:38:14PM +0200, Kevin Wolf wrote: >> Am 03.05.2019 um 21:37 hat Eduardo Habkost geschrieben: >> > Python 2 will reach end of life in January 1 2020. Declare it as >> > deprecated. >> > >> > Signed-off-by: Eduardo Habkost >> > --- >> > con

Re: [Qemu-devel] [Question] Memory hotplug clarification for Qemu ARM/virt

2019-05-08 Thread Robin Murphy
Hi Shameer, On 08/05/2019 11:15, Shameerali Kolothum Thodi wrote: Hi, This series here[0] attempts to add support for PCDIMM in QEMU for ARM/Virt platform and has stumbled upon an issue as it is not clear(at least from Qemu/EDK2 point of view) how in physical world the hotpluggable memory is ha

[Qemu-devel] [PATCH] iotests: Clean up after 192

2019-05-08 Thread Max Reitz
This patch makes 192 clean up the qemu command FIFOs, the qemu PID file, and the NBD socket file. Reported by: Thomas Huth Signed-off-by: Max Reitz --- tests/qemu-iotests/192 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/192 b/tests/qemu-iotests/192 i

[Qemu-devel] [Bug 1828207] [NEW] Request to add something like "Auth failed from IP" log report for built-in VNC server

2019-05-08 Thread Druta Pavel via Qemu-devel
Public bug reported: In environment with needs of public accessible VNC ports there is no logs or other registered events about authentication failures to analyze and/or integrate it to automated services like fail2ban ans so on. Thus the built-in VNC service is vulnerable to brutforce attacks a

Re: [Qemu-devel] [PATCH] iotests: Clean up after 192

2019-05-08 Thread Thomas Huth
On 08/05/2019 14.55, Max Reitz wrote: > This patch makes 192 clean up the qemu command FIFOs, the qemu PID file, > and the NBD socket file. > > Reported by: Thomas Huth > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/192 | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff

Re: [Qemu-devel] [PATCH] iotests: Clean up after 192

2019-05-08 Thread Max Reitz
On 08.05.19 15:00, Thomas Huth wrote: > On 08/05/2019 14.55, Max Reitz wrote: >> This patch makes 192 clean up the qemu command FIFOs, the qemu PID file, >> and the NBD socket file. >> >> Reported by: Thomas Huth >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/192 | 4 +++- >> 1 file ch

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: Fix cleanup for 192

2019-05-08 Thread Max Reitz
On 08.05.19 14:04, Kevin Wolf wrote: > Test case 192 calls _launch_qemu, so it also needs to _cleanup_qemu when > it's done, otherwise the QMP FIFOs stay around in scratch/. It also > creates a temporary NBD socket that needs to be removed as well at the > end of the test case. > > Reported-by: Th

Re: [Qemu-devel] [PATCH] tests: Force Python I/O encoding for check-qapi-schema

2019-05-08 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, May 07, 2019 at 03:13:45PM +0100, Daniel P. Berrangé wrote: >> On Mon, May 06, 2019 at 06:38:17PM -0300, Eduardo Habkost wrote: >> > test-qapi.py doesn't force a specific encoding for stderr or >> > stdout, but the reference files used by check-qapi-schema are in

Re: [Qemu-devel] [PATCH 1/7] file-posix: Update open_flags in raw_set_perm()

2019-05-08 Thread Kevin Wolf
Am 06.05.2019 um 21:47 hat Max Reitz geschrieben: > raw_check_perm() + raw_set_perm() can change the flags associated with > the current FD. If so, we have to update BDRVRawState.open_flags > accordingly. Otherwise, we may keep reopening the FD even though the > current one already has the correc

Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-05-08 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Suraj Jitindar Singh writes: >> >> > Add a monitor command "dump-stack" to be used to dump the stack for the >> > current cpu. >> >> I guess this is just for debugging. Correct? >> >> Shouldn't this be "info

Re: [Qemu-devel] [PATCH v2] tests/Makefile: Remove unused test-obj-y variable

2019-05-08 Thread Markus Armbruster
Thomas Huth writes: > I recently noticed that test-obj-y contains a file called > tests/check-block-qtest.o which simply does not belong to any .c > file and thus wondered why this is not causing any trouble. It is > only used to add -Itests to the command line (which refers to the > build direct

  1   2   3   >