[Qemu-devel] [PULL 1/7] usb-mtp: fix string length for filename when writing metadata

2019-05-03 Thread Gerd Hoffmann
From: Daniel P. Berrangé The ObjectInfo 'length' field provides the length of the wide character string filename. This is then converted to a multi-byte character string. This may have a different byte count to the wide character string. We should use the C string length of the multi-byte string

[Qemu-devel] [PULL 7/7] hw/usb: avoid format truncation warning when formatting port name

2019-05-03 Thread Gerd Hoffmann
From: Daniel P. Berrangé hw/usb/hcd-xhci.c: In function ‘usb_xhci_realize’: hw/usb/hcd-xhci.c:3339:66: warning: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size 5 [-Wformat-trunca\ tion=] 3339 | snprintf(port->name, sizeof(port->name), "usb

[Qemu-devel] [PULL 0/7] Usb 20190503 v2 patches

2019-05-03 Thread Gerd Hoffmann
The following changes since commit f75d15231e56cb0f2bafe19faf1229c459a60731: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-04-30 17:06:57 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20190503-v2-pull-reques

[Qemu-devel] [PULL 4/7] usb/xhci: avoid trigger assertion if guest write wrong epid

2019-05-03 Thread Gerd Hoffmann
From: Longpeng we found the following core in our environment: 0 0x7fc6b06c2237 in raise () 1 0x7fc6b06c3928 in abort () 2 0x7fc6b06bb056 in __assert_fail_base () 3 0x7fc6b06bb102 in __assert_fail () 4 0x00702e36 in xhci_kick_ep (...) 5 0x0047897a in memory_r

[Qemu-devel] [PULL 6/7] hw/usb/hcd-ohci: Move PCI-related code into a separate file

2019-05-03 Thread Gerd Hoffmann
From: Thomas Huth Some machines (like the pxa2xx-based ARM machines) only have a sysbus OHCI controller, but no PCI. With the new Kconfig-style build system, it will soon be possible to create QEMU binaries that only contain such PCI-less machines. However, the two OHCI controllers, for sysbus an

[Qemu-devel] [PULL 2/7] usb-mtp: fix alignment of access of ObjectInfo filename field

2019-05-03 Thread Gerd Hoffmann
From: Daniel P. Berrangé The ObjectInfo struct's "filename" field is following a uint8_t field in a packed struct and thus has bad alignment for a 16-bit field. Switch the field to to uint8_t and use the helper function for accessing unaligned 16-bit data. Note that although the MTP spec specifi

Re: [Qemu-devel] [PATCH v3] hw/usb/hcd-xhci: Fix GCC 9 build warning

2019-05-03 Thread Laurent Vivier
On 03/05/2019 02:42, Alistair Francis wrote: > Fix this build warning with GCC 9 on Fedora 30: > hw/usb/hcd-xhci.c:3339:66: error: ‘%d’ directive output may be truncated > writing between 1 and 10 bytes into a region of size 5 > [-Werror=format-truncation=] > 3339 | snprintf(port->na

[Qemu-devel] [PULL 5/7] hw/usb/hcd-ohci: Do not use PCI functions with sysbus devices in ohci_die()

2019-05-03 Thread Gerd Hoffmann
From: Thomas Huth The ohci_die() function always assumes to be running with a PCI OHCI controller and calls the PCI-specific functions pci_set_word(). However, this function might also get called for the sysbus OHCI devices, so it likely fails in that case. To fix this issue, change the code now,

[Qemu-devel] [PATCH] tests/docker: add ubuntu 18.04

2019-05-03 Thread Gerd Hoffmann
Based on the ubuntu.docker file. Used to reproduce the build failure Peter was seeing. Others might find this useful too ;) Signed-off-by: Gerd Hoffmann --- tests/docker/dockerfiles/ubuntu1804.docker | 57 ++ 1 file changed, 57 insertions(+) create mode 100644 tests/docker/d

[Qemu-devel] [PULL 3/7] usb-mtp: change default to success for usb_mtp_update_object

2019-05-03 Thread Gerd Hoffmann
From: Bandan Das Commit c5ead51f90cf (usb-mtp: return incomplete transfer on a lstat failure) checks if lstat succeeded when updating attributes of a file. However, it also changed behavior to return an error by default. This is incorrect because for smaller file sizes, Qemu will attempt to write

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] hw/char/escc: Lower irq when transmit buffer is filled

2019-05-03 Thread Mark Cave-Ayland
On 02/05/2019 13:11, Philippe Mathieu-Daudé wrote: > On 5/2/19 11:04 AM, Laurent Vivier wrote: >> On 19/04/2019 17:40, Stephen Checkoway wrote: >>> The SCC/ESCC will briefly stop asserting an interrupt when the >>> transmit FIFO is filled. >>> >>> This code doesn't model the transmit FIFO/shift re

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] hw/char/escc: Lower irq when transmit buffer is filled

2019-05-03 Thread Laurent Vivier
On 03/05/2019 09:14, Mark Cave-Ayland wrote: > On 02/05/2019 13:11, Philippe Mathieu-Daudé wrote: > >> On 5/2/19 11:04 AM, Laurent Vivier wrote: >>> On 19/04/2019 17:40, Stephen Checkoway wrote: The SCC/ESCC will briefly stop asserting an interrupt when the transmit FIFO is filled.

Re: [Qemu-devel] [PATCH v2 1/3] leon3: add a little bootloader

2019-05-03 Thread Mark Cave-Ayland
On 25/04/2019 13:18, KONRAD Frederic wrote: > This adds a little bootloader to the leon3_machine when a ram image is > given through the kernel parameter and no bios are provided: > * The UART transmiter is enabled. > * The TIMER is initialized. > > Reviewed-by: Fabien Chouteau > Reviewed-by

Re: [Qemu-devel] [RFC] Virtio RNG: Consider changing the default entropy source to /dev/urandom?

2019-05-03 Thread Richard W.M. Jones
On Thu, May 02, 2019 at 08:02:01PM +0200, Kashyap Chamarthy wrote: > [Reviving this old thread as I don't think we came to a conclusion on > this.] I guess the best thing is to submit the obvious 1 line patch and see what people think about it? (I agree the default ought to be changed.) Rich. -

Re: [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly

2019-05-03 Thread Cornelia Huck
On Thu, 2 May 2019 17:55:16 +0200 Cornelia Huck wrote: > Coverity notes that the result of object_dynamic_cast() to > SCSIDevice is not checked in s390_gen_initial_iplp(); as > we know that we always have a SCSIDevice in that branch, > we can instead cast via SCSI_DEVICE directly. > > Coverity:

Re: [Qemu-devel] [PATCH v2 1/3] leon3: add a little bootloader

2019-05-03 Thread Mark Cave-Ayland
On 03/05/2019 08:53, Mark Cave-Ayland wrote: > On 25/04/2019 13:18, KONRAD Frederic wrote: > >> This adds a little bootloader to the leon3_machine when a ram image is >> given through the kernel parameter and no bios are provided: >> * The UART transmiter is enabled. >> * The TIMER is initial

Re: [Qemu-devel] [PATCH v2 3/3] MAINTAINERS: add myself for leon3

2019-05-03 Thread Mark Cave-Ayland
On 25/04/2019 13:18, KONRAD Frederic wrote: > Reviewed-by: Fabien Chouteau > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: KONRAD Frederic > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 23db6f8..6f7d237 100644 > --- a/MAIN

Re: [Qemu-devel] [PATCH v2 2/3] leon3: introduce the plug and play mecanism

2019-05-03 Thread Mark Cave-Ayland
On 25/04/2019 13:18, KONRAD Frederic wrote: > This adds the AHB and APB plug and play devices. > They are scanned during the linux boot to discover the various peripheral. > > Reviewed-by: Fabien Chouteau > Signed-off-by: KONRAD Frederic > --- > hw/misc/Makefile.objs | 2 + > h

Re: [Qemu-devel] [PATCH v2] security.rst: add Security Guide to developer docs

2019-05-03 Thread Stefano Garzarella
On Thu, Apr 25, 2019 at 02:35:03PM +0100, Stefan Hajnoczi wrote: > At KVM Forum 2018 I gave a presentation on security in QEMU: > https://www.youtube.com/watch?v=YAdRf_hwxU8 (video) > https://vmsplice.net/~stefan/stefanha-kvm-forum-2018.pdf (slides) > > This patch adds a security guide to the deve

Re: [Qemu-devel] [PATCH v2 1/3] leon3: add a little bootloader

2019-05-03 Thread KONRAD Frederic
Hi Mark, } I think this patch is basically okay, however if you don't supply both a kernel and bios then you get the slightly enigmatic message below: $ ./qemu-system-sparc -M leon3_generic qemu-system-sparc: Can't read bios image (null) Perhaps add a define for LEON3_BIOS_FILENAME an

Re: [Qemu-devel] [PATCH v2 0/3] Leon3 patches

2019-05-03 Thread Mark Cave-Ayland
On 25/04/2019 13:18, KONRAD Frederic wrote: > Hi all, > > Those are some little fixes for the leon3 machine: > * The first part initializes the uart and the timer when no bios are > provided. > * The second part adds AHB and APB plug and play devices to allow to boot > linux. > * Th

Re: [Qemu-devel] [PATCH v2 2/3] leon3: introduce the plug and play mecanism

2019-05-03 Thread KONRAD Frederic
Le 5/3/19 à 10:09 AM, Mark Cave-Ayland a écrit : On 25/04/2019 13:18, KONRAD Frederic wrote: This adds the AHB and APB plug and play devices. They are scanned during the linux boot to discover the various peripheral. Reviewed-by: Fabien Chouteau Signed-off-by: KONRAD Frederic --- hw/mis

Re: [Qemu-devel] [PATCH v2 1/3] leon3: add a little bootloader

2019-05-03 Thread Mark Cave-Ayland
On 03/05/2019 09:18, KONRAD Frederic wrote: > Hi Mark, >   } >>> >>> I think this patch is basically okay, however if you don't supply both a >>> kernel and >>> bios then you get the slightly enigmatic message below: >>> >>> $ ./qemu-system-sparc -M leon3_generic >>> qemu-system-sparc:

[Qemu-devel] [PATCH v2 1/2] configure: set source_path only once and make its definition more robust

2019-05-03 Thread Antonio Ospite
From: Antonio Ospite Since commit 79d77bcd36 (configure: Remove --source-path option, 2019-04-29) source_path cannot be overridden anymore, move it out of the "default parameters" block since the word "default" may suggest that the value can change, while in fact it does not. While at it, only s

[Qemu-devel] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path

2019-05-03 Thread Antonio Ospite
From: Antonio Ospite The configure script breaks when the qemu source directory is in a path containing white spaces, in particular the list of targets is not correctly generated when calling "./configure --help" because of how the default_target_list variable is built. In addition to that, *bui

[Qemu-devel] [PATCH v2 0/2] configure: disallow spaces and colons in source path and build path

2019-05-03 Thread Antonio Ospite
Hi, Here is a v2 patch set to address https://bugs.launchpad.net/qemu/+bug/1817345 The series follows up to: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05290.html https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05573.html Changes since v1: - Add a preparatory patch to se

Re: [Qemu-devel] [PATCH v2 2/3] leon3: introduce the plug and play mecanism

2019-05-03 Thread Mark Cave-Ayland
On 03/05/2019 09:24, KONRAD Frederic wrote: > Le 5/3/19 à 10:09 AM, Mark Cave-Ayland a écrit : >> On 25/04/2019 13:18, KONRAD Frederic wrote: >> >>> This adds the AHB and APB plug and play devices. >>> They are scanned during the linux boot to discover the various peripheral. >>> >>> Reviewed-by:

Re: [Qemu-devel] [PATCH v2 0/3] Leon3 patches

2019-05-03 Thread KONRAD Frederic
Le 5/3/19 à 10:19 AM, Mark Cave-Ayland a écrit : On 25/04/2019 13:18, KONRAD Frederic wrote: Hi all, Those are some little fixes for the leon3 machine: * The first part initializes the uart and the timer when no bios are provided. * The second part adds AHB and APB plug and play

[Qemu-devel] [PATCH v3] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log

2019-05-03 Thread Boxuan Li
Use traces for debug message and qemu_log_mask for errors. Signed-off-by: Boxuan Li --- v1: https://patchew.org/QEMU/20190428110258.86681-1-libox...@connect.hku.hk/ v2: https://patchew.org/QEMU/20190501081039.58938-1-libox...@connect.hku.hk/ v3: Use qemu_log_mask for errors --- hw/virtio/trace-e

Re: [Qemu-devel] [PATCH v3] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log

2019-05-03 Thread Alex Bennée
Boxuan Li writes: > Use traces for debug message and qemu_log_mask for errors. > > Signed-off-by: Boxuan Li Reviewed-by: Alex Bennée > --- > v1: https://patchew.org/QEMU/20190428110258.86681-1-libox...@connect.hku.hk/ > v2: https://patchew.org/QEMU/20190501081039.58938-1-libox...@connect.hk

Re: [Qemu-devel] [PATCH v3 2/4] qga: Fix mingw compilation warnings on enum conversion

2019-05-03 Thread Philippe Mathieu-Daudé
On 5/3/19 2:25 AM, Cao Jiaxi wrote: > The win2qemu[] is supposed to be the conversion table to convert between > STORAGE_BUS_TYPE in Windows SDK and GuestDiskBusType in qga. > > But it was incorrectly written that it forces to set a GuestDiskBusType > value to STORAGE_BUS_TYPE, which generates an

Re: [Qemu-devel] [PATCH v2] security.rst: add Security Guide to developer docs

2019-05-03 Thread Alex Bennée
Stefan Hajnoczi writes: > At KVM Forum 2018 I gave a presentation on security in QEMU: > https://www.youtube.com/watch?v=YAdRf_hwxU8 (video) > https://vmsplice.net/~stefan/stefanha-kvm-forum-2018.pdf (slides) > > This patch adds a security guide to the developer docs. This document > covers th

Re: [Qemu-devel] [PATCH v3 3/4] util/cacheinfo: Use uint64_t on LLP64 model to satisfy Windows ARM64

2019-05-03 Thread Philippe Mathieu-Daudé
On 5/3/19 2:29 AM, Cao Jiaxi wrote: > Windows ARM64 uses LLP64 model, which breaks current assumptions. > > Signed-off-by: Cao Jiaxi > --- > util/cacheinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/cacheinfo.c b/util/cacheinfo.c > index 3cd080b83d..eebe1ce9

Re: [Qemu-devel] [PATCH v3 3/3] edu: uses uint64_t in dma operation

2019-05-03 Thread Jiri Slaby
On 22. 04. 19, 16:11, Li Qiang wrote: > The dma related variable dma.dst/src/cnt is dma_addr_t, it is > uint64_t in x64 platform. Change these usage from uint32_to > uint64_t to avoid trancation in edu_dma_timer. > > Signed-off-by: Li Qiang > Reviewed-by: Philippe Mathieu-Daude > --- > hw/misc/

Re: [Qemu-devel] [PATCH v3] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log

2019-05-03 Thread Philippe Mathieu-Daudé
Hi Li, On 5/3/19 10:46 AM, Boxuan Li wrote: > Use traces for debug message and qemu_log_mask for errors. > > Signed-off-by: Boxuan Li > --- > v1: https://patchew.org/QEMU/20190428110258.86681-1-libox...@connect.hku.hk/ > v2: https://patchew.org/QEMU/20190501081039.58938-1-libox...@connect.hku.hk

Re: [Qemu-devel] [PATCH v3 2/3] edu: mmio: allow 64-bit access in read dispatch

2019-05-03 Thread Jiri Slaby
On 22. 04. 19, 16:11, Li Qiang wrote: > The edu spec says when address >= 0x80, the MMIO area can > be accessed by 64-bit. > > Signed-off-by: Li Qiang > --- > Change since v2: > Fix an error per Phillippe's advice > > hw/misc/edu.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH v3 3/3] edu: uses uint64_t in dma operation

2019-05-03 Thread Philippe Mathieu-Daudé
On 5/3/19 11:12 AM, Jiri Slaby wrote: > On 22. 04. 19, 16:11, Li Qiang wrote: >> The dma related variable dma.dst/src/cnt is dma_addr_t, it is >> uint64_t in x64 platform. Change these usage from uint32_to >> uint64_t to avoid trancation in edu_dma_timer. Here I suggested fix the typo with "to avo

[Qemu-devel] [PULL 2/2] tests/uefi-boot-images: report the SMBIOS entry point structures

2019-05-03 Thread Laszlo Ersek
Rebuild the "bios-tables-test" UEFI boot images with the SMBIOS entry point reporting that has been added in the previous patch. Cc: "Philippe Mathieu-Daudé" Cc: Igor Mammedov Launchpad: https://bugs.launchpad.net/qemu/+bug/1821884 Signed-off-by: Laszlo Ersek Tested-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL 1/2] tests/uefi-test-tools: report the SMBIOS entry point structures

2019-05-03 Thread Laszlo Ersek
On UEFI systems, the SMBIOS entry point (a.k.a. anchor) structures are found similarly to the ACPI RSD PTR table(s): by scanning the ConfigurationTable array in the EFI system table for well-known GUIDs. Locate the SMBIOS 2.1 (32-bit) and 3.0 (64-bit) anchors in the BiosTablesTest UEFI application

Re: [Qemu-devel] [PATCH v3] hw/usb/hcd-xhci: Fix GCC 9 build warning

2019-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2019 at 12:42:04AM +, Alistair Francis wrote: > Fix this build warning with GCC 9 on Fedora 30: > hw/usb/hcd-xhci.c:3339:66: error: ‘%d’ directive output may be truncated > writing between 1 and 10 bytes into a region of size 5 > [-Werror=format-truncation=] > 3339 |

[Qemu-devel] [PULL 0/2] tests/uefi-test-tools: report the SMBIOS entry point structures

2019-05-03 Thread Laszlo Ersek
No changes relative to the original posting at <20190425104326.12835-1-lersek@redhat.com">http://mid.mail-archive.com/20190425104326.12835-1-lersek@redhat.com>, except for picking up the review/testing tags (also noted separately on each patch). Cc: "Philippe Mathieu-Daudé" Cc: Igor Mammedov Th

Re: [Qemu-devel] [PATCH] s390-bios: Skip bootmap signature entries

2019-05-03 Thread Thomas Huth
On 29/04/2019 15.09, Jason J. Herne wrote: > Newer versions of zipl have the ability to write signature entries to the boot > script for secure boot. We don't yet support secure boot, but we need to skip > over signature entries while reading the boot script in order to maintain our > ability to bo

Re: [Qemu-devel] [PULL 0/8] qtest and misc patches

2019-05-03 Thread Peter Maydell
On Thu, 2 May 2019 at 17:13, Thomas Huth wrote: > > Hi Peter, > > the following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df: > > Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' > into staging (2019-05-02 12:04:51 +0100) > > are available in the Git rep

[Qemu-devel] [PATCH] qcow2: Assert that host cluster offsets fit in L2 table entries

2019-05-03 Thread Alberto Garcia
The standard cluster descriptor in L2 table entries has a field to store the host cluster offset. When we need to get that offset from an entry we use L2E_OFFSET_MASK to ensure that we only use the bits that belong to that field. But while that mask is used every time we read from an L2 entry, it

[Qemu-devel] [Bug 1821884] Re: Extend uefi-test-tools to report SMBIOS location

2019-05-03 Thread Laszlo Ersek (Red Hat)
Posted [PULL 0/2] tests/uefi-test-tools: report the SMBIOS entry point structures 20190503093118.15700-1-lersek@redhat.com">http://mid.mail-archive.com/20190503093118.15700-1-lersek@redhat.com -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [PATCH v3] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log

2019-05-03 Thread LI, BO XUAN
Gotcha, thanks for the tip! I'll resend updated patch soon. On Fri, May 3, 2019 at 5:12 PM Philippe Mathieu-Daudé wrote: > Hi Li, > > On 5/3/19 10:46 AM, Boxuan Li wrote: > > Use traces for debug message and qemu_log_mask for errors. > > > > Signed-off-by: Boxuan Li > > --- > > v1: > https://pa

Re: [Qemu-devel] [PATCH v3 7/7] tests: Run the iotests during "make check" again

2019-05-03 Thread Alex Bennée
Thomas Huth writes: > People often forget to run the iotests before submitting patches or > pull requests - this is likely due to the fact that we do not run the > tests during our mandatory "make check" tests yet. Now that we've got > a proper "auto" group of iotests that should be fine to run

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-03 Thread Jakub Jermar
Hi, On 4/23/19 4:58 PM, Jakub Jermar wrote: > Hi Philippe! > > On 4/23/19 3:48 PM, Philippe Mathieu-Daudé wrote: >> Hi Jakub, >> >> On 4/23/19 1:00 PM, Jakub Jermář wrote: >>> This commit addresses QEMU Bug #1825311: >>> >>> mips_cpu_handle_mmu_fault renders all accessed pages executable >>> >>

Re: [Qemu-devel] [PATCH v3 7/7] tests: Run the iotests during "make check" again

2019-05-03 Thread Thomas Huth
On 03/05/2019 11.53, Alex Bennée wrote: > > Thomas Huth writes: > >> People often forget to run the iotests before submitting patches or >> pull requests - this is likely due to the fact that we do not run the >> tests during our mandatory "make check" tests yet. Now that we've got >> a proper "

Re: [Qemu-devel] [PATCH v2] security.rst: add Security Guide to developer docs

2019-05-03 Thread Philippe Mathieu-Daudé
On 5/3/19 11:04 AM, Alex Bennée wrote: > > Stefan Hajnoczi writes: > >> At KVM Forum 2018 I gave a presentation on security in QEMU: >> https://www.youtube.com/watch?v=YAdRf_hwxU8 (video) >> https://vmsplice.net/~stefan/stefanha-kvm-forum-2018.pdf (slides) >> >> This patch adds a security guide

Re: [Qemu-devel] [PATCH v3 4/4] osdep: Fix mingw compilation regarding stdio formats

2019-05-03 Thread Philippe Mathieu-Daudé
On 5/3/19 2:31 AM, Cao Jiaxi wrote: > I encountered the following compilation error on mingw: > > /mnt/d/qemu/include/qemu/osdep.h:97:9: error: '__USE_MINGW_ANSI_STDIO' macro > redefined [-Werror,-Wmacro-redefined] > #define __USE_MINGW_ANSI_STDIO 1 > ^ > /mnt/d/llvm-mingw/aarch64-w64-mi

Re: [Qemu-devel] [PATCH v3 0/4] Initial Windows on ARM (AArch64 64-Bit) host support

2019-05-03 Thread Philippe Mathieu-Daudé
On 5/3/19 2:22 AM, Cao Jiaxi wrote: > Initial Windows on ARM (AArch64 64-Bit) host support > > This series of patches is for initial support of Windows 10 on ARM as a QEMU > host. > Currently only TCG intepreter is working correctly, it crashes when TCG JIT > is enabled. > > For now we assume i

Re: [Qemu-devel] [PATCH v2] security.rst: add Security Guide to developer docs

2019-05-03 Thread Daniel P . Berrangé
On Thu, Apr 25, 2019 at 02:35:03PM +0100, Stefan Hajnoczi wrote: > At KVM Forum 2018 I gave a presentation on security in QEMU: > https://www.youtube.com/watch?v=YAdRf_hwxU8 (video) > https://vmsplice.net/~stefan/stefanha-kvm-forum-2018.pdf (slides) > > This patch adds a security guide to the deve

Re: [Qemu-devel] [PATCH v2] security.rst: add Security Guide to developer docs

2019-05-03 Thread Peter Maydell
On Fri, 3 May 2019 at 11:19, Daniel P. Berrangé wrote: > Everything above here is useful to QEMU devs, app devs & end users and > should be made part of the main QEMU doc - convert it to texi and @include > it from qemu-doc.texi, as we do for other stuff under docs/ If we convert it to texi we'll

Re: [Qemu-devel] [PATCH] linux-user: elf: Map empty PT_LOAD sections

2019-05-03 Thread Giuseppe Musacchio
Friendly inactivity ping. On Thu, 18 Apr 2019 at 17:42, Giuseppe Musacchio wrote: > > Some PT_LOAD sections may be completely zeroed out and their p_filesize > is zero, in that case the loader should just allocate a page that's at > least p_memsz bytes large (plus eventual alignment padding). > >

Re: [Qemu-devel] [PULL 00/13] Trivial branch patches

2019-05-03 Thread Peter Maydell
On Thu, 2 May 2019 at 19:58, Laurent Vivier wrote: > > The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df: > > Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' > into staging (2019-05-02 12:04:51 +0100) > > are available in the Git repository at:

Re: [Qemu-devel] [PATCH v2] security.rst: add Security Guide to developer docs

2019-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2019 at 11:28:53AM +0100, Peter Maydell wrote: > On Fri, 3 May 2019 at 11:19, Daniel P. Berrangé wrote: > > Everything above here is useful to QEMU devs, app devs & end users and > > should be made part of the main QEMU doc - convert it to texi and @include > > it from qemu-doc.tex

Re: [Qemu-devel] [PULL 00/13] Trivial branch patches

2019-05-03 Thread Laurent Vivier
On 03/05/2019 12:34, Peter Maydell wrote: > On Thu, 2 May 2019 at 19:58, Laurent Vivier wrote: >> >> The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df: >> >> Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' >> into staging (2019-05-02 12:04:51 +0

[Qemu-devel] [PATCH] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-05-03 Thread Stefano Garzarella
This patch allows 'qemu-img info' to show the 'disk size' for rbd images. We use the rbd_diff_iterate2() API to calculate the allocated size for the image. Signed-off-by: Stefano Garzarella --- block/rbd.c | 33 + 1 file changed, 33 insertions(+) diff --git a/blo

Re: [Qemu-devel] [PULL 00/13] Trivial branch patches

2019-05-03 Thread Alex Bennée
Peter Maydell writes: > On Thu, 2 May 2019 at 19:58, Laurent Vivier wrote: >> >> The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df: >> >> Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' >> into staging (2019-05-02 12:04:51 +0100) >> >> are a

[Qemu-devel] [PULL v2 00/12] Trivial branch patches

2019-05-03 Thread Laurent Vivier
The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df: Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-05-02 12:04:51 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/trivial-branch-pull-req

[Qemu-devel] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code

2019-05-03 Thread Laurent Vivier
From: Wei Yang We didn't specify the indent rule for multiline code here, which may mislead users. And in current code, the code use various styles. Add this rule in CODING_STYLE to make sure this is clear to every one. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov Reviewed-by: Igor Mam

[Qemu-devel] [PULL v2 03/12] CODING_STYLE: indent example code as all others

2019-05-03 Thread Laurent Vivier
From: Wei Yang All the example code are indented with four spaces except this one. Fix this by adding four spaces here. Signed-off-by: Wei Yang Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Reviewed-by: Stefano Garzarella Message-Id: <20190304071631

[Qemu-devel] [PULL v2 00/12] Trivial branch patches

2019-05-03 Thread Laurent Vivier
The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df: Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-05-02 12:04:51 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/trivial-branch-pull-req

[Qemu-devel] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf

2019-05-03 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Avoid to clutter stdout until explicitly requested (with -d guest_errors): $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta Bad SWSTYLE=0x04 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20190311102712.8572-1-p

[Qemu-devel] [PULL v2 07/12] Update configure

2019-05-03 Thread Laurent Vivier
From: Stefan Weil The last *.aml file was removed in commit 13b1881aacc7e5018773bd545bbaf8d5476699ee. Signed-off-by: Stefan Weil Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190409053320.14612-1...@weilnetz.de> Signed-off-by: Laurent Vivier --- configure |

[Qemu-devel] [PULL v2 04/12] doc: fix the configuration path

2019-05-03 Thread Laurent Vivier
From: Marc-André Lureau Use a CONFDIR variable to show the configured sysconf path in the generated documentations (html, man pages etc). Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1644985 Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <201811261

[Qemu-devel] [PULL v2 06/12] configure: fix pam test warning

2019-05-03 Thread Laurent Vivier
From: "Dr. David Alan Gilbert" The pam test generates a warning on Fedora 29 with -O3 compilation because the headers declare that the pam_conversation pointer to pam_start must be non-NULL. Change it to use the same 0 initialised structure as we actually use in qauthz. Signed-off-by: Dr. David

[Qemu-devel] [PULL v2 07/12] Update configure

2019-05-03 Thread Laurent Vivier
From: Stefan Weil The last *.aml file was removed in commit 13b1881aacc7e5018773bd545bbaf8d5476699ee. Signed-off-by: Stefan Weil Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190409053320.14612-1...@weilnetz.de> Signed-off-by: Laurent Vivier --- configure |

[Qemu-devel] [PULL v2 06/12] configure: fix pam test warning

2019-05-03 Thread Laurent Vivier
From: "Dr. David Alan Gilbert" The pam test generates a warning on Fedora 29 with -O3 compilation because the headers declare that the pam_conversation pointer to pam_start must be non-NULL. Change it to use the same 0 initialised structure as we actually use in qauthz. Signed-off-by: Dr. David

[Qemu-devel] [PULL v2 06/12] configure: fix pam test warning

2019-05-03 Thread Laurent Vivier
From: "Dr. David Alan Gilbert" The pam test generates a warning on Fedora 29 with -O3 compilation because the headers declare that the pam_conversation pointer to pam_start must be non-NULL. Change it to use the same 0 initialised structure as we actually use in qauthz. Signed-off-by: Dr. David

[Qemu-devel] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf

2019-05-03 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Avoid to clutter stdout until explicitly requested (with -d guest_errors): $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta Bad SWSTYLE=0x04 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20190311102712.8572-1-p

[Qemu-devel] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv

2019-05-03 Thread Laurent Vivier
From: Wei Yang Function object_new_with_propv already get the Type of the object, so we could leverage object_new_with_type here. Signed-off-by: Wei Yang Reviewed-by: Marc-André Lureau Reviewed-by: Stefano Garzarella Message-Id: <20190311083234.20841-1-richardw.y...@linux.intel.com> Signed-of

[Qemu-devel] [PULL v2 04/12] doc: fix the configuration path

2019-05-03 Thread Laurent Vivier
From: Marc-André Lureau Use a CONFDIR variable to show the configured sysconf path in the generated documentations (html, man pages etc). Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1644985 Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <201811261

[Qemu-devel] [PULL v2 07/12] Update configure

2019-05-03 Thread Laurent Vivier
From: Stefan Weil The last *.aml file was removed in commit 13b1881aacc7e5018773bd545bbaf8d5476699ee. Signed-off-by: Stefan Weil Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190409053320.14612-1...@weilnetz.de> Signed-off-by: Laurent Vivier --- configure |

[Qemu-devel] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code

2019-05-03 Thread Laurent Vivier
From: Wei Yang We didn't specify the indent rule for multiline code here, which may mislead users. And in current code, the code use various styles. Add this rule in CODING_STYLE to make sure this is clear to every one. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov Reviewed-by: Igor Mam

Re: [Qemu-devel] [PULL v2 00/12] Trivial branch patches

2019-05-03 Thread Laurent Vivier
On 03/05/2019 13:18, Laurent Vivier wrote: > The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df: > > Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' > into staging (2019-05-02 12:04:51 +0100) > > are available in the Git repository at: > > gi

[Qemu-devel] [PULL v2 03/12] CODING_STYLE: indent example code as all others

2019-05-03 Thread Laurent Vivier
From: Wei Yang All the example code are indented with four spaces except this one. Fix this by adding four spaces here. Signed-off-by: Wei Yang Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Reviewed-by: Stefano Garzarella Message-Id: <20190304071631

[Qemu-devel] [PULL v2 03/12] CODING_STYLE: indent example code as all others

2019-05-03 Thread Laurent Vivier
From: Wei Yang All the example code are indented with four spaces except this one. Fix this by adding four spaces here. Signed-off-by: Wei Yang Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Reviewed-by: Stefano Garzarella Message-Id: <20190304071631

[Qemu-devel] [PULL v2 08/12] Header cleanups

2019-05-03 Thread Laurent Vivier
From: Aruna Jayasena Removed unwanted includes from cpu-common.h This task was under https://wiki.qemu.org/Contribute/BiteSizedTasks Signed-off-by: Aruna Jayasena Reviewed-by: Peter Maydell Reviewed-by: Thomas Huth Message-Id: <20190409155635.10276-1-aruna...@cse.mrt.ac.lk> [lv: fix conflict

[Qemu-devel] [PULL v2 00/12] Trivial branch patches

2019-05-03 Thread Laurent Vivier
The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df: Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-05-02 12:04:51 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/trivial-branch-pull-req

Re: [Qemu-devel] [PULL v2 00/12] Trivial branch patches

2019-05-03 Thread Laurent Vivier
On 03/05/2019 13:19, Laurent Vivier wrote: > The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df: > > Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' > into staging (2019-05-02 12:04:51 +0100) > > are available in the Git repository at: > > gi

[Qemu-devel] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf

2019-05-03 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Avoid to clutter stdout until explicitly requested (with -d guest_errors): $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta Bad SWSTYLE=0x04 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20190311102712.8572-1-p

[Qemu-devel] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code

2019-05-03 Thread Laurent Vivier
From: Wei Yang We didn't specify the indent rule for multiline code here, which may mislead users. And in current code, the code use various styles. Add this rule in CODING_STYLE to make sure this is clear to every one. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov Reviewed-by: Igor Mam

[Qemu-devel] [PULL v2 04/12] doc: fix the configuration path

2019-05-03 Thread Laurent Vivier
From: Marc-André Lureau Use a CONFDIR variable to show the configured sysconf path in the generated documentations (html, man pages etc). Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1644985 Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <201811261

[Qemu-devel] [PULL v2 11/12] hw/sparc/leon3: Allow load of uImage firmwares

2019-05-03 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Currently the Leon3 machine doesn't allow to load legacy u-boot images: $ qemu-system-sparc -M leon3_generic -d in_asm \ -kernel HelenOS-0.6.0-sparc32-leon3.bin qemu-system-sparc: could not load kernel 'HelenOS-0.6.0-sparc32-leon3.bin' $ file HelenOS-0.6

[Qemu-devel] [PULL v2 12/12] sockets: avoid string truncation warnings when copying UNIX path

2019-05-03 Thread Laurent Vivier
From: Daniel P. Berrangé In file included from /usr/include/string.h:494, from include/qemu/osdep.h:101, from util/qemu-sockets.c:18: In function ‘strncpy’, inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5: /usr/include/bits/string_fortif

[Qemu-devel] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv

2019-05-03 Thread Laurent Vivier
From: Wei Yang Function object_new_with_propv already get the Type of the object, so we could leverage object_new_with_type here. Signed-off-by: Wei Yang Reviewed-by: Marc-André Lureau Reviewed-by: Stefano Garzarella Message-Id: <20190311083234.20841-1-richardw.y...@linux.intel.com> Signed-of

[Qemu-devel] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv

2019-05-03 Thread Laurent Vivier
From: Wei Yang Function object_new_with_propv already get the Type of the object, so we could leverage object_new_with_type here. Signed-off-by: Wei Yang Reviewed-by: Marc-André Lureau Reviewed-by: Stefano Garzarella Message-Id: <20190311083234.20841-1-richardw.y...@linux.intel.com> Signed-of

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] hw/char/escc: Lower irq when transmit buffer is filled

2019-05-03 Thread Mark Cave-Ayland
On 03/05/2019 08:21, Laurent Vivier wrote: >>> Mark, Artyom, are you OK with this patch? >> >> I started testing this with my OpenBIOS test images at the start of the >> week, but >> unfortunately got distracted by real life :) >> >> I've now finished and confirmed there are no regressions in my

[Qemu-devel] [PULL v2 10/12] Makefile: Let the 'clean' rule remove qemu-ga.exe on Windows hosts

2019-05-03 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Commit 48ff7a625b36 added the QEMU Guest Agent tool with the optional ".exe" suffix for Windows hosts, but forgot to use this suffix in the 'clean' rule. Calling this rule let a dangling executable in the build directory. Correct this by using the proper optional suff

[Qemu-devel] [PULL v2 09/12] net: Print output of "-net nic, model=help" to stdout instead of stderr

2019-05-03 Thread Laurent Vivier
From: Thomas Huth We are printing all other help output to stdout already (e.g. "-help", "-cpu help" and "-machine help" output). So the "-net nic,model=help" output should go to stdout instead of stderr, too. And while we're at it, also print the NICs line by line, like we do it e.g. with the "-

Re: [Qemu-devel] [PATCH v2] vmdk: Set vmdk parent backing_format to vmdk

2019-05-03 Thread Thomas Huth
Hi Sam, On 02/05/2019 15.08, Sam Eiderman wrote: > Commit b69864e ("vmdk: Support version=3 in VMDK descriptor files") > fixed the probe function to correctly guess vmdk descriptors with > version=3. > > This solves the issue where vmdk snapshot with parent vmdk descriptor > containing "version=

[Qemu-devel] Request for comment - dynamic VNC keyboard mapping

2019-05-03 Thread Mario
Hi all, I have a question related to the VNC server keyboard settings. Currently the user of qemu has to decide before VM startup which language is used for VNC keyboard mapping. If no keyboard is configured, the en-us keyboard will be loaded for keysym to scancode conversion. A later reconfigu

Re: [Qemu-devel] [PATCH] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-05-03 Thread Jason Dillaman
On Fri, May 3, 2019 at 7:02 AM Stefano Garzarella wrote: > > This patch allows 'qemu-img info' to show the 'disk size' for > rbd images. We use the rbd_diff_iterate2() API to calculate the > allocated size for the image. > > Signed-off-by: Stefano Garzarella > --- > block/rbd.c | 33

Re: [Qemu-devel] [PATCH] linux-user: elf: Map empty PT_LOAD sections

2019-05-03 Thread Peter Maydell
On Thu, 18 Apr 2019 at 17:46, Giuseppe Musacchio wrote: > > Some PT_LOAD sections may be completely zeroed out and their p_filesize > is zero, in that case the loader should just allocate a page that's at > least p_memsz bytes large (plus eventual alignment padding). Thanks for this patch -- code

[Qemu-devel] [PATCH v2] target/arm: Stop using variable length array in dc_zva

2019-05-03 Thread Peter Maydell
Currently the dc_zva helper function uses a variable length array. In fact we know (as the comment above remarks) that the length of this array is bounded because the architecture limits the block size and QEMU limits the target page size. Use a fixed array size and assert that we don't run off it.

Re: [Qemu-devel] Request for comment - dynamic VNC keyboard mapping

2019-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2019 at 01:47:15PM +0200, Mario wrote: > Hi all, > > I have a question related to the VNC server keyboard settings. Currently > the user of qemu has to decide before VM startup which language is used > for VNC keyboard mapping. If no keyboard is configured, the en-us keyboard > wil

Re: [Qemu-devel] [PATCH] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-05-03 Thread Stefano Garzarella
On Fri, May 03, 2019 at 07:55:01AM -0400, Jason Dillaman wrote: > On Fri, May 3, 2019 at 7:02 AM Stefano Garzarella wrote: > > > > This patch allows 'qemu-img info' to show the 'disk size' for > > rbd images. We use the rbd_diff_iterate2() API to calculate the > > allocated size for the image. > >

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-05-03 Thread Peter Maydell
On Mon, 25 Mar 2019 at 10:25, Peter Maydell wrote: > > On Mon, 18 Mar 2019 at 15:59, Alex Bennée wrote: > > > > > > Peter Maydell writes: [...] > > > Support this by making kvm_arch_put_registers() synchronize > > > CPU state back into the list. We sync only those registers > > > where the initi

  1   2   3   >