[Qemu-devel] [PATCH v2 10/29] tcg: Add tcg_out_dupm_vec to the backend interface

2019-04-30 Thread Richard Henderson
Currently stubbed out in all backends that support vectors. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 6 ++ tcg/i386/tcg-target.inc.c| 7 +++ tcg/tcg.c| 19 ++- 3 files changed, 31 insertions(+), 1 deletion(-) diff --gi

[Qemu-devel] [PATCH v2 14/29] tcg: Add gvec expanders for variable shift

2019-04-30 Thread Richard Henderson
The gvec expanders perform a modulo on the shift count. If the target requires alternate behaviour, then it cannot use the generic gvec expanders anyway, and will have to have its own custom code. Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime.h | 15 +++ tcg/tcg-op-gvec.h

[Qemu-devel] [PATCH v2 25/29] target/ppc: Use tcg_gen_abs_i32

2019-04-30 Thread Richard Henderson
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190423102145.14812-2-f4...@amsat.org> Signed-off-by: Richard Henderson --- target/ppc/translate/spe-impl.inc.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/target/ppc/transla

[Qemu-devel] [PATCH v2 19/29] tcg: Add support for integer absolute value

2019-04-30 Thread Richard Henderson
Remove a function of the same name from target/arm/. Use a branchless implementation of abs gleaned from gcc. Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tcg-op.h | 5 + target/arm/translate.c | 10 -- tcg/t

[Qemu-devel] [PATCH v2 13/29] tcg: Add INDEX_op_dup_mem_vec

2019-04-30 Thread Richard Henderson
Allow the backend to expand dup from memory directly, instead of forcing the value into a temp first. This is especially important if integer/vector register moves do not exist. Note that officially tcg_out_dupm_vec is allowed to fail. If it did, we could fix this up relatively easily: VECE ==

[Qemu-devel] [PATCH v2 27/29] target/s390x: Use tcg_gen_abs_i64

2019-04-30 Thread Richard Henderson
Cc: David Hildenbrand Signed-off-by: Richard Henderson --- target/s390x/translate.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index d4951836ad..e8e8a79b7d 100644 --- a/target/s390x/translate.c +++ b/target/s390x

[Qemu-devel] [PATCH v2 23/29] target/arm: Use tcg_gen_abs_i64 and tcg_gen_gvec_abs

2019-04-30 Thread Richard Henderson
Cc: qemu-...@nongnu.org Cc: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper.h| 2 -- target/arm/neon_helper.c | 5 - target/arm/translate-a64.c | 41 +- target/arm/translate.c | 11 +++--- 4 files changed, 8 inserti

[Qemu-devel] [PATCH v2 21/29] tcg/i386: Support vector absolute value

2019-04-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 2 +- tcg/i386/tcg-target.inc.c | 15 +++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h index 7445f05885..66f16fbe3c 100644 --- a/tcg/i386/tcg-target.h +++

[Qemu-devel] [PATCH v2 15/29] tcg/i386: Support vector variable shift opcodes

2019-04-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 2 +- tcg/i386/tcg-target.inc.c | 35 +++ 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h index 241bf19413..b240633455 100644 --- a/tcg/i3

[Qemu-devel] [PATCH v2 24/29] target/cris: Use tcg_gen_abs_tl

2019-04-30 Thread Richard Henderson
Cc: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/cris/translate.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index b005a5c20e..31b40a57f9 100644 --- a/target/cris/translate.c +++ b/target/cris/tra

[Qemu-devel] [PATCH v2 26/29] target/ppc: Use tcg_gen_abs_tl

2019-04-30 Thread Richard Henderson
Cc: David Gibson Signed-off-by: Richard Henderson --- target/ppc/translate.c | 68 +++--- 1 file changed, 24 insertions(+), 44 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 8d08625c33..b5217f632f 100644 --- a/target/ppc/trans

[Qemu-devel] [PATCH v2 17/29] tcg: Add gvec expanders for vector shift by scalar

2019-04-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg-op-gvec.h | 7 ++ tcg/tcg-op.h | 4 + tcg/tcg-op-gvec.c | 204 ++ tcg/tcg-op-vec.c | 54 4 files changed, 269 insertions(+) diff --git a/tcg/tcg-op-gvec.h b/tcg/tcg-op-gvec.h index 84

[Qemu-devel] [PATCH v2 22/29] tcg/aarch64: Support vector absolute value

2019-04-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 2 +- tcg/aarch64/tcg-target.inc.c | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tcg-target.h index 21d06d928c..e43554c3c7 100644 --- a/tcg/aarch64/tcg-target.h +

[Qemu-devel] [PATCH v2 28/29] target/tricore: Use tcg_gen_abs_tl

2019-04-30 Thread Richard Henderson
From: Philippe Mathieu-Daudé Reviewed-by: Bastian Koppelmann Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190423102145.14812-3-f4...@amsat.org> Signed-off-by: Richard Henderson --- target/tricore/translate.c | 27 +-- 1 file changed, 5 insertions(+), 22 deletion

[Qemu-devel] [PATCH v2 29/29] target/xtensa: Use tcg_gen_abs_i32

2019-04-30 Thread Richard Henderson
Cc: Max Filippov Signed-off-by: Richard Henderson --- target/xtensa/translate.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index 301c8e3161..b063fa85f2 100644 --- a/target/xtensa/translate.c +++ b/target/xtens

[Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-04-30 Thread Suraj Jitindar Singh
Add a monitor command "dump-stack" to be used to dump the stack for the current cpu. Signed-off-by: Suraj Jitindar Singh --- hmp-commands.hx | 13 + hmp.h | 1 + include/qom/cpu.h | 10 ++ monitor.c | 12 qom/cpu.c | 10 ++

[Qemu-devel] [PATCH 2/2] ppc: Add dump-stack implementation

2019-04-30 Thread Suraj Jitindar Singh
The monitor function dump-stack is used to dump the stack for a cpu. This can be useful for debugging purposes when the stack cannot be dumped by another means. Add a ppc implementation ppc_cpu_dump_stack(). The stack pointer is stored in R1 with the back pointer at offset 0 and the link register

[Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size

2019-04-30 Thread Joel Stanley
We currently use Qemu's default of 128MB. As we know how much ram each machine ships with, make it easier on users by setting a default. It can still be overridden with -m on the command line. Signed-off-by: Joel Stanley --- hw/arm/aspeed.c | 6 ++ include/hw/arm/aspeed.h | 1 + 2 f

Re: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size

2019-04-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190501061827.23080-1-j...@jms.id.au/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190501061827.23080-1-j...@jms.id.au Subject: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size

Re: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size

2019-04-30 Thread Andrew Jeffery
On Wed, 1 May 2019, at 15:48, Joel Stanley wrote: > We currently use Qemu's default of 128MB. As we know how much ram each > machine ships with, make it easier on users by setting a default. > > It can still be overridden with -m on the command line. > > Signed-off-by: Joel Stanley Reviewed-

Re: [Qemu-devel] [PATCH v3 4/9] s390x/cpumodel: msa9 facility

2019-04-30 Thread David Hildenbrand
On 30.04.19 07:41, Christian Borntraeger wrote: > > > On 29.04.19 21:24, David Hildenbrand wrote: >> On 29.04.19 11:02, Christian Borntraeger wrote: >>> Provide the MSA9 facility (stfle.155). >>> This also contains pckmo functions for key wrapping. Keep them in a >>> separate group to disable tho

Re: [Qemu-devel] [PATCH v3 0/2] commit: Make base read-only if there is an early failure

2019-04-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1556540297.git.be...@igalia.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time make

[Qemu-devel] [Bug 1827005] [NEW] hvf: ubuntu iso boot menu issue

2019-04-30 Thread Chen Zhang
Public bug reported: With hvf acceleration on macOS, ubuntu server installation ISO boot language menu shows fractured images. To reproduce the issue: ./x86_64-softmmu/qemu-system-x86_64 -m 800 -accel hvf -cdrom ~/ubuntu-16.04.4-server-amd64.iso Control: ./x86_64-softmmu/qemu-system-x86_64 -m 8

[Qemu-devel] [Bug 1827005] Re: hvf: ubuntu iso boot menu issue

2019-04-30 Thread Chen Zhang
** Attachment added: "normal case(tcg)" https://bugs.launchpad.net/qemu/+bug/1827005/+attachment/5260224/+files/Screen%20Shot%202019-04-30%20at%202.53.08%20PM.png -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

Re: [Qemu-devel] [PATCH v3 4/9] s390x/cpumodel: msa9 facility

2019-04-30 Thread Cornelia Huck
On Tue, 30 Apr 2019 09:00:56 +0200 David Hildenbrand wrote: > On 30.04.19 07:41, Christian Borntraeger wrote: > > > > > > On 29.04.19 21:24, David Hildenbrand wrote: > >> Just wondering, why keep the PCKMO ones separate, but not e.g. PCC ? > > > > Because those can be disabled at the HMC.

[Qemu-devel] [PATCH v6 01/30] hw/pci/pci-stub: Add msi_enabled() and msi_notify() to the pci stubs

2019-04-30 Thread Thomas Huth
Some machines have an AHCI adapter, but no PCI. To be able to compile hw/ide/ahci.c without CONFIG_PCI, we still need the two functions msi_enabled() and msi_notify() for linking. This is required for the new Kconfig-like build system, if a user wants to compile a QEMU binary with just one machine

[Qemu-devel] [PATCH v6 02/30] hw/ide/ahci: Add a Kconfig switch for the AHCI-ICH9 device

2019-04-30 Thread Thomas Huth
Some of our machines (like the ARM cubieboard) use CONFIG_AHCI for an AHCI sysbus device, but do not use CONFIG_PCI since they do not feature a PCI bus. With CONFIG_AHCI but without CONFIG_PCI, currently linking fails: ../hw/ide/ich.o: In function `pci_ich9_ahci_realize': hw/ide/ich.c:124:

[Qemu-devel] [PATCH v6 04/30] hw/usb/hcd-ohci: Move PCI-related code into a separate file

2019-04-30 Thread Thomas Huth
Some machines (like the pxa2xx-based ARM machines) only have a sysbus OHCI controller, but no PCI. With the new Kconfig-style build system, it will soon be possible to create QEMU binaries that only contain such PCI-less machines. However, the two OHCI controllers, for sysbus and for PCI, are curre

[Qemu-devel] [PATCH v6 00/30] Kconfig dependencies for ARM machines

2019-04-30 Thread Thomas Huth
This series reworks the default-configs/arm-softmmu.mak and default-configs/aarch64-softmmu.mak files to use the new Kconfig-style dependencies instead. Some of the patches are slightly based on the work by Ákos Kovács: https://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg03730.html The

[Qemu-devel] [PATCH v6 03/30] hw/usb/hcd-ohci: Do not use PCI functions with sysbus devices in ohci_die()

2019-04-30 Thread Thomas Huth
The ohci_die() function always assumes to be running with a PCI OHCI controller and calls the PCI-specific functions pci_set_word(). However, this function might also get called for the sysbus OHCI devices, so it likely fails in that case. To fix this issue, change the code now, so that there are t

[Qemu-devel] [PATCH v6 09/30] hw/arm: Express dependencies of musicpal with Kconfig

2019-04-30 Thread Thomas Huth
This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 6 +- hw/arm/Kconfig | 5 +

[Qemu-devel] [PATCH v6 12/30] hw/arm: Express dependencies of realview, versatile and vexpress with Kconfig

2019-04-30 Thread Thomas Huth
This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 24 - hw/arm/Kconfig

[Qemu-devel] [PATCH v6 05/30] hw/arm: Express dependencies of the exynos machines with Kconfig

2019-04-30 Thread Thomas Huth
Add Kconfig dependencies for the Exynos-related boards (nuri and smdkc210). This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- defau

[Qemu-devel] [PATCH v6 07/30] hw/arm: Express dependencies of integratorcp with Kconfig

2019-04-30 Thread Thomas Huth
This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 8 +--- hw/arm/Kconfig | 8

[Qemu-devel] [PATCH v6 10/30] hw/arm: Express dependencies of the OMAP machines with Kconfig

2019-04-30 Thread Thomas Huth
Add Kconfig dependencies for the OMAP machines (cheetah, n800, n810, sx1 and sx1-v1). This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth

[Qemu-devel] [PATCH v6 13/30] hw/arm: Express dependencies of the PXA2xx machines with Kconfig

2019-04-30 Thread Thomas Huth
Add Kconfig dependencies for the PXA2xx machines (akita, borzoi, connex and verdex gumstix, tosa, mainstone, spitz, terrier and z2). This patch is based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathi

[Qemu-devel] [PATCH v6 06/30] hw/arm: Express dependencies of the highbank machines with Kconfig

2019-04-30 Thread Thomas Huth
Add Kconfig dependencies for the highbank machine (and the midway machine). This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- defau

[Qemu-devel] [PATCH v6 14/30] hw/arm: Express dependencies of xilinx-zynq with Kconfig

2019-04-30 Thread Thomas Huth
Add Kconfig dependencies for the xilinx-zynq-a9 board. This patch is based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- defa

[Qemu-devel] [PATCH v6 20/30] hw/arm: Express dependencies of the MPS2 boards with Kconfig

2019-04-30 Thread Thomas Huth
Add Kconfig dependencies for the mps2-an* machines. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 20 +--- hw/arm/Kconfig | 19 +++ 2 files changed, 20 inse

[Qemu-devel] [PATCH v6 18/30] hw/arm: Express dependencies of netduino / stm32f2xx with Kconfig

2019-04-30 Thread Thomas Huth
Netduino only depends on the stm32f205 SoC which in turn depends on its components. Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 9 + hw/arm/Kconfig

[Qemu-devel] [PATCH v6 08/30] hw/arm: Express dependencies of the fsl-imx31 machine with Kconfig

2019-04-30 Thread Thomas Huth
Add Kconfig dependencies for the fsl-imx31 / kzm machine. This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Peter Chubb Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --

[Qemu-devel] [PATCH v6 15/30] hw/arm: Express dependencies of collie with Kconfig

2019-04-30 Thread Thomas Huth
Add Kconfig dependencies for the Strongarm collie machine. This patch is based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak

[Qemu-devel] [PATCH v6 24/30] hw/arm: Express dependencies of the MSF2 / EMCRAFT_SF2 machine with Kconfig

2019-04-30 Thread Thomas Huth
Add Kconfig dependencies for the emcraft-sf2 machine - we also distinguish between the machine (CONFIG_EMCRAFT_SF2) and the SoC (CONFIG_MSF2) now. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 3 +-- hw/ar

[Qemu-devel] [PATCH v6 11/30] hw/arm: Express dependencies of stellaris with Kconfig

2019-04-30 Thread Thomas Huth
This patch is slightly based on earlier work by Ákos Kovács (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch). Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 7 +-- hw/arm/Kconfig | 11 +++ 2 files changed, 12 in

[Qemu-devel] [PATCH v6 28/30] hw/arm: Express dependencies of the xlnx-versal-virt machine with Kconfig

2019-04-30 Thread Thomas Huth
Dependencies have been determined with trial-and-error and by looking at the xlnx-versal.c source file. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/arm/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/Kconfig b/h

[Qemu-devel] [PATCH v6 19/30] hw/arm: Express dependencies of allwinner / cubieboard with Kconfig

2019-04-30 Thread Thomas Huth
Add dependencies for the Cubitech Cubieboard. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 6 +- hw/arm/Kconfig | 9 + 2 files changed, 10 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH v6 30/30] hw/arm: Remove hard-enablement of the remaining PCI devices

2019-04-30 Thread Thomas Huth
The PCI devices should be pulled in by default if PCI_DEVICES is set, so there is no need anymore to enforce them in the configs file. Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 8 1 file changed, 8 deletions(-) diff --git a/defa

[Qemu-devel] [PATCH v6 22/30] hw/arm: Express dependencies of canon-a1100 with Kconfig

2019-04-30 Thread Thomas Huth
Add Kconfig dependencies for the DIGIC / canon-a1100 machine. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 2 +- hw/arm/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) dif

[Qemu-devel] [PATCH v6 16/30] hw/arm: Express dependencies of the aspeed boards with Kconfig

2019-04-30 Thread Thomas Huth
Dependencies have been determined by looking at hw/arm/aspeed.c Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 7 +-- hw/arm/Kconfig | 10 ++ 2 f

[Qemu-devel] [PATCH v6 26/30] hw/arm: Express dependencies of the microbit / nrf51 machine with Kconfig

2019-04-30 Thread Thomas Huth
Add Kconfig dependencies for the NRF51 / microbit machine. Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 3 +-- hw/arm/Kconfig | 6 ++ hw/arm/Makefile.ob

[Qemu-devel] [PATCH v6 17/30] hw/arm: Express dependencies of the virt machine with Kconfig

2019-04-30 Thread Thomas Huth
Dependencies have been determined by looking at hw/arm/virt.c Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/aarch64-softmmu.mak | 1 - default-configs/arm-softmmu.mak | 11 +-- hw/arm/Kconfig

[Qemu-devel] [PATCH v6 25/30] hw/arm: Express dependencies of the remaining IMX boards with Kconfig

2019-04-30 Thread Thomas Huth
IMX25, IMX7 and IMX6UL were still missing the Kconfig dependencies. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 2 -- hw/arm/Kconfig | 19 +++ 2 files changed, 19 insert

[Qemu-devel] [PATCH v6 21/30] hw/arm: Express dependencies of the raspi machines with Kconfig

2019-04-30 Thread Thomas Huth
Most of the code is directly controlled by the CONFIG_RASPI switch, so not much to add here additionally. Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 4 +--- hw/arm/Kconfig

Re: [Qemu-devel] [PATCH 2/9] cpu/topology: add general support for machine properties

2019-04-30 Thread Like Xu
On 2019/4/4 22:25, Igor Mammedov wrote: On Fri, 29 Mar 2019 16:48:38 +0800 Like Xu wrote: diff --git a/cpus.c b/cpus.c index e83f72b..834a697 100644 --- a/cpus.c +++ b/cpus.c @@ -2067,6 +2067,10 @@ static void qemu_dummy_start_vcpu(CPUState *cpu) void qemu_init_vcpu(CPUState *cpu)

[Qemu-devel] [PATCH v6 23/30] hw/arm: Express dependencies of sabrelite with Kconfig

2019-04-30 Thread Thomas Huth
Add Kconfig dependencies for the Sabrelite / iMX6 machine. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/arm-softmmu.mak | 4 +--- hw/arm/Kconfig | 9 + hw/arm/Makefile.objs| 3 ++- 3 fi

[Qemu-devel] [PATCH v6 27/30] hw/arm: Express dependencies of the ZynqMP zcu102 machine with Kconfig

2019-04-30 Thread Thomas Huth
This cleans up most settings in default-configs/aarch64-softmmu.mak. Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- default-configs/aarch64-softmmu.mak | 4 hw/arm/Kconfig | 11 +

[Qemu-devel] [PATCH v6 29/30] hw/arm: Express dependencies of the musca machines with Kconfig

2019-04-30 Thread Thomas Huth
Dependencies have been determined with trial-and-error and by looking at the musca.c source file. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/arm/Kconfig | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/

Re: [Qemu-devel] [PATCH v2] usb/xchi: avoid trigger assertion if guest write wrong epid

2019-04-30 Thread Philippe Mathieu-Daudé
On 4/30/19 8:21 AM, Longpeng(Mike) wrote: > From: Longpeng > > we found the following core in our environment: > 0 0x7fc6b06c2237 in raise () > 1 0x7fc6b06c3928 in abort () > 2 0x7fc6b06bb056 in __assert_fail_base () > 3 0x7fc6b06bb102 in __assert_fail () > 4 0x00702e

Re: [Qemu-devel] [PATCH v6 11/30] hw/arm: Express dependencies of stellaris with Kconfig

2019-04-30 Thread Philippe Mathieu-Daudé
On 4/30/19 9:13 AM, Thomas Huth wrote: > This patch is slightly based on earlier work by Ákos Kovács (i.e. > his "hw/arm/Kconfig: Add ARM Kconfig" patch). > > Tested-by: Philippe Mathieu-Daudé > Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé > --- > default-configs/arm-softmm

[Qemu-devel] [PATCH] vhost: remove the dead code

2019-04-30 Thread Jie Wang
remove the dead code Signed-off-by: Jie Wang --- hw/virtio/vhost.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 7f61018f2a..2303a8c206 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -1650,7 +1650,6 @@ fail_vq:

Re: [Qemu-devel] [PATCH v6 30/30] hw/arm: Remove hard-enablement of the remaining PCI devices

2019-04-30 Thread Philippe Mathieu-Daudé
On 4/30/19 9:14 AM, Thomas Huth wrote: > The PCI devices should be pulled in by default if PCI_DEVICES > is set, so there is no need anymore to enforce them in the configs > file. > > Tested-by: Philippe Mathieu-Daudé > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 8

Re: [Qemu-devel] [PATCH v5 07/10] qcow2: qcow2_co_preadv: improve locking

2019-04-30 Thread Vladimir Sementsov-Ogievskiy
29.04.2019 19:37, Max Reitz wrote: > On 02.04.19 17:37, Vladimir Sementsov-Ogievskiy wrote: >> Background: decryption will be done in threads, to take benefit of it, >> we should move it out of the lock first. > > ...which is safe after your commit c972fa123c73501b4, I presume. > > (At first glan

[Qemu-devel] [PATCH] vhost: fix incorrect print type

2019-04-30 Thread Jie Wang
fix incorrect print type in vhost_virtqueue_stop Signed-off-by: Jie Wang --- hw/virtio/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 7f61018f2a..286bb27c65 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -1081,7

Re: [Qemu-devel] [PATCH] qom/object: Display more helpful message when an object type is missing

2019-04-30 Thread Stefano Garzarella
On Sat, Apr 27, 2019 at 03:56:42PM +0200, Philippe Mathieu-Daudé wrote: > When writing a new board, adding device which uses other devices > (container) or simply refactoring, one can discover the hard way > his machine misses some devices. In the case of containers, the > error is not obvious: >

Re: [Qemu-devel] [PATCH] vhost: fix incorrect print type

2019-04-30 Thread Philippe Mathieu-Daudé
On 4/30/19 8:29 AM, Jie Wang wrote: > fix incorrect print type in vhost_virtqueue_stop > > Signed-off-by: Jie Wang > --- > hw/virtio/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > index 7f61018f2a..286bb27c65 100644 > ---

[Qemu-devel] [PATCH] hw/arm/fsl-imx: move cpus initialization to realize time after smp_cpus check

2019-04-30 Thread Like Xu
If "smp_cpus> FSL_IMX6_NUM_CPUS" fails in *_realize(), there is no need to initialize the CPUs in *_init(). So it could be better to create all cpus after the validity in *_realize(). On the other hand, it makes the usages of global variable smp_cpus more centrally for maintenance. Suggested-by: I

Re: [Qemu-devel] [PATCH v5 01/10] tests/perf: Test qemu-img convert from raw to encrypted qcow2

2019-04-30 Thread Vladimir Sementsov-Ogievskiy
29.04.2019 1:55, Max Reitz wrote: > On 02.04.19 17:37, Vladimir Sementsov-Ogievskiy wrote: >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> tests/perf/block/qcow2/convert-to-encrypted | 48 + >> 1 file changed, 48 insertions(+) >> create mode 100755 tests/perf/bloc

Re: [Qemu-devel] [PATCH] hw/arm/fsl-imx: move cpus initialization to realize time after smp_cpus check

2019-04-30 Thread Peter Maydell
On Tue, 30 Apr 2019 at 09:52, Like Xu wrote: > > If "smp_cpus> FSL_IMX6_NUM_CPUS" fails in *_realize(), there is no need to > initialize the CPUs in *_init(). So it could be better to create all cpus > after the validity in *_realize(). On the other hand, it makes the usages > of global variable s

Re: [Qemu-devel] [PULL 0/1] Tracing patches

2019-04-30 Thread Peter Maydell
On Mon, 29 Apr 2019 at 17:10, Stefan Hajnoczi wrote: > > The following changes since commit e0fb2c3d89aa77057ac4aa073e01f4ca484449b0: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190426' into > staging (2019-04-28 11:43:10 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v5 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter

2019-04-30 Thread Stefano Garzarella
On Tue, Apr 23, 2019 at 03:57:05PM +0300, Vladimir Sementsov-Ogievskiy wrote: > This fixes at least one overflow in qcow2_process_discards, which > passes 64bit region length to bdrv_pdiscard where bytes (or sectors in > the past) parameter is int since its introduction in 0b919fae. > > Signed-off

[Qemu-devel] [PATCH] vhost: fix memory leak in vhost_user_scsi_realize

2019-04-30 Thread Jie Wang
fix memory leak in vhost_user_scsi_realize Signed-off-by: Jie Wang --- hw/scsi/vhost-user-scsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/scsi/vhost-user-scsi.c b/hw/scsi/vhost-user-scsi.c index 8b1e6876db..a9fd8ea305 100644 --- a/hw/scsi/vhost-user-scsi.c +++ b/hw/scsi/vhost-us

Re: [Qemu-devel] [PATCH 14/26] target/openrisc: Convert to CPUClass::tlb_fill

2019-04-30 Thread Peter Maydell
On Wed, 3 Apr 2019 at 04:55, Richard Henderson wrote: > > Cc: Stafford Horne > Signed-off-by: Richard Henderson > --- a/target/openrisc/mmu.c > +++ b/target/openrisc/mmu.c > @@ -107,16 +107,42 @@ static void raise_mmu_exception(OpenRISCCPU *cpu, > target_ulong address, > cpu->env.lock_add

Re: [Qemu-devel] [PATCH 15/26] target/ppc: Convert to CPUClass::tlb_fill

2019-04-30 Thread Peter Maydell
On Wed, 3 Apr 2019 at 04:52, Richard Henderson wrote: > > Cc: qemu-...@nongnu.org > Cc: David Gibson > Signed-off-by: Richard Henderson > --- > target/ppc/cpu.h| 7 +++ > target/ppc/mmu_helper.c | 19 +-- > target/ppc/translate_init.inc.c | 5 ++---

Re: [Qemu-devel] [PATCH 0/9] block: buffer-based io

2019-04-30 Thread Stefano Garzarella
On Mon, Apr 22, 2019 at 05:58:29PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > We often need to do read/write with buffer, not qiov. Instead of > creating qiov in such cases, let's introduce corresponding helpers. > > Vladimir Sementsov-Ogievskiy (9): > block: introduce byte-based

Re: [Qemu-devel] [PATCH v3 5/7] hw/ppc: Implement fw_cfg_arch_key_name()

2019-04-30 Thread Laszlo Ersek
On 04/29/19 18:01, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 4/23/19 9:02 PM, Laszlo Ersek wrote: >> On 04/22/19 21:50, Philippe Mathieu-Daudé wrote: >>> Implement fw_cfg_arch_key_name(), which returns the name of a >>> ppc-specific key. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> -

Re: [Qemu-devel] [PATCH] s390-bios: Skip bootmap signature entries

2019-04-30 Thread Cornelia Huck
On Tue, 30 Apr 2019 11:24:27 +0200 Peter Oberparleiter wrote: > On 29.04.2019 15:45, Christian Borntraeger wrote: > > > > > > On 29.04.19 15:40, Cornelia Huck wrote: > >> On Mon, 29 Apr 2019 09:09:41 -0400 > >> "Jason J. Herne" wrote: > >> > >>> Newer versions of zipl have the ability to w

Re: [Qemu-devel] [PATCH 13/26] target/nios2: Convert to CPUClass::tlb_fill

2019-04-30 Thread Peter Maydell
On Wed, 3 Apr 2019 at 04:55, Richard Henderson wrote: > > Cc: Chris Wulff > Cc: Marek Vasut > Signed-off-by: Richard Henderson > --- > target/nios2/cpu.h| 5 +- > target/nios2/cpu.c| 5 +- > target/nios2/helper.c | 181 -- > target/nios2/mmu.

Re: [Qemu-devel] [PATCH 0/9] block: buffer-based io

2019-04-30 Thread Vladimir Sementsov-Ogievskiy
30.04.2019 12:38, Stefano Garzarella wrote: > On Mon, Apr 22, 2019 at 05:58:29PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> We often need to do read/write with buffer, not qiov. Instead of >> creating qiov in such cases, let's introduce corresponding helpers. >> >> Vladimir Sements

Re: [Qemu-devel] [PATCH v5 07/10] qcow2: qcow2_co_preadv: improve locking

2019-04-30 Thread Vladimir Sementsov-Ogievskiy
30.04.2019 11:38, Vladimir Sementsov-Ogievskiy wrote: > 29.04.2019 19:37, Max Reitz wrote: >> On 02.04.19 17:37, Vladimir Sementsov-Ogievskiy wrote: >>> Background: decryption will be done in threads, to take benefit of it, >>> we should move it out of the lock first. >> >> ...which is safe after y

Re: [Qemu-devel] [PATCH 3/5] vvfat: Replace bdrv_{read, write}() with bdrv_{pread, pwrite}()

2019-04-30 Thread Kevin Wolf
Am 29.04.2019 um 20:42 hat Alberto Garcia geschrieben: > There's only a couple of bdrv_read() and bdrv_write() calls left in > the vvfat code, and they can be trivially replaced with the byte-based > bdrv_pread() and bdrv_pwrite(). > > Signed-off-by: Alberto Garcia > --- > block/vvfat.c | 10 +++

Re: [Qemu-devel] [PATCH] [RFC] qcow2: add compression type feature

2019-04-30 Thread Stefano Garzarella
Hi Denis, few simple comments below regarding the CODING_STYLE (point 7. Comment style) On Tue, Feb 05, 2019 at 12:08:25PM +0300, Denis Plotnikov wrote: > The patch adds some preparation parts for incompatible compression type > feature into QCOW2 header that indicates that *all* compressed cluste

Re: [Qemu-devel] [PATCH v3 5/7] hw/ppc: Implement fw_cfg_arch_key_name()

2019-04-30 Thread Philippe Mathieu-Daudé
On 4/30/19 11:41 AM, Laszlo Ersek wrote: > On 04/29/19 18:01, Philippe Mathieu-Daudé wrote: >> Hi Laszlo, >> >> On 4/23/19 9:02 PM, Laszlo Ersek wrote: >>> On 04/22/19 21:50, Philippe Mathieu-Daudé wrote: Implement fw_cfg_arch_key_name(), which returns the name of a ppc-specific key.

Re: [Qemu-devel] [PULL v2 0/2] target/hppa patch queue

2019-04-30 Thread Peter Maydell
On Mon, 29 Apr 2019 at 22:58, Richard Henderson wrote: > > Rebased for v2. > > The following changes since commit 82b2865e0d0ea4c1001e9e7ed7920bcc0458f6de: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190429' into staging (2019-04-29 > 18:05:56 +0100) > > are ava

Re: [Qemu-devel] [PATCH 20/26] target/tilegx: Convert to CPUClass::tlb_fill

2019-04-30 Thread Peter Maydell
On Wed, 3 Apr 2019 at 05:03, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/tilegx/cpu.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 1/3] qapi: SupportStatusInfo struct

2019-04-30 Thread Daniel P . Berrangé
On Wed, Apr 24, 2019 at 03:20:36PM -0300, Eduardo Habkost wrote: > On Wed, Apr 24, 2019 at 09:26:52AM +0100, Daniel P. Berrangé wrote: > > On Tue, Apr 23, 2019 at 06:22:44PM -0300, Eduardo Habkost wrote: > > > This struct will be used to represent support and deprecation > > > status of QEMU featur

[Qemu-devel] [PATCH] qcow2: Fix error handling in the compression code

2019-04-30 Thread Alberto Garcia
This patch fixes a few things in the way error codes are handled in the qcow2 compression code: a) qcow2_co_pwritev_compressed() expects qcow2_co_compress() to only return -1 or -2 on failure, but this is not correct. Since the change from qcow2_compress() to qcow2_co_compress() in commit

Re: [Qemu-devel] [PATCH 23/26] target/xtensa: Convert to CPUClass::tlb_fill

2019-04-30 Thread Peter Maydell
On Wed, 3 Apr 2019 at 05:00, Richard Henderson wrote: > > Cc: Max Filippov > Signed-off-by: Richard Henderson > --- > target/xtensa/cpu.h| 5 +-- > target/xtensa/cpu.c| 5 ++- > target/xtensa/helper.c | 74 +- > 3 files changed, 42 insertions(+)

Re: [Qemu-devel] [PATCH] virtio-mmio: Always compile debug prints

2019-04-30 Thread Philippe Mathieu-Daudé
Hi Li, On 4/28/19 1:02 PM, Boxuan Li wrote: > Wrap printf calls inside debug macros (DPRINTF) in `if` statement, and > change output to stderr as well. This will ensure that printf function > will always compile and prevent bitrot of the format strings. There is an effort in QEMU to replace the o

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-04-30 Thread Dan Streetman
This has been verified by the original reporter to fix the problem of qemu crashing. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1823458 Title: race condition between vhost_net_stop and CHR_EVENT

Re: [Qemu-devel] [PATCH 22/26] target/unicore32: Convert to CPUClass::tlb_fill

2019-04-30 Thread Peter Maydell
On Wed, 3 Apr 2019 at 04:58, Richard Henderson wrote: > > Cc: Guan Xuetao > Signed-off-by: Richard Henderson > --- > target/unicore32/cpu.h | 5 +++-- > target/unicore32/cpu.c | 5 + > target/unicore32/helper.c| 23 --- > target/unicore32/op_helper.c |

Re: [Qemu-devel] [PATCH] qom/object: Display more helpful message when an object type is missing

2019-04-30 Thread Daniel P . Berrangé
On Sat, Apr 27, 2019 at 03:56:42PM +0200, Philippe Mathieu-Daudé wrote: > When writing a new board, adding device which uses other devices > (container) or simply refactoring, one can discover the hard way > his machine misses some devices. In the case of containers, the > error is not obvious: >

Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP

2019-04-30 Thread Daniel P . Berrangé
On Wed, Apr 24, 2019 at 03:10:49PM -0300, Eduardo Habkost wrote: > On Wed, Apr 24, 2019 at 09:56:53AM +0200, Thomas Huth wrote: > > On 23/04/2019 23.22, Eduardo Habkost wrote: > > > This series adds machine type deprecation information to the > > > output of the `query-machines` QMP command. With

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-04-30 Thread Dan Streetman
clarification: by "original reporter" I mean the customer of Canonical, reporting the problem to us. ** Tags removed: verification-mitaka-needed verification-needed verification-needed-xenial verification-ocata-needed ** Tags added: verification-done verification-done-xenial verification-mitaka-

Re: [Qemu-devel] [PATCH 21/26] target/tricore: Convert to CPUClass::tlb_fill

2019-04-30 Thread Peter Maydell
On Wed, 3 Apr 2019 at 04:58, Richard Henderson wrote: > > Cc: Bastian Koppelmann > Signed-off-by: Richard Henderson > --- > target/tricore/cpu.h | 6 +++--- > target/tricore/cpu.c | 1 + > target/tricore/helper.c| 27 +++ > target/tricore/op_helper.c |

Re: [Qemu-devel] [PATCH 1/3] qapi: SupportStatusInfo struct

2019-04-30 Thread Daniel P . Berrangé
On Thu, Apr 25, 2019 at 02:42:08PM -0300, Eduardo Habkost wrote: > On Thu, Apr 25, 2019 at 11:20:58AM -0300, Wainer dos Santos Moschetta wrote: > > Hi Eduardo, > > > > > > On 04/23/2019 06:22 PM, Eduardo Habkost wrote: > > > This struct will be used to represent support and deprecation > > > stat

Re: [Qemu-devel] [PATCH 2/5] vdi: Replace bdrv_{read, write}() with bdrv_{pread, pwrite}()

2019-04-30 Thread Kevin Wolf
Am 29.04.2019 um 20:42 hat Alberto Garcia geschrieben: > There's only a couple of bdrv_read() and bdrv_write() calls left in > the vdi code, and they can be trivially replaced with the byte-based > bdrv_pread() and bdrv_pwrite(). > > Signed-off-by: Alberto Garcia > --- > block/vdi.c | 11 ++-

Re: [Qemu-devel] [PATCH v5 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter

2019-04-30 Thread Vladimir Sementsov-Ogievskiy
30.04.2019 12:24, Stefano Garzarella wrote: > On Tue, Apr 23, 2019 at 03:57:05PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> This fixes at least one overflow in qcow2_process_discards, which >> passes 64bit region length to bdrv_pdiscard where bytes (or sectors in >> the past) parameter is int si

Re: [Qemu-devel] [PATCH] qcow2: Fix error handling in the compression code

2019-04-30 Thread Kevin Wolf
Am 30.04.2019 um 12:08 hat Alberto Garcia geschrieben: > This patch fixes a few things in the way error codes are handled in > the qcow2 compression code: > > a) qcow2_co_pwritev_compressed() expects qcow2_co_compress() to only >return -1 or -2 on failure, but this is not correct. Since the >

Re: [Qemu-devel] [PATCH 0/2] buffer and delay backup COW write operation

2019-04-30 Thread Vladimir Sementsov-Ogievskiy
28.04.2019 13:01, Liang Li wrote: > If the backup target is a slow device like ceph rbd, the backup > process will affect guest BLK write IO performance seriously, > it's cause by the drawback of COW mechanism, if guest overwrite the > backup BLK area, the IO can only be processed after the data ha

Re: [Qemu-devel] [PATCH v4 2/4] linux-user: Set PAGE_TARGET_1 for TARGET_PROT_BTI

2019-04-30 Thread Peter Maydell
On Mon, 29 Apr 2019 at 21:13, Richard Henderson wrote: > > On 4/29/19 9:21 AM, Peter Maydell wrote: > > This looks ok code-wise, but we'd need to hide it behind > > a defaults-to-off x-something property if we wanted to > > commit it before the kernel ABI is fixed. > > I'm not intending to change

  1   2   3   4   >