mcfg_start points to the start of MCFG table and is used in
build_header. While this information could be derived from mcfg.
This patch removes the unnecessary variable mcfg_start.
Signed-off-by: Wei Yang
Reviewed-by: Igor Mammedov
---
hw/arm/virt-acpi-build.c | 4 +---
1 file changed, 1 inser
Now we have two identical build_mcfg function.
Extract them to pci.c.
Signed-off-by: Wei Yang
---
v2:
* put it to dedicated file pci.c
---
default-configs/arm-softmmu.mak | 1 +
default-configs/i386-softmmu.mak | 1 +
hw/acpi/Kconfig | 4 +++
hw/acpi/Makefile.objs
This patch set tries to generalize MCFG table build process.
Wei Yang (4):
hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start
i386, acpi: remove mcfg_ prefix in AcpiMcfgInfo members
hw/arm/virt-acpi-build: pass AcpiMcfgInfo to build_mcfg()
hw/acpi: Extract build_mcfg to pci.c
This is obvious the member in AcpiMcfgInfo describe MCFG's property.
Remove the mcfg_ prefix.
Signed-off-by: Wei Yang
Suggested-by: Igor Mammedov
---
hw/i386/acpi-build.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-buil
To build MCFG, two information is necessary:
* bus number
* base address
Abstract these two information to AcpiMcfgInfo so that build_mcfg and
build_mcfg_q35 will have the same declaration.
Signed-off-by: Wei Yang
---
v2:
* for arm platform, construct a AcpiMcfgInfo directly
---
hw/
This patch makes the remaining dozen or so uses of the global
current_machine outside vl.c use qdev_get_machine() instead,
and then make current_machine local to vl.c instead of global.
With type assertion in qdev_get_machine(), it will be hard to
misuse this function if machine hasn't been create
To avoid the misuse of qdev_get_machine() if machine hasn't been created yet,
this patch uses qdev_get_machine_uncheck() for obj-common (share with user-only
mode) and adds type assertion to qdev_get_machine() in system-emulation mode.
Suggested-by: Igor Mammedov
Signed-off-by: Like Xu
---
hw/c
This patch makes the remaining dozen or so uses of the global
current_machine outside vl.c use qdev_get_machine() instead,
and then make current_machine local to vl.c instead of global.
Suggested-by: Peter Maydell
Signed-off-by: Like Xu
---
accel/kvm/kvm-all.c | 6 --
device-hotplug.c|
Am 14.04.2019 um 17:14 hat Jason Dillaman geschrieben:
> On Sun, Apr 14, 2019 at 9:20 AM Stefano Garzarella
> wrote:
> >
> > On Thu, Apr 11, 2019 at 01:06:49PM -0400, Jason Dillaman wrote:
> > > On Thu, Apr 11, 2019 at 9:02 AM Stefano Garzarella
> > > wrote:
> > > >
> > > > On Thu, Apr 11, 2019
On Sun, 14 Apr 2019 at 20:40, Richard Henderson
wrote:
>
> On 4/14/19 8:02 AM, Peter Maydell wrote:
> > There's similar wording for the effect of NSACR on CPACR, so
> > again I think we need to actually make the bits RAZ/WI
> > regardless of their underlying value, not just force them
> > to 0.
>
On Fri, 12 Apr 2019 14:19:16 -0700
Alistair Francis wrote:
> On Fri, Apr 12, 2019 at 1:36 AM Igor Mammedov wrote:
> >
> > On Thu, 11 Apr 2019 13:42:20 -0700
> > Alistair Francis wrote:
> >
> > > On Thu, Apr 11, 2019 at 5:18 AM Igor Mammedov wrote:
> > > >
> > > > On Wed, 10 Apr 2019 23:10:25 +
On Wed, Apr 10, 2019 at 03:20:05PM +, Paul Durrant wrote:
> > -Original Message-
> > From: Anthony PERARD [mailto:anthony.per...@citrix.com]
> > Sent: 10 April 2019 13:57
> > To: Paul Durrant
> > Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org;
> > xen-de...@lists.xenproject.org; Ste
Public bug reported:
The tlbivax instruction in QEMU does not work for address above 4G. The reason
behind this is a simple 32bit trunction of an address.
Changing the argument ea from uint32_t to target_ulong for the function
booke206_invalidate_ea_tlb() in target/ppc/mmu_helper.c solves the is
On 14/04/19 20:36, Artyom Tarasenko wrote:
>> You can probably remove this change, and replace it by
>> uint16_t type = PCI_DEVICE_GET_CLASS(dev)->device_id;
> Brilliant! Will do in V2, thainks.
Either that, or you could keep the current structure and make mmio_size
the last parameter of lsi_scsi_
On Sat, Apr 13, 2019 at 10:54:40AM +0800, Pu Wen wrote:
> Add a new base CPU model called 'Dhyana' to model processors from Hygon
> Dhyana(family 18h), which derived from AMD EPYC(family 17h).
>
> The following features bits have been removed compare to AMD EPYC:
> aes, pclmulqdq, sha_ni
>
> The
On Thu, Apr 11, 2019 at 01:45:06AM +0300, Liran Alon wrote:
>
>
> > On 9 Apr 2019, at 17:29, Stefan Hajnoczi wrote:
> >
> > On Thu, Mar 21, 2019 at 09:55:42AM +0200, Nir Weiner wrote:
> >> Originally migration was not possible with vhost-scsi because
> >> as part of migration, the source host t
On Fri, Apr 12, 2019 at 04:26:52PM +0100, Dr. David Alan Gilbert (git) wrote:
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index d3bad2fc27..ba4690b9ac 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -585,6 +585,21 @@ STEXI
> @findex gpa2hpa
> Print the host physical address at
Hi,
Just to clarify. I see two possible solutions:
1) Since the migration code doesn't receive fd, it isn't responsible for
closing it. So, it may be better to use migrate_fd_param for both
incoming/outgoing and add dupping for migrate_fd_param. Thus, clients must
close the fd themselves. But exi
On Sun, Apr 14, 2019 at 07:33:17PM -0400, Programmingkid wrote:
> Hi I was wondering if anyone has been able to boot from a bootcamp partition
> inside of QEMU. I know this partition can be used in QEMU but my own attempts
> at booting Windows 7 on my bootcamp partition did not work. I always see
* Stefan Hajnoczi (stefa...@gmail.com) wrote:
> On Fri, Apr 12, 2019 at 04:26:52PM +0100, Dr. David Alan Gilbert (git) wrote:
> > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > index d3bad2fc27..ba4690b9ac 100644
> > --- a/hmp-commands.hx
> > +++ b/hmp-commands.hx
> > @@ -585,6 +585,21 @@ STEXI
> On 15 Apr 2019, at 12:37, Stefan Hajnoczi wrote:
>
> On Thu, Apr 11, 2019 at 01:45:06AM +0300, Liran Alon wrote:
>>
>>
>>> On 9 Apr 2019, at 17:29, Stefan Hajnoczi wrote:
>>>
>>> On Thu, Mar 21, 2019 at 09:55:42AM +0200, Nir Weiner wrote:
Originally migration was not possible with v
On Thu, Apr 11, 2019 at 05:40:26PM +, Jason Gunthorpe wrote:
> On Thu, Apr 11, 2019 at 08:34:20PM +0300, Yuval Shaia wrote:
> > On Thu, Apr 11, 2019 at 05:24:08PM +, Jason Gunthorpe wrote:
> > > On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornelia Huck wrote:
> > > > On Thu, 11 Apr 2019 14:01
15.04.2019 8:51, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy writes:
>
>> It would be nice to have Error object not freed away when debugging a
>> coredump.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy
>> ---
>> util/error.c | 8 +---
>> 1 file changed, 5 insertions(+), 3
On Mon, Apr 15, 2019 at 12:50:08PM +0300, Yury Kotov wrote:
> Hi,
>
> Just to clarify. I see two possible solutions:
>
> 1) Since the migration code doesn't receive fd, it isn't responsible for
> closing it. So, it may be better to use migrate_fd_param for both
> incoming/outgoing and add dupping
On Tuesday 26 March 2019 05:03 AM, David Gibson wrote:
> On Mon, Mar 25, 2019 at 02:27:45PM +0530, Aravinda Prasad wrote:
>>
>>
>> On Monday 25 March 2019 12:02 PM, David Gibson wrote:
>>> On Fri, Mar 22, 2019 at 12:04:16PM +0530, Aravinda Prasad wrote:
Enable the KVM capability KVM_CAP_PPC
15.04.2019, 13:11, "Daniel P. Berrangé" :
> On Mon, Apr 15, 2019 at 12:50:08PM +0300, Yury Kotov wrote:
>> Hi,
>>
>> Just to clarify. I see two possible solutions:
>>
>> 1) Since the migration code doesn't receive fd, it isn't responsible for
>> closing it. So, it may be better to use migrate_f
On 4/13/19 8:44 AM, Richard Henderson wrote:
> On 4/10/19 11:49 PM, Philippe Mathieu-Daudé wrote:
>>> -if (seed_optarg != NULL) {
>>> -qemu_guest_random_seed_main(seed_optarg, &error_fatal);
>>> +{
>> Since 7be41675f7c we use gnu99 C, so this extra block indentation can be
>> remove
> On Apr 15, 2019, at 5:54 AM, Stefan Hajnoczi wrote:
>
> On Sun, Apr 14, 2019 at 07:33:17PM -0400, Programmingkid wrote:
>> Hi I was wondering if anyone has been able to boot from a bootcamp partition
>> inside of QEMU. I know this partition can be used in QEMU but my own
>> attempts at boot
15.04.2019, 13:17, "Yury Kotov" :
> 15.04.2019, 13:11, "Daniel P. Berrangé" :
>> On Mon, Apr 15, 2019 at 12:50:08PM +0300, Yury Kotov wrote:
>>> Hi,
>>>
>>> Just to clarify. I see two possible solutions:
>>>
>>> 1) Since the migration code doesn't receive fd, it isn't responsible for
>>> c
On Mon, Apr 15, 2019 at 01:17:06PM +0300, Yury Kotov wrote:
> 15.04.2019, 13:11, "Daniel P. Berrangé" :
> > On Mon, Apr 15, 2019 at 12:50:08PM +0300, Yury Kotov wrote:
> >> Hi,
> >>
> >> Just to clarify. I see two possible solutions:
> >>
> >> 1) Since the migration code doesn't receive fd, it i
On Fri, Apr 12, 2019 at 03:21:56PM +0530, Devesh Sharma wrote:
> On Thu, Apr 11, 2019 at 11:11 PM Yuval Shaia wrote:
> >
> > On Thu, Apr 11, 2019 at 08:34:20PM +0300, Yuval Shaia wrote:
> > > On Thu, Apr 11, 2019 at 05:24:08PM +, Jason Gunthorpe wrote:
> > > > On Thu, Apr 11, 2019 at 07:02:15P
On Mon, Apr 15, 2019 at 12:23:18PM +0200, Philippe Mathieu-Daudé wrote:
> On 4/13/19 8:44 AM, Richard Henderson wrote:
> > On 4/10/19 11:49 PM, Philippe Mathieu-Daudé wrote:
> >>> -if (seed_optarg != NULL) {
> >>> -qemu_guest_random_seed_main(seed_optarg, &error_fatal);
> >>> +{
> >
15.04.2019, 13:25, "Daniel P. Berrangé" :
> On Mon, Apr 15, 2019 at 01:17:06PM +0300, Yury Kotov wrote:
>> 15.04.2019, 13:11, "Daniel P. Berrangé" :
>> > On Mon, Apr 15, 2019 at 12:50:08PM +0300, Yury Kotov wrote:
>> >> Hi,
>> >>
>> >> Just to clarify. I see two possible solutions:
>> >>
>>
On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornelia Huck wrote:
> On Thu, 11 Apr 2019 14:01:54 +0300
> Yuval Shaia wrote:
>
> > Data center backends use more and more RDMA or RoCE devices and more and
> > more software runs in virtualized environment.
> > There is a need for a standard to enable R
On 4/14/19 11:24 PM, Hervé Poussineau wrote:
> Le 14/04/2019 à 20:53, Artyom Tarasenko a écrit :
>> On Sun, Apr 14, 2019 at 7:01 PM Hervé Poussineau
>> wrote:
>>>
>>> Le 12/04/2019 à 23:06, Artyom Tarasenko a écrit :
AIX 5.1 expects the base year to be 1900. Adjust accordingly.
Sign
On Mon, Apr 15, 2019 at 12:36 PM Philippe Mathieu-Daudé
wrote:
>
> On 4/14/19 11:24 PM, Hervé Poussineau wrote:
> > Le 14/04/2019 à 20:53, Artyom Tarasenko a écrit :
> >> On Sun, Apr 14, 2019 at 7:01 PM Hervé Poussineau
> >> wrote:
> >>>
> >>> Le 12/04/2019 à 23:06, Artyom Tarasenko a écrit :
> >
On Mon, Apr 15, 2019 at 01:33:21PM +0300, Yury Kotov wrote:
> 15.04.2019, 13:25, "Daniel P. Berrangé" :
> > On Mon, Apr 15, 2019 at 01:17:06PM +0300, Yury Kotov wrote:
> >> 15.04.2019, 13:11, "Daniel P. Berrangé" :
> >> > On Mon, Apr 15, 2019 at 12:50:08PM +0300, Yury Kotov wrote:
> >> >> Hi,
>
On 12/04/19 20:36, Eduardo Habkost wrote:
>> let's deprecate the old -realtime option.
>>
>> Signed-off-by: Thomas Huth
> Reviewed-by: Eduardo Habkost
>
> Paolo, do you want to queue this, or should I do it through the
> machine queue?
>
> -- Eduardo
I have just queued it.
Paolo
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Mon, Apr 15, 2019 at 01:33:21PM +0300, Yury Kotov wrote:
> > 15.04.2019, 13:25, "Daniel P. Berrangé" :
> > > On Mon, Apr 15, 2019 at 01:17:06PM +0300, Yury Kotov wrote:
> > >> 15.04.2019, 13:11, "Daniel P. Berrangé" :
> > >> > On Mon, Apr 15,
On Mon, Apr 15, 2019 at 12:15:12PM +0100, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > On Mon, Apr 15, 2019 at 01:33:21PM +0300, Yury Kotov wrote:
> > > 15.04.2019, 13:25, "Daniel P. Berrangé" :
> > > > On Mon, Apr 15, 2019 at 01:17:06PM +0300, Yury Kotov wr
* Paolo Bonzini (pbonz...@redhat.com) wrote:
>
> - Cole Robinson ha scritto:
> > On 4/12/19 3:47 AM, Paolo Bonzini wrote:
> > > On 10/04/19 20:26, Cole Robinson wrote:
> > >> On 11/20/18 6:44 AM, Dr. David Alan Gilbert wrote:
> > >>> * Paolo Bonzini (pbonz...@redhat.com) wrote:
> > Neste
On 13.4.19. 18:05, Aleksandar Markovic wrote:
On Thu, Apr 4, 2019 at 3:16 PM Mateja Marjanovic
wrote:
From: Mateja Marjanovic
Optimized ILVR. instructions, using a hybrid
Optimized -> Optimize
approach. For byte data elements, use a helper with an
unrolled loop (much better performance),
On 15/04/19 13:22, Dr. David Alan Gilbert wrote:
> * Paolo Bonzini (pbonz...@redhat.com) wrote:
>>
>> - Cole Robinson ha scritto:
>>> On 4/12/19 3:47 AM, Paolo Bonzini wrote:
On 10/04/19 20:26, Cole Robinson wrote:
> On 11/20/18 6:44 AM, Dr. David Alan Gilbert wrote:
>> * Paolo Bo
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Mon, Apr 15, 2019 at 12:15:12PM +0100, Dr. David Alan Gilbert wrote:
> > * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > > On Mon, Apr 15, 2019 at 01:33:21PM +0300, Yury Kotov wrote:
> > > > 15.04.2019, 13:25, "Daniel P. Berrangé" :
> > >
Localization is not a feature whose impact is limited to the UI
frontends. Other parts of QEMU rely in localization. In particular the
USB MTP driver needs to be able to convert filenames from the locale
specified character set into UTF-16 / UCS-2 encoded wide characters.
setlocale() is only set fr
Daniel P. Berrangé, le lun. 15 avril 2019 12:34:31 +0100, a ecrit:
> Hardcoding LC_CTYPE to C.UTF-8 is a partial regression vs the above
> curses commit, since it will break the curses wide character handling
> for non-UTF-8 locales but this is unavoidable until QEMU is cleaned up
> to cope with no
On 4/15/19 1:34 PM, Daniel P. Berrangé wrote:
> Localization is not a feature whose impact is limited to the UI
> frontends. Other parts of QEMU rely in localization. In particular the
> USB MTP driver needs to be able to convert filenames from the locale
> specified character set into UTF-16 / UCS
On Fri, 1 Mar 2019 10:38:56 +0100
Cornelia Huck wrote:
> [This is the Linux kernel part, git tree is available at
> https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/vfio-ccw.git
> vfio-ccw-eagain-caps-v3
>
> The companion QEMU patches are available at
> https://github.com/cohuck/qemu vf
From: "Dr. David Alan Gilbert"
Gcc 9 needs some convincing that sopreprbuf really is going to fill
in iov in the call from soreadbuf, even though the failure case
shouldn't happen.
Signed-off-by: Dr. David Alan Gilbert
---
slirp/src/socket.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
* Samuel Thibault (samuel.thiba...@gnu.org) wrote:
> Dr. David Alan Gilbert, le ven. 12 avril 2019 16:49:42 +0100, a ecrit:
> > * Samuel Thibault (samuel.thiba...@gnu.org) wrote:
> > > Hello,
> > >
> > > Dr. David Alan Gilbert, le lun. 08 avril 2019 09:46:53 +0100, a ecrit:
> > > > 'soread' has th
Dr. David Alan Gilbert (git), le lun. 15 avril 2019 13:02:05 +0100, a ecrit:
> From: "Dr. David Alan Gilbert"
>
> Gcc 9 needs some convincing that sopreprbuf really is going to fill
> in iov in the call from soreadbuf, even though the failure case
> shouldn't happen.
>
> Signed-off-by: Dr. David
Patchew URL: https://patchew.org/QEMU/20190415120205.2221-1-dgilb...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190415120205.2221-1-dgilb...@redhat.com
Subject: [Qemu-devel] [PATCH v2] slirp: Gcc 9 -O3 fix
Type: se
* Samuel Thibault (samuel.thiba...@gnu.org) wrote:
> Dr. David Alan Gilbert (git), le lun. 15 avril 2019 13:02:05 +0100, a ecrit:
> > From: "Dr. David Alan Gilbert"
> >
> > Gcc 9 needs some convincing that sopreprbuf really is going to fill
> > in iov in the call from soreadbuf, even though the f
From: "Dr. David Alan Gilbert"
Gcc 9 needs some convincing that sopreprbuf really is going to fill
in iov in the call from soreadbuf, even though the failure case
shouldn't happen.
Signed-off-by: Dr. David Alan Gilbert
---
slirp/src/socket.c | 5 -
1 file changed, 4 insertions(+), 1 deleti
Thanks! This is presumed fixed in Ubuntu also then, since 18.04 onwards
shipped a qemu version higher than 2.10.0. If this is wrong, please
reopen.
** Changed in: qemu (Ubuntu)
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-
15.04.2019, 14:30, "Dr. David Alan Gilbert" :
> * Daniel P. Berrangé (berra...@redhat.com) wrote:
>> On Mon, Apr 15, 2019 at 12:15:12PM +0100, Dr. David Alan Gilbert wrote:
>> > * Daniel P. Berrangé (berra...@redhat.com) wrote:
>> > > On Mon, Apr 15, 2019 at 01:33:21PM +0300, Yury Kotov wrote:
>
Patchew URL: https://patchew.org/QEMU/20190415121740.9881-1-dgilb...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190415121740.9881-1-dgilb...@redhat.com
Subject: [Qemu-devel] [PATCH v3] slirp: Gcc 9 -O3 fix
Type: se
Patchew URL:
https://patchew.org/QEMU/20190415113431.12060-1-berra...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
On 4/15/19 9:03 AM, Wei Yang wrote:
> This is obvious the member in AcpiMcfgInfo describe MCFG's property.
>
> Remove the mcfg_ prefix.
>
> Signed-off-by: Wei Yang
> Suggested-by: Igor Mammedov
> ---
> hw/i386/acpi-build.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
On 4/15/19 9:03 AM, Wei Yang wrote:
> To build MCFG, two information is necessary:
>
> * bus number
> * base address
>
> Abstract these two information to AcpiMcfgInfo so that build_mcfg and
> build_mcfg_q35 will have the same declaration.
>
> Signed-off-by: Wei Yang
>
> ---
> v2:
>
Hi Wei,
On 4/15/19 9:03 AM, Wei Yang wrote:
> Now we have two identical build_mcfg function.
>
> Extract them to pci.c.
>
> Signed-off-by: Wei Yang
>
> ---
> v2:
> * put it to dedicated file pci.c
> ---
> default-configs/arm-softmmu.mak | 1 +
> default-configs/i386-softmmu.mak | 1 +
>
On 4/15/19 9:03 AM, Wei Yang wrote:
> mcfg_start points to the start of MCFG table and is used in
> build_header. While this information could be derived from mcfg.
>
> This patch removes the unnecessary variable mcfg_start.
>
> Signed-off-by: Wei Yang
> Reviewed-by: Igor Mammedov
> ---
> hw/a
Hi, I also found a problem that qemu-img convert hands in ARM.
The convert command line is "qemu-img convert -f qcow2 -O raw disk.qcow2
disk.raw ".
The bt is below:
Thread 2 (Thread 0x4b776e50 (LWP 27215)):
#0 0x4a3f2994 in sigtimedwait () from /lib64/libc.so.6
#1 0x4a39c60c
Vladimir Sementsov-Ogievskiy writes:
> 15.04.2019 8:51, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> It would be nice to have Error object not freed away when debugging a
>>> coredump.
>>>
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy
>>> ---
>>> util/error.c | 8
Public bug reported:
Using any Linux image (in this case Alpine Linux iso) I want to utilise
all cores of my Raspberry with --accel,thread=multi. I know there is a
probably still problem with memory ordering of the host, but I have also
seen some very old commits which could potentially help with
Hi,
During live migration, the folloing log can see in nova-compute.log in my
environment:
ERROR nova.virt.libvirt.driver [req-039a85e1-e7a1-4a63-bc6d-c4b9a044aab6
0cdab20dc79f4bc6ae5790e7b4a898ac 3363c319773549178acc67f32c78310e - default
default] [instance: 5ec719f4-1865-4afe-a207-3d9fae22c410
memory_region_allocate_system_memory() was designed to be called for
allocating inital RAM. Using it mutiple times within one board is not
supported and could fail if -mem-path with non hugepage path is used.
Keep using memory_region_allocate_system_memory() only for initial
RAM and use memory_reg
rs6000mc_realize() violates memory_region_allocate_system_memory() contract
by calling it multiple times which could break -mem-path. Replace it with
plain memory_region_init_ram() instead.
Signed-off-by: Igor Mammedov
---
hw/ppc/rs6000_mc.c | 15 ++-
1 file changed, 10 insertions(+)
use qemu_ram_alloc_from_ptr() to create aliased RAMBlock
to the part of original memory region.
Signed-off-by: Igor Mammedov
---
exec.c | 7 ---
memory.c | 5 +
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/exec.c b/exec.c
index 6ab62f4..0fc10d1 100644
--- a/exec.c
+++
memory_region_allocate_system_memory() is supposed to be called only once,
but due to lack of the check some boards abused it by calling it multiple
times.
So here goes fixes that replace it with memory_region_init_ram() in most of
the cases.
However s390 case a bit convolted as we have to kee
machine_hppa_init() violates memory_region_allocate_system_memory() contract
by calling it multiple times which could break with -mem-path. Replace
the second usage (for 'rom') with memory_region_init_ram() instead.
Signed-off-by: Igor Mammedov
---
hw/hppa/machine.c | 5 ++---
1 file changed, 2
s390 was trying to solve limited memslot size issue by abusing
memory_region_allocate_system_memory(), which breaks API contract
where the function might be called only once.
s390 should have used memory aliases to fragment inital memory into
smaller chunks to satisfy KVM's memslot limitation. But
15.04.2019 16:08, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy writes:
>
>> 15.04.2019 8:51, Markus Armbruster wrote:
>>> Vladimir Sementsov-Ogievskiy writes:
>>>
It would be nice to have Error object not freed away when debugging a
coredump.
Signed-off-by: Vladimi
On 13.4.19. 18:05, Aleksandar Markovic wrote:
On Thu, Apr 4, 2019 at 3:18 PM Mateja Marjanovic
wrote:
From: Mateja Marjanovic
Optimize set of MSA instructions ILVEV., using
directly tcg registers and performing logic on them
instead of using helpers.
In the following table, the first colum
Fix the math involving non standard doorbell stride
Signed-off-by: Maxim Levitsky
---
block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/nvme.c b/block/nvme.c
index 2d208000df..208242cf1f 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -216,7 +216,7 @@ static
Signed-off-by: Maxim Levitsky
---
block/nvme.c | 81 ++
block/trace-events | 2 ++
2 files changed, 83 insertions(+)
diff --git a/block/nvme.c b/block/nvme.c
index 5121e809f0..386c2508b7 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -110,6 +11
Phase bits are only set by the hardware to indicate new completions
and not by the device driver.
Signed-off-by: Maxim Levitsky
---
block/nvme.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/nvme.c b/block/nvme.c
index 0684bbd077..2d208000df 100644
--- a/block/nvme.c
+++ b/block/nvm
CC: Fam Zheng
CC: Kevin Wolf
CC: Max Reitz
CC: qemu-devel@nongnu.org
Hi!
These are few assorted fixes and features for the userspace
nvme driver.
Tested that on my laptop with my Samsung X5 thunderbolt drive, which
happens to have 4K sectors, support for discard and write zeros.
Also bunch o
Currently the driver hardcodes the sector size to 512,
and doesn't check the underlying device
Signed-off-by: Maxim Levitsky
---
block/nvme.c | 40 +++-
1 file changed, 35 insertions(+), 5 deletions(-)
diff --git a/block/nvme.c b/block/nvme.c
index 208242cf1f
Signed-off-by: Maxim Levitsky
---
block/nvme.c | 69 +++-
block/trace-events | 1 +
include/block/nvme.h | 17 ++-
3 files changed, 85 insertions(+), 2 deletions(-)
diff --git a/block/nvme.c b/block/nvme.c
index 0d9b521760..5121e809f0 10
On Mon, 15 Apr 2019 15:03:05 +0800
Wei Yang wrote:
> This is obvious the member in AcpiMcfgInfo describe MCFG's property.
>
> Remove the mcfg_ prefix.
>
> Signed-off-by: Wei Yang
> Suggested-by: Igor Mammedov
Reviewed-by: Igor Mammedov
> ---
> hw/i386/acpi-build.c | 14 +++---
> 1
On Mon, 15 Apr 2019 15:03:06 +0800
Wei Yang wrote:
> To build MCFG, two information is necessary:
>
> * bus number
> * base address
>
> Abstract these two information to AcpiMcfgInfo so that build_mcfg and
> build_mcfg_q35 will have the same declaration.
>
> Signed-off-by: Wei Yang
>
On Mon, 15 Apr 2019 15:03:07 +0800
Wei Yang wrote:
> Now we have two identical build_mcfg function.
s/function./functions,/
>
> Extract them to pci.c.
s|.*|consolidate them in acpi/pci.c|
>
> Signed-off-by: Wei Yang
with above and Philippe's comment addressed
Reviewed-by: Igor Mammedov
Localization is not a feature whose impact is limited to the UI
frontends. Other parts of QEMU rely in localization. In particular the
USB MTP driver needs to be able to convert filenames from the locale
specified character set into UTF-16 / UCS-2 encoded wide characters.
setlocale() is only set fr
On Mon, 15 Apr 2019 15:03:03 +0800
Wei Yang wrote:
> This patch set tries to generalize MCFG table build process.
1.
series should reference not merged dependency if any exists.
in this case "[PATCH for-4.1] q35: acpi: do not create dummy MCFG table"
or as alternative include and repost that pa
On Mon, 15 Apr 2019 at 15:17, Daniel P. Berrangé wrote:
>
> Localization is not a feature whose impact is limited to the UI
> frontends. Other parts of QEMU rely in localization. In particular the
> USB MTP driver needs to be able to convert filenames from the locale
> specified character set into
It would be nice to have Error object not freed away when debugging a
coredump.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
v2: don't change error output format
util/error.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/util/error.c b/util/error.c
index 934a78e1b1
On 3/1/19 4:39 AM, Cornelia Huck wrote:
Allow to extend the regions used by vfio-ccw. The first user will be
handling of halt and clear subchannel.
Signed-off-by: Cornelia Huck
Reviewed-by: Eric Farman
---
drivers/s390/cio/vfio_ccw_ops.c | 186
driver
Do full, top and incremental mode copying all in one place. This
unifies the code path and helps further improvements.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/backup.c | 43 ++-
1 file changed, 10 insertions(+), 33 deletions(-)
diff --git a/
Split out cluster_size calculation. Move copy-bitmap creation above
block-job creation, as we are going to share it with upcoming
backup-top filter, which also should be created before actual block job
creation.
Also, while being here, drop unnecessary "goto error" from
bdrv_getlength error path.
Hi all!
Here some refactoring patches, as a first step for backup-top filter
introduction.
v6:
01: - use end_cluster instead of last_cluster and fix bug in
calculation [Max]
02: only rebased on 01, keep r-b
03, 04: new
05: it's rewritten
"[PATCH v5 10/11] block/backup: tiny refactor bac
Simplify backup_incremental_init_copy_bitmap using the function
bdrv_dirty_bitmap_next_dirty_area.
Note: move to job->len instead of bitmap size: it should not matter but
less code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/backup.c | 40
1 f
Split allocation checking to separate function and reduce nesting.
Consider bdrv_is_allocated() fail as allocated area, as copying more
than needed is not wrong (and we do it anyway) and seems better than
fail the whole job. And, most probably we will fail on the next read,
if there are real proble
We are going to share this bitmap between backup and backup-top filter
driver, so let's share something more meaningful. It also simplifies
some calculations.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
block/backup.c | 48 +++--
sorry, I make a spelling mistake here（"Hi, I also found a problem that
qemu-img convert hands in ARM."）.The right is "I also found a problem
that qemu-img convert hangs in ARM".
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://
* fengyd (fengy...@gmail.com) wrote:
> Hi,
>
> During live migration, the folloing log can see in nova-compute.log in my
> environment:
> ERROR nova.virt.libvirt.driver [req-039a85e1-e7a1-4a63-bc6d-c4b9a044aab6
> 0cdab20dc79f4bc6ae5790e7b4a898ac 3363c319773549178acc67f32c78310e - default
> defau
On 3/1/19 4:39 AM, Cornelia Huck wrote:
Add a region to the vfio-ccw device that can be used to submit
asynchronous I/O instructions. ssch continues to be handled by the
existing I/O region; the new region handles hsch and csch.
Interrupt status continues to be reported through the same chann
On 4/15/19 3:27 PM, Igor Mammedov wrote:
> memory_region_allocate_system_memory() was designed to be called for
> allocating inital RAM. Using it mutiple times within one board is not
> supported and could fail if -mem-path with non hugepage path is used.
>
> Keep using memory_region_allocate_syst
Do you find the cause of the bug and fix it?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1788582
Title:
Race condition during shutdown
Status in QEMU:
New
Bug description:
I ran into a bug
On 4/15/19 3:27 PM, Igor Mammedov wrote:
> machine_hppa_init() violates memory_region_allocate_system_memory() contract
> by calling it multiple times which could break with -mem-path. Replace
> the second usage (for 'rom') with memory_region_init_ram() instead.
>
> Signed-off-by: Igor Mammedov
>
1 - 100 of 189 matches
Mail list logo
