[Qemu-devel] [PULL 8/8] accel: Unbreak accelerator fallback

2019-04-02 Thread Markus Armbruster
When the user specifies a list of accelerators, we pick the first one that initializes successfully. Recent commit 1a3ec8c1564 broke that. Reproducer: $ qemu-system-x86_64 --machine accel=xen:tcg xencall: error: Could not obtain handle on privileged command interface: No such file or dir

[Qemu-devel] [PULL 1/3] tests: refactor file monitor test to make it more understandable

2019-04-02 Thread Daniel P . Berrangé
The current file monitor unit tests are too clever for their own good making it hard to understand the desired output. Instead of trying to infer the expected events, explicitly list the events we expect in the operation sequence. Instead of dynamically building a matrix of tests, just have one g

Re: [Qemu-devel] [PATCH v2] vl.c: make current_machine as non-global variable

2019-04-02 Thread Like Xu
On 2019/4/2 19:27, Markus Armbruster wrote: Like Xu writes: This patch makes the remaining dozen or so uses of the global current_machine outside vl.c use qdev_get_machine() instead, and then make current_machine local to vl.c instead of global. Signed-off-by: Like Xu You effectively repla

[Qemu-devel] [PULL 2/3] filemon: ensure watch IDs are unique to QFileMonitor scope

2019-04-02 Thread Daniel P . Berrangé
The watch IDs are mistakenly only unique within the scope of the directory being monitored. This is not useful for clients which are monitoring multiple directories. They require watch IDs to be unique globally within the QFileMonitor scope. Reviewed-by: Marc-André Lureau Tested-by: Bandan Das R

Re: [Qemu-devel] [RFC PATCH] aio: Add a knob to always poll if there are in-flight requests

2019-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190402121908.44081-1-...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bi

[Qemu-devel] [PULL 3/3] filemon: fix watch IDs to avoid potential wraparound issues

2019-04-02 Thread Daniel P . Berrangé
Watch IDs are allocated from incrementing a int counter against the QFileMonitor object. In very long life QEMU processes with a huge amount of USB MTP activity creating & deleting directories it is just about conceivable that the int counter can wrap around. This would result in incorrect behaviou

Re: [Qemu-devel] [PATCH v2 4/5] vl: Document dependencies hiding in global and compat props

2019-04-02 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Signed-off-by: Markus Armbruster >> --- >> vl.c | 24 ++-- >> 1 file changed, 22 insertions(+), 2 deletions(-) >> >> diff --git a/vl.c b/vl.c >> index e4d7ad6b85..8c6d06b01d 100644 >> --- a

[Qemu-devel] Unknown X11 keycode mapping report

2019-04-02 Thread Jean-Louis SOLATGES
Bonjour, par tightvnc server sur clipper depuis un linux connecté en vncviewer, je lance : qemu-system-x86_64 -m 16G -cpu kvm64 -accel kvm,thread=multi -smp 6,maxcpus=12 -net nic -net tap -net socket,listen=127.0.0.1:1234 -vga cirrus -boot c -hda uis1.img root@clipper:/home/jls/data# ** (qemu

Re: [Qemu-devel] [PATCH] curses: fix wchar_t printf warning

2019-04-02 Thread Eric Blake
On 4/2/19 2:30 AM, Gerd Hoffmann wrote: > On some systems wchar_t is "long int", on others just "int". And elsewhere, it's 'short'. > So go cast to "long int" and adjust the printf format accordingly. > > Reported-by: Mark Cave-Ayland > Signed-off-by: Gerd Hoffmann > --- > ui/curses.c | 4 ++-

[Qemu-devel] [PULL 0/8] Miscellaneous patches for 2019-04-02

2019-04-02 Thread Markus Armbruster
Two regression fixes for 4.0: * Unbreak migration for Xen * Unbreak accelerator fallback Three safe bug fixes thrown in: * Fix error location of qemu-system-FOO positional arguments * COLOStatus minor doc fix * COLOStatus member rename to conform to naming rules Markus Armbruster (6): vl: Fix

[Qemu-devel] [PULL 1/8] vl: Fix error location of positional arguments

2019-04-02 Thread Markus Armbruster
We blame badness in positional arguments on the last option argument: $ qemu-system-x86_64 -vnc :1 bad.img qemu-system-x86_64: -vnc :1: Could not open 'foo': No such file or directory I believe we've done this ever since we reported locations. Fix it to qemu-system-x86_64: bad.img:

[Qemu-devel] [PATCH 3/4] vl: Clean up after previous commit

2019-04-02 Thread Markus Armbruster
Since the previous commit, find_machine() and find_default_machine() don't have to deallocate on return. This permits further simplifications. Signed-off-by: Markus Armbruster --- vl.c | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/vl.c b/vl.c ind

Re: [Qemu-devel] [RFC for-4.1 4/5] pci: Simplify pci_bus_is_root()

2019-04-02 Thread Greg Kurz
On Tue, 2 Apr 2019 16:40:27 +1100 David Gibson wrote: > pci_bus_is_root() currently relies on a method in the PCIBusClass. > But it's always known if a PCI bus is a root bus when we create it, so > using a dynamic method is overkill. > > This replaces it with an IS_ROOT bit in a new flags field

Re: [Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup

2019-04-02 Thread Markus Armbruster
Wei Yang writes: > Now all the functions used to select machine is local and the call flow > looks like below: > > select_machine() > find_default_machine() > machine_parse() > find_machine() > > All these related function will need a GSList for TYPE_MACHINE. > Cur

Re: [Qemu-devel] Unknown X11 keycode mapping report

2019-04-02 Thread Daniel P . Berrangé
On Tue, Apr 02, 2019 at 02:47:25PM +0200, Jean-Louis SOLATGES wrote: > Bonjour, par tightvnc server sur clipper depuis un linux connecté en > vncviewer, Google translate doesn't do a good job here. Is this saying that you are running QEMU from inside a TightVNC server session running on Linux ?

[Qemu-devel] [PATCH 4/4] vl: Simplify machine_parse()

2019-04-02 Thread Markus Armbruster
Exploit that argument @name is nerver null. Check is_help_option() first, because that's what we do elsewhere. Signed-off-by: Markus Armbruster --- vl.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/vl.c b/vl.c index 6a31e5bfac..da1af3e10d 100644

Re: [Qemu-devel] [PATCH v3 2/2] vfio-ccw: support async command subregion

2019-04-02 Thread Cornelia Huck
On Thu, 21 Mar 2019 21:38:16 -0400 Eric Farman wrote: > On 3/1/19 4:39 AM, Cornelia Huck wrote: > > A vfio-ccw device may provide an async command subregion for > > issuing halt/clear subchannel requests. If it is present, use > > it for sending halt/clear request to the device; if not, fall > >

[Qemu-devel] [PATCH v4 4/5] target/mips: Refactor and fix COPY_U. instructions

2019-04-02 Thread Mateja Marjanovic
From: Mateja Marjanovic The old version of the helper for the COPY_U. MSA instructions has been replaced with four helpers that don't use switch, and change the endianness of the given index, when executed on a big endian host. Signed-off-by: Mateja Marjanovic --- target/mips/helper.h | 4

[Qemu-devel] [PATCH v4 1/5] target/mips: Fix MSA instructions LD. on big endian host

2019-04-02 Thread Mateja Marjanovic
From: Mateja Marjanovic Fix the case when the host is a big endian machine, and change the approach toward LD. instruction helpers. Signed-off-by: Mateja Marjanovic --- target/mips/op_helper.c | 188 ++-- 1 file changed, 168 insertions(+), 20 deletio

[Qemu-devel] [PATCH v4 3/5] target/mips: Refactor and fix COPY_S. instructions

2019-04-02 Thread Mateja Marjanovic
From: Mateja Marjanovic The old version of the helper for the COPY_S. MSA instructions has been replaced with four helpers that don't use switch, and change the endianness of the given index, when executed on a big endian host. Signed-off-by: Mateja Marjanovic --- target/mips/helper.h | 7

[Qemu-devel] [PATCH v4 0/5] target/mips: Fix support for MSA instructions on a big endian host

2019-04-02 Thread Mateja Marjanovic
From: Mateja Marjanovic Fix support for MSA instructions while executing QEMU on a machine that uses big endian MIPS CPU. This is achieved by changing the implementation of helpers for MSA instructions ST., LD., INSERT. (and D on MIPS64), COPY_S. (and D on MIPS64) and COPY_U. (and W on MIPS64). I

Re: [Qemu-devel] [PATCH v3 0/2] vfio-ccw: support hsch/csch (QEMU part)

2019-04-02 Thread Cornelia Huck
On Thu, 21 Mar 2019 21:49:54 -0400 Eric Farman wrote: > On 3/1/19 4:39 AM, Cornelia Huck wrote: > > > > [I'm not quite happy with how this async processing hooks up in css.c; > > ideas welcome.] > > I guess I'm not unhappy with it, but it does look a little odd. Not > sure I have a better i

[Qemu-devel] [PATCH v4 2/5] target/mips: Fix MSA instructions ST. on big endian host

2019-04-02 Thread Mateja Marjanovic
From: Mateja Marjanovic Fix the case when the host is a big endian machine, and change the approach toward ST. instruction helpers. Signed-off-by: Mateja Marjanovic --- target/mips/op_helper.c | 188 ++-- 1 file changed, 168 insertions(+), 20 deletio

[Qemu-devel] [PATCH v4 5/5] target/mips: Refactor and fix INSERT. instructions

2019-04-02 Thread Mateja Marjanovic
From: Mateja Marjanovic The old version of the helper for the INSERT. MSA instructions has been replaced with four helpers that don't use switch, and change the endianness of the given index, when executed on a big endian host. Signed-off-by: Mateja Marjanovic --- target/mips/helper.h | 5

Re: [Qemu-devel] [PULL 0/9] Block layer patches

2019-04-02 Thread Peter Maydell
On Tue, 2 Apr 2019 at 19:49, Kevin Wolf wrote: > > The following changes since commit d61d1a1fb2f1db6c54651844a28389c523f3f8c7: > > Merge remote-tracking branch > 'remotes/kraxel/tags/fixes-20190402-pull-request' into staging (2019-04-02 > 08:18:24 +0100)

Re: [Qemu-devel] [RFC for-4.1 5/5] pcie: Simplify pci_adjust_config_limit()

2019-04-02 Thread Greg Kurz
On Tue, 2 Apr 2019 16:40:28 +1100 David Gibson wrote: > Since c2077e2c "pci: Adjust PCI config limit based on bus topology", > pci_adjust_config_limit() has been used in the config space read and write > paths to only permit access to extended config space on buses which permit > it. Specifical

Re: [Qemu-devel] [PULL 0/8] Miscellaneous patches for 2019-04-02

2019-04-02 Thread Peter Maydell
Hi Markus -- this pullreq seems to be missing the git url and tag to merge. Could you fix it up and resend the cover letter, please? thanks -- PMM On Tue, 2 Apr 2019 at 20:25, Markus Armbruster wrote: > > Two regression fixes for 4.0: > > * Unbreak migration for Xen > * Unbreak accelerator fall

[Qemu-devel] [Bug 1567254] Re: qemu-2.5.1 will not run with gtk3/vte

2019-04-02 Thread John Frankish
Things seem to work with gtk3 and qemu-3.1.0 - I didn't try vte though... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1567254 Title: qemu-2.5.1 will not run with gtk3/vte Status in QEMU: Incom

Re: [Qemu-devel] [PATCH 13/14] hw/s390x/ipl: avoid taking address of fields in packed struct

2019-04-02 Thread Farhan Ali
On 03/29/2019 07:11 AM, Daniel P. Berrangé wrote: Compiling with GCC 9 complains hw/s390x/ipl.c: In function ‘s390_ipl_set_boot_menu’: hw/s390x/ipl.c:256:25: warning: taking address of packed member of ‘struct QemuIplParameters’ may result in an unaligned pointer value [-Waddress-of-packed-

Re: [Qemu-devel] [PATCH 11/14] hw/vfio/ccw: avoid taking address members in packed structs

2019-04-02 Thread Farhan Ali
On 03/29/2019 07:11 AM, Daniel P. Berrangé wrote: The GCC 9 compiler complains about many places in s390 code that take the address of members of the 'struct SCHIB' which is marked packed: hw/vfio/ccw.c: In function ‘vfio_ccw_io_notifier_handler’: hw/vfio/ccw.c:133:15: warning: taking address

Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-04-02 Thread Catherine Ho
On Tue, 2 Apr 2019 at 20:37, Peter Xu wrote: > On Tue, Apr 02, 2019 at 05:06:15PM +0800, Catherine Ho wrote: > > On Tue, 2 Apr 2019 at 15:58, Peter Xu wrote: > > > > > On Tue, Apr 02, 2019 at 03:47:16PM +0800, Catherine Ho wrote: > > > > Hi Peter Maydell > > > > > > > > On Tue, 2 Apr 2019 at 11:

[Qemu-devel] [Bug 1822798] [NEW] The hover of " Full list of releases " is not effective even not visible.

2019-04-02 Thread Jayshree Phulare
Public bug reported: The hover effect of "Full list of releases " on QEMU website that is https://www.qemu.org/ is not visible and hence effective so made it the issue on git hub and even committed it. ** Affects: qemu Importance: Undecided Assignee: Jayshree Phulare (jayshreephulare1)

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-02 Thread Shameerali Kolothum Thodi
Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: 01 April 2019 14:07 > To: Auger Eric ; Ard Biesheuvel > > Cc: peter.mayd...@linaro.org; sa...@linux.intel.com; > qemu-devel@nongnu.org; Shameerali Kolothum Thodi > ; Linuxarm > ; shannon.zha...@gmail.c

[Qemu-devel] [Bug 1822798] Re: The hover of " Full list of releases " is not effective even not visible.

2019-04-02 Thread Jayshree Phulare
The hover button color is changed so that is it effectively visible. line number 307 .button:hover { background: #8f1b1b; text-decoration: none; } ** Attachment added: "The hover button color is changed so that is it effectively visible.

Re: [Qemu-devel] [PULL 0/3] Filemon next patches

2019-04-02 Thread Peter Maydell
On Tue, 2 Apr 2019 at 20:10, Daniel P. Berrangé wrote: > > The following changes since commit d61d1a1fb2f1db6c54651844a28389c523f3f8c7: > > Merge remote-tracking branch > 'remotes/kraxel/tags/fixes-20190402-pull-request' into staging (2019-04-02 > 08:18:24 +0100)

Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-04-02 Thread Catherine Ho
On Tue, 2 Apr 2019 at 22:17, Catherine Ho wrote: > > > On Tue, 2 Apr 2019 at 20:37, Peter Xu wrote: > >> On Tue, Apr 02, 2019 at 05:06:15PM +0800, Catherine Ho wrote: >> > On Tue, 2 Apr 2019 at 15:58, Peter Xu wrote: >> > >> > > On Tue, Apr 02, 2019 at 03:47:16PM +0800, Catherine Ho wrote: >> >

Re: [Qemu-devel] [PATCH 3/3] block/stream: introduce a bottom node

2019-04-02 Thread Alberto Garcia
On Tue 02 Apr 2019 10:51:06 AM CEST, Andrey Shinkevich wrote: > @@ -3237,7 +3238,14 @@ void qmp_block_stream(bool has_job_id, const char > *job_id, const char *device, >job_flags |= JOB_MANUAL_DISMISS; >} > > -stream_start(has_job_id ? job_id : N

Re: [Qemu-devel] Want to contribute in this project.

2019-04-02 Thread Yuval Shaia
Hi, I guess you read the basic instructions from here: https://www.qemu.org/contribute/. What kind of project you are looking for? What is the scope of of the project? i.e. some minor bug fixes, some minor enactments, a major project etc. Do you have a contribution to some other open source projec

Re: [Qemu-devel] Unknown X11 keycode mapping report

2019-04-02 Thread Philippe Mathieu-Daudé
On 4/2/19 3:28 PM, Daniel P. Berrangé wrote: > On Tue, Apr 02, 2019 at 02:47:25PM +0200, Jean-Louis SOLATGES wrote: >> Bonjour, par tightvnc server sur clipper depuis un linux connecté en >> vncviewer, > > Google translate doesn't do a good job here. Google isn't that wrong here, I'm also having

Re: [Qemu-devel] [PATCH] curses: fix wchar_t printf warning

2019-04-02 Thread Philippe Mathieu-Daudé
On 4/2/19 2:57 PM, Eric Blake wrote: > On 4/2/19 2:30 AM, Gerd Hoffmann wrote: >> On some systems wchar_t is "long int", on others just "int". > > And elsewhere, it's 'short'. > >> So go cast to "long int" and adjust the printf format accordingly. >> >> Reported-by: Mark Cave-Ayland >> Signed-of

Re: [Qemu-devel] [PATCH 1/2] vl.c: make find_default_machine() local

2019-04-02 Thread Wei Yang
On Tue, Apr 02, 2019 at 08:33:08AM +0200, Markus Armbruster wrote: >Wei Yang writes: > >> Function find_default_machine() is introduced by commit 2c8cffa599b7 >> "vl: make find_default_machine externally visible", while it seems no >> one outside use it. >It was used outside of vl.c until commit a

[Qemu-devel] [PULL v2 0/8] Miscellaneous patches for 2019-04-02

2019-04-02 Thread Markus Armbruster
The following changes since commit d61d1a1fb2f1db6c54651844a28389c523f3f8c7: Merge remote-tracking branch 'remotes/kraxel/tags/fixes-20190402-pull-request' into staging (2019-04-02 08:18:24 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull

Re: [Qemu-devel] [PATCH v2 1/2] target/mips: Make the results of DIV_. the same as on hardware

2019-04-02 Thread Philippe Mathieu-Daudé
Hi Mateja, On 4/2/19 2:11 PM, Mateja Marjanovic wrote: > From: Mateja Marjanovic > > MSA instructions DIV_. when dividing by zero, > didn't return the same value when executed on a referent hardware > (FPGA MIPS 64 r6, little endian) and when executed on QEMU, which > is not a real bug, because

[Qemu-devel] [PATCH v5 1/2] target/mips: Optimize ILVOD. MSA instructions

2019-04-02 Thread Mateja Marjanovic
From: Mateja Marjanovic Optimize set of MSA instructions ILVOD, using directly tcg registers and performing logic on them instead of using helpers. instr|| before|| after == ilvod.b || 117.50 ms || 24.99 ms ilvod.h || 93.16 ms || 24.27

Re: [Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup

2019-04-02 Thread Wei Yang
On Tue, Apr 02, 2019 at 03:28:48PM +0200, Markus Armbruster wrote: >Wei Yang writes: > >> Now all the functions used to select machine is local and the call flow >> looks like below: >> >> select_machine() >> find_default_machine() >> machine_parse() >> find_machine

[Qemu-devel] [PATCH v5 0/2] target/mips: Optimize MSA . instructions

2019-04-02 Thread Mateja Marjanovic
From: Mateja Marjanovic Optimize MSA instructions ILVEV. and ILVOD., using directly tcg registers and performing logic on them insted of using helpers. v5: - Use tcg_gen_deposit function. - Added performance number for no-deposit and with-deposit cases of ILVEV.W. - Minor changes in commit

[Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

2019-04-02 Thread Mateja Marjanovic
From: Mateja Marjanovic Optimize set of MSA instructions ILVEV, using directly tcg registers and performing logic on them instead of using helpers. In the following table, the first column is the performance before this patch. The second represents the performance, after converting from helpers

Re: [Qemu-devel] [PATCH 1/2] vl.c: make find_default_machine() local

2019-04-02 Thread Markus Armbruster
Wei Yang writes: > On Tue, Apr 02, 2019 at 08:33:08AM +0200, Markus Armbruster wrote: >>Wei Yang writes: >> >>> Function find_default_machine() is introduced by commit 2c8cffa599b7 >>> "vl: make find_default_machine externally visible", while it seems no >>> one outside use it. >>It was used out

Re: [Qemu-devel] Unknown X11 keycode mapping report

2019-04-02 Thread Daniel P . Berrangé
On Tue, Apr 02, 2019 at 02:47:25PM +0200, Jean-Louis SOLATGES wrote: > Bonjour, par tightvnc server sur clipper depuis un linux connecté en > vncviewer, > > je lance : > qemu-system-x86_64 -m 16G -cpu kvm64 -accel kvm,thread=multi -smp > 6,maxcpus=12 -net nic -net tap -net socket,listen=127.0.0.

Re: [Qemu-devel] [PATCH v2 1/2] target/mips: Make the results of DIV_. the same as on hardware

2019-04-02 Thread Mateja Marjanovic
On 2.4.19. 17:08, Philippe Mathieu-Daudé wrote: Hi Mateja, On 4/2/19 2:11 PM, Mateja Marjanovic wrote: From: Mateja Marjanovic MSA instructions DIV_. when dividing by zero, didn't return the same value when executed on a referent hardware (FPGA MIPS 64 r6, little endian) and when executed o

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-02 Thread Auger Eric
Hi Laszlo, On 4/1/19 3:07 PM, Laszlo Ersek wrote: > On 03/29/19 14:56, Auger Eric wrote: >> Hi Ard, >> >> On 3/29/19 2:14 PM, Ard Biesheuvel wrote: >>> On Fri, 29 Mar 2019 at 14:12, Auger Eric wrote: Hi Shameer, On 3/29/19 10:59 AM, Shameerali Kolothum Thodi wrote: > >

[Qemu-devel] [PATCH v2] migration: avoid filling ignore-shared ramblock when in incoming migration

2019-04-02 Thread Catherine Ho
Commit 18269069c310 ("migration: Introduce ignore-shared capability") addes ignore-shared capability to bypass the shared ramblock (e,g, membackend + numa node). It does good to live migration. This commit expectes that QEMU doesn't write to guest RAM until VM starts, but it does on aarch64 qemu:

[Qemu-devel] [PATCH v5 05/10] qcow2-threads: qcow2_co_do_compress: protect queuing by mutex

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
Drop dependence on AioContext lock. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Reviewed-by: Paolo Bonzini --- block/qcow2-threads.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/block/qcow2-threads.c b/block/qcow2-threads.c index 20

[Qemu-devel] [PATCH v5 00/10] qcow2: encryption threads

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
v5: rebase on master, some conflicts resolved due to data-file feature 01: new patch, just move test from cover letter to a file. I really hope that it will not hang the whole series, so, if we don't want it as is or with really tiny improvements, I'd prefer to skip it and queue 02-10 firs

[Qemu-devel] [PATCH v5 09/10] qcow2: bdrv_co_pwritev: move encryption code out of the lock

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
Encryption will be done in threads, to take benefit of it, we should move it out of the lock first. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a

[Qemu-devel] [PATCH v5 04/10] qcow2-threads: use thread_pool_submit_co

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
Use thread_pool_submit_co, instead of reinventing it here. Note, that thread_pool_submit_aio() never returns NULL, so checking it was an extra thing. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2-threads.c | 17 ++--- 1 file changed, 2 inser

[Qemu-devel] [PATCH v5 01/10] tests/perf: Test qemu-img convert from raw to encrypted qcow2

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/perf/block/qcow2/convert-to-encrypted | 48 + 1 file changed, 48 insertions(+) create mode 100755 tests/perf/block/qcow2/convert-to-encrypted diff --git a/tests/perf/block/qcow2/convert-to-encrypted b/tests/perf/block/qc

[Qemu-devel] [PATCH v5 08/10] qcow2: qcow2_co_preadv: skip using hd_qiov when possible

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
qemu_iovec_memset has @offset parameter, so using hd_qiov for it is not needed. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index fcf92a7e

[Qemu-devel] [PATCH v5 02/10] qcow2.h: add missing include

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
qcow2.h depends on block_int.h. Compilation isn't broken currently only due to block_int.h always included before qcow2.h. Though, it seems better to directly include block_int.h in qcow2.h. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2.h | 1 +

[Qemu-devel] [PATCH v5 06/10] qcow2-threads: split out generic path

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
Move generic part out of qcow2_co_do_compress, to reuse it for encryption and rename things that would be shared with encryption path. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2.h | 4 ++-- block/qcow2-threads.c | 47

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-02 Thread Laszlo Ersek
On 04/02/19 17:29, Auger Eric wrote: > Hi Laszlo, > > On 4/1/19 3:07 PM, Laszlo Ersek wrote: >> On 03/29/19 14:56, Auger Eric wrote: >>> Hi Ard, >>> >>> On 3/29/19 2:14 PM, Ard Biesheuvel wrote: On Fri, 29 Mar 2019 at 14:12, Auger Eric wrote: > > Hi Shameer, > > On 3/29/19 10

[Qemu-devel] [PATCH v5 07/10] qcow2: qcow2_co_preadv: improve locking

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
Background: decryption will be done in threads, to take benefit of it, we should move it out of the lock first. But let's go further: it turns out, that for locking around switch cases we have only two variants: when we just do memset(0) not releasing the lock (it is useless) and when we actually

[Qemu-devel] [PATCH v5 03/10] qcow2: add separate file for threaded data processing functions

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
Move compression-on-threads to separate file. Encryption will be in it too. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2.h | 7 ++ block/qcow2-threads.c | 201 ++ block/qcow2.c | 169 ---

Re: [Qemu-devel] QEMU and vIOMMU support for emulated VF passthrough to nested (L2) VM

2019-04-02 Thread Elijah Shakkour
> -Original Message- > From: Knut Omang > Sent: Monday, April 1, 2019 5:24 PM > To: Elijah Shakkour ; Peter Xu > > Cc: Michael S. Tsirkin ; Alex Williamson > ; Marcel Apfelbaum > ; Stefan Hajnoczi ; > qemu-devel@nongnu.org > Subject: Re: QEMU and vIOMMU support for emulated VF passthrou

[Qemu-devel] [PATCH v5 10/10] qcow2: do encryption in threads

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
Do encryption/decryption in threads, like it is already done for compression. This improves asynchronous encrypted io. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2.h | 8 ++ block/qcow2-cluster.c | 7 ++--- block/qcow2-threads.c | 65

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-02 Thread Auger Eric
Laszlo, On 4/2/19 5:38 PM, Laszlo Ersek wrote: > On 04/02/19 17:29, Auger Eric wrote: >> Hi Laszlo, >> >> On 4/1/19 3:07 PM, Laszlo Ersek wrote: >>> On 03/29/19 14:56, Auger Eric wrote: Hi Ard, On 3/29/19 2:14 PM, Ard Biesheuvel wrote: > On Fri, 29 Mar 2019 at 14:12, Auger Eric

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-02 Thread Laszlo Ersek
On 04/02/19 17:42, Auger Eric wrote: > Hi Laszlo, > > On 4/2/19 12:33 PM, Laszlo Ersek wrote: >> On 04/02/19 09:42, Igor Mammedov wrote: >>> On Mon, 1 Apr 2019 15:07:05 +0200 >>> Laszlo Ersek wrote: >>> On 03/29/19 14:56, Auger Eric wrote: > Hi Ard, > > On 3/29/19 2:14 PM, Ard Bi

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-02 Thread Auger Eric
Hi Laszlo, On 4/2/19 12:33 PM, Laszlo Ersek wrote: > On 04/02/19 09:42, Igor Mammedov wrote: >> On Mon, 1 Apr 2019 15:07:05 +0200 >> Laszlo Ersek wrote: >> >>> On 03/29/19 14:56, Auger Eric wrote: Hi Ard, On 3/29/19 2:14 PM, Ard Biesheuvel wrote: > On Fri, 29 Mar 2019 at 14:1

Re: [Qemu-devel] [PATCH v2] vl.c: make current_machine as non-global variable

2019-04-02 Thread Igor Mammedov
On Tue, 2 Apr 2019 21:09:39 +0800 Like Xu wrote: > On 2019/4/2 19:27, Markus Armbruster wrote: > > Like Xu writes: > > > >> This patch makes the remaining dozen or so uses of the global > >> current_machine outside vl.c use qdev_get_machine() instead, > >> and then make current_machine local

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-02 Thread Laszlo Ersek
On 04/02/19 17:52, Laszlo Ersek wrote: > On 04/02/19 17:42, Auger Eric wrote: > The firmware does consume DT: > > - If you start QEMU *with* "-no-acpi", then the DT is both consumed by > the firmware (for its own information needs), and passed on to the OS. > > - If you sta

Re: [Qemu-devel] [PULL v2 0/8] Miscellaneous patches for 2019-04-02

2019-04-02 Thread Peter Maydell
On Tue, 2 Apr 2019 at 22:10, Markus Armbruster wrote: > > The following changes since commit d61d1a1fb2f1db6c54651844a28389c523f3f8c7: > > Merge remote-tracking branch > 'remotes/kraxel/tags/fixes-20190402-pull-request' into staging (2019-04-02 > 08:18:24 +0100)

Re: [Qemu-devel] [PATCH 11/14] hw/vfio/ccw: avoid taking address members in packed structs

2019-04-02 Thread Cornelia Huck
On Fri, 29 Mar 2019 11:11:01 + Daniel P. Berrangé wrote: > The GCC 9 compiler complains about many places in s390 code > that take the address of members of the 'struct SCHIB' which > is marked packed: > > hw/vfio/ccw.c: In function ‘vfio_ccw_io_notifier_handler’: > hw/vfio/ccw.c:133:15: war

Re: [Qemu-devel] [PATCH 11/14] hw/vfio/ccw: avoid taking address members in packed structs

2019-04-02 Thread Thomas Huth
On 02/04/2019 18.00, Cornelia Huck wrote: > On Fri, 29 Mar 2019 11:11:01 + > Daniel P. Berrangé wrote: > >> The GCC 9 compiler complains about many places in s390 code >> that take the address of members of the 'struct SCHIB' which >> is marked packed: >> >> hw/vfio/ccw.c: In function ‘vfio_c

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-02 Thread Auger Eric
Laszlo, On 4/2/19 5:52 PM, Laszlo Ersek wrote: > On 04/02/19 17:42, Auger Eric wrote: >> Hi Laszlo, >> >> On 4/2/19 12:33 PM, Laszlo Ersek wrote: >>> On 04/02/19 09:42, Igor Mammedov wrote: On Mon, 1 Apr 2019 15:07:05 +0200 Laszlo Ersek wrote: > On 03/29/19 14:56, Auger Eric wr

Re: [Qemu-devel] Block format 'raw' does not support the option 'share-rw'

2019-04-02 Thread Kevin Wolf
Am 28.03.2019 um 21:48 hat Michal Suchánek geschrieben: > On Thu, 28 Mar 2019 16:56:48 +0100 > Michal Suchánek wrote: > > > Hello, > > > > I tried to update my machine definitions to work with current qemu. > > > > Unfortunately, while qemu 2.11 supports disk sharing with raw images > > qemu 3.

Re: [Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup

2019-04-02 Thread Markus Armbruster
Wei Yang writes: > On Tue, Apr 02, 2019 at 03:28:48PM +0200, Markus Armbruster wrote: >>Wei Yang writes: >> >>> Now all the functions used to select machine is local and the call flow >>> looks like below: >>> >>> select_machine() >>> find_default_machine() >>> machine_parse(

Re: [Qemu-devel] [PATCH 11/14] hw/vfio/ccw: avoid taking address members in packed structs

2019-04-02 Thread Daniel P . Berrangé
On Tue, Apr 02, 2019 at 06:00:33PM +0200, Cornelia Huck wrote: > On Fri, 29 Mar 2019 11:11:01 + > Daniel P. Berrangé wrote: > > > The GCC 9 compiler complains about many places in s390 code > > that take the address of members of the 'struct SCHIB' which > > is marked packed: > > > > hw/vfio

Re: [Qemu-devel] [PATCH v2] vl.c: make current_machine as non-global variable

2019-04-02 Thread Markus Armbruster
Igor Mammedov writes: > On Tue, 2 Apr 2019 21:09:39 +0800 > Like Xu wrote: > >> On 2019/4/2 19:27, Markus Armbruster wrote: >> > Like Xu writes: >> > >> >> This patch makes the remaining dozen or so uses of the global >> >> current_machine outside vl.c use qdev_get_machine() instead, >> >> a

Re: [Qemu-devel] [PATCH 11/14] hw/vfio/ccw: avoid taking address members in packed structs

2019-04-02 Thread Cornelia Huck
On Tue, 2 Apr 2019 18:05:15 +0200 Thomas Huth wrote: > On 02/04/2019 18.00, Cornelia Huck wrote: > > On Fri, 29 Mar 2019 11:11:01 + > > Daniel P. Berrangé wrote: > > > >> The GCC 9 compiler complains about many places in s390 code > >> that take the address of members of the 'struct SCHIB

Re: [Qemu-devel] QEMU event loop optimizations

2019-04-02 Thread Kevin Wolf
Am 26.03.2019 um 15:11 hat Paolo Bonzini geschrieben: > - but actually (and a precursor to using IOCB_CMD_POLL) it should be > possible to have just one LinuxAioState per AioContext, and then > it can simply share the AioContext's EventNotifier. This removes > the need to do the event_notifier_tes

[Qemu-devel] [PATCH 0/3] acpi: More trace points

2019-04-02 Thread Markus Armbruster
I wrote these patches to help me debug an unplug failure. I expect them to be helpful for others, too. Markus Armbruster (3): acpi/piix4: Convert debug printf()s to trace events acpi/pcihp: Convert debug printf()s to trace events acpi/pcihp: Add a few more trace points related to unplug h

[Qemu-devel] [PATCH 1/3] acpi/piix4: Convert debug printf()s to trace events

2019-04-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/acpi/piix4.c | 14 +++--- hw/acpi/trace-events | 4 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 9c079d6834..546ba036ed 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -39,1

[Qemu-devel] [PATCH 2/3] acpi/pcihp: Convert debug printf()s to trace events

2019-04-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/acpi/pcihp.c | 25 - hw/acpi/trace-events | 9 + 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index 88e4ae1bcd..7729c5338b 100644 --- a/hw/acpi/pcihp.c +++ b/hw/acpi

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

2019-04-02 Thread Philippe Mathieu-Daudé
Hi Mateja, On 4/2/19 5:15 PM, Mateja Marjanovic wrote: > From: Mateja Marjanovic > > Optimize set of MSA instructions ILVEV, using directly > tcg registers and performing logic on them instead of > using helpers. Maybe you can still let this previous comment (if still valid): Performance mea

[Qemu-devel] [PATCH 3/3] acpi/pcihp: Add a few more trace points related to unplug

2019-04-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/acpi/pcihp.c | 7 +++ hw/acpi/trace-events | 3 +++ 2 files changed, 10 insertions(+) diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index 7729c5338b..613406d09b 100644 --- a/hw/acpi/pcihp.c +++ b/hw/acpi/pcihp.c @@ -152,6 +152,8 @@ static void ac

Re: [Qemu-devel] QEMU event loop optimizations

2019-04-02 Thread Paolo Bonzini
On 02/04/19 18:18, Kevin Wolf wrote: > Am 26.03.2019 um 15:11 hat Paolo Bonzini geschrieben: >> - but actually (and a precursor to using IOCB_CMD_POLL) it should be >> possible to have just one LinuxAioState per AioContext, and then >> it can simply share the AioContext's EventNotifier. This remov

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/97] Patch Round-up for stable 3.0.1, freeze on 2019-04-08

2019-04-02 Thread Cole Robinson
On 4/1/19 4:58 PM, Michael Roth wrote: > Hi everyone, > > > The following new patches are queued for QEMU stable v3.0.1: > > https://github.com/mdroth/qemu/commits/stable-3.0-staging > > The release

Re: [Qemu-devel] [PATCH v2] vl.c: make current_machine as non-global variable

2019-04-02 Thread Peter Maydell
On Tue, 2 Apr 2019 at 23:13, Markus Armbruster wrote: > > Igor Mammedov writes: > > maybe we can assert in qdev_get_machine() if machine hasn't been created > > yet? > > with this at least it will be hard to misuse function or catch invalid > > users. > > (but it still might miss some use cases

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

2019-04-02 Thread Aleksandar Markovic
> From: Philippe Mathieu-Daudé > Subject: Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize > ILVEV. MSA instructions > > Hi Mateja, > > On 4/2/19 5:15 PM, Mateja Marjanovic wrote: > > From: Mateja Marjanovic > > > > Optimize set of MSA instructions ILVEV, using directly > > tcg registers an

[Qemu-devel] [Bug 1815889]

2019-04-02 Thread Marek Olšák
(In reply to Michel Dänzer from comment #8) > Mesa doesn't really need explicit thread affinity at all. All it wants is > that certain sets of threads run on the same CPU module; it doesn't care > which particular CPU module that is. What's really needed is an API to > express this affinity between

Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-04-02 Thread Dr. David Alan Gilbert
* Catherine Ho (catherine.h...@gmail.com) wrote: > On Tue, 2 Apr 2019 at 20:37, Peter Xu wrote: > > > On Tue, Apr 02, 2019 at 05:06:15PM +0800, Catherine Ho wrote: > > > On Tue, 2 Apr 2019 at 15:58, Peter Xu wrote: > > > > > > > On Tue, Apr 02, 2019 at 03:47:16PM +0800, Catherine Ho wrote: > > >

[Qemu-devel] [Bug 1815889] Re: qemu-system-x86_64 crashed with signal 31 in __pthread_setaffinity_new()

2019-04-02 Thread Daniel Berrange
FYI the QEMU change merged in the following pull request changed to return an EPERM errno for the thread affinity syscalls: commit 12f067cc14b90aef60b2b7d03e1df74cc50a0459 Merge: 84bdc58c06 035121d23a Author: Peter Maydell Date: Thu Mar 28 12:04:52 2019 + Merge remote-tracking branch '

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

2019-04-02 Thread Philippe Mathieu-Daudé
On 4/2/19 7:07 PM, Aleksandar Markovic wrote: >> From: Philippe Mathieu-Daudé >> Subject: Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize >> ILVEV. MSA instructions >> >> Hi Mateja, >> >> On 4/2/19 5:15 PM, Mateja Marjanovic wrote: >>> From: Mateja Marjanovic >>> >>> Optimize set of MSA in

Re: [Qemu-devel] [PATCH] vmstate: check subsection_found is enough

2019-04-02 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > subsection_found is true implies vmdesc is not NULL. > > Signed-off-by: Wei Yang > --- > migration/vmstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/vmstate.c b/migration/vmstate.c > index e2bbb7b5f7.

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

2019-04-02 Thread Aleksandar Markovic
> +/* > + * [MSA] ILVEV.D wd, ws, wt > + * > + * Vector Interleave Even (Double data elements) > + * > + */ Double -> Doubleword

[Qemu-devel] [ANNOUNCE] QEMU 4.0.0-rc2 is now available

2019-04-02 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 4.0 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-4.0.0-rc2.tar.xz http://downl

Re: [Qemu-devel] [PATCH v3 4/8] Extend the command-line to provide memory latency and bandwidth information

2019-04-02 Thread Eduardo Habkost
On Wed, Feb 06, 2019 at 11:11:24AM +0100, Igor Mammedov wrote: > On Thu, 31 Jan 2019 15:16:54 +0800 > Tao Xu wrote: > > > From: Liu Jingqi > > > > Add -numa hmat-lb option to provide System Locality Latency and > > Bandwidth Information. These memory attributes help to build > > System Locality

Re: [Qemu-devel] [PATCH v2] vl.c: make current_machine as non-global variable

2019-04-02 Thread Eduardo Habkost
On Tue, Apr 02, 2019 at 11:23:42PM +0700, Peter Maydell wrote: > On Tue, 2 Apr 2019 at 23:13, Markus Armbruster wrote: > > > > Igor Mammedov writes: > > > maybe we can assert in qdev_get_machine() if machine hasn't been created > > > yet? > > > with this at least it will be hard to misuse functi

Re: [Qemu-devel] [PATCH v3 4/8] Extend the command-line to provide memory latency and bandwidth information

2019-04-02 Thread Eduardo Habkost
On Tue, Apr 02, 2019 at 11:46:37AM +0200, Igor Mammedov wrote: > On Tue, 2 Apr 2019 12:42:37 +0800 > Tao Xu wrote: > > > On 2/6/19 6:11 PM, Igor Mammedov wrote: > > > On Thu, 31 Jan 2019 15:16:54 +0800 > > > Tao Xu wrote: > > > > > >> From: Liu Jingqi > > >> > > >> Add -numa hmat-lb option t

Re: [Qemu-devel] [PATCH 0/3] acpi: More trace points

2019-04-02 Thread Philippe Mathieu-Daudé
On 4/2/19 6:18 PM, Markus Armbruster wrote: > I wrote these patches to help me debug an unplug failure. I expect > them to be helpful for others, too. Appreciated. FYI I have a WiP branch where I use existing tracepoints to check events order and timing (using Avocado). Series: Reviewed-by: Phi

<    1   2   3   >