On 01/04/2019 21:00, Max Reitz wrote:
> On 27.02.19 16:48, Andrey Shinkevich wrote:
>>
>>
>> On 27/02/2019 18:22, Max Reitz wrote:
>>> On 27.02.19 16:15, Andrey Shinkevich wrote:
On 27/02/2019 16:25, Max Reitz wrote:
> On 27.02.19 14:16, Denis Lunev wrote:
>> On 2/27/19 4:0
This reverts commit bd56d378842c238c8901536c06c20a4a51ee9761.
Turned out it isn't that simple as the device needs the pit object link.
So "-device isa-pcspk" isn't going wo work anyway. We are in freeze, so
just reverting the thing is the best way to handle this for now, trying
to come up with so
From: Peter Maydell
In usb_mask_to_str() we convert a mask of USB speeds into
a human-readable string (like "full+high") for use in
tracing and error messages. However the conversion code
doesn't do anything to the string buffer if the passed in
speedmask doesn't match any of the recognized speed
From: Volker Rümelin
Currently the default audio timer frequency is 1Hz instead of
a period of 1us. Also the audiodev timer-period property gets
converted like a frequency. Only handling of the legacy
QEMU_AUDIO_TIMER_PERIOD environment variable is correct because
it's actually a frequenc
The following changes since commit 230ce19814ecc6bff8edac3b5b86e7c82f422c6c:
Merge remote-tracking branch 'remotes/rth/tags/pull-axp-20190325' into
staging (2019-03-29 19:29:00 +)
are available in the Git repository at:
git://git.kraxel.org/qemu tags/fixes-20190402-pull-re
On Tue, Apr 02, 2019 at 06:44:13 +, Zhangbo (Oscar) wrote:
> >[...]
> >
> >> >>This does not play well with the fact that processes as the PR helper
> >> >>are always required.
> >> >>
> >> >>Merging them into libvirtd would make the VM stop until libvirtd is
> >> >>running again. Additionally
On Tue, 2 Apr 2019 16:40:26 +1100
David Gibson wrote:
> This function has an explicit test for accesses above the device's config
> size, in which case it returns ~0x0. But pci_host_config_read_common()
> which it is about to call already has checks against the config space
> limit and likewise
Richard Henderson writes:
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> include/exec/cpu-defs.h | 17 -
> accel/tcg/cputlb.c | 24
> 2 files changed, 16 insertions(+), 25 deletions(-)
>
> diff --git a/include/exec/cpu-defs
From: Bandan Das
This function is used in the delete path only and can
be replaced by a call to usb_mtp_object_free.
Reviewed-by: Peter Maydell
Signed-off-by: Bandan Das
Message-Id: <20190401211712.19012-3-...@redhat.com>
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-mtp.c | 14 ++
On Mon, 1 Apr 2019 16:24:40 +
Shameerali Kolothum Thodi wrote:
> > -Original Message-
> > From: Igor Mammedov [mailto:imamm...@redhat.com]
> > Sent: 01 April 2019 14:34
> > To: Shameerali Kolothum Thodi
> > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org;
> > eric.au...@redhat.com; pe
On some systems wchar_t is "long int", on others just "int".
So go cast to "long int" and adjust the printf format accordingly.
Reported-by: Mark Cave-Ayland
Signed-off-by: Gerd Hoffmann
---
ui/curses.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/curses.c b/ui/cur
From: Bandan Das
Spotted by Coverity: CID 1399414
mtp delete allows the return status of delete succeeded,
partial_delete or readonly - when none of the objects could be
deleted. Give more meaningful names to return values of the
delete function.
Some initiators recurse over the objects themsel
On 02/04/2019 07.55, Like Xu wrote:
> This patch makes the remaining dozen or so uses of the global
> current_machine outside vl.c use qdev_get_machine() instead,
> and then make current_machine local to vl.c instead of global.
>
> Signed-off-by: Like Xu
> ---
[...]
> --- a/vl.c
> +++ b/vl.c
> @@
On Mon, 1 Apr 2019 14:51:51 +
Shameerali Kolothum Thodi wrote:
> Hi Igor,
>
> > -Original Message-
> > From: Igor Mammedov [mailto:imamm...@redhat.com]
> > Sent: 01 April 2019 14:43
> > To: Auger Eric
> > Cc: Shameerali Kolothum Thodi ;
> > qemu-devel@nongnu.org; qemu-...@nongnu.org
Hi Peter,
I'm glad to hear these qemu general rules from you.
Here you raised two options:
1. Using a tool like libvirt to add a pluggable network card
2. Specify the network card on the command line
For the option2, I think specify the network model in command line is not
enough, per my
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Tuesday, April 2, 2019 2:20 PM
> To: Zhang, Chen
> Cc: Zhang Chen ; Dr. David Alan Gilbert
> ; Juan Quintela ; zhanghailiang
> ; Eric Blake ; qemu-
> dev ; Zhang, Chen
> Subject: Re: [Qemu-devel] [PATCH] q
On Tue, Apr 02, 2019 at 04:19:25AM +, Alex Bennée wrote:
>
> Stefano Garzarella writes:
>
> > Hi Alex,
> > I'm sending you some benchmarks and information about VSOCK CCing qemu-devel
> > and linux-netdev (maybe this info could be useful for others :))
> >
> > One of the VSOCK advantages is
On Tue, 2 Apr 2019 at 14:24, Tommy Jin wrote:
> For the option2, I think specify the network model in command line is
> not enough, per my understanding, we still need to create the device
> using API like pci_create && qdev_set_nic_properties && qdev_init_nofail,
> otherwise we'll get error promp
On Tue, 2 Apr 2019 at 14:47, Catherine Ho wrote:
>
> Here is my step:
> 1. start guest normal by qemu with shared memory-backend file
> 2. stop the vm. save the device state to another file via monitor migrate
> "exec: cat>..."
> 3. quit the vm
> 4. retore the vm by qemu -incoming "exec:cat ..."
On Mon, 1 Apr 2019 15:07:05 +0200
Laszlo Ersek wrote:
> On 03/29/19 14:56, Auger Eric wrote:
> > Hi Ard,
> >
> > On 3/29/19 2:14 PM, Ard Biesheuvel wrote:
> >> On Fri, 29 Mar 2019 at 14:12, Auger Eric wrote:
> >>>
> >>> Hi Shameer,
> >>>
> >>> On 3/29/19 10:59 AM, Shameerali Kolothum Thodi
On Tue, Apr 02, 2019 at 03:47:16PM +0800, Catherine Ho wrote:
> Hi Peter Maydell
>
> On Tue, 2 Apr 2019 at 11:05, Peter Maydell wrote:
>
> > On Tue, 2 Apr 2019 at 09:57, Catherine Ho
> > wrote:
> > > The root cause is the used idx is moved forward after 1st time incoming,
> > and in 2nd time in
On Tue, 2 Apr 2019 at 15:47, Catherine Ho wrote:
> Hi Peter Maydell
>
> On Tue, 2 Apr 2019 at 11:05, Peter Maydell
> wrote:
>
>> On Tue, 2 Apr 2019 at 09:57, Catherine Ho
>> wrote:
>> > The root cause is the used idx is moved forward after 1st time
>> incoming, and in 2nd time incoming,
>> > th
It was found that Hyper-V 2016 on KVM in some configurations (q35 machine +
piix4-usb-uhci) hangs on boot. Root-cause was that one of Hyper-V
level-triggered interrupt handler performs EOI before fixing the cause of
the interrupt. This results in IOAPIC keep re-raising the level-triggered
interrupt
Hi Peter Maydell
On Tue, 2 Apr 2019 at 11:05, Peter Maydell wrote:
> On Tue, 2 Apr 2019 at 09:57, Catherine Ho
> wrote:
> > The root cause is the used idx is moved forward after 1st time incoming,
> and in 2nd time incoming,
> > the last_avail_idx will be incorrectly restored from the saved dev
On 01/04/19 16:12, Laurent Vivier wrote:
> This cleanup removes hardware objects from the list of files to be
> built for linux-user only targets.
>
> It also builds traces files only when the related file is built.
>
> Tested with all combinations of --{disable,enable}-{system,user,tools}
>
> v
Am 01.04.2019 um 22:02 hat Markus Armbruster geschrieben:
> Markus Armbruster writes:
>
> > Let's review our options for 4.0.
> >
> > Please note my analysis is handicapped by incomplete information, in
> > particular on libvirt's needs.
> >
> > Terminology:
> >
> > * "Hard read-write" semantics:
> On 2 Apr 2019, at 11:02, Vitaly Kuznetsov wrote:
>
> It was found that Hyper-V 2016 on KVM in some configurations (q35 machine +
> piix4-usb-uhci) hangs on boot. Root-cause was that one of Hyper-V
> level-triggered interrupt handler performs EOI before fixing the cause of
> the interrupt. Th
On Fri, 29 Mar 2019 at 20:56, Auger Eric wrote:
> This series:
> - [PATCH v3 00/10] ARM virt: ACPI memory hotplug support,
> https://patchwork.kernel.org/cover/10863301/
>
> aims to introduce PCDIMM support in qemu. In ACPI mode, it builds the
> SRAT and DSDT parts and relies on GED to trigger the
On 13.03.2019 19:04, Kevin Wolf wrote:
> Am 14.12.2018 um 12:54 hat Denis Plotnikov geschrieben:
>> On 13.12.2018 15:20, Kevin Wolf wrote:
>>> Am 13.12.2018 um 12:07 hat Denis Plotnikov geschrieben:
Sounds it should be so, but it doesn't work that way and that's why:
when doing mirror w
ilable in the Git repository at:
>
> git://git.kraxel.org/qemu tags/fixes-20190402-pull-request
>
> for you to fetch changes up to be1092afa07794e5247eb504095fb5f2ae421ec6:
>
> audio: fix audio timer rate conversion bug (2019-04-02 07:50:49 +0200)
>
> -
"Zhang, Chen" writes:
>> -Original Message-
>> From: Markus Armbruster [mailto:arm...@redhat.com]
>> Sent: Tuesday, April 2, 2019 2:20 PM
>> To: Zhang, Chen
>> Cc: Zhang Chen ; Dr. David Alan Gilbert
>> ; Juan Quintela ; zhanghailiang
>> ; Eric Blake ; qemu-
>> dev ; Zhang, Chen
>> Subj
On Tue, Apr 02, 2019 at 10:19:29 +0200, Kevin Wolf wrote:
> Am 01.04.2019 um 22:02 hat Markus Armbruster geschrieben:
> > Markus Armbruster writes:
[...]
> > Given that the libvirt code isn't ready, why do we need this done and
> > declared stable in 4.0? We're going to tag -rc2 tomorrow...
>
This patch makes the remaining dozen or so uses of the global
current_machine outside vl.c use qdev_get_machine() instead,
and then make current_machine local to vl.c instead of global.
Signed-off-by: Like Xu
---
Changes in v2:
- make the variable current_machine "static" (Thomas Huth)
---
On 01/04/2019 18:44, Alberto Garcia wrote:
> On Fri 29 Mar 2019 05:15:43 PM CET, Vladimir Sementsov-Ogievskiy wrote:
@@ -3237,7 +3238,14 @@ void qmp_block_stream(bool has_job_id, const char
*job_id, const char *device,
job_flags |= JOB_MANUAL_DISMISS;
}
Am 01.04.2019 um 18:22 hat Markus Armbruster geschrieben:
> Peter Krempa writes:
> > On Mon, Apr 01, 2019 at 16:55:50 +0200, Markus Armbruster wrote:
> >> Peter Krempa writes:
> >> > That works with -drive as qemu reopens the files internally, but does
> >> > not work when using -blockdev.
> >>
On 02/04/19 10:23, Liran Alon wrote:
>> +#define SUCCESSIVE_IRQ_MAX_COUNT 1
>> +
>> +static void ioapic_timer(void *opaque)
> I suggest rename method to something such as
> “delayed_ioapic_service_timer_handler()”.
>
I renamed them to delayed_ioapic_service_{timer,cb} and queued the patch.
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Tuesday, April 2, 2019 4:37 PM
> To: Zhang, Chen
> Cc: Markus Armbruster ; zhanghailiang
> ; Juan Quintela ;
> qemu-dev ; Dr. David Alan Gilbert
> ; Zhang Chen
> Subject: Re: [Qemu-devel] [PATCH] qapi/mig
Hi Laszlo,
Thanks much for your detailed explanation. It has been very helpful.
> In order for the guest kernel to expose ACPI S3 suspend to a privileged
> guest user, the guest kernel first checks if the platform (hardware and
> firmware) support ACPI S3. This in turn depends on whether the DSDT
If in a hurry, skip ahead to "bottom line".
Kevin Wolf writes:
> Am 01.04.2019 um 22:02 hat Markus Armbruster geschrieben:
>> Markus Armbruster writes:
>>
>> > Let's review our options for 4.0.
>> >
>> > Please note my analysis is handicapped by incomplete information, in
>> > particular on li
From: Zhang Chen
Address Markus's comments change the 'last_mode' to 'last-mode'.
Signed-off-by: Zhang Chen
---
qapi/migration.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index cfde29acf8..9217886c80 100644
--- a/qapi/m
02.04.2019 11:51, Andrey Shinkevich wrote:
>
>
> On 01/04/2019 18:44, Alberto Garcia wrote:
>> On Fri 29 Mar 2019 05:15:43 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> @@ -3237,7 +3238,14 @@ void qmp_block_stream(bool has_job_id, const char
> *job_id, const char *device,
>
> On 2 Apr 2019, at 12:06, Paolo Bonzini wrote:
>
> On 02/04/19 10:23, Liran Alon wrote:
>>> +#define SUCCESSIVE_IRQ_MAX_COUNT 1
>>> +
>>> +static void ioapic_timer(void *opaque)
>> I suggest rename method to something such as
>> “delayed_ioapic_service_timer_handler()”.
>>
>
> I rename
On Tue, 2 Apr 2019 at 15:58, Peter Xu wrote:
> On Tue, Apr 02, 2019 at 03:47:16PM +0800, Catherine Ho wrote:
> > Hi Peter Maydell
> >
> > On Tue, 2 Apr 2019 at 11:05, Peter Maydell
> wrote:
> >
> > > On Tue, 2 Apr 2019 at 09:57, Catherine Ho
> > > wrote:
> > > > The root cause is the used idx i
Hi Ernest,
On 4/1/19 8:16 PM, Ernest Esene wrote:
> Set category and description for iommu devices.
>
> Signed-off-by: Ernest Esene
Reviewed-by: Eric Auger
Thanks
Eric
>
> ---
> v3:
> * set category and describe smmuv3 as suggested by Eric
> v2:
> * split into separate patches
> ---
>
On 1.4.19. 19:53, Aleksandar Markovic wrote:
From: Mateja Marjanovic
Subject: [PATCH v3 0/5] Add support for MSA instructions on a big endian host
"Add" -> "Fix"
Big endian host support should have worked from the moment MSA
support is added to QEMU.
I will change it in v4.
From: Mateja
On Tue, 2 Apr 2019 12:42:37 +0800
Tao Xu wrote:
> On 2/6/19 6:11 PM, Igor Mammedov wrote:
> > On Thu, 31 Jan 2019 15:16:54 +0800
> > Tao Xu wrote:
> >
> >> From: Liu Jingqi
> >>
> >> Add -numa hmat-lb option to provide System Locality Latency and
> >> Bandwidth Information. These memory attr
On 1.4.19. 19:30, Aleksandar Markovic wrote:
From: Mateja Marjanovic
Subject: [PATCH 2/2] target/mips: MOD_. MSA insturctions fixed
From: Mateja Marjanovic
In case of dividing integers by zero, the result is unpredictable [1],
but according to the hardware, the result is not zero, but the d
Am 27.03.2019 um 10:23 hat Thomas Huth geschrieben:
> iotest 235 currently only works with KVM - this is bad for systems where
> it is not available, e.g. CI pipelines. The test also works when using
> "tcg" as accelerator, so we can simply add that to the list of accelerators,
> too.
>
> Signed-o
On 1.4.19. 19:43, Aleksandar Markovic wrote:
From: Mateja Marjanovic
Subject: [PATCH 0/2] target/mips: Integer division by zero in MSA insturctions
The title look incomplete and uninformative: it mentions "the division by zero"
- but what is done in this case? Is this an implementation of th
On 1.4.19. 19:28, Aleksandar Markovic wrote:
From: Mateja Marjanovic
Subject: [PATCH 1/2] target/mips: DIV_. MSA insturctions fixed
"insturctions" -> "instructions". Try to find a spell checking tool that will
help
you avoid such cases in the future, especially since you tend to make the
sam
On Mon, 1 Apr 2019 19:11:50 +0100
Ernest Esene wrote:
> Set category and describe DIMM devices
>
> Signed-off-by: Ernest Esene
Reviewed-by: Igor Mammedov
>
> ---
> v3:
> * add MEMORY device category
> * set category to MEMORY
> v2:
> * split into separate patches
> ---
> hw/mem/nvdim
On 02/04/19 11:08, Liran Alon wrote:
>> -
>> -if (((entry >> IOAPIC_LVT_TRIGGER_MODE_SHIFT) & 1) !=
>> -IOAPIC_TRIGGER_LEVEL) {
>> +if (!(entry & IOAPIC_LVT_REMOTE_IRR)) {
>> continue;
>> }
> I think above “if” of checking remote-i
On Mon, 1 Apr 2019 12:01:48 -0300
"Maxiwell S. Garcia" wrote:
> Hi Greg,
>
> Thanks for your review. I added some comments below...
>
> On Fri, Mar 29, 2019 at 01:29:51PM +0100, Greg Kurz wrote:
> > On Thu, 28 Mar 2019 15:39:45 -0300
> > "Maxiwell S. Garcia" wrote:
> >
> > > Hi,
> > >
> >
On Tue, Apr 02, 2019 at 09:10:55AM +0200, Greg Kurz wrote:
> On Tue, 2 Apr 2019 16:40:26 +1100
> David Gibson wrote:
>
> > This function has an explicit test for accesses above the device's config
> > size, in which case it returns ~0x0. But pci_host_config_read_common()
> > which it is about t
On 04/02/19 09:42, Igor Mammedov wrote:
> On Mon, 1 Apr 2019 15:07:05 +0200
> Laszlo Ersek wrote:
>
>> On 03/29/19 14:56, Auger Eric wrote:
>>> Hi Ard,
>>>
>>> On 3/29/19 2:14 PM, Ard Biesheuvel wrote:
On Fri, 29 Mar 2019 at 14:12, Auger Eric wrote:
>
> Hi Shameer,
>
> O
On Mon, 1 Apr 2019 11:08:23 +0200
Markus Armbruster wrote:
> This reverts commit e60483f2f8498ae08ae79ca4c6fb03a3317f5e1e.
>
> Recent commit cda4aa9a5a0 moved block backend creation before machine
> property evaluation.
Side note:
I've also looked at
"[PATCH v3 11/12] pc: Support firmware con
On 1.4.19. 19:56, Aleksandar Markovic wrote:
From: Mateja Marjanovic
Subject: [PATCH v3 1/5] target/mips: MSA instructions ld, big endian host fix
Start the title with the imperative, such as "target/mips: Fix..."
Use full instruction names, as explained in previous reviews.
I will do that
On Mon, 1 Apr 2019 11:08:26 +0200
Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
Reviewed-by: Igor Mammedov
> ---
> vl.c | 24 ++--
> 1 file changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index e4d7ad6b85..8c6d06b01d 100644
> --- a
On Mon, 1 Apr 2019 11:08:25 +0200
Markus Armbruster wrote:
> migrate_add_blocker() asserts we have a current_migration object, in
> migrate_get_current(). We do only after migration_object_init().
>
> This contributes to the following dependency cycle:
>
> * configure_blockdev() must run befo
On Mon, 1 Apr 2019 11:08:24 +0200
Markus Armbruster wrote:
> This reverts commit 3df663e575f1876d7f3bc684f80e72fca0703d39.
> This reverts commit b605c47b57b58e61a901a50a0762dccf43d94783.
>
> Command line option --only-migratable is for disallowing any
> configuration that can block migration.
>
On 1.4.19. 20:03, Aleksandar Markovic wrote:
From: Mateja Marjanovic
Subject: [PATCH v3 5/5] target/mips: Different approach toward INSERT MSA
instr. and big endian fix
"Different approach toward..." -> "Refactor and fix INSERT.
instructions"
Same goes for this, change in v4.
Thanks,
Mat
On 1.4.19. 20:01, Aleksandar Markovic wrote:
From: Mateja Marjanovic
Subject: [PATCH v3 3/5] target/mips: Different approach toward COPY_S MSA
instr. and big endian fix
"Different approach toward..." -> "Refactor and fix COPY_S.
instructions"
I will change that in v4.
From: Mateja Marj
On 1.4.19. 19:58, Aleksandar Markovic wrote:
From: Mateja Marjanovic
Subject: [PATCH v3 2/5] target/mips: MSA instructions st, big endian host fix
From: Mateja Marjanovic
Fix the case when the host is running on a big endian machine,
and change the approach toward st instruction helpers.
S
On 1.4.19. 20:02, Aleksandar Markovic wrote:
From: Mateja Marjanovic
Subject: [PATCH v3 4/5] target/mips: Different approach toward COPY_U MSA
instr. and big endian fix
From: Mateja Marjanovic
"Different approach toward..." -> "Refactor and fix COPY_U. instructions"
Same goes for this, c
Hi
On Fri, Mar 22, 2019 at 3:30 PM Daniel P. Berrangé wrote:
>
> Watch IDs are allocated from incrementing a int counter against
> the QFileMonitor object. In very long life QEMU processes with
> a huge amount of USB MTP activity creating & deleting directories
> it is just about conceivable that
Like Xu writes:
> This patch makes the remaining dozen or so uses of the global
> current_machine outside vl.c use qdev_get_machine() instead,
> and then make current_machine local to vl.c instead of global.
>
> Signed-off-by: Like Xu
You effectively replace
current_machine
by
MACHIN
Zhang Chen writes:
> From: Zhang Chen
>
> Address Markus's comments change the 'last_mode' to 'last-mode'.
>
> Signed-off-by: Zhang Chen
> ---
> qapi/migration.json | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index cf
> On 2 Apr 2019, at 13:20, Paolo Bonzini wrote:
>
> On 02/04/19 11:08, Liran Alon wrote:
>>> -
>>> -if (((entry >> IOAPIC_LVT_TRIGGER_MODE_SHIFT) & 1) !=
>>> -IOAPIC_TRIGGER_LEVEL) {
>>> +if (!(entry & IOAPIC_LVT_REMOTE_IRR)) {
>>>continu
Igor Mammedov writes:
> On Mon, 1 Apr 2019 11:08:23 +0200
> Markus Armbruster wrote:
>
>> This reverts commit e60483f2f8498ae08ae79ca4c6fb03a3317f5e1e.
>>
>> Recent commit cda4aa9a5a0 moved block backend creation before machine
>> property evaluation.
>
> Side note:
> I've also looked at
> "[
Igor Mammedov writes:
> On Mon, 1 Apr 2019 11:08:24 +0200
> Markus Armbruster wrote:
>
>> This reverts commit 3df663e575f1876d7f3bc684f80e72fca0703d39.
>> This reverts commit b605c47b57b58e61a901a50a0762dccf43d94783.
>>
>> Command line option --only-migratable is for disallowing any
>> configu
From: Mateja Marjanovic
The behaviour when executing DIV_. and MOD_.
differs on a referent hardware (FPGA MIPS 64 r6, little endian) and on
QEMU, when the divisor is equal to zero. That is not a real bug, because
the behaviour in that case is unpredictable (references in commit
messages).
v2:
-
* Markus Armbruster (arm...@redhat.com) wrote:
> Igor Mammedov writes:
>
> > On Mon, 1 Apr 2019 11:08:24 +0200
> > Markus Armbruster wrote:
> >
> >> This reverts commit 3df663e575f1876d7f3bc684f80e72fca0703d39.
> >> This reverts commit b605c47b57b58e61a901a50a0762dccf43d94783.
> >>
> >> Comman
From: Mateja Marjanovic
MSA instructions DIV_. when dividing by zero,
didn't return the same value when executed on a referent hardware
(FPGA MIPS 64 r6, little endian) and when executed on QEMU, which
is not a real bug, because the result when dividing by zero is
UNPREDICTABLE [1] (page 141, 142
From: Mateja Marjanovic
MSA instructions MOD_. when dividing by zero,
didn't return the same value when executed on a referent hardware
(FPGA MIPS 64 r6, little endian) and when executed on QEMU, which
is not a real bug, because the result when dividing by zero is
UNPREDICTABLE [1] (page 255, 256
* Markus Armbruster (arm...@redhat.com) wrote:
> Signed-off-by: Markus Armbruster
> ---
> vl.c | 24 ++--
> 1 file changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index e4d7ad6b85..8c6d06b01d 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4285,16 +4285,36 @@
The polling mode in aio_poll is able to trim down ~20us on the average
request latency, but it needs manual fine tuning to adjust it to the
characteristics of the storage.
Here we add a new knob to the IOThread object, "poll-inflight". When
this knob is enabled, aio_poll will always use polling if
On Tue, Apr 02, 2019 at 05:06:15PM +0800, Catherine Ho wrote:
> On Tue, 2 Apr 2019 at 15:58, Peter Xu wrote:
>
> > On Tue, Apr 02, 2019 at 03:47:16PM +0800, Catherine Ho wrote:
> > > Hi Peter Maydell
> > >
> > > On Tue, 2 Apr 2019 at 11:05, Peter Maydell
> > wrote:
> > >
> > > > On Tue, 2 Apr 20
On Mon 01 Apr 2019 02:06:04 PM CEST, Andrey Shinkevich wrote:
> From: Vladimir Sementsov-Ogievskiy
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> Signed-off-by: Andrey Shinkevich
> ---
You can also say in the log message that the goto is not necessary since
the common exit code was removed i
The following changes since commit d61d1a1fb2f1db6c54651844a28389c523f3f8c7:
Merge remote-tracking branch
'remotes/kraxel/tags/fixes-20190402-pull-request' into staging (2019-04-02
08:18:24 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/fo
From: Alberto Garcia
Commit 6585493369819a48d34a86d57ec6b97cb5cd9bc0 added code to freeze
the backing chain from 'top' to 'base' for the duration of the
block-stream job.
The problem is that the freezing happens too late in stream_start():
during the bdrv_reopen_set_read_only() call earlier in t
From: Vladimir Sementsov-Ogievskiy
bdrv_replace_child() calls bdrv_check_perm() with error_abort on
loosening permissions. However file-locking operations may fail even
in this case, for example on NFS. And this leads to Qemu crash.
Let's avoid such errors. Note, that we ignore such things anywa
From: Nir Soffer
With Kevin's "block: Fix slow pre-zeroing in qemu-img convert"[1]
(commit c9fdcf202f, 'qemu-img: Use BDRV_REQ_NO_FALLBACK for
pre-zeroing') we skip the pre zero step called like this:
blk_make_zero(s->target, BDRV_REQ_MAY_UNMAP | BDRV_REQ_NO_FALLBACK)
And we write zeroes la
From: Alberto Garcia
All three functions that handle the BdrvChild.frozen attribute walk
the backing chain from 'bs' to 'base' and stop either when 'base' is
found or at the end of the chain if 'base' is NULL.
However if 'base' is not found then the functions return without
errors as if it was N
From: Thomas Huth
virtio-pci is optional on s390x, e.g. in downstream RHEL builds, it
is disabled. On s390x, virtio-ccw should be used instead. Other tests
like 051 or 240 already use virtio-scsi-ccw instead of virtio-scsi-pci
on s390x, so let's do the same here and always use virtio-scsi-ccw on
From: Alberto Garcia
The base node of a block-stream operation indicates the first image
from the backing chain starting from which no data is copied to the
top node.
The block-stream job allows others to use that base image, so a second
block-stream job could be writing to it at the same time.
---
hw/core/qdev-properties.c | 1 +
include/qemu-common.h | 11 ---
include/qemu/cutils.h | 12
qapi/qapi-util.c | 2 +-
util/id.c | 2 +-
5 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/hw/core/qdev-properties.c b/hw/core/
From: Thomas Huth
The file tests/qemu-iotests/COPYING is the same text as in the
COPYING file in the main directory. So as far as I can see, we don't
need the duplicate here.
Signed-off-by: Thomas Huth
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
tests/qemu-i
Qemu-hexdump declaration was moved from qemu-common.h to qemu/hexdump.h
Signed-off-by: Aruna Jayasena
---
hw/dma/pl330.c| 1 +
hw/dma/xlnx_dpdma.c | 1 +
include/qemu-common.h | 6 --
net/colo-compare.c| 2 +-
util/hexdump.c| 2 +-
util/iov.c| 2 +-
6 files
From: Stefano Garzarella
Several versions of GlusterFS (3.12? -> 6.0.1) fail when the
transfer size is greater or equal to 1024 MiB, so we are
limiting the transfer size to 512 MiB to avoid this rare issue.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1691320
Signed-off-by: Stefano Garza
Please Ignore this, Mistake
On Tue, 2 Apr 2019 at 18:21, Aruna Jayasena wrote:
> ---
> hw/core/qdev-properties.c | 1 +
> include/qemu-common.h | 11 ---
> include/qemu/cutils.h | 12
> qapi/qapi-util.c | 2 +-
> util/id.c | 2 +-
> 5 fil
From: Thomas Huth
iotest 235 currently only works with KVM - this is bad for systems where
it is not available, e.g. CI pipelines. The test also works when using
"tcg" as accelerator, so we can simply add that to the list of accelerators,
too.
Signed-off-by: Thomas Huth
Signed-off-by: Kevin Wol
This reverts commit 3df663e575f1876d7f3bc684f80e72fca0703d39.
This reverts commit b605c47b57b58e61a901a50a0762dccf43d94783.
Command line option --only-migratable is for disallowing any
configuration that can block migration.
Initially, --only-migratable set global variable @only_migratable.
Comm
This reverts commit e60483f2f8498ae08ae79ca4c6fb03a3317f5e1e.
Recent commit cda4aa9a5a0 moved block backend creation before machine
property evaluation. This broke block backends registering migration
blockers. Commit e60483f2f84 fixed it by moving migration object
creation before block backend
> From: Mateja Marjanovic
> Subject: [PATCH v2 2/2] target/mips: Make the results of MOD_.
> the same as on hardware
>
> From: Mateja Marjanovic
>
> MSA instructions MOD_. when dividing by zero,
> didn't return the same value when executed on a referent hardware
> (FPGA MIPS 64 r6, little endia
From: Zhang Chen
Signed-off-by: Zhang Chen
Message-Id: <20190326174510.13303-1-chen.zh...@intel.com>
Reviewed-by: Eric Blake
[Commit message tweaked as per Eric's review]
Signed-off-by: Markus Armbruster
---
qapi/migration.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Zhang Chen
Signed-off-by: Zhang Chen
Message-Id: <20190402085521.17973-1-chen.zh...@intel.com>
Reviewed-by: Markus Armbruster
[Commit message rephrased]
Signed-off-by: Markus Armbruster
---
qapi/migration.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qapi/
> From: Mateja Marjanovic
> Subject: [PATCH v2 1/2] target/mips: Make the results of DIV_.
> the same as on > hardware
>
> From: Mateja Marjanovic
>
> MSA instructions DIV_. when dividing by zero,
> didn't return the same value when executed on a referent hardware
> (FPGA MIPS 64 r6, little en
migrate_add_blocker() asserts we have a current_migration object, in
migrate_get_current(). We do only after migration_object_init().
This contributes to the following dependency cycle:
* configure_blockdev() must run before machine_set_property()
so machine properties can refer to block backe
Signed-off-by: Markus Armbruster
Message-Id: <20190401090827.20793-5-arm...@redhat.com>
Reviewed-by: Igor Mammedov
---
vl.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 0d517a09e1..c696ad2a13 100644
--- a/vl.c
+++ b/vl.c
@@ -4286
The following changes since commit d61d1a1fb2f1db6c54651844a28389c523f3f8c7:
Merge remote-tracking branch
'remotes/kraxel/tags/fixes-20190402-pull-request' into staging (2019-04-02
08:18:24 +0100)
are available in the Git repository at:
https://github.com/berrange/qemu tags/fi
1 - 100 of 258 matches
Mail list logo
