Re: [Qemu-devel] About making QEMU to LIBs!

2019-03-26 Thread Xiao Guangrong
On 3/26/19 7:18 AM, Paolo Bonzini wrote: On 25/03/19 12:46, Yang Zhong wrote: Hello all, Rust-VMM has started to make all features and common modules to crates, and CSP can deploy their VMM on demand. This afternoon, Xiao guangrong and i talked about the light weight VM solitions,and we th

Re: [Qemu-devel] [PATCH V2 RFT] vhost_net: don't set backend for the uninitialized virtqueue

2019-03-26 Thread Jason Wang
On 2019/3/25 下午8:32, Michael S. Tsirkin wrote: On Mon, Mar 25, 2019 at 11:56:13AM +0800, Jason Wang wrote: We used to set backend unconditionally, this won't work for some guests (e.g windows driver) who may not initialize all virtqueues. For kernel backend, this will fail since it may try to

[Qemu-devel] [PULL] target/riscv: Zero extend the inputs of divuw and remuw

2019-03-26 Thread Palmer Dabbelt
While running the GCC test suite against 4.0.0-rc0, Kito found a regression introduced by the decodetree conversion that caused divuw and remuw to sign-extend their inputs. The ISA manual says they are supposed to be zero extended: DIVW and DIVUW instructions are only valid for RV64, and divi

Re: [Qemu-devel] [PATCH] qapi/qmp-dispatch: fix return value in do_qmp_dispatch

2019-03-26 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > There are no harm but just looks weird to return bool in > pointer-returning function. Introduced in 69240fe62d1 with the whole > failure-checking "if" chunk. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/qmp-dispatch.c | 2 +- > 1 file chan

Re: [Qemu-devel] [PATCH] net/socket: learn to talk with a unix dgram socket

2019-03-26 Thread Jason Wang
On 2019/3/12 上午1:25, Marc-André Lureau wrote: -net socket has a fd argument, and may be passed pre-opened sockets. TCP sockets use framing. UDP sockets have datagram boundaries. When given a unix dgram socket, it will be able to read from it, but will attempt to send on the dgram_dst, which i

[Qemu-devel] [PULL] A Single RISC-V Patch for 4.0-rc1

2019-03-26 Thread Palmer Dabbelt
The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2: Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +) are available in the Git repository at: git://github.com/palmer-dabbelt/qemu.git tags/riscv-for-master-4.0-rc1 for you to fetch changes up to f17e02

Re: [Qemu-devel] [PATCH v7 6/6] migration: Block migration while handling machine check

2019-03-26 Thread Aravinda Prasad
On Tuesday 26 March 2019 09:49 AM, David Gibson wrote: > On Mon, Mar 25, 2019 at 02:31:10PM +0530, Aravinda Prasad wrote: >> >> >> On Monday 25 March 2019 12:03 PM, David Gibson wrote: >>> On Fri, Mar 22, 2019 at 12:04:25PM +0530, Aravinda Prasad wrote: Block VM migration requests until the

[Qemu-devel] [Bug 1821006] Re: qemu: Unsupported syscall: 382

2019-03-26 Thread Alexey Gavrilov
Yes, you are right the application works correctly. At least the result is expected. Vesion kernel le9i0nx@unit6:~$ uname -a Linux unit6 4.9.0-8-rt-amd64 #1 SMP PREEMPT RT Debian 4.9.144-3.1 (2019-02-19) x86_64 GNU/Linux Host debian 9 quest debian 10 quest glib version root@ddf2245902b3:/app# ap

Re: [Qemu-devel] [PATCH] e1000: Delay flush queue when receive RCTL

2019-03-26 Thread Jason Wang
On 2019/3/25 下午1:56, yuchenlin via Qemu-devel wrote: On 2019-03-25 12:26, Jason Wang wrote: On 2019/3/21 上午9:35, yuchenlin wrote: Ping? On 2019-03-13 14:56, yuchen...@synology.com wrote: From: yuchenlin Due to too early RCT0 interrput, win10x32 may hang on booting. This problem can be rep

Re: [Qemu-devel] [PULL 02/29] ppc/spapr: Receive and store device tree blob from SLOF

2019-03-26 Thread Greg Kurz
On Tue, 26 Mar 2019 10:47:15 +1100 David Gibson wrote: > On Mon, Mar 25, 2019 at 05:33:21PM +0100, Greg Kurz wrote: > > On Mon, 25 Mar 2019 11:53:47 +1100 > > David Gibson wrote: > > > > > On Sun, Mar 24, 2019 at 12:03:54AM -0400, Brad Smith wrote: > > > > Now that I am checking out 4.0.0 r

Re: [Qemu-devel] [PATCH v3 04/15] spapr/xive: add state synchronization with KVM

2019-03-26 Thread Cédric Le Goater
On 3/26/19 5:25 AM, David Gibson wrote: > On Fri, Mar 22, 2019 at 08:53:21AM +0100, Cédric Le Goater wrote: >> On 3/22/19 2:00 AM, David Gibson wrote: >>> On Thu, Mar 21, 2019 at 03:49:03PM +0100, Cédric Le Goater wrote: This extends the KVM XIVE device backend with 'synchronize_state' me

[Qemu-devel] [PULL 3/4] json: Fix off-by-one assert check in next_state()

2019-03-26 Thread Markus Armbruster
From: Liam Merwick The assert checking if the value of lexer->state in next_state(), which is used as an index to the 'json_lexer' array, incorrectly checks for an index value less than or equal to ARRAY_SIZE(json_lexer). Fix assert so that it just checks for an index less than the array size. S

[Qemu-devel] [PULL 4/4] qapi/qmp-dispatch: fix return value in do_qmp_dispatch

2019-03-26 Thread Markus Armbruster
From: Vladimir Sementsov-Ogievskiy There are no harm but just looks weird to return bool in pointer-returning function. Introduced in 69240fe62d1 with the whole failure-checking "if" chunk. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20190325154748.66381-1-vsement...@virtuozzo.com>

[Qemu-devel] [PULL 1/4] util/error: Remove an unnecessary NULL check

2019-03-26 Thread Markus Armbruster
From: Philippe Mathieu-Daudé This NULL check was required while introduced in 680d16dcb79f. Later refactor added a NULL check in error_setv(), so this check is now redundant. Reviewed-by: Daniel P. Berrangé Reviewed-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé Message-Id: <2019

[Qemu-devel] [PULL 2/4] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate

2019-03-26 Thread Markus Armbruster
Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/qobject.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir hw/block --in-place Signed-off-by: Markus Armbruster Message-Id: <20190313174433.12966-1-arm...@redhat.com> Reviewed-by: Er

[Qemu-devel] [PULL 0/4] Miscellaneous patches for 2019-03-26

2019-03-26 Thread Markus Armbruster
The following changes since commit d132baa05ed7a647067c807fd452ec794cc2ecb7: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2019-03-25 17:01:10 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-misc-2019-03-26

Re: [Qemu-devel] [PATCH 0/1] update copyright notice

2019-03-26 Thread IOMMU AUTHOR
On Wed, Mar 20, 2019 at 4:18 PM IOMMU AUTHOR wrote: > > > On Wed, Mar 20, 2019 at 12:16 AM IOMMU AUTHOR > wrote: > >> i'd rather the copyright notice on these files looks like i've put it >> below and since i just simply snipped my name(i'll provide legal proof >> that this is my name, if requir

Re: [Qemu-devel] [PATCH] Replace calls to object_child_foreach() with object_child_foreach_recursive()

2019-03-26 Thread Stefan Hajnoczi
On Sun, Mar 10, 2019 at 02:39:13AM +0100, Ernest Esene wrote: > Replace calls to object_child_foreach() with object_child_foreach_recursive() > when applicable: nvdimm_device_list, nmi_monitor_handle, find_sysbus_device, > pc_dimm_slot2bitmap, build_dimm_list. Ernest or Paolo: What is the rational

[Qemu-devel] [Bug 1821006] Re: qemu: Unsupported syscall: 382

2019-03-26 Thread Alexey Gavrilov
Upgrading the kernel did not change the situation. le9i0nx@unit6:~$ uname -a Linux unit6 4.19.0-0.bpo.2-rt-amd64 #1 SMP PREEMPT RT Debian 4.19.16-1~bpo9+1 (2019-02-07) x86_64 GNU/Linux ... Updating certificates in /etc/ssl/certs... qemu: Unsupported syscall: 382 0 added, 0 removed; done. Running

Re: [Qemu-devel] [Qemu-block] [PATCH] block/vhdx: Use IEC binary prefixes from "qemu/units.h"

2019-03-26 Thread Stefano Garzarella
On Mon, Mar 25, 2019 at 10:56:57PM +0100, Philippe Mathieu-Daudé wrote: > Le lun. 25 mars 2019 21:53, John Snow a écrit : > > On 3/21/19 5:40 AM, Stefano Garzarella wrote: > > > IEC binary prefixes are defined in "qemu/units.h", so we > > > can remove redundant definitions in "block/vhdx.h". > > >

Re: [Qemu-devel] [PATCH V2 0/4] fix usage of bool

2019-03-26 Thread Stefan Hajnoczi
On Sat, Mar 23, 2019 at 05:26:33PM +0300, Jafar Abdi wrote: > Clean up wrong usage of FALSE and TRUE in places that use "bool" from > stdbool.h. > > FALSE and TRUE (with capital letters) are the constants defined by glib for > being used with the "gboolean" type of glib. But some parts of the cod

Re: [Qemu-devel] [PATCH 0/8] Clean up #include "..." vs "<...>" and header guards

2019-03-26 Thread Stefan Hajnoczi
On Wed, Mar 20, 2019 at 02:54:22PM +, Daniel P. Berrangé wrote: > On Wed, Mar 20, 2019 at 01:52:26PM +, Stefan Hajnoczi wrote: > > On Fri, Mar 15, 2019 at 03:51:15PM +0100, Markus Armbruster wrote: > > > * Our use of header guards is rather sloppy. Sloppiness there can > > > lead to conf

Re: [Qemu-devel] [PATCH 1/4] trace: only include trace-event-subdirs when they are needed

2019-03-26 Thread Stefan Hajnoczi
On Thu, Mar 21, 2019 at 01:46:21PM +0100, Laurent Vivier wrote: > Some directories are built only for softmmu targets, > and the related trace-event-subdirs must do the same > > Signed-off-by: Laurent Vivier > --- > Makefile.objs | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH V2 0/4] fix usage of bool

2019-03-26 Thread Stefan Hajnoczi
On Sat, Mar 23, 2019 at 05:26:33PM +0300, Jafar Abdi wrote: > Clean up wrong usage of FALSE and TRUE in places that use "bool" from > stdbool.h. > > FALSE and TRUE (with capital letters) are the constants defined by glib for > being used with the "gboolean" type of glib. But some parts of the cod

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-03-26 Thread Stefan Hajnoczi
On Fri, Mar 08, 2019 at 09:50:36AM +, Stefan Hajnoczi wrote: > On Thu, Mar 07, 2019 at 03:29:41PM -0800, John G Johnson wrote: > > > On Mar 7, 2019, at 11:27 AM, Stefan Hajnoczi wrote: > > > On Thu, Mar 07, 2019 at 02:51:20PM +, Daniel P. Berrangé wrote: > > >> On Thu, Mar 07, 2019 at 02:2

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 4/6] target/ppc: Build rtas error log

2019-03-26 Thread Greg Kurz
On Tue, 26 Mar 2019 10:32:35 +1100 David Gibson wrote: > On Mon, Mar 25, 2019 at 01:56:50PM +0530, Aravinda Prasad wrote: > > > > > > On Monday 25 March 2019 12:00 PM, David Gibson wrote: > > > On Fri, Mar 22, 2019 at 12:04:07PM +0530, Aravinda Prasad wrote: > > >> This patch builds the rta

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-4.0?] exec: Only count mapped memory backends for qemu_getrampagesize()

2019-03-26 Thread Laurent Vivier
On 26/03/2019 04:50, David Gibson wrote: > qemu_getrampagesize() works out the minimum host page size backing any of > guest RAM. This is required in a few places, such as for POWER8 PAPR KVM > guests, because limitations of the hardware virtualization mean the guest > can't use pagesizes larger t

Re: [Qemu-devel] [PATCH 0/1] update copyright notice

2019-03-26 Thread Paolo Bonzini
On 26/03/19 08:14, IOMMU AUTHOR wrote: > got some clarification regarding this. > > i no longer wish to get this patch merged. Thanks very much for your understanding. Paolo

[Qemu-devel] [Bug 1821006] Re: qemu: Unsupported syscall: 382

2019-03-26 Thread Peter Maydell
Thanks for that repro case with qemu-debootstrap and chroot. I can confirm that I can repro this with QEMU version 2.11.1. However with current head of git QEMU this is fixed -- the "unsupported syscall" message is not printed. We added support for the renameat2 syscall in commit 95d0307cc10ca3df87

Re: [Qemu-devel] [PATCH 3/4] tools: edid-generate.c is part of the tools

2019-03-26 Thread Paolo Bonzini
On 21/03/19 13:46, Laurent Vivier wrote: > We don't need it for softmmu targets. > This is needed for next patch that will build > hw/ directory only for softmmu and not for tools. > > Signed-off-by: Laurent Vivier > --- > Makefile.objs | 5 + > 1 file changed, 5 insertions(+) > > diff --gi

Re: [Qemu-devel] [PATCH 2/4] ui: build keymap only with softmmu targets

2019-03-26 Thread Paolo Bonzini
On 21/03/19 13:46, Laurent Vivier wrote: > we don't need to generate the files for linux-user or for the tools > > Signed-off-by: Laurent Vivier > --- > Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Makefile b/Makefile > index d8dad39c5db1..609fac844637 100644 > --- a/Make

Re: [Qemu-devel] [PATCH 4/4] build: don't build hardware objects with linux-user

2019-03-26 Thread Paolo Bonzini
On 21/03/19 13:46, Laurent Vivier wrote: > + > +ifneq ($(CONFIG_USER_ONLY),y) > ### > # authz-obj-y is code used by both qemu system emulation and qemu-img > > @@ -21,21 +27,11 @@ block-obj-$(CONFIG_REPLICATION) += replication.

Re: [Qemu-devel] [PATCH 3/4] tools: edid-generate.c is part of the tools

2019-03-26 Thread Laurent Vivier
On 26/03/2019 09:42, Paolo Bonzini wrote: > On 21/03/19 13:46, Laurent Vivier wrote: >> We don't need it for softmmu targets. >> This is needed for next patch that will build >> hw/ directory only for softmmu and not for tools. >> >> Signed-off-by: Laurent Vivier >> --- >> Makefile.objs | 5 +

Re: [Qemu-devel] [PULL 00/15] Migration patches

2019-03-26 Thread Peter Maydell
On Mon, 25 Mar 2019 at 18:14, Juan Quintela wrote: > > The following changes since commit 50ccc488b0d4c3b8e2790c18bcd7329fc609a1c6: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190325' into staging (2019-03-25 > 15:58:49 +) > > are available in the Git reposi

Re: [Qemu-devel] [PATCH 0/4] build: cleanup in Makefile.objs

2019-03-26 Thread Paolo Bonzini
On 21/03/19 13:46, Laurent Vivier wrote: > This cleanup removes hardware objects from the list of files to be > built for linux-user only targets. > > It also builds traces files only when the related file is built. > > Tested with: > >configure --enable-user --disable-system >configure

Re: [Qemu-devel] [PATCH] SiFive RISC-V GPIO Device

2019-03-26 Thread Palmer Dabbelt
On Tue, 12 Feb 2019 09:38:39 PST (-0800), chout...@adacore.com wrote: QEMU model of the GPIO device on the SiFive E300 series SOCs. The pins are not used by a board definition yet, however this implementation can already be used to trigger GPIO interrupts from the software by configuring a pin a

[Qemu-devel] [PULL 2/2] pflash: Bury disabled code to limit device sizes

2019-03-26 Thread Markus Armbruster
From: Alex Bennée We disabled code to limit device sizes to 8, 16, 32 or 64MiB more than a decade ago in commit 95d1f3edd5e and c8b153d7949, v0.9.1. Bury. Signed-off-by: Alex Bennée Reviewed-by: Laszlo Ersek [Extracted from a larger patch, extended to pflash_cfi02.c] Signed-off-by: Markus Arm

[Qemu-devel] [PULL 1/2] pflash: Require backend size to match device, improve errors

2019-03-26 Thread Markus Armbruster
We reject undersized backends with a rather enigmatic "failed to read the initial flash content" error. For instance: $ qemu-system-ppc64 -S -display none -M sam460ex -drive if=pflash,format=raw,file=eins.img qemu-system-ppc64: Initialization of device cfi.pflash02 failed: failed to rea

Re: [Qemu-devel] [Qemu-block] [PATCH] thread-pool: Use an EventNotifier to coordinate with AioContext

2019-03-26 Thread Stefan Hajnoczi
On Mon, Mar 25, 2019 at 02:34:36PM +0100, Sergio Lopez wrote: > Our current ThreadPool implementation lacks support for AioContext's > event notifications. This not only means that it can't take advantage > from the IOThread's adaptive polling, but also that the latter works > against it, as it del

Re: [Qemu-devel] [PATCH 2/4] ui: build keymap only with softmmu targets

2019-03-26 Thread Laurent Vivier
On 26/03/2019 09:44, Paolo Bonzini wrote: > On 21/03/19 13:46, Laurent Vivier wrote: >> we don't need to generate the files for linux-user or for the tools >> >> Signed-off-by: Laurent Vivier >> --- >> Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Makefile b/Makefile >> i

Re: [Qemu-devel] About making QEMU to LIBs!

2019-03-26 Thread Paolo Bonzini
On 26/03/19 08:00, Xiao Guangrong wrote: > On 3/26/19 7:18 AM, Paolo Bonzini wrote: >> Also, what is the use case?  Is it to reduce the attack surface without >> having multiple QEMU binaries? > > Security is one story we concern, only the essential and audited > modules/libraries can be loaded in

[Qemu-devel] [PULL 0/2] Pflash and firmware configuration patches for 2019-03-26

2019-03-26 Thread Markus Armbruster
The following changes since commit d132baa05ed7a647067c807fd452ec794cc2ecb7: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2019-03-25 17:01:10 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-pflash-2019-03-2

Re: [Qemu-devel] [PATCH] Replace calls to object_child_foreach() with object_child_foreach_recursive()

2019-03-26 Thread Paolo Bonzini
On 26/03/19 08:43, Stefan Hajnoczi wrote: > On Sun, Mar 10, 2019 at 02:39:13AM +0100, Ernest Esene wrote: >> Replace calls to object_child_foreach() with object_child_foreach_recursive() >> when applicable: nvdimm_device_list, nmi_monitor_handle, find_sysbus_device, >> pc_dimm_slot2bitmap, build_di

Re: [Qemu-devel] [PATCH 2/4] ui: build keymap only with softmmu targets

2019-03-26 Thread Paolo Bonzini
On 26/03/19 10:04, Laurent Vivier wrote: > On 26/03/2019 09:44, Paolo Bonzini wrote: >> On 21/03/19 13:46, Laurent Vivier wrote: >>> we don't need to generate the files for linux-user or for the tools >>> >>> Signed-off-by: Laurent Vivier >>> --- >>> Makefile | 2 ++ >>> 1 file changed, 2 inserti

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 4/6] target/ppc: Build rtas error log

2019-03-26 Thread Aravinda Prasad
On Tuesday 26 March 2019 02:00 PM, Greg Kurz wrote: > On Tue, 26 Mar 2019 10:32:35 +1100 > David Gibson wrote: > >> On Mon, Mar 25, 2019 at 01:56:50PM +0530, Aravinda Prasad wrote: >>> >>> >>> On Monday 25 March 2019 12:00 PM, David Gibson wrote: On Fri, Mar 22, 2019 at 12:04:07PM +0530

Re: [Qemu-devel] About making QEMU to LIBs!

2019-03-26 Thread Stefan Hajnoczi
On Tue, Mar 26, 2019 at 03:00:05PM +0800, Xiao Guangrong wrote: > On 3/26/19 7:18 AM, Paolo Bonzini wrote: > > On 25/03/19 12:46, Yang Zhong wrote: > > > Hello all, > > > > > > Rust-VMM has started to make all features and common modules to crates, > > > and CSP can > > > deploy their VMM on dema

Re: [Qemu-devel] [Qemu-block] [PATCH] block/vhdx: Use IEC binary prefixes from "qemu/units.h"

2019-03-26 Thread Kevin Wolf
Am 26.03.2019 um 08:55 hat Stefano Garzarella geschrieben: > On Mon, Mar 25, 2019 at 10:56:57PM +0100, Philippe Mathieu-Daudé wrote: > > Le lun. 25 mars 2019 21:53, John Snow a écrit : > > > On 3/21/19 5:40 AM, Stefano Garzarella wrote: > > > > IEC binary prefixes are defined in "qemu/units.h", so

Re: [Qemu-devel] About making QEMU to LIBs!

2019-03-26 Thread Xiao Guangrong
On 3/26/19 5:07 PM, Paolo Bonzini wrote: On 26/03/19 08:00, Xiao Guangrong wrote: On 3/26/19 7:18 AM, Paolo Bonzini wrote: Also, what is the use case?  Is it to reduce the attack surface without having multiple QEMU binaries? Security is one story we concern, only the essential and audited

Re: [Qemu-devel] [PULL] A Single RISC-V Patch for 4.0-rc1

2019-03-26 Thread Peter Maydell
On Tue, 26 Mar 2019 at 06:54, Palmer Dabbelt wrote: > > The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2: > > Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +) > > are available in the Git repository at: > > git://github.com/palmer-dabbelt/qemu.git ta

Re: [Qemu-devel] [Qemu-block] [PATCH] block/vhdx: Use IEC binary prefixes from "qemu/units.h"

2019-03-26 Thread Philippe Mathieu-Daudé
Le mar. 26 mars 2019 10:14, Kevin Wolf a écrit : > Am 26.03.2019 um 08:55 hat Stefano Garzarella geschrieben: > > On Mon, Mar 25, 2019 at 10:56:57PM +0100, Philippe Mathieu-Daudé wrote: > > > Le lun. 25 mars 2019 21:53, John Snow a écrit : > > > > On 3/21/19 5:40 AM, Stefano Garzarella wrote: >

Re: [Qemu-devel] [PATCH 4/4] build: don't build hardware objects with linux-user

2019-03-26 Thread Laurent Vivier
On 26/03/2019 10:00, Paolo Bonzini wrote: > On 21/03/19 13:46, Laurent Vivier wrote: >> + >> +ifneq ($(CONFIG_USER_ONLY),y) >> ### >> # authz-obj-y is code used by both qemu system emulation and qemu-img >> >> @@ -21,21 +27,11

Re: [Qemu-devel] [Qemu-block] [PATCH] block/vhdx: Use IEC binary prefixes from "qemu/units.h"

2019-03-26 Thread Stefano Garzarella
On Tue, Mar 26, 2019 at 10:13:54AM +0100, Kevin Wolf wrote: > Am 26.03.2019 um 08:55 hat Stefano Garzarella geschrieben: > > On Mon, Mar 25, 2019 at 10:56:57PM +0100, Philippe Mathieu-Daudé wrote: > > > Le lun. 25 mars 2019 21:53, John Snow a écrit : > > > > On 3/21/19 5:40 AM, Stefano Garzarella

Re: [Qemu-devel] [PULL 0/4] Miscellaneous patches for 2019-03-26

2019-03-26 Thread Peter Maydell
On Tue, 26 Mar 2019 at 07:16, Markus Armbruster wrote: > > The following changes since commit d132baa05ed7a647067c807fd452ec794cc2ecb7: > > Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' > into staging (2019-03-25 17:01:10 +) > > are available in the Git repositor

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 4/6] target/ppc: Build rtas error log

2019-03-26 Thread Greg Kurz
On Tue, 26 Mar 2019 14:45:57 +0530 Aravinda Prasad wrote: > On Tuesday 26 March 2019 02:00 PM, Greg Kurz wrote: > > On Tue, 26 Mar 2019 10:32:35 +1100 > > David Gibson wrote: > > > >> On Mon, Mar 25, 2019 at 01:56:50PM +0530, Aravinda Prasad wrote: > >>> > >>> > >>> On Monday 25 March 2019

[Qemu-devel] [Bug 1821006] Re: qemu: Unsupported syscall: 382

2019-03-26 Thread Alexey Gavrilov
Unfortunately I was only able to check in 3.1. There is no problem with the call. root@unit6:/mnt/build/chroot# dpkg -l | grep qemu-user-static ii qemu-user-static 1:3.1+dfsg-5amd64QEMU user mode emulation b

Re: [Qemu-devel] [PATCH] target/arm: Set SIMDMISC and FPMISC for 32-bit -cpu max

2019-03-26 Thread Alex Bennée
Richard Henderson writes: > Fixes: https://bugs.launchpad.net/bugs/1821430 > Signed-off-by: Richard Henderson > --- > target/arm/cpu.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index 96f0ff0ec7..d9b8658921 100644 > --- a/target/arm/cpu

[Qemu-devel] [PATCH] target/ppc: Improve comment of bcctr used for spectre v2 mitigation

2019-03-26 Thread Greg Kurz
Signed-off-by: Greg Kurz --- target/ppc/translate.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 576210d901ad..badc1ae1a35d 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -3753,7 +3753,15

[Qemu-devel] [PULL] target/riscv: Fix wrong expanding for c.fswsp

2019-03-26 Thread Palmer Dabbelt
From: Kito Cheng base register is no rs1 not rs2 for fsw. Signed-off-by: Kito Cheng Reviewed-by: Palmer Dabbelt Signed-off-by: Palmer Dabbelt --- target/riscv/insn_trans/trans_rvc.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/insn_trans/trans_rvc.inc.

[Qemu-devel] [PULL] A second RISC-V Patch for 4.0.0-rc1

2019-03-26 Thread Palmer Dabbelt
merged tag 'riscv-for-master-4.0-rc1' The following changes since commit 4aef51963924fd58ffe88daebbe8055a360d7c10: Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-4.0-rc1' into staging (2019-03-26 08:51:35 +) are available in the Git repository at: git://github.com/pa

Re: [Qemu-devel] [PULL 0/2] Pflash and firmware configuration patches for 2019-03-26

2019-03-26 Thread Peter Maydell
On Tue, 26 Mar 2019 at 09:10, Markus Armbruster wrote: > > The following changes since commit d132baa05ed7a647067c807fd452ec794cc2ecb7: > > Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' > into staging (2019-03-25 17:01:10 +) > > are available in the Git repositor

Re: [Qemu-devel] [PATCH 4/4] build: don't build hardware objects with linux-user

2019-03-26 Thread Paolo Bonzini
On 26/03/19 10:35, Laurent Vivier wrote: > The change was based on the comments in the file. Right, but the comments do not imply that crypto is being built in the user-only case. In fact, only char/ is being built for --disable-system --disable-tools, and even that is because: 1) --disable-sy

Re: [Qemu-devel] [PATCH] RFC: build-sys: move slirp as git submodule project

2019-03-26 Thread Daniel P . Berrangé
On Tue, Mar 26, 2019 at 06:39:40AM +, Peter Maydell wrote: > On Mon, 25 Mar 2019 at 18:51, Eric Blake wrote: > > On 3/25/19 1:04 PM, Marc-André Lureau wrote: > > > RFC: is this acceptable during freeze? (not a feature or code change) > > > > It's a big enough change that I'd personally feel mo

Re: [Qemu-devel] [PATCH] target/arm: Set SIMDMISC and FPMISC for 32-bit -cpu max

2019-03-26 Thread Peter Maydell
On Mon, 25 Mar 2019 at 16:13, Richard Henderson wrote: > > Fixes: https://bugs.launchpad.net/bugs/1821430 > Signed-off-by: Richard Henderson > --- > target/arm/cpu.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index 96f0ff0ec7..d9b8658921 1

Re: [Qemu-devel] [PATCH for-4.0] gdbstub: fix vCont packet handling when no thread is specified

2019-03-26 Thread Peter Maydell
On Mon, 25 Mar 2019 at 11:05, Luc Michel wrote: > > The vCont packet accepts a series of actions, each being applied on a > given thread ID. Giving no thread ID for an action is valid and means > "all threads". > > This commit fixes vCont packets being incorrectly rejected when no > thread ID was

Re: [Qemu-devel] [PATCH 2/2] usb-mtp: refactor the flow of usb_mtp_write_data

2019-03-26 Thread Peter Maydell
On Tue, 19 Mar 2019 at 21:46, Bandan Das wrote: > > There's no functional change but the flow is (hopefully) > more consistent for both file and folder object types. > > Signed-off-by: Bandan Das > --- > hw/usb/dev-mtp.c | 58 +--- > 1 file changed, 30

Re: [Qemu-devel] [PATCH 1/2] usb-mtp: remove usb_mtp_object_free_one

2019-03-26 Thread Peter Maydell
On Tue, 19 Mar 2019 at 21:46, Bandan Das wrote: > > This function is used in the delete path only and can > be replaced by a call to usb_mtp_object_free. > > Signed-off-by: Bandan Das > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: use variable size of flash device to save memory

2019-03-26 Thread Laszlo Ersek
On 03/26/19 07:17, Markus Armbruster wrote: > Zheng Xiang writes: > >> Hi Peter, >> >> Thanks for your reply! >> >> On 2019/3/25 21:11, Peter Maydell wrote: >>> On Mon, 25 Mar 2019 at 12:53, Xiang Zheng wrote: Currently we fill the VIRT_FLASH space with two 64MB NOR images when us

Re: [Qemu-devel] [PULL] A second RISC-V Patch for 4.0.0-rc1

2019-03-26 Thread Peter Maydell
On Tue, 26 Mar 2019 at 10:25, Palmer Dabbelt wrote: > > merged tag 'riscv-for-master-4.0-rc1' > The following changes since commit 4aef51963924fd58ffe88daebbe8055a360d7c10: > > Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-4.0-rc1' > into staging (2019-03-26 08:51:35 +)

Re: [Qemu-devel] [PATCH v2 1/7] target/mips: Fix . MSA instructions for MIPS big endian host

2019-03-26 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Subject: Re: [PATCH v2 1/7] target/mips: Fix . MSA > instructions for MIPS big endian host > On 25.3.19. 22:21, Aleksandar Markovic wrote: >> From: Mateja Marjanovic >> Subject: [PATCH v2 1/7] target/mips: Fix . MSA instructions >> for MIPS big endian host >> Please

Re: [Qemu-devel] [PATCH] ohci: don't die on ED_LINK_LIMIT overflow

2019-03-26 Thread Gerd Hoffmann
On Thu, Mar 21, 2019 at 09:52:12AM +0100, Laurent Vivier wrote: > Stop processing the descriptor list instead. The next frame timer tick will > resume the work > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1686705 > Suggested-by: Gerd Hoffmann > Signed-off-by: Laurent Vivier Added to

Re: [Qemu-devel] [PATCH] ati-vga: Fix indexed access to video memory

2019-03-26 Thread Gerd Hoffmann
On Mon, Mar 18, 2019 at 11:34:46PM +0100, BALATON Zoltan wrote: > Coverity (CID 1399700) found that this was wrong so instead of trying > to do it by hand use existing access functions that should work better. Added to patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v2 1/7] target/mips: Fix . MSA instructions for MIPS big endian host

2019-03-26 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Subject: Re: [PATCH v2 1/7] target/mips: Fix . MSA > instructions for MIPS big endian host > > > From: Mateja Marjanovic > > Subject: Re: [PATCH v2 1/7] target/mips: Fix . MSA > > instructions for MIPS big endian host > > On 25.3.19. 22:21, Aleksandar Markovic wrot

Re: [Qemu-devel] [Qemu-block] [PATCH] thread-pool: Use an EventNotifier to coordinate with AioContext

2019-03-26 Thread Sergio Lopez
Stefan Hajnoczi writes: > On Mon, Mar 25, 2019 at 02:34:36PM +0100, Sergio Lopez wrote: >> Our current ThreadPool implementation lacks support for AioContext's >> event notifications. This not only means that it can't take advantage >> from the IOThread's adaptive polling, but also that the latt

Re: [Qemu-devel] About making QEMU to LIBs!

2019-03-26 Thread Yang Zhong
On Tue, Mar 26, 2019 at 10:07:35AM +0100, Paolo Bonzini wrote: > On 26/03/19 08:00, Xiao Guangrong wrote: > > On 3/26/19 7:18 AM, Paolo Bonzini wrote: > >> Also, what is the use case?  Is it to reduce the attack surface without > >> having multiple QEMU binaries? > > > > Security is one story we c

Re: [Qemu-devel] [RFC] arm/cpu: fix soft lockup panic after resuming from stop

2019-03-26 Thread Heyi Guo
Hi Steven, Thanks for your explanation. Please see my comments below. On 2019/3/21 0:29, Steven Price wrote: On 19/03/2019 14:39, Heyi Guo wrote: Hi Christoffer and Steve, On 2019/3/15 16:59, Christoffer Dall wrote: Hi Steve, On Wed, Mar 13, 2019 at 10:11:30AM +, Steven Price wrote:

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 10/15] s390-bios: Support for running format-0/1 channel programs

2019-03-26 Thread Thomas Huth
On 13/03/2019 17.31, Jason J. Herne wrote: > Introduce a library function for executing format-0 and format-1 > channel programs and waiting for their completion before continuing > execution. > > Add cu_type() to channel io library. This will be used to query control > unit type which is used to

Re: [Qemu-devel] [PULL 05/15] multifd: Be flexible about packet size

2019-03-26 Thread Peter Maydell
On Mon, 25 Mar 2019 at 18:13, Juan Quintela wrote: > > This way we can change the packet size in the future and everything > will work. We choose an arbitrary big number (100 times configured > size) as a limit about how big we will reallocate. > > Signed-off-by: Juan Quintela > Reviewed-by: Dr.

Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: Silence coverity CID 1390625

2019-03-26 Thread Peter Maydell
On Fri, 16 Nov 2018 at 18:43, John Snow wrote: > > Coverity warns that backing_bs() could give us a NULL pointer, which > we then use without checking that it isn't. > > In our loop condition, we check bs && bs->drv as a point of habit, but > by nature of the block graph, we cannot have null bs po

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 01/15] s390 vfio-ccw: Add bootindex property and IPLB data

2019-03-26 Thread Thomas Huth
On 13/03/2019 17.31, Jason J. Herne wrote: > Add bootindex property and iplb data for vfio-ccw devices. This allows us to > forward boot information into the bios for vfio-ccw devices. > > Refactor s390_get_ccw_device() to return device type. This prevents us from > having to use messy casting log

Re: [Qemu-devel] [PATCH RFC v4 01/12] target/rx: TCG translation

2019-03-26 Thread Yoshinori Sato
On Tue, 26 Mar 2019 00:50:53 +0900, Richard Henderson wrote: > > On 3/25/19 2:38 AM, Yoshinori Sato wrote: > >>> +static bool trans_EMUL_mr(DisasContext *ctx, arg_EMUL_mr *a) > >>> +{ > >>> +TCGv val, mem; > >>> +mem = tcg_temp_new(); > >>> +val = rx_load_source(ctx, mem, a->ld, a->mi,

Re: [Qemu-devel] [PATCH V2 RFT] vhost_net: don't set backend for the uninitialized virtqueue

2019-03-26 Thread Michael S. Tsirkin
On Tue, Mar 26, 2019 at 02:59:19PM +0800, Jason Wang wrote: > > On 2019/3/25 下午8:32, Michael S. Tsirkin wrote: > > On Mon, Mar 25, 2019 at 11:56:13AM +0800, Jason Wang wrote: > > > We used to set backend unconditionally, this won't work for some > > > guests (e.g windows driver) who may not initia

[Qemu-devel] [PATCH v2 0/4] pvrdma: Add support for SRQ

2019-03-26 Thread Kamal Heib
This series implements the SRQ (Shared Receive Queue) for the pvrdma device, It also includes all the needed functions and definitions for support SRQ in the backend and resource management layers. Changes from v1->v2: - Handle checkpatch.pl warnings. Kamal Heib (4): hw/rdma: Add SRQ support t

[Qemu-devel] [PATCH v2 1/4] hw/rdma: Add SRQ support to backend layer

2019-03-26 Thread Kamal Heib
Add the required function and definitions for support shared receive queues (SRQs) in the backend layer. Signed-off-by: Kamal Heib --- hw/rdma/rdma_backend.c | 116 +++- hw/rdma/rdma_backend.h | 12 hw/rdma/rdma_backend_defs.h | 5 ++ 3 files cha

[Qemu-devel] [PATCH v2 4/4] hw/pvrdma: Add support for SRQ

2019-03-26 Thread Kamal Heib
Implement the pvrdma device commands for supporting SRQ Signed-off-by: Kamal Heib --- hw/rdma/vmw/pvrdma_cmd.c| 147 hw/rdma/vmw/pvrdma_main.c | 16 hw/rdma/vmw/pvrdma_qp_ops.c | 46 ++- hw/rdma/vmw/pvrdma_qp_ops.h | 1 + 4 files change

[Qemu-devel] [PATCH v2 2/4] hw/rdma: Add support for managing SRQ resource

2019-03-26 Thread Kamal Heib
Adding the required functions and definitions for support managing the shared receive queues (SRQs). Signed-off-by: Kamal Heib --- hw/rdma/rdma_rm.c | 83 ++ hw/rdma/rdma_rm.h | 10 + hw/rdma/rdma_rm_defs.h | 8 3 files changed, 101 ins

[Qemu-devel] [PATCH v2 3/4] hw/rdma: Modify create/destroy QP to support SRQ

2019-03-26 Thread Kamal Heib
Modify create/destroy QP to support shared receive queue. Signed-off-by: Kamal Heib --- hw/rdma/rdma_backend.c | 9 -- hw/rdma/rdma_backend.h | 6 ++-- hw/rdma/rdma_rm.c| 23 +-- hw/rdma/rdma_rm.h| 3 +- hw/rdma/rdma_rm_defs.h | 1 + hw/rdma/vmw/pvrdma_c

Re: [Qemu-devel] [PATCH 0/2] kconfig: add fine-grained dependencies for MSI

2019-03-26 Thread Michael S. Tsirkin
On Thu, Mar 14, 2019 at 03:30:30PM +0100, Paolo Bonzini wrote: > RISC-V targets did not include PCIe ports before the Kconfig transition, > and grew them afterwards, but they are nonfunctional because the interrupt > controller does not support MSI. This patch restores the situation prior to > the

[Qemu-devel] QEMU event loop optimizations

2019-03-26 Thread Stefan Hajnoczi
Hi Sergio, Here are the forgotten event loop optimizations I mentioned: https://github.com/stefanha/qemu/commits/event-loop-optimizations The goal was to eliminate or reorder syscalls so that useful work (like executing BHs) occurs as soon as possible after an event is detected. I remember tha

[Qemu-devel] [PATCH for 4.1 v2 13/13] tests: add expected ACPI tables for arm/virt board

2019-03-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/data/acpi/virt/APIC | Bin 0 -> 168 bytes tests/data/acpi/virt/DSDT | Bin 0 -> 18476 bytes tests/data/acpi/virt/FACP | Bin 0 -> 268 bytes tests/data/acpi/virt/GTDT | Bin 0 -> 96 bytes tests/data/acpi/virt/MCFG | Bin 0 -> 60 bytes tests/data/acpi/virt/SPC

[Qemu-devel] [PATCH for 4.1 v2 09/13] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-03-26 Thread Igor Mammedov
once FW provides a pointer to SMBIOS entry point like it does for RSDP it should be possible to enable this one the same way. Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/bios-tables-test.c b/tests/bios

[Qemu-devel] [PATCH for 4.1 v2 11/13] tests: acpi: refactor rebuild-expected-aml.sh to dump ACPI tables for a specified list of targets

2019-03-26 Thread Igor Mammedov
Make initial list contain aarch64 and x86_64 targets. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- v2: * fix up error message (Philippe Mathieu-Daudé ) --- tests/data/acpi/rebuild-expected-aml.sh | 23 +++ 1 file changed, 11 insertions(+), 12 deletio

[Qemu-devel] [PULL 2/2] gdbstub: fix vCont packet handling when no thread is specified

2019-03-26 Thread Peter Maydell
From: Luc Michel The vCont packet accepts a series of actions, each being applied on a given thread ID. Giving no thread ID for an action is valid and means "all threads". This commit fixes vCont packets being incorrectly rejected when no thread ID was given for an action. In multiprocess mode,

[Qemu-devel] [PATCH for 4.1 v2 12/13] tests: acpi: print error unable to dump ACPI table during rebuild

2019-03-26 Thread Igor Mammedov
Instead of just asserting print the error that lead to assert first. While at it move assert into rebuild branch, which removes reduntant check done in case of !rebuild branch is taken (the later is taken care of by g_assert_no_error). Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c |

[Qemu-devel] [PATCH for 4.1 v2 10/13] tests: acpi: add simple arm/virt testcase

2019-03-26 Thread Igor Mammedov
adds simple arm/virt test case that starts guest with bios-tables-test.aarch64.iso.qcow2 boot image which initializes UefiTestSupport* structure in RAM once guest is booted. * see commit: tests: acpi: add acpi_find_rsdp_address_uefi() helper Signed-off-by: Igor Mammedov --- v3: * use firmware

[Qemu-devel] [PATCH for 4.1 v2 06/13] tests: acpi: move boot_sector_init() into x86 tests branch

2019-03-26 Thread Igor Mammedov
boot_sector_init() won't be used by arm/virt board, so move it from global scope to x86 branch that uses it. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- tests/bios-tables-test.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/bios-table

[Qemu-devel] [PULL 1/2] target/arm: Set SIMDMISC and FPMISC for 32-bit -cpu max

2019-03-26 Thread Peter Maydell
From: Richard Henderson Fixes: https://bugs.launchpad.net/bugs/1821430 Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-id: 20190325161338.6536-1-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/cpu.c | 5 + 1 f

[Qemu-devel] [PATCH for 4.1 v2 08/13] tests: acpi: add a way to start tests with UEFI firmware

2019-03-26 Thread Igor Mammedov
For testcase to use UEFI firmware, one needs to provide and specify firmwarei and varstore blobs names in test_data { uefi_fl1, uefi_fl2) } fields respectively and RAM start address plus size where to look for test structure signature. Additionally testcase should specify bootable cdrom image uefi-

[Qemu-devel] [PATCH for 4.1 v2 07/13] tests: acpi: add acpi_find_rsdp_address_uefi() helper

2019-03-26 Thread Igor Mammedov
introduce UEFI specific counterpart to acpi_find_rsdp_address() that will help to find RSDP address when [OA]VMF is used as firmware. It requires guest firmware or other guest app to place 1Mb aligned UefiTestSupport structure (defined in this patch) in RAM with UefiTestSupport::signature_guid set

[Qemu-devel] [PULL 0/2] target-arm queue

2019-03-26 Thread Peter Maydell
10:27:20 +) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20190326 for you to fetch changes up to c99ef792dc9ec6d8a5061428faf396ea9ceb8f57: gdbstub: fix vCont packet handling when no thread is specified (2019-03-26

[Qemu-devel] [PATCH for 4.1 v2 05/13] tests: acpi: skip FACS table if board uses hw reduced ACPI profile

2019-03-26 Thread Igor Mammedov
If FADT has HW_REDUCED_ACPI flag set, do not attempt to fetch FACS as it's not provided by the board. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- tests/bios-tables-test.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/bios-tables-te

  1   2   3   >