Re: [Qemu-devel] [RFC for-4.1 22/25] target/ppc: Style fixes for translate/fp-impl.inc.c

2019-03-25 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/translate/fp-impl.inc.c | 52 ++ > 1 file changed, 32 insertions(+), 20 deletions(-) > > diff --git a/target/ppc/translate/fp-impl.i

Re: [Qemu-devel] [RFC for-4.1 23/25] target/ppc: Style fixes for translate/vsx-impl.inc.c

2019-03-25 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/translate/vsx-impl.inc.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/target/ppc/translate/vsx-impl.inc.c > b/target

Re: [Qemu-devel] [PATCH v12 for-4.1 02/11] qemu_thread: supplement error handling for qemu_X_start_vcpu

2019-03-25 Thread Fei Li
在 2019/3/25 上午9:45, David Gibson 写道: On Mon, Mar 25, 2019 at 12:51:57AM +0800, Fei Li wrote: From: Fei Li The callers of qemu_init_vcpu() already passed the **errp to handle errors. In view of this, add a new Error parameter to qemu_init_vcpu() and all qemu_X_start_vcpu() functions called by

Re: [Qemu-devel] [PATCH v7 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-03-25 Thread Aravinda Prasad
On Monday 25 March 2019 11:46 AM, David Gibson wrote: > On Fri, Mar 22, 2019 at 12:03:39PM +0530, Aravinda Prasad wrote: >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls. >> >> The machine check notification address is saved when the >> OS iss

Re: [Qemu-devel] [PULL 02/29] ppc/spapr: Receive and store device tree blob from SLOF

2019-03-25 Thread Greg Kurz
On Mon, 25 Mar 2019 11:53:47 +1100 David Gibson wrote: > On Sun, Mar 24, 2019 at 12:03:54AM -0400, Brad Smith wrote: > > Now that I am checking out 4.0.0 rc's I see this diff is broken and > > depends on a function libfdt does not expose. The breakage is > > hidden by the fallback check in the co

Re: [Qemu-devel] [PATCH v7 2/6] Wrapper function to wait on condition for the main loop mutex

2019-03-25 Thread Aravinda Prasad
On Monday 25 March 2019 11:47 AM, David Gibson wrote: > On Fri, Mar 22, 2019 at 12:03:49PM +0530, Aravinda Prasad wrote: >> Introduce a wrapper function to wait on condition for >> the main loop mutex. This function atomically releases >> the main loop mutex and causes the calling thread to >> b

Re: [Qemu-devel] [RFC for-4.1 25/25] target/ppc: Style fixes for translate/spe-impl.inc.c

2019-03-25 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/translate/spe-impl.inc.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/target/ppc/translate/spe-impl.inc.c > b/target

Re: [Qemu-devel] [RFC for-4.1 24/25] target/ppc: Style fixes for translate/vmx-impl.inc.c

2019-03-25 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/translate/vmx-impl.inc.c | 26 +++--- > 1 file changed, 15 insertions(+), 11 deletions(-) > > diff --git a/target/ppc/translate/vmx-impl.inc

Re: [Qemu-devel] [PATCH v4 3/8] slirp: clarify license of slirp files using SPDX: explicit BSD

2019-03-25 Thread Cédric Le Goater
On 3/22/19 5:43 PM, Marc-André Lureau wrote: > Add SPDX license identifier to clarify the license of files with > explicit 3-clause BSD license header. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Thomas Huth [ clg: for the NC-SI files ] Reviewed-by: Cédric Le Goater Thanks, C. > --

Re: [Qemu-devel] [RFC for-4.1 20/25] target/ppc: Style fixes for translate_init.inc.c

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 07:39:32AM +0100, Cédric Le Goater wrote: > On 3/22/19 1:15 AM, David Gibson wrote: > > Signed-off-by: David Gibson > > There is a printf() we could change below. Anyhow, What did you have in mind? > > Reviewed-by: Cédric Le Goater > > Thanks, > > C. > > > --- > >

Re: [Qemu-devel] [Bug 1772165] Re: arm raspi2/raspi3 emulation has no USB support

2019-03-25 Thread Peter Maydell
On Sun, 24 Mar 2019 at 17:34, mcandre wrote: > Out of curiousity, does the raspi2 machine support a PCI bus? No. There is no PCI bus on the raspi2 hardware and so there is no PCI bus in QEMU's model of it. > I am > trying to boot Debian arm64 with qemu-system-aarch64, and am running > into all m

Re: [Qemu-devel] [PATCH v7 3/6] target/ppc: Handle NMI guest exit

2019-03-25 Thread Aravinda Prasad
On Monday 25 March 2019 11:52 AM, David Gibson wrote: > On Fri, Mar 22, 2019 at 12:03:58PM +0530, Aravinda Prasad wrote: >> Memory error such as bit flips that cannot be corrected >> by hardware are passed on to the kernel for handling. >> If the memory address in error belongs to guest then >>

[Qemu-devel] [Bug 1821444] Re: qemu-ppc (user) incorrectly translates float32 arithmetics

2019-03-25 Thread Sergei Trofimovich
Alternatively 'uint64_t helper_todouble(uint32_t)' could be implemented via include/fpu/softfloat.h:float64 float32_to_float64(float32, float_status *status); -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad

Re: [Qemu-devel] [RFC for-4.1 20/25] target/ppc: Style fixes for translate_init.inc.c

2019-03-25 Thread Cédric Le Goater
On 3/25/19 7:52 AM, David Gibson wrote: > On Mon, Mar 25, 2019 at 07:39:32AM +0100, Cédric Le Goater wrote: >> On 3/22/19 1:15 AM, David Gibson wrote: >>> Signed-off-by: David Gibson >> >> There is a printf() we could change below. Anyhow, > > What did you have in mind? [ ... ] This printf cou

Re: [Qemu-devel] [PATCH v7 4/6] target/ppc: Build rtas error log

2019-03-25 Thread Aravinda Prasad
On Monday 25 March 2019 12:00 PM, David Gibson wrote: > On Fri, Mar 22, 2019 at 12:04:07PM +0530, Aravinda Prasad wrote: >> This patch builds the rtas error log, copies it to the >> rtas_addr and then invokes the guest registered machine >> check handler. > > This commit message needs more cont

Re: [Qemu-devel] [OFFTOPIC PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

2019-03-25 Thread Michal Privoznik
On 3/21/19 6:03 PM, Peter Maydell wrote: (We're probably going to get rid of in-tree build support in 4.1.) Sorry for hijicking the thread, but can you point in me the discussion on the list where was this discussed please? I'm unable to find it. As a person who does in tree builds only I'm i

Re: [Qemu-devel] [OFFTOPIC PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

2019-03-25 Thread Peter Maydell
On Mon, 25 Mar 2019 at 08:29, Michal Privoznik wrote: > > On 3/21/19 6:03 PM, Peter Maydell wrote: > > (We're probably going to get rid of in-tree build support in 4.1.) > > Sorry for hijicking the thread, but can you point in me the discussion > on the list where was this discussed please? I'm un

Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 16/25] target/ppc: Style fixes for mmu-hash32.[ch]

2019-03-25 Thread Greg Kurz
On Fri, 22 Mar 2019 11:15:35 +1100 David Gibson wrote: > Signed-off-by: David Gibson > --- > target/ppc/mmu-hash32.c | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c > index e8562a7c87..f83944b78c 10

Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 00/25] Many style fixes for target/ppc

2019-03-25 Thread Greg Kurz
Hi anyone about to comment on this series, Be aware there's a bogus gr...@nongnu.org address is Cc list. Feel free to change it to gr...@kaod.org or to remove it when you post. I'm watching the thread anyway. Cheers, -- Greg On Fri, 22 Mar 2019 11:15:19 +1100 David Gibson wrote: > target/ppc

Re: [Qemu-devel] [PATCH v7 5/6] ppc: spapr: Enable FWNMI capability

2019-03-25 Thread Aravinda Prasad
On Monday 25 March 2019 12:02 PM, David Gibson wrote: > On Fri, Mar 22, 2019 at 12:04:16PM +0530, Aravinda Prasad wrote: >> Enable the KVM capability KVM_CAP_PPC_FWNMI so that >> the KVM causes guest exit with NMI as exit reason >> when it encounters a machine check exception on the >> address b

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-4.0 0/3] target/ppc: Fix pseries.cap-ibs=workaround with TCG

2019-03-25 Thread Greg Kurz
On Mon, 25 Mar 2019 11:31:04 +1100 Suraj Jitindar Singh wrote: > On Fri, 2019-03-22 at 19:03 +0100, Greg Kurz wrote: > > Since recent commit 2782ad4c4102 "target/ppc/spapr: Enable > > mitigations by > > default for pseries-4.0 machine type", some recent distros, eg. > > fedora29, > > fail to boot

[Qemu-devel] [PATCH RFC v5 09/12] hw/rx: RX Target hardware definition

2019-03-25 Thread Yoshinori Sato
rx62n - RX62N cpu. rxqemu - QEMU virtual target. Signed-off-by: Yoshinori Sato --- include/hw/rx/rx.h| 7 ++ include/hw/rx/rx62n.h | 54 hw/rx/rx62n.c | 226 ++ hw/rx/rxqemu.c| 100 ++ hw/rx/K

[Qemu-devel] [PATCH RFC v5 06/12] hw/intc: RX62N interrupt controller (ICUa)

2019-03-25 Thread Yoshinori Sato
This implementation supported only ICUa. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato --- include/hw/intc/rx_icu.h | 49 +++ hw/intc/rx_icu.c | 373 +++

[Qemu-devel] [PATCH RFC v5 12/12] include/hw/regiserfields.h: Add 8bit and 16bit registers

2019-03-25 Thread Yoshinori Sato
Some RX peripheral using 8bit and 16bit registers. Added 8bit and 16bit APIs. Signed-off-by: Yoshinori Sato --- include/hw/registerfields.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/hw/registerfields.h b/include/hw/registerfields.h index 2659a58737..f6bf911990 10064

[Qemu-devel] [PATCH RFC v5 02/12] target/rx: TCG helper

2019-03-25 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- target/rx/helper.h| 31 target/rx/helper.c| 148 target/rx/op_helper.c | 481 ++ 3 files changed, 660 insertions(+) create mode 100644 target/rx/helper.h create mode 100644 target/rx

[Qemu-devel] [PATCH RFC v5 05/12] target/rx: Miscellaneous files

2019-03-25 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- target/rx/gdbstub.c | 112 target/rx/monitor.c | 38 target/rx/Makefile.objs | 11 + 3 files changed, 161 insertions(+) create mode 100644 target/rx/gdbstub.c create mode 100644 tar

[Qemu-devel] [PATCH RFC v5 00/12] Add RX archtecture support

2019-03-25 Thread Yoshinori Sato
Hello. This patch series is added Renesas RX target emulation. Update review comments and fix some issues. My git repository is bellow. git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git Testing binaries bellow. u-boot Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz starting $ g

[Qemu-devel] [PATCH RFC v5 08/12] hw/char: RX62N serical communication interface (SCI)

2019-03-25 Thread Yoshinori Sato
This module supported only non FIFO type. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato --- include/hw/char/renesas_sci.h | 45 ++ hw/char/renesas_sci.c | 335 +

[Qemu-devel] [PATCH RFC v5 07/12] hw/timer: RX62N internal timer modules

2019-03-25 Thread Yoshinori Sato
renesas_tmr: 8bit timer modules. renesas_cmt: 16bit compare match timer modules. This part use many renesas's CPU. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato --- include/hw/timer/renesas_cmt.h | 33 +++

[Qemu-devel] [PATCH RFC v5 04/12] target/rx: RX disassembler

2019-03-25 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- include/disas/bfd.h |5 + target/rx/disas.c | 1486 +++ 2 files changed, 1491 insertions(+) create mode 100644 target/rx/disas.c diff --git a/include/disas/bfd.h b/include/disas/bfd.h index 41b61c85f9..b2c34

Re: [Qemu-devel] [PATCH v7 6/6] migration: Block migration while handling machine check

2019-03-25 Thread Aravinda Prasad
On Monday 25 March 2019 12:03 PM, David Gibson wrote: > On Fri, Mar 22, 2019 at 12:04:25PM +0530, Aravinda Prasad wrote: >> Block VM migration requests until the machine check >> error handling is complete as (i) these errors are >> specific to the source hardware and is irrelevant on >> the tar

[Qemu-devel] [PATCH RFC v5 11/12] MAINTAINERS: Add RX

2019-03-25 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- MAINTAINERS | 19 +++ 1 file changed, 19 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 85d7d764e5..046dbd8eb6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -272,6 +272,13 @@ F: include/hw/riscv/ F: linux-user/host/riscv32/ F: linux

[Qemu-devel] [PATCH RFC v5 03/12] target/rx: CPU definition

2019-03-25 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- target/rx/cpu-qom.h | 52 target/rx/cpu.h | 195 +++ target/rx/cpu.c | 232 3 files changed, 479 insertions(+) create mode 100644 target/rx/cpu-qom

[Qemu-devel] [PATCH RFC v5 10/12] Add rx-softmmu

2019-03-25 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- configure | 8 default-configs/rx-softmmu.mak | 7 +++ include/sysemu/arch_init.h | 1 + arch_init.c| 2 ++ hw/Kconfig | 1 + 5 files changed, 19 insertions(+) create mode 100644 defau

Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 17/25] target/ppc: Style fixes for mmu-hash64.[ch]

2019-03-25 Thread Greg Kurz
On Fri, 22 Mar 2019 11:15:36 +1100 David Gibson wrote: > Signed-off-by: David Gibson > --- Maybe you can fold the following in this patch: --- --- a/target/ppc/mmu-hash64.c +++ b/target/ppc/mmu-hash64.c @@ -750,8 +750,10 @@ int pp

[Qemu-devel] [PATCH RFC v5 01/12] target/rx: TCG translation

2019-03-25 Thread Yoshinori Sato
This part only supported RXv1 instructions. Instruction manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf Signed-off-by: Yoshinori Sato --- target/rx/translate.c | 2421 target/rx/insns.decode | 617

Re: [Qemu-devel] [PATCH RFC v4 04/12] target/rx: RX disassembler

2019-03-25 Thread Yoshinori Sato
On Fri, 22 Mar 2019 04:39:29 +0900, Richard Henderson wrote: > > On 3/20/19 7:16 AM, Yoshinori Sato wrote: > > +static const char *cond[] = { > > +"eq", "ne", "c", "nc", "gtu", "leu", "pz", "n", > > +"ge", "lt", "gt", "le", "o", "no", "ra", "f" > > +}; > > const char * const cond[] > > O

Re: [Qemu-devel] [PATCH RFC v4 03/12] target/rx: CPU definition

2019-03-25 Thread Yoshinori Sato
On Fri, 22 Mar 2019 04:28:03 +0900, Richard Henderson wrote: > > On 3/20/19 7:16 AM, Yoshinori Sato wrote: > > +#define FPSW_MASK 0xfc007cff > > +#define FPSW_RM_MASK 0x0003 > > +#define FPSW_DN (1 << 8) > > It's slightly confusing to have this as a mask, > > > +#define FPSW_CAUSE_MASK 0x000

Re: [Qemu-devel] [PATCH RFC v5 00/12] Add RX archtecture support

2019-03-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190325090047.122981-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH RFC v5 00/12] Add RX archtecture support Message-id: 20190325090047.122981-1-

Re: [Qemu-devel] [PATCH RFC v4 02/12] target/rx: TCG helper

2019-03-25 Thread Yoshinori Sato
On Fri, 22 Mar 2019 02:17:35 +0900, Richard Henderson wrote: > > On 3/20/19 7:16 AM, Yoshinori Sato wrote: > > +void rx_cpu_unpack_psw(CPURXState *env, int all) > > +{ > > +if (env->psw_pm == 0) { > > +env->psw_ipl = extract32(env->psw, PSW_IPL, 4); > > +if (all) { > > +

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Report bdrv_block_status failures

2019-03-25 Thread Kevin Wolf
Am 23.03.2019 um 22:26 hat Eric Blake geschrieben: > If bdrv_block_status_above() fails, we are aborting the convert > process but failing to print an error message. Broken in commit > 690c7301 (v2.4) when rewriting convert's logic. > > Discovered when teaching nbdkit to support NBD_CMD_BLOCK_STA

Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 18/25] target/ppc: Style fixes for mmu_helper.c

2019-03-25 Thread Greg Kurz
On Fri, 22 Mar 2019 11:15:37 +1100 David Gibson wrote: > Signed-off-by: David Gibson > --- > target/ppc/mmu_helper.c | 131 > 1 file changed, 80 insertions(+), 51 deletions(-) > > diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c > index 4a

Re: [Qemu-devel] [PATCH for-4.0] target/arm: Fix non-parallel expansion of CASP

2019-03-25 Thread Peter Maydell
On Fri, 22 Mar 2019 at 23:43, Richard Henderson wrote: > > The second word has been loaded from the unincremented > address since the first commit. > > Fixes: 44ac14b06fa > Reported-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 2 +- > 1 file changed, 1

Re: [Qemu-devel] [PATCH RFC v4 01/12] target/rx: TCG translation

2019-03-25 Thread Yoshinori Sato
On Thu, 21 Mar 2019 14:40:11 +0900, Richard Henderson wrote: > > On 3/20/19 7:15 AM, Yoshinori Sato wrote: > > +/* [ri, rb] */ > > +static inline void rx_gen_regindex(DisasContext *ctx, TCGv mem, > > Please drop all of the inline markers. > Let the compiler choose which are profitable to inline.

Re: [Qemu-devel] [PATCH v2] iotests: add 248: test resume mirror after auto pause on ENOSPC

2019-03-25 Thread Vladimir Sementsov-Ogievskiy
Hi, should I ping? Kevin, I thought you want to queue it for 4.0? 20.03.2019 14:59, Vladimir Sementsov-Ogievskiy wrote: > Test that mirror job actually resume on resume command after being > automatically paused on ENOSPC error. > > It's a follow-up test for 8d9648cbf3e > "blockjob: fix use

Re: [Qemu-devel] [PATCH v2] iotests: add 248: test resume mirror after auto pause on ENOSPC

2019-03-25 Thread Kevin Wolf
Am 20.03.2019 um 12:59 hat Vladimir Sementsov-Ogievskiy geschrieben: > Test that mirror job actually resume on resume command after being > automatically paused on ENOSPC error. > > It's a follow-up test for 8d9648cbf3e > "blockjob: fix user pause in block_job_error_action" > > Signed-off-by:

Re: [Qemu-devel] [PATCH V2 RFT] vhost_net: don't set backend for the uninitialized virtqueue

2019-03-25 Thread Jason Wang
On 2019/3/25 下午5:56, Yuri Benditovich wrote: Hi Jason, This seems ok now (4 previous patches + this one) Thanks for the testing. Could you test with just this patch? Since even without 4 previous patch, we've already had the check through virtio_queue_get_desc_addr() in vhost_virtqueue_st

Re: [Qemu-devel] [PATCH 0/3] target/arm: pmu fixes

2019-03-25 Thread Peter Maydell
On Fri, 22 Mar 2019 at 16:23, Andrew Jones wrote: > > The first two patches fix a regression I found when running > the arm (as opposed to arm64) pmu kvm-unit-tests test on tcg, > > $ git clone git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git > $ cd kvm-unit-tests > $ ./configure --a

Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 21/25] target/ppc: Style fixes for translate.c

2019-03-25 Thread Greg Kurz
On Fri, 22 Mar 2019 11:15:40 +1100 David Gibson wrote: > Signed-off-by: David Gibson > --- > target/ppc/translate.c | 507 + > 1 file changed, 315 insertions(+), 192 deletions(-) > > diff --git a/target/ppc/translate.c b/target/ppc/translate.c > index 98

Re: [Qemu-devel] [PATCH] target/arm: default config

2019-03-25 Thread Peter Maydell
On Fri, 22 Mar 2019 at 16:31, Andrew Jones wrote: > > In the kconfig shuffle arm lost pci-testdev which is used by > kvm-unit-tests. Let's add it back. > > Signed-off-by: Andrew Jones > --- > default-configs/arm-softmmu.mak | 1 + Applied to target-arm.next (with a tweaked subject line), thank

Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 00/25] Many style fixes for target/ppc

2019-03-25 Thread Greg Kurz
On Fri, 22 Mar 2019 11:15:19 +1100 David Gibson wrote: > target/ppc has a lot of old code that doesn't stick to the modern > style guidelines. That means we keep getting checkpatch warnings from > code motions in there, or from people copying the local style rather > than the global style. > >

Re: [Qemu-devel] [PATCH V2 RFT] vhost_net: don't set backend for the uninitialized virtqueue

2019-03-25 Thread Yuri Benditovich
Hi Jason, This seems ok now (4 previous patches + this one) On Mon, Mar 25, 2019 at 5:56 AM Jason Wang wrote: > > We used to set backend unconditionally, this won't work for some > guests (e.g windows driver) who may not initialize all virtqueues. For > kernel backend, this will fail since it ma

Re: [Qemu-devel] [Qemu-arm] [PATCH v2] nrf51_gpio: reflect pull-up/pull-down to IRQs

2019-03-25 Thread Peter Maydell
On Sun, 17 Mar 2019 at 14:13, Paolo Bonzini wrote: > > Some drivers do I2C bitbanging by keeping the output to 0 and flipping > the GPIO direction between input and output (see for example in Linux > gpio_set_open_drain_value_commit, in drivers/gpio/gpiolib.c). > When the GPIO is set to input, the

Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 20/25] target/ppc: Style fixes for translate_init.inc.c

2019-03-25 Thread Greg Kurz
On Fri, 22 Mar 2019 11:15:39 +1100 David Gibson wrote: > Signed-off-by: David Gibson > --- > target/ppc/translate_init.inc.c | 240 +++- > 1 file changed, 146 insertions(+), 94 deletions(-) > > diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init

Re: [Qemu-devel] [PATCH v5] hw/acpi: extract acpi_add_rom_blob()

2019-03-25 Thread Igor Mammedov
On Mon, 25 Mar 2019 13:59:10 +0800 Wei Yang wrote: > arm and i386 has almost the same function acpi_add_rom_blob(), except > giving different FWCfgCallback function. > > This patch moves acpi_add_rom_blob() to utils.c by passing > FWCfgCallback to it. > > Signed-off-by: Wei Yang > > --- > v5:

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-25 Thread Peter Maydell
On Mon, 18 Mar 2019 at 15:59, Alex Bennée wrote: > > > Peter Maydell writes: > > > At the moment the Arm implementations of kvm_arch_{get,put}_registers() > > don't support having QEMU change the values of system registers > > (aka coprocessor registers for AArch32). This is because although > >

[Qemu-devel] [PATCH] hostmem: Disable add/del memory during migration

2019-03-25 Thread Yury Kotov
I found a bug in QEMU 2.12 with adding memory-backend while live migration thread is running. But it seems that this bug was implicitly fixed in this commit (QEMU 3.0): b895de50: migration: discard non-migratable RAMBlocks I think it's better to disallow add/del memory backends during migration

Re: [Qemu-devel] [PATCH for-4.0] nbd: Permit simple error to NBD_CMD_BLOCK_STATUS

2019-03-25 Thread Vladimir Sementsov-Ogievskiy
23.03.2019 17:24, Eric Blake wrote: > The NBD spec is clear that when structured replies are active, a > simple error reply is acceptable to any command except for > NBD_CMD_READ. However, we were mistakenly requiring structured errors > for NBD_CMD_BLOCK_STATUS, and hanging up on a server that ga

Re: [Qemu-devel] qemu-system-x86_64: Initialization of device isa-pcspk failed: Initializing audio voice failed

2019-03-25 Thread Daniel P . Berrangé
On Sun, Mar 24, 2019 at 11:39:43AM +0100, Dominick Grift wrote: > qemu-kvm-4.0.0-0.2.rc0.fc31.x86_64 > > 2019-03-24 10:09:11,070: cmd: qemu-system-x86_64 -no-user-config -m 4096 > --machine accel=kvm -kernel /var/tmp/lorax.imgutils.5oejwg8q/isolinux/vmlinuz > -initrd /var/tmp/lmc-initrd-npcsdyha

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Report bdrv_block_status failures

2019-03-25 Thread Vladimir Sementsov-Ogievskiy
24.03.2019 0:26, Eric Blake wrote: > If bdrv_block_status_above() fails, we are aborting the convert > process but failing to print an error message. Broken in commit > 690c7301 (v2.4) when rewriting convert's logic. > > Discovered when teaching nbdkit to support NBD_CMD_BLOCK_STATUS, and > accid

Re: [Qemu-devel] [PATCH] device_tree: check device tree blob file size

2019-03-25 Thread P J P
Hello David, +-- On Mon, 25 Mar 2019, David Gibson wrote --+ | The only inherent limit to dtb size should be 2^31-1 bytes (the format | uses signed 32-bit ints as offsets). ~2GB of dtb?! Seems quite big to specify the h/w that a kernel is going to run/boot on. | Indeed there shouldn't be any

Re: [Qemu-devel] [PATCH V2 RFT] vhost_net: don't set backend for the uninitialized virtqueue

2019-03-25 Thread Yuri Benditovich
You're right, with just one latest patch things work. On Mon, Mar 25, 2019 at 11:59 AM Jason Wang wrote: > > > On 2019/3/25 下午5:56, Yuri Benditovich wrote: > > Hi Jason, > > > > This seems ok now (4 previous patches + this one) > > > Thanks for the testing. Could you test with just this patch? Si

Re: [Qemu-devel] [PATCH] docker: trivial changes to `make docker` help

2019-03-25 Thread Alex Bennée
Wainer dos Santos Moschetta writes: > Apply double quotes and period punctuation uniformly. > > Signed-off-by: Wainer dos Santos Moschetta Queued to for-4.0/testing-and-fpu-fixes, thanks. -- Alex Bennée

Re: [Qemu-devel] [PATCH] device_tree: check device tree blob file size

2019-03-25 Thread Peter Maydell
On Mon, 25 Mar 2019 at 10:34, P J P wrote: > IMO, generic 2MB of dtb size limit is reasonable; Considering 64KB is the max > we are seeing, plus QEMU has FDT_MAX_SIZE defined to be 0x10(~1MB), and > noone has complained that it's too small. Noone has complained that it's too small because rig

Re: [Qemu-devel] [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

2019-03-25 Thread Laszlo Ersek
Hi Peter, can you please comment: On 03/22/19 10:17, Laszlo Ersek wrote: > On 03/22/19 08:02, Philippe Mathieu-Daudé wrote: >> Le ven. 22 mars 2019 00:33, Laszlo Ersek a écrit : >> >>> On 03/21/19 23:32, Laszlo Ersek wrote: >>> Cool, so let me try this. I'm going to download the xz.old file

[Qemu-devel] [RFC PATCH 08/17] Add a global ResetDomain object for system emulation

2019-03-25 Thread Damien Hedde
All objects contained in this ResetDomain are cold-reset when calling qemu_devices_reset. Also add 2 functions to register/unregister object in this ResetDomain. Signed-off-by: Damien Hedde --- hw/core/reset.c| 56 +- include/sysemu/reset.h | 47 ++

[Qemu-devel] [RFC PATCH 06/17] Add function to control reset with gpio inputs

2019-03-25 Thread Damien Hedde
It adds the possibility to add 2 gpios to control the warm and cold reset. With theses ios, the reset can be maintained during some time. Each io is associated with a state to detect level changes. The cold reset io function is named power_gate as it is really the meaning of this io. Signed-off-b

[Qemu-devel] [RFC PATCH 03/17] make Device and Bus Resettable

2019-03-25 Thread Damien Hedde
This add Resettable interface implementation for both Bus and Device. The init phase default implementation is to call the legacy reset handler. Add a *resetting* counter in both Device and Bus. This counter allows us to handle reentrancy in reset operation. If a device/bus has multiple source tri

[Qemu-devel] [RFC PATCH 07/17] convert qdev/bus_reset_all to Resettable

2019-03-25 Thread Damien Hedde
Change qdev/bus_reset_all implementation. It now triggers a warm reset using the Resettable interface. Signed-off-by: Damien Hedde --- hw/core/qdev.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 8dae26d957..7adf23

[Qemu-devel] [RFC PATCH 10/17] Delete the system ResetDomain at the end of emulation

2019-03-25 Thread Damien Hedde
Signed-off-by: Damien Hedde --- vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vl.c b/vl.c index d61d5604e5..cf081d5264 100644 --- a/vl.c +++ b/vl.c @@ -4611,6 +4611,7 @@ int main(int argc, char **argv, char **envp) monitor_cleanup(); qemu_chr_cleanup(); user_creatable_cl

[Qemu-devel] [RFC PATCH 02/17] Create the ResetDomain QOM object

2019-03-25 Thread Damien Hedde
ResetDomain is an object implementing the Resettable interface. It is a container of several other Resettable and therefore allows to control reset operation over a group of Resettable. Addition and removal in a ResetDomain is done using the functions *reset_domain_register_object* and *reset_doma

[Qemu-devel] [RFC PATCH 01/17] Create Resettable QOM interface

2019-03-25 Thread Damien Hedde
This commit defines an interface allowing multi-phase reset. The phases are INIT, HOLD and EXIT. The reset of a Resettable is controlled with 2 functions: - resettable_assert_reset which starts the reset operation. - resettable_deassert_reset which ends the reset operation. There is also a `r

[Qemu-devel] [RFC 00/17] multi-phase reset mechanism

2019-03-25 Thread Damien Hedde
Hi all, This series is a proposal to implement the multi-phase reset we've discussed here (https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00310.html) and more recently there (https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg00081.html). To summarize, we need a multi-phase reset

[Qemu-devel] [RFC PATCH 09/17] global ResetDomain support for legacy reset handlers

2019-03-25 Thread Damien Hedde
INIT phase of the global ResetDomain now triggers the legacy reset handlers. *qemu_devices_reset* is now equivalent to do a cold reset of the global ResetDomain. Signed-off-by: Damien Hedde --- hw/core/reset.c | 109 +--- 1 file changed, 95 insertions(

[Qemu-devel] [RFC PATCH 17/17] Connect the uart reset gpios in the zynq platform

2019-03-25 Thread Damien Hedde
Connect the two uart reset inputs to the slcr corresponding outputs. Signed-off-by: Damien Hedde --- hw/arm/xilinx_zynq.c | 14 -- include/hw/char/cadence_uart.h | 10 +- 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/x

[Qemu-devel] [RFC PATCH 12/17] Put default sysbus in system reset domain

2019-03-25 Thread Damien Hedde
Switch from reset handler to Resettable interface. Signed-off-by: Damien Hedde --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index cf081d5264..e67f6e6c50 100644 --- a/vl.c +++ b/vl.c @@ -4537,7 +4537,7 @@ int main(int argc, char **argv, char **envp)

[Qemu-devel] [RFC PATCH 05/17] add vmstate description for device reset state

2019-03-25 Thread Damien Hedde
The `device_vmstate_reset` can be added by device specialization, as vmsd subsection, to migrate the reset related device state part. Signed-off-by: Damien Hedde --- hw/core/Makefile.objs | 1 + hw/core/qdev-vmstate.c | 25 + include/hw/qdev-core.h | 6 ++ 3 files

[Qemu-devel] [RFC PATCH 11/17] Put orphan buses in system reset domain

2019-03-25 Thread Damien Hedde
Switch from the legacy reset handlers to the system reset domain in order to use the Resettable interface. Signed-off-by: Damien Hedde --- hw/core/bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/core/bus.c b/hw/core/bus.c index 0a60bb4b24..73b215d2bb 100644 --- a

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Report bdrv_block_status failures

2019-03-25 Thread Vladimir Sementsov-Ogievskiy
25.03.2019 13:27, Vladimir Sementsov-Ogievskiy wrote: > 24.03.2019 0:26, Eric Blake wrote: >> If bdrv_block_status_above() fails, we are aborting the convert >> process but failing to print an error message.  Broken in commit >> 690c7301 (v2.4) when rewriting convert's logic. >> >> Discovered when

Re: [Qemu-devel] [PULL 0/8] Slirp patches

2019-03-25 Thread Peter Maydell
On Fri, 22 Mar 2019 at 19:17, Marc-André Lureau wrote: > > The following changes since commit d97a39d903fe33c45be83ac6943a2f82a3649a11: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' > into staging (2019-03-22 09:37:38 +) > > are available in the Git reposito

[Qemu-devel] [RFC PATCH 14/17] convert cadence_uart to 3-phases reset

2019-03-25 Thread Damien Hedde
Split the existing reset procedure into 3 phases. Test the resetting flag to discard register accesses and character reception. Also adds a active high reset io. Signed-off-by: Damien Hedde --- hw/char/cadence_uart.c | 48 ++ 1 file changed, 44 insertions(

Re: [Qemu-devel] [PATCH for-4.0 2/3] target/ppc: Enable "decrement and test CTR" version of bcctr

2019-03-25 Thread Greg Kurz
On Mon, 25 Mar 2019 17:38:49 +1100 David Gibson wrote: > On Fri, Mar 22, 2019 at 07:03:46PM +0100, Greg Kurz wrote: > > Even if all ISAs up to v3 indeed mention: > > > > If the "decrement and test CTR" option is specified (BO2=0), the > > instruction form is invalid. > > > > The UMs of

[Qemu-devel] [RFC PATCH 04/17] Add local reset methods in Device class

2019-03-25 Thread Damien Hedde
Add 3 methods in device class corresponding to the local part of the 3-phases reset. This allows specialization classes not to care about the ressetting counter and sub-buses. The exit phase method is called only if resetting counter hits 0. Also, these methods are called in `device_reset`. Specia

[Qemu-devel] [RFC PATCH 16/17] Add uart reset support in zynq_slcr

2019-03-25 Thread Damien Hedde
Add two gpio outputs to control the uart resets. Signed-off-by: Damien Hedde --- hw/misc/zynq_slcr.c | 29 + 1 file changed, 29 insertions(+) diff --git a/hw/misc/zynq_slcr.c b/hw/misc/zynq_slcr.c index 47f43e1d8d..5aa8f55b45 100644 --- a/hw/misc/zynq_slcr.c +++ b/hw

[Qemu-devel] [PATCH for-4.0] gdbstub: fix vCont packet handling when no thread is specified

2019-03-25 Thread Luc Michel
The vCont packet accepts a series of actions, each being applied on a given thread ID. Giving no thread ID for an action is valid and means "all threads". This commit fixes vCont packets being incorrectly rejected when no thread ID was given for an action. In multiprocess mode, the GDB Remote Pro

Re: [Qemu-devel] [PATCH 2/2] nbd: Tolerate some server non-compliance in NBD_CMD_BLOCK_STATUS

2019-03-25 Thread Vladimir Sementsov-Ogievskiy
24.03.2019 0:26, Eric Blake wrote: > The NBD spec states that NBD_CMD_FLAG_REQ_ONE (which we currently > always use) should not reply with an extent larger than our request, > and that the server's response should be exactly one extent. Right > now, that means that if a server sends more than one e

[Qemu-devel] [RFC PATCH 15/17] Convert zynq's slcr to 3-phases reset

2019-03-25 Thread Damien Hedde
Change the legacy reset function into the init phase and test the resetting flag in register accesses. Signed-off-by: Damien Hedde --- hw/misc/zynq_slcr.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/misc/zynq_slcr.c b/hw/misc/zynq_slcr.c index baa13d131

[Qemu-devel] [RFC PATCH 13/17] hw/misc/zynq_slcr: use standard register definition

2019-03-25 Thread Damien Hedde
Replace the zynq_slcr registers enum and macros using the hw/registerfields.h macros. Signed-off-by: Damien Hedde Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/misc/zynq_slcr.c | 472 ++-- 1 file changed, 236 insertions(+), 236

[Qemu-devel] tests/test-replication behaves unhelpfully if system is out of disk space

2019-03-25 Thread Peter Maydell
The tests/test-replication code tries to create some temporary working files in /tmp/. If the system it's running on happens to be out of disk space in /tmp/ it fails obscurely like this: ERROR:/home/pm215/qemu/tests/test-replication.c:120:test_blk_write: assertion failed: (async_ret == 0) In par

[Qemu-devel] [PATCH V2] RISC-V: fix single stepping over ret and other branching instructions

2019-03-25 Thread Fabien Chouteau
This patch introduces wrappers around the tcg_gen_exit_tb() and tcg_gen_lookup_and_goto_ptr() functions that handle single stepping, i.e. call gen_exception_debug() when single stepping is enabled. Theses functions are then used instead of the originals, bringing single stepping handling in places

Re: [Qemu-devel] [PATCH] RISC-V: fix single stepping over ret and other branching instructions

2019-03-25 Thread Fabien Chouteau
Thanks Richard, I sent a version 2. On 22/03/2019 16:24, Richard Henderson wrote: > On 3/22/19 4:22 AM, Fabien Chouteau wrote: >> +/* Wrapper around tcg_gen_exit_tb that handles single stepping */ >> +static void exit_tb(DisasContext *ctx, TranslationBlock *tb, unsigned idx) >> +{ >> +if (ctx

[Qemu-devel] About making QEMU to LIBs!

2019-03-25 Thread Yang Zhong
Hello all, Rust-VMM has started to make all features and common modules to crates, and CSP can deploy their VMM on demand. This afternoon, Xiao guangrong and i talked about the light weight VM solitions,and we thought QEMU can do same thing like Rust-vmm, although we can make all modules o

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Report bdrv_block_status failures

2019-03-25 Thread Kevin Wolf
Am 25.03.2019 um 11:27 hat Vladimir Sementsov-Ogievskiy geschrieben: > 24.03.2019 0:26, Eric Blake wrote: > > If bdrv_block_status_above() fails, we are aborting the convert > > process but failing to print an error message. Broken in commit > > 690c7301 (v2.4) when rewriting convert's logic. > >

Re: [Qemu-devel] [PATCH] hostmem: Disable add/del memory during migration

2019-03-25 Thread Juan Quintela
Yury Kotov wrote: > I found a bug in QEMU 2.12 with adding memory-backend while live migration > thread is running. > > But it seems that this bug was implicitly fixed in this commit (QEMU 3.0): > b895de50: migration: discard non-migratable RAMBlocks > > I think it's better to disallow add/del m

Re: [Qemu-devel] [PATCH 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-25 Thread Kevin Wolf
Am 22.03.2019 um 14:21 hat Kevin Wolf geschrieben: > If qemu-img convert sees that the target image isn't zero-initialised > yet, it tries to do an efficient zero write for the whole image first > to save the overhead of repeated explicit zero writes during the > conversion. Obviously, this provide

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-25 Thread gengdongjiu
On 2019/3/25 18:25, Peter Maydell wrote: > Further testing from Alex suggests this is some unrelated > bug or regression (ie not caused by this patch), but: > since the only in-tree use for this patch is to get nested > debugging working and it would be broken for this other > reason even with t

Re: [Qemu-devel] [PATCH v2 1/3] block: introducing 'bdrv_co_delete_file' interface

2019-03-25 Thread Kevin Wolf
Am 22.03.2019 um 18:52 hat Daniel Henrique Barboza geschrieben: > Adding to Block Drivers the capability of being able to clean up > its created files can be useful in certain situations. For the > LUKS driver, for instance, a failure in one of its authentication > steps can leave files in the host

Re: [Qemu-devel] [RFC 00/17] multi-phase reset mechanism

2019-03-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1553510737.git.damien.he...@greensocs.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bas

Re: [Qemu-devel] [PATCH v2 1/3] block: introducing 'bdrv_co_delete_file' interface

2019-03-25 Thread Daniel P . Berrangé
On Mon, Mar 25, 2019 at 01:10:46PM +0100, Kevin Wolf wrote: > Am 22.03.2019 um 18:52 hat Daniel Henrique Barboza geschrieben: > > Adding to Block Drivers the capability of being able to clean up > > its created files can be useful in certain situations. For the > > LUKS driver, for instance, a fail

Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 00/25] Many style fixes for target/ppc

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 09:56:34AM +0100, Greg Kurz wrote: > Hi anyone about to comment on this series, > > Be aware there's a bogus gr...@nongnu.org address is Cc list. Feel > free to change it to gr...@kaod.org or to remove it when you post. > I'm watching the thread anyway. Yeah, sorry about t

  1   2   3   >