Re: [Qemu-devel] [qemu-s390x] [PATCH] hw/s390x: fix clang compilation on 32bit machines

2019-03-24 Thread Marcel Apfelbaum
Hi, On 3/22/19 5:52 PM, Halil Pasic wrote: On Mon, 18 Mar 2019 22:08:50 +0100 Philippe Mathieu-Daudé wrote: Le lun. 18 mars 2019 11:34, Marcel Apfelbaum a écrit : Hi Christian, On 3/18/19 11:27 AM, Christian Borntraeger wrote: On 16.03.19 12:09, Philippe Mathieu-Daudé wrote: Hi Marcel,

Re: [Qemu-devel] [RFT 0/4] Don't start virtqueues that are not enabled for vhost

2019-03-24 Thread Yuri Benditovich
Hi Jason, This series does not do the job. Test case: tap, 4 queues, 2 CPU (so only 2 queues are enabled) For Q0 and Q1 vhost_net_start_one succeeds, For Q2: vhost_net_start_one calls vhost_dev_start (the call succeeds, does not start queue that is not enabled), then vhost_net_start_one calls vhos

[Qemu-devel] [Bug 1821515] Re: qemu-ppc (user) incorrectly converts float(nan)->double(non-nan)

2019-03-24 Thread Sergei Trofimovich
The bug is in the same area as https://bugs.launchpad.net/qemu/+bug/1821444 but in another branch of 'uint64_t helper_todouble(uint32_t arg=0x1)'. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1821515

[Qemu-devel] [Bug 1821515] [NEW] qemu-ppc (user) incorrectly converts float(nan)->double(non-nan)

2019-03-24 Thread Sergei Trofimovich
Public bug reported: Noticed on qemu-3.1.0 on GHC test suite where float32 comparisons didn't work on NaNs. Here is the minimal reproducer: ```c // cat a.c #include #include #include int main() { volatile float f1 = NAN; volatile float f2 = NAN; printf ("f1 (%e, %#x) >= f2 (%e, %

[Qemu-devel] qemu-system-x86_64: Initialization of device isa-pcspk failed: Initializing audio voice failed

2019-03-24 Thread Dominick Grift
qemu-kvm-4.0.0-0.2.rc0.fc31.x86_64 2019-03-24 10:09:11,070: cmd: qemu-system-x86_64 -no-user-config -m 4096 --machine accel=kvm -kernel /var/tmp/lorax.imgutils.5oejwg8q/isolinux/vmlinuz -initrd /var/tmp/lmc-initrd-npcsdyha.img -drive file=/var/tmp/lmc-disk-txw8t0m7.img,cache=unsafe,discard=unma

Re: [Qemu-devel] [Bug 1821430] [NEW] qemu-user-arm (4.0.0-rc0) crashes

2019-03-24 Thread Alex Bennée
asavah writes: > Public bug reported: > > I'm using qemu-user-arm for crosscompilation needs, usually via a wrapper. > qemu-user-arm (4.0.0-rc0) crashes with SIGILL on at least 2 instructions: > > first case (sadly I don't have more data handy, can reproduce at a later time > if needed): > (gd

Re: [Qemu-devel] [PATCH v11 for-4.0 09/11] qemu_thread: supplement error handling for migration

2019-03-24 Thread Fei Li
在 2019/2/5 上午12:34, Dr. David Alan Gilbert 写道: * Markus Armbruster (arm...@redhat.com) wrote: Dave, I tried to review the error paths, in particular resource cleanup, but there's a lot going on, and I'm not feeling confident. Please have a close look. Fei Li writes: From: Fei Li Update

[Qemu-devel] [Bug 1821430] Re: qemu-user-arm (4.0.0-rc0) crashes

2019-03-24 Thread asavah
I should point that -cpu cortex-a53 is not available in qemu-arm, I'm building arm 32 bit stuff. qemu-arm -cpu help Available CPUs: arm1026 arm1136 arm1136-r2 arm1176 arm11mpcore arm926 arm946 cortex-a15 cortex-a7 cortex-a8 cortex-a9 cortex-m0 cortex-m3 cortex-m33 cor

Re: [Qemu-devel] [PATCH v11 for-4.0 06/11] qemu_thread: supplement error handling for emulated_realize

2019-03-24 Thread Fei Li
在 2019/2/15 下午8:35, Fei Li 写道: 在 2019/2/4 下午9:30, Markus Armbruster 写道: Fei Li writes: 在 2019/2/1 下午9:04, Markus Armbruster 写道: Fei Li writes: From: Fei Li Utilize the existed errp to propagate the error and do the corresponding cleanup to replace the temporary &error_abort. Cc: Mar

[Qemu-devel] [Bug 1821430] Re: qemu-user-arm (4.0.0-rc0) crashes

2019-03-24 Thread Peter Maydell
Yeah, unfortunately we don't support cortex-a53 (or other 64-bit CPUs) in qemu-arm. (We also don't support them as highest-EL-is-AArch32 config in system mode.) Ideally we should fill in that gap, but in practice most people aren't building aarch32 code for ARMv8 -- either they want the back-compat

[Qemu-devel] [PATCH v12 for-4.1 04/11] qemu_thread: supplement error handling for pci_edu_realize

2019-03-24 Thread Fei Li
From: Fei Li Utilize the existed errp to propagate the error and do the corresponding cleanup to replace the temporary &error_abort. Cc: Markus Armbruster Cc: Jiri Slaby Signed-off-by: Fei Li Reviewed-by: Markus Armbruster --- hw/misc/edu.c | 11 --- 1 file changed, 8 insertions(+),

[Qemu-devel] [PATCH v12 for-4.1 00/11] qemu_thread_create: propagate the error to callers to handle

2019-03-24 Thread Fei Li
Hi, This idea comes from BiteSizedTasks, and this patch series implement the error checking of qemu_thread_create: make qemu_thread_create return a flag to indicate if it succeeded rather than failing with an error; make all callers check it. The first patch modifies the qemu_thread_create() by p

[Qemu-devel] [PATCH v12 for-4.1 06/11] qemu_thread: supplement error handling for emulated_realize

2019-03-24 Thread Fei Li
From: Fei Li Utilize the existed errp to propagate the error and do the corresponding cleanup to replace the temporary &error_abort. Cc: Markus Armbruster Cc: Gerd Hoffmann Signed-off-by: Fei Li --- hw/usb/ccid-card-emulated.c | 17 - 1 file changed, 12 insertions(+), 5 delet

[Qemu-devel] [PATCH v12 for-4.1 07/11] qemu_thread: supplement error handling for iothread_complete

2019-03-24 Thread Fei Li
From: Fei Li Utilize the existed errp to propagate the error and do the corresponding cleanup to replace the temporary &error_abort. Cc: Markus Armbruster Cc: Stefan Hajnoczi Cc: Eric Blake Signed-off-by: Fei Li Reviewed-by: Markus Armbruster --- iothread.c | 18 -- 1 file

[Qemu-devel] [PATCH v12 for-4.1 03/11] qemu_thread: supplement error handling for qmp_dump_guest_memory

2019-03-24 Thread Fei Li
From: Fei Li Utilize the existed errp to propagate the error instead of the temporary &error_abort. Cc: Markus Armbruster Cc: Marc-André Lureau Signed-off-by: Fei Li Reviewed-by: Markus Armbruster --- dump.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dump.c b/dump

[Qemu-devel] [PATCH v12 for-4.1 01/11] qemu_thread: make qemu_thread_create() take Error ** argument

2019-03-24 Thread Fei Li
From: Fei Li qemu_thread_create() abort()s on error. Not nice. Give it a return value and an Error ** argument, so it can return success/failure. Considering qemu_thread_create() is quite widely used in qemu, split this into two steps: this patch passes the &error_abort to qemu_thread_create() e

[Qemu-devel] [PATCH v12 for-4.1 05/11] qemu_thread: supplement error handling for h_resize_hpt_prepare

2019-03-24 Thread Fei Li
From: Fei Li Add a local_err to hold the error, and return the corresponding error code to replace the temporary &error_abort. Cc: Markus Armbruster Cc: David Gibson Signed-off-by: Fei Li Acked-by: David Gibson Reviewed-by: Markus Armbruster --- hw/ppc/spapr_hcall.c | 12 1 fi

[Qemu-devel] [PATCH v12 for-4.1 02/11] qemu_thread: supplement error handling for qemu_X_start_vcpu

2019-03-24 Thread Fei Li
From: Fei Li The callers of qemu_init_vcpu() already passed the **errp to handle errors. In view of this, add a new Error parameter to qemu_init_vcpu() and all qemu_X_start_vcpu() functions called by qemu_init_vcpu() to propagate the error and let the further callers check it. Besides, make qemu

Re: [Qemu-devel] [PATCH v12 for-4.1 00/11] qemu_thread_create: propagate the error to callers to handle

2019-03-24 Thread Fei Li
Please ignore this incomplete patch series, it seems there's something wrong with my email client.. :( Sorry for this! 在 2019/3/25 上午12:51, Fei Li 写道: Hi, This idea comes from BiteSizedTasks, and this patch series implement the error checking of qemu_thread_create: make qemu_thread_create retu

Re: [Qemu-devel] [PULL 02/29] ppc/spapr: Receive and store device tree blob from SLOF

2019-03-24 Thread Brad Smith
I filed a bug report for libfdt.. https://github.com/dgibson/dtc/issues/27 On 3/24/2019 12:03 AM, Brad Smith wrote: Now that I am checking out 4.0.0 rc's I see this diff is broken and depends on a function libfdt does not expose. The breakage is hidden by the fallback check in the configure scr

[Qemu-devel] [PATCH v12 for-4.1 00/11] qemu_thread_create: propagate the error to callers to handle

2019-03-24 Thread Fei Li
Hi, This idea comes from BiteSizedTasks, and this patch series implement the error checking of qemu_thread_create: make qemu_thread_create return a flag to indicate if it succeeded rather than failing with an error; make all callers check it. The first patch modifies the qemu_thread_create() by p

[Qemu-devel] [PATCH v12 for-4.1 08/11] qemu_thread: supplement error handling for qemu_signalfd_compat

2019-03-24 Thread Fei Li
From: Fei Li Set errno, do some cleanup, and return -1 to replace the temporary &error_abort when failing to create sigwait_compat. Cc: Markus Armbruster Cc: Eric Blake Signed-off-by: Fei Li Reviewed-by: Markus Armbruster --- util/compatfd.c | 13 ++--- 1 file changed, 10 insertions

[Qemu-devel] [PATCH v12 for-4.1 03/11] qemu_thread: supplement error handling for qmp_dump_guest_memory

2019-03-24 Thread Fei Li
From: Fei Li Utilize the existed errp to propagate the error instead of the temporary &error_abort. Cc: Markus Armbruster Cc: Marc-André Lureau Signed-off-by: Fei Li Reviewed-by: Markus Armbruster --- dump.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dump.c b/dump

[Qemu-devel] [PATCH v12 for-4.1 01/11] qemu_thread: make qemu_thread_create() take Error ** argument

2019-03-24 Thread Fei Li
From: Fei Li qemu_thread_create() abort()s on error. Not nice. Give it a return value and an Error ** argument, so it can return success/failure. Considering qemu_thread_create() is quite widely used in qemu, split this into two steps: this patch passes the &error_abort to qemu_thread_create() e

[Qemu-devel] [PATCH v12 for-4.1 07/11] qemu_thread: supplement error handling for iothread_complete

2019-03-24 Thread Fei Li
From: Fei Li Utilize the existed errp to propagate the error and do the corresponding cleanup to replace the temporary &error_abort. Cc: Markus Armbruster Cc: Stefan Hajnoczi Cc: Eric Blake Signed-off-by: Fei Li Reviewed-by: Markus Armbruster --- iothread.c | 18 -- 1 file

[Qemu-devel] [PATCH v12 for-4.1 05/11] qemu_thread: supplement error handling for h_resize_hpt_prepare

2019-03-24 Thread Fei Li
From: Fei Li Add a local_err to hold the error, and return the corresponding error code to replace the temporary &error_abort. Cc: Markus Armbruster Cc: David Gibson Signed-off-by: Fei Li Acked-by: David Gibson Reviewed-by: Markus Armbruster --- hw/ppc/spapr_hcall.c | 12 1 fi

[Qemu-devel] [PATCH v12 for-4.1 04/11] qemu_thread: supplement error handling for pci_edu_realize

2019-03-24 Thread Fei Li
From: Fei Li Utilize the existed errp to propagate the error and do the corresponding cleanup to replace the temporary &error_abort. Cc: Markus Armbruster Cc: Jiri Slaby Signed-off-by: Fei Li Reviewed-by: Markus Armbruster --- hw/misc/edu.c | 11 --- 1 file changed, 8 insertions(+),

[Qemu-devel] [PATCH v12 for-4.1 06/11] qemu_thread: supplement error handling for emulated_realize

2019-03-24 Thread Fei Li
From: Fei Li Utilize the existed errp to propagate the error and do the corresponding cleanup to replace the temporary &error_abort. Cc: Markus Armbruster Cc: Gerd Hoffmann Cc: Christophe Fergeau Cc: Marc-André Lureau Signed-off-by: Fei Li --- hw/usb/ccid-card-emulated.c | 17 -

[Qemu-devel] [PATCH v12 for-4.1 11/11] qemu_thread: supplement error handling for touch_all_pages

2019-03-24 Thread Fei Li
From: Fei Li Supplement the error handling for touch_all_pages: add an Error parameter for it to propagate the error to its caller to do the handling in case it fails. Cc: Markus Armbruster Signed-off-by: Fei Li --- util/oslib-posix.c | 35 ++- 1 file changed,

[Qemu-devel] [PATCH v12 for-4.1 02/11] qemu_thread: supplement error handling for qemu_X_start_vcpu

2019-03-24 Thread Fei Li
From: Fei Li The callers of qemu_init_vcpu() already passed the **errp to handle errors. In view of this, add a new Error parameter to qemu_init_vcpu() and all qemu_X_start_vcpu() functions called by qemu_init_vcpu() to propagate the error and let the further callers check it. Besides, make qemu

[Qemu-devel] [PATCH v12 for-4.1 10/11] qemu_thread: supplement error handling for vnc_start_worker_thread

2019-03-24 Thread Fei Li
From: Fei Li Supplement the error handling for vnc_thread_worker_thread: add an Error parameter for it to propagate the error to its caller to handle in case it fails, and make it return a Boolean to indicate whether it succeeds. Cc: Markus Armbruster Cc: Gerd Hoffmann Signed-off-by: Fei Li R

[Qemu-devel] [PATCH v12 for-4.1 11/11] qemu_thread: supplement error handling for touch_all_pages

2019-03-24 Thread Fei Li
From: Fei Li Supplement the error handling for touch_all_pages: add an Error parameter for it to propagate the error to its caller to do the handling in case it fails. Cc: Markus Armbruster Signed-off-by: Fei Li --- util/oslib-posix.c | 35 ++- 1 file changed,

[Qemu-devel] [Bug 1772165] Re: arm raspi2/raspi3 emulation has no USB support

2019-03-24 Thread mcandre
Out of curiousity, does the raspi2 machine support a PCI bus? I am trying to boot Debian arm64 with qemu-system-aarch64, and am running into all manner of complaints from qemu about missing devices. Is there another machine like virt, but that offers support for boot devices? -- You received this

[Qemu-devel] [PATCH v12 for-4.1 09/11] qemu_thread: supplement error handling for migration

2019-03-24 Thread Fei Li
From: Fei Li Update qemu_thread_create()'s callers by - setting an error on qemu_thread_create() failure for callers that set an error on failure; - reporting the error and returning failure for callers that return an error code on failure; - reporting the error and setting some state for cal

Re: [Qemu-devel] [PATCH 1/2] iotests: 030 TestParallelOps non-shared base node

2019-03-24 Thread Alberto Garcia
On Fri 22 Mar 2019 04:54:59 PM CET, Alberto Garcia wrote: >E <- D <- C <- B <- A > > 2) commit from C to E, then stream from C to A > >This fails because the commit job inserts a filter between C and B >and the bdrv_freeze_backing_chain(bs, base) call in stream_start() >fails. > >

[Qemu-devel] [PATCH] Categorize devices

2019-03-24 Thread Ernest Esene
Categorize devices in "uncategorised devices" section This patch is based on BiteSizedTask. Signed-off-by: Ernest Esene --- hw/dma/i82374.c | 2 ++ hw/i386/amd_iommu.c | 2 ++ hw/i386/intel_iommu.c | 2 ++ hw/i386/pc_piix.c | 1 + hw/ipmi/ipmi_bmc_extern.c | 2 ++ hw/

Re: [Qemu-devel] [PATCH V2 1/4] authz: fix usage of bool in listfile.c

2019-03-24 Thread Thomas Huth
On 23/03/2019 15.26, Jafar Abdi wrote: > Clean up wrong usage of FALSE and TRUE in places that use "bool" from > stdbool.h. > > FALSE and TRUE (with capital letters) are the constants defined by glib for > being used with the "gboolean" type of glib. But some parts of the code also > use > TRUE

Re: [Qemu-devel] [PATCH V2 2/4] tests/libqos: fix usage of bool in pci-pc.c

2019-03-24 Thread Thomas Huth
On 23/03/2019 15.26, Jafar Abdi wrote: > Clean up wrong usage of FALSE and TRUE in places that use "bool" from > stdbool.h. > > FALSE and TRUE (with capital letters) are the constants defined by glib for > being used with the "gboolean" type of glib. But some parts of the code also > use > TRUE

Re: [Qemu-devel] [PATCH V2 3/4] tests/libqos: fix usage of bool in pci-spapr.c

2019-03-24 Thread Thomas Huth
On 23/03/2019 15.26, Jafar Abdi wrote: > Clean up wrong usage of FALSE and TRUE in places that use "bool" from > stdbool.h. > > FALSE and TRUE (with capital letters) are the constants defined by glib for > being used with the "gboolean" type of glib. But some parts of the code also > use > TRUE

Re: [Qemu-devel] [PATCH V2 4/4] hw/tpm: fix usage of bool in tpm-tis.c

2019-03-24 Thread Thomas Huth
On 23/03/2019 15.26, Jafar Abdi wrote: > Clean up wrong usage of FALSE and TRUE in places that use "bool" from > stdbool.h. > > FALSE and TRUE (with capital letters) are the constants defined by glib for > being used with the "gboolean" type of glib. But some parts of the code also > use > TRUE

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-24 Thread Stafford Horne
On Thu, Mar 14, 2019 at 05:55:26AM +0900, Stafford Horne wrote: > On Tue, Mar 12, 2019 at 06:36:05PM +0100, Markus Armbruster wrote: > > = hw/openrisc/openrisc_sim.c = > > Jia Liu (maintainer:or1k-sim) > > Stafford Horne (odd fixer:OpenRISC) > > For OpenRISC the main test I do is boo

Re: [Qemu-devel] [PATCH V2 1/4] authz: fix usage of bool in listfile.c

2019-03-24 Thread Philippe Mathieu-Daudé
Le sam. 23 mars 2019 15:27, Jafar Abdi a écrit : > Clean up wrong usage of FALSE and TRUE in places that use "bool" from > stdbool.h. > > FALSE and TRUE (with capital letters) are the constants defined by glib for > being used with the "gboolean" type of glib. But some parts of the code > also us

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-4.0 0/3] target/ppc: Fix pseries.cap-ibs=workaround with TCG

2019-03-24 Thread Suraj Jitindar Singh
On Fri, 2019-03-22 at 19:03 +0100, Greg Kurz wrote: > Since recent commit 2782ad4c4102 "target/ppc/spapr: Enable > mitigations by > default for pseries-4.0 machine type", some recent distros, eg. > fedora29, > fail to boot under TCG because of a kernel panic: Good catch! I noticed this as well but

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-4.0 2/3] target/ppc: Enable "decrement and test CTR" version of bcctr

2019-03-24 Thread Suraj Jitindar Singh
On Fri, 2019-03-22 at 19:03 +0100, Greg Kurz wrote: > Even if all ISAs up to v3 indeed mention: > > If the "decrement and test CTR" option is specified (BO2=0), the > instruction form is invalid. > > The UMs of all existing 64-bit server class processors say: > > If BO[2] = 0, the co

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-4.0 1/3] target/ppc: Fix TCG temporary leaks in gen_bcond()

2019-03-24 Thread Suraj Jitindar Singh
On Fri, 2019-03-22 at 19:03 +0100, Greg Kurz wrote: > Signed-off-by: Greg Kurz Tested-by: Suraj Jitindar Singh > --- > target/ppc/translate.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target/ppc/translate.c b/target/ppc/translate.c > index 98b37cebc2f5..aaafa3a715d8 100644

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-4.0 3/3] target/ppc: Consolidate 64-bit server processor detection in a helper

2019-03-24 Thread Suraj Jitindar Singh
On Fri, 2019-03-22 at 19:03 +0100, Greg Kurz wrote: > We use PPC_SEGMENT_64B in various places to guard code that is > specific > to 64-bit server processors compliant with arch 2.x. Consolidate the > logic in a helper macro with an explicit name. Tested-by: Suraj Jitindar Singh > > Signed-off-

Re: [Qemu-devel] [PATCH] docker: trivial changes to `make docker` help

2019-03-24 Thread Fam Zheng
> On Mar 22, 2019, at 05:25, Wainer dos Santos Moschetta > wrote: > > Apply double quotes and period punctuation uniformly. > > Signed-off-by: Wainer dos Santos Moschetta > --- > tests/docker/Makefile.include | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tes

Re: [Qemu-devel] [PATCH v12 for-4.1 00/11] qemu_thread_create: propagate the error to callers to handle

2019-03-24 Thread Fei Li
Emm, the order seems a mess.. I will resend this patch series later as v13. So sorry for the trouble! Have a nice day Fei 在 2019/3/25 上午1:21, Fei Li 写道: Hi, This idea comes from BiteSizedTasks, and this patch series implement the error checking of qemu_thread_create: make qemu_thread_create

Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-03-24 Thread Peter Xu
On Fri, Mar 22, 2019 at 10:12:11AM +, Dr. David Alan Gilbert wrote: [...] > > In general, when we reset the system, we want to bring it > > back to exactly the state that it was in when QEMU was > > first started. That means we need to reload all the rom blob > > data into memory (because the

[Qemu-devel] [PATCH V2 RFT] vhost_net: don't set backend for the uninitialized virtqueue

2019-03-24 Thread Jason Wang
We used to set backend unconditionally, this won't work for some guests (e.g windows driver) who may not initialize all virtqueues. For kernel backend, this will fail since it may try to validate the rings during setting backend. Fixing this by simply skipping the backend set when we find desc is

Re: [Qemu-devel] [RFT 0/4] Don't start virtqueues that are not enabled for vhost

2019-03-24 Thread Jason Wang
On 2019/3/24 下午6:53, Yuri Benditovich wrote: Hi Jason, This series does not do the job. Test case: tap, 4 queues, 2 CPU (so only 2 queues are enabled) For Q0 and Q1 vhost_net_start_one succeeds, For Q2: vhost_net_start_one calls vhost_dev_start (the call succeeds, does not start queue that is

Re: [Qemu-devel] [PATCH V2 3/4] tests/libqos: fix usage of bool in pci-spapr.c

2019-03-24 Thread David Gibson
On Sat, Mar 23, 2019 at 05:26:36PM +0300, Jafar Abdi wrote: > Clean up wrong usage of FALSE and TRUE in places that use "bool" from > stdbool.h. > > FALSE and TRUE (with capital letters) are the constants defined by glib for > being used with the "gboolean" type of glib. But some parts of the cod

Re: [Qemu-devel] [PATCH] device_tree: check device tree blob file size

2019-03-24 Thread David Gibson
On Fri, Mar 22, 2019 at 10:30:51AM +, Peter Maydell wrote: > On Fri, 22 Mar 2019 at 10:11, P J P wrote: > > > > +-- On Fri, 22 Mar 2019, Peter Maydell wrote --+ > > | This document is specific to aarch64, but the part of > > | QEMU's device tree code being modified here is > > | architecture i

Re: [Qemu-devel] [PATCH] device_tree: check device tree blob file size

2019-03-24 Thread David Gibson
On Fri, Mar 22, 2019 at 09:14:53AM +, Peter Maydell wrote: > On Fri, 22 Mar 2019 at 07:38, P J P wrote: > > > > From: Prasad J Pandit > > > > Device tree blob(dtb) file can not be larger than 2MB in size.[*] > > Add check to avoid loading large dtb files in load_device_tree(), > > and potenti

Re: [Qemu-devel] [PATCH v12 for-4.1 02/11] qemu_thread: supplement error handling for qemu_X_start_vcpu

2019-03-24 Thread David Gibson
On Mon, Mar 25, 2019 at 12:51:57AM +0800, Fei Li wrote: > From: Fei Li > > The callers of qemu_init_vcpu() already passed the **errp to handle > errors. In view of this, add a new Error parameter to qemu_init_vcpu() > and all qemu_X_start_vcpu() functions called by qemu_init_vcpu() to > propagate

Re: [Qemu-devel] [PULL 02/29] ppc/spapr: Receive and store device tree blob from SLOF

2019-03-24 Thread David Gibson
On Sun, Mar 24, 2019 at 12:03:54AM -0400, Brad Smith wrote: > Now that I am checking out 4.0.0 rc's I see this diff is broken and > depends on a function libfdt does not expose. The breakage is > hidden by the fallback check in the configure script. Ah, bother. That keeps happening, unfortunately

Re: [Qemu-devel] [PATCH for-4.0 1/3] target/ppc: Fix TCG temporary leaks in gen_bcond()

2019-03-24 Thread David Gibson
On Fri, Mar 22, 2019 at 07:03:40PM +0100, Greg Kurz wrote: > Signed-off-by: Greg Kurz Applied to ppc-for-4.0. > --- > target/ppc/translate.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target/ppc/translate.c b/target/ppc/translate.c > index 98b37cebc2f5..aaafa3a715d8 100644 >

Re: [Qemu-devel] [RFC for-4.1 00/25] Many style fixes for target/ppc

2019-03-24 Thread David Gibson
On Fri, Mar 22, 2019 at 07:55:57AM +0100, Markus Armbruster wrote: > David Gibson writes: > > > target/ppc has a lot of old code that doesn't stick to the modern > > style guidelines. That means we keep getting checkpatch warnings from > > code motions in there, or from people copying the local

Re: [Qemu-devel] [PATCH V2 3/4] tests/libqos: fix usage of bool in pci-spapr.c

2019-03-24 Thread David Gibson
On Sat, Mar 23, 2019 at 05:26:36PM +0300, Jafar Abdi wrote: > Clean up wrong usage of FALSE and TRUE in places that use "bool" from > stdbool.h. > > FALSE and TRUE (with capital letters) are the constants defined by glib for > being used with the "gboolean" type of glib. But some parts of the cod

Re: [Qemu-devel] [PATCH] e1000: Delay flush queue when receive RCTL

2019-03-24 Thread Jason Wang
On 2019/3/21 上午9:35, yuchenlin wrote: Ping? On 2019-03-13 14:56, yuchen...@synology.com wrote: From: yuchenlin Due to too early RCT0 interrput, win10x32 may hang on booting. This problem can be reproduced by doing power cycle on win10x32 guest. In our environment, we have 10 win10x32 and st

Re: [Qemu-devel] [PATCH v2 1/5] hw/isa/Kconfig: PIIX4 southbridge requires USB UHCI

2019-03-24 Thread Thomas Huth
On 16/03/2019 23.39, Philippe Mathieu-Daudé wrote: > This fixes when configuring with --without-default-devices: > > $ qemu-system-mips64 -M malta --nodefaults -bios /dev/null > qemu-system-mips64: Unknown device 'piix4-usb-uhci' for bus 'PCI' > Aborted (core dumped) > > (gdb) bt > #0

Re: [Qemu-devel] [PATCH v2 1/5] hw/isa/Kconfig: PIIX4 southbridge requires USB UHCI

2019-03-24 Thread Thomas Huth
On 25/03/2019 05.49, Thomas Huth wrote: > On 16/03/2019 23.39, Philippe Mathieu-Daudé wrote: >> This fixes when configuring with --without-default-devices: >> >> $ qemu-system-mips64 -M malta --nodefaults -bios /dev/null >> qemu-system-mips64: Unknown device 'piix4-usb-uhci' for bus 'PCI' >>

Re: [Qemu-devel] [PATCH for-4.0 0/3] target/ppc: Fix pseries.cap-ibs=workaround with TCG

2019-03-24 Thread David Gibson
On Fri, Mar 22, 2019 at 07:03:35PM +0100, Greg Kurz wrote: > Since recent commit 2782ad4c4102 "target/ppc/spapr: Enable mitigations by > default for pseries-4.0 machine type", some recent distros, eg. fedora29, > fail to boot under TCG because of a kernel panic: > > [0.614425] Oops: Exception

Re: [Qemu-devel] [PATCH v2 3/5] hw/isa/Kconfig: i82378 SuperIO requires PC speaker device

2019-03-24 Thread Thomas Huth
On 16/03/2019 23.39, Philippe Mathieu-Daudé wrote: > This fixes when configuring with --without-default-devices: > > $ qemu-system-ppc -M prep --nodefaults > qemu-system-ppc: Machine type 'prep' is deprecated: use 40p machine type > instead > qemu-system-ppc: Unknown device 'isa-pcspk' for

Re: [Qemu-devel] [PATCH v2 4/5] hw/mips/Kconfig: Fulong 2e board requires ati-vga display device

2019-03-24 Thread Thomas Huth
On 16/03/2019 23.39, Philippe Mathieu-Daudé wrote: > This fixes when configuring with --without-default-devices: > > $ qemu-system-mips64el -M fulong2e --nodefaults -bios /dev/null > qemu-system-mips64el: Unknown device 'ati-vga' for bus 'PCI' > Aborted (core dumped) > > (gdb) bt > #1

Re: [Qemu-devel] [PATCH v2 5/5] hw/sparc/Kconfig: SPARCstation machine requires the TCX display

2019-03-24 Thread Thomas Huth
On 16/03/2019 23.39, Philippe Mathieu-Daudé wrote: > This is the default display device used in sun4m_hw_init(): > > /* If no display specified, default to TCX */ > > This fixes when configuring with --without-default-devices: > > $ sparc-softmmu/qemu-system-sparc --nodefaults > qemu-sys

Re: [Qemu-devel] [PATCH] e1000: Delay flush queue when receive RCTL

2019-03-24 Thread yuchenlin via Qemu-devel
On 2019-03-25 12:26, Jason Wang wrote: On 2019/3/21 上午9:35, yuchenlin wrote: Ping? On 2019-03-13 14:56, yuchen...@synology.com wrote: From: yuchenlin Due to too early RCT0 interrput, win10x32 may hang on booting. This problem can be reproduced by doing power cycle on win10x32 guest. In our

[Qemu-devel] [PATCH v5] hw/acpi: extract acpi_add_rom_blob()

2019-03-24 Thread Wei Yang
arm and i386 has almost the same function acpi_add_rom_blob(), except giving different FWCfgCallback function. This patch moves acpi_add_rom_blob() to utils.c by passing FWCfgCallback to it. Signed-off-by: Wei Yang --- v5: * remove unnecessary header glib/gprintf.h * rearrange include heade

[Qemu-devel] [Bug 504368] Re: sdl window intermittently scales instead of resizing

2019-03-24 Thread Thomas Huth
Since support for SDL 1.2 has been removed from QEMU now, can you still reproduce this issue with the latest version of QEMU and SDL2 ? ** Changed in: qemu Status: Triaged => Incomplete ** Changed in: qemu-kvm (Ubuntu) Status: Triaged => Incomplete ** Bug watch removed: SourceForge

[Qemu-devel] [Bug 1313816] Re: qemu should close sound device when no more needs.

2019-03-24 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

[Qemu-devel] [Bug 1730101] Re: The guest is only starting after its SDL window gets focus

2019-03-24 Thread Thomas Huth
Which version of SDL have you been using here? SDL 1.2 or SDL 2.0? If you were using 1.2, could you please try with 2.0 instead? Support for 1.2 has been removed now. ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- deve

[Qemu-devel] [Bug 1617114] Re: Qemu 2.6.0 freezes with windows guests

2019-03-24 Thread Thomas Huth
Which version of SDL were you using here? SDL 1.2 or SDL 2.0? If you were using SDL 1.2, could you please try with SDL 2.0 instead? Support for 1.2 has been removed now... ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [Bug 1730099] Re: Sometimes, when not touching the SDL window, the guest freezes

2019-03-24 Thread Thomas Huth
Which version of SDL are you using? SDL 1.2 or SDL 2.0? If you were using 1.2, could you please try 2.0 instead? Support for SDL 1.2 has been removed now. ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [Qemu-devel] [RFC for-4.1 03/25] target/ppc: Style fixes for ppc-models.[ch]

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/cpu-models.c | 2 +- > target/ppc/cpu-models.h | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/target/ppc/cpu-models.c b/target/pp

Re: [Qemu-devel] [RFC for-4.1 04/25] target/ppc: Style fixes for cpu.[ch]

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/cpu.h | 239 ++- > 1 file changed, 130 insertions(+), 109 deletions(-) > > diff --git a/target/ppc/cpu.h b/target/p

Re: [Qemu-devel] [RFC for-4.1 05/25] target/ppc: Style fixes for int_helper.c

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/int_helper.c | 70 +++-- > 1 file changed, 39 insertions(+), 31 deletions(-) > > diff --git a/target/ppc/int_helper.c b/targ

Re: [Qemu-devel] [RFC for-4.1 08/25] target/ppc: Style fixes for excp_helper.c

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/excp_helper.c | 87 > 1 file changed, 53 insertions(+), 34 deletions(-) > > diff --git a/target/ppc/excp_helper.c b/ta

Re: [Qemu-devel] [RFC for-4.1 11/25] target/ppc: Style fixes for kvm_ppc.h and kvm.c

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/kvm.c | 178 +++ > target/ppc/kvm_ppc.h | 3 +- > 2 files changed, 115 insertions(+), 66 deletions(-) > > diff --g

Re: [Qemu-devel] [RFC for-4.1 09/25] target/ppc: Style fixes for gdbstub.c

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/gdbstub.c | 34 +++--- > 1 file changed, 19 insertions(+), 15 deletions(-) > > diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstu

Re: [Qemu-devel] [RFC for-4.1 06/25] target/ppc: Style fixes for fpu_helper.c

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/fpu_helper.c | 134 +--- > 1 file changed, 83 insertions(+), 51 deletions(-) > > diff --git a/target/ppc/fpu_helper.c b/targ

Re: [Qemu-devel] [RFC for-4.1 17/25] target/ppc: Style fixes for mmu-hash64.[ch]

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/mmu-hash64.c | 62 + > 1 file changed, 38 insertions(+), 24 deletions(-) > > diff --git a/target/ppc/mmu-hash64.c b/targ

Re: [Qemu-devel] [RFC for-4.1 07/25] target/ppc: Style fixes for dfp_helper.c

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/dfp_helper.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/target/ppc/dfp_helper.c b/target/ppc/dfp_helper.c > index

Re: [Qemu-devel] [RFC for-4.1 13/25] target/ppc: Style fixes for mem_helper.c

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/mem_helper.c | 33 +++-- > 1 file changed, 19 insertions(+), 14 deletions(-) > > diff --git a/target/ppc/mem_helper.c b/target/ppc/m

Re: [Qemu-devel] [RFC for-4.1 14/25] target/ppc: Style fixes for mfrom_table.inc.c & mfrom_table_gen.c

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/mfrom_table.inc.c | 3 +-- > target/ppc/mfrom_table_gen.c | 8 +--- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/target/ppc/mfrom_tab

Re: [Qemu-devel] [RFC for-4.1 18/25] target/ppc: Style fixes for mmu_helper.c

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/mmu_helper.c | 131 > 1 file changed, 80 insertions(+), 51 deletions(-) > > diff --git a/target/ppc/mmu_helper.c b/targ

Re: [Qemu-devel] [PATCH v7 6/6] migration: Block migration while handling machine check

2019-03-24 Thread David Gibson
On Fri, Mar 22, 2019 at 12:04:25PM +0530, Aravinda Prasad wrote: > Block VM migration requests until the machine check > error handling is complete as (i) these errors are > specific to the source hardware and is irrelevant on > the target hardware, (ii) these errors cause data > corruption and sho

Re: [Qemu-devel] [RFC for-4.1 15/25] target/ppc: Style fixes for misc_helper.c

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/misc_helper.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c > index c65d

Re: [Qemu-devel] [RFC for-4.1 10/25] target/ppc: Style fixes for helper_regs.h

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/helper_regs.h | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/target/ppc/helper_regs.h b/target/ppc/helper_regs.h > index a2

Re: [Qemu-devel] [PATCH v7 2/6] Wrapper function to wait on condition for the main loop mutex

2019-03-24 Thread David Gibson
On Fri, Mar 22, 2019 at 12:03:49PM +0530, Aravinda Prasad wrote: > Introduce a wrapper function to wait on condition for > the main loop mutex. This function atomically releases > the main loop mutex and causes the calling thread to > block on the condition. > > Signed-off-by: Aravinda Prasad I

Re: [Qemu-devel] [RFC for-4.1 19/25] target/ppc: Style fixes for monitor.c

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/monitor.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/target/ppc/monitor.c b/target/ppc/monitor.c > index 04deec8030.

Re: [Qemu-devel] [PATCH v7 4/6] target/ppc: Build rtas error log

2019-03-24 Thread David Gibson
On Fri, Mar 22, 2019 at 12:04:07PM +0530, Aravinda Prasad wrote: > This patch builds the rtas error log, copies it to the > rtas_addr and then invokes the guest registered machine > check handler. This commit message needs more context. When is this occurring, why do we need this? [I can answer

Re: [Qemu-devel] [RFC for-4.1 12/25] target/ppc: Style fixes for machine.c

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/machine.c | 106 +-- > 1 file changed, 63 insertions(+), 43 deletions(-) > > diff --git a/target/ppc/machine.c b/target

Re: [Qemu-devel] [PATCH v7 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-03-24 Thread David Gibson
On Fri, Mar 22, 2019 at 12:03:39PM +0530, Aravinda Prasad wrote: > This patch adds support in QEMU to handle "ibm,nmi-register" > and "ibm,nmi-interlock" RTAS calls. > > The machine check notification address is saved when the > OS issues "ibm,nmi-register" RTAS call. > > This patch also handles

Re: [Qemu-devel] [PATCH for-4.0 3/3] target/ppc: Consolidate 64-bit server processor detection in a helper

2019-03-24 Thread David Gibson
On Fri, Mar 22, 2019 at 07:03:51PM +0100, Greg Kurz wrote: > We use PPC_SEGMENT_64B in various places to guard code that is specific > to 64-bit server processors compliant with arch 2.x. Consolidate the > logic in a helper macro with an explicit name. > > Signed-off-by: Greg Kurz This mitigates

Re: [Qemu-devel] [RFC for-4.1 16/25] target/ppc: Style fixes for mmu-hash32.[ch]

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/mmu-hash32.c | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c > i

Re: [Qemu-devel] [RFC for-4.1 21/25] target/ppc: Style fixes for translate.c

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/translate.c | 507 + > 1 file changed, 315 insertions(+), 192 deletions(-) > > diff --git a/target/ppc/translate.c b/tar

Re: [Qemu-devel] [RFC for-4.1 20/25] target/ppc: Style fixes for translate_init.inc.c

2019-03-24 Thread Cédric Le Goater
On 3/22/19 1:15 AM, David Gibson wrote: > Signed-off-by: David Gibson There is a printf() we could change below. Anyhow, Reviewed-by: Cédric Le Goater Thanks, C. > --- > target/ppc/translate_init.inc.c | 240 +++- > 1 file changed, 146 insertions(+), 94 deletions

Re: [Qemu-devel] [PATCH v7 3/6] target/ppc: Handle NMI guest exit

2019-03-24 Thread David Gibson
On Fri, Mar 22, 2019 at 12:03:58PM +0530, Aravinda Prasad wrote: > Memory error such as bit flips that cannot be corrected > by hardware are passed on to the kernel for handling. > If the memory address in error belongs to guest then > the guest kernel is responsible for taking suitable action. > P

Re: [Qemu-devel] [PATCH v7 5/6] ppc: spapr: Enable FWNMI capability

2019-03-24 Thread David Gibson
On Fri, Mar 22, 2019 at 12:04:16PM +0530, Aravinda Prasad wrote: > Enable the KVM capability KVM_CAP_PPC_FWNMI so that > the KVM causes guest exit with NMI as exit reason > when it encounters a machine check exception on the > address belonging to a guest. Without this capability > enabled, KVM red

Re: [Qemu-devel] [PATCH for-4.0 2/3] target/ppc: Enable "decrement and test CTR" version of bcctr

2019-03-24 Thread David Gibson
On Fri, Mar 22, 2019 at 07:03:46PM +0100, Greg Kurz wrote: > Even if all ISAs up to v3 indeed mention: > > If the "decrement and test CTR" option is specified (BO2=0), the > instruction form is invalid. > > The UMs of all existing 64-bit server class processors say: I've applied this ser

  1   2   >