GDB remote protocol supports reverse debugging of the targets.
It includes 'reverse step' and 'reverse continue' operations.
The first one finds the previous step of the execution,
and the second one is intended to stop at the last breakpoint that
would happen when the program is executed normally.
Public bug reported:
Hi,
One of our OpenStack instances crashed. It seems there was some problem
related to SPICE. Attaching what we had in qemu log. Also sending our
versions:
Linux pre-node1 4.18.0-13-generic #14~18.04.1-Ubuntu SMP Thu Dec 6
14:09:52 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
QE
The reverse keymap code can't handle dead keys. So use the nodeadkeys
variant of the keyboard layout for the german and french maps.
Signed-off-by: Gerd Hoffmann
---
pc-bios/keymaps/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pc-bios/keymaps/Makefile b/pc-bi
Non-empty record/replay queue prevents saving and loading the VM state,
because it includes pending bottom halves and block coroutines.
But when the new VM state is loaded, we don't have to preserve the consistency
of the current state anymore. Therefore this patch just flushes the queue
allowing t
Signed-off-by: Chen Zhang mailto:tgfb...@me.com>>
---
ui/cocoa.m | 35 +++
1 file changed, 27 insertions(+), 8 deletions(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index 5d0a6599d9..8e74f6e283 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -410,11 +410,31 @@ QemuCocoaView
From: Jim Wilson
The gdb CSR xml file has registers in documentation order, not numerical
order, so we need a table to map the register numbers. This also adds
fairly standard gdb hooks to access xml specified registers.
notice:
The fpu xml from gdb 8.3 has unused register #, 65 and make fi
On Wed, Mar 13, 2019 at 01:40:40PM +0100, Paolo Bonzini wrote:
> +static void tcg_out_endbr(TCGContext *s)
> +{
> +#if defined __CET__ && (__CET__ & 1)
Please include a comment explaining why __CET__ & 1 is necessary. Is
bit 0 of __CET__ the Indirect Branch Tracking feature flag?
signature.asc
On 14/03/19 23:19, Philippe Mathieu-Daudé wrote:
>> config PCI_DEVICES
>> bool
>> +
>> +config MSI
> Can we use PCI_MSI?
>
No, because it is a property of the interrupt controller, not of the PCI
host bridge.
Paolo
From: Pavel Dovgalyuk
This patch disables setting '-snapshot' option on by default
in record/replay mode. This is needed for creating vmstates in record
and replay modes.
Signed-off-by: Pavel Dovgalyuk
Acked-by: Kevin Wolf
---
vl.c | 10 --
1 file changed, 8 insertions(+), 2 deletio
On Wed, Mar 13, 2019 at 01:40:36PM +0100, Paolo Bonzini wrote:
> Split the jmpbuf access to a separate module and dispatch based
> on which CoroutineXYZ type is defined.
>
> Signed-off-by: Paolo Bonzini
> ---
> scripts/qemugdb/coroutine.py | 106 --
> scripts/qem
On Thu, Mar 14, 2019 at 08:04:00PM +0100, Markus Armbruster wrote:
> Kevin Wolf writes:
>
> > Am 13.03.2019 um 18:44 hat Markus Armbruster geschrieben:
> >> Patch created mechanically by rerunning:
> >>
> >> $ spatch --sp-file scripts/coccinelle/qobject.cocci \
> >> --macro-file
There are various actions in this test that must be executed
sequentially, as the result of it depends on the state triggered by the
previous one.
If the last argument of _send_qemu_cmd() is an empty string, it just
sends the QMP commands without waiting for an answer. While unlikely, it
may happe
On Fri, Mar 15, 2019 at 4:19 AM Palmer Dabbelt wrote:
> On Fri, 15 Mar 2019 02:06:07 PDT (-0700), Bastian Koppelmann wrote:
> > Hi Alistair
> >
> > On 3/14/19 9:28 PM, Alistair Francis wrote:
> >> On Wed, Mar 13, 2019 at 7:53 AM Palmer Dabbelt
> wrote:
> >>> From: Bastian Koppelmann
> >>>
> >>>
From: Jim Wilson
Signed-off-by: Jim Wilson
Signed-off-by: Chih-Min Chao
---
configure | 1 +
gdb-xml/riscv-32bit-fpu.xml | 6 +-
gdb-xml/riscv-64bit-cpu.xml | 47 +
gdb-xml/riscv-64bit-csr.xml | 250
gdb-xml/riscv-64bi
On Thu, Mar 14, 2019 at 07:15:10AM -0400, Stefan Berger wrote:
> On 3/14/19 5:59 AM, Daniel P. Berrangé wrote:
> > On Wed, Mar 13, 2019 at 03:43:13PM -0400, Stefan Berger wrote:
> > > Hello!
> > >
> > > If you have some feedback regarding a seccomp profile extension for
> > > swtpm
> > > for v0
Signed-off-by: Chen Zhang mailto:tgfb...@me.com>>
---
ui/cocoa.m | 29 +
1 file changed, 25 insertions(+), 4 deletions(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index 420b2411c1..5d0a6599d9 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -405,6 +405,24 @@ QemuCocoaView *coco
On Fri, 15 Mar 2019 at 11:08, Hongbo Zhang wrote:
>
> For the Aarch64, there is one machine 'virt', it is primarily meant to
> run on KVM and execute virtualization workloads, but we need an
> environment as faithful as possible to physical hardware, for supporting
> firmware and OS development fo
Am 15.03.2019 um 12:46 hat Sergio Lopez geschrieben:
> There are various actions in this test that must be executed
> sequentially, as the result of it depends on the state triggered by the
> previous one.
>
> If the last argument of _send_qemu_cmd() is an empty string, it just
> sends the QMP com
cchar_t can contain not only attr and chars fields, but also ext_color.
Initialize the whole structure to zero instead of enumerating fields.
Spotted by Coverity: CID 1399711
Signed-off-by: Samuel Thibault
---
ui/curses.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a
From: Amir Charif
These instructions do not trap when SVE is disabled in EL0,
causing them to be executed with wrong size information.
Signed-off-by: Amir Charif
Message-id: 1552579248-31025-1-git-send-email-amir.cha...@cea.fr
Reviewed-by: Richard Henderson
Reviewed-by: Peter Maydell
[PMM: ad
during the refactor to decodetree we removed the manual decoding that is
necessary for c.jal/c.addiw and removed the translation of c.flw/c.ld
and c.fsw/c.sd. This reintroduces the manual parsing and the
omited implementation.
Signed-off-by: Bastian Koppelmann
---
target/riscv/insn_trans/trans_r
From: Wei Yang
This is more proper to use PCIE_MMCFG_BUS to retrieve end_bus_number.
Signed-off-by: Wei Yang
Reviewed-by: Eric Auger
Reviewed-by: Igor Mammedov
Message-id: 20190312074953.16671-1-richardw.y...@linux.intel.com
Signed-off-by: Peter Maydell
---
hw/arm/virt-acpi-build.c | 4 ++--
Am 14.03.2019 um 18:27 hat Peter Maydell geschrieben:
> On Tue, 12 Mar 2019 at 17:30, Kevin Wolf wrote:
> >
> > In order to be able to dynamically reopen the file read-only or
> > read-write, depending on the users that are attached, we need to be able
> > to switch to a different file descriptor
Peter Maydell writes:
> On Fri, 15 Mar 2019 at 09:05, Alex Bennée wrote:
>>
>>
>> Peter Maydell writes:
>> > [+] I currently test:
>> > - windows crossbuilds
>>
>> We did have this with shippable but had to disable it when the upstream
>> repo went down. We could re-enable if we can rebuild
Concurrent IO becomes serial IO because of the qemu Coroutine lock,
which reduce IO performance severely.
So unlock Coroutine lock before bdrv_co_pwritev and
bdrv_co_preadv to fix it.
Signed-off-by: Zhengui li
---
block/vpc.c | 4
1 file changed, 4 insertions(+)
diff --git a/block/vpc.c b
Eric Blake, le ven. 15 mars 2019 08:02:29 -0500, a ecrit:
> On 3/15/19 5:06 AM, Peter Maydell wrote:
> > On Fri, 15 Mar 2019 at 08:37, Samuel Thibault
> > wrote:
> >>
> >> cchar_t can contain not only attr and chars fields, but also ext_color.
> >> Initialize the whole structure to zero instead of
On Fri, 2019-03-15 at 10:19 +0100, Paolo Bonzini wrote:
[...]
> +s390x:
> + enabled: false
> + requirements: ppcle
This doesn't look right :)
--
Andrea Bolognani / Red Hat / Virtualization
> On Mar 15, 2019, at 17:58, Alex Bennée wrote:
>
>
> Fam Zheng writes:
>
>>> On Mar 15, 2019, at 16:57, Alex Bennée wrote:
>>>
>>> I had installed the gitlab-runner from the Debian repo but it was out
>>> of date and didn't seem to work correctly.
>>
>> If there can be a sidecar x86 box
Gerd Hoffmann (2):
keymaps: use nodeadkeys variant for de and fr
keymaps: regenerate keymaps
pc-bios/keymaps/Makefile | 4 +--
pc-bios/keymaps/ar | 53
pc-bios/keymaps/bepo | 10 ++--
pc-bios/keymaps/cz | 10 ++--
pc-bios/ke
Peter Maydell, le ven. 15 mars 2019 10:06:48 +, a ecrit:
> > +curses_line[x] = (cchar_t) {};
> > curses_line[x].chars[0] = ch;
> > -curses_line[x].chars[1] = 0;
> > -curses_line[x].attr = 0;
> > }
> > cur
Coverity doesn't like that the return value of bdrv_check_update_perm()
stays unused only in this place (CID 1399710).
Even if checking local_err should be equivalent to checking ret < 0,
let's switch to using the return value to be more consistent (and in
case of a bug somewhere down the call cha
Am 14.03.2019 um 18:06 hat Peter Maydell geschrieben:
> On Fri, 6 Oct 2017 at 17:20, Kevin Wolf wrote:
> >
> > This changes the commit block job to support operation in a graph where
> > there is more than a single active layer that references the top node.
> >
> > This involves inserting the comm
On Thu, 21 Feb 2019 at 14:20, Auger Eric wrote:
> This commit introduces a regression when running with EDK2 FW:
I believe I've now tracked down what was going wrong here.
The problem was with the guest CPU reset path -- in
kvm_arm_reset_vcpu() we copy the kernel's reset state
into the cpreg_inde
On 13/03/2019 - 13:22:13, Marc-André Lureau wrote:
> Hi
>
> On Wed, Mar 13, 2019 at 10:49 AM Daniel P. Berrangé
> wrote:
> >
> > The Mesa library tries to set process affinity on some of its threads in
> > order to optimize its performance. Currently this results in QEMU being
> > immediately te
ommit 7074ab12c81a1b2b1e0e1c40983f56b2c5ccc494:
Merge remote-tracking branch
'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-03-14
16:19:37 +)
are available in the Git repository at:
https://git.linaro.org/people/pmaydell/qemu-arm.git
tags/pull-target-arm-20190315
for you to fetc
From: Dongjiu Geng
Some generic arch timer registers are Config-RW in the EL0,
which means the EL0 exception level can have write permission
if it is appropriately configured.
When VM access registers, QEMU firstly checks whether they have RW
permission, then check whether it is appropriately co
On Fri, 15 Mar 2019 at 10:52, Samuel Thibault wrote:
>
> Peter Maydell, le ven. 15 mars 2019 10:06:48 +, a ecrit:
> > > +curses_line[x] = (cchar_t) {};
> > > curses_line[x].chars[0] = ch;
> > > -curses_line[x].chars[1] = 0;
> > > -
This adds DDC support to ati-vga and connects i2c-ddc to provide EDID
info that is read by guests to find available screen modes. Not sure
if this is 100% correct yet but at least MorphOS is happy with it and
starts in a high resolution mode instead of 640x480 (although its
splash screen is still n
From: Jim Wilson
Signed-off-by: Jim Wilson
Signed-off-by: Chih-Min Chao
---
configure | 1 +
gdb-xml/riscv-32bit-cpu.xml | 47 +
gdb-xml/riscv-32bit-csr.xml | 250
gdb-xml/riscv-32bit-fpu.xml | 50 +
4 files cha
On Thu, Mar 14, 2019 at 08:26:11PM -0700, Richard Henderson wrote:
> Prefer it to direct use of /dev/urandom.
>
> Cc: Daniel P. Berrangé
> Signed-off-by: Richard Henderson
> ---
> v3: If getrandom is not present, fall back on /dev/(u)random.
> ---
> crypto/random-platform.c | 37 +++
From: Zoltán Baldaszti
The BCM2836 control logic module includes a simple
"local timer" which is a programmable down-counter that
can generates an interrupt. Implement this functionality.
Signed-off-by: Zoltán Baldaszti
[PMM: wrote commit message; wrapped long line; tweaked
some comments to ma
On Thu, Mar 14, 2019 at 08:26:16PM -0700, Richard Henderson wrote:
> When the -seed option is given, call qemu_guest_random_seed_main,
> putting the subsystem into deterministic mode. Pass derived seeds
> to each cpu created; which is a no-op unless the subsystem is in
> deterministic mode.
>
> C
From: Eric Auger
The GSIV numbers of the SPI based interrupts is not correct as
ARM_SPI_BASE was not added to the irqmap[VIRT_SMMU] value. So
this may collide with VIRTIO_MMIO irq window.
Signed-off-by: Eric Auger
Message-id: 20190312091031.5185-1-eric.au...@redhat.com
Reviewed-by: Shannon Zhao
On Fri, 15 Mar 2019 at 14:27, Kevin Wolf wrote:
>
> Coverity doesn't like that the return value of bdrv_check_update_perm()
> stays unused only in this place (CID 1399710).
>
> Even if checking local_err should be equivalent to checking ret < 0,
> let's switch to using the return value to be more
At the moment the Arm implementations of kvm_arch_{get,put}_registers()
don't support having QEMU change the values of system registers
(aka coprocessor registers for AArch32). This is because although
kvm_arch_get_registers() calls write_list_to_cpustate() to
update the CPU state struct fields (so
On Thu, Mar 14, 2019 at 08:26:14PM -0700, Richard Henderson wrote:
> Use a better interface for random numbers than rand().
> Fail gracefully if for some reason we cannot use the crypto system.
>
> Cc: Gerd Hoffmann
> Signed-off-by: Richard Henderson
> ---
> v2: Use qcrypto_random_bytes, not qem
Also delete a few redundant #include.
Signed-off-by: Markus Armbruster
---
contrib/rdmacm-mux/main.c | 18 +-
contrib/rdmacm-mux/rdmacm-mux.h | 6 +++---
hw/rdma/rdma_utils.h| 1 -
target/i386/whp-dispatch.h | 2 +-
target/i386/whpx-all.c | 1 -
> On Mar 15, 2019, at 17:19, Paolo Bonzini wrote:
>
> Patchew cannot yet retrieve the configuration from the QEMU Git tree, but
> this is planned. In the meanwhile, let's start storing it as YAML
> so that the Patchew configuration (currently accessible only to
> administrators)
> is public
On 15/03/19 03:53, Fam Zheng wrote:
>> [+] I currently test:
>> - windows crossbuilds
>> - S390, AArch32, AArch64, PPC64 Linux
>> (SPARC currently disabled because of the migration-test flakiness)
>> - OSX
>> - FreeBSD, OpenBSD, NetBSD via the tests/vm setup
>> - various x86-64 configs: from-clea
Cleaned up with scripts/clean-header-guards.pl.
Signed-off-by: Markus Armbruster
---
hw/ide/ahci_internal.h | 2 +-
include/block/aio-wait.h| 2 +-
include/exec/translator.h | 2 +-
include/hw/arm/nrf51_soc.h | 1 -
include/hw/arm/smmu-common.h
This series takes a good swing at two annoyances:
* We sometimes use #include "..." even for system headers, and <...>
for our own headers. Makes spotting the system headers harder, and
can be confusing. PATCH 01 cleans this up.
* Our use of header guards is rather sloppy. Sloppiness there
On Fri, 15 Mar 2019, Gerd Hoffmann wrote:
On Thu, Mar 14, 2019 at 08:11:21PM +0100, BALATON Zoltan wrote:
On Thu, 14 Mar 2019, Gerd Hoffmann wrote:
gets radeonfb going for me, on top of your i2c patches.
---
@@ -512,15 +531,15 @@ static void ati_mm_write(void *opaque, hwaddr addr,
if (s
On Thu, Mar 14, 2019 at 08:26:06PM -0700, Richard Henderson wrote:
> Changes since v2:
> * Changes from review.
> - getrandom is not exclusive of /dev/urandom fallback.
> - vnc fails gracefully on crypto failure.
> - a great renaming.
> * Drop the "nonblock" argument, as it's not de
We commonly define the header guard symbol without an explicit value.
Normalize the exceptions.
Done with scripts/clean-header-guards.pl.
Signed-off-by: Markus Armbruster
---
hw/timer/m48t59-internal.h| 3 ++-
include/disas/capstone.h | 2 +-
include/hw/scsi/emulation.h | 2 +-
inclu
Leading underscores are ill-advised because such identifiers are
reserved. Trailing underscores are merely ugly. Strip both.
Our header guards commonly end in _H. Normalize the exceptions.
Done with scripts/clean-header-guards.pl.
Signed-off-by: Markus Armbruster
---
block/crypto.h
Anthony PERARD writes:
> On Thu, Mar 14, 2019 at 08:04:00PM +0100, Markus Armbruster wrote:
>> Kevin Wolf writes:
>>
>> > Am 13.03.2019 um 18:44 hat Markus Armbruster geschrieben:
>> >> Patch created mechanically by rerunning:
>> >>
>> >> $ spatch --sp-file scripts/coccinelle/qobject.cocci
Reuse of the same guard symbol in multiple headers is okay as long as
they cannot be included together. scripts/clean-header-guards.pl
can't tell, so it warns.
Since we can avoid guard symbol reuse easily, do so: use guard symbol
${target^^}_${fname^^} for linux-user/$target/$fname, just like we
The bitbang i2c implementation is also useful for other device models
such as DDC in display controllers. Because of this, part of the file had
to be moved to the main i2c.h to avoid a warning in commit 2b4c1125ac.
Move the rest of the hw/i2c/bitbang_i2c.h to the main i2c.h now to allow
it to be us
Header guard symbols should match their file name to make guard
collisions less likely.
Cleaned up with scripts/clean-header-guards.pl, followed by some
renaming of new guard symbols picked by the script to better ones.
Signed-off-by: Markus Armbruster
---
contrib/elf2dmp/qemu_elf.h
Version 2 of proposed DDC implementation for ati-vga. This now cleans
up the include from hw/i2c/bitbang_i2c.h by moving that to public
header and implement DVI DDC port for rv100 model which supposed to fix
loading the Linux radeonfb driver.
BALATON Zoltan (2):
i2c: Move contents of bitbang_i2c
On Fri 15 Mar 2019 12:18:43 PM CET, Kevin Wolf wrote:
> Coverity doesn't like that the return value of bdrv_check_update_perm()
> stays unused only in this place (CID 1399710).
>
> Even if checking local_err should be equivalent to checking ret < 0,
> let's switch to using the return value to be m
On Thu, Mar 14, 2019 at 08:26:13PM -0700, Richard Henderson wrote:
> There were 3 copies of this code, one of which used the wrong
> data size for the failure indicator.
>
> Cc: Gerd Hoffmann
> Signed-off-by: Richard Henderson
> ---
> ui/vnc.c | 37 +++--
> 1 fil
On Thu, Mar 14, 2019 at 08:26:15PM -0700, Richard Henderson wrote:
> This routine is intended to produce high-quality random numbers to the
> guest. Normally, such numbers are crypto quality from the host, but a
> command-line option can force the use of a fully deterministic sequence
> for use wh
Kevin Wolf writes:
> Coverity doesn't like that the return value of bdrv_check_update_perm()
> stays unused only in this place (CID 1399710).
>
> Even if checking local_err should be equivalent to checking ret < 0,
> let's switch to using the return value to be more consistent (and in
> case of a
On Thu, Mar 14, 2019 at 03:57:06PM +, Alex Bennée wrote:
> As we approach stabilisation for 4.0 I thought it would be worth doing a
> review of the current state of CI and stimulate some discussion of where
> it is working for us and what could be improved.
Thanks for this summary and for all
On 15/03/19 15:04, Zhengui li wrote:
> Concurrent IO becomes serial IO because of the qemu Coroutine lock,
> which reduce IO performance severely.
>
> So unlock Coroutine lock before bdrv_co_pwritev and
> bdrv_co_preadv to fix it.
>
> Signed-off-by: Zhengui li
> ---
> block/vpc.c | 4
> 1
Include the generated trace.h the same way as we do everywhere else.
Signed-off-by: Markus Armbruster
---
authz/base.c | 2 +-
authz/list.c | 2 +-
authz/listfile.c | 2 +-
authz/pamacct.c | 2 +-
authz/simple.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/au
scripts/clean-header-guards.pl warns these headers use reserved
identifier _XTENSA_CORE_CONFIGURATION_H as header guard symbol. It
additionally warns the guard doesn't match the file name.
Reuse of the same guard symbol in multiple headers is okay as long as
they cannot be included together.
Sin
On Thu, Mar 14, 2019 at 06:31:34PM +0100, Sergio Lopez wrote:
> Our current AIO path does a great job at unloading the work from the VM,
> and combined with IOThreads provides a good performance in most
> scenarios. But it also comes with its costs, in both a longer execution
> path and the need of
Am 15.03.2019 um 15:04 hat Zhengui li geschrieben:
> Concurrent IO becomes serial IO because of the qemu Coroutine lock,
> which reduce IO performance severely.
>
> So unlock Coroutine lock before bdrv_co_pwritev and
> bdrv_co_preadv to fix it.
>
> Signed-off-by: Zhengui li
Thanks, applied to t
Stefan Hajnoczi writes:
> On Thu, Mar 14, 2019 at 06:31:34PM +0100, Sergio Lopez wrote:
>> Our current AIO path does a great job at unloading the work from the VM,
>> and combined with IOThreads provides a good performance in most
>> scenarios. But it also comes with its costs, in both a longer
On Fri, Mar 15, 2019 at 03:51:17PM +0100, Markus Armbruster wrote:
> Include the generated trace.h the same way as we do everywhere else.
>
> Signed-off-by: Markus Armbruster
> ---
> authz/base.c | 2 +-
> authz/list.c | 2 +-
> authz/listfile.c | 2 +-
> authz/pamacct.c | 2 +-
> authz
Hi Daniel,
On 3/15/19 7:18 AM, Daniel P. Berrangé wrote:
> On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote:
>>
>> On 1/18/19 3:39 AM, Erik Skultety wrote:
>>> I proceeded with cloning [1] to systemd and creating an udev rule that I
>>> planned
>>> on submitting to systemd upstream
Peter Maydell writes:
> On Fri, 8 Mar 2019 at 19:39, Bandan Das wrote:
>>
>> Peter Maydell writes:
>> > But the two places in usb_mtp_get_data() that call
>> > usb_mtp_write_metadata() still don't check its return
>> > value: don't they need to handle failure too?
>> >
>> I believe this is ok b
On Fri, 15 Mar 2019 06:51:40 PDT (-0700), Bastian Koppelmann wrote:
during the refactor to decodetree we removed the manual decoding that is
necessary for c.jal/c.addiw and removed the translation of c.flw/c.ld
and c.fsw/c.sd. This reintroduces the manual parsing and the
omited implementation.
S
Am 15.03.2019 um 16:33 hat Sergio Lopez geschrieben:
>
> Stefan Hajnoczi writes:
>
> > On Thu, Mar 14, 2019 at 06:31:34PM +0100, Sergio Lopez wrote:
> >> Our current AIO path does a great job at unloading the work from the VM,
> >> and combined with IOThreads provides a good performance in most
>
On Fri, Mar 15, 2019 at 03:51:57PM +, Singh, Brijesh wrote:
> Hi Daniel,
>
>
> On 3/15/19 7:18 AM, Daniel P. Berrangé wrote:
> > On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote:
> >>
> >> On 1/18/19 3:39 AM, Erik Skultety wrote:
> >>> I proceeded with cloning [1] to systemd and
We have been trying to merge the Gitlab runner patches for arm64
for over a year now; see
https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/725
I have not yet sorted out who at Gitlab has the ability to get
this change implemented - their management structure is
not something that I have
On 3/15/19 3:51 PM, Markus Armbruster wrote:
> Include the generated trace.h the same way as we do everywhere else.
I suppose this ended this way as a leftover from when this series
started in 2015. And I missed it while reviewing.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mat
On 3/15/19 3:51 PM, Markus Armbruster wrote:
> Reuse of the same guard symbol in multiple headers is okay as long as
> they cannot be included together. scripts/clean-header-guards.pl
> can't tell, so it warns.
>
> Since we can avoid guard symbol reuse easily, do so: use guard symbol
> ${target^^
Daniel P. Berrangé writes:
> The watch IDs are mistakenly only unique within the scope of the
> directory being monitored. This is not useful for clients which are
> monitoring multiple directories. They require watch IDs to be unique
> globally within the QFileMonitor scope.
>
> Signed-off-by: D
On 3/15/19 2:09 PM, Samuel Thibault wrote:
> cchar_t can contain not only attr and chars fields, but also ext_color.
> Initialize the whole structure to zero instead of enumerating fields.
>
> Spotted by Coverity: CID 1399711
>
> Signed-off-by: Samuel Thibault
> ---
> ui/curses.c | 6 +++---
>
On Fri, Mar 15, 2019 at 03:25:55PM +0100, BALATON Zoltan wrote:
> The bitbang i2c implementation is also useful for other device models
> such as DDC in display controllers. Because of this, part of the file had
> to be moved to the main i2c.h to avoid a warning in commit 2b4c1125ac.
> Move the res
On Thu, Mar 14, 2019 at 07:09:26PM +0100, Markus Armbruster wrote:
> We spell out sub/dir/ in sub/dir/trace-events' comments pointing to
> source files. That's because when trace-events got split up, the
> comments were moved verbatim.
>
> Delete the sub/dir/ part from these comments. Gets rid o
Stefan Hajnoczi writes:
> On Thu, Mar 14, 2019 at 03:57:06PM +, Alex Bennée wrote:
>> As we approach stabilisation for 4.0 I thought it would be worth doing a
>> review of the current state of CI and stimulate some discussion of where
>> it is working for us and what could be improved.
>
>
On 3/15/19 3:51 PM, Markus Armbruster wrote:
> We commonly define the header guard symbol without an explicit value.
> Normalize the exceptions.
>
> Done with scripts/clean-header-guards.pl.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/timer/m48t59-inte
On Fri, 15 Mar 2019 at 15:12, Stefan Hajnoczi wrote:
> How should all sub-maintainers be checking their pull requests?
>
> We should have information and a strict policy on minimum testing of
> pull requests. Right now I imagine it varies a lot between
> sub-maintainers.
>
> For my block pull req
Pavel Hrdina writes:
> On Tue, Mar 12, 2019 at 08:12:40AM +0100, Gerd Hoffmann wrote:
>> From: Kővágó, Zoltán
>>
>> Audio drivers now get an Audiodev * as config paramters, instead of the
>> global audio_option structs. There is some code in audio/audio_legacy.c
>> that converts the old enviro
On 3/15/19 3:51 PM, Markus Armbruster wrote:
> Leading underscores are ill-advised because such identifiers are
> reserved. Trailing underscores are merely ugly. Strip both.
>
> Our header guards commonly end in _H. Normalize the exceptions.
>
> Done with scripts/clean-header-guards.pl.
>
> S
> From: Mateja Marjanovic
> Subject: [PATCH 1/2] target/mips: Optimize ILVOD. MSA instructions
>
> From: Mateja Marjanovic
>
> Optimize set of MSA instructions ILVOD, using directly
> tcg registers and performing logic on them insted of
> using helpers.
insted -> instead
> Performance measure
On 15/03/19 17:28, Peter Maydell wrote:
> On Fri, 15 Mar 2019 at 15:12, Stefan Hajnoczi wrote:
>> How should all sub-maintainers be checking their pull requests?
>>
>> We should have information and a strict policy on minimum testing of
>> pull requests. Right now I imagine it varies a lot betwee
On 3/15/19 5:02 AM, Mateja Marjanovic wrote:
> +static inline void gen_ilvev_b(CPUMIPSState *env, uint32_t wd,
> + uint32_t ws, uint32_t wt) {
> +TCGv_i64 t0 = tcg_temp_new_i64();
> +TCGv_i64 t1 = tcg_temp_new_i64();
> +
> +uint64_t mask = (1ULL << 8) - 1;
On 3/15/19 5:02 AM, Mateja Marjanovic wrote:
> From: Mateja Marjanovic
>
> Optimize set of MSA instructions ILVOD, using directly
> tcg registers and performing logic on them insted of
> using helpers.
> Performance measurement is done by executing the
> instructions large number of times on a co
On Fri, Mar 15, 2019 at 12:27:06PM -0400, Bandan Das wrote:
> Daniel P. Berrangé writes:
>
> > The watch IDs are mistakenly only unique within the scope of the
> > directory being monitored. This is not useful for clients which are
> > monitoring multiple directories. They require watch IDs to be
Hi Daniel,
On 3/15/19 12:28 PM, Daniel P. Berrangé wrote:
> On Thu, Mar 14, 2019 at 07:43:58PM +0100, Philippe Mathieu-Daudé wrote:
>> On 3/13/19 10:00 PM, Laszlo Ersek wrote:
>>> Add the files built by the last patch: (compressed) binaries, and the
>>> cumulative license text that covers them.
>>
Patchew URL:
https://patchew.org/QEMU/155265169782.20013.5884232667053404718.stgit@pasha-VirtualBox/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN
On 15/03/2019 09:17, Paul Durrant wrote:
>> -Original Message-
>> From: Jason Andryuk [mailto:jandr...@gmail.com]
>> Sent: 14 March 2019 18:16
>> To: Paul Durrant
>> Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org;
>> marma...@invisiblethingslab.com; Simon
>> Gaiser ; Stefano St
Stefan Hajnoczi writes:
> On Thu, Mar 14, 2019 at 07:09:26PM +0100, Markus Armbruster wrote:
>> We spell out sub/dir/ in sub/dir/trace-events' comments pointing to
>> source files. That's because when trace-events got split up, the
>> comments were moved verbatim.
>>
>> Delete the sub/dir/ part
Hi,
>From my previous experience with the tests/ patches, I understood we
could still send PR that improve testing after soft freeze.
This series doesn't modify the QEMU binaries, it add EDK2 firmware blobs
in roms/ and rules to rebuild these roms.
These roms are useful for the ACPI tests introduc
TYPE_QAUTHZ is an abstract object of type TYPE_OBJECT. All other
are children of TYPE_QAUTHZ, thus also objects.
Keep INTERFACE_CHECK() for interfaces, and use OBJECT_CHECK() on
objects.
Reported-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
include/authz/base.h | 4 ++--
101 - 200 of 251 matches
Mail list logo
