Re: [Qemu-devel] [PATCH v13 19/25] replay: add BH oneshot event for block layer

2019-03-15 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 21.02.2019 um 12:05 hat Pavel Dovgalyuk geschrieben: > > Replay is capable of recording normal BH events, but sometimes > > there are single use callbacks scheduled with aio_bh_schedule_oneshot > > function. This patch enables recording and replayin

Re: [Qemu-devel] [PATCH] ati-vga: i2c fix

2019-03-15 Thread Gerd Hoffmann
On Thu, Mar 14, 2019 at 08:11:21PM +0100, BALATON Zoltan wrote: > On Thu, 14 Mar 2019, Gerd Hoffmann wrote: > > gets radeonfb going for me, on top of your i2c patches. > > --- > > hw/display/ati_int.h | 1 + > > hw/display/ati_regs.h | 1 + > > hw/display/ati.c | 35 ++

Re: [Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored

2019-03-15 Thread Gerd Hoffmann
Hi, > -qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440); > +qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, > ppdo->buffer_length); I'd just use ppdo->has_buffer_length ? ppdo->buffer_length : dev->timer_period * 4 here. cheers, Gerd

[Qemu-devel] [Bug 1815889] Re: qemu-system-x86_64 crashed with signal 31 in __pthread_setaffinity_new()

2019-03-15 Thread Launchpad Bug Tracker
This bug was fixed in the package mesa - 19.0.0-1ubuntu1 --- mesa (19.0.0-1ubuntu1) disco; urgency=medium * Merge from Debian. (LP: #1818516) * revert-set-full-thread-affinity.diff: Fix qemu crash. (LP: #1815889) -- Timo Aaltonen Thu, 14 Mar 2019 18:48:18 +0200 ** Changed in:

Re: [Qemu-devel] [PATCH 2/3] make latency configurable

2019-03-15 Thread Gerd Hoffmann
Hi, > r = pa_stream_connect_playback (stream, dev, attr, > PA_STREAM_INTERPOLATE_TIMING > -#ifdef PA_STREAM_ADJUST_LATENCY > |PA_STREAM_ADJUST_LATENCY > -#endif Unrelated change, separate commit please.

Re: [Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored

2019-03-15 Thread Gerd Hoffmann
On Fri, Mar 15, 2019 at 08:49:06AM +0100, Martin Schrodt wrote: > Hi, > > On 3/15/19 8:43 AM, Gerd Hoffmann wrote: > > Hi, > > > >> -qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440); > >> +qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, > >> ppdo->buffer_l

Re: [Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored

2019-03-15 Thread Martin Schrodt
Hi, On 3/15/19 8:43 AM, Gerd Hoffmann wrote: > Hi, > >> -qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440); >> +qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, >> ppdo->buffer_length); > > I'd just use > > ppdo->has_buffer_length ? ppdo->buffer_leng

Re: [Qemu-devel] [PATCH v3 07/23] ui/vnc: Split out authentication_failure

2019-03-15 Thread Gerd Hoffmann
On Thu, Mar 14, 2019 at 08:26:13PM -0700, Richard Henderson wrote: > There were 3 copies of this code, one of which used the wrong > data size for the failure indicator. > > Cc: Gerd Hoffmann > Signed-off-by: Richard Henderson Reviewed-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH v3 08/23] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc

2019-03-15 Thread Gerd Hoffmann
On Thu, Mar 14, 2019 at 08:26:14PM -0700, Richard Henderson wrote: > Use a better interface for random numbers than rand(). > Fail gracefully if for some reason we cannot use the crypto system. > > Cc: Gerd Hoffmann > Signed-off-by: Richard Henderson > --- > v2: Use qcrypto_random_bytes, not qem

Re: [Qemu-devel] [PATCH 0/2] kconfig: add fine-grained dependencies for MSI

2019-03-15 Thread Andrea Bolognani
On Thu, 2019-03-14 at 15:30 +0100, Paolo Bonzini wrote: > RISC-V targets did not include PCIe ports before the Kconfig transition, > and grew them afterwards, but they are nonfunctional because the interrupt > controller does not support MSI. This patch restores the situation prior to > the introd

Re: [Qemu-devel] [PATCH v3 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash

2019-03-15 Thread Michal Privoznik
On 3/14/19 8:01 PM, Markus Armbruster wrote: Michal Privoznik writes: On 3/8/19 2:14 PM, Markus Armbruster wrote: The previous commit added a way to configure firmware with -blockdev rather than -drive if=pflash. Document it as the preferred way. Signed-off-by: Markus Armbruster --- doc

Re: [Qemu-devel] [PATCH 2/3] make latency configurable

2019-03-15 Thread Martin Schrodt
Hi, On 3/15/19 8:53 AM, Gerd Hoffmann wrote: > Hi, > >> r = pa_stream_connect_playback (stream, dev, attr, >> PA_STREAM_INTERPOLATE_TIMING >> -#ifdef PA_STREAM_ADJUST_LATENCY >> |PA_STREAM_ADJUST_LATENCY

Re: [Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored

2019-03-15 Thread Martin Schrodt
On 3/15/19 9:01 AM, Gerd Hoffmann wrote: > On Fri, Mar 15, 2019 at 08:49:06AM +0100, Martin Schrodt wrote: >> Hi, >> >> On 3/15/19 8:43 AM, Gerd Hoffmann wrote: >>> Hi, >>> -qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440); +qapi_AudiodevPaPerDirectionOptio

[Qemu-devel] [PATCH] curses ui: always initialize all curses_line fields

2019-03-15 Thread Samuel Thibault
cchar_t can contain not only attr and chars fields, but also ext_color. Initialize the whole structure to zero instead of enumerating fields. Spotted by Coverity: CID 1399711 Signed-off-by: Samuel Thibault --- ui/curses.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ui/

Re: [Qemu-devel] [PATCH v2 04/11] hw/arm/virt: Add virtual ACPI device

2019-03-15 Thread Igor Mammedov
On Thu, 14 Mar 2019 16:55:36 + Shameerali Kolothum Thodi wrote: > Hi Igor, > > > -Original Message- > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Sent: 12 March 2019 15:48 > > To: Shameerali Kolothum Thodi > > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > > eric.au...

[Qemu-devel] [PATCH V4 2/3] audio/paaudio: prolong and make latency configurable

2019-03-15 Thread Martin Schrodt
The latency of a connection to the PulseAudio server is determined by the tlength parameter. This was hardcoded to 10ms, which is a bit too tight on my machine, causing audio on host and guest to malfunction. A setting of 15ms works fine here. To allow tweaking, I also made the setting configurable

[Qemu-devel] [PATCH V4 0/3] Fixes for PulseAudio driver

2019-03-15 Thread Martin Schrodt
Version 2 of the series added proper commit messages and fixed a typo. Version 3 fixes coding style problems Version 4 reintroduces the check, whether PA support adjusting latency, and sets the default buffer_length to the constant value that was present beforehand (works well, and testing revea

[Qemu-devel] [PATCH V4 1/3] audio/paaudio: fix ignored buffer_length setting

2019-03-15 Thread Martin Schrodt
Audiodev configuration allows to set the length of the buffered data. The setting was ignored and a constant value used instead. This patch makes the code apply the setting properly, and uses the previous default if nothing is supplied. Signed-off-by: Martin Schrodt --- audio/paaudio.c | 24

[Qemu-devel] [PATCH V4 3/3] audio/paaudio: fix microphone input being unusable

2019-03-15 Thread Martin Schrodt
The current code does not specify the metrics of the buffers for the input device. This makes PulseAudio choose very bad defaults, which causes input to be unusable: Audio put in gets out 30 seconds later. This patch fixes that and makes the latency configurable as well. Signed-off-by: Martin Schr

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-15 Thread Alex Bennée
Peter Maydell writes: > On Thu, 14 Mar 2019 at 15:57, Alex Bennée wrote: >> Testing in the Cloud >> >> >> After BuildBot went out-of-service we have been relying heavily on Travis >> as our primary CI platform. This has been creaking somewhat under the >> strain and while

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-15 Thread Alex Bennée
Fam Zheng writes: >> On Mar 15, 2019, at 02:22, Peter Maydell wrote: >> >> On Thu, 14 Mar 2019 at 15:57, Alex Bennée wrote: >>> Testing in the Cloud >>> >>> >>> After BuildBot went out-of-service we have been relying heavily on Travis >>> as our primary CI platform. This

Re: [Qemu-devel] [RFC] arm/cpu: fix soft lockup panic after resuming from stop

2019-03-15 Thread Christoffer Dall
Hi Steve, On Wed, Mar 13, 2019 at 10:11:30AM +, Steven Price wrote: > > Personally I think what we need is: > > * Either a patch like the one from Heyi Guo (save/restore CNTVCT_EL0) or > alternatively hooking up KVM_KVMCLOCK_CTRL to prevent the watchdog > firing when user space explicitly st

[Qemu-devel] [PATCH] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-15 Thread Roger Pau Monne
Or if it's not possible to honor the hinted address an error is returned instead. This makes it easier to spot the actual failure, instead of failing later on when the caller of xen_remap_bucket realizes the mapping has not been created at the requested address. Also note that at least on FreeBSD

Re: [Qemu-devel] [Qemu-arm] [PATCH] Check access permission to ADDVL/ADDPL/RDVL

2019-03-15 Thread Amir CHARIF
Thanks Eric, happy to join ^^ -Message d'origine- De : Eric Blake Envoyé : jeudi 14 mars 2019 18:44 À : Richard Henderson ; Peter Maydell ; Amir CHARIF Cc : qemu-arm ; QEMU Developers Objet : Re: [Qemu-devel] [Qemu-arm] [PATCH] Check access permission to ADDVL/ADDPL/RDVL On 3/14/19

Re: [Qemu-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE

2019-03-15 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 14 March 2019 19:37 > To: Simon Gaiser ; Jason Andryuk > ; Paul Durrant > > Cc: Anthony Perard ; > xen-de...@lists.xenproject.org; Stefano Stabellini > ; qemu-devel@nongnu.org; > marma...@invisiblethingslab.com > Subject: Re: [PATCH 6/6

Re: [Qemu-devel] [PULL 17/29] target/riscv: Convert quadrant 1 of RVXC insns to decodetree

2019-03-15 Thread Bastian Koppelmann
Hi Alistair On 3/14/19 9:28 PM, Alistair Francis wrote: On Wed, Mar 13, 2019 at 7:53 AM Palmer Dabbelt wrote: From: Bastian Koppelmann Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt This commit is the first bad commit in breaking 32-bit boot.

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-15 Thread Alex Bennée
Daniel P. Berrangé writes: > On Thu, Mar 14, 2019 at 03:57:06PM +, Alex Bennée wrote: >> Docker Images >> = >> >> The addition of docker has unlocked the ability to build a lot more >> tests as well as compile testing on a much wider range of distros. I >> think there are two ou

[Qemu-devel] [PATCH 0/2] ui/cocoa: Fix absolute input device grabbing issue on Mojave

2019-03-15 Thread Chen Zhang via Qemu-devel
On Mojave, absolute input device, i.e. tablet, had trouble re-grabbing the cursor in re-entry into the virtual screen area. In some cases, the `window` property of NSEvent object is nil, after exit of cursor, meaning that the `-locationInWindow` method would return value in screen coordinates. T

[Qemu-devel] [PATCH 1/2] Fix absolute input device grabbing issues on Mojave

2019-03-15 Thread Chen Zhang via Qemu-devel
Signed-off-by: Chen Zhang --- ui/cocoa.m | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 420b2411c1..5d0a6599d9 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -405,6 +405,24 @@ QemuCocoaView *cocoaView; return (p

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-15 Thread Fam Zheng
> On Mar 15, 2019, at 16:57, Alex Bennée wrote: > > I had installed the gitlab-runner from the Debian repo but it was out > of date and didn't seem to work correctly. If there can be a sidecar x86 box next to the test bot, it can be the controller node which runs gitlab-runner, the test scri

[Qemu-devel] [PATCH 2/2] ui/cocoa: fix grabbing issue in fullscreen mode

2019-03-15 Thread Chen Zhang via Qemu-devel
Signed-off-by: Chen Zhang --- ui/cocoa.m | 35 +++ 1 file changed, 27 insertions(+), 8 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 5d0a6599d9..8e74f6e283 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -410,11 +410,31 @@ QemuCocoaView *cocoaView; { N

[Qemu-devel] [PATCH] ci: store Patchew configuration in the tree

2019-03-15 Thread Paolo Bonzini
Patchew cannot yet retrieve the configuration from the QEMU Git tree, but this is planned. In the meanwhile, let's start storing it as YAML so that the Patchew configuration (currently accessible only to administrators) is public and documented. Signed-off-by: Paolo Bonzini --- .patchew.yml | 2

Re: [Qemu-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE

2019-03-15 Thread Paul Durrant
> -Original Message- > From: Jason Andryuk [mailto:jandr...@gmail.com] > Sent: 14 March 2019 18:16 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; > marma...@invisiblethingslab.com; Simon > Gaiser ; Stefano Stabellini > ; Anthony Perard > > Subject: Re: [

Re: [Qemu-devel] [PATCH] scripts/make-release: Stop shipping u-boot source as a tarball

2019-03-15 Thread Peter Maydell
On Thu, 14 Mar 2019 at 21:31, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 3/14/19 4:56 PM, Peter Maydell wrote: > > In commit d0dead3b6df7f6cd970e we changed to shipping the u-boot > > sources as a tarball, to work around a problem where they > > contained a file and directory that had the

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-15 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 03:31:47PM +0300, Yury Kotov wrote: > Hi, > > 14.03.2019, 14:44, "Daniel P. Berrangé" : > > On Thu, Mar 14, 2019 at 07:34:03AM -0400, Michael S. Tsirkin wrote: > >>  On Thu, Mar 14, 2019 at 11:24:22AM +, Daniel P. Berrangé wrote: > >>  > On Tue, Mar 12, 2019 at 12:49:35

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-15 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 06:22:44PM +, Peter Maydell wrote: > On Thu, 14 Mar 2019 at 15:57, Alex Bennée wrote: > > Testing in the Cloud > > > > > > After BuildBot went out-of-service we have been relying heavily on Travis > > as our primary CI platform. This has been creaki

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-15 Thread Alex Bennée
Fam Zheng writes: >> On Mar 15, 2019, at 16:57, Alex Bennée wrote: >> >> I had installed the gitlab-runner from the Debian repo but it was out >> of date and didn't seem to work correctly. > > If there can be a sidecar x86 box next to the test bot, it can be the > controller node which runs gi

Re: [Qemu-devel] [PATCH] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-15 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne [mailto:roger@citrix.com] > Sent: 15 March 2019 08:59 > To: qemu-devel@nongnu.org > Cc: Roger Pau Monne ; Stefano Stabellini > ; Anthony > Perard ; Paul Durrant ; > Igor Druzhinin > ; Paolo Bonzini ; Richard > Henderson ; > Eduardo Habkost

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-15 Thread Daniel P . Berrangé
On Fri, Mar 15, 2019 at 09:34:27AM +, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Thu, Mar 14, 2019 at 03:57:06PM +, Alex Bennée wrote: > >> Docker Images > >> = > >> > >> The addition of docker has unlocked the ability to build a lot more > >> tests as well as

[Qemu-devel] [PATCH v6 0/2] Add Arm SBSA Reference Machine

2019-03-15 Thread Hongbo Zhang
For the Aarch64, there is one machine 'virt', it is primarily meant to run on KVM and execute virtualization workloads, but we need an environment as faithful as possible to physical hardware, to support firmware and OS development for pysical Aarch64 machines. This machine comes with: - Re-desi

[Qemu-devel] [PATCH v6 2/2] hw/arm: Add arm SBSA reference machine, devices part

2019-03-15 Thread Hongbo Zhang
Following the previous patch, this patch adds peripheral devices to the newly introduced SBSA-ref machine. Signed-off-by: Hongbo Zhang --- hw/arm/sbsa-ref.c | 451 ++ 1 file changed, 451 insertions(+) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sb

[Qemu-devel] [PATCH v6 1/2] hw/arm: Add arm SBSA reference machine, skeleton part

2019-03-15 Thread Hongbo Zhang
For the Aarch64, there is one machine 'virt', it is primarily meant to run on KVM and execute virtualization workloads, but we need an environment as faithful as possible to physical hardware, for supporting firmware and OS development for pysical Aarch64 machines. This patch introduces new machin

Re: [Qemu-devel] [PATCH] curses ui: always initialize all curses_line fields

2019-03-15 Thread Peter Maydell
On Fri, 15 Mar 2019 at 08:37, Samuel Thibault wrote: > > cchar_t can contain not only attr and chars fields, but also ext_color. > Initialize the whole structure to zero instead of enumerating fields. > > Spotted by Coverity: CID 1399711 > > Signed-off-by: Samuel Thibault > --- > ui/curses.c | 3

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-15 Thread Alex Bennée
Daniel P. Berrangé writes: > On Fri, Mar 15, 2019 at 09:34:27AM +, Alex Bennée wrote: >> >> Daniel P. Berrangé writes: >> >> > On Thu, Mar 14, 2019 at 03:57:06PM +, Alex Bennée wrote: >> >> Docker Images >> >> = >> >> >> >> The addition of docker has unlocked the ability to

Re: [Qemu-devel] [PATCH] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-15 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 15 March 2019 10:10 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; Stefano Stabellini ; > Anthony Perard > ; Igor Druzhinin ; > Paolo Bonzini > ; Richard Henderson ; Eduardo Habkost > ; > Michael S. Tsirkin ; Marcel Apfelbaum > ; xe

Re: [Qemu-devel] [PATCH] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-15 Thread Roger Pau Monné
On Fri, Mar 15, 2019 at 10:54:42AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Roger Pau Monne [mailto:roger@citrix.com] > > Sent: 15 March 2019 08:59 > > To: qemu-devel@nongnu.org > > Cc: Roger Pau Monne ; Stefano Stabellini > > ; Anthony > > Perard ; Paul Durrant ; >

[Qemu-devel] [PATCH v5 3/5] RISC-V: Fixes to CSR_* register macros.

2019-03-15 Thread Chih-Min Chao
From: Jim Wilson This adds some missing CSR_* register macros, and documents some as being priv v1.9.1 specific. Signed-off-by: Jim Wilson Reviewed-by: Alistair Francis Message-Id: <20190212230830.9160-1-j...@sifive.com> --- target/riscv/cpu_bits.h | 35 +-- 1

Re: [Qemu-devel] [PATCH] scripts/make-release: Stop shipping u-boot source as a tarball

2019-03-15 Thread Philippe Mathieu-Daudé
On 3/15/19 10:46 AM, Peter Maydell wrote: > On Thu, 14 Mar 2019 at 21:31, Philippe Mathieu-Daudé > wrote: >> >> Hi Peter, >> >> On 3/14/19 4:56 PM, Peter Maydell wrote: >>> In commit d0dead3b6df7f6cd970e we changed to shipping the u-boot >>> sources as a tarball, to work around a problem where th

Re: [Qemu-devel] [PULL 17/29] target/riscv: Convert quadrant 1 of RVXC insns to decodetree

2019-03-15 Thread Palmer Dabbelt
On Fri, 15 Mar 2019 02:06:07 PDT (-0700), Bastian Koppelmann wrote: Hi Alistair On 3/14/19 9:28 PM, Alistair Francis wrote: On Wed, Mar 13, 2019 at 7:53 AM Palmer Dabbelt wrote: From: Bastian Koppelmann Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer A

[Qemu-devel] [PATCH 1/2] target/mips: Optimize ILVOD. MSA instructions

2019-03-15 Thread Mateja Marjanovic
From: Mateja Marjanovic Optimize set of MSA instructions ILVOD, using directly tcg registers and performing logic on them insted of using helpers. Performance measurement is done by executing the instructions large number of times on a computer with Intel Core i7-3770 CPU @ 3.40GHz×8. instructi

[Qemu-devel] [PATCH 2/2] target/mips: Optimize ILVEV. MSA instructions

2019-03-15 Thread Mateja Marjanovic
From: Mateja Marjanovic Optimize set of MSA instructions ILVEV, using directly tcg registers and performing logic on them insted of using helpers. Performance measurement is done by executing the instructions large number of times on a computer with Intel Core i7-3770 CPU @ 3.40GHz×8. instructi

Re: [Qemu-devel] [PATCH v2 04/11] hw/arm/virt: Add virtual ACPI device

2019-03-15 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: 15 March 2019 08:42 > To: Shameerali Kolothum Thodi > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; > shannon.zha...@gmail.com; sa...@linux.intel.com; > s

Re: [Qemu-devel] [PULL 0/5] target-arm queue

2019-03-15 Thread Peter Maydell
he Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20190315 > > for you to fetch changes up to 5de56742a3c91de3d646326bec43a989bba83ca4: > > target/arm: Check access permission to ADDVL/ADDPL/RDVL (2019-03-15 > 11:12:2

Re: [Qemu-devel] [PATCH v13 19/25] replay: add BH oneshot event for block layer

2019-03-15 Thread Kevin Wolf
Am 15.03.2019 um 08:26 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 21.02.2019 um 12:05 hat Pavel Dovgalyuk geschrieben: > > > Replay is capable of recording normal BH events, but sometimes > > > there are single use callbacks scheduled with aio_bh_schedule

[Qemu-devel] [PATCH 0/2] target/mips: Optimize ILVEV and ILVOD MSA instructions

2019-03-15 Thread Mateja Marjanovic
From: Mateja Marjanovic Optimize set of MSA instructions ILVEV and ILVOD, using directly tcg registers and performing logic on them insted of using helpers. Mateja Marjanovic (2): target/mips: Optimize ILVOD. MSA instructions target/mips: Optimize ILVEV. MSA instructions target/mips/helpe

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-03-15 Thread Daniel P . Berrangé
On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote: > > On 1/18/19 3:39 AM, Erik Skultety wrote: > > I proceeded with cloning [1] to systemd and creating an udev rule that I > > planned > > on submitting to systemd upstream - the initial idea was to mimic /dev/kvm > > and > > make it

[Qemu-devel] [PATCH v14 22/25] util/qemu-timer: refactor deadline calculation for external timers

2019-03-15 Thread Pavel Dovgalyuk
icount-based record/replay uses qemu_clock_deadline_ns_all to measure the period until vCPU may be interrupted. This function takes in account the virtual timers, because they belong to the virtual devices that may generate interrupt request or affect the virtual machine state. However, there are a

Re: [Qemu-devel] [PATCH v14 00/25] Fixing record/replay and adding reverse debugging

2019-03-15 Thread Pavel Dovgalyuk
Paolo, since we are in soft freeze phase, what about merging just patches 1-6, 14, 15, 19, 21-23, 25? They fix icount/rr bugs and make small improvements of these features. I also just noticed that patch 20 is obsolete. I'll drop it in the next iteration. Pavel Dovgalyuk > -Original Messag

Re: [Qemu-devel] [PATCH] curses ui: always initialize all curses_line fields

2019-03-15 Thread Eric Blake
On 3/15/19 5:06 AM, Peter Maydell wrote: > On Fri, 15 Mar 2019 at 08:37, Samuel Thibault > wrote: >> >> cchar_t can contain not only attr and chars fields, but also ext_color. >> Initialize the whole structure to zero instead of enumerating fields. >> >> Spotted by Coverity: CID 1399711 >> >> Sign

Re: [Qemu-devel] [PATCH v2 09/12] pc-bios: document the edk2 firmware images; add firmware descriptors

2019-03-15 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 10:00:54PM +0100, Laszlo Ersek wrote: > Update the README file with information on the images added previously, > and provide firmware descriptor documents that conform to > "docs/interop/firmware.json". > > Signed-off-by: Laszlo Ersek > Reviewed-by: Michal Privoznik > Re

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-15 Thread Pavel Hrdina
On Tue, Mar 12, 2019 at 08:12:40AM +0100, Gerd Hoffmann wrote: > From: Kővágó, Zoltán > > Audio drivers now get an Audiodev * as config paramters, instead of the > global audio_option structs. There is some code in audio/audio_legacy.c > that converts the old environment variables to audiodev op

[Qemu-devel] [PATCH v14 23/25] replay: fix replay shutdown

2019-03-15 Thread Pavel Dovgalyuk
This patch fixes shutdown of the replay process, which is terminated with the assert when shutdown event is read from the log. replay_finish_event reads new data_kind and therefore the value of data_kind should be preserved to be valid at qemu_system_shutdown_request call. Signed-off-by: Pavel Dov

[Qemu-devel] [PATCH v5 4/5] RISC-V: Add debug support for accessing CSRs.

2019-03-15 Thread Chih-Min Chao
From: Jim Wilson Add a debugger field to CPURISCVState. Add riscv_csrrw_debug function to set it. Disable mode checks when debugger field true. Signed-off-by: Jim Wilson Reviewed-by: Alistair Francis Message-Id: <20190212230903.9215-1-j...@sifive.com> --- target/riscv/cpu.h | 5 + targ

[Qemu-devel] [PATCH v14 25/25] icount: clean up cpu_can_io before jumping to the next block

2019-03-15 Thread Pavel Dovgalyuk
Most of IO instructions can be executed only at the end of the block in icount mode. Therefore translator can set cpu_can_io flag when translating the last instruction. But when the blocks are chained, then this flag is not reset and may remain set at the beginning of the next block. This patch res

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-15 Thread Peter Maydell
On Fri, 15 Mar 2019 at 09:05, Alex Bennée wrote: > > > Peter Maydell writes: > > [+] I currently test: > > - windows crossbuilds > > We did have this with shippable but had to disable it when the upstream > repo went down. We could re-enable if we can rebuild it and cache our > docker images wit

Re: [Qemu-devel] Data bus error with redeonfb on mips_fulong2e

2019-03-15 Thread BALATON Zoltan
On Fri, 15 Mar 2019, Philippe Mathieu-Daudé wrote: On 3/14/19 11:08 PM, BALATON Zoltan wrote: On Thu, 14 Mar 2019, Aleksandar Markovic wrote: From: BALATON Zoltan Subject: Data bus error with redeonfb on mips_fulong2e Hello, Trying to debug the Linux kernel oops with radeonfb I've added some

Re: [Qemu-devel] [PATCH] ci: store Patchew configuration in the tree

2019-03-15 Thread Alex Bennée
Paolo Bonzini writes: > Patchew cannot yet retrieve the configuration from the QEMU Git tree, but > this is planned. In the meanwhile, let's start storing it as YAML > so that the Patchew configuration (currently accessible only to > administrators) > is public and documented. > > Signed-off-

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-15 Thread Yongji Xie
On Fri, 15 Mar 2019 at 18:41, Yury Kotov wrote: > > 15.03.2019, 12:46, "Daniel P. Berrangé" : > > On Thu, Mar 14, 2019 at 03:31:47PM +0300, Yury Kotov wrote: > >> Hi, > >> > >> 14.03.2019, 14:44, "Daniel P. Berrangé" : > >> > On Thu, Mar 14, 2019 at 07:34:03AM -0400, Michael S. Tsirkin wrote: >

Re: [Qemu-devel] [PATCH v2 08/12] pc-bios: add edk2 firmware binaries and variable store templates

2019-03-15 Thread Gerd Hoffmann
Hi, > It would be nice if we had a standard dockerfile that was designated > as the build environment for each of the ROMs (one docker file might > be suitable for many of the ROMs in fact). If we manage to pull that off I'm wondering whenever there is a point in continuing shipping the firmwar

[Qemu-devel] [PATCH v14 05/25] replay: don't drain/flush bdrv queue while RR is working

2019-03-15 Thread Pavel Dovgalyuk
In record/replay mode bdrv queue is controlled by replay mechanism. It does not allow saving or loading the snapshots when bdrv queue is not empty. Stopping the VM is not blocked by nonempty queue, but flushing the queue is still impossible there, because it may cause deadlocks in replay mode. This

[Qemu-devel] [PATCH v14 24/25] replay: rename step-related variables and functions

2019-03-15 Thread Pavel Dovgalyuk
This patch renames replay_get_current_step() and related variables to make these names consistent with hmp/qmp commands. Signed-off-by: Pavel Dovgalyuk --- blockdev.c|2 +- include/sysemu/replay.h |2 +- migration/savevm.c|2 +- replay/replay-debugging.c |

Re: [Qemu-devel] [PATCH v2 08/12] pc-bios: add edk2 firmware binaries and variable store templates

2019-03-15 Thread Daniel P . Berrangé
On Fri, Mar 15, 2019 at 01:29:31PM +0100, Gerd Hoffmann wrote: > Hi, > > > It would be nice if we had a standard dockerfile that was designated > > as the build environment for each of the ROMs (one docker file might > > be suitable for many of the ROMs in fact). > > If we manage to pull that o

[Qemu-devel] [PATCH v14 16/25] gdbstub: add reverse step support in replay mode

2019-03-15 Thread Pavel Dovgalyuk
GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution. But replayed execution is

Re: [Qemu-devel] [PATCH v2 08/12] pc-bios: add edk2 firmware binaries and variable store templates

2019-03-15 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 07:43:58PM +0100, Philippe Mathieu-Daudé wrote: > On 3/13/19 10:00 PM, Laszlo Ersek wrote: > > Add the files built by the last patch: (compressed) binaries, and the > > cumulative license text that covers them. > > > > Signed-off-by: Laszlo Ersek > > --- > > > > Notes: >

[Qemu-devel] [PATCH v14 18/25] replay: describe reverse debugging in docs/replay.txt

2019-03-15 Thread Pavel Dovgalyuk
This patch updates the documentation and describes usage of the reverse debugging in QEMU+GDB. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 33 + 1 file changed, 33 insertions(+) diff --git a/docs/replay.txt b/docs/replay.txt index ce97c3f72f..47b4f2d9f

[Qemu-devel] [PATCH v14 14/25] replay: refine replay-time module

2019-03-15 Thread Pavel Dovgalyuk
This patch removes refactoring artifacts from the replay/replay-time.c Signed-off-by: Pavel Dovgalyuk --- replay/replay-time.c | 36 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/replay/replay-time.c b/replay/replay-time.c index 0df1693337

[Qemu-devel] [PATCH v14 11/25] replay: introduce info hmp/qmp command

2019-03-15 Thread Pavel Dovgalyuk
This patch introduces 'info replay' monitor command and corresponding qmp request. These commands request the current record/replay mode, replay log file name, and the instruction count (number of recorded/replayed instructions). The instruction count can be used with the replay_seek/replay_break

Re: [Qemu-devel] [PULL 17/29] target/riscv: Convert quadrant 1 of RVXC insns to decodetree

2019-03-15 Thread Bastian Koppelmann
On 3/15/19 1:44 PM, Bastian Koppelmann wrote: On 3/15/19 1:07 PM, Palmer Dabbelt wrote: On Fri, Mar 15, 2019 at 4:19 AM Palmer Dabbelt wrote: On Fri, 15 Mar 2019 02:06:07 PDT (-0700), Bastian Koppelmann wrote: Hi Alistair On 3/14/19 9:28 PM, Alistair Francis wrote: On Wed, Mar 13, 2019

[Qemu-devel] [PATCH v14 12/25] replay: introduce breakpoint at the specified step

2019-03-15 Thread Pavel Dovgalyuk
This patch introduces replay_break, replay_delete_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. replay_break command has one argument - number of instructions execu

[Qemu-devel] [PATCH v14 10/25] qapi: introduce replay.json for record/replay-related stuff

2019-03-15 Thread Pavel Dovgalyuk
This patch adds replay.json file. It will be used for adding record/replay-related data structures and commands. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Markus Armbruster -- v10: - minor changes v13: - rebased to the new QAPI files --- MAINTAINERS |1 + include/sysemu/re

Re: [Qemu-devel] Data bus error with redeonfb on mips_fulong2e

2019-03-15 Thread BALATON Zoltan
On Fri, 15 Mar 2019, Philippe Mathieu-Daudé wrote: $ fgrep 'pci_cfg_write ati-vga' trace.log ... 23023@1552615560.106226:pci_cfg_write ati-vga 06:0 @0x10 <- 0x408 23023@1552615560.106337:pci_cfg_write ati-vga 06:0 @0x18 <- 0x505 23023@1552615560.106823:pci_cfg_write ati-vga 06:0 @0x30 <-

[Qemu-devel] [PATCH v14 02/25] block: implement bdrv_snapshot_goto for blkreplay

2019-03-15 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch enables making snapshots with blkreplay used in block devices. This function is required to make bdrv_snapshot_goto without calling .bdrv_open which is not implemented. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf --- block/blkreplay.c |8

[Qemu-devel] [PATCH v14 07/25] qcow2: introduce icount field for snapshots

2019-03-15 Thread Pavel Dovgalyuk
This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf -- v2: - documented format changes in docs/interop/qcow2.txt (suggested by Eric Blake) v10:

Re: [Qemu-devel] [PATCHv2] curses ui: always initialize all curses_line fields

2019-03-15 Thread Peter Maydell
On Fri, 15 Mar 2019 at 13:09, Samuel Thibault wrote: > > cchar_t can contain not only attr and chars fields, but also ext_color. > Initialize the whole structure to zero instead of enumerating fields. > > Spotted by Coverity: CID 1399711 > > Signed-off-by: Samuel Thibault > --- > ui/curses.c | 6

[Qemu-devel] [PATCH v14 04/25] replay: update docs for record/replay with block devices

2019-03-15 Thread Pavel Dovgalyuk
This patch updates the description of the command lines for using record/replay with attached block devices. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/replay.txt b/docs/replay.txt index ee6aee9861..c

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-15 Thread Yury Kotov
15.03.2019, 12:46, "Daniel P. Berrangé" : > On Thu, Mar 14, 2019 at 03:31:47PM +0300, Yury Kotov wrote: >>  Hi, >> >>  14.03.2019, 14:44, "Daniel P. Berrangé" : >>  > On Thu, Mar 14, 2019 at 07:34:03AM -0400, Michael S. Tsirkin wrote: >>  >>  On Thu, Mar 14, 2019 at 11:24:22AM +, Daniel P. Berr

[Qemu-devel] [PATCH v14 13/25] replay: implement replay-seek command

2019-03-15 Thread Pavel Dovgalyuk
This patch adds hmp/qmp commands replay_seek/replay-seek that proceed the execution to the specified instruction count. The command automatically loads nearest snapshot and replays the execution to find the desired instruction count. Signed-off-by: Pavel Dovgalyuk Acked-by: Markus Armbruster --

[Qemu-devel] [PATCH v14 08/25] migration: introduce icount field for snapshots

2019-03-15 Thread Pavel Dovgalyuk
Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for proceeding the recorded execution to the specific moment of the time. E.g., 'reverse step' action (introduced in one of the

Re: [Qemu-devel] [PULL 17/29] target/riscv: Convert quadrant 1 of RVXC insns to decodetree

2019-03-15 Thread Bastian Koppelmann
On 3/15/19 1:07 PM, Palmer Dabbelt wrote: On Fri, Mar 15, 2019 at 4:19 AM Palmer Dabbelt wrote: On Fri, 15 Mar 2019 02:06:07 PDT (-0700), Bastian Koppelmann wrote: Hi Alistair On 3/14/19 9:28 PM, Alistair Francis wrote: On Wed, Mar 13, 2019 at 7:53 AM Palmer Dabbelt wrote: From: Bastia

[Qemu-devel] [PATCH v14 20/25] replay: init rtc after enabling the replay

2019-03-15 Thread Pavel Dovgalyuk
This patch postpones the call of 'configure_rtc' function. This call uses host clock to configure the rtc, but host clock access should be recorded when using icount record/replay mode. Therefore now rtc is configured after switching record/replay mode on. Signed-off-by: Pavel Dovgalyuk --- vl.c

[Qemu-devel] [PATCH v5 0/5] RISC-V: Add gdb xml files and gdbstub support

2019-03-15 Thread Chih-Min Chao
This is the 5th version of the patch set, based on the Jim's previous work, http://lists.nongnu.org/archive/html/qemu-riscv/2019-02/msg00059.html v4 -> v5: - rebase 7074ab1 - update the register xml files to gdb 8.3 - refine the fpu control registers, fflags/frm/fcsr

[Qemu-devel] [PATCH v14 19/25] replay: add BH oneshot event for block layer

2019-03-15 Thread Pavel Dovgalyuk
Replay is capable of recording normal BH events, but sometimes there are single use callbacks scheduled with aio_bh_schedule_oneshot function. This patch enables recording and replaying such callbacks. Block layer uses these events for calling the completion function. Replaying these calls makes th

Re: [Qemu-devel] Data bus error with redeonfb on mips_fulong2e

2019-03-15 Thread BALATON Zoltan
Hello, On Fri, 15 Mar 2019, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 3/14/19 11:08 PM, BALATON Zoltan wrote: On Thu, 14 Mar 2019, Aleksandar Markovic wrote: From: BALATON Zoltan Subject: Data bus error with redeonfb on mips_fulong2e Hello, Trying to debug the Linux kernel oops with rade

[Qemu-devel] [PATCH v14 06/25] replay: finish record/replay before closing the disks

2019-03-15 Thread Pavel Dovgalyuk
After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c |2 ++ vl.c|

[Qemu-devel] [PATCH v14 01/25] replay: add missing fix for internal function

2019-03-15 Thread Pavel Dovgalyuk
From: pbonz...@redhat.com This is a fix which was missed by patch 74c0b816adfc6aa1b01b4426fdf385e32e35cbac, which added current_step parameter to the replay_advance_current_step function. Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c |2 +- 1 file changed, 1 insertion(+), 1 d

[Qemu-devel] [PATCH v14 09/25] replay: provide an accessor for rr filename

2019-03-15 Thread Pavel Dovgalyuk
This patch adds an accessor function for the name of the record/replay log file. Adding an accessor instead of making variable global, prevents accidental modification of this variable by other modules. Signed-off-by: Pavel Dovgalyuk --- include/sysemu/replay.h |2 ++ replay/replay.c

Re: [Qemu-devel] [PATCHv2] curses ui: add missing iconv_close calls

2019-03-15 Thread Peter Maydell
On Thu, 14 Mar 2019 at 17:26, Samuel Thibault wrote: > > The iconv_t are opened but never closed. > > Spotted by Coverity: CID 1399708 > Spotted by Coverity: CID 1399709 > Spotted by Coverity: CID 1399713 > > Signed-off-by: Samuel Thibault Reviewed-by: Peter Maydell thanks -- PMM

[Qemu-devel] [PATCH v14 17/25] gdbstub: add reverse continue support in replay mode

2019-03-15 Thread Pavel Dovgalyuk
This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the breakpoints that were hit

[Qemu-devel] [PATCH v14 21/25] replay: document development rules

2019-03-15 Thread Pavel Dovgalyuk
This patch introduces docs/devel/replay.txt which describes the rules that should be followed to make virtual devices usable in record/replay mode. Signed-off-by: Pavel Dovgalyuk -- v9: fixed external virtual clock description (reported by Artem Pisarenko) --- docs/devel/replay.txt | 46

[Qemu-devel] [PATCH 2/2] keymaps: regenerate keymaps

2019-03-15 Thread Gerd Hoffmann
Pick up the config updates. Also add a few keys to the maps which got a QKeyCode assigned since the last time we generated the maps (Hiragana_Katakana, Muhenkan). Sync will xkbcommon updates. Signed-off-by: Gerd Hoffmann --- pc-bios/keymaps/ar| 53 +++---

  1   2   3   >