Re: [Qemu-devel] [PATCH v3 2/4] hw/firmware: Add Edk2Crypto and edk2_add_host_crypto_policy()

2019-03-11 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > The Edk2Crypto object is used to hold configuration values specific > to EDK2. > > The edk2_add_host_crypto_policy() function loads crypto policies > from the host, and register them as fw_cfg named file items. > So far only the 'https' policy is supported. > > A

Re: [Qemu-devel] [PATCH v3 1/4] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host()

2019-03-11 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Add a function to read the full content of file on the host, and add > a new 'file' name item to the fw_cfg device. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: s/ptr/data, corrected documentation (Laszlo) > v3: inverted the if() logic > --- > hw/nvram/

Re: [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak

2019-03-11 Thread Vladimir Sementsov-Ogievskiy
10.03.2019 14:34, Li Qiang wrote: > Fixes: 2dbfadf > Spotted by ASAN when 'make check'. > > Signed-off-by: Li Qiang Oops, my fault, thank you for fixing this! Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > tests/test-bdrv-graph-mod.c | 1 + > 1 file changed, 1 insertion(+) > > diff --g

[Qemu-devel] [PATCH] pcnet: Avoid warning when switching back to 16bit mode

2019-03-11 Thread Helge Deller
When Linux is shutting down, the pcnet32 driver switches the pcnet card back to 16bit mode to "avoid problems with dumb DOS packet driver after a warm reboot". This triggers the following warning in the qemu pcnet32 emulation: Bad SWSTYLE=0x04 Avoid this qemu warning by allowing the switch-back to

[Qemu-devel] [PATCH v5 1/2] qapi: move to QOM path for x-block-latency-histogram-set

2019-03-11 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 14 +++--- blockdev.c | 12 ++-- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 919d0530b2..9a72e3ee5f 100644 --- a/qapi/block-core.

[Qemu-devel] [PATCH v5 0/2] improve block-latency-histogram-set

2019-03-11 Thread Vladimir Sementsov-Ogievskiy
Move to QOM path for block-latency-histogram-set and drop x- prefix. v5: 01: fix parameter name s/id/device/ in qapi description and examples [Kevin] v4: 01: update definition of @id [Markus] go only through qmp_get_blk [Kevin] Vladimir Sementsov-Ogievskiy (2): qapi: move to QOM path f

[Qemu-devel] [PATCH v5 2/2] qapi: drop x- from x-block-latency-histogram-set

2019-03-11 Thread Vladimir Sementsov-Ogievskiy
Drop x- and x_ prefixes for latency histograms and update version to 3.1 Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 20 ++-- block/qapi.c | 12 ++-- blockdev.c | 2 +- 3 files changed, 17 insertions(+), 17 deletions(-) diff

[Qemu-devel] [PATCH] qom: use object_new_with_type in object_new_with_propv

2019-03-11 Thread Wei Yang
Function object_new_with_propv already get the Type of the object, so we could leverage object_new_with_type here. [make check test pass] Signed-off-by: Wei Yang --- qom/object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index 05a8567041..76

[Qemu-devel] [PULL 5/5] monitor: deprecate acl_show, acl_reset, acl_policy, acl_add, acl_remove

2019-03-11 Thread Gerd Hoffmann
From: Daniel P. Berrangé The various ACL related commands are obsolete now that the QAuthZ framework for authorization is fully integrated throughout QEMU network services. These only ever worked with VNC and were never used by libvirt. Mark it as deprecated with no direct replacement to be provi

Re: [Qemu-devel] [PATCH] tests: test-announce-self: fix memory leak

2019-03-11 Thread Thomas Huth
On 10/03/2019 14.12, Li Qiang wrote: > Spotted by ASAN when 'make check'. > > Signed-off-by: Li Qiang > --- > tests/test-announce-self.c | 20 ++-- > 1 file changed, 6 insertions(+), 14 deletions(-) > > diff --git a/tests/test-announce-self.c b/tests/test-announce-self.c > index

[Qemu-devel] [PULL 3/5] vnc: fix update stalls

2019-03-11 Thread Gerd Hoffmann
vnc aborts display update jobs on video mode switches and page flips. That can cause vnc update stalls in case an unfinished vnc job gets aborted. The vnc client will never receive the requested update then. Fix that by copying the state from job_update back to update in that case. Reports compla

[Qemu-devel] [RESEND PATCH] target/arm: change arch timer registers access permission

2019-03-11 Thread gengdongjiu
From: Dongjiu Geng Some generic arch timer registers are Config-RW in the EL0, which means the EL0 exception level can have write permission if it is appropriately configured. When VM access registers, it firstly checks whether they have RW permission, then check whether it is appropriately conf

[Qemu-devel] [PULL 4/5] vnc: allow specifying a custom authorization object name

2019-03-11 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The VNC server has historically had support for ACLs to check both the SASL username and the TLS x509 distinguished name. The VNC server was responsible for creating the initial ACL, and the client app was then responsible for populating it with rules using the HMP 'acl

[Qemu-devel] [PULL 2/5] curses: support wide input

2019-03-11 Thread Gerd Hoffmann
From: Samuel Thibault This makes use of wide curses functions instead of 8bit functions. This allows to type e.g. accented letters. Unfortunately, key codes are then returned with values that could be confused with wide characters by ncurses, so we need to add a maybe_keycode variable to know wh

Re: [Qemu-devel] [PATCH 0/3] migration: add sztd compression

2019-03-11 Thread Denis Plotnikov
ping ping ping! On 04.03.2019 18:10, Denis Plotnikov wrote: > ping! > > On 26.02.2019 16:15, Denis Plotnikov wrote: >> zstd date compression algorithm shows better performance on data compression. >> It might be useful to employ the algorithm in VM migration to reduce CPU >> usage. >> A user wil

[Qemu-devel] [PULL 0/5] Ui 20190311 v2 patches

2019-03-11 Thread Gerd Hoffmann
The following changes since commit e2a18635a400b0e68679614132e9ef6316105590: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2019-03-08' into staging (2019-03-09 20:55:44 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-20190311-v2-pu

[Qemu-devel] [PULL 1/5] Reduce curses escdelay from 1s to 25ms

2019-03-11 Thread Gerd Hoffmann
From: Samuel Thibault By default, curses will only report single ESC key event after 1s delay, since ESC is also used for keypad escape sequences. This however makes users believe that ESC is not working. Reducing to 25ms provides good user experience, while still allowing 25ms for keypad sequenc

[Qemu-devel] [PATCH] target/arm: change arch timer registers access permission

2019-03-11 Thread gengdongjiu
Some generic arch timer registers are Config-RW in the EL0, which means the EL0 exception level can have write permission if it is appropriately configured. When VM access registers, it firstly checks whether they have RW permission, then check whether it is appropriately configured. If they are d

[Qemu-devel] [PATCH] target/arm: change arch timer registers access permission

2019-03-11 Thread gengdongjiu
Some generic arch timer registers are Config-RW in the EL0, which means the EL0 exception level can have write permission if it is appropriately configured. When VM access registers, it firstly checks whether they have RW permission, then check whether it is appropriately configured. If they are d

Re: [Qemu-devel] [PULL 0/7] Ui 20190307 patches

2019-03-11 Thread Gerd Hoffmann
> > curses: better wide char support. > > vnc: acl update, stall fix. > Hi; this fails to build on FreeBSD; linking the qemu-system-* > binaries fails with: > > /usr/bin/ld: undefined reference to symbol `libiconv_open' (try adding > -liconv) > //usr/local/lib/libiconv.so.2: could not read symbo

Re: [Qemu-devel] [PATCH] tests: test-qgraph: fix a memory leak

2019-03-11 Thread Thomas Huth
On 10/03/2019 17.02, Li Qiang wrote: > Spotted by ASAN when 'make check'. > > Signed-off-by: Li Qiang > --- > tests/test-qgraph.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/test-qgraph.c b/tests/test-qgraph.c > index f6a6565e31..5c7e457075 100644 > --- a/te

[Qemu-devel] [PULL 2/5] virtio-vga: fix reset.

2019-03-11 Thread Gerd Hoffmann
Store reset handler of the parent class and just call that for a complete virtio reset. When taking the shortcut and calling virtio_gpu_reset() directly the generic virtio reset code (for virtqueues etc) will not be executed. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1597621 Signed-off

[Qemu-devel] [PULL 0/5] Vga 20190311 v2 patches

2019-03-11 Thread Gerd Hoffmann
The following changes since commit e2a18635a400b0e68679614132e9ef6316105590: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2019-03-08' into staging (2019-03-09 20:55:44 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-20190311-v2-pu

[Qemu-devel] [PULL 3/5] virtio-gpu: make virtio_gpu_reset static

2019-03-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Message-id: 20190307080244.9011-4-kra...@redhat.com --- include/hw/virtio/virtio-gpu.h | 1 - hw/display/virtio-gpu.c| 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/inc

[Qemu-devel] [PULL 5/5] mips_fulong2e: Add on-board graphics chip

2019-03-11 Thread Gerd Hoffmann
From: BALATON Zoltan Add (partial) emulation of the on-board GPU of the machine. This allows the PMON2000 firmware to run and should also work with Linux console but probably not with X yet. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Re

[Qemu-devel] [PULL 1/5] virtio: add class_size to VirtioPCIDeviceTypeInfo

2019-03-11 Thread Gerd Hoffmann
Needed when VirtioPCIClass subclasses have their own class struct with some extra fields. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Message-id: 20190307080244.9011-2-kra...@redhat.com --- hw/virtio/virtio-pci.h | 1 + hw/virtio/virtio-pci.

[Qemu-devel] [PULL 4/5] hw/display: Add basic ATI VGA emulation

2019-03-11 Thread Gerd Hoffmann
From: BALATON Zoltan At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and guests running on these and the PMON2000 firmware of the fulong2e expect this to be available. Fortunately these are very similar chips so they

Re: [Qemu-devel] [PATCH v7 0/2] Basic ATI VGA emulation

2019-03-11 Thread Gerd Hoffmann
On Sat, Mar 09, 2019 at 06:21:40PM +0100, BALATON Zoltan wrote: > Rebase on master to fix build with new Kconfig based stuff. Thanks. Pull v2 sent. cheers, Gerd

[Qemu-devel] [PULL 00/33] final s390x patches for 4.0 soft freeze

2019-03-11 Thread Cornelia Huck
The following changes since commit e2a18635a400b0e68679614132e9ef6316105590: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2019-03-08' into staging (2019-03-09 20:55:44 +) are available in the Git repository at: https://github.com/cohuck/qemu tags/s390x-20190311

[Qemu-devel] [PULL 02/33] s390x/tcg: Define vector instruction formats

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand These are the new instruction formats related to vector instructions as up to the z14 (a.k.a. latest PoP). As v2 appeares (like x2 in VRX) with d2/b2 in VRV, we have to assign it a higher field number to avoid collisions. Properly take care of the MSB (to be able to addr

[Qemu-devel] [PULL 06/33] s390x/tcg: Implement VECTOR GENERATE BYTE MASK

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Let's optimize it for the common cases (setting a vector to zero or all ones) - courtesy of Richard. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-6-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/ins

[Qemu-devel] [PULL 10/33] s390x/tcg: Implement VECTOR LOAD ELEMENT

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Fairly easy, load with desired size and store it into the right element. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-10-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 5 +

[Qemu-devel] [PULL 01/33] target/s390x: Remove non-architected entries from struct LowCore

2019-03-11 Thread Cornelia Huck
From: Thomas Huth There are some fields in our struct LowCore which apparently have been copied from a very old version of the Linux kernel. These fields are not architected in the "Principles of Operation", and only used on these memory locations in Linux kernels older than 2.6.29. Newer Linux k

[Qemu-devel] [PULL 04/33] s390x/tcg: Utilities for vector instruction helpers

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand We'll have to read/write vector elements quite frequently from helpers. The tricky bit is properly taking care of endianess. Handle it similar to aarch64. Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-4-da...@redhat.com> Reviewed-by: Thomas Huth Rev

Re: [Qemu-devel] [PATCH] ati-vga: Implement DDC and EDID info from monitor

2019-03-11 Thread Gerd Hoffmann
On Sun, Mar 10, 2019 at 12:22:17AM +0100, BALATON Zoltan wrote: > This adds DDC support to ati-vga and connects i2c-ddc to provide EDID > info that is read by guests to find available screen modes. Not sure > if this is 100% correct yet but at least MorphOS is happy with it and > starts in a high r

[Qemu-devel] [PULL 07/33] s390x/tcg: Implement VECTOR GENERATE MASK

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Add gen_gvec_dupi() for handling duplication of immediates, so it can be reused later. Reviewed-by: Richard Henderson Message-Id: <20190307121539.12842-7-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_

[Qemu-devel] [PULL 03/33] s390x/tcg: Check vector register instructions at central point

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Check them at a central point. We'll use a new instruction flag to flag all vector instructions (IF_VEC) and handle it very similar to AFP, whereby we use another unused position in the PSW mask to store the state of vector register enablement per translation block. Revie

[Qemu-devel] [PULL 05/33] s390x/tcg: Implement VECTOR GATHER ELEMENT

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Let's start with a more involved one, but it is the first in the list of vector support instructions (introduced with the vector facility). Good thing is, we need a lot of basic infrastructure for this. Reading and writing vector elements as well as checking element valid

[Qemu-devel] [PULL 20/33] s390x/tcg: Implement VECTOR PACK *

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand This is a big one. Luckily we only have a limited set of such nasty instructions. We'll implement all variants with helpers, except when sources and the destination don't overlap for VECTOR PACK. Provide different helpers when the cc is to be modified. We'll return the cc

[Qemu-devel] [PULL 08/33] s390x/tcg: Implement VECTOR LOAD

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand When loading from memory, load both elements into temps first before modifying the target vector Loading with strange alingment from the end of the address space will not properly wrap, we can ignore that for now. Reviewed-by: Richard Henderson Signed-off-by: David Hild

[Qemu-devel] [PULL 09/33] s390x/tcg: Implement VECTOR LOAD AND REPLICATE

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand We can use tcg_gen_gvec_dup_i64() to carry out the duplication. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-9-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 2 ++ target/s390x

[Qemu-devel] [PULL 12/33] s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand To avoid an helper, we have to do the actual calculation of the element address (offset in cpu_env + cpu_env) manually. Factor that out into get_vec_element_ptr_i64(). The same logic will be reused for "VECTOR LOAD VR ELEMENT FROM GR". Reviewed-by: Richard Henderson Sign

[Qemu-devel] [PULL 14/33] s390x/tcg: Implement VECTOR LOAD MULTIPLE

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Try to load the last element first. Access to the first element will be checked afterwards. This way, we can guarantee that the vector is not modified before we checked for all possible exceptions. (16 vectors cannot cross more than two pages) Reviewed-by: Richard Henders

[Qemu-devel] [PULL 23/33] s390x/tcg: Implement VECTOR REPLICATE

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Replicate via the special gvec helper. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-23-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 16

[Qemu-devel] [PULL 16/33] s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Very similar to VECTOR LOAD GR FROM VR ELEMENT, just the opposite direction. Also provide a fast path in case we don't care about the register content. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-16-da...@redhat.com>

[Qemu-devel] [PULL 11/33] s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Take care of properly sign-extending the immediate. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-11-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 5 + target/s390x/transla

[Qemu-devel] [PULL 15/33] s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Very similar to LOAD COUNT TO BLOCK BOUNDARY, but instead of only calculating, the actual vector is loaded. Use a temporary vector to not modify the real vector on exceptions. Initialize that one to zero, to not leak any data. Provide a fast path if we're loading a full ve

[Qemu-devel] [PULL 26/33] s390x/tcg: Implement VECTOR SELECT

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Provide an implementation based on i64 and on real host vectors. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-26-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 2 ++ target/s39

[Qemu-devel] [PULL 17/33] s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Fairly easy, just load from to gprs into a single vector. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-17-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 2 ++ target/s390x/trans

[Qemu-devel] [PULL 13/33] s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Fairly easy, zero out the vector before we load the desired element. Load the element before touching the vector. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-13-da...@redhat.com> Signed-off-by: Cornelia Huck --- ta

[Qemu-devel] [PULL 19/33] s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand We cannot use gvec expansion as source and destination elements are have different element numbers. So we'll expand using a fancy loop. Also, we have to take care of overlapping source and destination registers, therefore use a safe evaluation irder depending on the operat

[Qemu-devel] [PULL 28/33] s390x/tcg: Provide probe_write_access helper

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Instead of checking e.g. the first access on every touched page, we should check the actual access, otherwise we might get false positives when Low Address Protection (LAP) is active. As probe_write() can only deal with accesses to one page, we have to loop. Use i64 for t

[Qemu-devel] [PULL 21/33] s390x/tcg: Implement VECTOR PERMUTE

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Take care of overlying inputs and outputs by using a temporary vector. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-21-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 1 + targe

[Qemu-devel] [PULL 18/33] s390x/tcg: Implement VECTOR LOAD WITH LENGTH

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand We can reuse the helper introduced along with VECTOR LOAD TO BLOCK BOUNDARY. We just have to take care of converting the highest index into a length. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-18-da...@redhat.com> S

[Qemu-devel] [PULL 31/33] s390x/tcg: Implement VECTOR STORE MULTIPLE

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Similar to VECTOR LOAD MULTIPLE, just the opposite direction. Probe write access first. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-31-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def

[Qemu-devel] [PULL 25/33] s390x/tcg: Implement VECTOR SCATTER ELEMENT

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Similar to VECTOR GATHER ELEMENT, but the other direction. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-25-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 3 +++ target/s390x/tr

[Qemu-devel] [PULL 22/33] s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Read the whole input before modifying the destination vector. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-22-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 2 ++ target/s390x/

[Qemu-devel] [PULL 27/33] s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Load both elements signed and store them into the two 64 bit elements. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-27-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 2 ++ targ

[Qemu-devel] [PULL 24/33] s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Like VECTOR REPLICATE, but the element to be replicated comes from an immediate. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-24-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def |

[Qemu-devel] [PULL 32/33] s390x/tcg: Implement VECTOR STORE WITH LENGTH

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Very similar to VECTOR LOAD WITH LENGTH, just the opposite direction. Properly probe write access before modifying memory. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-32-da...@redhat.com> Signed-off-by: Cornelia Huck

[Qemu-devel] [PULL 29/33] s390x/tcg: Implement VECTOR STORE

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Properly probe the whole access first. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-29-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 17

[Qemu-devel] [PULL 33/33] s390x/tcg: Implement VECTOR UNPACK *

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand Combine all variant in a single handler. As source and destination have different element sizes, we can't use gvec expansion. Expand manually. Also watch out for overlapping source and destination registers. Use a safe evaluation order depending on the operation. Reviewed

[Qemu-devel] [PULL 30/33] s390x/tcg: Implement VECTOR STORE ELEMENT

2019-03-11 Thread Cornelia Huck
From: David Hildenbrand As we only store one element, there is nothing to consider regarding exceptions. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20190307121539.12842-30-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def |

Re: [Qemu-devel] [PATCH V3 4/7] Migration/colo.c: Add new COLOExitReason to handle all failover state

2019-03-11 Thread Zhang, Chen
-Original Message- From: Markus Armbruster [mailto:arm...@redhat.com] Sent: Sunday, March 10, 2019 1:06 AM To: Zhang, Chen Cc: Li Zhijian ; Zhang Chen ; Dr. David Alan Gilbert ; Juan Quintela ; zhanghailiang ; Eric Blake ; qemu-dev ; Zhang, Chen Subject: Re: [Qemu-devel] [PATCH V3

[Qemu-devel] Flatview rendering scalability issue

2019-03-11 Thread Sergio Lopez
Hi, Thanks to Q35/PCIe, we can now assign a large number of PCI devices to a single VM, but it seems that Flatview rendering scales poorly (worse than linear) when it has to deal with a large number of Memory Regions. I've measured to cost of the pci_default_write_config() call at virtio_write_co

Re: [Qemu-devel] Several questions about " [PATCH v3 0/5] virtio-9p: hotplug and migration support"

2019-03-11 Thread Greg Kurz
On Tue, 5 Mar 2019 19:28:37 +0800 wangyan wrote: > I am very happy for your reply. > > I am very interested in your old WIP and want to take a look. > > Our project still use 9pfs, and it needs to live migrate the > device while it is being used by the guest, is there any advice > for us to m

Re: [Qemu-devel] [PULL 00/33] final s390x patches for 4.0 soft freeze

2019-03-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190311090322.21603-1-coh...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190311090322.21603-1-coh...@redhat.com Subject: [Qemu-devel] [PULL 00/33] final s390x patc

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2019-03-11 Thread Jason Wang
On 2019/3/10 下午7:26, Li Qiang wrote: Hi Jason, What's the status of this patch? I don't see it in upstream. Thanks, Li Qiang Sorry, it would be in next pull request for sure. Thanks

Re: [Qemu-devel] Booting kernels with PVHVM documentation?

2019-03-11 Thread Stefano Garzarella
Hi Alex, sorry for the big delay, but I was traveling without my PC. On Wed, Mar 06, 2019 at 05:51:05PM +, Alex Bennée wrote: > > Hi, > > I've been looking at using PVH as an alternative to a long bios boot > sequence to boot some x86_64 test kernels for tests/tcg. I'm finding it > hard to p

Re: [Qemu-devel] [PULL 30/50] spapr: Generate FDT fragment for LMBs at configure connector time

2019-03-11 Thread Greg Kurz
Hi, Just back from vacation. On Wed, 6 Mar 2019 14:16:23 +1100 David Gibson wrote: > On Tue, Mar 05, 2019 at 04:10:20PM +, Peter Maydell wrote: > > On Tue, 26 Feb 2019 at 04:53, David Gibson > > wrote: > > > > > > From: Greg Kurz > > > > > > Hi -- Coverity points out a possible ove

Re: [Qemu-devel] Question about VM inner route entry's lost when vhost-user reconnect

2019-03-11 Thread Stefan Hajnoczi
On Fri, Mar 08, 2019 at 02:31:12AM +, Lilijun (Jerry, Cloud Networking) wrote: > This problem is related with backend vhost-user socket abnormal cases, we > shouldn't ask customers to configure it manually for backend's issues or > depends on guest OS's network configuration. In Step 1 you

Re: [Qemu-devel] [PATCH v4 2/6] vfio-ccw: rework ssch state handling

2019-03-11 Thread Cornelia Huck
On Fri, 8 Mar 2019 17:18:22 -0500 Eric Farman wrote: > On 03/01/2019 04:38 AM, Cornelia Huck wrote: > > The flow for processing ssch requests can be improved by splitting > > the BUSY state: > > > > - CP_PROCESSING: We reject any user space requests while we are in > >the process of translat

[Qemu-devel] [PATCH v2] hw/char/parallel: Make it possible to compile also without CONFIG_PARALLEL

2019-03-11 Thread Thomas Huth
For the downstream distribution of QEMU, we want to compile without CONFIG_PARALLEL. Commit 9157eee1b1c076ff3 already moved the function parallel_hds_isa_init() (which is still required for linking) into a file that is included anyway, but commit bb3d5ea858e7f888563a moved it to a separate file whi

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

2019-03-11 Thread Stefan Hajnoczi
On Thu, Mar 07, 2019 at 11:34:55AM +0100, Kevin Wolf wrote: > Am 07.03.2019 um 11:22 hat Stefan Hajnoczi geschrieben: > > On Wed, Mar 06, 2019 at 10:56:33PM +0100, Kevin Wolf wrote: > > > Am 21.12.2018 um 11:16 hat Yaowei Bai geschrieben: > > > * The first priority should be adding an in-process is

[Qemu-devel] [PATCH v4 3/10] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT

2019-03-11 Thread Unai Martinez-Corral
Allow to set options '--persistent' and/or '--credential' through environment variables. If not defined, defaults are used ('no'). Anyway, command-line arguments have priority over environment variables. Signed-off-by: Unai Martinez-Corral --- scripts/qemu-binfmt-conf.sh | 18 +++---

Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

2019-03-11 Thread Daniel P . Berrangé
On Sat, Mar 09, 2019 at 02:10:17PM +0100, Michal Prívozník wrote: > On 3/9/19 1:48 AM, Laszlo Ersek wrote: > > Repo: https://github.com/lersek/qemu.git > > Branch: edk2_build > > > > This series advances the roms/edk2 submodule to the "edk2-stable201903" > > release, and builds and captures plat

[Qemu-devel] [PATCH] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of fprintf

2019-03-11 Thread Philippe Mathieu-Daudé
Avoid to clutter stdout until explicitly requested (with -d guest_errors): $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta Bad SWSTYLE=0x04 Signed-off-by: Philippe Mathieu-Daudé --- Helge patch "pcnet: Avoid warning when switching back to 16bit mode" remembered me I had

Re: [Qemu-devel] [PATCH] pcnet: Avoid warning when switching back to 16bit mode

2019-03-11 Thread Philippe Mathieu-Daudé
On 3/11/19 8:47 AM, Helge Deller wrote: > When Linux is shutting down, the pcnet32 driver switches the pcnet card > back to 16bit mode to "avoid problems with dumb DOS packet driver after > a warm reboot". > This triggers the following warning in the qemu pcnet32 emulation: > Bad SWSTYLE=0x04 This

[Qemu-devel] [PATCH v4 4/10] qemu-binfmt-conf.sh: use the same presentation format as for qemu-*

2019-03-11 Thread Unai Martinez-Corral
Signed-off-by: Unai Martinez-Corral --- scripts/qemu-binfmt-conf.sh | 58 + 1 file changed, 27 insertions(+), 31 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index e7a714e22c..489d7d2326 100755 --- a/scripts/qemu-binfmt

[Qemu-devel] [PATCH v4 1/10] qemu-binfmt-conf.sh: enforce safe style consistency

2019-03-11 Thread Unai Martinez-Corral
Spaces are added before '; then', for consistency. All the tests are prefixed with 'x', in order to avoid risky comparisons (i.e. a user deliberately trying to provoke a syntax error). Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 14 +++-

Re: [Qemu-devel] converting build system to Meson?

2019-03-11 Thread Daniel P . Berrangé
On Sun, Mar 10, 2019 at 05:28:44PM +0100, Markus Armbruster wrote: > Paolo Bonzini writes: > > > Hi all, > > > > lately I have been thinking of converting the QEMU build system to > > Meson. Meson is a relatively new build system that can replace > > Autotools or hand-written Makefiles such as Q

Re: [Qemu-devel] [PATCH] tests: test-qgraph: fix a memory leak

2019-03-11 Thread Philippe Mathieu-Daudé
On 3/10/19 5:02 PM, Li Qiang wrote: > Spotted by ASAN when 'make check'. > Fixes: fc281c80202 > Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé > --- > tests/test-qgraph.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/test-qgraph.c b/tests/tes

Re: [Qemu-devel] Flatview rendering scalability issue

2019-03-11 Thread Paolo Bonzini
On 11/03/19 10:26, Sergio Lopez wrote: > I guess this is a consequence of having to reset/rebuild the Flatview > when altering the PCI BAR regions. > > Is this a known issue we're already working on? What version of QEMU is this? The initialization is O(n^2) because the guest initializes one dev

[Qemu-devel] [PATCH v6 09/11] hw/pvrdma: Delete pvrdma_exit function

2019-03-11 Thread Yuval Shaia
This hook is not called and was implemented by mistake. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 04845f4..a4afced 100644 --- a/hw/rd

[Qemu-devel] [PATCH v4 5/10] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options

2019-03-11 Thread Unai Martinez-Corral
This breaks backward compatibility. Options 'qemu-path' and 'qemu-suffix' have the 'qemu-' prefix, which is not present in other option names ('debian', 'systemd', 'persistent', 'credential'...). In order to keep consistency, the prefix is removed. Signed-off-by: Unai Martinez-Corral Reviewed-by

[Qemu-devel] [PATCH v4 2/10] qemu-binfmt-conf.sh: make opts -p and -c boolean

2019-03-11 Thread Unai Martinez-Corral
This patch breaks backward compatibility. Both '--persistent' and '--credential' default to 'no'. Hence, '-p no' or '-c no' are reduntant. Overall, accepting an argument might be misleading because options are, indeed, boolean. This patch makes both options boolean in getopt, so if any of them is

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 03:29:41PM -0800, John G Johnson wrote: > > > > On Mar 7, 2019, at 11:27 AM, Stefan Hajnoczi wrote: > > > > On Thu, Mar 07, 2019 at 02:51:20PM +, Daniel P. Berrangé wrote: > >> I guess one obvious answer is that the existing security mechanisms like > >> SELinux/ApAr

[Qemu-devel] [PATCH v6 08/11] hw/pvrdma: Delete unneeded function argument

2019-03-11 Thread Yuval Shaia
The function's argument rdma_dev_res is not needed as it is stored in the backend_dev object at init. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 13 ++--- hw/rdma/rdma_backend.h | 1 - hw/rdma/vmw/pvrdma_qp_ops.c | 3 +-- 3 files ch

[Qemu-devel] [PATCH v6 10/11] hw/pvrdma: Unregister from shutdown notifier when device goes down

2019-03-11 Thread Yuval Shaia
This hook was installed to close the device when VM is going down. After the device is closed there is no need to be informed on VM shutdown. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/rdma/vmw/

Re: [Qemu-devel] [Qemu-block] [PATCH 2/8] block: Avoid useless local_err

2019-03-11 Thread Alberto Garcia
On Fri 08 Mar 2019 04:37:51 PM CET, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto

[Qemu-devel] [PATCH v6 02/11] hw/rdma: Introduce protected qlist

2019-03-11 Thread Yuval Shaia
To make code more readable move handling of protected list to a rdma_utils Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 20 +--- hw/rdma/rdma_backend_defs.h | 8 ++-- hw/rdma/rdma_utils.c| 39

[Qemu-devel] [PATCH v6 05/11] {hmp, hw/pvrdma}: Expose device internals via monitor interface

2019-03-11 Thread Yuval Shaia
Allow interrogating device internals through HMP interface. The exposed indicators can be used for troubleshooting by developers or sysadmin. There is no need to expose these attributes to a management system (e.x. libvirt) because (1) most of them are not "device-management' related info and (2) t

[Qemu-devel] [PATCH v4 0/10] qemu-binfmt-conf.sh

2019-03-11 Thread Unai Martinez-Corral
Hi, This series reworks qemu-binfmt-conf.sh: * Argument from option '--systemd' is generalized to , and it is accepted for any mode (default, debian or systemd). It can be a single target arch or a list of them. * Option '--clear' is added, which allows to remove an already registered targ

[Qemu-devel] [PATCH v6 11/11] hw/pvrdma: Provide correct value to object_get_typename

2019-03-11 Thread Yuval Shaia
Use base object of PCIDevice in call to object_get_typename(). Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 49bfbd6..0b46561 100644 --- a/hw/rdma/vmw/pvrdma

[Qemu-devel] [PATCH v6 04/11] hw/pvrdma: Collect debugging statistics

2019-03-11 Thread Yuval Shaia
Add counters to enable enhance debugging Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c| 70 +++ hw/rdma/rdma_rm.c | 7 + hw/rdma/rdma_rm_defs.h| 27 +- hw/rdma/vmw/pvrdma.h | 10 +++ hw/rdma/vmw/pvr

Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

2019-03-11 Thread Daniel P . Berrangé
On Sat, Mar 09, 2019 at 02:20:06AM +0100, Philippe Mathieu-Daudé wrote: > On 3/9/19 1:48 AM, Laszlo Ersek wrote: > > Repo: https://github.com/lersek/qemu.git > > Branch: edk2_build > > > > This series advances the roms/edk2 submodule to the "edk2-stable201903" > > release, and builds and capture

[Qemu-devel] [PATCH v6 00/11] Misc fixes to pvrdma device

2019-03-11 Thread Yuval Shaia
Hi, Please review the following patch-set which consist of cosmetics fixes to device's user interface (traces, error_report and monitor) and some bug fixes. Thanks Markus, Eric, Marcel and David for your review. Review is needed for patches 4 and 11 (new) v0 -> v1: * Explain why device attri

[Qemu-devel] [PATCH v4 10/10] qemu-binfmt-conf.sh: add --test|--dry-run

2019-03-11 Thread Unai Martinez-Corral
Signed-off-by: Unai Martinez-Corral --- scripts/qemu-binfmt-conf.sh | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index a516181a3a..db85798e76 100755 --- a/scripts/qemu-binfmt-conf.sh +++ b/scri

[Qemu-devel] [PATCH] configure: Remove old *-config-devices.mak.d files when running configure

2019-03-11 Thread Thomas Huth
When running "make" in a build directory from the pre-Kconfig merge time, the build process currently fails with: make: *** No rule to make target `.../default-configs/pci.mak', needed by `aarch64-softmmu/config-devices.mak'. Stop. To make sure that this problem at least goes away when the us

[Qemu-devel] [PATCH v6 01/11] hw/rdma: Switch to generic error reporting way

2019-03-11 Thread Yuval Shaia
Utilize error_report for all pr_err calls and some pr_dbg that are considered as errors. For the remaining pr_dbg calls, the important ones were replaced by trace points while other deleted. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c| 354 +++

  1   2   3   4   5   6   >