On Tue, Feb 19, 2019 at 03:42:36PM +0100, Christophe de Dinechin wrote:
>
>
> > On 19 Feb 2019, at 09:53, Yan Zhao wrote:
> >
> > If a device has device memory capability, save/load data from device memory
> > in pre-copy and stop-and-copy phases.
> >
> > LOGGING state is set for device memory
Forwarding from Debian bugreport http://bugs.debian.org/922612
18.02.2019 15:43, Marc Lehmann wrote:
Package: qemu-system
Version: 1:3.1+dfsg-4
Severity: normal
Dear Maintainer,
after upgrading to qemu 3.1 from stretch [from qemu 2.8 -- mjt], I found
that both linux and windows guests, when us
Forwarding from Debian bug report #919057,
http://bugs.debian.org/919057
Apparently there's some prob with qemu 3.1 GTK frontend and mouse pointer
visibility. Especially this part:
I have similar problems as the original reporter, specifically, after
upgrading to qemu 3.1 from stretch [fro
This patch adds EDID support to the vfio display (aka vgpu) code.
When supported by the mdev driver qemu will generate a EDID blob
and pass it on using the new vfio edid region. The EDID blob will
be updated on UI changes (i.e. window resize), so the guest can
adapt.
Signed-off-by: Gerd Hoffmann
The 5.0 linux kernel header update finally landed in master. So this
series has no unmerged dependencies any more. Rebasing and re-sending
for merge.
This series adds EDID support to the qemu vfio display code. Various
display-reladed information -- most importantly the display resolution
which
Kick the display link up event with a 0.1 sec delay,
so the guest has a chance to notice the link down first.
Signed-off-by: Gerd Hoffmann
---
include/hw/vfio/vfio-common.h | 1 +
hw/vfio/display.c | 26 +++---
2 files changed, 24 insertions(+), 3 deletions(-)
d
This allows configure the display resolution which the vgpu should use.
The information will be passed to the guest using EDID, so the mdev
driver must support the vfio edid region for this to work.
Signed-off-by: Gerd Hoffmann
---
hw/vfio/pci.h | 2 ++
hw/vfio/display.c | 16 ++
On Wed, 20 Feb 2019 14:22:19 +1100
David Gibson wrote:
> On Tue, Feb 19, 2019 at 06:17:58PM +0100, Greg Kurz wrote:
> > All DRC subtypes have been converted to generate the FDT fragment at
> > configure connector time instead of attach time. The fdt and fdt_offset
> > arguments of spapr_drc_attac
On 02/19/19 18:55, Markus Armbruster wrote:
> Stephen Checkoway writes:
>
>>> On Feb 19, 2019, at 10:28, Markus Armbruster wrote:
>>>
>>> My terminology might be confused...
>>>
>>> Let me backtrack a bit an explain my use case. On physical PCs, the
>>> single flash chip is commonly configured
20.02.2019 1:00, John Snow wrote:
>
>
> On 2/18/19 1:13 PM, Vladimir Sementsov-Ogievskiy wrote:
>> 14.02.2019 2:36, John Snow wrote:
>>> Signed-off-by: John Snow
>>> ---
>>>block/dirty-bitmap.c | 15 +
>>>block/qcow2-bitmap.c | 42 ++
On 2/19/19 9:06 PM, Alex Williamson wrote:
The entire link status register for SR-IOV VFs is defined as RsvdZ,
reads simply return zero. Usually this is nothing more than lspci
reporting inconsequentially broken values:
LnkSta: Speed unknown, Width x0, ...
However, now that we're using
On 18/02/2019 13:08, Vladimir Sementsov-Ogievskiy wrote:
> 14.02.2019 16:43, Andrey Shinkevich wrote:
>>
>>
>> On 12/02/2019 14:35, Alberto Garcia wrote:
>>> On Mon 11 Feb 2019 05:58:05 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>> The problem is in the concept of "base" node. The code writt
i see,
but is there a good reason why it did work with an older qemu version/machine
type (<= 2.6)
also my cpuinfo says physical bits 39 but i cannot use more maxmem than 222G
i attached the cpuinfo, cmdline, and debug logs for a nonworking invocation and
one for each working, with 222G, with ma
** Attachment added: "debug-working-novirtio-net.log"
https://bugs.launchpad.net/qemu/+bug/1685242/+attachment/5240137/+files/debug-working-novirtio-net.log
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.ne
** Attachment added: "debug-working-2.6.log"
https://bugs.launchpad.net/qemu/+bug/1685242/+attachment/5240136/+files/debug-working-2.6.log
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1685242
Ti
** Attachment added: "qemu-cmdline"
https://bugs.launchpad.net/qemu/+bug/1685242/+attachment/5240133/+files/qemu-cmdline
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1685242
Title:
ovmf hangs
** Attachment added: "debug-working-222G.log"
https://bugs.launchpad.net/qemu/+bug/1685242/+attachment/5240135/+files/debug-working-222G.log
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1685242
** Attachment added: "debug-nonworking.log"
https://bugs.launchpad.net/qemu/+bug/1685242/+attachment/5240134/+files/debug-nonworking.log
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1685242
Titl
** Attachment added: "qemu-cmdline"
https://bugs.launchpad.net/qemu/+bug/1685242/+attachment/5240132/+files/qemu-cmdline
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1685242
Title:
ovmf hangs
It will be used to store the uri parameters. We want this only for
tcp, so we don't set it for other uris. We need it to know what port
is migration running.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Juan Quintela
--
This used to be uri parameter, but it has so many troubles to
repro
In v13:
- Rename socket_address to socket_address_list (dave)
- Remove useless breaks (dave)
If nothing pops out, everything is reviewed and will be sent on next
pull requset.
Later, Juan.
In v12:
- drop multifd case (caming in next series)
- fix leak of socketaddress (eric)
- handle vsock print
"Dr. David Alan Gilbert (git)" wrote:
> From: "Dr. David Alan Gilbert"
>
> During a cancelled migration there's a race where the fd can
> go into an error state before we get back around the migration loop
> and migration_detect_error transitions from cancelling->failed.
>
> Check for cancelled/c
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 64 ++
1 file changed, 64 insertions(+)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 8352612364..b0670efde7 100644
--- a/tests/migration-test.c
+++ b/tes
Not sharing code from precopy/unix because we have to read back the
tcp parameter.
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 109 +++--
1 file changed, 104 insertions(+), 5 deletions(-
On Wed, 20 Feb 2019 02:02:25 +0100
Philippe Mathieu-Daudé wrote:
> This function takes size_t argument and return a size_t.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/char/terminal3270.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Reviewed-by: Cornelia Huck
On Wed, 20 Feb 2019 02:02:26 +0100
Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/s390x/ebcdic.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/hw/s390x/ebcdic.h b/include/hw/s390x/ebcdic.h
> index 69a04cab62..
On Wed, Feb 20, 2019 at 2:03 AM Philippe Mathieu-Daudé
wrote:
>
> IOWatchPoll::fd_can_read() really is a GSourceFunc type, it simply
> returns a boolean value.
> Update the backends to return a boolean, whether there is data to
> read from the source or not.
>
> Suggested-by: Paolo Bonzini
> Sign
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> It will be used to store the uri parameters. We want this only for
>> tcp, so we don't set it for other uris. We need it to know what port
>> is migration running.
>>
>> Signed-off-by: Juan Quintela
>>
>> --
>>
Signed-off-by: Gerd Hoffmann
---
ui/kbd-state.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/ui/kbd-state.c b/ui/kbd-state.c
index ac14add70e..09e3cfedfc 100644
--- a/ui/kbd-state.c
+++ b/ui/kbd-state.c
@@ -42,14 +42,18 @@ void qkbd_state_key_event(QKbdSta
Hi
On Wed, Feb 20, 2019 at 2:03 AM Philippe Mathieu-Daudé
wrote:
>
> The backend should not return a negative length to read.
> We will later change the prototype of IOCanReadHandler to return an
> unsigned length. Meanwhile make sure the return length is positive.
>
> Suggested-by: Paolo Bonzini
Hi all!
We have a very frequent pattern of creating coroutine from function
with several arguments:
- create structure to pack parameters
- create _entry function to call original function taking parameters
from struct
- do different magic to handle completion: set ret to NOT_DONE or
Hi,
On Wed, Feb 20, 2019 at 6:05 AM Richard Henderson
wrote:
>
> Based-on: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg02733.html
> aka the v3 ARMv8.5-MemTag patch set,
> or at least some of the early patches that split handle_msr_i.
>
> The v8.4 parts have been tested vs FVP, but th
On 2019/2/19 下午10:19, Michael S. Tsirkin wrote:
On Tue, Feb 19, 2019 at 02:27:35PM +0800, Jason Wang wrote:
On 2019/2/19 上午7:34, Michael S. Tsirkin wrote:
On Mon, Feb 18, 2019 at 10:49:08PM +0200, Yuri Benditovich wrote:
On Mon, Feb 18, 2019 at 6:39 PM Michael S. Tsirkin wrote:
On Mon, Feb
> On 20 Feb 2019, at 08:58, Zhao Yan wrote:
>
> On Tue, Feb 19, 2019 at 03:42:36PM +0100, Christophe de Dinechin wrote:
>>
>>
>>> On 19 Feb 2019, at 09:53, Yan Zhao wrote:
>>>
>>> If a device has device memory capability, save/load data from device memory
>>> in pre-copy and stop-and-copy
On Wed, Feb 20, 2019 at 11:02:35AM +0100, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> ui/kbd-state.c | 16 ++--
> 1 file changed, 10 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www.fl
Laszlo Ersek writes:
> On 02/19/19 18:55, Markus Armbruster wrote:
>> Stephen Checkoway writes:
>>
On Feb 19, 2019, at 10:28, Markus Armbruster wrote:
My terminology might be confused...
Let me backtrack a bit an explain my use case. On physical PCs, the
single f
Hi
On Wed, Feb 20, 2019 at 2:03 AM Philippe Mathieu-Daudé
wrote:
>
> TabletChardev::query is an array of uint8_t.
> Use the same type to hold it (this also silent a -Wsign-conversion
> warning in the trace function).
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
> -
On 20/02/2019 10.22, Juan Quintela wrote:
> Not sharing code from precopy/unix because we have to read back the
> tcp parameter.
>
> Reviewed-by: Dr. David Alan Gilbert
> Reviewed-by: Peter Xu
> Signed-off-by: Juan Quintela
> ---
> tests/migration-test.c | 109 +
* Kirti Wankhede (kwankh...@nvidia.com) wrote:
> Add migration support for VFIO device
Hi Kirti,
Can you explain how this compares and works with Yan Zhao's
set?
These look like two incompatible solutions to me - if that's
the case we need to take a step back and figure out how to combine
them
On 20/02/19 07:16, Thomas Huth wrote:
> By the way, what's the current status of the Kconfig series? Will there
> be another respin soon? ... the next softfreeze is not that far away ...
Waiting on the vhost series; I'll talk to Peter about merging it without
ARM and handling ARM later.
Paolo
Richard Henderson writes:
> Now setting, but not relying upon, env->hflags.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> v2: Fixed partial conversion to assignment to env->hflags.
> ---
> target/arm/internals.h | 1 +
> linux-user/syscall.c | 1 +
> tar
Richard Henderson writes:
> This is the payoff.
>
> From perf record -g data of ubuntu 18 boot and shutdown:
>
> BEFORE:
>
> - 23.02% 2.82% qemu-system-aar [.] helper_lookup_tb_ptr
>- 20.22% helper_lookup_tb_ptr
> + 10.05% tb_htable_lookup
> - 9.13% cpu_get_tb_cpu_state
On Wed, Feb 20, 2019 at 02:02:32AM +0100, Philippe Mathieu-Daudé wrote:
> diff --git a/include/chardev/char.h b/include/chardev/char.h
> index 0341dd1ba2..2e3b5a15ca 100644
> --- a/include/chardev/char.h
> +++ b/include/chardev/char.h
> @@ -221,7 +221,7 @@ void qemu_chr_set_feature(Chardev *chr,
>
Hi
On Wed, Feb 20, 2019 at 2:04 AM Philippe Mathieu-Daudé
wrote:
>
> In the previous commit we added an assert to be sure than
> qemu_chr_be_can_write() will never return a negative value.
> We can now change its prototype to return a size_t.
> Adapt the backends accordingly.
Each variable you c
Hi
On Wed, Feb 20, 2019 at 11:39 AM Daniel P. Berrangé wrote:
>
> On Wed, Feb 20, 2019 at 02:02:32AM +0100, Philippe Mathieu-Daudé wrote:
>
> > diff --git a/include/chardev/char.h b/include/chardev/char.h
> > index 0341dd1ba2..2e3b5a15ca 100644
> > --- a/include/chardev/char.h
> > +++ b/include/c
It fails to install homebrew. Since this is out of our control, mark
it as an expected failure.
Signed-off-by: Paolo Bonzini
---
.travis.yml | 8
1 file changed, 8 insertions(+)
diff --git a/.travis.yml b/.travis.yml
index baa06b976a..a7ab72b43b 100644
--- a/.travis.yml
+++ b/.travis.
It looks like something in netmap has changed and compilation fails:
install -D libnetmap.a //usr/local/lib/libnetmap.a
install: cannot stat libnetmap.a: No such file or directory
Add an explicit "make" step to fix it.
Signed-off-by: Paolo Bonzini
---
tests/docker/dockerfiles/debian-amd6
On 20/02/19 11:45, Paolo Bonzini wrote:
> It fails to install homebrew. Since this is out of our control, mark
> it as an expected failure.
>
> Signed-off-by: Paolo Bonzini
> ---
> .travis.yml | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index ba
It fails to install homebrew. Unfortunately we cannot mark
it as an expected failure because Travis does not match
allow_failures rows against include rows (only against the
main test matrix, which we do not use at all), so just disable
it.
Signed-off-by: Paolo Bonzini
---
.travis.yml | 15
On Wed, 20 Feb 2019 02:02:27 +0100
Philippe Mathieu-Daudé wrote:
> We will reuse this variable in the next patch.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/char/sclpconsole-lm.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/hw/char/sclpconsole-lm.c
On Wed, 20 Feb 2019 02:02:29 +0100
Philippe Mathieu-Daudé wrote:
> Since all callers provide an unsigned value, we can safely
> use a size_t argument.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/char/sclpconsole-lm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by
On Wed, 20 Feb 2019 02:02:28 +0100
Philippe Mathieu-Daudé wrote:
> Since it is unlikely we have sizeof(mdbo->mto.message) < 0,
> we can convert this variable to an unsigned type.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/char/sclpconsole-lm.c | 3 ++-
> 1 file changed, 2 insertions(
Hi
On Wed, Feb 20, 2019 at 2:02 AM Philippe Mathieu-Daudé
wrote:
>
> Hi,
>
> This series convert the chardev::qemu_chr_write() to take unsigned
> length argument. To do so I went through all caller and checked if
> there are no negative value possible.
Changing signedness is problematic and can
On Wed, 20 Feb 2019 11:53:42 +0100
Marc-André Lureau wrote:
> Hi
>
> On Wed, Feb 20, 2019 at 2:02 AM Philippe Mathieu-Daudé
> wrote:
> >
> > Hi,
> >
> > This series convert the chardev::qemu_chr_write() to take unsigned
> > length argument. To do so I went through all caller and checked if
> >
On Wed, Feb 20, 2019 at 2:04 AM Philippe Mathieu-Daudé
wrote:
>
> Since strlen() returns an unsigned value, it is pointless to
> convert it to a signed one. Use size_t to hold its return value.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
(it looks like the variable
* Zhao Yan (yan.y.z...@intel.com) wrote:
> On Tue, Feb 19, 2019 at 11:01:45AM +, Dr. David Alan Gilbert wrote:
> > * Yan Zhao (yan.y.z...@intel.com) wrote:
> > > +msi_data = qemu_get_be32(f);
> > > +vfio_pci_write_config(pdev,
> > > +pdev->msi_cap + (msi_64bit ? PCI_MSI_D
On Wed, Feb 20, 2019 at 2:04 AM Philippe Mathieu-Daudé
wrote:
>
> In put_packet_binary() we have:
>
> uint8_t *p;
> for(;;) {
> p = s->last_packet;
> *(p++) = ...
> s->last_packet_len = p - s->last_packet;
> put_buffer(s, (uint8_t *)s->last_packet, s->last_p
On Wed, Feb 20, 2019 at 2:04 AM Philippe Mathieu-Daudé
wrote:
>
> All callers provide a size_t argument, we can safely use size_t
> for this function.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
> ---
> gdbstub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 dele
On Wed, 20 Feb 2019 14:30:53 +1100
David Gibson wrote:
> On Tue, Feb 19, 2019 at 06:17:33PM +0100, Greg Kurz wrote:
> > This allows to hotplug/unplug PHBs. I could successfully test:
> > - using in-kernel XICS, emulated XICS and XIVE
> > - hotplug/unplug with e1000 device to validate LSIs
> > - h
On Wed, Feb 20, 2019 at 2:05 AM Philippe Mathieu-Daudé
wrote:
>
> VHOST_USER_HDR_SIZE uses offsetof(), thus is an expression of type
> size_t. Update the format string accordingly.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
> ---
> hw/virtio/vhost-user.c | 14 +++
On Wed, Feb 20, 2019 at 2:05 AM Philippe Mathieu-Daudé
wrote:
>
> The single caller of xencons_send(), con_event() already use the
> difference 'con->buffer.size - con->buffer.consumed'.
> Deduplicate by passing the difference as an argument.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-b
* Zhao Yan (yan.y.z...@intel.com) wrote:
> On Tue, Feb 19, 2019 at 11:32:13AM +, Dr. David Alan Gilbert wrote:
> > * Yan Zhao (yan.y.z...@intel.com) wrote:
> > > This patchset enables VFIO devices to have live migration capability.
> > > Currently it does not support post-copy phase.
> > >
> >
From: Liam Merwick
Signed-off-by: Liam Merwick
Message-id: 1549460216-25808-4-git-send-email-liam.merw...@oracle.com
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-xhci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 99b83aaa
On 2/20/19 11:03 AM, Marc-André Lureau wrote:
> Hi
>
> On Wed, Feb 20, 2019 at 2:03 AM Philippe Mathieu-Daudé
> wrote:
>>
>> The backend should not return a negative length to read.
>> We will later change the prototype of IOCanReadHandler to return an
>> unsigned length. Meanwhile make sure the
From: Liam Merwick
There is no need to calculate the 'eps' variable in usb_ep_get()
if 'ep' is the control endpoint. Instead the calculation should
be done after validating the input before returning an entry
indexed by the endpoint 'ep'.
Signed-off-by: Liam Merwick
Reviewed-by: Darren Kenny
Hi
On Wed, Feb 20, 2019 at 2:06 AM Philippe Mathieu-Daudé
wrote:
>
> The buffer.size and buffer.consumed fields are only updated within the
> buffer_append() body. We can simply let buffer_append() return the
> difference (the buffer consumed).
>
> Signed-off-by: Philippe Mathieu-Daudé
This is
From: Liam Merwick
In musb_packet(), the call to usb_find_device() can return NULL
if it doesn't find a device matching 'addr' so explicitly check
the return value before passing it to usb_ep_get(). This then
allows the subsequent calculation of 'id' to be streamlined.
Signed-off-by: Liam Merwi
The following changes since commit 2e68b8620637a4ee8c79b5724144b726af1e261b:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.0-20190219' into
staging (2019-02-18 16:20:13 +)
are available in the git repository at:
git://git.kraxel.org/qemu tags/usb-20190220-pu
From: Liam Merwick
A call to ohci_find_device() can return NULL if it doesn't find a
device matching 'addr' so for the two callers, explicitly check
the return value before passing it to usb_ep_get().
Signed-off-by: Liam Merwick
Message-id: 1549460216-25808-6-git-send-email-liam.merw...@oracle.
From: Liam Merwick
No caller of usb_ep_get() calls it with a NULL device (previous commits
have addressed the few remaining cases which didn't explicitly check).
Replace check for 'dev == NULL' with an assert instead.
Signed-off-by: Liam Merwick
Message-id: 1549460216-25808-10-git-send-email-li
From: Liam Merwick
Add an assert and an explicit check before the two callers to
usb_ep_get() in the USB redirector code to ensure the device
passed in is not NULL.
Signed-off-by: Liam Merwick
Message-id: 1549460216-25808-9-git-send-email-liam.merw...@oracle.com
Signed-off-by: Gerd Hoffmann
--
From: Liam Merwick
In ehci_process_itd(), the call to ehci_find_device() can return NULL
if it doesn't find a device matching 'devaddr' so explicitly check
the return value before passing it to usb_ep_get().
Signed-off-by: Liam Merwick
Message-id: 1549460216-25808-5-git-send-email-liam.merw...@
From: Liam Merwick
Most callers of xhci_port_update() and xhci_wakeup() pass in a pointer
to an array entry and can never be NULL but add two defensive asserts
to protect against future changes (e.g. adding a new port speed, etc.)
adding a path through xhci_lookup_port() that could result in the
From: Liam Merwick
In uhci_handle_td(), the call to ehci_find_device() can return NULL
if it doesn't find a device matching 'addr' so explicitly check
the return value before passing it to usb_ep_get().
Signed-off-by: Liam Merwick
Message-id: 1549460216-25808-7-git-send-email-liam.merw...@oracl
On Wed, Feb 20, 2019 at 2:06 AM Philippe Mathieu-Daudé
wrote:
>
> Both callers in hw/char/virtio-serial-bus.c provide unsigned values,
> even the trace event display an unsigned value.
> Convert the have_data() handler to take an unsigned value.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewe
> -Original Message-
> From: Qemu-devel
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Zhao Yan
> Sent: Thursday, January 10, 2019 9:19 AM
> To: Alex Williamson
> Cc: pbonz...@redhat.com; qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH] vfio: ass
Hi
On Wed, Feb 20, 2019 at 2:07 AM Philippe Mathieu-Daudé
wrote:
>
> Since iov_size() returns a size_t, no need to use a signed type.
And it is the variable only purpose.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
> ---
> net/filter-mirror.c | 2 +-
> 1 file
On Wed, Feb 20, 2019 at 2:06 AM Philippe Mathieu-Daudé
wrote:
>
> Avoid to use a signed type to hold an unsigned value.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
> ---
> hw/tpm/tpm_emulator.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> di
On 2/20/19 11:40 AM, Marc-André Lureau wrote:
> Hi
>
> On Wed, Feb 20, 2019 at 2:04 AM Philippe Mathieu-Daudé
> wrote:
>>
>> In the previous commit we added an assert to be sure than
>> qemu_chr_be_can_write() will never return a negative value.
>> We can now change its prototype to return a size
On 13/02/19 12:54, Thomas Huth wrote:
> This is very convenient for people like me who store their QEMU git trees
> on gitlab.com: Automatic CI pipelines are now run for each branch that is
> pushed to the server - useful for some extra-testing before sending PULL-
> requests for example. Since the
On Wed, Feb 20, 2019 at 12:13:45PM +0100, Gerd Hoffmann wrote:
> From: Liam Merwick
>
> Add an assert and an explicit check before the two callers to
> usb_ep_get() in the USB redirector code to ensure the device
> passed in is not NULL.
>
> Signed-off-by: Liam Merwick
> Message-id: 1549460216-
> -Original Message-
> From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
> Sent: Wednesday, February 20, 2019 7:02 PM
> To: Zhao Yan
> Cc: c...@nvidia.com; k...@vger.kernel.org; a...@ozlabs.ru;
> zhengxiao...@alibaba-inc.com; shuangtai@alibaba-inc.com;
> qemu-devel@nongnu.org
On 20/02/19 01:05, Philippe Mathieu-Daudé wrote:
> Some Linux specific code is missing guards, leading to
> build failure on OSX:
>
> $ sudo brew install libiscsi
> $ ./configure && make
> [...]
> CC block/iscsi.o
> qemu/block/iscsi.c:338:24: error: 'iscsi_aiocb_info' defined but
On 19/02/19 22:19, Viktor Prutyanov wrote:
> Before this patch, if elf2dmp failed to find NT kernel PE magic in
> allowed virtual address range, then it assumes NULL as NT kernel
> address and cause segfault.
>
> This patch fix the problem described above by checking NT kernel address
> before fut
On Wed, Feb 20, 2019 at 11:53:42AM +0100, Marc-André Lureau wrote:
> Hi
>
> On Wed, Feb 20, 2019 at 2:02 AM Philippe Mathieu-Daudé
> wrote:
> >
> > Hi,
> >
> > This series convert the chardev::qemu_chr_write() to take unsigned
> > length argument. To do so I went through all caller and checked if
On 2/20/19 11:42 AM, Marc-André Lureau wrote:
> Hi
>
> On Wed, Feb 20, 2019 at 11:39 AM Daniel P. Berrangé
> wrote:
>>
>> On Wed, Feb 20, 2019 at 02:02:32AM +0100, Philippe Mathieu-Daudé wrote:
>>
>>> diff --git a/include/chardev/char.h b/include/chardev/char.h
>>> index 0341dd1ba2..2e3b5a15ca 1
Thomas Huth writes:
> This is very convenient for people like me who store their QEMU git trees
> on gitlab.com: Automatic CI pipelines are now run for each branch that is
> pushed to the server - useful for some extra-testing before sending PULL-
> requests for example. Since the runtime of th
Paolo Bonzini writes:
> It fails to install homebrew. Unfortunately we cannot mark
> it as an expected failure because Travis does not match
> allow_failures rows against include rows (only against the
> main test matrix, which we do not use at all), so just disable
> it.
>
> Signed-off-by: Pa
On 2/20/19 10:40 AM, Cornelia Huck wrote:
> On Wed, 20 Feb 2019 02:02:26 +0100
> Philippe Mathieu-Daudé wrote:
>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> include/hw/s390x/ebcdic.h | 8
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/hw/s390x/ebcd
On Wed, 20 Feb 2019 11:28:46 +
"Gonglei (Arei)" wrote:
> > -Original Message-
> > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
> > Sent: Wednesday, February 20, 2019 7:02 PM
> > To: Zhao Yan
> > Cc: c...@nvidia.com; k...@vger.kernel.org; a...@ozlabs.ru;
> > zhengxiao...@
Hi yan,
Thanks for your work.
I have some suggestions or questions:
1) Would you add msix mode support,? if not, pls add a check in
vfio_pci_save_config(), likes Nvidia's solution.
2) We should start vfio devices before vcpu resumes, so we can't rely on vm
start change handler completely.
3) W
We send packages without pages sometimes for sysnchronizanion. The
iov functions do the right thing, but we will be changing this code in
future patches.
Signed-off-by: Juan Quintela
---
migration/ram.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/migr
Libvirt don't want to expose (and explain it). From now on we measure
the number of packages in bytes instead of pages, so it is the same
independently of architecture. We choose the page size of x86.
Notice that in the following patch we make this variable.
Signed-off-by: Juan Quintela
---
hm
We need to send this field when we add compression support. As we are
still on x- stage, we can do this kind of changes.
Signed-off-by: Juan Quintela
---
migration/ram.c| 15 +--
migration/trace-events | 4 ++--
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git
It really indicates what is the number of allocated pages for one
packet. Once there rename "used" to "pages_used".
Signed-off-by: Juan Quintela
---
migration/ram.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
in
v2:
- Measure packet size in bytes/not pages
- Change the defalut value from 64KB to 512KB
- rename used field to pages_used
- rename size field to pages_alloc
- Create nnext_packet_size field
Will be used on compression series later.
- Be flexible about what packet sizes we allow.
Please review
We set multifd-channels.
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Thomas Huth
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 48 ++
1 file changed, 48 insertions(+)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index a2
We moved from 64KB to 512KB, as it makes less locking contention
without any downside in testing.
Signed-off-by: Juan Quintela
---
migration/ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index 75a8fc21f8..d57db00ce4 100644
--- a/migra
This way we can change the packet size in the future and everything
will work. We choose an arbitrary big number (100 times configured
size) as a limit about how big we will reallocate.
Signed-off-by: Juan Quintela
---
migration/ram.c | 24 ++--
1 file changed, 18 insertions
We make it supported from now on.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Juan Quintela
---
hmp.c | 10 +-
migration/migration.c | 26 +-
qapi/migration.json | 34 +-
3 files changed, 35 insertions(+),
1 - 100 of 394 matches
Mail list logo
