Re: [Qemu-devel] [PATCH v3] i386, acpi: check acpi_memory_hotplug capacity in pre_plug

2019-02-19 Thread Wei Yang
On Tue, Feb 19, 2019 at 08:53:22AM +0800, Wei Yang wrote: >Currently we do device realization like below: > > hotplug_handler_pre_plug() > dc->realize() > hotplug_handler_plug() > >Before we do device realization and plug, we should allocate necessary >resources and check if memory-hotplug-su

[Qemu-devel] [PATCH v4] i386, acpi: check acpi_memory_hotplug capacity in pre_plug

2019-02-19 Thread Wei Yang
Currently we do device realization like below: hotplug_handler_pre_plug() dc->realize() hotplug_handler_plug() Before we do device realization and plug, we should allocate necessary resources and check if memory-hotplug-support property is enabled. At the piix4 and ich9, the memory-hotp

Re: [Qemu-devel] [RFC PATCH 3/4] spapr: Add NVDIMM device support

2019-02-19 Thread Igor Mammedov
On Tue, 05 Feb 2019 23:26:27 -0600 Shivaprasad G Bhat wrote: > Add support for NVDIMM devices for sPAPR. Piggyback on existing nvdimm > device interface in QEMU to support virtual NVDIMM devices for Power (May have > to re-look at this later). Create the required DT entries for the > device (som

Re: [Qemu-devel] [PATCH v4 07/11] virtio: fill/flush/pop for packed ring

2019-02-19 Thread Wei Xu
On Tue, Feb 19, 2019 at 02:49:42PM +0800, Jason Wang wrote: > > On 2019/2/18 下午10:46, Wei Xu wrote: > >>Do we allow chain more descriptors than vq size in the case of indirect? > >>According to the spec: > >> > >>" > >> > >>The device limits the number of descriptors in a list through a > >>transp

Re: [Qemu-devel] Key repeat is no longer working on TTY and grub menu

2019-02-19 Thread Gerd Hoffmann
On Wed, Feb 13, 2019 at 07:01:35AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Yes, this is another regression accidentally introduced by the keyboard > > state tracker. > > > > When GTK does key repeat it omits the Up event for repeated keys. > > > > IOW, you get > > > >

Re: [Qemu-devel] [PATCH v4 06/11] virtio: get avail bytes check for packed ring

2019-02-19 Thread Wei Xu
On Tue, Feb 19, 2019 at 02:24:11PM +0800, Jason Wang wrote: > > On 2019/2/19 上午1:07, Wei Xu wrote: > >On Mon, Feb 18, 2019 at 03:27:21PM +0800, Jason Wang wrote: > >>On 2019/2/14 下午12:26, w...@redhat.com wrote: > >>>From: Wei Xu > >>> > >>>Add packed ring headcount check. > >>> > >>>Common part o

Re: [Qemu-devel] [PATCH v1 0/1] Allow TAP to unnegotiate virtio-net header

2019-02-19 Thread Vincenzo Maffione
Il giorno mar 19 feb 2019 alle ore 07:48 Jason Wang ha scritto: > > On 2019/2/18 下午7:53, Vincenzo Maffione wrote: > > Hi Jason, > >Thanks for the quick reply. > > > > My PV device (to be open sourced soon) uses the QEMU net backend > interface, > > in a way similar to virtio-net. > > For exam

[Qemu-devel] [PATCH 01/14] MAINTAINERS: Add some missing entries for the sun4m machine

2019-02-19 Thread Thomas Huth
These files / devices are only used by SPARC machines, so we can sort them into the corresponding categories in the MAINTAINERS file. Cc: Mark Cave-Ayland Signed-off-by: Thomas Huth --- MAINTAINERS | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAIN

[Qemu-devel] [PATCH 03/14] MAINTAINERS: Add missing entries for the PC machines

2019-02-19 Thread Thomas Huth
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Signed-off-by: Thomas Huth --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index feb9095..2cc112c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[Qemu-devel] [PATCH 00/14] Various updates to the MAINTAINERS file

2019-02-19 Thread Thomas Huth
I recently noticed that we missed to include many updates to the MAINTAINERS file that have been posted to the qemu-devel mailing list within the last weeks. This patch series is now a collection of these patches, with some tweaks to some of them according to the discussions that have taken place a

[Qemu-devel] [PATCH 08/14] MAINTAINERS: Orphanize the 'GDB stub' subsystem

2019-02-19 Thread Thomas Huth
From: Philippe Mathieu-Daudé Nobody is looking at those files, downgrade this subsystem as orphan. Remove the qemu-devel@nongnu.org entry because the list is always selected by the 'All patches CC here' section. Suggested-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé Signed-off-

[Qemu-devel] [PATCH 04/14] MAINTAINERS: Add missing entries for the QObject section

2019-02-19 Thread Thomas Huth
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster Signed-off-by: Thomas Huth --- MAINTAINERS | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2cc112c..e7b4114 1006

[Qemu-devel] [PATCH 02/14] MAINTAINERS: Add missing entries for the sun4u machines

2019-02-19 Thread Thomas Huth
From: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7e4f70a..feb9095 100644 --- a/MAINTAINERS +++ b/

[Qemu-devel] [PATCH 09/14] MAINTAINERS: Add maintainers to the Linux subsystem

2019-02-19 Thread Thomas Huth
From: Philippe Mathieu-Daudé Add Michael, Cornelia and Paolo as maintainers of the Linux subsystem. Remove the qemu-devel@nongnu.org entry because the list is always selected by the 'All patches CC here' section. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Acked-by: Corn

[Qemu-devel] [PATCH 06/14] MAINTAINERS: Add an entry for the Dino machine

2019-02-19 Thread Thomas Huth
From: Philippe Mathieu-Daudé Add Richard as maintainer, and Helge as reviewer. Cc: Richard Henderson Cc: Helge Deller Signed-off-by: Philippe Mathieu-Daudé [thuth: Add the machine entry alphabetically] Signed-off-by: Thomas Huth --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+)

[Qemu-devel] [PATCH 11/14] MAINTAINERS: Clean up the RISC-V TCG backend section

2019-02-19 Thread Thomas Huth
The e-mail address m...@sifive.com of Micheal is not valid anymore. Commit 7d04ac38959f8115f2a02 removed the entry already from the main RISC-V section, but apparently forgot to remove it from the TCG backend section, too. Cc: Palmer Dabbelt Cc: Alistair Francis Fixes: 7d04ac38959f8115f2a029d81d

[Qemu-devel] [PATCH 05/14] MAINTAINERS: Add missing test entries to the Cryptography section

2019-02-19 Thread Thomas Huth
From: Philippe Mathieu-Daudé Acked-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e7b4114..59e4c8a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2065

[Qemu-devel] [PATCH 07/14] MAINTAINERS: Add maintainer to the POSIX subsystem

2019-02-19 Thread Thomas Huth
From: Philippe Mathieu-Daudé Add Paolo as maintainer of the POSIX subsystem. Remove the qemu-devel@nongnu.org entry because the list is always selected by the 'All patches CC here' section. Cc: Paolo Bonzini Suggested-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé Signed-off-by:

Re: [Qemu-devel] [RFC PATCH 06/11] qcow2: Don't assume 0 is an invalid cluster offset

2019-02-19 Thread Kevin Wolf
Am 19.02.2019 um 00:13 hat Max Reitz geschrieben: > On 31.01.19 18:55, Kevin Wolf wrote: > > The cluster allocation code uses 0 as an invalid offset that is used in > > case of errors or as "offset not yet determined". With external data > > files, a host cluster offset of 0 becomes valid, though.

[Qemu-devel] [PATCH 10/14] MAINTAINERS: Add maintainer to the TCG/i386 subsystem

2019-02-19 Thread Thomas Huth
From: Philippe Mathieu-Daudé Richard obviously maintains this subdirectory, make this official :) Remove the qemu-devel@nongnu.org entry because the list is always selected by the 'All patches CC here' section. Cc: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Thomas

Re: [Qemu-devel] nonzero LUN on USB Bulk Only Transfer fails with QEMU+edk2

2019-02-19 Thread Gerd Hoffmann
Hi, > (2) If I change the cmdline to "lun=5", then the exchange is: Not supported (by the usb protocol). The protocol has a control message to query the number of devices (grep for GetMaxLun in qemu). LUNs are not allowed to be sparse. So, with a single storage device the LUN must be zero.

[Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-19 Thread Yan Zhao
This patchset enables VFIO devices to have live migration capability. Currently it does not support post-copy phase. It follows Alex's comments on last version of VFIO live migration patches, including device states, VFIO device state region layout, dirty bitmap's query. Device Data --- D

Re: [Qemu-devel] [PATCH 10/10] hw/arm hw/xtensa: De-duplicate pflash creation code some

2019-02-19 Thread Max Filippov
On Mon, Feb 18, 2019 at 5:07 AM Markus Armbruster wrote: > > pflash_cfi01_register() creates a TYPE_CFI_PFLASH01 device, sets > properties, realizes, and wires up. > > We have three modified copies of it, because their users need to set > additional properties, or have the wiring done differently.

[Qemu-devel] [PATCH 3/5] vfio/migration: tracking of dirty page in system memory

2019-02-19 Thread Yan Zhao
register the log_sync interface to hook into ram's live migration callbacks. ram_save_pending |->migration_bitmap_sync |->memory_global_dirty_log_sync |->memory_region_sync_dirty_bitmap |->listener->log_sync(listener, &mrs); So, the dirty page produced by vfio

[Qemu-devel] [PATCH 1/5] vfio/migration: define kernel interfaces

2019-02-19 Thread Yan Zhao
- defined 4 device states regions: one control region and 3 data regions - defined layout of control region in struct vfio_device_state_ctl - defined 4 device states: running, stop, running&logging, stop&logging - define 3 device data categories: device config, device memory, system memory - defi

Re: [Qemu-devel] [RFC PATCH 08/11] qcow2: Add basic data-file infrastructure

2019-02-19 Thread Kevin Wolf
Am 19.02.2019 um 00:57 hat Max Reitz geschrieben: > On 31.01.19 18:55, Kevin Wolf wrote: > > This adds a .bdrv_open option to specify the external data file node. > > > > Signed-off-by: Kevin Wolf > > --- > > qapi/block-core.json | 3 ++- > > block/qcow2.h| 4 +++- > > block/qcow2.c

[Qemu-devel] [PATCH 5/5] vfio/migration: support device memory capability

2019-02-19 Thread Yan Zhao
If a device has device memory capability, save/load data from device memory in pre-copy and stop-and-copy phases. LOGGING state is set for device memory for dirty page logging: in LOGGING state, get device memory returns whole device memory snapshot; outside LOGGING state, get device memory return

Re: [Qemu-devel] [PATCH v6 09/18] hw/arm/virt: Implement kvm_type function for 4.0 machine

2019-02-19 Thread Auger Eric
Hi Igor, On 2/19/19 8:49 AM, Igor Mammedov wrote: > On Mon, 18 Feb 2019 22:29:40 +0100 > Auger Eric wrote: > >> Hi Peter, >> >> On 2/14/19 6:29 PM, Peter Maydell wrote: >>> On Tue, 5 Feb 2019 at 17:33, Eric Auger wrote: This patch implements the machine class kvm_type() callback. >>

[Qemu-devel] [PATCH 4/5] vfio/migration: turn on migration

2019-02-19 Thread Yan Zhao
init vfio migration in vfio_realize() and register migraton blocker if failure met. finalize all migration resources when vfio_instance_finalize(). Signed-off-by: Yan Zhao Signed-off-by: Yulei Zhang --- hw/vfio/pci.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/h

[Qemu-devel] [PATCH 2/5] vfio/migration: support device of device config capability

2019-02-19 Thread Yan Zhao
Device config is the default data that every device should have. so device config capability is by default on, no need to set. - Currently two type of resources are saved/loaded for device of device config capability: General PCI config data, and Device config data. They are copies as a whol

Re: [Qemu-devel] nonzero LUN on USB Bulk Only Transfer fails with QEMU+edk2

2019-02-19 Thread Laszlo Ersek
On 02/19/19 09:49, Gerd Hoffmann wrote: > Hi, > >> (2) If I change the cmdline to "lun=5", then the exchange is: > > Not supported (by the usb protocol). > > The protocol has a control message to query the number of devices (grep > for GetMaxLun in qemu). LUNs are not allowed to be sparse. S

Re: [Qemu-devel] [RFC PATCH 10/11] qcow2: Store data file name in the image

2019-02-19 Thread Kevin Wolf
Am 19.02.2019 um 01:18 hat Max Reitz geschrieben: > On 31.01.19 18:55, Kevin Wolf wrote: > > Rather than requiring that the external data file node is passed > > explicitly when creating the qcow2 node, store the filename in the > > designated header extension during .bdrv_create and read it from t

Re: [Qemu-devel] Failing iotests in CI (was: Add a gitlab-ci file for Continuous Integration testing on Gitlab)

2019-02-19 Thread Thomas Huth
On 19/02/2019 08.53, Kevin Wolf wrote: > Am 19.02.2019 um 07:44 hat Thomas Huth geschrieben: >> On 18/02/2019 19.22, Cleber Rosa wrote: >>> >>> >>> On 2/13/19 6:54 AM, Thomas Huth wrote: This is very convenient for people like me who store their QEMU git trees on gitlab.com: Automatic CI

[Qemu-devel] [Bug 1816052] Re: qemu system emulator fails to start if no sound card is present on host

2019-02-19 Thread Gerd Hoffmann
What happens if you remove "try-alsa" from the configure line? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1816052 Title: qemu system emulator fails to start if no sound card is present on host

Re: [Qemu-devel] [RFC PATCH 11/11] qcow2: Add data file to ImageInfoSpecificQCow2

2019-02-19 Thread Kevin Wolf
Am 19.02.2019 um 01:47 hat Max Reitz geschrieben: > On 31.01.19 18:55, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > qapi/block-core.json | 1 + > > block/qcow2.c| 6 +- > > 2 files changed, 6 insertions(+), 1 deletion(-) > > [...] > > > diff --git a/block/qcow2.c b/bl

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-19 Thread Gerd Hoffmann
On Mon, Feb 11, 2019 at 04:19:14AM +0100, BALATON Zoltan wrote: > At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI > gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and > guests running on these and the PMON2000 firmware of the fulong2e > expect this to be available.

Re: [Qemu-devel] [PATCH v11 7/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2019-02-19 Thread Wang, Wei W
On Friday, December 14, 2018 7:17 PM, Dr. David Alan Gilbert wrote: > > On 12/14/2018 05:56 PM, Dr. David Alan Gilbert wrote: > > > * Wei Wang (wei.w.w...@intel.com) wrote: > > > > On 12/13/2018 11:45 PM, Dr. David Alan Gilbert wrote: > > > > > * Wei Wang (wei.w.w...@intel.com) wrote: > > > > > > T

Re: [Qemu-devel] [RFC PATCH 3/4] spapr: Add NVDIMM device support

2019-02-19 Thread Shivaprasad G Bhat
On 02/19/2019 01:41 PM, Igor Mammedov wrote: On Tue, 05 Feb 2019 23:26:27 -0600 Shivaprasad G Bhat wrote: Add support for NVDIMM devices for sPAPR. Piggyback on existing nvdimm device interface in QEMU to support virtual NVDIMM devices for Power (May have to re-look at this later). Create

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] ppc: add host-serial and host-model machine attributes

2019-02-19 Thread Daniel P . Berrangé
On Tue, Feb 19, 2019 at 12:21:04PM +1100, David Gibson wrote: > On Mon, Feb 18, 2019 at 11:52:18AM +, Daniel P. Berrangé wrote: > > On Mon, Feb 18, 2019 at 12:38:11PM +0100, Greg Kurz wrote: > > > On Mon, 18 Feb 2019 15:42:18 +0530 > > > P J P wrote: > > > > > > > From: Prasad J Pandit > > >

Re: [Qemu-devel] [PATCH v4 07/11] virtio: fill/flush/pop for packed ring

2019-02-19 Thread Jason Wang
On 2019/2/19 下午4:21, Wei Xu wrote: On Tue, Feb 19, 2019 at 02:49:42PM +0800, Jason Wang wrote: On 2019/2/18 下午10:46, Wei Xu wrote: Do we allow chain more descriptors than vq size in the case of indirect? According to the spec: " The device limits the number of descriptors in a list through

Re: [Qemu-devel] [PATCH v1 0/1] Allow TAP to unnegotiate virtio-net header

2019-02-19 Thread Jason Wang
On 2019/2/19 下午4:28, Vincenzo Maffione wrote: Il giorno mar 19 feb 2019 alle ore 07:48 Jason Wang ha scritto: On 2019/2/18 下午7:53, Vincenzo Maffione wrote: Hi Jason, Thanks for the quick reply. My PV device (to be open sourced soon) uses the QEMU net backend interface, in a way simil

Re: [Qemu-devel] [PULL 00/43] ppc-for-4.0 queue 20190219

2019-02-19 Thread Peter Maydell
available in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-4.0-20190219 > > for you to fetch changes up to 73e14c6a9cdefb94c01ea488f04e7fba7ac0dc5b: > > target/ppc: convert vmin* and vmax* t

Re: [Qemu-devel] Failing iotests in CI (was: Add a gitlab-ci file for Continuous Integration testing on Gitlab)

2019-02-19 Thread Kevin Wolf
Am 19.02.2019 um 10:04 hat Thomas Huth geschrieben: > On 19/02/2019 08.53, Kevin Wolf wrote: > > Am 19.02.2019 um 07:44 hat Thomas Huth geschrieben: > >> On 18/02/2019 19.22, Cleber Rosa wrote: > >>> > >>> > >>> On 2/13/19 6:54 AM, Thomas Huth wrote: > This is very convenient for people like m

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-19 Thread Peter Maydell
On Tue, 12 Feb 2019 at 23:59, BALATON Zoltan wrote: > > Hello, > > On Tue, 12 Feb 2019, Philippe Mathieu-Daudé wrote: > > Hi Zoltan, > > Thanks for the quick review and testing. I'll use your suggestions for the > other (mips) patches in a v2. For this one I'm not convinced. > > > On 2/11/19 4:19

Re: [Qemu-devel] Failing iotests in CI (was: Add a gitlab-ci file for Continuous Integration testing on Gitlab)

2019-02-19 Thread Thomas Huth
On 19/02/2019 10.37, Kevin Wolf wrote: > Am 19.02.2019 um 10:04 hat Thomas Huth geschrieben: >> On 19/02/2019 08.53, Kevin Wolf wrote: [...] >>> Which are the cases that fail for you with '--disable-tcg'? >> >> These tests are failing: 087 169 188 232 235 238 > > Hm, 087 and 232 just do something

[Qemu-devel] [PATCH] audio: don't use alsa by default

2019-02-19 Thread Gerd Hoffmann
In case no sound hardware is present the driver initializes successfully and throws errors later on, i.e. effectively the automatic probing doesn't work. So the driver should not be used by default (until that is fixed). Drop the can_be_default flag. Explicitly picking the alsa driver (using QEM

Re: [Qemu-devel] [PATCH v2 2/6] block/dirty-bitmaps: rename frozen predicate helper

2019-02-19 Thread Vladimir Sementsov-Ogievskiy
19.02.2019 1:32, John Snow wrote: > > > On 2/18/19 8:57 AM, Vladimir Sementsov-Ogievskiy wrote: >> 14.02.2019 2:23, John Snow wrote: >>> "Frozen" was a good description a long time ago, but it isn't adequate now. >>> Rename the frozen predicate to has_successor to make the semantics of the >>> pr

Re: [Qemu-devel] [PATCH 04/12] io: Make qio_channel_yield() interruptible

2019-02-19 Thread Kevin Wolf
Am 18.02.2019 um 18:11 hat Paolo Bonzini geschrieben: > On 18/02/19 17:18, Kevin Wolf wrote: > > Similar to how qemu_co_sleep_ns() allows to be preempted by an external > > coroutine entry, allow reentering qio_channel_yield() early. > > > > Signed-off-by: Kevin Wolf > > --- > > include/io/chann

Re: [Qemu-devel] [PATCH] iotests: handle TypeError for Python3 in test 242

2019-02-19 Thread Vladimir Sementsov-Ogievskiy
18.02.2019 22:59, Andrey Shinkevich wrote: > To write one byte to disk, Python2 may use 'chr' type. > In Python3, conversion to 'byte' type is required. > > Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy Forget to say to Andrey that we should add Reported-by: Kevin

Re: [Qemu-devel] [PATCH] audio: don't use alsa by default

2019-02-19 Thread David Hildenbrand
On 19.02.19 11:15, Gerd Hoffmann wrote: > ardware is present the driver initializes > successfully and throws errors later on, i.e. effectively the > automatic probing doesn't work. So the driver should not be > used by default (until that is fixed). Drop the can_be_default > flag. > > Explicitl

Re: [Qemu-devel] [PATCH 2/4] nbd/client: do negotiation in coroutine

2019-02-19 Thread Vladimir Sementsov-Ogievskiy
12.02.2019 0:38, Eric Blake wrote: > On 2/11/19 6:55 AM, Vladimir Sementsov-Ogievskiy wrote: >> As a first step to non-blocking negotiation, move it to coroutine. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> nbd/client.c | 123 +-- >>

Re: [Qemu-devel] [PATCH 3/4] nbd: do qemu_coroutine_yield during tls handshake

2019-02-19 Thread Vladimir Sementsov-Ogievskiy
12.02.2019 0:55, Eric Blake wrote: > On 2/11/19 6:56 AM, Vladimir Sementsov-Ogievskiy wrote: >> We always call qio_channel_tls_handshake in nbd from couroutine. Take >> benefit of it and just yield instead of creating personal main loop. >> >> Mark and rename the function and it's callers correspon

Re: [Qemu-devel] [PATCH v4 08/11] virtio: event suppression support for packed ring

2019-02-19 Thread Wei Xu
On Tue, Feb 19, 2019 at 03:19:58PM +0800, Jason Wang wrote: > > On 2019/2/14 下午12:26, w...@redhat.com wrote: > >From: Wei Xu > > > >Difference between 'avail_wrap_counter' and 'last_avail_wrap_counter': > >For Tx(guest transmitting), they are the same after each pop of a desc. > > > >For Rx(guest

Re: [Qemu-devel] Failing qemu-iotest 233

2019-02-19 Thread Daniel P . Berrangé
On Tue, Feb 19, 2019 at 07:36:07AM +0100, Thomas Huth wrote: > > Hi Eric, hi Daniel, > > QEMU iotest 233 is failing for me on RHEL7: > > 233[07:29:30] [07:29:30] [failed, exit status 1] - output > mismatch (see 233.out.bad) > --- /home/thuth/devel/qemu/tests/qemu-iotests/233.ou

Re: [Qemu-devel] Object instantiation vs. device realization: what to do when?

2019-02-19 Thread Igor Mammedov
On Thu, 14 Feb 2019 17:58:06 +0100 Paolo Bonzini wrote: > On 14/02/19 17:21, Markus Armbruster wrote: > > * As an interim step, the #DeviceState:realized property can also be > > * set with qdev_init_nofail(). > > * In the future, devices will propagate this state change to their children > >

Re: [Qemu-devel] [PATCH v4 09/11] virtio-net: update the head descriptor in a chain lastly

2019-02-19 Thread Wei Xu
On Tue, Feb 19, 2019 at 03:23:01PM +0800, Jason Wang wrote: > > On 2019/2/14 下午12:26, w...@redhat.com wrote: > >From: Wei Xu > > > >This is a helper for packed ring. > > > >To support packed ring, the head descriptor in a chain should be updated > >lastly since no 'avail_idx' like in packed ring

Re: [Qemu-devel] [PATCH 2/5] vfio/migration: support device of device config capability

2019-02-19 Thread Dr. David Alan Gilbert
* Yan Zhao (yan.y.z...@intel.com) wrote: > Device config is the default data that every device should have. so > device config capability is by default on, no need to set. > > - Currently two type of resources are saved/loaded for device of device > config capability: > General PCI config data

Re: [Qemu-devel] [PATCH v4 10/11] virtio: migration support for packed ring

2019-02-19 Thread Wei Xu
On Tue, Feb 19, 2019 at 03:30:41PM +0800, Jason Wang wrote: > > On 2019/2/14 下午12:26, w...@redhat.com wrote: > >From: Wei Xu > > > >Both userspace and vhost-net/user are supported with this patch. > > > >A new subsection is introduced for packed ring, only 'last_avail_idx' > >and 'last_avail_wrap

Re: [Qemu-devel] [PATCH v3 4/6] vfio-ccw: add capabilities chain

2019-02-19 Thread Cornelia Huck
On Fri, 15 Feb 2019 10:46:08 -0500 Eric Farman wrote: > On 01/30/2019 08:22 AM, Cornelia Huck wrote: > > Allow to extend the regions used by vfio-ccw. The first user will be > > handling of halt and clear subchannel. > > > > Signed-off-by: Cornelia Huck > > --- > > drivers/s390/cio/vfio_ccw_o

Re: [Qemu-devel] Failing iotests in CI (was: Add a gitlab-ci file for Continuous Integration testing on Gitlab)

2019-02-19 Thread Daniel P . Berrangé
On Tue, Feb 19, 2019 at 10:37:16AM +0100, Kevin Wolf wrote: > Am 19.02.2019 um 10:04 hat Thomas Huth geschrieben: > > > > https://gitlab.com/huth/qemu/-/jobs/163680780 > > > > Some of them apparently need encryption to be enabled (as already > > mentioned by Cleber in his patch) - thus should th

Re: [Qemu-devel] [PATCH 1/4] target/arm: Split out recompute_hflags et al

2019-02-19 Thread Alex Bennée
Richard Henderson writes: > We will use these to minimize the computation for every call to > cpu_get_tb_cpu_state. For now, the env->hflags variable is not used. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 22 +++- > target/arm/helper.h| 3 + > target/arm/in

[Qemu-devel] [Bug 1808928] Re: Bitmap Extra data is not supported

2019-02-19 Thread Ali Sag
Sorry, because of log time, VM logs were removed. Journalctl for libvirtd is remain.. It was like that. 018-12-17 17:01:50.990+: 43198: error : qemuMonitorIORead:606 : Unable to read from monitor: Connection reset by peer Dec 17 20:01:50 vm-kvm09 libvirtd[43198]: 2018-12-17 17:01:50.991+:

Re: [Qemu-devel] [PATCH 07/12] nbd: Increase bs->in_flight during AioContext switch

2019-02-19 Thread Kevin Wolf
Am 18.02.2019 um 18:22 hat Paolo Bonzini geschrieben: > On 18/02/19 17:18, Kevin Wolf wrote: > > +/* aio_ctx_switch is only supposed to be set if we're sitting > > in > > + * the qio_channel_yield() below. */ > > +assert(!*aio_ctx_switch); > > bdrv_

Re: [Qemu-devel] [PATCH] audio: don't use alsa by default

2019-02-19 Thread Daniel P . Berrangé
On Tue, Feb 19, 2019 at 11:15:10AM +0100, Gerd Hoffmann wrote: > In case no sound hardware is present the driver initializes > successfully and throws errors later on, i.e. effectively the > automatic probing doesn't work. So the driver should not be > used by default (until that is fixed). Drop

Re: [Qemu-devel] [PATCH] audio: don't use alsa by default

2019-02-19 Thread Daniel P . Berrangé
On Tue, Feb 19, 2019 at 11:39:49AM +0100, David Hildenbrand wrote: > On 19.02.19 11:15, Gerd Hoffmann wrote: > > ardware is present the driver initializes > > successfully and throws errors later on, i.e. effectively the > > automatic probing doesn't work. So the driver should not be > > used by d

Re: [Qemu-devel] [PATCH 11/12] block: Use normal drain for bdrv_set_aio_context()

2019-02-19 Thread Kevin Wolf
Am 18.02.2019 um 21:57 hat Eric Blake geschrieben: > On 2/18/19 10:18 AM, Kevin Wolf wrote: > > Now that bdrv_set_aio_context() works inside drained sections, it can > > also use the real drain function instead of open coding something > > similar. > > > > Signed-off-by: Kevin Wolf > > --- > > b

Re: [Qemu-devel] [PATCH 5/5] vfio/migration: support device memory capability

2019-02-19 Thread Dr. David Alan Gilbert
* Yan Zhao (yan.y.z...@intel.com) wrote: > If a device has device memory capability, save/load data from device memory > in pre-copy and stop-and-copy phases. > > LOGGING state is set for device memory for dirty page logging: > in LOGGING state, get device memory returns whole device memory snapsh

Re: [Qemu-devel] [PATCH] audio: don't use alsa by default

2019-02-19 Thread David Hildenbrand
On 19.02.19 12:17, Daniel P. Berrangé wrote: > On Tue, Feb 19, 2019 at 11:39:49AM +0100, David Hildenbrand wrote: >> On 19.02.19 11:15, Gerd Hoffmann wrote: >>> ardware is present the driver initializes >>> successfully and throws errors later on, i.e. effectively the >>> automatic probing doesn't

Re: [Qemu-devel] [PATCH v4 11/11] virtio: CLI and provide packed ring feature bit by default

2019-02-19 Thread Wei Xu
On Tue, Feb 19, 2019 at 03:32:19PM +0800, Jason Wang wrote: > > On 2019/2/14 下午12:26, w...@redhat.com wrote: > >From: Wei Xu > > > >Add userspace and vhost kernel/user support. > > > >Add CLI "ring_packed=true/false" to enable/disable packed ring provision. > >Usage: > > -device virtio-net-pc

Re: [Qemu-devel] Failing iotests in CI (was: Add a gitlab-ci file for Continuous Integration testing on Gitlab)

2019-02-19 Thread Kevin Wolf
Am 19.02.2019 um 12:06 hat Daniel P. Berrangé geschrieben: > On Tue, Feb 19, 2019 at 10:37:16AM +0100, Kevin Wolf wrote: > > Am 19.02.2019 um 10:04 hat Thomas Huth geschrieben: > > > > > > https://gitlab.com/huth/qemu/-/jobs/163680780 > > > > > > Some of them apparently need encryption to be ena

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-19 Thread Dr. David Alan Gilbert
* Yan Zhao (yan.y.z...@intel.com) wrote: > This patchset enables VFIO devices to have live migration capability. > Currently it does not support post-copy phase. > > It follows Alex's comments on last version of VFIO live migration patches, > including device states, VFIO device state region layou

Re: [Qemu-devel] [Qemu-ppc] [PATCH 04/10] sam460ex: Don't size flash memory to match backing image

2019-02-19 Thread BALATON Zoltan
On Tue, 19 Feb 2019, Markus Armbruster wrote: BALATON Zoltan writes: On Mon, 18 Feb 2019, Markus Armbruster wrote: BALATON Zoltan writes: On Mon, 18 Feb 2019, Markus Armbruster wrote: Machine "sam460ex" maps its flash memory at address 0xFFF0. When no image is supplied, its size is 1Mi

Re: [Qemu-devel] [PATCH v4 07/11] virtio: fill/flush/pop for packed ring

2019-02-19 Thread Wei Xu
On Tue, Feb 19, 2019 at 05:33:57PM +0800, Jason Wang wrote: > > On 2019/2/19 下午4:21, Wei Xu wrote: > >On Tue, Feb 19, 2019 at 02:49:42PM +0800, Jason Wang wrote: > >>On 2019/2/18 下午10:46, Wei Xu wrote: > Do we allow chain more descriptors than vq size in the case of indirect? > According t

Re: [Qemu-devel] Failing iotests in CI (was: Add a gitlab-ci file for Continuous Integration testing on Gitlab)

2019-02-19 Thread Kevin Wolf
Am 19.02.2019 um 11:11 hat Thomas Huth geschrieben: > On 19/02/2019 10.37, Kevin Wolf wrote: > > Am 19.02.2019 um 10:04 hat Thomas Huth geschrieben: > >> On 19/02/2019 08.53, Kevin Wolf wrote: > [...] > >>> Which are the cases that fail for you with '--disable-tcg'? > >> > >> These tests are failin

[Qemu-devel] [PATCH] qemu-img: fix error reporting for -object

2019-02-19 Thread Daniel P . Berrangé
Error reporting for user_creatable_add_opts_foreach was changed so that it no longer called 'error_report_err' in: commit 7e1e0c11127bde81cff260fc6859690435c509d6 Author: Markus Armbruster Date: Wed Oct 17 10:26:43 2018 +0200 qom: Clean up error reporting in user_creatable_add_opts_f

[Qemu-devel] [PATCH] iotests: drop unnecessary accel=kvm

2019-02-19 Thread Stefan Hajnoczi
Tests 235 and 238 do not require the kvm accelerator. TCG works fine. Use the default accelerator instead of requiring kvm. Suggested-by: Thomas Huth Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/235 | 1 - tests/qemu-iotests/238 | 1 - 2 files changed, 2 deletions(-) diff --git a/te

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-19 Thread BALATON Zoltan
On Tue, 19 Feb 2019, Gerd Hoffmann wrote: On Mon, Feb 11, 2019 at 04:19:14AM +0100, BALATON Zoltan wrote: At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and guests running on these and the PMON2000 firmware of the

Re: [Qemu-devel] Failing iotests in CI (was: Add a gitlab-ci file for Continuous Integration testing on Gitlab)

2019-02-19 Thread Daniel P . Berrangé
On Tue, Feb 19, 2019 at 12:31:41PM +0100, Kevin Wolf wrote: > Am 19.02.2019 um 12:06 hat Daniel P. Berrangé geschrieben: > > On Tue, Feb 19, 2019 at 10:37:16AM +0100, Kevin Wolf wrote: > > > Am 19.02.2019 um 10:04 hat Thomas Huth geschrieben: > > > > > > > > https://gitlab.com/huth/qemu/-/jobs/16

Re: [Qemu-devel] [PATCH] iotests: drop unnecessary accel=kvm

2019-02-19 Thread Thomas Huth
On 19/02/2019 12.59, Stefan Hajnoczi wrote: > Tests 235 and 238 do not require the kvm accelerator. TCG works fine. > > Use the default accelerator instead of requiring kvm. > > Suggested-by: Thomas Huth > Signed-off-by: Stefan Hajnoczi > --- > tests/qemu-iotests/235 | 1 - > tests/qemu-iotes

Re: [Qemu-devel] Failing iotests in CI (was: Add a gitlab-ci file for Continuous Integration testing on Gitlab)

2019-02-19 Thread Daniel P . Berrangé
On Tue, Feb 19, 2019 at 12:01:28PM +, Daniel P. Berrangé wrote: > On Tue, Feb 19, 2019 at 12:31:41PM +0100, Kevin Wolf wrote: > > Am 19.02.2019 um 12:06 hat Daniel P. Berrangé geschrieben: > > > On Tue, Feb 19, 2019 at 10:37:16AM +0100, Kevin Wolf wrote: > > > > Am 19.02.2019 um 10:04 hat Thoma

Re: [Qemu-devel] [PATCH] hw/rdma: another clang compilation fix

2019-02-19 Thread Marcel Apfelbaum
Hi Philippe, On 2/19/19 12:05 AM, Philippe Mathieu-Daudé wrote: On 2/17/19 8:51 AM, Marcel Apfelbaum wrote: Cc:qemu-sta...@nongnu.org I doubt this is a security issue worth Cc'ing qemu-stable :) I thought it worth adding a compilation fix to the stable branch. Thanks, Marcel Thanks, Ma

Re: [Qemu-devel] Failing iotests in CI (was: Add a gitlab-ci file for Continuous Integration testing on Gitlab)

2019-02-19 Thread Thomas Huth
On 19/02/2019 12.38, Kevin Wolf wrote: > Am 19.02.2019 um 11:11 hat Thomas Huth geschrieben: >> On 19/02/2019 10.37, Kevin Wolf wrote: >>> Am 19.02.2019 um 10:04 hat Thomas Huth geschrieben: On 19/02/2019 08.53, Kevin Wolf wrote: [...] >> 169 got killed via abort(): >> >> 169[0

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-19 Thread BALATON Zoltan
On Tue, 19 Feb 2019, Peter Maydell wrote: On Tue, 12 Feb 2019 at 23:59, BALATON Zoltan wrote: On Tue, 12 Feb 2019, Philippe Mathieu-Daudé wrote: On 2/11/19 4:19 AM, BALATON Zoltan wrote: [...] + +static void ati_reg_write_offs(uint32_t *reg, int offs, + uint64_t

Re: [Qemu-devel] [PATCH] iotests: drop unnecessary accel=kvm

2019-02-19 Thread Vladimir Sementsov-Ogievskiy
19.02.2019 15:02, Thomas Huth wrote: > On 19/02/2019 12.59, Stefan Hajnoczi wrote: >> Tests 235 and 238 do not require the kvm accelerator. TCG works fine. >> >> Use the default accelerator instead of requiring kvm. >> >> Suggested-by: Thomas Huth >> Signed-off-by: Stefan Hajnoczi >> --- >> te

Re: [Qemu-devel] [PATCH] audio: don't use alsa by default

2019-02-19 Thread Gerd Hoffmann
On Tue, Feb 19, 2019 at 11:39:49AM +0100, David Hildenbrand wrote: > On 19.02.19 11:15, Gerd Hoffmann wrote: > > ardware is present the driver initializes > > successfully and throws errors later on, i.e. effectively the > > automatic probing doesn't work. So the driver should not be > > used by d

Re: [Qemu-devel] [PATCH] qemu-img: fix error reporting for -object

2019-02-19 Thread Philippe Mathieu-Daudé
On 2/19/19 12:46 PM, Daniel P. Berrangé wrote: > Error reporting for user_creatable_add_opts_foreach was changed so that > it no longer called 'error_report_err' in: > > commit 7e1e0c11127bde81cff260fc6859690435c509d6 > Author: Markus Armbruster > Date: Wed Oct 17 10:26:43 2018 +0200 > >

Re: [Qemu-devel] Failing iotests in CI (was: Add a gitlab-ci file for Continuous Integration testing on Gitlab)

2019-02-19 Thread Kevin Wolf
Am 19.02.2019 um 13:01 hat Daniel P. Berrangé geschrieben: > On Tue, Feb 19, 2019 at 12:31:41PM +0100, Kevin Wolf wrote: > > Am 19.02.2019 um 12:06 hat Daniel P. Berrangé geschrieben: > > > On Tue, Feb 19, 2019 at 10:37:16AM +0100, Kevin Wolf wrote: > > > > Am 19.02.2019 um 10:04 hat Thomas Huth ge

Re: [Qemu-devel] [PATCH 01/14] MAINTAINERS: Add some missing entries for the sun4m machine

2019-02-19 Thread Philippe Mathieu-Daudé
On 2/19/19 9:36 AM, Thomas Huth wrote: > These files / devices are only used by SPARC machines, so we can sort > them into the corresponding categories in the MAINTAINERS file. > > Cc: Mark Cave-Ayland > Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 7 +

Re: [Qemu-devel] [PATCH] audio: don't use alsa by default

2019-02-19 Thread Daniel P . Berrangé
On Tue, Feb 19, 2019 at 01:12:58PM +0100, Gerd Hoffmann wrote: > On Tue, Feb 19, 2019 at 11:39:49AM +0100, David Hildenbrand wrote: > > On 19.02.19 11:15, Gerd Hoffmann wrote: > > > ardware is present the driver initializes > > > successfully and throws errors later on, i.e. effectively the > > > a

Re: [Qemu-devel] [PATCH 09/14] MAINTAINERS: Add maintainers to the Linux subsystem

2019-02-19 Thread Philippe Mathieu-Daudé
On 2/19/19 9:36 AM, Thomas Huth wrote: > From: Philippe Mathieu-Daudé > > Add Michael, Cornelia and Paolo as maintainers of the Linux subsystem. > > Remove the qemu-devel@nongnu.org entry because the list is always > selected by the 'All patches CC here' section. > > Suggested-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: remove check on pc-dimm hotpluggable

2019-02-19 Thread Philippe Mathieu-Daudé
On 2/19/19 7:07 AM, Wei Yang wrote: > Function acpi_memory_plug_cb() is only invoked when dev is a PCDIMM, > which is hotpluggable. This means it is not necessary to check this > property again. > > This patch removes this check. > > Signed-off-by: Wei Yang > --- > hw/acpi/memory_hotplug.c | 4

Re: [Qemu-devel] [PATCH 12/14] hw/arm/musca: Add MPCs

2019-02-19 Thread Peter Maydell
On Thu, 14 Feb 2019 at 12:51, Peter Maydell wrote: > > The Musca board puts its SRAM and flash behind TrustZone > Memory Protection Controllers (MPCs). Each MPC sits between > the CPU and the RAM/flash, and also has a set of memory mapped > control registers. Wire up the MPCs, and the memory behin

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: remove check on pc-dimm hotpluggable

2019-02-19 Thread Philippe Mathieu-Daudé
On 2/19/19 7:07 AM, Wei Yang wrote: > Function acpi_memory_plug_cb() is only invoked when dev is a PCDIMM, > which is hotpluggable. This means it is not necessary to check this > property again. > > This patch removes this check. > > Signed-off-by: Wei Yang > --- > hw/acpi/memory_hotplug.c | 4

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-19 Thread Gerd Hoffmann
Hi, > > Which linux driver is this? > > Those in linux/drivers/video/fbdev/aty/. This ati-vga model defaults to Rage > 128 Pro (what PoweMac3,1 has, device id 0x5046) which is handled by the > aty128fb driver under Linux. MIPS fulong2e has Mobility Radeon M6 (RV100, > device id 0x5159) that you

Re: [Qemu-devel] [PATCH] audio: don't use alsa by default

2019-02-19 Thread Gerd Hoffmann
> > So SDL has the same problem (possibly only when using alsa). > > > > Hmm. Dropping can_be_default here will too break sound on BSD ... > > We could temporarily put the Linux default ordering back to have "oss" > before sdl/alsa until the initialization code in sdl/alsa can be fixed to > corr

Re: [Qemu-devel] [PATCH 2/2] pc-dimm: remove realize callback

2019-02-19 Thread Philippe Mathieu-Daudé
On 2/19/19 7:07 AM, Wei Yang wrote: > PCDIMM's realize callback is introduced to do proper setup for NVDIMM. > > Currently the NVDIMM setup task is nvdimm_prepare_memory_region(), which > is done in pre_plug stage. This means related task has already been done > at realize point. > > This patch r

Re: [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand

2019-02-19 Thread Philippe Mathieu-Daudé
On 2/18/19 1:56 PM, Markus Armbruster wrote: > PFLASH_BUG()'s lone use has a suspicious smell: it prints "Possible > BUG", which sounds like a warning, then calls exit(1), followed by > unreachable goto reset_flash. All this commit does is expanding the > macro, so the smell becomes more poignant,

Re: [Qemu-devel] [PATCH 03/10] hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}

2019-02-19 Thread Philippe Mathieu-Daudé
On 2/18/19 1:56 PM, Markus Armbruster wrote: > We have two open-coded copies of macro CFI_PFLASH01(). Move the macro > to the header, so we can ditch the copies. Move CFI_PFLASH02() to the > header for symmetry. > > We define macros TYPE_CFI_PFLASH01 and TYPE_CFI_PFLASH02 for type name > strings

[Qemu-devel] [PATCH v2] audio: don't build alsa and sdl by default on linux

2019-02-19 Thread Gerd Hoffmann
In case no sound hardware is present both alsa and sdl drivers initialize successfully and throw errors later on, i.e. effectively the automatic probing doesn't work. Drop them from the list of default audio drivers for linux because of that. Fixes: 6a48541873 audio: probe audio drivers by defaul

Re: [Qemu-devel] [PATCH 1/4] io/channel: add qio_channel_get_attached_aio_context()

2019-02-19 Thread Vladimir Sementsov-Ogievskiy
12.02.2019 13:33, Daniel P. Berrangé wrote: > On Mon, Feb 11, 2019 at 03:55:58PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Expose attached aio context. It will be used in nbd code, to >> understand, in which aio context negotiation should be done. > > I'm not especially objecting to the idea o

  1   2   3   4   5   >