On Wed, Jan 30, 2019 at 02:37:01PM +, Liam Merwick wrote:
> There is no need to calculate the 'eps' variable in usb_ep_get()
> if 'ep' is the control endpoint. Instead the calculation should
> be done after validating the input and the resulting pointer also
> validated before returning an ent
From: Paolo Bonzini
Make hw/vfio configurable and add new CONFIG_VFIO_* to the
default-configs/s390x*-softmmu.mak. This allow a finer-grain
selection of the various VFIO backends.
Signed-off-by: Paolo Bonzini
---
default-configs/arm-softmmu.mak | 2 ++
default-configs/pci.mak | 2
On 2019-01-31 08:32, Yang Zhong wrote:
> From: Paolo Bonzini
>
> This is not needed on ARM, and brings in ISA bus code which is otherwise not
> necessary.
>
> Signed-off-by: Paolo Bonzini
> ---
> hw/ide/Makefile.objs | 4 +--
> hw/ide/core.c| 25 -
> hw/ide/ioport.c
On Wed, Jan 30, 2019 at 02:37:02PM +, Liam Merwick wrote:
> From: Liam Merwick
>
> usb_ep_get() can return a Null pointer in the (albeit unlikely) case
> that a NULL USBDevice is passed in via the 'dev' parameter.
That should never ever happen.
> Reported by the Parfait static code analysis
Use git archive to create tarballs of qemu and submodules instead of
cloning the repository and the submodules. This is a order of magnitude
faster because it doesn't fetch the submodules from the internet each
time the script runs.
Signed-off-by: Gerd Hoffmann
---
Notes:
v2: don't run git
30.01.2019 22:58, John Snow wrote:
>
>
> On 1/30/19 8:58 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Hi!
>>
>> I have a question about job_pause_point. Now a good job of moving generic
>> things about
>> block-jobs to job.c is done..
>>
>> job_pause_point do visible job-state change, as changing
31.01.2019 4:01, John Snow wrote:
> The meaning of the states has changed subtly over time,
> this should bring the understanding more in-line with the
> current, actual usages.
>
> Reported-by: Eric Blake
> Signed-off-by: John Snow
> ---
> block/dirty-bitmap.c | 19 +--
> qap
On 2019-01-31 08:32, Yang Zhong wrote:
> Change the CONFIGs for PCI EXPRESS and make module name more
> clear for code files.
>
> Signed-off-by: Yang Zhong
> Cc: Michael S. Tsirkin
> Signed-off-by: Paolo Bonzini
> ---
> default-configs/arm-softmmu.mak | 4 ++--
> default-configs/i386-soft
Laszlo Ersek writes:
> On 01/30/19 15:33, Paolo Bonzini wrote:
>> On 30/01/19 15:13, Markus Armbruster wrote:
>>> -global driver=cfi.pflash01,property=secure,value=on
>>>
>>> Affects *all* such devices, but fortunately we have at most two, and
>>> the one we don't want to affect happens to ig
On 2019-01-31 08:32, Yang Zhong wrote:
> make virt code configurable and the new CONFIG_VIRT definitions
> added to the default-configs/arm-softmmu.mak to replace CONFIG_ACPI
> in arm board.
I think the patch description needs a refresh. It's CONFIG_ARM_VIRT now,
and CONFIG_ACPI is not replaced an
On 2019-01-31 08:32, Yang Zhong wrote:
> From: Paolo Bonzini
>
> Make hw/s390x configurable and add new CONFIG_* to the
> default-configs/s390x*-softmmu.mak. This will be used to
> enable/disable vfio-ccw.
>
> Signed-off-by: Paolo Bonzini
> ---
> default-configs/s390x-softmmu.mak | 1 +
> hw/s
Paolo Bonzini writes:
> On 30/01/19 15:13, Markus Armbruster wrote:
>> -global driver=cfi.pflash01,property=secure,value=on
>>
>> Affects *all* such devices, but fortunately we have at most two, and the
>> one we don't want to affect happens to ignore the property value.
>
> Is this true? I
On 2019-01-31 08:32, Yang Zhong wrote:
> Add the new configs to default-configs/riscv*-sofmmu.mak.
>
> Signed-off-by: Yang Zhong
> Signed-off-by: Paolo Bonzini
> Reviewed-by: Alistair Francis
> ---
> default-configs/riscv32-softmmu.mak | 7 +++
> default-configs/riscv64-softmmu.mak | 7 +
On Thu, Jan 31, 2019 at 09:36:01AM +0100, Thomas Huth wrote:
> On 2019-01-31 08:32, Yang Zhong wrote:
> > make virt code configurable and the new CONFIG_VIRT definitions
> > added to the default-configs/arm-softmmu.mak to replace CONFIG_ACPI
> > in arm board.
>
> I think the patch description need
On 2019-01-31 08:32, Yang Zhong wrote:
> From: Paolo Bonzini
>
> Make hw/vfio configurable and add new CONFIG_VFIO_* to the
> default-configs/s390x*-softmmu.mak. This allow a finer-grain
> selection of the various VFIO backends.
>
> Signed-off-by: Paolo Bonzini
> ---
> default-configs/arm-sof
Peter Maydell writes:
> On Wed, 30 Jan 2019 at 16:44, Laszlo Ersek wrote:
>>
>> On 01/30/19 16:24, Peter Maydell wrote:
>>
>> > Well, nobody who does anything with x86 has cared enough to
>> > make the pflash implementation actually correct.
>>
>> I feel sort of included under this umbrella, so:
Am 31.01.2019 um 03:03 hat John Snow geschrieben:
> On 1/30/19 12:27 PM, Kevin Wolf wrote:
> > Am 14.01.2019 um 17:25 hat Eric Blake geschrieben:
> >> From: John Snow
> >>
> >> New interface, new smoke test.
> >>
> >> Signed-off-by: John Snow
> >> Reviewed-by: Vladimir Sementsov-Ogievskiy
> >> R
Am 31.01.2019 um 00:52 hat Max Reitz geschrieben:
> Without this filter, this test sometimes fails.
>
> Signed-off-by: Max Reitz
Thanks, applied to the block branch.
Kevin
Am 31.01.2019 um 03:26 hat John Snow geschrieben:
> It's not enough to order the kwargs for consistent QMP log output,
> we must also sort any sub-dictionaries in lists that appear as values.
>
> Reported-by: Kevin Wolf
> Signed-off-by: John Snow
Thanks, applied to the block branch.
Kevin
On 30.01.19 23:10, Michael S. Tsirkin wrote:
> On Wed, Jan 30, 2019 at 04:07:06PM +0100, David Hildenbrand wrote:
>> On 30.01.19 14:09, Paolo Bonzini wrote:
>>> On 30/01/19 13:35, David Hildenbrand wrote:
On 14.12.18 10:58, Paolo Bonzini wrote:
> On 12/12/18 10:57, David Hildenbrand wrote:
On 31/01/19 09:33, Markus Armbruster wrote:
> I thought secure=on affected only writes (and so wouldn't matter with
> readonly=on), but I was wrong:
>
> static MemTxResult pflash_mem_read_with_attrs(void *opaque, hwaddr addr,
> uint64_t *value,
>
On 31/01/19 09:40, Markus Armbruster wrote:
>> Maybe we should just add pflash block properties to the machine? And
>> then it can create the devices if the properties are set to a non-empty
>> value.
> What exactly do you have in mind? Something like
>
> -machine q35,ovmf-code=OVMF-CODE-NOD
On 30.01.19 20:52, Collin Walling wrote:
> On 1/21/19 8:42 AM, David Hildenbrand wrote:
>> PCI on s390x is really weird and how it was modeled in QEMU might not have
>> been the right choice. Anyhow, right now it is the case that:
>> - Hotplugging a PCI device will silently create a zPCI device
>>
Paolo Bonzini writes:
> On 31/01/19 09:33, Markus Armbruster wrote:
>> I thought secure=on affected only writes (and so wouldn't matter with
>> readonly=on), but I was wrong:
>>
>> static MemTxResult pflash_mem_read_with_attrs(void *opaque, hwaddr addr,
>> uint64_t *value,
>>
Paolo Bonzini writes:
> On 31/01/19 09:40, Markus Armbruster wrote:
>>> Maybe we should just add pflash block properties to the machine? And
>>> then it can create the devices if the properties are set to a non-empty
>>> value.
>> What exactly do you have in mind? Something like
>>
>> -mac
30.01.2019 22:26, Andrey Shinkevich wrote:
>
>
> On 30/01/2019 21:24, Eric Blake wrote:
>> On 1/30/19 11:51 AM, Andrey Shinkevich wrote:
>>> In the 'Format specific information' section of the 'qemu-img info'
>>> command output, the supplemental information about existing QCOW2
[...]
>>> +##
>>
On Wed, 30 Jan 2019 at 08:23, Igor Mammedov wrote:
>
> On Tue, 29 Jan 2019 15:26:29 +
> Peter Maydell wrote:
> > Oh, I see now. I think this is a bug in boot.c and we should
> > fix it by making the "this is a firmware boot" code path also
> > do the arm_load_dtb() call. I'll send a patch.
>
On Wed, 30 Jan 2019 21:36:04 -0200
Murilo Opsfelder Araujo wrote:
> Unfold parts of qemu_ram_mmap() for the sake of understanding, moving
> declarations to the top, and keeping architecture-specifics in the
> ifdef-else blocks. No changes in the function behaviour.
>
> Give ptr and ptr1 meaning
On Thu, 31 Jan 2019 at 06:39, Thomas Huth wrote:
>
> On 2019-01-30 20:01, Palmer Dabbelt wrote:
> > On Wed, 30 Jan 2019 09:45:33 PST (-0800), ebl...@redhat.com wrote:
> >> On 1/30/19 11:35 AM, Palmer Dabbelt wrote:
> >>> The following changes since commit
> >>> 5385a5988c8a55bebdc878c05b96648579b5
On Wed, 30 Jan 2019 21:36:05 -0200
Murilo Opsfelder Araujo wrote:
> The commit 7197fb4058bcb68986bae2bb2c04d6370f3e7218 ("util/mmap-alloc:
> fix hugetlb support on ppc64") fixed Huge TLB mappings on ppc64.
>
> However, we still need to consider the underlying huge page size
> during munmap() bec
On Thu, 31 Jan 2019 at 08:52, Markus Armbruster wrote:
> Lesson for the future: when we correct something, but don't dare to
> touch (some) existing uses (being not "reasonably sure it doesn't
> actually break guests that used to work"), we should at least have
> enough sense to make "incorrect" o
On 31/01/19 10:41, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
>> On 31/01/19 09:40, Markus Armbruster wrote:
Maybe we should just add pflash block properties to the machine? And
then it can create the devices if the properties are set to a non-empty
value.
>>> What exactly
31.01.2019 5:26, John Snow wrote:
> It's not enough to order the kwargs for consistent QMP log output,
> we must also sort any sub-dictionaries in lists that appear as values.
>
> Reported-by: Kevin Wolf
> Signed-off-by: John Snow
> ---
> tests/qemu-iotests/236.out| 56 +---
On 1/31/19 3:37 AM, Cleber Rosa wrote:
> On 1/22/19 11:07 AM, Alex Bennée wrote:
>> Cleber Rosa writes:
>>
>>> Just like the previous tests, boots a Linux kernel on a ppc64 target
>>> using the pseries machine.
>>
>> So running this on my rather slow SynQuacer I get:
>>
>> (04/16)
>> /home/alex/
On 1/31/19 2:26 AM, Cleber Rosa wrote:
> On 1/22/19 5:19 AM, Philippe Mathieu-Daudé wrote:
>> Hi Cleber,
>>
>> On 1/17/19 7:56 PM, Cleber Rosa wrote:
>>> Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta
>>> board and verify the serial is working.
>>>
>>> If mips64el is a target b
Peter Maydell writes:
> On Thu, 31 Jan 2019 at 08:52, Markus Armbruster wrote:
>> Lesson for the future: when we correct something, but don't dare to
>> touch (some) existing uses (being not "reasonably sure it doesn't
>> actually break guests that used to work"), we should at least have
>> enou
On 1/31/19 2:34 AM, Cleber Rosa wrote:
> On 1/22/19 5:57 AM, Philippe Mathieu-Daudé wrote:
>> On 1/17/19 7:56 PM, Cleber Rosa wrote:
>>> Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta
>>> board and verify the serial is working.
>>>
>>> If mips64el is a target being built, "make
On Thu, Jan 31, 2019 at 08:41:43AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > +git archive --format tar $HEAD > "$tar_file"
> > > +test $? -ne 0 && error "failed to archive qemu"
> > > for sm in $submodules; do
> > > -git submodule update --init $sm
> > > -test $? -ne 0 && error "failed
On 1/31/19 3:53 AM, Cleber Rosa wrote:
> On 1/22/19 5:52 AM, Philippe Mathieu-Daudé wrote:
>> On 1/17/19 7:56 PM, Cleber Rosa wrote:
>>> Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta
>>> board and verify the serial is working. One extra command added to
>>> the QEMU command l
On Thu, 31 Jan 2019 at 10:24, Markus Armbruster wrote:
> 1. Make the device model default to some "correct" configuration, even
> if that setting is kind of arbitrary. That way, any code using new
> style gets an "incorrect" configuration only if it actively selects one.
I don't think that's muc
On Thu, Jan 31, 2019 at 02:45:13PM +1100, Adam Baxter wrote:
> Hi,
> How do I gather and include the required DLLs (SDL, zlib etc) in the NSIS
> installer? (and also in a standalone build to be zipped up, but that's less
> important)
>
> I noticed the wiki doesn't really mention bundling dependenc
My extremely embarassing script for getting the DLLs is as follows,
but at least it avoids a WINE dependency:
STAGING=/tmp/myqemu/
make install prefix=$STAGING
#todo: probably better to walk these dependencies in a loop, and not
use grep (but seriously, where's the mingw dumpbin)
FIRST=$(strings $
On 1/25/19 3:00 PM, Alex Bennée wrote:
> This allows us to invoke the build with a custom target (for the VMs
> that use the {target} format string specifier). Currently OpenBSD is
> still hardwired due to problems running check.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
On 1/25/19 3:00 PM, Alex Bennée wrote:
> Now the underlying basevm support passes these along we can expose
> some additional variables to our Makefile to allow more customised
> tweaking of the build. For example:
>
> make vm-build-freebsd TARGET_LIST=aarch64-softmmu \
> EXTRA_CONFIGURE_OPT
On 1/25/19 3:00 PM, Alex Bennée wrote:
> The "make check" target calls check-qtest which has the appropriate
> system binaries as dependencies so we shouldn't need to do two steps
> of make invocation. Doing it in two steps was a hangover from when our
> make check couldn't run tests in parallel.
>
After testing a recent commit of QEMU I noticed that 256 color support is
missing in Mac OS 9's color options. A lot of games refuse to run without being
able to set the monitor to 256 colors. Could we have this option added?
Thank you.
On Mon, 28 Jan 2019 at 19:38, Eduardo Habkost wrote:
>
> The following changes since commit 5f39a91dbd9a186edb999afd4d17524f4b1da14f:
>
> Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into
> staging (2019-01-28 12:54:06 +)
>
> are available in the Git repository at:
>
On Thu, 31 Jan 2019 at 10:50, Daniel P. Berrangé wrote:
>
> On Thu, Jan 31, 2019 at 02:45:13PM +1100, Adam Baxter wrote:
> > Hi,
> > How do I gather and include the required DLLs (SDL, zlib etc) in the NSIS
> > installer? (and also in a standalone build to be zipped up, but that's less
> > importa
The arm_boot_info struct has a skip_dtb_autoload flag: if this is
set to true by the board code then arm_load_kernel() will not
load the DTB itself, but will leave this for the board code to
do itself later. However, the check for this is done in a
code path which is only executed for the case wher
Fix the block comment style in arm_load_kernel() to QEMU's
current style preferences. This will allow us to do some
refactoring of this function without checkpatch complaining
about the code-motion patches.
Signed-off-by: Peter Maydell
---
hw/arm/boot.c | 30 --
1 fil
The arm_boot_info struct has a skip_dtb_autoload flag: if this is
set to true by the board code then arm_load_kernel() will not
load the DTB itself, but will leave this for the board code to
do itself later. However, the check for this is done in a
code path which is only executed for the case wher
Factor out the "direct kernel boot" code path from arm_load_kernel()
into its own function; this function is getting long enough that
the code flow is a bit confusing.
This commit only moves code around; no semantic changes.
We leave the "load the dtb" code in arm_load_kernel() -- this
is current
Factor out the "boot via firmware" code path from arm_load_kernel()
into its own function.
This commit only moves code around; no semantic changes.
Signed-off-by: Peter Maydell
---
hw/arm/boot.c | 92 +++
1 file changed, 49 insertions(+), 43 delet
The code path for booting firmware doesn't set env->boot_info. At
first sight this looks odd, so add a comment saying why we don't.
Signed-off-by: Peter Maydell
---
hw/arm/boot.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index a2e724ac68a
On Thu, Jan 31, 2019 at 11:19:04AM +, Peter Maydell wrote:
> On Thu, 31 Jan 2019 at 10:50, Daniel P. Berrangé wrote:
> >
> > On Thu, Jan 31, 2019 at 02:45:13PM +1100, Adam Baxter wrote:
> > > Hi,
> > > How do I gather and include the required DLLs (SDL, zlib etc) in the NSIS
> > > installer? (
Hi,
Sorry for resurrecting this thread after so long but I just upgraded the host
to Qemu 3.1 and libvirt 4.10 and I'm still facing this problem.
At the moment I cannot use virtio disks (virtio-blk nor virtio-scsi) with my
guests in order to avoid this issue so as a workaround I'm using SATA emu
On Wed, 30 Jan 2019 19:51:27 +0100
Halil Pasic wrote:
> On Wed, 30 Jan 2019 14:22:07 +0100
> Cornelia Huck wrote:
>
> > When we get a solicited interrupt, the start function may have
> > been cleared by a csch, but we still have a channel program
> > structure allocated. Make it safe to call th
On Wed, 30 Jan 2019 18:09:31 +0100
Halil Pasic wrote:
> On Wed, 30 Jan 2019 14:22:12 +0100
> Cornelia Huck wrote:
>
> > +static void fsm_async_retry(struct vfio_ccw_private *private,
> > + enum vfio_ccw_event event)
> > +{
> > + private->cmd_region->ret_code = -EAGAIN;
>
On 01/31/19 10:19, Paolo Bonzini wrote:
> On 31/01/19 09:40, Markus Armbruster wrote:
>>> Maybe we should just add pflash block properties to the machine? And
>>> then it can create the devices if the properties are set to a non-empty
>>> value.
>> What exactly do you have in mind? Something like
On Wed, 30 Jan 2019 at 08:59, Hongbo Zhang wrote:
>
> On Tue, 22 Jan 2019 at 19:42, Peter Maydell wrote:
> >
> > On Fri, 7 Dec 2018 at 09:08, Hongbo Zhang wrote:
> > > +[VIRT_SECURE_MEM] = { 0x2000, 0x2000 },
> > > +[VIRT_CPUPERIPHS] = { 0x4000, 0x0008 },
On 01/31/19 10:37, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
>> On 31/01/19 09:33, Markus Armbruster wrote:
>>> I thought secure=on affected only writes (and so wouldn't matter with
>>> readonly=on), but I was wrong:
>>>
>>> static MemTxResult pflash_mem_read_with_attrs(void *opaque,
On Mon, 28 Jan 2019 at 19:43, Eduardo Habkost wrote:
>
> The following changes since commit 5f39a91dbd9a186edb999afd4d17524f4b1da14f:
>
> Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into
> staging (2019-01-28 12:54:06 +)
>
> are available in the Git repository at:
>
Peter Maydell writes:
> On Thu, 31 Jan 2019 at 10:24, Markus Armbruster wrote:
>> 1. Make the device model default to some "correct" configuration, even
>> if that setting is kind of arbitrary. That way, any code using new
>> style gets an "incorrect" configuration only if it actively selects o
On 31/01/19 10:37, Markus Armbruster wrote:
>>
>>> Hmm, why is it okay to treat all pfl->cmd values the same when
>>> secure=on?
>> But doesn't matter. You just don't want MMIO mode to be active outside
>> SMM: all that non-SMM code want to do with the flash is read and execute
>> it, as far as th
Paolo Bonzini writes:
> On 31/01/19 10:41, Markus Armbruster wrote:
>> Paolo Bonzini writes:
>>
>>> On 31/01/19 09:40, Markus Armbruster wrote:
> Maybe we should just add pflash block properties to the machine? And
> then it can create the devices if the properties are set to a non-emp
From: mahaocong
This patch adds possibility to start mirroring with user-created-bitmap.
On full mode, mirror create a non-named-bitmap by scanning whole block-chain,
and on top mode, mirror create a bitmap by scanning the top block layer. So I
think I can copy a user-created-bitmap and use it as
On Thu, 31 Jan 2019 12:52:20 +0100
Cornelia Huck wrote:
> On Wed, 30 Jan 2019 19:51:27 +0100
> Halil Pasic wrote:
>
> > On Wed, 30 Jan 2019 14:22:07 +0100
> > Cornelia Huck wrote:
> >
> > > When we get a solicited interrupt, the start function may have
> > > been cleared by a csch, but we sti
The cmd() method of the QEMUQtestProtocol class sends a qtest command
to QEMU but doesn't wait for the return message ("OK", "FAIL", "ERR").
Because of this, it can return control to the caller before the
command has actually finished.
In cases like clock_step or clock_set this means that cmd() ca
On Thu, Jan 31, 2019 at 12:12 PM Programmingkid
wrote:
> After testing a recent commit of QEMU I noticed that 256 color support is
> missing in Mac OS 9's color options. A lot of games refuse to run without
> being able to set the monitor to 256 colors. Could we have this option
> added?
>
> Than
Paolo Bonzini writes:
> On 31/01/19 10:37, Markus Armbruster wrote:
>>>
Hmm, why is it okay to treat all pfl->cmd values the same when
secure=on?
>>> But doesn't matter. You just don't want MMIO mode to be active outside
>>> SMM: all that non-SMM code want to do with the flash is read
On Wed, 30 Jan 2019 at 03:18, Stefan Hajnoczi wrote:
>
> The following changes since commit f6b06fcceef465de0cf2514c9f76fe0192896781:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190121-pull-request'
> into staging (2019-01-23 17:57:47 +)
>
> are available in the Git repositor
On 1/30/19 10:48 PM, Lucien Murray-Pitts wrote:
> The result is that vCont now does not recognise the case where no
> process/thread is provided after the action.
Thanks for re-sending; this one came through a lot nicer! Welcome to
the community; while a first submission can always be a bit daun
The {IOE, DZE, OFE, UFE, IXE, IDE} bits in the FPSCR/FPCR are for
enabling trapped IEEE floating point exceptions (where IEEE exception
conditions cause a CPU exception rather than updating the FPSR status
bits). QEMU doesn't implement this (and nor does the hardware we're
modelling), but for imple
Use git archive to create tarballs of qemu and submodules instead of
cloning the repository and the submodules. This is a order of magnitude
faster because it doesn't fetch the submodules from the internet each
time the script runs.
Signed-off-by: Gerd Hoffmann
---
scripts/archive-source.sh | 6
The function rdma_poll_cq is called from two contexts - completion
handler thread which sense new completion on backend channel and
explicitly as result of guest issuing poll_cq command.
Add lock to protect against concurrent executions.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c | 2
To protect against CPU over utilization when guest performs unneeded
busy waiting loop on an empty CQ.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c | 11 +++
hw/rdma/rdma_backend.h | 2 +-
hw/rdma/rdma_rm.c | 1 +
hw/rdma/rdma_rm_defs.h | 6 +-
hw
When QP is destroyed the backend QP is destroyed as well. This ensures
we clean all received buffer we posted to it.
However, a contexts of these buffers are still remain in the device.
Fix it by maintaining a list of buffer's context and free them when QP
is destroyed.
Signed-off-by: Yuval Shaia
Hi,
Please review the following patch-set which consist of cosmetics fixes to
device's user interface (traces, error_report and monitor) and some bug
fixes.
Thanks,
Yuval
Yuval Shaia (10):
hw/rdma: Switch to generic error reporting way
hw/rdma: Introduce locked qlist
hw/rdma: Warn when too
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c| 53 ---
hw/rdma/rdma_rm.c | 6 +
hw/rdma/rdma_rm_defs.h| 21
hw/rdma/vmw/pvrdma.h | 5
hw/rdma/vmw/pvrdma_main.c | 3 +++
5 files changed, 74 insertions(+),
Signed-off-by: Yuval Shaia
---
hmp-commands-info.hx | 14 ++
monitor.c| 6 ++
2 files changed, 20 insertions(+)
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
index cbee8b944d..32f6215619 100644
--- a/hmp-commands-info.hx
+++ b/hmp-commands-info.hx
@@ -522,
To make code more readable move handling of locked list to a generic
functions.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c | 20 +--
hw/rdma/rdma_backend_defs.h | 8 ++--
hw/rdma/rdma_utils.c| 39 +
hw/rdma/rdma_uti
When device is going down free all saved MAD buffers.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c | 32
hw/rdma/rdma_backend.h | 1 +
2 files changed, 33 insertions(+)
diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
index d43fb1e677..65b2
This patch updates the description of the command lines for using
record/replay with attached block devices.
Signed-off-by: Pavel Dovgalyuk
---
docs/replay.txt | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/docs/replay.txt b/docs/replay.txt
index 3497585..2c2c
Utilize error_report for all pr_err calls and some pr_dbg that are
considered as errors.
For the remaining pr_dbg calls, the important ones were replaced by
trace points while other deleted.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c| 336 ++
hw
From: Pavel Dovgalyuk
This patch disables setting '-snapshot' option on by default
in record/replay mode. This is needed for creating vmstates in record
and replay modes.
Signed-off-by: Pavel Dovgalyuk
---
vl.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/vl
Signed-off-by: Yuval Shaia
---
hw/rdma/vmw/pvrdma.h | 1 +
hw/rdma/vmw/pvrdma_main.c | 72 +++
2 files changed, 73 insertions(+)
diff --git a/hw/rdma/vmw/pvrdma.h b/hw/rdma/vmw/pvrdma.h
index 167706ec2c..dc10f21ca0 100644
--- a/hw/rdma/vmw/pvrdma.h
+++ b
From: pbonz...@redhat.com
This is a fix which was missed by patch
74c0b816adfc6aa1b01b4426fdf385e32e35cbac, which added current_step
parameter to the replay_advance_current_step function.
Signed-off-by: Pavel Dovgalyuk
---
replay/replay-internal.c |2 +-
1 file changed, 1 insertion(+), 1 d
From: Pavel Dovgalyuk
This patch enables making snapshots with blkreplay used in
block devices.
This function is required to make bdrv_snapshot_goto without
calling .bdrv_open which is not implemented.
Signed-off-by: Pavel Dovgalyuk
---
block/blkreplay.c |8
1 file changed, 8 inse
The function argument rdma_dev_res is not needed as it is stored in the
backend_dev object at init.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c | 13 ++---
hw/rdma/rdma_backend.h | 1 -
hw/rdma/vmw/pvrdma_qp_ops.c | 3 +--
3 files changed, 7 insertions(+), 10 deleti
This patch introduces replay_break, replay_delete_break
qmp and hmp commands.
These commands allow stopping at the specified instruction.
It may be useful for debugging when there are some known
events that should be investigated.
replay_break command has one argument - number of instructions
execu
GDB remote protocol supports reverse debugging of the targets.
It includes 'reverse step' and 'reverse continue' operations.
The first one finds the previous step of the execution,
and the second one is intended to stop at the last breakpoint that
would happen when the program is executed normally.
This patch introduces the icount field for saving within the snapshot.
It is required for navigation between the snapshots in record/replay mode.
Signed-off-by: Pavel Dovgalyuk
Acked-by: Kevin Wolf
--
v2:
- documented format changes in docs/interop/qcow2.txt
(suggested by Eric Blake)
v10:
After recent updates block devices cannot be closed on qemu exit.
This happens due to the block request polling when replay is not finished.
Therefore now we stop execution recording before closing the block devices.
Signed-off-by: Pavel Dovgalyuk
---
replay/replay.c |2 ++
vl.c|
Non-empty record/replay queue prevents saving and loading the VM state,
because it includes pending bottom halves and block coroutines.
But when the new VM state is loaded, we don't have to preserve the consistency
of the current state anymore. Therefore this patch just flushes the queue
allowing t
In record/replay mode bdrv queue is controlled by replay mechanism.
It does not allow saving or loading the snapshots
when bdrv queue is not empty. Stopping the VM is not blocked by nonempty
queue, but flushing the queue is still impossible there,
because it may cause deadlocks in replay mode.
This
Saving icount as a parameters of the snapshot allows navigation between
them in the execution replay scenario.
This information can be used for finding a specific snapshot for proceeding
the recorded execution to the specific moment of the time.
E.g., 'reverse step' action (introduced in one of the
This patch adds an accessor function for the name of the record/replay
log file. Adding an accessor instead of making variable global,
prevents accidental modification of this variable by other modules.
Signed-off-by: Pavel Dovgalyuk
---
include/sysemu/replay.h |2 ++
replay/replay.c
This patch adds support of the reverse continue operation for gdbstub.
Reverse continue finds the last breakpoint that would happen in normal
execution from the beginning to the current moment.
Implementation of the reverse continue replays the execution twice:
to find the breakpoints that were hit
This patch postpones the call of 'configure_rtc' function. This call
uses host clock to configure the rtc, but host clock access should be
recorded when using icount record/replay mode. Therefore now rtc
is configured after switching record/replay mode on.
Signed-off-by: Pavel Dovgalyuk
---
vl.c
This patch introduces 'info replay' monitor command and
corresponding qmp request.
These commands request the current record/replay mode, replay log file
name, and the instruction count (number of recorded/replayed
instructions). The instruction count can be used with the
replay_seek/replay_break
1 - 100 of 413 matches
Mail list logo
