Re: [Qemu-devel] [PATCH v4 00/21] nbd: add qemu-nbd --list

2019-01-18 Thread Vladimir Sementsov-Ogievskiy
17.01.2019 22:36, Eric Blake wrote: > I got tired of debugging whether a server was advertising the > correct things during negotiation by inspecting the trace > logs of qemu-io as client - not to mention that without SOME > sort of client tracing particular commands, we can't easily > regression t

Re: [Qemu-devel] [PATCH v4 01/21] iotests: Make 233 output more reliable

2019-01-18 Thread Vladimir Sementsov-Ogievskiy
17.01.2019 22:36, Eric Blake wrote: > We have a race between the nbd server and the client both trying > to report errors at once which can make the test sometimes fail > if the output lines swap order under load. Break the race by > collecting server messages into a file and then replaying that >

Re: [Qemu-devel] [PATCH v2] hw/vfio/common: Refactor container initialization

2019-01-18 Thread Greg Kurz
On Thu, 17 Jan 2019 22:02:45 +0100 Eric Auger wrote: > In vfio_connect_container() the code that selects the > iommu type can benefit from helpers such as > vfio_iommu_get_type() and vfio_init_container(). As > a result we end up with a switch/case on the iommu type > that makes the code a little

Re: [Qemu-devel] [PATCH v2] hw/vfio/common: Refactor container initialization

2019-01-18 Thread Auger Eric
Hi Alexey, On 1/18/19 5:51 AM, Alexey Kardashevskiy wrote: > > > On 18/01/2019 08:02, Eric Auger wrote: >> In vfio_connect_container() the code that selects the >> iommu type can benefit from helpers such as >> vfio_iommu_get_type() and vfio_init_container(). As >> a result we end up with a swit

[Qemu-devel] [PATCH v3] hw/vfio/common: Refactor container initialization

2019-01-18 Thread Eric Auger
In vfio_connect_container() the code that selects the iommu type can benefit from helpers such as vfio_iommu_get_type() and vfio_init_container(). As a result we end up with a switch/case on the iommu type that makes the code a little bit more readable and ready for addition of new iommu types. Als

Re: [Qemu-devel] [PATCH 17/18] Boot Linux Console Test: add a test for s390x + s390-ccw-virtio

2019-01-18 Thread Cornelia Huck
On Thu, 17 Jan 2019 13:56:27 -0500 Cleber Rosa wrote: > Just like the previous tests, boots a Linux kernel on a s390x target > using the s390-ccw-virtio machine. > > Because it's not possible to have multiple VT220 consoles, > '-nodefaults' is used, so that the one set with set_console() works >

Re: [Qemu-devel] [RFC PATCH v2 35/37] i386-softmmu.mak: remove all CONFIG_* except boards definitions

2019-01-18 Thread Yang Zhong
On Thu, Jan 17, 2019 at 12:03:34PM +0100, Thomas Huth wrote: > > --- a/hw/mem/Kconfig > > +++ b/hw/mem/Kconfig > > @@ -6,3 +6,5 @@ config MEM_DEVICE > > > > config NVDIMM > > bool > > +default y > > +depends on I440FX && Q35 > > I440FX || Q35 ? > Thanks Thomas, "I440FX || Q35" i

Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes

2019-01-18 Thread Philippe Mathieu-Daudé
Hi Alex, On 1/17/19 9:10 PM, Alex Bennée wrote: > > Peter Maydell writes: > >> On Thu, 17 Jan 2019 at 18:30, Emilio G. Cota wrote: >>> >>> On Thu, Jan 17, 2019 at 17:37:54 +, Peter Maydell wrote: On Thu, 17 Jan 2019 at 13:27, Alex Bennée wrote: > > The following changes since

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

2019-01-18 Thread Auger Eric
Hi Alexey, On 1/18/19 5:14 AM, Alexey Kardashevskiy wrote: > > > On 17/01/2019 20:16, Auger Eric wrote: >> Hi Alexey, Cornelia, >> >> On 1/17/19 4:46 AM, Alexey Kardashevskiy wrote: >>> >>> >>> On 12/01/2019 03:58, Eric Auger wrote: The code used to attach the eventfd handler for the ERR an

Re: [Qemu-devel] [PATCH v3] hw/vfio/common: Refactor container initialization

2019-01-18 Thread Greg Kurz
On Fri, 18 Jan 2019 09:55:25 +0100 Eric Auger wrote: > In vfio_connect_container() the code that selects the > iommu type can benefit from helpers such as > vfio_iommu_get_type() and vfio_init_container(). As > a result we end up with a switch/case on the iommu type > that makes the code a little

Re: [Qemu-devel] [PATCH v4 for-4.0 4/7] libvhost-user: Support tracking inflight I/O in shared memory

2019-01-18 Thread Jason Wang
On 2019/1/18 下午3:01, Yongji Xie wrote: On Fri, 18 Jan 2019 at 12:00, Jason Wang wrote: On 2019/1/18 上午11:32, Yongji Xie wrote: On Thu, 17 Jan 2019 at 17:57, Jason Wang wrote: On 2019/1/15 下午10:51, Yongji Xie wrote: Well, this may work but here're my points: 1) The code want to recover f

Re: [Qemu-devel] [PULL v2 00/49] pci, pc, virtio: fixes, features

2019-01-18 Thread Igor Mammedov
On Thu, 17 Jan 2019 21:12:53 -0500 "Michael S. Tsirkin" wrote: > On Thu, Jan 17, 2019 at 04:21:24PM +, Peter Maydell wrote: > > On Thu, 17 Jan 2019 at 13:44, Michael S. Tsirkin wrote: > > > > > > On Thu, Jan 17, 2019 at 12:48:22PM +, Peter Maydell wrote: > > > > This fails 'make chec

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

2019-01-18 Thread Cornelia Huck
On Fri, 18 Jan 2019 10:08:12 +0100 Auger Eric wrote: > Hi Alexey, > > On 1/18/19 5:14 AM, Alexey Kardashevskiy wrote: > > > > > > On 17/01/2019 20:16, Auger Eric wrote: > >> Hi Alexey, Cornelia, > >> > >> On 1/17/19 4:46 AM, Alexey Kardashevskiy wrote: > >>> > >>> > >>> On 12/01/2019 03:58

[Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-18 Thread Erik Skultety
Hi, this is a summary of a private discussion I've had with guys CC'd on this email about finding a solution to [1] - basically, the default permissions on /dev/sev (below) make it impossible to query for SEV platform capabilities, since by default we run QEMU as qemu:qemu when probing for capabili

Re: [Qemu-devel] [PATCH v4 05/21] nbd/server: Hoist length check to qmp_nbd_server_add

2019-01-18 Thread Vladimir Sementsov-Ogievskiy
17.01.2019 22:36, Eric Blake wrote: > We only had two callers to nbd_export_new; qemu-nbd.c always > passed a valid offset/length pair (because it already checked > the file length, to ensure that offset was in bounds), while > blockdev-nbd.c always passed 0/-1. Then nbd_export_new reduces > the s

Re: [Qemu-devel] [PATCH v3 8/9] qcow2: bdrv_co_pwritev: move encryption code out of the lock

2019-01-18 Thread Alberto Garcia
On Tue 08 Jan 2019 06:06:54 PM CET, Vladimir Sementsov-Ogievskiy wrote: > Encryption will be done in threads, to take benefit of it, we should > move it out of the lock first. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.c | 35 +-- > 1 file

Re: [Qemu-devel] [PATCH v2 0/6] Acquire the AioContext during _realize()

2019-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2019 at 02:24:10PM +0100, Alberto Garcia wrote: > On Wed 16 Jan 2019 02:54:44 PM CET, Stefan Hajnoczi wrote: > > This patch series makes virtio-blk and virtio-scsi more robust, > > although I haven't checked what happens if the drive is attached to a > > different IOThread than the

Re: [Qemu-devel] AVX support for TCG

2019-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2019 at 03:57:08PM +0200, Nick Renieris wrote: > Just a heads up, I don't know if I want to go for this myself yet. > I'm still not sure I'll even be able to deliver the refactoring in > time (Step 2 in your list), and I hadn't even considered tests for SSE > as something I'd have t

Re: [Qemu-devel] [PATCH RFC 01/10] qdev: Let the hotplug_handler_unplug() caller delete the device

2019-01-18 Thread Igor Mammedov
On Wed, 16 Jan 2019 12:35:14 +0100 David Hildenbrand wrote: > When unplugging a device, at one point the device will be destroyed > via object_unparent(). This will, one the one hand, unrealize the > removed device hierarchy, and on the other hand, destroy/free the > device hierarchy. > > When c

Re: [Qemu-devel] [PATCH v4 11/21] nbd/client: Split out nbd_send_meta_query()

2019-01-18 Thread Vladimir Sementsov-Ogievskiy
17.01.2019 22:36, Eric Blake wrote: > Refactor nbd_negotiate_simple_meta_context() to pull out the > code that can be reused to send a LIST request for 0 or 1 query. > No semantic change. The old comment about 'sizeof(uint32_t)' > being equivalent to '/* number of queries */' is no longer > needed

[Qemu-devel] [PATCH 2/2] Acceptance tests: add support more than 2GiB initrd test with linux-v4.19

2019-01-18 Thread Li Zhijian
timeout is updated to 5mins since we need more time to load a large initrd to the guest CC: Wainer dos Santos Moschetta CC: Caio Carrara CC: Cleber Rosa CC: Eduardo Habkost CC: Philippe Mathieu-Daudé Signed-off-by: Li Zhijian --- tests/acceptance/linux_initrd.py | 37 +++

Re: [Qemu-devel] [PATCH v4 01/21] iotests: Make 233 output more reliable

2019-01-18 Thread Daniel P . Berrangé
On Thu, Jan 17, 2019 at 01:36:38PM -0600, Eric Blake wrote: > We have a race between the nbd server and the client both trying > to report errors at once which can make the test sometimes fail > if the output lines swap order under load. Break the race by > collecting server messages into a file a

[Qemu-devel] [PATCH 1/2] Acceptance tests: use linux-3.6 and set vm memory to 4GiB

2019-01-18 Thread Li Zhijian
linux-3.6 kernel shipped by Fedora-19 cannot support xldflags so that it cannot support loading more than 2GiB initrd CC: Wainer dos Santos Moschetta CC: Caio Carrara CC: Cleber Rosa CC: Eduardo Habkost CC: Philippe Mathieu-Daudé Signed-off-by: Li Zhijian --- this patch is basing on early A

Re: [Qemu-devel] [PATCH v4 15/21] nbd/client: Pull out oldstyle size determination

2019-01-18 Thread Vladimir Sementsov-Ogievskiy
17.01.2019 22:36, Eric Blake wrote: > Another refactoring creating nbd_negotiate_finish_oldstyle() > for further reuse during 'qemu-nbd --list'. > > Signed-off-by: Eric Blake > Reviewed-by: Richard W.M. Jones you forget my r-b: Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladi

Re: [Qemu-devel] [PATCH v4 01/21] iotests: Make 233 output more reliable

2019-01-18 Thread Daniel P . Berrangé
On Fri, Jan 18, 2019 at 08:28:21AM +, Vladimir Sementsov-Ogievskiy wrote: > 17.01.2019 22:36, Eric Blake wrote: > > We have a race between the nbd server and the client both trying > > to report errors at once which can make the test sometimes fail > > if the output lines swap order under load.

Re: [Qemu-devel] [PATCH] trace: add ability to do simple printf logging via systemtap

2019-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2019 at 02:52:07PM +, Daniel P. Berrangé wrote: Nice improvement, thanks! Do you want to send a docs/devel/tracing.txt follow-up patch to document this feature? Thanks, applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing Stefan signature.asc Descri

Re: [Qemu-devel] Live migration from Qemu 2.12 hosts to Qemu 3.2 hosts, with VMX flag enabled in the guest?

2019-01-18 Thread Dr. David Alan Gilbert
* Mark Mielke (mark.mie...@gmail.com) wrote: > Thank you for the work on nested virtualization. Having had live migrations > fail in the past when nested virtualization has been active, it is great to > see that clever people have been working on this problem! > > My question is about whether a mi

Re: [Qemu-devel] Live migration from Qemu 2.12 hosts to Qemu 3.2 hosts, with VMX flag enabled in the guest?

2019-01-18 Thread Paolo Bonzini
On 18/01/19 11:02, Dr. David Alan Gilbert wrote: >> >> It fails if the flag is set, rather than if any nested virtualization has >> been used before. >> >> I'm concerned I will end up with a requirement for *all* guests to be >> restarted in order to migrate them to the new hosts, rather than just

Re: [Qemu-devel] [PATCH RFC 03/10] qdev: Provide qdev_get_bus_hotplug_handler()

2019-01-18 Thread Igor Mammedov
On Wed, 16 Jan 2019 12:35:16 +0100 David Hildenbrand wrote: > Let's use a wrapper instead of looking it up manually. This function can > than be reused when we explicitly want to have the bus hotplug handler > (e.g. when the bus hotplug handler was overwritten by the machine > hotplug handler). >

[Qemu-devel] [PATCH v4] qemu-io: Add generic function for reinitializing optind.

2019-01-18 Thread Richard W.M. Jones
v3 was posted here: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg01536.html In v4: - Detect optreset at ./configure time and use ifdef HAVE_OPTRESET. - Adjusted comment style. - Checkpatch is now clean. - Retested on Linux, FreeBSD 11.2 and OpenBSD 6.4. Rich.

Re: [Qemu-devel] [PATCH v2 0/6] Acquire the AioContext during _realize()

2019-01-18 Thread Kevin Wolf
Am 18.01.2019 um 10:56 hat Stefan Hajnoczi geschrieben: > On Thu, Jan 17, 2019 at 02:24:10PM +0100, Alberto Garcia wrote: > > On Wed 16 Jan 2019 02:54:44 PM CET, Stefan Hajnoczi wrote: > > > This patch series makes virtio-blk and virtio-scsi more robust, > > > although I haven't checked what happen

[Qemu-devel] [PATCH v4] qemu-io: Add generic function for reinitializing optind.

2019-01-18 Thread Richard W.M. Jones
On FreeBSD 11.2: $ nbdkit memory size=1M --run './qemu-io -f raw -c "aio_write 0 512" $nbd' Parsing error: non-numeric argument, or extraneous/unrecognized suffix -- aio_write After main option parsing, we reinitialize optind so we can parse each command. However reinitializing optind to 0

Re: [Qemu-devel] Live migration from Qemu 2.12 hosts to Qemu 3.2 hosts, with VMX flag enabled in the guest?

2019-01-18 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 18/01/19 11:02, Dr. David Alan Gilbert wrote: > >> > >> It fails if the flag is set, rather than if any nested virtualization has > >> been used before. > >> > >> I'm concerned I will end up with a requirement for *all* guests to be > >> restarted i

Re: [Qemu-devel] [Qemu-arm] Problems adding TMS570LC43 - Cortex-R5f

2019-01-18 Thread KONRAD Frederic
Le 1/17/19 à 7:00 PM, Philippe Mathieu-Daudé a écrit : Hi, On 1/17/19 5:54 PM, João Gaspar wrote: Hi! I'm new at QEMU so I have some questions. I'm trying to create a new support machine to QEMU, the TMS570LC43 board, this board use the Cortex-R5f microcontroller. At this moment when I do t

Re: [Qemu-devel] [PATCH 1/2] Acceptance tests: use linux-3.6 and set vm memory to 4GiB

2019-01-18 Thread Li Zhijian
Sorry, there are some typos, please ignore this version i will correct in V2 On 1/18/19 18:02, Li Zhijian wrote: linux-3.6 kernel shipped by Fedora-19 cannot support xldflags so that it s/Fedora-19/Fedora-18 cannot support loading more than 2GiB initrd CC: Wainer dos Santos Moschetta CC:

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-18 Thread Daniel P . Berrangé
On Fri, Jan 18, 2019 at 10:39:35AM +0100, Erik Skultety wrote: > Hi, > this is a summary of a private discussion I've had with guys CC'd on this > email > about finding a solution to [1] - basically, the default permissions on > /dev/sev (below) make it impossible to query for SEV platform capabil

Re: [Qemu-devel] [PATCH 2/2] Acceptance tests: add support more than 2GiB initrd test with linux-v4.19

2019-01-18 Thread Li Zhijian
Sorry, there are some typos, please ignore this version i will correct in V2 s/v4.19/v4.16 on subject. On 1/18/19 18:02, Li Zhijian wrote: timeout is updated to 5mins since we need more time to load a large initrd to the guest CC: Wainer dos Santos Moschetta CC: Caio Carrara CC: Cleber Ros

Re: [Qemu-devel] [PATCH RFC 09/10] pc: Support for PCI based memory devices

2019-01-18 Thread Igor Mammedov
On Wed, 16 Jan 2019 12:35:22 +0100 David Hildenbrand wrote: > Override the PCI device hotplug handler to properly handle the > memory device part from the machine hotplug handler and forward to the > actual PCI bus hotplug handler. > > As PCI hotplug has not been properly factored out into hotpl

Re: [Qemu-devel] [PATCH v4] qemu-io: Add generic function for reinitializing optind.

2019-01-18 Thread Daniel P . Berrangé
On Fri, Jan 18, 2019 at 10:11:14AM +, Richard W.M. Jones wrote: > On FreeBSD 11.2: > > $ nbdkit memory size=1M --run './qemu-io -f raw -c "aio_write 0 512" $nbd' > Parsing error: non-numeric argument, or extraneous/unrecognized suffix -- > aio_write > > After main option parsing, we rein

Re: [Qemu-devel] [PATCH] trace: add ability to do simple printf logging via systemtap

2019-01-18 Thread Daniel P . Berrangé
On Fri, Jan 18, 2019 at 10:05:35AM +, Stefan Hajnoczi wrote: > On Thu, Jan 17, 2019 at 02:52:07PM +, Daniel P. Berrangé wrote: > > Nice improvement, thanks! Do you want to send a docs/devel/tracing.txt > follow-up patch to document this feature? Ok, will do. > > Thanks, applied to my t

Re: [Qemu-devel] Live migration from Qemu 2.12 hosts to Qemu 3.2 hosts, with VMX flag enabled in the guest?

2019-01-18 Thread Daniel P . Berrangé
On Fri, Jan 18, 2019 at 10:16:34AM +, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: > > On 18/01/19 11:02, Dr. David Alan Gilbert wrote: > > >> > > >> It fails if the flag is set, rather than if any nested virtualization has > > >> been used before. > > >> > > >>

[Qemu-devel] [PATCH 0/2] contrib: gitdm: Some updates

2019-01-18 Thread Aleksandar Markovic
From: Aleksandar Markovic Add Citrix, Huawei, Intel, and Microsoft to domain map, and update Wave Computuing group. Aleksandar Markovic (2): contrib: gitdm: Update domain-map contrib: gitdm: Update Wave Computing group contrib/gitdm/domain-map | 4 contrib/gitdm/group-map-wav

[Qemu-devel] [PATCH 2/2] contrib: gitdm: Update Wave Computing group

2019-01-18 Thread Aleksandar Markovic
From: Aleksandar Markovic Add all missing MIPS/Imgtec/Wave contributors (from the inception of QEMU). Signed-off-by: Aleksandar Markovic --- contrib/gitdm/group-map-wavecomp | 12 1 file changed, 12 insertions(+) diff --git a/contrib/gitdm/group-map-wavecomp b/contrib/gitdm/group

[Qemu-devel] [PATCH 1/2] contrib: gitdm: Update domain-map

2019-01-18 Thread Aleksandar Markovic
From: Aleksandar Markovic Add Citrix, Huawei, Intel, and Microsoft to domain-map. Signed-off-by: Aleksandar Markovic --- contrib/gitdm/domain-map | 4 1 file changed, 4 insertions(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index 0ab41ee..9c09285 100644 --- a/cont

Re: [Qemu-devel] [PATCH v2 0/6] Acquire the AioContext during _realize()

2019-01-18 Thread Kevin Wolf
Am 14.01.2019 um 15:23 hat Alberto Garcia geschrieben: > This series acquires the AioContext in the _realize() functions of > several devices before making use of their block backends. This fixes > at least a couple of crashes (in virtio-blk and scsi). The other > devices don't currently support io

Re: [Qemu-devel] [PATCH 1/2] contrib: gitdm: Update domain-map

2019-01-18 Thread Aleksandar Markovic
On Friday, January 18, 2019, Aleksandar Markovic < aleksandar.marko...@rt-rk.com> wrote: > From: Aleksandar Markovic > > Add Citrix, Huawei, Intel, and Microsoft to domain-map. > > Signed-off-by: Aleksandar Markovic > --- > contrib/gitdm/domain-map | 4 > 1 file changed, 4 insertions(+) >

Re: [Qemu-devel] [PATCH 06/18] Acceptance tests: use "arch:" tag to filter target specific tests

2019-01-18 Thread Cornelia Huck
On Thu, 17 Jan 2019 13:56:16 -0500 Cleber Rosa wrote: > Currently, the only test that contains some target architecture > information is "boot_linux_console.py" which test contains a "x86_64" > tag. But that tag is not respected in the default execution, that is, > "make check-acceptance" doesn'

Re: [Qemu-devel] [PATCH] trace: add ability to do simple printf logging via systemtap

2019-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2019 at 02:52:07PM +, Daniel P. Berrangé wrote: Dequeued. I encountered two issues during testing: 1. s/binary/file/ in qemu-trace-stap's which() function: diff --git a/scripts/qemu-trace-stap b/scripts/qemu-trace-stap index b2eb41fbb0..3b4ec5e9b9 100755 --- a/scripts/qemu-t

Re: [Qemu-devel] [libvirt] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-18 Thread Erik Skultety
On Fri, Jan 18, 2019 at 10:16:38AM +, Daniel P. Berrangé wrote: > On Fri, Jan 18, 2019 at 10:39:35AM +0100, Erik Skultety wrote: > > Hi, > > this is a summary of a private discussion I've had with guys CC'd on this > > email > > about finding a solution to [1] - basically, the default permissi

Re: [Qemu-devel] [PATCH 00/27] slirp: make it again a standalone project (part 2)

2019-01-18 Thread Marc-André Lureau
Hi On Fri, Jan 18, 2019 at 3:09 AM Samuel Thibault wrote: > > Also thinking about it: I guess we'd want to make the usage of libslirp > optional, at least because (I guess) at some points the future libslirp There is already --disable-slirp. My upcoming patches for external libslirp honor that t

Re: [Qemu-devel] [PATCH 01/27] slirp: generalize guestfwd with a callback based approach

2019-01-18 Thread Marc-André Lureau
Hi On Fri, Jan 18, 2019 at 3:07 AM Samuel Thibault wrote: > > Marc-André Lureau, le jeu. 17 janv. 2019 15:43:33 +0400, a ecrit: > > /* XXX this blocks entire thread. Rewrite to use > > * qemu_chr_fe_write and background I/O callbacks */ > > Seeing this, I guess a whole pass wil

Re: [Qemu-devel] [Qemu-arm] Problems adding TMS570LC43 - Cortex-R5f

2019-01-18 Thread Philippe Mathieu-Daudé
On 1/18/19 11:14 AM, KONRAD Frederic wrote: > Le 1/17/19 à 7:00 PM, Philippe Mathieu-Daudé a écrit : >> On 1/17/19 5:54 PM, João Gaspar wrote: >>> Hi! >>> I'm new at QEMU so I have some questions. >>> >>> I'm trying to create a new support machine to QEMU, the TMS570LC43 >>> board, this board use t

Re: [Qemu-devel] block: Update flags in bdrv_set_read_only()

2019-01-18 Thread Kevin Wolf
[ Cc: qemu-block - noticed only now that it was missing ] Am 14.01.2019 um 12:01 hat Kevin Wolf geschrieben: > Am 12.01.2019 um 18:08 hat Michael Tokarev geschrieben: > > commit eeae6a596b0efc092f5101c67683053e245e6250 > > Author: Kevin Wolf > > Date: Tue Oct 9 16:57:12 2018 +0200 >

[Qemu-devel] [Bug 1810603] Re: QEMU QCow Images grow dramatically

2019-01-18 Thread Lenny Helpline
We have played a bit around with external snapshots (as suggested by Eric Blake in post #3), however, it appears that external snapshots are not fully supported yet. While I can create external snapshots, I'm unable to revert to them using virt-manager (which we use for managing our VM farm): Erro

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-18 Thread Daniel P . Berrangé
On Fri, Jan 18, 2019 at 12:11:50PM +0100, Martin Kletzander wrote: > On Fri, Jan 18, 2019 at 10:16:38AM +, Daniel P. Berrangé wrote: > > I've just realized there is a potential 3rd solution. Remember there is > > actually nothing inherantly special about the 'root' user as an account > > ID. 'r

[Qemu-devel] [RFC PATCH] gdbstub: Avoid NULL dereference in gdb_handle_packet()

2019-01-18 Thread Philippe Mathieu-Daudé
The "Hg" GDB packet is used to select the current thread, and can fail. GDB doesn't not check for failure and emits further packets that can access and dereference s->c_cpu or s->g_cpu. Add a check that returns "E22" (EINVAL) when those pointers are not set. Peter Maydell reported: GDB doesn't

[Qemu-devel] [RFC PATCH v3 03/43] hw/arm/Makefile.objs: CONFIG_VIRT created for virt board

2019-01-18 Thread Yang Zhong
make virt code configurable and the new CONFIG_VIRT definitions added to the default-configs/arm-softmmu.mak to replace CONFIG_ACPI in arm board. Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- default-configs/arm-softmmu.mak | 1 + hw/arm/Makefile.objs| 3 ++- 2 files change

[Qemu-devel] [RFC PATCH v3 01/43] build: actually use CONFIG_PAM

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini Do not link it unconditionally into all binaries. Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- default-configs/i386-softmmu.mak | 1 + hw/pci-host/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --g

[Qemu-devel] [RFC PATCH v3 02/43] hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini CONFIG_PIIX and CONFIG_Q35 created for the pc board object files. These are enabled automatically at default-configs/i386-softmmu.mak and default-configs/x86_64-softmmu.mak Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-config

[Qemu-devel] [RFC PATCH v3 07/43] hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*

2019-01-18 Thread Yang Zhong
From: Ákos Kovács CONFIG_PPC405, CONFIG_PPC440, CONFIG_MAC_OLDWORLD, CONFIG_MAX_NEWWORLD and CONFIG_VIRTEX configuration options created for default-configs/ppc*-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong --- default-configs/ppc-softmmu.mak

[Qemu-devel] [RFC PATCH v3 00/43] Support Kconfig in QEMU

2019-01-18 Thread Yang Zhong
This Kconfig implementation is rebased from Paolo's branch https://github.com/bonzini/qemu/commits/kconfig I rebased most of patches except non-x86 ARCHs dependency definitions this time. https://github.com/yangzhon/qemu/commits/topic/upstream/Kconfig The current RFC patches only support (*) x86_

[Qemu-devel] [RFC PATCH v3 05/43] hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards

2019-01-18 Thread Yang Zhong
From: Ákos Kovács CONFIG_PETALOGIX_* and CONFIG_XLNX_* configs added to default-configs/microblaze-softmmu.mak and default-configs/microblazeel-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini --- default-configs/microblaze-softmmu.mak | 3 +++ hw/microblaze/Makefile.objs

[Qemu-devel] [RFC PATCH v3 04/43] hw/m68k/Makefile.objs: Conditionally build boards

2019-01-18 Thread Yang Zhong
From: Ákos Kovács CONFIG_AN5206, CONFIG_MCF5206 and CONFIG_MCF5208 make variables created for m68k boards, and added to default-configs/m86k-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini --- default-configs/m68k-softmmu.mak | 2 ++ hw/m68k/Makefile.objs| 4 +

[Qemu-devel] [RFC PATCH v3 14/43] hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64

2019-01-18 Thread Yang Zhong
Add the new configs to default-configs/sparc64-sofmmu.mak. Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- default-configs/sparc64-softmmu.mak | 2 ++ hw/sparc64/Makefile.objs| 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/default-configs/sparc64-so

[Qemu-devel] [RFC PATCH v3 08/43] hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device

2019-01-18 Thread Yang Zhong
From: Ákos Kovács Make hw/sh4 configurable and add new CONFIG_* to the default-configs/sh4*-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini --- default-configs/sh4-softmmu.mak | 2 ++ default-configs/sh4eb-softmmu.mak | 2 ++ hw/sh4/Makefile.objs | 4 ++--

[Qemu-devel] [RFC PATCH v3 18/43] hw/moxie/Makefile.objs: Conditionally build moxie

2019-01-18 Thread Yang Zhong
CONFIG_MOXIE added for moxiesim board. Signed-off-by: Yang Zhong --- default-configs/moxie-softmmu.mak | 1 + hw/moxie/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/default-configs/moxie-softmmu.mak b/default-configs/moxie-softmmu.mak index e00d0

[Qemu-devel] [RFC PATCH v3 12/43] hw/nios2/Makefile.objs: Conditionally build nios2

2019-01-18 Thread Yang Zhong
CONFIG_NIOS2_10M50 added for 10m50 dev board. Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- default-configs/nios2-softmmu.mak | 1 + hw/nios2/Makefile.objs| 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/default-configs/nios2-softmmu.mak b/default-con

[Qemu-devel] [RFC PATCH v3 06/43] hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards

2019-01-18 Thread Yang Zhong
From: Ákos Kovács Add the new configs to default-configs/mips*-sofmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong --- default-configs/mips-softmmu-common.mak | 3 +++ hw/mips/Makefile.objs | 6 -- 2 files changed, 7 insertions(

[Qemu-devel] [RFC PATCH v3 17/43] hw/hppa/Makefile.objs: Create CONFIG_* for hppa

2019-01-18 Thread Yang Zhong
Add the new configs to default-configs/hppa-sofmmu.mak. Signed-off-by: Yang Zhong --- default-configs/hppa-softmmu.mak | 2 ++ hw/hppa/Makefile.objs| 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/default-configs/hppa-softmmu.mak b/default-configs/hppa-softmmu.

Re: [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input

2019-01-18 Thread Marc-André Lureau
Hi On Thu, Jan 17, 2019 at 5:56 PM Peter Maydell wrote: > > On Thu, 17 Jan 2019 at 13:41, Philippe Mathieu-Daudé > wrote: > > On 1/17/19 12:50 AM, Samuel Thibault wrote: > > > --- a/slirp/slirp.c > > > +++ b/slirp/slirp.c > > > @@ -851,7 +851,7 @@ void slirp_input(Slirp *slirp, const uint8_t *p

[Qemu-devel] [RFC PATCH v3 10/43] hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst

2019-01-18 Thread Yang Zhong
From: Ákos Kovács CONFIG_LM32 and CONFIG_MILKYMIST added for lm32 and milkmyst build. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- hw/lm32/Makefile.objs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/lm32/Makefile.objs b/hw/

[Qemu-devel] [RFC PATCH v3 09/43] hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created

2019-01-18 Thread Yang Zhong
From: Ákos Kovács CONFIG_LEON3 added to default-configs/sparc-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/sparc-softmmu.mak | 2 ++ hw/sparc/Makefile.objs| 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-

[Qemu-devel] [RFC PATCH v3 21/43] minikconfig: add parser skeleton

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini This implements a scanner and recursive descent parser for Kconfig-like configuration files. The only "action" of the parser is for now to detect undefined variables and process include files. The main differences between Kconfig and this are: * only the "bool" type is supp

[Qemu-devel] [RFC PATCH v3 11/43] hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally

2019-01-18 Thread Yang Zhong
From: Ákos Kovács Add the new CONFIG_* values to default-config/xtensa*-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth Acked-by: Max Filippov --- default-configs/xtensa-softmmu.mak | 3 +++ default-configs/xtensaeb-softmmu.mak | 3 +++ hw/xte

[Qemu-devel] [RFC PATCH v3 16/43] hw/cris/Makefile.objs: Create CONFIG_* for cris

2019-01-18 Thread Yang Zhong
Add the new configs to default-configs/cris-sofmmu.mak. Signed-off-by: Yang Zhong --- default-configs/cris-softmmu.mak | 1 + hw/cris/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/default-configs/cris-softmmu.mak b/default-configs/cris-softmmu.mak

[Qemu-devel] [RFC PATCH v3 27/43] ide: express dependencies with Kconfig

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/alpha-softmmu.mak | 2 -- default-configs/pci.mak | 3 --- hw/ide/Kconfig| 15 +++ 3 files changed, 15 insertions(+), 5 deletions(-) diff --git a/default-c

[Qemu-devel] [RFC PATCH v3 24/43] hw/display: make edid configurable

2019-01-18 Thread Yang Zhong
Use CONFIG_EDID to make edid-generate.c and edid-region.c configurable. Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- default-configs/pci.mak | 1 + hw/display/Makefile.objs | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/default-configs/pci.mak b/default-conf

[Qemu-devel] [RFC PATCH v3 15/43] hw/alpha/Makefile.objs: Create CONFIG_* for alpha

2019-01-18 Thread Yang Zhong
Add the new configs to default-configs/alpha-sofmmu.mak. Signed-off-by: Yang Zhong --- default-configs/alpha-softmmu.mak | 2 ++ hw/alpha/Makefile.objs| 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/default-configs/alpha-softmmu.mak b/default-configs/alpha-so

[Qemu-devel] [RFC PATCH v3 19/43] hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc

2019-01-18 Thread Yang Zhong
Add the new configs to default-configs/or1k-sofmmu.mak. Signed-off-by: Yang Zhong --- default-configs/or1k-softmmu.mak | 1 + hw/openrisc/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/default-configs/or1k-softmmu.mak b/default-configs/or1k-softmmu.mak

[Qemu-devel] [RFC PATCH v3 22/43] minikconfig: add AST

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini Add Python classes that represent the Kconfig abstract syntax tree. The abstract syntax tree is stored as a list of clauses. For example: config FOO depends on BAR select BAZ is represented as three clauses: FOO depends on BAR FOO default n

[Qemu-devel] [RFC PATCH v3 13/43] hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards

2019-01-18 Thread Yang Zhong
Add the new configs to default-configs/riscv*-sofmmu.mak. Signed-off-by: Yang Zhong --- default-configs/riscv32-softmmu.mak | 7 +++ default-configs/riscv64-softmmu.mak | 7 +++ hw/riscv/Makefile.objs | 22 +++--- 3 files changed, 25 insertions(+), 11 delet

[Qemu-devel] [RFC PATCH v3 20/43] hw/tricore/Makefile.objs: Create CONFIG_* for tricore

2019-01-18 Thread Yang Zhong
Add the new configs to default-configs/tricore-sofmmu.mak. Signed-off-by: Yang Zhong --- default-configs/tricore-softmmu.mak | 1 + hw/tricore/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/default-configs/tricore-softmmu.mak b/default-configs/tri

[Qemu-devel] [RFC PATCH v3 25/43] kconfig: introduce kconfig files

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini The Kconfig files were generated mostly with this script: for i in `grep -ho CONFIG_[A-Z0-9_]* default-configs/* | sort -u`; do set fnord `git grep -lw $i -- 'hw/*/Makefile.objs' ` shift if test $# = 1; then cat >> $(dirname $1)/Kconfig << EOF config ${i#C

[Qemu-devel] [RFC PATCH v3 23/43] minikconfig: add semantic analysis

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini There are three parts in the semantic analysis: 1) evaluating expressions. This is done as a simple visit of the Expr nodes. 2) ordering clauses. This is done by constructing a graph of variables. There is an edge from X to Y if Y depends on X, if X selects Y, or if X appe

[Qemu-devel] [RFC PATCH v3 30/43] build: convert sound.mak to Kconfig

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini There is really nothing special in these devices; they are just ISA devices. Instead of including them for each target, set CONFIG_ISA_BUS to true, and make the devices default to present whenever ISA is available. More conversion of ISA devices will follow. Done with the f

[Qemu-devel] [RFC PATCH v3 26/43] build: switch to Kconfig

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini The make_device_config.sh script is replaced by minikconf, which is modified to support the same command line as its predecessor. The roots of the parsing are default-configs/*.mak, Kconfig.host and hw/Kconfig. One difference with make_device_config.sh is that all symbols ha

Re: [Qemu-devel] [PATCH v3 8/9] qcow2: bdrv_co_pwritev: move encryption code out of the lock

2019-01-18 Thread Vladimir Sementsov-Ogievskiy
18.01.2019 12:51, Alberto Garcia wrote: > On Tue 08 Jan 2019 06:06:54 PM CET, Vladimir Sementsov-Ogievskiy wrote: >> Encryption will be done in threads, to take benefit of it, we should >> move it out of the lock first. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> block/qcow2.c |

[Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable

2019-01-18 Thread Yang Zhong
Make pcie splited from pci and make it configurable. Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- default-configs/pci.mak | 1 + hw/pci/Kconfig | 3 +++ hw/pci/Makefile.objs| 5 +++-- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/default-configs/pci.mak b

[Qemu-devel] [RFC PATCH v3 31/43] build: convert usb.mak to Kconfig

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini Instead of including the same list of devices for each target, let the host controllers select CONFIG_USB and make the devices default to present whenever USB is available. Done with the following script: while read i; do i=${i%=y}; i=${i#CONFIG_} sed -i -e'/^conf

[Qemu-devel] [RFC PATCH v3 32/43] scsi: express dependencies with Kconfig

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini This automatically removes the SCSI subsystem from the binary altogether if no controllers are selected. Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong --- hw/scsi/Kconfig | 12 hw/scsi/Makefile.objs | 2 +- hw/usb/Kconfig| 2 ++ 3 file

[Qemu-devel] [RFC PATCH v3 29/43] build: convert pci.mak to Kconfig

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini Instead of including the same list of devices for each target, set CONFIG_PCI to true, and make the devices default to present whenever PCI is available. Done mostly with the following script: while read i; do i=${i%=y}; i=${i#CONFIG_} sed -i -e'/^config '$i'$/!b

[Qemu-devel] [RFC PATCH v3 33/43] bluetooth: express dependencies with Kconfig

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- hw/Makefile.objs | 2 +- hw/usb/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/Makefile.objs b/hw/Makefile.objs index 39d882af6f..b95b0c74a1 100644 --- a/

Re: [Qemu-devel] [PATCH v4 16/21] nbd/client: Refactor nbd_opt_go() to support NBD_OPT_INFO

2019-01-18 Thread Vladimir Sementsov-Ogievskiy
17.01.2019 22:36, Eric Blake wrote: > Rename the function to nbd_opt_info_or_go() with an added parameter > and slight changes to comments and trace messages, in order to > reuse the function for NBD_OPT_INFO. > > Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best reg

[Qemu-devel] [RFC PATCH v3 34/43] isa: express dependencies with kconfig

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong --- default-configs/i386-softmmu.mak | 9 - hw/audio/Kconfig | 2 ++ hw/block/Kconfig | 2 ++ hw/char/Kconfig | 6 ++ hw/display/Kconfig | 3 +++

[Qemu-devel] [RFC PATCH v3 37/43] ptimer: express dependencies with Kconfig

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- hw/Kconfig | 2 ++ hw/net/Kconfig | 2 ++ hw/timer/Kconfig | 6 ++ 3 files changed, 10 insertions(+) diff --git a/hw/Kconfig b/hw/Kconfig index 906143a816..0d836b527e 100644 --

[Qemu-devel] [RFC PATCH v3 35/43] i386: express dependencies with Kconfig

2019-01-18 Thread Yang Zhong
From: Paolo Bonzini This way, the default-configs file only need to specify the boards and any optional devices. Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong --- default-configs/i386-softmmu.mak | 39 hw/acpi/Kconfig | 3 ++ hw/display/Kconfig

[Qemu-devel] [RFC PATCH v3 41/43] i386-softmmu.mak: remove all CONFIG_* except boards definitions

2019-01-18 Thread Yang Zhong
%-softmmu.mak only keep boards definitions in Kconfig mode. Signed-off-by: Yang Zhong --- default-configs/i386-softmmu.mak | 22 -- hw/acpi/Kconfig | 4 hw/i386/Kconfig | 5 + hw/ipmi/Kconfig | 8 hw/mem/

[Qemu-devel] [RFC PATCH v3 39/43] hyperv: express dependencies with kconfig

2019-01-18 Thread Yang Zhong
remove default-configs/hyperv.mak and make dependencies with Kconfig. Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- default-configs/hyperv.mak | 2 -- default-configs/i386-softmmu.mak | 1 - hw/hyperv/Kconfig| 4 3 files changed, 4 insertions(+), 3 deletions(

Re: [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input

2019-01-18 Thread Marc-André Lureau
Hi On Fri, Jan 18, 2019 at 3:25 PM Marc-André Lureau wrote: > > Hi > > On Thu, Jan 17, 2019 at 5:56 PM Peter Maydell > wrote: > > > > On Thu, 17 Jan 2019 at 13:41, Philippe Mathieu-Daudé > > wrote: > > > On 1/17/19 12:50 AM, Samuel Thibault wrote: > > > > --- a/slirp/slirp.c > > > > +++ b/sli

[Qemu-devel] [RFC PATCH v3 43/43] Makefile: only support defconfig

2019-01-18 Thread Yang Zhong
add CONFIG_VHOST_USER and CONFIG_LINUX in Kconfig.host, the current Makefile only support defconfig because of randconfig does not work. Signed-off-by: Yang Zhong --- Kconfig.host | 6 ++ Makefile | 16 hw/block/Kconfig | 2 ++ hw/scsi/Kconfig | 2 ++ hw/tpm/

  1   2   3   4   5   >