Re: [Qemu-devel] [PATCH] net/colo-compare.c: Remove duplicated code

2019-01-15 Thread Jason Wang
On 2019/1/15 上午12:44, Philippe Mathieu-Daudé wrote: On 1/14/19 3:30 PM, Thomas Huth wrote: On 2019-01-14 15:05, Zhang Chen wrote: From: Zhang Chen Fix duplicated code: https://bugs.launchpad.net/qemu/+bug/1811499 Fixes: f449c9e549c Signed-off-by: Zhang Chen --- net/colo-compare.c | 8

Re: [Qemu-devel] [PATCH] vhost-user: fix qemu crash caused by failed backend

2019-01-15 Thread Marc-André Lureau
On Tue, Jan 15, 2019 at 7:59 AM Michael S. Tsirkin wrote: > > On Tue, Oct 02, 2018 at 01:54:25PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Thu, Sep 27, 2018 at 7:37 PM Liang Li wrote: > > > > > > During live migration, when stopping vhost-user device, 'vhost_dev_stop' > > > will be called

[Qemu-devel] [Bug 1785698] Re: Solaris build error: unknown type name ‘gcry_error_t’

2019-01-15 Thread Thomas Huth
Right, we've got a separate bug for libutil already, and as far as I can see, all the other problems here were due to using the non-POSIX compliant shell etc., so let's close this bug here and track the libutil problem in the other bug. ** Changed in: qemu Status: New => Invalid -- You re

Re: [Qemu-devel] [qemu-s390x] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs

2019-01-15 Thread Cornelia Huck
On Mon, 14 Jan 2019 13:44:12 -0500 "Jason J. Herne" wrote: > On 1/7/19 2:02 PM, Jason J. Herne wrote: > >>> @@ -190,6 +247,9 @@ struct ciw { > >>>   __u16 count; > >>>   }; > >>> +#define CU_TYPE_VIRTIO  0x3832 > >>> +#define CU_TYPE_DASD0x3990 > >> > >> No other dasd ty

[Qemu-devel] [Bug 1777252] Re: tests/Makefile.include trying to add linking library '-lutil' that break the build on Solaris

2019-01-15 Thread Thomas Huth
Does something like this work for you? diff --git a/tests/Makefile.include b/tests/Makefile.include --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -777,7 +777,7 @@ tests/migration/initrd-stress.img: tests/migration/stress$(EXESUF) rm $(INITRD_WORK_DIR)/init rmdir $(I

Re: [Qemu-devel] [qemu-s390x] [PATCH v1] s390x/pci: Send correct event on hotplug.

2019-01-15 Thread Cornelia Huck
On Mon, 14 Jan 2019 21:59:58 +0100 David Hildenbrand wrote: > On 14.01.19 21:00, Collin Walling wrote: > > On 1/14/19 12:44 PM, Cornelia Huck wrote: > >> [restored cc:s] > >> > >> On Mon, 14 Jan 2019 11:06:19 +0100 > >> Pierre Morel wrote: > >> > >>> On 11/01/2019 10:38, Cornelia Huck wrote:

Re: [Qemu-devel] [PATCH v1] s390x/pci: Send correct event on hotplug.

2019-01-15 Thread Cornelia Huck
On Thu, 10 Jan 2019 22:03:58 +0100 David Hildenbrand wrote: > Comit 2c28c490571f ("s390x/pci: let pci devices start in configured mode") > changed the initial state of zPCI devices from ZPCI_FS_STANDBY to > ZPCI_FS_DISABLED (a.k.a. configured). However we still only send a > HP_EVENT_RESERVED_TO_

[Qemu-devel] [Bug 1811782] [NEW] QEMU Windows fails to mount rootfs on an ISO where QEMU Linux works normally

2019-01-15 Thread Chris Ward
Public bug reported: I have installed QEMU 3.1.0 for Microsoft Windows from https://qemu.weilnetz.de/w64/ . When I give the command "qemu-system-x86_64.exe -cdrom ..\QemuSaver\freeduc2.iso", qemu boots the ISO, but the resulting Linux kernel panics when trying to mount the root file system. Run

Re: [Qemu-devel] [PATCH v3 04/19] nbd/server: Hoist length check to qemp_nbd_server_add

2019-01-15 Thread Vladimir Sementsov-Ogievskiy
12.01.2019 20:57, Eric Blake wrote: > We only had two callers to nbd_export_new; qemu-nbd.c always > passed a valid offset/length pair (because it already checked > the file length, to ensure that offset was in bounds), while > blockdev-nbd always passed 0/-1. Then nbd_export_new reduces > the siz

[Qemu-devel] [Bug 1811782] Re: QEMU Windows fails to mount rootfs on an ISO where QEMU Linux works normally

2019-01-15 Thread Chris Ward
This fails on Windows 7 and on Windows 10. I have had success with different ISO files. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1811782 Title: QEMU Windows fails to mount rootfs on an ISO whe

Re: [Qemu-devel] [RFC v2 0/4] QEMU changes to do PVH boot

2019-01-15 Thread Liam Merwick
Hi Stefano, On 10/01/2019 15:12, Stefano Garzarella wrote: On Wed, Jan 09, 2019 at 01:18:12PM -0800, Maran Wilson wrote: On 1/9/2019 11:53 AM, Boris Ostrovsky wrote: On 1/9/19 6:53 AM, Stefano Garzarella wrote: Hi Liam, On Tue, Jan 8, 2019 at 3:47 PM Liam Merwick wrote: QEMU sets the hvm_m

[Qemu-devel] [PATCH v2 0/4] pvh: add new PVH option rom

2019-01-15 Thread Stefano Garzarella
This patch series is based on "[RFC v2 0/4] QEMU changes to do PVH boot" and provides a PVH option rom that can be used with SeaBIOS to boot uncompressed kernel using the x86/HVM direct boot ABI. Patches 1 and 2 are to prepare the PVH option rom, moving common functions in a new header. Patch 3 a

[Qemu-devel] [PATCH v2 3/4] optionrom: add new PVH option rom

2019-01-15 Thread Stefano Garzarella
The new pvh.bin option rom can be used with SeaBIOS to boot uncompressed kernel using the x86/HVM direct boot ABI. pvh.S contains the entry point of the option rom. It runs in real mode, loads the e820 table querying the BIOS, and then it switches to 32bit protect mode and jump to the pvh_load_ker

[Qemu-devel] [PATCH v1] virtio: add checks for the size of the indirect table

2019-01-15 Thread Dima Stepanov
The virtqueue_pop() and virtqueue_get_avail_bytes() routines can use the INDIRECT table to get the data. It is possible to create a packet which will lead to the assert message like: include/exec/memory.h:1995: void address_space_read_cached(MemoryRegionCache *, hwaddr, void *, int): Assertio

[Qemu-devel] [PATCH v2 2/4] linuxboot_dma: move common functions in a new header

2019-01-15 Thread Stefano Garzarella
In order to allow other option roms to use these common useful functions and definitions, this patch put them in two new C header files called optrom.h and optrom_fw_cfg.h. We also add useful out*() in*() functions for different size, and new fw_cfg functions to use when DMA feature is not availabl

[Qemu-devel] [PATCH v2 4/4] hw/i386/pc: use PVH option rom

2019-01-15 Thread Stefano Garzarella
Use pvh.bin option rom when we are booting an uncompressed kernel using the x86/HVM direct boot ABI. Signed-off-by: Stefano Garzarella Based-on: <1545422632-2-5-git-send-email-liam.merw...@oracle.com> --- hw/i386/pc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/i386/pc.c b/hw

[Qemu-devel] [PATCH v2 1/4] linuxboot_dma: remove duplicate definitions of FW_CFG

2019-01-15 Thread Stefano Garzarella
FW_CFG_DMA_CTL_* bits and struct fw_cfg_dma_access are defined in the qemu_fw_cfg.h header file already included in linuxboot_dma.c, so we can remove the definition of BIOS_CFG_DMA_CTL_* and struct FWCfgDmaAccess. Signed-off-by: Stefano Garzarella Reviewed-by: Stefan Hajnoczi --- pc-bios/option

Re: [Qemu-devel] [PATCH] include/fpu/softfloat: Fix compilation with Clang on s390x

2019-01-15 Thread Peter Maydell
On Mon, 14 Jan 2019 at 22:48, Alex Bennée wrote: > > > Richard Henderson writes: > > But perhaps > > > > unsigned __int128 n = (unsigned __int128)n1 << 64 | n0; > > *r = n % d; > > return n / d; > > > > will allow the compiler to do what the assembly does for some 64-bit > > hosts. >

[Qemu-devel] [Bug 1811720] Re: storage physical_block_size is restricted to uint16_t

2019-01-15 Thread Коренберг Марк
Yes, you are right. Thanks for the response. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1811720 Title: storage physical_block_size is restricte

Re: [Qemu-devel] [PATCH v2 2/3] migration: fix memory leak when updating tls-creds and tls-hostname

2019-01-15 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Jan 11, 2019 at 02:37:31PM +0800, guangrong.x...@gmail.com wrote: > > From: Xiao Guangrong > > > > If we update parameter, tls-creds and tls-hostname, these string > > values are duplicated to local variables in migrate_params_test_apply() > > by us

Re: [Qemu-devel] [PATCH v3 05/19] nbd/server: Favor [u]int64_t over off_t

2019-01-15 Thread Vladimir Sementsov-Ogievskiy
12.01.2019 20:57, Eric Blake wrote: > Although our compile-time environment is set up so that we always > support long files with 64-bit off_t, we have no guarantee whether > off_t is the same type as int64_t. This requires casts when > printing values, and prevents us from directly using qemu_str

Re: [Qemu-devel] test-filter-mirror hangs

2019-01-15 Thread Peter Maydell
On Fri, 11 Jan 2019 at 16:15, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > Recently I've noticed that test-filter-mirror has been hanging > > intermittently, typically when run on some other TCG architecture. > > In the instance I've just looked at, this

Re: [Qemu-devel] [PATCH v1] virtio: add checks for the size of the indirect table

2019-01-15 Thread Philippe Mathieu-Daudé
On 1/15/19 11:08 AM, Dima Stepanov wrote: > The virtqueue_pop() and virtqueue_get_avail_bytes() routines can use the > INDIRECT table to get the data. It is possible to create a packet which > will lead to the assert message like: > include/exec/memory.h:1995: void > address_space_read_cached(M

Re: [Qemu-devel] [PATCH v1] virtio: add checks for the size of the indirect table

2019-01-15 Thread Cornelia Huck
On Tue, 15 Jan 2019 13:08:47 +0300 Dima Stepanov wrote: > The virtqueue_pop() and virtqueue_get_avail_bytes() routines can use the > INDIRECT table to get the data. It is possible to create a packet which > will lead to the assert message like: > include/exec/memory.h:1995: void > address_spa

Re: [Qemu-devel] [PATCH v1 4/8] RISC-V: Use riscv prefix consistently on cpu helpers

2019-01-15 Thread Philippe Mathieu-Daudé
Hi Alistair, On 1/15/19 12:58 AM, Alistair Francis wrote: > From: Michael Clark > > * Add riscv prefix to raise_exception function > * Add riscv prefix to CSR read/write functions > * Add riscv prefix to signal handler function > * Add riscv prefix to get fflags function > * Remove redundant dec

[Qemu-devel] [PATCH 1/2] qcow2: include LUKS payload overhead in qemu-img measure

2019-01-15 Thread Stefan Hajnoczi
LUKS encryption reserves clusters for its own payload data. The size of this area must be included in the qemu-img measure calculation so that we arrive at the correct minimum required image size. (Ab)use the qcrypto_block_create() API to determine the payload overhead. We discard the payload da

[Qemu-devel] [PATCH 0/2] qcow2: include LUKS payload overhead in qemu-img measure

2019-01-15 Thread Stefan Hajnoczi
The LUKS payload has a significant size (>1 MB). It must be included in the qemu-img measure calculation so we arrive at the correct minimum image size. Stefan Hajnoczi (2): qcow2: include LUKS payload overhead in qemu-img measure iotests: add LUKS payload overhead to 178 qemu-img measure tes

[Qemu-devel] [PATCH 2/2] iotests: add LUKS payload overhead to 178 qemu-img measure test

2019-01-15 Thread Stefan Hajnoczi
The previous patch includes the LUKS payload overhead into the qemu-img measure calculation for qcow2. Update qemu-iotests 178 to exercise this new code path. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/178 | 8 tests/qemu-iotests/178.out.qcow2 | 24 +++

Re: [Qemu-devel] [PULL 00/21] misc testing fixes for Travis and docker

2019-01-15 Thread Peter Maydell
On Mon, 14 Jan 2019 at 15:01, Alex Bennée wrote: > > The following changes since commit 7260438b7056469610ee166f7abe9ff8a26b8b16: > > Merge remote-tracking branch > 'remotes/palmer/tags/riscv-for-master-3.2-part2' into staging (2019-01-14 > 11:41:43 +) > > are available in the Git reposito

Re: [Qemu-devel] [PATCH 0/2] qcow2: include LUKS payload overhead in qemu-img measure

2019-01-15 Thread Philippe Mathieu-Daudé
On 1/15/19 12:10 PM, Stefan Hajnoczi wrote: > The LUKS payload has a significant size (>1 MB). It must be included in the > qemu-img measure calculation so we arrive at the correct minimum image size. > > Stefan Hajnoczi (2): > qcow2: include LUKS payload overhead in qemu-img measure > iotest

Re: [Qemu-devel] [qemu-s390x] [PATCH v2] configure: Only build the s390-ccw bios if the compiler supports -march=z900

2019-01-15 Thread Christian Borntraeger
On 14.01.2019 13:52, Thomas Huth wrote: > We want to build our s390-ccw bios with -march=z900 so that it also > works with the oldest s390x CPU that we support with TCG. However, > Clang on s390x does not support -march=z900 anymore, so we can not > use this compiler to build the s390-ccw bios.

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

2019-01-15 Thread Cornelia Huck
On Fri, 11 Jan 2019 17:58:00 +0100 Eric Auger wrote: > The code used to attach the eventfd handler for the ERR and > REQ irq indices can be factorized into a helper. In subsequent > patches we will extend this helper to support other irq indices. Looks like a nice refactoring to me. > > We tes

Re: [Qemu-devel] [PATCH 2/2] vfio-pci: Use vfio_register_event_notifier in vfio_intx_enable_kvm

2019-01-15 Thread Cornelia Huck
On Fri, 11 Jan 2019 17:58:01 +0100 Eric Auger wrote: > We can also use vfio_register_event_notifier() helper in > vfio_intx_enable_kvm to set the signalling associated to > VFIO_PCI_INTX_IRQ_INDEX. > > Signed-off-by: Eric Auger > --- > hw/vfio/pci.c | 38 +++---

[Qemu-devel] Profesjonalne Strony i Sklepy internetowe.

2019-01-15 Thread Strony, sklepy internetowe.
Dzień dobry, tworzymy nowoczesne */Stron i Sklepów WWW. /* Jeżeli chcieliby Państwo otrzymać propozycję w tym zakresie dla Państwa firmy prosimy o odpowiedź "*TAK"*. Serdecznie Pozdrawiamy

[Qemu-devel] [PATCH v3 0/4] QEMU changes to do PVH boot

2019-01-15 Thread Liam Merwick
For certain applications it is desirable to rapidly boot a KVM virtual machine. In cases where legacy hardware and software support within the guest is not needed, QEMU should be able to boot directly into the uncompressed Linux kernel binary with minimal firmware involvement. There already exists

[Qemu-devel] [PATCH v3 2/5] elf-ops.h: Add get_elf_note_type()

2019-01-15 Thread Liam Merwick
Introduce a routine which, given a pointer to a range of ELF Notes, searches through them looking for a note matching the type specified and returns a pointer to the matching ELF note. get_elf_note_type() is used by elf_load[32|64]() to find the specified note type required by the 'elf_note_fn' pa

[Qemu-devel] [PATCH v3 4/5] pvh: Boot uncompressed kernel using direct boot ABI

2019-01-15 Thread Liam Merwick
These changes (along with corresponding Linux kernel and qboot changes) enable a guest to be booted using the x86/HVM direct boot ABI. This commit adds a load_elfboot() routine to pass the size and location of the kernel entry point to qboot (which will fill in the start_info struct information ne

[Qemu-devel] [PATCH v3 3/5] pvh: Add x86/HVM direct boot ABI header file

2019-01-15 Thread Liam Merwick
From: Liam Merwick The x86/HVM direct boot ABI permits Qemu to be able to boot directly into the uncompressed Linux kernel binary with minimal firmware involvement. https://xenbits.xen.org/docs/unstable/misc/pvh.html This commit adds the header file that defines the start_info struct th

[Qemu-devel] [PATCH v3 1/5] elf: Add optional function ptr to load_elf() to parse ELF notes

2019-01-15 Thread Liam Merwick
This patch adds an optional function pointer, 'elf_note_fn', to load_elf() which causes load_elf() to additionally parse any ELF program headers of type PT_NOTE and check to see if the ELF Note is of the type specified by the 'translate_opaque' arg. If a matching ELF Note is found then the specfied

[Qemu-devel] [PATCH v3 5/5] pvh: load initrd and expose it through fw_cfg

2019-01-15 Thread Liam Merwick
From: Stefano Garzarella When initrd is specified, load and expose it to the guest firmware through fw_cfg. The firmware will fill the hvm_start_info for the kernel. Signed-off-by: Stefano Garzarella Based-on: <1545422632-2-5-git-send-email-liam.merw...@oracle.com> Signed-off-by: Liam Merwi

Re: [Qemu-devel] [PATCH 03/15] hw/ssi: Remove SSIBus from "qemu/typedefs.h"

2019-01-15 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > From: Philippe Mathieu-Daudé > > There are only three files requiring this typedef, let them > include "hw/ssi/ssi.h" directly to simplify "qemu/typedefs.h". > > To clean "qemu/typedefs.h", move the forward declaration > to "hw/ssi/ssi.h". > > Signed-off-by: Phil

Re: [Qemu-devel] [PATCH v3 06/19] qemu-nbd: Avoid strtol open-coding

2019-01-15 Thread Vladimir Sementsov-Ogievskiy
12.01.2019 20:57, Eric Blake wrote: > Our copy-and-pasted open-coding of strtol handling forgot to > handle overflow conditions. Use qemu_strto*() instead. > > In the case of --partition, since we insist on a user-supplied > partition to be non-zero, we can use 0 rather than -1 for our > initial

Re: [Qemu-devel] [PULL 00/44] pci, pc, virtio: fixes, features

2019-01-15 Thread Michael S. Tsirkin
On Tue, Jan 15, 2019 at 01:38:02PM +0800, Peter Xu wrote: > On Mon, Jan 14, 2019 at 08:35:11PM -0500, Michael S. Tsirkin wrote: > > The following changes since commit 89bd861c2b470e3fb45596945509079c72af3ac2: > > > > Merge remote-tracking branch > > 'remotes/ehabkost/tags/x86-next-pull-request'

Re: [Qemu-devel] [PATCH v4 for-4.0 2/7] vhost-user: Support transferring inflight buffer between qemu and backend

2019-01-15 Thread Michael S. Tsirkin
On Tue, Jan 15, 2019 at 02:46:42PM +0800, Yongji Xie wrote: > On Tue, 15 Jan 2019 at 06:25, Michael S. Tsirkin wrote: > > > > On Wed, Jan 09, 2019 at 07:27:23PM +0800, elohi...@gmail.com wrote: > > > @@ -382,6 +397,30 @@ If VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD protocol > > > feature is negotiated,

Re: [Qemu-devel] [PATCH for-4.0 v9 09/16] qemu_thread: supplement error handling for pci_edu_realize

2019-01-15 Thread Markus Armbruster
Fei Li writes: > 在 2019/1/14 下午8:36, Markus Armbruster 写道: >> Fei Li writes: >> >>> Just to make sure about how to do the cleanup. I notice that in >>> device_set_realized(), >>> the current code does not call "dc->unrealize(dev, NULL);" when >>> dc->realize() fails. > Sorry that I am still un

Re: [Qemu-devel] [PATCH 03/15] hw/ssi: Remove SSIBus from "qemu/typedefs.h"

2019-01-15 Thread Thomas Huth
On 2019-01-15 13:28, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> From: Philippe Mathieu-Daudé >> >> There are only three files requiring this typedef, let them >> include "hw/ssi/ssi.h" directly to simplify "qemu/typedefs.h". >> >> To clean "qemu/typedefs.h", move the forward

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

2019-01-15 Thread Auger Eric
Hi Cornelia, On 1/15/19 1:03 PM, Cornelia Huck wrote: > On Fri, 11 Jan 2019 17:58:00 +0100 > Eric Auger wrote: > >> The code used to attach the eventfd handler for the ERR and >> REQ irq indices can be factorized into a helper. In subsequent >> patches we will extend this helper to support other

Re: [Qemu-devel] [PATCH 2/2] vfio-pci: Use vfio_register_event_notifier in vfio_intx_enable_kvm

2019-01-15 Thread Auger Eric
Hi Cornelia, On 1/15/19 1:12 PM, Cornelia Huck wrote: > On Fri, 11 Jan 2019 17:58:01 +0100 > Eric Auger wrote: > >> We can also use vfio_register_event_notifier() helper in >> vfio_intx_enable_kvm to set the signalling associated to >> VFIO_PCI_INTX_IRQ_INDEX. >> >> Signed-off-by: Eric Auger >>

Re: [Qemu-devel] [PATCH v1] virtio: add checks for the size of the indirect table

2019-01-15 Thread Dima Stepanov
On Tue, Jan 15, 2019 at 11:40:09AM +0100, Cornelia Huck wrote: > On Tue, 15 Jan 2019 13:08:47 +0300 > Dima Stepanov wrote: > > > The virtqueue_pop() and virtqueue_get_avail_bytes() routines can use the > > INDIRECT table to get the data. It is possible to create a packet which > > will lead to th

Re: [Qemu-devel] [PULL v2 00/27] ivshmem deprecation, qtests, typedefs and gnu99

2019-01-15 Thread Peter Maydell
On Mon, 14 Jan 2019 at 17:45, Thomas Huth wrote: > > Hi Peter! > > The following changes since commit 7260438b7056469610ee166f7abe9ff8a26b8b16: > > Merge remote-tracking branch > 'remotes/palmer/tags/riscv-for-master-3.2-part2' into staging (2019-01-14 > 11:41:43 +) > > are available in t

Re: [Qemu-devel] [PATCH v3 10/19] nbd/client: Split out nbd_send_one_meta_context()

2019-01-15 Thread Vladimir Sementsov-Ogievskiy
12.01.2019 20:58, Eric Blake wrote: > Refactor nbd_negotiate_simple_meta_context() to pull out the > code that can be reused to send a LIST request for 0 or 1 query. > No semantic change. The old comment about 'sizeof(uint32_t)' > being equivalent to '/* number of queries */' is no longer > needed

[Qemu-devel] Crash when deleting an iothread that is being used

2019-01-15 Thread Alberto Garcia
Here's how to reproduce the crash: { "execute": "qmp_capabilities" } { "execute": "blockdev-add", "arguments": {"driver": "null-co", "node-name": "hd0"}} { "execute": "object-add", "arguments": {"qom-type": "iothread", "id": "iothread0"}} { "execute": "x-blockdev-set-iothread", "arguments": {"no

Re: [Qemu-devel] [PATCH v1] virtio: add checks for the size of the indirect table

2019-01-15 Thread Cornelia Huck
On Tue, 15 Jan 2019 16:11:19 +0300 Dima Stepanov wrote: > On Tue, Jan 15, 2019 at 11:40:09AM +0100, Cornelia Huck wrote: > > On Tue, 15 Jan 2019 13:08:47 +0300 > > Dima Stepanov wrote: > > > > > The virtqueue_pop() and virtqueue_get_avail_bytes() routines can use the > > > INDIRECT table to g

Re: [Qemu-devel] [PATCH v2] s390x/pci: Set the iommu region size mpcifc request

2019-01-15 Thread Cornelia Huck
On Thu, 10 Jan 2019 14:00:07 +0100 Pierre Morel wrote: > The size of the accessible iommu memory region in the guest > is given to the IOMMU by the guest through the mpcifc request > specifying the PCI Base Address and the PCI Address Limit. > > Let set the size of the IOMMU region to: s/Let/Le

[Qemu-devel] [RFC PATCH v2 23/37] build: convert pci.mak to Kconfig

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini Instead of including the same list of devices for each target, set CONFIG_PCI to true, and make the devices default to present whenever PCI is available. Done mostly with the following script: while read i; do i=${i%=y}; i=${i#CONFIG_} sed -i -e'/^config '$i'$/!b

Re: [Qemu-devel] [Qemu-block] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-15 Thread Stefan Hajnoczi
On Mon, Jan 14, 2019 at 09:56:28PM +0100, Alberto Garcia wrote: > On Mon 14 Jan 2019 05:31:17 PM CET, Stefan Hajnoczi > wrote: > > On Mon, Jan 14, 2019 at 05:26:48PM +0100, Alberto Garcia wrote: > >> On Mon 14 Jan 2019 05:15:25 PM CET, Stefan Hajnoczi wrote: > >> >> > I've been able to reproduce

[Qemu-devel] [RFC PATCH v2 31/37] ptimer: express dependencies with Kconfig

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong --- hw/Kconfig | 2 ++ hw/net/Kconfig | 2 ++ hw/timer/Kconfig | 6 ++ 3 files changed, 10 insertions(+) diff --git a/hw/Kconfig b/hw/Kconfig index 55743a958a..f9d88986a0 100644 --- a/hw/Kconfig +++ b/hw/Kc

[Qemu-devel] [RFC PATCH v2 32/37] edid: express dependencies with kconfig

2019-01-15 Thread Yang Zhong
Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- hw/display/Kconfig | 2 ++ hw/i2c/Kconfig | 1 + 2 files changed, 3 insertions(+) diff --git a/hw/display/Kconfig b/hw/display/Kconfig index 7a9d121772..933793cc13 100644 --- a/hw/display/Kconfig +++ b/hw/display/Kconfig @@ -38,6 +38,7

[Qemu-devel] [RFC PATCH v2 37/37] Makefile: only support defconfig

2019-01-15 Thread Yang Zhong
add CONFIG_VHOST_USER and CONFIG_LINUX in Kconfig.host, the current Makefile only support defconfig because of randconfig does not work. Signed-off-by: Yang Zhong --- Kconfig.host | 6 ++ Makefile | 16 hw/block/Kconfig | 2 ++ hw/scsi/Kconfig | 2 ++ hw/tpm/

Re: [Qemu-devel] [PATCH v4 for-4.0 2/7] vhost-user: Support transferring inflight buffer between qemu and backend

2019-01-15 Thread Yongji Xie
On Tue, 15 Jan 2019 at 20:54, Michael S. Tsirkin wrote: > > On Tue, Jan 15, 2019 at 02:46:42PM +0800, Yongji Xie wrote: > > On Tue, 15 Jan 2019 at 06:25, Michael S. Tsirkin wrote: > > > > > > On Wed, Jan 09, 2019 at 07:27:23PM +0800, elohi...@gmail.com wrote: > > > > @@ -382,6 +397,30 @@ If VHOST

[Qemu-devel] [RFC PATCH v2 28/37] isa: express dependencies with kconfig

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong --- default-configs/i386-softmmu.mak | 10 -- hw/audio/Kconfig | 2 ++ hw/block/Kconfig | 2 ++ hw/char/Kconfig | 6 ++ hw/display/Kconfig |

[Qemu-devel] [RFC PATCH v2 36/37] minikconf: implement allyesconfig, allnoconfig, randconfig, defconfig

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini Apart from defconfig (which is a no-op), the others are implemented implemented simply by ignoring the RHS of assignments and "default" statements. The RHS is replaced respectively by "true", "false" or a random value. Signed-off-by: Paolo Bonzini --- Makefile

[Qemu-devel] [RFC PATCH v2 34/37] virtio: make virtio dependencies with Kconfig

2019-01-15 Thread Yang Zhong
Signed-off-by: Yang Zhong --- default-configs/i386-softmmu.mak | 1 - default-configs/s390x-softmmu.mak | 1 - default-configs/virtio.mak| 14 -- hw/9pfs/Kconfig | 2 ++ hw/block/Kconfig | 2 ++ hw/char/Kconfig | 2 ++

[Qemu-devel] [RFC PATCH v2 24/37] build: convert sound.mak to Kconfig

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini There is really nothing special in these devices; they are just ISA devices. Instead of including them for each target, set CONFIG_ISA to true, and make the devices default to present whenever ISA is available. More conversion of ISA devices will follow. Done with the follo

[Qemu-devel] [RFC PATCH v2 29/37] i386: express dependencies with Kconfig

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini This way, the default-configs file only need to specify the boards and any optional devices. Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong --- default-configs/i386-softmmu.mak | 39 hw/acpi/Kconfig | 3 ++ hw/display/Kconfig

[Qemu-devel] [RFC PATCH v2 33/37] hyperv: express dependencies with kconfig

2019-01-15 Thread Yang Zhong
remove default-configs/hyperv.mak and make dependencies with Kconfig. Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- default-configs/hyperv.mak | 2 -- default-configs/i386-softmmu.mak | 1 - hw/hyperv/Kconfig| 4 3 files changed, 4 insertions(+), 3 deletions(

[Qemu-devel] [RFC PATCH v2 35/37] i386-softmmu.mak: remove all CONFIG_* except boards definitions

2019-01-15 Thread Yang Zhong
%-softmmu.mak only keep boards definitions in Kconfig mode. Signed-off-by: Yang Zhong --- default-configs/i386-softmmu.mak | 22 -- hw/acpi/Kconfig | 4 hw/i386/Kconfig | 5 + hw/ipmi/Kconfig | 6 ++ hw/mem/Kc

[Qemu-devel] [RFC PATCH v2 19/37] kconfig: introduce kconfig files

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini The Kconfig files were generated mostly with this script: for i in `grep -ho CONFIG_[A-Z0-9_]* default-configs/* | sort -u`; do set fnord `git grep -lw $i -- 'hw/*/Makefile.objs' ` shift if test $# = 1; then cat >> $(dirname $1)/Kconfig << EOF config ${i#C

[Qemu-devel] [RFC PATCH v2 27/37] bluetooth: express dependencies with Kconfig

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- hw/Makefile.objs | 2 +- hw/usb/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/Makefile.objs b/hw/Makefile.objs index 39d882af6f..b95b0c74a1 100644 --- a/

[Qemu-devel] [RFC PATCH v2 21/37] ide: express dependencies with Kconfig

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini Signed-off-by: Paolo Bonzini --- default-configs/alpha-softmmu.mak | 2 -- default-configs/pci.mak | 3 --- hw/ide/Kconfig| 15 +++ 3 files changed, 15 insertions(+), 5 deletions(-) diff --git a/default-configs/alpha-softmmu.mak

[Qemu-devel] [RFC PATCH v2 30/37] i2c: express dependencies with Kconfig

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong --- default-configs/i386-softmmu.mak | 1 - hw/Makefile.objs | 2 +- hw/audio/Kconfig | 1 + hw/display/Kconfig | 3 +++ hw/gpio/Kconfig | 1 + hw/i2c/Kconf

[Qemu-devel] [RFC PATCH v2 22/37] hw/pci/Makefile.objs: make pcie configurable

2019-01-15 Thread Yang Zhong
Make pcie splited from pci and make it configurable. Signed-off-by: Yang Zhong --- default-configs/pci.mak | 1 + hw/pci/Kconfig | 3 +++ hw/pci/Makefile.objs| 5 +++-- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/default-configs/pci.mak b/default-configs/pci.mak i

[Qemu-devel] [RFC PATCH v2 16/37] minikconfig: add AST

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini Add Python classes that represent the Kconfig abstract syntax tree. The abstract syntax tree is stored as a list of clauses. For example: config FOO depends on BAR select BAZ is represented as three clauses: FOO depends on BAR FOO default n

[Qemu-devel] [RFC PATCH v2 14/37] hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64

2019-01-15 Thread Yang Zhong
Add the new configs to default-configs/sparc64-sofmmu.mak. Signed-off-by: Yang Zhong --- default-configs/sparc64-softmmu.mak | 2 ++ hw/sparc64/Makefile.objs| 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/default-configs/sparc64-softmmu.mak b/default-confi

[Qemu-devel] [RFC PATCH v2 25/37] build: convert usb.mak to Kconfig

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini Instead of including the same list of devices for each target, let the host controllers select CONFIG_USB and make the devices default to present whenever USB is available. Done with the following script: while read i; do i=${i%=y}; i=${i#CONFIG_} sed -i -e'/^conf

[Qemu-devel] [RFC PATCH v2 18/37] hw/display: make edid configurable

2019-01-15 Thread Yang Zhong
Use CONFIG_EDID to make edid-generate.c and edid-region.c configurable. Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- default-configs/pci.mak | 1 + hw/display/Makefile.objs | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/default-configs/pci.mak b/default-conf

[Qemu-devel] [RFC PATCH v2 11/37] hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally

2019-01-15 Thread Yang Zhong
From: Ákos Kovács Add the new CONFIG_* values to default-config/xtensa*-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini --- default-configs/xtensa-softmmu.mak | 3 +++ default-configs/xtensaeb-softmmu.mak | 3 +++ hw/xtensa/Makefile.objs | 4 ++-- 3 files c

[Qemu-devel] [RFC PATCH v2 08/37] hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device

2019-01-15 Thread Yang Zhong
From: Ákos Kovács Make hw/sh4 configurable and add new CONFIG_* to the default-configs/sh4*-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini --- default-configs/sh4-softmmu.mak | 3 +++ default-configs/sh4eb-softmmu.mak | 3 +++ hw/sh4/Makefile.objs | 6 +++

[Qemu-devel] [RFC PATCH v2 26/37] scsi: express dependencies with Kconfig

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini This lets you disable SCSI altogether with "CONFIG_SCSI=n". Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong --- hw/scsi/Kconfig | 12 hw/scsi/Makefile.objs | 2 +- hw/usb/Kconfig| 2 ++ 3 files changed, 15 insertions(+), 1 deletion(-) d

[Qemu-devel] [RFC PATCH v2 13/37] hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards

2019-01-15 Thread Yang Zhong
Add the new configs to default-configs/riscv*-sofmmu.mak. Signed-off-by: Yang Zhong --- default-configs/riscv32-softmmu.mak | 6 ++ default-configs/riscv64-softmmu.mak | 6 ++ hw/riscv/Makefile.objs | 22 +++--- 3 files changed, 23 insertions(+), 11 deletio

[Qemu-devel] [RFC PATCH v2 09/37] hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created

2019-01-15 Thread Yang Zhong
From: Ákos Kovács CONFIG_LEON3 added to default-configs/sparc-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini --- default-configs/sparc-softmmu.mak | 2 ++ hw/sparc/Makefile.objs| 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/default-co

[Qemu-devel] [RFC PATCH v2 06/37] hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards

2019-01-15 Thread Yang Zhong
From: Ákos Kovács Add the new configs to default-configs/mips*-sofmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong --- default-configs/mips-softmmu-common.mak | 4 default-configs/mips64el-softmmu.mak| 1 - hw/mips/Makefile.objs

[Qemu-devel] [RFC PATCH v2 20/37] build: switch to Kconfig

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini The make_device_config.sh script is replaced by minikconf, which is modified to support the same command line as its predecessor. The roots of the parsing are default-configs/*.mak, Kconfig.host and hw/Kconfig. One difference with make_device_config.sh is that all symbols ha

[Qemu-devel] [RFC PATCH v2 12/37] hw/nios2/Makefile.objs: Conditionally build nios2

2019-01-15 Thread Yang Zhong
CONFIG_NIOS2_10M50_BOARD added for 10m50 dev board. Signed-off-by: Yang Zhong --- default-configs/nios2-softmmu.mak | 1 + hw/nios2/Makefile.objs| 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/default-configs/nios2-softmmu.mak b/default-configs/nios2-softmmu.m

[Qemu-devel] [RFC PATCH v2 00/37] Support Kconfig in QEMU

2019-01-15 Thread Yang Zhong
This Kconfig implementation is rebased from Paolo's branch https://github.com/bonzini/qemu/commits/kconfig I rebased most of patches except other ARCHs board definitions this time. https://github.com/yangzhon/qemu/commits/topic/upstream/Kconfig The current RFC patches only support (*) x86_64 plat

Re: [Qemu-devel] [PULL 0/5] gitdm updates with final 2018 stats

2019-01-15 Thread Peter Maydell
On Mon, 14 Jan 2019 at 16:09, Alex Bennée wrote: > > The following changes since commit 7260438b7056469610ee166f7abe9ff8a26b8b16: > > Merge remote-tracking branch > 'remotes/palmer/tags/riscv-for-master-3.2-part2' into staging (2019-01-14 > 11:41:43 +) > > are available in the Git reposito

[Qemu-devel] [RFC PATCH v2 01/37] build: actually use CONFIG_PAM

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini Do not link it unconditionally into all binaries. Signed-off-by: Paolo Bonzini --- default-configs/i386-softmmu.mak | 1 + hw/pci-host/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/default-configs/i386-softmmu.mak b/default-confi

[Qemu-devel] [RFC PATCH v2 07/37] hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*

2019-01-15 Thread Yang Zhong
From: Ákos Kovács CONFIG_PPC405, CONFIG_PPC440, CONFIG_MAC_OLDWORLD, CONFIG_MAX_NEWWORLD and CONFIG_VIRTEX configuration options created for default-configs/ppc*-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong --- default-configs/ppc-softmmu.mak

[Qemu-devel] [RFC PATCH v2 17/37] minikconfig: add semantic analysis

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini There are three parts in the semantic analysis: 1) evaluating expressions. This is done as a simple visit of the Expr nodes. 2) ordering clauses. This is done by constructing a graph of variables. There is an edge from X to Y if Y depends on X, if X selects Y, or if X appe

Re: [Qemu-devel] [PULL v2 00/27] ivshmem deprecation, qtests, typedefs and gnu99

2019-01-15 Thread Thomas Huth
On 2019-01-15 14:16, Peter Maydell wrote: > On Mon, 14 Jan 2019 at 17:45, Thomas Huth wrote: >> >> Hi Peter! >> >> The following changes since commit 7260438b7056469610ee166f7abe9ff8a26b8b16: >> >> Merge remote-tracking branch >> 'remotes/palmer/tags/riscv-for-master-3.2-part2' into staging (2

[Qemu-devel] [RFC PATCH v2 05/37] hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards

2019-01-15 Thread Yang Zhong
From: Ákos Kovács CONFIG_PETALOGIX_* and CONFIG_XLNX_* configs added to default-configs/microblaze-softmmu.mak and default-configs/microblazeel-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini --- default-configs/microblaze-softmmu.mak | 3 +++ hw/microblaze/Makefile.objs

[Qemu-devel] [RFC PATCH v2 15/37] minikconfig: add parser skeleton

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini This implements a scanner and recursive descent parser for Kconfig-like configuration files. The only "action" of the parser is for now to detect undefined variables and process include files. The main differences between Kconfig and this are: * only the "bool" type is supp

Re: [Qemu-devel] [PATCH v1] virtio: add checks for the size of the indirect table

2019-01-15 Thread Stefan Hajnoczi
On Tue, Jan 15, 2019 at 01:08:47PM +0300, Dima Stepanov wrote: > The virtqueue_pop() and virtqueue_get_avail_bytes() routines can use the > INDIRECT table to get the data. It is possible to create a packet which > will lead to the assert message like: > include/exec/memory.h:1995: void > addres

Re: [Qemu-devel] [Qemu-block] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-15 Thread Alberto Garcia
On Tue 15 Jan 2019 03:18:00 PM CET, Stefan Hajnoczi wrote: >> So if my understanding is correct QEMU can be shut down when there >> are iothreads waiting for a mutex. Is that something that we should >> be worried about? > > Nothing joins the iothreads in vl.c:main(). > > The assumption is that any

[Qemu-devel] [RFC PATCH v2 10/37] hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst

2019-01-15 Thread Yang Zhong
From: Ákos Kovács CONFIG_LM32 and CONFIG_MILKYMIST added for lm32 and milkmyst build. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini --- hw/lm32/Makefile.objs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/lm32/Makefile.objs b/hw/lm32/Makefile.objs index e

[Qemu-devel] [RFC PATCH v2 03/37] hw/arm/Makefile.objs: CONFIG_VIRT created for virt board

2019-01-15 Thread Yang Zhong
make virt code configurable and the new CONFIG_VIRT definitions added to the default-configs/arm-softmmu.mak to replace CONFIG_ACPI in arm board. Signed-off-by: Yang Zhong --- default-configs/arm-softmmu.mak | 2 +- hw/arm/Makefile.objs| 4 ++-- 2 files changed, 3 insertions(+), 3 de

[Qemu-devel] [PATCH 07/12] chardev: split tcp_chr_wait_connected into two methods

2019-01-15 Thread Daniel P . Berrangé
The tcp_chr_wait_connected method can deal with either server or client chardevs, but some callers only care about one of these possibilities. The tcp_chr_wait_connected method will also need some refactoring to reliably deal with its primary goal of allowing a device frontend to wait for an establ

[Qemu-devel] [RFC PATCH v2 02/37] hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards

2019-01-15 Thread Yang Zhong
From: Paolo Bonzini CONFIG_PIIX and CONFIG_Q35 created for the pc board object files. These are enabled automatically at default-configs/i386-softmmu.mak and default-configs/x86_64-softmmu.mak Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-config

[Qemu-devel] [RFC PATCH v2 04/37] hw/m68k/Makefile.objs: Conditionally build boards

2019-01-15 Thread Yang Zhong
From: Ákos Kovács CONFIG_AN5206, CONFIG_MCF5206 and CONFIG_MCF5208 make variables created for m68k boards, and added to default-configs/m86k-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini --- default-configs/m68k-softmmu.mak | 3 +++ hw/m68k/Makefile.objs| 5

[Qemu-devel] [PATCH 12/12] chardev: fix race with client connections in tcp_chr_wait_connected

2019-01-15 Thread Daniel P . Berrangé
When the 'reconnect' option is given for a client connection, the qmp_chardev_open_socket_client method will run an asynchronous connection attempt. The QIOChannel socket executes this is a single use background thread, so the connection will succeed immediately (assuming the server is listening).

  1   2   3   4   >