Re: [Qemu-devel] [PATCH v5 02/11] block/dirty-bitmap: remove assertion from restore

2018-12-20 Thread Vladimir Sementsov-Ogievskiy
20.12.2018 5:29, John Snow wrote: > When making a backup of a dirty bitmap (for transactions), we want to > restore that backup whether or not the bitmap is enabled or not. > > It is perfectly valid to write into bitmaps that are disabled. It is > only illegitimate for the guest to have done so. >

Re: [Qemu-devel] Question about aio_poll and glib aio_ctx_dispatch

2018-12-20 Thread Li Qiang
Fam Zheng 于2018年12月20日周四 上午9:26写道: > > > > On Dec 20, 2018, at 06:58, Li Qiang wrote: > > > > Hello Paolo > > > > Thanks for your kind reply. > > > > Yes, aio_poll and aio_ctx_dispatch mostly run in different threads, > though > > Sometimes they can run in a thread nested from Fam’s slides: > >

[Qemu-devel] [PATCH v1 0/1] migration: add incremental mode on drive-mirror

2018-12-20 Thread mahaocong
From: mahaocong This patch adds possibility to start mirroring with user-created-bitmap. The use-case is, for live migration with ceph rbd image. I think the new function may be used to reduce the initial dirty block number on drive-mirror by using user-created-bitmap instead of created from bloc

[Qemu-devel] [PATCH v1 1/1] add incremental mode on drive-mirror

2018-12-20 Thread mahaocong
From: mahaocong Signed-off-by: mahaocong --- block/dirty-bitmap.c | 14 ++ block/mirror.c | 63 +++- blockdev.c | 36 +++-- include/block/block_int.h| 3 ++- include/block/dirty-bitm

[Qemu-devel] [PATCH v2] ui/cocoa: Include less of the generated modular QAPI headers

2018-12-20 Thread Markus Armbruster
Avoids pointless recompilation. Missed in commit 112ed241f5d. Signed-off-by: Markus Armbruster --- ui/cocoa.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index ecf12bfc2e..ddc058e76e 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -32,7 +32,8 @@ #i

Re: [Qemu-devel] [PATCH v4 3/5] iotests: change qmp_log filters to expect QMP objects only

2018-12-20 Thread Vladimir Sementsov-Ogievskiy
19.12.2018 21:35, John Snow wrote: > > > On 12/19/18 6:07 AM, Vladimir Sementsov-Ogievskiy wrote: >> 19.12.2018 4:52, John Snow wrote: >>> log() treats filters as if they can always filter its primary argument. >>> qmp_log treats filters as if they're always text. >>> >>> Change qmp_log to treat

Re: [Qemu-devel] [PATCH v5 03/11] blockdev: n-ary bitmap merge

2018-12-20 Thread Vladimir Sementsov-Ogievskiy
20.12.2018 5:29, John Snow wrote: > Especially outside of transactions, it is helpful to provide > all-or-nothing semantics for bitmap merges. This facilitates > the coalescing of multiple bitmaps into a single target for > the "checkpoint" interpretation when assembling bitmaps that > represent ar

Re: [Qemu-devel] [PATCH v4 3/5] iotests: change qmp_log filters to expect QMP objects only

2018-12-20 Thread Vladimir Sementsov-Ogievskiy
19.12.2018 22:52, John Snow wrote: > > > On 12/19/18 2:01 PM, Eric Blake wrote: >> On 12/19/18 5:27 AM, Vladimir Sementsov-Ogievskiy wrote: >> >>> But still not sure that it worth it. Isn't it better to just remove >>> fields from dict, >>> which are unpredictable, instead of substituting them..

Re: [Qemu-devel] [QEMU-devel][PATCH v3] aio-posix: Fix concurrent aio_poll/set_fd_handler.

2018-12-20 Thread Remy NOEL
On 12/19/18 8:32 PM, Paolo Bonzini wrote: You found another bug then. :) K. Will fix.

Re: [Qemu-devel] [PATCH] disas/microblaze: Remove unused REG_SP macro

2018-12-20 Thread Philippe Mathieu-Daudé
On 12/20/18 5:33 AM, Richard Henderson wrote: > This causes a build error with debian sid, riscv64 host: > > disas/microblaze.c:179: error: "REG_SP" redefined [-Werror] > #define REG_SP 1 /* stack pointer */ > > In file included from /usr/include/signal.h:306, > from include/qe

Re: [Qemu-devel] [PATCH v5 07/11] iotests: add qmp recursive sorting function

2018-12-20 Thread Vladimir Sementsov-Ogievskiy
20.12.2018 5:29, John Snow wrote: > Python before 3.6 does not sort dictionaries (including kwargs). > Therefore, printing QMP objects involves sorting the keys to have > a predictable ordering in the iotests output. > > However, if we want to pretty-print QMP objects being sent to the > QEMU proc

[Qemu-devel] [PULL 0/2] Miscellaneous patches for 2018-12-20

2018-12-20 Thread Markus Armbruster
The following changes since commit b72566a4ffaddbc0c0c1f6f5ee91b42ab13ff429: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2018-12-19 15:31:02 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-misc-201

[Qemu-devel] [PULL 2/2] build: Remake config-host.mak when VERSION changes

2018-12-20 Thread Markus Armbruster
configure gets the version number from VERSION, and writes it to config-host.mak. The make dependency for that is missing. Because of that, a rebuild after a VERSION change may not pick up the change. Fix that. Signed-off-by: Markus Armbruster Message-Id: <20181214084754.23854-1-arm...@redhat.c

[Qemu-devel] [PULL 1/2] Clean up includes

2018-12-20 Thread Markus Armbruster
Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes, with the changes to the following files manually reverted: contrib/libvhost-user/libvhost-user-glib.h contrib/libvhost-user/libv

Re: [Qemu-devel] [PATCH] iotests.py: rework log and qmp_log

2018-12-20 Thread Vladimir Sementsov-Ogievskiy
ignore it, the work continues in John's series "bitmaps: remove x- prefix from QMP api" -- Best regards, Vladimir

Re: [Qemu-devel] [PATCH v5 08/11] iotests: remove default filters from qmp_log

2018-12-20 Thread Vladimir Sementsov-Ogievskiy
20.12.2018 5:29, John Snow wrote: > Several places in iotests deal with serializing objects into JSON > strings, but to add pretty-printing it seems desireable to localize > all of those cases. > > log() seems like a good candidate for that centralized behavior. > log() can already serialize json

Re: [Qemu-devel] [PATCH v2 0/3] q35: change defaults for kernel irqchip and IR

2018-12-20 Thread Paolo Bonzini
On 20/12/18 06:40, Peter Xu wrote: > For old versions of QEMU: we used machine compat properties. > > For old kernels (<4.4): if user didn't specify split kernel irqchip, > we'll take it only as the first priority if it's supported by the > kernel; otherwise, we will continue with complete kernel

Re: [Qemu-devel] [PULL v2 00/35] Misc patches for 2018-12-18

2018-12-20 Thread Paolo Bonzini
On 20/12/18 00:10, Peter Maydell wrote: > I get a compile failure on my OSX system: > > CC tests/test-crypto-pbkdf.o > /Users/pm215/src/qemu-for-merges/tests/test-crypto-pbkdf.c:444:17: > error: too few arguments to function call, single argument 'msg' was > not specified > g_test_skip(

Re: [Qemu-devel] [PATCH v2] ui/cocoa: Include less of the generated modular QAPI headers

2018-12-20 Thread Philippe Mathieu-Daudé
On 12/20/18 9:45 AM, Markus Armbruster wrote: > Avoids pointless recompilation. Missed in commit 112ed241f5d. > > Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > ui/cocoa.m | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(

Re: [Qemu-devel] [PATCH v2 0/3] q35: change defaults for kernel irqchip and IR

2018-12-20 Thread Peter Xu
On Thu, Dec 20, 2018 at 11:00:21AM +0100, Paolo Bonzini wrote: > On 20/12/18 06:40, Peter Xu wrote: > > For old versions of QEMU: we used machine compat properties. > > > > For old kernels (<4.4): if user didn't specify split kernel irqchip, > > we'll take it only as the first priority if it's sup

[Qemu-devel] [RFC PATCH] fpu: add compile time check for old glibc/libm and fma

2018-12-20 Thread Alex Bennée
Some versions of glibc have been reported to have problems with fused-multiply-accumulate operations. If the underlying fma implementation does a two step operation it will instroduce subtle rounding errors. Newer versions of the library seem to deal with this better and modern hardware has fused o

[Qemu-devel] did the qemu can emulate the whole system with the processor that without support the "virtulization and kvm"?

2018-12-20 Thread tugouxp
hi folks: did the qemu can emulate the whole system(such as ubuntu) with the processor that without support the "virtulization and kvm"? thanks for your kindly support.

Re: [Qemu-devel] [PATCH] tests/tcg: add barrier test for ARM

2018-12-20 Thread Alex Bennée
Alex Bennée writes: > This is a port of my kvm-unit-tests barrier test. A couple of things > are done in a more user-space friendly way but the tests are the same. > > Signed-off-by: Alex Bennée > + > +# Barrier tests need atomic definitions, steal QEMUs > +barrier: CFLAGS+=-I$(SRC_PATH)/incl

Re: [Qemu-devel] Monitor and serial output window broken with SDL2

2018-12-20 Thread BALATON Zoltan
On Thu, 20 Dec 2018, Gerd Hoffmann wrote: On Wed, Dec 19, 2018 at 07:11:34PM +0100, BALATON Zoltan wrote: On Wed, 19 Dec 2018, Daniel P. Berrangé wrote: On Tue, Dec 18, 2018 at 08:05:59PM +0100, BALATON Zoltan wrote: On Tue, 18 Dec 2018, Daniel P. Berrangé wrote: I don't see any difference de

Re: [Qemu-devel] [PATCH] docker: Use a stable snapshot for Debian Sid

2018-12-20 Thread Philippe Mathieu-Daudé
Hi Fam, On 11/2/18 8:24 AM, Fam Zheng wrote: > On Fri, Nov 2, 2018 at 3:20 PM Philippe Mathieu-Daudé wrote: >> >> Hi Fam, >> >> Thanks for picking this. >> >> On Fri, Nov 2, 2018 at 7:48 AM Fam Zheng wrote: >>> On Thu, 11/01 19:37, Philippe Mathieu-Daudé wrote: The Debian Sid repository is

Re: [Qemu-devel] [PATCH v5 09/11] iotests: change qmp_log filters to expect QMP objects only

2018-12-20 Thread Vladimir Sementsov-Ogievskiy
20.12.2018 5:29, John Snow wrote: > As laid out in the previous commit's message: > > ``` > Several places in iotests deal with serializing objects into JSON > strings, but to add pretty-printing it seems desireable to localize > all of those cases. > > log() seems like a good candidate for that

Re: [Qemu-devel] [PATCH v5 10/11] iotests: implement pretty-print for log and qmp_log

2018-12-20 Thread Vladimir Sementsov-Ogievskiy
20.12.2018 5:29, John Snow wrote: > If iotests have lines exceeding >998 characters long, git doesn't > want to send it plaintext to the list. We can solve this by allowing > the iotests to use pretty printed QMP output that we can match against > instead. > > As a bonus, it's much nicer for human

Re: [Qemu-devel] [PULL v2 00/35] Misc patches for 2018-12-18

2018-12-20 Thread Philippe Mathieu-Daudé
On 12/20/18 12:10 AM, Peter Maydell wrote: > On Wed, 19 Dec 2018 at 15:21, Paolo Bonzini wrote: >> >> The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d: >> >> Merge remote-tracking branch >> 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18 >

Re: [Qemu-devel] [PATCH v2] ui/cocoa: Include less of the generated modular QAPI headers

2018-12-20 Thread Roman Bolshakov
On Thu, Dec 20, 2018 at 09:45:59AM +0100, Markus Armbruster wrote: > Avoids pointless recompilation. Missed in commit 112ed241f5d. > > Signed-off-by: Markus Armbruster > --- > ui/cocoa.m | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Roman Bolshakov Tested-by: Roman

Re: [Qemu-devel] [PULL 00/64] slirp updates

2018-12-20 Thread Marc-André Lureau
Hi On Wed, Dec 19, 2018 at 11:45 PM Peter Maydell wrote: > > On Tue, 18 Dec 2018 at 23:04, Samuel Thibault > wrote: > > > > The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d: > > > > Merge remote-tracking branch > > 'remotes/huth-gitlab/tags/pull-request-2018-12-17'

Re: [Qemu-devel] [PATCH] i386/kvm: expose HV_CPUID_ENLIGHTMENT_INFO.EAX and HV_CPUID_NESTED_FEATURES.EAX as feature words

2018-12-20 Thread Eduardo Habkost
On Wed, Dec 19, 2018 at 06:25:06PM +0100, Vitaly Kuznetsov wrote: > Eduardo Habkost writes: > > > On Mon, Dec 03, 2018 at 03:17:06PM +0100, Vitaly Kuznetsov wrote: > >> Eduardo Habkost writes: > > [...] > >> > But note that we might still be able to move the existing > >> > "hyperv_*" features t

Re: [Qemu-devel] [PATCH 2/9] tests: acpi: use AcpiSdtTable::aml in consistent way

2018-12-20 Thread Igor Mammedov
On Wed, 19 Dec 2018 17:02:36 -0200 Wainer dos Santos Moschetta wrote: > On 12/10/2018 04:10 PM, Igor Mammedov wrote: > > Currently in the 1st case we store table body fetched from QEMU in > > AcpiSdtTable::aml minus it's header but in the 2nd case when we > > load reference aml from disk, it hold

Re: [Qemu-devel] [PATCH -v2] target-i386: Reenable RDTSCP support on Opteron_G[345] CPU models CPU models

2018-12-20 Thread Eduardo Habkost
On Wed, Dec 12, 2018 at 09:08:03PM +0100, Borislav Petkov wrote: > On Wed, Dec 12, 2018 at 05:52:35PM -0200, Eduardo Habkost wrote: > > Why did you remove this entry from PC_COMPAT_2_4? > > > > We must keep compatibility with old behavior of Opteron_G2 on > > pc-2.4, even if the old behavior was i

[Qemu-devel] [PATCH] target/i386: Disable MPX support on named CPU models

2018-12-20 Thread Paolo Bonzini
MPX support is being phased out by Intel; GCC has dropped it, Linux is also going to do that. Even though KVM will have special code to support MPX after the kernel proper stops enabling it in XCR0, we probably also want to deprecate that in a few years. As a start, do not enable it by default fo

Re: [Qemu-devel] [PATCH v5 11/11] iotests: add iotest 236 for testing bitmap merge

2018-12-20 Thread Vladimir Sementsov-Ogievskiy
20.12.2018 5:29, John Snow wrote: > New interface, new smoke test. > > Signed-off-by: John Snow > --- [...] > +# A: 7 clusters > +# B: 4 clusters > +# C: 6 clusters > +log(query_bitmaps(vm), indent=2) > + > +log('\n--- Submitting Bad Merge ---\n') aha, spent some time, tryi

Re: [Qemu-devel] [PATCH v2 1/3] q35: set split kernel irqchip as default

2018-12-20 Thread Eduardo Habkost
On Thu, Dec 20, 2018 at 01:40:35PM +0800, Peter Xu wrote: > Starting from QEMU 4.0, let's specify "split" as the default value for > kernel-irqchip. > > So for QEMU>=4.0 we'll have: allowed=Y,required=N,split=Y >for QEMU<=3.1 we'll have: allowed=Y,required=N,split=N >(omitting all the "ker

[Qemu-devel] [PATCH] target-i386: hvf: remove MPX support

2018-12-20 Thread Paolo Bonzini
MPX support is being phased out by Intel and actually I am not sure that OS X has ever enabled it in XCR0. Drop it from the Hypervisor.framework acceleration. Signed-off-by: Paolo Bonzini --- target/i386/hvf/x86_cpuid.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) d

Re: [Qemu-devel] [PATCH 0/9] tests: apci: consolidate and cleanup ACPI test code

2018-12-20 Thread Igor Mammedov
On Wed, 19 Dec 2018 11:38:36 -0500 "Michael S. Tsirkin" wrote: > On Mon, Dec 10, 2018 at 07:10:06PM +0100, Igor Mammedov wrote: > > While working on adding tests for virt/arm board (uefi/XSDT/64-bit table > > pointers), > > I found it's rather difficult to deal with mixed ACPI testing code that

Re: [Qemu-devel] [PULL v2 00/35] Misc patches for 2018-12-18

2018-12-20 Thread Paolo Bonzini
On 20/12/18 12:43, Philippe Mathieu-Daudé wrote: >> subprocess.CalledProcessError: Command '['docker', 'build', '-t', >> 'qemu:debian9', '-f', '/tmp/docker_buildsvtS6R/tmp74LVkj.docker', >> '/tmp/docker_buildsvtS6R']' returned non-zero exit status 100 >> /home/petmay01/linaro/qemu-for-merges/tests/

Re: [Qemu-devel] [PULL 00/64] slirp updates

2018-12-20 Thread Marc-André Lureau
Hi On Thu, Dec 20, 2018 at 4:01 PM Marc-André Lureau wrote: > > Hi > > On Wed, Dec 19, 2018 at 11:45 PM Peter Maydell > wrote: > > > > On Tue, 18 Dec 2018 at 23:04, Samuel Thibault > > wrote: > > > > > > The following changes since commit > > > e85c577158a2e8e252414959da9ef15c12eec63d: > > >

Re: [Qemu-devel] did the qemu can emulate the whole system with the processor that without support the "virtulization and kvm"?

2018-12-20 Thread Alex Bennée
tugouxp <13824125...@163.com> writes: > hi folks: > did the qemu can emulate the whole system(such as ubuntu) with > the processor that without support the "virtulization and kvm"? I don't quite follow your question. However if you are asking about the cross-architecture emulation (us

[Qemu-devel] [PULL v3 00/35] Misc patches for 2018-12-18

2018-12-20 Thread Paolo Bonzini
The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18 14:31:06 +) are available in the Git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

[Qemu-devel] [PULL 22/35] test: execute g_test_run when tests are skipped

2018-12-20 Thread Paolo Bonzini
Sometimes a test's main() function recognizes that the environment does not support the test, and therefore exits. In this case, we still should run g_test_run() so that a TAP harness will print the test plan ("1..0") and the test will be marked as skipped. Signed-off-by: Paolo Bonzini Message-I

Re: [Qemu-devel] [PULL 00/64] slirp updates

2018-12-20 Thread Samuel Thibault
Marc-André Lureau, le jeu. 20 déc. 2018 16:01:44 +0400, a ecrit: > > declaration of 'inet_pton' [-Werror=nested-externs] > > if (!inet_pton(AF_INET6, vprefix6, &ip6_prefix)) { > > ^ > > > > This one is easy, it needs "build-sys: require Vista API by default > globally" series that Paolo

Re: [Qemu-devel] [PATCH 1/2] i386: remove the new CPUID 'PCONFIG' from Icelake-Server CPU model

2018-12-20 Thread Paolo Bonzini
On 20/12/18 01:18, Robert Hoo wrote: > On Wed, 2018-12-19 at 14:01 +, Daniel P. Berrangé wrote: >> On Wed, Dec 19, 2018 at 09:44:40PM +0800, Robert Hoo wrote: >>> Signed-off-by: Robert Hoo >>> --- >>>  target/i386/cpu.c | 3 +-- >>>  1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff -

Re: [Qemu-devel] [PATCH for-3.2 01/11] vhost-user: define conventions for vhost-user backends

2018-12-20 Thread Marc-André Lureau
Hi On Wed, Dec 19, 2018 at 7:42 PM Michael S. Tsirkin wrote: > > On Wed, Dec 19, 2018 at 12:01:59PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Wed, Dec 19, 2018 at 3:20 AM Michael S. Tsirkin wrote: > > > > > > On Tue, Dec 18, 2018 at 10:35:05PM +0400, Marc-André Lureau wrote: > > > > Hi >

Re: [Qemu-devel] [PATCH 1/2] i386: remove the new CPUID 'PCONFIG' from Icelake-Server CPU model

2018-12-20 Thread Robert Hoo
On Thu, 2018-12-20 at 13:38 +0100, Paolo Bonzini wrote: > On 20/12/18 01:18, Robert Hoo wrote: > > On Wed, 2018-12-19 at 14:01 +, Daniel P. Berrangé wrote: > > > On Wed, Dec 19, 2018 at 09:44:40PM +0800, Robert Hoo wrote: > > > > Signed-off-by: Robert Hoo > > > > --- > > > >  target/i386/cpu.c

[Qemu-devel] [Bug 1809252] [NEW] Password authentication in FIPS-compliant mode

2018-12-20 Thread Tomasz Barański
Public bug reported: The documentation states, that: "The VNC protocol has limited support for password based authentication. (...) Password authentication is not supported when operating in FIPS 140-2 compliance mode as it requires the use of the DES cipher." Would it be possible for qemu to us

Re: [Qemu-devel] [RFC PATCH] fpu: add compile time check for old glibc/libm and fma

2018-12-20 Thread Aleksandar Markovic
On Dec 20, 2018 12:11 PM, "Alex Bennée" wrote: > > Some versions of glibc have been reported to have problems with > fused-multiply-accumulate operations. If the underlying fma > implementation does a two step operation it will instroduce subtle > rounding errors. Newer versions of the library see

Re: [Qemu-devel] [PATCH 1/2] i386: remove the new CPUID 'PCONFIG' from Icelake-Server CPU model

2018-12-20 Thread Paolo Bonzini
On 20/12/18 13:50, Robert Hoo wrote: >> We should still leave it in the 3.1 machine types.  I've just sent a >> patch to do the same with MPX. >> > I took a look your patch of "Disable MPX support on named CPU models". > Seems you do the same as I do to PCONFIG. So you agree with my above > patch?:

Re: [Qemu-devel] [PATCH v2 11/22] nbd/client: Change signature of nbd_negotiate_simple_meta_context()

2018-12-20 Thread Vladimir Sementsov-Ogievskiy
15.12.2018 16:53, Eric Blake wrote: > Pass 'info' instead of three separate parameters related to info, > when requesting the server to set the meta context. Update the > NBDExportInfo struct to rename the received id field to match the > fact that we are currently overloading the field to match w

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-20 Thread Michael S. Tsirkin
On Thu, Dec 20, 2018 at 01:37:40PM +0800, Yi Zhang wrote: > On 2018-12-19 at 22:42:07 -0500, Michael S. Tsirkin wrote: > > On Thu, Dec 20, 2018 at 11:03:12AM +0800, Yi Zhang wrote: > > > On 2018-12-19 at 10:59:10 -0500, Michael S. Tsirkin wrote: > > > > On Wed, Dec 19, 2018 at 05:10:18PM +0800, Yi

Re: [Qemu-devel] [PATCH v2 12/22] nbd/client: Improve error handling in nbd_negotiate_simple_meta_context()

2018-12-20 Thread Vladimir Sementsov-Ogievskiy
17.12.2018 18:30, Eric Blake wrote: > On 12/15/18 9:19 AM, Richard W.M. Jones wrote: >> On Sat, Dec 15, 2018 at 07:53:14AM -0600, Eric Blake wrote: >>> Always allocate space for the reply returned by the server and >>> hoist the trace earlier, as it is more interesting to trace the >>> server's rep

[Qemu-devel] [PATCH v2 10/12] qapi: document DisplayType enum

2018-12-20 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- qapi/ui.json | 24 1 file changed, 24 insertions(+) diff --git a/qapi/ui.json b/qapi/ui.json index 5ad13248d5..3f2f662dca 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1075,6 +1075,30 @@ # # Display (user interface) type. # +# @

Re: [Qemu-devel] [PATCH] target/i386: Disable MPX support on named CPU models

2018-12-20 Thread Paolo Bonzini
On 20/12/18 15:18, Wainer dos Santos Moschetta wrote: > > On 12/20/2018 10:11 AM, Paolo Bonzini wrote: >> MPX support is being phased out by Intel; GCC has dropped it, Linux >> is also going to do that.  Even though KVM will have special code >> to support MPX after the kernel proper stops enablin

[Qemu-devel] [PATCH v2 07/12] char: move SpiceChardev and open_spice_port() to spice.h header

2018-12-20 Thread Marc-André Lureau
This will allow easier subclassing of SpiceChardev, in upcoming "display: add -display app launching external application" patch. Signed-off-by: Marc-André Lureau --- include/chardev/spice.h | 27 +++ chardev/spice.c | 28 +--- 2 files chan

Re: [Qemu-devel] [PATCH v3 05/16] virtio: split virtio balloon bits from virtio-pci

2018-12-20 Thread Stefano Garzarella
On Thu, Dec 13, 2018 at 10:07 PM Juan Quintela wrote: > > Reviewed-by: Thomas Huth > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs| 1 + > hw/virtio/virtio-balloon-pci.c | 94 ++ > hw/virtio/virtio-pci.c

[Qemu-devel] [PATCH v2 05/12] spice: merge options lists

2018-12-20 Thread Marc-André Lureau
Passing several -spice options to qemu command line, or calling several time qemu_opts_set() will ignore all but the first option list. Since the spice server is a singleton, it makes sense to merge all the options, the last value being the one taken into account. This changes the behaviour from,

[Qemu-devel] [PATCH v2 08/12] char: register spice ports after spice started

2018-12-20 Thread Marc-André Lureau
Spice port registration is delayed until the server is started. But ports created after are not being registered. If the server is already started, do vmc_register_interface() to register it from qemu_chr_open_spice_port(). Signed-off-by: Marc-André Lureau --- chardev/spice.c | 5 + 1 file c

Re: [Qemu-devel] [PATCH] target/i386: Disable MPX support on named CPU models

2018-12-20 Thread Wainer dos Santos Moschetta
On 12/20/2018 10:11 AM, Paolo Bonzini wrote: MPX support is being phased out by Intel; GCC has dropped it, Linux is also going to do that. Even though KVM will have special code to support MPX after the kernel proper stops enabling it in XCR0, we probably also want to deprecate that in a few y

[Qemu-devel] [PATCH v2 06/12] spice: do not stop spice if VM is paused

2018-12-20 Thread Marc-André Lureau
spice_server_vm_start/stop() was added to help migration state (commit f5bb039c6d97ef3e664094eab3c9a4dc1824ed73). However, a paused VM could keep running the spice server. This will allow a Spice client to keep sending commands to a spice chardev. This allows to stop/cont a VM from a Spice monitor

[Qemu-devel] [PATCH v2 11/12] spice: use a default name for the server

2018-12-20 Thread Marc-André Lureau
If no -name is given, let's use a friendly "QEMU version" server name. This is sometime exposed on spice client side, for example on remote-viewer title. Signed-off-by: Marc-André Lureau --- ui/spice-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/spice-core.c b/ui/

[Qemu-devel] [PATCH v2 09/12] build-sys: add gio-2.0 check

2018-12-20 Thread Marc-André Lureau
GIO is required for the -display app backend. Signed-off-by: Marc-André Lureau --- configure | 13 + 1 file changed, 13 insertions(+) diff --git a/configure b/configure index b0927b882a..dd0bcc2a10 100755 --- a/configure +++ b/configure @@ -3518,6 +3518,14 @@ for i in $glib_modules;

[Qemu-devel] [PATCH v2 12/12] display: add -display spice-app launching a Spice client

2018-12-20 Thread Marc-André Lureau
Add a new display backend that will configure Spice to allow a remote client to control QEMU in a similar fashion as other QEMU display backend/UI like GTK. For this to work, it will set up Spice server with a unix socket, and register a VC chardev that will be exposed as Spice ports. A QMP monito

[Qemu-devel] [PATCH v2 01/12] configure: bump spice-server required version to 0.12.5

2018-12-20 Thread Marc-André Lureau
Looking at chardev/spice.c code, I realize compilation was broken for a while with spice-server < 0.12.3. Let's bump required version to 0.12.5, released May 19 2014, instead of adding more #ifdef. (this patch combines changes from an early version and some of Frediano "[PATCH 2/2] spice: Bump req

[Qemu-devel] [PATCH v2 02/12] char/spice: trigger HUP event

2018-12-20 Thread Marc-André Lureau
Inform the front-end of disconnected state (spice client disconnected). This will wakeup the source handler immediately, so it can detect the disconnection asap. Signed-off-by: Marc-André Lureau --- chardev/spice.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --gi

[Qemu-devel] [PATCH v2 03/12] char/spice: discard write() if backend is disconnected

2018-12-20 Thread Marc-André Lureau
Most chardev backend handle write() as discarded data if underlying system is disconnected. For unknown historical reasons, the Spice backend has "reliable" write: it will wait until the client end is reconnected to do further successful write(). To decide whether it make sense to wait until the c

Re: [Qemu-devel] [Bug 1809252] [NEW] Password authentication in FIPS-compliant mode

2018-12-20 Thread Eric Blake
On 12/20/18 6:59 AM, Tomasz Barański wrote: Public bug reported: The documentation states, that: "The VNC protocol has limited support for password based authentication. (...) Password authentication is not supported when operating in FIPS 140-2 compliance mode as it requires the use of the DES

[Qemu-devel] [PATCH v2 04/12] spice: avoid spice runtime assert

2018-12-20 Thread Marc-André Lureau
The Spice server doesn't like to be started or stopped twice . It aborts with: (process:6191): Spice-ERROR **: 19:29:35.912: red-worker.c:623:handle_dev_start: assertion `!worker->running' failed It's easy to avoid that situation since qemu spice_display_is_running tracks the server state. Afte

[Qemu-devel] [PATCH v2 00/12] spice: add -display spice-app, setup and launch a Spice client

2018-12-20 Thread Marc-André Lureau
Hi, The QEMU GTK UI is quite featurful. Yet, it doesn't provide many of the functionalities one can expect from a VM desktop application (USB redirection, shared folders, drag and drop, better multimonitor support etc.). Spice is able to export many of the VM controls to a client, including QMP m

Re: [Qemu-devel] [PATCH v2 10/12] qapi: document DisplayType enum

2018-12-20 Thread Eric Blake
On 12/20/18 8:15 AM, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau --- qapi/ui.json | 24 1 file changed, 24 insertions(+) diff --git a/qapi/ui.json b/qapi/ui.json index 5ad13248d5..3f2f662dca 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1075,6 +1075,

Re: [Qemu-devel] [PULL v2 00/30] pci, pc, virtio: fixes, features

2018-12-20 Thread Igor Mammedov
On Wed, 19 Dec 2018 19:15:26 + Peter Maydell wrote: > On Tue, 18 Dec 2018 at 16:11, Michael S. Tsirkin wrote: > > > > Changes from v1: > > Drop > > intel_iommu: turn on IR by default > > > > The following changes since commit f163448536e5f7ae8905b14547eab37a41a75f6c: > > > > Me

Re: [Qemu-devel] [PULL v2 00/30] pci, pc, virtio: fixes, features

2018-12-20 Thread Peter Maydell
On Thu, 20 Dec 2018 at 14:50, Igor Mammedov wrote: > > On Wed, 19 Dec 2018 19:15:26 + > Peter Maydell wrote: > > Hi; I'm afraid I get conflicts in some files which look > > too complicated for me to want to try to resolve at this end: > > Auto-merging tests/vmgenid-test.c > > CONFLICT (conten

[Qemu-devel] [Bug 1809252] Re: Password authentication in FIPS-compliant mode

2018-12-20 Thread Daniel Berrange
The VNC password authentication scheme is not extensible. It is unfixably broken by design. QEMU provides the SASL authentication scheme for VNC which allows for strong authentication, when combined with the VeNCrypt authentication scheme that uses TLS. These extensions are supported by the gtk-v

Re: [Qemu-devel] [PULL v2 00/30] pci, pc, virtio: fixes, features

2018-12-20 Thread Michael S. Tsirkin
On Thu, Dec 20, 2018 at 03:49:59PM +0100, Igor Mammedov wrote: > On Wed, 19 Dec 2018 19:15:26 + > Peter Maydell wrote: > > > On Tue, 18 Dec 2018 at 16:11, Michael S. Tsirkin wrote: > > > > > > Changes from v1: > > > Drop > > > intel_iommu: turn on IR by default > > > > > > The fo

Re: [Qemu-devel] [PATCH v11 04/10] block: introduce BDRV_REQ_ALLOCATE flag

2018-12-20 Thread Vladimir Sementsov-Ogievskiy
18.12.2018 10:57, Anton Nefedov wrote: > The flag is supposed to indicate that the region of the disk image has > to be sufficiently allocated so it reads as zeroes. > > The call with the flag set must return -ENOTSUP if allocation cannot > be done efficiently. > This has to be made sure of by bot

Re: [Qemu-devel] [PULL v2 00/30] pci, pc, virtio: fixes, features

2018-12-20 Thread Igor Mammedov
On Thu, 20 Dec 2018 14:52:49 + Peter Maydell wrote: > On Thu, 20 Dec 2018 at 14:50, Igor Mammedov wrote: > > > > On Wed, 19 Dec 2018 19:15:26 + > > Peter Maydell wrote: > > > Hi; I'm afraid I get conflicts in some files which look > > > too complicated for me to want to try to resolve a

[Qemu-devel] [PATCH v3 29/30] hw: acpi: Remove AcpiRsdpDescriptor and fix tests

2018-12-20 Thread Igor Mammedov
From: Samuel Ortiz The only remaining AcpiRsdpDescriptor users are the ACPI utils for the BIOS table tests. We remove that dependency and can thus remove the structure itself. Signed-off-by: Samuel Ortiz Reviewed-by: Igor Mammedov Reviewed-by: Andrew Jones Reviewed-by: Michael S. Tsirkin Sig

Re: [Qemu-devel] [PATCH v3 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

2018-12-20 Thread Igor Mammedov
On Wed, 19 Dec 2018 14:00:37 +0100 Andrew Jones wrote: > On Wed, Dec 19, 2018 at 01:43:40PM +0100, Philippe Mathieu-Daudé wrote: > > Hi Drew, > > > > On 12/19/18 11:10 AM, Andrew Jones wrote: > > > On Tue, Dec 18, 2018 at 06:51:20PM +0100, Philippe Mathieu-Daudé wrote: > > >> GCC 8 added a -Wstr

[Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_fd_handler.

2018-12-20 Thread remy . noel
From: Remy Noel It is possible for an io_poll/read/write callback to be concurrently executed along with an aio_set_fd_handlers. This can cause all sorts of problems, like a NULL callback or a bad opaque pointer. V2: * Do not use RCU anymore as it inccurs a performance loss V3: * Don't

[Qemu-devel] [QEMU-devel][PATCH v4 1/2] aio-posix: Unregister fd from ctx epoll when removing fd_handler.

2018-12-20 Thread remy . noel
From: Remy Noel Cleaning the events will cause aio_epoll_update to unregister the fd. Otherwise, the fd is kept registered until it is destroyed. Signed-off-by: Remy Noel --- util/aio-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util/aio-posix.c b/util/aio-posix.c index 51c41

[Qemu-devel] [QEMU-devel][PATCH v4 2/2] aio-posix: Fix concurrent aio_poll/set_fd_handler.

2018-12-20 Thread remy . noel
From: Remy Noel It is possible for an io_poll callback to be concurrently executed along with an aio_set_fd_handlers. This can cause all sorts of problems, like a NULL callback or a bad opaque pointer. This changes set_fd_handlers so that it no longer modify existing handlers entries and instead

Re: [Qemu-devel] [PATCH] docs: apply some qemu.org-like CSS style to HTML

2018-12-20 Thread Marc-André Lureau
Hi On Wed, Dec 19, 2018 at 7:17 PM Aleksandar Markovic wrote: > > > On Nov 22, 2018 3:18 PM, "Marc-André Lureau" > wrote: > > > > Style a bit the HTML documents, to make them look like qemu.org pages. > > > > Signed-off-by: Marc-André Lureau > > --- > > Makefile | 2 + >

Re: [Qemu-devel] [PATCH] docs: apply some qemu.org-like CSS style to HTML

2018-12-20 Thread Daniel P . Berrangé
On Thu, Dec 20, 2018 at 07:24:56PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Dec 19, 2018 at 7:17 PM Aleksandar Markovic > wrote: > > > > > > On Nov 22, 2018 3:18 PM, "Marc-André Lureau" > > wrote: > > > > > > Style a bit the HTML documents, to make them look like qemu.org pages. > > > >

Re: [Qemu-devel] [PATCH v6 28/28] hostmem: use object id for memory region name with >= 4.0

2018-12-20 Thread Igor Mammedov
On Thu, 13 Dec 2018 01:48:50 +0400 Marc-André Lureau wrote: > hostmem-file and hostmem-memfd use the whole object path for the > memory region name, and hostname-ram uses only the path component (the > object id, or canonical path basename): > > qemu -m 1024 -object memory-backend-file,id=mem,si

Re: [Qemu-devel] [PATCH v6 00/28] Generalize machine compatibility properties

2018-12-20 Thread Igor Mammedov
On Thu, 13 Dec 2018 01:48:22 +0400 Marc-André Lureau wrote: > Hi, > > During "[PATCH v2 05/10] qom/globals: generalize > object_property_set_globals()" review, Eduardo suggested to rework the > GlobalProperty handling, so that -global is limited to QDev only and > we avoid mixing the machine com

Re: [Qemu-devel] [PATCH v3 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

2018-12-20 Thread Philippe Mathieu-Daudé
On Thu, Dec 20, 2018 at 4:18 PM Igor Mammedov wrote: > > On Wed, 19 Dec 2018 14:00:37 +0100 > Andrew Jones wrote: > > > On Wed, Dec 19, 2018 at 01:43:40PM +0100, Philippe Mathieu-Daudé wrote: > > > Hi Drew, > > > > > > On 12/19/18 11:10 AM, Andrew Jones wrote: > > > > On Tue, Dec 18, 2018 at 06:5

[Qemu-devel] [PATCH v3 0/9] target/ppc: prepare for conversion to TCG vector operations

2018-12-20 Thread Mark Cave-Ayland
This patchset is an attempt at trying to improve the VMX (Altivec) instruction performance by laying the groundwork for use of the new TCG vector operations. Patches 1 and 2 fix a sign-extension error discovered in EXTRACT_SHELPER and an associated typo in the SIMM5 macro which were discovered whi

[Qemu-devel] [PATCH v3 1/9] target/ppc: fix typo in SIMM5 extraction helper

2018-12-20 Thread Mark Cave-Ayland
As the macro name suggests, the argument should be signed and not unsigned. Signed-off-by: Mark Cave-Ayland --- target/ppc/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/internal.h b/target/ppc/internal.h index a9bcadff42..8b35863549 100644 --- a/target

[Qemu-devel] [PATCH v3 4/9] target/ppc: introduce get_avr64() and set_avr64() helpers for VMX register access

2018-12-20 Thread Mark Cave-Ayland
These helpers allow us to move AVR register values to/from the specified TCGv_i64 argument. To prevent VMX helpers accessing the cpu_avr{l,h} arrays directly, add extra TCG temporaries as required. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Acked-by: David Gibson --- targ

[Qemu-devel] [PATCH v3 8/9] target/ppc: move FP and VMX registers into aligned vsr register array

2018-12-20 Thread Mark Cave-Ayland
The VSX register array is a block of 64 128-bit registers where the first 32 registers consist of the existing 64-bit FP registers extended to 128-bit using new VSR registers, and the last 32 registers are the VMX 128-bit registers as show below: 64-bit 64-bit +--

[Qemu-devel] [PATCH v3 3/9] target/ppc: introduce get_fpr() and set_fpr() helpers for FP register access

2018-12-20 Thread Mark Cave-Ayland
These helpers allow us to move FP register values to/from the specified TCGv_i64 argument in the VSR helpers to be introduced shortly. To prevent FP helpers accessing the cpu_fpr array directly, add extra TCG temporaries as required. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson

[Qemu-devel] [PATCH v3 6/9] target/ppc: switch FPR, VMX and VSX helpers to access data directly from cpu_env

2018-12-20 Thread Mark Cave-Ayland
Instead of accessing the FPR, VMX and VSX registers through static arrays of TCGv_i64 globals, remove them and change the helpers to load/store data directly within cpu_env. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Acked-by: David Gibson --- target/ppc/translate.c

[Qemu-devel] [PATCH v3 9/9] target/ppc: replace AVR* macros with Vsr* macros

2018-12-20 Thread Mark Cave-Ayland
Now that the VMX and VSR register sets have been combined, the same macros can be used to access both AVR and VSR field members. Signed-off-by: Mark Cave-Ayland --- target/ppc/int_helper.c | 38 +- target/ppc/internal.h | 4 2 files changed, 17 inserti

[Qemu-devel] [PATCH v3 7/9] target/ppc: merge ppc_vsr_t and ppc_avr_t union types

2018-12-20 Thread Mark Cave-Ayland
Since the VSX registers are actually a superset of the VMX registers then they can be represented by the same type. Merge ppc_avr_t into ppc_vsr_t and change ppc_avr_t to be a simple typedef alias. Note that due to a difference in the naming of the float32 member between ppc_avr_t and ppc_vsr_t, r

[Qemu-devel] [PATCH v3 2/9] target/ppc: switch EXTRACT_HELPER macros over to use sextract32/extract32

2018-12-20 Thread Mark Cave-Ayland
These ensure that we consistently handle signed and unsigned extensions correctly when decoding immediates from instruction opcodes. Signed-off-by: Mark Cave-Ayland --- target/ppc/internal.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/ppc/internal.h b/targ

Re: [Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_fd_handler.

2018-12-20 Thread Stefan Hajnoczi
On Thu, Dec 20, 2018 at 04:20:28PM +0100, remy.n...@blade-group.com wrote: > From: Remy Noel > > It is possible for an io_poll/read/write callback to be concurrently executed > along > with an aio_set_fd_handlers. This can cause all sorts of problems, like > a NULL callback or a bad opaque point

[Qemu-devel] [PATCH v3 5/9] target/ppc: introduce get_cpu_vsr{l, h}() and set_cpu_vsr{l, h}() helpers for VSR register access

2018-12-20 Thread Mark Cave-Ayland
These helpers allow us to move VSR register values to/from the specified TCGv_i64 argument. To prevent VSX helpers accessing the cpu_vsr array directly, add extra TCG temporaries as required. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Acked-by: David Gibson --- target/ppc

Re: [Qemu-devel] [PATCH for-3.2 01/11] vhost-user: define conventions for vhost-user backends

2018-12-20 Thread Michael S. Tsirkin
On Thu, Dec 20, 2018 at 04:40:55PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Dec 19, 2018 at 7:42 PM Michael S. Tsirkin wrote: > > > > On Wed, Dec 19, 2018 at 12:01:59PM +0400, Marc-André Lureau wrote: > > > Hi > > > > > > On Wed, Dec 19, 2018 at 3:20 AM Michael S. Tsirkin > > > wrote: >

[Qemu-devel] [PULL 0/2] Final s390x patches for 2018

2018-12-20 Thread Cornelia Huck
The following changes since commit b72566a4ffaddbc0c0c1f6f5ee91b42ab13ff429: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2018-12-19 15:31:02 +) are available in the Git repository at: https://github.com/cohuck/qemu tags/s390

  1   2   3   >