[Qemu-devel] [PATCH V6 0/6] nvdimm: support MAP_SYNC for memory-backend-file

2018-12-12 Thread Zhang Yi
Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to guarantee the write persistence to mmap'ed files supporting DAX (e.g., files on ext4/xfs file system mounted with '-o dax'). A description of MAP_SYNC and MAP_SHARED_VALIDATE can be found at https://patchwork.kernel.org/patch

[Qemu-devel] [PATCH V6 1/6] numa: Fixed the memory leak of numa error message

2018-12-12 Thread Zhang Yi
object_get_canonical_path_component() returns a string which must be freed using g_free(). Signed-off-by: Zhang Yi Reviewed-by: Pankaj gupta Reviewed-by: Igor Mammedov --- numa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/numa.c b/numa.c index 50ec016..3875e1e 100644 --- a/numa.c +++

[Qemu-devel] [PATCH V6 3/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2018-12-12 Thread Zhang Yi
When a file supporting DAX is used as vNVDIMM backend, mmap it with MAP_SYNC flag in addition can guarantee the persistence of guest write to the backend file without other QEMU actions (e.g., periodic fsync() by QEMU). A set of RAM_SYNC flags are added to qemu_ram_mmap(): Signed-off-by: Haozhong

[Qemu-devel] [PATCH V6 2/6] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter

2018-12-12 Thread Zhang Yi
As more flag parameters besides the existing 'shared' are going to be added to qemu_ram_mmap(), let's switch 'shared' to a 'flags' parameter in advance, so as to ease the further additions. Signed-off-by: Haozhong Zhang Signed-off-by: Zhang Yi --- exec.c| 7 --- include

[Qemu-devel] [PATCH V6 4/6] util/mmap-alloc: Switch the RAM_SYNC flags to OnOffAuto

2018-12-12 Thread Zhang Yi
Signed-off-by: Zhang Yi A set of RAM_SYNC_ON_OFF_AUTO{AUTO,ON,OFF} flags are added to qemu_ram_mmap(): - If RAM_SYNC_ON_OFF_AUTO_ON is present, qemu_ram_mmap() will try to pass MAP_SYNC to mmap(). It will then fail if the host OS or the backend file do not support MAP_SYNC, or MAP_SYNC is co

[Qemu-devel] [PATCH V6 5/6] hostmem: add more information in error messages

2018-12-12 Thread Zhang Yi
When there are multiple memory backends in use, including the object type name, ID and the property name in the error message can help users to locate the error. Signed-off-by: Haozhong Zhang Signed-off-by: Zhang Yi --- backends/hostmem-file.c | 6 -- backends/hostmem.c | 8 +--- 2

[Qemu-devel] [PATCH V6 6/6] hostmem-file: add 'sync' option

2018-12-12 Thread Zhang Yi
This option controls whether QEMU mmap(2) the memory backend file with MAP_SYNC flag, which could consistent filesystem metadata for each guest write, if MAP_SYNC flag is supported by the host kernel(Linux kernel 4.15 and later) and the backend is a file supporting DAX (e.g., file on ext4/xfs file

Re: [Qemu-devel] [PATCH 2/3] mac_newworld: enable access to EDID data for the VGA device

2018-12-12 Thread Gerd Hoffmann
On Fri, Dec 07, 2018 at 04:08:05PM +, Mark Cave-Ayland wrote: > This is in preparation for some upcoming QEMU NDRV driver changes that pass > display information from the host to the guest. > -pci_vga_init(pci_bus); > +dev = qdev_create(BUS(pci_bus), "VGA"); > +qdev_prop_set_int32(

Re: [Qemu-devel] [PATCH v2 7/7] block/qcow2-refcount: fix out-of-file L2 entries to be read-as-zero

2018-12-12 Thread Vladimir Sementsov-Ogievskiy
13.10.2018 15:58, Max Reitz wrote: > On 10.10.18 18:59, Vladimir Sementsov-Ogievskiy wrote: >> 10.10.2018 19:55, Vladimir Sementsov-Ogievskiy wrote: >>> 10.10.2018 19:39, Vladimir Sementsov-Ogievskiy wrote: 17.08.2018 15:22, Vladimir Sementsov-Ogievskiy wrote: > Rewrite corrupted L2 table

[Qemu-devel] [Bug 1780812] Re: Full-Screen Switch Does Nothing When Using SDL

2018-12-12 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1780812 Title: Full-Screen Switch Does Nothing When Using SDL Status in QEMU: Fix R

[Qemu-devel] [Bug 1794939] Re: QEMU does not build with vte v2.91

2018-12-12 Thread Thomas Huth
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=6415994ffcc6d22b3f5a ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1794939 Title: Q

[Qemu-devel] [Bug 1785972] Re: v3.0.0-rc4: VM fails to start after vcpuhotunplug, managedsave sequence

2018-12-12 Thread Thomas Huth
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=cc71c7760e263f808c4240a ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1785972 Title:

[Qemu-devel] [Bug 1803160] Re: qemu-3.1.0-rc0: tcg.c crash in temp_load

2018-12-12 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1803160 Title: qemu-3.1.0-rc0: tcg.c crash in temp_load Status in QEMU: Fix Release

Re: [Qemu-devel] [PATCH for-4.0 v7 02/27] qapi: do not define enumeration value explicitly

2018-12-12 Thread Markus Armbruster
Marc-André Lureau writes: > The C standard has the initial value at 0 and the subsequent values > incremented by 1. No need to set this explicitely. > > This will prevent from artificial "gaps" when compiling out some enum > values and having unnecessarily large MAX values & enums arrays, or > si

[Qemu-devel] [Bug 1637974] Re: dead code in pl080 functions

2018-12-12 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1637974 Title: dead code in pl080 functions Status in QEMU: Fix Released Bug descr

Re: [Qemu-devel] [PATCH for-4.0 v2 3/7] configure: Remove old -fno-gcse workaround for GCC 4.6.x and 4.7.[012]

2018-12-12 Thread Thomas Huth
On 2018-12-04 16:32, Thomas Huth wrote: > Now that we require at least GCC 4.8, we don't need this als workaround > for 4.6 and 4.7 anymore. > > Reviewed-by: Richard Henderson > Signed-off-by: Thomas Huth > --- > Makefile.target | 3 --- > configure | 27 --- > 2

Re: [Qemu-devel] [PATCH 2/3] mac_newworld: enable access to EDID data for the VGA device

2018-12-12 Thread Mark Cave-Ayland
On 12/12/2018 08:32, Gerd Hoffmann wrote: > On Fri, Dec 07, 2018 at 04:08:05PM +, Mark Cave-Ayland wrote: >> This is in preparation for some upcoming QEMU NDRV driver changes that pass >> display information from the host to the guest. > >> -pci_vga_init(pci_bus); >> +dev = qdev_creat

[Qemu-devel] ping Re: [PATCH 0/3] nbd-client: drop extra error noise

2018-12-12 Thread Vladimir Sementsov-Ogievskiy
ping 02.11.2018 18:11, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > It was discussed, that error messages, produced by error_reprt_err's, > added in f140e300 are > 1. not really needed > 2. subject to race conditions > > And it was decided to drop them (switch to trace-points), look thread

Re: [Qemu-devel] [Xen-devel] xen_disk qdevification (was: [PATCH 0/3] Performance improvements for xen_disk v2)

2018-12-12 Thread Olaf Hering
On Fri, Nov 02, Kevin Wolf wrote: > A while ago, a downstream patch review found out that there are some QMP > commands that would immediately crash if a xen_disk device were present > because of the lacking qdevification. This is not the code quality > standard I envision for QEMU. It's time for

Re: [Qemu-devel] [PATCH for-4.0 v7 02/27] qapi: do not define enumeration value explicitly

2018-12-12 Thread Marc-André Lureau
Hi On Wed, Dec 12, 2018 at 12:52 PM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > The C standard has the initial value at 0 and the subsequent values > > incremented by 1. No need to set this explicitely. > > > > This will prevent from artificial "gaps" when compiling out some enu

Re: [Qemu-devel] [PATCH] x86: host-phys-bits-limit option

2018-12-12 Thread Yu Zhang
On Tue, Dec 11, 2018 at 05:25:27PM -0200, Eduardo Habkost wrote: > Some downstream distributions of QEMU set host-phys-bits=on by > default. This worked very well for most use cases, because > phys-bits really didn't have huge consequences. The only > difference was on the CPUID data seen by guest

Re: [Qemu-devel] [PATCH v7 16/19] spapr: introduce a new sPAPR IRQ backend supporting XIVE and XICS

2018-12-12 Thread Cédric Le Goater
[ ... ] + +static qemu_irq spapr_qirq_dual(sPAPRMachineState *spapr, int irq) +{ +return spapr_irq_current(spapr)->qirq(spapr, irq); >>> >>> Urgh... I don't think this is going to work. IIRC the various devices >>> (PHB, VIO, etc.) are wired up to their qirqs at realize

[Qemu-devel] [PULL 1/8] configure: Add a test for the minimum compiler version

2018-12-12 Thread Thomas Huth
So far we only had implicit requirements for the minimum compiler version, e.g. we require at least GCC 4.1 for the support of atomics. However, such old compiler versions are not tested anymore by the developers, so they are not really supported anymore. Since we recently declared explicitly what

[Qemu-devel] [PULL 3/8] configure: Remove old -fno-gcse workaround for GCC 4.6.x and 4.7.[012]

2018-12-12 Thread Thomas Huth
Now that we require at least GCC 4.8, we don't need this als workaround for 4.6 and 4.7 anymore. Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth --- Makefile.target | 3 --- configure | 17 + 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a/Makefil

[Qemu-devel] [PULL 2/8] configure: Remove obsolete check for Clang < 3.2

2018-12-12 Thread Thomas Huth
Since we have got a check for Clang >= 3.4 now, we do not need to check for older Clang versions in the configure test for 128-bit ints anymore. Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth --- configure | 5 - 1 file changed, 5 deletions(-) diff --git a/configure b/configure

[Qemu-devel] [PULL 8/8] i2c: Move typedef of bitbang_i2c_interface to i2c.h

2018-12-12 Thread Thomas Huth
From: BALATON Zoltan Clang 3.4 considers duplicate typedef in ppc4xx_i2c.h and bitbang_i2c.h an error even if they are identical. Move it to a common place to allow building with this clang version. Reported-by: Thomas Huth Signed-off-by: BALATON Zoltan Acked-by: David Gibson Reviewed-by: Phi

[Qemu-devel] [PULL 0/8] Set minimum compiler versions to GCC 4.8 and Clang 3.4

2018-12-12 Thread Thomas Huth
Hi Peter, the following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 19:18:58 +) are available in the git repository at: https://gitlab.com/huth/qemu.git tags/pul

[Qemu-devel] [PULL 5/8] audio/alsaaudio: Remove compiler check around pragma

2018-12-12 Thread Thomas Huth
Both GCC v4.8 and Clang v3.4 support the -Waddress option, so we do not need the compiler version check here anymore. Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth --- audio/alsaaudio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index

[Qemu-devel] [PATCH v4 00/11] pci: hotplug handler reworks

2018-12-12 Thread David Hildenbrand
This is a resend with added RB's. @MST please pick up :) This series reworks some pci hotplug handlers (except for s390, that will require more work but is not required for now). 1. Route all unplug calls via the hotplug handler when called from the unplug_request handler. This will be requir

[Qemu-devel] [PULL 4/8] tcg/tcg.h: Remove GCC check for tcg_debug_assert() macro

2018-12-12 Thread Thomas Huth
Both GCC v4.8 and Clang v3.4 (our minimum versions) support __builtin_unreachable(), so we can remove the version check here now. Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth --- tcg/tcg.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h

[Qemu-devel] [PULL 6/8] includes: Replace QEMU_GNUC_PREREQ with "__has_builtin || !defined(__clang__)"

2018-12-12 Thread Thomas Huth
Since we require GCC version 4.8 or newer now, we can be sure that the builtin functions are always available on GCC. And for Clang, we can check the availablility with __has_builtin instead. Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth --- include/qemu/compiler.h | 2 +- include

[Qemu-devel] [PATCH v4 01/11] pci/pcie: rename hotplug handler callbacks

2018-12-12 Thread David Hildenbrand
The callbacks are also called for cold plugged devices. Drop the "hot" to better match the actual callback names. While at it, also rename pcie_cap_slot_hotplug_common() to pcie_cap_slot_plug_common(). Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand ---

[Qemu-devel] [PATCH v4 02/11] pci/shpc: rename hotplug handler callbacks

2018-12-12 Thread David Hildenbrand
The callbacks are also called for cold plugged devices. Drop the "hot" to better match the actual callback names. While at it, also rename shpc_device_hotplug_common() to shpc_device_plug_common(). Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/pc

[Qemu-devel] [PATCH v4 03/11] s390x/pci: rename hotplug handler callbacks

2018-12-12 Thread David Hildenbrand
The callbacks are also called for cold plugged devices. Drop the "hot" to better match the actual callback names. Reviewed-by: David Gibson Reviewed-by: Cornelia Huck Reviewed-by: Igor Mammedov Reviewed-by: Pierre Morel Signed-off-by: David Hildenbrand --- hw/s390x/s390-pci-bus.c | 12 ++-

[Qemu-devel] [PULL 7/8] Remove QEMU_ARTIFICIAL macro

2018-12-12 Thread Thomas Huth
The code that used it has already been removed a while ago with commit dc41aa7d34989b552ef ("tcg: Remove GET_TCGV_* and MAKE_TCGV_*"). Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth --- include/qemu/compiler.h| 6 -- scripts/checkpatch.pl | 1 - scripts/cocci-macro-file.

[Qemu-devel] [PATCH v4 05/11] pci/pcihp: perform check for bus capability in pre_plug handler

2018-12-12 Thread David Hildenbrand
Perform the check in the pre_plug handler. In addition, we need the capability only if the device is actually hotplugged (and not created during machine initialization). This is a preparation for coldplugging pci devices via that hotplug handler. Reviewed-by: Igor Mammedov Signed-off-by: David Hi

[Qemu-devel] [PATCH v4 04/11] pci/pcie: stop plug/unplug if the slot is locked

2018-12-12 Thread David Hildenbrand
We better stop right away. For now, errors would be partially ignored (so the guest might get informed or the device might get unplugged), although actual plug/unplug will be reported as failed to the user. While at it, properly move the check to the pre_plug handler for the plug case, as we can t

[Qemu-devel] [PATCH v4 08/11] pci/pcie: perform unplug via the hotplug handler

2018-12-12 Thread David Hildenbrand
Introduce and use the "unplug" callback. This is a preparation for multi-stage hotplug handlers, whereby the bus hotplug handler is overwritten by the machine hotplug handler. This handler will then pass control to the bus hotplug handler. So to get this running cleanly, we also have to make sure

[Qemu-devel] [PATCH v4 06/11] pci/pcihp: overwrite hotplug handler recursively from the start

2018-12-12 Thread David Hildenbrand
For now, the hotplug handler is not called for devices that are being cold plugged. The hotplug handler is setup when the machine initialization is fully done. Only bridges that were cold plugged are considered. Set the hotplug handler for the root piix bus directly when realizing. Overwrite the h

[Qemu-devel] ping2 Re: [PATCH v4 0/8] dirty-bitmap: rewrite bdrv_dirty_iter_next_area

2018-12-12 Thread Vladimir Sementsov-Ogievskiy
ping. No dependencies, apply to master. 17.09.2018 17:57, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > 1. bdrv_dirty_iter_next_area don't use hbitmap_next_zero and uses > inefficient loop instead. Let's improve it. > > 2. bdrv_dirty_iter_next_area don't handle unaligned offset and > max_off

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-12 Thread Yongji Xie
On Wed, 12 Dec 2018 at 15:47, Jason Wang wrote: > > > On 2018/12/12 下午2:41, Yongji Xie wrote: > > On Wed, 12 Dec 2018 at 12:07, Jason Wang wrote: > >> > >> On 2018/12/12 上午11:21, Yongji Xie wrote: > >>> On Wed, 12 Dec 2018 at 11:00, Jason Wang wrote: > On 2018/12/12 上午10:48, Yongji Xie wrot

[Qemu-devel] [PATCH v4 2/2] memory-device: rewrite address assignment using ranges

2018-12-12 Thread David Hildenbrand
Let's rewrite it properly using ranges. This fixes certain overflows that are right now possible. E.g. qemu-system-x86_64 -m 4G,slots=20,maxmem=40G -M pc \ -object memory-backend-file,id=mem1,share,mem-path=/dev/zero,size=2G -device pc-dimm,memdev=mem1,id=dimm1,addr=-0x4000 Now proper

[Qemu-devel] [PATCH v4 07/11] pci/pcihp: perform unplug via the hotplug handler

2018-12-12 Thread David Hildenbrand
Introduce and use the "unplug" callback. This is a preparation for multi-stage hotplug handlers, whereby the bus hotplug handler is overwritten by the machine hotplug handler. This handler will then pass control to the bus hotplug handler. So to get this running cleanly, we also have to make sure

Re: [Qemu-devel] [RFC PATCH] contrib: add a basic gitdm config

2018-12-12 Thread Thomas Huth
On 2018-12-11 18:42, Alex Bennée wrote: > This is a QEMU specific version of a gitdm config for generating > reports on the contributor base of the project. I've added enough > group maps and domain aliases to ensure the current top ten is as > reflective as it can be. As of this commit running: >

[Qemu-devel] [Bug 1786343] Re: QEMU v3.0.0-rc4 configure fails with --enable-mpath on CentOS 7.5

2018-12-12 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1786343 Title: QEMU v3.0.0-rc4 configure fails with --enable-mpath on CentOS 7.5 Stat

[Qemu-devel] [PATCH v4 09/11] pci: Reuse pci-bridge hotplug handler handlers for pcie-pci-bridge

2018-12-12 Thread David Hildenbrand
These functions are essentially the same, we only have to use object_get_typename() for reporting errors. So let's share the implementation of hotplug handler callbacks. Suggested-by: Igor Mammedov Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/pci-bridge/pci_bridge_dev.c

[Qemu-devel] [Bug 1793119] Re: Wrong floating-point emulation on AArch64 with FPCR set to zero

2018-12-12 Thread Thomas Huth
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=5dfbc9e4903c0121140f2 ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1793119 Title:

[Qemu-devel] [PATCH v4 10/11] pci/shpc: perform unplug via the hotplug handler

2018-12-12 Thread David Hildenbrand
Introduce and use the "unplug" callback. This is a preparation for multi-stage hotplug handlers, whereby the bus hotplug handler is overwritten by the machine hotplug handler. This handler will then pass control to the bus hotplug handler. So to get this running cleanly, we also have to make sure

Re: [Qemu-devel] [PATCH] virt: Fix broken indentation

2018-12-12 Thread Thomas Huth
On 2018-12-12 01:31, Eduardo Habkost wrote: > I introduced indentation using tabs instead of spaces in another > commit. Peter reported the problem, and I failed to fix that > before sending my pull request. > > Reported-by: Peter Maydell > Fixes: 951597607696 ("virt: Eliminate separate instance

[Qemu-devel] [Bug 1797033] Re: Running with -rtc clock=vm, base= introduces arbitrary base shift at guest startup

2018-12-12 Thread Thomas Huth
Fix has been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=eb6a52099160f1a6e66d7e ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs

[Qemu-devel] [PATCH v4 11/11] spapr_pci: perform unplug via the hotplug handler

2018-12-12 Thread David Hildenbrand
Introduce and use the "unplug" callback. This is a preparation for multi-stage hotplug handlers, whereby the bus hotplug handler is overwritten by the machine hotplug handler. This handler will then pass control to the bus hotplug handler. So to get this running cleanly, we also have to make sure

[Qemu-devel] [Bug 1768246] Re: cpu-exec.c:648: cpu_loop_exec_tb: Assertion `use_icount' failed.

2018-12-12 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1768246 Title: cpu-exec.c:648: cpu_loop_exec_tb: Assertion `use_icount' failed. Statu

Re: [Qemu-devel] [Xen-devel] xen_disk qdevification (was: [PATCH 0/3] Performance improvements for xen_disk v2)

2018-12-12 Thread Paul Durrant
> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: 12 December 2018 09:00 > To: Kevin Wolf > Cc: Tim Smith ; Stefano Stabellini > ; qemu-bl...@nongnu.org; arm...@redhat.com; qemu- > de...@nongnu.org; Max Reitz ; Paul Durrant > ; Anthony Perard ; > xen-de...@lists.xenp

Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error

2018-12-12 Thread P J P
+-- On Wed, 12 Dec 2018, P J P wrote --+ | | Also, can you rebase this patch on top of the patchset i posted last week: | | https://patchwork.kernel.org/patch/10705439/ | | Okay, I'll send revised patch set. Thanks so much for the prompt review. I tried to git apply above patch-set over v3.1.0-rc

[Qemu-devel] [Bug 1716292] Re: User mode emulation returns wrong value for write(fd, NULL, 0)

2018-12-12 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1716292 Title: User mode emulation returns wrong value for write(fd, NULL, 0) Status

[Qemu-devel] [PATCH v4 0/2] qapi/range/memory-device: fixes and cleanups

2018-12-12 Thread David Hildenbrand
These are the two leftovers from [PATCH v3 0/7] qapi/range/memory-device: fixes and cleanups The remaining patches extent the QEMU range code and rewrite memory-device code to make use of it. v3 -> v4: - "memory-device: rewrite address assignment using ranges" -- Use better error messages --

[Qemu-devel] [Bug 1795527] Re: Malformed audio and video output stuttering after upgrade to QEMU 3.0

2018-12-12 Thread Thomas Huth
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=6cdc2d189cb60a9d13e ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1795527 Title: Ma

[Qemu-devel] [PATCH v4 1/2] range: add some more functions

2018-12-12 Thread David Hildenbrand
Add some more functions that will be used in memory-device context. range_init(): Init using lower bound and size, check for validity range_init_nofail(): Init using lower bound and size, validity asserted range_size(): Extract the size of a range range_overlaps_range(): Check for overlaps of two

[Qemu-devel] [Bug 1804323] Re: qemu segfaults in virtio-scsi driver if underlying device returns -EIO

2018-12-12 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1804323 Title: qemu segfaults in virtio-scsi driver if underlying device returns -EIO

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu 2/3] ppc/spapr: Receive and store device tree blob from SLOF

2018-12-12 Thread Greg Kurz
On Wed, 12 Dec 2018 10:57:20 +1100 Alexey Kardashevskiy wrote: > On 12/12/2018 03:35, Greg Kurz wrote: > > On Tue, 11 Dec 2018 16:49:25 +1100 > > Alexey Kardashevskiy wrote: > > > >> SLOF receives a device tree and updates it with various properties > >> before switching to the guest kernel a

[Qemu-devel] [Bug 1777672] Re: QEMU raspi virtual/physical frame buffer not implemented

2018-12-12 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1777672 Title: QEMU raspi virtual/physical frame buffer not implemented Status in QEM

[Qemu-devel] [Bug 1774677] Re: -icount increases boot time by >10x

2018-12-12 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1774677 Title: -icount increases boot time by >10x Status in QEMU: Fix Released Bu

[Qemu-devel] [PULL 0/2] Block patches

2018-12-12 Thread Stefan Hajnoczi
The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 19:18:58 +) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/block-pull-re

[Qemu-devel] [PULL 1/2] virtio-blk: rename iov to out_iov in virtio_blk_handle_request()

2018-12-12 Thread Stefan Hajnoczi
From: Dongli Zhang In virtio_blk_handle_request(), in_iov is used for input header while iov is used for output header. Rename iov to out_iov to pair output header's name with in_iov to avoid confusing people when reading source code. Signed-off-by: Dongli Zhang Message-id: 1541520556-8334-1-gi

Re: [Qemu-devel] [RFC PATCH] contrib: add a basic gitdm config

2018-12-12 Thread Greg Kurz
On Wed, 12 Dec 2018 10:30:13 +0100 Thomas Huth wrote: > On 2018-12-11 18:42, Alex Bennée wrote: > > This is a QEMU specific version of a gitdm config for generating > > reports on the contributor base of the project. I've added enough > > group maps and domain aliases to ensure the current top te

[Qemu-devel] [PULL 1/6] s390x/zpci: drop msix.available

2018-12-12 Thread Cornelia Huck
From: David Hildenbrand I fail to see why this is useful as we require MSIX always and completely fail adding a device. Signed-off-by: David Hildenbrand Message-Id: <20181105110313.29312-2-da...@redhat.com> Fixes: 4f6482bfe3da1e6b51ad4722a0c22f22f0d54a3b Reviewed-by: Thomas Huth Reviewed-by: C

[Qemu-devel] [PULL 0/6] s390x: first batch of 4.0 changes

2018-12-12 Thread Cornelia Huck
The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 19:18:58 +) are available in the Git repository at: https://github.com/cohuck/qemu tags/s390

[Qemu-devel] [PULL 2/2] virtio-blk: fix comment for virtio_blk_rw_complete as nalloc is initially -1

2018-12-12 Thread Stefan Hajnoczi
From: Dongli Zhang The initial value of nalloc is -1, but not 1. Signed-off-by: Dongli Zhang Reviewed-by: Laurent Vivier Message-id: 1541479952-32355-1-git-send-email-dongli.zh...@oracle.com Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[Qemu-devel] [PULL 2/6] s390x: introduce 4.0 compat machine

2018-12-12 Thread Cornelia Huck
Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index a0615a8b35..fd9d0b0542 100644 --- a/hw/s390x/s390-virtio-

[Qemu-devel] [PATCH] vhost-vsock: support parse mergeable feature

2018-12-12 Thread jiangyiwen
Currently vhost-vsock doesn't have any feature bits, so it don't support parse mergeable rx buffer feature. And the feature is support in another series of patches named "VSOCK: support mergeable rx buffer in vhost-vsock". So we neet to support parse mergeable feature in vhost-vsock if above patch

[Qemu-devel] [PULL 3/6] s390/MAINTAINERS: Add Halil as kvm and machine maintainer

2018-12-12 Thread Cornelia Huck
From: Christian Borntraeger Halil does more work in this area than I do right now. Lets add Halil. Signed-off-by: Christian Borntraeger Message-Id: <20181204133802.100998-1-borntrae...@de.ibm.com> Acked-by: Halil Pasic Signed-off-by: Cornelia Huck --- MAINTAINERS | 4 +++- 1 file changed, 3

[Qemu-devel] [PULL 4/6] s390x/tod: Properly stop the KVM TOD while the guest is not running

2018-12-12 Thread Cornelia Huck
From: David Hildenbrand Just like on other architectures, we should stop the clock while the guest is not running. This is already properly done for TCG. Right now, doing an offline migration (stop, migrate, cont) can easily trigger stalls in the guest. Even doing a (hmp) stop ... wait 2

[Qemu-devel] [PULL 5/6] vfio-ap: flag as compatible with balloon

2018-12-12 Thread Cornelia Huck
vfio-ap devices do not pin any pages in the host. Therefore, they are compatible with memory ballooning. Flag them as compatible, so both vfio-ap and a balloon can be used simultaneously. Cc: qemu-sta...@nongnu.org Acked-by: Christian Borntraeger Tested-by: Tony Krowiak Reviewed-by: Halil Pasic

[Qemu-devel] [PULL 6/6] hw/s390x/virtio-ccw.c: Don't take address of fields in packed structs

2018-12-12 Thread Cornelia Huck
From: Peter Maydell Taking the address of a field in a packed struct is a bad idea, because it might not be actually aligned enough for that pointer type (and thus cause a crash on dereference on some host architectures). Newer versions of clang warn about this. Avoid the bug by not using the "mo

Re: [Qemu-devel] [PULL 0/8] Set minimum compiler versions to GCC 4.8 and Clang 3.4

2018-12-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1544606032-16924-1-git-send-email-th...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT B

[Qemu-devel] [Bug 1528214] Re: qemu 1.7.0 vhost_net crash

2018-12-12 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU and the kernel? Or could we close this ticket nowadays? ... also, since this looks like a kernel bug instead of a QEMU bug, have you tried to report it to the KVM or virtio mailing list instead? *

[Qemu-devel] [PATCH v1] pc: Use hotplug_handler_(plug|unplug|unplug_request)

2018-12-12 Thread David Hildenbrand
Let's avoid manually looking up the hotplug handler class. Use the existing wrappers instead. Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 30 -- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 4cd2fbca4d..c88571

[Qemu-devel] [Bug 1528718] Re: Initial monitor does not output anything on Windows (MSYS2 binary)

2018-12-12 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscrib

[Qemu-devel] [Bug 1789751] Re: Using -overcommit flag leads to qemu crashing

2018-12-12 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1789751 Title: Using -overcommit flag leads to qemu crashing Status in QEMU: Fix Re

Re: [Qemu-devel] [RFC PATCH] contrib: add a basic gitdm config

2018-12-12 Thread Alex Bennée
Thomas Huth writes: > On 2018-12-11 18:42, Alex Bennée wrote: >> This is a QEMU specific version of a gitdm config for generating >> reports on the contributor base of the project. I've added enough >> group maps and domain aliases to ensure the current top ten is as >> reflective as it can be.

[Qemu-devel] [PULL 00/11] Monitor patches for 2018-12-12

2018-12-12 Thread Markus Armbruster
The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 19:18:58 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-monitor-20

[Qemu-devel] [PULL 04/11] monitor: check if chardev can switch gcontext for OOB

2018-12-12 Thread Markus Armbruster
From: Marc-André Lureau Not all backends are able to switch gcontext. Those backends cannot drive a OOB monitor (the monitor would then be blocking on main thread). For example, ringbuf, spice, or more esoteric input chardevs like braille or MUX. We already forbid MUX because not all frontends

[Qemu-devel] [PULL 06/11] monitor: prevent inserting new monitors after cleanup

2018-12-12 Thread Markus Armbruster
From: Marc-André Lureau monitor_cleanup() is one of the last things main() calls before it returns. In the following patch, monitor_cleanup() will release the monitor_lock during flushing. There may be pending commands to insert new monitors, which would modify the mon_list during iteration, and

[Qemu-devel] [PULL 08/11] monitor: Suspend monitor instead dropping commands

2018-12-12 Thread Markus Armbruster
From: Peter Xu When a QMP client sends in-band commands more quickly that we can process them, we can either queue them without limit (QUEUE), drop commands when the queue is full (DROP), or suspend receiving commands when the queue is full (SUSPEND). None of them is ideal: * QUEUE lets a misbe

[Qemu-devel] [PULL 02/11] monitor: accept chardev input from iothread

2018-12-12 Thread Markus Armbruster
From: Marc-André Lureau Chardev backends may not handle safely IO events from concurrent threads (may not handle I/O events from concurrent threads safely, only the write path is since commit > 9005b2a7589540a3733b3abdcfbccfe7746cd1a1). Better to wake up the chardev from the monitor IO thread if

Re: [Qemu-devel] [RFC PATCH] contrib: add a basic gitdm config

2018-12-12 Thread Cédric Le Goater
On 12/12/18 11:01 AM, Alex Bennée wrote: > > Thomas Huth writes: > >> On 2018-12-11 18:42, Alex Bennée wrote: >>> This is a QEMU specific version of a gitdm config for generating >>> reports on the contributor base of the project. I've added enough >>> group maps and domain aliases to ensure the

[Qemu-devel] [PULL 05/11] colo: check chardev can switch context

2018-12-12 Thread Markus Armbruster
From: Marc-André Lureau COLO uses a worker context (iothread) to drive the chardev. All backends are not able to switch the context, let's report an error in this case. Signed-off-by: Marc-André Lureau Message-Id: <20181205203737.9011-6-marcandre.lur...@redhat.com> Reviewed-by: Li Zhijian Revi

[Qemu-devel] [PULL 01/11] monitor: inline ambiguous helper functions

2018-12-12 Thread Markus Armbruster
From: Marc-André Lureau The function were not named with "mon_iothread", or following the AIO vs GMainContext distinction. Inline them instead. Signed-off-by: Marc-André Lureau Reviewed-by: Peter Xu Reviewed-by: Markus Armbruster Message-Id: <20181205203737.9011-2-marcandre.lur...@redhat.com>

[Qemu-devel] [PULL 03/11] char: add a QEMU_CHAR_FEATURE_GCONTEXT flag

2018-12-12 Thread Markus Armbruster
From: Marc-André Lureau QEMU_CHAR_FEATURE_GCONTEXT declares the character device can switch GMainContext. Assert we don't switch context when the character device doesn't provide this feature. Character device users must not violate this restriction. In particular, user configurations that vio

[Qemu-devel] [PULL 09/11] monitor: Remove "x-oob", offer capability "oob" unconditionally

2018-12-12 Thread Markus Armbruster
From: Peter Xu Out-of-band command execution was introduced in commit cf869d53172. Unfortunately, we ran into a regression, and had to turn it into an experimental option for 2.12 (commit be933ffc23). http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html The regression has since

[Qemu-devel] [PULL 10/11] Revert "tests: Add parameter to qtest_init_without_qmp_handshake"

2018-12-12 Thread Markus Armbruster
From: Peter Xu This reverts commit ddee57e0176f6ab53b13c6c97605b62737a8fd7a. Meanwhile, revert one line from fa198ad9bdef to make sure qtest_init_without_qmp_handshake() will only pass in one parameter. Reviewed-by: Markus Armbruster Reviewed-by: Marc-André Lureau Signed-off-by: Peter Xu Mes

[Qemu-devel] [PULL 11/11] tests: add oob functional test for test-qmp-cmds

2018-12-12 Thread Markus Armbruster
From: Peter Xu Straightforward test just to let the test-qmp-cmds be complete. Reviewed-by: Marc-André Lureau Signed-off-by: Peter Xu Message-Id: <20181009062718.1914-6-pet...@redhat.com> Signed-off-by: Markus Armbruster --- tests/test-qmp-cmds.c | 16 1 file changed, 16 ins

[Qemu-devel] [PULL 1/2] tracetool: Include thread id information in log backend

2018-12-12 Thread Stefan Hajnoczi
From: Fabiano Rosas Currently the log backend prints the process id of QEMU at the start of each output line, but since threads share the same PID there is no clear distinction between their outputs. Having the thread id present in the log makes it easier to see when output comes from different

[Qemu-devel] [PULL 07/11] monitor: avoid potential dead-lock when cleaning up

2018-12-12 Thread Markus Armbruster
From: Marc-André Lureau When a monitor is connected to a Spice chardev, the monitor cleanup can dead-lock: #0 0x7f43446637fd in __lll_lock_wait () at /lib64/libpthread.so.0 #1 0x7f434465ccf4 in pthread_mutex_lock () at /lib64/libpthread.so.0 #2 0x556dd79f22ba in qemu_mutex_lock

[Qemu-devel] [PULL 0/2] Tracing patches

2018-12-12 Thread Stefan Hajnoczi
The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 19:18:58 +) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-

[Qemu-devel] [PULL 2/2] trace: simple style changes

2018-12-12 Thread Stefan Hajnoczi
From: Larry Dewey This changes two lines in simple.c that end with a comma, and replaces them with a semi-colon. Signed-off-by: Larry Dewey Reviewed-by: John Snow Message-id: 20181127190849.10558-1-lde...@suse.com Signed-off-by: Stefan Hajnoczi --- trace/simple.c | 4 ++-- 1 file changed, 2

[Qemu-devel] [RFC PATCH v2] contrib: add a basic gitdm config

2018-12-12 Thread Alex Bennée
This is a QEMU specific version of a gitdm config for generating reports on the contributor base of the project. I've added enough group maps and domain aliases to ensure the current top ten is as reflective as it can be. As of this commit running: git log --numstat --since "Last Year" | gitdm -

Re: [Qemu-devel] [RFC PATCH v2] contrib: add a basic gitdm config

2018-12-12 Thread Daniel P . Berrangé
On Wed, Dec 12, 2018 at 10:25:48AM +, Alex Bennée wrote: > This is a QEMU specific version of a gitdm config for generating > reports on the contributor base of the project. I've added enough > group maps and domain aliases to ensure the current top ten is as > reflective as it can be. As of th

[Qemu-devel] ping Re: [PATCH v4 00/10] NBD reconnect

2018-12-12 Thread Vladimir Sementsov-Ogievskiy
ping 31.07.2018 20:30, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > Here is NBD reconnect. Previously, if connection failed all current > and future requests will fail. After the series, nbd-client driver > will try to reconnect unlimited times. During first @reconnect-delay > seconds of rec

[Qemu-devel] 4.0 changelog open - maintainers update after PULL is merged

2018-12-12 Thread Daniel P . Berrangé
Rather than wait until the feature freeze to fill out the release changelog, lets try a new approach for 4.0 where we fill it out as code is merged. I've created a changelog template for 4.0: https://wiki.qemu.org/ChangeLog/4.0 Any maintainer who sends a PULL request, should make appropriate ad

  1   2   3   4   5   6   >