[Qemu-devel] [PATCH 04/71] vhost-net: compile it on all targets that have virtio-net.

2018-12-03 Thread Paolo Bonzini
This shows a preexisting bug: if a KVM target did not have virtio-net enabled, it would fail with undefined symbols when vhost was enabled. This must now be fixed, lest targets that have no virtio-net fail to compile. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- configu

[Qemu-devel] [PATCH 16/71] tests/libqos: rename qpci_init_pc and qpci_init_spapr functions

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Rename qpci_init_pc in qpci_pc_new and qpci_init_spapr in qpci_spapr_new, since theese function actually allocate a new pci struct and initialize it. Changed QOSOps field name from qpci_init to qpci_new. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: P

[Qemu-devel] [PATCH 13/71] vhost-user-test: small changes to init_hugepagefs

2018-12-03 Thread Paolo Bonzini
After the conversion to qgraph, the equivalent of "main" will be in a constructor and will run even if the tests are not being requested. Therefore, it should not assert that init_hugepagefs succeeds and will be called when creating the TestServer. This patch changes the prototype of init_hugepage

[Qemu-devel] [PATCH 05/71] vhost-net: revamp configure logic

2018-12-03 Thread Paolo Bonzini
Detect all invalid configurations (e.g. mingw32 with vhost-user, non-Linux with vhost-kernel). As a collateral benefit, all vhost-kernel backends can be now disabled if one wants to reduce the attack surface. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- configure

[Qemu-devel] [PATCH 25/71] tests/libqos: arm/sabrelite machine node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add arm/sabrelite machine to the graph. This machine contains generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include |

[Qemu-devel] [PATCH 15/71] tests/libqos: introduce virtio_start_device

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito This function is intended to group all the qvirtio_* functions that start the qvirtio devices. Applied in all tests using this combination of functions. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/libqos/virtio.c| 7 ++

[Qemu-devel] [PATCH 23/71] tests/libqos: arm/raspi2 machine node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add arm/raspi2 machine to the graph. This machine contains a generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include| 1

[Qemu-devel] [PATCH 09/71] vhost-user-test: support VHOST_USER_PROTOCOL_F_CROSS_ENDIAN

2018-12-03 Thread Paolo Bonzini
This will be useful to run the qtest for ppc64 targets on (for example) x86_64 hosts. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- tests/vhost-user-test.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-te

[Qemu-devel] [PATCH 27/71] tests/libqos: aarch64/xlnx-zcu102 machine node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add xlnx-zcu102 machine to the graph. This machine contains generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include

Re: [Qemu-devel] [PATCH for-4.0 1/7] configure: Add a test for the minimum compiler version

2018-12-03 Thread Daniel P . Berrangé
On Mon, Dec 03, 2018 at 03:27:35PM +0100, Thomas Huth wrote: > On 2018-12-03 15:16, Daniel P. Berrangé wrote: > > On Mon, Dec 03, 2018 at 03:05:31PM +0100, Thomas Huth wrote: > >> So far we only had implicit requirements for the minimum compiler version, > >> e.g. we require at least GCC 4.1 for th

[Qemu-devel] [PATCH 28/71] qos-test: sdhci test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/sdhci-test in first qgraph test node, sdhci-test. This test consumes an sdhci interface and checks that its function return the expected values. Note that this test does not allocate any sdhci structure, it's all done by the qtest walking graph mech

[Qemu-devel] [PATCH 08/71] vhost-user: support cross-endian vnet headers

2018-12-03 Thread Paolo Bonzini
vhost-user already has a way to communicate the endianness of the guest via the vring endianness messages. The vring endianness always matches the vnet header endianness so there is no need to do anything else in the backend. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- net/

[Qemu-devel] [PATCH 29/71] tests/qgraph: add generic PCI testcases

2018-12-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 1 + tests/pci-test.c | 25 + 2 files changed, 26 insertions(+) create mode 100644 tests/pci-test.c diff --git a/tests/Makefile.include b/tests/Makefile.include index e6be21c..f749fae 100644 --- a/tests/Mak

[Qemu-devel] [PATCH 22/71] tests/libqos: sdhci driver and interface nodes

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for sdhci-pci and generic-sdhci (memory mapped) drivers. Both drivers implement (produce) the same interface sdhci, that provides the readw - readq - writeq functions. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PATCH 36/71] tests/libqos: remove global_qtest from virtio endianness checks

2018-12-03 Thread Paolo Bonzini
This is needed to support migration tests with qgraph. Signed-off-by: Paolo Bonzini --- tests/libqos/virtio-pci.c | 11 ++- tests/libqos/virtio.c | 5 + tests/libqos/virtio.h | 8 ++-- 3 files changed, 17 insertions(+), 7 deletions(-) diff --git a/tests/libqos/virtio-p

[Qemu-devel] [PATCH 11/71] vhost-user-test: reduce usage of global_qtest

2018-12-03 Thread Paolo Bonzini
Whenever the code can run on multiple QTestStates, use them explicitly instead of global_qtest. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- tests/vhost-user-test.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/t

[Qemu-devel] [PATCH 37/71] tests/libqos: virtio-mmio driver and interface nodes

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add virtio-mmio node in qgraph framework. virtio-mmio produces virtio-bus, the interface consumed by all virtio-*-device nodes. Being a memory-mapped device, it doesn't have to provide a constructor to qgraph, since it's always "contained" inside some other nodes

[Qemu-devel] [PATCH 26/71] tests/libqos: arm/xilinx-zynq-a9 machine node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add xilinx-zynq-a9 machine to the graph. This machine contains generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include

[Qemu-devel] [PATCH 35/71] tests/libqos: virtio-pci driver and interface nodes

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add QOSGraphObject to QVirtioPCIDevice structure, with a basic constructor. virtio-pci is not present in qgraph, since it will be used as starting point by its subclasses (virtio-*-pci) Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PATCH 21/71] tests/libqos: x86_64/pc machine node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add pc machine for the x86_64 QEMU binary. This machine contains an i440FX-pcihost driver, that contains itself a pci-bus-pc that produces the pci-bus interface. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include

[Qemu-devel] [PATCH 39/71] tests/qgraph: add generic virtio testcases

2018-12-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 1 + tests/virtio-test.c| 25 + 2 files changed, 26 insertions(+) create mode 100644 tests/virtio-test.c diff --git a/tests/Makefile.include b/tests/Makefile.include index 4545232..9603022 100644 --- a/tests/

[Qemu-devel] [PATCH 32/71] tests/libqos: has_buggy_msi flag

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito The Qgraph framework makes any test using pci bus run the same function using pci-pci and pci-spapr bus. However, some tests are not ready to use the spapr bus, due to a MSI bug. Until it does not get fixed, this flag allows them to skip the test Signed-off-by: E

[Qemu-devel] [PATCH 42/71] tests/libqos: virtio-9p driver and interface nodes

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-9p-pci and virtio-9p-device. Both nodes produce virtio-9p, but virtio-9p-pci receives a pci-bus and overrides virtio-pci QOSGraphObject and its functions, while virtio-9p-device receives a virtio and implements its own functions Signed

[Qemu-devel] [PATCH 24/71] tests/libqos: arm/smdkc210 machine node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add arm/smdkc210 machine machine to the graph. This machine contains generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include

[Qemu-devel] [PATCH 40/71] tests/libqos: virtio-serial driver and interface nodes

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-serial-pci and virtio-serial-device. Both nodes produce virtio-serial, but virtio-serial-pci receives a pci-bus and uses virtio-pci QOSGraphObject and functions, while virtio-serial-device receives a virtio-bus and implements its own fu

[Qemu-devel] [PATCH 33/71] tests/libqos: e1000e driver and interface nodes

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-e1000e. It consumes a pci-bus, and it's directly used by tests (e1000e is pci based). Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 1 + tests/libqos/e1000e.c | 260 ++

[Qemu-devel] [PATCH 45/71] tests/qgraph: remove virtio-balloon-test

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito The tests/virtio-balloon-test is covered by generic virtio tests, so remove it. Signed-off-by: Paolo Bonzini Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 3 --- tests/virtio-balloon-test.c | 33 -

[Qemu-devel] [PATCH 19/71] tests: qgraph API for the qtest driver framework

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph API that allows to add/remove nodes and edges from the graph, implementation of Depth First Search to discover the paths and basic unit test to check correctness of the API. Included also a main executable that takes care of starting the framework, crea

[Qemu-devel] [PATCH 44/71] tests/libqos: virtio-balloon driver and interface nodes

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-balloon-pci and virtio-balloon-device. Both nodes produce virtio-balloon, but virtio-balloon-pci receives a pci-bus and uses virtio-pci QOSGraphObject and functions, while virtio-balloon-device receives a virtio and implements its own f

[Qemu-devel] [PATCH 38/71] tests/libqos: arm/virt machine node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add arm/virt machine to the graph. This machine contains virtio-mmio, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 1 + tests

[Qemu-devel] [PATCH 46/71] tests/libqos: virtio-rng driver and interface nodes

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-rng-pci and virtio-rng-device. Both nodes produce virtio-rng, but virtio-rng-pci receives a pci-bus and uses virtio-pci QOSGraphObject and functions, while virtio-rng-device receives a virtio and implements its own functions Signed-off

[Qemu-devel] [PATCH 20/71] tests/libqos: pci-pc driver and interface nodes

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add pci-bus-pc node, move QPCIBusPC struct declaration in its header (since it will be needed by other drivers) and introduce a setter method for drivers that do not need to allocate but have to initialize QPCIBusPC. Signed-off-by: Emanuele Giuseppe Esposito Sig

[Qemu-devel] [PATCH 53/71] vhost-user-test: always use 256 MiB of guest memory

2018-12-03 Thread Paolo Bonzini
Some tests are using a small amount of RAM for the guest (2 MiB) in order to save host memory, others are using 512 MiB. However, pSeries machines only support multiples of 256 MiB. Using 256 MiB of memory does not use more host memory than now, even for the migration test that starts two guests,

[Qemu-devel] [PATCH 41/71] qos-test: virtio-console and virtio-serial test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/virtio-console-test and tests/virtio-serial-test in qgraph test node. This test consumes a virtio-serial interface and checks that its function return the expected values. Note that this test does not allocate any virtio-console or virtio-serial str

[Qemu-devel] [PATCH 54/71] qos-test: vhost-user test node

2018-12-03 Thread Paolo Bonzini
Convert tests/virtio-net-test in qgraph test node, virtio-net-test. This test consumes a virtio-net interface and checks that its function return the expected values. Note that this test does not allocate any virtio-net structure, it's all done by the qtest walking graph mechanism. Nevertheless,

[Qemu-devel] [PATCH 55/71] tests/libqos: virtio-scsi driver and interface nodes

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-scsi-pci and virtio-scsi-device. Both nodes produce virtio-scsi, but virtio-scsi-pci receives a pci-bus and uses virtio-pci QOSGraphObject and its functions, while virtio-scsi-device receives a virtio and implements its own functions S

[Qemu-devel] [PATCH 47/71] qos-test: virtio-rng test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/virtio-rng-test in qgraph test node, virtio-rng-test. This test consumes a virtio-rng interface and checks that its function return the expected values. Some functions are implemented only for virtio-rng-pci, so they don't consume virtio-rng, but vi

[Qemu-devel] [PATCH 30/71] tests/libqos: pci-spapr driver and interface nodes

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add pci-bus-spapr node, that produces pci-bus. Move QPCIBusSPAPR struct declaration in its header (since it will be needed by other drivers) and introduce a setter method for drivers that do not need to allocate but have to initialize QPCIBusSPAPR. Signed-off-by:

[Qemu-devel] [PATCH 59/71] qos-test: ac97 test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/ac97-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 +-- tests/ac97-test.c

[Qemu-devel] [PATCH 58/71] tests: move virtio entirely to qos-test

2018-12-03 Thread Paolo Bonzini
The only remaining test that needs libqos-virtio-obj-y is drive_del-test, which really only needs a function. Move that function to the test and remove libqos-virtio-obj-y. Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 9 - tests/drive_del-test.c | 25 +++---

[Qemu-devel] [PATCH 56/71] qos-test: virtio-scsi test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/virtio-scsi-test in qgraph test node, virtio-scsi-test. This test consumes a virtio-scsi interface and checks that its function return the expected values. Some functions are implemented only for virtio-scsi-pci, so they don't consume virtio-scsi, b

[Qemu-devel] [PATCH 31/71] tests/qgraph: ppc64/pseries machine node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add pseries machine for the ppc64 QEMU binary. This machine contains a spapr-pci-host-bridge driver, that contains itself a pci-bus-spapr that produces the pci-bus interface. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Mak

[Qemu-devel] [PATCH 63/71] qos-test: nvme test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/nvme-test to a driver node; the code to discover the PCI device is replaced by generic qgraph code, therefore we're not placing it in tests/libqos. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include

[Qemu-devel] [PATCH 67/71] qos-test: vmxnet3 test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/vmxnet3-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 +-- tests/vmxnet3-test

[Qemu-devel] [PATCH 34/71] qos-test: e1000e test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/e1000e-test in qgraph test node, e1000e-test. This test consumes an e1000e interface and checks that its function return the expected values. Note that this test does not allocate any e1000e structure, it's all done by the qtest walking graph mechan

[Qemu-devel] [PATCH 57/71] tests/libqos: remove pre-qgraph QVirtioPCIDevice API

2018-12-03 Thread Paolo Bonzini
Remove the qvirtio_pci_device_find* and qvirtio_pci_device_free APIs, now that they do not have any users. Signed-off-by: Paolo Bonzini --- tests/libqos/virtio-pci.c | 112 +++--- tests/libqos/virtio-pci.h | 4 -- 2 files changed, 17 insertions(+), 99 de

[Qemu-devel] [PATCH 65/71] qos-test: spapr-phb test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/spapr-phb-test to a qgraph test node, spapr-phb-test. This test adds another spapr-pci-host-bridge device in the ppc64/pseries machine Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 +-- tes

[Qemu-devel] [PATCH 68/71] qos-test: es1370 test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/es1370-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 +-- tests/es1370-test.c

[Qemu-devel] [PATCH 60/71] qos-test: tpci200 test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/tpci200-test to a driver node; currently it runs the PCI nop test only, but it also produces the ipack interface. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 +-- tests/libqos/tpci200.c |

[Qemu-devel] [PATCH 43/71] qos-test: virtio-9p test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/virtio-9p-test into a qgraph test node. This test consumes a virtio-9p interface and checks that its functions return the expected values. Note that this test does not allocate any virtio-9p structure, it's all done by the qtest walking graph mechan

[Qemu-devel] [PATCH 71/71] qos-test: megasas test node

2018-12-03 Thread Paolo Bonzini
Convert tests/megasas-test to a driver node; the code to discover the PCI device is replaced by generic qgraph code. Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 +- tests/megasas-test.c | 80 +- 2 files changed, 41 insertions(+),

[Qemu-devel] [PATCH 66/71] qos-test: usb-hcd-ohci test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/usb-hcd-ohci-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include| 4 +--- tests/usb

[Qemu-devel] [PATCH 62/71] qos-test: ne2k_pci test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/ne2000-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. The actual device consumed by the test is ne2k_pci. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PATCH 48/71] tests/libqos: virtio-blk driver and interface nodes

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-blk-pci and virtio-blk-device. Both nodes produce virtio-blk, but virtio-blk-pci receives a pci-bus and uses virtio-pci QOSGraphObject and functions, while virtio-blk-device receives a virtio and implements its own functions Signed-off

Re: [Qemu-devel] Calendar

2018-12-03 Thread Thomas Huth
On 2018-12-03 13:54, Gonzo FWS wrote: > Hey, I have written an embedded gameboy color emulator for my OS (IncludeOS) > which does run primarily in Qemu-KVM atm. And therein lies the problem - PS2 > only works with KVM enabled at present. > > Is it too late to submit something? I will submit a st

Re: [Qemu-devel] [PATCH 00/10] Remove deprecated load_image() function

2018-12-03 Thread Richard Henderson
On 11/30/18 9:17 AM, Peter Maydell wrote: > Peter Maydell (10): > hw/ppc/mac_newworld, mac_oldworld: Don't use load_image() > hw/ppc/ppc405_boards: Don't use load_image() > hw/smbios/smbios.c: Don't use load_image() > hw/pci/pci.c: Don't use load_image() > hw/i386/pc.c: Don't use load_ima

[Qemu-devel] [PATCH 64/71] qos-test: pcnet test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/pcnet-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 +-- tests/pcnet-test.c

[Qemu-devel] [PATCH 49/71] qos-test: virtio-blk test node

2018-12-03 Thread Paolo Bonzini
Convert tests/virtio-blk-test in qgraph test node, virtio-blk-test. This test consumes a virtio-blk interface and checks that its function return the expected values. Some functions are implemented only for virtio-blk-pci, so they don't consume virtio-blk, but virtio-blk-pci Note that this test d

Re: [Qemu-devel] QEMU/NEMU boot time with several x86 firmwares

2018-12-03 Thread Rob Bradford
Hi Stefano, thanks for capturing all these numbers, On Mon, 2018-12-03 at 15:27 +0100, Stefano Garzarella wrote: > Hi Rob, > I continued to investigate the boot time, and as you suggested I > looked also at qemu-lite 2.11.2 > (https://github.com/kata-containers/qemu) and NEMU "virt" machine. I > d

Re: [Qemu-devel] [PATCH v3 05/16] tcg/arm: Remove reloc_pc24_atomic

2018-12-03 Thread Alex Bennée
Richard Henderson writes: > It is unused since 3fb53fb4d12f2e7833bd1659e6013237b130ef20. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/arm/tcg-target.inc.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-tar

[Qemu-devel] [PATCH 69/71] qos-test: eepro100 test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/eepro100-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. For now, all nodes share the same constructor and destructor. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bo

[Qemu-devel] [PATCH 51/71] qos-test: virtio-net test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/virtio-net-test in qgraph test node, virtio-net-test. This test consumes a virtio-net interface and checks that its function return the expected values. Some functions are implemented only for virtio-net-pci, so they don't consume virtio-net, but vi

[Qemu-devel] [PATCH 70/71] qos-test: e1000 test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/e1000-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 +-- tests/e1000-test.c

Re: [Qemu-devel] [RFC 0/5] ui/cocoa: Use OSX's main loop

2018-12-03 Thread Richard Henderson
On 12/1/18 6:30 AM, Peter Maydell wrote: > Patchset structure: > * patch 1 does the "make sure we have the iothread lock for >calls into QEMU" (which is effectively a no-op initially >since we'll already be holding that lock when our refresh >etc callbacks are called) > * patch 2 make

[Qemu-devel] [PATCH 50/71] tests/libqos: virtio-net driver and interface nodes

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Add qgraph nodes for virtio-net-pci and virtio-net-device. Both nodes produce virtio-net, but virtio-net-pci receives a pci-bus and overrides virtio-pci QOSGraphObject and its functions, while virtio-net-device receives a virtio and implements its own functions S

Re: [Qemu-devel] [PATCH v3 04/16] tcg/aarch64: Fold away "noaddr" branch routines

2018-12-03 Thread Alex Bennée
Richard Henderson writes: > There are one use apiece for these. There is no longer a need for > preserving branch offset operands, as we no longer re-translate. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/aarch64/tcg-target.inc.c | 21 ++--- >

[Qemu-devel] [PATCH 52/71] tests/libqos: support multiqueue for virtio-net

2018-12-03 Thread Paolo Bonzini
Initialize the additional virtqueues if they are supported. This is needed to switch vhost-user-test's multiqueue test to the virtio-net qgraph. Signed-off-by: Paolo Bonzini --- tests/libqos/virtio-net.c | 21 + tests/libqos/virtio-net.h | 4 ++-- tests/virtio-net-test.c |

[Qemu-devel] [PULL 2/3] nbd/client: Make x-dirty-bitmap more reliable

2018-12-03 Thread Eric Blake
The implementation of x-dirty-bitmap in qemu 3.0 (commit 216ee365) silently falls back to treating the server as not supporting NBD_CMD_BLOCK_STATUS if a requested meta_context name was not negotiated, which in turn means treating the _entire_ image as data. Since our hack relied on using 'qemu-img

[Qemu-devel] [PULL 1/3] nbd/server: Advertise all contexts in response to bare LIST

2018-12-03 Thread Eric Blake
The NBD spec, and even our code comment, says that if the client asks for NBD_OPT_LIST_META_CONTEXT with 0 queries, then we should reply with (a possibly-compressed representation of) ALL contexts that we are willing to let them try. But commit 3d068aff forgot to advertise qemu:dirty-bitmap:FOO.

[Qemu-devel] [PATCH 61/71] qos-test: ipoctal232 test node

2018-12-03 Thread Paolo Bonzini
From: Emanuele Giuseppe Esposito Convert tests/ipoctal232-test to a driver node; currently it runs the PCI nop test only, therefore we're not placing it in tests/libqos. This test creates a tpci200 node that produces an interface ipack consumed by the ipoctal232 device. Signed-off-by: Emanuele

[Qemu-devel] [PULL 0/3] NBD patches for 3.1-rc4

2018-12-03 Thread Eric Blake
The following changes since commit 4750e1a888ac3d320607f33b676f299005be98e6: Update version for v3.1.0-rc3 release (2018-11-28 17:37:34 +) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2018-12-03 for you to fetch changes up to c688e6ca7b41a10524

Re: [Qemu-devel] [PATCH RFC] qdev: Let the hotplug_unplug() caller delete the device

2018-12-03 Thread Cornelia Huck
On Wed, 28 Nov 2018 15:54:55 +0100 David Hildenbrand wrote: > When unplugging a device, at one point the device will be destroyed > via object_unparent(). This will, one the one hand, unrealize the > device hierarchy to be removed, and on the other hand, destroy/free the > device hierarchy. > >

[Qemu-devel] [PULL 3/3] nbd/client: Send NBD_CMD_DISC if open fails after connect

2018-12-03 Thread Eric Blake
If nbd_client_init() fails after we are already connected, then the server will spam logs with: Disconnect client, due to: Unexpected end-of-file before all bytes were read unless we gracefully disconnect before closing the connection. Ways to trigger this: $ opts=driver=nbd,export=foo,server.

Re: [Qemu-devel] [PATCH for-3.1 v3] iotests: simple mirror test with kvm on 1G image

2018-12-03 Thread Vladimir Sementsov-Ogievskiy
03.12.2018 18:12, Max Reitz wrote: > From: Vladimir Sementsov-Ogievskiy > > This test is broken without previous commit fixing dead-lock in mirror. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Max Reitz > --- > Based-on: 20181129101801.6421-2-vsement...@virtuozzo.com > > T

Re: [Qemu-devel] [PATCH 06/18] xen: add grant table interface for XenDevice-s

2018-12-03 Thread Anthony PERARD
On Wed, Nov 21, 2018 at 03:11:59PM +, Paul Durrant wrote: > The legacy PV backend infrastructure provides functions to map, unmap and > copy pages granted by frontends. Similar functionality will be required > by XenDevice implementations so this patch adds the necessary support. > > Signed-of

[Qemu-devel] [PATCH for-4.0 2/5] tcg/i386: Implement INDEX_op_extr{lh}_i64_i32 for 32-bit guests

2018-12-03 Thread Richard Henderson
This preserves the invariant that all TCG_TYPE_I32 values are zero-extended in the 64-bit host register. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 5 +++-- tcg/i386/tcg-target.inc.c | 6 ++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tcg/i386/tcg-tar

Re: [Qemu-devel] [PATCH for-4.0 3/7] configure: Remove old -fno-gcse workaround for GCC 4.6.x and 4.7.[012]

2018-12-03 Thread Richard Henderson
On 12/3/18 8:05 AM, Thomas Huth wrote: > Now that we require at least GCC 4.8, we don't need this als workaround > for 4.6 and 4.7 anymore. > > Signed-off-by: Thomas Huth > --- > Makefile.target | 3 --- > configure | 27 --- > 2 files changed, 30 deletions(-) Rev

[Qemu-devel] [PATCH for-4.0 3/5] tcg/i386: Assume 32-bit values are zero-extended

2018-12-03 Thread Richard Henderson
We now have an invariant that all TCG_TYPE_I32 values are zero-extended, which means that we do not need to extend them again during qemu_ld/st, either explicitly via a separate tcg_out_ext32u or implicitly via P_ADDR32. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 103 ++

[Qemu-devel] [PATCH for-4.0 0/5] tcg/i386: Improve guest_base handling

2018-12-03 Thread Richard Henderson
This tidies guest_base handling such that (1) we require no scratch registers, (2) we require no extra instructions besides the memory op, and (3) we reduce the size of the memory op by omitting a prefix. In principal point 3 is offset by adding additional opcodes to handle zero-extension when con

Re: [Qemu-devel] [PATCH v5 27/36] sysbus: add a sysbus_mmio_unmap() helper

2018-12-03 Thread Cédric Le Goater
On 11/29/18 5:36 PM, Cédric Le Goater wrote: > On 11/29/18 5:09 AM, David Gibson wrote: >> On Fri, Nov 16, 2018 at 11:57:20AM +0100, Cédric Le Goater wrote: >>> This will be used to remove the MMIO regions of the POWER9 XIVE >>> interrupt controller when the sPAPR machine is reseted. >>> >>> Signed

Re: [Qemu-devel] [PATCH for-3.1 v3 1/2] usb-mtp: fix utf16_to_str

2018-12-03 Thread Philippe Mathieu-Daudé
On 3/12/18 11:10, Gerd Hoffmann wrote: > Make utf16_to_str return an allocated string. Remove the assumtion that > the number of string bytes equals the number of utf16 chars (which is > only true for ascii chars). Instead call wcstombs twice, once to figure > the storage size and once for the ac

[Qemu-devel] [PATCH for-4.0 5/5] tcg/i386: Add setup_guest_base_seg for FreeBSD

2018-12-03 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index b8d2dd5ba3..3a39b51685 100644 --- a/tcg/i386/tcg-target.inc.c +++ b/tcg/i386/tcg-target.inc.c @@ -1873,6 +1873,15

Re: [Qemu-devel] Calendar

2018-12-03 Thread Gonzo FWS
Sorry, I completely forgot to mention the demo image I attached contains the ROM "Floracy" which is a game that never found a publisher and was later made public by the author. Source: http://www.nesworld.com/article.php?system=gbc&data=gbchomebrew Gameboy Color Homebrew (www.nesworld.com)

Re: [Qemu-devel] [PATCH V4 for 3.1 1/4] net: drop too large packet early

2018-12-03 Thread Eric Blake
On 12/3/18 4:06 AM, Jason Wang wrote: We try to detect and drop too large packet (>INT_MAX) in 1592a9947036 ("net: ignore packet size greater than INT_MAX") during packet delivering. Unfortunately, this is not sufficient as we may hit another integer overflow when trying to queue such large packe

Re: [Qemu-devel] [PATCH v2 0/2] mirror dead-lock

2018-12-03 Thread Kevin Wolf
Am 29.11.2018 um 11:17 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > v2: add fix:) > > We've faced the following mirror bug: > > Just run mirror on qcow2 image more than 1G, and qemu is in dead lock. > > Dead lock described in 01, in short, we have extra aio_context_acquire > and

Re: [Qemu-devel] [PATCH for-4.0 4/7] Remove QEMU_ARTIFICIAL macro

2018-12-03 Thread Richard Henderson
On 12/3/18 8:05 AM, Thomas Huth wrote: > The code that used it has already been removed a while ago with commit > dc41aa7d34989b552ef ("tcg: Remove GET_TCGV_* and MAKE_TCGV_*"). > > Signed-off-by: Thomas Huth > --- > include/qemu/compiler.h| 6 -- > scripts/checkpatch.pl | 1 - > sc

Re: [Qemu-devel] [PATCH 07/18] xen: add event channel interface for XenDevice-s

2018-12-03 Thread Anthony PERARD
On Wed, Nov 21, 2018 at 03:12:00PM +, Paul Durrant wrote: > The legacy PV backend infrastructure provides functions to bind, unbind > and send notifications to event channnels. Similar functionality will be > required by XenDevice implementations so this patch adds the necessary > support. > >

Re: [Qemu-devel] [PATCH for-4.0 7/7] includes: Replace QEMU_GNUC_PREREQ with "__has_builtin || !defined(__clang__)"

2018-12-03 Thread Richard Henderson
On 12/3/18 8:05 AM, Thomas Huth wrote: > Since we require GCC version 4.8 or newer now, we can be sure that > the builtin functions are always available on GCC. And for Clang, > we can check the availablility with __has_builtin instead. > > Signed-off-by: Thomas Huth > --- > include/qemu/compile

Re: [Qemu-devel] [PATCH for-3.1 v3] iotests: simple mirror test with kvm on 1G image

2018-12-03 Thread Kevin Wolf
Am 03.12.2018 um 16:12 hat Max Reitz geschrieben: > From: Vladimir Sementsov-Ogievskiy > > This test is broken without previous commit fixing dead-lock in mirror. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Max Reitz Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH for-4.0 5/7] tcg/tcg.h: Remove GCC check for tcg_debug_assert() macro

2018-12-03 Thread Richard Henderson
On 12/3/18 8:05 AM, Thomas Huth wrote: > Both GCC v4.8 and Clang v3.4 support (our minimum versions) support > __builtin_unreachable(), so we can remove the version check here now. > > Signed-off-by: Thomas Huth > --- > tcg/tcg.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Review

Re: [Qemu-devel] [PATCH V4 for 3.1 2/4] virtio-net-test: accept variable length argument in pci_test_start()

2018-12-03 Thread Eric Blake
On 12/3/18 4:06 AM, Jason Wang wrote: This allows flexibility to be reused for all kinds of command line used by other tests. Signed-off-by: Jason Wang --- tests/virtio-net-test.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake -- Eric Bl

[Qemu-devel] [for-4.0 PATCH v2 1/9] pcie: Create enums for link speed and width

2018-12-03 Thread Alex Williamson
In preparation for reporting higher virtual link speeds and widths, create enums and macros to help us manage them. Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Tested-by: Geoffrey McRae Signed-off-by: Alex Williamson --- hw/pci/pcie.c |7 --- hw/vfio/pci.c |

[Qemu-devel] [PATCH for-4.0 1/5] tcg/i386: Propagate is64 to tcg_out_qemu_ld_direct

2018-12-03 Thread Richard Henderson
This helps preserve the invariant that all TCG_TYPE_I32 values are stored zero-extended in the 64-bit host registers. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i

Re: [Qemu-devel] [PATCH V4 for 3.1 0/4] Fix possible OOB during queuing packets

2018-12-03 Thread Peter Maydell
On Mon, 3 Dec 2018 at 10:06, Jason Wang wrote: > > Hi: > > This series tries to fix a possible OOB during queueing packets > through qemu_net_queue_append_iov(). This could happen when it tries > to queue a packet whose size is larger than INT_MAX which may lead > integer overflow. We've fixed sim

[Qemu-devel] [for-4.0 PATCH v2 3/9] qapi: Define PCIe link speed and width properties

2018-12-03 Thread Alex Williamson
Create properties to be able to define speeds and widths for PCIe links. The only tricky bit here is that our get and set callbacks translate from the fixed QAPI automagic enums to those we define in PCI code to represent the actual register segment value. Cc: Eric Blake Cc: Markus Armbruster T

[Qemu-devel] [PATCH for-4.0 4/5] tcg/i386: Precompute all guest_base parameters

2018-12-03 Thread Richard Henderson
These values are constant between all qemu_ld/st invocations; there is no need to figure this out each time. If we cannot use a segment or an offset directly for guest_base, load the value into a register in the prologue. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 101

[Qemu-devel] [for-4.0 PATCH v2 2/9] pci: Sync PCIe downstream port LNKSTA on read

2018-12-03 Thread Alex Williamson
The PCIe link speed and width between a downstream device and its upstream port is negotiated on real hardware and susceptible to dynamic changes due to signal issues and power management. In the emulated device case there is no real hardware link, but we still might wish to have some consistency

[Qemu-devel] [for-4.0 PATCH v2 4/9] pcie: Add link speed and width fields to PCIESlot

2018-12-03 Thread Alex Williamson
Add fields allowing the PCIe link speed and width of a PCIESlot to be configured, with an instance_post_init callback on the root port parent class to set defaults. This allows child classes to set these via properties or via their own instance_init callback, without requiring all implementions to

[Qemu-devel] [for-4.0 PATCH v2 6/9] pcie: Allow generic PCIe root port to specify link speed and width

2018-12-03 Thread Alex Williamson
Allow users to specify speed and width values for the generic PCIe root port. Defaults remain at 2.5GT/s & x1 for compatiblity. Note for libvirt testing that pcie-root-port controllers are given default names like "pci.7" which don't play well with using the "-set device.$name.$prop=$value" optio

Re: [Qemu-devel] [PATCH v5 06/36] ppc/xive: add support for the END Event State buffers

2018-12-03 Thread Cédric Le Goater
On 12/3/18 2:14 AM, David Gibson wrote: > On Fri, Nov 30, 2018 at 07:41:33AM +0100, Cédric Le Goater wrote: >> On 11/30/18 2:04 AM, David Gibson wrote: >>> On Thu, Nov 29, 2018 at 11:06:13PM +0100, Cédric Le Goater wrote: On 11/22/18 6:13 AM, David Gibson wrote: > On Fri, Nov 16, 2018 at 1

  1   2   3   4   >