Re: [Qemu-devel] [PATCH 1/3] nbd/server: Advertise all contexts in response to bare LIST

2018-11-30 Thread Vladimir Sementsov-Ogievskiy
30.11.2018 5:32, Eric Blake wrote: > The NBD spec, and even our code comment, says that if the client > asks for NBD_OPT_LIST_META_CONTEXT with 0 queries, then we should > reply with (a possibly-compressed representation of) ALL contexts > that we are willing to let them try. But commit 3d068aff f

Re: [Qemu-devel] [PATCH v5 16/36] spapr: add hcalls support for the XIVE exploitation interrupt mode

2018-11-30 Thread Cédric Le Goater
On 11/30/18 2:23 AM, David Gibson wrote: > On Thu, Nov 29, 2018 at 05:04:50PM +0100, Cédric Le Goater wrote: >> On 11/29/18 2:23 AM, David Gibson wrote: >>> On Wed, Nov 28, 2018 at 11:21:37PM +0100, Cédric Le Goater wrote: On 11/28/18 5:25 AM, David Gibson wrote: > On Fri, Nov 16, 2018 at

Re: [Qemu-devel] [PATCH v7 17/19] replay: add BH oneshot event for block layer

2018-11-30 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 10.10.2018 um 15:35 hat Pavel Dovgalyuk geschrieben: > > Replay is capable of recording normal BH events, but sometimes > > there are single use callbacks scheduled with aio_bh_schedule_oneshot > > function. This patch enables recording and replayin

Re: [Qemu-devel] [PATCH 2/3] nbd/client: Make x-dirty-bitmap more reliable

2018-11-30 Thread Vladimir Sementsov-Ogievskiy
30.11.2018 5:32, Eric Blake wrote: > The implementation of x-dirty-bitmap in qemu 3.0 silently > falls back to treating the server as not supporting > NBD_CMD_BLOCK_STATUS if a requested meta_context name was not > negotiated, which in turn means treating the _entire_ image as > data. Since our hac

Re: [Qemu-devel] [PATCH v3 1/1] ppc/pnv: Add model for Power8 PHB3 PCIe Host bridge

2018-11-30 Thread Cédric Le Goater
On 11/30/18 5:26 AM, David Gibson wrote: > On Mon, Jul 30, 2018 at 07:17:48PM +0200, Cédric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> This is a model of the PCIe Host Bridge (PHB3) found on a Power8 >> processor. It includes the PowerBus logic interface (PBCQ), IOMMU >> support, a sin

[Qemu-devel] KVM call for agenda for 2018-12-04

2018-11-30 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: B

Re: [Qemu-devel] [PATCH] hostmem: Validate host-nodes before setting bitmap

2018-11-30 Thread Stefano Garzarella
On Thu, Nov 29, 2018 at 7:59 PM Eduardo Habkost wrote: > > host_memory_backend_set_host_nodes() was not validating > host-nodes before writing to backend->host_nodes, making QEMU > write beyond the end of the bitmap. > > Fix the crash and add a simple regression test for the fix. > > Reported-by:

[Qemu-devel] [Bug 1519037] Re: qemu-i386 32-bit segfault

2018-11-30 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscrib

Re: [Qemu-devel] [PATCH v1 1/4] hw/arm: versal: Remove bogus virtio-mmio creation

2018-11-30 Thread Luc Michel
On 11/29/18 5:36 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Remove bogus virtio-mmio creation. This was an accidental > left-over an experiment. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Luc Michel Luc > --- > hw/arm/xlnx-versal-virt.c | 1 - > 1 file changed, 1 d

Re: [Qemu-devel] [PATCH] hostmem: Validate host-nodes before setting bitmap

2018-11-30 Thread Markus Armbruster
Eduardo Habkost writes: > host_memory_backend_set_host_nodes() was not validating > host-nodes before writing to backend->host_nodes, making QEMU > write beyond the end of the bitmap. > > Fix the crash and add a simple regression test for the fix. > > Reported-by: Markus Armbruster > Signed-off-

Re: [Qemu-devel] [PATCH 3/3] nbd/client: Send NBD_CMD_DISC if open fails after connect

2018-11-30 Thread Vladimir Sementsov-Ogievskiy
30.11.2018 5:32, Eric Blake wrote: > If nbd_client_init() fails after we are already connected, > then the server will spam logs with: > > Disconnect client, due to: Unexpected end-of-file before all bytes were read > > unless we gracefully disconnect before closing the connection. > > Ways to t

Re: [Qemu-devel] [PATCH v2 6/6] s390x/vfio: ap: Implementing AP Queue Interrupt Control

2018-11-30 Thread Cornelia Huck
On Thu, 29 Nov 2018 16:53:28 -0500 Tony Krowiak wrote: > On 11/22/18 11:35 AM, Pierre Morel wrote: > > +static uint32_t ap_pqap_clear_irq(VFIODevice *vdev, APQueue *apq) > > +{ > > +struct vfio_ap_aqic param; > > +uint32_t retval; > > + > > +param.apqn = apq->apqn; > > +param.isc

[Qemu-devel] [PATCH for-4.0] 9p: remove support for the "handle" backend

2018-11-30 Thread Greg Kurz
The "handle" fsdev backend was deprecated in QEMU 2.12.0 with: commit db3b3c7281ca82e2647e072a1f97db111313dd73 Author: Greg Kurz Date: Mon Jan 8 11:18:23 2018 +0100 9pfs: deprecate handle backend This backend raise some concerns: - doesn't support symlinks - fails +100 tests

[Qemu-devel] [PATCH v4 2/5] The discard flag for block stream operation

2018-11-30 Thread Andrey Shinkevich
Adding a parameter to QMP block-stream command to allow discarding blocks in the backing chain while blocks are being copied to the active layer. Signed-off-by: Andrey Shinkevich --- block/stream.c| 3 +-- blockdev.c| 8 +++- hmp-commands.hx | 4 ++-- hm

[Qemu-devel] [PATCH v4 3/5] iotests: allow resume_drive by node name

2018-11-30 Thread Andrey Shinkevich
From: Vladimir Sementsov-Ogievskiy After node graph changes, we may not be able to resume_drive by device name (backing files are not recursively searched). So, lets allow to resume by node-name. Set constant name for breakpoints, to avoid introducing extra parameters. Signed-off-by: Vladimir Se

[Qemu-devel] [PATCH v4 5/5] iotests: 030 with block-stream discard

2018-11-30 Thread Andrey Shinkevich
The classes that set tests for the block-stream command with discard option on are inherited from the existent classes in the 030 file. Some QMP commands do not have the optional 'discard' argument because the WRITE permission is not being granted when the filter is inserted. For instance, it is tr

[Qemu-devel] [PATCH v4 4/5] iotests: prepare 030 for graph change

2018-11-30 Thread Andrey Shinkevich
The discard option for block-stream command requires insertion of the filter to write into the backing chain. In that case, the job will not resume by device name. So, the node name is specified. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/030 | 20 1 file change

[Qemu-devel] [PATCH v4 1/5] Discard blocks while copy-on-read

2018-11-30 Thread Andrey Shinkevich
Discards the block duplicated in an intermediate backing file after the block have been copied into the active layer during QMP block-stream operation. It saves the disk space while merging external snapshots. Signed-off-by: Andrey Shinkevich --- block/stream.c | 428

[Qemu-devel] [PATCH v4 0/5] Discrad blocks during block-stream operation

2018-11-30 Thread Andrey Shinkevich
Dear all, The given feature discards blocks with copy-on-read operation while the streaming process runs. Adding the 'discard' argument to the QMP block-stream command allows dropping a block in the backing chain after it has been copied to the active layer. That will elude the block duplication i

Re: [Qemu-devel] [PATCH v2 01/16] virtio: split vhost vsock bits from virtio-pci

2018-11-30 Thread Juan Quintela
Thomas Huth wrote: > On 2018-11-29 07:30, Thomas Huth wrote: >> On 2018-11-26 20:59, Juan Quintela wrote: >>> Signed-off-by: Juan Quintela >>> >>> --- >>> >>> Updated copyright info >>> Also split virtio-pci.h bits >>> --- >>> hw/virtio/Makefile.objs | 2 +- >>> hw/virtio/vhost-vsock-pci.c

Re: [Qemu-devel] [PATCH for-4.0 0/4] Small checkpatch fixes and improvements

2018-11-30 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH for-4.0 0/4] Small checkpatch fixes and improvements Message-id: 20181129090120.28828-1-pbonz...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=ba

Re: [Qemu-devel] [PATCH 1/3] qapi: move ShutdownCause to qapi/run-state.json

2018-11-30 Thread Markus Armbruster
Dominik Csapak writes: > this makes it possible to use the reason as return value > in a QMP event, such as SHUTDOWN Please start your sentences with a capital letter and end them with punctuation. The patch's purpose could perhaps be stated a bit more clearly. Let me try: qapi: Turn Shutdo

Re: [Qemu-devel] [PATCH for-4.0] 9p: remove support for the "handle" backend

2018-11-30 Thread Thomas Huth
On 2018-11-30 09:49, Greg Kurz wrote: > The "handle" fsdev backend was deprecated in QEMU 2.12.0 with: > > commit db3b3c7281ca82e2647e072a1f97db111313dd73 > Author: Greg Kurz > Date: Mon Jan 8 11:18:23 2018 +0100 > > 9pfs: deprecate handle backend > > This backend raise some concerns:

Re: [Qemu-devel] [PATCH v2 1/6] s390x/vfio: ap: Finding the AP bridge

2018-11-30 Thread Pierre Morel
On 29/11/2018 21:30, Tony Krowiak wrote: On 11/22/18 11:35 AM, Pierre Morel wrote: In the case we will enter QEMU through interception of instructions, we will need to retrieve the AP devices. The base device is the AP bridge. Let us implement a way to retrieve the AP Bridge from qtree. Signed

Re: [Qemu-devel] [PATCH 1/3] qapi: move ShutdownCause to qapi/run-state.json

2018-11-30 Thread Markus Armbruster
One more thing... Markus Armbruster writes: > Dominik Csapak writes: > >> this makes it possible to use the reason as return value >> in a QMP event, such as SHUTDOWN > > Please start your sentences with a capital letter and end them with > punctuation. > > The patch's purpose could perhaps be

Re: [Qemu-devel] [PATCH V2 for 3.1 0/4] Fix possible OOB during queuing packets

2018-11-30 Thread P J P
+-- On Thu, 29 Nov 2018, Eric Blake wrote --+ | How important is this for 3.1? We've missed -rc3. Is this CVE quality | because of a guest being able to cause mayhem by intentionally getting into | this condition (in which case, we need it, as well as a CVE assigned)? Is it | pre-existing in 3

Re: [Qemu-devel] [PATCH v2] s390x/pci: add common fmb

2018-11-30 Thread Pierre Morel
On 31/10/2018 11:49, Cornelia Huck wrote: On Wed, 24 Oct 2018 11:58:33 +0800 Yi Min Zhao wrote: 在 2018/10/24 上午5:25, Cornelia Huck 写道: On Mon, 22 Oct 2018 13:17:34 +0100 Thomas Huth wrote: ...snip... If endianness has error, I think the values must looks wrong. The right thing is that

Re: [Qemu-devel] [PATCH v2 5/8] hw: arm: Convert the RSDP build to the buid_append_foo() API

2018-11-30 Thread Igor Mammedov
On Thu, 29 Nov 2018 14:24:25 +0100 Samuel Ortiz wrote: > Instead of filling a mapped and packed C structure field in random order > and being careful about endianness and sizes, build_rsdp() now uses > build_append_int_noprefix() to compose RSDP table. > > This makes for an easier to review and

Re: [Qemu-devel] [PATCH v2] s390x/pci: add common fmb

2018-11-30 Thread Cornelia Huck
On Fri, 30 Nov 2018 10:23:14 +0100 Pierre Morel wrote: > On 31/10/2018 11:49, Cornelia Huck wrote: > > On Wed, 24 Oct 2018 11:58:33 +0800 > > Yi Min Zhao wrote: > > > >> 在 2018/10/24 上午5:25, Cornelia Huck 写道: > >>> On Mon, 22 Oct 2018 13:17:34 +0100 > >>> Thomas Huth wrote: > >>> > >

Re: [Qemu-devel] [PATCH v2 2/6] s390x/vfio: ap: Use the APdevice as a child of the APBus

2018-11-30 Thread Pierre Morel
On 29/11/2018 21:42, Tony Krowiak wrote: On 11/22/18 11:35 AM, Pierre Morel wrote: Two good reasons to use the base device as a child of the AP BUS: - We can easily find the device without traversing the qtree. - In case we have different APdevice instantiation, VFIO with    interception or emul

Re: [Qemu-devel] [PATCH] hostmem: Validate host-nodes before setting bitmap

2018-11-30 Thread David Hildenbrand
On 29.11.18 19:57, Eduardo Habkost wrote: > host_memory_backend_set_host_nodes() was not validating > host-nodes before writing to backend->host_nodes, making QEMU > write beyond the end of the bitmap. > > Fix the crash and add a simple regression test for the fix. > > Reported-by: Markus Armbrus

Re: [Qemu-devel] [PATCH v2 8/8] hw: acpi: Remove AcpiRsdpDescriptor and fix tests

2018-11-30 Thread Samuel Ortiz
On Thu, Nov 29, 2018 at 04:07:43PM +0100, Andrew Jones wrote: > On Thu, Nov 29, 2018 at 02:24:28PM +0100, Samuel Ortiz wrote: > > The only remaining AcpiRsdpDescriptor users are the ACPI utils for the > > BIOS table tests. > > We remove that dependency and can thus remove the structure itself. > >

Re: [Qemu-devel] [PATCH] hostmem: Validate host-nodes before setting bitmap

2018-11-30 Thread David Hildenbrand
On 30.11.18 09:37, Markus Armbruster wrote: > Eduardo Habkost writes: > >> host_memory_backend_set_host_nodes() was not validating >> host-nodes before writing to backend->host_nodes, making QEMU >> write beyond the end of the bitmap. >> >> Fix the crash and add a simple regression test for the f

[Qemu-devel] [PATCH v3 16/21] timer/etraxfs_timer: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in etraxfs_timer_class_init(). Cc: edgar.igles...@gmail.com Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Edgar E. Iglesias --- hw/timer/etraxfs_timer.c | 14 +++--- 1 file change

[Qemu-devel] [PATCH v3 04/21] core/empty_slot: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in empty_slot_class_init(). Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- hw/core/empty_slot.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 6/8] hw: arm: Support both legacy and current RSDP build

2018-11-30 Thread Igor Mammedov
On Thu, 29 Nov 2018 14:24:26 +0100 Samuel Ortiz wrote: > We add the ability to build legacy or current RSDP tables, based on the > AcpiRsdpData revision field passed to build_rsdp(). > Although arm/virt only uses RSDP v2, adding that capability to > build_rsdp will allow us to share the RSDP buil

[Qemu-devel] [PATCH v3 11/21] milkymist-hpdmc: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in milkymist_hpdmc_class_init(). Cc: g...@mprc.pku.edu.cn Cc: mich...@walle.cc Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé --- hw/misc/milkymist-hpdmc.c | 9 +++-- 1 file changed, 3 insertions(+)

[Qemu-devel] [PATCH v3 09/21] input/pl050: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in pl050_class_init(). Cc: peter.mayd...@linaro.org Cc: qemu-...@nongnu.org Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé --- hw/input/pl050.c | 11 +-- 1 file changed, 5 insertions(+), 6 delet

[Qemu-devel] [PATCH v3 05/21] display/g364fb: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in g364fb_sysbus_class_init(). Cc: pbonz...@redhat.com Cc: kra...@redhat.com Cc: f4...@amsat.org Cc: alistair.fran...@wdc.com Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH v3 12/21] milkymist-pfpu: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in milkymist_pfpu_class_init(). Cc: mich...@walle.cc Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé --- hw/misc/milkymist-pfpu.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff

[Qemu-devel] [PATCH v3 08/21] milkymist-softusb: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in milkymist_softusb_class_init(). Cc: mich...@walle.cc Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé --- hw/input/milkymist-softusb.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletion

[Qemu-devel] [PATCH v3 10/21] intc/puv3_intc: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in puv3_intc_class_init(). Cc: g...@mprc.pku.edu.cn Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé --- hw/intc/puv3_intc.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a

[Qemu-devel] [PATCH v3 14/21] nvram/ds1225y: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in nvram_sysbus_class_init(). Cc: pbonz...@redhat.com Cc: marcandre.lur...@redhat.com Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé --- hw/nvram/ds1225y.c | 12 +--- 1 file changed, 5 insertion

[Qemu-devel] [PATCH v3 03/21] char/grlib_apbuart: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in grlib_apbuart_class_init(). Cc: chout...@adacore.com Cc: marcandre.lur...@redhat.com Cc: pbonz...@redhat.com Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé --- hw/char/grlib_apbuart.c | 12 +-

[Qemu-devel] [PATCH v3 01/21] musicpal: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in mv88w8618_wlan_class_init(). Cc: jan.kis...@web.de Cc: peter.mayd...@linaro.org Cc: qemu-...@nongnu.org Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/musicpal.c | 9 - 1 file chan

[Qemu-devel] [PATCH v3 17/21] timer/grlib_gptimer: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in grlib_gptimer_class_init(). Cc: chout...@adacore.com Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé --- hw/timer/grlib_gptimer.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) dif

[Qemu-devel] [PATCH v3 02/21] block/noenand: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in onenand_class_init(). Cc: kw...@redhat.com Cc: mre...@redhat.com Cc: qemu-bl...@nongnu.org Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé --- hw/block/onenand.c | 16 +++- 1 file changed,

[Qemu-devel] [PATCH v3 19/21] usb/tusb6010: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in tusb6010_class_init(). Cc: kra...@redhat.com Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju --- hw/usb/tusb6010.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/usb/tusb6010.c b/hw/usb/tusb6010.c index a2

[Qemu-devel] [PATCH v3 07/21] gpio/puv3_gpio: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in puv3_gpio_class_init(). Cc: g...@mprc.pku.edu.cn Cc: peter.mayd...@linaro.org Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé --- hw/gpio/puv3_gpio.c | 29 ++--- 1 file changed

[Qemu-devel] [PATCH v3 13/21] puv3_pm.c: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in puv3_pm_class_init(). Cc: g...@mprc.pku.edu.cn Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- hw/misc/puv3_pm.c | 10 -- 1 file changed, 4 insertions(+), 6 del

[Qemu-devel] [PATCH v3 06/21] dma/puv3_dma: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in puv3_dma_class_init(). Cc: g...@mprc.pku.edu.cn Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- hw/dma/puv3_dma.c | 10 -- 1 file changed, 4 insertions(+), 6 de

[Qemu-devel] [PATCH v3 18/21] timer/puv3_ost: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in puv3_ost_class_init(). Cc: g...@mprc.pku.edu.cn Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé --- hw/timer/puv3_ost.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH v3 15/21] pci-bridge/dec: Convert sysbus init function to realize function

2018-11-30 Thread Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in pci_dec_21154_device_class_init(). Cc: da...@gibson.dropbear.id.au Cc: m...@redhat.com Cc: marcel.apfelb...@gmail.com Cc: qemu-...@nongnu.org Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: David Gibson Acked-by: David Gibso

Re: [Qemu-devel] [PATCH RFC v2 5/5] migration: add more error handling for postcopy_ram_enable_notify

2018-11-30 Thread Dr. David Alan Gilbert
* Fei Li (f...@suse.com) wrote: > Call postcopy_ram_incoming_cleanup() to do the cleanup when > postcopy_ram_enable_notify fails. Besides, report the error > message when qemu_ram_foreach_migratable_block() fails. > > Cc: Dr. David Alan Gilbert > Signed-off-by: Fei Li Reviewed-by: Dr. David Ala

[Qemu-devel] [PATCH v3] s390x/tod: Properly stop the KVM TOD while the guest is not running

2018-11-30 Thread David Hildenbrand
Just like on other architectures, we should stop the clock while the guest is not running. This is already properly done for TCG. Right now, doing an offline migration (stop, migrate, cont) can easily trigger stalls in the guest. Even doing a (hmp) stop ... wait 2 minutes ... (hmp) con

[Qemu-devel] [PATCH v3 00/21] QOM'ify SysBusDeviceClass->init

2018-11-30 Thread Mao Zhongyi
v3 -> v2: - rebase to the HEAD - use SysBusDevice *sbd variable in patch15 v2 -> v1: - SYS_BUS_DEVICE(dev) was used in a function several times, so use a variable 'sbd' to replace it, like: SysBusDevice *sbd = SYS_BUS_DEVICE(dev); - remove the xen_sysdev_init() function - drop the patch21 in

[Qemu-devel] [PATCH v3 20/21] xen_backend: remove xen_sysdev_init() function

2018-11-30 Thread Mao Zhongyi
The init function doesn't do anything at all, so we just omit it. Cc: sstabell...@kernel.org Cc: anthony.per...@citrix.com Cc: xen-de...@lists.xenproject.org Cc: peter.mayd...@linaro.org Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Acked-by: Anthony PERARD --- hw/xen/xen_backend.c

Re: [Qemu-devel] [PATCH for-4.0 0/2] test: replace gtester with a TAP driver

2018-11-30 Thread Paolo Bonzini
On 30/11/18 08:21, Thomas Huth wrote: > On 2018-11-29 21:43, Eric Blake wrote: >> On 11/29/18 11:45 AM, Paolo Bonzini wrote: >>> gtester is deprecated by upstream glib and it does not support tests >>> that call g_test_skip in some glib stable releases. >>> >>> glib suggests instead using Automake'

Re: [Qemu-devel] [PATCH 3/3] qapi: add reason to SHUTDOWN and RESET events

2018-11-30 Thread Markus Armbruster
Dominik Csapak writes: > this makes it possible to determine what the exact reason was for > a RESET or a SHUTDOWN Yes, but why is that useful? I can guess, but the commit shouldn't make me guess. Please start your sentences with a capital letter and end them with punctuation. > this patch al

Re: [Qemu-devel] [PATCH v2] glib-compat: work around g_test_message bug with subprocess tests

2018-11-30 Thread Daniel P . Berrangé
On Fri, Nov 30, 2018 at 01:08:29AM +0100, Paolo Bonzini wrote: > On 29/11/18 19:00, Paolo Bonzini wrote: > > Subprocesses are created by glib without leaving the file descriptors > > open. Therefore, g_test_message (and assertion failures, but those > > trigger when things are going bad anyway) wi

[Qemu-devel] [PATCH v3 21/21] core/sysbus: remove the SysBusDeviceClass::init path

2018-11-30 Thread Mao Zhongyi
Currently, all sysbus devices have been converted to realize(), so remove this path. Cc: ehabk...@redhat.com Cc: th...@redhat.com Cc: pbonz...@redhat.com Cc: arm...@redhat.com Cc: peter.mayd...@linaro.org Cc: richard.hender...@linaro.org Cc: alistair.fran...@wdc.com Signed-off-by: Mao Zhongyi Si

Re: [Qemu-devel] qemu-iotests 232 fails when running the test as root user

2018-11-30 Thread Daniel P . Berrangé
On Thu, Nov 29, 2018 at 03:07:54PM -0600, Eric Blake wrote: > On 11/29/18 3:03 PM, Farhan Ali wrote: > > Hi, > > > > I am seeing a failure of the qemu-iotest number 232 when running the > > test as a root user. Is this the expected behavior? > > > > Here is the output of the failure: > > > > >

[Qemu-devel] [PATCH] util: vfio-helpers: use ARRAY_SIZE in qemu_vfio_init_pci()

2018-11-30 Thread Li Qiang
Cc: qemu-triv...@nongnu.org Signed-off-by: Li Qiang --- util/vfio-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c index 9cd42e..342d4a2285 100644 --- a/util/vfio-helpers.c +++ b/util/vfio-helpers.c @@ -348,7 +348,7 @@ st

Re: [Qemu-devel] [PATCH 2/3] qapi: split host-qmp into quit and system-reset

2018-11-30 Thread Markus Armbruster
Cc: Pavel to assess possible impact on replay. Cc: Eric to give him a chance to correct misunderstandings of ShutdownCause. Dominik Csapak writes: > it is interesting to know whether the shutdown cause was 'quit' or > 'reset', especially when using --no-reboot Are you sure it *is* interesting?

Re: [Qemu-devel] [PATCH v2 7/8] hw: acpi: Export and share the ARM RSDP build

2018-11-30 Thread Igor Mammedov
On Thu, 29 Nov 2018 14:24:27 +0100 Samuel Ortiz wrote: > Now that build_rsdp() supports building both legacy and current RSDP > tables, we can move it to a generic folder (hw/acpi) and have the i386 > ACPI code reuse it in order to reduce code duplication. > > Signed-off-by: Samuel Ortiz > Revi

Re: [Qemu-devel] [PATCH v7 04/19] replay: don't drain/flush bdrv queue while RR is working

2018-11-30 Thread Kevin Wolf
Am 30.11.2018 um 08:55 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 10.10.2018 um 15:33 hat Pavel Dovgalyuk geschrieben: > > > In record/replay mode bdrv queue is controlled by replay mechanism. > > > It does not allow saving or loading the snapshots > > >

Re: [Qemu-devel] encrypt in threads

2018-11-30 Thread Daniel P . Berrangé
On Thu, Nov 29, 2018 at 06:28:44PM +, Vladimir Sementsov-Ogievskiy wrote: > > On 27.11.2018 16:08, Daniel P. Berrangé wrote: > > On Thu, Nov 22, 2018 at 01:01:20PM +, Vladimir Sementsov-Ogievskiy > > wrote: > >> 21.11.2018 20:30, Vladimir Sementsov-Ogievskiy wrote: > >>> Hi Daniel! > >>>

Re: [Qemu-devel] [PATCH v2] glib-compat: work around g_test_message bug with subprocess tests

2018-11-30 Thread Paolo Bonzini
On 30/11/18 10:58, Daniel P. Berrangé wrote: > On Fri, Nov 30, 2018 at 01:08:29AM +0100, Paolo Bonzini wrote: >> On 29/11/18 19:00, Paolo Bonzini wrote: >>> Subprocesses are created by glib without leaving the file descriptors >>> open. Therefore, g_test_message (and assertion failures, but those

Re: [Qemu-devel] [PATCH for-3.2 0/4] build-sys: require Vista API by default globally

2018-11-30 Thread Paolo Bonzini
On 29/11/18 11:50, Marc-André Lureau wrote: > On Thu, Nov 29, 2018 at 2:45 PM Stefan Weil wrote: >> >> Am 29.11.2018 um 11:16 schrieb Paolo Bonzini: >>> On 22/11/18 12:00, Marc-André Lureau wrote: include/qemu/osdep.h | 17 ++ accel/tcg/translate-all.c | 4 --- qga/co

Re: [Qemu-devel] [PATCH for-4.0 0/2] test: replace gtester with a TAP driver

2018-11-30 Thread Daniel P . Berrangé
On Thu, Nov 29, 2018 at 02:43:03PM -0600, Eric Blake wrote: > On 11/29/18 11:45 AM, Paolo Bonzini wrote: > > gtester is deprecated by upstream glib and it does not support tests > > that call g_test_skip in some glib stable releases. > > > > glib suggests instead using Automake's TAP support. We

Re: [Qemu-devel] [PATCH for-4.0 0/2] test: replace gtester with a TAP driver

2018-11-30 Thread Paolo Bonzini
On 30/11/18 10:54, Daniel P. Berrangé wrote: > FYI, for docs about the TAP protocol see: > >https://testanything.org/tap-specification.html > > I've always liked the TAP protocol approach to test output where you print > an ok/not ok status for each piece of the test, as opposed to assertion

Re: [Qemu-devel] [PATCH v2 6/8] hw: arm: Support both legacy and current RSDP build

2018-11-30 Thread Igor Mammedov
On Thu, 29 Nov 2018 15:59:42 +0100 Samuel Ortiz wrote: > On Thu, Nov 29, 2018 at 03:42:43PM +0100, Andrew Jones wrote: > > On Thu, Nov 29, 2018 at 02:24:26PM +0100, Samuel Ortiz wrote: > > > We add the ability to build legacy or current RSDP tables, based on the > > > AcpiRsdpData revision fiel

Re: [Qemu-devel] encrypt in threads

2018-11-30 Thread Vladimir Sementsov-Ogievskiy
30.11.2018 12:48, Daniel P. Berrangé wrote: > On Thu, Nov 29, 2018 at 06:28:44PM +, Vladimir Sementsov-Ogievskiy wrote: >> >> On 27.11.2018 16:08, Daniel P. Berrangé wrote: >>> On Thu, Nov 22, 2018 at 01:01:20PM +, Vladimir Sementsov-Ogievskiy >>> wrote: 21.11.2018 20:30, Vladimir Sem

Re: [Qemu-devel] What's our ABI promise for externally visible QOM?

2018-11-30 Thread Daniel P . Berrangé
On Fri, Nov 30, 2018 at 07:59:59AM +0100, Markus Armbruster wrote: > QOM types and the QOM graph are externally visible: > > * qom-list-types returns QOM type names and parents. > > Fine print: the result is limited to concrete types by default. > Aside: that's the only way to figure out whet

Re: [Qemu-devel] encrypt in threads

2018-11-30 Thread Daniel P . Berrangé
On Fri, Nov 30, 2018 at 10:04:57AM +, Vladimir Sementsov-Ogievskiy wrote: > 30.11.2018 12:48, Daniel P. Berrangé wrote: > > On Thu, Nov 29, 2018 at 06:28:44PM +, Vladimir Sementsov-Ogievskiy > > wrote: > >> > >> On 27.11.2018 16:08, Daniel P. Berrangé wrote: > >>> On Thu, Nov 22, 2018 at 0

Re: [Qemu-devel] [PATCH for-4.0 0/2] test: replace gtester with a TAP driver

2018-11-30 Thread Daniel P . Berrangé
On Fri, Nov 30, 2018 at 10:56:01AM +0100, Paolo Bonzini wrote: > On 30/11/18 10:54, Daniel P. Berrangé wrote: > > FYI, for docs about the TAP protocol see: > > > >https://testanything.org/tap-specification.html > > > > I've always liked the TAP protocol approach to test output where you print

Re: [Qemu-devel] [PATCH v2 8/8] hw: acpi: Remove AcpiRsdpDescriptor and fix tests

2018-11-30 Thread Igor Mammedov
On Thu, 29 Nov 2018 14:24:28 +0100 Samuel Ortiz wrote: > The only remaining AcpiRsdpDescriptor users are the ACPI utils for the > BIOS table tests. > We remove that dependency and can thus remove the structure itself. > > Signed-off-by: Samuel Ortiz > --- > include/hw/acpi/acpi-defs.h | 13 ---

Re: [Qemu-devel] [PATCH v2 0/8] hw: acpi: RSDP fixes and refactoring

2018-11-30 Thread Igor Mammedov
On Thu, 29 Nov 2018 14:24:20 +0100 Samuel Ortiz wrote: > This patch serie fixes a couple of RSDP checksum related issues: > > - On RSDP rev2, we are not adding the extended checksum and computing > the checksum on the full table instead of the first 20 bytes. > - On RSDP rev1, we are computing

[Qemu-devel] [PATCH maybe-for-3.1?] linux-user: Fix compilation with clang 3.4

2018-11-30 Thread Thomas Huth
Clang version 3.4.2 does not know the -Wpragmas option yet and bails out with an error when we try to disable it in linux-user/qemu.h. Fortunately, clang has a __has_warning() macro which allows us to add an explicit check for this option to fix this issue. Fixes: 850d5e330a9c68cc998cecc02caf8a3c8

Re: [Qemu-devel] [PATCH v7 07/16] gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo

2018-11-30 Thread Edgar E. Iglesias
On Fri, Nov 23, 2018 at 10:17:20AM +0100, Luc Michel wrote: > Change the thread info related packets handling to support multiprocess > extension. > > Add the CPUs class name in the extra info to help differentiate > them in multiprocess mode. Reviewed-by: Edgar E. Iglesias > > Signed-off-by:

Re: [Qemu-devel] [PATCH maybe-for-3.1?] linux-user: Fix compilation with clang 3.4

2018-11-30 Thread Laurent Vivier
On 30/11/2018 11:33, Thomas Huth wrote: > Clang version 3.4.2 does not know the -Wpragmas option yet and bails > out with an error when we try to disable it in linux-user/qemu.h. > Fortunately, clang has a __has_warning() macro which allows us to add > an explicit check for this option to fix this

[Qemu-devel] [PATCH for-4.0] compiler.h: Add an explicit check for the compiler version

2018-11-30 Thread Thomas Huth
The questions about our minimum compiler requirement pops up every couple of months, and we then have to recall the details each time. So let's document this in a proper way, by adding a comment and check for the right compiler version to our compiler.h header. Signed-off-by: Thomas Huth --- inc

Re: [Qemu-devel] [PATCH for-4.0] compiler.h: Add an explicit check for the compiler version

2018-11-30 Thread Paolo Bonzini
On 30/11/18 11:43, Thomas Huth wrote: > The questions about our minimum compiler requirement pops up every > couple of months, and we then have to recall the details each time. > So let's document this in a proper way, by adding a comment and > check for the right compiler version to our compiler.h

Re: [Qemu-devel] [PATCH v7 04/19] replay: don't drain/flush bdrv queue while RR is working

2018-11-30 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 30.11.2018 um 08:55 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 10.10.2018 um 15:33 hat Pavel Dovgalyuk geschrieben: > > > > In record/replay mode bdrv queue is controlled by replay mechanism. > > > > I

Re: [Qemu-devel] [PATCH for-3.2 v4 16/28] hw: apply machine compat properties without touching globals

2018-11-30 Thread Igor Mammedov
On Fri, 30 Nov 2018 01:36:03 +0400 Marc-André Lureau wrote: > Hi > > On Thu, Nov 29, 2018 at 9:51 PM Eduardo Habkost wrote: > > > > On Thu, Nov 29, 2018 at 02:32:18PM +0400, Marc-André Lureau wrote: > > > Hi > > > On Wed, Nov 28, 2018 at 9:53 PM Igor Mammedov > > > wrote: > > > > > > > >

[Qemu-devel] [PATCH for-3.1 2/2] usb-mtp: outlaw slashes in filenames

2018-11-30 Thread Gerd Hoffmann
Slash is unix directory separator, so they are not allowed in filenames. Note this also stops the classic escape via "../". Fixes: CVE-2018-16867 Reported-by: Michael Hanselmann (hansmi.ch) Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Qemu-devel] [PATCH for-3.1 0/2] usb-mtp: two bugfixes (one security fix).

2018-11-30 Thread Gerd Hoffmann
Gerd Hoffmann (2): usb-mtp: fix utf16_to_str usb-mtp: outlaw slashes in filenames hw/usb/dev-mtp.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) -- 2.9.3

[Qemu-devel] [PATCH for-3.1 1/2] usb-mtp: fix utf16_to_str

2018-11-30 Thread Gerd Hoffmann
Make utf16_to_str return an allocated string. Remove the assumtion that the number of string bytes equals the number of utf16 chars (which is only true for ascii chars). Instead call wcstombs twice, once to figure the storage size and once for the actual conversion (as suggested by the wcstombs m

Re: [Qemu-devel] [PATCH for-4.0] compiler.h: Add an explicit check for the compiler version

2018-11-30 Thread Daniel P . Berrangé
On Fri, Nov 30, 2018 at 11:43:40AM +0100, Thomas Huth wrote: > The questions about our minimum compiler requirement pops up every > couple of months, and we then have to recall the details each time. > So let's document this in a proper way, by adding a comment and > check for the right compiler ve

Re: [Qemu-devel] [PATCH v7 17/19] replay: add BH oneshot event for block layer

2018-11-30 Thread Kevin Wolf
Am 30.11.2018 um 09:21 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 10.10.2018 um 15:35 hat Pavel Dovgalyuk geschrieben: > > > Replay is capable of recording normal BH events, but sometimes > > > there are single use callbacks scheduled with aio_bh_schedule

Re: [Qemu-devel] Hot-pluggable device without ->unrealize() is highly suspect

2018-11-30 Thread Peter Maydell
On Fri, 30 Nov 2018 at 07:40, Markus Armbruster wrote: > Peter Maydell writes: > > Add an assert somewhere and catch it with the usual > > "instantiate everything" qtest? > The troublemaker is (3), where we may end up with an overridden > realize-like method and an non-matching, un-overridden un

Re: [Qemu-devel] AioContext locking vs. coroutines (was: [PATCH] mirror dead-lock)

2018-11-30 Thread Paolo Bonzini
On 29/11/18 11:42, Kevin Wolf wrote: > I guess in this specific instance we can just remove the locking from > mirror_read/write_complete becasue it's only locking an AioContext whose > lock we already hold anyway because we're in a Coroutine owned by the > AioContext, so yielding will release the

Re: [Qemu-devel] [PATCH v7 17/19] replay: add BH oneshot event for block layer

2018-11-30 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 30.11.2018 um 09:21 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 10.10.2018 um 15:35 hat Pavel Dovgalyuk geschrieben: > > > > Replay is capable of recording normal BH events, but sometimes > > > > there

Re: [Qemu-devel] [Qemu-devel for-3.1?] [PATCH] egl-headless: add egl_create_context

2018-11-30 Thread Gerd Hoffmann
On Thu, Nov 29, 2018 at 08:09:56AM -0600, Eric Blake wrote: > On 11/29/18 6:35 AM, Gerd Hoffmann wrote: > > We must set the correct context (via eglMakeCurrent) before > > calling qemu_egl_create_context, so we need a thin wrapper and can't > > hook qemu_egl_create_context directly as ->dpy_gl_ctx_

Re: [Qemu-devel] [PATCH for 3.1 0/4] Fix possible OOB during queuing packets

2018-11-30 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH for 3.1 0/4] Fix possible OOB during queuing packets Message-id: 2018

Re: [Qemu-devel] [PATCH RFC 2/5] qemu_thread_join: fix segmentation fault

2018-11-30 Thread Fei Li
On 11/29/2018 10:32 PM, Philippe Mathieu-Daudé wrote: Hi Fei, On 28/11/18 11:33, Fei Li wrote: To avoid the segmentation fault in qemu_thread_join(), just directly return when the QemuThread *thread failed to be created in either qemu-thread-posix.c or qemu-thread-win32.c. Signed-off-by: Fe

[Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2018-11-30 Thread Roman Bolshakov
I've tried to run two x86 guests with Cocoa display on 3.1 rc3, the GUI doesn't crash. I've tried to change screen resolution on openSUSE 15, it also works without an issue. My command line is: ./x86_64-softmmu/qemu-system-x86_64 -accel hvf -cpu host -hda /path/to/disk -m MEMORY -- You received

Re: [Qemu-devel] [PATCH for-3.2 v4 16/28] hw: apply machine compat properties without touching globals

2018-11-30 Thread Eduardo Habkost
On Fri, Nov 30, 2018 at 11:55:26AM +0100, Igor Mammedov wrote: > On Fri, 30 Nov 2018 01:36:03 +0400 > Marc-André Lureau wrote: > > > Hi > > > > On Thu, Nov 29, 2018 at 9:51 PM Eduardo Habkost wrote: > > > > > > On Thu, Nov 29, 2018 at 02:32:18PM +0400, Marc-André Lureau wrote: > > > > Hi > >

Re: [Qemu-devel] [PATCH for-3.2 v4 16/28] hw: apply machine compat properties without touching globals

2018-11-30 Thread Igor Mammedov
On Thu, 29 Nov 2018 14:32:18 +0400 Marc-André Lureau wrote: > Hi > On Wed, Nov 28, 2018 at 9:53 PM Igor Mammedov wrote: > > > > On Tue, 27 Nov 2018 11:35:27 -0200 > > Eduardo Habkost wrote: > > > > > On Tue, Nov 27, 2018 at 05:10:05PM +0400, Marc-André Lureau wrote: > > > > On Tue, Nov 27,

Re: [Qemu-devel] [PATCH] hostmem: Validate host-nodes before setting bitmap

2018-11-30 Thread Eduardo Habkost
On Fri, Nov 30, 2018 at 09:32:21AM +0100, Stefano Garzarella wrote: > On Thu, Nov 29, 2018 at 7:59 PM Eduardo Habkost wrote: > > > > host_memory_backend_set_host_nodes() was not validating > > host-nodes before writing to backend->host_nodes, making QEMU > > write beyond the end of the bitmap. > >

  1   2   3   4   >