Re: [Qemu-devel] [PATCH v2 4/6] Warn on obsolete and deprecated devices.

2018-11-07 Thread Gerd Hoffmann
On Tue, Nov 06, 2018 at 09:36:44AM -0500, Michael S. Tsirkin wrote: > On Tue, Nov 06, 2018 at 11:23:33AM +0100, Gerd Hoffmann wrote: > > Print a warning for deprecated and obsolete devices. > > Also add support state to device listing. > > > > Signed-off-by: Gerd Hoffmann > > Should we also add

Re: [Qemu-devel] [PATCH 10/18] json: Define new QMP message for pvrdma

2018-11-07 Thread Yuval Shaia
On Mon, Nov 05, 2018 at 09:58:56AM -0600, Eric Blake wrote: > On 11/5/18 6:45 AM, Yuval Shaia wrote: > > pvrdma requires that the same GID attached to it will be attached to the > > backend device in the host. > > > > A new QMP messages is defined so pvrdma device can broadcast any change > > made

Re: [Qemu-devel] [PATCH v2 2/6] add QemuSupportState

2018-11-07 Thread Gerd Hoffmann
Hi, > >> +# @experimental: in development, can be unstable or incomplete. > > > > People reading this document would ask: what would appear on > > MAINTAINERS if SupportState is `experimental`? > > Probably Maintained. It's something that is on its way towards becoming > "supported", but stil

Re: [Qemu-devel] [PATCH v2 for-3.1] hw/arm/sysbus-fdt: Only call match_fn callback if the type matches

2018-11-07 Thread Geert Uytterhoeven
Hi Eric, On Tue, Nov 6, 2018 at 7:42 PM Eric Auger wrote: > Commit af7d64ede0b9 (hw/arm/sysbus-fdt: Allow device matching with DT > compatible value) introduced a match_fn callback which gets called > for each registered combo to check whether a sysbus device can be > dynamically instantiated. Ho

[Qemu-devel] The error from compiling QEMU statically

2018-11-07 Thread wj193102
Hi, everybody. I want to compile QEMU statically. But when I make the soure files, I get the error messages. Please help me to resolve them. Now I will tell you the steps what I do. (1)$ cd qemu-3.0.0 (2)$ ./configure --prefix=/usr --static (3)$ make When I input the "make" command, and run it, t

Re: [Qemu-devel] [PATCH v3 2/3] Deprecate HMP `cpu-add`

2018-11-07 Thread Kashyap Chamarthy
On Mon, Nov 05, 2018 at 12:20:05PM +0100, Thomas Huth wrote: > On 2018-10-30 13:35, Kashyap Chamarthy wrote: > > Since we're deprecating the QMP `cpu-add`, let's deprecate its HMP > > equivalent, too. > > > > Suggested-by: Thomas Huth > > Signed-off-by: Kashyap Chamarthy [...] > > diff --git a

Re: [Qemu-devel] [PATCH v2 04/10] pci/pcie: stop plug/unplug if the slot is locked

2018-11-07 Thread David Hildenbrand
On 07.11.18 00:10, David Gibson wrote: > On Mon, Nov 05, 2018 at 11:20:38AM +0100, David Hildenbrand wrote: >> We better stop right away. While at it, properly move the check >> to the pre_plug handler. >> >> Reviewed-by: Igor Mammedov >> Signed-off-by: David Hildenbrand > > Reviewed-by: David G

Re: [Qemu-devel] [PULL 1/1] update seabios to master snapshot

2018-11-07 Thread Gerd Hoffmann
Hi, > > Signed-off-by: Gerd Hoffmann > > Thanks for taking the latest version. If this works out well, would it be > possible to use this version of Seabios also for QEMU 3.0 stable? I am > asking primarily due to the TPM patches and the fact that QEMU 3.0 is > packaged in F29, with the CRB po

Re: [Qemu-devel] [PATCH v3 2/3] Deprecate HMP `cpu-add`

2018-11-07 Thread Thomas Huth
On 2018-11-07 09:49, Kashyap Chamarthy wrote: > On Mon, Nov 05, 2018 at 12:20:05PM +0100, Thomas Huth wrote: >> On 2018-10-30 13:35, Kashyap Chamarthy wrote: >>> Since we're deprecating the QMP `cpu-add`, let's deprecate its HMP >>> equivalent, too. >>> >>> Suggested-by: Thomas Huth >>> Signed-off

Re: [Qemu-devel] The error from compiling QEMU statically

2018-11-07 Thread Philippe Mathieu-Daudé
Hi, On 7/11/18 9:43, wj193102 wrote: Hi, everybody. I want to compile QEMU statically. But when I make the soure files, I get the error messages. Please help me to resolve them. Now I will tell you the steps what I do. (1)$ cd qemu-3.0.0 (2)$ ./configure --prefix=/usr --static Can you share t

Re: [Qemu-devel] [PATCH v2 1/6] move ObjectClass to typedefs.h

2018-11-07 Thread Philippe Mathieu-Daudé
On 6/11/18 11:23, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- include/qemu/typedefs.h | 1 + include/qom/object.h| 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/typedefs

Re: [Qemu-devel] [PATCH 0/2] nvme: fix two issues in nvme unhotplug

2018-11-07 Thread Kevin Wolf
Am 29.10.2018 um 07:29 hat Li Qiang geschrieben: > The first corrent the refcount and second fix a memory leak. Thanks, applied to the block branch. Kevin

[Qemu-devel] [Bug 1794939] Re: QEMU does not build with vte v2.91

2018-11-07 Thread Bastian Koppelmann
Hi Berg, thanks for the tip, a fix has also been commited already :) Cheers, Bastian ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1794939 T

Re: [Qemu-devel] [PATCH v4 03/11] block: allow serialized reads to intersect

2018-11-07 Thread Vladimir Sementsov-Ogievskiy
06.11.2018 20:57, Kevin Wolf wrote: > Am 15.10.2018 um 18:06 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Otherwise, if we have serialized read-part in copy_range from backing >> file to its parent if CoW take place, this CoW's sub-reads will >> intersect with firstly created serialized read re

Re: [Qemu-devel] [Qemu-block] ping Re: [PATCH v4 00/11] backup-top filter driver for backup

2018-11-07 Thread Vladimir Sementsov-Ogievskiy
07.11.2018 01:35, John Snow wrote: > > On 11/06/2018 12:21 PM, Kevin Wolf wrote: >> Am 02.11.2018 um 17:41 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> ping >>> >>> 15.10.2018 19:06, Vladimir Sementsov-Ogievskiy wrote: Hi all! These series introduce backup-top driver. It's a fil

[Qemu-devel] [RFC PATCH spice/qemu v3 0/3] QXL interface to set monitor ID

2018-11-07 Thread Lukáš Hrázký
Hello, another version of the proposed API for monitor identification information. Still not for merge yet, the plan is to merge when it's complete. Changes since v2: * Merged the two API functions into one: spice_qxl_set_device_info(QXLInstance *instance, const char

[Qemu-devel] [RFC PATCH spice v3 2/3] QXL interface: deprecate spice_qxl_set_max_monitors

2018-11-07 Thread Lukáš Hrázký
Replace it by spice_qxl_set_device_info. Note we can't use monitors_count for what's stored in max_monitors, because monitors_count denotes the length of the device_display_ids array, which spice_qxl_set_max_monitors doesn't touch. Signed-off-by: Lukáš Hrázký --- server/red-qxl.c | 1 + server

[Qemu-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest

2018-11-07 Thread Lukáš Hrázký
Adds a function to let QEMU provide information to identify graphics devices and their monitors in the guest. The function (spice_qxl_set_device_info) sets the device address (e.g. a PCI path) and monitor ID -> device display ID mapping of displays exposed by given QXL interface. Signed-off-by: Lu

[Qemu-devel] [RFC PATCH qemu v3 3/3] spice: set device address and device display ID in QXL interface

2018-11-07 Thread Lukáš Hrázký
Calls the new SPICE QXL interface function spice_qxl_set_device_info to set the hardware address of the graphics device represented by the QXL interface (e.g. a PCI path) and the device display IDs (the IDs of the device's monitors that belong to this QXL interface). Also stops using the deprecate

Re: [Qemu-devel] [PULL 0/8] Monitor patches for 2018-10-30

2018-11-07 Thread Peter Maydell
On 7 November 2018 at 02:56, Peter Xu wrote: > Strange, "make check -j8" failed on my hosts (I tried two) with either > Markus's pull tree or qemu master: > > hw/core/ptimer.o: In function `timer_new_tl': > /home/xz/git/qemu/include/qemu/timer.h:536: undefined reference to > `timer_init_tl' > col

Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-07 Thread Peter Maydell
On 7 November 2018 at 06:05, Markus Armbruster wrote: > Eduardo Habkost writes: > >> The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis >> seems to provide an older version. Change the existing rules to >> use command output instead of exit code, to make it compatible >> with older

Re: [Qemu-devel] The error from compiling QEMU statically

2018-11-07 Thread Peter Maydell
On 7 November 2018 at 08:43, wj193102 wrote: > Hi, everybody. > I want to compile QEMU statically. But when I make the soure files, I get the > error messages. Please help me to resolve them. > Now I will tell you the steps what I do. > (1)$ cd qemu-3.0.0 > (2)$ ./configure --prefix=/usr --static

Re: [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation

2018-11-07 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181029173437.32559-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n

[Qemu-devel] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

2018-11-07 Thread Richard W.M. Jones
(I'm not going to claim this is a bug, but it causes a large, easily measurable performance regression in virt-v2v). In qemu 2.10, when you do ‘qemu-img convert’ to an NBD target, qemu interleaves write and zero requests. We can observe this as follows: $ virt-builder fedora-28 $ nbdkit --fi

Re: [Qemu-devel] [RFC 0/2] vhost-vfio: introduce mdev based HW vhost backend

2018-11-07 Thread Liang, Cunming
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Tuesday, November 6, 2018 4:18 AM > To: Wang, Xiao W ; m...@redhat.com; > alex.william...@redhat.com > Cc: qemu-devel@nongnu.org; Bie, Tiwei ; Liang, Cunming > ; Ye, Xiaolong ; Wang, Zhihong > ; Daly, Dan > Subj

Re: [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation

2018-11-07 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181029173437.32559-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH 0/4] scsi-generic

Re: [Qemu-devel] [PATCH v6 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-11-07 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181102152257.20637-1-mark.cave-ayl...@ilande.co.uk Subject: [Qemu-devel] [PATCH v6 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine === TEST SCRIPT BEGIN === #!/bin

[Qemu-devel] [PATCH for-3.2 v3 00/14] Generalize machine compatibility properties

2018-11-07 Thread Marc-André Lureau
Hi, During "[PATCH v2 05/10] qom/globals: generalize object_property_set_globals()" review, Eduardo suggested to rework the GlobalProperty handling, so that -global is limited to QDev only and we avoid mixing the machine compats and the user-provided -global properties (instead of generalizing -gl

[Qemu-devel] [PATCH for-3.2 v3 01/14] tests: qdev_prop_check_globals() doesn't return "all_used"

2018-11-07 Thread Marc-André Lureau
Instead, it returns 1 if an error was detected, which is the case for: /qdev/properties/dynamic/global/subprocess: warning: global dynamic-prop-type-bad.prop3 has invalid class name warning: global nohotplug-type.prop5=105 not used warning: global nondevice-type.prop6 has invalid class name Clari

[Qemu-devel] [PATCH for-3.2 v3 02/14] qom: make interface types abstract

2018-11-07 Thread Marc-André Lureau
Interfaces don't have instance, let's make the interface type really abstract to avoid confusion. Signed-off-by: Marc-André Lureau --- include/hw/acpi/acpi_dev_interface.h | 6 +- include/hw/arm/linux-boot-if.h | 5 + include/hw/fw-path-provider.h| 4 +--- include/hw/hotplu

[Qemu-devel] [PATCH for-3.2 v3 05/14] qdev: move qdev_prop_register_global_list() to tests

2018-11-07 Thread Marc-André Lureau
The function is only used by a test, move it there. Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost --- include/hw/qdev-properties.h | 1 - hw/core/qdev-properties.c | 9 - tests/test-qdev-global-props.c | 18 ++ 3 files changed, 14 insertions(+),

[Qemu-devel] [PATCH for-3.2 v3 04/14] accel: register global_props like machine globals

2018-11-07 Thread Marc-André Lureau
global_props is only used for Xen xen_compat_props. It's a static array of GlobalProperty, like machine globals in SET_MACHINE_COMPAT(). Let's register the globals the same way, without extra copy allocation. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov --- include/hw/qdev-proper

[Qemu-devel] [PATCH for-3.2 v3 03/14] qom: make user_creatable_complete() specific to UserCreatable

2018-11-07 Thread Marc-André Lureau
Instead of accepting any Object*, change user_creatable_complete() to require a UserCreatable*. Modify the callers to pass the appropriate argument, removing redundant dynamic cast checks in object creation. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov --- include/qom/object_inte

[Qemu-devel] [PATCH for-3.2 v3 09/14] qdev-props: remove errp from GlobalProperty

2018-11-07 Thread Marc-André Lureau
All qdev_prop_register_global() set &error_fatal for errp, except '-rtc driftfix=slew', which arguably should also use &error_fatal, as otherwise failing to apply the property would only report a warning. Signed-off-by: Marc-André Lureau --- include/hw/qdev-core.h| 6 -- hw/core/qdev-pro

[Qemu-devel] [PATCH for-3.2 v3 14/14] hostmem: use object id for memory region name with >= 3.1

2018-11-07 Thread Marc-André Lureau
hostmem-file and hostmem-memfd use the whole object path for the memory region name, and hostname-ram uses only the path component (the object id, or canonical path basename): qemu -m 1024 -object memory-backend-file,id=mem,size=1G,mem-path=/tmp/foo -numa node,memdev=mem -monitor stdio (qemu) inf

[Qemu-devel] [PATCH for-3.2 v3 07/14] qdev: all globals are now user-provided

2018-11-07 Thread Marc-André Lureau
Considering that CPU features are provided via command line, the global_props are now all user-provided globals. No need to track this anymore for qdev_prop_check_globals(). Signed-off-by: Marc-André Lureau --- include/hw/qdev-core.h | 3 -- hw/core/qdev-properties.c | 4 --- test

[Qemu-devel] [PATCH for-3.2 v3 06/14] qdev: do not mix compat props with global props

2018-11-07 Thread Marc-André Lureau
Machine & Accel props are not provided by user. Let's not mix them with the global properties. Call a new helper function object_apply_global_props() during device_post_init(). Add a stub for current_machine, so qemu-user and tests can find a fallback symbol when linking with QDev. The following

Re: [Qemu-devel] [PATCH v1 4/5] s390x/vfio: ap: Intercepting AP Queue Interrupt Control

2018-11-07 Thread Cornelia Huck
On Fri, 2 Nov 2018 11:30:20 +0100 Pierre Morel wrote: > From: Pierre Morel Meta: you may want to rewrite your authorship to the shorter address. > > We intercept the PQAP(AQIC) instruction. > > Until we implement AQIC we return a PGM_OPERATION. > > Signed-off-by: Pierre Morel > --- > hw/

[Qemu-devel] [PATCH for-3.2 v3 11/14] qom: teach interfaces to implement post-init

2018-11-07 Thread Marc-André Lureau
The following patches are going to implement post_init callbacks for settings properties. The interface post_init are called before the instance post_init, so the default interface behaviour can be overriden if necessary. Signed-off-by: Marc-André Lureau --- qom/object.c| 8

[Qemu-devel] [PATCH for-3.2 v3 08/14] qdev-props: convert global_props to GArray

2018-11-07 Thread Marc-André Lureau
A step towards being able to call object_apply_global_props(). Signed-off-by: Marc-André Lureau --- hw/core/qdev-properties.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index 43c30a57f4.

[Qemu-devel] [PATCH for-3.2 v3 13/14] hw/i386: add pc-i440fx-3.2 & pc-q35-3.2

2018-11-07 Thread Marc-André Lureau
The following patch is going to add compatiblity parameters for qemu <= 3.1. Signed-off-by: Marc-André Lureau --- include/hw/compat.h | 3 +++ include/hw/i386/pc.h | 3 +++ hw/i386/pc_piix.c| 21 ++--- hw/i386/pc_q35.c | 19 +-- 4 files changed, 41 inse

[Qemu-devel] [PATCH for-3.2 v3 10/14] qdev-props: call object_apply_global_props()

2018-11-07 Thread Marc-André Lureau
It's now possible to use the common function. Teach object_apply_global_props() to warn if Error argument is NULL. Signed-off-by: Marc-André Lureau --- hw/core/qdev-properties.c | 24 ++-- qom/object.c | 6 +- 2 files changed, 7 insertions(+), 23 deletions(

Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-07 Thread Eduardo Habkost
On Wed, Nov 07, 2018 at 07:05:03AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis > > seems to provide an older version. Change the existing rules to > > use command output instead of exit code, to make it compatib

[Qemu-devel] [PATCH for-3.2 v3 12/14] machine: add compat-props interface

2018-11-07 Thread Marc-André Lureau
Let's make compatiblity properties an interface, so that objects other than QDev can benefit from having machine compatiblity properties. Signed-off-by: Marc-André Lureau --- include/hw/boards.h| 2 ++ hw/core/compat-props.c | 43 ++ hw/core/qdev.c

[Qemu-devel] [PATCH v4 08/15] block: Use bdrv_reopen_set_read_only() in the mirror driver

2018-11-07 Thread Alberto Garcia
The 'block-commit' QMP command is implemented internally using two different drivers. If the source image is the active layer then the mirror driver is used (commit_active_start()), otherwise the commit driver is used (commit_start()). In both cases the destination image must be put temporarily in

[Qemu-devel] [PATCH v4 04/15] block: Use bdrv_reopen_set_read_only() in bdrv_commit()

2018-11-07 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/commit.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/block/commit

[Qemu-devel] [PATCH v4 09/15] block: Drop bdrv_reopen()

2018-11-07 Thread Alberto Garcia
No one is using this function anymore, so we can safely remove it. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block.c | 21 - include/block/block.h | 1 - 2 files changed, 22 deletions(-) diff --git a/block.c b/block.c index cfa53f7114..31de7b22

[Qemu-devel] [PATCH v4 03/15] block: Use bdrv_reopen_set_read_only() in commit_start/complete()

2018-11-07 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/commit.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/b

[Qemu-devel] [PATCH v4 00/15] Don't pass flags to bdrv_reopen_queue()

2018-11-07 Thread Alberto Garcia
Hi all, when reopening a BlockDriverState using bdrv_reopen() and friends the new options can be specified either with a QDict or with flags. Both methods overlap and that makes the semantics and the implementation unnecessarily complicated. This series removes the 'flags' parameter from these fu

[Qemu-devel] [PATCH v4 15/15] block: Assert that flags are up-to-date in bdrv_reopen_prepare()

2018-11-07 Thread Alberto Garcia
Towards the end of bdrv_reopen_queue_child(), before starting to process the children, the update_flags_from_options() function is called in order to have BDRVReopenState.flags in sync with the options from the QDict. This is necessary because during the reopen process flags must be updated for al

[Qemu-devel] [PATCH v4 02/15] block: Use bdrv_reopen_set_read_only() in bdrv_backing_update_filename()

2018-11-07 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block

[Qemu-devel] [PATCH v4 01/15] block: Add bdrv_reopen_set_read_only()

2018-11-07 Thread Alberto Garcia
Most callers of bdrv_reopen() only use it to switch a BlockDriverState between read-only and read-write, so this patch adds a new function that does just that. We also want to get rid of the flags parameter in the bdrv_reopen() API, so this function sets the "read-only" option and passes the origi

[Qemu-devel] [PATCH v4 10/15] qemu-io: Put flag changes in the options QDict in reopen_f()

2018-11-07 Thread Alberto Garcia
When reopen_f() puts a block device in the reopen queue, some of the new options are passed using a QDict, but others ("read-only" and the cache options) are passed as flags. This patch puts those flags in the QDict. This way the flags parameter becomes redundant and we'll be able to get rid of it

[Qemu-devel] [PATCH v4 13/15] block: Stop passing flags to bdrv_reopen_queue_child()

2018-11-07 Thread Alberto Garcia
Now that all callers are passing the new options using the QDict we no longer need the 'flags' parameter. This patch makes the following changes: 1) The update_options_from_flags() call is no longer necessary so it can be removed. 2) The update_flags_from_options() call is now used i

[Qemu-devel] [PATCH v4 12/15] block: Remove flags parameter from bdrv_reopen_queue()

2018-11-07 Thread Alberto Garcia
Now that all callers are passing all flag changes as QDict options, the flags parameter is no longer necessary, so we can get rid of it. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block.c | 5 +++-- block/replication.c | 6 ++ include/block/block.h | 3 +-- qem

[Qemu-devel] [PATCH v4 06/15] block: Use bdrv_reopen_set_read_only() in qmp_change_backing_file()

2018-11-07 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- blockdev.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/bl

[Qemu-devel] [PATCH v4 05/15] block: Use bdrv_reopen_set_read_only() in stream_start/complete()

2018-11-07 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/stream.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --gi

[Qemu-devel] [PATCH for-3.2 v3 3/3] qcow2-snapshot: remove redundant find_snapshot_by_id_and_name call

2018-11-07 Thread Daniel Henrique Barboza
In qcow2_snapshot_create there is the following code block: /* Generate an ID */ find_new_snapshot_id(bs, sn_info->id_str, sizeof(sn_info->id_str)); /* Check that the ID is unique */ if (find_snapshot_by_id_and_name(bs, sn_info->id_str, NULL) >= 0) { return -EEXIST; }

[Qemu-devel] [PATCH v4 11/15] block: Clean up reopen_backing_file() in block/replication.c

2018-11-07 Thread Alberto Garcia
This function is used to put the hidden and secondary disks in read-write mode before launching the backup job, and back in read-only mode afterwards. This patch does the following changes: - Use an options QDict with the "read-only" option instead of passing the changes as flags only. -

[Qemu-devel] [PATCH for-3.2 v3 1/3] block/snapshot.c: eliminate use of ID input in snapshot operations

2018-11-07 Thread Daniel Henrique Barboza
At this moment, QEMU attempts to create/load/delete snapshots by using either an ID (id_str) or a name. The problem is that the code isn't consistent of whether the entered argument is an ID or a name, causing unexpected behaviors. For example, when creating snapshots via savevm , what happens is

[Qemu-devel] [PATCH v4 07/15] block: Use bdrv_reopen_set_read_only() in external_snapshot_commit()

2018-11-07 Thread Alberto Garcia
This patch replaces the bdrv_reopen() call that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- blockdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.

[Qemu-devel] [PATCH for-3.2 v3 2/3] block/snapshot: remove bdrv_snapshot_delete_by_id_or_name

2018-11-07 Thread Daniel Henrique Barboza
After the previous patch, the only instance of this function left is inside qemu-img.c. qemu-img is using it inside the 'img_snapshot' function to delete snapshots in the SNAPSHOT_DELETE case, based on a "snapshot_name" string that refers to the tag, not ID, of the QEMUSnapshotInfo struct. This ca

[Qemu-devel] [PATCH v4 14/15] block: Remove assertions from update_flags_from_options()

2018-11-07 Thread Alberto Garcia
This function takes three options (cache.direct, cache.no-flush and read-only) from a QemuOpts object and updates the flags accordingly. If any of those options is not set (because it was missing from the original QDict or because it had an invalid value) then the function aborts with a failed ass

[Qemu-devel] [PATCH for-3.2 v3 0/3] HMP/snapshot changes - do not use ID anymore

2018-11-07 Thread Daniel Henrique Barboza
changes in v3: - rebased to v3.1.0-rc0 tag - hmp-commands.hx documentation now mentions the change of semantics starting version 3.2. - previous version link: http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg00629.html It is not uncommon to see bugs being opened by testers that attempt

[Qemu-devel] [PATCH] Support u-boot noload images for arm as used by NetBSD/evbarm GENERIC kernel.

2018-11-07 Thread Nick Hudson
noload kernels are loaded with the u-boot image header and as a result the header size needs adding to the entry point.  Fake up a hdr so the kernel image is loaded at the right address and the entry point is adjusted appropriately Signed-off-by: Nick Hudson ---  hw/arm/boot.c |  8 +

[Qemu-devel] [Bug 1794939] Re: QEMU does not build with vte v2.91

2018-11-07 Thread Berg Lloyd-Haig
Hi Bastian, I got past this error by installing libvte-dev instead of libvte-2.91-dev. I'm not sure if it actually works however. Cheers, Berg -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1794939

Re: [Qemu-devel] [PATCH v2] block: Make more block drivers compile-time configurable

2018-11-07 Thread Max Reitz
On 07.11.18 07:36, Markus Armbruster wrote: > From: Jeff Cody > > This adds configure options to control the following block drivers: > > * Bochs > * Cloop > * Dmg > * Qcow (V1) > * Vdi > * Vvfat > * qed > * parallels > * sheepdog > > Each of these defaults to being enabled. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v1 5/5] s390x/vfio: ap: Implementing AP Queue Interrupt Control

2018-11-07 Thread Cornelia Huck
On Fri, 2 Nov 2018 11:30:21 +0100 Pierre Morel wrote: > We intercept the PQAP(AQIC) instruction and transform > the guest's AQIC command parameters for the host AQIC > parameters. > > Doing this we use the standard adapter interface to provide > the adapter NIB, indicator and ISC. > > We defin

Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-07 Thread Peter Maydell
On 7 November 2018 at 12:49, Eduardo Habkost wrote: > Now, why do we need --with-python, and why do we need to use > $(PYTHON) when running tests? If somebody wants to use a > different Python binary when running tests, they can already use > $PATH for that. > > (That's the same argument I used f

Re: [Qemu-devel] [PATCH 3/7] qcow2: split out reading normal clusters from qcow2_co_preadv

2018-11-07 Thread Max Reitz
On 01.11.18 13:17, Vladimir Sementsov-Ogievskiy wrote: > 27.09.2018 20:35, Max Reitz wrote: >> On 07.08.18 19:43, Vladimir Sementsov-Ogievskiy wrote: >>> Memory allocation may become less efficient for encrypted case. It's a >>> payment for further asynchronous scheme. >>> >>> Signed-off-by: Vladim

Re: [Qemu-devel] [PATCH] Support u-boot noload images for arm as used by NetBSD/evbarm GENERIC kernel.

2018-11-07 Thread Kamil Rytarowski
I saw this thread, but from a NetBSD maintainer point of view, I will defer review to ARM people. On 07.11.2018 14:19, Nick Hudson wrote: > noload kernels are loaded with the u-boot image header and as a result > the header size needs adding to the entry point.  Fake up a hdr so the > kernel image

Re: [Qemu-devel] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

2018-11-07 Thread Richard W.M. Jones
Another thing I tried was to change the NBD server (nbdkit) so that it doesn't advertise zero support to the client: $ nbdkit --filter=log --filter=nozero memory size=6G logfile=/tmp/log \ --run './qemu-img convert ./fedora-28.img -n $nbd' $ grep '\.\.\.$' /tmp/log | sed 's/.*\([A-Z][a-z

Re: [Qemu-devel] [RFC 0/2] vhost-vfio: introduce mdev based HW vhost backend

2018-11-07 Thread Jason Wang
On 2018/11/7 下午8:26, Liang, Cunming wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Tuesday, November 6, 2018 4:18 AM To: Wang, Xiao W ; m...@redhat.com; alex.william...@redhat.com Cc: qemu-devel@nongnu.org; Bie, Tiwei ; Liang, Cunming ; Ye, Xiaolong ; Wa

Re: [Qemu-devel] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

2018-11-07 Thread Nir Soffer
Wed, Nov 7, 2018 at 4:36 PM Richard W.M. Jones wrote: > Another thing I tried was to change the NBD server (nbdkit) so that it > doesn't advertise zero support to the client: > > $ nbdkit --filter=log --filter=nozero memory size=6G logfile=/tmp/log \ > --run './qemu-img convert ./fedora-2

Re: [Qemu-devel] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

2018-11-07 Thread Richard W.M. Jones
On Wed, Nov 07, 2018 at 04:56:48PM +0200, Nir Soffer wrote: > Wed, Nov 7, 2018 at 4:36 PM Richard W.M. Jones wrote: > > > Another thing I tried was to change the NBD server (nbdkit) so that it > > doesn't advertise zero support to the client: > > > > $ nbdkit --filter=log --filter=nozero memory

Re: [Qemu-devel] [RFC 0/2] vhost-vfio: introduce mdev based HW vhost backend

2018-11-07 Thread Liang, Cunming
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Wednesday, November 7, 2018 2:38 PM > To: Liang, Cunming ; Wang, Xiao W > ; m...@redhat.com; alex.william...@redhat.com > Cc: qemu-devel@nongnu.org; Bie, Tiwei ; Ye, Xiaolong > ; Wang, Zhihong ; Daly, Dan > > Su

[Qemu-devel] [PATCH for-3.2 v2] vhost-user: define conventions for vhost-user backends

2018-11-07 Thread Marc-André Lureau
As discussed during "[PATCH v4 00/29] vhost-user for input & GPU" review, let's define a common set of backend conventions to help with management layer implementation, and interoperability. v2: - use a vhost-user.json schema to discover backends and describe capability format - drop --pidfil

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-07 Thread Philippe Mathieu-Daudé
On 7/11/18 0:06, Peter Maydell wrote: On 6 November 2018 at 19:16, Philippe Mathieu-Daudé wrote: On 6/11/18 19:43, Peter Maydell wrote: I had an idea for how to get a rough list of source files containing devices that haven't been QOMified. The theory is that a pre-QOM device generally has an

[Qemu-devel] [PATCH] i386: Rename bools in PCMachineState to end in _enabled

2018-11-07 Thread minyard
From: Corey Minyard This makes their function more clear and prevents conflicts when adding the actual devices to the machine state, if necessary. Signed-off-by: Corey Minyard Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost --- hw/i386/pc.c | 18 +- hw/i3

Re: [Qemu-devel] [PATCH v3 1/7] qapi: use qemu_strtoi64() in parse_str

2018-11-07 Thread Markus Armbruster
David Hildenbrand writes: > On 05.11.18 21:43, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> On 05.11.18 16:37, Markus Armbruster wrote: David Hildenbrand writes: > On 31.10.18 18:55, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> On 31.1

Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-07 Thread Eduardo Habkost
On Wed, Nov 07, 2018 at 01:45:35PM +, Peter Maydell wrote: > On 7 November 2018 at 12:49, Eduardo Habkost wrote: > > Now, why do we need --with-python, and why do we need to use > > $(PYTHON) when running tests? If somebody wants to use a > > different Python binary when running tests, they c

Re: [Qemu-devel] QEMU and Kconfig

2018-11-07 Thread Samuel Ortiz
Hi Paolo, On Thu, Sep 27, 2018 at 10:55:59AM +0200, Paolo Bonzini wrote: > > What is the syntactic thing in this example which distinguishes > > "user can toggle this" (ESP_PCI, ARM_VIRT, SUN4M) from "user > > can't toggle this, it's just an internal thing selected by > > other nodes" (the rest) ?

Re: [Qemu-devel] [PATCH for-3.2 v3 13/14] hw/i386: add pc-i440fx-3.2 & pc-q35-3.2

2018-11-07 Thread Marc-André Lureau
Hi On Wed, Nov 7, 2018 at 4:49 PM Marc-André Lureau wrote: > > The following patch is going to add compatiblity parameters for > qemu <= 3.1. > I realize this may be good enough for x86 i440/q35 machines, but what about other machines & architectures? What do we officially support, for migratio

Re: [Qemu-devel] [PATCH] i386: Rename bools in PCMachineState to end in _enabled

2018-11-07 Thread Philippe Mathieu-Daudé
On 7/11/18 16:24, miny...@acm.org wrote: From: Corey Minyard This makes their function more clear and prevents conflicts when adding the actual devices to the machine state, if necessary. Signed-off-by: Corey Minyard Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Reviewed-by

[Qemu-devel] [PATCH 0/3] Fix/add vmstate handling in some I2C code

2018-11-07 Thread minyard
These changes allow SMBus access while doing a state transfer. Seems like a good idea to me in general. I have these queued for the SMBus IPMI driver work, of course.

[Qemu-devel] [PATCH 1/3] i2c:pm_smbus: Fix state transfer

2018-11-07 Thread minyard
From: Corey Minyard Transfer the state information for the SMBus registers and internal data so it will work on a VM transfer. Signed-off-by: Corey Minyard Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Dr. David Alan Gilbert --- hw/acpi/piix4.c | 3 ++- hw/i2c/pm_smbus.c |

[Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-07 Thread minyard
From: Corey Minyard This was if the eeprom is accessed during a state transfer, the transfer will be reliable. Signed-off-by: Corey Minyard Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Dr. David Alan Gilbert --- hw/i2c/smbus_eeprom.c | 16 +++- 1 file changed, 15 insertions(+),

[Qemu-devel] [PATCH 2/3] i2c: Add an SMBus vmstate structure

2018-11-07 Thread minyard
From: Corey Minyard There is no vmstate handling for SMBus, so no device sitting on SMBus can have a state transfer that works reliable. So add it. Signed-off-by: Corey Minyard Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Dr. David Alan Gilbert --- hw/i2c/smbus.c | 14 +

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add an entry for the 'collie' machine

2018-11-07 Thread Markus Armbruster
Peter Maydell writes: > On 6 November 2018 at 18:52, Thomas Huth wrote: >> On 2018-11-06 19:49, Philippe Mathieu-Daudé wrote: >>> On 6/11/18 19:17, Thomas Huth wrote: There is no active maintainer, but since Peter is picking up patches via qemu-...@nongnu.org, I think we could at least

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/4] s390x/zpci: drop msix.available

2018-11-07 Thread Collin Walling
On 11/5/18 6:19 AM, Cornelia Huck wrote: > On Mon, 5 Nov 2018 12:03:10 +0100 > David Hildenbrand wrote: > >> I fail to see why this is useful as we require MSIX always and >> completely fail adding a device. >> >> Signed-off-by: David Hildenbrand >> --- >> hw/s390x/s390-pci-bus.c | 2 -- >> hw

[Qemu-devel] [PATCH v5] lsi: Reselection needed to remove pending commands from queue

2018-11-07 Thread George Kennedy
Under heavy IO (e.g. fio) the queue is not checked frequently enough for pending commands. As a result some pending commands are timed out by the linux sym53c8xx driver, which sends SCSI Abort messages for the timed out commands. The SCSI Abort messages result in linux errors, which show up on the

Re: [Qemu-devel] [PATCH v2 for-3.1] hw/arm/sysbus-fdt: Only call match_fn callback if the type matches

2018-11-07 Thread Alex Williamson
On Tue, 6 Nov 2018 19:42:12 +0100 Eric Auger wrote: > Commit af7d64ede0b9 (hw/arm/sysbus-fdt: Allow device matching with DT > compatible value) introduced a match_fn callback which gets called > for each registered combo to check whether a sysbus device can be > dynamically instantiated. However

Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-07 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Nov 07, 2018 at 01:45:35PM +, Peter Maydell wrote: >> On 7 November 2018 at 12:49, Eduardo Habkost wrote: >> > Now, why do we need --with-python, and why do we need to use >> > $(PYTHON) when running tests? If somebody wants to use a >> > different Python b

Re: [Qemu-devel] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

2018-11-07 Thread Eric Blake
On 11/7/18 6:13 AM, Richard W.M. Jones wrote: (I'm not going to claim this is a bug, but it causes a large, easily measurable performance regression in virt-v2v). I haven't closely looked at at this email thread yet, but a quick first impression: In qemu 2.12 this behaviour changed: $

Re: [Qemu-devel] [PULL 0/8] Monitor patches for 2018-10-30

2018-11-07 Thread Eric Blake
On 11/7/18 5:21 AM, Peter Maydell wrote: On 7 November 2018 at 02:56, Peter Xu wrote: Strange, "make check -j8" failed on my hosts (I tried two) with either Markus's pull tree or qemu master: hw/core/ptimer.o: In function `timer_new_tl': /home/xz/git/qemu/include/qemu/timer.h:536: undefined re

Re: [Qemu-devel] vhost-user devices work with chardev from different threads

2018-11-07 Thread Yury Kotov
Hi, I was wrong... Described problem with vhost-user is not possible. It cannot enter tcp_chr_disconnect twice because of qemu global mutex (BQL). Thus chardev event handler (main loop) and vhost_user_blk_set_status (VCPU) are working under BQL. 30.10.2018, 20:12, "Marc-André Lureau" : > Hi > > O

[Qemu-devel] getting link errors when building for qga-vss.dll

2018-11-07 Thread Kirk Allan
When I try to build qga-vss.dll I get the following link error: LINKqga/vss-win32/qga-vss.dll /usr/lib64/gcc/i686-w64-mingw32/8.2.0/../../../../i686-w64-mingw32/bin/ld: qga/vss-win32/requester.o: in function `requester_freeze': /src/qemu/qga/vss-win32/requester.cpp:284: undefined reference to

Re: [Qemu-devel] [Qemu-block] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

2018-11-07 Thread Kevin Wolf
Am 07.11.2018 um 15:56 hat Nir Soffer geschrieben: > Wed, Nov 7, 2018 at 4:36 PM Richard W.M. Jones wrote: > > > Another thing I tried was to change the NBD server (nbdkit) so that it > > doesn't advertise zero support to the client: > > > > $ nbdkit --filter=log --filter=nozero memory size=6G

[Qemu-devel] [Bug 1758819] Re: HVF Illegal instruction: 4, High Sierra, v2.12-rc0

2018-11-07 Thread Nathan Wallace
I am also able to reproduce this bug. The problem is that when hvf is enabled, qemu will attempt to execute the xgetbv instruction, which isn't supported on my processor (Intel Xeon X5670). Here is a stack trace from lldb; the behavior is 100% reproducible for me. nathan@Nathans-Mac-Pro:~/src/qem

Re: [Qemu-devel] [PATCH v4 00/16] gdbstub: support for the multiprocess extension

2018-11-07 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181106110548.4209-1-luc.mic...@greensocs.com Subject: [Qemu-devel] [PATCH v4 00/16] gdbstub: support for the multiprocess extension === TEST SCRIPT BEGIN === #!/bin/bash

  1   2   >