On 31 October 2018 at 00:31, Eduardo Habkost wrote:
> From: Cleber Rosa
>
> A number of QEMU tests are written in Python, and may benefit
> from an untainted Python venv.
>
> By using make rules, tests that depend on specific Python libs
> can set that rule as a requirement, along with rules that
On 5/11/18 19:14, Michael S. Tsirkin wrote:
From: Peter Maydell
Currently tests/hex-loader-check-data contains data files used
by the hexloader-test, and configure individually symlinks those
data files into the build directory using a wildcard.
Using a wildcard like this is a bad idea, becaus
Looks like we've fixed them all already in the past months, e.g. with:
f7d6bfcdc0fe49040aac3ac131a319cb5427957e
spapr_pci: fail gracefully with non-pseries machine types
2363d5ee231bf047479422d56d3b85b7d37a7c23
hw/ppc/spapr_cpu_core: Add a proper check for spapr machine
ef0e8fc768a561dd13a8
On 5/11/18 19:14, Michael S. Tsirkin wrote:
From: Peter Maydell
The FILES variable is used to accumulate a list of things to symlink
from the source tree into the build tree. These don't have to be
individual files; symlinking an entire directory of data files is
also fine. Rename it to somet
On 5/11/18 19:14, Michael S. Tsirkin wrote:
From: Peter Maydell
Currently tests/acpi-test-data contains data files used by the
bios-tables-test, and configure individually symlinks those
data files into the build directory using a wildcard.
Using a wildcard like this is a bad idea, because if
On 5 November 2018 at 19:44, Alistair Francis wrote:
> Coverity caught a malloc() call that was never freed. This patch ensures
> that we free the memory but also updates the allocation to use
> g_strdup_printf() instead of malloc().
>
> Signed-off-by: Alistair Francis
> Suggested-by: Peter Mayde
Public bug reported:
Launching a centos74 iso VM today does not work anymore on x86_64
without increasing the size of the memory parameter. For example with
this command :
$ /opt/qemu-3.0.0/bin/qemu-system-x86_64 --curses -enable-kvm -drive
file=file.dd,index=0,media=disk -drive file=centos-
x8
On 6/11/18 14:10, Peter Maydell wrote:
On 31 October 2018 at 00:31, Eduardo Habkost wrote:
From: Cleber Rosa
A number of QEMU tests are written in Python, and may benefit
from an untainted Python venv.
By using make rules, tests that depend on specific Python libs
can set that rule as a requ
61f0f4b4947:
>
> Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20181105' into
> staging (2018-11-06 09:10:46 +)
>
> are available in the Git repository at:
>
> https://git.linaro.org/people/pmaydell/qemu-arm.git
> tags/p
On Thu 01 Nov 2018 07:27:36 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> diff --git a/block/qcow2.c b/block/qcow2.c
> index e9d24b801e..950b9f7ec6 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -3956,14 +3956,15 @@ fail:
> int qcow2_decompress_cluster(BlockDriverState *bs, uint64_t clus
(added various kvm/virtualization lists in Cc as well as qemu as I don't
know who's "wrong" here)
Pavel Tatashin wrote on Thu, Jul 19, 2018:
> Allow sched_clock() to be used before schec_clock_init() is called.
> This provides with a way to get early boot timestamps on machines with
> unstable clo
Pavel has a new email address, cc'd - steve
On 11/6/2018 12:42 AM, Dominique Martinet wrote:
> (added various kvm/virtualization lists in Cc as well as qemu as I don't
> know who's "wrong" here)
>
> Pavel Tatashin wrote on Thu, Jul 19, 2018:
>> Allow sched_clock() to be used before schec_clock_in
On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote:
> On 5/11/18 19:14, Michael S. Tsirkin wrote:
> > From: Peter Maydell
> >
> > Currently tests/hex-loader-check-data contains data files used
> > by the hexloader-test, and configure individually symlinks those
> > data files
The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis
seems to provide an older version. Change the existing rules to
use command output instead of exit code, to make it compatible
with older GNU make versions.
Signed-off-by: Eduardo Habkost
---
I think that's the cause of the Travis
On Thu 01 Nov 2018 07:27:38 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> Do decompression in threads, like it is already done for compression.
> This improves asynchronous compressed reads performance.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
Peter Maydell writes:
> Looking through code I noticed that in target/arm/translate.c there
> is the following comment in the decode for the load-acquire/store-release
> instructions:
>
> /* Since the emulation does not have barriers,
> the acquire/release semantics need no speci
;
> are available in the git repository at:
>
> git://git.kraxel.org/qemu tags/seabios-20181106-pull-request
>
> for you to fetch changes up to 0b8f74488e50f98b04e63157f85fde8a13f8d6aa:
>
> update seabios to master snapshot (2018-11-06 12:23:58 +0100)
>
> ---
On 11/6/18 12:21 AM, P J P wrote:
From: Prasad J Pandit
When TIS request is done, set 'sts' data field across all localities.
Signed-off-by: Prasad J Pandit
Reviewed-by: Stefan Berger
---
hw/tpm/tpm_tis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/tpm/tpm
On Tue, Nov 06, 2018 at 11:23:31AM +0100, Gerd Hoffmann wrote:
> Indicates support state for something (device, backend, subsystem, ...)
> in qemu. Add QemuSupportState field to ObjectClass. Add some support
> code.
>
> TODO: wire up to qom-list-types
>
> Signed-off-by: Gerd Hoffmann
> ---
[..
On 6/11/18 15:13, Eduardo Habkost wrote:
The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis
seems to provide an older version. Change the existing rules to
use command output instead of exit code, to make it compatible
with older GNU make versions.
You were quicker, I just found
On 11/6/18 3:13 AM, Marc-André Lureau wrote:
Hi
On Tue, Nov 6, 2018 at 9:24 AM P J P wrote:
From: Prasad J Pandit
When TIS request is done, set 'sts' data field across all localities.
The code certainly meant to set the field across all localities.
However I don't see in the "TCG PC Client
On 11/6/18 6:51 AM, Thomas Huth wrote:
On 2018-10-30 22:47, Stefan Berger wrote:
From: Marc-André Lureau
If swtpm is not found in $PATH or --tpm2 isn't supported, we display
this in the test log. We cannot mark the test as skipped due to a bug in
certain versions of the gtester environment tha
On Tue, Nov 06, 2018 at 11:23:33AM +0100, Gerd Hoffmann wrote:
> Print a warning for deprecated and obsolete devices.
> Also add support state to device listing.
>
> Signed-off-by: Gerd Hoffmann
Should we also add a runtime flag to block these?
E.g. I can see libvirt doing that and passing
the r
Hi Peter,
Can you apply this patch as a CI bug-fix?
Thanks,
Phil.
On 6/11/18 15:27, Philippe Mathieu-Daudé wrote:
On 6/11/18 15:13, Eduardo Habkost wrote:
The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis
seems to provide an older version. Change the existing rules to
use com
On 2018-11-02 10:05, P J P wrote:
> +-- On Sat, 27 Oct 2018, P J P wrote --+
> |+-- On Sun, 21 Oct 2018, P J P wrote --+
> || The length parameter values are not negative, thus use an unsigned
> || type 'size_t' for them. Many routines pass 'len' values to memcpy(3)
> || calls. If it was negative,
On 2018-11-04 14:41, Mark Cave-Ayland wrote:
> On 04/11/2018 06:53, no-re...@patchew.org wrote:
>
>> Hi,
>>
>> This series seems to have some coding style problems. See output below for
>> more information:
>>
>> Type: series
>> Message-id: 20181102152257.20637-1-mark.cave-ayl...@ilande.co.uk
>> S
On 21/10/18 19:58, P J P wrote:
From: Prasad J Pandit
The length parameter values are not negative, thus use an unsigned
type 'size_t' for them. Many routines pass 'len' values to memcpy(3)
calls. If it was negative, it could lead to memory corruption issues.
Add check to avoid it.
Reported-by
On 2018-11-02 16:22, Mark Cave-Ayland wrote:
> From: Laurent Vivier
>
> Co-developed-by: Mark Cave-Ayland
> Signed-off-by: Mark Cave-Ayland
> Signed-off-by: Laurent Vivier
> Reviewed-by: Hervé Poussineau
> ---
> hw/misc/mac_via.c | 190
> +
On 2018-11-02 16:22, Mark Cave-Ayland wrote:
> From: Laurent Vivier
>
> Co-developed-by: Mark Cave-Ayland
> Signed-off-by: Mark Cave-Ayland
> Signed-off-by: Laurent Vivier
> Reviewed-by: Hervé Poussineau
> ---
> arch_init.c| 4 +
> hw/display/Makefile.objs | 1 +
> hw/d
Display a message during the test using g_test_message rather
than fprintf.
Signed-off-by: Stefan Berger
---
tests/tpm-tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
index 93a5beba01..5f217a2d92 100644
--- a/tests/tpm-tests.c
+++
On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> +buf = g_try_malloc(csize);
> +if (!buf) {
> +return -ENOMEM;
> +}
> +iov.iov_base = buf;
> +iov.iov_len = csize;
> +qemu_iovec_init_external(&local_qiov, &iov, 1);
>
> -iov.iov_base
Coverity complains (CID 1005726) that we might pass -1 as the fd
argument to send() in slirp_send(), because we previously checked for
"so->s == -1 && so->extra". The case of "so->s == -1 but so->extra
NULL" should not in theory happen, but it is hard to guarantee
because various places in the cod
06.11.2018 18:06, Alberto Garcia wrote:
> On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>
>> +buf = g_try_malloc(csize);
>> +if (!buf) {
>> +return -ENOMEM;
>> +}
>> +iov.iov_base = buf;
>> +iov.iov_len = csize;
>> +qemu_iovec_init_external(
On 6/11/18 15:13, Michael S. Tsirkin wrote:
On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote:
On 5/11/18 19:14, Michael S. Tsirkin wrote:
From: Peter Maydell
Currently tests/hex-loader-check-data contains data files used
by the hexloader-test, and configure individually
06.11.2018 16:53, Alberto Garcia wrote:
> On Thu 01 Nov 2018 07:27:36 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>
>> diff --git a/block/qcow2.c b/block/qcow2.c
>> index e9d24b801e..950b9f7ec6 100644
>> --- a/block/qcow2.c
>> +++ b/block/qcow2.c
>> @@ -3956,14 +3956,15 @@ fail:
>> int qcow2_deco
On 2018-11-06 16:13, Stefan Berger wrote:
> Display a message during the test using g_test_message rather
> than fprintf.
>
> Signed-off-by: Stefan Berger
> ---
> tests/tpm-tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
> i
On 06/11/2018 15:52, Thomas Huth wrote:
> On 2018-11-02 10:05, P J P wrote:
>> +-- On Sat, 27 Oct 2018, P J P wrote --+
>> |+-- On Sun, 21 Oct 2018, P J P wrote --+
>> || The length parameter values are not negative, thus use an unsigned
>> || type 'size_t' for them. Many routines pass 'len' values
There are three outstanding Coverity issues for the slirp code.
This patchset fixes them:
* easiest first, we explicitly check for so->s == -1 in slirp_send()
to avoid possibly passing -1 to the send() function.
In an ideal world we could assert() it wasn't -1, but the
slirp code is too c
Now that socreate() can never fail, we can remove the code
that was trying to handle that situation.
In particular this removes code in tcp_connect() that
provoked Coverity to complain (CID 1005724): in
closesocket(accept(inso->s, (struct sockaddr *)&addr, &addrlen));
if the accept() call fails t
Currently fork_exec() fork()s, and then creates and connects the
child socket which it uses for communication with the parent in
the child process. This is awkward because the child has no
mechanism to report failure back to the parent, which might end
up blocked forever in accept(). The child code
The slirp socreate() function can only fail if the attempt
to malloc() the struct socket fails. Switch to using
g_new() instead, which will allow us to remove the
error-handling code from its callers.
Signed-off-by: Peter Maydell
---
We already use g_new/g_malloc in slirp, including for
mbuf buff
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20181029173437.32559-1-pbonz...@redhat.com
Subject: [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n
On Tue 06 Nov 2018 04:13:58 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> 06.11.2018 18:06, Alberto Garcia wrote:
>> On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>>
>>> +buf = g_try_malloc(csize);
>>> +if (!buf) {
>>> +return -ENOMEM;
>>> +}
>>> +i
On 6 November 2018 at 15:15, Philippe Mathieu-Daudé wrote:
> No worry, I'm not mad at all, but there might be an issue in your git PR
> workflow, this series also missed your maintainer S-o-b.
>
> Peter: Can you add a such check in your scripts? (during next merge window,
> no hurry).
>
> Rather t
Currently replay_get_byte() does not check for an error
from getc(). Coverity points out (CID 1390622) that this
could result in unexpected behaviour (such as looping
forever, if we use the replay_get_dword() return value
for a loop count). We don't expect reads from the replay
log to fail, and if
On 10/29/18 2:34 PM, Paolo Bonzini wrote:
Block limits emulation is just placing 0xb0 as the final byte of the
VPD pages list. However, VPD page numbers must be sorted, so change
that to an in-place insert. Since I couldn't find any disk that triggered
the loop more than once, this was teste
On 10/29/18 2:34 PM, Paolo Bonzini wrote:
A device can report an excessive number of VPD pages when asked for a
list; this can cause an out-of-bounds access to buf in
scsi_generic_set_vpd_bl_emulation. It should not happen, but
it is technically not incorrect so handle it: do not check any by
On 6 November 2018 at 14:13, Eduardo Habkost wrote:
> The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis
> seems to provide an older version. Change the existing rules to
> use command output instead of exit code, to make it compatible
> with older GNU make versions.
>
> Signed-off-
On 2018-11-02 16:22, Mark Cave-Ayland wrote:
> From: Laurent Vivier
>
> Co-developed-by: Mark Cave-Ayland
> Signed-off-by: Mark Cave-Ayland
> Signed-off-by: Laurent Vivier
> ---
> hw/Makefile.objs| 1 +
> hw/nubus/Makefile.objs | 4 +
> hw/nubus/mac-nubus-
Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20181029173437.32559-1-pbonz...@redhat.com
Subject: [Qemu-devel] [PATCH 0/4] scsi-generic
On 5 November 2018 at 15:35, Eric Auger wrote:
> Commit af7d64ede0b9 (hw/arm/sysbus-fdt: Allow device matching with DT
> compatible value) introduced a match_fn callback which gets called
> for each registered combo to check whether a sysbus device can be
> dynamically instantiated. However the ca
On 11/06/18 13:39, Peter Maydell wrote:
> On 6 November 2018 at 11:20, Peter Maydell wrote:
>> On 6 November 2018 at 11:07, Michael S. Tsirkin wrote:
>>> On Tue, Nov 06, 2018 at 09:18:49AM +0100, Thomas Huth wrote:
On 2018-11-05 19:14, Michael S. Tsirkin wrote:
> The following changes si
On Tue, Nov 06, 2018 at 09:43:06AM +, Richard W.M. Jones wrote:
> On Tue, Nov 06, 2018 at 09:14:57AM +, Richard W.M. Jones wrote:
> > This link shows how to combine delay and error filters together:
> >
> > https://rwmj.wordpress.com/2018/11/04/nbd-graphical-viewer/
>
> Oops, that's in
Hi,
How did you find all those issues, Max? First patch is something that
I missed out from the SCSI spec (ordering of the VPD pages)
and could have been detected by code inspection, but I am curious about
the other fixes.
Thanks,
Daniel
On 10/29/18 2:34 PM, Paolo Bonzini wrote:
scsi-gener
Peter Maydell writes:
> On 30 October 2018 at 19:16, Markus Armbruster wrote:
>> The following changes since commit 3f3285491dd52014852a56135c90e428c8b507ea:
>>
>> Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request'
>> into staging (2018-10-30 14:09:25 +)
>>
>> are ava
On Sun, 28 Oct 2018 23:29:40 -0700
Li Qiang wrote:
> Currently, when hotplug/unhotplug nvme device, it will cause an
> assert in object.c. Following is the backtrack:
>
> ERROR:qom/object.c:981:object_unref: assertion failed: (obj->ref > 0)
>
> Thread 2 "qemu-system-x86" received signal SIGABRT
On Tue, Nov 06, 2018 at 03:31:08PM +, Peter Maydell wrote:
> On 6 November 2018 at 15:15, Philippe Mathieu-Daudé wrote:
> > No worry, I'm not mad at all, but there might be an issue in your git PR
> > workflow, this series also missed your maintainer S-o-b.
> >
> > Peter: Can you add a such ch
In virtio_blk_handle_request(), in_iov is used for input header while iov
is used for output header. Rename iov to out_iov to pair output header's
name with in_iov to avoid confusing people when reading source code.
Signed-off-by: Dongli Zhang
---
hw/block/virtio-blk.c | 8
1 file chang
On Tue, Nov 06, 2018 at 04:15:03PM +0100, Philippe Mathieu-Daudé wrote:
> On 6/11/18 15:13, Michael S. Tsirkin wrote:
> > On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote:
> > > On 5/11/18 19:14, Michael S. Tsirkin wrote:
> > > > From: Peter Maydell
> > > >
> > > > Currently
On 06/11/2018 16:15, Philippe Mathieu-Daudé wrote:
> On 6/11/18 15:13, Michael S. Tsirkin wrote:
>> On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote:
>>> On 5/11/18 19:14, Michael S. Tsirkin wrote:
From: Peter Maydell
Currently tests/hex-loader-check-data conta
06.11.2018 18:30, Alberto Garcia wrote:
> On Tue 06 Nov 2018 04:13:58 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>> 06.11.2018 18:06, Alberto Garcia wrote:
>>> On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>>>
+buf = g_try_malloc(csize);
+if (!buf) {
>>>
Before we supported direct execution from MMIO regions, we
implemented workarounds in commit 720424359917887c926a33d2
which let us avoid doing so, even if the SAU or MPU region
was less than page-sized.
Once we implemented execute-from-MMIO, we removed part
of those workarounds in commit d4b6275df
Remove a TODO comment about implementing the vectored interrupt
controller. We have had an implementation of that for a decade;
it's in hw/intc/pl190.c.
Signed-off-by: Peter Maydell
---
target/arm/helper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/arm/helper.c b/target/arm/helper
Am 01.11.2018 um 17:30 hat Peter Maydell geschrieben:
> In the function external_snapshot_prepare() we have a
> BlockdevSnapshotSync struct, which has the usual combination
> of has_snapshot_node_name and snapshot_node_name fields for an
> optional field. We set up a local variable
> const
Am 05.11.2018 um 04:04 hat zhenwei pi geschrieben:
> Function block_latency_histogram_set may return error, but qapi ignore this.
> This can be reproduced easily by qmp command:
> virsh qemu-monitor-command INSTANCE
> '{"execute":"x-block-latency-histogram-set",
> "arguments":{"device":"drive-virt
Am 05.11.2018 um 16:08 hat Julio Faracco geschrieben:
> Since Mac OS X El Capitain (v10.11), Apple uses LZFSE compression to
> generate compressed DMGs as an alternative to BZIP2. Possible, Apple
> want to keep this algorithm as default in long term. Some years ago,
> Apple opened the LZFSE algor
Am 31.10.2018 um 10:30 hat Vladimir Sementsov-Ogievskiy geschrieben:
> ping2
>
> Hi, it's a first step to backup refactoring and improving. Just get rid
> of this extra and unnatural synchronization.
The replication maintainers don't seem to have an opinion about this, so
thanks, applied to bloc
Am 02.11.2018 um 17:41 hat Vladimir Sementsov-Ogievskiy geschrieben:
> ping
>
> 15.10.2018 19:06, Vladimir Sementsov-Ogievskiy wrote:
> > Hi all!
> >
> > These series introduce backup-top driver. It's a filter-node, which
> > do copy-before-write operation. Mirror uses filter-node for handling
> >
Am 15.10.2018 um 18:06 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Drop write notifiers and use filter node instead. Changes:
>
> 1. copy-before-writes now handled by filter node, so, drop all
>is_write_notifier arguments.
>
> 2. we don't have intersecting requests, so their handling is d
On 6/11/18 17:38, Peter Maydell wrote:
Before we supported direct execution from MMIO regions, we
implemented workarounds in commit 720424359917887c926a33d2
which let us avoid doing so, even if the SAU or MPU region
was less than page-sized.
Once we implemented execute-from-MMIO, we removed part
On 11/6/18 6:28 AM, Gerd Hoffmann wrote:
seabios 1.12 release is planned for november.
update seabios to a master branch snapshot so it gets more testing
and to make the delta smaller when updating to -final during freeze.
git shortlog rel-1.11.2..14221cd86e
===
From: Wolfgang Bumiller
monitor_resume() and monitor_suspend() both want to
"kick" the I/O thread if it is there, but in
monitor_suspend() lacked the use_io_thread flag condition.
This is required when we later only spawn the thread on
first use.
Signed-off-by: Wolfgang Bumiller
Reviewed-by: Er
From: Eric Blake
A quick coredump on an incomplete command line:
./x86_64-softmmu/qemu-system-x86_64 -mon mode=control,pretty=on
#0 0x7723d9e4 in g_str_hash () at /lib64/libglib-2.0.so.0
#1 0x7723ce38 in g_hash_table_lookup () at /lib64/libglib-2.0.so.0
#2 0x55cc007
From: Wolfgang Bumiller
Commit d32749deb615 moved the call to monitor_init_globals()
to before os_daemonize(), making it an unsuitable place to
spawn the monitor iothread as it won't be inherited over the
fork() in os_daemonize().
We now spawn the thread the first time we instantiate a
monitor w
The following changes since commit 0ca70f19c010ccf0b10cf7cc1d2b9a87193fe787:
tests: Fix Python 3 detection on older GNU make versions (2018-11-06 14:58:13
+)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2018-10-30-v2
for you to fetch change
Am 15.10.2018 um 18:06 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Otherwise, if we have serialized read-part in copy_range from backing
> file to its parent if CoW take place, this CoW's sub-reads will
> intersect with firstly created serialized read request.
>
> Anyway, reads should not infl
Am 15.10.2018 um 18:06 hat Vladimir Sementsov-Ogievskiy geschrieben:
> As it already said in the comment, we don't want to create loops in
> parent->child relations. So, when we try to append @to to @c, we should
> check that @c is not in @to children subtree, and we should check it
> recursively,
There is no active maintainer, but since Peter is picking up
patches via qemu-...@nongnu.org, I think we could at least use
"Odd Fixes" as status here.
Signed-off-by: Thomas Huth
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0499e11..47
On 6 November 2018 at 17:39, Markus Armbruster wrote:
> The following changes since commit 0ca70f19c010ccf0b10cf7cc1d2b9a87193fe787:
>
> tests: Fix Python 3 detection on older GNU make versions (2018-11-06
> 14:58:13 +)
>
> are available in the Git repository at:
>
> git://repo.or.cz/qemu
Commit af7d64ede0b9 (hw/arm/sysbus-fdt: Allow device matching with DT
compatible value) introduced a match_fn callback which gets called
for each registered combo to check whether a sysbus device can be
dynamically instantiated. However the callback gets called even if
the device type does not matc
I had an idea for how to get a rough list of source files
containing devices that haven't been QOMified. The theory
is that a pre-QOM device generally has an "init" function
which allocates memory for the device struct. So looking in
hw/ for files which call g_new*() or g_malloc*() should get
us al
On 6/11/18 19:17, Thomas Huth wrote:
There is no active maintainer, but since Peter is picking up
patches via qemu-...@nongnu.org, I think we could at least use
"Odd Fixes" as status here.
This looks more as "Orphan" to me...
Regardless the one choosed:
Reviewed-by: Philippe Mathieu-Daudé
On 2018-11-06 19:49, Philippe Mathieu-Daudé wrote:
> On 6/11/18 19:17, Thomas Huth wrote:
>> There is no active maintainer, but since Peter is picking up
>> patches via qemu-...@nongnu.org, I think we could at least use
>> "Odd Fixes" as status here.
>
> This looks more as "Orphan" to me...
I'll
On 06/11/2018 16:54, Daniel Henrique Barboza wrote:
> Hi,
>
> How did you find all those issues, Max? First patch is something that
> I missed out from the SCSI spec (ordering of the VPD pages)
> and could have been detected by code inspection, but I am curious about
> the other fixes.
It was fo
On 06/11/2018 15:52, Thomas Huth wrote:
> The bluetooth subsystem is completely unmaintained, so if Paolo does not
> want to pick it up through his "misc" tree, maybe Peter could apply this
> patch directly? Or maybe it could go through the trivial tree since it
> does not look very complicated?
I
On 31/10/2018 22:03, George Kennedy wrote:
> +#define SCRIPTS_LOAD_AND_STORE 0xe2340004
I'm very confused. Why did this constant reappear?
Paolo
On 6 November 2018 at 18:52, Thomas Huth wrote:
> On 2018-11-06 19:49, Philippe Mathieu-Daudé wrote:
>> On 6/11/18 19:17, Thomas Huth wrote:
>>> There is no active maintainer, but since Peter is picking up
>>> patches via qemu-...@nongnu.org, I think we could at least use
>>> "Odd Fixes" as status
On 11/6/2018 1:58 PM, Paolo Bonzini wrote:
On 31/10/2018 22:03, George Kennedy wrote:
+#define SCRIPTS_LOAD_AND_STORE 0xe2340004
I'm very confused. Why did this constant reappear?
Ok. Me too.
What are you proposing instead and I'll change it to that?
Did I have what you're after in a pr
On 06/11/2018 20:13, george kennedy wrote:
>
> On 11/6/2018 1:58 PM, Paolo Bonzini wrote:
>> On 31/10/2018 22:03, George Kennedy wrote:
>>> +#define SCRIPTS_LOAD_AND_STORE 0xe2340004
>> I'm very confused. Why did this constant reappear?
>
> Ok. Me too.
>
> What are you proposing instead and I'
On 6/11/18 19:43, Peter Maydell wrote:
I had an idea for how to get a rough list of source files
containing devices that haven't been QOMified. The theory
is that a pre-QOM device generally has an "init" function
which allocates memory for the device struct. So looking in
hw/ for files which call
On 06/11/2018 19:43, Peter Maydell wrote:
> hw/pci/shpc.c ?
This is not a device, it is a PCI capability.
Paolo
On 06/11/2018 19:43, Peter Maydell wrote:
> hw/core/ptimer.c
Not a device.
> hw/i2c/bitbang_i2c.c
TYPE_GPIO_I2C?
> hw/ide/ahci.c
Even though AHCIState is not a QOM object, all of its users are
(TYPE_SYSBUS_AHCI is in this file, TYPE_ICH9_AHCI is in hw/ide/ich.c).
Paolo
On Tue, Nov 6, 2018 at 11:47 AM Paolo Bonzini wrote:
>
> On 06/11/2018 19:43, Peter Maydell wrote:
> > hw/core/ptimer.c
>
> Not a device.
>
> > hw/i2c/bitbang_i2c.c
>
> TYPE_GPIO_I2C?
>
> > hw/ide/ahci.c
>
> Even though AHCIState is not a QOM object, all of its users are
> (TYPE_SYSBUS_AHCI is in
On 11/06/2018 02:46 PM, Paolo Bonzini wrote:
> On 06/11/2018 19:43, Peter Maydell wrote:
>> hw/ide/ahci.c
>
> Even though AHCIState is not a QOM object, all of its users are
> (TYPE_SYSBUS_AHCI is in this file, TYPE_ICH9_AHCI is in hw/ide/ich.c).
>
Yeah, if there's something *further* that n
On 06/11/2018 22:23, John Snow wrote:
>
>
> On 11/06/2018 02:46 PM, Paolo Bonzini wrote:
>> On 06/11/2018 19:43, Peter Maydell wrote:
>
>>> hw/ide/ahci.c
>>
>> Even though AHCIState is not a QOM object, all of its users are
>> (TYPE_SYSBUS_AHCI is in this file, TYPE_ICH9_AHCI is in hw/ide/ich.c)
From: Daniel P. Berrangé
The 'q35' machine type implements an Intel Series 3 chipset,
of which there are several variants:
https://www.intel.com/Assets/PDF/datasheet/316966.pdf
The key difference between the 82P35 MCH ('p35', PCI device ID 0x29c0)
and 82Q35 GMCH ('q35', PCI device ID 0x29b0)
Emulation of the block limits VPD page called back into scsi-disk.c,
which however expected the request to be for a SCSIDiskState and
accessed a scsi-generic device outside the bounds of its struct
(namely to retrieve s->max_unmap_size and s->max_io_size).
To avoid this, move the emulation code to
Other people are doing a much better work than myself at handling some
subsystems. For those files it is better if I downgrade myself to
reviewer or recognize that I am not actually doing any work there.
Cc: Daniel P. Berrange
Cc: Gerd Hoffmann
Cc: Eric Blake
Cc: Thomas Huth
Cc: Laurent Vivie
Block limits emulation is just placing 0xb0 as the final byte of the
VPD pages list. However, VPD page numbers must be sorted, so change
that to an in-place insert. Since I couldn't find any disk that triggered
the loop more than once, this was tested by adding manually 0xb1
at the end of the lis
The following changes since commit fc3d1bad1edf08871275cf469a64e12dae4eba96:
oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD (2018-11-06
10:52:23 +)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you to fetch changes up to a4
101 - 200 of 250 matches
Mail list logo
