[Qemu-devel] [Bug 1800993] [NEW] How to Migration VM Built on Qemu Souce Code Installation

2018-11-01 Thread aditya
Public bug reported: Respected all, I followed https://wiki.qemu.org/Hosts/Linux to build qemu from source code. Its installed successfully with Ubuntu 16.04 VM created using VNC server. Now, Could you please suggest me how to migrate VM from one host to another?. Email: adityaf...@gmail.com *

Re: [Qemu-devel] [PATCH] tests/vm: Use subprocess.Popen() with to uncompress XZ files

2018-11-01 Thread Fam Zheng
On Sat, 10/13 02:30, Philippe Mathieu-Daudé wrote: > Avoiding the file copy greatly speeds the process up. > > Comparison with network file already cached, stopping after build_image(): > > Before: > $ time make vm-build-freebsd > real1m38.153s > user1m16.871s > sys 0m19.325s

Re: [Qemu-devel] [PATCH v6 0/5] Connect a PCIe host and graphics support to RISC-V

2018-11-01 Thread Andrea Bolognani
On Wed, 2018-10-31 at 13:10 -0700, Alistair Francis wrote: > On Wed, Oct 31, 2018 at 7:51 AM Andrea Bolognani wrote: > > With the pcie.0 <- pcie-root-port <- virtio-net-pci setup I get > > > > qemu-system-riscv64: -device pcie-root-port,port=0x8,chassis=1,\ > > id=pci.1,bus=pcie.0,multifuncti

[Qemu-devel] [PULL v2 1/7] websock: fix handshake leak

2018-11-01 Thread Marc-André Lureau
Missed in f69a8bde293. Thanks Valgrind: ==955== 217 bytes in 1 blocks are definitely lost in loss record 275 of 321 ==955==at 0x483A965: realloc (vg_replace_malloc.c:785) ==955==by 0x50B6839: __vasprintf_chk (in /usr/lib64/libc-2.28.so) ==955==by 0x49AA05C: g_vasprintf (in /usr/lib64/l

[Qemu-devel] [PULL v2 0/7] Chardev patches

2018-11-01 Thread Marc-André Lureau
The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: Merge remote-tracking branch 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging (2018-10-30 15:49:55 +) are available in the Git repository at: https://github.com/elmarco/qemu.git tags/chrde

[Qemu-devel] [PULL v2 3/7] char-socket: make 'fd' incompatible with 'reconnect'

2018-11-01 Thread Marc-André Lureau
A chardev socket created with the 'fd=' argument is not going to handle reconnection properly by recycling the same fd (or not in a supported way). Let's forbid this case. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- chardev/char-socket.c | 4 1 file changed, 4 inse

[Qemu-devel] [PULL v2 2/7] char-socket: correctly set has_reconnect when parsing QemuOpts

2018-11-01 Thread Marc-André Lureau
qemu_chr_parse_socket() fills all ChardevSocket fields, but that doesn't reflect correctly the arguments given with the options / on the command line. "reconnect" takes a number as argument, and the default value is 0, which doesn't help to identify the missing option. The other arguments have defa

[Qemu-devel] [PULL v2 6/7] tests/test-char: Check websocket chardev functionality

2018-11-01 Thread Marc-André Lureau
From: Julia Suvorova Test order: Creating server websocket chardev Creating usual tcp chardev client Sending handshake message from client Receiving handshake reply Sending ping frame with "hello" payload Receiving pong reply Sending binary data "world" Checking th

[Qemu-devel] [PULL v2 4/7] chardev/char-socket: Function headers refactoring

2018-11-01 Thread Marc-André Lureau
From: Julia Suvorova Upcoming websocket support requires additional parameters in function headers that are already overloaded. This patch replaces the bunch of parameters with a single structure pointer. Signed-off-by: Julia Suvorova Message-Id: <20181018223501.21683-2-jus...@mail.ru> Reviewed

[Qemu-devel] [PULL v2 7/7] editorconfig: set emacs mode

2018-11-01 Thread Marc-André Lureau
Some time ago, I proposed to use an (eval) in .dir-locals.el to set the mode for all json files and Makefile. Unfortunately, this isn't safe, and emacs will prompt the user, which isn't very friendly. Fortunately, editorconfig provides a special config key which does allow to set the emacs mode. A

[Qemu-devel] [PULL v2 5/7] chardev: Add websocket support

2018-11-01 Thread Marc-André Lureau
From: Julia Suvorova New option "websocket" added to allow using WebSocket protocol for chardev socket backend. Example: -chardev socket,websocket,server,id=... Signed-off-by: Julia Suvorova Message-Id: <20181018223501.21683-3-jus...@mail.ru> Reviewed-by: Daniel P. Berrangé Reviewed-by: St

Re: [Qemu-devel] [PATCH v2] vhost-user: define conventions for vhost-user backends

2018-11-01 Thread Marc-André Lureau
Hi On Wed, Oct 31, 2018 at 8:05 PM Daniel P. Berrangé wrote: > > On Wed, Oct 31, 2018 at 07:44:36PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Tue, Oct 16, 2018 at 4:14 PM Daniel P. Berrangé > > wrote: > > > > > It just reinvents the chardev unix socket syntax, but in a > > > > > differe

[Qemu-devel] Running application on R5 of xilinx zcu102 QEMU model

2018-11-01 Thread Mirza, Taimoor
Hi Guys, I have built my application to run on Cortex-R5 ZCU-102. I can successfully run my application on target but I am now trying to run it on QEMU zcu-102 model and facing some problems. Below is the command that I am using: ~/qemu_oss/qemu/aarch64-softmmu/qemu-system-aarch64 -M xlnx-zcu10

Re: [Qemu-devel] [PATCH v3 4/7] range: add some more functions

2018-11-01 Thread Igor Mammedov
On Tue, 23 Oct 2018 17:23:03 +0200 David Hildenbrand wrote: > Add some more functions that will be used in memory-device context. > > range_init(): Init using lower bound and size, check for validity > range_init_nofail(): Init using lower bound and size, validity asserted > range_size(): Extrac

Re: [Qemu-devel] [PATCH] tests/bios-tables-test: Sanitize test verbose output

2018-11-01 Thread Igor Mammedov
On Tue, 30 Oct 2018 01:18:40 +0100 Philippe Mathieu-Daudé wrote: > Fix the extraneous extra blank lines in the test output when running with V=1. > > Before: > > TEST: tests/bios-tables-test... (pid=25678) > /i386/acpi/piix4: > Looking for expected file 'tests/acpi-test-data/pc/DS

[Qemu-devel] [PATCH RFC v7 5/9] migration: fix the multifd code when sending less channels

2018-11-01 Thread Fei Li
Set the migration state to "failed" instead of "setup" when failing to send packet via some channel. Cc: Peter Xu Signed-off-by: Fei Li --- migration/ram.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 4db3b3e8f4..c84d164fc8 100644 --- a/migration

[Qemu-devel] [PATCH RFC v7 2/9] qemu_init_vcpu: add a new Error parameter to propagate

2018-11-01 Thread Fei Li
This patch is to pave the way for a later patch as it is too long: "qemu_thread_create: propagate the error to callers to handle." The callers of qemu_init_vcpu() already passed the **errp to handle errors. In view of this, add a new Error parameter to all the functions called by qemu_init_vcpu()

[Qemu-devel] [PATCH RFC v7 3/9] qemu_thread_join: fix segmentation fault

2018-11-01 Thread Fei Li
To avoid the segmentation fault in qemu_thread_join(), just directly return when the QemuThread *thread failed to be created in either qemu-thread-posix.c or qemu-thread-win32.c. Signed-off-by: Fei Li Reviewed-by: Fam Zheng --- util/qemu-thread-posix.c | 3 +++ util/qemu-thread-win32.c | 2 +-

[Qemu-devel] [PATCH RFC v7 1/9] Fix segmentation fault when qemu_signal_init fails

2018-11-01 Thread Fei Li
When qemu_signal_init() fails in qemu_init_main_loop(), we return without setting an error. Its callers crash then when they try to report the error with error_report_err(). To avoid such segmentation fault, add a new Error parameter to make the call trace to propagate the err to the final caller

[Qemu-devel] [PATCH RFC v7 6/9] migration: fix the multifd code when receiving less channels

2018-11-01 Thread Fei Li
In our current code, when multifd is used during migration, if there is an error before the destination receives all new channels, the source keeps running, however the destination does not exit but keeps waiting until the source is killed deliberately. Fix this by dumping the specific error and l

[Qemu-devel] [PATCH RFC v7 7/9] migration: remove unused &local_err parameter in migrate_set_error

2018-11-01 Thread Fei Li
Always call migrate_set_error() to set the error state without relying on whether multifd_save_cleanup() succeeds. As the passed &local_err is never used in multifd_save_cleanup(), remove it. Cc: Dr. David Alan Gilbert Signed-off-by: Fei Li --- migration/migration.c | 5 + migration/ram.c

[Qemu-devel] [PATCH RFC v7 4/9] migration: fix some segmentation faults when using multifd

2018-11-01 Thread Fei Li
When multifd is used during migration, a segmentaion fault will occur in the source when multifd_save_cleanup() is called again if the multifd_send_state has been freed in earlier error handling. This can happen when migrate_fd_connect() fails and multifd_fd_cleanup() is called, and then multifd_ne

Re: [Qemu-devel] [PATCH v2 05/10] qom/globals: generalize object_property_set_globals()

2018-11-01 Thread Igor Mammedov
On Wed, 31 Oct 2018 17:12:56 -0300 Eduardo Habkost wrote: > On Tue, Oct 30, 2018 at 07:04:48PM +0400, Marc-André Lureau wrote: > > Handle calls of object_property_set_globals() with any object type, > > but only apply globals to TYPE_DEVICE & TYPE_USER_CREATABLE. > > > > Signed-off-by: Marc-Andr

[Qemu-devel] [PATCH RFC v7 9/9] qemu_thread_create: propagate the error to callers to handle

2018-11-01 Thread Fei Li
Make qemu_thread_create() return a Boolean to indicate if it succeeds rather than failing with an error. And add an Error parameter to hold the error message and let the callers handle it. Signed-off-by: Fei Li --- cpus.c | 45 - dump.c

[Qemu-devel] [PATCH RFC v7 8/9] migration: add more error handling for postcopy_ram_enable_notify

2018-11-01 Thread Fei Li
Call postcopy_ram_incoming_cleanup() to do the cleanup when postcopy_ram_enable_notify fails. Besides, report the error message when qemu_ram_foreach_migratable_block() fails. Cc: Dr. David Alan Gilbert Signed-off-by: Fei Li --- migration/postcopy-ram.c | 1 + migration/savevm.c | 1 + 2

[Qemu-devel] [PATCH RFC v7 0/9] qemu_thread_create: propagate errors to callers to check

2018-11-01 Thread Fei Li
Hi, This idea comes from BiteSizedTasks, and this patch series implement the error checking of qemu_thread_create: make qemu_thread_create return a flag to indicate if it succeeded rather than failing with an error; make all callers check it. The first and the third patch fixes some segmentation

[Qemu-devel] [PATCH v4 01/23] hw: i386: Decouple the ACPI build from the PC machine type

2018-11-01 Thread Samuel Ortiz
ACPI tables are platform and machine type and even architecture agnostic, and as such we want to provide an internal ACPI API that only depends on platform agnostic information. For the x86 architecture, in order to build ACPI tables independently from the PC or Q35 machine types, we are moving a

[Qemu-devel] [PATCH v4 03/23] hw: acpi: Export the RSDP build API

2018-11-01 Thread Samuel Ortiz
The hardware-reduced API will need to build RSDP as well, so we should export this routine. While doing so, we also slightly change the function prototype. Since no caller needs it, and to make it more consistent with the rest of the AML build API, the function no longer returns its RSDP table. Si

Re: [Qemu-devel] [PATCH v3 0/3] arm: Add nRF51 SoC UART support

2018-11-01 Thread Stefan Hajnoczi
On Mon, Oct 29, 2018 at 02:37:42PM +, Peter Maydell wrote: > On 25 October 2018 at 01:50, Julia Suvorova wrote: > > This series adds support for the nRF51 SoC UART, that used in > > BBC Micro:bit board, and QTest for it. > > > > v3: > > * serial_hd() moved to the board code > > * sysbu

[Qemu-devel] [PATCH v4 02/23] hw: acpi: Export ACPI build alignment API

2018-11-01 Thread Samuel Ortiz
This is going to be needed by the Hardware-reduced ACPI routines. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Samuel Ortiz --- hw/acpi/aml-build.c | 8 hw/i386/acpi-build.c| 8 include/hw/acpi/aml-build.h | 2 ++ 3 file

[Qemu-devel] [PATCH v4 05/23] hw: arm: Switch to the AML build RSDP building routine

2018-11-01 Thread Samuel Ortiz
We make the ARM virt ACPI code use the now shared build_rsdp() API from aml-build.c. By doing so we fix a bug where the ARM implementation was missing adding both the legacy and extended checksums, which was building an invalid RSDP table. Signed-off-by: Samuel Ortiz --- hw/arm/virt-acpi-build.c

[Qemu-devel] [PATCH v4 04/23] hw: acpi: Implement XSDT support for RSDP

2018-11-01 Thread Samuel Ortiz
XSDT is the 64-bit version of the legacy ACPI RSDT (Root System Description Table). RSDT only allow for 32-bit addressses and have thus been deprecated. Since ACPI version 2.0, RSDPs should point at XSDTs and no longer RSDTs, although RSDTs are still supported for backward compatibility. Since ver

[Qemu-devel] [PATCH v4 08/23] hw: i386: Move PCI host definitions to pci_host.h

2018-11-01 Thread Samuel Ortiz
The PCI hole properties are not pc or i386 specific. They belong to the PCI host header instead. Signed-off-by: Samuel Ortiz --- include/hw/i386/pc.h | 5 - include/hw/pci/pci_host.h | 6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/include/hw/i386/pc.h b/includ

[Qemu-devel] [PATCH v4 11/23] hw: acpi: Export the MCFG getter

2018-11-01 Thread Samuel Ortiz
From: Yang Zhong The ACPI MCFG getter is not x86 specific and could be called from anywhere within generic ACPI API, so let's export it. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Yang Zhong --- hw/acpi/aml-build.c | 24 ++

[Qemu-devel] [PATCH v4 09/23] hw: acpi: Export the PCI host and holes getters

2018-11-01 Thread Samuel Ortiz
This is going to be needed by the hardware reduced implementation, so let's export it. Once the ACPI builder methods and getters will be implemented, the acpi_get_pci_host() implementation will become hardware agnostic. Signed-off-by: Samuel Ortiz --- hw/acpi/aml-build.c | 43 +++

[Qemu-devel] [PATCH v4 16/23] hw: acpi: Export the PCI hotplug API

2018-11-01 Thread Samuel Ortiz
From: Sebastien Boeuf The ACPI hotplug support for PCI devices APIs are not x86 or even machine type specific. In order for future machine types to be able to re-use that code, we export it through the architecture agnostic hw/acpi folder. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

[Qemu-devel] [PATCH v4 06/23] hw: acpi: Generalize AML build routines

2018-11-01 Thread Samuel Ortiz
From: Yang Zhong Most of the AML build routines under acpi-build are not even architecture specific. They can be moved to the more generic hw/acpi folder where they could be shared across machine types and architectures. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Sig

[Qemu-devel] [PATCH v4 13/23] hw: i386: Make the hotpluggable memory size property more generic

2018-11-01 Thread Samuel Ortiz
This property is currently defined under i386/pc while it only describes a region size that's eventually fetched from the AML ACPI code. We can make it more generic and shareable across machine types by moving it to memory-device.h instead. Signed-off-by: Samuel Ortiz --- hw/i386/acpi-build.c

[Qemu-devel] [PATCH v4 10/23] hw: acpi: Export and generalize the PCI host AML API

2018-11-01 Thread Samuel Ortiz
From: Yang Zhong The AML build routines for the PCI host bridge and the corresponding DSDT addition are neither x86 nor PC machine type specific. We can move them to the architecture agnostic hw/acpi folder, and by carrying all the needed information through a new AcpiPciBus structure, we can mak

[Qemu-devel] [PATCH v4 17/23] hw: i386: Export the MADT build method

2018-11-01 Thread Samuel Ortiz
It is going to be used by the PC machine type as the MADT table builder method and thus needs to be exported outside of acpi-build.c Also, now that the generic build_madt() API is exported, we have to rename the ARM static one in order to avoid build time conflicts. Reviewed-by: Philippe Mathieu-

[Qemu-devel] [PATCH v4 12/23] hw: acpi: Do not create hotplug method when handler is not defined

2018-11-01 Thread Samuel Ortiz
CPU and memory ACPI hotplug are not necessarily handled through SCI events. For example, with Hardware-reduced ACPI, the GED device will manage ACPI hotplug entirely. As a consequence, we make the CPU and memory specific events AML generation optional. The code will only be added when the method na

[Qemu-devel] [PATCH v4 19/23] hw: acpi: Define ACPI tables builder interface

2018-11-01 Thread Samuel Ortiz
In order to decouple ACPI APIs from specific machine types, we are creating an ACPI builder interface that each ACPI platform can choose to implement. This way, a new machine type can re-use the high level ACPI APIs and define some custom table build methods, without having to duplicate most of the

[Qemu-devel] [PATCH v4 15/23] hw: acpi: Fix memory hotplug AML generation error

2018-11-01 Thread Samuel Ortiz
From: Yang Zhong When using the generated memory hotplug AML, the iasl compiler would give the following error: dsdt.dsl 266: Return (MOST (_UID, Arg0, Arg1, Arg2)) Error 6080 - Called method returns no value ^ Signed-off-by: Yang Zhong --- hw/acpi/memory_hotplug.c | 10 +- 1 file cha

[Qemu-devel] [PATCH v4 23/23] hw: i386: Refactor PCI host getter

2018-11-01 Thread Samuel Ortiz
From: Yang Zhong Now that the ACPI builder methods are added, we can reach the ACPI configuration pointer from the MachineState pointer. From there we can get to the PCI host pointer and return it. This makes the PCI host getter an ACPI, architecture agnostic function. Signed-off-by: Yang Zhong

[Qemu-devel] [PATCH v4 07/23] hw: acpi: Factorize _OSC AML across architectures

2018-11-01 Thread Samuel Ortiz
From: Yang Zhong The _OSC AML table is almost identical between the i386 Q35 and arm virt machine types. We can make it slightly more generic and share it across all PCIe architectures. Signed-off-by: Yang Zhong --- hw/acpi/aml-build.c | 84 +++-- hw/arm

Re: [Qemu-devel] [PATCH v3 4/7] range: add some more functions

2018-11-01 Thread David Hildenbrand
On 01.11.18 11:00, Igor Mammedov wrote: > On Tue, 23 Oct 2018 17:23:03 +0200 > David Hildenbrand wrote: > >> Add some more functions that will be used in memory-device context. >> >> range_init(): Init using lower bound and size, check for validity >> range_init_nofail(): Init using lower bound a

[Qemu-devel] [PATCH v4 00/23] ACPI reorganization for hardware-reduced support

2018-11-01 Thread Samuel Ortiz
This patch set provides an ACPI code reorganization in preparation for adding hardware-reduced support to QEMU. The changes are coming from the NEMU [1] project where we're defining a new x86 machine type: i386/virt. This is an EFI only, ACPI hardware-reduced platform and as such we had to impleme

Re: [Qemu-devel] [PATCH v2 0/2] test: fw_cfg: add reboot-timeout test case

2018-11-01 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1540873732-3503-1-git-send-email-liq...@gmail.com Subject: [Qemu-devel] [PATCH v2 0/2] te

[Qemu-devel] [PATCH v4 14/23] hw: i386: Export the i386 ACPI SRAT build method

2018-11-01 Thread Samuel Ortiz
This is the standard way of building SRAT on x86 platfoms. But future machine types could decide to define their own custom SRAT build method through the ACPI builder methods. Moreover, we will also need to reach build_srat() from outside of acpi-build in order to use it as the ACPI builder SRAT bu

[Qemu-devel] [PATCH v4 21/23] hw: pci-host: piix: Return PCI host pointer instead of PCI bus

2018-11-01 Thread Samuel Ortiz
For building the MCFG table, we need to track a given machine type PCI host pointer, and we can't get it from the bus pointer alone. As piix returns a PCI bus pointer, we simply modify its builder to return a PCI host pointer instead. Signed-off-by: Samuel Ortiz --- hw/i386/pc_piix.c| 18 +++

Re: [Qemu-devel] [PATCH v3 01/13] qtest: Add set_irq_in command to set IRQ/GPIO level

2018-11-01 Thread Stefan Hajnoczi
On Tue, Oct 30, 2018 at 08:25:15PM -0400, Steffen Görtz wrote: > Adds a new qtest command "set_irq_in" which allows > to set qemu gpio lines to a given level. > > Based on https://lists.gnu.org/archive/html/qemu-devel/2012-12/msg02363.html > which never got merged. > > Signed-off-by: Steffen Gört

[Qemu-devel] [PATCH v4 18/23] hw: acpi: Retrieve the PCI bus from AcpiPciHpState

2018-11-01 Thread Samuel Ortiz
From: Sebastien Boeuf Instead of using the machine type specific method find_i440fx() to retrieve the PCI bus, this commit aims to rely on the fact that the PCI bus is known by the structure AcpiPciHpState. When the structure is initialized through acpi_pcihp_init() call, it saves the PCI bus, w

[Qemu-devel] [PATCH v4 20/23] hw: i386: Implement the ACPI builder interface for PC

2018-11-01 Thread Samuel Ortiz
All PC machine type derivatives will use the same ACPI table build methods. But with that change in place, any new x86 machine type will be able to re-use the acpi-build API and customize part of it by defining its own ACPI table build methods. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Phili

[Qemu-devel] [PATCH v4 22/23] hw: i386: Set ACPI configuration PCI host pointer

2018-11-01 Thread Samuel Ortiz
For both PC and Q35 machine types, we can set it at the PCI host bridge creation time. Signed-off-by: Samuel Ortiz --- hw/i386/pc_piix.c | 1 + hw/i386/pc_q35.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index f5b139a3eb..f1f0de3585 100644 --- a/

[Qemu-devel] [PATCH] block/nvme: optimize the performance of nvme driver based on vfio-pci

2018-11-01 Thread Li Feng
When the IO size is larger than 2 pages, we move the the pointer one by one in the pagelist, this is inefficient. This is a simple benchmark result: Before: $ qemu-io -c 'write 0 1G' nvme://:00:04.0/1 wrote 1073741824/1073741824 bytes at offset 0 1 GiB, 1 ops; 0:00:02.41 (424.504 MiB/sec and

[Qemu-devel] [PATCH] ivshmem: fix memory backend leak

2018-11-01 Thread Igor Mammedov
object_new() returns a new backend with refcount == 1 and then later object_property_add_child() increases refcount to 2 So when ivshmem is desroyed, the backend it has created isn't destroyed along with it as children cleanup will bring backend's refcount only to 1, which leaks backend including r

Re: [Qemu-devel] [PULL 0/2] target/xtensa updates for 3.1

2018-11-01 Thread Peter Maydell
On 30 October 2018 at 18:34, Max Filippov wrote: > Hi Peter, > > please pull the following series that adds bFLT binaries support for > target/xtensa. > > The following changes since commit 3892f1f1a963e59dfe012cd9d461d33b2986fa3b: > > Merge remote-tracking branch 'remotes/dgibson/tags/libfdt-20

Re: [Qemu-devel] [PATCH v3 02/13] arm: Add header to host common definition for nRF51 SOC peripherals

2018-11-01 Thread Stefan Hajnoczi
On Tue, Oct 30, 2018 at 08:25:16PM -0400, Steffen Görtz wrote: > Adds a header that provides definitions that are used > across nRF51 peripherals > > Signed-off-by: Steffen Görtz > --- > hw/arm/nrf51_soc.c | 33 ++- > include/hw/arm/nrf51.h | 44 ++

Re: [Qemu-devel] [PATCH] ivshmem: fix memory backend leak

2018-11-01 Thread Marc-André Lureau
On Thu, Nov 1, 2018 at 2:53 PM Igor Mammedov wrote: > > object_new() returns a new backend with refcount == 1 and > then later object_property_add_child() increases refcount to 2 > So when ivshmem is desroyed, the backend it has created isn't > destroyed along with it as children cleanup will brin

Re: [Qemu-devel] [PATCH v2 01/10] qom: make user_creatable_complete() specific to UserCreatable

2018-11-01 Thread Igor Mammedov
On Tue, 30 Oct 2018 19:04:44 +0400 Marc-André Lureau wrote: > Instead of accepting any Object*, change user_creatable_complete() to > require a UserCreatable*. Modify the callers to pass the appropriate > argument, removing redundant dynamic cast checks in object creation. > > Signed-off-by: Mar

Re: [Qemu-devel] [PATCH v3 04/13] arm: Instantiate NRF51 random number generator

2018-11-01 Thread Stefan Hajnoczi
On Tue, Oct 30, 2018 at 08:25:18PM -0400, Steffen Görtz wrote: > Use RNG in SOC. > > Signed-off-by: Steffen Görtz > --- > hw/arm/nrf51_soc.c | 16 > include/hw/arm/nrf51_soc.h | 2 ++ > 2 files changed, 18 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Des

Re: [Qemu-devel] [PATCH v3 4/7] range: add some more functions

2018-11-01 Thread Igor Mammedov
On Thu, 1 Nov 2018 11:29:51 +0100 David Hildenbrand wrote: > On 01.11.18 11:00, Igor Mammedov wrote: > > On Tue, 23 Oct 2018 17:23:03 +0200 > > David Hildenbrand wrote: > > > >> Add some more functions that will be used in memory-device context. > >> > >> range_init(): Init using lower bound

[Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-01 Thread Aleksandar Markovic
Hi, Fridrik, I did some closer code inspection of R5900 in last few days, and I noticed some sub-optimal implementation in the area where R5900-specific opcodes overlap with the rest-of-MIPS-CPUs opcodes. The right implementation should be based on the principle that all such cases are covered

Re: [Qemu-devel] [PATCH v3 02/13] arm: Add header to host common definition for nRF51 SOC peripherals

2018-11-01 Thread Julia Suvorova via Qemu-devel
On 31.10.2018 00:25, Steffen Görtz wrote: Adds a header that provides definitions that are used across nRF51 peripherals Signed-off-by: Steffen Görtz --- hw/arm/nrf51_soc.c | 33 ++- include/hw/arm/nrf51.h | 44 in

Re: [Qemu-devel] [PATCH v3 05/13] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories

2018-11-01 Thread Stefan Hajnoczi
On Tue, Oct 30, 2018 at 08:25:19PM -0400, Steffen Görtz wrote: > +static void io_write(void *opaque, hwaddr offset, uint64_t value, > +unsigned int size) > +{ > +NRF51NVMState *s = NRF51_NVM(opaque); > + > +switch (offset) { > +case NRF51_NVMC_CONFIG: > +s->config = valu

Re: [Qemu-devel] [PATCH v2 0/2] test: fw_cfg: add reboot-timeout test case

2018-11-01 Thread Li Qiang
Hello all This is cause because the fixed patch here: -->https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg7.html is not merged ATM. Thanks, Li Qiang 于2018年11月1日周四 下午5:51写道: > Hi, > > This series failed docker-quick@centos7 build test. Please find the > testing commands and > thei

[Qemu-devel] [PULL 0/1] M68k for 3.1 patches

2018-11-01 Thread Laurent Vivier
The following changes since commit 7d51a855cd568ec3399a1834ada4023cfa12f231: Merge remote-tracking branch 'remotes/xtensa/tags/20181030-xtensa' into staging (2018-10-31 16:11:43 +) are available in the Git repository at: git://github.com/vivier/qemu-m68k.git tags/m68k-for-3.1-pull-reque

[Qemu-devel] [PULL 1/1] target/m68k: use EXCP_ILLEGAL instead of EXCP_UNSUPPORTED

2018-11-01 Thread Laurent Vivier
Coldfire defines an "Unsupported instruction" exception if execution of a valid instruction is attempted but the required hardware is not present in the processor. We use it with instructions that are in fact undefined or illegal, and the exception expected in this case by the kernel is the illega

Re: [Qemu-devel] [PULL 0/8] Monitor patches for 2018-10-30

2018-11-01 Thread Peter Maydell
On 30 October 2018 at 19:16, Markus Armbruster wrote: > The following changes since commit 3f3285491dd52014852a56135c90e428c8b507ea: > > Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' > into staging (2018-10-30 14:09:25 +) > > are available in the Git repository at:

Re: [Qemu-devel] [PULL 00/10] Misc patches for 2018-10-30

2018-11-01 Thread Peter Maydell
On 30 October 2018 at 19:50, Paolo Bonzini wrote: > The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: > > Merge remote-tracking branch > 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging > (2018-10-30 15:49:55 +) > > are available in the git r

Re: [Qemu-devel] [PATCH v3 05/13] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories

2018-11-01 Thread Stefan Hajnoczi
On Tue, Oct 30, 2018 at 08:25:19PM -0400, Steffen Görtz wrote: > +static Property nrf51_nvm_properties[] = { > +DEFINE_PROP_UINT32("code_size", NRF51NVMState, code_size, 0x100), I'm a fan of '-' instead of '_' in qdev property names. There are more instances of '-' than '_', but it's up to yo

Re: [Qemu-devel] [PATCH 1/9] qom/user-creatable: add a few helper macros

2018-11-01 Thread Igor Mammedov
On Tue, 30 Oct 2018 20:07:17 -0300 Eduardo Habkost wrote: > On Tue, Oct 30, 2018 at 03:22:43PM +0100, Igor Mammedov wrote: > > On Tue, 30 Oct 2018 13:26:40 +0400 > > Marc-André Lureau wrote: > > > > > Hi > > > > > > On Tue, Oct 30, 2018 at 5:37 AM Eduardo Habkost > > > wrote: > > > > > >

Re: [Qemu-devel] [PATCH v3 07/13] tests: Add bbc:microbit / nRF51 test suite

2018-11-01 Thread Stefan Hajnoczi
On Tue, Oct 30, 2018 at 08:25:21PM -0400, Steffen Görtz wrote: > The microbit-test includes tests for the nRF51 NVMC > peripheral and will host future nRF51 peripheral tests > and board-level bbc:microbit tests. > > Signed-off-by: Steffen Görtz > --- > tests/Makefile.include | 2 + > tests/mic

Re: [Qemu-devel] [PATCH v3 08/13] hw/gpio/nrf51_gpio: Add nRF51 GPIO peripheral

2018-11-01 Thread Stefan Hajnoczi
On Tue, Oct 30, 2018 at 08:25:22PM -0400, Steffen Görtz wrote: > +/* > + * Check if the output driver is connected to the direction switch > + * given the current configuration and logic level. > + * It is not differentiated between standard and "high"(-power) drive modes. > + */ > +static bool is_

Re: [Qemu-devel] [PATCH] ivshmem: fix memory backend leak

2018-11-01 Thread Igor Mammedov
On Thu, 1 Nov 2018 15:02:04 +0400 Marc-André Lureau wrote: > On Thu, Nov 1, 2018 at 2:53 PM Igor Mammedov wrote: > > > > object_new() returns a new backend with refcount == 1 and > > then later object_property_add_child() increases refcount to 2 > > So when ivshmem is desroyed, the backend it ha

Re: [Qemu-devel] [PATCH 3/7] qcow2: split out reading normal clusters from qcow2_co_preadv

2018-11-01 Thread Vladimir Sementsov-Ogievskiy
27.09.2018 20:35, Max Reitz wrote: On 07.08.18 19:43, Vladimir Sementsov-Ogievskiy wrote: Memory allocation may become less efficient for encrypted case. It's a payment for further asynchronous scheme. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qco

Re: [Qemu-devel] [PATCH v3 06/13] arm: Instantiate NRF51 special NVM's and NVMC

2018-11-01 Thread Stefan Hajnoczi
On Tue, Oct 30, 2018 at 08:25:20PM -0400, Steffen Görtz wrote: > Instantiates UICR, FICR and NVMC in nRF51 SOC. > > Signed-off-by: Steffen Görtz > --- > hw/arm/nrf51_soc.c | 37 ++--- > include/hw/arm/nrf51_soc.h | 2 ++ > 2 files changed, 36 insertions(+

Re: [Qemu-devel] [PATCH v1 1/4] target/arm64: properly handle DBGVR RESS bits

2018-11-01 Thread Alex Bennée
Peter Maydell writes: > On 26 September 2018 at 12:20, Alex Bennée wrote: >> This only fails with some (broken) versions of gdb but we should >> treat the top bits of DBGBVR as RESS. As the hardware may have IMPDEF >> approaches to writes to this register we apply the sign extension when >> ch

Re: [Qemu-devel] [PATCH v3 09/13] arm: Instantiate NRF51 general purpose I/O

2018-11-01 Thread Stefan Hajnoczi
On Tue, Oct 30, 2018 at 08:25:23PM -0400, Steffen Görtz wrote: > Instantiates GPIO peripheral model > > Signed-off-by: Steffen Görtz > --- > hw/arm/nrf51_soc.c | 16 > include/hw/arm/nrf51_soc.h | 2 ++ > 2 files changed, 18 insertions(+) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v3 10/13] tests/microbit-test: Add Tests for nRF51 GPIO

2018-11-01 Thread Stefan Hajnoczi
On Tue, Oct 30, 2018 at 08:25:24PM -0400, Steffen Görtz wrote: > The test suite for the nRF51 GPIO peripheral for now > only tests initial state. Additionally a set of > tests testing an implementation detail of the model > are included. > > Signed-off-by: Steffen Görtz > --- > tests/microbit-te

Re: [Qemu-devel] [PATCH v3 13/13] arm: Add Clock peripheral stub to NRF51 SOC

2018-11-01 Thread Stefan Hajnoczi
On Tue, Oct 30, 2018 at 08:25:27PM -0400, Steffen Görtz wrote: > This stubs enables the microbit-micropython firmware to run > on the microbit machine. > > Signed-off-by: Steffen Görtz > --- > hw/arm/nrf51_soc.c | 27 +++ > include/hw/arm/nrf51_soc.h | 1 + > 2 f

Re: [Qemu-devel] [PATCH v3 12/13] arm: Instantiate NRF51 Timers

2018-11-01 Thread Stefan Hajnoczi
On Tue, Oct 30, 2018 at 08:25:26PM -0400, Steffen Görtz wrote: > +/* TIMER */ > +for (i = 0; i < NRF51_NUM_TIMERS; i++) { > +object_property_set_bool(OBJECT(&s->timer[i]), true, "realized", > &err); > +if (err) { > +error_propagate(errp, err); > +ret

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-01 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > > > > On 31 Oct 2018, at 20:59, Dr. David Alan Gilbert > > wrote: > > > > * Liran Alon (liran.a...@oracle.com) wrote: > >> > >> > >>> On 31 Oct 2018, at 20:19, Paolo Bonzini wrote: > >>> > >>> On 31/10/2018 19:17, Eduardo Habkost wrote: >

Re: [Qemu-devel] [PULL v2 0/5] Merge tpm 2018/10/29 v2

2018-11-01 Thread Peter Maydell
On 30 October 2018 at 21:47, Stefan Berger wrote: > This pull request fixes a couple of TPM support related issues, > such as full initialization of a variable to quiet down valgrind, > a possible race in the TPM related test cases and marking test > cases as skipped if swtpm was not found in PATH

Re: [Qemu-devel] [PULL 00/15] Python queue, 2018-10-30

2018-11-01 Thread Peter Maydell
On 31 October 2018 at 00:31, Eduardo Habkost wrote: > Sorry for submitting this at the last minute. > > The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: > > Merge remote-tracking branch > 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging > (2018-

Re: [Qemu-devel] [PATCH v1 2/7] pcihp: overwrite hotplug handler recursively from the start

2018-11-01 Thread Igor Mammedov
On Wed, 24 Oct 2018 12:19:25 +0200 David Hildenbrand wrote: > For now, the hotplug handler is not called for devices that are > being cold plugged. The hotplug handler is setup when the machine > initialization is fully done. Only bridges that were cold plugged are > considered. > > Set the hotp

Re: [Qemu-devel] [PATCH v1 1/7] pcihp: perform check for bus capability in pre_plug handler

2018-11-01 Thread Igor Mammedov
On Wed, 24 Oct 2018 12:19:24 +0200 David Hildenbrand wrote: > Perform the check in the pre_plug handler. In addition, we need the > capability only if the device is actually hotplugged (and not created > during machine initialization). This is a preparation for coldplugging > devices via that hot

Re: [Qemu-devel] [PATCH v1 3/7] pcihp: route unplug via the hotplug handler

2018-11-01 Thread Igor Mammedov
On Wed, 24 Oct 2018 12:19:26 +0200 David Hildenbrand wrote: > Preparation for multi-stage hotplug handlers. Commit message should describe what and why the patch does for the sake of unaware. (I know 'why' right now but will for sure forget all the reasons later) beside of rerouting it also make

Re: [Qemu-devel] [PATCH] tests/bios-tables-test: Sanitize test verbose output

2018-11-01 Thread Peter Maydell
On 1 November 2018 at 14:26, Eric Blake wrote: > Umm, this prints a blank line even if I run 'make check V=0' - do we support > V=0 as a way to disable verbosity Empirically, we do not. Our rules.make defines quiet-command = $(if $(V),$1,$(if $(2),@printf " %-7s %s\n" $2 $3 && $1, @$1)) which w

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-01 Thread Philippe Mathieu-Daudé
Cc'ing Fredrik. On 1/11/18 12:06, Aleksandar Markovic wrote: Hi, Fridrik, I did some closer code inspection of R5900 in last few days, and I noticed some sub-optimal implementation in the area where R5900-specific opcodes overlap with the rest-of-MIPS-CPUs opcodes. The right implementation s

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-01 Thread Emilio G. Cota
Cc'ing Fredrik, who I think was the intended recipient of the below. E. On Thu, Nov 01, 2018 at 11:06:30 +, Aleksandar Markovic wrote: > Hi, Fridrik, > > I did some closer code inspection of R5900 in last few days, and I noticed > some sub-optimal implementation in the area

Re: [Qemu-devel] [PATCH v1 4/7] pci/pcie: route unplug via the hotplug handler

2018-11-01 Thread Igor Mammedov
On Wed, 24 Oct 2018 12:19:27 +0200 David Hildenbrand wrote: > Preparation for multi-stage hotplug handlers. commit message needs a rationale shat/why is done here, especially if it's preliminary refactoring for some future work (which I'd shortly describe here as well). The same applies to patch

Re: [Qemu-devel] [PATCH] tests/bios-tables-test: Sanitize test verbose output

2018-11-01 Thread Eric Blake
On 10/29/18 7:18 PM, Philippe Mathieu-Daudé wrote: Fix the extraneous extra blank lines in the test output when running with V=1. +++ b/tests/bios-tables-test.c @@ -371,6 +371,9 @@ static GArray *load_expected_aml(test_data *data) gboolean ret; GArray *exp_tables = g_array_new(

Re: [Qemu-devel] [PATCH] ivshmem: fix memory backend leak

2018-11-01 Thread Philippe Mathieu-Daudé
On 1/11/18 11:44, Igor Mammedov wrote: object_new() returns a new backend with refcount == 1 and then later object_property_add_child() increases refcount to 2 So when ivshmem is desroyed, the backend it has created isn't ^ "destroyed" destroyed along with it as children

Re: [Qemu-devel] [PATCH v2 09/10] hw/i386: add pc-i440fx-3.1 & pc-q35-3.1

2018-11-01 Thread Igor Mammedov
On Tue, 30 Oct 2018 19:04:52 +0400 Marc-André Lureau wrote: > The following patch is going to add compatiblity parameters. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov > --- > include/hw/i386/pc.h | 2 +- > hw/i386/pc_piix.c| 15

[Qemu-devel] [PATCH] chardev: fix mess in OPENED/CLOSED events when muxed

2018-11-01 Thread Artem Pisarenko
When chardev is multiplexed (mux=on) there are a lot of cases, when CHR_EVENT_OPENED/CHR_EVENT_CLOSED events pairing (expected from frontend side) is broken. There are either generation of multiple repeated or extra CHR_EVENT_OPENED events, or CHR_EVENT_CLOSED just isn't generated at all (when it d

Re: [Qemu-devel] [PATCH v1 0/7] pci: hotplug handler reworks

2018-11-01 Thread Igor Mammedov
On Wed, 31 Oct 2018 18:31:30 +0100 David Hildenbrand wrote: > On 24.10.18 12:19, David Hildenbrand wrote: > > This series reworks some pci hotplug handlers (except for s390, that will > > require more work but is not required for now). > > > > 1. Route all unplug calls via the hotplug handler wh

Re: [Qemu-devel] [PATCH 1/9] qom/user-creatable: add a few helper macros

2018-11-01 Thread Eduardo Habkost
On Thu, Nov 01, 2018 at 01:16:37PM +0100, Igor Mammedov wrote: > On Tue, 30 Oct 2018 20:07:17 -0300 > Eduardo Habkost wrote: > > > On Tue, Oct 30, 2018 at 03:22:43PM +0100, Igor Mammedov wrote: > > > On Tue, 30 Oct 2018 13:26:40 +0400 > > > Marc-André Lureau wrote: > > > > > > > Hi > > > > >

Re: [Qemu-devel] [PULL 0/2] Misc next patches

2018-11-01 Thread Peter Maydell
On 31 October 2018 at 11:36, Daniel P. Berrangé wrote: > The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: > > Merge remote-tracking branch > 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging > (2018-10-30 15:49:55 +) > > are available in the

[Qemu-devel] [PATCH] virtserialport/virtconsole: fix messy opening/closing port

2018-11-01 Thread Artem Pisarenko
This fixes wrong interfacing between virtio serial port and bus models, and corresponding chardev backends, caused extra and incorrect activity during guest boot process (when virtserialport device used). Signed-off-by: Artem Pisarenko --- Notes: Although this doesn't trigger any issue/bug (

  1   2   3   >