Commit 9cbef9d68e (qemu-option: improve qemu_opts_print_help() output)
affected qemu-img help output, and broke this test case.
Update the output reference to fix it.
Signed-off-by: Fam Zheng
---
I'm once again looking at enabling iotests on patchew (via vm based
tests), but immediately got bl
Am 2018-10-30 18:00, schrieb Peter Maydell:
Check the return value from load_image_targphys(), which tells us
whether our attempt to load the BIOS image into RAM failed.
(Spotted by Coverity, CID 1190305.)
Signed-off-by: Peter Maydell
Acked-by: Michael Walle
Will you put it in your queue, P
Am 2018-07-18 12:48, schrieb Michael Walle:
It is only possible to retrieve the current state of an interrupt line.
But
there are devices which just pulses the interrupt line. Introduce a
latch
which is set by qtest and which can be cleared by the test case.
Signed-off-by: Michael Walle
Cc: P
Public bug reported:
Qemu crashed after starting and stopping VM for many times, and the
final log shows below.
qemu-system-x86_64: hw/usb/dev-storage.c:236: usb_msd_send_status: Assertion
`s->csw.sig == cpu_to_le32(0x53425355)' failed.
2018-10-05 15:33:11.261+: shutting down
I got the back
** Tags added: usb
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1800786
Title:
USB assertion `s->csw.sig == cpu_to_le32(0x53425355)' failed
Status in QEMU:
New
Bug description:
Qemu crashed
On Wed, 10/31 16:04, Fam Zheng wrote:
> Commit 9cbef9d68e (qemu-option: improve qemu_opts_print_help() output)
> affected qemu-img help output, and broke this test case.
>
> Update the output reference to fix it.
>
> Signed-off-by: Fam Zheng
>
> ---
>
> I'm once again looking at enabling iotes
On Tue, 30 Oct 2018 20:15:45 -0300
Eduardo Habkost wrote:
> On Tue, Oct 30, 2018 at 06:37:42PM +0100, Philippe Mathieu-Daudé wrote:
> > If I understand correctly, we have this 'state machine':
> >
> >SupportedUnsupported Deprecated
> >
> > (someone to talk) (nobody
On 30/10/2018 22:42, George Kennedy wrote:
> Under heavy IO (e.g. fio) the queue is not checked frequently enough for
> pending commands. As a result some pending commands are timed out by the
> linux sym53c8xx driver, which sends SCSI Abort messages for the timed out
> commands. The SCSI Abort mes
When you clone the repository without previous commit history, 'git://'
doesn't protect from man-in-the-middle attacks. HTTPS is more secure
since the client verifies the server certificate.
Reported-by: Jann Horn
Signed-off-by: Stefan Hajnoczi
---
README | 4 ++--
pc-bios/README | 4 +
When you clone the repository without previous commit history, 'git://'
doesn't protect from man-in-the-middle attacks. HTTPS is more secure
since the client verifies the server certificate.
Reported-by: Jann Horn
Signed-off-by: Stefan Hajnoczi
---
MAINTAINERS | 74 ++--
Jeff Cody has enabled git smart HTTP support on qemu.org. From now on HTTPS is
the preferred protocol because it adds some protection against
man-in-the-middle when cloning a repo.
This patch series updates git:// URLs and changes them to https://. The
https:// URL format is:
https://git.qem
When you clone the repository without previous commit history, 'git://'
doesn't protect from man-in-the-middle attacks. HTTPS is more secure
since the client verifies the server certificate.
Also change git.qemu-project.org to git.qemu.org (we control both domain
names but qemu.org is used more w
When you clone the repository without previous commit history, 'git://'
doesn't protect from man-in-the-middle attacks. HTTPS is more secure
since the client verifies the server certificate.
Reported-by: Jann Horn
Signed-off-by: Stefan Hajnoczi
---
scripts/get_maintainer.pl | 2 +-
1 file chan
ping2
Hi, it's a first step to backup refactoring and improving. Just get rid
of this extra and unnatural synchronization.
19.09.2018 15:43, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> We finally implemented fleecing scheme, create a test case for it (222)
> and even made it safe (f8d59dfb
On 30/10/2018 16:16, Li Qiang wrote:
> Cc: qemu-triv...@nongnu.org
>
> Signed-off-by: Li Qiang
> ---
> include/hw/qdev-core.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
> index a24d0dd566..92851e55df 100644
> --- a/in
The issue was reported as in https://bugs.launchpad.net/qemu/+bug/1793859
When an OpenGL accelerated GTK window is used for iGVT-g DMA Buf device,
window scaling would cause guest cursor to move in undesirable velocity.
To fix this usability issue, the gtk mouse motion events was modified to
sca
Am 31.10.18 um 09:31 schrieb Michael Walle:
> Am 2018-07-18 12:48, schrieb Michael Walle:
>> It is only possible to retrieve the current state of an interrupt
>> line. But
>> there are devices which just pulses the interrupt line. Introduce a latch
>> which is set by qtest and which can be cleared
18.10.2018 13:42, zhenwei pi wrote:
> Function block_latency_histogram_set may return error, but qapi ignore
> this.
> This can be reproduced easily by qmp command:
> virsh qemu-monitor-command INSTANCE
> '{"execute":"x-block-latency-histogram-set",
> "arguments":{"device":"drive-virtio-disk1","b
On Wed, Oct 31, 2018 at 08:43:06AM +, Stefan Hajnoczi wrote:
> When you clone the repository without previous commit history, 'git://'
> doesn't protect from man-in-the-middle attacks. HTTPS is more secure
> since the client verifies the server certificate.
>
> Reported-by: Jann Horn
> Signe
On Wed, Oct 31, 2018 at 08:43:07AM +, Stefan Hajnoczi wrote:
> When you clone the repository without previous commit history, 'git://'
> doesn't protect from man-in-the-middle attacks. HTTPS is more secure
> since the client verifies the server certificate.
>
> Reported-by: Jann Horn
> Signe
On Wed, Oct 31, 2018 at 08:43:08AM +, Stefan Hajnoczi wrote:
> When you clone the repository without previous commit history, 'git://'
> doesn't protect from man-in-the-middle attacks. HTTPS is more secure
> since the client verifies the server certificate.
>
> Reported-by: Jann Horn
> Signe
On Wed, Oct 31, 2018 at 08:43:09AM +, Stefan Hajnoczi wrote:
> When you clone the repository without previous commit history, 'git://'
> doesn't protect from man-in-the-middle attacks. HTTPS is more secure
> since the client verifies the server certificate.
>
> Also change git.qemu-project.or
On Wed, 31 Oct 2018 08:43:08 +
Stefan Hajnoczi wrote:
> When you clone the repository without previous commit history, 'git://'
> doesn't protect from man-in-the-middle attacks. HTTPS is more secure
> since the client verifies the server certificate.
>
> Reported-by: Jann Horn
> Signed-off
On 23.10.18 17:22, David Hildenbrand wrote:
> While working on memory device code, I noticed that specifiying an uint64_t
> on command line does not work in all cases as we always parse an int64_t.
> So I fix that and also cleanup the old int64_t parser.
>
> To be able to fix some overflows in mem
On 18/07/2018 12:48, Michael Walle wrote:
> /**
> + * get_irq_latched:
> + * @num: Interrupt to observe.
> + *
> + * Returns: The latched level of the @num interrupt.
> + */
> +static inline bool get_irq_latched(int num)
> +{
> +return qtest_get_irq_latched(global_qtest, num);
> +}
> +
> +/**
osdep.h should be included first:
CC tests/vhost-user-bridge.o
In file included from /home/elmarco/src/qemu/tests/vhost-user-bridge.c:32:
/home/elmarco/src/qemu/include/qemu/atomic.h:480:1: error: unknown type name
‘int64_t’
int64_t atomic_read_i64(const int64_t *ptr);
^~~
/home/elm
On 10/20/18 9:14 AM, Bastian Koppelmann wrote:
[...]
+static bool trans_fclass_d(DisasContext *ctx, arg_fclass_d *a, uint32_t insn)
+{
+#if defined(TARGET_RISCV64)
+REQUIRE_FPU;
+
+TCGv t0 = tcg_temp_new();
+gen_helper_fclass_d(t0, cpu_fpr[a->rs1]);
+gen_set_gpr(a->rd, t0);
+
Hi Philippe,
On Tue, Oct 30, 2018 at 07:04:15PM +0100, Philippe Mathieu-Daudé wrote:
> > > > > +void acpi_get_pci_holes(Range *hole, Range *hole64)
> > >
> > > ... and this function neither, it should stay in hw/i386/acpi-build.c,
> > > thus
> > > you don't need to modify the prototype and can c
On 10/31/18 11:44 AM, Bastian Koppelmann wrote:
On 10/20/18 9:14 AM, Bastian Koppelmann wrote:
[...]
+static bool trans_fclass_d(DisasContext *ctx, arg_fclass_d *a,
uint32_t insn)
+{
+#if defined(TARGET_RISCV64)
+ REQUIRE_FPU;
+
+ TCGv t0 = tcg_temp_new();
+ gen_helper_fclass_d(t0,
Peter Maydell writes:
> In handle_vec_simd_shli() we have a check:
> if (size > 3 && !is_q) {
> unallocated_encoding(s);
> return;
> }
> However this can never be true, because we calculate
> int size = 32 - clz32(immh) - 1;
> where immh is a 4 bit field which we
On Wed, 24 Oct 2018 11:58:33 +0800
Yi Min Zhao wrote:
> 在 2018/10/24 上午5:25, Cornelia Huck 写道:
> > On Mon, 22 Oct 2018 13:17:34 +0100
> > Thomas Huth wrote:
> >
> >> On 2018-10-22 10:02, Yi Min Zhao wrote:
> >>> Common function measurement block is used to report counters of
> >>> successful
On 10/30/18 9:30 AM, Pavel Dovgalyuk wrote:
> This patch fixes processing of mtmsr instructions in icount mode.
> In this mode writing to interrupt/peripheral state is controlled
> by can_do_io flag. This flag must be set explicitly before helper
> function invocation.
>
> Signed-off-by: Maria Kli
On 10/30/18 4:55 PM, Laurent Vivier wrote:
> Coldfire defines an "Unsupported instruction" exception if execution
> of a valid instruction is attempted but the required hardware is not
> present in the processor.
>
> We use it with instructions that are in fact undefined or illegal,
> and the exce
On 31/10/2018 01:25, Steffen Görtz wrote:
> Adds a new qtest command "set_irq_in" which allows
> to set qemu gpio lines to a given level.
>
> Based on https://lists.gnu.org/archive/html/qemu-devel/2012-12/msg02363.html
> which never got merged.
>
> Signed-off-by: Steffen Görtz
> Originally-by: M
Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20181030114048.21527-1-phi...@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/2] hw/arm/exyn
On 10/31/2018 03:49 AM, Dr. David Alan Gilbert wrote:
* Fei Li (f...@suse.com) wrote:
Add error handling for qemu_ram_foreach_migratable_block() when
it fails.
Always call migrate_set_error() to set the error state without relying
on whether multifd_save_cleanup() succeeds. As the passed &lo
On 10/31/2018 11:41 AM, Marc-André Lureau wrote:
> osdep.h should be included first:
>
> CC tests/vhost-user-bridge.o
> In file included from /home/elmarco/src/qemu/tests/vhost-user-bridge.c:32:
> /home/elmarco/src/qemu/include/qemu/atomic.h:480:1: error: unknown type name
> ‘int64_t’
> i
On 10/31/2018 5:21 AM, Paolo Bonzini wrote:
On 30/10/2018 22:42, George Kennedy wrote:
Under heavy IO (e.g. fio) the queue is not checked frequently enough for
pending commands. As a result some pending commands are timed out by the
linux sym53c8xx driver, which sends SCSI Abort messages for
Signed-off-by: Anton Nefedov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Reviewed-by: Eric Blake
---
qapi/block-core.json | 29 +++--
include/block/accounting.h | 1 +
block/qapi.c | 6 ++
tests/qemu-iotests/227.out |
new in v5:
- new patch 3. Protects from double-accounting IDE trim requests in
ide_handle_rw_error().
- patch 4: move block_acct_invalid() for unmap to ide_issue_trim_cb()
This way it doesn't affect read and write requests.
- patch 7: added missing hunks as suggested by Kevi
Make the stat fields definition slightly more readable.
Also reorder total_time_ns stats read-write-flush as done elsewhere.
Cosmetic change only.
Signed-off-by: Anton Nefedov
---
qapi/block-core.json | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git
Signed-off-by: Anton Nefedov
---
hw/ide/core.c | 12
1 file changed, 12 insertions(+)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 04e22e751d..8da77ff3e3 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -441,6 +441,14 @@ static void ide_issue_trim_cb(void *opaque, int ret)
This adds some protection from accounting unitialized cookie.
That is, block_acct_failed/done without previous block_acct_start;
in that case, cookie probably holds values from previous operation.
(Note: it might also be unitialized holding garbage value and there is
still "< BLOCK_MAX_IOTYPE" as
This will help to identify how many of the user-issued discard operations
(accounted on a device level) have actually suceeded down on the host file
(even though the numbers will not be exactly the same if non-raw format
driver is used (e.g. qcow2 sending metadata discards)).
Note that these numbe
Emilio G. Cota writes:
> Cc: David Gibson
> Cc: Alexander Graf
> Cc: qemu-...@nongnu.org
> Signed-off-by: Emilio G. Cota
Reviewed-by: Alex Bennée
> ---
> target/ppc/translate.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/target/ppc/translate.c b/target/
A block driver can provide a callback to report driver-specific
statistics.
file-posix driver now reports discard statistics
Signed-off-by: Anton Nefedov
---
qapi/block-core.json | 39 +++
include/block/block.h | 1 +
include/block/block_int.h | 1
This will help to account the operation in the following commit.
The difference is that we don't call scsi_disk_req_check_error() before
the 1st discard iteration anymore. That function also checks if
the request is cancelled, however it shouldn't get canceled until it
yields in blk_aio() function
The sheepdog mailing list is setup to stop and queue messages from
non-subscribers, pending moderator approval. Unfortunately it seems
that the moderation queue is not actively deadlt with. Even when messages
are approved, the sender is never added to the whitelist, so every
future mail the same se
In some cases the Author: email address in patches submitted to the
list gets mangled such that it says
John Doe via Qemu-devel
This change is a result of workarounds for DMARC policies.
Subsystem maintainers accepting patches need to catch these and fix
them before sending pull requests, s
Signed-off-by: Anton Nefedov
---
hw/scsi/scsi-disk.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index e132504913..dee71f9dde 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -1663,10 +1663,16 @@ static vo
The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd:
Merge remote-tracking branch
'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging
(2018-10-30 15:49:55 +)
are available in the Git repository at:
https://github.com/berrange/qemu tags/misc-nex
On 31/10/2018 12:29, George Kennedy wrote:
>>> case 2: /* Wait Reselect */
>>> + if (!s->resel_dsp) {
>>> + s->resel_dsp = s->dsp - 8;
>>> + }
>>
>> What is the reason for the "if"?
>
> The save of the Rselection Script address only nee
it allows to report it in the error handler
Signed-off-by: Anton Nefedov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
---
hw/scsi/scsi-disk.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
inde
Emilio G. Cota writes:
> Signed-off-by: Emilio G. Cota
Reviewed-by: Alex Bennée
> ---
> target/alpha/translate.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/target/alpha/translate.c b/target/alpha/translate.c
> index e5d62850c5..25cd95931d 100644
> --- a/
Emilio G. Cota writes:
> And fix the temp leak along the way.
>
> Cc: "Edgar E. Iglesias"
> Signed-off-by: Emilio G. Cota
Reviewed-by: Alex Bennée
> ---
> target/cris/translate.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/target/cris/translate.c b/target
Emilio G. Cota writes:
> Signed-off-by: Emilio G. Cota
Reviewed-by: Alex Bennée
> ---
> target/hppa/translate.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target/hppa/translate.c b/target/hppa/translate.c
> index ce05d5619d..df9179e70f 100644
> --- a/target/
Emilio G. Cota writes:
> Cc: "Edgar E. Iglesias"
> Signed-off-by: Emilio G. Cota
Reviewed-by: Alex Bennée
> ---
> target/microblaze/translate.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index
Emilio G. Cota writes:
> Cc: Laurent Vivier
> Signed-off-by: Emilio G. Cota
Reviewed-by: Alex Bennée
> ---
> target/m68k/translate.c | 9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
> index ae3651b867..d55e
this makes it possible to determine what the exact reason was for
a RESET or a SHUTDOWN
this patch also fixes the iotests
Signed-off-by: Dominik Csapak
---
qapi/run-state.json| 4 ++--
tests/qemu-iotests/060.out | 4 ++--
tests/qemu-iotests/071.out | 4 ++--
tests/qemu-iotests/081.ou
this makes it possible to use the reason as return value
in a QMP event, such as SHUTDOWN
Signed-off-by: Dominik Csapak
---
include/sysemu/sysemu.h | 20
qapi/run-state.json | 33 +
2 files changed, 33 insertions(+), 20 deletions(-)
diff
it is interesting to know whether the shutdown cause was 'quit' or
'reset', especially when using --no-reboot
Signed-off-by: Dominik Csapak
---
qapi/run-state.json | 10 ++
qmp.c | 4 ++--
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/qapi/run-state.json b
This series improves the QMP SHUTDOWN and RESET events by adding
the ShutdownCause as additional parameter and splitting
the HOST_QMP reason into HOST_QMP_QUIT and HOST_QMP_SYSTEM_RESET
to be able to detect the difference between them when using '--no-reboot'
this is an alternative to my previous
Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20181029232100.8454-1-phi...@redhat.com
Subject: [Qemu-devel] [PATCH 0/3] hw/arm/exynos4:
Emilio G. Cota writes:
> Signed-off-by: Emilio G. Cota
Reviewed-by: Alex Bennée
> ---
> accel/tcg/tcg-runtime.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/accel/tcg/tcg-runtime.c b/accel/tcg/tcg-runtime.c
> index 4aa038465f..70e3c9de71 100644
> --- a/accel/tcg
On Tue, Oct 30, 2018 at 12:35:15PM +, Aleksandar Markovic wrote:
> Perhaps checkpatch.pl should make sure the commit messages do not contain
> "address@hidden" and "Reviewed-off-by"?
>
> $ git log | grep address@hidden
> Signed-off-by: Michael S. Tsirkin
> Signed-off-by: Ronald Hecht
Emilio G. Cota writes:
> cpu->halted will soon be protected by cpu->lock.
> We will use these helpers to ease the transition,
> since right now cpu->halted has many direct callers.
>
> Reviewed-by: Richard Henderson
> Signed-off-by: Emilio G. Cota
Reviewed-by: Alex Bennée
> ---
> include/
All three patches have appeared on list before, though not all
at once in the same series. This is all cleanup suggested by
the ongoing risc-v work.
r~
Richard Henderson (3):
decodetree: Add !extern flag to argument sets
decodetree: Remove "insn" argument from trans_* expanders
decodetre
Allow argument sets to be shared between two decoders by avoiding
a re-declaration error. Make sure that anonymous argument sets
and anonymous formats have unique names.
Reviewed-by: Bastian Koppelmann
Signed-off-by: Richard Henderson
---
scripts/decodetree.py | 34 +++-
While it would be possible to concatenate input files with make,
passing the original input files to decodetree.py allows us to
generate error messages which allows compilation environments
(read: emacs) to next-error to the correct input file.
Signed-off-by: Richard Henderson
---
scripts/decode
Emilio G. Cota writes:
> Cc: Andrzej Zaborowski
> Cc: Peter Maydell
> Cc: qemu-...@nongnu.org
> Reviewed-by: Richard Henderson
> Signed-off-by: Emilio G. Cota
Reviewed-by: Alex Bennée
> ---
> hw/arm/omap1.c| 4 ++--
> hw/arm/pxa2xx_gpio.c | 2 +-
> hw/arm/pxa2xx_pic.c
This allows trans_* expanders to be shared between decoders
for 32 and 16-bit insns, by not tying the expander to the
size of the insn that produced it.
This change requires adjusting the two existing users to match.
Signed-off-by: Richard Henderson
---
target/arm/translate-sve.c | 507 +++
tags/pull-tcg-20181031
for you to fetch changes up to ab6511053015b9cc636915e2c2b97305cbf044f0:
cputlb: Remove tlb_c.pending_flushes (2018-10-31 12:16:39 +)
Track mmu_idx for which the TLB is clean and need not be flu
Protect it with the tlb_lock instead of using atomics.
The move puts it in or near the same cacheline as the lock;
using the lock means we don't need a second atomic operation
in order to perform the update. Which makes it cheap to also
update pending_flush in tlb_flush_by_mmuidx_async_work.
Test
The bugs this was working around were fixed with commits
022d6378c7fd target/unicore32: remove tlb_flush from uc32_init_fn
6e11beecfde0 target/alpha: remove tlb_flush from alpha_cpu_initfn
Tested-by: Emilio G. Cota
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
accel/tcg/cp
This is the first of several moves to reduce the size of the
CPU_COMMON_TLB macro and improve some locality of refernce.
Tested-by: Emilio G. Cota
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
include/exec/cpu-defs.h | 17 ---
accel/tcg/cputlb.c | 48 +++
The difference between the two sets of APIs is now miniscule.
Tested-by: Emilio G. Cota
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
accel/tcg/cputlb.c | 58 ++
1 file changed, 12 insertions(+), 46 deletions(-)
diff --git a/accel
The difference between the two sets of APIs is now miniscule.
This allows tlb_flush, tlb_flush_all_cpus, and tlb_flush_all_cpus_synced
to be merged with their corresponding by_mmuidx functions as well. For
accounting, consider mmu_idx_bitmask = ALL_MMUIDX_BITS to be a full flush.
Tested-by: Emil
The set of large pages in the kernel is probably not the same
as the set of large pages in the application. Forcing one
range to cover both will flush more often than necessary.
This allows tlb_flush_page_async_work to flush just the one
mmu_idx implicated, which in turn allows us to remove
tlb_c
This is essentially redundant with tlb_c.dirty.
Tested-by: Emilio G. Cota
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
include/exec/cpu-defs.h | 6 --
accel/tcg/cputlb.c | 16 ++--
2 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/include
Especially for guests with large numbers of tlbs, like ARM or PPC,
we may well not use all of them in between flush operations.
Remember which tlbs have been used since the last flush, and
avoid any useless flushing.
Tested-by: Emilio G. Cota
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard He
On 25/10/2018 16:45, Emilio G. Cota wrote:
> Cc: Laurent Vivier
> Signed-off-by: Emilio G. Cota
> ---
> target/m68k/translate.c | 9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Laurent Vivier
Our only statistic so far was "full" tlb flushes, where all mmu_idx
are flushed at the same time.
Now count "partial" tlb flushes where sets of mmu_idx are flushed,
but the set is not maximal. Account one per mmu_idx flushed, as
that is the unit of work performed.
We don't actually count elided
The rest of the tlb victim cache is per-tlb,
the next use index should be as well.
Tested-by: Emilio G. Cota
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
include/exec/cpu-defs.h | 5 +++--
accel/tcg/cputlb.c | 5 ++---
2 files changed, 5 insertions(+), 5 deletions(-)
On 25/10/2018 16:45, Emilio G. Cota wrote:
> Cc: Laurent Vivier
> Reviewed-by: Richard Henderson
> Signed-off-by: Emilio G. Cota
> ---
> target/m68k/op_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Laurent Vivier
On 10/31/2018 06:18 AM, Peter Xu wrote:
On Tue, Oct 30, 2018 at 06:05:18PM +0800, Fei Li wrote:
[...]
@@ -1366,6 +1373,10 @@ bool multifd_recv_new_channel(QIOChannel *ioc)
QEMU_THREAD_JOINABLE);
atomic_inc(&multifd_recv_state->count);
return multifd_r
On 25/10/2018 16:46, Emilio G. Cota wrote:
> Cc: Laurent Vivier
> Reviewed-by: Richard Henderson
> Signed-off-by: Emilio G. Cota
> ---
> target/m68k/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Laurent Vivier
Hi Laurent,
thank you for your remarks! I have fixed the documentation (also added some
explanation for the fields) and switched to int/qemu_strtoi with base=0.
Steffen
Reviewed-by: Richard Henderson
Signed-off-by: Bastian Koppelmann
Signed-off-by: Peer Adelt
---
v2 -> v3:
- moved 64-bit only insn to insn64.decode
- dropped insn argument of trans_foo functions
target/riscv/insn32.decode | 10 +++
target/riscv/insn64.decode |
Signed-off-by: Bastian Koppelmann
Signed-off-by: Peer Adelt
---
v2 -> v3:
- split into two patches for RV32 and RV64
- dropped insn argument of trans_foo functions
target/riscv/insn32.decode | 10
target/riscv/insn_trans/trans_rvi.inc.c | 64 +
Reviewed-by: Richard Henderson
Signed-off-by: Bastian Koppelmann
Signed-off-by: Peer Adelt
---
v2 -> v3:
- removed %pred/%succ
- dropped insn argument of trans_foo functions
target/riscv/insn32.decode | 2 ++
target/riscv/insn_trans/trans_rvi.inc.c | 21 ++
Reviewed-by: Richard Henderson
Signed-off-by: Bastian Koppelmann
Signed-off-by: Peer Adelt
---
v2 -> v3:
- dropped insn argument of trans_foo functions
target/riscv/insn32.decode | 35 +++
target/riscv/insn_trans/trans_rvf.inc.c | 334
target/riscv/tr
this splits the 64-bit only instructions into its own decode file such
that we generate the decoder for these instructions only for the RISC-V
64 bit target.
Signed-off-by: Bastian Koppelmann
Signed-off-by: Peer Adelt
---
target/riscv/Makefile.objs | 8 +---
target/riscv/insn6
we cannot remove the call to gen_arith() in decode_RV32_64G() since it
is used to translate multiply instructions.
Signed-off-by: Bastian Koppelmann
Signed-off-by: Peer Adelt
---
v2 -> v3:
- moved 64-bit only insn to insn64.decode
- dropped insn argument of trans_foo functions
target/r
Reviewed-by: Richard Henderson
Signed-off-by: Bastian Koppelmann
Signed-off-by: Peer Adelt
---
v2 -> v3:
- dropped insn argument of trans_foo functions
target/riscv/insn32.decode | 17 +++
target/riscv/insn_trans/trans_rva.inc.c | 145
target/riscv/tr
only a translate functions of rvc need to handle special cases. For
the other rvc instruction we can remove the extra layer of indirection.
Signed-off-by: Bastian Koppelmann
---
target/riscv/insn16.decode | 37 +--
target/riscv/insn_trans/trans_rvc.inc.c | 48 ---
Reviewed-by: Richard Henderson
Signed-off-by: Bastian Koppelmann
Signed-off-by: Peer Adelt
---
v2 -> v3:
- dropped insn argument of trans_foo functions
target/riscv/insn32.decode | 8 +++
target/riscv/insn_trans/trans_rvi.inc.c | 79 +
target/riscv/tra
Reviewed-by: Palmer Dabbelt
Reviewed-by: Richard Henderson
Signed-off-by: Bastian Koppelmann
Signed-off-by: Peer Adelt
---
v2 -> v3:
- dropped insn argument of trans_foo functions
- removal of AUIPC moved to 0002
- &branch -> &b
target/riscv/insn32.decode | 19 +++
Reviewed-by: Richard Henderson
Signed-off-by: Bastian Koppelmann
Signed-off-by: Peer Adelt
---
v2 -> v3:
- moved 64-bit only insn to insn64.decode
- dropped insn argument of trans_foo functions
target/riscv/insn64.decode | 13 +++
target/riscv/insn_trans/trans_rva.inc.c |
CPURISCVState is rarely used, so there is no need to pass it to every
translate function. This paves the way for decodetree which only passes
DisasContext to translate functions.
Reviewed-by: Palmer Dabbelt
Signed-off-by: Bastian Koppelmann
---
target/riscv/translate.c | 15 ---
1 f
Reviewed-by: Richard Henderson
Signed-off-by: Bastian Koppelmann
Signed-off-by: Peer Adelt
---
target/riscv/insn_trans/trans_rvi.inc.c | 78 +
target/riscv/translate.c| 59 ++-
2 files changed, 85 insertions(+), 52 deletions(-)
diff --git
1 - 100 of 342 matches
Mail list logo
