Re: [Qemu-devel] [RFC v3 25/56] exec: use cpu_reset_interrupt

2018-10-22 Thread Emilio G. Cota
On Sun, Oct 21, 2018 at 14:17:01 +0100, Richard Henderson wrote: > On 10/19/18 2:05 AM, Emilio G. Cota wrote: > > -cpu->interrupt_request &= ~0x01; > > +cpu_reset_interrupt(cpu, ~0x01); > > cpu_reset_interrupt(cpu, 1); Ouch. Fixed. > Although this is during vmload, and I'm not sure what

Re: [Qemu-devel] [PATCH] vga_int: remove unused function protype

2018-10-22 Thread Philippe Mathieu-Daudé
On 22/10/18 10:00, yuchenlin--- via Qemu-devel wrote: From: yuchenlin Signed-off-by: yuchenlin Reviewed-by: Philippe Mathieu-Daudé --- hw/display/vga_int.h | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h index 6e4fa48a79..55c418eab5 100644

Re: [Qemu-devel] [PATCH v4 2/3] audio: use object link instead of qdev property to pass wm8750 reference

2018-10-22 Thread Philippe Mathieu-Daudé
On 22/10/18 9:40, Mao Zhongyi wrote: According to qdev-properties.h, properties of pointer type should be avoided, it seems a link type property is a good substitution. Cc: Jan Kiszka Cc: Peter Maydell Cc: Gerd Hoffmann Signed-off-by: Mao Zhongyi Reviewed-by: Philippe Mathieu-Daudé ---

Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R5900

2018-10-22 Thread Philippe Mathieu-Daudé
On Mon, Oct 22, 2018 at 3:34 PM Aleksandar Markovic wrote: > > From: Fredrik Noring > > Subject: [PATCH v8 00/38] target/mips: Limited support for the R5900 > > > I experienced some build errors (see the end of this mail), so I had to > exclude some patches, but all others are fine, and had my "

Re: [Qemu-devel] [RFC v3 37/56] mips: convert to cpu_interrupt_request

2018-10-22 Thread Emilio G. Cota
On Sun, Oct 21, 2018 at 14:30:20 +0100, Richard Henderson wrote: > On 10/19/18 2:06 AM, Emilio G. Cota wrote: > > @@ -60,7 +60,7 @@ static bool mips_cpu_has_work(CPUState *cs) > > /* Prior to MIPS Release 6 it is implementation dependent if > > non-enabled > > interrupts wake-up the C

Re: [Qemu-devel] [PATCH 0/2] target/mips: Two corrections

2018-10-22 Thread Philippe Mathieu-Daudé
On Mon, Oct 22, 2018 at 1:59 PM Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > This small series adds two corrections for issues reported recently. > > Aleksandar Markovic (2): > target/mips: Fix the title of translate.c > target/mips: Fix decoding of ALIGN and DALIGN instructio

Re: [Qemu-devel] [PATCH] vhost-scsi: prevent using uninitialized vqs

2018-10-22 Thread Philippe Mathieu-Daudé
On 22/10/18 4:17, yuchenlin via Qemu-devel wrote: Ping? On 2018-10-12 17:07, yuchen...@synology.com wrote: From: yuchenlin There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device, but seabios will only set the physical address for the 3rd one (cmd). Then in vhost_virtqueue_start()

Re: [Qemu-devel] [PATCH v6 07/11] authz: add QAuthZSimple object type for easy whitelist auth checks

2018-10-22 Thread Philippe Mathieu-Daudé
On 19/10/18 15:38, Daniel P. Berrangé wrote: In many cases a single VM will just need to whilelist a single identity as the allowed user of network services. This is especially the case for TLS live migration (optionally with NBD storage) where we just need to whitelist the x509 certificate disti

Re: [Qemu-devel] [RFC v3 46/56] accel/tcg: convert to cpu_interrupt_request

2018-10-22 Thread Emilio G. Cota
On Sun, Oct 21, 2018 at 14:34:25 +0100, Richard Henderson wrote: > On 10/19/18 2:06 AM, Emilio G. Cota wrote: > > @@ -540,16 +540,16 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, > > */ > > atomic_mb_set(&cpu->icount_decr.u16.high, 0); > > > > -if (unlikely(atomic_read(

Re: [Qemu-devel] [PATCH v6 09/11] authz: add QAuthZListFile object type for a file access control list

2018-10-22 Thread Philippe Mathieu-Daudé
On 19/10/18 15:38, Daniel P. Berrangé wrote: Add a QAuthZListFile object type that implements the QAuthZ interface. This built-in implementation is a proxy around the QAtuhZList object type, initializing it from an external file, and optionally, automatically reloading it whenever it changes. To

Re: [Qemu-devel] [PATCH v4 10/11] dp8393x: manage big endian bus

2018-10-22 Thread Philippe Mathieu-Daudé
On Thu, Oct 18, 2018 at 8:43 PM Mark Cave-Ayland wrote: > > From: Laurent Vivier > > This is needed by Quadra 800, this card can run on little-endian > or big-endian bus. > > Signed-off-by: Laurent Vivier > Tested-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/dp839

Re: [Qemu-devel] [PATCH v7 2/3] Acceptance tests: add make rule for running them

2018-10-22 Thread Philippe Mathieu-Daudé
On 18/10/18 17:31, Cleber Rosa wrote: The acceptance (aka functional, aka Avocado-based) tests are Python files located in "tests/acceptance" that need to be run with the Avocado libs and test runner. Let's provide a convenient way for QEMU developers to run them, by making use of the tests-venv

[Qemu-devel] [Bug 1799200] Re: null pointer dereference in tcg_emit_op

2018-10-22 Thread Emilio G. Cota
1. You're leaking the "ptr" TCG temp. Fix it, and also test your code with the --enable-debug-tcg configure flag. 2. Don't insert your helper in .insn_start; you'll have better luck in .translate_insn. -- You received this bug notification because you are a member of qemu- devel-ml, which is su

Re: [Qemu-devel] [RFC v3 46/56] accel/tcg: convert to cpu_interrupt_request

2018-10-22 Thread Richard Henderson
On 10/23/18 12:50 AM, Emilio G. Cota wrote: > On Sun, Oct 21, 2018 at 14:34:25 +0100, Richard Henderson wrote: >> On 10/19/18 2:06 AM, Emilio G. Cota wrote: >>> @@ -540,16 +540,16 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, >>> */ >>> atomic_mb_set(&cpu->icount_decr.u16.hig

[Qemu-devel] [PATCH] usb: ohci: make num_ports to an unsinged integer

2018-10-22 Thread Li Qiang
This can avoid setting OCHIState.num_ports to a negative num. Signed-off-by: Li Qiang --- hw/usb/hcd-ohci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index 66656a1..c34cf5b 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.

[Qemu-devel] [Bug 1799200] Re: null pointer dereference in tcg_emit_op

2018-10-22 Thread wwb1234
Hi Emilio G. Cota (cota), for point 1, I don't know what you mean about leaking the ptr TCG temp for point 2. what I want to do is call callback function when execute every guest instructions so I think it's not should inset code in .translate_insn. what do you think about it? -- You receiv

[Qemu-devel] [Bug 1799200] Re: null pointer dereference in tcg_emit_op

2018-10-22 Thread wwb1234
Hi Emilio G. Cota (cota), thank you, after I free the "ptr",there is no crash occur :) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1799200 Title: null pointer dereference in tcg_emit_op Stat

Re: [Qemu-devel] [PATCH v1] arm: check bit index before usage

2018-10-22 Thread P J P
+-- On Tue, 23 Oct 2018, Philippe Mathieu-Daudé wrote --+ | > From: Prasad J Pandit | > | > Update v1: use ARRAY_SIZE macro | >-> https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg04826.html | > | > -qemu_set_irq(s->handler[bit], (level >> bit) & 1); | > +if (bit < ARR

Re: [Qemu-devel] [PATCH] file-posix: Use error API properly

2018-10-22 Thread Markus Armbruster
Fam Zheng writes: > Use error_report for situations that affect user operation (i.e. we're > actually returning error), and warn_report/warn_report_err when some > less critical error happened but the user operation can still carry on. > > Suggested-by: Markus Armbruster > Signed-off-by: Fam Zh

[Qemu-devel] [Bug 1364501] Re: Gdb hangs when trying to single-step after an invalid instruction

2018-10-22 Thread Thomas Huth
** Changed in: qemu Status: Expired => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1364501 Title: Gdb hangs when trying to single-step after an invalid instruction Status in QEMU:

Re: [Qemu-devel] [PATCH v4 01/11] hw/m68k: add via support

2018-10-22 Thread Thomas Huth
On 2018-10-18 19:28, Mark Cave-Ayland wrote: > From: Laurent Vivier > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > --- [...] > diff --git a/hw/misc/mac_via.c b/hw/misc/mac_via.c > new file mode 100644 > index 00..084974a24d > -

Re: [Qemu-devel] [PATCH v4 02/11] hw/m68k: implement ADB bus support for via

2018-10-22 Thread Thomas Huth
On 2018-10-18 19:28, Mark Cave-Ayland wrote: > From: Laurent Vivier > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > --- > hw/input/adb.c| 2 + > hw/misc/mac_via.c | 166 > +

<    1   2   3