On 2018年10月11日 22:08, w...@redhat.com wrote:
From: Wei Xu
Signed-off-by: Wei Xu
---
hw/virtio/virtio.c | 126 +++--
1 file changed, 123 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index d12a7e3..1d257
Do you know how to use "git bisect"? If so, could you maybe try to
bisect which commit between v2.12.0 and v3.0.0 introduced this problem?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1795148
Title:
On Mon, Oct 15, 2018 at 11:18:05AM +0800, Jason Wang wrote:
>
>
> On 2018年10月11日 22:08, w...@redhat.com wrote:
> >From: Wei Xu
> >
> >Basic initialization and helpers for packed ring.
> >
> >Signed-off-by: Wei Xu
> >---
> > hw/virtio/virtio.c | 57
> > +
On 2018-10-15 08:51, Mao Zhongyi wrote:
> Various shell files contain a mix between obsolete `` and
> modern $(); use of `` is only required when using /bin/sh
> on Solaris. It would be nice to convert to using $()
> everywhere, or at least in all bash scripts, as well as in
> all scripts that are
>>> This occurs in practice routinely for POWER KVM systems, since both host
>>> and guest typically use 64kiB pages.
>>>
>>> To make this safe, without breaking that useful case, we need to
>>> accumulate 4kiB balloon requests until we have a whole contiguous host page
>>> at which point we can di
On 2018-10-15 08:51, Mao Zhongyi wrote:
> Various shell files contain a mix between obsolete `` and
> modern $(); use of `` is only required when using /bin/sh
> on Solaris. It would be nice to convert to using $()
> everywhere, or at least in all bash scripts, as well as in
> all scripts that are
On Mon, Oct 15, 2018 at 11:10:12AM +0800, Jason Wang wrote:
>
>
> On 2018年10月11日 22:08, w...@redhat.com wrote:
> >From: Wei Xu
> >
> >Expand 1.0 by adding offset calculation accordingly.
>
> This is only part of what this patch did and I suggest to another patch to
> do this.
>
> >
> >Signed-o
On 2018-10-15 08:51, Mao Zhongyi wrote:
> Various shell files contain a mix between obsolete `` and
> modern $(); use of `` is only required when using /bin/sh
> on Solaris. It would be nice to convert to using $()
> everywhere, or at least in all bash scripts, as well as in
> all scripts that are
On 12/10/2018 16:21, Igor Mammedov wrote:
> On Fri, 12 Oct 2018 10:45:41 +0200
> David Hildenbrand wrote:
>
>>>
>>> The correct order should be opposite to one that created a devices,
>>> i.e. unplug -> unrealize -> delete.
>>> Doing unplug stuff after device was unrealized looks outright wrong
>
On Mon, Oct 15, 2018 at 11:03:52AM +0800, Jason Wang wrote:
>
>
> On 2018年10月11日 22:08, w...@redhat.com wrote:
> >From: Wei Xu
> >
> >Redefine packed ring structure according to qemu nomenclature,
> >also supported data(event index, wrap counter, etc) are introduced.
> >
> >Signed-off-by: Wei Xu
On 10/15/18 3:07 PM, Thomas Huth wrote:
On 2018-10-15 08:51, Mao Zhongyi wrote:
Various shell files contain a mix between obsolete `` and
modern $(); use of `` is only required when using /bin/sh
on Solaris. It would be nice to convert to using $()
everywhere, or at least in all bash scripts,
On 2018年10月11日 22:08, w...@redhat.com wrote:
From: Wei Xu
With the support of marking a descriptor used/unused in 'flags'
field for 1.1, the current way of filling a chained descriptors
does not work since driver side may get the wrong 'num_buffer'
information in case of the head descriptor
On 2018年10月11日 22:08, w...@redhat.com wrote:
From: Wei Xu
(cherry picked from commit 305a2c4640c15c5717245067ab937fd10f478ee6)
Signed-off-by: Wei Xu
(cherry picked from commit 46476dae6f44c6fef8802a4a0ac7d0d79fe399e3)
Signed-off-by: Wei Xu
The cherry-pick tag looks odd.
---
hw/virtio
On 2018年10月15日 15:09, Wei Xu wrote:
-hwaddr virtio_queue_get_avail_size(VirtIODevice *vdev, int n)
+hwaddr virtio_queue_get_driver_size(VirtIODevice *vdev, int n)
{
-return offsetof(VRingAvail, ring) +
-sizeof(uint16_t) * vdev->vq[n].vring.num;
+int s;
+
+if (virtio_vdev_
Fei Li writes:
> Add a new Error parameter for vnc_display_init() to handle errors
> in its caller: vnc_init_func(), just like vnc_display_open() does.
> And let its callees propagate the Error, like init_keyboard_layout().
>
> Signed-off-by: Fei Li
> ---
> include/ui/console.h | 2 +-
> ui/cu
On Mon, Oct 15, 2018 at 03:45:46PM +0800, Jason Wang wrote:
>
>
> On 2018年10月11日 22:08, w...@redhat.com wrote:
> >From: Wei Xu
> >
> >With the support of marking a descriptor used/unused in 'flags'
> >field for 1.1, the current way of filling a chained descriptors
> >does not work since driver s
On 2018年10月15日 15:26, Wei Xu wrote:
On Mon, Oct 15, 2018 at 11:03:52AM +0800, Jason Wang wrote:
On 2018年10月11日 22:08, w...@redhat.com wrote:
From: Wei Xu
Redefine packed ring structure according to qemu nomenclature,
also supported data(event index, wrap counter, etc) are introduced.
Sig
Thomas Huth writes:
> On 2018-10-15 08:51, Mao Zhongyi wrote:
>> Various shell files contain a mix between obsolete `` and
>> modern $(); use of `` is only required when using /bin/sh
>> on Solaris. It would be nice to convert to using $()
>> everywhere, or at least in all bash scripts, as well a
On 2018年10月15日 16:03, Wei Xu wrote:
On Mon, Oct 15, 2018 at 03:45:46PM +0800, Jason Wang wrote:
On 2018年10月11日 22:08, w...@redhat.com wrote:
From: Wei Xu
With the support of marking a descriptor used/unused in 'flags'
field for 1.1, the current way of filling a chained descriptors
does no
On Mon, Oct 15, 2018 at 03:50:21PM +0800, Jason Wang wrote:
>
>
> On 2018年10月11日 22:08, w...@redhat.com wrote:
> >From: Wei Xu
> >
> >(cherry picked from commit 305a2c4640c15c5717245067ab937fd10f478ee6)
> >Signed-off-by: Wei Xu
> >(cherry picked from commit 46476dae6f44c6fef8802a4a0ac7d0d79fe39
On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote:
> The current virtio-*-pci device types actually represent 3
> different types of devices:
> * virtio 1.0 non-transitional devices
> * virtio 1.0 transitional devices
Ok.
> * virtio 0.9 ("legacy device" in virtio 1.0 terminology)
W
On Mon, Oct 15, 2018 at 02:59:48PM +0800, Jason Wang wrote:
>
>
> On 2018年10月11日 22:08, w...@redhat.com wrote:
> >From: Wei Xu
> >
> >Signed-off-by: Wei Xu
> >---
> > hw/virtio/virtio.c | 126
> > +++--
> > 1 file changed, 123 insertions(+), 3 d
On 14/10/2018 16:55, Artem Pisarenko wrote:
> Attributes are simple flags, associated with individual timers for their
> whole lifetime.
> They intended to be used to mark individual timers for special handling by
> various qemu features operating at qemu core level.
> Existing timer, aio and cor
Ping?
Paolo, what do you think about upstreaming this before soft freeze?
Pavel Dovgalyuk
> -Original Message-
> From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru]
> Sent: Wednesday, October 10, 2018 4:34 PM
> To: qemu-devel@nongnu.org
> Cc: peter.mayd...@linaro.org; war2jor...@liv
The following changes since commit a73549f99612f758dec0fdea6ae1c30b6c709a0b:
Merge remote-tracking branch 'remotes/kraxel/tags/ui-20181012-pull-request'
into staging (2018-10-12 16:45:51 +0100)
are available in the git repository at:
https://github.com/jasowang/qemu.git tags/net-pull-reques
From: Zhang Chen
During the time of VM's running, PVM may dirty some pages, we will transfer
PVM's dirty pages to SVM and store them into SVM's RAM cache at next checkpoint
time. So, the content of SVM's RAM cache will always be same with PVM's memory
after checkpoint.
Instead of flushing all co
From: Zhang Chen
We record the address of the dirty pages that received,
it will help flushing pages that cached into SVM.
Here, it is a trick, we record dirty pages by re-using migration
dirty bitmap. In the later patch, we will start the dirty log
for SVM, just like migration, in this way, we
From: Zhang Chen
It's a good idea to use notifier to notify COLO frame of
inconsistent packets comparing.
Signed-off-by: Zhang Chen
Signed-off-by: Zhang Chen
Signed-off-by: zhanghailiang
Signed-off-by: Jason Wang
---
net/colo-compare.c | 37 ++---
net/colo-co
From: Zhang Chen
While do checkpoint, we need to flush all the unhandled packets,
By using the filter notifier mechanism, we can easily to notify
every compare object to do this process, which runs inside
of compare threads as a coroutine.
Signed-off-by: zhanghailiang
Signed-off-by: Zhang Chen
From: Zhang Chen
We add almost full TCP state machine in filter-rewriter, except
TCPS_LISTEN and some simplify in VM active close FIN states.
The reason for this simplify job is because guest kernel will track
the TCP status and wait 2MSL time too, if client resend the FIN packet,
guest will rese
From: Zhang Chen
Suggested by Markus Armbruster rename COLO unknown mode to none mode.
Signed-off-by: Zhang Chen
Signed-off-by: Zhang Chen
Reviewed-by: Eric Blake
Reviewed-by: Markus Armbruster
Signed-off-by: Jason Wang
---
migration/colo-failover.c | 2 +-
migration/colo.c | 2
From: Zhang Chen
Make sure master start block replication after slave's block
replication started.
Besides, we need to activate VM's blocks before goes into
COLO state.
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Signed-off-by: Zhang Chen
Signed-off-by: Zhang Chen
Signed-off-by:
From: Zhang Chen
There are several stages during loadvm/savevm process. In different stage,
migration incoming processes different types of sections.
We want to control these stages more accuracy, it will benefit COLO
performance, we don't have to save type of QEMU_VM_SECTION_START
sections every
From: zhanghailiang
Notify all net filters about the checkpoint and failover event.
Signed-off-by: zhanghailiang
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Jason Wang
---
migration/colo.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/migration/colo.c b/migratio
From: Zhang Chen
For COLO FT, both the PVM and SVM run at the same time,
only sync the state while it needs.
So here, let SVM runs while not doing checkpoint, change
DEFAULT_MIGRATE_X_CHECKPOINT_DELAY to 200*100.
Besides, we forgot to release colo_checkpoint_semd and
colo_delay_timer, fix them
From: zhanghailiang
If some errors happen during VM's COLO FT stage, it's important to
notify the users of this event. Together with 'x-colo-lost-heartbeat',
Users can intervene in COLO's failover work immediately.
If users don't want to get involved in COLO's failover verdict,
it is still necess
From: zhanghailiang
COLO thread may sleep at qemu_sem_wait(&s->colo_checkpoint_sem),
while failover works begin, It's better to wakeup it to quick
the process.
Signed-off-by: zhanghailiang
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Jason Wang
---
migration/colo.c | 8
1 file
From: Zhang Chen
After one round of checkpoint, the states between PVM and SVM
become consistent, so it is unnecessary to adjust the sequence
of net packets for old connections, besides, while failover
happens, filter-rewriter will into failover mode that needn't
handle the new TCP connection.
S
In pcnet_receive(), we try to assign size_ to size which converts from
size_t to integer. This will cause troubles when size_ is greater
INT_MAX, this will lead a negative value in size and it can then pass
the check of size < MIN_BUF_SIZE which may lead out of bound access
for both buf and buf1.
From: Zhang Chen
Filter needs to process the event of checkpoint/failover or
other event passed by COLO frame.
Signed-off-by: zhanghailiang
Signed-off-by: Zhang Chen
Signed-off-by: Zhang Chen
Signed-off-by: Jason Wang
---
include/net/filter.h | 5 +
net/filter.c | 17 ++
From: Zhang Chen
Libvirt or other high level software can use this command query colo status.
You can test this command like that:
{'execute':'query-colo-status'}
Signed-off-by: Zhang Chen
Signed-off-by: Zhang Chen
Signed-off-by: Jason Wang
---
migration/colo.c| 21 +
From: Zhang Chen
We should not load PVM's state directly into SVM, because there maybe some
errors happen when SVM is receving data, which will break SVM.
We need to ensure receving all data before load the state into SVM. We use
an extra memory to cache these data (PVM's ram). The ram cache in
There should not be a reason for passing a packet size greater than
INT_MAX. It's usually a hint of bug somewhere, so ignore packet size
greater than INT_MAX in qemu_deliver_packet_iov()
CC: qemu-sta...@nongnu.org
Reported-by: Daniel Shapira
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Jason W
From: zhanghailiang
Don't need to flush all VM's ram from cache, only
flush the dirty pages since last checkpoint
Signed-off-by: Li Zhijian
Signed-off-by: Zhang Chen
Signed-off-by: Zhang Chen
Signed-off-by: zhanghailiang
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Jason Wang
---
mi
From: Zhang Chen
This diagram make user better understand COLO.
Suggested by Markus Armbruster.
Signed-off-by: Zhang Chen
Signed-off-by: Zhang Chen
Signed-off-by: Jason Wang
---
docs/COLO-FT.txt | 34 ++
1 file changed, 34 insertions(+)
diff --git a/docs/COLO
Fixes: CID 1395986
Fixes: 979f7ef8966bc4495a710ed9e4af42098f92ee79
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20181005134608.1251-1-kra...@redhat.com
---
hw/display/qxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/qxl.c b/hw/d
On 14/10/2018 16:55, Artem Pisarenko wrote:
> +qemu_mutex_lock(&timer_list->active_timers_lock);
> +ts = timer_list->active_timers;
> +while (timer_expired_ns(ts, current_time)) {
> +if (!(ts->attributes & QEMU_TIMER_ATTR(EXTERNAL))) {
> +
From: liujunjie
Before, we did not clear callback like handle_output when delete
the virtqueue which may result be segmentfault.
The scene is as follows:
1. Start a vm with multiqueue vhost-net,
2. then we write VIRTIO_PCI_GUEST_FEATURES in PCI configuration to
triger multiqueue disable in this v
This also makes the default display resolution configurable,
via xres and yres properties. The default is 1024x768.
The old code had a hard-coded resolution of 1600x1200.
Cc: Linus Walleij
Cc: BALATON Zoltan
Signed-off-by: Gerd Hoffmann
Message-id: 20181005110837.28209-1-kra...@redhat.com
---
On 14/10/2018 16:55, Artem Pisarenko wrote:
>
> Current implementation of timers/clock processing is confusing (at
> least for me) because of exceptions from design concept behind them,
> introduced by icount mode (which adds QEMU_CLOCK_VIRTUAL_RT). Adding
> QEMU_CLOCK_VIRTUAL_EXT just made things
Hi Peter,
On 10/05/2018 11:26 AM, Jerome Forissier wrote:
> +CC: Rob Herring
>
> On 10/05/2018 11:16 AM, Peter Maydell wrote:
>> On 5 October 2018 at 09:07, Jerome Forissier
>> wrote:
>>> Bindings for /secure-chosen and /secure-chosen/stdout-path have been
>>> proposed 1.5 years ago [1] and impl
From: Zhang Chen
We need to know if migration is going into COLO state for
incoming side before start normal migration.
Instead by using the VMStateDescription to send colo_state
from source side to destination side, we use MIG_CMD_ENABLE_COLO
to indicate whether COLO is enabled or not.
Signed-
This allows modern architectures which don't care about vga
compatibility (risc-v for example) build bochs-display without
including all vga emulation too.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Alistair Francis
Message-id: 20181005160147.892-2-kra...@redhat.com
---
default-configs/pci.mak
In ne2000_receive(), we try to assign size_ to size which converts
from size_t to integer. This will cause troubles when size_ is greater
INT_MAX, this will lead a negative value in size and it can then pass
the check of size < MIN_BUF_SIZE which may lead out of bound access of
for both buf and buf
On 2018年10月15日 16:20, Wei Xu wrote:
+static void virtio_queue_set_notification_packed(VirtQueue *vq, int enable)
+{
+VRingPackedDescEvent e;
+VRingMemoryRegionCaches *caches;
+
+rcu_read_lock();
+caches = vring_get_region_caches(vq);
+vring_packed_event_read(vq->vdev, &cac
The following changes since commit a73549f99612f758dec0fdea6ae1c30b6c709a0b:
Merge remote-tracking branch 'remotes/kraxel/tags/ui-20181012-pull-request'
into staging (2018-10-12 16:45:51 +0100)
are available in the git repository at:
git://git.kraxel.org/qemu tags/vga-20181015-pu
In rtl8139_do_receive(), we try to assign size_ to size which converts
from size_t to integer. This will cause troubles when size_ is greater
INT_MAX, this will lead a negative value in size and it can then pass
the check of size < MIN_BUF_SIZE which may lead out of bound access of
for both buf and
From: Martin Wilck
The e1000 emulation silently discards RX packets if there's
insufficient space in the ring buffer. This leads to errors
on higher-level protocols in the guest, with no indication
about the error cause.
This patch increments the "Missed Packets Count" (MPC) and
"Receive No Buff
Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.
Signed-off-by: Mao Zhongyi
Reviewed-by: Thomas Huth
---
scripts/git-submodule.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/git-submodu
Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.
Signed-off-by: Mao Zhongyi
Reviewed-by: Thomas Huth
---
scripts/archive-source.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/archive-so
Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.
Signed-off-by: Mao Zhongyi
Reviewed-by: Thomas Huth
---
scripts/show-fixed-bugs.sh | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/sh
From: Thomas Huth
When using the "-device" option, the property is called "mac".
"macaddr" is only used for the legacy "-net nic" option.
Reported-by: Harald Hoyer
Reviewed-by: Markus Armbruster
Signed-off-by: Thomas Huth
Signed-off-by: Jason Wang
---
qemu-options.hx | 2 +-
1 file changed,
On Sat 13 Oct 2018 10:52:31 AM CEST, Li Qiang wrote:
> Signed-off-by: Li Qiang
Reviewed-by: Alberto Garcia
Berto
Use stl_le_p() & friends instead of casts.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20181015055333.32030-1-kra...@redhat.com
---
hw/display/edid-generate.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/display/edid-generate.c
Signed-off-by: Gerd Hoffmann
Message-id: 20181005160147.892-3-kra...@redhat.com
---
hw/display/bochs-display.c | 13 +
hw/display/Makefile.objs | 1 +
2 files changed, 14 insertions(+)
diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
index 09d8944a1b..3d439eb24
From: Alex Williamson
Difficult to make use of if not installed
Fixes: cd1bfd5ef336 ("seabios: update bios and vgabios binaries")
Signed-off-by: Alex Williamson
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 153936155938.28040.11513367417790075721.st...@gimli.home
Signed-off-by: Gerd Hoffmann
From: Thomas Huth
In downstream distros like RHEL we'd like to disable some of the "legacy"
devices of QEMU. The ISA version of the Cirrus VGA device is one of these
legacy devices. So let's make the build process a little bit more flexible
here by putting the Cirrus ISA code into a separate file
On Sat, Oct 13, 2018 at 02:02:27AM -0300, Eduardo Habkost wrote:
> Signed-off-by: Eduardo Habkost
> ---
> I'd like to do this in QEMU 3.1. I think it's time to drop
> support for old systems that have only Python 2.
>
> We still have a few scripts that are not required for building
> QEMU that st
Am 12.10.2018 um 18:47 hat Eric Blake geschrieben:
> On 10/12/18 6:55 AM, Kevin Wolf wrote:
> > If a management application builds the block graph node by node, the
> > protocol layer doesn't inherit its read-only option from the format
> > layer any more, so it must be set explicitly.
> >
>
> >
On 13 October 2018 at 17:50, Hristo Mihaylov
wrote:
> Hello,
> I'm trying to install OpenBSD 6.3 on Arch Linux.
> This is the crash output:
>
> qemu-system-x86_64:
> /build/qemu/src/qemu-3.0.0/include/exec/memory_ldst_cached.inc.h:85:
> address_space_stw_le_cached: Assertion `addr < cache->len &&
ping
18.09.2018 13:37, Vladimir Sementsov-Ogievskiy wrote:
> 17.09.2018 21:33, John Snow wrote:
>>
>> On 09/17/2018 11:51 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> Hmm, ping, anybody here ?)
>>>
>> Was preparing to stage on Friday, working on it now.
>>
>> I never understood why you forbid the t
On Fri, 12 Oct 2018 23:54:35 -0300
Eduardo Habkost wrote:
> The current virtio-*-pci device types actually represent 3
> different types of devices:
> * virtio 1.0 non-transitional devices
> * virtio 1.0 transitional devices
> * virtio 0.9 ("legacy device" in virtio 1.0 terminology)
>
> That wou
I suspect this is a known bug, fixed in master in commit db812c4073c77.
You could test that by cherry-picking it to 3.0 or just testing against
master.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/17
On 15 October 2018 at 10:32, Daniel P. Berrangé wrote:
> On Sat, Oct 13, 2018 at 02:02:27AM -0300, Eduardo Habkost wrote:
>> Signed-off-by: Eduardo Habkost
>> ---
>> I'd like to do this in QEMU 3.1. I think it's time to drop
>> support for old systems that have only Python 2.
>>
>> We still have
Am 13.10.2018 um 10:52 hat Li Qiang geschrieben:
> Signed-off-by: Li Qiang
Thanks, applied to the block branch.
Kevin
On 10/15/2018 03:58 PM, Markus Armbruster wrote:
Fei Li writes:
Add a new Error parameter for vnc_display_init() to handle errors
in its caller: vnc_init_func(), just like vnc_display_open() does.
And let its callees propagate the Error, like init_keyboard_layout().
Signed-off-by: Fei Li
On Mon, Oct 15, 2018 at 11:02:03AM +0100, Peter Maydell wrote:
> On 15 October 2018 at 10:32, Daniel P. Berrangé wrote:
> > On Sat, Oct 13, 2018 at 02:02:27AM -0300, Eduardo Habkost wrote:
> >> Signed-off-by: Eduardo Habkost
> >> ---
> >> I'd like to do this in QEMU 3.1. I think it's time to dro
Am 15.10.2018 um 12:02 hat Peter Maydell geschrieben:
> On 15 October 2018 at 10:32, Daniel P. Berrangé wrote:
> > On Sat, Oct 13, 2018 at 02:02:27AM -0300, Eduardo Habkost wrote:
> >> Signed-off-by: Eduardo Habkost
> >> ---
> >> I'd like to do this in QEMU 3.1. I think it's time to drop
> >> su
On Mon, Oct 15, 2018 at 10:16:41AM +0200, Gerd Hoffmann wrote:
> On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote:
> > The current virtio-*-pci device types actually represent 3
> > different types of devices:
> > * virtio 1.0 non-transitional devices
> > * virtio 1.0 transitional de
On Mon, Oct 15, 2018 at 08:54:27AM +0200, David Hildenbrand wrote:
> On 12/10/2018 20:05, Michael S. Tsirkin wrote:
> > On Fri, Oct 12, 2018 at 02:24:27PM +1100, David Gibson wrote:
> >> When the balloon is inflated, we discard memory place in it using madvise()
> >> with MADV_DONTNEED. And when w
From: Aleksandar Markovic
This series contains three cosmetic changes that do not affect any
QEMU feature, but are still hopefully helpful for development.
Aleksandar Markovic (3):
target/mips: Add a comment with an overview of CP0 registers
target/mips: Add a comment before each CP0 registe
From: Aleksandar Markovic
Add a comment before each CP0 register section in CPUMIPSState
definition, thus visually separating these sections.
Signed-off-by: Aleksandar Markovic
---
target/mips/cpu.h | 88 +++
1 file changed, 88 insertions(+)
From: Aleksandar Markovic
Add a comment with an overview of CP0 registers close to the
definition of their corresponding fields in CPUMIPSState.
Signed-off-by: Aleksandar Markovic
---
target/mips/cpu.h | 109 ++
1 file changed, 109 insertions
From: Aleksandar Markovic
Yongbok Kim used two email adresses for QEMU contributions -
his company changed its ownership/name.
Signed-off-by: Aleksandar Markovic
---
.mailmap | 1 +
1 file changed, 1 insertion(+)
diff --git a/.mailmap b/.mailmap
index 2c2b9b1..0d886a1 100644
--- a/.mailmap
++
> From: Fredrik Noring
> Sent: Saturday, October 13, 2018 1:11 PM
> To: Aleksandar Markovic; Maciej W. Rozycki; Philippe Mathieu-Daudé
> Cc: Richard Henderson; Aurelien Jarno; Petar Jovanovic; Peter Maydell; Jürgen
> Urban; > qemu-devel@nongnu.org
> Subject: [PATCH v7 7/7] elf: Toshiba/Sony rathe
On 15.10.18 07:55, Markus Armbruster wrote:
> Max Reitz writes:
>
>> On 13.10.18 22:36, Eduardo Habkost wrote:
>>> On Sat, Oct 13, 2018 at 08:20:25PM +0200, Max Reitz wrote:
On 13.10.18 07:02, Eduardo Habkost wrote:
> Signed-off-by: Eduardo Habkost
> ---
> I'd like to do this in
On 15.10.18 13:01, Max Reitz wrote:
> On 15.10.18 07:55, Markus Armbruster wrote:
>> Max Reitz writes:
>>
>>> On 13.10.18 22:36, Eduardo Habkost wrote:
On Sat, Oct 13, 2018 at 08:20:25PM +0200, Max Reitz wrote:
> On 13.10.18 07:02, Eduardo Habkost wrote:
>> Signed-off-by: Eduardo Habk
>> (And "Expect access in the near future." does not sound like guarantees
>> to me either way)
>
> Should we be concerned about impact on performance though?
Yes, it really depends on the use case (and most of the time, the memory
won't be directly reused). Let's document it in the commit log
Calling error_report() in a function that takes an Error ** argument
is suspicious. 9p-handle.c's handle_parse_opts() does that, and then
fails without setting an error. Wrong. Its caller crashes when it
tries to report the error:
$ qemu-system-x86_64 -nodefaults -fsdev id=foo,fsdriver=hand
Calling error_report() in a function that takes an Error ** argument
is suspicious. Convert a few that are actually warnings to
warn_report().
While there, split warnings consisting of multiple sentences to
conform to conventions spelled out in warn_report()'s contract, and
improve a rather usele
Calling error_report() in a function that takes an Error ** argument
is suspicious. save_snapshot() and load_snapshot() do that, and then
fail without setting an error. Wrong. The HMP commands survive this
unscathed, since hmp_handle_error() does nothing when no error has
been set. Callers main
Calling error_report() or similar in a function that takes an Error **
argument is suspicious. Fix a number of instances that are actually
wrong. Clean up a few more that are merely fragile / bad examples.
v2:
* PATCH 01: New
* PATCH 02: Commit hash corrected in commit message [Eric]
* PATCH 13:
Signed-off-by: Markus Armbruster
---
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 22beca29d1..89520d8007 100644
--- a/vl.c
+++ b/vl.c
@@ -4397,7 +4397,7 @@ int main(int argc, char **argv, char **envp)
if (qemu_opts_foreach(qemu_find_opts("drive")
Calling error_report() in a function that takes an Error ** argument
is suspicious. mon_init_func() does that, and then fails without
setting an error. Its caller main(), via qemu_opts_foreach(), is fine
with it, but clean it up anyway.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mat
>From include/qapi/error.h:
* Pass an existing error to the caller with the message modified:
* error_propagate(errp, err);
* error_prepend(errp, "Could not frobnicate '%s': ", name);
Fei Li pointed out that doing error_propagate() first doesn't work
well when @errp is &error_fatal
Add a slight improvement of the Coccinelle semantic patch from commit
007b06578ab, and use it to clean up. It leaves dead Error * variables
behind, cleaned up manually.
Cc: David Gibson
Cc: Alexander Graf
Cc: Eric Blake
Cc: Paolo Bonzini
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Bla
Calling error_report() from within a function that takes an Error **
argument is suspicious. drive_new() calls error_report() even though
it can run within drive_init_func(), which takes an Error ** argument.
drive_init_func()'s caller main(), via qemu_opts_foreach(), is fine
with it, but clean it
Calling error_report() in a function that takes an Error ** argument
is suspicious. parse_numa_node() does that, and then exit()s. It
also passes &error_fatal to machine_set_cpu_numa_node(). Both wrong.
Attempting to configure numa when the machine doesn't support it kills
the VM:
$ qemu-sy
Calling error_report() in a function that takes an Error ** argument
is suspicious. parse_add_fd() does that, and then fails without
setting an error. Its caller main(), via qemu_opts_foreach(), is fine
with it, but clean it up anyway.
Also change call of cleanup_add_fd(), which can't fail, for
Calling error_report() in a function that takes an Error ** argument
is suspicious. chardev_init_func() does that, and then fails without
setting an error. Its caller main(), via qemu_opts_foreach(), is fine
with it, but clean it up anyway.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe
1 - 100 of 283 matches
Mail list logo
