On 2018-10-12 02:21, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> gdbstub.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index c8478de8f5..c4e4f9f082 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -20,7 +20,6 @@
> #include "qa
From: Liu Yuan
E-mail to one of block/sheepdog maintainers Mitake Hitoshi bounces
: unknown user: "mitake.hitoshi"
and no current address is known. So just remove it.
Signed-off-by: Liu Yuan
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 32
On 12/10/2018 05:24, David Gibson wrote:
> When the balloon is inflated, we discard memory place in it using madvise()
> with MADV_DONTNEED. And when we deflate it we use MADV_WILLNEED, which
> sounds like it makes sense but is actually unnecessary.
>
> The misleadingly named MADV_DONTNEED just d
On 12/10/2018 05:24, David Gibson wrote:
> The virtio-balloon device's verification of the address given to it by the
> guest has a number of faults:
> * The addresses here are guest physical addresses, which should be
> 'hwaddr' rather than 'ram_addr_t' (the distinction is admittedly
>
On 12/10/2018 05:24, David Gibson wrote:
> This replaces the balloon_page() internal interface with
> ballon_inflate_page(), with a slightly different interface. The new
> interface will make future alterations simpler.
>
> Signed-off-by: David Gibson
> ---
> hw/virtio/virtio-balloon.c | 17 +++
Fei Li writes:
> On 10/11/2018 06:02 PM, Markus Armbruster wrote:
>> Fei Li writes:
>>
>>> Currently, when qemu_signal_init() fails it only returns a non-zero
>>> value but without propagating any Error. But its callers need a
>>> non-null err when runs error_report_err(err), or else 0->msg occu
On 12/10/2018 02:22, Philippe Mathieu-Daudé wrote:
> Suggested-by: Paolo Bonzini
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> chardev/char-fd.c | 2 +-
> include/chardev/char-fd.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/chardev/char-fd.c b/chardev/
On 12/10/2018 05:24, David Gibson wrote:
> The virtio-balloon always works in units of 4kiB (BALLOON_PAGE_SIZE), but
> on the host side, we can only actually discard memory in units of the host
> page size.
>
> At present we handle this very badly: we silently ignore balloon requests
> that aren't
Fei Li writes:
> On 10/11/2018 09:13 PM, Markus Armbruster wrote:
>> Fei Li writes:
>>
>>> Add a new Error parameter for vnc_display_init() to handle errors
>>> in its caller: vnc_init_func(), just like vnc_display_open() does.
>>> And let the call trace propagate the Error.
>>>
>>> Besides, mak
On Fri, Oct 12, 2018 at 02:22:06AM +0200, Philippe Mathieu-Daudé wrote:
> Hi Paolo,
>
> Here are the changes you suggested in
> https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02294.html
>
> First two simple cleanups while here,
> then slowly convert backends then frontends.
>
> Regards
Fei Li writes:
> On 10/11/2018 09:19 PM, Markus Armbruster wrote:
>> Fei Li writes:
>>
>>> The caller of qemu_init_vcpu() already passed the **errp to handle
>> Which caller? There are many. Or do you mean "The callers"?
> Oh, sorry, I mean "The callers" :)
>>
>>> errors. In view of this, add
On Fri, 12 Oct 2018 11:17:32 +1100
David Gibson wrote:
> On Thu, Oct 11, 2018 at 03:04:08PM +0200, Greg Kurz wrote:
> > On Thu, 11 Oct 2018 13:02:50 +0200
> > Philippe Mathieu-Daudé wrote:
> >
> > > Hi Greg,
> > >
> > > On 11/10/2018 09:00, Greg Kurz wrote:
> > > > According to CODING_STYL
On Thu, 11 Oct 2018 10:50:13 +0200
David Hildenbrand wrote:
> On 08/10/2018 16:12, Igor Mammedov wrote:
> > On Mon, 8 Oct 2018 14:41:50 +0200
> > David Hildenbrand wrote:
> >
> >> On 08/10/2018 14:19, Igor Mammedov wrote:
> >>> On Mon, 8 Oct 2018 13:47:53 +0200
> >>> David Hildenbrand wrot
Liu Yuan writes:
> From: Liu Yuan
>
> E-mail to one of block/sheepdog maintainers Mitake Hitoshi bounces
>
> : unknown user: "mitake.hitoshi"
Yup, got that, too.
> and no current address is known. So just remove it.
>
> Signed-off-by: Liu Yuan
> ---
> MAINTAINERS | 1 -
> 1 file changed, 1 d
Cc: Jan Kiszka
Cc: Peter Maydell
Cc: Gerd Hoffmann
To: qemu-...@nongnu.org
Signed-off-by: Mao Zhongyi
Reviewed-by: Philippe Mathieu-Daudé
---
hw/arm/musicpal.c | 2 +-
hw/audio/marvell_88w8618.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm/musicpal.c
According to qdev-properties.h, properties of pointer type
should be avoid, so convert qdev property to link, Whilst we
are here, also update some hardcoded strings with already
defineded macros.
v2:
-removed the patch1
-removed the TYPE_name in VMStateDescription.name
Cc: Jan Kiszka
Cc: Peter M
According to qdev-properties.h, properties of pointer type should
be avoided, it seems a link type property is a good substitution.
Cc: Jan Kiszka
Cc: Peter Maydell
Cc: Gerd Hoffmann
To: qemu-...@nongnu.org
Signed-off-by: Mao Zhongyi
---
hw/arm/musicpal.c | 3 ++-
hw/audio/marvell_
Cc: Jan Kiszka
Cc: Philippe Mathieu-Daudé
Cc: Peter Maydell
To: qemu-...@nongnu.org
Signed-off-by: Mao Zhongyi
---
hw/arm/musicpal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c
index ac266f9253..9648b3af44 100644
--- a/hw/arm/music
On 12/10/2018 05:24, David Gibson wrote:
> The virtio-balloon always works in units of 4kiB (BALLOON_PAGE_SIZE), but
> on the host side, we can only actually discard memory in units of the host
> page size.
>
> At present we handle this very badly: we silently ignore balloon requests
> that aren't
Long-term testing showed that my trivial adaptation didn't fixed issue and I
sticked to modification from QBox. It didn't failed yet.
And yes, issue still relevant to current master branch.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to Q
Hi,
> > OnOffAuto display;
> > +bool enable_ramfb;
> > int32_t bootindex;
> > uint32_t igd_gms;
> > OffAutoPCIBAR msix_relo;
>
> Hi Gerd,
>
> One tiny nit here, we can move this new bool down in the struct with
> the rest of the bools for better alignment. I can change
>
> The correct order should be opposite to one that created a devices,
> i.e. unplug -> unrealize -> delete.
> Doing unplug stuff after device was unrealized looks outright wrong
> (essentially device doesn't exists anymore except memory where it's
> been located).
pre_plug -> realize -> plug
u
* jialina01 (jialin...@baidu.com) wrote:
> During an active background migraion, snapshot will trigger a
> segmentfault. As snapshot clears the "current_migration" struct
> and updates "to_dst_file" before it finds out that there is a
> migration task, Migration accesses the null pointer in
> "curr
As requested by David, two distinct patches and PCI still mentionned
in the new type names.
--
Greg
---
Greg Kurz (2):
spapr_pci: convert g_malloc() to g_new()
spapr_pci: rename some structured types
hw/ppc/spapr_pci.c | 22 +++---
include/hw/pci-host/sp
According to CODING_STYLE, structured types names are expected to be
in CamelCase but we have:
typedef struct spapr_pci_msi {
uint32_t first_irq;
uint32_t num;
} spapr_pci_msi;
typedef struct spapr_pci_msi_mig {
uint32_t key;
spapr_pci_msi value;
} spapr_pci_msi_mig;
Acronyms are
When allocating an array, it is a recommended coding practice to call
g_new(FooType, n) instead of g_malloc(n * sizeof(FooType)) because
it takes care to avoid overflow when calculating the size of the
allocated block and it returns FooType *, which allows the compiler
to perform type checking.
Si
From: yuchenlin
There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device,
but seabios will only set the physical address for the 3rd one (cmd).
Then in vhost_virtqueue_start(), virtio_queue_get_desc_addr()
will be 0 for ctrl and event vq.
In this case, ctrl and event vq are not initia
On Thu, Oct 11, 2018 at 05:37:46PM +0200, Lukáš Hrázký wrote:
> On Thu, 2018-10-11 at 17:09 +0200, Gerd Hoffmann wrote:
> > > > Ok. We probably should fix interface_client_monitors_config() to use
> > > > the channel_id instead of qemu_console_get_head() then.
> > >
> > > It's not that simple. Th
On Thu, Oct 11, 2018 at 05:21:45PM +0200, Thomas Huth wrote:
> In downstream distros like RHEL we'd like to disable some of the "legacy"
> devices of QEMU. The ISA version of the Cirrus VGA device is one of these
> legacy devices. So let's make the build process a little bit more flexible
> here by
On 11 October 2018 at 21:52, Michael Clark wrote:
> Peter, I have to pull in your remote wholesale. I don't cherry-pick from
> your tree. I think this is truly dumb. This might serve the needs of some
> folk running Linux but we have emulation fidelity fixes for the RISC-V
> community as a whole.
On Thu, Oct 11, 2018 at 04:48:34PM +0100, Daniel P. Berrangé wrote:
> Adding Markus since we're talking about new CLI argument and capability
> reporting standards.
>
> On Fri, Sep 14, 2018 at 05:52:30PM +0400, Marc-André Lureau wrote:
> > As discussed during "[PATCH v4 00/29] vhost-user for input
On 2018-10-12 11:31, Gerd Hoffmann wrote:
> On Thu, Oct 11, 2018 at 05:21:45PM +0200, Thomas Huth wrote:
>> In downstream distros like RHEL we'd like to disable some of the "legacy"
>> devices of QEMU. The ISA version of the Cirrus VGA device is one of these
>> legacy devices. So let's make the bui
On 10/12/2018 03:56 PM, Markus Armbruster wrote:
Fei Li writes:
On 10/11/2018 06:02 PM, Markus Armbruster wrote:
Fei Li writes:
Currently, when qemu_signal_init() fails it only returns a non-zero
value but without propagating any Error. But its callers need a
non-null err when runs erro
On 12/10/2018 11:05, Greg Kurz wrote:
> When allocating an array, it is a recommended coding practice to call
> g_new(FooType, n) instead of g_malloc(n * sizeof(FooType)) because
> it takes care to avoid overflow when calculating the size of the
> allocated block and it returns FooType *, which all
Hi
On Thu, Oct 11, 2018 at 7:49 PM Daniel P. Berrangé wrote:
>
> Adding Markus since we're talking about new CLI argument and capability
> reporting standards.
>
> On Fri, Sep 14, 2018 at 05:52:30PM +0400, Marc-André Lureau wrote:
> > As discussed during "[PATCH v4 00/29] vhost-user for input & G
On 12/10/2018 10:30, Mao Zhongyi wrote:
> Cc: Jan Kiszka
> Cc: Peter Maydell
> Cc: Gerd Hoffmann
> To: qemu-...@nongnu.org
"To: qemu-...@nongnu.org" is probably not relevant in the commit message.
The Linux kernel describes the 'Cc:' line in the "Submitting patches:
the essential guide to gett
Hi Mao,
On 12/10/2018 10:30, Mao Zhongyi wrote:
> According to qdev-properties.h, properties of pointer type should
> be avoided, it seems a link type property is a good substitution.
>
> Cc: Jan Kiszka
> Cc: Peter Maydell
> Cc: Gerd Hoffmann
> To: qemu-...@nongnu.org
>
> Signed-off-by: Mao Z
On 12/10/2018 10:30, Mao Zhongyi wrote:
> Cc: Jan Kiszka
> Cc: Philippe Mathieu-Daudé
> Cc: Peter Maydell
> To: qemu-...@nongnu.org
>
> Signed-off-by: Mao Zhongyi
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/arm/musicpal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
On Fri, 2018-10-12 at 11:27 +0200, Gerd Hoffmann wrote:
> On Thu, Oct 11, 2018 at 05:37:46PM +0200, Lukáš Hrázký wrote:
> > On Thu, 2018-10-11 at 17:09 +0200, Gerd Hoffmann wrote:
> > > > > Ok. We probably should fix interface_client_monitors_config() to use
> > > > > the channel_id instead of qem
On Fri, Oct 12, 2018 at 01:43:39PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Thu, Oct 11, 2018 at 7:49 PM Daniel P. Berrangé
> wrote:
> >
> > Adding Markus since we're talking about new CLI argument and capability
> > reporting standards.
> >
> > On Fri, Sep 14, 2018 at 05:52:30PM +0400, Marc-
On 12/10/2018 05:40, Li Qiang wrote:
> Define a TYPE_VFIO_PCI and drop DO_UPCAST.
>
> Signed-off-by: Li Qiang
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/vfio/pci.c | 29 +++--
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/hw/vfio/pci.c b/hw/
Sorry for the noise, there is something wrong with this patch,
I will fix it and resend this patchset.
Thanks,
Mao
On 10/12/18 4:30 PM, Mao Zhongyi wrote:
Cc: Jan Kiszka
Cc: Philippe Mathieu-Daudé
Cc: Peter Maydell
To: qemu-...@nongnu.org
Signed-off-by: Mao Zhongyi
---
hw/arm/musicpal.c
The following changes since commit 75e50c80e051423a6f55a34ee4a1eec842444a5b:
Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2018-10-10' into
staging (2018-10-11 10:43:37 +0100)
are available in the Git repository at:
git://github.com/cohuck/qemu tags/s390x-20181012
From: Tony Krowiak
A new CPU model feature and two new CPU model facilities are
introduced to support AP devices for a KVM guest.
CPU model features:
1. The S390_FEAT_AP CPU model feature indicates whether AP
instructions are available to the guest. This feature will
be enabled only if th
From: Tony Krowiak
Let's use the KVM_SET_DEVICE_ATTR ioctl to enable hardware
interpretation of AP instructions executed on the guest.
If the S390_FEAT_AP feature is switched on for the guest,
AP instructions must be interpreted by default; otherwise,
they will be intercepted.
This attribute set
From: Tony Krowiak
Introduces the base object model for virtualizing AP devices.
Signed-off-by: Tony Krowiak
Tested-by: Pierre Morel
Acked-by: David Hildenbrand
Reviewed-by: Thomas Huth
Reviewed-by: Halil Pasic
Tested-by: Christian Borntraeger
Message-Id: <20181010170309.12045-5-akrow...@l
From: Thomas Huth
Debug macros that are disabled by default should be avoided (since the
code bit-rots quite easily). Thus turn these debug prints into proper
qemu_log_mask(CPU_LOG_xxx, ...) statements instead. The DPRINTF statements
in do_[ext|io|mchk]_interrupt can even be removed completely si
Update to kvm/next commit dd5bd0a65ff6 ("Merge tag 'kvm-s390-next-4.20-1'
of git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux into HEAD")
Signed-off-by: Cornelia Huck
---
include/standard-headers/linux/input.h | 9 +
linux-headers/asm-arm/kvm.h| 13 +
From: Tony Krowiak
Introduces a VFIO based AP device. The device is defined via
the QEMU command line by specifying:
-device vfio-ap,sysfsdev=
There may be only one vfio-ap device configured for a guest.
The mediated matrix device is created by the VFIO AP device
driver by writing a UUID t
From: Tony Krowiak
This patch provides documentation describing the AP architecture and
design concepts behind the virtualization of AP devices. It also
includes an example of how to configure AP devices for exclusive
use of KVM guests.
Signed-off-by: Tony Krowiak
Reviewed-by: Pierre Morel
Tes
From: Thomas Huth
The device is required for running qtests, see hw/s390x/tod.c:
void s390_init_tod(void)
{
Object *obj;
if (kvm_enabled()) {
obj = object_new(TYPE_KVM_S390_TOD);
} else {
obj = object_new(TYPE_QEMU_S390_TOD);
}
[...]
}
During qtests, we're
On 12/10/2018 10:05, Wangguang wrote:
> Hi
>
> qemu had a assert when we use scsi-3 reservation。
>
> This happen when scsi sence is recoverd error。
>
> And which lead scsi_req_complete twice.
>
>
>
>
>
> static bool scsi_handle_rw_error(SCSIDiskReq *r, int error, bool
> acct_failed)
>
>
In downstream distros like RHEL we'd like to disable some of the "legacy"
devices of QEMU. The ISA version of the Cirrus VGA device is one of these
legacy devices. So let's make the build process a little bit more flexible
here by putting the Cirrus ISA code into a separate file which is only
inclu
Hi, Philippe
On 10/12/18 5:50 PM, Philippe Mathieu-Daudé wrote:
On 12/10/2018 10:30, Mao Zhongyi wrote:
Cc: Jan Kiszka
Cc: Peter Maydell
Cc: Gerd Hoffmann
To: qemu-...@nongnu.org
"To: qemu-...@nongnu.org" is probably not relevant in the commit message.
The Linux kernel describes the 'Cc:'
> On Thu, Oct 11, 2018 at 05:37:46PM +0200, Lukáš Hrázký wrote:
> > On Thu, 2018-10-11 at 17:09 +0200, Gerd Hoffmann wrote:
> > > > > Ok. We probably should fix interface_client_monitors_config() to use
> > > > > the channel_id instead of qemu_console_get_head() then.
> > > >
> > > > It's not tha
Hi Philippe,
On 10/3/18 12:42 AM, Philippe Mathieu-Daudé wrote:
> Hi Damien,
>
> On 10/2/18 4:24 PM, Damien Hedde wrote:
>> This prints the clocks attached to a DeviceState when using "info qtree"
>> monitor
>> command. For every clock, it displays the direction, the name and if the
>> clock is
On 10/12/2018 04:18 PM, Markus Armbruster wrote:
Fei Li writes:
On 10/11/2018 09:13 PM, Markus Armbruster wrote:
Fei Li writes:
Add a new Error parameter for vnc_display_init() to handle errors
in its caller: vnc_init_func(), just like vnc_display_open() does.
And let the call trace pro
Hi,
> Note, I can't remember what Markus had proposed for CLI arguments in
> QAPI, so I invented something arbitary but plausible.
Using qapi visitors to parse the command line. Used by -blockdev and
-display (and maybe others meanwhile). See parse_display_qapi().
I think Daniels suggestion
On 10/12/2018 04:24 PM, Markus Armbruster wrote:
Fei Li writes:
On 10/11/2018 09:19 PM, Markus Armbruster wrote:
Fei Li writes:
The caller of qemu_init_vcpu() already passed the **errp to handle
Which caller? There are many. Or do you mean "The callers"?
Oh, sorry, I mean "The calle
On Fri, Oct 12, 2018 at 12:23:11PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > Note, I can't remember what Markus had proposed for CLI arguments in
> > QAPI, so I invented something arbitary but plausible.
>
> Using qapi visitors to parse the command line. Used by -blockdev and
> -display (and may
Hi,
> > When using qemu_console_get_head() it doesn't work correctly, it would
> > use the qxl card's data. It would work if spice-server would filter the
> > list to only include the entries for the given display channel before
> > calling the ->client_monitors_config() callback. But it doesn
>
> Hi,
>
> > > When using qemu_console_get_head() it doesn't work correctly, it would
> > > use the qxl card's data. It would work if spice-server would filter the
> > > list to only include the entries for the given display channel before
> > > calling the ->client_monitors_config() callback.
On 10/12/2018 06:23 PM, Fei Li wrote:
On 10/12/2018 04:18 PM, Markus Armbruster wrote:
Fei Li writes:
On 10/11/2018 09:13 PM, Markus Armbruster wrote:
Fei Li writes:
Add a new Error parameter for vnc_display_init() to handle errors
in its caller: vnc_init_func(), just like vnc_displa
On 11 October 2018 at 20:25, Dr. David Alan Gilbert (git)
wrote:
> From: "Dr. David Alan Gilbert"
>
> The following changes since commit 75e50c80e051423a6f55a34ee4a1eec842444a5b:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2018-10-10'
> into staging (2018-10-11 10:43:37 +01
On Fri, Oct 12, 2018 at 06:46:37AM -0400, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > > > When using qemu_console_get_head() it doesn't work correctly, it would
> > > > use the qxl card's data. It would work if spice-server would filter the
> > > > list to only include the entries for the given d
On 12 October 2018 at 02:50, Fam Zheng wrote:
> The following changes since commit 75e50c80e051423a6f55a34ee4a1eec842444a5b:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2018-10-10'
> into staging (2018-10-11 10:43:37 +0100)
>
> are available in the Git repository at:
>
> g
See qemu_spice_add_display_interface(), the console index is also used
as channel id. So put that into the qxl->id field too.
In typical use cases (one primary qxl-vga device, optionally one or more
secondary qxl devices, no non-qxl display devices) this doesn't change
anything.
With this in pla
Future spice-server versions will call the client_monitors_config
callback with the monitors list filtered to only include the monitors
of the given display channel (aka QXLInstance). Luckily this is easily
detectable at runtime, so we can prepare for that in advance and also
make qemu compatible
The qemu api claims to be easier to use, and the resulting code
shows that.
Signed-off-by: David Hildenbrand
---
qapi/string-input-visitor.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c
index af0a8
Right now, we parse uint64_t values just like int64_t values, resulting
in negative values getting accepted and certain valid large numbers only
being representable as negative numbers. Also, reported errors indicate
that an int64_t is expected.
Parse uin64_t separately. Implementation inspired by
Add some more functions that will be used in memory-device context.
range_init(): Init using lower bound and size, check for validity
range_init_nofail(): Init using lower bound and size, validity asserted
range_size(): Extract the size of a range
range_overlaps_range(): Check for overlaps of two
Should not be a problem right now, but it could theoretically happen
in the future.
Signed-off-by: David Hildenbrand
---
hw/mem/memory-device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index 996ad1490f..8be63c8032 10064
While working on memory device code, I noticed that specifiying an uint64_t
on command line does not work in all cases as we always parse an int64_t.
So I fix that and also cleanup the old int64_t parser.
To be able to fix some overflows in memory-device code in a clean way,
I am reusing the range
Add a new Error parameter for vnc_display_init() to handle errors
in its caller: vnc_init_func(), just like vnc_display_open() does.
And let its callees propagate the Error, like init_keyboard_layout().
Signed-off-by: Fei Li
---
include/ui/console.h | 2 +-
ui/curses.c | 4 +++-
ui/ke
Let's rewrite it properly using ranges. This fixes certain overflows that
are right now possible. E.g.
qemu-system-x86_64 -m 4G,slots=20,maxmem=40G -M pc \
-object memory-backend-file,id=mem1,share,mem-path=/dev/zero,size=2G
-device pc-dimm,memdev=mem1,id=dimm1,addr=-0x4000
Now proper
If there are no changes, let's use a const pointer.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: David Hildenbrand
---
include/qemu/range.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/qemu/range.h b/include/qemu/range.h
index f28f0c1825..7e75f4e655 10
Hi, Philippe
On 10/12/18 5:53 PM, Philippe Mathieu-Daudé wrote:
Hi Mao,
On 12/10/2018 10:30, Mao Zhongyi wrote:
According to qdev-properties.h, properties of pointer type should
be avoided, it seems a link type property is a good substitution.
Cc: Jan Kiszka
Cc: Peter Maydell
Cc: Gerd Hoffm
If a management application builds the block graph node by node, the
protocol layer doesn't inherit its read-only option from the format
layer any more, so it must be set explicitly.
Backing files should work on read-only storage, but at the same time, a
block job like commit should be able to reo
Shorter and easier to read.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: David Hildenbrand
---
hw/mem/memory-device.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index 7de1ccd497..996ad1490f 100644
--- a/hw/mem/
To fully change the read-only state of a node, we must not only change
bs->read_only, but also update bs->open_flags.
Signed-off-by: Kevin Wolf
---
block.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/block.c b/block.c
index 0d6e5f1a76..d7bd6d29b4 100644
--- a/block.c
+++ b/block.c
If read-only=off, but auto-read-only=on is given, open a read-write NBD
connection if the server provides a read-write export, but instead of
erroring out for read-only exports, just degrade to read-only.
Signed-off-by: Kevin Wolf
---
block/nbd-client.c | 10 +-
1 file changed, 5 inserti
If read-only=off, but auto-read-only=on is given, open the file
read-write if we have the permissions, but instead of erroring out for
read-only files, just degrade to read-only.
Signed-off-by: Kevin Wolf
---
block/gluster.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/block/glus
Some block drivers have traditionally changed their node to read-only
mode without asking the user. This behaviour has been marked deprecated
since 2.11, expecting users to provide an explicit read-only=on option.
Now that we have auto-read-only=on, enable these drivers to make use of
the option.
See patch 2 for an explanation of the motivation.
v2:
- Turn bdrv_set_read_only() into bdrv_apply_auto_read_only()
- Support the option in a lot more block drivers
Kevin Wolf (8):
block: Update flags in bdrv_set_read_only()
block: Add auto-read-only option
block: Require auto-read-only for
If read-only=off, but auto-read-only=on is given, just degrade to
read-only.
Signed-off-by: Kevin Wolf
---
block/curl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/curl.c b/block/curl.c
index fabb2b4da7..db5d2bd8ef 100644
--- a/block/curl.c
+++ b/block/curl.
If read-only=off, but auto-read-only=on is given, open the file
read-write if we have the permissions, but instead of erroring out for
read-only files, just degrade to read-only.
Signed-off-by: Kevin Wolf
---
block/file-posix.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/b
If read-only=off, but auto-read-only=on is given, open the volume
read-write if we have the permissions, but instead of erroring out for
read-only volumes, just degrade to read-only.
Signed-off-by: Kevin Wolf
---
block/iscsi.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff -
On 10/12/2018 07:50 PM, Fei Li wrote:
Add a new Error parameter for vnc_display_init() to handle errors
in its caller: vnc_init_func(), just like vnc_display_open() does.
And let its callees propagate the Error, like init_keyboard_layout().
Signed-off-by: Fei Li
As this version do a big adj
Hi
qemu had a assert when we use scsi-3 reservation。
This happen when scsi sence is recoverd error。
And which lead scsi_req_complete twice.
static bool scsi_handle_rw_error(SCSIDiskReq *r, int error, bool acct_failed)
{
bool is_read = (r->req.cmd.mode == SCSI_XFER_FROM_DEV);
SCSIDiskState
On 12.10.18 07:44, Markus Armbruster wrote:
> Copying Marc-André for a possible connection to his recent work on
> improving help. Marc-André, search for "format=help". Just in case you
> have further observations to offer.
>
> Max Reitz writes:
>
>> On 08.10.18 19:31, Markus Armbruster wrote:
Cc'ing Eduardo and Thomas.
On 12/10/2018 13:51, maozy wrote:
> Hi, Philippe
>
> On 10/12/18 5:53 PM, Philippe Mathieu-Daudé wrote:
>> Hi Mao,
>>
>> On 12/10/2018 10:30, Mao Zhongyi wrote:
>>> According to qdev-properties.h, properties of pointer type should
>>> be avoided, it seems a link type pr
Fixes: CID 1395986
Fixes: 979f7ef8966bc4495a710ed9e4af42098f92ee79
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20181005134608.1251-1-kra...@redhat.com
---
hw/display/qxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/qxl.c b/hw/d
This also makes the default display resolution configurable,
via xres and yres properties. The default is 1024x768.
The old code had a hard-coded resolution of 1600x1200.
Cc: Linus Walleij
Cc: BALATON Zoltan
Signed-off-by: Gerd Hoffmann
Message-id: 20181005110837.28209-1-kra...@redhat.com
---
From: Thomas Huth
In downstream distros like RHEL we'd like to disable some of the "legacy"
devices of QEMU. The ISA version of the Cirrus VGA device is one of these
legacy devices. So let's make the build process a little bit more flexible
here by putting the Cirrus ISA code into a separate file
Signed-off-by: Gerd Hoffmann
Message-id: 20181005160147.892-3-kra...@redhat.com
---
hw/display/bochs-display.c | 13 +
hw/display/Makefile.objs | 1 +
2 files changed, 14 insertions(+)
diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
index 09d8944a1b..3d439eb24
This allows modern architectures which don't care about vga
compatibility (risc-v for example) build bochs-display without
including all vga emulation too.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Alistair Francis
Message-id: 20181005160147.892-2-kra...@redhat.com
---
default-configs/pci.mak
The following changes since commit 75e50c80e051423a6f55a34ee4a1eec842444a5b:
Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2018-10-10' into
staging (2018-10-11 10:43:37 +0100)
are available in the git repository at:
git://git.kraxel.org/qemu tags/vga-20181012-pu
ble in the Git repository at:
>
> git://github.com/cohuck/qemu tags/s390x-20181012
>
> for you to fetch changes up to 0161215d435ef5680c4623bcbdfe89ce5b35cf42:
>
> hw/s390x: Include the tod-qemu also for builds wi
Hi Fei,
On 12/10/2018 13:50, Fei Li wrote:
> Add a new Error parameter for vnc_display_init() to handle errors
> in its caller: vnc_init_func(), just like vnc_display_open() does.
> And let its callees propagate the Error, like init_keyboard_layout().
>
> Signed-off-by: Fei Li
> ---
> include/u
While looking at Mao's series
(https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02519.html) I
wondered if devices having link properties can be user-creatable.
Using the following patch (I don't think this is correct to put qdev
code into qobject, but I used this as PoC):
-- >8 --
diff --
1 - 100 of 292 matches
Mail list logo
