[Qemu-devel] [PATCH] spapr_pci: rename some structured types

According to CODING_STYLE, structured types names are expected to be in CamelCase. PCI is dropped from the name for better readability. While here, this also converts a call to g_malloc(n * sizeofi(foo)) to g_new(n, foo), which is a recommended good practice. Signed-off-by: Greg Kurz --- hw/ppc

[Qemu-devel] [PATCH v5 0/3] file-posix: Simplifications on image locking

v5: Address Max's comments (Thanks for reviewing): - Clean up after test done. - Add rev-by to patch 1 and 2. v4: Fix test on systems without OFD. [Patchew] The first patch reduces chances of QEMU crash in unusual (but not unlikely) cases especially when used by Libvirt (see commit messag

[Qemu-devel] [PATCH v5 1/3] file-posix: Skip effectiveless OFD lock operations

If we know we've already locked the bytes, don't do it again; similarly don't unlock a byte if we haven't locked it. This doesn't change the behavior, but fixes a corner case explained below. Libvirt had an error handling bug that an image can get its (ownership, file mode, SELinux) permissions ch

[Qemu-devel] [PATCH v5 3/3] tests: Add unit tests for image locking

Signed-off-by: Fam Zheng --- tests/Makefile.include | 2 + tests/test-image-locking.c | 157 + 2 files changed, 159 insertions(+) create mode 100644 tests/test-image-locking.c diff --git a/tests/Makefile.include b/tests/Makefile.include index 7a3059bf6c

[Qemu-devel] [PATCH v5 2/3] file-posix: Drop s->lock_fd

The lock_fd field is not strictly necessary because transferring locked bytes from old fd to the new one shouldn't fail anyway. This spares the user one fd per image. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- block/file-posix.c | 37 + 1 file change

Re: [Qemu-devel] [PATCH v9 1/3] qmp: query-current-machine with wakeup-suspend-support

Daniel Henrique Barboza writes: > When issuing the qmp/hmp 'system_wakeup' command, what happens in a > nutshell is: > > - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason > and notify the event > - in the main_loop, all vcpus are paused, a system reset is issued, all > sub

Re: [Qemu-devel] [PATCH v9 2/3] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions

Daniel Henrique Barboza writes: > This patch updates the descriptions of 'guest-suspend-ram' and > 'guest-suspend-hybrid' to mention that both commands relies now > on the proper support for wake up from suspend, retrieved by the > 'wakeup-suspend-support' attribute of the 'query-current-machine'

Re: [Qemu-devel] [PATCH] sdl2: Support all virtio-gpu formats

On Wed, Oct 10, 2018 at 07:35:06PM +0200, Max Reitz wrote: > On 10.10.18 12:10, Gerd Hoffmann wrote: > > On Mon, Oct 08, 2018 at 08:50:13PM +0200, Max Reitz wrote: > >> There are some 2D resource formats that can be used through virtio-gpu, > > > > Ahem, not really. XRGB is the only one which wor

Re: [Qemu-devel] [PATCH v9 3/3] qmp hmp: Make system_wakeup check wake-up support and run state

Daniel Henrique Barboza writes: > The qmp/hmp command 'system_wakeup' is simply a direct call to > 'qemu_system_wakeup_request' from vl.c. This function verifies if > runstate is SUSPENDED and if the wake up reason is valid before > proceeding. However, no error or warning is thrown if any of tho

Re: [Qemu-devel] [PATCH v5 0/5] Connect a PCIe host and graphics support to RISC-V

On Thu, Oct 11, 2018 at 07:59:59AM +0200, Andrea Bolognani wrote: > On Wed, 2018-10-10 at 10:57 -0700, Alistair wrote: > > On 10/10/2018 05:26 AM, Andrea Bolognani wrote: > > > * what should libvirt look for to figure out whether or not a RISC-V > > >guest will have PCI support? For aarch64 we

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 6/9] target/s390x: Convert to HAVE_CMPXCHG128 and HAVE_ATOMIC128

On 03/10/2018 21:39, Richard Henderson wrote: > Cc: qemu-s3...@nongnu.org > Signed-off-by: Richard Henderson > --- > target/s390x/mem_helper.c | 92 +-- > 1 file changed, 41 insertions(+), 51 deletions(-) > > diff --git a/target/s390x/mem_helper.c b/target/s39

Re: [Qemu-devel] [PATCH v2 0/4] hw/pci-host/x86: extend the 64-bit PCI hole relative to the fw-assigned base

Michael, On 09/27/18 23:24, Laszlo Ersek wrote: > This is v2 of the series previously posted at > . > > Changes are noted on every patch. can you please merge this series? Please note that it depends on v2 of the following pa

Re: [Qemu-devel] [PATCH v5 0/5] Connect a PCIe host and graphics support to RISC-V

On Thu, Oct 11, 2018 at 07:59:59AM +0200, Andrea Bolognani wrote: > On Wed, 2018-10-10 at 10:57 -0700, Alistair wrote: > > I use this monolithic config: > > https://github.com/alistair23/meta-riscv/blob/7a950aa705b439b5ec19bb6f094930888335ba7b/recipes-kernel/linux/files/freedom-u540/defconfig > >

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 7/9] target/s390x: Split do_cdsg, do_lpq, do_stpq

On 03/10/2018 21:39, Richard Henderson wrote: > Cc: qemu-s3...@nongnu.org > Signed-off-by: Richard Henderson > --- > target/s390x/mem_helper.c | 128 ++ > 1 file changed, 61 insertions(+), 67 deletions(-) > > diff --git a/target/s390x/mem_helper.c b/target/s39

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 8/9] target/s390x: Skip wout, cout helpers if op helper does not return

On 03/10/2018 21:39, Richard Henderson wrote: > When op raises an exception, it may not have initialized the output > temps that would be written back by wout or cout. > > Cc: qemu-s3...@nongnu.org > Signed-off-by: Richard Henderson > --- > target/s390x/translate.c | 12 +++- > 1 file ch

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 9/9] target/s390x: Check HAVE_ATOMIC128 and HAVE_CMPXCHG128 at translate

On 03/10/2018 21:39, Richard Henderson wrote: > Cc: qemu-s3...@nongnu.org > Signed-off-by: Richard Henderson > --- > target/s390x/mem_helper.c | 40 +++ > target/s390x/translate.c | 25 +--- > 2 files changed, 38 insertions(+), 27 deletions

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 0/9] tcg: Reorg 128-bit atomic operations

On 09/10/2018 20:51, Emilio G. Cota wrote: > On Wed, Oct 03, 2018 at 14:39:22 -0500, Richard Henderson wrote: > (snip) >> Richard Henderson (9): >> tcg: Split CONFIG_ATOMIC128 >> target/i386: Convert to HAVE_CMPXCHG128 >> target/arm: Convert to HAVE_CMPXCHG128 >> target/arm: Check HAVE_CMPX

Re: [Qemu-devel] [qemu-s390x] [PATCH v11 0/6] s390x: vfio-ap: guest dedicated crypto adapters

On 10/10/2018 20:15, Christian Borntraeger wrote: > > On 10/10/2018 07:03 PM, Tony Krowiak wrote: >> This patch series is the QEMU counterpart to the KVM/kernel support for >> guest dedicated crypto adapters. The KVM/kernel model is built on the >> VFIO mediated device framework and provides the

Re: [Qemu-devel] [PATCH v2 2/2] monitor: delay monitor iothread creation

On Thu, Oct 11, 2018 at 08:30:24AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Fri, Sep 28, 2018 at 01:00:26PM +0400, Marc-André Lureau wrote: > >> Hi > >> > >> On Fri, Sep 28, 2018 at 12:02 PM Wolfgang Bumiller > >> wrote: > >> > > >> > Commit d32749deb615 moved the call to mon

[Qemu-devel] [PATCH] pci_bridge: fix typo in comment

Signed-off-by: Mao Zhongyi --- hw/pci/pci_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c index 90f7208856..da8daa3ff2 100644 --- a/hw/pci/pci_bridge.c +++ b/hw/pci/pci_bridge.c @@ -399,7 +399,7 @@ void pci_bridge_exitfn(PCIDe

Re: [Qemu-devel] [PATCH 0/4] block: Add auto-read-only option

On Tue, Oct 09, 2018 at 21:35:20 +0200, Kevin Wolf wrote: > Peter, would this provide what libvirt urgently needs for backing files > vs. the commit block job? This looks fine for us with one exception. I'd prefer if the curl driver implemented this too so that we don't have to hardcode the readon

Re: [Qemu-devel] [PATCH v1 3/7] range: pass const pointer where possible

* David Hildenbrand (da...@redhat.com) wrote: > If there are no changes, let's use a const pointer. > > Signed-off-by: David Hildenbrand Reviewed-by: Dr. David Alan Gilbert > --- > include/qemu/range.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/qem

Re: [Qemu-devel] [PATCH v1 5/7] memory-device: use QEMU_IS_ALIGNED

* David Hildenbrand (da...@redhat.com) wrote: > Shorter and easier to read. > > Signed-off-by: David Hildenbrand Reviewed-by: Dr. David Alan Gilbert > --- > hw/mem/memory-device.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/mem/memory-device.c b/hw/mem/m

Re: [Qemu-devel] [PATCH v4 18/24] qdev: hotplug: provide do_unplug handler

On 08/10/2018 16:12, Igor Mammedov wrote: > On Mon, 8 Oct 2018 14:41:50 +0200 > David Hildenbrand wrote: > >> On 08/10/2018 14:19, Igor Mammedov wrote: >>> On Mon, 8 Oct 2018 13:47:53 +0200 >>> David Hildenbrand wrote: >>> > That way using [2] and [1 - modulo it should match only concrete

[Qemu-devel] [PATCH 3/4] audio: use object link instead of qdev property to pass wm8750 reference

According to qdev-properties.h, properties of pointer type should be avoided, it seems a link type property is a good substitution. Cc: Jan Kiszka Cc: Peter Maydell Cc: Gerd Hoffmann To: qemu-...@nongnu.org Signed-off-by: Mao Zhongyi --- hw/arm/musicpal.c | 3 ++- hw/audio/marvell_

[Qemu-devel] [PATCH 2/4] audio: use TYPE_WM8750 instead of a hardcoded string

Cc: Jan Kiszka Cc: Peter Maydell Cc: Gerd Hoffmann To: qemu-...@nongnu.org Signed-off-by: Mao Zhongyi --- hw/arm/musicpal.c | 2 +- hw/audio/marvell_88w8618.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index c807010e83

[Qemu-devel] [PATCH 1/4] wm8750: remove duplicate macro

The header file wm8750.h contains '#define TYPE_WM8750 "wm8750"' macro, but '#define CODEC "wm8750"' macro is redefined in wm8750.c, just remove the local CODEC macro and replace it with TYPE_WM8750. Cc: Gerd Hoffmann Signed-off-by: Mao Zhongyi --- hw/audio/wm8750.c | 18 -- 1

[Qemu-devel] [PATCH 0/4] use object link instead of qdev property

According to qdev-properties.h, properties of pointer type should be avoid, so convert qdev property to link, Whilst we are here, also update some hardcoded strings with already defineded macros. Mao Zhongyi (4): wm8750: remove duplicate macro audio: use TYPE_WM8750 instead of a hardcoded stri

[Qemu-devel] [PATCH 4/4] audio: use existing macros istead of hardcoded strings

Cc: Jan Kiszka Cc: Peter Maydell Cc: Gerd Hoffmann To: qemu-...@nongnu.org Signed-off-by: Mao Zhongyi --- hw/arm/musicpal.c | 16 hw/audio/marvell_88w8618.c | 3 +-- include/hw/audio/wm8750.h | 1 + 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions

* David Hildenbrand (da...@redhat.com) wrote: > Add some more functions that will be used in memory-device context. > > range_init(): Init using lower bound and size > range_valid(): Check if there would be an overflow when initializin > range_size(): Extract the size of a range > range_overlaps_r

Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions

On 11/10/2018 11:08, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> Add some more functions that will be used in memory-device context. >> >> range_init(): Init using lower bound and size >> range_valid(): Check if there would be an overflow when initializin >> ran

[Qemu-devel] [Bug 1797332] Re: qemu nested virtualization is not working with Ubuntu16.04

** Attachment added: "The same question, but markdown readable and with more spaces" https://bugs.launchpad.net/qemu/+bug/1797332/+attachment/5199881/+files/nestedVirtBug.md -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https:/

[Qemu-devel] [Bug 1797332] [NEW] qemu nested virtualization is not working with Ubuntu16.04

Public bug reported: # 1 What am I trying to do ? # I want to use `libvirt` `qemu/KVM` with **nested virtualization** like described in [1] and [2]. **But it does not work with Ubuntu16.04.** It worked some times ago, but not anymore. I want 2 levels of virtualization like this: * L0 – the bar

Re: [Qemu-devel] [qemu-s390x] [PATCH v11 5/6] s390x/vfio: ap: Introduce VFIO AP device

On 2018-10-10 19:03, Tony Krowiak wrote: > Introduces a VFIO based AP device. The device is defined via > the QEMU command line by specifying: > > -device vfio-ap,sysfsdev= > > There may be only one vfio-ap device configured for a guest. > > The mediated matrix device is created by the VFIO

Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions

* David Hildenbrand (da...@redhat.com) wrote: > On 11/10/2018 11:08, Dr. David Alan Gilbert wrote: > > * David Hildenbrand (da...@redhat.com) wrote: > >> Add some more functions that will be used in memory-device context. > >> > >> range_init(): Init using lower bound and size > >> range_valid(): C

Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions

On 11/10/2018 11:21, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> On 11/10/2018 11:08, Dr. David Alan Gilbert wrote: >>> * David Hildenbrand (da...@redhat.com) wrote: Add some more functions that will be used in memory-device context. range_init():

Re: [Qemu-devel] [qemu-s390x] [PATCH v11 0/6] s390x: vfio-ap: guest dedicated crypto adapters

On 2018-10-11 10:12, David Hildenbrand wrote: > On 10/10/2018 20:15, Christian Borntraeger wrote: >> >> On 10/10/2018 07:03 PM, Tony Krowiak wrote: >>> This patch series is the QEMU counterpart to the KVM/kernel support for >>> guest dedicated crypto adapters. The KVM/kernel model is built on the

Re: [Qemu-devel] [PATCH v1 0/5] Misc RISC-V patches

On 10 October 2018 at 19:22, Palmer Dabbelt wrote: > On Wed, 10 Oct 2018 11:10:07 PDT (-0700), peter.mayd...@linaro.org wrote: >> >> On 10 October 2018 at 18:49, Palmer Dabbelt wrote: >>> >>> we should really >>> get the ball rolling on our big patch backlog. >> >> >> Yes, please do. Softfreeze i

Re: [Qemu-devel] [PATCH] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

On 11 October 2018 at 00:55, Brad Smith wrote: > And from FreeBSD... > > MAP_STACK MAP_STACK implies MAP_ANON, and offset of 0. The fd > argument must be -1 and prot must include at least > PROT_READ and PROT_WRITE. > > This option creates a memory region that grows to at > most len bytes in

Re: [Qemu-devel] [PATCH] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

On 11.10.2018 11:36, Peter Maydell wrote: > On 11 October 2018 at 00:55, Brad Smith wrote: >> And from FreeBSD... >> >> MAP_STACK MAP_STACK implies MAP_ANON, and offset of 0. The fd >> argument must be -1 and prot must include at least >> PROT_READ and PROT_WRITE. >> >> This option creates a

Re: [Qemu-devel] [PATCH v11 0/6] s390x: vfio-ap: guest dedicated crypto adapters

On Wed, 10 Oct 2018 20:15:55 +0200 Christian Borntraeger wrote: > On 10/10/2018 07:03 PM, Tony Krowiak wrote: > > This patch series is the QEMU counterpart to the KVM/kernel support for > > guest dedicated crypto adapters. The KVM/kernel model is built on the > > VFIO mediated device framework

Re: [Qemu-devel] [PATCH v2 2/2] monitor: delay monitor iothread creation

Wolfgang Bumiller writes: > On Thu, Oct 11, 2018 at 08:30:24AM +0200, Markus Armbruster wrote: [...] >> Since the bug is inconveniencing people, should I merge v1 for now? We >> can then figure out how to improve on it. > > Tbh I'm unsure which way to proceed at this point. Don't worry, ball's

Re: [Qemu-devel] [PATCH v3 0/4] mips: Increase the insn_flags holder size and clean mips-defs.h

> From: Philippe Mathieu-Daudé on behalf of > Philippe Mathieu-Daudé > Subject: Re: [PATCH v3 0/4] mips: Increase the insn_flags holder size and > clean mips-defs.h > > Ping? I will get back to this series in next few days. Thanks, Aleksandar

Re: [Qemu-devel] [PATCH v11 0/6] s390x: vfio-ap: guest dedicated crypto adapters

On 10/11/2018 11:48 AM, Cornelia Huck wrote: > On Wed, 10 Oct 2018 20:15:55 +0200 > Christian Borntraeger wrote: > >> On 10/10/2018 07:03 PM, Tony Krowiak wrote: >>> This patch series is the QEMU counterpart to the KVM/kernel support for >>> guest dedicated crypto adapters. The KVM/kernel mod

[Qemu-devel] [Bug 1797332] Re: qemu nested virtualization is not working with Ubuntu16.04

** Project changed: qemu => qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1797332 Title: qemu nested virtualization is not working with Ubuntu16.04 Status in qemu package in Ubuntu:

Re: [Qemu-devel] [PATCH RFC v5 1/7] Fix segmentation fault when qemu_signal_init fails

Fei Li writes: > Currently, when qemu_signal_init() fails it only returns a non-zero > value but without propagating any Error. But its callers need a > non-null err when runs error_report_err(err), or else 0->msg occurs. The bug is in qemu_init_main_loop(): ret = qemu_signal_init(); if

[Qemu-devel] [Bug 1368204] Re: WinME isn't able to detect QEMU's cdrom drive and other hard drives automatically

** Changed in: qemu Assignee: John Snow (jnsnow) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368204 Title: WinME isn't able to detect QEMU's cdrom drive and other hard drive

[Qemu-devel] [Bug 639651] Re: DRIVER_IRQL_NOT_LESS_OR_EQUAL booting WIndows XP with Synaptics driver installed

** Package changed: debian => qemu (Debian) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/639651 Title: DRIVER_IRQL_NOT_LESS_OR_EQUAL booting WIndows XP with Synaptics driver installed Status in

Re: [Qemu-devel] virtio-console downgrade the virtio-pci-blk performance

Add Amit Shah. After some tests, we found: - the virtio serial port number is inversely proportional to the iSCSI virtio-blk-pci performance. If we set the virio-serial ports to 2("), the performance downgrade is minimal. - use local disk/ram disk as virtio-blk-pci disk, the performance downgrade

Re: [Qemu-devel] [PATCH v1 7/7] memory-device: rewrite address assignment using ranges

* David Hildenbrand (da...@redhat.com) wrote: > Let's rewrite it properly using ranges. This fixes certain overflows that > are right now possible. E.g. > > qemu-system-x86_64 -m 4G,slots=20,maxmem=40G -M pc \ > -object memory-backend-file,id=mem1,share,mem-path=/dev/zero,size=2G > -device

Re: [Qemu-devel] [PATCH v1 7/7] memory-device: rewrite address assignment using ranges

>> if (hint) { >> -new_addr = *hint; >> -if (new_addr < address_space_start) { >> +if (!range_valid(*hint, size)) { >> error_setg(errp, "can't add memory device [0x%" PRIx64 ":0x%" >> PRIx64 >> - "] before 0x%" PRIx64, new_addr, size,

Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions

* David Hildenbrand (da...@redhat.com) wrote: > On 11/10/2018 11:21, Dr. David Alan Gilbert wrote: > > * David Hildenbrand (da...@redhat.com) wrote: > >> On 11/10/2018 11:08, Dr. David Alan Gilbert wrote: > >>> * David Hildenbrand (da...@redhat.com) wrote: > Add some more functions that will b

Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions

On 11/10/2018 12:27, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> On 11/10/2018 11:21, Dr. David Alan Gilbert wrote: >>> * David Hildenbrand (da...@redhat.com) wrote: On 11/10/2018 11:08, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.

Re: [Qemu-devel] [PATCH v11 5/6] s390x/vfio: ap: Introduce VFIO AP device

On Wed, 10 Oct 2018 13:03:07 -0400 Tony Krowiak wrote: > +static void vfio_ap_class_init(ObjectClass *klass, void *data) > +{ > +DeviceClass *dc = DEVICE_CLASS(klass); > + > +dc->props = vfio_ap_properties; > +dc->vmsd = &vfio_ap_vmstate; > +dc->desc = "VFIO-based AP device assign

Re: [Qemu-devel] [PATCH] pci_bridge: fix typo in comment

On 11/10/2018 10:25, Mao Zhongyi wrote: > Signed-off-by: Mao Zhongyi Reviewed-by: Philippe Mathieu-Daudé > --- > hw/pci/pci_bridge.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c > index 90f7208856..da8daa3ff2 100644 > --- a

Re: [Qemu-devel] [PATCH 1/4] wm8750: remove duplicate macro

Hi Mao, On 11/10/2018 11:00, Mao Zhongyi wrote: > The header file wm8750.h contains '#define TYPE_WM8750 "wm8750"' > macro, but '#define CODEC "wm8750"' macro is redefined in wm8750.c, > just remove the local CODEC macro and replace it with TYPE_WM8750. > > Cc: Gerd Hoffmann > > Signed-off-by:

Re: [Qemu-devel] [PATCH 2/4] audio: use TYPE_WM8750 instead of a hardcoded string

On 11/10/2018 11:00, Mao Zhongyi wrote: > Cc: Jan Kiszka > Cc: Peter Maydell > Cc: Gerd Hoffmann > To: qemu-...@nongnu.org > > Signed-off-by: Mao Zhongyi Reviewed-by: Philippe Mathieu-Daudé > --- > hw/arm/musicpal.c | 2 +- > hw/audio/marvell_88w8618.c | 2 +- > 2 files changed, 2

Re: [Qemu-devel] [PATCH 4/4] audio: use existing macros istead of hardcoded strings

On 11/10/2018 11:00, Mao Zhongyi wrote: > Cc: Jan Kiszka > Cc: Peter Maydell > Cc: Gerd Hoffmann > To: qemu-...@nongnu.org > > Signed-off-by: Mao Zhongyi > --- > hw/arm/musicpal.c | 16 > hw/audio/marvell_88w8618.c | 3 +-- > include/hw/audio/wm8750.h | 1 + > 3 f

Re: [Qemu-devel] [PATCH v3 4/9] target/arm: Check HAVE_CMPXCHG128 at translate time

On 03/10/2018 21:39, Richard Henderson wrote: > Reviewed-by: Emilio G. Cota > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/helper-a64.c| 16 > target/arm/translate-a64.c | 38 ++ > 2 files chan

Re: [Qemu-devel] [PATCH v3 2/9] target/i386: Convert to HAVE_CMPXCHG128

On 03/10/2018 21:39, Richard Henderson wrote: > Reviewed-by: Emilio G. Cota > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > target/i386/mem_helper.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/target/i386/mem_helper.c b/tar

[Qemu-devel] [PATCH] qcow2: Get the request alignment for encrypted images from QCryptoBlock

This doesn't have any practical effect at the moment because the values of BDRV_SECTOR_SIZE, QCRYPTO_BLOCK_LUKS_SECTOR_SIZE and QCRYPTO_BLOCK_QCOW_SECTOR_SIZE are all the same (512 bytes), but future encryption methods could have different requirements. Signed-off-by: Alberto Garcia --- block/qc

Re: [Qemu-devel] [PATCH] qcow2: Get the request alignment for encrypted images from QCryptoBlock

On Thu, Oct 11, 2018 at 01:58:02PM +0300, Alberto Garcia wrote: > This doesn't have any practical effect at the moment because the > values of BDRV_SECTOR_SIZE, QCRYPTO_BLOCK_LUKS_SECTOR_SIZE and > QCRYPTO_BLOCK_QCOW_SECTOR_SIZE are all the same (512 bytes), but > future encryption methods could ha

Re: [Qemu-devel] [PATCH] spapr_pci: rename some structured types

Hi Greg, On 11/10/2018 09:00, Greg Kurz wrote: > According to CODING_STYLE, structured types names are expected to be > in CamelCase. PCI is dropped from the name for better readability. > > While here, this also converts a call to g_malloc(n * sizeofi(foo)) to sizeof(foo) > g_new(n, foo), whic

Re: [Qemu-devel] [PATCH 1/1] qmp, hmp: make subsystem/system-vendor identities optional

* Markus Armbruster (arm...@redhat.com) wrote: > "Denis V. Lunev" writes: > > > According to PCI specification subsystem id and subsystem vendor id are > > optinal and could be abscent in Type1 header and can be found on > > different offsets within Type0 and Type2 headers. > > Well, they *are*

Re: [Qemu-devel] [PATCH 4/4] audio: use existing macros istead of hardcoded strings

On 11 October 2018 at 11:45, Philippe Mathieu-Daudé wrote: > On 11/10/2018 11:00, Mao Zhongyi wrote: >> Cc: Jan Kiszka >> Cc: Peter Maydell >> Cc: Gerd Hoffmann >> To: qemu-...@nongnu.org >> >> Signed-off-by: Mao Zhongyi >> --- >> hw/arm/musicpal.c | 16 >> hw/audio/

Re: [Qemu-devel] [PATCH v11 0/6] s390x: vfio-ap: guest dedicated crypto adapters

On 11/10/2018 12:00, Christian Borntraeger wrote: On 10/11/2018 11:48 AM, Cornelia Huck wrote: On Wed, 10 Oct 2018 20:15:55 +0200 Christian Borntraeger wrote: On 10/10/2018 07:03 PM, Tony Krowiak wrote: This patch series is the QEMU counterpart to the KVM/kernel support for guest dedicated

[Qemu-devel] [PATCH v4 00/22] Misc MIPS fixes and improvements for October 2018

From: Aleksandar Markovic This series contains support for MIPS ABI flags in elf.h, hardware page table walker, DSP R3 availability control, and emulation of nanoMIPS EVA instructions. It also contains support for WatchHi, MemoryMapID, SAARI, and SAAR registers, ITU updates, implementation of DRA

[Qemu-devel] [PATCH v4 01/22] elf: Fix PT_MIPS_XXX constants

From: Stefan Markovic Fix existing and add missing PT_MIPS_XXX constants in elf.h. This is copied from kernel header arch/mips/include/asm/elf.h. Signed-off-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- include/elf.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) d

[Qemu-devel] [PATCH v4 02/22] elf: Add MIPS_ABI_FP_XXX constants

From: Stefan Markovic Add MIPS_ABI_FP_XXX constants to elf.h. The source of information is kernel header arch/mips/include/asm/elf.h. Signed-off-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- include/elf.h | 8 1 file changed, 8 insertions(+) diff --git a/include/elf.h b

[Qemu-devel] [PATCH v4 11/22] target/mips: Add CP0 SAARI and SAAR registers

From: Yongbok Kim SAARI (Special Address Access Register Index) provides an index into the SAAR register to indicate whether the ITU or other block is being accessed. SAAR (Special Address Access Register) stores the base address where the ITU will be located, as well as the block size. Signed-o

[Qemu-devel] [PATCH v4 06/22] target/mips: Add CPO PWSize register

From: Yongbok Kim Add PWSize register (CP0 Register 5, Select 7). The PWSize register configures hardware page table walking for TLB refills. This register is required for the hardware page walker feature. It exists only if Config3 PW bit is set to 1. It contains following fields: GDW (29..24

[Qemu-devel] [PATCH v4 05/22] target/mips: Add CPO PWField register

From: Yongbok Kim Add PWField register (CP0 Register 5, Select 6). The PWField register configures hardware page table walking for TLB refills. This register is required for the hardware page walker feature. It exists only if Config3 PW bit is set to 1. It contains following fields: GDI (29..

[Qemu-devel] [PATCH v4 07/22] target/mips: Add CPO PWCtl register

From: Yongbok Kim Add PWCtl register (CP0 Register 5, Select 6). The PWCtl register configures hardware page table walking for TLB refills. This register is required for the hardware page walker feature. It exists only if Config3 PW bit is set to 1. It contains following fields: PWEn (31)

[Qemu-devel] [PATCH v4 13/22] target/mips: Add availability control for DSP R3 ASE

From: Stefan Markovic Add infrastructure for availability control for DSP R3 ASE MIPS instructions. Only BPOSGE32C currently belongs to DSP R3 ASE, but this is likely to be changed in near future. Reviewed-by: Aleksandar Markovic Signed-off-by: Stefan Markovic Signed-off-by: Aleksandar Markovi

[Qemu-devel] [PATCH v4 08/22] target/mips: Implement hardware page table walker

From: Yongbok Kim Implement hardware page table walker. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic --- target/mips/helper.c| 369 +++- target/mips/internal.h | 1 + target/mips/op_helper.c | 7 +- 3 files changed, 374 ins

[Qemu-devel] [PATCH v4 16/22] target/mips: Add opcodes for nanoMIPS EVA instructions

From: Dimitrije Nikolic Add opcodes for nanoMIPS EVA instructions: CACHEE, LBE, LBUE, LHE, LHUE, LLE, LLWPE, LWE, PREFE, SBE, SCE, SCWPE, SHE, SWE. Signed-off-by: Dimitrije Nikolic Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 34 ++ 1 file c

[Qemu-devel] [PATCH v4 09/22] target/mips: Extend WatchHi registers

From: Yongbok Kim WatchHi is extended by the field MemoryMapID with the GINVT instruction. The field is accessible by MTHC0/MFHC0 in 32-bit architectures and DMTC0/DMFC0 in 64-bit architectures. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 2 +-

[Qemu-devel] [PATCH v4 15/22] target/mips: Fix emulation of microMIPS R6 SELEQZ. SELNEZ.

From: Matthew Fortune Fix emulation of microMIPS R6 SELEQZ. SELNEZ. instructions. Their handling was permuted. Signed-off-by: Matthew Fortune Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tar

[Qemu-devel] [PATCH v4 03/22] elf: Add Mips_elf_abiflags_v0 structure

From: Stefan Markovic Add Mips_elf_abiflags_v0 structure to elf.h. The source of information is kernel header arch/mips/include/asm/elf.h. Signed-off-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- include/elf.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/i

[Qemu-devel] [PATCH v4 20/22] target/mips: Add DEC feature to mips32r6-generic CPU

From: Yongbok Kim Set Config5.DEC Dual Endian Capability bit of mips32r6-generic CPU. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic --- target/mips/translate_init.inc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/mips/translate_init.inc.c b/tar

[Qemu-devel] [PATCH v4 04/22] target/mips: Add CPO PWBase register

From: Yongbok Kim Add PWBase register (CP0 Register 5, Select 5). The PWBase register contains the Page Table Base virtual address. This register is required for the hardware page walker feature. It exists only if Config3 PW bit is set to 1. Signed-off-by: Yongbok Kim Signed-off-by: Aleksanda

[Qemu-devel] [PATCH v4 19/22] hw/mips: Add Data Scratch Pad RAM

From: Yongbok Kim The optional Data Scratch Pad RAM (DSPRAM) block provides a general scratch pad RAM used for temporary storage of data. The DSPRAM provides a connection to on-chip memory or memory-mapped registers, which are accessed in parallel with the L1 data cache to minimize access latency

[Qemu-devel] [PATCH v4 10/22] target/mips: Add CPO MemoryMapID register

From: Yongbok Kim Add CPO MemoryMapID register. It is used by Global TLB Invalidate instruction (GINVT). Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 1 + target/mips/internal.h | 1 + target/mips/machine.c | 4 3 files changed, 6 insertions

[Qemu-devel] [PATCH v4 14/22] target/mips: Improve DSP R2/R3-related naming

From: Stefan Markovic Do following replacements: ASE_DSPR2 -> ASE_DSP_R2 ASE_DSPR3 -> ASE_DSP_R3 check_dspr2() -> check_dsp_r2() check_dspr3() -> check_dsp_r3() Signed-off-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- target/mips/internal.h | 4 +- target/mips/mips-d

[Qemu-devel] [PATCH v4 12/22] target/mips: Add bit definitions for DSP R3 ASE

From: Stefan Markovic Add DSP R3 ASE related bit definition for insn_flags and hflags. Reviewed-by: Aleksandar Markovic Signed-off-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 1 + target/mips/mips-defs.h | 1 + 2 files changed, 2 insertions(+) diff -

[Qemu-devel] [PATCH v4 21/22] target/mips: Add MSA ASE to MIPS64R2-generic CPU

From: Yongbok Kim Add MSA ASE to MIPS64R2-generic CPU. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic --- target/mips/translate_init.inc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target/mips/translate_init.inc.c b/target/mips/translate_init.in

Re: [Qemu-devel] [PATCH v3] python: Use io.StringIO

Am 10.10.2018 um 23:31 hat Philippe Mathieu-Daudé geschrieben: > Both Python 2.7 and 3 support the same io.StringIO to > handle unicode strings. > > Use the common form to use indistinctly Python 2.7 or 3. > > http://python-future.org/compatible_idioms.html#stringio > > This fixes running tests

[Qemu-devel] [PATCH v4 22/22] target/mips: Add I6500 core configuration

From: Yongbok Kim Add I6500 core configuration. Note that this configuration is supported only by best-effort due to lack of certain features in QEMU. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic --- target/mips/translate_init.inc.c | 43 ++

[Qemu-devel] [PATCH v4 17/22] target/mips: Implement emulation of nanoMIPS EVA instructions

From: Dimitrije Nikolic Implement emulation of nanoMIPS EVA instructions. They are all part of P.LS.E0 instruction pool, or one of its subpools. Signed-off-by: Dimitrije Nikolic Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 79 +++

Re: [Qemu-devel] [PATCH v11 0/6] s390x: vfio-ap: guest dedicated crypto adapters

On Wed, 10 Oct 2018 13:03:02 -0400 Tony Krowiak wrote: > This patch series is the QEMU counterpart to the KVM/kernel support for > guest dedicated crypto adapters. The KVM/kernel model is built on the > VFIO mediated device framework and provides the infrastructure for > granting exclusive gue

[Qemu-devel] [PATCH] ccid-card-passthru: check buffer size parameter

From: Prasad J Pandit While reading virtual smart card data, if buffer 'size' is negative it would lead to memory corruption errors. Add check to avoid it. Reported-by: Arash TC Signed-off-by: Prasad J Pandit --- hw/usb/ccid-card-passthru.c | 1 + 1 file changed, 1 insertion(+) diff --git a/

[Qemu-devel] [PATCH v4 18/22] hw/mips: Update ITU to utilise SAARI/SAAR registers

From: Yongbok Kim Update the ITU to utilise SAARI/SAAR registers and add new ITU Control Register (ICR0). Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic --- hw/mips/cps.c | 8 ++ hw/misc/mips_itu.c | 72 +- i

Re: [Qemu-devel] [PATCH v5 0/5] Connect a PCIe host and graphics support to RISC-V

On Thu, Oct 11, 2018 at 09:01:14AM +0100, Richard W.M. Jones wrote: > Here are the settings we currently do NOT have in my RV kernel: > > CONFIG_HOTPLUG_PCI_PCIE=y > CONFIG_HOTPLUG_PCI=y > CONFIG_MEDIA_PCI_SUPPORT=y > CONFIG_PCI_ATS=y > CONFIG_PCI_DEBUG=y > CONFIG_PCIEAER=y > CONFIG_PCIEASPM_DEFAU

Re: [Qemu-devel] [PULL 0/5] Miscellaneous patches for 2018-10-10

On 10 October 2018 at 07:11, Markus Armbruster wrote: > The following changes since commit 7c69b7c849641a39ba3defa40d384a2ba24cd7a2: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20181008' into staging (2018-10-08 > 15:01:30 +0100) > > are available in the Git repos

Re: [Qemu-devel] [PATCH] ccid-card-passthru: check buffer size parameter

Cc'ing Paolo & Marc-André. On 11/10/2018 13:24, P J P wrote: > From: Prasad J Pandit > > While reading virtual smart card data, if buffer 'size' is negative > it would lead to memory corruption errors. Add check to avoid it. The IOReadHandler does not have documentation. typedef void IOReadHa

Re: [Qemu-devel] [PATCH v5 0/5] Connect a PCIe host and graphics support to RISC-V

On 11 October 2018 at 08:55, Richard W.M. Jones wrote: > Can we ignore non-PCIe guests? virtio-mmio should die. I note that Edgar's recent Xilinx Versal patchset adds a new user of virtio-mmio. If that statement is meant to apply generally it might be worth starting the discussion in that patcht

Re: [Qemu-devel] [PATCH v4 17/22] target/mips: Implement emulation of nanoMIPS EVA instructions

Hi Aleksandar, On 11/10/2018 13:22, Aleksandar Markovic wrote: > From: Dimitrije Nikolic > > Implement emulation of nanoMIPS EVA instructions. They are all > part of P.LS.E0 instruction pool, or one of its subpools. > > Signed-off-by: Dimitrije Nikolic Thanks for adding Dimitrije's S-o-b. >

Re: [Qemu-devel] [libvirt] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

* Peter Krempa (pkre...@redhat.com) wrote: > On Tue, Oct 09, 2018 at 19:34:43 +0200, Markus Armbruster wrote: > > Cc: libvir-list for review of the compatibility argument below. > > > > Daniel Henrique Barboza writes: > > > > > Hey David, > > > > > > On 9/21/18 9:29 AM, Dr. David Alan Gilbert wr

Re: [Qemu-devel] [PATCH v9 1/3] qmp: query-current-machine with wakeup-suspend-support

On 10/11/18 4:38 AM, Markus Armbruster wrote: Daniel Henrique Barboza writes: When issuing the qmp/hmp 'system_wakeup' command, what happens in a nutshell is: - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason and notify the event - in the main_loop, all vcpus are pa

[Qemu-devel] [PATCH] i440fx: use ARRAY_SIZE for pam_regions

Cc: qemu-triv...@nongnu.org Signed-off-by: Li Qiang --- hw/pci-host/piix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 0e608347c1..230d5d2ea3 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -142,7 +142,7 @@ st

  1   2   3   4   >