Signed-off-by: Li Qiang
---
hw/core/loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/loader.c b/hw/core/loader.c
index aa0b3fc867..910f9a97a9 100644
--- a/hw/core/loader.c
+++ b/hw/core/loader.c
@@ -837,7 +837,7 @@ struct Rom {
uint8_t *data;
MemoryRe
Hi Peter,
On 10/8/18 8:47 AM, Peter Xu wrote:
> There are two callers for vtd_sync_shadow_page_table_range(): one
> provided a valid context entry and one not. Move that fetching
> operation into the caller vtd_sync_shadow_page_table() where we need to
> fetch the context entry.
>
> Meanwhile, r
Hi Peter,
On 10/8/18 8:47 AM, Peter Xu wrote:
> We should handle VTD_FR_CONTEXT_ENTRY_P properly when synchronizing
> shadow page tables. Having invalid context entry there is perfectly
> valid when we move a device out of an existing domain. When that
> happens, instead of posting an error we i
On Mon, 8 Oct 2018 19:31:01 +0200
Markus Armbruster wrote:
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. 9p-handle.c's handle_parse_opts() does that, and then
> fails without setting an error. Wrong. Its caller crashes when it
> tries to report the er
On Tue, Oct 09, 2018 at 09:27:15AM +0200, Auger Eric wrote:
[...]
> > @@ -1056,12 +1058,28 @@ static int
> > vtd_sync_shadow_page_table(VTDAddressSpace *vtd_as)
> > {
> > int ret;
> > VTDContextEntry ce;
> > +IOMMUNotifier *n;
> >
> > ret = vtd_dev_to_context_entry(vtd_as->
On Mon, 8 Oct 2018 19:31:22 +0200
Markus Armbruster wrote:
> Calling error_report() from within a a function that takes an Error **
> argument is suspicious. qemu_fsdev_add() does that, and its caller
> fsdev_init_func() then fails without setting an error. Its caller
> main(), via qemu_opts_f
There are two callers for vtd_sync_shadow_page_table_range(): one
provided a valid context entry and one not. Move that fetching
operation into the caller vtd_sync_shadow_page_table() where we need to
fetch the context entry.
Meanwhile, remove the error_report_once() directly since we're already
v3:
- pick r-b
- return when -VTD_FR_CONTEXT_ENTRY_P is detected (v1 is correct here,
but I did wrong thing when splitting the patch in v2) [Eric]
v2:
- split patch into more, remove useless comment [Eric]
- remove one error_report_once() when rework the code [Jason]
This series fixes a QEMU cr
The gen_BUG() function calls already cpu_abort(), which prints the
information to stderr and the log already. So instead of additionally
printing the dc->pc via fprintf() and qemu_log here, too, we can
simply pass this information to cpu_abort() instead.
Signed-off-by: Thomas Huth
---
target/cri
We should handle VTD_FR_CONTEXT_ENTRY_P properly when synchronizing
shadow page tables. Having invalid context entry there is perfectly
valid when we move a device out of an existing domain. When that
happens, instead of posting an error we invalidate the whole region.
Without this patch, QEMU w
Hi Thomas,
On 09/10/2018 09:46, Thomas Huth wrote:
> The gen_BUG() function calls already cpu_abort(), which prints the
> information to stderr and the log already. So instead of additionally
> printing the dc->pc via fprintf() and qemu_log here, too, we can
> simply pass this information to cpu_a
Hi Peter,
On 10/9/18 9:45 AM, Peter Xu wrote:
> We should handle VTD_FR_CONTEXT_ENTRY_P properly when synchronizing
> shadow page tables. Having invalid context entry there is perfectly
> valid when we move a device out of an existing domain. When that
> happens, instead of posting an error we i
On 09/10/2018 09:08, Li Qiang wrote:
> Signed-off-by: Li Qiang
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/core/loader.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/loader.c b/hw/core/loader.c
> index aa0b3fc867..910f9a97a9 100644
> --- a/hw/core/loader
Hi
On Tue, Oct 9, 2018 at 2:03 AM Max Reitz wrote:
>
> First of all, this patch broke iotest 082. But then again, all that'd
> be needed is a correction of the reference output.
Oops, ok. Let see if we change it again,
>
> However:
>
> On 07.09.18 09:59, Marc-André Lureau wrote:
> > Modify qem
Public bug reported:
I am trying to run an OpenSUSE PowerPC Little Endian system under Microsoft
Windows. I have an English UK keyboard. The keyboard is basically correct (I
get a 'pound' sign when I press shift-3) but some of the keys are rendered
incorrectly. The wrong keys are
\ renders as #
Pavel Dovgalyuk writes:
>> From: Alex Bennée [mailto:alex.ben...@linaro.org]
>> Any serious analysis tool should allow for us to track all memory
>> accesses so I think the guest_mem_before trace point should probably
>> be split into guest_mem_before_store and guest_mem_after_load. We
>> could
> From: Alex Bennée [mailto:alex.ben...@linaro.org]
> Pavel Dovgalyuk writes:
>
> >> From: Alex Bennée [mailto:alex.ben...@linaro.org]
> >> Any serious analysis tool should allow for us to track all memory
> >> accesses so I think the guest_mem_before trace point should probably
> >> be split int
On Mon 08 Oct 2018 08:46:57 PM CEST, Max Reitz wrote:
> On 08.10.18 20:13, Alberto Garcia wrote:
>> On Mon 08 Oct 2018 04:48:50 AM CEST, Max Reitz wrote:
>>
+/* Old values are used for options that aren't set yet */
+old_options = qdict_clone_shallow(bs->options);
+bdrv_
Hi
On Tue, Oct 9, 2018 at 10:28 AM Peter Xu wrote:
>
> Currently when QMP request queue full we won't resume the monitor until
> we have completely handled the current command. It's not necessary
> since even before it's handled the queue is already non-full. Moving
> the resume logic earlier be
On 10/09/2018 09:45 AM, Peter Xu wrote:
v3:
- pick r-b
- return when -VTD_FR_CONTEXT_ENTRY_P is detected (v1 is correct here,
but I did wrong thing when splitting the patch in v2) [Eric]
v2:
- split patch into more, remove useless comment [Eric]
- remove one error_report_once() when rework
Please try the following patch.
There was a problem with rtc option in record/replay mode.
diff --git a/vl.c b/vl.c
index 40d5d0f..afe1c20 100644
--- a/vl.c
+++ b/vl.c
@@ -2885,6 +2885,7 @@ int main(int argc, char **argv, char **envp)
DisplayState *ds;
QemuOpts *opts, *machine_
Peter Maydell writes:
> On 5 October 2018 at 15:13, Thomas Huth wrote:
>> When compiling with "--disable-tcg", we currently still use "tcg"
>> as default accelerator. "kvm" should be used in this case instead.
>
> This part is non-controversial and makes good sense.
Agreed.
>> Also, some downs
On 8 October 2018 at 23:17, Stefano Stabellini wrote:
> I double-checked all the addresses and they are correct. For some reason
> after starting the guest, ATS12NSOPW starts to fail for
> ffc006f91628, which is the same virtual address corresponding to the
> same runstate region allocated in
Hi
On Mon, Oct 8, 2018 at 9:38 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. pc.c's pc_machine_set_nvdimm_persistence() does that,
> and then exit()s. Wrong. Attempting to set machine property
> nvdimm-persistence to a bad
On Mon, Oct 8, 2018 at 9:35 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. ioapic_realize() does that, and then exit()s.
> Currently mostly harmless, as the device cannot be hot-plugged.
>
> Fixes: 20fd4b7b6d9282fe0cb83601f182
Paolo Bonzini writes:
> On 04/10/2018 12:53, Thomas Huth wrote:
>> The file "qemu-options.h", "qemu-options.hx" and "qemu-options-wrapper.h"
>> in the main directory are currently without maintainer according to our
>> get_maintainers.pl script. Considering that the command line options are
>> a
Hi
On Mon, Oct 8, 2018 at 9:47 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. smbios_entry_add() does that, and then exit()s. It
> also passes &error_fatal to qemu_opts_validate(). Both wrong, but
> currently harmless, as it
Pavel Dovgalyuk writes:
>> From: Alex Bennée [mailto:alex.ben...@linaro.org]
>> Pavel Dovgalyuk writes:
>>
>> >> From: Alex Bennée [mailto:alex.ben...@linaro.org]
>> >> Any serious analysis tool should allow for us to track all memory
>> >> accesses so I think the guest_mem_before trace point
Hi
On Mon, Oct 8, 2018 at 9:33 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. save_snapshot() and load_snapshot() do that, and then
> fail without setting an error. Wrong. The HMP commands survive this
> unscathed, since hmp
On 8 October 2018 at 22:34, Edgar E. Iglesias wrote:
> On Mon, Oct 08, 2018 at 02:10:29PM +0100, Peter Maydell wrote:
>> On 3 October 2018 at 16:07, Edgar E. Iglesias
>> wrote:
>> > From: "Edgar E. Iglesias"
>> >
>> > Add the ARM Cortex-A72.
>> >
>> > Signed-off-by: Edgar E. Iglesias
>> > +
Hi
On Mon, Oct 8, 2018 at 9:54 PM Markus Armbruster wrote:
>
> When -netdev l2tpv3 fails, it first reports a specific error, then a
> generic one, like this:
>
> $ qemu-system-x86_64 -netdev l2tpv3,id=foo,src=,dst=,txsession=1
> qemu-system-x86_64: -netdev l2tpv3,id=foo,src=,dst=,txsession
On 05/10/2018 11:20, David Hildenbrand wrote:
> This series completes refactoring of pre_plug, plug and unplug logic of
> memory devices. With this as a basis, we can built e.g. virtio
> based memory devices or internal "RAM chip" devices.
>
> I dropped the virtio-pmem prototype for now, I will lo
Hi
On Mon, Oct 8, 2018 at 9:45 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. net_socket_fd_init() does that, and then fails without
> setting an error. Wrong. I didn't analyze how exactly this can
> break. A caller that re
Am 08.10.2018 um 21:53 hat Eric Blake geschrieben:
> On 10/8/18 11:40 AM, Kevin Wolf wrote:
> > Am 08.10.2018 um 17:43 hat Peter Maydell geschrieben:
> > > Looking at the backtraces I'm wondering if this is the result of
> > > an implicit reliance on the order in which per-thread destructors
> > >
ok, so lets forget about the stuttering and just concentrate on what broke in
3.0
Can you try building the bleeding edge qemu and see if the problem still exists
?
Dave
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.l
We can re-use the s390-ccw bios code to implement a small firmware
for a s390x guest which prints out the "A" and "B" characters and
modifies the memory, as required for the migration test.
[quintela: Converted the compile script to Makefile rules]
Signed-off-by: Juan Quintela
Signed-off-by: Thom
Hi
On Mon, Oct 8, 2018 at 9:50 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. parse_sandbox() does that, and then fails without
> setting an error. Its caller main(), via qemu_opts_foreach(), is fine
> with it, but clean it
Markus Armbruster writes:
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. Convert a few that are actually warnings to
> warn_report().
>
> While there, split a warning consisting of multiple sentences to
> conform to conventions spelled out in warn_repor
On Mon, 8 Oct 2018 14:10:50 -0500
Eric Blake wrote:
> On 10/1/18 3:59 AM, Igor Mammedov wrote:
>
> >>> Anyway, what about this:
> >>>
> >>> The command returns an object with a "qom-path" member for each
> >>> present CPU. In this case, it shows an IvyBridge-IBRS-x86_64-cpu in
> >>>
Hi
On Mon, Oct 8, 2018 at 9:44 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. parse_add_fd() does that, and then fails without
> setting an error. Its caller main(), via qemu_opts_foreach(), is fine
> with it, but clean it u
Signed-off-by: Li Qiang
---
include/exec/memory.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 3a427aa..1fbbdaf 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -935,7 +935,7 @@ uint64_t memory_regio
On 9 October 2018 at 11:21, Li Qiang wrote:
> Signed-off-by: Li Qiang
> ---
> include/exec/memory.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Thanks. Contents of patch
Reviewed-by: Peter Maydell
but the commit message should say "fix typos", not "fix types"
(a 'typo' is a
On 8 October 2018 at 17:16, Cornelia Huck wrote:
> On Mon, 8 Oct 2018 17:32:04 +0200
> David Hildenbrand wrote:
>
>> linux-user should always enable AFP, otherwise our emulated binary
>> might crash once it tries to make use of additional floating-point
>> registers or instructions.
>>
>> Cc: Pe
Peter Maydell 于2018年10月9日周二 下午6:26写道：
> On 9 October 2018 at 11:21, Li Qiang wrote:
> > Signed-off-by: Li Qiang
> > ---
> > include/exec/memory.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Thanks. Contents of patch
> Reviewed-by: Peter Maydell
>
> but the commit messa
On 08/10/2018 19:31, Markus Armbruster wrote:
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. tpm_init_tpmdev() does that, and then fails without
> setting an error. Its caller main(), via tpm_init() and
> qemu_opts_foreach(), is fine with it, but clean it
On 05/10/2018 11:20, David Hildenbrand wrote:
> Handle id==NULL better and indicate that we are dealing with memory
> devices.
>
> Signed-off-by: David Hildenbrand
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/mem/memory-device.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
Hi
On Mon, Oct 8, 2018 at 9:39 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. user_creatable_add_opts_foreach() does that, and then
> fails without setting an error. Its caller main(), via
> qemu_opts_foreach(), is fine with
Hi
On Mon, Oct 8, 2018 at 9:51 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. chardev_init_func() does that, and then fails without
> setting an error. Its caller main(), via qemu_opts_foreach(), is fine
> with it, but clean
On 08/10/2018 18:40, Kevin Wolf wrote:
>>
>> I'm pretty confident this analysis of the problem is correct:
>> unfortunately I have no idea what the right way to fix it is...
> Yes, I agree with your analysis. If __thread variables can be destructed
> before pthread_key_create() destructors are call
Hi
On Mon, Oct 8, 2018 at 9:47 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. machine_set_property() does that, and then fails without
> setting an error. Its caller main(), via qemu_opts_foreach(), is fine
> with it, but cl
Theodore Dubois writes:
> ping http://patchwork.ozlabs.org/patch/786393/
Applied to tct-tests/next with another patch to work around enterq.
Sorry for the delay.
>
> ~Theodore
>
>> On Jul 10, 2017, at 1:57 PM, Theodore Dubois wrote:
>>
>> Clang's assembler is slightly incompatible with GCC's
Hi
On Mon, Oct 8, 2018 at 9:37 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. mon_init_func() does that, and then fails without
> setting an error. Its caller main(), via qemu_opts_foreach(), is fine
> with it, but clean it
(Since all previous patches are already merged to master, I'm running tests
against latest (almost) version from master branch. Following results are
based on master commit dafd95053611aa14dda40266857608d12ddce658 .)
Applying this patch made Tests 1 and 2 succeed (at least I wasn't able to
acheive
Hi
On Mon, Oct 8, 2018 at 9:57 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. parse_fw_cfg() does that, and then fails without
> setting an error. Its caller main(), via qemu_opts_foreach(), is fine
> with it, but clean it
On Mon, 8 Oct 2018 14:39:42 +0200
Thomas Huth wrote:
> The spapr-rng device is suboptimal when compared to virtio-rng, so
> users might want to disable it in their builds. Thus let's introduce
> a proper CONFIG switch to allow us to compile QEMU without this device.
> The function spapr_rng_popu
Maybe this will help?
https://www.mail-archive.com/qemu-devel@nongnu.org/msg560780.html
Pavel Dovgalyuk
From: Artem Pisarenko [mailto:artem.k.pisare...@gmail.com]
Sent: Tuesday, October 09, 2018 2:24 PM
To: Pavel Dovgalyuk
Cc: pavel.dovga...@ispras.ru; qemu-devel@nongnu.org
Subject: Re
Hi
On Mon, Oct 8, 2018 at 9:38 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. vnc_init_func() does that, and then fails without
> setting an error. Its caller main(), via qemu_opts_foreach(), is fine
> with it, but clean it
Hi
On Mon, Oct 8, 2018 at 9:33 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. tpm_init_tpmdev() does that, and then fails without
> setting an error. Its caller main(), via tpm_init() and
> qemu_opts_foreach(), is fine with
Hi Thomas,
On 08/10/2018 14:39, Thomas Huth wrote:
> The spapr-rng device is suboptimal when compared to virtio-rng, so
> users might want to disable it in their builds. Thus let's introduce
> a proper CONFIG switch to allow us to compile QEMU without this device.
> The function spapr_rng_populate
Hi
On Mon, Oct 8, 2018 at 9:43 PM Markus Armbruster wrote:
>
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. add_channel() does that, and then exit()s. Its caller
> main(), via qemu_opts_foreach(), is fine with it, but clean it up
> anyway.
>
> Cc: Gerd H
Eduardo Habkost writes:
> On Wed, Oct 03, 2018 at 12:46:05PM +0200, Kashyap Chamarthy wrote:
>> While at it, s/QMU/QEMU in @CpuDefinitionInfo.
>>
>> Signed-off-by: Kashyap Chamarthy
>
> Reviewed-by: Eduardo Habkost
>
> Will this go through the QAPI tree?
Queued with the commit message updated
On 5 October 2018 at 17:09, Laurent Vivier wrote:
> On 05/10/2018 17:25, Richard Henderson wrote:
>> On 10/5/18 4:10 AM, Peter Maydell wrote:
>>> On 5 October 2018 at 01:28, Laurent Vivier wrote:
I have the following error when building on Fedora 28 and gcc (GCC)
8.1.1 20180712 (Red Hat
Hi,
I start a virtual machine with commandline:
/usr/libexec/qemu-kvm --enable-kvm -smp 8 -m 8192 -device
vfio-pci,host=:81:00.0
Then I pause the qemu process before executing the main_loop function by gdb.
At this moment, lspci shows the regions are disabled like below:
81:00.0 3D c
On Fri, Sep 21, 2018 at 01:02:05PM +0200, Simon Ruderich wrote:
> On Tue, Aug 21, 2018 at 02:38:02PM +0200, Simon Ruderich wrote:
>> Hello,
>>
>> I've adapted the patch to error out if a char/block device is
>> used. I think that's the simplest fix for the issue mentioned by
>> Eric Blake.
>>
>> Ar
On Sat 06 Oct 2018 01:39:59 AM CEST, Max Reitz wrote:
> This function queries a node; since we cannot do that right now, it
> executes query-named-block-nodes and returns the matching node's object.
>
> Signed-off-by: Max Reitz
> ---
Reviewed-by: Alberto Garcia
Berto
Philippe Mathieu-Daudé writes:
> Hi Alex,
>
> On Mon, Oct 8, 2018 at 5:21 PM Alex Bennée wrote:
>> We have reached the point where the MacOSX build was regularly timing
>> out. So as before I've reduced the target list to "major"
>> architectures to try and bring the build time down. I've adde
Hi
On Mon, Oct 8, 2018 at 11:15 AM Peter Xu wrote:
>
> On Tue, Oct 02, 2018 at 01:13:10PM +0400, Marc-André Lureau wrote:
> > Hi Peter
> >
> > On Sat, Sep 29, 2018 at 8:05 AM Peter Xu wrote:
> > >
> > > On Fri, Sep 28, 2018 at 04:06:30PM +0400, Marc-André Lureau wrote:
> > > > Hi
> > > >
> > > >
On 9 October 2018 at 13:24, Alex Bennée wrote:
>
> Philippe Mathieu-Daudé writes:
>> I'd also add another entry with --enable-user.
>
> Ohh, does MacOSX use the bsd-user machinery?
No. It used to have its own darwin-user, but we removed
that some years ago because it was unmaintained and broken.
Emilio G. Cota writes:
> v1: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01146.html
>
> Changes since v1:
Hmm I'm seeing some qtest failures, for example:
$ make check-qtest-alpha V=1
...
QTEST_QEMU_BINARY=alpha-softmmu/qemu-system-alpha QTEST_QEMU_IMG=qemu-img
MALLOC_PERT
On Mon, Oct 08, 2018 at 01:27:26PM +0200, Vitaly Kuznetsov wrote:
> Hyper-V PV IPI support is merged to KVM, enable the feature in Qemu. When
> enabled, this allows Windows guests to send IPIs to other vCPUs with a
> single hypercall even when there are >64 vCPUs in the request.
>
> Signed-off-by:
On Mon, Oct 08, 2018 at 01:27:25PM +0200, Vitaly Kuznetsov wrote:
> This brings us three new defines: KVM_CAP_ARM_INJECT_SERROR_ESR,
> KVM_CAP_MSR_PLATFORM_INFO and KVM_CAP_HYPERV_SEND_IPI.
>
> Signed-off-by: Vitaly Kuznetsov
> ---
> linux-headers/linux/kvm.h | 7 +--
> 1 file changed, 5 ins
The XTS cipher mode is significantly slower than CBC mode. This series
approximately doubles the XTS performance which will improve the I/O
rate for LUKS disks.
Daniel P. Berrangé (6):
crypto: expand algorithm coverage for cipher benchmark
crypto: remove code duplication in tweak encrypt/decry
Add testing coverage for AES with XTS, ECB and CTR modes
Signed-off-by: Daniel P. Berrangé
---
tests/benchmark-crypto-cipher.c | 149 +++-
1 file changed, 126 insertions(+), 23 deletions(-)
diff --git a/tests/benchmark-crypto-cipher.c b/tests/benchmark-crypto-cipher.
The tweak encrypt/decrypt functions are identical except for the
comments, so can be merged. Profiling data shows that the compiler is
in fact already merging the two merges in the object files.
Signed-off-by: Daniel P. Berrangé
---
crypto/xts.c | 64 -
The new type is designed to allow use of 64-bit arithmetic instead
of operating 1-byte at a time. The following patches will use this to
improve performance.
Signed-off-by: Daniel P. Berrangé
---
crypto/xts.c | 45 +
1 file changed, 25 insertions(+), 2
Using 64-bit arithmetic increases the performance for xts-aes-128
when built with gcrypt:
Encrypt: 320 MB/s -> 460 MB/s
Decrypt: 325 MB/s -> 485 MB/s
Signed-off-by: Daniel P. Berrangé
---
crypto/xts.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git
Encouraging the compiler to inline xts_tweak_encdec increases the
performance for xts-aes-128 when built with gcrypt:
Encrypt: 460 MB/s -> 485 MB/s
Decrypt: 485 MB/s -> 505 MB/s
Signed-off-by: Daniel P. Berrangé
---
crypto/xts.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(
"Denis V. Lunev" writes:
> According to PCI specification subsystem id and subsystem vendor id are
> optinal and could be abscent in Type1 header and can be found on
> different offsets within Type0 and Type2 headers.
Well, they *are* absent in Type1 headers. Perhaps:
According to PCI specif
Using 64-bit arithmetic increases the performance for xts-aes-128
when built with gcrypt:
Encrypt: 235 MB/s -> 320 MB/s
Decrypt: 245 MB/s -> 325 MB/s
Signed-off-by: Daniel P. Berrangé
---
crypto/xts.c | 52 +---
1 file changed, 33 insertions(+
On Mon, Oct 08, 2018 at 03:08:14PM +0100, Peter Maydell wrote:
> On 3 October 2018 at 16:07, Edgar E. Iglesias
> wrote:
> > In QEMU we'd like to have a virtual developer board with the Versal SoC
> > and a selected set of peripherals under the control of QEMU.
> > We'd like to gradually extend th
It wasn't so easy to apply this patch due to problems in compilation of
version you pointed to, and due to content distortions introduced by mail
archive, but I got it worked finally :)
Applying this patch finally made all my tests succeed... almost :)
Now qemu may hang in random moment of emulat
Roman Kagan writes:
> On Mon, Oct 08, 2018 at 01:27:25PM +0200, Vitaly Kuznetsov wrote:
>> This brings us three new defines: KVM_CAP_ARM_INJECT_SERROR_ESR,
>> KVM_CAP_MSR_PLATFORM_INFO and KVM_CAP_HYPERV_SEND_IPI.
>>
>> Signed-off-by: Vitaly Kuznetsov
>> ---
>> linux-headers/linux/kvm.h | 7 ++
When an object is in turn owned by another user object, it is not
desirable to expose this in the QOM object hierarchy, as it is
just an internal implementation detail, we should be free to change
without exposure.
Signed-off-by: Daniel P. Berrangé
---
qom/object.c| 12
An update to
v2: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04469.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg05660.html
v4: https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg02961.html
The current network services now support encryption via TLS and i
The inotify userspace API for reading events is quite horrible, so it is
useful to wrap it in a more friendly API to avoid duplicating code
across many users in QEMU. Wrapping it also allows introduction of a
platform portability layer, so that we can add impls for non-Linux based
equivalents in fu
Li Qiang writes:
> Hello Philippe,
>
> Philippe Mathieu-Daudé 于2018年10月9日周二 下午1:52写道：
>
>> Hi Li,
>>
>> On 09/10/2018 04:39, Li Qiang wrote:
>> > It makes sense to print the error message while reading
>> > file failed.
[...]
>> > diff --git a/vl.c b/vl.c
>> > index 4e25c78..69fc77c 100644
>> >
IN_ISDIR is not a bit that one can request when registering a
watch with inotify_add_watch. Rather it is a bit that is set
automatically when reading events from the kernel.
Signed-off-by: Daniel P. Berrangé
---
hw/usb/dev-mtp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
The internal inotify APIs allow alot of conditional statements to be
cleared out, and provide a simpler callback for handling events.
Signed-off-by: Daniel P. Berrangé
---
hw/usb/dev-mtp.c| 250
hw/usb/trace-events | 2 +-
2 files changed, 93 in
From: "Daniel P. Berrange"
Add an authorization backend that talks to PAM to check whether the user
identity is allowed. This only uses the PAM account validation facility,
which is essentially just a check to see if the provided username is permitted
access. It doesn't use the authentication or
This brings us three new defines: KVM_CAP_ARM_INJECT_SERROR_ESR,
KVM_CAP_MSR_PLATFORM_INFO and KVM_CAP_HYPERV_SEND_IPI.
Signed-off-by: Vitaly Kuznetsov
---
linux-headers/linux/kvm.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
index
Add a QAuthZListFile object type that implements the QAuthZ interface. This
built-in implementation is a proxy around the QAtuhZList object type,
initializing it from an external file, and optionally, automatically
reloading it whenever it changes.
To create an instance of this object via the QMP
Various functions accepting 'char *' string parameters were missing
'const' qualifiers.
Signed-off-by: Daniel P. Berrangé
---
hw/usb/dev-mtp.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index f026419e47..ccbe25820b 100644
--- a
From: "Daniel P. Berrange"
The current qemu_acl module provides a simple access control list
facility inside QEMU, which is used via a set of monitor commands
acl_show, acl_policy, acl_add, acl_remove & acl_reset.
Note there is no ability to create ACLs - the network services (eg VNC
server) wer
Hyper-V PV IPI enlightenment was merged to KVM (kvm/queue currently).
Support the feature enablement in Qemu.
Changes since v1 [Roman Kagan]:
- Strip kvm.h with 'make headers_install' before putting to Qemu.
- Add Reviewed-by: to PATCH2
Vitaly Kuznetsov (2):
linux-headers: update to pre-4.20 (k
In many cases a single VM will just need to whilelist a single identity
as the allowed user of network services. This is especially the case for
TLS live migration (optionally with NBD storage) where we just need to
whitelist the x509 certificate distinguished name of the source QEMU
host.
Via QMP
From: "Daniel P. Berrange"
The 'qemu_acl' type was a previous non-QOM based attempt to provide an
authorization facility in QEMU. Because it is non-QOM based it cannot be
created via the command line and requires special monitor commands to
manipulate it.
The new QAuthZ subclasses provide a supe
Hyper-V PV IPI support is merged to KVM, enable the feature in Qemu. When
enabled, this allows Windows guests to send IPIs to other vCPUs with a
single hypercall even when there are >64 vCPUs in the request.
Signed-off-by: Vitaly Kuznetsov
Reviewed-by: Roman Kagan
---
target/i386/cpu.c
Hi,
Here is a small series of fixes for the monitor, mostly related to
threading issues.
Marc-André Lureau (6):
monitor: inline ambiguous helper functions
monitor: accept chardev input from iothread
char: add a QEMU_CHAR_FEATURE_GCONTEXT flag
monitor: check if chardev can switch gcontext
From: "Daniel P. Berrange"
Add a QAuthZList object type that implements the QAuthZ interface. This
built-in implementation maintains a trivial access control list with a
sequence of match rules and a final default policy. This replicates the
functionality currently provided by the qemu_acl module
Chardev backends may not handle safely IO events from concurrent
threads. Better to wake up the chardev from the monitor IO thread if
it's being used as the chardev context.
Signed-off-by: Marc-André Lureau
---
monitor.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff -
1 - 100 of 315 matches
Mail list logo
