Re: [Qemu-devel] [RFC PATCH 0/3] acceptance tests: Test firmware checking debug console output

2018-10-03 Thread Laszlo Ersek
On 10/03/18 02:23, Cleber Rosa wrote: > On 9/28/18 6:51 AM, Laszlo Ersek wrote: >> I'm not sure if Avocado provides disk image preparation utilities, but >> perhaps (a) we could use the vvfat driver (*shudder*) or (b) we could >> preformat a small image, and track it as a binary file in git.

Re: [Qemu-devel] [PATCH 0/3] per-TLB lock

2018-10-03 Thread Paolo Bonzini
On 02/10/2018 23:29, Emilio G. Cota wrote: > This series introduces a per-TLB lock. This removes existing UB > (e.g. memset racing with cmpxchg on another thread while flushing), > and in my opinion makes the TLB code simpler to understand. > > I had a bit of trouble finding the best place to init

Re: [Qemu-devel] [PATCH] hw/pci-host/ppce500: Use DeviceState::realize rather than SysBusDevice::init

2018-10-03 Thread Philippe Mathieu-Daudé
On Wed, Oct 3, 2018 at 7:39 AM Cédric Le Goater wrote: > On 10/2/18 11:53 PM, Philippe Mathieu-Daudé wrote: > > Move from the legacy SysBusDevice::init method to using > > DeviceState::realize. > > > > Signed-off-by: Philippe Mathieu-Daudé > > That patch was already reviewed by you and merged by

Re: [Qemu-devel] [PATCH v5 5/9] docs/clocks: add device's clock documentation

2018-10-03 Thread Philippe Mathieu-Daudé
Hi Damien, On 02/10/2018 16:24, Damien Hedde wrote: > Add the documentation about the clock inputs and outputs in devices. > > This is based on the original work of Frederic Konrad. > > Signed-off-by: Damien Hedde > --- > docs/devel/clock.txt | 163 +++ >

Re: [Qemu-devel] [PATCH v5 4/9] qdev-clock: introduce an init array to ease the device construction

2018-10-03 Thread Philippe Mathieu-Daudé
On 02/10/2018 16:24, Damien Hedde wrote: > Introduce a function and macro helpers to setup several clocks > in a device from a static array description. > > An element of the array describes the clock (name and direction) as > well as the related callback and an optional offset to store the > crea

Re: [Qemu-devel] [PATCH 02/13] target/arm: Define new EXCP type for v8M stack overflows

2018-10-03 Thread Philippe Mathieu-Daudé
On 02/10/2018 18:35, Peter Maydell wrote: > Define EXCP_STKOF, and arrange for it to cause us to take > a UsageFault with CFSR.STKOF set. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/cpu.h| 2 ++ > target/arm/helper.c | 5 + > 2 files changed

Re: [Qemu-devel] [PATCH 03/13] target/arm: Move v7m_using_psp() to internals.h

2018-10-03 Thread Philippe Mathieu-Daudé
On 02/10/2018 18:35, Peter Maydell wrote: > We're going to want v7m_using_psp() in op_helper.c in the > next patch, so move it from helper.c to internals.h. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/internals.h | 15 +++ > target/arm/h

Re: [Qemu-devel] [PATCH 06/13] target/arm: Add v8M stack checks on exception entry

2018-10-03 Thread Philippe Mathieu-Daudé
On 02/10/2018 18:35, Peter Maydell wrote: > Add checks for breaches of the v8M stack limit when the > stack pointer is decremented to push the exception frame > for exception entry. > > Note that the exception-entry case is unique in that the > stack pointer is updated to be the limit value if the

Re: [Qemu-devel] [PATCH 07/13] target/arm: Add v8M stack limit checks on NS function calls

2018-10-03 Thread Philippe Mathieu-Daudé
On 02/10/2018 18:35, Peter Maydell wrote: > Check the v8M stack limits when pushing the frame for a > non-secure function call via BLXNS. > > In order to be able to generate the exception we need to > promote raise_exception() from being local to op_helper.c > so we can call it from helper.c. > >

Re: [Qemu-devel] [PATCH 09/13] target/arm: Add v8M stack checks for Thumb2 LDM/STM

2018-10-03 Thread Philippe Mathieu-Daudé
On 02/10/2018 18:35, Peter Maydell wrote: > Add the v8M stack checks for: > * LDM (T2 encoding) > * STM (T2 encoding) > > This includes the 32-bit encodings of the instructions listed > in v8M ARM ARM rule R_YVWT as > * LDM, LDMIA, LDMFD > * LDMDB, LDMEA > * POP (multiple registers) > * PUSH

[Qemu-devel] [PATCH 1/1] vl.c: call optional script when exiting

2018-10-03 Thread Dominik Csapak
some users might want to call a script when qemu exits, without listening to a qmp monitor for events when running with --daemonize this can be used for things like external cleanups Signed-off-by: Dominik Csapak --- qemu-options.hx | 18 ++ vl.c| 45

Re: [Qemu-devel] [PATCH 09/15] hw/mips/malta: Replace 'empty_slot' by 'unimplemented_device'

2018-10-03 Thread Peter Maydell
On 2 October 2018 at 20:40, Philippe Mathieu-Daudé wrote: > On 10/2/18 3:23 PM, Peter Maydell wrote: >> Not sure about this one. unimplemented_device means "there should >> be something here, but QEMU's model is incomplete", and if the user >> asks for 'unimp' warnings via the -d option then all a

Re: [Qemu-devel] [PATCH 11/13] target/arm: Add v8M stack checks for Thumb push/pop

2018-10-03 Thread Philippe Mathieu-Daudé
On 02/10/2018 18:35, Peter Maydell wrote: > Add v8M stack checks for the 16-bit Thumb push/pop > encodings: STMDB, STMFD, LDM, LDMIA, LDMFD. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- > target/arm/translate.c | 16 +++- > 1 file changed, 15 insertio

[Qemu-devel] [PATCH 0/1] add exit-script option to qemu

2018-10-03 Thread Dominik Csapak
this patch aims to execute a script when qemu exits so that one can do cleanups when using --daemonize without having to use the qmp monitor for now i have mostly copied the script execution code from the launch_script function of net/tap.c as i am not sure if it would make sense to refactor that

Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Disable test-bdrv-drain and test-replication

2018-10-03 Thread Peter Maydell
On 2 October 2018 at 21:11, John Snow wrote: > > > On 10/01/2018 09:20 AM, Peter Maydell wrote: >> The test-bdrv-drain and test-replication tests have >> intermittent errors which make my build testing process >> fail way too often. Disable them both for the moment. >> >> Signed-off-by: Peter Mayd

Re: [Qemu-devel] [PATCH] softfloat: Fix division

2018-10-03 Thread Alex Bennée
Richard Henderson writes: > The __udiv_qrnnd primitive that we nicked from gmp requires its > inputs to be normalized. We were not doing that. Because the > inputs are nearly normalized already, finishing that is trivial. > Inline div128to64 into its one user, because it is no longer a > gene

Re: [Qemu-devel] [PATCH 2/3] cputlb: serialize tlb updates with env->tlb_lock

2018-10-03 Thread Alex Bennée
Emilio G. Cota writes: > Currently we rely on atomic operations for cross-CPU invalidations. > There are two cases that these atomics miss: cross-CPU invalidations > can race with either (1) vCPU threads flushing their TLB, which > happens via memset, or (2) vCPUs calling tlb_reset_dirty on the

Re: [Qemu-devel] [PATCH v3 00/18] fleecing-hook driver for backup

2018-10-03 Thread Vladimir Sementsov-Ogievskiy
02.10.2018 23:19, Eric Blake wrote: > On 10/1/18 5:29 AM, Vladimir Sementsov-Ogievskiy wrote: >> v2 was "[RFC v2] new, node-graph-based fleecing and backup" >> >> Hi all! >> >> These series introduce fleecing-hook driver. It's a filter-node, which >> do copy-before-write operation. Mirror uses filt

Re: [Qemu-devel] [PATCH 12/13] target/arm: Add v8M stack checks for VLDM/VSTM

2018-10-03 Thread Philippe Mathieu-Daudé
On 02/10/2018 18:35, Peter Maydell wrote: > Add the v8M stack checks for the VLDM/VSTM > (aka VPUSH/VPOP) instructions. This code is currently > unreachable because we haven't yet implemented M profile > floating point support, but since the change is simple, > we add it now because otherwise we're

Re: [Qemu-devel] [PATCH 2/3] cputlb: serialize tlb updates with env->tlb_lock

2018-10-03 Thread Paolo Bonzini
On 03/10/2018 11:19, Alex Bennée wrote: >> Fix it by using tlb_lock, a per-vCPU lock. All updaters of tlb_table >> and the corresponding victim cache now hold the lock. >> The readers that do not hold tlb_lock must use atomic reads when >> reading .addr_write, since this field can be updated by oth

Re: [Qemu-devel] [PATCH] fpu/softfloat: Replace countLeadingZeros32/64 with clz32/64

2018-10-03 Thread Philippe Mathieu-Daudé
On 28/09/2018 09:01, Thomas Huth wrote: > Our minimum required compiler for compiling QEMU is GCC 4.1 these days, > so we can drop the support for compilers which do not provide the > __builtin_clz*() functions yet. Since the countLeadingZeros32/64 are > then identical to the clz32/64 functions, an

Re: [Qemu-devel] [PULL v4 00/80] Misc patches for 2018-09-30

2018-10-03 Thread Peter Maydell
On 2 October 2018 at 18:22, Paolo Bonzini wrote: > The following changes since commit 3892f1f1a963e59dfe012cd9d461d33b2986fa3b: > > Merge remote-tracking branch 'remotes/dgibson/tags/libfdt-20181002' into > staging (2018-10-02 09:54:44 +0100) > > are available in the git repository at: > > >

Re: [Qemu-devel] [PATCH 0/1] add exit-script option to qemu

2018-10-03 Thread Philippe Mathieu-Daudé
Hi Dominik, On 03/10/2018 11:13, Dominik Csapak wrote: > this patch aims to execute a script when qemu exits > so that one can do cleanups when using --daemonize without > having to use the qmp monitor > > for now i have mostly copied the script execution code from > the launch_script function of

Re: [Qemu-devel] [PATCH 1/1] vl.c: call optional script when exiting

2018-10-03 Thread Philippe Mathieu-Daudé
On 03/10/2018 11:13, Dominik Csapak wrote: > some users might want to call a script when qemu exits, without listening > to a qmp monitor for events when running with --daemonize > > this can be used for things like external cleanups > > Signed-off-by: Dominik Csapak > --- > qemu-options.hx | 1

Re: [Qemu-devel] [PATCH 13/13] target/arm: Add v8M stack checks for MSR to SP_NS

2018-10-03 Thread Philippe Mathieu-Daudé
On 02/10/2018 18:35, Peter Maydell wrote: > Updating the NS stack pointer via MSR to SP_NS should include > a check whether the new SP value is below the stack limit. > No other kinds of update to the various stack pointer and > limit registers via MSR should perform a check. > > Signed-off-by: Pe

[Qemu-devel] [PATCH] block: replace "discard" literal with BDRV_OPT_DISCARD macro

2018-10-03 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- block.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 7710b399a3..0d6e5f1a76 100644 --- a/block.c +++ b/block.c @@ -1327,7 +1327,7 @@ QemuOptsList bdrv_runtime_opts = { .help = "try to optimize zero

Re: [Qemu-devel] [PATCH 05/13] target/arm: Add some comments in Thumb decode

2018-10-03 Thread Philippe Mathieu-Daudé
On 02/10/2018 18:35, Peter Maydell wrote: > Add some comments to the Thumb decoder indicating what bits > of the instruction have been decoded at various points in > the code. > > This is not an exhaustive set of comments; we're gradually > adding comments as we work with particular bits of the co

Re: [Qemu-devel] [PATCH 3/5] hyperv: factor out arch-independent API into hw/hyperv

2018-10-03 Thread Paolo Bonzini
On 21/09/2018 10:20, Roman Kagan wrote: > A significant part of hyperv.c is not actually tied to x86, and can > be moved to hw/. > > This will allow to maintain most of Hyper-V and VMBus > target-independent, and to avoid conflicts with inclusion of > arch-specific headers down the road in VMBus i

[Qemu-devel] [PULL 5/6] chardev: mark the calls that allow an implicit mux monitor

2018-10-03 Thread Marc-André Lureau
This is mostly for readability of the code. Let's make it clear which callers can create an implicit monitor when the chardev is muxed. This will also enforce a safer behaviour, as we don't really support creating monitor anywhere/anytime at the moment. Add an assert() to make sure the programmer

[Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType

2018-10-03 Thread Kashyap Chamarthy
While at it, s/QMU/QEMU in @CpuDefinitionInfo. Signed-off-by: Kashyap Chamarthy --- qapi/misc.json | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qapi/misc.json b/qapi/misc.json index ada9af5add..f98de3a58c 100644 --- a/qapi/misc.json +++ b/qapi/misc.json @@ -20

[Qemu-devel] [PULL 3/6] chardev: unref if underlying chardev has no parent

2018-10-03 Thread Marc-André Lureau
It's possible to write code creating a chardev backend that is not registered. When it is not user-created, it makes sense to keep it hidden. Let the associated frontend destroy it also in this case. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- chardev/char-fe.c | 7

Re: [Qemu-devel] [PATCH 4/5] default-configs: collect CONFIG_HYPERV* in hyperv.mak

2018-10-03 Thread Paolo Bonzini
On 21/09/2018 10:20, Roman Kagan wrote: > diff --git a/default-configs/hyperv.mak b/default-configs/hyperv.mak > new file mode 100644 > index 00..3d45e28403 > --- /dev/null > +++ b/default-configs/hyperv.mak > @@ -0,0 +1,2 @@ > +CONFIG_HYPERV=$(CONFIG_KVM) > +CONFIG_HYPERV_TESTDEV=$(CONFIG_

Re: [Qemu-devel] [PATCH 10/13] target/arm: Add v8M stack checks for T32 load/store single

2018-10-03 Thread Philippe Mathieu-Daudé
On 02/10/2018 18:35, Peter Maydell wrote: > Add v8M stack checks for the instructions in the T32 > "load/store single" encoding class: these are the > "immediate pre-indexed" and "immediate, post-indexed" > LDR and STR instructions. > > Signed-off-by: Peter Maydell > --- > target/arm/translate.c

[Qemu-devel] [PULL 2/6] chardev: remove qemu_chr_fe_read_all() counter

2018-10-03 Thread Marc-André Lureau
There is no obvious reason to have a loop counter. This limits from reading several megabytes large buffers in one go, since socket read/write usually have a limit. Signed-off-by: Marc-André Lureau Reviewed-by: Paolo Bonzini --- chardev/char-fe.c | 6 +- 1 file changed, 1 insertion(+), 5 de

[Qemu-devel] [PULL 0/6] Chardev patches

2018-10-03 Thread Marc-André Lureau
The following changes since commit dafd95053611aa14dda40266857608d12ddce658: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-10-02 18:27:18 +0100) are available in the Git repository at: https://github.com/elmarco/qemu.git tags/chardev-pull-request for y

Re: [Qemu-devel] [PATCH 05/10] hyperv: add synic message delivery

2018-10-03 Thread Paolo Bonzini
On 21/09/2018 10:22, Roman Kagan wrote: > +typedef struct HvSintStagedMesage { > +/* message content staged by hyperv_post_msg */ > +struct hyperv_message msg; > +/* callback + data (r/o) to complete the processing in a BH */ > +HvSintMsgCb cb; > +void *cb_data; > +/* messag

[Qemu-devel] [PULL 1/6] chardev: avoid crash if no associated address

2018-10-03 Thread Marc-André Lureau
A socket chardev may not have associated address (when adding client fd manually for example). But on disconnect, updating socket filename expects an address and may lead to this crash: Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. 0x55d8c70c in SocketAddress_

[Qemu-devel] [PULL 4/6] char.h: fix gtk-doc comment style

2018-10-03 Thread Marc-André Lureau
Fix up conformance to GTK-Doc function comment style, as documented in https://developer.gnome.org/gtk-doc-manual/stable/documenting_symbols.html.en Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Markus Armbruster --- include/chardev/char-fe.h | 81 ++

Re: [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType

2018-10-03 Thread Marc-André Lureau
Hi On Wed, Oct 3, 2018 at 3:02 PM Kashyap Chamarthy wrote: > > While at it, s/QMU/QEMU in @CpuDefinitionInfo. > > Signed-off-by: Kashyap Chamarthy Reviewed-by: Marc-André Lureau > --- > qapi/misc.json | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/qapi/

[Qemu-devel] [PULL 6/6] chardev: use a child source for qio input source

2018-10-03 Thread Marc-André Lureau
GLib child source were added with version 2.28. We can use them now that we bumped our requirement to 2.40. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- chardev/char-io.c | 48 +-- 1 file changed, 5 insertions(+), 43 deletions(

Re: [Qemu-devel] [PATCH 00/10] hyperv: add connection infrastructure

2018-10-03 Thread Paolo Bonzini
On 21/09/2018 10:22, Roman Kagan wrote: > This series introduces the infrastructure to send and receive Hyper-V > messages and events. > > More specifically, > > - SynIC is turned into a full-fledged device managing the memory regions > used for QEMU->guest communication > - machinery is introd

Re: [Qemu-devel] [PATCH 3/5] hyperv: factor out arch-independent API into hw/hyperv

2018-10-03 Thread Roman Kagan
On Wed, Oct 03, 2018 at 12:56:00PM +0200, Paolo Bonzini wrote: > On 21/09/2018 10:20, Roman Kagan wrote: > > A significant part of hyperv.c is not actually tied to x86, and can > > be moved to hw/. > > > > This will allow to maintain most of Hyper-V and VMBus > > target-independent, and to avoid c

[Qemu-devel] [PATCH 0/3] Mark non-volatile memory regions

2018-10-03 Thread Marc-André Lureau
Hi, As discussed in the "[PATCH v10 6/6] tpm: add ACPI memory clear interface" thread, and proposed in the "[PATCH] RFC: mark non-volatile memory region", here is a small series to mark non-volvatile memory regions and skip them on dump. Upcoming TCG "Platform Reset Attack Mitigation" will also us

[Qemu-devel] [PATCH 3/3] memory-mapping: skip non-volatile memory regions in GuestPhysBlockList

2018-10-03 Thread Marc-André Lureau
GuestPhysBlockList is currently used to produce dumps. Given the size and the typical usage of NVDIMM for storage, they are not a good idea to have in the dumps. We may want to have an extra dump option to include them. For now, skip non-volatile regions. The TCG memory clear function is going to

Re: [Qemu-devel] [PATCH v2 15/15] arm/xlnx-zynqmp: put APUs and RPUs in separate GDB groups

2018-10-03 Thread Luc Michel
On 10/2/18 1:58 PM, Peter Maydell wrote: > On 2 October 2018 at 12:33, Philippe Mathieu-Daudé wrote: >> Cc'ing more QOM involved people. >> >> On 01/10/2018 13:57, Luc Michel wrote: >>> Create two separate QOM containers for APUs and RPUs to indicate to the >>> GDB stub that those CPUs should b

[Qemu-devel] [PATCH 1/3] memory: learn about non-volatile memory region

2018-10-03 Thread Marc-André Lureau
Add a new flag to mark memory region that are used as non-volatile, by NVDIMM for example. That bit is propagated down to the flat view, and reflected in HMP info mtree with a "nv-" prefix on the memory type. This way, guest_phys_blocks_region_add() can skip the NV memory regions for dumps and TCG

[Qemu-devel] [PATCH 2/3] nvdimm: set non-volatile on the memory region

2018-10-03 Thread Marc-André Lureau
qemu-system-x86_64 -machine pc,nvdimm -m 2G,slots=4,maxmem=16G -enable-kvm -monitor stdio -object memory-backend-file,id=mem1,share=on,mem-path=/tmp/foo,size=1G -device nvdimm,id=nvdimm1,memdev=mem1 HMP info mtree command reflects the flag with "nv-" prefix on memory type: (qemu) info mtree 00

Re: [Qemu-devel] [PATCH 3/5] hyperv: factor out arch-independent API into hw/hyperv

2018-10-03 Thread Paolo Bonzini
On 03/10/2018 13:34, Roman Kagan wrote: > On Wed, Oct 03, 2018 at 12:56:00PM +0200, Paolo Bonzini wrote: >> On 21/09/2018 10:20, Roman Kagan wrote: >>> A significant part of hyperv.c is not actually tied to x86, and can >>> be moved to hw/. >>> >>> This will allow to maintain most of Hyper-V and VM

[Qemu-devel] [PATCH] gtk: fix uninitialized variable

2018-10-03 Thread Paolo Bonzini
zoom_to_fit is never initialized to false, Coverity complains (not sure why GCC does not). Fixes: e8b1386ea1719525a1a92df03377764703fe8c64 Cc: kra...@redhat.com Signed-off-by: Paolo Bonzini --- ui/gtk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index

Re: [Qemu-devel] [PATCH v4 1/6] block/dirty-bitmaps: add user_locked status checker

2018-10-03 Thread Eric Blake
On 10/2/18 6:02 PM, John Snow wrote: Instead of both frozen and qmp_locked checks, wrap it into one check. frozen implies the bitmap is split in two (for backup), and shouldn't be modified. qmp_locked implies it's being used by another operation, like being exported over NBD. In both cases it mea

Re: [Qemu-devel] [PATCH v4 2/6] block/dirty-bitmaps: fix merge permissions

2018-10-03 Thread Eric Blake
On 10/2/18 6:02 PM, John Snow wrote: In prior commits that made merge transactionable, we removed the assertion that merge cannot operate on disabled bitmaps. In addition, we want to make sure that we are prohibiting merges to "locked" bitmaps. Use the new user_locked function to check. Reporte

Re: [Qemu-devel] [PATCH v4 3/6] block/dirty-bitmaps: allow clear on disabled bitmaps

2018-10-03 Thread Eric Blake
On 10/2/18 6:02 PM, John Snow wrote: Similarly to merge, it's OK to allow clear operations on disabled bitmaps, as this condition only means that they are not recording new writes. We are free to clear it if the user requests it. Signed-off-by: John Snow --- block/dirty-bitmap.c | 1 - block

Re: [Qemu-devel] [PATCH v4 4/6] block/dirty-bitmaps: prohibit enable/disable on locked/frozen bitmaps

2018-10-03 Thread Eric Blake
On 10/2/18 6:02 PM, John Snow wrote: We're not being consistent about this. If it's in use by an operation, the user should not be able to change the behavior of that bitmap. Signed-off-by: John Snow --- blockdev.c | 26 -- 1 file changed, 20 insertions(+), 6 deletion

Re: [Qemu-devel] [PATCH v4 6/6] nbd: forbid use of frozen bitmaps

2018-10-03 Thread Eric Blake
On 10/2/18 6:02 PM, John Snow wrote: Whether it's "locked" or "frozen", it's in use and should not be allowed for the purposes of this operation. Signed-off-by: John Snow --- nbd/server.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nbd/server.c b/nbd/server.c inde

Re: [Qemu-devel] [PATCH v4 5/6] block/backup: prohibit backup from using in use bitmaps

2018-10-03 Thread Eric Blake
On 10/2/18 6:02 PM, John Snow wrote: If the bitmap is frozen, we shouldn't touch it. Signed-off-by: John Snow --- blockdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.c index d0febfca79..098d4c337f 100644 --- a/blockdev.c +++ b/blo

Re: [Qemu-devel] [PATCH v4 1/6] block/dirty-bitmaps: add user_locked status checker

2018-10-03 Thread Vladimir Sementsov-Ogievskiy
03.10.2018 02:02, John Snow wrote: Instead of both frozen and qmp_locked checks, wrap it into one check. frozen implies the bitmap is split in two (for backup), and shouldn't be modified. qmp_locked implies it's being used by another operation, like being exported over NBD. In both cases it means

Re: [Qemu-devel] [PATCH v2 05/12] qom/object: fix iterating properties over a class

2018-10-03 Thread Paolo Bonzini
On 07/09/2018 09:59, Marc-André Lureau wrote: > object_class_property_iter_init() starts from the given class, so the > next class should continue with the parent class. > > Signed-off-by: Marc-André Lureau > --- > qom/object.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --

Re: [Qemu-devel] [PATCH v2 06/12] qom/object: register 'type' property as class property

2018-10-03 Thread Paolo Bonzini
On 07/09/2018 09:59, Marc-André Lureau wrote: > Let's save a few byte in each object instance. > > (Is this property really used anywhere? Only qom-get could read it) Well, it's not really used but it's part of the external API. > Signed-off-by: Marc-André Lureau > --- > qom/object.c | 7 -

Re: [Qemu-devel] [PATCH v4 2/6] block/dirty-bitmaps: fix merge permissions

2018-10-03 Thread Vladimir Sementsov-Ogievskiy
03.10.2018 02:02, John Snow wrote: > In prior commits that made merge transactionable, we removed the > assertion that merge cannot operate on disabled bitmaps. In addition, > we want to make sure that we are prohibiting merges to "locked" bitmaps. > > Use the new user_locked function to check. > >

Re: [Qemu-devel] [PATCH 05/10] hyperv: add synic message delivery

2018-10-03 Thread Roman Kagan
On Wed, Oct 03, 2018 at 01:06:58PM +0200, Paolo Bonzini wrote: > On 21/09/2018 10:22, Roman Kagan wrote: > > +typedef struct HvSintStagedMesage { > > +/* message content staged by hyperv_post_msg */ > > +struct hyperv_message msg; > > +/* callback + data (r/o) to complete the processing

Re: [Qemu-devel] [PATCH v2 00/12] Various qemu command line options help improvements

2018-10-03 Thread Paolo Bonzini
On 02/10/2018 12:54, Marc-André Lureau wrote: >>> >>> This is a compilation of patches I have to improve command line help >>> support. The "qemu-option" patches have already been sent earlier, I >>> modified the first to fix an issue reported by Markus. The other >>> patches add support for -objec

Re: [Qemu-devel] [PATCH v2 10/12] vl: handle -object help

2018-10-03 Thread Paolo Bonzini
On 07/09/2018 09:59, Marc-André Lureau wrote: > List the user creatable objects. > > Signed-off-by: Marc-André Lureau > --- > vl.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/vl.c b/vl.c > index 5ba06adf78..71765a2982 100644 > --- a/vl.c > +++ b/vl.c > @@ -2731,6 +27

Re: [Qemu-devel] [PATCH v2 09/12] tests/qom-proplist: check class properties iterator

2018-10-03 Thread Paolo Bonzini
On 07/09/2018 09:59, Marc-André Lureau wrote: > This test failed before "fix iterating properties over a class". > > Signed-off-by: Marc-André Lureau > --- > tests/check-qom-proplist.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/tests/check-qom-proplist.c b/tests/check-qom

Re: [Qemu-devel] [PATCH v2 07/12] tests/qom-proplist: check duplicate "bv" property registration failed

2018-10-03 Thread Paolo Bonzini
On 07/09/2018 09:59, Marc-André Lureau wrote: > "bv" is already a class property. > > Signed-off-by: Marc-André Lureau > --- > tests/check-qom-proplist.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c > index

Re: [Qemu-devel] [PATCH v4 3/6] block/dirty-bitmaps: allow clear on disabled bitmaps

2018-10-03 Thread Vladimir Sementsov-Ogievskiy
03.10.2018 02:02, John Snow wrote: > Similarly to merge, it's OK to allow clear operations on disabled > bitmaps, as this condition only means that they are not recording > new writes. We are free to clear it if the user requests it. > > Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Og

Re: [Qemu-devel] [PATCH v2 08/12] tests/qom-proplist: check properties are not listed multiple times

2018-10-03 Thread Paolo Bonzini
On 07/09/2018 09:59, Marc-André Lureau wrote: > And factor out a common function used by the follow class properties > iterator test. > > Signed-off-by: Marc-André Lureau > --- > tests/check-qom-proplist.c | 44 +- > 1 file changed, 24 insertions(+), 20 deleti

Re: [Qemu-devel] [PATCH v2 11/12] hostmem: add some properties description

2018-10-03 Thread Paolo Bonzini
On 07/09/2018 09:59, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > backends/hostmem-memfd.c | 9 + > backends/hostmem.c | 14 ++ > 2 files changed, 23 insertions(+) > > diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c > index 1e20f

Re: [Qemu-devel] [PATCH v2 12/12] vl: list user creatable properties when 'help' is argument

2018-10-03 Thread Paolo Bonzini
On 07/09/2018 09:59, Marc-André Lureau wrote: > Iterate over the writable class properties, sort and print them out > with the description if available. > > Ex: qemu -object memory-backend-file,help > memory-backend-file.align=int > memory-backend-file.discard-data=bool > memory-backend-file.dump=

Re: [Qemu-devel] [PATCH v4 4/6] block/dirty-bitmaps: prohibit enable/disable on locked/frozen bitmaps

2018-10-03 Thread Vladimir Sementsov-Ogievskiy
03.10.2018 02:02, John Snow wrote: > We're not being consistent about this. If it's in use by an operation, > the user should not be able to change the behavior of that bitmap. > > Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > blockdev.c | 26 -

Re: [Qemu-devel] [PATCH] gtk: fix uninitialized variable

2018-10-03 Thread Philippe Mathieu-Daudé
On 03/10/2018 14:11, Paolo Bonzini wrote: > zoom_to_fit is never initialized to false, Coverity complains > (not sure why GCC does not). > > Fixes: e8b1386ea1719525a1a92df03377764703fe8c64 > Cc: kra...@redhat.com > Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé > --- > ui/gt

[Qemu-devel] [PATCH] configure: remove glib_subprocess check

2018-10-03 Thread Marc-André Lureau
This should have been removed as part of commit 692fbdf9f4c6f6bafd0b3a4d4f94973effd3bbae. Signed-off-by: Marc-André Lureau --- configure | 6 -- 1 file changed, 6 deletions(-) diff --git a/configure b/configure index a7368044cc..4f6d6e03b1 100755 --- a/configure +++ b/configure @@ -3557,12

[Qemu-devel] [PATCH 2/2] tests/tpm: mark swtpm test as skipped instead of successful

2018-10-03 Thread Marc-André Lureau
If swtpm is not found in $PATH or --tpm2 isn't supported, let's mark the test as SKIP. Signed-off-by: Marc-André Lureau --- tests/tpm-util.h | 2 ++ tests/tpm-tests.c | 33 + tests/tpm-util.c | 8 +--- 3 files changed, 24 insertions(+), 19 deletions(-) di

Re: [Qemu-devel] [PATCH v4 5/6] block/backup: prohibit backup from using in use bitmaps

2018-10-03 Thread Vladimir Sementsov-Ogievskiy
03.10.2018 15:28, Eric Blake wrote: > On 10/2/18 6:02 PM, John Snow wrote: >> If the bitmap is frozen, we shouldn't touch it. >> >> Signed-off-by: John Snow >> --- >>   blockdev.c | 12 ++-- >>   1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/blockdev.c b/blockdev.c >> i

[Qemu-devel] [PATCH 1/2] tests/tpm: fix tpm_util_swtpm_has_tpm2()

2018-10-03 Thread Marc-André Lureau
Using g_spawn_async_with_pipes() is more complicated than running the sync version. The async version returns a file descriptor for stdout, which may not be fully read. Sometime "--tpm2" will failed to be read, and will cause the related test to be silently skipped. Use g_spawn_sync() instead, sim

Re: [Qemu-devel] [PULL 75/79] memory: Remove old_mmio accessors

2018-10-03 Thread Philippe Mathieu-Daudé
On 30/09/2018 10:13, Paolo Bonzini wrote: > From: Peter Maydell > > Now that all the users of old_mmio MemoryRegion accessors > have been converted, we can remove the core code support. > > Signed-off-by: Peter Maydell > Message-Id: <20180824170422.5783-2-peter.mayd...@linaro.org> > Based-on: <

Re: [Qemu-devel] [RFC v3 00/15] ARM virt: PCDIMM/NVDIMM at 2TB

2018-10-03 Thread Auger Eric
Hi, On 7/3/18 9:19 AM, Eric Auger wrote: > This series aims at supporting PCDIMM/NVDIMM intantiation in > machvirt at 2TB guest physical address. > > This is achieved in 3 steps: > 1) support more than 40b IPA/GPA > 2) support PCDIMM instantiation > 3) support NVDIMM instantiation While respinni

[Qemu-devel] [Bug 1795799] [NEW] Cirrus video, graphical corruption, bad fonts

2018-10-03 Thread 1448412
Public bug reported: The error === I started qemu by `shell $ ./qemu-system-i386 -serial stdio -cdrom /dev/cdrom -vga cirrus S11S11S11S11▒*n*n*n*n ` with the original suse7.0 cd 1 in the cdrom drive (I think https://archive.org/details/suse-7.0_release_i386 has t

Re: [Qemu-devel] [PATCH 3/3] memory-mapping: skip non-volatile memory regions in GuestPhysBlockList

2018-10-03 Thread Laszlo Ersek
On 10/03/18 13:44, Marc-André Lureau wrote: > GuestPhysBlockList is currently used to produce dumps. Given the size > and the typical usage of NVDIMM for storage, they are not a good idea > to have in the dumps. We may want to have an extra dump option to > include them. For now, skip non-volatile

[Qemu-devel] [Bug 1795799] Re: Cirrus video, graphical corruption, bad fonts

2018-10-03 Thread 1448412
Here's what Suse62 does. I started this system by uli_r@DESKTOP-I4GHL3R /cygdrive/h/programme/qemu $ ./qemu-system-i386 -serial stdio -hda suse62.ima -vga cirrus WARNING: Image format was not specified for 'suse62.ima' and probing guessed raw. Automatically detecting the format is dange

Re: [Qemu-devel] [PATCH v4 5/6] block/backup: prohibit backup from using in use bitmaps

2018-10-03 Thread Vladimir Sementsov-Ogievskiy
03.10.2018 02:02, John Snow wrote: > If the bitmap is frozen, we shouldn't touch it. > > Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > blockdev.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/blockdev.c b/blockdev.c > index

Re: [Qemu-devel] [PATCH v4 6/6] nbd: forbid use of frozen bitmaps

2018-10-03 Thread Vladimir Sementsov-Ogievskiy
Reviewed-by: Vladimir Sementsov-Ogievskiy 03.10.2018 02:02, John Snow wrote: > Whether it's "locked" or "frozen", it's in use and should > not be allowed for the purposes of this operation. > > Signed-off-by: John Snow > --- > nbd/server.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deleti

Re: [Qemu-devel] [PATCH] softfloat: Fix division

2018-10-03 Thread Richard Henderson
On 10/3/18 4:28 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> The __udiv_qrnnd primitive that we nicked from gmp requires its >> inputs to be normalized. We were not doing that. Because the >> inputs are nearly normalized already, finishing that is trivial. >> Inline div128to64 int

Re: [Qemu-devel] [RFC v3 00/15] ARM virt: PCDIMM/NVDIMM at 2TB

2018-10-03 Thread Dr. David Alan Gilbert
* Auger Eric (eric.au...@redhat.com) wrote: > Hi, > > On 7/3/18 9:19 AM, Eric Auger wrote: > > This series aims at supporting PCDIMM/NVDIMM intantiation in > > machvirt at 2TB guest physical address. > > > > This is achieved in 3 steps: > > 1) support more than 40b IPA/GPA > > 2) support PCDIMM i

[Qemu-devel] [PULL 00/12] Option patches

2018-10-03 Thread Marc-André Lureau
The following changes since commit dafd95053611aa14dda40266857608d12ddce658: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-10-02 18:27:18 +0100) are available in the Git repository at: https://github.com/elmarco/qemu.git tags/option-pull-request for yo

[Qemu-devel] [PULL 02/12] cutils: add qemu_pstrcmp0()

2018-10-03 Thread Marc-André Lureau
A char** variant of g_strcmp0(). Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- include/qemu/cutils.h | 12 util/cutils.c | 5 + 2 files changed, 17 insertions(+) diff --git a/include/qemu/cutils.h b/include/qemu/cutils.h index 47aaa3b0b9..7071bfe2d4 10

[Qemu-devel] [PULL 04/12] qemu-option: improve qemu_opts_print_help() output

2018-10-03 Thread Marc-André Lureau
Modify qemu_opts_print_help(): - to print expected argument type - skip description if not available - sort lines - prefix with the list name (like qdev, to avoid confusion) - drop 16-chars alignment, use a '-' as seperator for option name and description For ex, "-spice help" output is changed

[Qemu-devel] [PULL 05/12] qom/object: fix iterating properties over a class

2018-10-03 Thread Marc-André Lureau
object_class_property_iter_init() starts from the given class, so the next class should continue with the parent class. Signed-off-by: Marc-André Lureau Reviewed-by: Paolo Bonzini --- qom/object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c in

[Qemu-devel] [PULL 01/12] qdev-monitor: print help to stdout

2018-10-03 Thread Marc-André Lureau
qdev_device_help() is used from command line "-device help", or from HMP "device_add". If used from command line, print help to stdout (it is only printed on explicit demand). Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- include/monitor/monitor.h | 3 +++ monitor.c

[Qemu-devel] [PULL 06/12] qom/object: register 'type' property as class property

2018-10-03 Thread Marc-André Lureau
Let's save a few byte in each object instance. Signed-off-by: Marc-André Lureau Reviewed-by: Paolo Bonzini --- qom/object.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qom/object.c b/qom/object.c index 9eaf08a53c..547dcf97c3 100644 --- a/qom/object.c +++ b/qom/obj

[Qemu-devel] [PULL 10/12] vl: handle -object help

2018-10-03 Thread Marc-André Lureau
List the user creatable objects. Signed-off-by: Marc-André Lureau Reviewed-by: Paolo Bonzini --- vl.c | 13 + 1 file changed, 13 insertions(+) diff --git a/vl.c b/vl.c index 0388852deb..aab1452d1a 100644 --- a/vl.c +++ b/vl.c @@ -2698,6 +2698,19 @@ static int machine_set_property(v

[Qemu-devel] [PULL 07/12] tests/qom-proplist: check duplicate "bv" property registration failed

2018-10-03 Thread Marc-André Lureau
"bv" is already a class property. Signed-off-by: Marc-André Lureau Reviewed-by: Paolo Bonzini --- tests/check-qom-proplist.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c index 92898e1520..0f6d9c1ce3 100644 --- a/

[Qemu-devel] [PULL 09/12] tests/qom-proplist: check class properties iterator

2018-10-03 Thread Marc-André Lureau
This test failed before "fix iterating properties over a class". Signed-off-by: Marc-André Lureau Reviewed-by: Paolo Bonzini --- tests/check-qom-proplist.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c index 8e1b9c27f3..7ed1

[Qemu-devel] [PULL 03/12] qemu-option: add help fallback to print the list of options

2018-10-03 Thread Marc-André Lureau
QDev options accept 'help' (or '?', but that's problematic with shell globbing) in the list of parameters, which is handy to list the available options. Unfortunately, this isn't built in QemuOpts. qemu_opts_parse_noisily() seems to be the common path for command line options, so place a fallback

[Qemu-devel] [PULL 11/12] hostmem: add some properties description

2018-10-03 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau Reviewed-by: Paolo Bonzini --- backends/hostmem-memfd.c | 9 + backends/hostmem.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c index 3800bd07b6..b6836b28e5 100644 --- a/bac

[Qemu-devel] [PULL 12/12] vl: list user creatable properties when 'help' is argument

2018-10-03 Thread Marc-André Lureau
Iterate over the writable class properties, sort and print them out with the description if available. Ex: qemu -object memory-backend-file,help memory-backend-file.align=int memory-backend-file.discard-data=bool memory-backend-file.dump=bool - Set to 'off' to exclude from core dump memory-backend

Re: [Qemu-devel] [PATCH 00/10] hyperv: add connection infrastructure

2018-10-03 Thread Roman Kagan
On Wed, Oct 03, 2018 at 01:12:10PM +0200, Paolo Bonzini wrote: > On 21/09/2018 10:22, Roman Kagan wrote: > > This series introduces the infrastructure to send and receive Hyper-V > > messages and events. > > > > More specifically, > > > > - SynIC is turned into a full-fledged device managing the

Re: [Qemu-devel] [PATCH 1/2] tests/tpm: fix tpm_util_swtpm_has_tpm2()

2018-10-03 Thread Stefan Berger
On 10/3/18 9:21 AM, Marc-André Lureau wrote: Using g_spawn_async_with_pipes() is more complicated than running the sync version. The async version returns a file descriptor for stdout, which may not be fully read. Sometime "--tpm2" will failed to be read, and will cause the related test to be sil

[Qemu-devel] [PULL 08/12] tests/qom-proplist: check properties are not listed multiple times

2018-10-03 Thread Marc-André Lureau
And factor out a common function used by the follow class properties iterator test. Signed-off-by: Marc-André Lureau Reviewed-by: Paolo Bonzini --- tests/check-qom-proplist.c | 44 +- 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/tests/check

Re: [Qemu-devel] [PATCH 2/2] tests/tpm: mark swtpm test as skipped instead of successful

2018-10-03 Thread Stefan Berger
On 10/3/18 9:21 AM, Marc-André Lureau wrote: If swtpm is not found in $PATH or --tpm2 isn't supported, let's mark the test as SKIP. Signed-off-by: Marc-André Lureau --- tests/tpm-util.h | 2 ++ tests/tpm-tests.c | 33 + tests/tpm-util.c | 8 +--- 3 f

Re: [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType

2018-10-03 Thread Eric Blake
On 10/3/18 5:46 AM, Kashyap Chamarthy wrote: While at it, s/QMU/QEMU in @CpuDefinitionInfo. Could mention that it was a repetition of 'independent of'. Signed-off-by: Kashyap Chamarthy --- qapi/misc.json | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Er

  1   2   3   >