On Fri, Sep 21, 2018 at 08:06:24PM +0200, Laszlo Ersek wrote:
> On 09/21/18 17:43, Kashyap Chamarthy wrote:
[...]
> > (b) When QEMU exposes a Virtio RNG device to the guest, that device
> > needs a source of entropy, and IIUC, that source needs to be
> > "non-blocking" (i.e. `/dev/urandom
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Pavel Dovgalyuk writes:
>
> > This patch introduces replay_break qmp and hmp commands.
> > These commands allow stopping at the specified instruction.
> > It may be useful for debugging when there are some known
> > events that should be inve
Hi Andrew,
Thanks for the review and comments.
[...]
> > @@ -600,6 +605,60 @@ int kvm_arm_cpreg_level(uint64_t regidx)
> > #define AARCH64_SIMD_CTRL_REG(x) (KVM_REG_ARM64 | KVM_REG_SIZE_U32 | \
> > KVM_REG_ARM_CORE | KVM_REG_ARM_CORE_REG(x))
> >
> > +static int kvm_put_vcpu
On Thu, Sep 20, 2018 at 12:32:39PM +0200, David Hildenbrand wrote:
> From: Pankaj Gupta
>
> We need a proxy device for virtio-pmem.
>
> Signed-off-by: Pankaj Gupta
> [ split up patches ]
> Signed-off-by: David Hildenbrand
Reviewed-by: David Gibson
> ---
> hw/virtio/virtio-pci.c | 41 ++
On Thu, Sep 20, 2018 at 12:32:42PM +0200, David Hildenbrand wrote:
> virtio-pmem devices will have to be hotplugged using the machine hotplug
> handler just like other memory devices. Therefore, all machines that
> want to support virtio-pmem will have to modify their machine hotplug
> handler.
>
This reverts commit 7a066770f53c198014add869696427f81d67e9c2.
The patch did not work as expected: The vmxnet3 test is currently
not run at all anymore.
Signed-off-by: Thomas Huth
---
tests/Makefile.include | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/Makefile.in
This reverts commit 669cc7100065c690cb7b4f3da5cfc471d1ed4740.
The patch did not work as expected: The endianess test is currently
not run at all anymore.
Signed-off-by: Thomas Huth
---
tests/Makefile.include | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/test
The recent clean-up in the tests/Makefile.include file disabled some
tests accidentally: Adding tests directly to check-qtest-y does not
work since the variable is overwritten at the end of the file again.
Also the Makefile is only included once and not per target architecture,
so adding the tests
This reverts commit ee1f6c812b3240420dff07a3860060b7d4abfe09.
The patch did not work as expected: The wdt_ib700 test is currently
not run at all anymore.
Signed-off-by: Thomas Huth
---
tests/Makefile.include | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/Makefile.
On 24/09/2018 08:44, David Gibson wrote:
> On Thu, Sep 20, 2018 at 12:32:42PM +0200, David Hildenbrand wrote:
>> virtio-pmem devices will have to be hotplugged using the machine hotplug
>> handler just like other memory devices. Therefore, all machines that
>> want to support virtio-pmem will have
On 24/09/2018 07:45, David Gibson wrote:
> On Thu, Sep 20, 2018 at 12:32:38PM +0200, David Hildenbrand wrote:
>> From: Pankaj Gupta
>>
>> This is the current protoype of virtio-pmem. Support will require
>> machine changes for the architectures that will support it, so it will
>> not yet be compil
From: Hikaru Nishida
Before this change, memory-backend-file object is invalid for macOS
hosts because hostmem-file.c is compiled only on Linux hosts.
However, macOS hosts can support memory-backend-file object in the same
way as on Linux hosts.
This patch makes hostmem-file.c and related functio
On 24/09/2018 10:13, hikaru...@gmail.com wrote:
> From: Hikaru Nishida
>
> Before this change, memory-backend-file object is invalid for macOS
> hosts because hostmem-file.c is compiled only on Linux hosts.
> However, macOS hosts can support memory-backend-file object in the same
> way as on Linu
On 21/09/2018 10:38, David Gibson wrote:
> On Fri, Sep 21, 2018 at 09:15:09AM +0200, David Hildenbrand wrote:
>>
-mr = ddc->get_memory_region(dimm, errp);
-if (!mr) {
+value = memory_device_get_region_size(MEMORY_DEVICE(obj), errp);
>>>
>>> Given the below, that sh
According to https://bugs.launchpad.net/qemu/+bug/588691 CD-ROM drives
should be working again, so I assume we can close this bug nowadays? Or
can you still reproduce it with the latest version of QEMU?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification be
** Changed in: qemu
Importance: Undecided => Wishlist
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1502884
Title:
Super important feature req: QEMU VNC server: Introduce a keyboard
"norepeat"
Hi All,
It seems that back in 2013, Paolo tried to start a GSoC project [1]
aimed at integrating Kconfig into QEMU and use it as its main
configuration framework.
I personally think that the rationale described in this GSoC project
is still valid today. However I'm not sure the project even start
Looking through old bug tickets... can you still reproduce this issue
with the latest version of QEMU? Or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscrib
On Fri, 21 Sep 2018 15:13:30 +0400
Marc-André Lureau wrote:
> Hi,
>
> This is a readability suggestion. See the first patch for the doc
> change, and the second patch for an example of usage and readability
> improvement.
Looks like a nice improvement,
but could you conversion tree wide so we en
Hi Dan,
Thanks for the review. Please find my reply inline.
> > This patch adds virtio-pmem driver for KVM guest.
> >
> > Guest reads the persistent memory range information from
> > Qemu over VIRTIO and registers it on nvdimm_bus. It also
> > creates a nd_region object with the persistent memory
> On 24/09/2018 07:45, David Gibson wrote:
> > On Thu, Sep 20, 2018 at 12:32:38PM +0200, David Hildenbrand wrote:
> >> From: Pankaj Gupta
> >>
> >> This is the current protoype of virtio-pmem. Support will require
> >> machine changes for the architectures that will support it, so it will
> >> n
On 28 August 2018 at 20:10, Markus Armbruster wrote:
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2'
> into staging (2018-08-27 16:44:20 +0100)
>
> are available in the Git repository
> > This patch adds functionality to perform flush from guest
> > to host over VIRTIO. We are registering a callback based
> > on 'nd_region' type. virtio_pmem driver requires this special
> > flush function. For rest of the region types we are registering
> > existing flush function. Report erro
On 29 August 2018 at 10:41, Cornelia Huck wrote:
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2'
> into staging (2018-08-27 16:44:20 +0100)
>
> are available in the Git repository at:
> Subject: Re: [PATCH 1/3] nd: move nd_region to common header
>
> On Fri, Aug 31, 2018 at 6:31 AM Pankaj Gupta wrote:
> >
> > This patch moves nd_region definition to common header
> > include/linux/nd.h file. This is required for flush callback
> > support for both virtio-pmem & pmem driver.
On 19 September 2018 at 11:19, Cédric Le Goater wrote:
> These are the number of read operations done on the flash memory region :
>
> 922478 ~ 3.5 MBytes OpenBMC U-Boot
> 20569977 ~ 80 MBytes Mainline U-Boot
>
>
> So we are trashing the TBs I would say. Is there a way to increase the
>
On 24/09/2018 09:42, Thomas Huth wrote:
> The recent clean-up in the tests/Makefile.include file disabled some
> tests accidentally: Adding tests directly to check-qtest-y does not
> work since the variable is overwritten at the end of the file again.
> Also the Makefile is only included once and n
On Thu, 20 Sep 2018 12:32:26 +0200
David Hildenbrand wrote:
> Let's properly forward the errors, so errors from get_region_size() /
> get_plugged_size() can be handled.
>
> Users right now call both functions after the device has been realized,
> which is will never fail, so it is fine to contin
Thank you for letting me know about CONFIG_POSIX.
I'll fix my patch to utilize it and submit again.
Hikaru Nishida
2018年9月24日(月) 17:51 Paolo Bonzini :
>
> On 24/09/2018 10:13, hikaru...@gmail.com wrote:
> > From: Hikaru Nishida
> >
> > Before this change, memory-backend-file object is invalid fo
On Thu, 20 Sep 2018 12:32:27 +0200
David Hildenbrand wrote:
> Document the functions and when to not expect errors.
>
> Signed-off-by: David Hildenbrand
> ---
> include/hw/mem/memory-device.h | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/include/hw/mem/memory-device.
On 31 August 2018 at 09:38, Thomas Huth wrote:
> Hi Peter!
>
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2'
> into staging (2018-08-27 16:44:20 +0100)
>
> are available in the git re
On 24/09/2018 14:22, Igor Mammedov wrote:
> On Thu, 20 Sep 2018 12:32:27 +0200
> David Hildenbrand wrote:
>
>> Document the functions and when to not expect errors.
>>
>> Signed-off-by: David Hildenbrand
>> ---
>> include/hw/mem/memory-device.h | 13 +
>> 1 file changed, 13 insertio
On 2018-09-24 14:24, Peter Maydell wrote:
> On 31 August 2018 at 09:38, Thomas Huth wrote:
>> Hi Peter!
>>
>> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>>
>> Merge remote-tracking branch
>> 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-
On Mon, 24 Sep 2018 11:03:35 +0200
David Hildenbrand wrote:
> On 21/09/2018 10:38, David Gibson wrote:
> > On Fri, Sep 21, 2018 at 09:15:09AM +0200, David Hildenbrand wrote:
> >>
>
> -mr = ddc->get_memory_region(dimm, errp);
> -if (!mr) {
> +value = memory_de
Add 'break' statements missing from a switch in the APB dual-timer
write function. Spotted by Coverity as CID 1395626 and 1395633.
Reported-by: Paolo Bonzini
Signed-off-by: Peter Maydell
---
hw/timer/cmsdk-apb-dualtimer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/timer/cmsdk-apb-
From: Hikaru Nishida
Before this change, memory-backend-file object is valid for Linux hosts
only because hostmem-file.c is compiled only on Linux hosts.
However, other POSIX-based hosts (such as macOS) can support
memory-backend-file object in the same way as on Linux hosts.
This patch makes hos
On 9 September 2018 at 21:34, Paolo Bonzini wrote:
> On 24/08/2018 11:33, Peter Maydell wrote:
>> ze);
>> +
>> + if (offset >= A_TIMERITCR) {
>> + switch (offset) {
>> + case A_TIMERITCR:
>> + s->timeritcr = value & R_TIMERITCR_VALID_MASK;
>> + cmsdk_apb_dualtimer_update(s);
>> + case A_TIMERITOP:
On 24 September 2018 at 13:29, Thomas Huth wrote:
> On 2018-09-24 14:24, Peter Maydell wrote:
>> Applied, thanks.
>
> Oops, I was just about to send a v2 for this (since Markus had some
> complaints about one of the patches)... I guess we should revert "tests:
> add qmp/qom-set-without-value test"
On 2018-09-24 14:35, Peter Maydell wrote:
> On 24 September 2018 at 13:29, Thomas Huth wrote:
>> On 2018-09-24 14:24, Peter Maydell wrote:
>>> Applied, thanks.
>>
>> Oops, I was just about to send a v2 for this (since Markus had some
>> complaints about one of the patches)... I guess we should rev
On Mon, 24 Sep 2018 14:26:23 +0200
David Hildenbrand wrote:
> On 24/09/2018 14:22, Igor Mammedov wrote:
> > On Thu, 20 Sep 2018 12:32:27 +0200
> > David Hildenbrand wrote:
> >
> >> Document the functions and when to not expect errors.
> >>
> >> Signed-off-by: David Hildenbrand
> >> ---
> >>
On 24/09/2018 14:39, Igor Mammedov wrote:
> On Mon, 24 Sep 2018 14:26:23 +0200
> David Hildenbrand wrote:
>
>> On 24/09/2018 14:22, Igor Mammedov wrote:
>>> On Thu, 20 Sep 2018 12:32:27 +0200
>>> David Hildenbrand wrote:
>>>
Document the functions and when to not expect errors.
"Pavel Dovgalyuk" writes:
>> From: Markus Armbruster [mailto:arm...@redhat.com]
>> Pavel Dovgalyuk writes:
>>
>> > This patch introduces replay_break qmp and hmp commands.
>> > These commands allow stopping at the specified instruction.
>> > It may be useful for debugging when there are some kn
On 31 August 2018 at 12:32, Mark Cave-Ayland
wrote:
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2'
> into staging (2018-08-27 16:44:20 +0100)
>
> are available in the git repository a
On Thu, 20 Sep 2018 12:32:29 +0200
David Hildenbrand wrote:
> The memory region is necessary for plugging/unplugging a memory device.
> The region size (via get_region_size()) is no longer sufficient, as
> besides the alignment, also the region itself is required in order to
> add it to the devic
On 24 September 2018 at 14:02, Markus Armbruster wrote:
> "Pavel Dovgalyuk" writes:
>> This is a doxygen-style comment for automatic documentation generation.
>
> We don't generate documentation, yet.
>
> We do have many GTKDoc-style comments. Perhaps because we hope that if
> we only add enough
On 10/05/2018 15:32, Igor Mammedov wrote:
> On Thu, 10 May 2018 15:20:55 +0200
> David Hildenbrand wrote:
>
>> On 10.05.2018 15:02, Igor Mammedov wrote:
>>> On Wed, 9 May 2018 16:13:14 +0200
>>> David Hildenbrand wrote:
>>>
On 03.05.2018 17:49, David Hildenbrand wrote:
> Hotplug ha
On Mon, 24 Sep 2018 14:40:24 +0200
David Hildenbrand wrote:
> On 24/09/2018 14:39, Igor Mammedov wrote:
> > On Mon, 24 Sep 2018 14:26:23 +0200
> > David Hildenbrand wrote:
> >
> >> On 24/09/2018 14:22, Igor Mammedov wrote:
> >>> On Thu, 20 Sep 2018 12:32:27 +0200
> >>> David Hildenbrand wr
On 24/09/2018 15:19, Igor Mammedov wrote:
> On Mon, 24 Sep 2018 14:40:24 +0200
> David Hildenbrand wrote:
>
>> On 24/09/2018 14:39, Igor Mammedov wrote:
>>> On Mon, 24 Sep 2018 14:26:23 +0200
>>> David Hildenbrand wrote:
>>>
On 24/09/2018 14:22, Igor Mammedov wrote:
> On Thu, 20 Se
Public bug reported:
readlink(2) seems to ignore the size of supplied buffer for the resolved
name and always returns the actual size of the resolved name instead.
Steps to reproduce:
```bash
echo '#include
#include
#include
int main(int argc, const char** argv)
{
if(argc < 2) exit(1);
On Fri, 21 Sep 2018 09:19:17 +0200
David Hildenbrand wrote:
> On 21/09/2018 07:19, David Gibson wrote:
> > On Thu, Sep 20, 2018 at 12:32:30PM +0200, David Hildenbrand wrote:
> >> We now have get_memory_region(), which can be used generically to detect
> >> the region size. Use memory_device_get
On 09/24/2018 01:41 PM, Peter Maydell wrote:
> On 19 September 2018 at 11:19, Cédric Le Goater wrote:
>> These are the number of read operations done on the flash memory region :
>>
>> 922478 ~ 3.5 MBytes OpenBMC U-Boot
>> 20569977 ~ 80 MBytes Mainline U-Boot
>>
>>
>> So we are trashing
On 24 September 2018 at 14:28, Cédric Le Goater wrote:
> On 09/24/2018 01:41 PM, Peter Maydell wrote:
>> On 19 September 2018 at 11:19, Cédric Le Goater wrote:
>>> These are the number of read operations done on the flash memory region :
>>>
>>> 922478 ~ 3.5 MBytes OpenBMC U-Boot
>>> 2056
On 24 September 2018 at 13:38, Thomas Huth wrote:
> On 2018-09-24 14:35, Peter Maydell wrote:
>> On 24 September 2018 at 13:29, Thomas Huth wrote:
>>> On 2018-09-24 14:24, Peter Maydell wrote:
Applied, thanks.
>>>
>>> Oops, I was just about to send a v2 for this (since Markus had some
>>> co
On Thu, 20 Sep 2018 12:32:31 +0200
David Hildenbrand wrote:
> To be able to factor out address asignment of memory devices, we will
> have to read (get_addr()) and write (set_addr()) the address.
>
> We can't use properties for this purpose, as properties are device
> specific. E.g. while the ad
On Fri 21 Sep 2018 07:23:09 PM CEST, Leonid Bloch wrote:
> The default cache-clean-interval is set to 10 minutes, in order to lower
> the overhead of the qcow2 caches (before the default was 0, i.e.
> disabled).
>
> * For non-Linux platforms the default is kept at 0, because
> cache-clean-interva
On Thu, 20 Sep 2018 12:32:32 +0200
David Hildenbrand wrote:
> With all required memory device class functions in place, we can factor
> out pre_plug handling of memory devices. Take proper care of errors. We
> still have to carry along legacy_align required for pc compatibility
> handling.
>
> W
On 19.09.18 11:18, Alberto Garcia wrote:
> On Thu 06 Sep 2018 11:37:08 AM CEST, Alberto Garcia wrote:
>> 'discard' is one of the basic BlockdevOptions available for all
>> drivers, but it's not handled by bdrv_reopen_prepare() so any attempt
>> to change it results in an error:
>>
>>(qemu) qem
On Mon 24 Sep 2018 03:43:10 PM CEST, Max Reitz wrote:
> On 19.09.18 11:18, Alberto Garcia wrote:
>> On Thu 06 Sep 2018 11:37:08 AM CEST, Alberto Garcia wrote:
>>> 'discard' is one of the basic BlockdevOptions available for all
>>> drivers, but it's not handled by bdrv_reopen_prepare() so any attem
On Thu, 20 Sep 2018 12:32:33 +0200
David Hildenbrand wrote:
> With the new memory device functions in place, we can factor out
> plugging of memory devices completely.
>
> Signed-off-by: David Hildenbrand
> ---
> hw/mem/memory-device.c | 10 +++---
> hw/mem/pc-dimm.c
On 9/24/18 2:31 PM, Peter Maydell wrote:
> Add 'break' statements missing from a switch in the APB dual-timer
> write function. Spotted by Coverity as CID 1395626 and 1395633.
>
> Reported-by: Paolo Bonzini
> Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/timer/c
On Thu, 20 Sep 2018 12:32:35 +0200
David Hildenbrand wrote:
> Let's trace the address when pre_pluggin/plugging/unplugging a memory device.
>
> Trace it when pre_plugging as well as when plugging, so we really know
> when a specific address is actually used.
>
> Signed-off-by: David Hildenbrand
On Fri 21 Sep 2018 07:23:03 PM CEST, Leonid Bloch wrote:
> Adding a lookup table for the powers of two, with the appropriate size
> prefixes. This is needed when a size has to be stringified, in which
> case something like '(1 * KiB)' would become a literal '(1 * (1L << 10))'
> string. Powers of tw
On 09/24/2018 03:31 PM, Peter Maydell wrote:
> On 24 September 2018 at 14:28, Cédric Le Goater wrote:
>> On 09/24/2018 01:41 PM, Peter Maydell wrote:
>>> On 19 September 2018 at 11:19, Cédric Le Goater wrote:
These are the number of read operations done on the flash memory region :
On 9/21/18 3:28 AM, Wolfgang Bumiller wrote:
monitor_resume() and monitor_suspend() both want to
"kick" the I/O thread if it is there, but in
monitor_suspend() lacked the use_io_thread flag condition.
This is required when we later only spawn the thread on
first use.
When sending a multi-patch
On 9/21/18 12:23 PM, Leonid Bloch wrote:
Adding a lookup table for the powers of two, with the appropriate size
prefixes. This is needed when a size has to be stringified, in which
case something like '(1 * KiB)' would become a literal '(1 * (1L << 10))'
string. Powers of two are used very often
On Thu, 20 Sep 2018 12:32:34 +0200
David Hildenbrand wrote:
> With the new memory device functions in place, we can factor out
> unplugging of memory devices completely.
>
> Signed-off-by: David Hildenbrand
> ---
> hw/mem/memory-device.c | 8 ++--
> hw/mem/pc-dimm.c |
On Thu, 20 Sep 2018 12:32:36 +0200
David Hildenbrand wrote:
> Once we have other memory devices that are not ACPI devices (e.g.
> virtio based), we cannot indicate them via ACPI. So let's skip these
> devices.
>
> Signed-off-by: David Hildenbrand
dimm specific entries in SRAT will be removed so
> On Sep 24, 2018, at 5:14 AM, Thomas Huth <1332...@bugs.launchpad.net> wrote:
>
> According to https://bugs.launchpad.net/qemu/+bug/588691 CD-ROM drives
> should be working again, so I assume we can close this bug nowadays? Or
> can you still reproduce it with the latest version of QEMU?
>
> **
On Thu, 20 Sep 2018 12:32:37 +0200
David Hildenbrand wrote:
> When reporting the id of virtio-based memory devices, we always have to
> take the one of the proxy device (parent), not the one of the memory
> device directly.
>
> Let's generalize this by allowing memory devices to specify an optio
On 31 August 2018 at 15:32, Max Reitz wrote:
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2'
> into staging (2018-08-27 16:44:20 +0100)
>
> are available in the Git repository at:
>
>
On Fri 21 Sep 2018 07:23:02 PM CEST, Leonid Bloch wrote:
> Signed-off-by: Leonid Bloch
> ---
> docs/qcow2-cache.txt | 20 +---
> qemu-options.hx | 9 ++---
> 2 files changed, 19 insertions(+), 10 deletions(-)
>
> diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
>
On 1 September 2018 at 12:17, Markus Armbruster wrote:
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2'
> into staging (2018-08-27 16:44:20 +0100)
>
> are available in the Git repositor
Hi Philippe,
> > That would be programs not compiled by GCC, as explained in the first
> > sentence of the body text. The subject line is very brief by necessity
> > since it is limited to 72 or so characters. It was an attempt to qualify
> > the subject line "initial support for MIPS R5900", whic
On 3 September 2018 at 07:57, Gerd Hoffmann wrote:
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2'
> into staging (2018-08-27 16:44:20 +0100)
>
> are available in the git repository at
From: Cornelia Huck
Add two functions to print an error/warning report once depending
on a passed-in condition variable and flip it if printed. This is
useful if you want to print a message not once-globally, but e.g.
once-per-device.
Inspired by warn_once() in hw/vfio/ccw.c, which has been repl
Commit ba51ef25571 moved hw/dma/sun4m_iommu.c to
hw/sparc/sun4m_iommu.c without updating MAINTAINERS.
Commit f5980f757c0 deleted include/hw/sparc/sun4m.h without updating
MAINTAINERS.
Commit 0bcc8e5bd8d fat-fingered tests/check-block-qdict.c.
Commit 33e9e9bd62d fat-fingered include/qemu/job.h.
From: Cornelia Huck
{error,warn}_report_once() are a special case of the new functions
and can simply switch to them.
Signed-off-by: Cornelia Huck
Message-Id: <20180830145902.27376-3-coh...@redhat.com>
Reviewed-by: Markus Armbruster
[Dispense with unlikely() to keep the macros as simple as pos
From: Mao Zhongyi
error_report and friends already add a "qemu-system-xxx" prefix
to the string, so a "qemu:" prefix is redundant in the string.
Just drop it.
Reported-by: Thomas Huth
Signed-off-by: Mao Zhongyi
Reviewed-by: Eduardo Habkost
Message-Id: <1537495530-580-1-git-send-email-maozhon.
The following changes since commit d6f71af65410d3e003ba331c5e57eddcf716cbcf:
Merge remote-tracking branch 'remotes/xanclic/tags/pull-block-2018-08-31-v2'
into staging (2018-09-24 14:35:58 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-error-2018-09
Marcel Apfelbaum 于2018年9月20日周四 下午2:41写道：
>
> Hi Zihan, Gerd
>
> On 09/20/2018 09:09 AM, Gerd Hoffmann wrote:
> As for the management, will some checks when adding mcfg be enough for
> management? Or I can maintain a variable to indicate how many space
> have been consumed and warn t
Hi Marcel,
Marcel Apfelbaum 于2018年9月20日周四 下午2:39写道：
>
> Hi Zihan,
>
> On 09/18/2018 04:41 PM, Michael S. Tsirkin wrote:
> > Cc Laine, Eric for an opinion about the management interface.
> >
> > On Mon, Sep 17, 2018 at 10:57:31PM +0800, Zihan Yang wrote:
> >> Hi all
> >>
> >> Here is a minimal w
** Summary changed:
- readlink(2) returns invalid size for /proc/self/exe
+ readlink(2) returns incorrect size for /proc/self/exe
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1794086
Title:
readl
On 5 September 2018 at 23:09, Alistair Francis wrote:
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2'
> into staging (2018-08-27 16:44:20 +0100)
>
> are available in the Git repository
Le 19/09/2018 à 10:04, Cortland Tölva a écrit :
> Provide ioctl definitions for the generic thunk mechanism to
> convert most usbfs calls.
>
> Signed-off-by: Cortland Tölva
> ---
> linux-user/ioctls.h| 38 ++
> linux-user/syscall.c | 3 ++
> linux-user/sysc
The lexer uses macro TERMINAL_NEEDED_LOOKAHEAD() to decide whether a
state transition consumes the input character. It returns true when
the state transition is defined with the TERMINAL() macro. To detect
that, it checks whether input '\0' would have resulted in the same
state transition, and th
When the lexer isn't in its start state at the end of input, it's
working on a token. To flush it out, it needs to transit to its start
state on "end of input" lookahead.
There are two ways to the start state, depending on the current state:
* If the lexer is in a TERMINAL(JSON_FOO) state, it ca
The following changes since commit d5a515738ee2dec0cdf11d8a14a09abae6c20571:
Merge remote-tracking branch 'remotes/kraxel/tags/vga-20180903-pull-request'
into staging (2018-09-24 16:15:26 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-qobject-2018-
The lexer fails to end a valid token when the lookahead character is
beyond '\x7F'. For instance, input
true\xC2\xA2
produces the tokens
JSON_ERROR true\xC2
JSON_ERROR \xA2
This should be
JSON_KEYWORD true
JSON_ERROR \xC2
JSON_ERROR \xA2
instead.
Th
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180831075841.13363-6-arm...@redhat.com>
---
qobject/json-lexer.c | 9 +
qobject/json-parser-int.h | 8
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/qobject/json-lexer.c b/qobject/json-
The lexer ignores whitespace like this:
on whitespace on non-ws spontaneously
IN_START --> IN_WHITESPACE --> JSON_SKIP --> IN_START
^|
\__/ on whitespace
This accumulates a whitespace token in state IN_WHITESPACE, only to
throw it
When the lexer chokes on an input character, it consumes the
character, emits a JSON error token, and enters its start state. This
can lead to suboptimal error recovery. For instance, input
0123 ,
produces the tokens
JSON_ERROR01
JSON_INTEGER 23
JSON_COMMA,
Make the l
On 9/24/18 5:09 PM, Eric Blake wrote:
> On 9/21/18 12:23 PM, Leonid Bloch wrote:
>> Adding a lookup table for the powers of two, with the appropriate size
>> prefixes. This is needed when a size has to be stringified, in which
>> case something like '(1 * KiB)' would become a literal '(1 * (1L << 1
** Changed in: qemu
Status: Incomplete => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1332234
Title:
qemu-system-ppc no longer able to read real cdrom
Status in QEMU:
Fix R
On Fri 21 Sep 2018 07:23:07 PM CEST, Leonid Bloch wrote:
> The upper limit on the L2 cache size is increased from 1 MB to 32 MB
> on Linux platforms, and to 8 MB on other platforms (this difference is
> caused by the ability to set intervals for cache cleaning on Linux
> platforms only).
>
> This i
On 24/09/2018 15:12, Peter Maydell wrote:
> It got bumped by more important things
> and also because somebody else said they were going to look at it,
> and then it got bumped off *their* todo list by more important
> things :-))
I sense the force calling me... Well, my plans were did not actuall
On 9/24/18 6:04 PM, Alberto Garcia wrote:
> On Fri 21 Sep 2018 07:23:02 PM CEST, Leonid Bloch wrote:
>> Signed-off-by: Leonid Bloch
>> ---
>> docs/qcow2-cache.txt | 20 +---
>> qemu-options.hx | 9 ++---
>> 2 files changed, 19 insertions(+), 10 deletions(-)
>>
>> diff
Le 19/09/2018 à 10:04, Cortland Tölva a écrit :
> Userspace submits a USB Request Buffer to the kernel, optionally
> discards it, and finally reaps the URB. Thunk buffers from target
> to host and back.
>
> Tested by running an i386 scanner driver on ARMv7. Neither the
> discardurb ioctl nor the
On 9/21/18 12:23 PM, Leonid Bloch wrote:
Signed-off-by: Leonid Bloch
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 2 +-
block/qcow2.h | 9 +
2 files changed, 6 insertions(+), 5 deletions(-)
+++ b/block/qcow2.h
@@ -27,6 +27,7 @@
#include "crypto/block.h"
#include "qemu
On 20.09.18 18:19, Kevin Wolf wrote:
> When draining a block node, we recurse to its parent and for subtree
> drains also to its children. A single AIO_WAIT_WHILE() is then used to
> wait for bdrv_drain_poll() to become true, which depends on all of the
> nodes we recursed to. However, if the respe
On 7 September 2018 at 08:31, David Gibson wrote:
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2'
> into staging (2018-08-27 16:44:20 +0100)
>
> are available in the Git repository at:
1 - 100 of 155 matches
Mail list logo
