Re: [Qemu-devel] [PATCH 09/11] aspeed/smc: add DMA calibration settings

2018-09-19 Thread Cédric Le Goater
On 09/18/2018 08:54 PM, Peter Maydell wrote: > On 31 August 2018 at 11:38, Cédric Le Goater wrote: >> When doing calibration, the SPI clock rate in the CE0 Control Register >> and the read delay cycles in the Read Timing Compensation Register are >> replaced by bit[11:4] of the DMA Control Registe

Re: [Qemu-devel] [PATCH] s390x/pci: add common fmb

2018-09-19 Thread Yi Min Zhao
No comment? 在 2018/9/4 下午5:15, Yi Min Zhao 写道: Common function measurement block is used to report counters of successfully issued pcilg/stg/stb and rpcit instructions. This patch introduces a new struct ZpciFmb and schedules a timer callback to copy fmb to the guest memory at a interval time w

Re: [Qemu-devel] [PATCH 08/11] aspeed/smc: add support for DMAs

2018-09-19 Thread Cédric Le Goater
On 09/18/2018 08:53 PM, Peter Maydell wrote: > On 31 August 2018 at 11:38, Cédric Le Goater wrote: >> The FMC controller on the Aspeed SoCs support DMA to access the flash >> modules. It can operate in a normal mode, to copy to or from the flash >> module mapping window, or in a checksum calculati

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 0/2] 40p: fix PCI interrupt routing

2018-09-19 Thread Roman Kapl
Hi, On 09/19/2018 08:57 AM, Mark Cave-Ayland wrote: On 18/09/2018 22:12, Mark Cave-Ayland wrote: Roman, can you reproduce this locally at all? My setup is nothing special, just Debian Stretch on amd64. I've just realised that because this bug is still dependent upon queued patches, it would

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 3/6] s390x/kvm: enable/disable AP instruction interpretation for guest

2018-09-19 Thread David Hildenbrand
Am 19.09.18 um 00:23 schrieb Halil Pasic: > > > On 09/18/2018 06:59 PM, Tony Krowiak wrote: >> I've discussed this with Halil -- Pierre is out until next week. We >> are in agreement that while these changes are viable, they result in >> a slightly more complicated implementation compared to prev

Re: [Qemu-devel] [PATCH] s390x/pci: add common fmb

2018-09-19 Thread Thomas Huth
On 2018-09-19 09:08, Yi Min Zhao wrote: > No comment? Since the zPCI spec is not available to the public, it's quite hard to give any valuable comments here... I'll try anyway... > 在 2018/9/4 下午5:15, Yi Min Zhao 写道: >> Common function measurement block is used to report counters of >> successfull

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 3/6] s390x/kvm: enable/disable AP instruction interpretation for guest

2018-09-19 Thread David Hildenbrand
>> >> Apart from that, looks good to me. > > Let me summarize what I think you are suggesting. > > For KVM: > 1. Get rid of KVM_S390_VM_CPU_FEAT_AP in KVM > 2. Make AP instruction interception the default. > 3. Provide the KVM_S390_VM_CRYPTO_ENABLE_APIE attribute in KVM if the > AP instructio

[Qemu-devel] [Bug 1486278] Re: 'info vnc' monitor command does not show websocket information

2018-09-19 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1486278 Title: 'info vnc' monitor command does not show websocket information Status in QEMU:

[Qemu-devel] [Bug 1502613] Re: [Feature Request] Battery Status / Virtual Battery

2018-09-19 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1502613 Title: [Feature Request] Battery Status / Virtual Battery Status in QEMU: New Bug

[Qemu-devel] [Bug 1133769] Re: qtest failures leave orphaned qemu processes hanging around

2018-09-19 Thread Thomas Huth
I think this has been fixed sometime in the past already. Or can you still reproduce this problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. h

[Qemu-devel] [PATCH] tests/Makefile: Re-enable the endianness-, wdt_ib700- and the vmxnet3-test

2018-09-19 Thread Thomas Huth
Recent clean-ups moved these tests directly to the check-qtest-y variable, but this variable gets completely overwritten at the end of the Makefile by: check-qtest-y=$(foreach TARGET,$(TARGETS), $(check-qtest-$(TARGET)-y)) So the endianness-, wdt_ib700- and the vmxnet3-test are currently not run

[Qemu-devel] [Bug 1793275] [NEW] Hosts fail to start after update to QEMU 3.0

2018-09-19 Thread Neil Darlow
Public bug reported: Host OS: Archlinux Host Architecture: AMD64 Guest OS: FreeBSD-11.2 (x2) and Archlinux (x1) Guest Architecture: AMD64 I have been using QEMU 2.x without issue for a number of years but since updating to QEMU 3.0 my guests do not complete startup. FreeBSD 11.2 guest failure sy

Re: [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen

2018-09-19 Thread Alberto Garcia
On Thu 06 Sep 2018 11:37:08 AM CEST, Alberto Garcia wrote: > 'discard' is one of the basic BlockdevOptions available for all > drivers, but it's not handled by bdrv_reopen_prepare() so any attempt > to change it results in an error: > >(qemu) qemu-io virtio0 "reopen -o discard=on" >Cannot

Re: [Qemu-devel] [PATCH v4 2/3] hw/arm/sysbus-fdt: Allow device matching with DT compatible value

2018-09-19 Thread Auger Eric
Hi Geert, On 9/13/18 5:44 PM, Geert Uytterhoeven wrote: > From: Auger Eric > > Up to now we have relied on the device type to identify a device tree > node creation function. Since we would like the vfio-platform device to > be instantiatable with different compatible strings we introduce the s

Re: [Qemu-devel] [PATCH v4 3/3] hw/arm/virt: Allow dynamic vfio-platform devices again

2018-09-19 Thread Auger Eric
Hi Geert, On 9/13/18 5:44 PM, Geert Uytterhoeven wrote: > Allow the instantation of generic dynamic vfio-platform devices again, > without the need to create a new device-specific vfio type. > > This is more or less a partial revert of commit 6f2062b9758ebc64 > ("hw/arm/virt: Allow only supported

Re: [Qemu-devel] [PATCH v4 1/3] vfio/platform: Make the vfio-platform device non-abstract

2018-09-19 Thread Auger Eric
On 9/13/18 5:44 PM, Geert Uytterhoeven wrote: > From: Auger Eric > > Up to now the vfio-platform device has been abstract and could not be > instantiated. The integration of a new vfio platform device required > creating a dummy derived device which only set the compatible string. > > Follow

Re: [Qemu-devel] [PATCH] tests/Makefile: Re-enable the endianness-, wdt_ib700- and the vmxnet3-test

2018-09-19 Thread Philippe Mathieu-Daudé
On 9/19/18 10:58 AM, Thomas Huth wrote: > Recent clean-ups moved these tests directly to the check-qtest-y variable, > but this variable gets completely overwritten at the end of the Makefile by: > > check-qtest-y=$(foreach TARGET,$(TARGETS), $(check-qtest-$(TARGET)-y)) > > So the endianness-, wd

Re: [Qemu-devel] [PATCH v4 5/8] target/mips: R5900 DMULT[U], DDIV[U], LL, SC, LLD and SCD are user only

2018-09-19 Thread Philippe Mathieu-Daudé
On 9/18/18 8:26 PM, Maciej W. Rozycki wrote: > Hi Fredrik, > >> I agree, that is important too. I will post an updated v5 soon. Another >> alternative change is to define check_insn_opc_user_only as >> >> static inline void check_insn_opc_user_only(DisasContext *ctx, int flags) >> { >> #ifndef CON

Re: [Qemu-devel] qemu arm emulation not working correctly in debian stretch

2018-09-19 Thread Philippe Mathieu-Daudé
Cc'ing Linux user maintainers (you can see the entry in the MAINTAINERS file in the source tree). On 9/17/18 4:51 PM, m.mar...@voestalpine.com wrote: > Hello everyone, > > My name is Michael. I'm working for voestalpine in an embedded software > project for railways diagnostics. > > Before fili

Re: [Qemu-devel] [PATCH 3/3] display/stdvga: add edid support.

2018-09-19 Thread Philippe Mathieu-Daudé
On 9/17/18 10:26 AM, Gerd Hoffmann wrote: > This patch adds edid support to the qemu stdvga. It is turned off by > default and can be enabled with the new edid property. The patch also > adds xres and yres properties to specify the video mode you want the > guest use. Works only with edid enable

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 07/10] hw/misc/zynq_slcr: use standard register definition

2018-09-19 Thread Philippe Mathieu-Daudé
On 9/17/18 10:40 AM, damien.he...@greensocs.com wrote: > From: Damien Hedde > > Replace the zynq_slcr registers enum and macros using the > hw/registerfields.h macros. This looks cleaner, indeed. > > Signed-off-by: Damien Hedde Reviewed-by: Philippe Mathieu-Daudé > --- > hw/misc/zynq_slcr

[Qemu-devel] [Bug 1788665] Re: Low 2D graphics performance with Windows 10 (1803) VGA passthrough VM using "Spectre" protection

2018-09-19 Thread Dr. David Alan Gilbert
Have we got this the right way around So you're saying the one with spec-ctrl disabled is faster, but has a lot more kvm-exits? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1788665 Title: Low

Re: [Qemu-devel] [PATCH v5 1/3] target/s390x: use regular spaces in translate.c

2018-09-19 Thread Cornelia Huck
On Sat, 1 Sep 2018 20:33:20 -0400 Pavel Zbitskiy wrote: > In a few places translate.c contains non-breaking spaces (0xc2 0xa0) > instead of regular ones (0x20): > > 7c 7c c2 a0 63 63 > 7c 7c 2063 63 > | |c c > > This confuses some text editors. > > Signed-off-by: Pavel Zbi

Re: [Qemu-devel] [PATCH 04/11] hw/arm/aspeed: add a 'mmio-exec' property to boot from the FMC flash module

2018-09-19 Thread Cédric Le Goater
On 09/19/2018 08:51 AM, Cédric Le Goater wrote: > On 09/18/2018 08:44 PM, Peter Maydell wrote: >> On 31 August 2018 at 11:38, Cédric Le Goater wrote: >>> Now that MMIO execution is supported, introduce a 'mmio-exec' property >>> to boot directly from CE0 of the FMC controller using a memory region

Re: [Qemu-devel] [PATCH] qapi/misc.json: Clarify about usage of QMP 'cpu-add'

2018-09-19 Thread Kashyap Chamarthy
On Tue, Sep 18, 2018 at 11:19:38AM -0300, Eduardo Habkost wrote: > On Tue, Sep 18, 2018 at 03:23:03PM +0200, Kashyap Chamarthy wrote: > > Eduardo Habkost mentioned on IRC that the intended functionality of QMP > > 'cpu-add' is replaced with a combination of 'query-hotpluggable-cpus' > > and 'device

Re: [Qemu-devel] [PATCH v10 6/6] tpm: add ACPI memory clear interface

2018-09-19 Thread Marc-André Lureau
Hi On Tue, Sep 18, 2018 at 7:49 PM Dr. David Alan Gilbert wrote: > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > Hi > > > > On Tue, Sep 11, 2018 at 6:19 PM Laszlo Ersek wrote: > > > > > > +Alex, due to mention of 21e00fa55f3fd > > > > > > On 09/10/18 15:03, Marc-André Lureau wrot

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hvf: drop unused variable

2018-09-19 Thread Philippe Mathieu-Daudé
On 9/18/18 11:28 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > target/i386/hvf/hvf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c > index 5db167df98..9f52bc413a 100644 > --- a/target/i386/hvf/hvf.c > +++ b/target/i386/hvf

[Qemu-devel] [PATCH] qxl: use guest_monitor_config for local renderer.

2018-09-19 Thread Gerd Hoffmann
When processing monitor config from guest store head0 width and height for single-head configurations. Use these when creating the DisplaySurface in the local renderer. This fixes a rendering issue with wayland. Wayland rounds up the framebuffer width and height to a multiple of 64, so with odd

Re: [Qemu-devel] [Qemu-arm] [PATCH 01/11] aspeed/timer: fix compile breakage with clang 3.4.2

2018-09-19 Thread Philippe Mathieu-Daudé
On 8/31/18 12:38 PM, Cédric Le Goater wrote: > In file included from /home/thuth/devel/qemu/hw/timer/aspeed_timer.c:16: > /home/thuth/devel/qemu/include/hw/misc/aspeed_scu.h:37:3: error: > redefinition of typedef 'AspeedSCUState' is a C11 feature > [-Werror,-Wtypedef-redefinition] > } AspeedS

Re: [Qemu-devel] [PATCH] qxl: use guest_monitor_config for local renderer.

2018-09-19 Thread Marc-André Lureau
Hi On Wed, Sep 19, 2018 at 2:33 PM Gerd Hoffmann wrote: > > When processing monitor config from guest store head0 width and height > for single-head configurations. Use these when creating the > DisplaySurface in the local renderer. > > This fixes a rendering issue with wayland. Wayland rounds

Re: [Qemu-devel] [PATCH v10 6/6] tpm: add ACPI memory clear interface

2018-09-19 Thread He, Junyan
Add zhangyi -Original Message- From: Marc-André Lureau [mailto:marcandre.lur...@gmail.com] Sent: Wednesday, September 19, 2018 6:30 PM To: Dr. David Alan Gilbert Cc: He, Junyan ; Laszlo Ersek ; Eduardo Habkost ; Michael S. Tsirkin ; Stefan Berger ; QEMU ; Paolo Bonzini ; Igor Mammedov

Re: [Qemu-devel] [PATCH v10 6/6] tpm: add ACPI memory clear interface

2018-09-19 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Tue, Sep 18, 2018 at 7:49 PM Dr. David Alan Gilbert > wrote: > > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > Hi > > > > > > On Tue, Sep 11, 2018 at 6:19 PM Laszlo Ersek wrote: > > > > > > > > +Alex, due to

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hvf: drop unused variable

2018-09-19 Thread Thomas Huth
On 2018-09-19 12:30, Philippe Mathieu-Daudé wrote: > On 9/18/18 11:28 AM, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> --- >> target/i386/hvf/hvf.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c >> index 5db167df98..9f52bc413a 1

[Qemu-devel] [Bug 1793297] [NEW] windows's paint software cross-shadped cursor offset a pixel in guest windows which is generated by qemu-kvm

2018-09-19 Thread jobs.ub18
Public bug reported: I have already tested lots of versions of QEMU. Since qemu-2.3.0 -- qemu-3.0.0. I find weird phenomena about windows's paint software cross-shaped cursor offset a pixel since qemu-2.10.0, but it is ok before the version of qemu-2.10.0. Only spice agent and service are runni

Re: [Qemu-devel] [PATCH v10 6/6] tpm: add ACPI memory clear interface

2018-09-19 Thread Igor Mammedov
On Wed, 19 Sep 2018 11:58:22 +0100 "Dr. David Alan Gilbert" wrote: > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > Hi > > > > On Tue, Sep 18, 2018 at 7:49 PM Dr. David Alan Gilbert > > wrote: > > > > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > > Hi > > >

Re: [Qemu-devel] [PATCH v10 6/6] tpm: add ACPI memory clear interface

2018-09-19 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Wed, 19 Sep 2018 11:58:22 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > Hi > > > > > > On Tue, Sep 18, 2018 at 7:49 PM Dr. David Alan Gilbert > > > wrote: > > > > > > > > * Marc-And

Re: [Qemu-devel] [PATCH] cpu.h: fix a typo in comment

2018-09-19 Thread Markus Armbruster
Could be merged via qemu-trivial (cc'ed). Li Qiang writes: > Found by reading the code. > > Signed-off-by: Li Qiang > --- > include/qom/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/qom/cpu.h b/include/qom/cpu.h > index dc130cd307..5bb94a9f86 100644 > -

[Qemu-devel] [PATCH 2/2] block/backup: drop unused synchronization interface

2018-09-19 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_backup.h | 13 block/backup.c | 38 +++- 2 files changed, 7 insertions(+), 44 deletions(-) diff --git a/include/block/block_backup.h b/include/block/block_backup.h index

[Qemu-devel] [PATCH 0/2] replication: drop extra sync

2018-09-19 Thread Vladimir Sementsov-Ogievskiy
Hi all! We finally implemented fleecing scheme, create a test case for it (222) and even made it safe (f8d59dfb40). However, fleecing is used inside block-replication long ago, and to make the scheme safe it uses direct interface to backup-job copy requests synchronization, which can be dropped n

[Qemu-devel] [PATCH 1/2] block/replication: drop extra synchronization

2018-09-19 Thread Vladimir Sementsov-Ogievskiy
After commit f8d59dfb40 "block/backup: fix fleecing scheme: use serialized writes" fleecing (specifically reading from backup target, when backup source is in backing chain of backup target) is safe, because all backup-job writes to target are serialized. Therefore we don't need additional sync

[Qemu-devel] [PATCH 1/3] Check for Linux USBFS in configure

2018-09-19 Thread Cortland Tölva
In preparation for adding user mode emulation support for the Linux usbfs interface, check for its kernel header. Signed-off-by: Cortland Tölva --- configure | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 58862d2ae8..5d36f454

[Qemu-devel] [PATCH 0/3] Linux usermode emulation user mode USB driver support.

2018-09-19 Thread Cortland Tölva
This patch series aims to let programs running under QEMU Linux user mode emulation implement user-space USB drivers via the USBFS ioctl()s. First I check for the necessary header files, then I define some types, and last I implement the submit, discard, and reap functions, which involve USB reque

[Qemu-devel] [PATCH 3/3] linux-user: implement special usbfs ioctls.

2018-09-19 Thread Cortland Tölva
Userspace submits a USB Request Buffer to the kernel, optionally discards it, and finally reaps the URB. Thunk buffers from target to host and back. Tested by running an i386 scanner driver on ARMv7. Neither the discardurb ioctl nor the kernel's updating the argument to the reap ioctl with a poi

[Qemu-devel] [PATCH 2/3] Linux user mode usbfs types and defs.

2018-09-19 Thread Cortland Tölva
Provide ioctl definitions for the generic thunk mechanism to convert most usbfs calls. Signed-off-by: Cortland Tölva --- linux-user/ioctls.h| 38 ++ linux-user/syscall.c | 3 ++ linux-user/syscall_defs.h | 32 ++ linux-user/syscall_type

[Qemu-devel] [PATCH] sm501: Adjust endianness of pixel value in rectangle fill

2018-09-19 Thread Marcus Comstedt
The value from twoD_foreground (which is in host endian format) must be converted to the endianness of the framebuffer (currently always little endian) before it can be used to perform the fill operation. Signed-off-by: Marcus Comstedt --- Hi. I noticed when running AmigaOS 4.1 as a guest that

Re: [Qemu-devel] [PATCH] hw/qdev-core: Fix description of instance_init

2018-09-19 Thread Markus Armbruster
Thomas Huth writes: > The part of the documentation of DeviceClass that talks about instance_init > is partly wrong: instance_init() functions must not abort or exit, since > the function is also called during introspection of the device already. I figure it was correct back when the comment was

Re: [Qemu-devel] [PATCH] qom: fix comments for object_property_set_qobject function

2018-09-19 Thread Markus Armbruster
Li Qiang writes: > Also make the definition and declare of this function's argument name > the same. > > Signed-off-by: Li Qiang > --- > include/qom/qom-qobject.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/qom/qom-qobject.h b/include/qom/qom-qobject.h >

Re: [Qemu-devel] [PATCH v2] usb: assign unique serial numbers to hid devices

2018-09-19 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> OK, so now I've found the bit about the magic 42; commit 7b074a22 of >> yours; recommended checking for 42 for knowing we had autosuspend; >> what's actually in the current fedora hid rules is serial!=1 - I wonder >> what others have. > > Whatever upstream syste

[Qemu-devel] [PATCH RFC v3 2/7] ui/vnc.c: polish vnc_init_func

2018-09-19 Thread Fei Li
Add a new Error parameter for vnc_display_init() to handle errors in its caller: vnc_init_func(), just like vnc_display_open() does. And let the call trace propagate the Error. Besides, make vnc_start_worker_thread() return a bool to indicate whether it succeeds instead of returning nothing. Sign

[Qemu-devel] [PATCH RFC v3 3/7] qemu_init_vcpu: add a new Error parameter to propagate

2018-09-19 Thread Fei Li
The caller of qemu_init_vcpu() already passed the **errp to handle errors. In view of this, add a new Error parameter to the following call trace to propagate the error and let the further caller check it. Besides, make qemu_init_vcpu() return a Boolean value to let its callers know whether it suc

[Qemu-devel] [PATCH RFC v3 1/7] Fix segmentation fault when qemu_signal_init fails

2018-09-19 Thread Fei Li
Currently, when qemu_signal_init() fails it only returns a non-zero value but without propagating any Error. But its callers need a non-null err when runs error_report_err(err), or else 0->msg occurs. To avoid such segmentation fault, add a new Error parameter to make the call trace to propagate t

[Qemu-devel] [PATCH RFC v3 4/7] migration: fix the compression code

2018-09-19 Thread Fei Li
Add judgement in compress_threads_save_cleanup() to check whether the static CompressParam *comp_param has been allocated. If not, just return; or else Segmentation fault will occur when using the NULL comp_param's parameters in terminate_compression_threads(). One test case can reproduce this erro

[Qemu-devel] [PATCH RFC v3 0/7] qemu_thread_create: propagate errors to callers to check

2018-09-19 Thread Fei Li
Hi, This idea comes from BiteSizedTasks, and this patch series implement the error checking of qemu_thread_create: make qemu_thread_create return a flag to indicate if it succeeded rather than failing with an error; make all callers check it. The first three patches apply to those call traces who

[Qemu-devel] [PATCH RFC v3 5/7] migration: fix the multifd code

2018-09-19 Thread Fei Li
When multifd is used during migration, if there is an error before the destination receives all new channels, the destination does not exit but keeps waiting in our current code. However, a segmentaion fault will occur in the source when multifd_save_cleanup() is called again as the multifd_send_st

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-19 Thread Markus Armbruster
Peter Xu writes: > On Wed, Sep 05, 2018 at 05:05:10PM +0200, Wolfgang Bumiller wrote: >> On Mon, Jun 18, 2018 at 04:08:53PM +0200, Markus Armbruster wrote: >> > From: Peter Xu >> > >> > Before this patch, monitor fd helpers might be called even earlier than >> > monitor_init_globals(). This ca

[Qemu-devel] [PATCH RFC v3 6/7] qemu_thread_join: fix segmentation fault

2018-09-19 Thread Fei Li
To avoid the segmentation fault in qemu_thread_join(), just directly return when the QemuThread *thread was failed to be created in both qemu-thread-posix.c and qemu-thread-win32.c. Signed-off-by: Fei Li --- util/qemu-thread-posix.c | 3 +++ util/qemu-thread-win32.c | 2 +- 2 files changed, 4 in

[Qemu-devel] [PATCH RFC v3 7/7] qemu_thread_create: propagate the error to callers to handle

2018-09-19 Thread Fei Li
Make qemu_thread_create() return a Boolean to indicate if it succeeds rather than failing with an error. And add an Error parameter to hold the error message and let the callers handle it. Signed-off-by: Fei Li --- cpus.c | 45 +++-- dump.

Re: [Qemu-devel] [PATCH 1/3] Check for Linux USBFS in configure

2018-09-19 Thread Laurent Vivier
Le 19/09/2018 à 10:04, Cortland Tölva a écrit : > In preparation for adding user mode emulation support for the > Linux usbfs interface, check for its kernel header. > > Signed-off-by: Cortland Tölva > --- > configure | 21 - > 1 file changed, 20 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-19 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Daniel P. Berrangé writes: >> >> > On Tue, Sep 04, 2018 at 08:39:27AM +0200, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote:

Re: [Qemu-devel] [PATCH 1/3] Check for Linux USBFS in configure

2018-09-19 Thread Laurent Vivier
Le 19/09/2018 à 15:39, Laurent Vivier a écrit : > Le 19/09/2018 à 10:04, Cortland Tölva a écrit : >> In preparation for adding user mode emulation support for the >> Linux usbfs interface, check for its kernel header. >> >> Signed-off-by: Cortland Tölva >> --- >> configure | 21 ++

Re: [Qemu-devel] [PATCH v10 6/6] tpm: add ACPI memory clear interface

2018-09-19 Thread Marc-André Lureau
Hi On Wed, Sep 19, 2018 at 4:14 PM Dr. David Alan Gilbert wrote: > > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Wed, 19 Sep 2018 11:58:22 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > > Hi > > > > > > > > On Tue, Sep 18

Re: [Qemu-devel] [PATCH] sm501: Adjust endianness of pixel value in rectangle fill

2018-09-19 Thread BALATON Zoltan
On Wed, 19 Sep 2018, Marcus Comstedt wrote: The value from twoD_foreground (which is in host endian format) must be converted to the endianness of the framebuffer (currently always little endian) before it can be used to perform the fill operation. Signed-off-by: Marcus Comstedt Reviewed-by:

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 0/2] 40p: fix PCI interrupt routing

2018-09-19 Thread Roman Kapl
Hi, On 09/19/2018 08:57 AM, Mark Cave-Ayland wrote: On 18/09/2018 22:12, Mark Cave-Ayland wrote: Roman, can you reproduce this locally at all? My setup is nothing special, just Debian Stretch on amd64. Ok, so I am able to reproduce it with your image and --enable-debug, but I was not able t

[Qemu-devel] [PATCH 08/14] block: Use bdrv_reopen_set_read_only() in external_snapshot_commit()

2018-09-19 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia --- blockdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 58e057b0d9..2f2

[Qemu-devel] [PATCH 07/14] block: Use bdrv_reopen_set_read_only() in qmp_change_backing_file()

2018-09-19 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia --- blockdev.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.c index 72f5347df

[Qemu-devel] [PATCH 02/14] block: Add bdrv_reopen_set_read_only()

2018-09-19 Thread Alberto Garcia
Most callers of bdrv_reopen() only use it to switch a BlockDriverState between read-only and read-write, so this patch adds a new function that does just that. We also want to get rid of the flags parameter in the bdrv_reopen() API, so this function sets the "read-only" option and passes the origi

[Qemu-devel] [PATCH 05/14] block: Use bdrv_reopen_set_read_only() in bdrv_commit()

2018-09-19 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia --- block/commit.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/block/commit.c b/block/commit.c inde

[Qemu-devel] [PATCH 11/14] qemu-io: Put flag changes in the options QDict in reopen_f()

2018-09-19 Thread Alberto Garcia
When reopen_f() puts a block device in the reopen queue, some of the new options are passed using a QDict, but others ("read-only" and the cache options) are passed as flags. This patch puts those flags in the QDict. This way the flags parameter becomes redundant and we'll be able to get rid of it

[Qemu-devel] [PATCH 03/14] block: Use bdrv_reopen_set_read_only() in bdrv_backing_update_filename()

2018-09-19 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia --- block.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index e023945c8e..ac9

[Qemu-devel] [PATCH 00/14] Don't pass flags to bdrv_reopen_queue()

2018-09-19 Thread Alberto Garcia
Hi, in the description of my "Misc reopen-related patches" I said that the next series after that one would be the implementation of the blockdev-reopen QMP command. That's not going to be the case after all because I have a dozen of new patches that I wanted to publish now. So here's what's goin

[Qemu-devel] [PATCH 01/14] block: Don't call update_flags_from_options() if the options are wrong

2018-09-19 Thread Alberto Garcia
If qemu_opts_absorb_qdict() fails and we carry on and call update_flags_from_options() then that can result on a failed assertion: $ qemu-io -c 'reopen -o read-only=foo' hd.qcow2 block.c:1101: update_flags_from_options: Assertion `qemu_opt_find(opts, BDRV_OPT_CACHE_DIRECT)' failed. Abort

[Qemu-devel] [PATCH 10/14] block: Drop bdrv_reopen()

2018-09-19 Thread Alberto Garcia
No one is using this function anymore, so we can safely remove it Signed-off-by: Alberto Garcia --- block.c | 21 - include/block/block.h | 1 - 2 files changed, 22 deletions(-) diff --git a/block.c b/block.c index ac945b4bc8..3751167434 100644 --- a/block.c +

[Qemu-devel] [PATCH 09/14] block: Use bdrv_reopen_set_read_only() in the mirror driver

2018-09-19 Thread Alberto Garcia
The 'block-commit' QMP command is implemented internally using two different drivers. If the source image is the active layer then the mirror driver is used (commit_active_start()), otherwise the commit driver is used (commit_start()). In both cases the destination image must be put temporarily in

[Qemu-devel] [PATCH 12/14] block: Clean up reopen_backing_file() in block/replication.c

2018-09-19 Thread Alberto Garcia
This function is used to put the hidden and secondary disks in read-write mode before launching the backup job, and back in read-only mode afterwards. This patch does the following changes: - Use an options QDict with the "read-only" option instead of passing the changes as flags only. -

[Qemu-devel] [PATCH 06/14] block: Use bdrv_reopen_set_read_only() in stream_start/complete()

2018-09-19 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia --- block/stream.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/block/stream.c b/blo

[Qemu-devel] [PATCH 13/14] block: Remove flags parameter from bdrv_reopen_queue()

2018-09-19 Thread Alberto Garcia
Now that all callers are passing all flag changes as QDict options, the flags parameter is no longer necessary, so we can get rid of it. Signed-off-by: Alberto Garcia --- block.c | 5 +++-- block/replication.c | 6 ++ include/block/block.h | 3 +-- qemu-io-cmds.c| 2 +

[Qemu-devel] [PATCH 04/14] block: Use bdrv_reopen_set_read_only() in commit_start/complete()

2018-09-19 Thread Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia --- block/commit.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/block/commit.c b/block/co

Re: [Qemu-devel] [PATCH RFC v3 2/7] ui/vnc.c: polish vnc_init_func

2018-09-19 Thread Fam Zheng
On Wed, 09/19 21:35, Fei Li wrote: > Add a new Error parameter for vnc_display_init() to handle errors > in its caller: vnc_init_func(), just like vnc_display_open() does. > And let the call trace propagate the Error. > > Besides, make vnc_start_worker_thread() return a bool to indicate > whether

[Qemu-devel] [PATCH 14/14] block: Stop passing flags to bdrv_reopen_queue_child()

2018-09-19 Thread Alberto Garcia
Now that all callers are passing the new options using the QDict we no longer need the 'flags' parameter. This patch makes the following changes: 1) The update_options_from_flags() call is no longer necessary so it can be removed. 2) The update_flags_from_options() call is now used i

Re: [Qemu-devel] [PATCH 11/35] target/i386: access cpu->interrupt_request with atomics

2018-09-19 Thread Emilio G. Cota
On Tue, Sep 18, 2018 at 14:04:35 -0700, Richard Henderson wrote: > On 9/17/18 9:30 AM, Emilio G. Cota wrote: > > cpu_reset(cs); > > -cs->interrupt_request = sipi; > > +atomic_mb_set(&cs->interrupt_request, sipi); > > memcpy(&env->start_init_save, &save->start_init_save, > > Why d

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-19 Thread Wolfgang Bumiller
On Wed, Sep 19, 2018 at 03:36:02PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Wed, Sep 05, 2018 at 05:05:10PM +0200, Wolfgang Bumiller wrote: > >> On Mon, Jun 18, 2018 at 04:08:53PM +0200, Markus Armbruster wrote: > >> > From: Peter Xu > >> > > >> > Before this patch, monitor f

Re: [Qemu-devel] [PATCH RFC v3 1/7] Fix segmentation fault when qemu_signal_init fails

2018-09-19 Thread Fam Zheng
On Wed, 09/19 21:35, Fei Li wrote: > Currently, when qemu_signal_init() fails it only returns a non-zero > value but without propagating any Error. But its callers need a > non-null err when runs error_report_err(err), or else 0->msg occurs. > > To avoid such segmentation fault, add a new Error pa

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-19 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Tue, Sep 04, 2018 at 08:39:27AM +0200, Markus Armbruster wrote: > >> >> Daniel P. Berrangé writes: > >> >> > >>

Re: [Qemu-devel] [PATCH] block: Don't call update_flags_from_options() if the options are wrong

2018-09-19 Thread Alberto Garcia
On Tue 11 Sep 2018 02:32:56 PM CEST, Alberto Garcia wrote: > If qemu_opts_absorb_qdict() fails and we carry on and call > update_flags_from_options() then that can result on a failed > assertion: > >$ qemu-io -c 'reopen -o read-only=foo' hd.qcow2 >block.c:1101: update_flags_from_options: As

Re: [Qemu-devel] [PATCH RFC v3 3/7] qemu_init_vcpu: add a new Error parameter to propagate

2018-09-19 Thread Fam Zheng
On Wed, 09/19 21:35, Fei Li wrote: > The caller of qemu_init_vcpu() already passed the **errp to handle > errors. In view of this, add a new Error parameter to the following > call trace to propagate the error and let the further caller check it. > > Besides, make qemu_init_vcpu() return a Boolean

Re: [Qemu-devel] [PATCH RFC v3 6/7] qemu_thread_join: fix segmentation fault

2018-09-19 Thread Fam Zheng
On Wed, 09/19 21:35, Fei Li wrote: > To avoid the segmentation fault in qemu_thread_join(), just directly > return when the QemuThread *thread was failed to be created in both > qemu-thread-posix.c and qemu-thread-win32.c. Per English grammar, I think "when the QemuThread *thread failed to be crea

Re: [Qemu-devel] qemu-nbd performance

2018-09-19 Thread Eric Blake
On 9/19/18 1:46 AM, lampahome wrote: All images are on the RAID0(3 SSD). Below is the performance: image numberseq. read(MB/s)seq. write(MB/s) 11480 60 16 1453 36 32 1450

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 0/2] 40p: fix PCI interrupt routing

2018-09-19 Thread Peter Maydell
On 19 September 2018 at 07:47, Roman Kapl wrote: > It seems that the `dcbz` instruction is not emulated correctly (which may > lead to some garbage in inittab?). However, if I manualy inline the > `helper_dcbz_common` code into `helper dcbz`, it starts to work. This is because helper_dcbz_common(

Re: [Qemu-devel] [PATCH v10 6/6] tpm: add ACPI memory clear interface

2018-09-19 Thread Igor Mammedov
On Wed, 19 Sep 2018 13:14:05 +0100 "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Wed, 19 Sep 2018 11:58:22 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > > Hi > > > > > > > > On Tue,

Re: [Qemu-devel] [PATCH v10 6/6] tpm: add ACPI memory clear interface

2018-09-19 Thread Igor Mammedov
On Wed, 19 Sep 2018 18:36:14 +0400 Marc-André Lureau wrote: > Hi > > On Wed, Sep 19, 2018 at 4:14 PM Dr. David Alan Gilbert > wrote: > > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Wed, 19 Sep 2018 11:58:22 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Marc-Andr

Re: [Qemu-devel] [RFC PATCH 00/13] target/arm: Derive cpu id regs from features

2018-09-19 Thread Alex Bennée
Richard Henderson writes: > This is something we talked about in the context of enabling sve in > system mode. We don't want to replicate info between these two locations. > > I'm not 100% happy with this, thus the RFC. In particular, there are > several places in id_isar0, id_isar2, and id_i

Re: [Qemu-devel] [PATCH RFC v3 7/7] qemu_thread_create: propagate the error to callers to handle

2018-09-19 Thread Fam Zheng
On Wed, 09/19 21:35, Fei Li wrote: > Make qemu_thread_create() return a Boolean to indicate if it succeeds > rather than failing with an error. And add an Error parameter to hold > the error message and let the callers handle it. > > Signed-off-by: Fei Li > --- > cpus.c | 45

Re: [Qemu-devel] [PATCH RFC v3 0/7] qemu_thread_create: propagate errors to callers to check

2018-09-19 Thread Fam Zheng
On Wed, 09/19 21:35, Fei Li wrote: > Hi, > > This idea comes from BiteSizedTasks, and this patch series implement > the error checking of qemu_thread_create: make qemu_thread_create > return a flag to indicate if it succeeded rather than failing with an > error; make all callers check it. Looks g

Re: [Qemu-devel] [RFC PATCH 00/13] target/arm: Derive cpu id regs from features

2018-09-19 Thread Peter Maydell
On 19 September 2018 at 08:44, Alex Bennée wrote: > > Richard Henderson writes: > >> This is something we talked about in the context of enabling sve in >> system mode. We don't want to replicate info between these two locations. >> >> I'm not 100% happy with this, thus the RFC. In particular,

Re: [Qemu-devel] [PATCH] sm501: Adjust endianness of pixel value in rectangle fill

2018-09-19 Thread Peter Maydell
On 19 September 2018 at 07:46, BALATON Zoltan wrote: > On Wed, 19 Sep 2018, Marcus Comstedt wrote: >> >> The value from twoD_foreground (which is in host endian format) must >> be converted to the endianness of the framebuffer (currently always >> little endian) before it can be used to perform th

Re: [Qemu-devel] Dropped CPU feature names and backward compatibility

2018-09-19 Thread Eduardo Habkost
On Tue, Sep 18, 2018 at 05:35:20PM +0200, Paolo Bonzini wrote: > On 18/09/2018 16:22, Eduardo Habkost wrote: > > On Tue, Sep 18, 2018 at 04:02:54PM +0200, Paolo Bonzini wrote: > >> On 18/09/2018 15:14, Eduardo Habkost wrote: > >>> If it broke something, we should restore the option names and > >>>

Re: [Qemu-devel] [PATCH 05/35] target/s390x: use cpu_reset_interrupt

2018-09-19 Thread Cornelia Huck
On Mon, 17 Sep 2018 12:30:33 -0400 "Emilio G. Cota" wrote: > From: Paolo Bonzini > > It will be changed to an atomic operation soon. > > Cc: Cornelia Huck > Cc: Richard Henderson > Cc: Alexander Graf > Cc: David Hildenbrand > Cc: qemu-s3...@nongnu.org > Signed-off-by: Paolo Bonzini > Sign

Re: [Qemu-devel] [PATCH 23/35] target/s390x: access cpu->interrupt_request with atomics

2018-09-19 Thread Cornelia Huck
On Mon, 17 Sep 2018 12:30:51 -0400 "Emilio G. Cota" wrote: > From: Paolo Bonzini > > Cc: Cornelia Huck > Cc: Christian Borntraeger > Cc: Alexander Graf > Cc: Richard Henderson > Cc: David Hildenbrand > Cc: qemu-s3...@nongnu.org > Signed-off-by: Paolo Bonzini > Signed-off-by: Emilio G. Cot

Re: [Qemu-devel] [PATCH 34/35] exec: push BQL down to cpu->do_interrupt

2018-09-19 Thread Cornelia Huck
On Mon, 17 Sep 2018 12:31:02 -0400 "Emilio G. Cota" wrote: > From: Paolo Bonzini > > cpu->do_interrupt can now be called with BQL held (from > cpu->cpu_exec_interrupt) or without (from cpu_handle_exception). > > Only a few targets rely on global device state in cc->do_interrupt; > add checks t

Re: [Qemu-devel] [PATCH] qapi/misc.json: Clarify about usage of QMP 'cpu-add'

2018-09-19 Thread Eduardo Habkost
On Wed, Sep 19, 2018 at 12:22:19PM +0200, Kashyap Chamarthy wrote: > On Tue, Sep 18, 2018 at 11:19:38AM -0300, Eduardo Habkost wrote: > > On Tue, Sep 18, 2018 at 03:23:03PM +0200, Kashyap Chamarthy wrote: > > > Eduardo Habkost mentioned on IRC that the intended functionality of QMP > > > 'cpu-add'

  1   2   >